Re: [gentoo-dev] [PATCH 07/15] perl-module.eclass: Do not do any magic with MY_... variables in EAPI=6 anymore

2015-12-12 Thread Andreas K. Huettel 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Am Samstag, 12. Dezember 2015, 12:59:08 schrieb Michał Górny:
> Dnia 11 grudnia 2015 22:03:03 CET, dilfri...@gentoo.org napisał(a):
> >
> >-if [[ -n ${MY_PN} || -n ${MY_PV} || -n ${MODULE_VERSION} ]] ; then
> >-: ${MY_P:=${MY_PN:-${PN}}-${MY_PV:-${MODULE_VERSION:-${PV
> >-S=${MY_S:-${WORKDIR}/${MY_P}}
> >+if [[ ${EAPI:-0} = 5 ]] ; then
> >+if [[ -n ${MY_PN} || -n ${MY_PV} || -n ${MODULE_VERSION} ]] ; then
> >+: ${MY_P:=${MY_PN:-${PN}}-${MY_PV:-${MODULE_VERSION:-${PV
> >+S=${MY_S:-${WORKDIR}/${MY_P}}
> >+fi
> >+MODULE_NAME=${MY_PN:-${PN}}
> >+MODULE_P=${MY_P:-${P}}
> >+else
> >+MODULE_NAME=${MODULE_NAME:-${PN}}
> >+MODULE_P=${MODULE_NAME}-${MODULE_VERSION:-${PV}}
> >+S=${WORKDIR}/${MODULE_P}

> How likely is it that one would use MY_* without MODULE_*? Maybe it would
> be good to warn about this?

Well... the main usage of this input is calculation of SRC_URI and S. 

So, I'm not so worried about it, since failing to update the settings will 
lead to problems already when running ebuild manifest...

- -- 

Andreas K. Huettel
Gentoo Linux developer 
dilfri...@gentoo.org
http://www.akhuettel.de/

-BEGIN PGP SIGNATURE-
Version: GnuPG v2.1

iQJ8BAEBCgBmBQJWbILnXxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0RkJDMzI0NjNBOTIwMDY5MTQ2NkMzNDBF
MTM4NkZEN0VGNEI1Nzc5AAoJEOE4b9fvS1d5G+MQALIzMM1eedqHJJeLCd9wA1NB
0I9usDqNFv1XOUA0cMEpPMSSqpmEx5/rCBdTAwjOYhqzf1U7ks9ZPPaVwxNFTqR+
t1eoOtT2w9JbJzeBfWOefiwBwhAVKZH56mH5oITDzN+QWev7n2Xs336fSN1P6glW
Ip4JqKNXH7fbV0jvmID6Yc6iReXXGLKs862us6cDpkm03bq4c1SE4dgWNN69UCkv
oM5DfP3PqNkOXLWafNGpvgD0NCdzm64bDZo+/8OlmZ1rFNDp0pAuDUyblWCMuGZw
mvTetAES0u5F1TyOA4x2jK+CGHvonnBorCBaTvSjLiNtBZ/b/KatrGYqwn0/yHo7
Hoz3Vq9ZgcKnT9asKv2sJOLG8V1rjVTcJJrJKrhj6MziWikhFblxfktnc0MO1//1
DWPpj9kbO7H33gZ7Ob3fegdk7BJzhcKxoTTRwKixXpGcwpR+KZ98z7YvqCDZwJq3
RTKrsM9FgTmqPgMxkR+/8XLrJrEKDR8UfSUgp10fdXLgEVX/6fY5mmSUc5SOqfOV
HjpZAo5ioJ1lyETQisWIC4VTBYIlBvgWrkbqUPM5gh7lOk0Gd+NR3/8es1BMA0h/
68WpyJ1z2m57bnmseD/WXBwU81xp52teM0rWGrB+c0JvEtAQ2YB3Xq6UCxDcjuxs
nu83ET+yxh4A9ptmaJHb
=7sm6
-END PGP SIGNATURE-

Re: [gentoo-dev] [PATCH 07/15] perl-module.eclass: Do not do any magic with MY_... variables in EAPI=6 anymore

2015-12-12 Thread Michał Górny 


Dnia 11 grudnia 2015 22:03:03 CET, dilfri...@gentoo.org napisał(a):
>From: Andreas K. Hüttel 
>
>---
> eclass/perl-module.eclass | 16 +++-
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
>diff --git a/eclass/perl-module.eclass b/eclass/perl-module.eclass
>index 6a5f2ff..7434bcf 100644
>--- a/eclass/perl-module.eclass
>+++ b/eclass/perl-module.eclass
>@@ -102,12 +102,18 @@ esac
> 
> LICENSE="${LICENSE:-|| ( Artistic GPL-1+ )}"
> 
>-if [[ -n ${MY_PN} || -n ${MY_PV} || -n ${MODULE_VERSION} ]] ; then
>-  : ${MY_P:=${MY_PN:-${PN}}-${MY_PV:-${MODULE_VERSION:-${PV
>-  S=${MY_S:-${WORKDIR}/${MY_P}}
>+if [[ ${EAPI:-0} = 5 ]] ; then
>+  if [[ -n ${MY_PN} || -n ${MY_PV} || -n ${MODULE_VERSION} ]] ; then
>+  : ${MY_P:=${MY_PN:-${PN}}-${MY_PV:-${MODULE_VERSION:-${PV
>+  S=${MY_S:-${WORKDIR}/${MY_P}}
>+  fi
>+  MODULE_NAME=${MY_PN:-${PN}}
>+  MODULE_P=${MY_P:-${P}}
>+else
>+  MODULE_NAME=${MODULE_NAME:-${PN}}
>+  MODULE_P=${MODULE_NAME}-${MODULE_VERSION:-${PV}}
>+  S=${WORKDIR}/${MODULE_P}
> fi
>-MODULE_NAME=${MY_PN:-${PN}}
>-MODULE_P=${MY_P:-${P}}
> 
> [[ -z "${SRC_URI}" && -z "${MODULE_A}" ]] && \
>   MODULE_A="${MODULE_P}.${MODULE_A_EXT:-tar.gz}"

How likely is it that one would use MY_* without MODULE_*? Maybe it would be 
good to warn about this?
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.