Re: [gentoo-dev] [PATCH v2 2/3] distutils-r1.eclass: Use python_has_version in ...enable_sphinx
On Thu, 2022-02-10 at 15:27 -0800, Matt Turner wrote: > On Thu, Feb 10, 2022 at 6:45 AM Michał Górny wrote: > > > > Signed-off-by: Michał Górny > > > Looks good to me. I noticed that this implementation takes only a > single -b/-d/-r as the initial argument and then a list of packages. > I'd suggested pairs of -b/-d/-r but I think you're right not to > implement that. I doubt that it's common to need to mix -b/-d/-r. > Yeah, I think having options affect only a subset of arguments would be confusing at best. -- Best regards, Michał Górny
Re: [gentoo-dev] [PATCH v2 2/3] distutils-r1.eclass: Use python_has_version in ...enable_sphinx
On Thu, Feb 10, 2022 at 6:45 AM Michał Górny wrote: > > Signed-off-by: Michał Górny Looks good to me. I noticed that this implementation takes only a single -b/-d/-r as the initial argument and then a list of packages. I'd suggested pairs of -b/-d/-r but I think you're right not to implement that. I doubt that it's common to need to mix -b/-d/-r. Thanks!
