[gentoo-portage-dev] Re: r3046 - main/trunk/pym

2006-04-01 Thread Mike Frysinger 
On Saturday 01 April 2006 02:34, Zach Medico wrote:
 Modified:
main/trunk/pym/portage.py
 Log:
 Fix ROOT handling for timestamps of lib directories. Only run ldconfig when
 timestamps have changed (the makelinks flag does not force ldconfig unless
 timestamps have changed).

no, this is still wrong

makelinks is kept sep from the ld mtime logic on purpose
-mike
-- 
gentoo-portage-dev@gentoo.org mailing list

Re: [gentoo-portage-dev] rewriting the ldconfig logic

2006-04-01 Thread Mike Frysinger 
On Saturday 01 April 2006 17:17, Zac Medico wrote:
 Mike Frysinger wrote:
  i thought about this some more ... why do we even care about the mtimes
  during package merge ?  if a package doesnt install any files into a
  libdir, why should we bother running ldconfig ?  if a user updated the
  dirs, then they can either run ldconfig or env-update ...
 
  so imo, the logic should be:
  if srcroot is None:
  mtime checks
  else:
  libdir existence checks

 Yeah, I think that's correct.  Also, even though we don't need to check the
 mtimes when srcroot is defined, we can still update the mtimes in the
 mtimedb to the current values in order to avoid an unnecessary ldconfig run
 on the next env_update call.

feel like implementing this ?  that way we dont stop on each others feet again 
and i dont have to waste time when you rewrite my work ;)
-mike
-- 
gentoo-portage-dev@gentoo.org mailing list