Re: [gentoo-portage-dev] [PATCH v2] prepman: do not compress files =128 bytes

2013-03-21 Thread Sergei Trofimovich
On Thu, 21 Mar 2013 07:51:49 -0400
James Cloos cl...@jhcloos.com wrote:

  MF == Mike Frysinger vap...@gentoo.org writes:
 
 MF +SIZE_LIMIT='128'
 
 The limit probably should be larger, given that nothing which fits into
 one filesystem block will use less space compressed.

While it's usually true btrfs does not store things in blocks and
allocates space in byte ranges. All filesystem (data or meta)
modifications are copy-on-write thus it does not needs growth holes
by design.

-- 

  Sergei


signature.asc
Description: PGP signature


Re: [gentoo-portage-dev] [PATCH v2] prepman: do not compress files =128 bytes

2013-03-21 Thread Mike Frysinger
On Thursday 21 March 2013 07:51:49 James Cloos wrote:
  MF == Mike Frysinger vap...@gentoo.org writes:
 MF +SIZE_LIMIT='128'
 
 The limit probably should be larger, given that nothing which fits into
 one filesystem block will use less space compressed.
 
 In many cases a limit of 4096 would be appropriate.  But a limit of 1024
 should cover the lowest common denominator.

realistically, there are no man pages that are under 4k.  look at the 
referenced bug for more details.

you're also ignoring things like tail packing.  i really don't want to start 
customizing code for FS idiosyncrasies that are not reliable.
-mike


signature.asc
Description: This is a digitally signed message part.