Am 11.12.2013 08:57, schrieb Mike Frysinger: > On Thursday 05 December 2013 15:57:17 sebastianlut...@gmx.de > wrote: >> --- a/bin/misc-functions.sh +++ b/bin/misc-functions.sh @@ -242,6 >> +242,11 @@ install_qa_check() { [[ -d ${ED}/$x ]] && f+=" $x\n" >> done >> >> + # It's ok create these directories, but not to install into >> them. (bug 493154) > > our style uses #12345 rather than (bug 12345) # It's ok create > these directories, but not to install into them. #493154 > >> + for x in var/cache var/lib var/lock var/run run ; do + [[ -d >> ${ED}/$x ]] && [[ $(find "${ED}/${x}" -prune -empty) = "" ]] && >> f+=" $x\n" > > the -d check doesn't handle symlinks correctly ... baselayout would > install /var/run -> /run, and the -d would deref that to the real > symlink. however, `find` will not descend into the symlink, so we > end up being saved by that. > > we have -z for detecting empty output rather than comparing to an > empty string > > non-builtin vars should use braces, so that'd be ${x}. i know some > of the code in here doesn't follow that, but we should be marching > in that direction with new code.
My bash knowledge is rather limited. So, thanks for your comments. > >> if [[ -n $f ]] ; then eqawarn "QA Notice: This ebuild installs >> into the following > deprecated directories:" > > this warning is incorrect for these paths. we need to create a new > warning that clearly explains what is going on. > Right, thanks for fixing. > i'll send out a new version. -mike > FWIW, new patch looks fine. Sebastian