Re: [gentoo-portage-dev] Re: [PATCH V2] emerge: check correctly for --sync success (bug 606588)

2017-01-22 Thread Brian Dolbec 
On Sun, 22 Jan 2017 17:29:39 -0800
Zac Medico  wrote:

> On 01/20/2017 11:23 AM, Alexandru Elisei wrote:
> > The class SyncRepos will keep a list of (repo, returncode) tuples.
> > If sync is unsuccessful emerge will use this list to return the
> > first failed repository return code.  
> 
> I've pushed a minimal fix:
> 
> https://gitweb.gentoo.org/proj/portage.git/commit/?id=23f239134b0290cbe0435e13d8f1b1757c6d8524
> 
> It just returns 1 on failure. Would it really be useful to preserve
> the returncode from the first failed repo? Probably not.

Thanks Alexandru, Zac.

-- 
Brian Dolbec

Re: [gentoo-portage-dev] Re: [PATCH V2] emerge: check correctly for --sync success (bug 606588)

2017-01-22 Thread Zac Medico 
On 01/20/2017 11:23 AM, Alexandru Elisei wrote:
> The class SyncRepos will keep a list of (repo, returncode) tuples.
> If sync is unsuccessful emerge will use this list to return the first
> failed repository return code.

I've pushed a minimal fix:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=23f239134b0290cbe0435e13d8f1b1757c6d8524

It just returns 1 on failure. Would it really be useful to preserve the
returncode from the first failed repo? Probably not.
-- 
Thanks,
Zac