On 15/12/18 08:55, Michał Górny wrote: > On Sat, 2018-12-15 at 02:25 +0000, M. J. Everitt wrote: >> This patchset aims to fix potential ambiguity and confusion between older >> PORT_LOG* variables, >> and more recent PORTAGE_* variables - often leading to mysteriously lacking >> logging due to >> incorrect variable names. Documented in Bug 668538; with thanks to Zac for >> diagnosis, and >> solution assistance! >> > Does 'often' actually affect more than one person? Do you have any > evidence to support this? > > Given that a lot of Portage variables don't have any prefix or sane > names, I dare say this one doesn't especially stand out. > Just a thought, but how about you apply your skill and wisdom to reviewing the patches, instead of wasting it on writing snide replies? Quite radical I know, but whadda ya think?!
As it happens, I was going for consistency here, as that often reflects code quality, and you being a keen QA member, I'da thought perhaps you might have spotted this! Not only this, but as noted, unless you know the man pages for portage and make.conf in order to recite them in your sleep, they are confusing for users, as they do not necessarily follow an obvious pattern, and it wasn't until I was attempting to debug something that I noticed that despite believing I had the correct settings in my make.conf (set over a period of YEARS) they were in fact completely useless, and it wasn't until I had to spend time with somebody debugging WTF was happening, that this particular issue even became apparent...
signature.asc
Description: OpenPGP digital signature
