[gentoo-portage-dev] Heads-up regarding dbapi/vartree.py: dblink._unmerge_pkgfiles
Hi all, I've been working on bugs https://bugs.gentoo.org/291589 and https://bugs.gentoo.org/346203 And that led me to start thinking/attempting to refactor a bit the way dblink._unmerge_pkgfiles does things. I've done few things to try and figure out how the whole function works, not heavy coding yet. So, if anybody is working on vartree.py, particularly with dblink and/or _unmerge_pkgfiles let me know so we don't block or mess each other plans. Cheers, -- Jesus Rivero (Neurogeek) Gentoo Developer
Re: [gentoo-portage-dev] [PATCH 2/3 v2] Have repoman check that a package directory contains at least one ebuild (bug #245305).
On Fri, Jan 17, 2014 at 4:36 PM, Tom Wijsman tom...@gentoo.org wrote:
---
bin/repoman | 8
man/repoman.1 | 3 +++
2 files changed, 11 insertions(+)
diff --git a/bin/repoman b/bin/repoman
index d1542e9..44f3d3d 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -326,6 +326,7 @@ qahelp = {
SRC_URI.mirror: A uri listed in profiles/thirdpartymirrors is
found in SRC_URI,
ebuild.syntax: Error generating cache entry for ebuild;
typically caused by ebuild syntax error or digest verification failure,
ebuild.output: A simple sourcing of the ebuild produces output;
this breaks ebuild policy.,
+ ebuild.missing: A package directory must at least contain one
ebuild or be treecleaned.,
ebuild.nesteddie: Placing 'die' inside ( ) prints an error, but
doesn't stop the ebuild.,
variable.invalidchar: A variable contains an invalid character
that is not part of the ASCII character set,
variable.readonly: Assigning a readonly variable,
@@ -1442,6 +1443,13 @@ for x in effective_scanlist:
can_force = False
continue
+ if not ebuildlist:
+ stats[ebuild.missing] += 1
+ fails[ebuild.missing].append(%s must at least contain
one % x + \
+ ebuild or be treecleaned.)
+ can_force = False
+ continue
+
# Sort ebuilds in ascending order for the KEYWORDS.dropped check.
ebuildlist = sorted(pkgs.values())
ebuildlist = [pkg.pf for pkg in ebuildlist]
diff --git a/man/repoman.1 b/man/repoman.1
index a78f94e..6315ea9 100644
--- a/man/repoman.1
+++ b/man/repoman.1
@@ -301,6 +301,9 @@ Ebuilds that exist but have not been added to cvs
.B ebuild.output
A simple sourcing of the ebuild produces output; this breaks ebuild
policy.
.TP
+.B ebuild.missing
+A package directory must at least contain one ebuild or be treecleaned.
+.TP
.B ebuild.patches
PATCHES variable should be a bash array to ensure white space safety
.TP
--
1.8.5.2
Looks fine.
--
Jesus Rivero (Neurogeek)
Gentoo Developer
Re: [gentoo-portage-dev] Signing off patches
On Thu, Jan 16, 2014 at 12:44 PM, Alexander Berntsen alexan...@plaimi.netwrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 16/01/14 18:24, Jesus Rivero (Neurogeek) wrote: So, how would this work with emails to this list, exactly? An email should be sent any time one of those fields is changed? That's not necessary, in my opinion. We already send emails, looks OK to me and similar. And most patches don't really need more than one review and an ACK by the lead. Do you have a more detailed plan on how would this work? Not really. We're small enough to do this organically and on a per-case basis. But basically, if someone authors a non-trivial patch, that person should *never* push themselves. Whoever reviews it should push it, adding the Reviewed-by field. The reviewer should also get an ACK by the team lead (via IRC or whatever) and add that to the commit before pushing. Gotcha!, that makes sense to me. In a bigger project (or with a team lead with a lot of free time...), I would argue that the reviewer should send the new commit, with the Reviewed-by field added, to the team lead, which then adds the Acked-by field themselves, before pushing. I'm not convinced the benefits of this extra step outweighs the drawback in the overhead of this small community of ours. - -- Alexander alexan...@plaimi.net http://plaimi.net/~alexander -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlLYGpkACgkQRtClrXBQc7WA4AEAmghIHMkNxiqJ79CONZzs/k/u t0QoASddzlSruejiVaQA+QFOdbgMaA59hf9DInPAgpG7Kc6fbFENgkZn4jEY9NAq =CrCK -END PGP SIGNATURE- Thanks, -- Jesus Rivero (Neurogeek) Gentoo Developer
Re: [gentoo-portage-dev] [PATCH 3/3] Have repoman deprecate G2CONF for the GNOME team. (bug #482084).
On Jan 15, 2014 7:08 PM, Tom Wijsman tom...@gentoo.org wrote:
---
bin/repoman | 2 ++
man/repoman.1 | 3 +++
pym/repoman/checks.py | 10 ++
3 files changed, 15 insertions(+)
diff --git a/bin/repoman b/bin/repoman
index 3263ceb..6754edd 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -318,6 +318,7 @@ qahelp = {
EAPI.incompatible: Ebuilds that use features that are only
available with a different EAPI,
EAPI.unsupported: Ebuilds that have an unsupported EAPI
version (you must upgrade portage),
SLOT.invalid: Ebuilds that have a missing or invalid SLOT
variable value,
+ G2CONF.deprecated: G2CONF is deprecated, see Gentoo bug
#482084 and the GNOME team policies,
HOMEPAGE.missing: Ebuilds that have a missing or empty
HOMEPAGE variable,
HOMEPAGE.virtual: Virtuals that have a non-empty HOMEPAGE
variable,
PDEPEND.suspect: PDEPEND contains a package that usually only
belongs in DEPEND.,
@@ -382,6 +383,7 @@ qawarnings = set((
dependency.badtilde,
DESCRIPTION.toolong,
EAPI.deprecated,
+G2CONF.deprecated,
HOMEPAGE.virtual,
LICENSE.deprecated,
LICENSE.virtual,
diff --git a/man/repoman.1 b/man/repoman.1
index 2bf3765..7ec43d5 100644
--- a/man/repoman.1
+++ b/man/repoman.1
@@ -227,6 +227,9 @@ Syntax error in RESTRICT (usually an extra/missing
space/parenthesis)
.B SLOT.invalid
Ebuilds that have a missing or invalid SLOT variable value
.TP
+.B G2CONF.deprecated
+G2CONF is deprecated, see Gentoo bug #482084 and the GNOME team policies
+.TP
.B SRC_URI.mirror
A uri listed in profiles/thirdpartymirrors is found in SRC_URI
.TP
diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index 85aa065..c2608b0 100644
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -799,6 +799,16 @@ class PortageInternalVariableAssignment(LineCheck):
e += ' on line: %d'
return e
+class DeprecateG2CONF(LineCheck):
+ repoman_check_name = 'G2CONF.deprecated'
+ re = re.compile(r'.*G2CONF.*')
+
+ def check(self, num, line):
+ Run the check on line and return error if there is
one
+ m = self.re.match(line)
+ if m is not None:
+ return (G2CONF on line %d is deprecated, see
Gentoo bug #482084.)
Are you missing the line number interpolation here? or %d is supposed to be
returned?
+
_base_check_classes = (InheritEclass, LineCheck, PhaseCheck)
_constant_checks = None
--
1.8.5.2
Other than that, Looks good to me.
[gentoo-portage-dev] [PATCH] Added support for variable expansion in source command. wrt bug #490896
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, Attached is a patch to allow variables in the argument for the source command in make.conf The implementation refactors what happens when allow_sourcing is True in the portage.util.getconfig function. Instead of just setting lex.source, now we also pass the expand_map dict. This patch fixes bug #490896 Jesus Rivero -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.16 (GNU/Linux) iEYEARECAAYFAlLS5XgACgkQdIssYB9vBoOUoQCdFA2JfPHvjLDVp0mqDTo01Z9E wMoAmgJLflNFTb9JoSnOJzZga6oJckYI =3Atz -END PGP SIGNATURE- 0001-Added-support-for-variable-expansion-in-source-command.patch Description: Binary data
[gentoo-portage-dev] [PATCH] [REV] Added support for variable expansion in source command. wrt bug #490896
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, In the previous patch, I didn't notice an error in the unittest I wrote for the feature. Attached is the correct patch, please disregard the previous one. Cheers, Jesus Rivero -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.16 (GNU/Linux) iEYEARECAAYFAlLS7oQACgkQdIssYB9vBoP5wgCgh0kIe28oKg5XECPkjoe36QaH oY8An0iUVqvPi5cftWbpbrHO2nSsUcqz =wZnl -END PGP SIGNATURE- 0002-Added-support-for-variable-expansion-in-source-command.patch Description: Binary data
