Re: [gentoo-portage-dev] [PATCH] Do not interrupt on SIGCONT

2015-02-26 Thread Zac Medico 
On 02/25/2015 08:30 PM, Mike Frysinger wrote:
 From: Bertrand SIMONNET bsimon...@chromium.org
 
 SIGCONT signals should not interrupt any system calls (locking or wait pid for
 example).
 
 URL: http://crbug.com/417800
 X-Gentoo-Bug-URL: https://bugs.gentoo.org/500436
 ---
  pym/_emerge/Scheduler.py | 1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/pym/_emerge/Scheduler.py b/pym/_emerge/Scheduler.py
 index d6db311..6e3bf1a 100644
 --- a/pym/_emerge/Scheduler.py
 +++ b/pym/_emerge/Scheduler.py
 @@ -1017,6 +1017,7 @@ class Scheduler(PollScheduler):
   earlier_sigterm_handler = signal.signal(signal.SIGTERM, 
 sighandler)
   earlier_sigcont_handler = \
   signal.signal(signal.SIGCONT, 
 self._sigcont_handler)
 + signal.siginterrupt(signal.SIGCONT, False)
  
   try:
   rval = self._merge()
 

LGTM.

We already have wrappers to handle EINTR for waitpid and lockf:

https://github.com/gentoo/portage/commit/7c70eea2f607baffcbb9d465c03578d69b09decf
https://github.com/gentoo/portage/commit/664684f0f17c0f3570ffd9382037994db1ec66bd

I suppose it won't hurt to suppress EINTR though...
-- 
Thanks,
Zac

[gentoo-portage-dev] [PATCH] Do not interrupt on SIGCONT

2015-02-25 Thread Mike Frysinger 
From: Bertrand SIMONNET bsimon...@chromium.org

SIGCONT signals should not interrupt any system calls (locking or wait pid for
example).

URL: http://crbug.com/417800
X-Gentoo-Bug-URL: https://bugs.gentoo.org/500436
---
 pym/_emerge/Scheduler.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/pym/_emerge/Scheduler.py b/pym/_emerge/Scheduler.py
index d6db311..6e3bf1a 100644
--- a/pym/_emerge/Scheduler.py
+++ b/pym/_emerge/Scheduler.py
@@ -1017,6 +1017,7 @@ class Scheduler(PollScheduler):
earlier_sigterm_handler = signal.signal(signal.SIGTERM, 
sighandler)
earlier_sigcont_handler = \
signal.signal(signal.SIGCONT, 
self._sigcont_handler)
+   signal.siginterrupt(signal.SIGCONT, False)
 
try:
rval = self._merge()
-- 
2.3.0