Re: [gentoo-portage-dev] [PATCH] Implement --newrepo flag.
Am 17.02.2014 22:44, schrieb David James: From a theoretical perspective, the reason why I implemented this is because ebuilds are the source of truth. According to the ebuilds, the owner repo of dev-libs/C-1 is repo1, so this means that, with --newrepo, any binpkg for dev-libs/C-1 from repo2 would be invalid. Actually this test passes even without --new-repo. So yes, your interpretation is what's used by portage. Patch is committed. This functionality is useful in the case where an ebuild changes repos. In this case, with --newrepo, you would want the package to be rebuilt and any binaries to be invalidated, and our tests validate this. Cheers, David
Re: [gentoo-portage-dev] [PATCH] Implement --newrepo flag.
Am 17.02.2014 17:39, schrieb Brian Dolbec: Mike, if you can confirm the tests pass. Go ahead and merge it. Please give me some more time to review it. I'll commit it if it lgtm.
Re: [gentoo-portage-dev] [PATCH] Implement --newrepo flag.
Am 17.02.2014 18:52, schrieb David James:
@@ -96,6 +105,68 @@ class MultirepoTestCase(TestCase):
snip
+
+ #--newrepo: pick ebuild if binpkg/ebuild have different
repo
+ ResolverPlaygroundTestCase(
+ [dev-libs/C],
+ options = {--usepkg: True, --newrepo: True,
--selective: True},
+ success = True,
+ check_repo_names = True,
+ mergelist = [dev-libs/C-1::repo1]),
Why should it take the ebuild from the repo with lower priority?
I thought the intend was that the package should be reinstalled if it is
now pulled from a repo with higher priority than the repo from which the
installed package came.
Re: [gentoo-portage-dev] [PATCH] Implement --newrepo flag.
On Friday, February 14, 2014 09:31:19 David James wrote: The --newrepo flag tells emerge to recompile a package if it is now being pulled from a different repository. BUG=chromium:200417 TEST=Verify ebuilds get pulled in when repo changes. --- man/emerge.1 | 5 +++ pym/_emerge/create_depgraph_params.py | 1 + pym/_emerge/depgraph.py | 80 ++- pym/_emerge/help.py | 2 +- 4 files changed, 48 insertions(+), 40 deletions(-) looks like your client line wrapped everything which is why it's unusable. i guess you need to use `git send-email` or tell your client to disable line wrapping when sending out patches. unless gmail is your client in which case you have to use `git` ;). -mike signature.asc Description: This is a digitally signed message part.
Re: [gentoo-portage-dev] [PATCH] Implement --newrepo flag.
Am 14.02.2014 21:43, schrieb David James: Uploaded here: https://chromium-review.googlesource.com/#/c/186651/ You should be able to cherry-pick using this command: git fetch https://chromium.googlesource.com/chromiumos/third_party/portage_tool refs/changes/51/186651/1 git cherry-pick FETCH_HEAD The patch has conflicts in depgraph.py. I haven't added automated tests yet. Cheers, David
