Re: [gentoo-portage-dev] [PATCH] egencache: Migrate _special_filename class to portage.utils.changelog for api use

[Brian Dolbec]

On Sat, 3 Dec 2016 14:10:33 -0800
Zac Medico  wrote:

> On 12/03/2016 01:49 PM, Brian Dolbec wrote:
> > +   if self.file_type_lt(self, other):
> > +   return True
> > +   elif self.file_type_lt(other, self):
> > +   return False  
> 
> Patch looks good, except there are 2 missed renames from file_type_lt
> to _file_type_lt above.


all issues fixed, and commit now pushed.
-- 
Brian Dolbec 

Re: [gentoo-portage-dev] [PATCH] egencache: Migrate _special_filename class to portage.utils.changelog for api use

[Zac Medico]

On 12/03/2016 01:49 PM, Brian Dolbec wrote:
> + if self.file_type_lt(self, other):
> + return True
> + elif self.file_type_lt(other, self):
> + return False

Patch looks good, except there are 2 missed renames from file_type_lt to
_file_type_lt above.
-- 
Thanks,
Zac