Re: [gentoo-portage-dev] [PATCH] portage.output: Replace darkblue colors with teal
On Sat, Dec 4, 2021, at 3:47 AM, Fabian Groffen wrote: > On 04-12-2021 10:24:23 +0100, Michał Górny wrote: > Now, if you would make a supported claim that all terminals we install > use a black background by default, your change becomes more valid. > I've wanted this change for many years actually, it's annoying booting into the admincd/installcd and having a lot of stuff be hard to see. When I finally get a graphical environment up it goes away but for a different reason. Ages ago there were people complaining about colored terminals and their eyesight -- part of it, I think, is the fact that some things display in blue. Sid.
Re: [gentoo-portage-dev] [PATCH] portage.output: Replace darkblue colors with teal
Michael Orlitzky wrote: > On Sat, 2021-12-04 at 10:47 +0100, Fabian Groffen wrote: >> Now, if you would make a supported claim that all terminals we install >> use a black background by default, your change becomes more valid. >> >> > For one, when you're working through the handbook to install Gentoo, > you're doing it on a black background. > > Or if you have any physical servers. The dark-blue-on-black is even > more fun to read from three feet away on the CRT monitor from 1995 in > the back of a poorly lit server room. > > > > As a user, I like the new color. I to use a black background and the dark blue is hard to see. I've also had to either copy and paste elsewhere or change the default color of Konsole. I might add, every console, the ctrl+alt+F1 console, that I have ever seen is also black. As a user, +1 for the change. If it is OK, +10. Dale :-) :_)
Re: [gentoo-portage-dev] [PATCH] portage.output: Replace darkblue colors with teal
On Sat, 2021-12-04 at 10:47 +0100, Fabian Groffen wrote: > > Now, if you would make a supported claim that all terminals we install > use a black background by default, your change becomes more valid. > > For one, when you're working through the handbook to install Gentoo, you're doing it on a black background. Or if you have any physical servers. The dark-blue-on-black is even more fun to read from three feet away on the CRT monitor from 1995 in the back of a poorly lit server room.
Re: [gentoo-portage-dev] [PATCH] portage.output: Replace darkblue colors with teal
On Saturday, 4 December 2021 10:47:53 PM NZDT Fabian Groffen wrote: > On 04-12-2021 10:24:23 +0100, Michał Górny wrote: > > On Sat, 2021-12-04 at 10:15 +0100, Fabian Groffen wrote: > > > On 04-12-2021 10:13:09 +0100, Michał Górny wrote: > > > > On Sat, 2021-12-04 at 09:56 +0100, Fabian Groffen wrote: > > > > > Why don't you change your color.map instead of changing the default > > > > > for > > > > > everyone? > > > > > > > > Why should we keep a stupid default? Should we optimize Gentoo for > > > > people who don't want to be able to read Portage's output? > > > > > > You're assuming everyone uses the terminal in the way you do. I simply > > > don't think that's how the world looks like. > > > > On the other hand, you're assuming that everyone uses the terminal > > in the way you do. > > It eludes me how you came to that conclusion. > > > > No need for calling things stupid, IMO. > > > > Using dark blue on black background is stupid. > > ... then don't use black background or dark blue text? > > Now, if you would make a supported claim that all terminals we install > use a black background by default, your change becomes more valid. > Well IMO, teal is still easy to read against a black & white background, where darkblue is almost impossible on black. This just seems like a sensible default > However, we then still don't know if people leave that default or use > something else, but we could make some educated guess about the amount > of people not changing the default. > > My point, because I think this wasn't clear to you, is and always was, > how many people is this change going to be disruptive to. And should > we make a hint to users when they install this version of Portage that > they can revert/change this by altering color.map (and how)? > > Thanks, > Fabian signature.asc Description: This is a digitally signed message part.
Re: [gentoo-portage-dev] [PATCH] portage.output: Replace darkblue colors with teal
On 04-12-2021 10:24:23 +0100, Michał Górny wrote: > On Sat, 2021-12-04 at 10:15 +0100, Fabian Groffen wrote: > > On 04-12-2021 10:13:09 +0100, Michał Górny wrote: > > > On Sat, 2021-12-04 at 09:56 +0100, Fabian Groffen wrote: > > > > Why don't you change your color.map instead of changing the default for > > > > everyone? > > > > > > Why should we keep a stupid default? Should we optimize Gentoo for > > > people who don't want to be able to read Portage's output? > > > > You're assuming everyone uses the terminal in the way you do. I simply > > don't think that's how the world looks like. > > On the other hand, you're assuming that everyone uses the terminal > in the way you do. It eludes me how you came to that conclusion. > > No need for calling things stupid, IMO. > > Using dark blue on black background is stupid. ... then don't use black background or dark blue text? Now, if you would make a supported claim that all terminals we install use a black background by default, your change becomes more valid. However, we then still don't know if people leave that default or use something else, but we could make some educated guess about the amount of people not changing the default. My point, because I think this wasn't clear to you, is and always was, how many people is this change going to be disruptive to. And should we make a hint to users when they install this version of Portage that they can revert/change this by altering color.map (and how)? Thanks, Fabian -- Fabian Groffen Gentoo on a different level signature.asc Description: PGP signature
Re: [gentoo-portage-dev] [PATCH] portage.output: Replace darkblue colors with teal
On Sat, 2021-12-04 at 10:15 +0100, Fabian Groffen wrote: > On 04-12-2021 10:13:09 +0100, Michał Górny wrote: > > On Sat, 2021-12-04 at 09:56 +0100, Fabian Groffen wrote: > > > Why don't you change your color.map instead of changing the default for > > > everyone? > > > > Why should we keep a stupid default? Should we optimize Gentoo for > > people who don't want to be able to read Portage's output? > > You're assuming everyone uses the terminal in the way you do. I simply > don't think that's how the world looks like. On the other hand, you're assuming that everyone uses the terminal in the way you do. > No need for calling things stupid, IMO. Using dark blue on black background is stupid. -- Best regards, Michał Górny
Re: [gentoo-portage-dev] [PATCH] portage.output: Replace darkblue colors with teal
On 04-12-2021 10:13:09 +0100, Michał Górny wrote: > On Sat, 2021-12-04 at 09:56 +0100, Fabian Groffen wrote: > > Why don't you change your color.map instead of changing the default for > > everyone? > > Why should we keep a stupid default? Should we optimize Gentoo for > people who don't want to be able to read Portage's output? You're assuming everyone uses the terminal in the way you do. I simply don't think that's how the world looks like. No need for calling things stupid, IMO. -- Fabian Groffen Gentoo on a different level signature.asc Description: PGP signature
Re: [gentoo-portage-dev] [PATCH] portage.output: Replace darkblue colors with teal
On Sat, 2021-12-04 at 09:56 +0100, Fabian Groffen wrote: > Why don't you change your color.map instead of changing the default for > everyone? Why should we keep a stupid default? Should we optimize Gentoo for people who don't want to be able to read Portage's output? -- Best regards, Michał Górny
Re: [gentoo-portage-dev] [PATCH] portage.output: Replace darkblue colors with teal
Why don't you change your color.map instead of changing the default for
everyone?
Thanks,
Fabian
On 04-12-2021 05:48:49 +0100, Michał Górny wrote:
> The "darkblue" color is often barely visible on dark terminals which
> makes reading emerge output really hard (I basically have to copy-paste
> it a lot in order to be able to read it at all). Replace it with teal
> that does not seem to have any significant use in the output.
>
> Signed-off-by: Michał Górny
> ---
> lib/portage/output.py | 6 +++---
> man/color.map.5 | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
>
> The before-after screenshot can be found on the PR:
> https://github.com/gentoo/portage/pull/776
>
>
> diff --git a/lib/portage/output.py b/lib/portage/output.py
> index 42f487f8a..77375b012 100644
> --- a/lib/portage/output.py
> +++ b/lib/portage/output.py
> @@ -157,7 +157,7 @@ _styles["UNMERGE_WARN"] = ("red",)
> _styles["SECURITY_WARN"] = ("red",)
> _styles["MERGE_LIST_PROGRESS"] = ("yellow",)
> _styles["PKG_BLOCKER"] = ("red",)
> -_styles["PKG_BLOCKER_SATISFIED"] = ("darkblue",)
> +_styles["PKG_BLOCKER_SATISFIED"] = ("teal",)
> _styles["PKG_MERGE"] = ("darkgreen",)
> _styles["PKG_MERGE_SYSTEM"] = ("darkgreen",)
> _styles["PKG_MERGE_WORLD"] = ("green",)
> @@ -165,8 +165,8 @@ _styles["PKG_BINARY_MERGE"] = ("purple",)
> _styles["PKG_BINARY_MERGE_SYSTEM"] = ("purple",)
> _styles["PKG_BINARY_MERGE_WORLD"] = ("fuchsia",)
> _styles["PKG_UNINSTALL"] = ("red",)
> -_styles["PKG_NOMERGE"] = ("darkblue",)
> -_styles["PKG_NOMERGE_SYSTEM"] = ("darkblue",)
> +_styles["PKG_NOMERGE"] = ("teal",)
> +_styles["PKG_NOMERGE_SYSTEM"] = ("teal",)
> _styles["PKG_NOMERGE_WORLD"] = ("blue",)
> _styles["PROMPT_CHOICE_DEFAULT"] = ("green",)
> _styles["PROMPT_CHOICE_OTHER"] = ("red",)
> diff --git a/man/color.map.5 b/man/color.map.5
> index 288bf7fbd..92a1baa91 100644
> --- a/man/color.map.5
> +++ b/man/color.map.5
> @@ -40,7 +40,7 @@ Defines color used for numbers indicating merge progress.
> \fBPKG_BLOCKER\fR = \fI"red"\fR
> Defines color used for unsatisfied blockers.
> .TP
> -\fBPKG_BLOCKER_SATISFIED\fR = \fI"darkblue"\fR
> +\fBPKG_BLOCKER_SATISFIED\fR = \fI"teal"\fR
> Defines color used for satisfied blockers.
> .TP
> \fBPKG_MERGE\fR = \fI"darkgreen"\fR
> @@ -63,10 +63,10 @@ package.
> Defines color used for world packages planned to be merged using a binary
> package.
> .TP
> -\fBPKG_NOMERGE\fR = \fI"darkblue"\fR
> +\fBPKG_NOMERGE\fR = \fI"teal"\fR
> Defines color used for packages not planned to be merged.
> .TP
> -\fBPKG_NOMERGE_SYSTEM\fR = \fI"darkblue"\fR
> +\fBPKG_NOMERGE_SYSTEM\fR = \fI"teal"\fR
> Defines color used for system packages not planned to be merged.
> .TP
> \fBPKG_NOMERGE_WORLD\fR = \fI"blue"\fR
> --
> 2.34.1
>
>
--
Fabian Groffen
Gentoo on a different level
signature.asc
Description: PGP signature
[gentoo-portage-dev] [PATCH] portage.output: Replace darkblue colors with teal
The "darkblue" color is often barely visible on dark terminals which
makes reading emerge output really hard (I basically have to copy-paste
it a lot in order to be able to read it at all). Replace it with teal
that does not seem to have any significant use in the output.
Signed-off-by: Michał Górny
---
lib/portage/output.py | 6 +++---
man/color.map.5 | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
The before-after screenshot can be found on the PR:
https://github.com/gentoo/portage/pull/776
diff --git a/lib/portage/output.py b/lib/portage/output.py
index 42f487f8a..77375b012 100644
--- a/lib/portage/output.py
+++ b/lib/portage/output.py
@@ -157,7 +157,7 @@ _styles["UNMERGE_WARN"] = ("red",)
_styles["SECURITY_WARN"] = ("red",)
_styles["MERGE_LIST_PROGRESS"] = ("yellow",)
_styles["PKG_BLOCKER"] = ("red",)
-_styles["PKG_BLOCKER_SATISFIED"] = ("darkblue",)
+_styles["PKG_BLOCKER_SATISFIED"] = ("teal",)
_styles["PKG_MERGE"] = ("darkgreen",)
_styles["PKG_MERGE_SYSTEM"] = ("darkgreen",)
_styles["PKG_MERGE_WORLD"] = ("green",)
@@ -165,8 +165,8 @@ _styles["PKG_BINARY_MERGE"] = ("purple",)
_styles["PKG_BINARY_MERGE_SYSTEM"] = ("purple",)
_styles["PKG_BINARY_MERGE_WORLD"] = ("fuchsia",)
_styles["PKG_UNINSTALL"] = ("red",)
-_styles["PKG_NOMERGE"] = ("darkblue",)
-_styles["PKG_NOMERGE_SYSTEM"] = ("darkblue",)
+_styles["PKG_NOMERGE"] = ("teal",)
+_styles["PKG_NOMERGE_SYSTEM"] = ("teal",)
_styles["PKG_NOMERGE_WORLD"] = ("blue",)
_styles["PROMPT_CHOICE_DEFAULT"] = ("green",)
_styles["PROMPT_CHOICE_OTHER"] = ("red",)
diff --git a/man/color.map.5 b/man/color.map.5
index 288bf7fbd..92a1baa91 100644
--- a/man/color.map.5
+++ b/man/color.map.5
@@ -40,7 +40,7 @@ Defines color used for numbers indicating merge progress.
\fBPKG_BLOCKER\fR = \fI"red"\fR
Defines color used for unsatisfied blockers.
.TP
-\fBPKG_BLOCKER_SATISFIED\fR = \fI"darkblue"\fR
+\fBPKG_BLOCKER_SATISFIED\fR = \fI"teal"\fR
Defines color used for satisfied blockers.
.TP
\fBPKG_MERGE\fR = \fI"darkgreen"\fR
@@ -63,10 +63,10 @@ package.
Defines color used for world packages planned to be merged using a binary
package.
.TP
-\fBPKG_NOMERGE\fR = \fI"darkblue"\fR
+\fBPKG_NOMERGE\fR = \fI"teal"\fR
Defines color used for packages not planned to be merged.
.TP
-\fBPKG_NOMERGE_SYSTEM\fR = \fI"darkblue"\fR
+\fBPKG_NOMERGE_SYSTEM\fR = \fI"teal"\fR
Defines color used for system packages not planned to be merged.
.TP
\fBPKG_NOMERGE_WORLD\fR = \fI"blue"\fR
--
2.34.1
