Re: [gentoo-portage-dev] [PATCH] repoman: fix _here_doc_re to handle file redirection
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Uhm. Looks. Uhm. Brian, is this OK? - -- Alexander berna...@gentoo.org https://secure.plaimi.net/~alexander -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBCgAGBQJWnfn9AAoJENQqWdRUGk8B9GkP/RMSjepdRA84K6IG7nhCLLWC LBAQ7lzrvo6l6Q9tZeJdFrToaFcecR/t8ou9zhFDRXqslbzMov6+ri6fKjZLZYhx tkOSHK04ZhqhDiaGFr6SGCfsKUPSsVzsOKyZZypdpdAiNME28la4tfsG1V0SBVU3 8AX2kc8ewhhYppWmhK2rVUxgMv50hR5lme5tyyB0Rz6sc7V7rh8nAx4kJZEOm5XW 09MvNHJnSBDORNNZ7u+/htmEHTNbxmppANQ2U5+ZQU/tUP5FUpb9aeLYfdT+EWOx WW1glFVzk7fZk4il8mK2xuoRocOjp0DLzTEiHXd1NdKQY+tE+3LLuJkIe+gHvj6L t65E04GbYMbPvP7l3FGiYLG3Wm+tihXwfLJ7G2CX6AsJGsETaGm3HonAn01t6euN 0FutMfHtAPLE6VmUoJeG2VGL7grlM9Nzg7AT2qcz5r99YJ0n6Xo2EguMnE+Dshh9 I2VLBB6A1KyObmhTOtbM0aAzo1BJLURScDuLw0vfETyGhDhxD0K3khHBJr7i+1/N xGqlWVsAJmnw+qKKanUFq7SKvsWjIoBYzgAD9X87xQhGTeIHM4synNWGFejNNdZV rr9JNzfVJn99uqSzX68EwTQw71zR6jt0GWOxPTc60+oI3NxxPZOypp4lsyQfnnHB 0p7nSH1svMbLyabMWXCQ =vgNt -END PGP SIGNATURE-
Re: [gentoo-portage-dev] [PATCH] repoman: fix _here_doc_re to handle file redirection
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Tue, 19 Jan 2016 09:55:26 +0100 Alexander Berntsenwrote: > > Uhm. Looks. Uhm. Brian, is this OK? > > - -- > Alexander > berna...@gentoo.org > https://secure.plaimi.net/~alexander > Yeah, I also see I forgot to move some code from that checks.py to the new check plugin using that portion of code. P.S. I also see a lot of code in that file that is not being used. I'll double check that it was not used in 2.2.21 also (the last version before the stage 1 merge. I believe much of it was removed from use with the tree becoming EAPI 5, even though not all the EAPI checks in there were not banned. - -- Brian Dolbec -BEGIN PGP SIGNATURE- Version: GnuPG v2.1 iQJ8BAEBCgBmBQJWnoPwXxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNUQ3Qzc0RTA4MUNDNzBEQjRBNEFBRjVG QkJEMDg3Mjc1ODIwRUQ4AAoJEPu9CHJ1gg7Yk34P/A9Wq2Hv+bIbtXNVx484x5P7 ROndhNIRnLakvhs6IyZGbXYcyZVDkh+irp3RpTXZFFoPo9G20K0gpJONA8TuhkSv imH47Spss97H5Z28jzto3IbG6GCAWWz/Y8+jChmwAZFUM777+2MytxUpIqV56TjV Zw2+z3vqLIi94AoaRrGtXjnWDB8EyyihtEUjB70aAtJ4FsQc33jd2M14q1Fc6vVR UxXWCU5Gk00VykeOwQMQM47z6AUzX/5qj2yPbNHjpehTVntMba0yfnAVMIORPwvc nCKPSFMwBTfBa0Rk/796JN+JuZXhcT/+24tVCMONJhSJFw8cXyzE6NIxvYMJZFa2 xZqDeGbeIoQtwc+EFbFSWvNsrDQntJ5LjszQ2Ml9QCnwdCwMuxTxdrgTSYsrU6FG dlTrJmNc5TAQdAFkKzKSK1/F00/JHTVtKkyKtzKPOv0erDg7MV3nzIG28NI3i0JG 06sa3/pXLQ0DxLIU7XJklvFwziDDp5paz6eB1I9zL7zXgHS5DsPWlo+Qz5jg382Z ppFnXasr2i2SHm8A0pCl/jb7pUPcdahdilkVI5G7+rpAzlOJGix98Iir0WwZThIx eVi5DHiw+95VnI2ldczkmTJjpPy/wSp3DtJ+gMZnQ4GDMWYQy8jlK8KeE2RWtmzz 9bFTqNDrdq8j0/mT3E/m =piKD -END PGP SIGNATURE-
[gentoo-portage-dev] [PATCH] repoman: fix _here_doc_re to handle file redirection
This suppresses "Unquoted Variable" warnings for sys-apps/portage ebuilds where a here-doc is used to generate repos.conf: ebuild.minorsyn 6 sys-apps/portage/portage-2.2.8-r2.ebuild: Unquoted Variable on line: 496 sys-apps/portage/portage-2.2.20.1.ebuild: Unquoted Variable on line: 290 sys-apps/portage/portage-2.2.23.ebuild: Unquoted Variable on line: 290 sys-apps/portage/portage-2.2.24.ebuild: Unquoted Variable on line: 290 sys-apps/portage/portage-2.2.25.ebuild: Unquoted Variable on line: 290 sys-apps/portage/portage-2.2.26.ebuild: Unquoted Variable on line: 294 --- pym/repoman/checks/ebuilds/checks.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pym/repoman/checks/ebuilds/checks.py b/pym/repoman/checks/ebuilds/checks.py index 7bab8e4..c752fcf 100644 --- a/pym/repoman/checks/ebuilds/checks.py +++ b/pym/repoman/checks/ebuilds/checks.py @@ -920,7 +920,7 @@ def checks_init(experimental_inherit=False): for k, kwargs in _eclass_info.items( -_here_doc_re = re.compile(r'.*\s<<[-]?(\w+)$') +_here_doc_re = re.compile(r'.*<<[-]?(\w+)\s*(>\s*\S+)?$') _ignore_comment_re = re.compile(r'^\s*#') -- 2.4.10