Re: [gentoo-portage-dev] Move PORTAGE_INST_UID and PORTAGE_INST_GID to make.globals?

2006-03-10 Thread Kito


On Mar 10, 2006, at 10:01 PM, Jason Stubbs wrote:


On Saturday 11 March 2006 06:48, Kito wrote:


On Mar 10, 2006, at 4:26 AM, Zac Medico wrote:


-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hello,

What do people think about moving PORTAGE_INST_UID and
PORTAGE_INST_GID to make.globals?


Would the profiles not be a more logical place to set these? If not,
can we twist the logic to make it so? :p


The profiles would be able to override it. In the case of non- 
incrementals

the first definition found is the winner in the order of:

env -> make.conf -> make.defaults (profile) -> make.globals


err, right..should've known that. Thanks for answering a silly question.

--Kito




--
gentoo-portage-dev@gentoo.org mailing list



Re: [gentoo-portage-dev] Move PORTAGE_INST_UID and PORTAGE_INST_GID to make.globals?

2006-03-10 Thread Jason Stubbs
On Saturday 11 March 2006 06:48, Kito wrote:
> 
> On Mar 10, 2006, at 4:26 AM, Zac Medico wrote:
> 
> > -BEGIN PGP SIGNED MESSAGE-
> > Hash: SHA1
> >
> > Hello,
> >
> > What do people think about moving PORTAGE_INST_UID and  
> > PORTAGE_INST_GID to make.globals?
> 
> Would the profiles not be a more logical place to set these? If not,  
> can we twist the logic to make it so? :p

The profiles would be able to override it. In the case of non-incrementals
the first definition found is the winner in the order of:

env -> make.conf -> make.defaults (profile) -> make.globals

--
Jason Stubbs
-- 
gentoo-portage-dev@gentoo.org mailing list



Re: [gentoo-portage-dev] Move PORTAGE_INST_UID and PORTAGE_INST_GID to make.globals?

2006-03-10 Thread Kito


On Mar 10, 2006, at 4:26 AM, Zac Medico wrote:


-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hello,

What do people think about moving PORTAGE_INST_UID and  
PORTAGE_INST_GID to make.globals?


Would the profiles not be a more logical place to set these? If not,  
can we twist the logic to make it so? :p


--Kito




--
gentoo-portage-dev@gentoo.org mailing list



[gentoo-portage-dev] Move PORTAGE_INST_UID and PORTAGE_INST_GID to make.globals?

2006-03-10 Thread Zac Medico
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hello,

What do people think about moving PORTAGE_INST_UID and PORTAGE_INST_GID to 
make.globals?  The variables are currently hard coded in ebuild.sh and it might 
be useful to override the uid and gid via make.conf.

Zac 
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.2.1 (GNU/Linux)

iD8DBQFEEVRp/ejvha5XGaMRAmjQAKDVdPpgHH90AGQaZecSj/vMLatWOACdF8NR
9jcL5KUT9LRndtPZ+i3TKrE=
=BqTq
-END PGP SIGNATURE-
Index: cnf/make.globals
===
--- cnf/make.globals	(revision 2838)
+++ cnf/make.globals	(working copy)
@@ -60,6 +60,10 @@
 # Disable auto-use
 USE_ORDER="env:pkg:conf:defaults"
 
+PORTAGE_INST_UID="0"
+PORTAGE_INST_GID="0"
+
+
 #*
 #**  DO NOT EDIT THIS FILE  **
 # ***
Index: bin/dosbin
===
--- bin/dosbin	(revision 2838)
+++ bin/dosbin	(working copy)
@@ -16,7 +16,7 @@
 
 for x in "$@" ; do
 	if [[ -e ${x} ]] ; then
-		install -m0755 -o 0 -g 0 "${x}" "${D}${DESTTREE}/sbin"
+		install -m0755 -o ${PORTAGE_INST_UID} -g ${PORTAGE_INST_GID} "${x}" "${D}${DESTTREE}/sbin"
 	else
 		echo "!!! ${0##*/}: ${x} does not exist" 1>&2
 		false
Index: bin/dobin
===
--- bin/dobin	(revision 2838)
+++ bin/dobin	(working copy)
@@ -16,7 +16,7 @@
 
 for x in "$@" ; do
 	if [[ -e ${x} ]] ; then
-		install -m0755 -o 0 -g 0 "${x}" "${D}${DESTTREE}/bin"
+		install -m0755 -o ${PORTAGE_INST_UID} -g ${PORTAGE_INST_GID} "${x}" "${D}${DESTTREE}/bin"
 	else
 		echo "!!! ${0##*/}: ${x} does not exist" 1>&2
 		false
Index: bin/ebuild.sh
===
--- bin/ebuild.sh	(revision 2838)
+++ bin/ebuild.sh	(working copy)
@@ -1017,10 +1017,6 @@
 	trap SIGINT SIGQUIT
 }
 
-
-PORTAGE_INST_UID="0"
-PORTAGE_INST_GID="0"
-
 dyn_install() {
 	[ -z "$PORTAGE_BUILDDIR" ] && die "${FUNCNAME}: PORTAGE_BUILDDIR is unset"
 	trap "abort_install" SIGINT SIGQUIT