[gentoo-portage-dev] When must we write tests, when is it optional?

2014-01-17 Thread Tom Wijsman 
Hello

Looking back on the repoman patches from both me and creffett, we
haven't written tests; it's on my plan to still do that, if possible.

This makes me wonder: Should writing tests be a requirement? When?

-- 
With kind regards,

Tom Wijsman (TomWij)
Gentoo Developer

E-mail address  : tom...@gentoo.org
GPG Public Key  : 6D34E57D
GPG Fingerprint : C165 AF18 AB4C 400B C3D2  ABF0 95B2 1FCD 6D34 E57D


signature.asc
Description: PGP signature

Re: [gentoo-portage-dev] When must we write tests, when is it optional?

2014-01-17 Thread Mike Frysinger 
On Saturday 18 January 2014 01:40:04 Mike Frysinger wrote:
 On Friday 17 January 2014 19:10:56 Tom Wijsman wrote:
  Looking back on the repoman patches from both me and creffett, we
  haven't written tests; it's on my plan to still do that, if possible.
  
  This makes me wonder: Should writing tests be a requirement? When?
 
 i'm not sure if it should be a hard requirement, but it is strongly
 encouraged

i would even encourage reviewers to inquire about tests, especially when the 
change is not entirely obvious
-mike


signature.asc
Description: This is a digitally signed message part.