Re: [geos-devel] GEOS-3.3.0rc1 released
On 19/05/11 20:53, Sandro Santilli wrote: On Thu, May 19, 2011 at 03:34:28PM -0400, Frank Warmerdam wrote: Hopefully we could issue an RC2? We're also waiting for Mat's CMake fixes I started merging outstanding patches last night, but I need to do it manually due to some parts rejected by patch util. I'm completing it tonight. Best regards, -- Mateusz Loskot, http://mateusz.loskot.net Charter Member of OSGeo, http://osgeo.org Member of ACCU, http://accu.org ___ geos-devel mailing list geos-devel@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/geos-devel
Re: [geos-devel] GEOS-3.3.0rc1 released
On 11-05-17 04:32 PM, Paul Meems wrote: Hi list, I've just downloaded GEOS-3.3.0RC1 and try to run nmake on a Win7 with VS2008 Pro. After a while processing I get this error: NMAKE : fatal error U1073: don't know how to make 'geomgraph\EdgeIntersection.obj' NMAKE : fatal error U1077: 'C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\BIN\nmake.EXE' : return code '0x2' I've already Googled but didn't find anything useful. This is the first output of nmake /f makefile.vc http://makefile.vc/ MSVC_VER=1500 Microsoft (R) Program Maintenance Utility Version 9.00.30729.01 Copyright (C) Microsoft Corporation. All rights reserved. ** *** GEOS Build Configuration *** *** Setting BUILD_DEBUG NO *** Setting ENABLE_INLINE NO *** Setting BUILD_BATCH NO *** Using Microsoft NMAKE version 9.00.30729.01 *** Using Microsoft Visual C++ version 9.0 *** Using Microsoft C/C++ version 1500 *** Setting GEOS_INCLUDE -I..\include -I..\capi *** Setting INCLUDE C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\ATLMFC \INCLUDE;C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\INCLUDE;C:\Progra m Files\Microsoft SDKs\Windows\v6.0A\include; *** Using CFLAGS /nologo /MD /GR /O2 /W3 /EHs *** Using CPPFLAGS /D NDEBUG /D NOMINMAX /D WIN32_LEAN_AND_MEAN /D NOGDI /D GEOS_DLL_EXPORT /D _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECAT E /D _SCL_SECURE_NO_DEPRECATE ** Probably I'm doing something wrong. I'm no expert on compiling C++ projects and/or using nmake. Can anybody give me a hint? Paul, I am working on fixing up the Makefile.vc. I see it has fallen behind on a number of points. Hopefully an RC2 will be possible once I have the fix in. Best regards, -- ---+-- I set the clouds in motion - turn up | Frank Warmerdam, warmer...@pobox.com light and sound - activate the windows | http://pobox.com/~warmerdam and watch the world go round - Rush| Geospatial Programmer for Rent ___ geos-devel mailing list geos-devel@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/geos-devel
Re: [geos-devel] GEOS-3.3.0rc1 released
On Thu, May 19, 2011 at 03:34:28PM -0400, Frank Warmerdam wrote: I have made a few fixes in trunk related to this: http://trac.osgeo.org/geos/changeset/3372 The changes to Makefile.vc are specific to this building approach. But the other changes could affect other builds. One was declaring assert for SegmentPointComparitor.h. Another was a problem when GEOS_INLINE is not defined and the last was a problem building with NDEBUG. The change in PolygonBuilder.cpp looks suspicious. The found two shells in MinimalEdgeRing exception was even triggered by a recently closed bug. Could you reverse that and file a ticket explaining why you'd need to disable it when building with NDEBUG ? Hopefully we could issue an RC2? We're also waiting for Mat's CMake fixes --strk; () Free GIS Flash consultant/developer /\ http://strk.keybit.net/services.html ___ geos-devel mailing list geos-devel@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/geos-devel
Re: [geos-devel] GEOS-3.3.0rc1 released
On Thu, May 19, 2011 at 04:15:57PM -0400, Frank Warmerdam wrote: On 11-05-19 03:53 PM, Sandro Santilli wrote: The change in PolygonBuilder.cpp looks suspicious. The found two shells in MinimalEdgeRing exception was even triggered by a recently closed bug. Could you reverse that and file a ticket explaining why you'd need to disable it when building with NDEBUG ? Strk, The definition of shellCount was already: #ifndef NDEBUG int shellCount=0; #endif It seems clear, in context, that the shellCount related stuff was setup to be a debug-only build check. I have no idea why. Ok, the correct fix is to remove the NDEBUG check around the declaration of shellCount. It was like that because what is now an exception used to be an assertion, but we found real world input data triggering it, and Martin Davis agreed on turning that assertion into an exception as it due to numerical stability and can thus be handled. All I did was extend things accordingly. So I'm not really inclined to back it out, and file a ticket. But if you think that the shellCount checks and corresponding exception should always be evaluated then I would suggest filing a ticket to that effect and we can remove all the #ifndef NDEBUG wrappers for shellCount stuff. Yes, that's the way to go. We can avoid a ticket, but could you please commit the wrapper removal ? NOTE: I know it's annoying to file tickets, but it is currently our only way to comment about changes in context. Maybe a commit mailing list would make that easier. --strk; () Free GIS Flash consultant/developer /\ http://strk.keybit.net/services.html ___ geos-devel mailing list geos-devel@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/geos-devel
