Re: [Geoserver-devel] Problems with the FeatureSizeFeatureCollection
Hi Jim, testing delegation works is not so hard, see this test class for an example: https://github.com/geotools/geotools/blob/865cc72a90b07841a4c871d1b07fcc8e5defd35b/modules/library/main/src/test/java/org/geotools/data/crs/ReprojectFeatureResultsTest.java#L43 Cheers Andrea On Fri, Jun 8, 2018 at 7:02 PM, Jim Hughes wrote: > Hi Andrea, > > I tossed up a PR here: https://github.com/geoserver/geoserver/pull/2905 > with a ticket https://osgeo-org.atlassian.net/browse/GEOS-8779. > > I am not seeing a quick way to provide a unit test. If you (or anyone) > has a suggestion on that front, I'm happy to include one. > > Cheers, > > Jim > > > On 06/08/2018 12:49 PM, Andrea Aime wrote: > > Hi Jim, > yes, properly implemented collection wrappers should allow delegation > > Cheers > Andrea > > On Fri, Jun 8, 2018 at 6:47 PM, Jim Hughes wrote: > >> Andrea, >> >> Thanks for helping the PR through. >> >> I haven't tested out the first case completely. I've definitely run into >> the issue that Alvaro is trying to address with WFS 2.0. >> >> In the short term, is allowing the FC to delegate reasonable? >> >> Cheers, >> >> Jim >> >> >> On 06/08/2018 12:07 PM, Andrea Aime wrote: >> >> Ah, >> that change was controversial and the pull request sat there for ages >> before being merged: >> https://github.com/geoserver/geoserver/pull/2664 >> >> (shows me as the author, but it's not really me, I'm just unwillingly >> involved because nobody else would take action) >> >> Please discuss. >> >> Cheers >> Andrea >> >> >> On Fri, Jun 8, 2018 at 5:57 PM, Jim Hughes wrote: >> >>> Hi all, >>> >>> While testing out GeoMesa with GeoServer 2.13.x, we ran into some issues >>> with the FeatureSizeFeatureCollection. I think there are two issues: >>> >>> First, for a layers backed by a large volume of data, getCount returning >>> -1 is partially a way of saying that you don't want to count all the >>> features;). Given this pattern, I'd suggest that the >>> FeatureSizeFeatureCollection might be taken off the usual path completely. >>> It looks like it might be an optimization when working with a bunch of >>> little shapefiles. >>> >>> Second, WPSes can be implemented with a visitor pattern. For instance, >>> the gs:Unique process leverages the GeoTools UniqueVisitor(1) which is >>> recognized by the JDBC DataStores. (In GeoMesa, we do a bunch of similar >>> things.) >>> >>> The fact that the current FeatureSizeFeatureCollection doesn't delegate >>> prevents the UniqueProcess (and the GeoMesa ones) from working properly... >>> >>> In the short term, any objection to a PR which enables delegation for >>> that FeatureCollection? >>> >>> Cheers, >>> >>> Jim >>> >>> 1. UniqueVisitor: https://github.com/geotools/ge >>> otools/blob/master/modules/library/main/src/main/java/org/ge >>> otools/feature/visitor/UniqueVisitor.java >>> https://github.com/geotools/geotools/blob/master/modules/lib >>> rary/jdbc/src/main/java/org/geotools/jdbc/SQLDialect.java#L375 >>> >>> p.s. I debugged this using PostGIS and the gs:Unique process. When the >>> FeatureSizeFC was 'on', the queries did not have the 'distinct' keyword. >>> When the FC was off, GeoServer did make a 'distinct' query. >>> >>> >>> >>> -- >>> Check out the vibrant tech community on one of the world's most >>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >>> ___ >>> Geoserver-devel mailing list >>> Geoserver-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>> >>> >> >> >> -- >> >> Regards, Andrea Aime == GeoServer Professional Services from the experts! >> Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime >> @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 >> Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 >> 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it >> --- *Con riferimento >> alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - >> Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni >> circostanza inerente alla presente email (il suo contenuto, gli eventuali >> allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i >> destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per >> errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le >> sarei comunque grato se potesse darmene notizia. This email is intended >> only for the person or entity to which it is addressed and may contain >> information that is privileged, confidential or otherwise protected from >> disclosure. We remind that - as provided by European Regulation 2016/679 >> “GDPR” - copying, dissemination or use of this e-mail or the information >> herein by anyone other than the intended recipient is prohibited. If you >> h
Re: [Geoserver-devel] You have been... ref0rmatt3d!
Good news, thank you Andrea ! On 06/09/2018 03:25 PM, Andrea Aime wrote: Hi all, as agreed, the big bad reformat landed on master, 2.13.x and 2.12.x. Back to normal business for everybody :-) And oh, I've modified the setup so that on Travis it won't check for local modifications, but directly for faulty formatting (the error message should be easier to understand). The Jenkins builds are also following the same settings Oh, I've noticed there is a newer version of the formatting plugin, but as far as I could tell, it was not fixing any bug of significant, while it was changing the formatting rules for annotations a bit, changing several files. I skipped this upgrade to avoid adding extra noise on the commit history... if need be, we can revisit and upgrade later I guess Cheers Andrea == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it --- /Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail./ -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel -- Regards, Nuno Oliveira == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Nuno Miguel Carvalho Oliveira @nmcoliveira Software Engineer GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 http://www.geo-solutions.it http://twitter.com/geosolutions_it --- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] You have been... ref0rmatt3d!
Hi all, as agreed, the big bad reformat landed on master, 2.13.x and 2.12.x. Back to normal business for everybody :-) And oh, I've modified the setup so that on Travis it won't check for local modifications, but directly for faulty formatting (the error message should be easier to understand). The Jenkins builds are also following the same settings Oh, I've noticed there is a newer version of the formatting plugin, but as far as I could tell, it was not fixing any bug of significant, while it was changing the formatting rules for annotations a bit, changing several files. I skipped this upgrade to avoid adding extra noise on the commit history... if need be, we can revisit and upgrade later I guess Cheers Andrea == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it --- *Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.* -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
