Re: [Geoserver-devel] is CatalogListener.reloaded() dead code?

2024-05-19 Thread Jody Garnett
What does happen on catalogue reload? can we restore the event?

--
Jody Garnett


On Sun, May 19, 2024 at 5:27 PM Gabriel Roldan <
gabriel.rol...@camptocamp.com> wrote:

> Hey all,
>
> tried to live-test a CatalogListener.reloaded() implementation, turns out
> I can't find any caller in the codebase:
>
> grep "\.reloaded()" -R --include=*.java
> wms/src/test/java/org/geoserver/wms/capabilities/GetCapabilitiesLegendURLTest.java:
>((LegendSampleImpl)
> GeoServerExtensions.bean(LegendSample.class)).reloaded();
>
> Is it supposed to be replaced by GeoServerLifecycleHandler.onReload(), or
> at some point we stopped calling it?
> There seems to be a couple implementations out there with non-empty bodies:
> - LayerGroupContainmentCache$CatalogChangeListener
> - LegendSampleImpl
> - MimeTypeCacheClearingListener
> - WFSConfiguration'\s anonymous inner class
>
>
> TIA,
> gabe
> *camptocamp*
> INNOVATIVE SOLUTIONS
> BY OPEN SOURCE EXPERTS
>
> *Gabriel Roldán*
> Geospatial Developer
>
> ___
> Geoserver-devel mailing list
> Geoserver-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
___
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel


[Geoserver-devel] is CatalogListener.reloaded() dead code?

2024-05-19 Thread Gabriel Roldan
Hey all,

tried to live-test a CatalogListener.reloaded() implementation, turns out I
can't find any caller in the codebase:

grep "\.reloaded()" -R --include=*.java
wms/src/test/java/org/geoserver/wms/capabilities/GetCapabilitiesLegendURLTest.java:
   ((LegendSampleImpl)
GeoServerExtensions.bean(LegendSample.class)).reloaded();

Is it supposed to be replaced by GeoServerLifecycleHandler.onReload(), or
at some point we stopped calling it?
There seems to be a couple implementations out there with non-empty bodies:
- LayerGroupContainmentCache$CatalogChangeListener
- LegendSampleImpl
- MimeTypeCacheClearingListener
- WFSConfiguration'\s anonymous inner class


TIA,
gabe
*camptocamp*
INNOVATIVE SOLUTIONS
BY OPEN SOURCE EXPERTS

*Gabriel Roldán*
Geospatial Developer
___
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel