Re: [Geotools-devel] Alignment of the planets caused geotools-master-online-postgis DefaultTemporalGeometricPrimitiveTest failure?

2018-06-03 Thread Ben Caradoc-Davies 

And we can also expect this test to fail on 1 January 2020:
https://github.com/geotools/geotools/blob/master/modules/library/main/src/test/java/org/geotools/temporal/object/DefaultTemporalGeometricPrimitiveTest.java#L95

The last time this test failed in 2012 the fix was to increase the year 
to 2020:


[GEOT-3995] 
org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest fails 
in 2012

https://osgeo-org.atlassian.net/browse/GEOT-3995
https://github.com/geotools/geotools/commit/15aa91e588def1ec9822b0308c9fffb8fff5821d#diff-8f07c1965dae55b7158e9080c79486e5

Kind regards,

--
Ben Caradoc-Davies 
Director
Transient Software Limited 
New Zealand

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] Alignment of the planets caused geotools-master-online-postgis DefaultTemporalGeometricPrimitiveTest failure?

2018-06-03 Thread Jody Garnett 
Not quite a fault in our stars, but close.
On Sun, Jun 3, 2018 at 8:44 PM Ben Caradoc-Davies  wrote:

> On 03/06/18 09:56, Ben Caradoc-Davies wrote:
> > On 03/06/18 09:33, moni...@boundlessgeo.com wrote:
> >> See
> >> <
> https://build.geoserver.org/job/geotools-master-online-postgis/626/display/redirect>
>
> > I kicked it and it failed again:
> > Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0 sec
> > <<< FAILURE! - in
> > org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest
> >
> testDistance(org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest)
>
> >   Time elapsed: 0 sec  <<< FAILURE!
> > java.lang.AssertionError: null
> >  at org.junit.Assert.fail(Assert.java:86)
> >  at org.junit.Assert.assertTrue(Assert.java:41)
> >  at org.junit.Assert.assertFalse(Assert.java:64)
> >  at org.junit.Assert.assertFalse(Assert.java:74)
> >  at
> >
> org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest.testDistance(DefaultTemporalGeometricPrimitiveTest.java:73)
>
> > Timezone rollover problem? Month zero is January. Server west of the
> > meridian? But why was this passing before?
>
> There is a logic error in the test! The test assumes that the duration
> from 25 July 1985 from 1 January 2000 (6734 days) is not the same as the
> duration from 1 January 2000 to today. But this happens. Once! I am just
> not sure why it seems to have happened one week early on 2 June 2018.
>
> $ date -u -d "6734 day 12:00 25 July 1981 UTC"
> Sat  1 Jan 12:00:00 UTC 2000
>
> $ date -u -d "6734 day 12:00 1 Jan 2000 UTC"
> Sat  9 Jun 12:00:00 UTC 2018
>
> Kind regards,
>
> --
> Ben Caradoc-Davies 
> Director
> Transient Software Limited 
> New Zealand
>
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> GeoTools-Devel mailing list
> GeoTools-Devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
-- 
--
Jody Garnett
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] Alignment of the planets caused geotools-master-online-postgis DefaultTemporalGeometricPrimitiveTest failure?

2018-06-03 Thread Ben Caradoc-Davies 

On 03/06/18 09:56, Ben Caradoc-Davies wrote:

On 03/06/18 09:33, moni...@boundlessgeo.com wrote:
See 
 

I kicked it and it failed again:
Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0 sec 
<<< FAILURE! - in 
org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest
testDistance(org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest) 
  Time elapsed: 0 sec  <<< FAILURE!

java.lang.AssertionError: null
 at org.junit.Assert.fail(Assert.java:86)
 at org.junit.Assert.assertTrue(Assert.java:41)
 at org.junit.Assert.assertFalse(Assert.java:64)
 at org.junit.Assert.assertFalse(Assert.java:74)
 at 
org.geotools.temporal.object.DefaultTemporalGeometricPrimitiveTest.testDistance(DefaultTemporalGeometricPrimitiveTest.java:73) 
Timezone rollover problem? Month zero is January. Server west of the 
meridian? But why was this passing before?


There is a logic error in the test! The test assumes that the duration 
from 25 July 1985 from 1 January 2000 (6734 days) is not the same as the 
duration from 1 January 2000 to today. But this happens. Once! I am just 
not sure why it seems to have happened one week early on 2 June 2018.


$ date -u -d "6734 day 12:00 25 July 1981 UTC"
Sat  1 Jan 12:00:00 UTC 2000

$ date -u -d "6734 day 12:00 1 Jan 2000 UTC"
Sat  9 Jun 12:00:00 UTC 2018

Kind regards,

--
Ben Caradoc-Davies 
Director
Transient Software Limited 
New Zealand

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

[Geotools-devel] Jenkins build is back to normal : geotools-master-online-postgis #627

2018-06-03 Thread monitor 
See 



--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel