Re: [Geotools-devel] MBStyles breaking the build on OpenJDK?
I spent some time working on that issue, the solution to get the test working, after attempting to find any cross platform font issues, was to relax the threshold. John Schulz Mobile: +1.314.398.0984 Software Developer | Boundless <http://boundlessgeo.com/> jsch...@boundlessgeo.com On Tue, Feb 27, 2018 at 10:08 AM, Andrea Aime <andrea.a...@geo-solutions.it> wrote: > Hi, > I'm having a build failure in the mbstyles module that has no match on the > build server, the test > being VisualTransformerTest.mbSymbolLayerTextLinePlacementVisualTest. > The error is: > > java.lang.AssertionError: Images are visibly different, found 1975 > different pixels, against a threshold of 1800 > > Here is the visual diff: > > [image: Inline image 1] > > Zooming in, it actually seems an aliasing issue. > > So, objections to relax the threshold to2000? Just in that test, or in all > of them? > > Cheers > Andrea > > == > GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions S.A.S. > Via di Montramito 3/A > 55054 Massarosa (LU) > phone: +39 0584 962313 <+39%200584%20962313> > fax: +39 0584 1660272 <+39%200584%20166%200272> > mob: +39 339 8844549 <+39%20339%20884%204549> > > http://www.geo-solutions.it > http://twitter.com/geosolutions_it > > AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 > > Le informazioni contenute in questo messaggio di posta elettronica e/o > nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il > loro utilizzo è consentito esclusivamente al destinatario del messaggio, > per le finalità indicate nel messaggio stesso. Qualora riceviate questo > messaggio senza esserne il destinatario, Vi preghiamo cortesemente di > darcene notizia via e-mail e di procedere alla distruzione del messaggio > stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, > divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od > utilizzarlo per finalità diverse, costituisce comportamento contrario ai > principi dettati dal D.Lgs. 196/2003. > > The information in this message and/or attachments, is intended solely for > the attention and use of the named addressee(s) and may be confidential or > proprietary in nature or covered by the provisions of privacy act > (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection > Code).Any use not in accord with its purpose, any disclosure, reproduction, > copying, distribution, or either dissemination, either whole or partial, is > strictly forbidden except previous formal approval of the named > addressee(s). If you are not the intended recipient, please contact > immediately the sender by telephone, fax or e-mail and delete the > information in this message that has been received in error. The sender > does not give any warranty or accept liability as the content, accuracy or > completeness of sent messages and accepts no responsibility for changes > made after they were sent or for other risks which arise as a result of > e-mail transmission, viruses, etc. > > > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > GeoTools-Devel mailing list > GeoTools-Devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Looking into contrast enhancement bug for mulit-band rasters
I found that it worked in GeoServer 2.6.5 which is using GeoTools 12.5. It's not working to well using openlayers (which might be expected in this version?), however using Normalize in other wms request formats, PNG, JPEG etc. are working as expected. From what I recall it was failing all the way back to 2.7 when you were helping me look into it. On Thu, Nov 9, 2017 at 12:55 PM, Devon Tucker <dtuc...@boundlessgeo.com> wrote: > John, which version of GeoServer does this work in? > > I looked into this a bit as well. I *believe* that the root issue is an > ArrayIndexOutOfBounds exception inside the IHSColorSpace conversion, which > occurs using either JAI or JAIEXT. > > https://gist.github.com/dvntucker/b5198a7f7143c234a0613e03bb2970d3 > > I get the same exception in the JAIEXT version of IHSColorSpace as well. > This class is reading is reading past the raster bounds, which leads me to > believe there is something wrong with the Image Layout when doing the IHS > conversion. > > One thing I did notice is that ContrastEnhancementNode is re-using the > same Hints over and over again, calling ImageWorker.setHints before every > operation: > > https://github.com/geotools/geotools/blob/master/modules/ > library/render/src/main/java/org/geotools/renderer/lite/gridcoverage2d/ > ContrastEnhancementNode.java > > I'm not totally sure this is the correct way to use ImageWorker? As I > understand it from looking at the code, ImageWorker updates its own Hints > after each call in order to track the updated image layout. I _think_ > calling setRenderingHints each time might be causing issues? However, when > I tried to remove all these calls it didn't seem to fix the issue, so I > don't know for sure. > > It's also possible that the issue is simply a bug in the IHSColorSpace > conversion. Possibly a simple off by one error? I didn't look too closely > at the code to discern whether there might be an issue here. The bug is > replicated in both the Java and EXT versions, so I assumed not, but it's > worth looking at. > > On Thu, Nov 9, 2017 at 8:04 AM, John Schulz <jsch...@boundlessgeo.com> > wrote: > >> Hi Daniele, and all, >> >> I'm looking into an issue involving a contrast enhancement bug for 3 and >> 4 band rasters found here: https://osgeo-org.atlassian.ne >> t/browse/GEOT-5860 >> >> In tracking down the bug it appears to be a regression. I think that the >> issue stems from the IHS colorspace conversion section of the >> ContrastEnhancementNode, where the parameters of the image and the raster, >> at the very least, appear to get out of synch. >> >> I'm just looking to start a conversation as I get more familiar with >> issue and hoping to get some insight into when this regression came along. >> >> Cheers, >> >> John >> >> >> -- >> Check out the vibrant tech community on one of the world's most >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> ___ >> GeoTools-Devel mailing list >> GeoTools-Devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geotools-devel >> >> > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Looking into contrast enhancement bug for mulit-band rasters
Hi Daniele, and all, I'm looking into an issue involving a contrast enhancement bug for 3 and 4 band rasters found here: https://osgeo-org.atlassian.net/browse/GEOT-5860 In tracking down the bug it appears to be a regression. I think that the issue stems from the IHS colorspace conversion section of the ContrastEnhancementNode, where the parameters of the image and the raster, at the very least, appear to get out of synch. I'm just looking to start a conversation as I get more familiar with issue and hoping to get some insight into when this regression came along. Cheers, John -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Hue Rotate for Rasters
Simone, I've gone with the approach to right now implement this as a rendering transformation. I took this approach because it is less invasive than the other approaches and the operation can easily used as a raster process and SLD. Let me know if you have any concerns. Thanks, John Schulz On Thu, Aug 3, 2017 at 8:18 AM, Simone Giannecchini < simone.giannecch...@geo-solutions.it> wrote: > Chiming in late. > > My suggestions would be as follows: > - implement the operation in the ImageWorker. Most/All the logic > should stay here. > - Add a new contrast enhancement > > Adding a rendering transformation later on for whatever reason would > be very easy. > > That said, if you want to have full performance you might have to go > down to implement the operation directly in JAI/JAI-Ext rather than > combining various JAI operations; however, this is another story.. > > Regards, > Simone Giannecchini > == > GeoServer Professional Services from the experts! > Visit http://goo.gl/it488V for more information. > == > Ing. Simone Giannecchini > @simogeo > Founder/Director > > GeoSolutions S.A.S. > Via di Montramito 3/A > 55054 Massarosa (LU) > Italy > phone: +39 0584 962313 > fax: +39 0584 1660272 > mob: +39 333 8128928 > > http://www.geo-solutions.it > http://twitter.com/geosolutions_it > > --- > AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 > Le informazioni contenute in questo messaggio di posta elettronica e/o > nel/i file/s allegato/i sono da considerarsi strettamente riservate. > Il loro utilizzo è consentito esclusivamente al destinatario del > messaggio, per le finalità indicate nel messaggio stesso. Qualora > riceviate questo messaggio senza esserne il destinatario, Vi preghiamo > cortesemente di darcene notizia via e-mail e di procedere alla > distruzione del messaggio stesso, cancellandolo dal Vostro sistema. > Conservare il messaggio stesso, divulgarlo anche in parte, > distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità > diverse, costituisce comportamento contrario ai principi dettati dal > D.Lgs. 196/2003. > > The information in this message and/or attachments, is intended solely > for the attention and use of the named addressee(s) and may be > confidential or proprietary in nature or covered by the provisions of > privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New > Data Protection Code).Any use not in accord with its purpose, any > disclosure, reproduction, copying, distribution, or either > dissemination, either whole or partial, is strictly forbidden except > previous formal approval of the named addressee(s). If you are not the > intended recipient, please contact immediately the sender by > telephone, fax or e-mail and delete the information in this message > that has been received in error. The sender does not give any warranty > or accept liability as the content, accuracy or completeness of sent > messages and accepts no responsibility for changes made after they > were sent or for other risks which arise as a result of e-mail > transmission, viruses, etc. > > > On Thu, Jul 20, 2017 at 7:10 PM, Torben Barsballe > <tbarsba...@boundlessgeo.com> wrote: > > > > > > On Thu, Jul 20, 2017 at 12:06 AM, Ian Turton <ijtur...@gmail.com> wrote: > >> > >> I think that how you expose this to the user depends on what you or they > >> think the process is going to be used for. > >> > >> I lean towards the rendering transformation as I see it as a process to > >> transform a raster into another one rather than an enhancement of the > >> raster. But I'm not a raster expert and I've never come across this > type of > >> transformation before. > >> > > > > To provide a bit of an alternate viewpoint, in the places I have seen > > hue-rotate used it has been the same type of operation as > > brightness/contrast or changing the saturation. This has generally not > been > > in a GeoSpatial context however, just general image transformations. > > > > Given that we are using a ContrastEnhancement for brightness / contrast, > I > > could completely understand using a similar Color Enhancement for hue > > rotate. > > > > That said, I'm sure a rendering transform would be fine too. > > > > Torben > > > > > > > -- > > Check out the vibrant tech community on one of the world's most > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > ___ >
[Geotools-devel] [JIRA] (GEOT-5786) Create functionality for Hue Rotate for rasters
Title: Message Title John Schulz created an issue GeoTools / GEOT-5786 Create functionality for Hue Rotate for rasters Issue Type: Improvement Assignee: John Schulz Created: 20/Jul/17 3:26 PM Priority: Medium Reporter: John Schulz Copied from email list conversation: To all, I am wanting to move forward with creating a proposal for an implementation to extend functionality for HueRotate and Saturation for rasters. As stated by Torben the basic idea would be to take an image and convert it to the HSV or HSL color space and rotate the hue of each pixel by the same degree across the entire image, keeping the relative appearance in tact. A good example can be found here: http://crawlingrobotfortress.blogspot.ca/2013/06/optimizing-hue-rotation-operator.html In this discussion I believe there are two feasible approaches and was looking for any additional input in deciding the best way to move forward with the proposal. 1. Create a new rendering transformation option. This approach would be considered a raster-to-raster transformation and would require creating and executing a new process and operation/function and extending its use to the SLD. 2. Create a new normalization process for colors similar to the Contrast Enhancement normalization, extending the RasterSymbolizer elements. I feel that this option could be implemented in a couple of different ways as well. a. Extend the algorithm vendor option to include HueRotate and Saturation algorithms for Normalize within Contrast Enhancement. b. Create a new SLD element "ColorEnhancement" to follow in a similar fashion as Contrast Enhancement and the Normalize, but specifically altering the colorspace. Any additional thoughts would be appreciated, Th
Re: [Geotools-devel] Hue Rotate for Rasters
To all, I am wanting to move forward with creating a proposal for an implementation to extend functionality for HueRotate and Saturation for rasters. As stated by Torben the basic idea would be to take an image and convert it to the HSV or HSL <https://en.wikipedia.org/wiki/HSL_and_HSV> color space and rotate the hue of each pixel by the same degree across the entire image, keeping the relative appearance in tact. A good example can be found here: http://crawlingrobotfortress.blogspot.ca/2013/06/optimizing-hue-rotation-operator.html In this discussion I believe there are two feasible approaches and was looking for any additional input in deciding the best way to move forward with the proposal. 1. Create a new rendering transformation <http://docs.geoserver.org/stable/en/user/styling/sld/extensions/rendering-transform.html> option. This approach would be considered a raster-to-raster transformation and would require creating and executing a new process and operation/function and extending its use to the SLD. 2. Create a new normalization process for colors similar to the Contrast Enhancement <http://docs.geoserver.org/latest/en/user/styling/sld/reference/rastersymbolizer.html#contrastenhancement> normalization, extending the RasterSymbolizer elements. I feel that this option could be implemented in a couple of different ways as well. a. Extend the algorithm vendor option to include HueRotate and Saturation algorithms for Normalize within Contrast Enhancement. b. Create a new SLD element "ColorEnhancement" to follow in a similar fashion as Contrast Enhancement and the Normalize, but specifically altering the colorspace. Any additional thoughts would be appreciated, Thanks, John On Fri, Jul 14, 2017 at 5:49 PM, Torben Barsballe < tbarsba...@boundlessgeo.com> wrote: > Hi Ian, > > Here are a couple of references that deal with implementing Hue-Rotate: > > https://beesbuzz.biz/code/hsv_color_transforms.php > http://crawlingrobotfortress.blogspot.ca/2013/06/optimizing-hue-rotation- > operator.html > > The basic idea is you have an image in the HSV > <https://en.wikipedia.org/wiki/HSL_and_HSV> colour space, and you change > the increment the Hue of each pixel by some amount. This has the effect of > "rotating" the hue of the image as a whole. > > It is a fairly common transform in most graphical programs (like GIMP or > Photoshop). > > Torben > > On Fri, Jul 14, 2017 at 1:59 PM, Jody Garnett <jody.garn...@gmail.com> > wrote: > >> Thanks for the correction Andrea, this would be a raster-to-raster >> rendering transform, or a new normalization algorithm. >> >> Ian - Hue rotate is used when an image has been produced with >> complementary colours (in a colour wheel sense). If you can image spinning >> the color wheel while leaving the everything in the same relative position. >> It is used in video games for example to reuse graphic assets. Torben had a >> good reference if we ask him. >> >> >> >> >> -- >> Jody Garnett >> >> On 14 July 2017 at 13:18, Andrea Aime <andrea.a...@geo-solutions.it> >> wrote: >> >>> Ian, >>> Jody is calling them geometry transformations, but he really means >>> rendering transformations (geometry transformation >>> is the act of applying a function inside the geometry tag for the >>> current vector feature, has nothing to do with rasters): >>> >>> http://docs.geoserver.org/stable/en/user/styling/sld/extensi >>> ons/geometry-transformations.html >>> http://docs.geoserver.org/stable/en/user/styling/sld/extensi >>> ons/rendering-transform.html >>> >>> Cheers >>> Andrea >>> >>> On Fri, Jul 14, 2017 at 9:25 PM, Ian Turton <ijtur...@gmail.com> wrote: >>> >>>> Could you please expand on what hue rotate does? I'm not sure if I >>>> understand it well enough to decide if it is an image operation or a >>>> geometry operation. >>>> >>>> Ian >>>> >>>> On 14 Jul 2017 18:15, "Jody Garnett" <jody.garn...@gmail.com> wrote: >>>> >>>> ShadedRelief was the only other thing I could think of, in SLD spec >>>> directly. >>>> >>>> We also have our geoserver specific extension for geometry >>>> transformations. We have to ask someone here if that can be used to >>>> introduce the colorSpace operation >>>> <http://iihm.imag.fr/Docs/java/jai1_0guide/Color.doc.html#51551> to >>>> HSV and then a bandcombine operation >>>> <http://iihm.imag.fr/Docs/java/jai1_0guide/Color.doc.html#51591>
Re: [Geotools-devel] Hue Rotate for Rasters
I meant to say: "which would entail a new element in the *RasterSymbolizer*" On Fri, Jul 14, 2017 at 11:04 AM, John Schulz <jsch...@boundlessgeo.com> wrote: > I looking through what additional functionality I am looking for, I think > it might be appropriate to add in a ColorEnhancement element of sorts, to > include algorithms for HueRotate and Saturation. I seems like a lot of my > work would overlap with what is already in ContrastEnhancement and not sure > how the additional efforts would payout. > > @Jody - you did mention that it might be better to implement in a similar > fashion of ShadedRelief, which would entail a new element in the > RasterLayer anyway - thoughts? > > John Schulz > > On Fri, Jul 14, 2017 at 9:17 AM, Jody Garnett <jody.garn...@gmail.com> > wrote: > >> Ian with respect to exposing new methods to the SLD, do you think Hue >> Rotate could be added as a new Color Normalization algorithm? >> >> The only other example I could think of would be as a geometry >> transformation, both options kind of make sense so I was not sure what to >> recommend. >> >> -- >> Jody Garnett >> >> On 14 July 2017 at 00:47, Ian Turton <ijtur...@gmail.com> wrote: >> >>> Hi John, >>> >>> I'm not sure I'm necessarily the right person to ask about this as all I >>> did was expose the new methods to the SLD so that people could make use of >>> the new functionality. The actual code to make changes to the raster was >>> writen long before I was there - https://github.com/geotools/ >>> geotools/blame/master/modules/library/render/src/main/java/o >>> rg/geotools/renderer/lite/gridcoverage2d/ContrastEnhancementNode.java >>> >>> Hope that helps, if not feel free to continue to ask questions on this >>> list. Though I warn you a lot of us are travelling this week for FOSS4GE >>> and then building up to FOSS4G so there may be delays in responding. >>> >>> Ian >>> >>> On 12 July 2017 at 19:29, John Schulz <jsch...@boundlessgeo.com> wrote: >>> >>>> Greeting Ian, >>>> >>>> I'm working on creating a hue rotate option for rasters processed in >>>> Geotools and with speaking with my team have come across your work with >>>> ContrastEnhancement and was hoping to get some insight into working with >>>> the normalization process and how it might be used in my endeavors. >>>> >>>> I look forward to hearing back on your thoughts. >>>> >>>> Cheers, >>>> >>>> John >>>> >>> >>> >>> >>> -- >>> Ian Turton >>> >>> >>> -- >>> Check out the vibrant tech community on one of the world's most >>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >>> ___ >>> GeoTools-Devel mailing list >>> GeoTools-Devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>> >>> >> > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
Re: [Geotools-devel] Hue Rotate for Rasters
I looking through what additional functionality I am looking for, I think it might be appropriate to add in a ColorEnhancement element of sorts, to include algorithms for HueRotate and Saturation. I seems like a lot of my work would overlap with what is already in ContrastEnhancement and not sure how the additional efforts would payout. @Jody - you did mention that it might be better to implement in a similar fashion of ShadedRelief, which would entail a new element in the RasterLayer anyway - thoughts? John Schulz On Fri, Jul 14, 2017 at 9:17 AM, Jody Garnett <jody.garn...@gmail.com> wrote: > Ian with respect to exposing new methods to the SLD, do you think Hue > Rotate could be added as a new Color Normalization algorithm? > > The only other example I could think of would be as a geometry > transformation, both options kind of make sense so I was not sure what to > recommend. > > -- > Jody Garnett > > On 14 July 2017 at 00:47, Ian Turton <ijtur...@gmail.com> wrote: > >> Hi John, >> >> I'm not sure I'm necessarily the right person to ask about this as all I >> did was expose the new methods to the SLD so that people could make use of >> the new functionality. The actual code to make changes to the raster was >> writen long before I was there - https://github.com/geotools/ >> geotools/blame/master/modules/library/render/src/main/java/o >> rg/geotools/renderer/lite/gridcoverage2d/ContrastEnhancementNode.java >> >> Hope that helps, if not feel free to continue to ask questions on this >> list. Though I warn you a lot of us are travelling this week for FOSS4GE >> and then building up to FOSS4G so there may be delays in responding. >> >> Ian >> >> On 12 July 2017 at 19:29, John Schulz <jsch...@boundlessgeo.com> wrote: >> >>> Greeting Ian, >>> >>> I'm working on creating a hue rotate option for rasters processed in >>> Geotools and with speaking with my team have come across your work with >>> ContrastEnhancement and was hoping to get some insight into working with >>> the normalization process and how it might be used in my endeavors. >>> >>> I look forward to hearing back on your thoughts. >>> >>> Cheers, >>> >>> John >>> >> >> >> >> -- >> Ian Turton >> >> >> -- >> Check out the vibrant tech community on one of the world's most >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> ___ >> GeoTools-Devel mailing list >> GeoTools-Devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geotools-devel >> >> > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Hue Rotate for Rasters
Greeting Ian, I'm working on creating a hue rotate option for rasters processed in Geotools and with speaking with my team have come across your work with ContrastEnhancement and was hoping to get some insight into working with the normalization process and how it might be used in my endeavors. I look forward to hearing back on your thoughts. Cheers, John -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
[Geotools-devel] Introduction
Hi all, My name is John Schulz and I'm a new apprentice developer at Boundless, and I am working with Dave Vick. I've met some of you already and look forward to working with you all. I was hoping to be set up on the JIRA development team so I can get some experience with the bug stomp tomorrow. Cheers! -- John Schulz -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
