Re: [Geotools-devel] Google formatting, a second look

2018-03-20 Thread Eric Engle via GeoTools-Devel 
Cool, thanks guys, happy (re)formatting ;0


On Tue, Mar 20, 2018 at 10:10 AM Andrea Aime 
wrote:

> Hi Eric,
> we discussed it at today's PSC meeting, I'm going to propose the 4 spaced
> one (for official vote), the bulk of the
> core devs are used to it, and for a very long time.
>
> Cheers
> Andrea
>
>
> On Mon, Mar 19, 2018 at 5:41 PM, Eric Engle  wrote:
>
>> Just my $.02, as a long-time lurker who would love to simplify
>> contributions as much as possible: I use 2 space indentation in my day job,
>> and contributing some of that work upstream to you is certainly simpler if
>> that also uses two spaces ;-]
>>
>> Best regards,
>>
>> Eric
>>
>>
>> On Sun, Mar 18, 2018 at 3:22 AM Ian Turton  wrote:
>>
>>>
>>>
>>> On 18 March 2018 at 09:49, Andrea Aime 
>>> wrote:
>>>
 Hi,
 given the issues on the intellij + checkstyle approach I had a second
 look at the google variant
 and cleaned up the branch to have a good separation of pom changes and
 reformats:

 https://github.com/aaime/geotools/tree/intellij_checkstyle2

 Indeed, it took 3 runs to get to a stable formatting, you can see them
 as separate commits and check
 the changes occurred in each:
 https://github.com/aaime/geotools/tree/google_format

 Looking at the code, I'm suffering from mild nausea... that said, the
 same happened when I switched
 from Eclipse to IntelliJ a few months ago, was sick for a week but then
 it went away.


>>> From the quick look I've had it isn't too bad, I quite like 2 spaces per
>>> tab (I used it for local projects for a while).
>>>
>>> TBH I'm less concerned about what it looks like and more concerned that
>>> it is maintainable going forward.
>>>
>>>
>>> Thanks for experimenting with this.
>>>
>>>
>>> Ian
>>>
>>>
>>> --
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>> ___
>>> GeoTools-Devel mailing list
>>> GeoTools-Devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>>
>>
>
>
> --
>
> Regards,
>
> Andrea Aime
>
> ==
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via di Montramito 3/A
> 55054  Massarosa (LU)
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39  339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
>
> Le informazioni contenute in questo messaggio di posta elettronica e/o
> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
> darcene notizia via e-mail e di procedere alla distruzione del messaggio
> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
> principi dettati dal D.Lgs. 196/2003.
>
> The information in this message and/or attachments, is intended solely for
> the attention and use of the named addressee(s) and may be confidential or
> proprietary in nature or covered by the provisions of privacy act
> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
> Code).Any use not in accord with its purpose, any disclosure, reproduction,
> copying, distribution, or either dissemination, either whole or partial, is
> strictly forbidden except previous formal approval of the named
> addressee(s). If you are not the intended recipient, please contact
> immediately the sender by telephone, fax or e-mail and delete the
> information in this message that has been received in error. The sender
> does not give any warranty or accept liability as the content, accuracy or
> completeness of sent messages and accepts no responsibility  for changes
> made after they were sent or for other risks which arise as a result of
> e-mail transmission, viruses, etc.
>
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] Google formatting, a second look

2018-03-20 Thread Andrea Aime 
Hi Eric,
we discussed it at today's PSC meeting, I'm going to propose the 4 spaced
one (for official vote), the bulk of the
core devs are used to it, and for a very long time.

Cheers
Andrea


On Mon, Mar 19, 2018 at 5:41 PM, Eric Engle  wrote:

> Just my $.02, as a long-time lurker who would love to simplify
> contributions as much as possible: I use 2 space indentation in my day job,
> and contributing some of that work upstream to you is certainly simpler if
> that also uses two spaces ;-]
>
> Best regards,
>
> Eric
>
>
> On Sun, Mar 18, 2018 at 3:22 AM Ian Turton  wrote:
>
>>
>>
>> On 18 March 2018 at 09:49, Andrea Aime 
>> wrote:
>>
>>> Hi,
>>> given the issues on the intellij + checkstyle approach I had a second
>>> look at the google variant
>>> and cleaned up the branch to have a good separation of pom changes and
>>> reformats:
>>>
>>> https://github.com/aaime/geotools/tree/intellij_checkstyle2
>>>
>>> Indeed, it took 3 runs to get to a stable formatting, you can see them
>>> as separate commits and check
>>> the changes occurred in each:
>>> https://github.com/aaime/geotools/tree/google_format
>>>
>>> Looking at the code, I'm suffering from mild nausea... that said, the
>>> same happened when I switched
>>> from Eclipse to IntelliJ a few months ago, was sick for a week but then
>>> it went away.
>>>
>>>
>> From the quick look I've had it isn't too bad, I quite like 2 spaces per
>> tab (I used it for local projects for a while).
>>
>> TBH I'm less concerned about what it looks like and more concerned that
>> it is maintainable going forward.
>>
>>
>> Thanks for experimenting with this.
>>
>>
>> Ian
>>
>> 
>> --
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot__
>> _
>> GeoTools-Devel mailing list
>> GeoTools-Devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
>


-- 

Regards,

Andrea Aime

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39  339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility  for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] Google formatting, a second look

2018-03-20 Thread Andrea Aime 
On Tue, Mar 20, 2018 at 10:27 AM, Nuno Oliveira <
nuno.olive...@geo-solutions.it> wrote:

> Hi all,
>
> Indeed the 4 spaces tab is better and I can live with the other changes,
> I doubt we will ever found a format that will make everyone happy :P
>

Yes indeed, we just need to find something that will not make people run
away screaming :-)


>
> So in practice:
>
>1. we would run this once
>2. then run a check for each build
>3. developers will have two ways of applying this style:
>   1. using maven
>
> I'm not so sure about this. Using maven would do another wholesale
reformat, and might do more changes
that the files just edited. What I'm trying to say is, the checker might be
not complaining for something
the reformatter would change anyways. It's less likely when using the same
tool for both reformat
and check, but still a possibility. It's pretty much guaranteed to happen
instead if we were to go
for intellij command line format + checkstyle.


>
>1. or using a plugin \ style in the IDE https://github.com/google/
>   google-java-format
>
>
Yep, this is how I'd think it should be used. Or even manually really, as
long as the checker does not
complain during the build we're good imho.

Cheers
Andrea

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39  339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility  for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] Google formatting, a second look

2018-03-20 Thread Andrea Aime 
On Tue, Mar 20, 2018 at 10:27 AM, Nuno Oliveira <
nuno.olive...@geo-solutions.it> wrote:

> Hi all,
>
> Indeed the 4 spaces tab is better and I can live with the other changes,
> I doubt we will ever found a format that will make everyone happy :P
>

Yes indeed, we just need to find something that will not make people run
away screaming :-)


>
> So in practice:
>
>1. we would run this once
>2. then run a check for each build
>3. developers will have two ways of applying this style:
>   1. using maven
>
> I'm not so sure about this. Using maven would do another wholesale
reformat, and might do more changes
that the files just edited. What I'm trying to say is, the checker might be
not complaining for something
the reformatter would change anyways. It's less likely when using the same
tool for both reformat
and check, but still a possibility. It's pretty much guaranteed to happen
instead if we were to go
for intellij command line format + checkstyle.


>
>1. or using a plugin \ style in the IDE https://github.com/google/
>   google-java-format
>
>
Yep, this is how I'd think it should be used. Or even manually really, as
long as the checker does not
complain during the build we're good imho.

Cheers
Andrea

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39  339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility  for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] Google formatting, a second look

2018-03-20 Thread Nuno Oliveira 

Hi all,

Indeed the 4 spaces tab is better and I can live with the other changes,
I doubt we will ever found a format that will make everyone happy :P

So in practice:

1. we would run this once
2. then run a check for each build
3. developers will have two ways of applying this style:
1. using maven
2. or using a plugin \ style in the IDE 
https://github.com/google/google-java-format

+1 for this one.

Thanks for the investigation Andrea.

On 03/18/2018 10:12 AM, Andrea Aime wrote:

Hi all,
interesting news, the formatter has basically a single format style option that 
I did overlook
before, choosing between google style and AOSP one, Android Open Source Project.

Checking the google formatter source code, I found just one significant 
difference between the two...
AOSP uses 4 spaces indent!
(reference, 
https://github.com/google/google-java-format/blob/master/core/src/main/java/com/google/googlejavaformat/java/JavaFormatterOptions.java)


I've setup a different branch using it, so that people can have a look:
https://github.com/aaime/geotools/tree/aosp_format

This kind of look like a winner to me, if we can accept the non full 
idempotency issue.
Personally it's not a deal breaker, as I don't think we should reformat automatically at each 
commit, but just do it once, and then run a check on each build.


Cheers
Andrea



On Sun, Mar 18, 2018 at 10:49 AM, Andrea Aime > wrote:


Hi,
given the issues on the intellij + checkstyle approach I had a second look 
at the google variant
and cleaned up the branch to have a good separation of pom changes and 
reformats:

https://github.com/aaime/geotools/tree/intellij_checkstyle2


Indeed, it took 3 runs to get to a stable formatting, you can see them as 
separate commits and
check
the changes occurred in each:
https://github.com/aaime/geotools/tree/google_format


Looking at the code, I'm suffering from mild nausea... that said, the same 
happened when I
switched
from Eclipse to IntelliJ a few months ago, was sick for a week but then it 
went away.

Cheers
Andrea
==

GeoServer Professional Services from the experts! Visit 
http://goo.gl/it488V for more
information.==Ing. Andrea Aime @geowolfTechnical LeadGeoSolutions S.A.S.Via 
di Montramito
3/A55054  Massarosa (LU)phone: +39 0584 962313 
fax: +39 0584 1660272
mob: +39  339 8844549

http://www.geo-solutions.ithttp://twitter.com/geosolutions_it


AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o 
nel/i file/s allegato/i
sono da considerarsi strettamente riservate. Il loro utilizzo è consentito 
esclusivamente al
destinatario del messaggio, per le finalità indicate nel messaggio stesso. 
Qualora riceviate
questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente 
di darcene notizia
via e-mail e di procedere alla distruzione del messaggio stesso, 
cancellandolo dal Vostro
sistema. Conservare il messaggio stesso, divulgarlo anche in parte, 
distribuirlo ad altri
soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce 
comportamento contrario
ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for 
the attention and
use of the named addressee(s) and may be confidential or proprietary in 
nature or covered by
the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - 
Italy's New Data
Protection Code).Any use not in accord with its purpose, any disclosure, 
reproduction,
copying, distribution, or either dissemination, either whole or partial, is 
strictly forbidden
except previous formal approval of the named addressee(s). If you are not 
the intended
recipient, please contact immediately the sender by telephone, fax or 
e-mail and delete the
information in this message that has been received in error. The sender 
does not give any
warranty or accept liability as the content, accuracy or completeness of 
sent messages and
accepts no responsibility  for changes made after they were sent or for 
other risks which
arise as a result of e-mail transmission, viruses, etc.




--

Regards,

Andrea Aime

==GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more 
information.==Ing. Andrea Aime @geowolfTechnical LeadGeoSolutions S.A.S.Via di Montramito 3/A55054 
 Massarosa (LU)phone: +39 0584 962313fax: +39 0584 1660272mob: +39  339 
8844549http://www.geo-solutions.ithttp://twitter.com/geosolutions_it


AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni

Re: [Geotools-devel] Google formatting, a second look

2018-03-19 Thread Eric Engle via GeoTools-Devel 
Just my $.02, as a long-time lurker who would love to simplify
contributions as much as possible: I use 2 space indentation in my day job,
and contributing some of that work upstream to you is certainly simpler if
that also uses two spaces ;-]

Best regards,

Eric


On Sun, Mar 18, 2018 at 3:22 AM Ian Turton  wrote:

>
>
> On 18 March 2018 at 09:49, Andrea Aime 
> wrote:
>
>> Hi,
>> given the issues on the intellij + checkstyle approach I had a second
>> look at the google variant
>> and cleaned up the branch to have a good separation of pom changes and
>> reformats:
>>
>> https://github.com/aaime/geotools/tree/intellij_checkstyle2
>>
>> Indeed, it took 3 runs to get to a stable formatting, you can see them as
>> separate commits and check
>> the changes occurred in each:
>> https://github.com/aaime/geotools/tree/google_format
>>
>> Looking at the code, I'm suffering from mild nausea... that said, the
>> same happened when I switched
>> from Eclipse to IntelliJ a few months ago, was sick for a week but then
>> it went away.
>>
>>
> From the quick look I've had it isn't too bad, I quite like 2 spaces per
> tab (I used it for local projects for a while).
>
> TBH I'm less concerned about what it looks like and more concerned that it
> is maintainable going forward.
>
>
> Thanks for experimenting with this.
>
>
> Ian
>
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> GeoTools-Devel mailing list
> GeoTools-Devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] Google formatting, a second look

2018-03-18 Thread Ian Turton 
On 18 March 2018 at 09:49, Andrea Aime  wrote:

> Hi,
> given the issues on the intellij + checkstyle approach I had a second look
> at the google variant
> and cleaned up the branch to have a good separation of pom changes and
> reformats:
>
> https://github.com/aaime/geotools/tree/intellij_checkstyle2
>
> Indeed, it took 3 runs to get to a stable formatting, you can see them as
> separate commits and check
> the changes occurred in each:
> https://github.com/aaime/geotools/tree/google_format
>
> Looking at the code, I'm suffering from mild nausea... that said, the same
> happened when I switched
> from Eclipse to IntelliJ a few months ago, was sick for a week but then it
> went away.
>
>
>From the quick look I've had it isn't too bad, I quite like 2 spaces per
tab (I used it for local projects for a while).

TBH I'm less concerned about what it looks like and more concerned that it
is maintainable going forward.


Thanks for experimenting with this.


Ian
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] Google formatting, a second look

2018-03-18 Thread Andrea Aime 
Hi all,
interesting news, the formatter has basically a single format style option
that I did overlook
before, choosing between google style and AOSP one, Android Open Source
Project.

Checking the google formatter source code, I found just one significant
difference between the two...
AOSP uses 4 spaces indent!
(reference,
https://github.com/google/google-java-format/blob/master/core/src/main/java/com/google/googlejavaformat/java/JavaFormatterOptions.java
)

I've setup a different branch using it, so that people can have a look:
https://github.com/aaime/geotools/tree/aosp_format

This kind of look like a winner to me, if we can accept the non full
idempotency issue.
Personally it's not a deal breaker, as I don't think we should reformat
automatically at each commit, but just do it once, and then run a check on
each build.

Cheers
Andrea



On Sun, Mar 18, 2018 at 10:49 AM, Andrea Aime 
wrote:

> Hi,
> given the issues on the intellij + checkstyle approach I had a second look
> at the google variant
> and cleaned up the branch to have a good separation of pom changes and
> reformats:
>
> https://github.com/aaime/geotools/tree/intellij_checkstyle2
>
> Indeed, it took 3 runs to get to a stable formatting, you can see them as
> separate commits and check
> the changes occurred in each:
> https://github.com/aaime/geotools/tree/google_format
>
> Looking at the code, I'm suffering from mild nausea... that said, the same
> happened when I switched
> from Eclipse to IntelliJ a few months ago, was sick for a week but then it
> went away.
>
> Cheers
> Andrea
>
> ==
>
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via di Montramito 3/A
> 55054  Massarosa (LU)
> phone: +39 0584 962313 <+39%200584%20962313>
> fax: +39 0584 1660272 <+39%200584%20166%200272>
> mob: +39  339 8844549 <+39%20339%20884%204549>
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
>
> Le informazioni contenute in questo messaggio di posta elettronica e/o
> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
> darcene notizia via e-mail e di procedere alla distruzione del messaggio
> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
> principi dettati dal D.Lgs. 196/2003.
>
> The information in this message and/or attachments, is intended solely for
> the attention and use of the named addressee(s) and may be confidential or
> proprietary in nature or covered by the provisions of privacy act
> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
> Code).Any use not in accord with its purpose, any disclosure, reproduction,
> copying, distribution, or either dissemination, either whole or partial, is
> strictly forbidden except previous formal approval of the named
> addressee(s). If you are not the intended recipient, please contact
> immediately the sender by telephone, fax or e-mail and delete the
> information in this message that has been received in error. The sender
> does not give any warranty or accept liability as the content, accuracy or
> completeness of sent messages and accepts no responsibility  for changes
> made after they were sent or for other risks which arise as a result of
> e-mail transmission, viruses, etc.
>
>


-- 

Regards,

Andrea Aime

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39  339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the

[Geotools-devel] Google formatting, a second look

2018-03-18 Thread Andrea Aime 
Hi,
given the issues on the intellij + checkstyle approach I had a second look
at the google variant
and cleaned up the branch to have a good separation of pom changes and
reformats:

https://github.com/aaime/geotools/tree/intellij_checkstyle2

Indeed, it took 3 runs to get to a stable formatting, you can see them as
separate commits and check
the changes occurred in each:
https://github.com/aaime/geotools/tree/google_format

Looking at the code, I'm suffering from mild nausea... that said, the same
happened when I switched
from Eclipse to IntelliJ a few months ago, was sick for a week but then it
went away.

Cheers
Andrea

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39  339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility  for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel