[MERGED] osmo-bts[master]: Fix build after recent gsm_bts_alloc() change

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: Fix build after recent gsm_bts_alloc() change
..


Fix build after recent gsm_bts_alloc() change

In openbsc.git Change-Id I61c18a7f021fcb1ec00d34a745f4e3ab03416c2d
we changed the gsm_bts_alloc() function signature to include
a second argument (the BTS number).  This broke omso-bts, and this
commit is intended to make it build again.

Change-Id: I7ef7654d48c1cfc7e4ecb0b771553ec0740ce2bf
---
M src/common/main.c
M tests/agch/agch_test.c
M tests/cipher/cipher_test.c
M tests/handover/handover_test.c
M tests/meas/meas_test.c
M tests/paging/paging_test.c
M tests/tx_power/tx_power_test.c
7 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/src/common/main.c b/src/common/main.c
index 4c51848..6c13663 100644
--- a/src/common/main.c
+++ b/src/common/main.c
@@ -241,7 +241,7 @@
 
handle_options(argc, argv);
 
-   bts = gsm_bts_alloc(tall_bts_ctx);
+   bts = gsm_bts_alloc(tall_bts_ctx, 0);
if (!bts) {
fprintf(stderr, "Failed to create BTS structure\n");
exit(1);
diff --git a/tests/agch/agch_test.c b/tests/agch/agch_test.c
index e275c64..7c4e6cd 100644
--- a/tests/agch/agch_test.c
+++ b/tests/agch/agch_test.c
@@ -229,7 +229,7 @@
 
bts_log_init(NULL);
 
-   bts = gsm_bts_alloc(tall_bts_ctx);
+   bts = gsm_bts_alloc(tall_bts_ctx, 0);
if (bts_init(bts) < 0) {
fprintf(stderr, "unable to open bts\n");
exit(1);
diff --git a/tests/cipher/cipher_test.c b/tests/cipher/cipher_test.c
index c913925..07d9fde 100644
--- a/tests/cipher/cipher_test.c
+++ b/tests/cipher/cipher_test.c
@@ -71,7 +71,7 @@
 
bts_log_init(NULL);
 
-   bts = gsm_bts_alloc(tall_bts_ctx);
+   bts = gsm_bts_alloc(tall_bts_ctx, 0);
if (bts_init(bts) < 0) {
fprintf(stderr, "unable to open bts\n");
exit(1);
diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c
index 611c441..adc4d65 100644
--- a/tests/handover/handover_test.c
+++ b/tests/handover/handover_test.c
@@ -71,7 +71,7 @@
bts_log_init(NULL);
osmo_stderr_target->categories[DHO].loglevel = LOGL_DEBUG;
 
-   bts = gsm_bts_alloc(tall_bts_ctx);
+   bts = gsm_bts_alloc(tall_bts_ctx, 0);
if (!bts) {
fprintf(stderr, "Failed to create BTS structure\n");
exit(1);
diff --git a/tests/meas/meas_test.c b/tests/meas/meas_test.c
index c87350b..6c514ca 100644
--- a/tests/meas/meas_test.c
+++ b/tests/meas/meas_test.c
@@ -97,7 +97,7 @@
bts_log_init(NULL);
osmo_stderr_target->categories[DMEAS].loglevel = LOGL_DEBUG;
 
-   bts = gsm_bts_alloc(tall_bts_ctx);
+   bts = gsm_bts_alloc(tall_bts_ctx, 0);
if (!bts) {
fprintf(stderr, "Failed to create BTS structure\n");
exit(1);
diff --git a/tests/paging/paging_test.c b/tests/paging/paging_test.c
index 1d5f216..2573b3f 100644
--- a/tests/paging/paging_test.c
+++ b/tests/paging/paging_test.c
@@ -117,7 +117,7 @@
 
bts_log_init(NULL);
 
-   bts = gsm_bts_alloc(tall_bts_ctx);
+   bts = gsm_bts_alloc(tall_bts_ctx, 0);
if (bts_init(bts) < 0) {
fprintf(stderr, "unable to open bts\n");
exit(1);
diff --git a/tests/tx_power/tx_power_test.c b/tests/tx_power/tx_power_test.c
index fb23409..a47d186 100644
--- a/tests/tx_power/tx_power_test.c
+++ b/tests/tx_power/tx_power_test.c
@@ -215,7 +215,7 @@
osmo_stderr_target->categories[DL1C].loglevel = LOGL_DEBUG;
log_set_print_filename(osmo_stderr_target, 0);
 
-   bts = gsm_bts_alloc(tall_bts_ctx);
+   bts = gsm_bts_alloc(tall_bts_ctx, 0);
if (!bts) {
fprintf(stderr, "Failed to create BTS structure\n");
exit(1);

-- 
To view, visit https://gerrit.osmocom.org/3511
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7ef7654d48c1cfc7e4ecb0b771553ec0740ce2bf
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

osmo-bts[master]: Fix build after recent gsm_bts_alloc() change

[Harald Welte]

Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.osmocom.org/3511
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ef7654d48c1cfc7e4ecb0b771553ec0740ce2bf
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

osmo-bts[master]: Fix build after recent gsm_bts_alloc() change

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3511
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ef7654d48c1cfc7e4ecb0b771553ec0740ce2bf
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

Build failure of network:osmocom:nightly/osmo-bts in xUbuntu_17.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/xUbuntu_17.04/x86_64

Package network:osmocom:nightly/osmo-bts failed to build in xUbuntu_17.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bts

Last lines of build log:
[   84s]  from main.c:43:
[   84s] ../../include/openbsc/gsm_data_shared.h:903:17: note: declared here
[   84s]  struct gsm_bts *gsm_bts_alloc(void *talloc_ctx, uint8_t bts_num);
[   84s]  ^
[   84s] Makefile:396: recipe for target 'main.o' failed
[   84s] make[4]: *** [main.o] Error 1
[   84s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common'
[   84s] Makefile:346: recipe for target 'all-recursive' failed
[   84s] make[3]: *** [all-recursive] Error 1
[   84s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   84s] Makefile:398: recipe for target 'all-recursive' failed
[   84s] make[2]: *** [all-recursive] Error 1
[   84s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   84s] Makefile:339: recipe for target 'all' failed
[   84s] make[1]: *** [all] Error 2
[   84s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   84s] dh_auto_build: make -j1 returned exit code 2
[   84s] debian/rules:12: recipe for target 'build' failed
[   84s] make: *** [build] Error 2
[   84s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   84s] 
[   84s] lamb06 failed "build osmo-bts_0.5.0.20170814.dsc" at Sun Aug 13 
23:15:13 UTC 2017.
[   84s] 
[   84s] ### VM INTERACTION START ###
[   87s] [   76.058816] reboot: Power down
[   87s] ### VM INTERACTION END ###
[   87s] 
[   87s] lamb06 failed "build osmo-bts_0.5.0.20170814.dsc" at Sun Aug 13 
23:15:17 UTC 2017.
[   87s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bts in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_9.0/i586

Package network:osmocom:nightly/osmo-bts failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bts

Last lines of build log:
[  101s]  from main.c:43:
[  101s] ../../include/openbsc/gsm_data_shared.h:903:17: note: declared here
[  101s]  struct gsm_bts *gsm_bts_alloc(void *talloc_ctx, uint8_t bts_num);
[  101s]  ^
[  101s] Makefile:396: recipe for target 'main.o' failed
[  101s] make[4]: *** [main.o] Error 1
[  101s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common'
[  101s] Makefile:346: recipe for target 'all-recursive' failed
[  101s] make[3]: *** [all-recursive] Error 1
[  101s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  101s] Makefile:398: recipe for target 'all-recursive' failed
[  101s] make[2]: *** [all-recursive] Error 1
[  101s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  101s] Makefile:339: recipe for target 'all' failed
[  101s] make[1]: *** [all] Error 2
[  101s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  101s] dh_auto_build: make -j1 returned exit code 2
[  101s] debian/rules:12: recipe for target 'build' failed
[  101s] make: *** [build] Error 2
[  101s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  101s] 
[  101s] lamb13 failed "build osmo-bts_0.5.0.20170814.dsc" at Sun Aug 13 
23:12:44 UTC 2017.
[  101s] 
[  101s] ### VM INTERACTION START ###
[  104s] [   91.652317] reboot: Power down
[  104s] ### VM INTERACTION END ###
[  104s] 
[  104s] lamb13 failed "build osmo-bts_0.5.0.20170814.dsc" at Sun Aug 13 
23:12:47 UTC 2017.
[  104s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bts in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_9.0/i586

Package network:osmocom:nightly/osmo-bts failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bts

Last lines of build log:
[  101s]  from main.c:43:
[  101s] ../../include/openbsc/gsm_data_shared.h:903:17: note: declared here
[  101s]  struct gsm_bts *gsm_bts_alloc(void *talloc_ctx, uint8_t bts_num);
[  101s]  ^
[  101s] Makefile:396: recipe for target 'main.o' failed
[  101s] make[4]: *** [main.o] Error 1
[  101s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common'
[  101s] Makefile:346: recipe for target 'all-recursive' failed
[  101s] make[3]: *** [all-recursive] Error 1
[  101s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  101s] Makefile:398: recipe for target 'all-recursive' failed
[  101s] make[2]: *** [all-recursive] Error 1
[  101s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  101s] Makefile:339: recipe for target 'all' failed
[  101s] make[1]: *** [all] Error 2
[  101s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  101s] dh_auto_build: make -j1 returned exit code 2
[  101s] debian/rules:12: recipe for target 'build' failed
[  101s] make: *** [build] Error 2
[  101s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  101s] 
[  101s] lamb13 failed "build osmo-bts_0.5.0.20170814.dsc" at Sun Aug 13 
23:12:44 UTC 2017.
[  101s] 
[  101s] ### VM INTERACTION START ###
[  104s] [   91.652317] reboot: Power down
[  104s] ### VM INTERACTION END ###
[  104s] 
[  104s] lamb13 failed "build osmo-bts_0.5.0.20170814.dsc" at Sun Aug 13 
23:12:47 UTC 2017.
[  104s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bts in xUbuntu_16.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/xUbuntu_16.10/x86_64

Package network:osmocom:nightly/osmo-bts failed to build in xUbuntu_16.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bts

Last lines of build log:
[   84s]  from main.c:43:
[   84s] ../../include/openbsc/gsm_data_shared.h:903:17: note: declared here
[   84s]  struct gsm_bts *gsm_bts_alloc(void *talloc_ctx, uint8_t bts_num);
[   84s]  ^
[   84s] Makefile:396: recipe for target 'main.o' failed
[   84s] make[4]: *** [main.o] Error 1
[   84s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common'
[   84s] Makefile:346: recipe for target 'all-recursive' failed
[   84s] make[3]: *** [all-recursive] Error 1
[   84s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   84s] Makefile:398: recipe for target 'all-recursive' failed
[   84s] make[2]: *** [all-recursive] Error 1
[   84s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   84s] Makefile:339: recipe for target 'all' failed
[   84s] make[1]: *** [all] Error 2
[   84s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   84s] dh_auto_build: make -j1 returned exit code 2
[   84s] debian/rules:12: recipe for target 'build' failed
[   84s] make: *** [build] Error 2
[   84s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   84s] 
[   84s] lamb51 failed "build osmo-bts_0.5.0.20170814.dsc" at Sun Aug 13 
23:11:57 UTC 2017.
[   84s] 
[   84s] ### VM INTERACTION START ###
[   87s] [   76.207386] reboot: Power down
[   87s] ### VM INTERACTION END ###
[   87s] 
[   87s] lamb51 failed "build osmo-bts_0.5.0.20170814.dsc" at Sun Aug 13 
23:12:00 UTC 2017.
[   87s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bts in xUbuntu_16.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/xUbuntu_16.10/x86_64

Package network:osmocom:nightly/osmo-bts failed to build in xUbuntu_16.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bts

Last lines of build log:
[   84s]  from main.c:43:
[   84s] ../../include/openbsc/gsm_data_shared.h:903:17: note: declared here
[   84s]  struct gsm_bts *gsm_bts_alloc(void *talloc_ctx, uint8_t bts_num);
[   84s]  ^
[   84s] Makefile:396: recipe for target 'main.o' failed
[   84s] make[4]: *** [main.o] Error 1
[   84s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common'
[   84s] Makefile:346: recipe for target 'all-recursive' failed
[   84s] make[3]: *** [all-recursive] Error 1
[   84s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   84s] Makefile:398: recipe for target 'all-recursive' failed
[   84s] make[2]: *** [all-recursive] Error 1
[   84s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   84s] Makefile:339: recipe for target 'all' failed
[   84s] make[1]: *** [all] Error 2
[   84s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   84s] dh_auto_build: make -j1 returned exit code 2
[   84s] debian/rules:12: recipe for target 'build' failed
[   84s] make: *** [build] Error 2
[   84s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   84s] 
[   84s] lamb51 failed "build osmo-bts_0.5.0.20170814.dsc" at Sun Aug 13 
23:11:57 UTC 2017.
[   84s] 
[   84s] ### VM INTERACTION START ###
[   87s] [   76.207386] reboot: Power down
[   87s] ### VM INTERACTION END ###
[   87s] 
[   87s] lamb51 failed "build osmo-bts_0.5.0.20170814.dsc" at Sun Aug 13 
23:12:00 UTC 2017.
[   87s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bts in xUbuntu_17.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/xUbuntu_17.04/i586

Package network:osmocom:nightly/osmo-bts failed to build in xUbuntu_17.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bts

Last lines of build log:
[   47s]  from main.c:43:
[   47s] ../../include/openbsc/gsm_data_shared.h:903:17: note: declared here
[   47s]  struct gsm_bts *gsm_bts_alloc(void *talloc_ctx, uint8_t bts_num);
[   47s]  ^
[   47s] Makefile:396: recipe for target 'main.o' failed
[   47s] make[4]: *** [main.o] Error 1
[   47s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common'
[   47s] Makefile:346: recipe for target 'all-recursive' failed
[   47s] make[3]: *** [all-recursive] Error 1
[   47s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   47s] Makefile:398: recipe for target 'all-recursive' failed
[   47s] make[2]: *** [all-recursive] Error 1
[   47s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   47s] Makefile:339: recipe for target 'all' failed
[   47s] make[1]: *** [all] Error 2
[   47s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   47s] dh_auto_build: make -j1 returned exit code 2
[   47s] debian/rules:12: recipe for target 'build' failed
[   47s] make: *** [build] Error 2
[   47s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   47s] 
[   47s] build70 failed "build osmo-bts_0.5.0.20170814.dsc" at Sun Aug 13 
23:10:53 UTC 2017.
[   47s] 
[   47s] ### VM INTERACTION START ###
[   50s] [   43.311209] reboot: Power down
[   50s] ### VM INTERACTION END ###
[   50s] 
[   50s] build70 failed "build osmo-bts_0.5.0.20170814.dsc" at Sun Aug 13 
23:10:57 UTC 2017.
[   50s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bts in xUbuntu_17.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/xUbuntu_17.04/i586

Package network:osmocom:nightly/osmo-bts failed to build in xUbuntu_17.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bts

Last lines of build log:
[   47s]  from main.c:43:
[   47s] ../../include/openbsc/gsm_data_shared.h:903:17: note: declared here
[   47s]  struct gsm_bts *gsm_bts_alloc(void *talloc_ctx, uint8_t bts_num);
[   47s]  ^
[   47s] Makefile:396: recipe for target 'main.o' failed
[   47s] make[4]: *** [main.o] Error 1
[   47s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common'
[   47s] Makefile:346: recipe for target 'all-recursive' failed
[   47s] make[3]: *** [all-recursive] Error 1
[   47s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   47s] Makefile:398: recipe for target 'all-recursive' failed
[   47s] make[2]: *** [all-recursive] Error 1
[   47s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   47s] Makefile:339: recipe for target 'all' failed
[   47s] make[1]: *** [all] Error 2
[   47s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   47s] dh_auto_build: make -j1 returned exit code 2
[   47s] debian/rules:12: recipe for target 'build' failed
[   47s] make: *** [build] Error 2
[   47s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   47s] 
[   47s] build70 failed "build osmo-bts_0.5.0.20170814.dsc" at Sun Aug 13 
23:10:53 UTC 2017.
[   47s] 
[   47s] ### VM INTERACTION START ###
[   50s] [   43.311209] reboot: Power down
[   50s] ### VM INTERACTION END ###
[   50s] 
[   50s] build70 failed "build osmo-bts_0.5.0.20170814.dsc" at Sun Aug 13 
23:10:57 UTC 2017.
[   50s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

[MERGED] openbsc[master]: handover_logic: set correct link to bts for subscriber_conne...

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: handover_logic: set correct link to bts for 
subscriber_connection in case of moving this connection to another bts
..


handover_logic: set correct link to bts for subscriber_connection in case of 
moving this connection to another bts

In case of successful completion of handover gsm_subscriber_connection could be 
moved from one bts to another,
so connection link to bts should be replaced by link to bts, which owns 
new_lchan.
This bug was detected, because conn->bts->nr is used in call control log 
messages
and wrong number of bts was observed in these messages after handover.

Change-Id: Idc7dd412b7580c451e716b73ef7549826c60b0d9
---
M openbsc/src/libbsc/handover_logic.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/libbsc/handover_logic.c 
b/openbsc/src/libbsc/handover_logic.c
index 4dd913b..795a2ee 100644
--- a/openbsc/src/libbsc/handover_logic.c
+++ b/openbsc/src/libbsc/handover_logic.c
@@ -281,6 +281,7 @@
 
new_lchan->conn->ho_lchan = NULL;
new_lchan->conn->lchan = new_lchan;
+   new_lchan->conn->bts = new_lchan->ts->trx->bts;
ho->old_lchan->conn = NULL;
 
lchan_release(ho->old_lchan, 0, RSL_REL_LOCAL_END);

-- 
To view, visit https://gerrit.osmocom.org/3466
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idc7dd412b7580c451e716b73ef7549826c60b0d9
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Ivan Kluchnikov 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

openbsc[master]: mgcp_osmux: Remove unused parameter

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3483
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb1e7cb15fe04642578f5292124ebc1eac9c9aa3
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pablo Neira Ayuso 
Gerrit-HasComments: No

[MERGED] openbsc[master]: mgcp_osmux: Remove unused parameter

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: mgcp_osmux: Remove unused parameter
..


mgcp_osmux: Remove unused parameter

Change-Id: Icb1e7cb15fe04642578f5292124ebc1eac9c9aa3
---
M openbsc/include/openbsc/osmux.h
M openbsc/src/libmgcp/mgcp_osmux.c
2 files changed, 4 insertions(+), 8 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified
  Pablo Neira Ayuso: Looks good to me, but someone else must approve



diff --git a/openbsc/include/openbsc/osmux.h b/openbsc/include/openbsc/osmux.h
index 0b64a7f..f3ea72a 100644
--- a/openbsc/include/openbsc/osmux.h
+++ b/openbsc/include/openbsc/osmux.h
@@ -11,8 +11,7 @@
 };
 
 int osmux_init(int role, struct mgcp_config *cfg);
-int osmux_enable_endpoint(struct mgcp_endpoint *endp, int role,
- struct in_addr *addr, uint16_t port);
+int osmux_enable_endpoint(struct mgcp_endpoint *endp, struct in_addr *addr, 
uint16_t port);
 void osmux_disable_endpoint(struct mgcp_endpoint *endp);
 void osmux_allocate_cid(struct mgcp_endpoint *endp);
 void osmux_release_cid(struct mgcp_endpoint *endp);
diff --git a/openbsc/src/libmgcp/mgcp_osmux.c b/openbsc/src/libmgcp/mgcp_osmux.c
index b46a80e..c52984b 100644
--- a/openbsc/src/libmgcp/mgcp_osmux.c
+++ b/openbsc/src/libmgcp/mgcp_osmux.c
@@ -340,8 +340,7 @@
if (endp->osmux.state == OSMUX_STATE_ENABLED)
goto out;
 
-   if (osmux_enable_endpoint(endp, OSMUX_ROLE_BSC_NAT,
- >sin_addr, addr->sin_port) < 0 ){
+   if (osmux_enable_endpoint(endp, >sin_addr, addr->sin_port) < 0 ) {
LOGP(DMGCP, LOGL_ERROR,
 "Could not enable osmux in endpoint %d\n",
 ENDPOINT_NUMBER(endp));
@@ -433,8 +432,7 @@
return 0;
 }
 
-int osmux_enable_endpoint(struct mgcp_endpoint *endp, int role,
- struct in_addr *addr, uint16_t port)
+int osmux_enable_endpoint(struct mgcp_endpoint *endp, struct in_addr *addr, 
uint16_t port)
 {
/* If osmux is enabled, initialize the output handler. This handler is
 * used to reconstruct the RTP flow from osmux. The RTP SSRC is
@@ -522,8 +520,7 @@
return 0;
 
if (endp->osmux.state == OSMUX_STATE_ACTIVATING) {
-   if (osmux_enable_endpoint(endp, OSMUX_ROLE_BSC,
- >net_end.addr,
+   if (osmux_enable_endpoint(endp, >net_end.addr,
  htons(endp->cfg->osmux_port)) < 0) {
LOGP(DMGCP, LOGL_ERROR,
 "Could not activate osmux in endpoint %d\n",

-- 
To view, visit https://gerrit.osmocom.org/3483
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icb1e7cb15fe04642578f5292124ebc1eac9c9aa3
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pablo Neira Ayuso 

osmo-gsm-manuals[master]: osmux: Fix description for Dummy frames FT field

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3478
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia421655bd1be45101da3db2a0af44fbb3cc111c1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pablo Neira Ayuso 
Gerrit-HasComments: No

[MERGED] osmo-gsm-manuals[master]: osmux: Fix description for Dummy frames FT field

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: osmux: Fix description for Dummy frames FT field
..


osmux: Fix description for Dummy frames FT field

Change-Id: Ia421655bd1be45101da3db2a0af44fbb3cc111c1
---
M OsmoBSC/osmux-reference.adoc
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified
  Pablo Neira Ayuso: Looks good to me, but someone else must approve



diff --git a/OsmoBSC/osmux-reference.adoc b/OsmoBSC/osmux-reference.adoc
index 4d03a4b..929f442 100644
--- a/OsmoBSC/osmux-reference.adoc
+++ b/OsmoBSC/osmux-reference.adoc
@@ -159,7 +159,7 @@
 
 
 Field Type (FT): 2 bits::
-The Field Type allocated for LAPD Signalling is "0".
+The Field Type allocated for LAPD Signalling frames is "0".
 
 This frame type is not yet supported inside OsmoCom and may be subject to
 change in future versions of the protocol.
@@ -197,7 +197,7 @@
 talkspurt.
 
 Field Type (FT): 2 bits::
-The Field Type allocated for AMR codec is "1".
+The Field Type allocated for AMR Codec frames is "1".
 
 Frame Counter (CTR): 2 bits::
 Provides the number of batched AMR payloads (starting 0) after the header. For
@@ -284,7 +284,7 @@
 
 
 Field Type (FT): 2 bits::
-The Field Type allocated for AMR codec is "2".
+The Field Type allocated for Dummy frames is "2".
 
 Frame Counter (CTR): 2 bits::
 Provides the number of dummy batched AMR payloads (starting 0) after the 
header.

-- 
To view, visit https://gerrit.osmocom.org/3478
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia421655bd1be45101da3db2a0af44fbb3cc111c1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pablo Neira Ayuso 

[MERGED] libosmo-sccp[master]: sccp: add doxgen comments for osmo_sccp_simple_client()

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: sccp: add doxgen comments for osmo_sccp_simple_client()
..


sccp: add doxgen comments for osmo_sccp_simple_client()

Some of the functons in sccp_user.c have already
doygen comments on them.

Add doxygen comments for the simple client functions as well

Change-Id: I9143bdc54d729f9f50e69fe38cd1798e065f2497
---
M src/sccp_user.c
1 file changed, 32 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/sccp_user.c b/src/sccp_user.c
index 387061c..c0e2b5a 100644
--- a/src/sccp_user.c
+++ b/src/sccp_user.c
@@ -295,6 +295,18 @@
  * Convenience function for CLIENT
  ***/
 
+/*! \brief request an sccp client instance
+ *  \param[in] ctx talloc context
+ *  \param[in] ss7_id of the SS7/CS7 instance
+ *  \param[in] name human readable name
+ *  \param[in] default_pc pointcode to be used on missing VTY setting
+ *  \param[in] prot protocol to be used (e.g OSMO_SS7_ASP_PROT_M3UA)
+ *  \param[in] default_local_port local port to be usd on missing VTY setting
+ *  \param[in] default_local_ip local IP-address to be usd on missing VTY 
setting
+ *  \param[in] default_remote_port remote port to be usd on missing VTY setting
+ *  \param[in] default_remote_ip remote IP-address to be usd on missing VTY 
setting
+ *  \returns callee-allocated SCCP instance on success; NULL on error */
+
 struct osmo_sccp_instance *
 osmo_sccp_simple_client_on_ss7_id(void *ctx, uint32_t ss7_id, const char *name,
  uint32_t default_pc,
@@ -313,6 +325,12 @@
struct osmo_ss7_asp *asp;
bool asp_created = false;
char *as_name, *asp_name = NULL;
+
+   /*! The function will examine the given CS7 instance and its sub
+*  components (as, asp, etc.). If necessary it will allocate
+*  the missing components. If no CS7 instance can be detected
+*  under the caller supplied ID, a new instance will be created
+*  beforehand. */
 
/* Choose default ports when the caller does not supply valid port
 * numbers. */
@@ -450,12 +468,26 @@
return NULL;
 }
 
+/*! \brief request an sccp client instance
+ *  \param[in] ctx talloc context
+ *  \param[in] name human readable name
+ *  \param[in] default_pc pointcode to be used on missing VTY setting
+ *  \param[in] prot protocol to be used (e.g OSMO_SS7_ASP_PROT_M3UA)
+ *  \param[in] default_local_port local port to be usd on missing VTY setting
+ *  \param[in] default_local_ip local IP-address to be usd on missing VTY 
setting
+ *  \param[in] default_remote_port remote port to be usd on missing VTY setting
+ *  \param[in] default_remote_ip remote IP-address to be usd on missing VTY 
setting
+ *  \returns callee-allocated SCCP instance on success; NULL on error */
 struct osmo_sccp_instance *
 osmo_sccp_simple_client(void *ctx, const char *name, uint32_t default_pc,
enum osmo_ss7_asp_protocol prot, int default_local_port,
const char *default_local_ip, int default_remote_port,
const char *default_remote_ip)
 {
+   /*! This is simplified version of osmo_sccp_simple_client_on_ss7_id().
+*  the only difference is that the ID of the CS7 instance will be
+*  set to 1 statically */
+
return osmo_sccp_simple_client_on_ss7_id(ctx, 1, name, default_pc, prot,
 default_local_port,
 default_local_ip,

-- 
To view, visit https://gerrit.osmocom.org/3481
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9143bdc54d729f9f50e69fe38cd1798e065f2497
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

[MERGED] libosmo-sccp[master]: sccp: fix handling of default IP addresses in osmo_sccp_simp...

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: sccp: fix handling of default IP addresses in 
osmo_sccp_simple_client()
..


sccp: fix handling of default IP addresses in osmo_sccp_simple_client()

When the default IP addresses (remote or local) the respective
struct value should be set to NULL.

Fix wrong ?:-notation.

Change-Id: I312caf9d54cedb02034e4ef88fdd2e6ad9ca1c34
---
M src/sccp_user.c
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/sccp_user.c b/src/sccp_user.c
index 9116b60..4e28aa0 100644
--- a/src/sccp_user.c
+++ b/src/sccp_user.c
@@ -404,10 +404,10 @@
goto out_rt;
asp_created = true;
 
-   default_local_ip ? asp->cfg.local.host =
-   talloc_strdup(asp, default_local_ip) : NULL;
-   default_remote_ip ? asp->cfg.remote.host =
-   talloc_strdup(asp, default_remote_ip) : NULL;
+   asp->cfg.local.host =
+   default_local_ip ? asp->cfg.local.host : NULL;
+   asp->cfg.remote.host =
+   default_remote_ip ? asp->cfg.remote.host : NULL;
 
osmo_ss7_as_add_asp(as, asp->cfg.name);
}

-- 
To view, visit https://gerrit.osmocom.org/3479
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I312caf9d54cedb02034e4ef88fdd2e6ad9ca1c34
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

[MERGED] libosmo-sccp[master]: sccp: make osmo_sccp_addr_name() available

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: sccp: make osmo_sccp_addr_name() available
..


sccp: make osmo_sccp_addr_name() available

osmo_sccp_addr_name() is not listed in any header file.

Add osmo_sccp_addr_name() to sccp_helpers.h in order to make
it available.

Change-Id: I092dd55948faeeff78f28f7d50c5b84b9e69ef24
---
M include/osmocom/sigtran/sccp_helpers.h
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/sigtran/sccp_helpers.h 
b/include/osmocom/sigtran/sccp_helpers.h
index 2f318f4..c2175f4 100644
--- a/include/osmocom/sigtran/sccp_helpers.h
+++ b/include/osmocom/sigtran/sccp_helpers.h
@@ -54,3 +54,4 @@
 
 char *osmo_sccp_gt_dump(const struct osmo_sccp_gt *gt);
 char *osmo_sccp_addr_dump(const struct osmo_sccp_addr *addr);
+char *osmo_sccp_addr_name(const struct osmo_ss7_instance *ss7, const struct 
osmo_sccp_addr *addr);

-- 
To view, visit https://gerrit.osmocom.org/3482
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I092dd55948faeeff78f28f7d50c5b84b9e69ef24
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

[MERGED] libosmo-sccp[master]: sccp: check for valid point code in osmo_sccp_simple_client()

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: sccp: check for valid point code in osmo_sccp_simple_client()
..


sccp: check for valid point code in osmo_sccp_simple_client()

The point-code is not checked in the beginning, only the ASP
checks the point code at a very late stage and fails in case
an invalid point-code is detected.

Remove the check in the ASP creation.

Add a new check after the SS7 initalization that checks the
point-code. If none is set, the default point-code will be
used.

Change-Id: I334d90e769bd9952f67c51b12a945f22bd268fa8
---
M src/sccp_user.c
1 file changed, 10 insertions(+), 6 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/sccp_user.c b/src/sccp_user.c
index 4e28aa0..387061c 100644
--- a/src/sccp_user.c
+++ b/src/sccp_user.c
@@ -342,6 +342,16 @@
ss7->cfg.primary_pc = default_pc;
ss7_created = true;
}
+
+   /* In case no valid point-code has been configured via the VTY, we
+* will fall back to the default pointcode. */
+   if (!osmo_ss7_pc_is_valid(ss7->cfg.primary_pc)) {
+   LOGP(DLSCCP, LOGL_ERROR,
+"SS7 instance %u: no primary point-code set, using default 
point-code\n",
+ss7->cfg.id);
+   ss7->cfg.primary_pc = default_pc;
+   }
+
LOGP(DLSCCP, LOGL_NOTICE, "%s: Using SS7 instance %u, pc:%s\n", name,
 ss7->cfg.id, osmo_ss7_pointcode_print(ss7, ss7->cfg.primary_pc));
 
@@ -364,12 +374,6 @@
if (!as)
goto out_ss7;
as_created = true;
-
-   if (!osmo_ss7_pc_is_valid(ss7->cfg.primary_pc)) {
-   LOGP(DLSCCP, LOGL_ERROR, "SS7 instance %u: no primary 
point-code set\n",
-ss7->cfg.id);
-   goto out_ss7;
-   }
as->cfg.routing_key.pc = ss7->cfg.primary_pc;
}
LOGP(DLSCCP, LOGL_NOTICE, "%s: Using AS instance %s\n", name,

-- 
To view, visit https://gerrit.osmocom.org/3480
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I334d90e769bd9952f67c51b12a945f22bd268fa8
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

libosmo-sccp[master]: sccp: fixup for osmo_sccp_get_ss7()

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3485
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84d484e4441fd37443fff8c67e17df8fb15d5b2e
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[MERGED] libosmo-sccp[master]: sccp: fixup for osmo_sccp_get_ss7()

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: sccp: fixup for osmo_sccp_get_ss7()
..


sccp: fixup for osmo_sccp_get_ss7()

osmo_sccp_get_ss7() has the risk of a nullpointer dereference, when
sccp is NULL.

Return NULL when the sccp instance is NULL.

Add doxygen comment

Change-Id: I84d484e4441fd37443fff8c67e17df8fb15d5b2e
---
M include/osmocom/sigtran/sccp_sap.h
M src/sccp_user.c
2 files changed, 7 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/sigtran/sccp_sap.h 
b/include/osmocom/sigtran/sccp_sap.h
index bf1b368..5524bd8 100644
--- a/include/osmocom/sigtran/sccp_sap.h
+++ b/include/osmocom/sigtran/sccp_sap.h
@@ -246,7 +246,7 @@
 struct osmo_sccp_instance *
 osmo_sccp_instance_create(struct osmo_ss7_instance *ss7, void *priv);
 void osmo_sccp_instance_destroy(struct osmo_sccp_instance *inst);
-struct osmo_ss7_instance *osmo_sccp_get_ss7(struct osmo_sccp_instance *sccp);
+struct osmo_ss7_instance *osmo_sccp_get_ss7(const struct osmo_sccp_instance 
*sccp);
 struct osmo_sccp_instance *osmo_sccp_get_sccp(const struct osmo_sccp_user 
*scu);
 
 void osmo_sccp_user_unbind(struct osmo_sccp_user *scu);
diff --git a/src/sccp_user.c b/src/sccp_user.c
index a4568cf..b0a807d 100644
--- a/src/sccp_user.c
+++ b/src/sccp_user.c
@@ -598,8 +598,13 @@
return NULL;
 }
 
-struct osmo_ss7_instance *osmo_sccp_get_ss7(struct osmo_sccp_instance *sccp)
+/*! \brief get the SS7 instance that is related to the given SCCP instance
+ *  \param[in] sccp SCCP instance
+ *  \returns SS7 instance; NULL if sccp was NULL */
+struct osmo_ss7_instance *osmo_sccp_get_ss7(const struct osmo_sccp_instance 
*sccp)
 {
+   if (!sccp)
+   return NULL;
return sccp->ss7;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/3485
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I84d484e4441fd37443fff8c67e17df8fb15d5b2e
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

libosmo-sccp[master]: sccp: make osmo_sccp_addr_name() available

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3482
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I092dd55948faeeff78f28f7d50c5b84b9e69ef24
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[MERGED] libosmo-sccp[master]: sccp: function to get sccp instance from sccp user

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: sccp: function to get sccp instance from sccp user
..


sccp: function to get sccp instance from sccp user

It is currently impossible to find out which SCCP instance handles
a particular user.

Introduce function to lookup the SCCP instance from a given SCCP
user.

Change-Id: I9562c4f1d00e2ebb3252c5dea598b643aa393719
---
M include/osmocom/sigtran/sccp_sap.h
M src/sccp_user.c
2 files changed, 11 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/sigtran/sccp_sap.h 
b/include/osmocom/sigtran/sccp_sap.h
index 796597f..bf1b368 100644
--- a/include/osmocom/sigtran/sccp_sap.h
+++ b/include/osmocom/sigtran/sccp_sap.h
@@ -247,6 +247,7 @@
 osmo_sccp_instance_create(struct osmo_ss7_instance *ss7, void *priv);
 void osmo_sccp_instance_destroy(struct osmo_sccp_instance *inst);
 struct osmo_ss7_instance *osmo_sccp_get_ss7(struct osmo_sccp_instance *sccp);
+struct osmo_sccp_instance *osmo_sccp_get_sccp(const struct osmo_sccp_user 
*scu);
 
 void osmo_sccp_user_unbind(struct osmo_sccp_user *scu);
 void osmo_sccp_user_set_priv(struct osmo_sccp_user *scu, void *priv);
diff --git a/src/sccp_user.c b/src/sccp_user.c
index c0e2b5a..a4568cf 100644
--- a/src/sccp_user.c
+++ b/src/sccp_user.c
@@ -602,3 +602,13 @@
 {
return sccp->ss7;
 }
+
+/*! \brief get the SCCP instance that is related to the given sccp user
+ *  \param[in] scu SCCP user
+ *  \returns SCCP instance; NULL if scu was NULL */
+struct osmo_sccp_instance *osmo_sccp_get_sccp(const struct osmo_sccp_user *scu)
+{
+   if (!scu)
+   return NULL;
+   return scu->inst;
+}

-- 
To view, visit https://gerrit.osmocom.org/3484
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9562c4f1d00e2ebb3252c5dea598b643aa393719
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

libosmo-sccp[master]: sccp: function to get sccp instance from sccp user

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3484
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9562c4f1d00e2ebb3252c5dea598b643aa393719
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

libosmo-sccp[master]: sccp: check for valid point code in osmo_sccp_simple_client()

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3480
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I334d90e769bd9952f67c51b12a945f22bd268fa8
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

libosmo-sccp[master]: sccp: fix handling of default IP addresses in osmo_sccp_simp...

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3479
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I312caf9d54cedb02034e4ef88fdd2e6ad9ca1c34
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

libosmo-sccp[master]: sccp: add doxgen comments for osmo_sccp_simple_client()

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3481
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9143bdc54d729f9f50e69fe38cd1798e065f2497
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[MERGED] osmo-iuh[master]: add /debian package support

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: add /debian package support
..


add /debian package support

Change-Id: I985805aea0e48fe70619de8b81206098e4e37613
---
A debian/changelog
A debian/compat
A debian/control
A debian/copyright
A debian/libosmo-ranap-dev.install
A debian/libosmo-ranap0.install
A debian/osmo-hnbgw.install
A debian/rules
A debian/source/format
9 files changed, 139 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/debian/changelog b/debian/changelog
new file mode 100644
index 000..91bd155
--- /dev/null
+++ b/debian/changelog
@@ -0,0 +1,5 @@
+osmo-iuh (0.1.0) UNRELEASED; urgency=low
+
+  * Initial release.
+
+ -- Alexander Couzens   Tue, 08 Aug 2017 04:13:19 +
diff --git a/debian/compat b/debian/compat
new file mode 100644
index 000..ec63514
--- /dev/null
+++ b/debian/compat
@@ -0,0 +1 @@
+9
diff --git a/debian/control b/debian/control
new file mode 100644
index 000..56a7667
--- /dev/null
+++ b/debian/control
@@ -0,0 +1,60 @@
+Source: osmo-iuh
+Section: libs
+Priority: extra
+Maintainer: Alexander Couzens 
+Build-Depends: debhelper (>=9),
+   dh-autoreconf,
+   pkg-config,
+   autoconf,
+   automake,
+   libtool,
+   git,
+   libasn1c-dev,
+   libsctp-dev,
+   libosmo-netif-dev,
+   libosmocore-dev,
+   libosmo-netif-dev,
+   libosmo-sccp-dev,
+   python (>= 2.7)
+Standards-Version: 3.9.8
+Vcs-Git: git://git.osmocom.org/osmo-iuh.git
+Vcs-Browser: https://git.osmocom.org/osmo-iuh/
+Homepage: https://projects.osmocom.org/projects/osmohnbgw
+
+Package: osmo-hnbgw
+Section: net
+Architecture: any
+Multi-Arch: no
+Pre-Depends: ${misc:Pre-Depends}
+Depends: ${misc:Depends}, ${shlibs:Depends}
+Description: osmocom Home Node B Gateway
+
+Package: osmo-hnbgw-dbg
+Section: debug
+Architecture: any
+Multi-Arch: no
+Pre-Depends: ${misc:Pre-Depends}
+Depends: osmo-hnbgw (= ${binary:Version}), ${misc:Depends}
+Description: osmocom Home Node B Gateway
+
+Package: libosmo-ranap0
+Section: libs
+Architecture: any
+Multi-Arch: same
+Pre-Depends: ${misc:Pre-Depends}
+Depends: ${misc:Depends}, ${shlibs:Depends}
+Description: Osmocom code for the Iuh interface (HNBAP, RUA, RANAP)
+
+Package: libosmo-ranap-dbg
+Section: debug
+Architecture: any
+Multi-Arch: same
+Depends: libosmo-ranap0 (= ${binary:Version}), ${misc:Depends}
+Description: Osmocom code for the Iuh interface (HNBAP, RUA, RANAP)
+
+Package: libosmo-ranap-dev
+Section: libdevel
+Architecture: any
+Multi-Arch: same
+Depends: libosmo-ranap0 (= ${binary:Version}), ${misc:Depends}
+Description: Osmocom code for the Iuh interface (HNBAP, RUA, RANAP)
diff --git a/debian/copyright b/debian/copyright
new file mode 100644
index 000..5cb4a3a
--- /dev/null
+++ b/debian/copyright
@@ -0,0 +1,48 @@
+Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Upstream-Name: osmo-iuh
+Source: git://git.osmocom.org/
+
+Files: *
+Copyright: 2015 Daniel Willmann 
+   2015 Harald Welte 
+   2015-2017 sysmocom s.f.m.c. GmbH 
+License:   AGPL-3.0+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU Affero General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+ .
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ GNU Affero General Public License for more details.
+ .
+ You should have received a copy of the GNU Affero General Public License
+ along with this program.  If not, see .
+
+Files: asn1/rua/eurecom/rua_decoder.c
+   asn1/rua/eurecom/rua_encoder.c
+   asn1/rua/eurecom/rua_ies_defs.h
+Copyright: 1999-2012 Eurecom
+License:   GPL-2.0
+ This program is free software; you can redistribute it and/or modify it
+ under the terms and conditions of the GNU General Public License,
+ version 2, as published by the Free Software Foundation.
+ .
+ This program is distributed in the hope it will be useful, but WITHOUT
+ ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ more details.
+ .
+ You should have received a copy of the GNU General Public License along with
+ this program; if not, write to the Free Software Foundation, Inc.,
+ 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
+ .
+ The full GNU General Public License is included in this distribution in
+ 

[MERGED] osmo-iuh[master]: iu_client: derive local SCCP addr from sccp instance

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: iu_client: derive local SCCP addr from sccp instance
..


iu_client: derive local SCCP addr from sccp instance

ranap_iu_init() is passed an sccp instance that has a local primary point code.
Use this primary PC by default as the local address for IuCS and IuPS clients.

Remove the current vty command 'iu local-address point-code PC':
- It is possible that we would like to configure a differing local point code
  at some point; this should then happen via sccp address book entries, not
  parsing PC directly.
- Obtaining the local PC from the SCCP instance makes this command obsolete for
  all setups we're currently aiming at: one local PC per SCCP instance.
- There are vty doc failures in this vty command, which cause osmo-msc and
  osmo-bsc vty test failures; rather than fixing this, let's drop it entirely
  until we see a need for it (and then do it properly with the address book).

Cosmetic: prefix the local static variable with g_* like g_sccp and g_scu and
define it in the same place. No default values are needed anymore, it gets
overwritten in ranap_iu_init().

Change-Id: I3bb7fc1cd5261d214c6ba0cccfe95f637e6db087
---
M src/iu_client.c
M src/iu_client_vty.c
2 files changed, 3 insertions(+), 27 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/iu_client.c b/src/iu_client.c
index 83ed276..17d955d 100644
--- a/src/iu_client.c
+++ b/src/iu_client.c
@@ -83,6 +83,7 @@
 
 static struct osmo_sccp_instance *g_sccp;
 static struct osmo_sccp_user *g_scu;
+static struct osmo_sccp_addr g_local_sccp_addr;
 
 const struct value_string ranap_iu_event_type_names[] = {
OSMO_VALUE_STRING(RANAP_IU_EVENT_RAB_ASSIGN),
@@ -584,13 +585,6 @@
  * Paging
  ***/
 
-struct osmo_sccp_addr local_sccp_addr = {
-   .presence = OSMO_SCCP_ADDR_T_SSN | OSMO_SCCP_ADDR_T_PC,
-   .ri = OSMO_SCCP_RI_SSN_PC,
-   .ssn = OSMO_SCCP_SSN_RANAP,
-   .pc = 1,
-};
-
 /* Send a paging command down a given SCCP User. tmsi and paging_cause are
  * optional and may be passed NULL and 0, respectively, to disable their use.
  * See enum RANAP_PagingCause.
@@ -604,7 +598,7 @@
struct msgb *msg;
msg = ranap_new_msg_paging_cmd(imsi, tmsi, is_ps? 1 : 0, paging_cause);
msg->l2h = msg->data;
-   osmo_sccp_tx_unitdata_msg(g_scu, _sccp_addr, called_addr, msg);
+   osmo_sccp_tx_unitdata_msg(g_scu, _local_sccp_addr, called_addr, msg);
return 0;
 }
 
@@ -776,6 +770,7 @@
global_iu_recv_cb = iu_recv_cb;
global_iu_event_cb = iu_event_cb;
g_sccp = sccp;
+   osmo_sccp_local_addr_by_instance(_local_sccp_addr, sccp, 
OSMO_SCCP_SSN_RANAP);
g_scu = osmo_sccp_user_bind(g_sccp, sccp_user_name, sccp_sap_up, 
OSMO_SCCP_SSN_RANAP);
 
return 0;
diff --git a/src/iu_client_vty.c b/src/iu_client_vty.c
index b809b2a..a99facd 100644
--- a/src/iu_client_vty.c
+++ b/src/iu_client_vty.c
@@ -75,21 +75,6 @@
return CMD_SUCCESS;
 }
 
-extern struct osmo_sccp_addr local_sccp_addr;
-
-DEFUN(cfg_iu_local_addr_pc, cfg_iu_local_addr_pc_cmd,
-   "iu local-address point-code PC",
-   IU_STR "Local SCCP Address\n")
-{
-   local_sccp_addr.presence = OSMO_SCCP_ADDR_T_PC | OSMO_SCCP_ADDR_T_SSN;
-   local_sccp_addr.ri = OSMO_SCCP_RI_SSN_PC;
-   local_sccp_addr.pc = osmo_ss7_pointcode_parse(NULL, argv[0]);
-
-   return CMD_SUCCESS;
-}
-
-/* TODO: GT address configuration, in line with 4.5.1.1.1 of TS 25.410 */
-
 int ranap_iu_vty_config_write(struct vty *vty, const char *indent)
 {
if (!g_rab_assign_addr_enc) {
@@ -113,9 +98,6 @@
return CMD_WARNING;
}
 
-   vty_out(vty, "%siu local-address point-code %s%s", indent,
-   osmo_ss7_pointcode_print(NULL, local_sccp_addr.pc), 
VTY_NEWLINE);
-
if (asn_debug)
vty_out(vty, "%sasn1 debug 1%s", indent, VTY_NEWLINE);
 
@@ -130,7 +112,6 @@
g_rab_assign_addr_enc = rab_assign_addr_enc;
 
install_element(iu_parent_node, _iu_rab_assign_addr_enc_cmd);
-   install_element(iu_parent_node, _iu_local_addr_pc_cmd);
 
/* Technically, these are global ASN.1 settings and not necessarily 
limited to the Iu interface.
 * Practically, only Iu users will use ASN.1 in Osmocom programs -- at 
least so far. So it is

-- 
To view, visit https://gerrit.osmocom.org/3507
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3bb7fc1cd5261d214c6ba0cccfe95f637e6db087
Gerrit-PatchSet: 2
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

libasn1c[master]: Re-license asn1helper.c under identical license as upstream

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3509
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e714d4c51d771b1eabec7aa06e7daae73f48b15
Gerrit-PatchSet: 1
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-HasComments: No

libasn1c[master]: debian/copyright: Code in this repository is under BSD-2-Clause

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3510
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f908ce4f670e062e6808ac7966d0e52bfe6b4f9
Gerrit-PatchSet: 1
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-HasComments: No

[PATCH] libasn1c[master]: Re-license asn1helper.c under identical license as upstream

[Harald Welte]

Review at  https://gerrit.osmocom.org/3509

Re-license asn1helper.c under identical license as upstream

asn1helpers.c originally existed in the repository of an application
(osmo-hnbgw, IIRC), and hence was under AGPLv3.  When moving it to
this repository, it should have been relicensed but wasn't.  The
intention was never to "contaminate" (lib)asn1c with AGPLv3 code.

Change-Id: I8e714d4c51d771b1eabec7aa06e7daae73f48b15
---
M debian/copyright
M src/asn1helpers.c
2 files changed, 3 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libasn1c refs/changes/09/3509/1

diff --git a/debian/copyright b/debian/copyright
index 91a7cb9..2eef07a 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -18,19 +18,7 @@
 
 Files: src/asn1helpers.c
 Copyright: 2014-2015 by Harald Welte 
-License:   AGPL-3.0+
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU Affero General Public License as published by
- the Free Software Foundation; either version 3 of the License, or
- (at your option) any later version.
- .
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- GNU Affero General Public License for more details.
- .
- You should have received a copy of the GNU Affero General Public License
- along with this program.  If not, see .
+License: BSD-2-Clause
 
 Files: debian/*
 Copyright: 2017 Alexander Couzens 
diff --git a/src/asn1helpers.c b/src/asn1helpers.c
index aca5300..a4ced70 100644
--- a/src/asn1helpers.c
+++ b/src/asn1helpers.c
@@ -3,19 +3,8 @@
 /* (C) 2014-2015 by Harald Welte 
  * All Rights Reserved
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as published by
- * the Free Software Foundation; either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see .
- *
+ * Redistribution and modifications are permitted subject to BSD license
+ * contained in COPYING file.
  */
 
 #include 

-- 
To view, visit https://gerrit.osmocom.org/3509
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e714d4c51d771b1eabec7aa06e7daae73f48b15
Gerrit-PatchSet: 1
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 

[PATCH] libasn1c[master]: debian/copyright: Code in this repository is under BSD-2-Clause

[Harald Welte]

Review at  https://gerrit.osmocom.org/3510

debian/copyright: Code in this repository is under BSD-2-Clause

The license is not a 3-clause BSD, but a 2-clause BSD.  Couldn't
find any trace to a 3rd clause anywhere.

Change-Id: I4f908ce4f670e062e6808ac7966d0e52bfe6b4f9
---
M debian/copyright
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libasn1c refs/changes/10/3510/1

diff --git a/debian/copyright b/debian/copyright
index 2eef07a..0494a0a 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -4,17 +4,17 @@
 
 Files: *
 Copyright: 2005-2014 Lev Walkin 
-License: BSD-3-Clause
+License: BSD-2-Clause
 
 Files: src/xer_support.c
 Copyright: 2003,2004 X/IO Labs, xiolabs.com.
2003,2004,2005 Lev Walkin .
-License: BSD-3-Clause
+License: BSD-2-Clause
 
 Files: include/asn1c/xer_support.h
 Copyright: 2003,2004 X/IO Labs, xiolabs.com
2003,2004 Lev Walkin 
-License: BSD-3-Clause
+License: BSD-2-Clause
 
 Files: src/asn1helpers.c
 Copyright: 2014-2015 by Harald Welte 

-- 
To view, visit https://gerrit.osmocom.org/3510
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f908ce4f670e062e6808ac7966d0e52bfe6b4f9
Gerrit-PatchSet: 1
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 

[MERGED] libasn1c[master]: add /debian to build a package

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: add /debian to build a package
..


add /debian to build a package

debian files need a release so start with release 0.1.0

Change-Id: I135d975b84027d51cb1dc534e04dd314bbd20289
---
A debian/changelog
A debian/compat
A debian/control
A debian/copyright
A debian/libasn1c-dev.install
A debian/libasn1c0.install
A debian/rules
A debian/source/format
8 files changed, 168 insertions(+), 0 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved; Verified



diff --git a/debian/changelog b/debian/changelog
new file mode 100644
index 000..f56c11a
--- /dev/null
+++ b/debian/changelog
@@ -0,0 +1,5 @@
+libasn1c (0.1.0) UNRELEASED; urgency=low
+
+  * Initial release.
+
+ -- Alexander Couzens   Sun, 06 Aug 2017 22:25:03 +
diff --git a/debian/compat b/debian/compat
new file mode 100644
index 000..ec63514
--- /dev/null
+++ b/debian/compat
@@ -0,0 +1 @@
+9
diff --git a/debian/control b/debian/control
new file mode 100644
index 000..4313249
--- /dev/null
+++ b/debian/control
@@ -0,0 +1,33 @@
+Source: libasn1c
+Section: libs
+Priority: extra
+Maintainer: Alexander Couzens 
+Build-Depends: debhelper (>=9),
+   dh-autoreconf,
+   libtalloc-dev
+Standards-Version: 3.9.8
+Vcs-Git: git://git.osmocom.org/libasn1c.git
+Vcs-Browser: http://git.osmocom.org/gitweb?p=libasn1c.git;a=summary
+Homepage: https://projects.osmocom.org/projects/libasn1c
+
+Package: libasn1c0
+Section: libs
+Architecture: any
+Multi-Arch: same
+Pre-Depends: ${misc:Pre-Depends}
+Depends: ${misc:Depends}, ${shlibs:Depends}
+Description: asn1c runtime code as shared library
+
+Package: libasn1c-dbg
+Section: debug
+Architecture: any
+Multi-Arch: same
+Depends: libasn1c0 (= ${binary:Version}), ${misc:Depends}
+Description: asn1c runtime code as shared library
+
+Package: libasn1c-dev
+Section: libdevel
+Architecture: any
+Multi-Arch: same
+Depends: libasn1c0 (= ${binary:Version}), ${misc:Depends}
+Description: asn1c runtime code as shared library
diff --git a/debian/copyright b/debian/copyright
new file mode 100644
index 000..91a7cb9
--- /dev/null
+++ b/debian/copyright
@@ -0,0 +1,64 @@
+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Upstream-Name: libasn1c
+Source: git://git.osmocom.org/libasn1c
+
+Files: *
+Copyright: 2005-2014 Lev Walkin 
+License: BSD-3-Clause
+
+Files: src/xer_support.c
+Copyright: 2003,2004 X/IO Labs, xiolabs.com.
+   2003,2004,2005 Lev Walkin .
+License: BSD-3-Clause
+
+Files: include/asn1c/xer_support.h
+Copyright: 2003,2004 X/IO Labs, xiolabs.com
+   2003,2004 Lev Walkin 
+License: BSD-3-Clause
+
+Files: src/asn1helpers.c
+Copyright: 2014-2015 by Harald Welte 
+License:   AGPL-3.0+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU Affero General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+ .
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ GNU Affero General Public License for more details.
+ .
+ You should have received a copy of the GNU Affero General Public License
+ along with this program.  If not, see .
+
+Files: debian/*
+Copyright: 2017 Alexander Couzens 
+License: BSD-3-Clause
+
+License: BSD-3-Clause
+ Redistribution and use in source and binary forms, with or without
+ modification, are permitted provided that the following conditions
+ are met:
+ .
+ 1. Redistributions of source code must retain the above copyright
+notice, this list of conditions and the following disclaimer.
+ 2. Redistributions in binary form must reproduce the above copyright
+notice, this list of conditions and the following disclaimer in the
+documentation and/or other materials provided with the distribution.
+ 3. Neither the name of the University nor the names of its contributors
+may be used to endorse or promote products derived from this software
+without specific prior written permission.
+ .
+ THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
+ ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
+ FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR 

libasn1c[master]: add /debian to build a package

[Harald Welte]

Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.osmocom.org/3440
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I135d975b84027d51cb1dc534e04dd314bbd20289
Gerrit-PatchSet: 2
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: lynxis lazus 
Gerrit-HasComments: No

Build failure of network:osmocom:nightly/openbsc in Debian_8.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_8.0/x86_64

Package network:osmocom:nightly/openbsc failed to build in Debian_8.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  157s] make[5]: Nothing to be done for 'install-data-am'.
[  157s] make[5]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  157s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  157s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  157s] make[3]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  157s] make[4]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  157s] make[4]: Nothing to be done for 'install-exec-am'.
[  157s]  /bin/mkdir -p 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
[  157s]  /usr/bin/install -c -m 644 openbsc.pc 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
[  157s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  157s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  157s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  157s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  157s]dh_install -O--sourcedirectory=openbsc
[  157s] cp: cannot stat 'debian/tmp//usr/bin/osmo-sgsn': No such file or 
directory
[  157s] dh_install: cp -a debian/tmp//usr/bin/osmo-sgsn 
debian/osmocom-sgsn///usr/bin/ returned exit code 1
[  157s] debian/rules:13: recipe for target 'binary' failed
[  157s] make: *** [binary] Error 2
[  157s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  157s] 
[  157s] lamb12 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
22:39:29 UTC 2017.
[  157s] 
[  157s] ### VM INTERACTION START ###
[  158s] Powering off.
[  158s] [  145.955730] reboot: Power down
[  158s] ### VM INTERACTION END ###
[  158s] 
[  158s] lamb12 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
22:39:30 UTC 2017.
[  158s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/openbsc in Debian_8.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_8.0/x86_64

Package network:osmocom:nightly/openbsc failed to build in Debian_8.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  157s] make[5]: Nothing to be done for 'install-data-am'.
[  157s] make[5]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  157s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  157s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  157s] make[3]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  157s] make[4]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  157s] make[4]: Nothing to be done for 'install-exec-am'.
[  157s]  /bin/mkdir -p 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
[  157s]  /usr/bin/install -c -m 644 openbsc.pc 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
[  157s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  157s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  157s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  157s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  157s]dh_install -O--sourcedirectory=openbsc
[  157s] cp: cannot stat 'debian/tmp//usr/bin/osmo-sgsn': No such file or 
directory
[  157s] dh_install: cp -a debian/tmp//usr/bin/osmo-sgsn 
debian/osmocom-sgsn///usr/bin/ returned exit code 1
[  157s] debian/rules:13: recipe for target 'binary' failed
[  157s] make: *** [binary] Error 2
[  157s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  157s] 
[  157s] lamb12 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
22:39:29 UTC 2017.
[  157s] 
[  157s] ### VM INTERACTION START ###
[  158s] Powering off.
[  158s] [  145.955730] reboot: Power down
[  158s] ### VM INTERACTION END ###
[  158s] 
[  158s] lamb12 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
22:39:30 UTC 2017.
[  158s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

libasn1c[master]: add /debian to build a package

[Harald Welte]

Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3440
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I135d975b84027d51cb1dc534e04dd314bbd20289
Gerrit-PatchSet: 2
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: lynxis lazus 
Gerrit-HasComments: No

osmo-iuh[master]: add /debian package support

[Harald Welte]

Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3506
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I985805aea0e48fe70619de8b81206098e4e37613
Gerrit-PatchSet: 2
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: lynxis lazus 
Gerrit-HasComments: No

openbsc[master]: libcommon: Fix log output for bts>0.

[Harald Welte]

Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3185
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61c18a7f021fcb1ec00d34a745f4e3ab03416c2d
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Alexander Chemeris 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-HasComments: No

[MERGED] openbsc[master]: libcommon: Fix log output for bts>0.

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: libcommon: Fix log output for bts>0.
..


libcommon: Fix log output for bts>0.

Fixes regression probably introduced in c696cc28.

For bts>0 logging doesn't show bts number correctly when printing lchan
identification string - it will always show it as "bts=0". The reason for
this is that the identification string is cached before bts->nr value is
set to a proper value.

This patch sets bts->nr as part of the first step of the bts structure
initialization, before caching happens thus making sure the cached
identification string is cached with the correct values.

Change-Id: I61c18a7f021fcb1ec00d34a745f4e3ab03416c2d
---
M openbsc/include/openbsc/gsm_data_shared.h
M openbsc/src/libcommon/gsm_data.c
M openbsc/src/libcommon/gsm_data_shared.c
M openbsc/tests/channel/channel_test.c
M openbsc/tests/channel/channel_test.ok
M openbsc/tests/gsm0408/gsm0408_test.c
6 files changed, 44 insertions(+), 10 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/include/openbsc/gsm_data_shared.h 
b/openbsc/include/openbsc/gsm_data_shared.h
index 4c71a07..369668d 100644
--- a/openbsc/include/openbsc/gsm_data_shared.h
+++ b/openbsc/include/openbsc/gsm_data_shared.h
@@ -900,7 +900,7 @@
 };
 
 
-struct gsm_bts *gsm_bts_alloc(void *talloc_ctx);
+struct gsm_bts *gsm_bts_alloc(void *talloc_ctx, uint8_t bts_num);
 struct gsm_bts *gsm_bts_num(struct gsm_network *net, int num);
 
 struct gsm_bts_trx *gsm_bts_trx_alloc(struct gsm_bts *bts);
diff --git a/openbsc/src/libcommon/gsm_data.c b/openbsc/src/libcommon/gsm_data.c
index db7de08..f1049e9 100644
--- a/openbsc/src/libcommon/gsm_data.c
+++ b/openbsc/src/libcommon/gsm_data.c
@@ -286,12 +286,13 @@
if (!model && type != GSM_BTS_TYPE_UNKNOWN)
return NULL;
 
-   bts = gsm_bts_alloc(net);
+   bts = gsm_bts_alloc(net, net->num_bts);
if (!bts)
return NULL;
 
+   net->num_bts++;
+
bts->network = net;
-   bts->nr = net->num_bts++;
bts->type = type;
bts->model = model;
bts->bsic = bsic;
diff --git a/openbsc/src/libcommon/gsm_data_shared.c 
b/openbsc/src/libcommon/gsm_data_shared.c
index 8992636..d792f3b 100644
--- a/openbsc/src/libcommon/gsm_data_shared.c
+++ b/openbsc/src/libcommon/gsm_data_shared.c
@@ -312,7 +312,7 @@
.initial_mcs = 6,
 };
 
-struct gsm_bts *gsm_bts_alloc(void *ctx)
+struct gsm_bts *gsm_bts_alloc(void *ctx, uint8_t bts_num)
 {
struct gsm_bts *bts = talloc_zero(ctx, struct gsm_bts);
int i;
@@ -320,6 +320,7 @@
if (!bts)
return NULL;
 
+   bts->nr = bts_num;
bts->num_trx = 0;
INIT_LLIST_HEAD(>trx_list);
bts->ms_max_power = 15; /* dBm */
diff --git a/openbsc/tests/channel/channel_test.c 
b/openbsc/tests/channel/channel_test.c
index 88293d0..cf19aab 100644
--- a/openbsc/tests/channel/channel_test.c
+++ b/openbsc/tests/channel/channel_test.c
@@ -70,7 +70,7 @@
network = bsc_network_init(tall_bsc_ctx, 1, 1, NULL);
if (!network)
exit(1);
-   bts = gsm_bts_alloc(network);
+   bts = gsm_bts_alloc(network, 0);
bts->location_area_code = 23;
s_conn.network = network;
 
@@ -91,6 +91,36 @@
 
OSMO_ASSERT(s_end);
 }
+
+
+void test_bts_debug_print(void)
+{
+   struct gsm_network *network;
+   struct gsm_bts *bts;
+   struct gsm_bts_trx *trx;
+
+   printf("Testing the lchan printing:");
+
+   /* Create a dummy network */
+   network = bsc_network_init(tall_bsc_ctx, 1, 1, NULL);
+   if (!network)
+   exit(1);
+   /* Add a BTS with some reasonanbly non-zero id */
+   bts = gsm_bts_alloc(network, 45);
+   /* Add a second TRX to test on multiple TRXs */
+   gsm_bts_trx_alloc(bts);
+
+   llist_for_each_entry(trx, >trx_list, list) {
+   char *name = gsm_lchan_name(>ts[3].lchan[4]);
+
+   if (name)
+   printf(" %s", name);
+   else
+   printf("NULL name");
+   }
+   printf("\n");
+}
+
 
 void test_dyn_ts_subslots(void)
 {
@@ -128,6 +158,7 @@
 
test_request_chan();
test_dyn_ts_subslots();
+   test_bts_debug_print();
 
return EXIT_SUCCESS;
 }
diff --git a/openbsc/tests/channel/channel_test.ok 
b/openbsc/tests/channel/channel_test.ok
index 33c8193..e2e93ef 100644
--- a/openbsc/tests/channel/channel_test.ok
+++ b/openbsc/tests/channel/channel_test.ok
@@ -1,3 +1,4 @@
 Testing the gsm_subscriber chan logic
 Reached, didn't crash, test passed
 Testing subslot numbers for pchan types
+Testing the lchan printing: (bts=45,trx=0,ts=3,ss=4) (bts=45,trx=1,ts=3,ss=4)
diff --git a/openbsc/tests/gsm0408/gsm0408_test.c 
b/openbsc/tests/gsm0408/gsm0408_test.c
index 5a8c6ca..63b5c7c 100644
--- 

osmo-iuh[master]: iu_client: derive local SCCP addr from sccp instance

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3507
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3bb7fc1cd5261d214c6ba0cccfe95f637e6db087
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[MERGED] openbsc[master]: libmsc: use new smpp34 esm_class definitions

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: libmsc: use new smpp34 esm_class definitions
..


libmsc: use new smpp34 esm_class definitions

Replace magic numbers by esm_class definitions, which
have been added to latest libsmpp34 in Change-Id
I91afd8b462b8fd3b2c4c5b54f4eeb7ec5b730b65


Change-Id: I6c458690da60c8f3637680efbd718f6e8c6feb4c
---
M openbsc/src/libmsc/smpp_openbsc.c
1 file changed, 8 insertions(+), 10 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/libmsc/smpp_openbsc.c 
b/openbsc/src/libmsc/smpp_openbsc.c
index 7e23abd..ddb24b5 100644
--- a/openbsc/src/libmsc/smpp_openbsc.c
+++ b/openbsc/src/libmsc/smpp_openbsc.c
@@ -157,14 +157,13 @@
osmo_strlcpy(sms->src.addr, (char *)submit->source_addr,
 sizeof(sms->src.addr));
 
-   /* This is a Delivery Acknowledgment. */
-   if (submit->esm_class == 0x08)
+   if (submit->esm_class == SMPP34_DELIVERY_ACK)
sms->is_report = true;
 
-   if (submit->esm_class & 0x40)
+   if (submit->esm_class & SMPP34_UDHI_IND)
sms->ud_hdr_ind = 1;
 
-   if (submit->esm_class & 0x80) {
+   if (submit->esm_class & SMPP34_REPLY_PATH) {
sms->reply_path_req = 1;
 #warning Implement reply path
}
@@ -240,7 +239,7 @@
sms->smpp.esme = esme;
sms->protocol_id = submit->protocol_id;
 
-   switch (submit->esm_class & 3) {
+   switch (submit->esm_class & SMPP34_MSG_MODE_MASK) {
case 0: /* default */
case 1: /* datagram */
case 3: /* store-and-forward */
@@ -664,16 +663,15 @@
memcpy(deliver.destination_addr, sms->dst.addr,
sizeof(deliver.destination_addr));
 
-   /* Short message contains a delivery receipt? Sect. 5.2.12. */
if (sms->is_report)
-   deliver.esm_class = 0x04;
+   deliver.esm_class = SMPP34_DELIVERY_RECEIPT;
else
-   deliver.esm_class = 1;  /* datagram mode */
+   deliver.esm_class = SMPP34_DATAGRAM_MODE;
 
if (sms->ud_hdr_ind)
-   deliver.esm_class |= 0x40;
+   deliver.esm_class |= SMPP34_UDHI_IND;
if (sms->reply_path_req)
-   deliver.esm_class |= 0x80;
+   deliver.esm_class |= SMPP34_REPLY_PATH;
 
deliver.protocol_id = sms->protocol_id;
deliver.priority_flag   = 0;

-- 
To view, visit https://gerrit.osmocom.org/3474
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6c458690da60c8f3637680efbd718f6e8c6feb4c
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Pablo Neira Ayuso 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pablo Neira Ayuso 

[MERGED] openggsn[master]: update debian/changelog to 0.94 + fix pkg-config version

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: update debian/changelog to 0.94 + fix pkg-config version
..


update debian/changelog to 0.94 + fix pkg-config version

This updates the debian changelog to 0.94 and adds some logic
to debian/rulres which fixes the version of the libgtp.pc file
built as part of our OBS builds (used to be UNKNOWN since
commit 23eea1d132120198745dcca32728906d5f05dc5f)

Change-Id: I883feaef35ff5ffd1b22fb255b7c36112b4a8f3b
---
M debian/changelog
M debian/rules
2 files changed, 13 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/debian/changelog b/debian/changelog
index 5d52bfd..17a0a36 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,9 +1,16 @@
-openggsn (0.93) UNRELEASED; urgency=medium
+openggsn (0.94) UNRELEASED; urgency=medium
 
+  [ Holger Hans Peter Freyther ]
   * Bump version to ease upgrading from Debian SID.
   * Bump libgtp SO version after ABI change.
 
- -- Holger Hans Peter Freyther   Tue, 24 Jan 2017 
17:26:26 +0100
+  [ Harald Welte ]
+  * various documentation / README updates
+  * improve error logging and propagation
+  * endian-safe definition of IP header
+  * IPv6 user plane support
+
+ -- Harald Welte   Sun, 13 Aug 2017 09:34:20 +0200
 
 openggsn (0.92) precise; urgency=medium
 
diff --git a/debian/rules b/debian/rules
index 8710fa0..aa95e28 100755
--- a/debian/rules
+++ b/debian/rules
@@ -3,6 +3,10 @@
 # Uncomment this to turn on verbose mode.
 #export DH_VERBOSE=1
 
+DEBIAN  := $(shell dpkg-parsechangelog | grep ^Version: | cut -d' ' -f2)
+DEBVERS := $(shell echo '$(DEBIAN)' | cut -d- -f1)
+VERSION := $(shell echo '$(DEBVERS)' | sed -e 's/[+-].*//' -e 's/~//g')
+
 # This has to be exported to make some magic below work.
 #export DH_OPTIONS
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all

-- 
To view, visit https://gerrit.osmocom.org/3508
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I883feaef35ff5ffd1b22fb255b7c36112b4a8f3b
Gerrit-PatchSet: 1
Gerrit-Project: openggsn
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

[PATCH] openggsn[master]: update debian/changelog to 0.94 + fix pkg-config version

[Harald Welte]

Review at  https://gerrit.osmocom.org/3508

update debian/changelog to 0.94 + fix pkg-config version

This updates the debian changelog to 0.94 and adds some logic
to debian/rulres which fixes the version of the libgtp.pc file
built as part of our OBS builds (used to be UNKNOWN since
commit 23eea1d132120198745dcca32728906d5f05dc5f)

Change-Id: I883feaef35ff5ffd1b22fb255b7c36112b4a8f3b
---
M debian/changelog
M debian/rules
2 files changed, 13 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openggsn refs/changes/08/3508/1

diff --git a/debian/changelog b/debian/changelog
index 5d52bfd..17a0a36 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,9 +1,16 @@
-openggsn (0.93) UNRELEASED; urgency=medium
+openggsn (0.94) UNRELEASED; urgency=medium
 
+  [ Holger Hans Peter Freyther ]
   * Bump version to ease upgrading from Debian SID.
   * Bump libgtp SO version after ABI change.
 
- -- Holger Hans Peter Freyther   Tue, 24 Jan 2017 
17:26:26 +0100
+  [ Harald Welte ]
+  * various documentation / README updates
+  * improve error logging and propagation
+  * endian-safe definition of IP header
+  * IPv6 user plane support
+
+ -- Harald Welte   Sun, 13 Aug 2017 09:34:20 +0200
 
 openggsn (0.92) precise; urgency=medium
 
diff --git a/debian/rules b/debian/rules
index 8710fa0..aa95e28 100755
--- a/debian/rules
+++ b/debian/rules
@@ -3,6 +3,10 @@
 # Uncomment this to turn on verbose mode.
 #export DH_VERBOSE=1
 
+DEBIAN  := $(shell dpkg-parsechangelog | grep ^Version: | cut -d' ' -f2)
+DEBVERS := $(shell echo '$(DEBIAN)' | cut -d- -f1)
+VERSION := $(shell echo '$(DEBVERS)' | sed -e 's/[+-].*//' -e 's/~//g')
+
 # This has to be exported to make some magic below work.
 #export DH_OPTIONS
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all

-- 
To view, visit https://gerrit.osmocom.org/3508
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I883feaef35ff5ffd1b22fb255b7c36112b4a8f3b
Gerrit-PatchSet: 1
Gerrit-Project: openggsn
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 

openggsn[master]: update debian/changelog to 0.94 + fix pkg-config version

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3508
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I883feaef35ff5ffd1b22fb255b7c36112b4a8f3b
Gerrit-PatchSet: 1
Gerrit-Project: openggsn
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  248s] make[5]: Nothing to be done for 'install-data-am'.
[  248s] make[5]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  248s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  248s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  248s] make[3]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  248s] make[4]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  248s] make[4]: Nothing to be done for 'install-exec-am'.
[  248s]  /bin/mkdir -p 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
[  248s]  /usr/bin/install -c -m 644 openbsc.pc 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
[  248s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  248s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  248s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  248s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  248s]dh_install -O--sourcedirectory=openbsc
[  248s] dh_install: osmocom-sgsn missing files: /usr/bin/osmo-sgsn
[  248s] dh_install: osmo-gtphub missing files: /usr/bin/osmo-gtphub
[  248s] dh_install: missing files, aborting
[  248s] debian/rules:13: recipe for target 'binary' failed
[  248s] make: *** [binary] Error 2
[  248s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  248s] 
[  248s] cloud127 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:08:58 UTC 2017.
[  248s] 
[  248s] ### VM INTERACTION START ###
[  251s] [  213.137996] reboot: Power down
[  255s] ### VM INTERACTION END ###
[  255s] 
[  255s] cloud127 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:09:05 UTC 2017.
[  255s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  248s] make[5]: Nothing to be done for 'install-data-am'.
[  248s] make[5]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  248s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  248s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  248s] make[3]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  248s] make[4]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  248s] make[4]: Nothing to be done for 'install-exec-am'.
[  248s]  /bin/mkdir -p 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
[  248s]  /usr/bin/install -c -m 644 openbsc.pc 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
[  248s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  248s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  248s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  248s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  248s]dh_install -O--sourcedirectory=openbsc
[  248s] dh_install: osmocom-sgsn missing files: /usr/bin/osmo-sgsn
[  248s] dh_install: osmo-gtphub missing files: /usr/bin/osmo-gtphub
[  248s] dh_install: missing files, aborting
[  248s] debian/rules:13: recipe for target 'binary' failed
[  248s] make: *** [binary] Error 2
[  248s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  248s] 
[  248s] cloud127 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:08:58 UTC 2017.
[  248s] 
[  248s] ### VM INTERACTION START ###
[  251s] [  213.137996] reboot: Power down
[  255s] ### VM INTERACTION END ###
[  255s] 
[  255s] cloud127 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:09:05 UTC 2017.
[  255s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/x86_64

Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  151s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  151s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  151s] make[3]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  151s] make[4]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  151s] make[4]: Nothing to be done for 'install-exec-am'.
[  151s]  /bin/mkdir -p 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
[  151s]  /usr/bin/install -c -m 644 openbsc.pc 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
[  151s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  151s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  151s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  151s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  151s]dh_install -O--sourcedirectory=openbsc
[  151s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-sgsn" (tried 
in "." and "debian/tmp")
[  151s] dh_install: osmocom-sgsn missing files: /usr/bin/osmo-sgsn
[  151s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-gtphub" 
(tried in "." and "debian/tmp")
[  151s] dh_install: osmo-gtphub missing files: /usr/bin/osmo-gtphub
[  151s] dh_install: missing files, aborting
[  151s] debian/rules:13: recipe for target 'binary' failed
[  151s] make: *** [binary] Error 2
[  151s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  151s] 
[  151s] lamb09 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:08:02 UTC 2017.
[  151s] 
[  151s] ### VM INTERACTION START ###
[  154s] [  143.780142] reboot: Power down
[  154s] ### VM INTERACTION END ###
[  154s] 
[  154s] lamb09 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:08:05 UTC 2017.
[  154s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/i586

Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  189s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  189s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  189s] make[3]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  189s] make[4]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  189s] make[4]: Nothing to be done for 'install-exec-am'.
[  189s]  /bin/mkdir -p 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/i386-linux-gnu/pkgconfig'
[  189s]  /usr/bin/install -c -m 644 openbsc.pc 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/i386-linux-gnu/pkgconfig'
[  189s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  189s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  189s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  189s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  189s]dh_install -O--sourcedirectory=openbsc
[  190s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-sgsn" (tried 
in "." and "debian/tmp")
[  190s] dh_install: osmocom-sgsn missing files: /usr/bin/osmo-sgsn
[  190s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-gtphub" 
(tried in "." and "debian/tmp")
[  190s] dh_install: osmo-gtphub missing files: /usr/bin/osmo-gtphub
[  190s] dh_install: missing files, aborting
[  190s] debian/rules:13: recipe for target 'binary' failed
[  190s] make: *** [binary] Error 2
[  190s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  190s] 
[  190s] lamb74 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:08:00 UTC 2017.
[  190s] 
[  190s] ### VM INTERACTION START ###
[  193s] [  181.166056] reboot: Power down
[  193s] ### VM INTERACTION END ###
[  193s] 
[  193s] lamb74 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:08:04 UTC 2017.
[  193s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/x86_64

Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  151s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  151s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  151s] make[3]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  151s] make[4]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  151s] make[4]: Nothing to be done for 'install-exec-am'.
[  151s]  /bin/mkdir -p 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
[  151s]  /usr/bin/install -c -m 644 openbsc.pc 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
[  151s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  151s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  151s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  151s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  151s]dh_install -O--sourcedirectory=openbsc
[  151s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-sgsn" (tried 
in "." and "debian/tmp")
[  151s] dh_install: osmocom-sgsn missing files: /usr/bin/osmo-sgsn
[  151s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-gtphub" 
(tried in "." and "debian/tmp")
[  151s] dh_install: osmo-gtphub missing files: /usr/bin/osmo-gtphub
[  151s] dh_install: missing files, aborting
[  151s] debian/rules:13: recipe for target 'binary' failed
[  151s] make: *** [binary] Error 2
[  151s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  151s] 
[  151s] lamb09 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:08:02 UTC 2017.
[  151s] 
[  151s] ### VM INTERACTION START ###
[  154s] [  143.780142] reboot: Power down
[  154s] ### VM INTERACTION END ###
[  154s] 
[  154s] lamb09 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:08:05 UTC 2017.
[  154s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/i586

Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  189s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  189s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  189s] make[3]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  189s] make[4]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  189s] make[4]: Nothing to be done for 'install-exec-am'.
[  189s]  /bin/mkdir -p 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/i386-linux-gnu/pkgconfig'
[  189s]  /usr/bin/install -c -m 644 openbsc.pc 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/i386-linux-gnu/pkgconfig'
[  189s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  189s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  189s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  189s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  189s]dh_install -O--sourcedirectory=openbsc
[  190s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-sgsn" (tried 
in "." and "debian/tmp")
[  190s] dh_install: osmocom-sgsn missing files: /usr/bin/osmo-sgsn
[  190s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-gtphub" 
(tried in "." and "debian/tmp")
[  190s] dh_install: osmo-gtphub missing files: /usr/bin/osmo-gtphub
[  190s] dh_install: missing files, aborting
[  190s] debian/rules:13: recipe for target 'binary' failed
[  190s] make: *** [binary] Error 2
[  190s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  190s] 
[  190s] lamb74 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:08:00 UTC 2017.
[  190s] 
[  190s] ### VM INTERACTION START ###
[  193s] [  181.166056] reboot: Power down
[  193s] ### VM INTERACTION END ###
[  193s] 
[  193s] lamb74 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:08:04 UTC 2017.
[  193s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/i586

Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  217s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  217s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  217s] make[3]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  217s] make[4]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  217s] make[4]: Nothing to be done for 'install-exec-am'.
[  217s]  /bin/mkdir -p 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/i386-linux-gnu/pkgconfig'
[  217s]  /usr/bin/install -c -m 644 openbsc.pc 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/i386-linux-gnu/pkgconfig'
[  217s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  217s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  217s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  217s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  217s]dh_install -O--sourcedirectory=openbsc
[  218s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-sgsn" (tried 
in "." and "debian/tmp")
[  218s] dh_install: osmocom-sgsn missing files: /usr/bin/osmo-sgsn
[  218s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-gtphub" 
(tried in "." and "debian/tmp")
[  218s] dh_install: osmo-gtphub missing files: /usr/bin/osmo-gtphub
[  218s] dh_install: missing files, aborting
[  218s] debian/rules:13: recipe for target 'binary' failed
[  218s] make: *** [binary] Error 2
[  218s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  218s] 
[  218s] lamb15 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:06:54 UTC 2017.
[  218s] 
[  218s] ### VM INTERACTION START ###
[  221s] [  205.602194] reboot: Power down
[  221s] ### VM INTERACTION END ###
[  221s] 
[  221s] lamb15 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:06:57 UTC 2017.
[  221s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.10/i586

Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  168s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  168s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  168s] make[3]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  168s] make[4]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  168s] make[4]: Nothing to be done for 'install-exec-am'.
[  168s]  /bin/mkdir -p 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/i386-linux-gnu/pkgconfig'
[  168s]  /usr/bin/install -c -m 644 openbsc.pc 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/i386-linux-gnu/pkgconfig'
[  168s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  168s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  168s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  168s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  168s]dh_install -O--sourcedirectory=openbsc
[  168s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-sgsn" (tried 
in "." and "debian/tmp")
[  168s] dh_install: osmocom-sgsn missing files: /usr/bin/osmo-sgsn
[  168s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-gtphub" 
(tried in "." and "debian/tmp")
[  168s] dh_install: osmo-gtphub missing files: /usr/bin/osmo-gtphub
[  168s] dh_install: missing files, aborting
[  168s] debian/rules:13: recipe for target 'binary' failed
[  168s] make: *** [binary] Error 2
[  168s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  168s] 
[  168s] lamb17 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:07:06 UTC 2017.
[  168s] 
[  168s] ### VM INTERACTION START ###
[  172s] [  161.086257] reboot: Power down
[  172s] ### VM INTERACTION END ###
[  172s] 
[  172s] lamb17 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:07:10 UTC 2017.
[  172s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/x86_64

Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  118s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  118s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  118s] make[3]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  118s] make[4]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  118s] make[4]: Nothing to be done for 'install-exec-am'.
[  118s]  /bin/mkdir -p 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
[  118s]  /usr/bin/install -c -m 644 openbsc.pc 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
[  118s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  118s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  118s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  118s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  118s]dh_install -O--sourcedirectory=openbsc
[  118s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-sgsn" (tried 
in "." and "debian/tmp")
[  118s] dh_install: osmocom-sgsn missing files: /usr/bin/osmo-sgsn
[  118s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-gtphub" 
(tried in "." and "debian/tmp")
[  118s] dh_install: osmo-gtphub missing files: /usr/bin/osmo-gtphub
[  118s] dh_install: missing files, aborting
[  118s] debian/rules:13: recipe for target 'binary' failed
[  118s] make: *** [binary] Error 2
[  118s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  118s] 
[  118s] build77 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:07:46 UTC 2017.
[  118s] 
[  118s] ### VM INTERACTION START ###
[  121s] [  105.862345] reboot: Power down
[  121s] ### VM INTERACTION END ###
[  121s] 
[  121s] build77 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:07:49 UTC 2017.
[  121s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/x86_64

Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  118s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  118s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  118s] make[3]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  118s] make[4]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  118s] make[4]: Nothing to be done for 'install-exec-am'.
[  118s]  /bin/mkdir -p 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
[  118s]  /usr/bin/install -c -m 644 openbsc.pc 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
[  118s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  118s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  118s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  118s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  118s]dh_install -O--sourcedirectory=openbsc
[  118s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-sgsn" (tried 
in "." and "debian/tmp")
[  118s] dh_install: osmocom-sgsn missing files: /usr/bin/osmo-sgsn
[  118s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-gtphub" 
(tried in "." and "debian/tmp")
[  118s] dh_install: osmo-gtphub missing files: /usr/bin/osmo-gtphub
[  118s] dh_install: missing files, aborting
[  118s] debian/rules:13: recipe for target 'binary' failed
[  118s] make: *** [binary] Error 2
[  118s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  118s] 
[  118s] build77 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:07:46 UTC 2017.
[  118s] 
[  118s] ### VM INTERACTION START ###
[  121s] [  105.862345] reboot: Power down
[  121s] ### VM INTERACTION END ###
[  121s] 
[  121s] build77 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:07:49 UTC 2017.
[  121s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.10/i586

Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  168s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  168s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  168s] make[3]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  168s] make[4]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  168s] make[4]: Nothing to be done for 'install-exec-am'.
[  168s]  /bin/mkdir -p 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/i386-linux-gnu/pkgconfig'
[  168s]  /usr/bin/install -c -m 644 openbsc.pc 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/i386-linux-gnu/pkgconfig'
[  168s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  168s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  168s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  168s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  168s]dh_install -O--sourcedirectory=openbsc
[  168s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-sgsn" (tried 
in "." and "debian/tmp")
[  168s] dh_install: osmocom-sgsn missing files: /usr/bin/osmo-sgsn
[  168s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-gtphub" 
(tried in "." and "debian/tmp")
[  168s] dh_install: osmo-gtphub missing files: /usr/bin/osmo-gtphub
[  168s] dh_install: missing files, aborting
[  168s] debian/rules:13: recipe for target 'binary' failed
[  168s] make: *** [binary] Error 2
[  168s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  168s] 
[  168s] lamb17 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:07:06 UTC 2017.
[  168s] 
[  168s] ### VM INTERACTION START ###
[  172s] [  161.086257] reboot: Power down
[  172s] ### VM INTERACTION END ###
[  172s] 
[  172s] lamb17 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:07:10 UTC 2017.
[  172s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/i586

Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  217s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  217s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  217s] make[3]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  217s] make[4]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  217s] make[4]: Nothing to be done for 'install-exec-am'.
[  217s]  /bin/mkdir -p 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/i386-linux-gnu/pkgconfig'
[  217s]  /usr/bin/install -c -m 644 openbsc.pc 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/i386-linux-gnu/pkgconfig'
[  217s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  217s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  217s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  217s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  217s]dh_install -O--sourcedirectory=openbsc
[  218s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-sgsn" (tried 
in "." and "debian/tmp")
[  218s] dh_install: osmocom-sgsn missing files: /usr/bin/osmo-sgsn
[  218s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-gtphub" 
(tried in "." and "debian/tmp")
[  218s] dh_install: osmo-gtphub missing files: /usr/bin/osmo-gtphub
[  218s] dh_install: missing files, aborting
[  218s] debian/rules:13: recipe for target 'binary' failed
[  218s] make: *** [binary] Error 2
[  218s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  218s] 
[  218s] lamb15 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:06:54 UTC 2017.
[  218s] 
[  218s] ### VM INTERACTION START ###
[  221s] [  205.602194] reboot: Power down
[  221s] ### VM INTERACTION END ###
[  221s] 
[  221s] lamb15 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:06:57 UTC 2017.
[  221s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.10/x86_64

Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  173s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  173s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  173s] make[3]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  173s] make[4]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  173s] make[4]: Nothing to be done for 'install-exec-am'.
[  173s]  /bin/mkdir -p 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
[  173s]  /usr/bin/install -c -m 644 openbsc.pc 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
[  173s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  173s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  173s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  173s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  173s]dh_install -O--sourcedirectory=openbsc
[  173s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-sgsn" (tried 
in "." and "debian/tmp")
[  173s] dh_install: osmocom-sgsn missing files: /usr/bin/osmo-sgsn
[  173s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-gtphub" 
(tried in "." and "debian/tmp")
[  173s] dh_install: osmo-gtphub missing files: /usr/bin/osmo-gtphub
[  173s] dh_install: missing files, aborting
[  173s] debian/rules:13: recipe for target 'binary' failed
[  173s] make: *** [binary] Error 2
[  173s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  174s] 
[  174s] lamb02 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:05:50 UTC 2017.
[  174s] 
[  174s] ### VM INTERACTION START ###
[  177s] [  166.615285] reboot: Power down
[  177s] ### VM INTERACTION END ###
[  177s] 
[  177s] lamb02 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:05:53 UTC 2017.
[  177s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.10/x86_64

Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  173s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  173s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[  173s] make[3]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  173s] make[4]: Entering directory '/usr/src/packages/BUILD/openbsc'
[  173s] make[4]: Nothing to be done for 'install-exec-am'.
[  173s]  /bin/mkdir -p 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
[  173s]  /usr/bin/install -c -m 644 openbsc.pc 
'/usr/src/packages/BUILD/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
[  173s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  173s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  173s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  173s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  173s]dh_install -O--sourcedirectory=openbsc
[  173s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-sgsn" (tried 
in "." and "debian/tmp")
[  173s] dh_install: osmocom-sgsn missing files: /usr/bin/osmo-sgsn
[  173s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-gtphub" 
(tried in "." and "debian/tmp")
[  173s] dh_install: osmo-gtphub missing files: /usr/bin/osmo-gtphub
[  173s] dh_install: missing files, aborting
[  173s] debian/rules:13: recipe for target 'binary' failed
[  173s] make: *** [binary] Error 2
[  173s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  174s] 
[  174s] lamb02 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:05:50 UTC 2017.
[  174s] 
[  174s] ### VM INTERACTION START ###
[  177s] [  166.615285] reboot: Power down
[  177s] ### VM INTERACTION END ###
[  177s] 
[  177s] lamb02 failed "build openbsc_0.15.1.20170813.dsc" at Sun Aug 13 
20:05:53 UTC 2017.
[  177s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)