libosmocore[master]: Use value string check from osmo-ci

[Harald Welte]

Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3685
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I513835be2d931d0a931cdfc996f361a451bc1a15
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

[MERGED] libosmocore[master]: Use value string check from osmo-ci

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: Use value string check from osmo-ci
..


Use value string check from osmo-ci

Change-Id: I513835be2d931d0a931cdfc996f361a451bc1a15
---
M contrib/jenkins-arm.sh
M contrib/jenkins.sh
D contrib/verify_value_string_arrays_are_terminated.py
3 files changed, 4 insertions(+), 36 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/contrib/jenkins-arm.sh b/contrib/jenkins-arm.sh
index 510b0e9..ad992af 100755
--- a/contrib/jenkins-arm.sh
+++ b/contrib/jenkins-arm.sh
@@ -2,7 +2,7 @@
 
 set -ex
 
-./contrib/verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
+verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
 
 autoreconf --install --force
 ./configure --enable-static \
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 6a72840..4a26776 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -1,8 +1,9 @@
-#!/usr/bin/env bash
+#!/bin/sh
+# jenkins build helper script for libosmo-sccp.  This is how we build on 
jenkins.osmocom.org
 
 set -ex
 
-./contrib/verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
+verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
 
 if [ "x$label" = "xFreeBSD_amd64" ]; then
 ENABLE_SANITIZE=""
diff --git a/contrib/verify_value_string_arrays_are_terminated.py 
b/contrib/verify_value_string_arrays_are_terminated.py
deleted file mode 100755
index 020bb4d..000
--- a/contrib/verify_value_string_arrays_are_terminated.py
+++ /dev/null
@@ -1,33 +0,0 @@
-#!/usr/bin/env python3
-# vim: expandtab tabstop=2 shiftwidth=2 nocin
-
-'''
-Usage:
-  verify_value_string_arrays_are_terminated.py PATH [PATH [...]]
-
-e.g.
-libosmocore/contrib/verify_value_string_arrays_are_terminated.py $(find . 
-name "*.[hc]")
-'''
-
-import re
-import sys
-import codecs
-
-value_string_array_re = re.compile(
-  r'((\bstruct\s+value_string\b[^{;]*?)\s*=[^{;]*{[^;]*}\s*;)',
-  re.MULTILINE | re.DOTALL)
-
-members = r'(\.(value|str)\s*=\s*)?'
-terminator_re = re.compile('{\s*' + members + '(0|NULL)\s*,'
-   '\s*' + members + '(0|NULL)\s*}')
-errors_found = 0
-
-for f in sys.argv[1:]:
-  arrays = value_string_array_re.findall(codecs.open(f, "r", "utf-8").read())
-  for array_def, name in arrays:
-if not terminator_re.search(array_def):
-  print('ERROR: file contains unterminated value_string %r: %r'
-% (name, f))
-  errors_found += 1
-
-sys.exit(errors_found)

-- 
To view, visit https://gerrit.osmocom.org/3685
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I513835be2d931d0a931cdfc996f361a451bc1a15
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 

libosmocore[master]: Update release helper

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3680
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I413f99cbfa6e6dcc753e3be9fc3c8d682e6a41f3
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[MERGED] osmo-hlr[master]: Use release helper from libosmocore

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: Use release helper from libosmocore
..


Use release helper from libosmocore

Change-Id: I06b9ceff1e1ecfccc1b1a52ffe6b9d3f6dcaa34d
Related: OS#1861
---
M Makefile.am
M configure.ac
2 files changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/Makefile.am b/Makefile.am
index 0d60cee..392d80d 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -10,6 +10,8 @@
.version \
$(NULL)
 
+@RELMAKE@
+
 BUILT_SOURCES = $(top_srcdir)/.version
 $(top_srcdir)/.version:
echo $(VERSION) > $@-t && mv $@-t $@
diff --git a/configure.ac b/configure.ac
index 958b48b..6532940 100644
--- a/configure.ac
+++ b/configure.ac
@@ -15,6 +15,10 @@
 dnl kernel style compile messages
 m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
 
+dnl include release helper
+RELMAKE='-include osmo-release.mk'
+AC_SUBST([RELMAKE])
+
 dnl checks for programs
 AC_PROG_MAKE_SET
 AC_PROG_MKDIR_P

-- 
To view, visit https://gerrit.osmocom.org/3689
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I06b9ceff1e1ecfccc1b1a52ffe6b9d3f6dcaa34d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

osmo-hlr[master]: Use release helper from libosmocore

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3689
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06b9ceff1e1ecfccc1b1a52ffe6b9d3f6dcaa34d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

osmo-sip-connector[master]: Use release helper from libosmocore

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3691
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a65695d6191aa7647b9872e58da4a00bbad59e2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[MERGED] osmo-sip-connector[master]: Use release helper from libosmocore

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: Use release helper from libosmocore
..


Use release helper from libosmocore

Change-Id: I1a65695d6191aa7647b9872e58da4a00bbad59e2
Related: OS#1861
---
M .gitignore
M Makefile.am
M configure.ac
3 files changed, 9 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/.gitignore b/.gitignore
index f8fa410..87bed96 100644
--- a/.gitignore
+++ b/.gitignore
@@ -20,3 +20,5 @@
 stamp-h1
 
 osmo-sip-connector
+.tarball-version
+.version
diff --git a/Makefile.am b/Makefile.am
index abb1d66..5a2c4a9 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -4,6 +4,9 @@
 
 BUILT_SOURCES = $(top_srcdir)/.version
 EXTRA_DIST = git-version-gen osmoappdesc.py .version
+
+@RELMAKE@
+
 $(top_srcdir)/.version:
echo $(VERSION) > $@-t && mv $@-t $@
 dist-hook:
diff --git a/configure.ac b/configure.ac
index 1fa6157..35a75b9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -14,6 +14,10 @@
 fi
 PKG_PROG_PKG_CONFIG([0.20])
 
+dnl include release helper
+RELMAKE='-include osmo-release.mk'
+AC_SUBST([RELMAKE])
+
 dnl kernel style compile messages
 m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
 AC_PROG_CC

-- 
To view, visit https://gerrit.osmocom.org/3691
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1a65695d6191aa7647b9872e58da4a00bbad59e2
Gerrit-PatchSet: 2
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

osmo-sip-connector[master]: Add git review config

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3690
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60f6b29998954b0698e523efaa766f8bb895cdf7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-HasComments: No

[MERGED] osmo-sip-connector[master]: Add git review config

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: Add git review config
..


Add git review config

Change-Id: I60f6b29998954b0698e523efaa766f8bb895cdf7
---
A .gitreview
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  lynxis lazus: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/.gitreview b/.gitreview
new file mode 100644
index 000..19c01e0
--- /dev/null
+++ b/.gitreview
@@ -0,0 +1,4 @@
+[gerrit]
+host=gerrit.osmocom.org
+project=osmo-sip-connector
+

-- 
To view, visit https://gerrit.osmocom.org/3690
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I60f6b29998954b0698e523efaa766f8bb895cdf7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 

[MERGED] osmo-ci[master]: osmocom-nightly-nitb-split.yml: schedule the job to be run a...

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: osmocom-nightly-nitb-split.yml: schedule the job to be run at 
midnight
..


osmocom-nightly-nitb-split.yml: schedule the job to be run at midnight

Change-Id: I0d80e7d260f9092f44d4d80471a4dd67b7acc839
---
M scripts/osmocom-nightly-nitb-split.yml
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Max: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved; Verified



diff --git a/scripts/osmocom-nightly-nitb-split.yml 
b/scripts/osmocom-nightly-nitb-split.yml
index 6c264fd..7dbf46f 100644
--- a/scripts/osmocom-nightly-nitb-split.yml
+++ b/scripts/osmocom-nightly-nitb-split.yml
@@ -17,4 +17,6 @@
   - git:
   url: git://git.osmocom.org/osmo-ci
   git-config-name: 'Jenkins Builder'
-  git-config-email: 'jenk...@osmocom.org
+  git-config-email: 'jenk...@osmocom.org'
+triggers:
+  - timed: "@midnight"

-- 
To view, visit https://gerrit.osmocom.org/3558
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0d80e7d260f9092f44d4d80471a4dd67b7acc839
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Max 

[MERGED] osmo-ci[master]: jenkins: Copy Dockerfile and script from buildhost

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: jenkins: Copy Dockerfile and script from buildhost
..


jenkins: Copy Dockerfile and script from buildhost

We are not using the Docker registry due difficult GPL compliance
but build the image on the build node itself. After prototyping
if containers can be used for building these files remained forked
on the node. These days it seems to be easier to complain than to
say thank you that this new approach has its merits. Copy the files
from the build slave to the directory they should have been in.

Change-Id: Icb0406f96b0c18e77be51ad8317c2668fb23a45e
---
A docker/Dockerfile_osmocom_jenkins.amd64
A docker/rebuild_osmocom_jenkins_image.sh
2 files changed, 71 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/docker/Dockerfile_osmocom_jenkins.amd64 
b/docker/Dockerfile_osmocom_jenkins.amd64
new file mode 100644
index 000..8f33233
--- /dev/null
+++ b/docker/Dockerfile_osmocom_jenkins.amd64
@@ -0,0 +1,69 @@
+FROM debian:jessie
+
+RUN dpkg --add-architecture i386 && \
+DEBIAN_FRONTEND=noninteractive apt-get update && \
+DEBIAN_FRONTEND=noninteractive apt-get upgrade -y && \
+DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends 
wget make
+
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends 
gcc g++ make git
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends 
sudo
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends 
unzip bzip2  python
+
+# match the outside user
+RUN useradd --uid=1000 build
+#RUN echo "build ALL=(ALL) NOPASSWD:ALL" > /etc/sudoers.d/build
+
+RUN mkdir /build
+RUN chown build:build /build
+
+# still generic
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends 
doxygen git asciidoc rsync coccinelle
+
+# for GNU smalltalk
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends 
flex bison libsigsegv-dev libffi-dev texinfo
+
+# libosmo-sccp/abis/etc
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends 
libortp-dev libpcsclite-dev libsctp-dev libfftw3-dev libsnmp-dev  
libusb-1.0-0-dev libtalloc-dev libgnutls28-dev
+
+# OsmocomBB
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends 
gcc-arm-none-eabi
+
+# building
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends 
libtool pkg-config automake autoconf
+
+# Linux kernel
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y bc
+
+# and all
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y doxygen g++ 
libtalloc-dev libpcsclite-dev make gcc pkgconf libtool autoconf 
autoconf-archive automake libortp-dev asciidoc mscgen git libsctp-dev 
libpcap-dev osc libc-ares-dev libgps-dev  libsofia-sip-ua-glib-dev  libssl-dev 
libsqlite3-dev libusb-dev libffi-dev libfftw3-dev flex bison libdbi-dev  
libsnmp-dev libncurses5-dev libgsm1-dev python-minimal python3 libdbd-sqlite3 
cppcheck htop  libgmp-dev gawk texinfo flex bison bc  libsigsegv-dev libffi-dev 
libusb-1.0-0-dev  libreadline-dev debhelper devscripts gcc-arm-none-eabi 
git-buildpackage dh-systemd dh-autoreconf bc openssh-client 
+
+RUN git clone git://git.osmocom.org/python/osmo-python-tests && cd 
osmo-python-tests && python2 ./setup.py install # 2017-03-06
+
+
+RUN echo "#!/bin/sh \n\
+ \n\
+if ! test -d \$1; \n\
+then \n\
+  git clone git://git.osmocom.org/\$1 \$1 \n\
+fi \n\
+\n\
+cd \$1 \n\
+git fetch origin \n\
+git reset --hard origin/master" > /usr/local/bin/osmo-deps.sh
+RUN chmod +x /usr/local/bin/osmo-deps.sh
+
+
+RUN git clone http://git.savannah.gnu.org/r/smalltalk.git
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends 
flex libsigsegv-dev bison libgmp-dev texinfo zip libltdl-dev 
+RUN cd smalltalk && autoreconf --install --force && ./configure && make install
+RUN rm -rf smalltalk
+RUN git clone https://github.com/zecke/petitparser.git && cd petitparser && 
gst-package package.xml
+RUN git clone https://github.com/zecke/petitparser-tests.git && cd 
petitparser-tests && gst-package package.xml
+RUN git clone git://git.osmocom.org/smalltalk/osmo-st-logging && cd 
osmo-st-logging && gst-package package.xml
+RUN git clone git://git.osmocom.org/smalltalk/osmo-st-core && cd osmo-st-core 
&& gst-package package.xml
+RUN git clone git://git.osmocom.org/smalltalk/osmo-st-network && cd 
osmo-st-network && gst-package package.xml
+RUN git clone git://git.osmocom.org/smalltalk/osmo-st-gsm && cd osmo-st-gsm && 
gst-package --test package.xml
+RUN git clone git://git.osmocom.org/smalltalk/osmo-st-openbsc-test && cd 
osmo-st-openbsc-test/fakebts && gst-package --test package.xml
+RUN rm -rf petitparser petitparser-tests osmo-st-logging ost-st-core 
osmo-st-network osmo-st-gsm osmo-st-openbsc-test
+RUN 

[MERGED] osmo-ci[master]: scripts: add requirements.txt to list jenkins-job-builder

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: scripts: add requirements.txt to list jenkins-job-builder
..


scripts: add requirements.txt to list jenkins-job-builder

Change-Id: If25ce84593bbf6a393928a8f4e1670f320c48ca4
---
A scripts/requirements.txt
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/scripts/requirements.txt b/scripts/requirements.txt
new file mode 100644
index 000..6b700dc
--- /dev/null
+++ b/scripts/requirements.txt
@@ -0,0 +1 @@
+jenkins-job-builder

-- 
To view, visit https://gerrit.osmocom.org/3559
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If25ce84593bbf6a393928a8f4e1670f320c48ca4
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Max 

osmo-ci[master]: jenkins: Copy Dockerfile and script from buildhost

[Harald Welte]

Patch Set 1: Code-Review+2 Verified+1

-- 
To view, visit https://gerrit.osmocom.org/3675
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0406f96b0c18e77be51ad8317c2668fb23a45e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: neels 
Gerrit-HasComments: No

osmo-bts[master]: Bump version: 0.5.0 → 0.6.0

[Harald Welte]

Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3598
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I613d09ae0f9f0aa67be1dc6015da1fb9314110fd
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[MERGED] osmo-bts[master]: Bump version: 0.5.0 → 0.6.0

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: Bump version: 0.5.0 → 0.6.0
..


Bump version: 0.5.0 → 0.6.0

Change-Id: I613d09ae0f9f0aa67be1dc6015da1fb9314110fd
---
M debian/changelog
1 file changed, 482 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/debian/changelog b/debian/changelog
index 5c2d203..61c46c6 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,4 +1,485 @@
-osmo-bts (0.5.0) UNRELEASED; urgency=medium
+osmo-bts (0.6.0) unstable; urgency=medium
+
+  [ Holger Hans Peter Freyther ]
+  * Initial release.
+  * misc: Ignore files generated by a debian packaging build
+  * jenkins: Add the build script from jenkins here
+  * jenkins: Add the build script from jenkins here
+  * sysmobts: Add the barebox boot state reservation
+  * sysmobts: Fix eeprom padding before gpg key
+  * ci/spatch: Remove the "static" analysis handling
+  * oct: Attempt to enable the Octphy for the osmo-bts-oct build
+  * debian: Use the header files installed by openbsc-dev
+  * build: Do not require more headers from OpenBSC
+  * sysmobts: Make reservation for mode/netmask/ip and suc
+  * sysmobts: Store a simple network config in the EEPROM as well
+
+  [ Max ]
+  * Ensure TRX invariant
+  * Use libosmocore function for uplink measurements
+  * Fix debug output
+  * Fix RTP timestamps in case of DTX
+  * Add DTXd support for sysmoBTS and LC15
+  * Use libosmocodec for AMR RTP
+  * octphy: Use the app. info. defaults as base
+  * Fix debug output
+  * DTXd: store/repeat last SID
+  * DTXd: store/repeat last SID
+  * DTXu: mark beginning of speech burst in RTP
+  * Fix OML activation
+  * TRX: Add vty command to power on/off transceiver
+  * TRX: add configuration example
+  * Add .gitreview
+  * DTX: add support for AMR/HR
+  * Move copy-pasted code into common part
+  * Use libosmocodec functions for AMR
+  * Use error values instead of number for RSL error
+  * Clarify logging message
+  * Make get_lchan_by_chan_nr globally available
+  * DTXu: move copy-pasted code to common part
+  * Remove duplicated nibble shift code
+  * TRX: add Uplink DTX support for FR/HR
+  * Mark array as static const
+  * sysmobts: dump PRACH and PTCCH parameters
+  * Activate PTCCH UL
+  * Fix dsp tracing at phy config
+  * octphy: fix build
+  * Fill measurements data for L1SAP
+  * sysmo: ts_connect: log channel combination name instead of number
+  * DTX: fix last SID saving
+  * DTX: fix SID repeat scheduling
+  * DTX: fix SID logic
+  * lc15, sysmo: Use SID_FIRST_P1 to initiate DTX
+  * DTX: check Marker bit to send ONSET to L1
+  * DTX: remove misleading comment
+  * LC15: Clarify msgb ownership / fix memory leaks
+  * DTX: move scheduling check inside repeat_last_sid
+  * DTX: further AMR SID cache fixes (lc15, sysmo)
+  * DTX: move ONSET detection into separate function
+  * DTX: send AMR voice alongside with ONSET
+  * DTX: fix conversion from fn to ms
+  * Move copy-pasted array into shared header
+  * DTX DL: use FSM for AMR
+  * TRX: fix building with latest DTX changes
+  * DTX: fix array size calculation
+  * DTX AMR - fix buffer length check
+  * Replace magic number with define
+  * Fix lc15 build
+  * Extend RTP RX callback parameters
+  * DTX HR - fix array size calculation
+  * Fix DTX DL AMR SIDscheduling logic
+  * Add tools to check DTX operation
+  * DTX DL: split ONSET state handling
+  * Remove obsolete define
+  * DTX DL: add AMR HR support to scheduling check
+  * DTX fix ONSET handling
+  * dtx_check.gawk: Fix false-positives in DTX check
+  * Fix tests linking with libosmocodec
+  * DTX DL: tighten check for enabled operation
+  * DTX: wrap FSM signal dispatching
+  * Add libosmocodec for octphy build
+  * dtx_check.gawk: add check for repetitive SID FIRST
+  * Remove duplicated code
+  * Replace link_id constant with define
+  * DTX DL AMR: rewrite FSM recursion
+  * Remove duplicated code
+  * Fix AGCH/PCH proportional allocation
+  * TRX: prevent segfault upon phy init
+  * DTX: add explicit check if DTX enabled
+  * Save RTP metadata in Control Buffer
+  * osmo-bts-trx: fix lchan deactivation
+  * DTX: fix TS adjustment for ONSET
+  * Optionally use adaptive RTP jitter buffering
+  * Integrate Debian packaging changes
+  * DTX AMR HR: fix inhibition
+  * Add copyright for .deb packages
+  * Move code to libosmocore
+  * Log socket path on error
+  * Add Abis OML failure event reporting
+  * Alarm on various errors
+  * Remove obsolete define TLVP_PRES_LEN
+  * scheduler: log lchan on which prim error occured
+  * deb: use gsm_data_shared.* from openbsc-dev
+  * OML: internalize failure reporting
+  * Add ctrl command to send OML alert
+  * Fix typo in TCH/H interleaving table
+  * Use oml-alert CTRL command for temp report
+  * Remove code duplication
+  * Handle ctrl cmd allocation failures
+  * Check for suitable lchan type 

[MERGED] osmo-bts[master]: Add git-version-gen snippet

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: Add git-version-gen snippet
..


Add git-version-gen snippet

Change-Id: Id1732921ecb768b3c3c4872b82b74ccc3d26cf77
Related: OS#1861
---
M Makefile.am
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/Makefile.am b/Makefile.am
index 5c1add6..4832c84 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -15,6 +15,14 @@
doc/examples/sysmo/sysmobts-mgr.cfg \
doc/examples/virtual/openbsc-virtual.cfg \
doc/examples/virtual/osmobts-virtual.cfg \
+   git-version-gen .version \
README.md
 
 @RELMAKE@
+
+BUILT_SOURCES = $(top_srcdir)/.version
+
+$(top_srcdir)/.version:
+   echo $(VERSION) > $@-t && mv $@-t $@
+dist-hook:
+   echo $(VERSION) > $(distdir)/.tarball-version

-- 
To view, visit https://gerrit.osmocom.org/3678
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id1732921ecb768b3c3c4872b82b74ccc3d26cf77
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

osmo-bts[master]: Add git-version-gen snippet

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3678
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1732921ecb768b3c3c4872b82b74ccc3d26cf77
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

libosmo-abis[master]: Bump version: 0.3.2 → 0.4.0

[Harald Welte]

Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3595
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibefe53a7f5b06fb8a9294574af41dacac68bdbe9
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[MERGED] libosmo-abis[master]: Bump version: 0.3.2 → 0.4.0

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: Bump version: 0.3.2 → 0.4.0
..


Bump version: 0.3.2 → 0.4.0

Change-Id: Ibefe53a7f5b06fb8a9294574af41dacac68bdbe9
---
M TODO-RELEASE
M debian/changelog
M src/Makefile.am
3 files changed, 18 insertions(+), 8 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/TODO-RELEASE b/TODO-RELEASE
index 128778a..d0852fc 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -1,4 +1,9 @@
+# When cleaning up this file: bump API version in corresponding Makefile.am 
and rename corresponding debian/lib*.install
+# according to 
https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html#Updating-version-info
+# In short:
+# LIBVERSION=c:r:a
+# If the library source code has changed at all since the last update, then 
increment revision: c:r + 1:a.
+# If any interfaces have been added, removed, or changed since the last 
update: c + 1:0:0.
+# If any interfaces have been added since the last public release: c:r:a + 1.
+# If any interfaces have been removed or changed since the last public 
release: c:r:0.
 #library   whatdescription / commit summary line
-libosmo-abis   API change  major: add parameter to rx_cb() callack in 
osmo_ortp.h
-libosmo-abis   API change  major: add parameter to struct input_signal_data
-libosmo-abis   API change  major: add parameters to rx_cb() callack in 
osmo_ortp.h
diff --git a/debian/changelog b/debian/changelog
index b2cf0e9..13c0996 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,8 +1,12 @@
-libosmo-abis (0.3.3) UNRELEASED; urgency=medium
+libosmo-abis (0.4.0) unstable; urgency=medium
 
   * Move forward towards a new release.
+  * libosmo-abis   API change  major: add parameter to struct
+input_signal_data
+  * libosmo-trau   API change  major: add parameters to rx_cb()
+callack in osmo_ortp.h
 
- -- Holger Hans Peter Freyther   Tue, 24 May 2016 
23:02:47 +0200
+ -- Holger Hans Peter Freyther   Fri, 25 Aug 2017 
16:09:46 +0200
 
 libosmo-abis (0.3.2) unstable; urgency=medium
 
diff --git a/src/Makefile.am b/src/Makefile.am
index 760c1f5..7395d17 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1,7 +1,8 @@
 # This is _NOT_ the library release version, it's an API version.
-# Please read Chapter 6 "Library interface versions" of the libtool 
documentation before making any modification
-ABIS_LIBVERSION=5:0:0
-TRAU_LIBVERSION=1:0:0
+# Please read chapter "Library interface versions" of the libtool documentation
+# before making any modifications: 
https://www.gnu.org/software/libtool/manual/html_node/Versioning.html
+ABIS_LIBVERSION=6:0:0
+TRAU_LIBVERSION=2:0:0
 
 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)
 AM_CFLAGS= -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) 
$(LIBOSMOVTY_CFLAGS) $(COVERAGE_CFLAGS)

-- 
To view, visit https://gerrit.osmocom.org/3595
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibefe53a7f5b06fb8a9294574af41dacac68bdbe9
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder

osmo-sip-connector[master]: Add git review config

[lynxis lazus]

Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.osmocom.org/3690
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60f6b29998954b0698e523efaa766f8bb895cdf7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-HasComments: No

[PATCH] osmo-sip-connector[master]: Use release helper from libosmocore

[Max]

Review at  https://gerrit.osmocom.org/3691

Use release helper from libosmocore

Change-Id: I1a65695d6191aa7647b9872e58da4a00bbad59e2
Related: OS#1861
---
M .gitignore
M Makefile.am
M configure.ac
3 files changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector 
refs/changes/91/3691/1

diff --git a/.gitignore b/.gitignore
index f8fa410..87bed96 100644
--- a/.gitignore
+++ b/.gitignore
@@ -20,3 +20,5 @@
 stamp-h1
 
 osmo-sip-connector
+.tarball-version
+.version
diff --git a/Makefile.am b/Makefile.am
index abb1d66..5a2c4a9 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -4,6 +4,9 @@
 
 BUILT_SOURCES = $(top_srcdir)/.version
 EXTRA_DIST = git-version-gen osmoappdesc.py .version
+
+@RELMAKE@
+
 $(top_srcdir)/.version:
echo $(VERSION) > $@-t && mv $@-t $@
 dist-hook:
diff --git a/configure.ac b/configure.ac
index 1fa6157..35a75b9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -14,6 +14,10 @@
 fi
 PKG_PROG_PKG_CONFIG([0.20])
 
+dnl include release helper
+RELMAKE='-include osmo-release.mk'
+AC_SUBST([RELMAKE])
+
 dnl kernel style compile messages
 m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
 AC_PROG_CC

-- 
To view, visit https://gerrit.osmocom.org/3691
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a65695d6191aa7647b9872e58da4a00bbad59e2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Owner: Max 

[PATCH] osmo-sip-connector[master]: Add git review config

[Max]

Review at  https://gerrit.osmocom.org/3690

Add git review config

Change-Id: I60f6b29998954b0698e523efaa766f8bb895cdf7
---
A .gitreview
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector 
refs/changes/90/3690/1

diff --git a/.gitreview b/.gitreview
new file mode 100644
index 000..19c01e0
--- /dev/null
+++ b/.gitreview
@@ -0,0 +1,4 @@
+[gerrit]
+host=gerrit.osmocom.org
+project=osmo-sip-connector
+

-- 
To view, visit https://gerrit.osmocom.org/3690
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I60f6b29998954b0698e523efaa766f8bb895cdf7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Owner: Max 

[PATCH] osmo-hlr[master]: Use release helper from libosmocore

[Max]

Review at  https://gerrit.osmocom.org/3689

Use release helper from libosmocore

Change-Id: I06b9ceff1e1ecfccc1b1a52ffe6b9d3f6dcaa34d
Related: OS#1861
---
M Makefile.am
M configure.ac
2 files changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/89/3689/1

diff --git a/Makefile.am b/Makefile.am
index 0d60cee..392d80d 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -10,6 +10,8 @@
.version \
$(NULL)
 
+@RELMAKE@
+
 BUILT_SOURCES = $(top_srcdir)/.version
 $(top_srcdir)/.version:
echo $(VERSION) > $@-t && mv $@-t $@
diff --git a/configure.ac b/configure.ac
index 958b48b..6532940 100644
--- a/configure.ac
+++ b/configure.ac
@@ -15,6 +15,10 @@
 dnl kernel style compile messages
 m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
 
+dnl include release helper
+RELMAKE='-include osmo-release.mk'
+AC_SUBST([RELMAKE])
+
 dnl checks for programs
 AC_PROG_MAKE_SET
 AC_PROG_MKDIR_P

-- 
To view, visit https://gerrit.osmocom.org/3689
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I06b9ceff1e1ecfccc1b1a52ffe6b9d3f6dcaa34d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Max 

libosmocore[master]: Use value string check from osmo-ci

[Max]

Patch Set 3:

N. B: this should be merged last, after all the repos converted to check script 
from osmo-ci.

-- 
To view, visit https://gerrit.osmocom.org/3685
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I513835be2d931d0a931cdfc996f361a451bc1a15
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

[PATCH] libosmocore[master]: Use value string check from osmo-ci

[Max]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/3685

to look at the new patch set (#3).

Use value string check from osmo-ci

Change-Id: I513835be2d931d0a931cdfc996f361a451bc1a15
---
M contrib/jenkins-arm.sh
M contrib/jenkins.sh
D contrib/verify_value_string_arrays_are_terminated.py
3 files changed, 4 insertions(+), 36 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/85/3685/3

diff --git a/contrib/jenkins-arm.sh b/contrib/jenkins-arm.sh
index 510b0e9..ad992af 100755
--- a/contrib/jenkins-arm.sh
+++ b/contrib/jenkins-arm.sh
@@ -2,7 +2,7 @@
 
 set -ex
 
-./contrib/verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
+verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
 
 autoreconf --install --force
 ./configure --enable-static \
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 6a72840..4a26776 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -1,8 +1,9 @@
-#!/usr/bin/env bash
+#!/bin/sh
+# jenkins build helper script for libosmo-sccp.  This is how we build on 
jenkins.osmocom.org
 
 set -ex
 
-./contrib/verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
+verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
 
 if [ "x$label" = "xFreeBSD_amd64" ]; then
 ENABLE_SANITIZE=""
diff --git a/contrib/verify_value_string_arrays_are_terminated.py 
b/contrib/verify_value_string_arrays_are_terminated.py
deleted file mode 100755
index 020bb4d..000
--- a/contrib/verify_value_string_arrays_are_terminated.py
+++ /dev/null
@@ -1,33 +0,0 @@
-#!/usr/bin/env python3
-# vim: expandtab tabstop=2 shiftwidth=2 nocin
-
-'''
-Usage:
-  verify_value_string_arrays_are_terminated.py PATH [PATH [...]]
-
-e.g.
-libosmocore/contrib/verify_value_string_arrays_are_terminated.py $(find . 
-name "*.[hc]")
-'''
-
-import re
-import sys
-import codecs
-
-value_string_array_re = re.compile(
-  r'((\bstruct\s+value_string\b[^{;]*?)\s*=[^{;]*{[^;]*}\s*;)',
-  re.MULTILINE | re.DOTALL)
-
-members = r'(\.(value|str)\s*=\s*)?'
-terminator_re = re.compile('{\s*' + members + '(0|NULL)\s*,'
-   '\s*' + members + '(0|NULL)\s*}')
-errors_found = 0
-
-for f in sys.argv[1:]:
-  arrays = value_string_array_re.findall(codecs.open(f, "r", "utf-8").read())
-  for array_def, name in arrays:
-if not terminator_re.search(array_def):
-  print('ERROR: file contains unterminated value_string %r: %r'
-% (name, f))
-  errors_found += 1
-
-sys.exit(errors_found)

-- 
To view, visit https://gerrit.osmocom.org/3685
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I513835be2d931d0a931cdfc996f361a451bc1a15
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 

[PATCH] osmo-iuh[master]: Use value string check from osmo-ci

[Max]

Review at  https://gerrit.osmocom.org/3688

Use value string check from osmo-ci

Change-Id: I9fc4a0ce4ca29f8b76e189d040097f3e63298ba5
---
M contrib/jenkins.sh
1 file changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/88/3688/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index b500e1c..cda0e2c 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -1,4 +1,4 @@
-#!/usr/bin/env bash
+#!/bin/sh
 
 set -ex
 
@@ -10,13 +10,12 @@
 mkdir "$deps" || true
 rm -rf "$inst"
 
-osmo-build-dep.sh libosmocore
-
-"$deps"/libosmocore/contrib/verify_value_string_arrays_are_terminated.py 
$(find . -name "*.[hc]")
+verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
 
 export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH"
 export LD_LIBRARY_PATH="$inst/lib"
 
+osmo-build-dep.sh libosmocore
 osmo-build-dep.sh libosmo-abis
 osmo-build-dep.sh libosmo-netif
 osmo-build-dep.sh libosmo-sccp

-- 
To view, visit https://gerrit.osmocom.org/3688
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fc4a0ce4ca29f8b76e189d040097f3e63298ba5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Max 

[PATCH] osmo-hlr[master]: Use value string check from osmo-ci

[Max]

Review at  https://gerrit.osmocom.org/3687

Use value string check from osmo-ci

Change-Id: I56ea5be60d2a3cf8442f58e1121b13074e2e6a08
---
M contrib/jenkins.sh
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/87/3687/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 12b2be9..e2abb60 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -17,13 +17,12 @@
 mkdir "$deps" || true
 rm -rf "$inst"
 
+verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
+
 export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH"
 export LD_LIBRARY_PATH="$inst/lib"
 
 osmo-build-dep.sh libosmocore "" ac_cv_path_DOXYGEN=false
-
-"$deps"/libosmocore/contrib/verify_value_string_arrays_are_terminated.py 
$(find . -name "*.[hc]")
-
 osmo-build-dep.sh libosmo-abis
 
 set +x

-- 
To view, visit https://gerrit.osmocom.org/3687
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I56ea5be60d2a3cf8442f58e1121b13074e2e6a08
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Max 

[PATCH] libosmocore[master]: Use value string check from osmo-ci

[Max]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/3685

to look at the new patch set (#2).

Use value string check from osmo-ci

Change-Id: I513835be2d931d0a931cdfc996f361a451bc1a15
---
M contrib/jenkins-arm.sh
M contrib/jenkins.sh
2 files changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/85/3685/2

diff --git a/contrib/jenkins-arm.sh b/contrib/jenkins-arm.sh
index 510b0e9..ad992af 100755
--- a/contrib/jenkins-arm.sh
+++ b/contrib/jenkins-arm.sh
@@ -2,7 +2,7 @@
 
 set -ex
 
-./contrib/verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
+verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
 
 autoreconf --install --force
 ./configure --enable-static \
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 6a72840..4a26776 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -1,8 +1,9 @@
-#!/usr/bin/env bash
+#!/bin/sh
+# jenkins build helper script for libosmo-sccp.  This is how we build on 
jenkins.osmocom.org
 
 set -ex
 
-./contrib/verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
+verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
 
 if [ "x$label" = "xFreeBSD_amd64" ]; then
 ENABLE_SANITIZE=""

-- 
To view, visit https://gerrit.osmocom.org/3685
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I513835be2d931d0a931cdfc996f361a451bc1a15
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder

[PATCH] libosmo-sccp[master]: Use value string check from osmo-ci

[Max]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/3684

to look at the new patch set (#2).

Use value string check from osmo-ci

Change-Id: I1a2223b1a059fbb832948decf11f9237fad389f2
---
M contrib/jenkins.sh
1 file changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/84/3684/2

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 38c1134..ae850ed 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -1,4 +1,4 @@
-#!/usr/bin/env bash
+#!/bin/sh
 # jenkins build helper script for libosmo-sccp.  This is how we build on 
jenkins.osmocom.org
 
 if ! [ -x "$(command -v osmo-build-dep.sh)" ]; then
@@ -17,13 +17,12 @@
 mkdir "$deps" || true
 rm -rf "$inst"
 
-osmo-build-dep.sh libosmocore
-
-"$deps"/libosmocore/contrib/verify_value_string_arrays_are_terminated.py 
$(find . -name "*.[hc]")
+verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
 
 export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH"
 export LD_LIBRARY_PATH="$inst/lib"
 
+osmo-build-dep.sh libosmocore
 osmo-build-dep.sh libosmo-abis
 osmo-build-dep.sh libosmo-netif
 

-- 
To view, visit https://gerrit.osmocom.org/3684
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1a2223b1a059fbb832948decf11f9237fad389f2
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 

[PATCH] libosmo-netif[master]: Use value string check from osmo-ci

[Max]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/3683

to look at the new patch set (#2).

Use value string check from osmo-ci

Change-Id: Id6048a69c9e0cc15010de643330aeb2a7271b2a6
---
M contrib/jenkins.sh
1 file changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/83/3683/2

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 2231efc..3e35a46 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -1,4 +1,4 @@
-#!/usr/bin/env bash
+#!/bin/sh
 # jenkins build helper script for libosmo-netif.  This is how we build on 
jenkins.osmocom.org
 
 if ! [ -x "$(command -v osmo-build-dep.sh)" ]; then
@@ -17,13 +17,12 @@
 mkdir "$deps" || true
 rm -rf "$inst"
 
-osmo-build-dep.sh libosmocore
-
-"$deps"/libosmocore/contrib/verify_value_string_arrays_are_terminated.py 
$(find . -name "*.[hc]")
+verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
 
 export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH"
 export LD_LIBRARY_PATH="$inst/lib"
 
+osmo-build-dep.sh libosmocore
 osmo-build-dep.sh libosmo-abis
 
 set +x

-- 
To view, visit https://gerrit.osmocom.org/3683
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id6048a69c9e0cc15010de643330aeb2a7271b2a6
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 

[PATCH] openggsn[master]: Use value string check from osmo-ci

[Max]

Review at  https://gerrit.osmocom.org/3686

Use value string check from osmo-ci

Change-Id: I036ed452826b9a6848d22d45bdcc95e20a110b8b
---
M contrib/jenkins.sh
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openggsn refs/changes/86/3686/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 30416b2..71ba909 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -1,6 +1,8 @@
-#!/usr/bin/env bash
+#!/bin/sh
 
 set -ex
+
+verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
 
 mkdir deps || true
 cd deps
@@ -12,8 +14,6 @@
 $MAKE $PARALLEL_MAKE install
 
 cd ../../
-
-deps/libosmocore/contrib/verify_value_string_arrays_are_terminated.py $(find . 
-name "*.[hc]")
 
 autoreconf --install --force
 PKG_CONFIG_PATH=$PWD/deps/install/lib/pkgconfig:$PKG_CONFIG_PATH ./configure

-- 
To view, visit https://gerrit.osmocom.org/3686
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I036ed452826b9a6848d22d45bdcc95e20a110b8b
Gerrit-PatchSet: 1
Gerrit-Project: openggsn
Gerrit-Branch: master
Gerrit-Owner: Max 

[PATCH] libosmocore[master]: Use value string check from osmo-ci

[Max]

Review at  https://gerrit.osmocom.org/3685

Use value string check from osmo-ci

Change-Id: I513835be2d931d0a931cdfc996f361a451bc1a15
---
M contrib/jenkins.sh
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/85/3685/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 6a72840..4a26776 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -1,8 +1,9 @@
-#!/usr/bin/env bash
+#!/bin/sh
+# jenkins build helper script for libosmo-sccp.  This is how we build on 
jenkins.osmocom.org
 
 set -ex
 
-./contrib/verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
+verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
 
 if [ "x$label" = "xFreeBSD_amd64" ]; then
 ENABLE_SANITIZE=""

-- 
To view, visit https://gerrit.osmocom.org/3685
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I513835be2d931d0a931cdfc996f361a451bc1a15
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max 

[PATCH] libosmo-sccp[master]: Use value string check from osmo-ci

[Max]

Review at  https://gerrit.osmocom.org/3684

Use value string check from osmo-ci

Change-Id: I1a2223b1a059fbb832948decf11f9237fad389f2
---
M contrib/jenkins.sh
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/84/3684/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 38c1134..747243e 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -17,13 +17,12 @@
 mkdir "$deps" || true
 rm -rf "$inst"
 
-osmo-build-dep.sh libosmocore
-
-"$deps"/libosmocore/contrib/verify_value_string_arrays_are_terminated.py 
$(find . -name "*.[hc]")
+verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
 
 export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH"
 export LD_LIBRARY_PATH="$inst/lib"
 
+osmo-build-dep.sh libosmocore
 osmo-build-dep.sh libosmo-abis
 osmo-build-dep.sh libosmo-netif
 

-- 
To view, visit https://gerrit.osmocom.org/3684
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a2223b1a059fbb832948decf11f9237fad389f2
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Max 

[PATCH] libosmo-netif[master]: Use value string check from osmo-ci

[Max]

Review at  https://gerrit.osmocom.org/3683

Use value string check from osmo-ci

Change-Id: Id6048a69c9e0cc15010de643330aeb2a7271b2a6
---
M contrib/jenkins.sh
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/83/3683/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 2231efc..999d2ce 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -17,9 +17,9 @@
 mkdir "$deps" || true
 rm -rf "$inst"
 
-osmo-build-dep.sh libosmocore
+verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
 
-"$deps"/libosmocore/contrib/verify_value_string_arrays_are_terminated.py 
$(find . -name "*.[hc]")
+osmo-build-dep.sh libosmocore
 
 export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH"
 export LD_LIBRARY_PATH="$inst/lib"

-- 
To view, visit https://gerrit.osmocom.org/3683
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6048a69c9e0cc15010de643330aeb2a7271b2a6
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Owner: Max 

[PATCH] libosmo-abis[master]: Use value string check from osmo-ci

[Max]

Review at  https://gerrit.osmocom.org/3682

Use value string check from osmo-ci

Change-Id: I60d480ce6fb761ac8e15318dbe2c591359a51c3c
---
M contrib/jenkins.sh
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/82/3682/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 769d5a7..6ff44ee 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -16,9 +16,9 @@
 mkdir "$deps" || true
 rm -rf "$inst"
 
-osmo-build-dep.sh libosmocore
+verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
 
-"$deps"/libosmocore/contrib/verify_value_string_arrays_are_terminated.py 
$(find . -name "*.[hc]")
+osmo-build-dep.sh libosmocore
 
 export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH"
 export LD_LIBRARY_PATH="$inst/lib"

-- 
To view, visit https://gerrit.osmocom.org/3682
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I60d480ce6fb761ac8e15318dbe2c591359a51c3c
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Owner: Max 

[PATCH] osmo-bts[master]: Use value string check from osmo-ci

[Max]

Review at  https://gerrit.osmocom.org/3681

Use value string check from osmo-ci

Change-Id: I5bce234a5b8133c81b3ea8757e05de56d3aa15d8
---
M contrib/jenkins_common.sh
1 file changed, 2 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/81/3681/1

diff --git a/contrib/jenkins_common.sh b/contrib/jenkins_common.sh
index 78ca0af..c1891b2 100644
--- a/contrib/jenkins_common.sh
+++ b/contrib/jenkins_common.sh
@@ -20,14 +20,7 @@
 mkdir -p "$deps"
 rm -rf "$inst"
 
-cd "$deps"
-
-# Get libosmocore for verify_value_string_arrays_are_terminated.py
-osmo-deps.sh libosmocore
-
-cd "$base"
-
-"$deps"/libosmocore/contrib/verify_value_string_arrays_are_terminated.py 
$(find . -name "*.[hc]")
+verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
 
 # generic project build function, usage:
 # build "PROJECT-NAME" "CONFIGURE OPTIONS"
@@ -41,6 +34,7 @@
 set -x
 
 cd $deps
+osmo-deps.sh libosmocore
 osmo-deps.sh openbsc
 conf_flags="--with-openbsc=$deps/openbsc/openbsc/include"
 cd $base

-- 
To view, visit https://gerrit.osmocom.org/3681
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bce234a5b8133c81b3ea8757e05de56d3aa15d8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max 

[MERGED] osmo-gsm-tester[master]: default-suites.conf: Add suites to explicitly test with sysm...

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged.

Change subject: default-suites.conf: Add suites to explicitly test with 
sysmoCell5000
..


default-suites.conf: Add suites to explicitly test with sysmoCell5000

Change-Id: I6ff08a281c0c32148ca2c59f731d6550bf7b1c90
---
M example/default-suites.conf
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/example/default-suites.conf b/example/default-suites.conf
index 4904844..0198486 100644
--- a/example/default-suites.conf
+++ b/example/default-suites.conf
@@ -2,6 +2,8 @@
 - aoip_sms:sysmo
 - sms:trx-b200
 - aoip_sms:trx-b200
+- sms:trx-sysmocell5000
+- aoip_sms:trx-sysmocell5000
 - smpp
 - aoip_smpp
 - aoip_encryption

-- 
To view, visit https://gerrit.osmocom.org/3589
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6ff08a281c0c32148ca2c59f731d6550bf7b1c90
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 

libosmo-netif[master]: osmux: Re-write osmux_snprintf

[Pau Espin Pedrol]

Patch Set 1:

> @Pau: You're not the only one getting confused with it, snprintf()
 > is a mess, it's hard to deal with it, hence this macro that retains
 > semantics that aims to simplify things... if you find any better,
 > let me know I'd be happy to reuse it in my code moving forward :-).
 > 
 > @Holger: Either way, I don't mind if you don't need the snprintf
 > semantics, this is a _snprintf() function after all, just explaning
 > here. So the intention at least that I can remember was to keep in
 > sync with how snprintf() works. Anyway, feel free to simplify this.
 > 

Even if the intention was to follow snprintf, as far as I can tell it doesn't 
seem to be actually working correctly. Implementation previous to this patch 
returns offset in all functions. offset var is always calculated using this 
part of the macro:
if (ret > len)  \
ret = len;  \
offset += ret;  \

Which means offset is never going to be bigger than the "size" originally 
passed as parameter. That's correct as offset marks internally next position to 
write in the buffer, but should not be the var being returned as it's always <= 
size even if size of buffer is smaller than required size.

In exchange, size (from the variable) should be initialized to 0 at the start 
of each function after assigning len = size, then return size in each function. 
This could be called "count" instead of "size" to avoid confusion with "size in 
parameter. Actually, I don't really understand what's the usage of the "size" 
variable as used currently, which starts having size of the buffer (used or 
not) and keeps growing.

On top of that, I have the feeling the previous implementation doesn't handle 
the case where snprintf returns negative value (error). So even after all those 
modifications, we still need to add extra logic to handle that. In nftables 
code it seems to be handled by calling abort(), which doesn't seem like a 
perfect approach in any case. It's not nice having libraries calling abort().

 > Anyway, I just wanted to make sure this patch was really fixing up
 > the real issue. I understand you observe a crash, but not clear to
 > me why the patch is fixing it.
 > 
 > Cheers.


I try to fix all this corner cases explained above in this patch. I started 
looking again today at following a more conservative approach, like fixing step 
by step the current code, but as far as I can tell doesn't make sense, as 
there's a lot of stuff which needs changes.

So, if there's no more objections to this patch, during following days I'll 
push a new version with the description fixes as advised by Holger, and we can 
then merge it.

-- 
To view, visit https://gerrit.osmocom.org/3537
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I695771d099833842db37a415b636035d17f1bba7
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pablo Neira Ayuso 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

[ABANDON] libosmo-abis[master]: Bump version: 0.3.2 → 0.4.0

[Max]

Max has abandoned this change.

Change subject: Bump version: 0.3.2 → 0.4.0
..


Abandoned

-- 
To view, visit https://gerrit.osmocom.org/3596
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I6f0ac8377adeccd4c56555cdc16768973c1f0876
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: neels 

[PATCH] libosmo-abis[master]: Bump version: 0.3.2 → 0.4.0

[Max]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/3595

to look at the new patch set (#2).

Bump version: 0.3.2 → 0.4.0

Change-Id: Ibefe53a7f5b06fb8a9294574af41dacac68bdbe9
---
M TODO-RELEASE
M debian/changelog
M src/Makefile.am
3 files changed, 18 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/95/3595/2

diff --git a/TODO-RELEASE b/TODO-RELEASE
index 128778a..d0852fc 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -1,4 +1,9 @@
+# When cleaning up this file: bump API version in corresponding Makefile.am 
and rename corresponding debian/lib*.install
+# according to 
https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html#Updating-version-info
+# In short:
+# LIBVERSION=c:r:a
+# If the library source code has changed at all since the last update, then 
increment revision: c:r + 1:a.
+# If any interfaces have been added, removed, or changed since the last 
update: c + 1:0:0.
+# If any interfaces have been added since the last public release: c:r:a + 1.
+# If any interfaces have been removed or changed since the last public 
release: c:r:0.
 #library   whatdescription / commit summary line
-libosmo-abis   API change  major: add parameter to rx_cb() callack in 
osmo_ortp.h
-libosmo-abis   API change  major: add parameter to struct input_signal_data
-libosmo-abis   API change  major: add parameters to rx_cb() callack in 
osmo_ortp.h
diff --git a/debian/changelog b/debian/changelog
index b2cf0e9..13c0996 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,8 +1,12 @@
-libosmo-abis (0.3.3) UNRELEASED; urgency=medium
+libosmo-abis (0.4.0) unstable; urgency=medium
 
   * Move forward towards a new release.
+  * libosmo-abis   API change  major: add parameter to struct
+input_signal_data
+  * libosmo-trau   API change  major: add parameters to rx_cb()
+callack in osmo_ortp.h
 
- -- Holger Hans Peter Freyther   Tue, 24 May 2016 
23:02:47 +0200
+ -- Holger Hans Peter Freyther   Fri, 25 Aug 2017 
16:09:46 +0200
 
 libosmo-abis (0.3.2) unstable; urgency=medium
 
diff --git a/src/Makefile.am b/src/Makefile.am
index 760c1f5..7395d17 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1,7 +1,8 @@
 # This is _NOT_ the library release version, it's an API version.
-# Please read Chapter 6 "Library interface versions" of the libtool 
documentation before making any modification
-ABIS_LIBVERSION=5:0:0
-TRAU_LIBVERSION=1:0:0
+# Please read chapter "Library interface versions" of the libtool documentation
+# before making any modifications: 
https://www.gnu.org/software/libtool/manual/html_node/Versioning.html
+ABIS_LIBVERSION=6:0:0
+TRAU_LIBVERSION=2:0:0
 
 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)
 AM_CFLAGS= -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) 
$(LIBOSMOVTY_CFLAGS) $(COVERAGE_CFLAGS)

-- 
To view, visit https://gerrit.osmocom.org/3595
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibefe53a7f5b06fb8a9294574af41dacac68bdbe9
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder

[PATCH] libosmocore[master]: Update release helper

[Max]

Review at  https://gerrit.osmocom.org/3680

Update release helper

* add reference to semver spec
* use 'patch' release by default
* unify debian/changelog distro update for library and non-library
  projects
* abort library release for non-empty TODO-RELEASE if libversion is not
  modified

Change-Id: I413f99cbfa6e6dcc753e3be9fc3c8d682e6a41f3
Related: OS#1861
---
M osmo-release.mk
1 file changed, 26 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/80/3680/1

diff --git a/osmo-release.mk b/osmo-release.mk
index 3fe6803..03eb3cb 100644
--- a/osmo-release.mk
+++ b/osmo-release.mk
@@ -1,28 +1,39 @@
-ifdef REL
-NEW_VERSION := $(shell bumpversion --list --current-version $(VERSION) $(REL) 
--allow-dirty | awk -F '=' '{ print $$2 }')
-LIBVERS := $(shell git grep -n LIBVERSION | grep  '=' | grep am | grep -v 
LDFLAGS)
-ISODATE := $(shell date -I)
+ifndef REL
+   REL := patch
 endif
 
+NEW_VER := $(shell bumpversion --list --current-version $(VERSION) $(REL) 
--allow-dirty | awk -F '=' '{ print $$2 }')
+LIBVERS := $(shell git grep -n LIBVERSION | grep  '=' | grep am | grep -v 
LDFLAGS)
+MAKEMOD := $(shell git diff -GLIBVERSION --stat | grep Makefile.am)
+ISODATE := $(shell date -I)
+
 release:
-ifeq ($(NEW_VERSION),)
-   @$(error Failed to determine NEW_VERSION - please fix versioning 
(current is $(VERSION)) before proceeding with the release)
+
+ifeq ($(NEW_VER),)
+   @$(error Please fix versioning to match http://semver.org/ spec 
(current is $(VERSION)) before proceeding.)
 endif
-   @echo "Releasing" $(VERSION) "->" $(NEW_VERSION)"..."
+
+ifeq ($(origin REL), file)
+   @echo "No REL value specified, defaulting to 'patch' release"
+endif
+
+   @echo "Releasing" $(VERSION) "->" $(NEW_VER)"..."
+
 ifeq ($(LIBVERS),)
@gbp dch --debian-tag='%(version)s' --auto --meta --git-author 
--multimaint-merge --ignore-branch
 else
@echo "You should NOT be doing this unless you've read and understood 
following article:"
@echo 
"https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html#Updating-version-info;
-   @grep -v '#' TODO-RELEASE | sed 's/\t\+/:/g' | xargs -d'\n' -I entry 
dch -m -v $(NEW_VERSION) "entry"
-   @dch -r -m --distribution "unstable" ""
+   @grep -v '#' TODO-RELEASE | sed 's/\t\+/: /g' > TODO-RELEASE.entries
@grep '#' TODO-RELEASE > TODO-RELEASE.clean
@mv TODO-RELEASE.clean TODO-RELEASE
-   @echo "Do NOT push the release commit if you have not adjusted 
LIBVERSION in preceeding commit!!!"
-   @echo "Are you sure the following versions are correct?"
-   @echo $(LIBVERS)
+ifeq ($(MAKEMOD),)
+   @$(if $(shell git status -s -uno TODO-RELEASE),,$(error Before 
releasing, please modify some of the libversions: $(LIBVERS)))
 endif
+   @xargs -a TODO-RELEASE.entries -r -d'\n' -I entry dch -m -v $(NEW_VER) 
"entry"
+endif
+   @dch -r -m --distribution "unstable" ""
@git add -u
-   @bumpversion --current-version $(VERSION) $(REL) --tag --commit 
--tag-name $(NEW_VERSION) --allow-dirty
-   @git tag -s $(NEW_VERSION) -f -m "Release v$(NEW_VERSION) on 
$(ISODATE)."
-   @echo "Release" $(NEW_VERSION) "prepared, tagged and signed."
+   @bumpversion --current-version $(VERSION) $(REL) --tag --commit 
--tag-name $(NEW_VER) --allow-dirty
+   @git tag -s $(NEW_VER) -f -m "Release v$(NEW_VER) on $(ISODATE)."
+   @echo "Release" $(NEW_VER) "prepared, tagged and signed."

-- 
To view, visit https://gerrit.osmocom.org/3680
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I413f99cbfa6e6dcc753e3be9fc3c8d682e6a41f3
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max 

[PATCH] osmo-bts[master]: Use git-version-gen from gnulib

[Max]

Review at  https://gerrit.osmocom.org/3679

Use git-version-gen from gnulib

Depend on gnulib package and use upstream's git-version-gen instead of
local copy.

Change-Id: I290acecbbb91f5ee713a035d07e23e7d5c0cf03c
Related: OS#1861
---
M Makefile.am
M configure.ac
M debian/control
D git-version-gen
4 files changed, 3 insertions(+), 153 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/79/3679/1

diff --git a/Makefile.am b/Makefile.am
index 4832c84..0cd5373 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -15,7 +15,7 @@
doc/examples/sysmo/sysmobts-mgr.cfg \
doc/examples/virtual/openbsc-virtual.cfg \
doc/examples/virtual/osmobts-virtual.cfg \
-   git-version-gen .version \
+   .version \
README.md
 
 @RELMAKE@
diff --git a/configure.ac b/configure.ac
index bc36456..d741d2e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,6 +1,6 @@
 dnl Process this file with autoconf to produce a configure script
 AC_INIT([osmo-bts],
-   m4_esyscmd([./git-version-gen .tarball-version]),
+   m4_esyscmd([/usr/share/gnulib/build-aux/git-version-gen 
.tarball-version]),
[openbsc-de...@lists.openbsc.org])
 
 dnl *This* is the root dir, even if an install-sh exists in ../ or ../../
diff --git a/debian/control b/debian/control
index e1a58b2..c7c34d8 100644
--- a/debian/control
+++ b/debian/control
@@ -4,6 +4,7 @@
 Priority: optional
 Build-Depends: debhelper (>= 9),
pkg-config,
+   gnulib,
dh-autoreconf,
dh-systemd (>= 1.5),
autotools-dev,
diff --git a/git-version-gen b/git-version-gen
deleted file mode 100755
index 42cf3d2..000
--- a/git-version-gen
+++ /dev/null
@@ -1,151 +0,0 @@
-#!/bin/sh
-# Print a version string.
-scriptversion=2010-01-28.01
-
-# Copyright (C) 2007-2010 Free Software Foundation, Inc.
-#
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 3 of the License, or
-# (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program.  If not, see .
-
-# This script is derived from GIT-VERSION-GEN from GIT: http://git.or.cz/.
-# It may be run two ways:
-# - from a git repository in which the "git describe" command below
-#   produces useful output (thus requiring at least one signed tag)
-# - from a non-git-repo directory containing a .tarball-version file, which
-#   presumes this script is invoked like "./git-version-gen .tarball-version".
-
-# In order to use intra-version strings in your project, you will need two
-# separate generated version string files:
-#
-# .tarball-version - present only in a distribution tarball, and not in
-#   a checked-out repository.  Created with contents that were learned at
-#   the last time autoconf was run, and used by git-version-gen.  Must not
-#   be present in either $(srcdir) or $(builddir) for git-version-gen to
-#   give accurate answers during normal development with a checked out tree,
-#   but must be present in a tarball when there is no version control system.
-#   Therefore, it cannot be used in any dependencies.  GNUmakefile has
-#   hooks to force a reconfigure at distribution time to get the value
-#   correct, without penalizing normal development with extra reconfigures.
-#
-# .version - present in a checked-out repository and in a distribution
-#   tarball.  Usable in dependencies, particularly for files that don't
-#   want to depend on config.h but do want to track version changes.
-#   Delete this file prior to any autoconf run where you want to rebuild
-#   files to pick up a version string change; and leave it stale to
-#   minimize rebuild time after unrelated changes to configure sources.
-#
-# It is probably wise to add these two files to .gitignore, so that you
-# don't accidentally commit either generated file.
-#
-# Use the following line in your configure.ac, so that $(VERSION) will
-# automatically be up-to-date each time configure is run (and note that
-# since configure.ac no longer includes a version string, Makefile rules
-# should not depend on configure.ac for version updates).
-#
-# AC_INIT([GNU project],
-# m4_esyscmd([build-aux/git-version-gen .tarball-version]),
-# [bug-project@example])
-#
-# Then use the following lines in your Makefile.am, so that .version
-# will be present for dependencies, and so that .tarball-version will
-# exist in distribution tarballs.
-#
-# BUILT_SOURCES = $(top_srcdir)/.version
-# $(top_srcdir)/.version:
-#  echo $(VERSION) > $@-t && mv $@-t $@
-# 

[PATCH] osmo-bts[master]: Bump version: 0.5.0 → 0.6.0

[Max]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/3598

to look at the new patch set (#2).

Bump version: 0.5.0 → 0.6.0

Change-Id: I613d09ae0f9f0aa67be1dc6015da1fb9314110fd
---
M debian/changelog
1 file changed, 482 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/98/3598/2

diff --git a/debian/changelog b/debian/changelog
index 5c2d203..61c46c6 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,4 +1,485 @@
-osmo-bts (0.5.0) UNRELEASED; urgency=medium
+osmo-bts (0.6.0) unstable; urgency=medium
+
+  [ Holger Hans Peter Freyther ]
+  * Initial release.
+  * misc: Ignore files generated by a debian packaging build
+  * jenkins: Add the build script from jenkins here
+  * jenkins: Add the build script from jenkins here
+  * sysmobts: Add the barebox boot state reservation
+  * sysmobts: Fix eeprom padding before gpg key
+  * ci/spatch: Remove the "static" analysis handling
+  * oct: Attempt to enable the Octphy for the osmo-bts-oct build
+  * debian: Use the header files installed by openbsc-dev
+  * build: Do not require more headers from OpenBSC
+  * sysmobts: Make reservation for mode/netmask/ip and suc
+  * sysmobts: Store a simple network config in the EEPROM as well
+
+  [ Max ]
+  * Ensure TRX invariant
+  * Use libosmocore function for uplink measurements
+  * Fix debug output
+  * Fix RTP timestamps in case of DTX
+  * Add DTXd support for sysmoBTS and LC15
+  * Use libosmocodec for AMR RTP
+  * octphy: Use the app. info. defaults as base
+  * Fix debug output
+  * DTXd: store/repeat last SID
+  * DTXd: store/repeat last SID
+  * DTXu: mark beginning of speech burst in RTP
+  * Fix OML activation
+  * TRX: Add vty command to power on/off transceiver
+  * TRX: add configuration example
+  * Add .gitreview
+  * DTX: add support for AMR/HR
+  * Move copy-pasted code into common part
+  * Use libosmocodec functions for AMR
+  * Use error values instead of number for RSL error
+  * Clarify logging message
+  * Make get_lchan_by_chan_nr globally available
+  * DTXu: move copy-pasted code to common part
+  * Remove duplicated nibble shift code
+  * TRX: add Uplink DTX support for FR/HR
+  * Mark array as static const
+  * sysmobts: dump PRACH and PTCCH parameters
+  * Activate PTCCH UL
+  * Fix dsp tracing at phy config
+  * octphy: fix build
+  * Fill measurements data for L1SAP
+  * sysmo: ts_connect: log channel combination name instead of number
+  * DTX: fix last SID saving
+  * DTX: fix SID repeat scheduling
+  * DTX: fix SID logic
+  * lc15, sysmo: Use SID_FIRST_P1 to initiate DTX
+  * DTX: check Marker bit to send ONSET to L1
+  * DTX: remove misleading comment
+  * LC15: Clarify msgb ownership / fix memory leaks
+  * DTX: move scheduling check inside repeat_last_sid
+  * DTX: further AMR SID cache fixes (lc15, sysmo)
+  * DTX: move ONSET detection into separate function
+  * DTX: send AMR voice alongside with ONSET
+  * DTX: fix conversion from fn to ms
+  * Move copy-pasted array into shared header
+  * DTX DL: use FSM for AMR
+  * TRX: fix building with latest DTX changes
+  * DTX: fix array size calculation
+  * DTX AMR - fix buffer length check
+  * Replace magic number with define
+  * Fix lc15 build
+  * Extend RTP RX callback parameters
+  * DTX HR - fix array size calculation
+  * Fix DTX DL AMR SIDscheduling logic
+  * Add tools to check DTX operation
+  * DTX DL: split ONSET state handling
+  * Remove obsolete define
+  * DTX DL: add AMR HR support to scheduling check
+  * DTX fix ONSET handling
+  * dtx_check.gawk: Fix false-positives in DTX check
+  * Fix tests linking with libosmocodec
+  * DTX DL: tighten check for enabled operation
+  * DTX: wrap FSM signal dispatching
+  * Add libosmocodec for octphy build
+  * dtx_check.gawk: add check for repetitive SID FIRST
+  * Remove duplicated code
+  * Replace link_id constant with define
+  * DTX DL AMR: rewrite FSM recursion
+  * Remove duplicated code
+  * Fix AGCH/PCH proportional allocation
+  * TRX: prevent segfault upon phy init
+  * DTX: add explicit check if DTX enabled
+  * Save RTP metadata in Control Buffer
+  * osmo-bts-trx: fix lchan deactivation
+  * DTX: fix TS adjustment for ONSET
+  * Optionally use adaptive RTP jitter buffering
+  * Integrate Debian packaging changes
+  * DTX AMR HR: fix inhibition
+  * Add copyright for .deb packages
+  * Move code to libosmocore
+  * Log socket path on error
+  * Add Abis OML failure event reporting
+  * Alarm on various errors
+  * Remove obsolete define TLVP_PRES_LEN
+  * scheduler: log lchan on which prim error occured
+  * deb: use gsm_data_shared.* from openbsc-dev
+  * OML: internalize failure reporting
+  * Add ctrl command to send OML alert
+  * Fix typo in TCH/H interleaving table
+  * Use oml-alert CTRL command for temp report
+  * Remove code duplication
+  * Handle ctrl cmd allocation failures
+  * Check for suitable lchan type when detecting HO
+  * 

[PATCH] osmo-bts[master]: Add git-version-gen snippet

[Max]

Review at  https://gerrit.osmocom.org/3678

Add git-version-gen snippet

Change-Id: Id1732921ecb768b3c3c4872b82b74ccc3d26cf77
Related: OS#1861
---
M Makefile.am
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/78/3678/1

diff --git a/Makefile.am b/Makefile.am
index 5c1add6..4832c84 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -15,6 +15,14 @@
doc/examples/sysmo/sysmobts-mgr.cfg \
doc/examples/virtual/openbsc-virtual.cfg \
doc/examples/virtual/osmobts-virtual.cfg \
+   git-version-gen .version \
README.md
 
 @RELMAKE@
+
+BUILT_SOURCES = $(top_srcdir)/.version
+
+$(top_srcdir)/.version:
+   echo $(VERSION) > $@-t && mv $@-t $@
+dist-hook:
+   echo $(VERSION) > $(distdir)/.tarball-version

-- 
To view, visit https://gerrit.osmocom.org/3678
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1732921ecb768b3c3c4872b82b74ccc3d26cf77
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max 

osmo-msc[master]: smpp: Fix compilation warning

[Pau Espin Pedrol]

Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.osmocom.org/3668
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0901ddadb5f72e1585cb1797ac22c8ab95e83146
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

osmo-msc[master]: libmsc: Fix wrong handling of user_message_reference parameter

[Pau Espin Pedrol]

Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.osmocom.org/3669
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If748548a4a223e529a1110c89e483b599b406e8b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

[MERGED] osmo-gsm-tester[master]: modem: Attempt fixing crash from Register() dbus method

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged.

Change subject: modem: Attempt fixing crash from Register() dbus method
..


modem: Attempt fixing crash from Register() dbus method

Register() method returned today this error which is expected acording
to ofono documentation API. In this case it probably happens because the
modem internally starts registering at some point between the time
Scan() is finished and we call Register(). In this case it is fine for
us and we should just ignore the error.

A helper method is added to check for this as so far it seems tricky to
check error information coming from pydbus. I could not reproduce this
issue locally so I could not test that the helper function is going to
handle it correctly when it is triggered. That's why I added extra debug
information to be able to fix it next time it is triggered.

  File 
"/home/jenkins/workspace/osmo-gsm-tester_run/osmo-gsm-tester/src/osmo_gsm_tester/ofono_client.py",
 line 489, in scan_cb_register
dbus_op.Register()
  File "/usr/local/lib/python3.4/dist-packages/pydbus/proxy_method.py", line 
75, in __call__
0, timeout_to_glib(timeout), None).unpack()
GLib.Error: g-io-error-quark: GDBus.Error:org.ofono.Error.InProgress: Operation 
already in progress (36)

Change-Id: I58dda09416ee7328812431220fd3d239c5c2980a
---
M src/osmo_gsm_tester/ofono_client.py
1 file changed, 12 insertions(+), 2 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_gsm_tester/ofono_client.py 
b/src/osmo_gsm_tester/ofono_client.py
index ed7e3e4..43aa091 100644
--- a/src/osmo_gsm_tester/ofono_client.py
+++ b/src/osmo_gsm_tester/ofono_client.py
@@ -139,6 +139,15 @@
 0, timeout, cancellable,
 _async_result_handler, user_data)
 
+def dbus_call_dismiss_error(log_obj, err_str, method):
+try:
+method()
+except Exception as e:
+if isinstance(e, GLib.Error) and err_str in e.domain:
+log_obj.log('Dismissed Dbus method error: %r' % e)
+return
+raise log.Error('dbus_call_dismiss_error raised error %r' % e)
+
 class ModemDbusInteraction(log.Origin):
 '''Work around inconveniences specific to pydbus and ofono.
 ofono adds and removes DBus interfaces and notifies about them.
@@ -463,7 +472,8 @@
 return
 self.log('Registering with the default network')
 netreg = self.dbus.interface(I_NETREG)
-netreg.Register()
+dbus_call_dismiss_error(self, 'org.ofono.Error.InProgress', 
netreg.Register)
+
 
 def scan_cb_register(self, scanned_operators, mcc_mnc):
 self.dbg('scanned operators: ', scanned_operators);
@@ -486,7 +496,7 @@
 return
 dbus_op = systembus_get(matching_op_path)
 self.log('Registering with operator', matching_op_path, mcc_mnc)
-dbus_op.Register()
+dbus_call_dismiss_error(self, 'org.ofono.Error.InProgress', 
dbus_op.Register)
 
 def power_cycle(self):
 'Power the modem and put it online, power cycle it if it was already 
on'

-- 
To view, visit https://gerrit.osmocom.org/3677
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I58dda09416ee7328812431220fd3d239c5c2980a
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 

[PATCH] osmo-gsm-tester[master]: modem: Attempt fixing crash from Register() dbus method

[Pau Espin Pedrol]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/3677

to look at the new patch set (#2).

modem: Attempt fixing crash from Register() dbus method

Register() method returned today this error which is expected acording
to ofono documentation API. In this case it probably happens because the
modem internally starts registering at some point between the time
Scan() is finished and we call Register(). In this case it is fine for
us and we should just ignore the error.

A helper method is added to check for this as so far it seems tricky to
check error information coming from pydbus. I could not reproduce this
issue locally so I could not test that the helper function is going to
handle it correctly when it is triggered. That's why I added extra debug
information to be able to fix it next time it is triggered.

  File 
"/home/jenkins/workspace/osmo-gsm-tester_run/osmo-gsm-tester/src/osmo_gsm_tester/ofono_client.py",
 line 489, in scan_cb_register
dbus_op.Register()
  File "/usr/local/lib/python3.4/dist-packages/pydbus/proxy_method.py", line 
75, in __call__
0, timeout_to_glib(timeout), None).unpack()
GLib.Error: g-io-error-quark: GDBus.Error:org.ofono.Error.InProgress: Operation 
already in progress (36)

Change-Id: I58dda09416ee7328812431220fd3d239c5c2980a
---
M src/osmo_gsm_tester/ofono_client.py
1 file changed, 12 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/77/3677/2

diff --git a/src/osmo_gsm_tester/ofono_client.py 
b/src/osmo_gsm_tester/ofono_client.py
index ed7e3e4..43aa091 100644
--- a/src/osmo_gsm_tester/ofono_client.py
+++ b/src/osmo_gsm_tester/ofono_client.py
@@ -139,6 +139,15 @@
 0, timeout, cancellable,
 _async_result_handler, user_data)
 
+def dbus_call_dismiss_error(log_obj, err_str, method):
+try:
+method()
+except Exception as e:
+if isinstance(e, GLib.Error) and err_str in e.domain:
+log_obj.log('Dismissed Dbus method error: %r' % e)
+return
+raise log.Error('dbus_call_dismiss_error raised error %r' % e)
+
 class ModemDbusInteraction(log.Origin):
 '''Work around inconveniences specific to pydbus and ofono.
 ofono adds and removes DBus interfaces and notifies about them.
@@ -463,7 +472,8 @@
 return
 self.log('Registering with the default network')
 netreg = self.dbus.interface(I_NETREG)
-netreg.Register()
+dbus_call_dismiss_error(self, 'org.ofono.Error.InProgress', 
netreg.Register)
+
 
 def scan_cb_register(self, scanned_operators, mcc_mnc):
 self.dbg('scanned operators: ', scanned_operators);
@@ -486,7 +496,7 @@
 return
 dbus_op = systembus_get(matching_op_path)
 self.log('Registering with operator', matching_op_path, mcc_mnc)
-dbus_op.Register()
+dbus_call_dismiss_error(self, 'org.ofono.Error.InProgress', 
dbus_op.Register)
 
 def power_cycle(self):
 'Power the modem and put it online, power cycle it if it was already 
on'

-- 
To view, visit https://gerrit.osmocom.org/3677
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58dda09416ee7328812431220fd3d239c5c2980a
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder

[PATCH] osmo-gsm-tester[master]: modem: Attempt fixing crash from Register() dbus method

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/3677

modem: Attempt fixing crash from Register() dbus method

Register() method returned today this error which is expected acording
to ofono documentation API. In this case it probably happens because the
modem internally starts registering at some point between the time
Scan() is finished and we call Register(). In this case it is fine for
us and we should just ignore the error.

A helper method is added to check for this as so far it seems tricky to
check error information coming from pydbus. I could not reproduce this
issue locally so I could not test that the helper function is going to
handle it correctly when it is triggered. That's why I added extra debug
information to be able to fix it next time it is triggered.

  File 
"/home/jenkins/workspace/osmo-gsm-tester_run/osmo-gsm-tester/src/osmo_gsm_tester/ofono_client.py",
 line 489, in scan_cb_register
dbus_op.Register()
  File "/usr/local/lib/python3.4/dist-packages/pydbus/proxy_method.py", line 
75, in __call__
0, timeout_to_glib(timeout), None).unpack()
GLib.Error: g-io-error-quark: GDBus.Error:org.ofono.Error.InProgress: Operation 
already in progress (36)

Change-Id: I58dda09416ee7328812431220fd3d239c5c2980a
---
M src/osmo_gsm_tester/ofono_client.py
1 file changed, 13 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/77/3677/1

diff --git a/src/osmo_gsm_tester/ofono_client.py 
b/src/osmo_gsm_tester/ofono_client.py
index ed7e3e4..3768719 100644
--- a/src/osmo_gsm_tester/ofono_client.py
+++ b/src/osmo_gsm_tester/ofono_client.py
@@ -139,6 +139,16 @@
 0, timeout, cancellable,
 _async_result_handler, user_data)
 
+def dbus_call_dismiss_error(log, err_str, method):
+try:
+log.log("calling method")
+method()
+except Exception as e:
+if isinstance(e, GLib.Error) and err_str in e.domain:
+log.log('Dismissed Dbus method error: %r' % e)
+return
+raise log.logError('dbus_call_dismiss_error raised error %r' % e)
+
 class ModemDbusInteraction(log.Origin):
 '''Work around inconveniences specific to pydbus and ofono.
 ofono adds and removes DBus interfaces and notifies about them.
@@ -463,7 +473,8 @@
 return
 self.log('Registering with the default network')
 netreg = self.dbus.interface(I_NETREG)
-netreg.Register()
+dbus_call_dismiss_error(self, 'org.ofono.Error.InProgress', 
netreg.Register)
+
 
 def scan_cb_register(self, scanned_operators, mcc_mnc):
 self.dbg('scanned operators: ', scanned_operators);
@@ -486,7 +497,7 @@
 return
 dbus_op = systembus_get(matching_op_path)
 self.log('Registering with operator', matching_op_path, mcc_mnc)
-dbus_op.Register()
+dbus_call_dismiss_error(self, 'org.ofono.Error.InProgress', 
dbus_op.Register)
 
 def power_cycle(self):
 'Power the modem and put it online, power cycle it if it was already 
on'

-- 
To view, visit https://gerrit.osmocom.org/3677
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I58dda09416ee7328812431220fd3d239c5c2980a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 

[PATCH] osmo-ci[master]: jenkins: Follow the convention and create a jenkins.sh as well

[Holger Freyther]

Review at  https://gerrit.osmocom.org/3676

jenkins: Follow the convention and create a jenkins.sh as well

Instead of modifying the job on Jenkins, let's do it like in our
other projects. Create the diretcory if it doesn't exist and use
git pull origin for the Debian9 system.

Change-Id: I0ecdc02e3271fe09980f370167277370c599fcfa
---
A contrib/jenkins.sh
1 file changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/76/3676/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
new file mode 100755
index 000..88f509e
--- /dev/null
+++ b/contrib/jenkins.sh
@@ -0,0 +1,10 @@
+#!/bin/sh
+
+cd ~/osmo-ci || (cd ~/ && git clone git://git.osmocom.org/osmo-ci)
+git rev-parse HEAD
+git status
+
+git pull origin
+
+git rev-parse HEAD
+git status

-- 
To view, visit https://gerrit.osmocom.org/3676
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ecdc02e3271fe09980f370167277370c599fcfa
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther 

[PATCH] osmo-ci[master]: jenkins: Copy Dockerfile and script from buildhost

[Holger Freyther]

Review at  https://gerrit.osmocom.org/3675

jenkins: Copy Dockerfile and script from buildhost

We are not using the Docker registry due difficult GPL compliance
but build the image on the build node itself. After prototyping
if containers can be used for building these files remained forked
on the node. These days it seems to be easier to complain than to
say thank you that this new approach has its merits. Copy the files
from the build slave to the directory they should have been in.

Change-Id: Icb0406f96b0c18e77be51ad8317c2668fb23a45e
---
A docker/Dockerfile_osmocom_jenkins.amd64
A docker/rebuild_osmocom_jenkins_image.sh
2 files changed, 71 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/75/3675/1

diff --git a/docker/Dockerfile_osmocom_jenkins.amd64 
b/docker/Dockerfile_osmocom_jenkins.amd64
new file mode 100644
index 000..8f33233
--- /dev/null
+++ b/docker/Dockerfile_osmocom_jenkins.amd64
@@ -0,0 +1,69 @@
+FROM debian:jessie
+
+RUN dpkg --add-architecture i386 && \
+DEBIAN_FRONTEND=noninteractive apt-get update && \
+DEBIAN_FRONTEND=noninteractive apt-get upgrade -y && \
+DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends 
wget make
+
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends 
gcc g++ make git
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends 
sudo
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends 
unzip bzip2  python
+
+# match the outside user
+RUN useradd --uid=1000 build
+#RUN echo "build ALL=(ALL) NOPASSWD:ALL" > /etc/sudoers.d/build
+
+RUN mkdir /build
+RUN chown build:build /build
+
+# still generic
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends 
doxygen git asciidoc rsync coccinelle
+
+# for GNU smalltalk
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends 
flex bison libsigsegv-dev libffi-dev texinfo
+
+# libosmo-sccp/abis/etc
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends 
libortp-dev libpcsclite-dev libsctp-dev libfftw3-dev libsnmp-dev  
libusb-1.0-0-dev libtalloc-dev libgnutls28-dev
+
+# OsmocomBB
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends 
gcc-arm-none-eabi
+
+# building
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends 
libtool pkg-config automake autoconf
+
+# Linux kernel
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y bc
+
+# and all
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y doxygen g++ 
libtalloc-dev libpcsclite-dev make gcc pkgconf libtool autoconf 
autoconf-archive automake libortp-dev asciidoc mscgen git libsctp-dev 
libpcap-dev osc libc-ares-dev libgps-dev  libsofia-sip-ua-glib-dev  libssl-dev 
libsqlite3-dev libusb-dev libffi-dev libfftw3-dev flex bison libdbi-dev  
libsnmp-dev libncurses5-dev libgsm1-dev python-minimal python3 libdbd-sqlite3 
cppcheck htop  libgmp-dev gawk texinfo flex bison bc  libsigsegv-dev libffi-dev 
libusb-1.0-0-dev  libreadline-dev debhelper devscripts gcc-arm-none-eabi 
git-buildpackage dh-systemd dh-autoreconf bc openssh-client 
+
+RUN git clone git://git.osmocom.org/python/osmo-python-tests && cd 
osmo-python-tests && python2 ./setup.py install # 2017-03-06
+
+
+RUN echo "#!/bin/sh \n\
+ \n\
+if ! test -d \$1; \n\
+then \n\
+  git clone git://git.osmocom.org/\$1 \$1 \n\
+fi \n\
+\n\
+cd \$1 \n\
+git fetch origin \n\
+git reset --hard origin/master" > /usr/local/bin/osmo-deps.sh
+RUN chmod +x /usr/local/bin/osmo-deps.sh
+
+
+RUN git clone http://git.savannah.gnu.org/r/smalltalk.git
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends 
flex libsigsegv-dev bison libgmp-dev texinfo zip libltdl-dev 
+RUN cd smalltalk && autoreconf --install --force && ./configure && make install
+RUN rm -rf smalltalk
+RUN git clone https://github.com/zecke/petitparser.git && cd petitparser && 
gst-package package.xml
+RUN git clone https://github.com/zecke/petitparser-tests.git && cd 
petitparser-tests && gst-package package.xml
+RUN git clone git://git.osmocom.org/smalltalk/osmo-st-logging && cd 
osmo-st-logging && gst-package package.xml
+RUN git clone git://git.osmocom.org/smalltalk/osmo-st-core && cd osmo-st-core 
&& gst-package package.xml
+RUN git clone git://git.osmocom.org/smalltalk/osmo-st-network && cd 
osmo-st-network && gst-package package.xml
+RUN git clone git://git.osmocom.org/smalltalk/osmo-st-gsm && cd osmo-st-gsm && 
gst-package --test package.xml
+RUN git clone git://git.osmocom.org/smalltalk/osmo-st-openbsc-test && cd 
osmo-st-openbsc-test/fakebts && gst-package --test package.xml
+RUN rm -rf petitparser petitparser-tests osmo-st-logging ost-st-core 
osmo-st-network osmo-st-gsm osmo-st-openbsc-test
+RUN DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends 
python-pip
+RUN pip install timeout_decorator
diff --git a/docker/rebuild_osmocom_jenkins_image.sh 

osmo-bts[master]: osmo-bts-trx: Relax validation to allow TRX data bursts with...

[Harald Welte]

Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3580
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94c3cb160bfed0ba9c41ed7ef5f8d8a65b81ad07
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[MERGED] osmo-bts[master]: osmo-bts-trx: Relax validation to allow TRX data bursts with...

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: osmo-bts-trx: Relax validation to allow TRX data bursts without 
padding
..


osmo-bts-trx: Relax validation to allow TRX data bursts without padding

Original OpenBTS transcievers add 2 bytes of padding to the end of data
bursts, having in total 158 bytes. As those two extra bytes are being
ignored after the initial validation, let's relax this validation a bit
in order to accept transcievers that decide no to send these two extra
bytes.

Change-Id: I94c3cb160bfed0ba9c41ed7ef5f8d8a65b81ad07
---
M src/osmo-bts-trx/trx_if.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c
index 86a3b9b..a41cf2c 100644
--- a/src/osmo-bts-trx/trx_if.c
+++ b/src/osmo-bts-trx/trx_if.c
@@ -443,7 +443,8 @@
return len;
} else if (len == EGPRS_BURST_LEN + 10) {
burst_len = EGPRS_BURST_LEN;
-   } else if (len != GSM_BURST_LEN + 10) {
+   /* Accept bursts ending with 2 bytes of padding (OpenBTS compatible 
trx) or without them: */
+   } else if (len != GSM_BURST_LEN + 10 && len != GSM_BURST_LEN + 8) {
LOGP(DTRX, LOGL_NOTICE, "Got data message with invalid lenght "
"'%d'\n", len);
return -EINVAL;

-- 
To view, visit https://gerrit.osmocom.org/3580
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94c3cb160bfed0ba9c41ed7ef5f8d8a65b81ad07
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

[PATCH] osmo-bts[master]: osmo-bts-trx: Relax validation to allow TRX data bursts with...

[Pau Espin Pedrol]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/3580

to look at the new patch set (#2).

osmo-bts-trx: Relax validation to allow TRX data bursts without padding

Original OpenBTS transcievers add 2 bytes of padding to the end of data
bursts, having in total 158 bytes. As those two extra bytes are being
ignored after the initial validation, let's relax this validation a bit
in order to accept transcievers that decide no to send these two extra
bytes.

Change-Id: I94c3cb160bfed0ba9c41ed7ef5f8d8a65b81ad07
---
M src/osmo-bts-trx/trx_if.c
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/80/3580/2

diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c
index 86a3b9b..a41cf2c 100644
--- a/src/osmo-bts-trx/trx_if.c
+++ b/src/osmo-bts-trx/trx_if.c
@@ -443,7 +443,8 @@
return len;
} else if (len == EGPRS_BURST_LEN + 10) {
burst_len = EGPRS_BURST_LEN;
-   } else if (len != GSM_BURST_LEN + 10) {
+   /* Accept bursts ending with 2 bytes of padding (OpenBTS compatible 
trx) or without them: */
+   } else if (len != GSM_BURST_LEN + 10 && len != GSM_BURST_LEN + 8) {
LOGP(DTRX, LOGL_NOTICE, "Got data message with invalid lenght "
"'%d'\n", len);
return -EINVAL;

-- 
To view, visit https://gerrit.osmocom.org/3580
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I94c3cb160bfed0ba9c41ed7ef5f8d8a65b81ad07
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder