pysim[master]: pySim-*.py: Set shebang to use python v2

2017-12-30 Thread Pau Espin Pedrol 

Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.osmocom.org/5621
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ab4e9edc44a8045915d4828c6de2fa98027fb7e
Gerrit-PatchSet: 2
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

[MERGED] pysim[master]: pySim-*.py: Set shebang to use python v2

2017-12-30 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged.

Change subject: pySim-*.py: Set shebang to use python v2
..


pySim-*.py: Set shebang to use python v2

Nowadays bin/python usually points to python3, and this script is written
in python2, which means if run directly from terminal it will fail with
some print syntax errors.

Change-Id: I6ab4e9edc44a8045915d4828c6de2fa98027fb7e
---
M pySim-prog.py
M pySim-read.py
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/pySim-prog.py b/pySim-prog.py
index 14874cd..d3a29c7 100755
--- a/pySim-prog.py
+++ b/pySim-prog.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python2
 
 #
 # Utility to deal with sim cards and program the 'magic' ones easily
diff --git a/pySim-read.py b/pySim-read.py
index 2c10866..5ca39ee 100755
--- a/pySim-read.py
+++ b/pySim-read.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python2
 
 #
 # Utility to display some informations about a SIM card

-- 
To view, visit https://gerrit.osmocom.org/5621
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6ab4e9edc44a8045915d4828c6de2fa98027fb7e
Gerrit-PatchSet: 2
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol

[MERGED] pysim[master]: pySim-prog.py: Fix trailing whitespace

2017-12-30 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged.

Change subject: pySim-prog.py: Fix trailing whitespace
..


pySim-prog.py: Fix trailing whitespace

Change-Id: I735dc7bb774d77d3b60b1712b0f0afcbb81dc726
---
M pySim-prog.py
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Pau Espin Pedrol: Verified
  Max: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/pySim-prog.py b/pySim-prog.py
index d3a29c7..3df18ba 100755
--- a/pySim-prog.py
+++ b/pySim-prog.py
@@ -650,4 +650,3 @@
 
if not opts.batch_mode:
done = True
-

-- 
To view, visit https://gerrit.osmocom.org/5622
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I735dc7bb774d77d3b60b1712b0f0afcbb81dc726
Gerrit-PatchSet: 2
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol

pysim[master]: pySim-prog.py: Fix trailing whitespace

2017-12-30 Thread Pau Espin Pedrol 

Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.osmocom.org/5622
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I735dc7bb774d77d3b60b1712b0f0afcbb81dc726
Gerrit-PatchSet: 2
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

Build failure of network:osmocom:nightly/osmo-bsc in Debian_9.0/armv7l

2017-12-30 Thread OBS Notification 
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/armv7l

Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  177s]printf(line);
[  177s]^~
[  177s] cc1: some warnings being treated as errors
[  177s] Makefile:517: recipe for target 'abisip-find.o' failed
[  177s] make[4]: *** [abisip-find.o] Error 1
[  177s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/ipaccess'
[  177s] Makefile:408: recipe for target 'all-recursive' failed
[  177s] make[3]: *** [all-recursive] Error 1
[  177s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  177s] Makefile:443: recipe for target 'all-recursive' failed
[  177s] make[2]: *** [all-recursive] Error 1
[  177s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  177s] Makefile:375: recipe for target 'all' failed
[  177s] make[1]: *** [all] Error 2
[  177s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  177s] dh_auto_build: make -j1 returned exit code 2
[  177s] debian/rules:45: recipe for target 'build' failed
[  177s] make: *** [build] Error 2
[  177s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  177s] 
[  177s] armbuild02 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
21:40:49 UTC 2017.
[  177s] 
[  177s] ### VM INTERACTION START ###
[  180s] [  163.908256] SysRq : Power Off
[  180s] [  163.927807] reboot: Power down
[  180s] ### VM INTERACTION END ###
[  180s] 
[  180s] armbuild02 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
21:40:52 UTC 2017.
[  180s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bsc in Debian_8.0/x86_64

2017-12-30 Thread OBS Notification 
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_8.0/x86_64

Package network:osmocom:nightly/osmo-bsc failed to build in Debian_8.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  108s]printf(line);
[  108s]^
[  108s] cc1: some warnings being treated as errors
[  108s] Makefile:506: recipe for target 'abisip-find.o' failed
[  108s] make[4]: *** [abisip-find.o] Error 1
[  108s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/ipaccess'
[  108s] Makefile:396: recipe for target 'all-recursive' failed
[  108s] make[3]: *** [all-recursive] Error 1
[  108s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  108s] Makefile:431: recipe for target 'all-recursive' failed
[  108s] make[2]: *** [all-recursive] Error 1
[  108s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  108s] Makefile:362: recipe for target 'all' failed
[  108s] make[1]: *** [all] Error 2
[  108s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  108s] dh_auto_build: make -j1 returned exit code 2
[  108s] debian/rules:45: recipe for target 'build' failed
[  108s] make: *** [build] Error 2
[  108s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  108s] 
[  108s] build79 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:07:20 UTC 2017.
[  108s] 
[  108s] ### VM INTERACTION START ###
[  109s] Powering off.
[  109s] [  101.848645] reboot: Power down
[  109s] ### VM INTERACTION END ###
[  109s] 
[  109s] build79 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:07:21 UTC 2017.
[  109s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bsc in Debian_9.0/i586

2017-12-30 Thread OBS Notification 
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/i586

Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  131s] abisip-find.c:317:3: error: format not a string literal and no format 
arguments [-Werror=format-security]
[  131s]printf(line);
[  131s]^~
[  131s] cc1: some warnings being treated as errors
[  131s] Makefile:517: recipe for target 'abisip-find.o' failed
[  131s] make[4]: *** [abisip-find.o] Error 1
[  131s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/ipaccess'
[  131s] Makefile:408: recipe for target 'all-recursive' failed
[  131s] make[3]: *** [all-recursive] Error 1
[  131s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  131s] Makefile:443: recipe for target 'all-recursive' failed
[  131s] make[2]: *** [all-recursive] Error 1
[  131s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  131s] Makefile:375: recipe for target 'all' failed
[  131s] make[1]: *** [all] Error 2
[  131s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  131s] dh_auto_build: make -j1 returned exit code 2
[  131s] debian/rules:45: recipe for target 'build' failed
[  131s] make: *** [build] Error 2
[  131s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  131s] 
[  131s] lamb05 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:05:43 UTC 2017.
[  131s] 
[  131s] ### VM INTERACTION START ###
[  134s] [  125.820549] reboot: Power down
[  134s] ### VM INTERACTION END ###
[  134s] 
[  134s] lamb05 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:05:47 UTC 2017.
[  134s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bsc in Debian_8.0/i586

2017-12-30 Thread OBS Notification 
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_8.0/i586

Package network:osmocom:nightly/osmo-bsc failed to build in Debian_8.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  105s]printf(line);
[  105s]^
[  106s] cc1: some warnings being treated as errors
[  106s] Makefile:506: recipe for target 'abisip-find.o' failed
[  106s] make[4]: *** [abisip-find.o] Error 1
[  106s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/ipaccess'
[  106s] Makefile:396: recipe for target 'all-recursive' failed
[  106s] make[3]: *** [all-recursive] Error 1
[  106s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  106s] Makefile:431: recipe for target 'all-recursive' failed
[  106s] make[2]: *** [all-recursive] Error 1
[  106s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  106s] Makefile:362: recipe for target 'all' failed
[  106s] make[1]: *** [all] Error 2
[  106s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  106s] dh_auto_build: make -j1 returned exit code 2
[  106s] debian/rules:45: recipe for target 'build' failed
[  106s] make: *** [build] Error 2
[  106s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  106s] 
[  106s] lamb74 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:05:10 UTC 2017.
[  106s] 
[  106s] ### VM INTERACTION START ###
[  107s] Powering off.
[  107s] [  100.130792] reboot: Power down
[  107s] ### VM INTERACTION END ###
[  107s] 
[  107s] lamb74 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:05:12 UTC 2017.
[  107s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_17.10/x86_64

2017-12-30 Thread OBS Notification 
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  149s] abisip-find.c:317:3: error: format not a string literal and no format 
arguments [-Werror=format-security]
[  149s]printf(line);
[  149s]^~
[  149s] cc1: some warnings being treated as errors
[  149s] Makefile:517: recipe for target 'abisip-find.o' failed
[  149s] make[4]: *** [abisip-find.o] Error 1
[  149s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/ipaccess'
[  149s] Makefile:408: recipe for target 'all-recursive' failed
[  149s] make[3]: *** [all-recursive] Error 1
[  149s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  149s] Makefile:443: recipe for target 'all-recursive' failed
[  149s] make[2]: *** [all-recursive] Error 1
[  149s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  149s] Makefile:375: recipe for target 'all' failed
[  149s] make[1]: *** [all] Error 2
[  149s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  149s] dh_auto_build: make -j1 returned exit code 2
[  149s] debian/rules:45: recipe for target 'build' failed
[  149s] make: *** [build] Error 2
[  149s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  150s] 
[  150s] cloud115 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:05:11 UTC 2017.
[  150s] 
[  150s] ### VM INTERACTION START ###
[  153s] [  120.671954] reboot: Power down
[  155s] ### VM INTERACTION END ###
[  156s] 
[  156s] cloud115 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:05:18 UTC 2017.
[  156s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_16.04/i586

2017-12-30 Thread OBS Notification 
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.04/i586

Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  106s] abisip-find.c:317:3: error: format not a string literal and no format 
arguments [-Werror=format-security]
[  106s]printf(line);
[  106s]^
[  106s] cc1: some warnings being treated as errors
[  106s] Makefile:517: recipe for target 'abisip-find.o' failed
[  106s] make[4]: *** [abisip-find.o] Error 1
[  106s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/ipaccess'
[  106s] Makefile:408: recipe for target 'all-recursive' failed
[  106s] make[3]: *** [all-recursive] Error 1
[  106s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  106s] Makefile:443: recipe for target 'all-recursive' failed
[  106s] make[2]: *** [all-recursive] Error 1
[  106s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  106s] Makefile:375: recipe for target 'all' failed
[  106s] make[1]: *** [all] Error 2
[  106s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  106s] dh_auto_build: make -j1 returned exit code 2
[  106s] debian/rules:45: recipe for target 'build' failed
[  106s] make: *** [build] Error 2
[  106s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  106s] 
[  106s] build75 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:04:27 UTC 2017.
[  106s] 
[  106s] ### VM INTERACTION START ###
[  109s] [  103.073332] reboot: Power down
[  109s] ### VM INTERACTION END ###
[  109s] 
[  109s] build75 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:04:31 UTC 2017.
[  109s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bsc in Debian_9.0/x86_64

2017-12-30 Thread OBS Notification 
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/x86_64

Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  168s] abisip-find.c:317:3: error: format not a string literal and no format 
arguments [-Werror=format-security]
[  168s]printf(line);
[  168s]^~
[  168s] cc1: some warnings being treated as errors
[  168s] Makefile:517: recipe for target 'abisip-find.o' failed
[  168s] make[4]: *** [abisip-find.o] Error 1
[  168s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/ipaccess'
[  168s] Makefile:408: recipe for target 'all-recursive' failed
[  168s] make[3]: *** [all-recursive] Error 1
[  168s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  168s] Makefile:443: recipe for target 'all-recursive' failed
[  168s] make[2]: *** [all-recursive] Error 1
[  168s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  168s] Makefile:375: recipe for target 'all' failed
[  168s] make[1]: *** [all] Error 2
[  168s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  168s] dh_auto_build: make -j1 returned exit code 2
[  168s] debian/rules:45: recipe for target 'build' failed
[  168s] make: *** [build] Error 2
[  168s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  168s] 
[  168s] lamb22 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:05:07 UTC 2017.
[  168s] 
[  168s] ### VM INTERACTION START ###
[  171s] [  160.632510] reboot: Power down
[  171s] ### VM INTERACTION END ###
[  171s] 
[  171s] lamb22 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:05:10 UTC 2017.
[  171s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_16.04/x86_64

2017-12-30 Thread OBS Notification 
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  108s] abisip-find.c:317:3: error: format not a string literal and no format 
arguments [-Werror=format-security]
[  108s]printf(line);
[  108s]^
[  109s] cc1: some warnings being treated as errors
[  109s] Makefile:517: recipe for target 'abisip-find.o' failed
[  109s] make[4]: *** [abisip-find.o] Error 1
[  109s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/ipaccess'
[  109s] Makefile:408: recipe for target 'all-recursive' failed
[  109s] make[3]: *** [all-recursive] Error 1
[  109s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  109s] Makefile:443: recipe for target 'all-recursive' failed
[  109s] make[2]: *** [all-recursive] Error 1
[  109s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  109s] Makefile:375: recipe for target 'all' failed
[  109s] make[1]: *** [all] Error 2
[  109s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  109s] dh_auto_build: make -j1 returned exit code 2
[  109s] debian/rules:45: recipe for target 'build' failed
[  109s] make: *** [build] Error 2
[  109s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  109s] 
[  109s] lamb67 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:05:13 UTC 2017.
[  109s] 
[  109s] ### VM INTERACTION START ###
[  112s] [  105.154204] reboot: Power down
[  112s] ### VM INTERACTION END ###
[  112s] 
[  112s] lamb67 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:05:17 UTC 2017.
[  112s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_16.10/x86_64

2017-12-30 Thread OBS Notification 
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.10/x86_64

Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[   97s] abisip-find.c:317:3: error: format not a string literal and no format 
arguments [-Werror=format-security]
[   97s]printf(line);
[   97s]^~
[   97s] cc1: some warnings being treated as errors
[   97s] Makefile:517: recipe for target 'abisip-find.o' failed
[   97s] make[4]: *** [abisip-find.o] Error 1
[   97s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/ipaccess'
[   97s] Makefile:408: recipe for target 'all-recursive' failed
[   97s] make[3]: *** [all-recursive] Error 1
[   97s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   97s] Makefile:443: recipe for target 'all-recursive' failed
[   97s] make[2]: *** [all-recursive] Error 1
[   97s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   97s] Makefile:375: recipe for target 'all' failed
[   97s] make[1]: *** [all] Error 2
[   97s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   97s] dh_auto_build: make -j1 returned exit code 2
[   97s] debian/rules:45: recipe for target 'build' failed
[   97s] make: *** [build] Error 2
[   97s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   97s] 
[   97s] lamb71 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:04:25 UTC 2017.
[   97s] 
[   97s] ### VM INTERACTION START ###
[  100s] [   92.350446] reboot: Power down
[  100s] ### VM INTERACTION END ###
[  100s] 
[  100s] lamb71 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:04:28 UTC 2017.
[  100s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_17.04/x86_64

2017-12-30 Thread OBS Notification 
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_17.04/x86_64

Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_17.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  115s] abisip-find.c:317:3: error: format not a string literal and no format 
arguments [-Werror=format-security]
[  115s]printf(line);
[  115s]^~
[  115s] cc1: some warnings being treated as errors
[  115s] Makefile:517: recipe for target 'abisip-find.o' failed
[  115s] make[4]: *** [abisip-find.o] Error 1
[  115s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/ipaccess'
[  115s] Makefile:408: recipe for target 'all-recursive' failed
[  115s] make[3]: *** [all-recursive] Error 1
[  115s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  115s] Makefile:443: recipe for target 'all-recursive' failed
[  115s] make[2]: *** [all-recursive] Error 1
[  115s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  115s] Makefile:375: recipe for target 'all' failed
[  115s] make[1]: *** [all] Error 2
[  115s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  115s] dh_auto_build: make -j1 returned exit code 2
[  115s] debian/rules:45: recipe for target 'build' failed
[  115s] make: *** [build] Error 2
[  115s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  115s] 
[  115s] build31 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:04:00 UTC 2017.
[  115s] 
[  116s] ### VM INTERACTION START ###
[  119s] [  110.545900] reboot: Power down
[  119s] ### VM INTERACTION END ###
[  119s] 
[  119s] build31 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:04:03 UTC 2017.
[  119s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_17.04/i586

2017-12-30 Thread OBS Notification 
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_17.04/i586

Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_17.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  212s] abisip-find.c:317:3: error: format not a string literal and no format 
arguments [-Werror=format-security]
[  212s]printf(line);
[  212s]^~
[  213s] cc1: some warnings being treated as errors
[  213s] Makefile:517: recipe for target 'abisip-find.o' failed
[  213s] make[4]: *** [abisip-find.o] Error 1
[  213s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/ipaccess'
[  213s] Makefile:408: recipe for target 'all-recursive' failed
[  213s] make[3]: *** [all-recursive] Error 1
[  213s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  213s] Makefile:443: recipe for target 'all-recursive' failed
[  213s] make[2]: *** [all-recursive] Error 1
[  213s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  213s] Makefile:375: recipe for target 'all' failed
[  213s] make[1]: *** [all] Error 2
[  213s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  213s] dh_auto_build: make -j1 returned exit code 2
[  213s] debian/rules:45: recipe for target 'build' failed
[  213s] make: *** [build] Error 2
[  213s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  213s] 
[  213s] cloud123 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:03:54 UTC 2017.
[  213s] 
[  213s] ### VM INTERACTION START ###
[  216s] [  180.058221] reboot: Power down
[  217s] ### VM INTERACTION END ###
[  217s] 
[  217s] cloud123 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:03:59 UTC 2017.
[  217s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_16.10/i586

2017-12-30 Thread OBS Notification 
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.10/i586

Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  100s] abisip-find.c:317:3: error: format not a string literal and no format 
arguments [-Werror=format-security]
[  100s]printf(line);
[  100s]^~
[  100s] cc1: some warnings being treated as errors
[  100s] Makefile:517: recipe for target 'abisip-find.o' failed
[  100s] make[4]: *** [abisip-find.o] Error 1
[  100s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/ipaccess'
[  100s] Makefile:408: recipe for target 'all-recursive' failed
[  100s] make[3]: *** [all-recursive] Error 1
[  100s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  100s] Makefile:443: recipe for target 'all-recursive' failed
[  100s] make[2]: *** [all-recursive] Error 1
[  100s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  100s] Makefile:375: recipe for target 'all' failed
[  100s] make[1]: *** [all] Error 2
[  100s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  100s] dh_auto_build: make -j1 returned exit code 2
[  100s] debian/rules:45: recipe for target 'build' failed
[  100s] make: *** [build] Error 2
[  100s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  100s] 
[  100s] lamb61 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:02:13 UTC 2017.
[  100s] 
[  100s] ### VM INTERACTION START ###
[  103s] [   95.867208] reboot: Power down
[  103s] ### VM INTERACTION END ###
[  103s] 
[  103s] lamb61 failed "build osmo-bsc_1.1.2.20171230.dsc" at Sat Dec 30 
20:02:16 UTC 2017.
[  103s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

[MERGED] osmocom-bb[master]: mobile: Add lua examples for basic functions that are available

2017-12-30 Thread Harald Welte 
Harald Welte has submitted this change and it was merged.

Change subject: mobile: Add lua examples for basic functions that are available
..


mobile: Add lua examples for basic functions that are available

Link to Lua docs, link to our manual. Demo logging, timer, MS
on/off, sms sending and sms receiving. For the MM state I will
need to export constants/names to make this usable. Currently
it is a bit of a hack (first time to MM_IDLE) to send a SMS. We
would know when we attached though.

Change-Id: I10ac656330b65e3905d6cbbb7865aa0f969cd9ff
---
A doc/examples/mobile/lua_helloworld.lua
A doc/examples/mobile/lua_ms_on_off.lua
A doc/examples/mobile/lua_sms_on_attach.lua
A doc/examples/mobile/lua_sms_receive.lua
A doc/examples/mobile/lua_timer.lua
5 files changed, 91 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/doc/examples/mobile/lua_helloworld.lua 
b/doc/examples/mobile/lua_helloworld.lua
new file mode 100644
index 000..fd5abcc
--- /dev/null
+++ b/doc/examples/mobile/lua_helloworld.lua
@@ -0,0 +1,9 @@
+-- See https://www.lua.org/manual/5.3/ for Lua
+-- See http://ftp.osmocom.org/docs/latest/osmocombb-usermanual.pdf -- 
Scripting with Lua
+
+-- Standard print and log_* are forwarded to the Osmocom logging framework
+print("Hellp from Lua");
+log_notice("Notice from lua");
+log_debug("Debug from Lua");
+log_error("Error from Lua");
+log_fatal("Fatal from Lua");
diff --git a/doc/examples/mobile/lua_ms_on_off.lua 
b/doc/examples/mobile/lua_ms_on_off.lua
new file mode 100644
index 000..57e492d
--- /dev/null
+++ b/doc/examples/mobile/lua_ms_on_off.lua
@@ -0,0 +1,23 @@
+-- See https://www.lua.org/manual/5.3/ for Lua
+-- See http://ftp.osmocom.org/docs/latest/osmocombb-usermanual.pdf -- 
Scripting with Lua
+
+
+-- Switch the MS on/off but this can only be done if the MS
+-- is in the right state. This assumes that the MS is fully
+-- connected and doesn't stall.
+
+local start = false
+osmo.ms().start()
+function toggle_ms_state()
+   timer = osmo.timeout(20, function()
+   if start then
+   print("STARTING", osmo.ms().start())
+   start = false
+   else
+   print("STOPPING", osmo.ms().stop(true))
+   start = true
+   end
+   toggle_ms_state()
+   end)
+end
+toggle_ms_state()
diff --git a/doc/examples/mobile/lua_sms_on_attach.lua 
b/doc/examples/mobile/lua_sms_on_attach.lua
new file mode 100644
index 000..8d73f2f
--- /dev/null
+++ b/doc/examples/mobile/lua_sms_on_attach.lua
@@ -0,0 +1,32 @@
+-- See https://www.lua.org/manual/5.3/ for Lua
+-- See http://ftp.osmocom.org/docs/latest/osmocombb-usermanual.pdf -- 
Scripting with Lua
+
+
+-- State change
+local sent_sms = false
+function mm_cb(new_state, new_substate, old_substate)
+   -- The system has attached and returned to idle. Send a SMS the first 
time
+   -- it happens.
+   if new_state == 19 and new_substate == 1 then
+   if not sent_sms then
+   sent_sms = true
+   osmo.ms():sms_send_simple("1234", "21321324", 
"fooo", 23)
+   end
+   end
+end
+
+-- Called when a new SMS arrives or status for delivery
+-- is updated. Check the msg_ref field.
+function sms_cb(sms, cause, valid)
+   print("SMS data cb", sms, cause, valid)
+   for i, v in pairs(sms) do
+   print(i, v)
+   end
+end
+
+-- We need to register a callback 
+local cbs = {
+   Sms=sms_cb,
+   Mm=mm_cb
+}
+osmo.ms():register(cbs)
diff --git a/doc/examples/mobile/lua_sms_receive.lua 
b/doc/examples/mobile/lua_sms_receive.lua
new file mode 100644
index 000..4be4e0a
--- /dev/null
+++ b/doc/examples/mobile/lua_sms_receive.lua
@@ -0,0 +1,15 @@
+-- See https://www.lua.org/manual/5.3/ for Lua
+-- See http://ftp.osmocom.org/docs/latest/osmocombb-usermanual.pdf -- 
Scripting with Lua
+
+function sms_cb(sms, cause, valid)
+   print("SMS data cb", sms, cause, valid)
+   for i, v in pairs(sms) do
+   print(i, v)
+   end
+end
+
+local cbs = {
+   Sms=sms_cb,
+}
+
+osmo.ms():register(cbs)
diff --git a/doc/examples/mobile/lua_timer.lua 
b/doc/examples/mobile/lua_timer.lua
new file mode 100644
index 000..1119af8
--- /dev/null
+++ b/doc/examples/mobile/lua_timer.lua
@@ -0,0 +1,12 @@
+-- See https://www.lua.org/manual/5.3/ for Lua
+-- See http://ftp.osmocom.org/docs/latest/osmocombb-usermanual.pdf -- 
Scripting with Lua
+
+-- Start and stop timer with callback. Schedule a timeout and
+-- resume execution then.
+
+-- Timeout in 10 seconds
+local timer = osmo.timeout(10, function()
+   print("Timeout occurred");
+end)
+-- We can cancel it. The callback will not be called
+timer:cancel()

-- 
To view, visit https://gerrit.osmocom.org/5596
To unsubscribe, visit

[MERGED] osmocom-bb[master]: mobile: Send SMS through the primitive interface

2017-12-30 Thread Harald Welte 
Harald Welte has submitted this change and it was merged.

Change subject: mobile: Send SMS through the primitive interface
..


mobile: Send SMS through the primitive interface

Make this symmetric and send the SMS through the primitive
interface. Construct and copy the sms into the prim, store
the SCA in the prim as well. In 04.11 we see we can store
2*10 digits in the destination address and a NUL.

Change-Id: I91d7537f4f6ce5ba00218c58f3456947ec7bc662
---
M src/host/layer23/include/osmocom/bb/mobile/gsm411_sms.h
M src/host/layer23/include/osmocom/bb/mobile/primitives.h
M src/host/layer23/src/mobile/gsm411_sms.c
M src/host/layer23/src/mobile/primitives.c
M src/host/layer23/src/mobile/script_lua.c
5 files changed, 39 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/host/layer23/include/osmocom/bb/mobile/gsm411_sms.h 
b/src/host/layer23/include/osmocom/bb/mobile/gsm411_sms.h
index d3074fb..3ed6710 100644
--- a/src/host/layer23/include/osmocom/bb/mobile/gsm411_sms.h
+++ b/src/host/layer23/include/osmocom/bb/mobile/gsm411_sms.h
@@ -35,5 +35,7 @@
 int gsm411_rcv_sms(struct osmocom_ms *ms, struct msgb *msg);
 int sms_send(struct osmocom_ms *ms, const char *sms_sca, const char *number,
const char *text, uint8_t msg_ref);
+int gsm411_tx_sms_submit(struct osmocom_ms *ms, const char *sms_sca,
+   struct gsm_sms *sms);
 
 #endif /* _GSM411_SMS_H */
diff --git a/src/host/layer23/include/osmocom/bb/mobile/primitives.h 
b/src/host/layer23/include/osmocom/bb/mobile/primitives.h
index 39b4945..034b202 100644
--- a/src/host/layer23/include/osmocom/bb/mobile/primitives.h
+++ b/src/host/layer23/include/osmocom/bb/mobile/primitives.h
@@ -62,6 +62,8 @@
 struct mobile_sms_param {
struct gsm_sms sms;
 
+   char sca[20+1]; /*sms;
+
+   /* Force a NUL at the end of the string */
+   param->sca[sizeof(param->sca) - 1] = '\0';
+
+   return gsm411_tx_sms_submit(intf->ms, param->sca, sms);
+}
+
 int mobile_prim_intf_req(struct mobile_prim_intf *intf, struct mobile_prim 
*prim)
 {
int rc = 0;
@@ -184,6 +197,9 @@
case OSMO_PRIM(PRIM_MOB_TIMER_CANCEL, PRIM_OP_REQUEST):
rc = cancel_timer(intf, >u.timer);
break;
+   case OSMO_PRIM(PRIM_MOB_SMS, PRIM_OP_REQUEST):
+   rc = send_sms(intf, >u.sms);
+   break;
default:
LOGP(DPRIM, LOGL_ERROR, "Unknown primitive: %d\n", 
OSMO_PRIM_HDR(>hdr));
break;
diff --git a/src/host/layer23/src/mobile/script_lua.c 
b/src/host/layer23/src/mobile/script_lua.c
index 1b80c48..14ab58f 100644
--- a/src/host/layer23/src/mobile/script_lua.c
+++ b/src/host/layer23/src/mobile/script_lua.c
@@ -372,7 +372,9 @@
 static int lua_ms_sms_send_simple(lua_State *L)
 {
const char *sms_sca, *number, *text;
-   int msg_ref, rc;
+   struct mobile_prim *prim;
+   struct gsm_sms *sms;
+   int msg_ref;
 
luaL_argcheck(L, lua_isnumber(L, -1), 4, "msg_ref needs to be a 
number");
luaL_argcheck(L, lua_isstring(L, -2), 3, "text must be a string");
@@ -384,8 +386,21 @@
number = lua_tostring(L, -3);
sms_sca = lua_tostring(L, -4);
 
-   rc = sms_send(get_primitive(L)->ms, sms_sca, number, text, msg_ref);
-   lua_pushinteger(L, rc);
+   prim = mobile_prim_alloc(PRIM_MOB_SMS, PRIM_OP_REQUEST);
+
+   sms = sms_from_text(number, 0, text);
+   if (!sms) {
+   lua_pushinteger(L, -ENOMEM);
+   msgb_free(prim->hdr.msg);
+   return 1;
+   }
+
+   prim->u.sms.sms = *sms;
+   prim->u.sms.sms.msg_ref = msg_ref;
+   osmo_strlcpy(prim->u.sms.sca, sms_sca, sizeof(prim->u.sms.sca));
+   mobile_prim_intf_req(get_primitive(L), prim);
+
+   lua_pushinteger(L, 0);
return 1;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/5594
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I91d7537f4f6ce5ba00218c58f3456947ec7bc662
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

[MERGED] osmocom-bb[master]: mobile: Properly close the primitive interface on reload

2017-12-30 Thread Harald Welte 
Harald Welte has submitted this change and it was merged.

Change subject: mobile: Properly close the primitive interface on reload
..


mobile: Properly close the primitive interface on reload

When reloading a script go through script_lua_close. Get the
primitive first. Then destruct the lua environment which will
lead to GC (e.g. cancellation of timers) and then delete the
primitive code.

Change-Id: I5bb4fa9e7c5010f3ad50b258dcb14956eea8822a
---
M src/host/layer23/src/mobile/script_lua.c
1 file changed, 6 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/host/layer23/src/mobile/script_lua.c 
b/src/host/layer23/src/mobile/script_lua.c
index 14ab58f..9b256d3 100644
--- a/src/host/layer23/src/mobile/script_lua.c
+++ b/src/host/layer23/src/mobile/script_lua.c
@@ -510,10 +510,14 @@
 
 int script_lua_close(struct osmocom_ms *ms)
 {
+   struct mobile_prim_intf *intf;
+
if (!ms->lua_state)
return 0;
 
+   intf = get_primitive(ms->lua_state);
lua_close(ms->lua_state);
+   mobile_prim_intf_free(intf);
ms->lua_state = NULL;
return 0;
 }
@@ -523,8 +527,7 @@
struct mobile_prim_intf *intf;
int err;
 
-   if (ms->lua_state)
-   lua_close(ms->lua_state);
+   script_lua_close(ms);
ms->lua_state = lua_newstate(talloc_lua_alloc, ms);
if (!ms->lua_state)
return -1;
@@ -550,7 +553,7 @@
vty_out(vty, "%% LUA execute error: %s%s",
lua_tostring(ms->lua_state, -1), VTY_NEWLINE);
lua_pop(ms->lua_state, 1);
-   return 3;
+   return -3;
}
 
return 0;

-- 
To view, visit https://gerrit.osmocom.org/5595
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5bb4fa9e7c5010f3ad50b258dcb14956eea8822a
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

osmocom-bb[master]: mobile: Send SMS through the primitive interface

2017-12-30 Thread Harald Welte 

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/5594
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91d7537f4f6ce5ba00218c58f3456947ec7bc662
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

osmocom-bb[master]: mobile: Properly close the primitive interface on reload

2017-12-30 Thread Harald Welte 

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/5595
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bb4fa9e7c5010f3ad50b258dcb14956eea8822a
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

osmocom-bb[master]: mobile: Add lua examples for basic functions that are available

2017-12-30 Thread Harald Welte 

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/5596
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10ac656330b65e3905d6cbbb7865aa0f969cd9ff
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

osmo-iuh[master]: Add control interface

2017-12-30 Thread Harald Welte 

Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/5591
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4637e88da00bac1ab0237c29ac73806d024863ba
Gerrit-PatchSet: 2
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: lynxis lazus 
Gerrit-HasComments: No

osmo-iuh[master]: Expand ctrl interface

2017-12-30 Thread Harald Welte 

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/5599
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a2d6fa3d6d0829ccee4ecc0998d9299c97820e9
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: lynxis lazus 
Gerrit-HasComments: No

osmo-sgsn[master]: Remove obsolete ./configure option

2017-12-30 Thread Harald Welte 

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/5606
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6230cfcf10247b601e16e7b872305499815520a9
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

pysim[master]: utils.py: dec_imsi: Fix ValueError

2017-12-30 Thread Harald Welte 

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/5623
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d3ecbf9edd190d1941816796cee60e3957d5943
Gerrit-PatchSet: 1
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-HasComments: No

[MERGED] osmo-bsc[master]: Fix .deb builds

2017-12-30 Thread Harald Welte 
Harald Welte has submitted this change and it was merged.

Change subject: Fix .deb builds
..


Fix .deb builds

The code triggers following error:
abisip-find.c:317:3: error: format not a string literal and no format
arguments [-Werror=format-security]

The error was introduced in 5bf1e15c55340f236d84f70d3d04c871403d3503.

Change-Id: I613781495edbc53916ca70ff7b78d28ffabd3f5d
---
M src/ipaccess/abisip-find.c
1 file changed, 2 insertions(+), 6 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/ipaccess/abisip-find.c b/src/ipaccess/abisip-find.c
index d94e18a..4e1d192 100644
--- a/src/ipaccess/abisip-find.c
+++ b/src/ipaccess/abisip-find.c
@@ -312,12 +312,8 @@
base_stations_bump(changed);
printf("RX: %u   \r", responses);
fflush(stdout);
-   } else {
-   char *line = parse_response(ctx, buf, len);
-   printf(line);
-   printf("\n");
-   talloc_free(line);
-   }
+   } else
+   printf("%s\n", parse_response(ctx, buf, len));
 }
 
 static int read_response(int fd)

-- 
To view, visit https://gerrit.osmocom.org/5619
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I613781495edbc53916ca70ff7b78d28ffabd3f5d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr

osmo-bsc[master]: Fix .deb builds

2017-12-30 Thread Harald Welte 

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/5619
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I613781495edbc53916ca70ff7b78d28ffabd3f5d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

osmo-bsc[master]: Check and handle SMS encoding failure

2017-12-30 Thread Harald Welte 

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/5615
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9fc16e24f7df5ebad6f4f1b389b2c5e861be95d7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: lynxis lazus 
Gerrit-HasComments: No

[MERGED] osmo-msc[master]: VLR: remove unused parameter

2017-12-30 Thread Harald Welte 
Harald Welte has submitted this change and it was merged.

Change subject: VLR: remove unused parameter
..


VLR: remove unused parameter

The expire_lu is never used but is printed for every subscriber. Let's
remove it to avoid confusion.

Change-Id: I6f7ad1670836384d1e6a58f47a13464fdbbf8509
---
M include/osmocom/msc/vlr.h
M src/libmsc/vty_interface_layer3.c
2 files changed, 0 insertions(+), 8 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/msc/vlr.h b/include/osmocom/msc/vlr.h
index 1b365a9..d68b7be 100644
--- a/include/osmocom/msc/vlr.h
+++ b/include/osmocom/msc/vlr.h
@@ -136,7 +136,6 @@
bool la_allowed;
 
int use_count;
-   time_t expire_lu;   /* FIXME: overlap with 
periodic_lu_timer/age_indicator */
 
struct osmo_fsm_inst *lu_fsm;
struct osmo_fsm_inst *auth_fsm;
diff --git a/src/libmsc/vty_interface_layer3.c 
b/src/libmsc/vty_interface_layer3.c
index 02a3600..65ba178 100644
--- a/src/libmsc/vty_interface_layer3.c
+++ b/src/libmsc/vty_interface_layer3.c
@@ -64,7 +64,6 @@
 {
int reqs;
struct llist_head *entry;
-   char expire_time[200];
 
if (strlen(vsub->name))
vty_out(vty, "Name: '%s'%s", vsub->name, VTY_NEWLINE);
@@ -109,12 +108,6 @@
osmo_hexdump(t->vec.kc, sizeof(t->vec.kc)),
VTY_NEWLINE);
}
-
-   /* print the expiration time of a subscriber */
-   strftime(expire_time, sizeof(expire_time),
-   "%a, %d %b %Y %T %z", localtime(>expire_lu));
-   expire_time[sizeof(expire_time) - 1] = '\0';
-   vty_out(vty, "Expiration Time: %s%s", expire_time, VTY_NEWLINE);
 
reqs = 0;
llist_for_each(entry, >cs.requests)

-- 
To view, visit https://gerrit.osmocom.org/5620
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6f7ad1670836384d1e6a58f47a13464fdbbf8509
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

osmo-msc[master]: VLR: remove unused parameter

2017-12-30 Thread Harald Welte 

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/5620
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f7ad1670836384d1e6a58f47a13464fdbbf8509
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

gapk[master]: Add git-review config

2017-12-30 Thread Harald Welte 

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/5624
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4304dc8248087c23aaf3a5d205cd341ed6a758a
Gerrit-PatchSet: 1
Gerrit-Project: gapk
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: tnt 
Gerrit-HasComments: No

pysim[master]: pySim-*.py: Set shebang to use python v2

2017-12-30 Thread Harald Welte 

Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/5621
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ab4e9edc44a8045915d4828c6de2fa98027fb7e
Gerrit-PatchSet: 2
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Max 
Gerrit-HasComments: No

pysim[master]: pySim-prog.py: Fix trailing whitespace

2017-12-30 Thread Harald Welte 

Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/5622
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I735dc7bb774d77d3b60b1712b0f0afcbb81dc726
Gerrit-PatchSet: 2
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Max 
Gerrit-HasComments: No