osmo-msc[master]: Track libosmocore API change in osmo-msc.

[Neels Hofmeyr]

Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/6518/1/src/libmsc/a_iface.c
File src/libmsc/a_iface.c:

Line 197:   struct gsm0808_cell_id_list cil;
we have gsm0808_cell_id_list2 now, right?


-- 
To view, visit https://gerrit.osmocom.org/6518
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67377270cf3b081ac5dc9cd7b4dc28f74143753a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: Yes

osmo-bsc[master]: handover_test: explicitly wrap abis_rsl_sendmsg()

[Neels Hofmeyr]

Patch Set 1:

(1 comment)

so then this is entirely cosmetic...

https://gerrit.osmocom.org/#/c/7121/1//COMMIT_MSG
Commit Message:

Line 11: magic (aka luck).
> I don't think so. The linker should ever only look for linking other files 
but this only works when the other implementation is in a library? Can we by 
accident have two implementations of the same function, and each one is 
preferred by different parts of the code? (shudder!)


-- 
To view, visit https://gerrit.osmocom.org/7121
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05ce33a4e42bc82b9ce5060e2f811033f5a1f8d8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: Yes

libasn1c[master]: configure: add --enable-werror

[Harald Welte]

Patch Set 1:

I would really hope there is another method than to add a configure.ac flag for 
every compiler option / CFLAG we ever want to sue from our continuous 
integration setup.  I know, it's easy to complain and if it helps, ok.  But it 
just feels like the wrong approach to me, sorry.

-- 
To view, visit https://gerrit.osmocom.org/7096
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcc8238584a585434b39a046cd2d7e18ddaf7f8c
Gerrit-PatchSet: 1
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

osmo-bsc[master]: handover_test: explicitly wrap abis_rsl_sendmsg()

[Harald Welte]

Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/7121/1//COMMIT_MSG
Commit Message:

PS1, Line 10: a
no babies were harmed ;)


Line 11: magic (aka luck).
I don't think so. The linker should ever only look for linking other files if 
there's an unresolved symbol in the curent file.  So as long as you define the 
function in the same file where you use it, the local symbol should always have 
preference over any "remote" symbol.


-- 
To view, visit https://gerrit.osmocom.org/7121
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05ce33a4e42bc82b9ce5060e2f811033f5a1f8d8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

osmo-trx[master]: osmo-trx: Use VTY cfg structures while still allowing cmd li...

[Harald Welte]

Patch Set 6:

While you're at it, it would be the perfect opportunity now to create a 
osmo-trx-usermanual and osmo-trx-vty-reference in osmo-gsm-manuals.git even 
with only minimal content to help users with a manual as they convert their 
setups

-- 
To view, visit https://gerrit.osmocom.org/6651
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8de1a5da4b3c0b6a49e00033f616e1d66656adf
Gerrit-PatchSet: 6
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/armv7l

Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  238s] | #define HAVE_STDINT_H 1
[  238s] | #define HAVE_UNISTD_H 1
[  238s] | #define HAVE_DLFCN_H 1
[  238s] | #define LT_OBJDIR ".libs/"
[  238s] | #define BUILD_SMPP 1
[  238s] | #define STDC_HEADERS 1
[  238s] | #define HAVE_DBI_DBD_H 1
[  238s] | #define HAVE_PCAP_PCAP_H 1
[  238s] | #define HAVE_TM_GMTOFF_IN_TM 1
[  238s] | 
[  238s] | configure: exit 0
[  238s] 
[  238s] debian/rules:32: recipe for target 'override_dh_auto_test' failed
[  238s] make[1]: *** [override_dh_auto_test] Error 1
[  238s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  238s] debian/rules:13: recipe for target 'build' failed
[  238s] make: *** [build] Error 2
[  238s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  238s] 
[  238s] armbuild26 failed "build openbsc_1.0.0.20180305.dsc" at Mon Mar  5 
22:24:50 UTC 2018.
[  238s] 
[  238s] ### VM INTERACTION START ###
[  241s] [  221.971036] SysRq : Power Off
[  241s] [  221.986643] reboot: Power down
[  241s] qemu-system-aarch64: Failed to unlink socket 
/var/cache/obs/worker/root_4/root.monitor: Permission denied
[  241s] ### VM INTERACTION END ###
[  241s] 
[  241s] armbuild26 failed "build openbsc_1.0.0.20180305.dsc" at Mon Mar  5 
22:24:53 UTC 2018.
[  241s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

osmo-trx[master]: osmo-trx: Use VTY cfg structures while still allowing cmd li...

[Harald Welte]

Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/6651
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8de1a5da4b3c0b6a49e00033f616e1d66656adf
Gerrit-PatchSet: 6
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

osmo-trx[master]: doc: Add sample cfg file for LimeSDR

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7095
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16de70eac0fd79107b8317af37201e6da834c169
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

osmo-trx[master]: vty: Implement VTY cfg parsing for current parameters

[Harald Welte]

Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/6650
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie084c1b30b63f91c6e7640832ec1797d9e813832
Gerrit-PatchSet: 6
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-HasComments: No

osmo-trx[master]: Move enums required by VTY to a separate header

[Harald Welte]

Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/6649
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d5b0576aa96869756f1629a40306c0043b6304b
Gerrit-PatchSet: 6
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-HasComments: No

osmo-trx[master]: osmo-trx.cpp: Move trx start and stop to helper functions

[Harald Welte]

Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/6648
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10eaaafe38ace2b7bb095a0ad1db70d6c06ee03b
Gerrit-PatchSet: 6
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/aarch64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/aarch64

Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/aarch64

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  433s] | configure:12638: result: yes
[  433s] | configure:12644: checking for LIBOSMOCTRL
[  433s] | configure:12651: $PKG_CONFIG --exists --print-errors "libosmoctrl"
[  433s] | configure:12654: $? = 0
[  433s] | configure:12668: $PKG_CONFIG --exists --print-errors "libosmoctrl"
[  433s] | configure:12671: $? = 0
[  433s] | configure:12729: result: yes
[  433s] | configure:12735: checking for LIBOSMOGSM
[  433s] | configure:12742: $PKG_CONFIG --exists --print-errors "libosmogsm >= 
0.9.5"
[  433s] | configure:12745: $? = 0
[  433s] | configure:12759: $PKG_CONFIG --exists --print-errors "libosmogsm >= 
0.9.5"
[  433s] | configure:12762: $? = 0
[  433s] | configure:12820: result: yes
[  433s] | configure:12826: checking for LIBOSMOABIS
[  433s] | configure:12833: $PKG_CONFIG --exists --print-errors "libosmoabis >= 
0.2.0"
[  433s] | configure:12836: $? = 0
[  433s] | configure:12850: $PKG_CONFIG --exists --print-errors "libosmoabis >= 
0.2.0"
[  433s] | configure:12853: $? = 0
[  433s] | configure:12911: result: yes
[  433s] | configure:12917: checking for LIBOSMOGB
[  433s] | configure:12924: $PKG_CONFIG --exists --print-errors "libosmogb >= 
0.6.4"
[  433s] | configure:12927: $? = 0
[  435s] | configure:12941: $PKG_CONFIG --exists --print-[  406.094406] sysrq: 
SysRq : Power Off
[  435s] [  406.097891] reboot: Power down
[  435s] qemu-system-aarch64: Failed to unlink socket 
/var/cache/obs/worker/root_15/root.monitor: Permission denied
[  435s] ### VM INTERACTION END ###
[  435s] 
[  435s] obs-arm-3 failed "build openbsc_1.0.0.20180305.dsc" at Mon Mar  5 
21:12:24 UTC 2018.
[  435s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

[PATCH] osmo-bsc[master]: handover_test: explicitly wrap abis_rsl_sendmsg()

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7121

handover_test: explicitly wrap abis_rsl_sendmsg()

Until now, handover_test simply defines an abis_rsl_sendmsg() function to
override the one from libosmo-babis. To me this amounts to implicit linker
magic (aka luck).

The common pattern we're using for this scenario is to explicitly wrap an
existing function by instructing the linker. Also do this for
abis_rsl_sendmsg() in handover_test.c to clarify.

Change-Id: I05ce33a4e42bc82b9ce5060e2f811033f5a1f8d8
---
M tests/handover/Makefile.am
M tests/handover/handover_test.c
2 files changed, 8 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/21/7121/1

diff --git a/tests/handover/Makefile.am b/tests/handover/Makefile.am
index 5cdc0b0..7133fcd 100644
--- a/tests/handover/Makefile.am
+++ b/tests/handover/Makefile.am
@@ -27,6 +27,10 @@
handover_test.c \
$(NULL)
 
+handover_test_LDFLAGS =\
+   -Wl,--wrap=abis_rsl_sendmsg \
+   $(NULL)
+
 handover_test_LDADD = \
$(top_builddir)/src/libbsc/libbsc.a \
$(LIBOSMOCORE_LIBS) \
diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c
index 8ba97fd..bf7350c 100644
--- a/tests/handover/handover_test.c
+++ b/tests/handover/handover_test.c
@@ -339,8 +339,10 @@
abis_rsl_rcvmsg(msg);
 }
 
-/* RSL messages from BSC */
-int abis_rsl_sendmsg(struct msgb *msg)
+/* override, requires '-Wl,--wrap=abis_rsl_sendmsg'.
+ * Catch RSL messages sent towards the BTS. */
+int __real_abis_rsl_sendmsg(struct msgb *msg);
+int __wrap_abis_rsl_sendmsg(struct msgb *msg)
 {
struct abis_rsl_dchan_hdr *dh = (struct abis_rsl_dchan_hdr *) msg->data;
struct e1inp_sign_link *sign_link = msg->dst;

-- 
To view, visit https://gerrit.osmocom.org/7121
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I05ce33a4e42bc82b9ce5060e2f811033f5a1f8d8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  141s] | #define HAVE_INTTYPES_H 1
[  141s] | #define HAVE_STDINT_H 1
[  141s] | #define HAVE_UNISTD_H 1
[  141s] | #define HAVE_DLFCN_H 1
[  141s] | #define LT_OBJDIR ".libs/"
[  141s] | #define BUILD_SMPP 1
[  141s] | #define STDC_HEADERS 1
[  141s] | #define HAVE_DBI_DBD_H 1
[  141s] | #define HAVE_PCAP_PCAP_H 1
[  141s] | #define HAVE_TM_GMTOFF_IN_TM 1
[  141s] | 
[  141s] | configure: exit 0
[  141s] 
[  141s] debian/rules:32: recipe for target 'override_dh_auto_test' failed
[  141s] make[1]: *** [override_dh_auto_test] Error 1
[  141s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  141s] debian/rules:13: recipe for target 'build' failed
[  141s] make: *** [build] Error 2
[  141s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  141s] 
[  141s] lamb20 failed "build openbsc_1.0.0.20180305.dsc" at Mon Mar  5 
20:54:33 UTC 2018.
[  141s] 
[  141s] ### VM INTERACTION START ###
[  144s] [  136.658791] reboot: Power down
[  144s] qemu-system-x86_64: Failed to unlink socket 
/var/cache/obs/worker/root_3/root.monitor: Permission denied
[  144s] ### VM INTERACTION END ###
[  144s] 
[  144s] lamb20 failed "build openbsc_1.0.0.20180305.dsc" at Mon Mar  5 
20:54:36 UTC 2018.
[  144s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/i586

Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  341s] | #define HAVE_INTTYPES_H 1
[  341s] | #define HAVE_STDINT_H 1
[  341s] | #define HAVE_UNISTD_H 1
[  341s] | #define HAVE_DLFCN_H 1
[  341s] | #define LT_OBJDIR ".libs/"
[  341s] | #define BUILD_SMPP 1
[  341s] | #define STDC_HEADERS 1
[  341s] | #define HAVE_DBI_DBD_H 1
[  341s] | #define HAVE_PCAP_PCAP_H 1
[  341s] | #define HAVE_TM_GMTOFF_IN_TM 1
[  341s] | 
[  341s] | configure: exit 0
[  341s] 
[  341s] debian/rules:32: recipe for target 'override_dh_auto_test' failed
[  341s] make[1]: *** [override_dh_auto_test] Error 1
[  341s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  341s] debian/rules:13: recipe for target 'build' failed
[  341s] make: *** [build] Error 2
[  341s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  341s] 
[  341s] lamb53 failed "build openbsc_1.0.0.20180305.dsc" at Mon Mar  5 
20:48:23 UTC 2018.
[  341s] 
[  341s] ### VM INTERACTION START ###
[  344s] [  318.621276] reboot: Power down
[  344s] qemu-system-x86_64: Failed to unlink socket 
/var/cache/obs/worker/root_7/root.monitor: Permission denied
[  344s] ### VM INTERACTION END ###
[  344s] 
[  344s] lamb53 failed "build openbsc_1.0.0.20180305.dsc" at Mon Mar  5 
20:48:26 UTC 2018.
[  344s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/i586

Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  251s] | lt_cv_sys_global_symbol_to_c_name_address='sed -n -e '\''s/^: \(.*\) 
.*$/  {"\1", (void *) 0},/p'\'' -e '\''s/^[ABCDGIRSTW][ABCDGIRSTW]* .* \(.*\)$/ 
 {"\1", (void *) \&\1},/p'\'''
[  251s] | lt_cv_sys_global_symbol_to_c_name_address_lib_prefix='sed -n -e 
'\''s/^: \(.*\) .*$/  {"\1", (void *) 0},/p'\'' -e 
'\''s/^[ABCDGIRSTW][ABCDGIRSTW]* .* \(lib.*\)$/  {"\1", (void *) \&\1},/p'\'' 
-e '\''s/^[ABCDGIRSTW][ABCDGIRSTW]* .* \(.*\)$/  {"lib\1", (void *) 
\&\1},/p'\'''
[  251s] | lt_cv_sys_global_symbol_to_cdecl='sed -n -e '\''s/^T .* 
\(.*\)$/extern int \1();/p'\'' -e '\''s/^[ABCDGIRSTW][ABCDGIRSTW]* .* 
\(.*\)$/extern char \1;/p'\'''
[  251s] | lt_cv_sys_global_symbol_to_import=
[  251s] | lt_cv_sys_max_cmd_len=1572864
[  251s] | lt_cv_to_host_file_cmd=func_convert_file_noop
[  251s] | lt_cv_to_tool_file_cmd=func_convert_file_noop
[  251s] | lt_cv_truncate_bin='/bin/dd bs=4096 count=1'
[  251s] | osmo_cv_tm_includes_tm_gmtoff=yes
[  251s] | pkg_cv_LIBCRYPTO_CFLAGS=
[  251s] | pkg_cv_LIBCRYPTO_LIBS=-lcrypto
[  251s] | pkg_cv_LIBOSMOABIS_CFLAGS=-I/usr/include/
[  251s] | pkg_cv_LIBOSMOABIS_LIBS=-losmoabis
[  251s] | pkg_cv_LIBOSMOCORE_CFLAGS=-I/usr/include/
[  251s] | pkg_cv_LIBOSMOCORE_LIBS='-ltalloc -losmocore'
[  251s] | pkg_cv_LIBOSMOCTRL_CFLAGS=-I/usr/include/
[  251s] | pkg_cv_LIBOSMOCTRL_LIBS='-ltalloc -losmoctrl -losmogsm -losmocore'
[  251s] | pkg_cv_LIBOSMOGB_CFLAGS='-fno-strict-aliasing -I/usr/include/'
[  251s] | pkg_cv_LIBOSMOGB_LIBS='-ltalloc -losmogb -losmovty -losmocore'
[  251s] | pkg_cv_LIBOSMOGSM_CFLAGS=-I/usr/include/
[  251s] | pkg_cv_LIBOSMOGSM_LIBS='-ltalloc -losmogsm -losmocore'
[  251s] | pkg_cv_LIBOSMONETIF_CFLAGS=-I/usr/include/
[  251s] | pkg_cv_LIBOSMONETIF_LIBS=-losmonetif
[  253s] | pkg_cv_LIBOSMOSCCP_CFLAGS=-I/usr/incl[  244.340071] reboot: Power 
down
[  253s] qemu-system-x86_64: Failed to unlink socket 
/var/cache/obs/worker/root_6/root.monitor: Permission denied
[  253s] ### VM INTERACTION END ###
[  253s] 
[  253s] lamb26 failed "build openbsc_1.0.0.20180305.dsc" at Mon Mar  5 
20:48:06 UTC 2018.
[  253s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.10/i586

Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly openbsc

Last lines of build log:
[  147s] | #define HAVE_INTTYPES_H 1
[  147s] | #define HAVE_STDINT_H 1
[  147s] | #define HAVE_UNISTD_H 1
[  147s] | #define HAVE_DLFCN_H 1
[  147s] | #define LT_OBJDIR ".libs/"
[  147s] | #define BUILD_SMPP 1
[  147s] | #define STDC_HEADERS 1
[  147s] | #define HAVE_DBI_DBD_H 1
[  147s] | #define HAVE_PCAP_PCAP_H 1
[  147s] | #define HAVE_TM_GMTOFF_IN_TM 1
[  147s] | 
[  147s] | configure: exit 0
[  147s] 
[  147s] debian/rules:32: recipe for target 'override_dh_auto_test' failed
[  147s] make[1]: *** [override_dh_auto_test] Error 1
[  147s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  147s] debian/rules:13: recipe for target 'build' failed
[  147s] make: *** [build] Error 2
[  147s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  147s] 
[  147s] lamb06 failed "build openbsc_1.0.0.20180305.dsc" at Mon Mar  5 
20:46:16 UTC 2018.
[  147s] 
[  147s] ### VM INTERACTION START ###
[  150s] [  142.941245] reboot: Power down
[  150s] qemu-system-x86_64: Failed to unlink socket 
/var/cache/obs/worker/root_5/root.monitor: Permission denied
[  150s] ### VM INTERACTION END ###
[  150s] 
[  150s] lamb06 failed "build openbsc_1.0.0.20180305.dsc" at Mon Mar  5 
20:46:19 UTC 2018.
[  150s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

[MERGED] openbsc[master]: fix build: gprs_ra_id_by_bts(): ensure to init all values

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged.

Change subject: fix build: gprs_ra_id_by_bts(): ensure to init all values
..


fix build: gprs_ra_id_by_bts(): ensure to init all values

After recent libosmocore commit "implement support for 3-digit MNC with leading
zeros" c4fce1425e19d604c199c895e227dc2519110456
Id2240f7f518494c9df6c8bda52c0d5092f90f221, struct gprs_ra_id has a new member,
namely mnc_3_digits. In gprs_ra_id_by_bts(), this new member is now not
initialized and may end up having an arbitrary value, which then may amount to
mnc_3_digits == true. Hence the resulting BCD representation of the MCC-MNC may
inadvertently and randomly indicate a leading zero on the MNC.

Use a struct assignment so that all members are guaranteed to be set, and so
that mnc_3_digits will be zero in all cases.

Since above libosmocore commit, nanobts_omlattr_test fails "randomly", fixed by
this patch.

Change-Id: I5ae899f3c236b3b4feb5c8cf762e2f2d964dbc65
---
M openbsc/src/libcommon/gsm_data.c
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/libcommon/gsm_data.c b/openbsc/src/libcommon/gsm_data.c
index 55d6fce..2028f05 100644
--- a/openbsc/src/libcommon/gsm_data.c
+++ b/openbsc/src/libcommon/gsm_data.c
@@ -338,10 +338,12 @@
 
 void gprs_ra_id_by_bts(struct gprs_ra_id *raid, struct gsm_bts *bts)
 {
-   raid->mcc = bts->network->country_code;
-   raid->mnc = bts->network->network_code;
-   raid->lac = bts->location_area_code;
-   raid->rac = bts->gprs.rac;
+   *raid = (struct gprs_ra_id){
+   .mcc = bts->network->country_code,
+   .mnc = bts->network->network_code,
+   .lac = bts->location_area_code,
+   .rac = bts->gprs.rac,
+   };
 }
 
 int gsm48_ra_id_by_bts(uint8_t *buf, struct gsm_bts *bts)

-- 
To view, visit https://gerrit.osmocom.org/7120
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5ae899f3c236b3b4feb5c8cf762e2f2d964dbc65
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 

openbsc[master]: fix build: gprs_ra_id_by_bts(): ensure to init all values

[Neels Hofmeyr]

Patch Set 1: Code-Review+2

(backport of osmo-bsc fix)

-- 
To view, visit https://gerrit.osmocom.org/7120
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ae899f3c236b3b4feb5c8cf762e2f2d964dbc65
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

[PATCH] openbsc[master]: fix build: gprs_ra_id_by_bts(): ensure to init all values

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7120

fix build: gprs_ra_id_by_bts(): ensure to init all values

After recent libosmocore commit "implement support for 3-digit MNC with leading
zeros" c4fce1425e19d604c199c895e227dc2519110456
Id2240f7f518494c9df6c8bda52c0d5092f90f221, struct gprs_ra_id has a new member,
namely mnc_3_digits. In gprs_ra_id_by_bts(), this new member is now not
initialized and may end up having an arbitrary value, which then may amount to
mnc_3_digits == true. Hence the resulting BCD representation of the MCC-MNC may
inadvertently and randomly indicate a leading zero on the MNC.

Use a struct assignment so that all members are guaranteed to be set, and so
that mnc_3_digits will be zero in all cases.

Since above libosmocore commit, nanobts_omlattr_test fails "randomly", fixed by
this patch.

Change-Id: I5ae899f3c236b3b4feb5c8cf762e2f2d964dbc65
---
M openbsc/src/libcommon/gsm_data.c
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/20/7120/1

diff --git a/openbsc/src/libcommon/gsm_data.c b/openbsc/src/libcommon/gsm_data.c
index 55d6fce..2028f05 100644
--- a/openbsc/src/libcommon/gsm_data.c
+++ b/openbsc/src/libcommon/gsm_data.c
@@ -338,10 +338,12 @@
 
 void gprs_ra_id_by_bts(struct gprs_ra_id *raid, struct gsm_bts *bts)
 {
-   raid->mcc = bts->network->country_code;
-   raid->mnc = bts->network->network_code;
-   raid->lac = bts->location_area_code;
-   raid->rac = bts->gprs.rac;
+   *raid = (struct gprs_ra_id){
+   .mcc = bts->network->country_code,
+   .mnc = bts->network->network_code,
+   .lac = bts->location_area_code,
+   .rac = bts->gprs.rac,
+   };
 }
 
 int gsm48_ra_id_by_bts(uint8_t *buf, struct gsm_bts *bts)

-- 
To view, visit https://gerrit.osmocom.org/7120
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ae899f3c236b3b4feb5c8cf762e2f2d964dbc65
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] osmo-sgsn[master]: configure: add --enable-werror

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7119

configure: add --enable-werror

Provide a sane means of adding the -Werror compiler flag.

Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"',
but that actually *overwrites* all the other CFLAGS we might want to have set.

Maintain these exceptions from -Werror:
a) deprecation (allow upstream to mark deprecation without breaking builds);
b) "#warning" pragmas (allow to remind ourselves of errors without breaking
   builds)

As a last configure step before generating the output files, print the complete
CFLAGS and CPPFLAGS by means of AC_MSG_RESULT.

Change-Id: Ifea235feb073a276302436936e908d9125c77a82
---
M configure.ac
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/19/7119/1

diff --git a/configure.ac b/configure.ac
index 504157b..1b23d27 100644
--- a/configure.ac
+++ b/configure.ac
@@ -80,6 +80,24 @@
CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined"
 fi
 
+AC_ARG_ENABLE(werror,
+   [AS_HELP_STRING(
+   [--enable-werror],
+   [Turn all compiler warnings into errors, with exceptions:
+a) deprecation (allow upstream to mark deprecation without 
breaking builds);
+b) "#warning" pragmas (allow to remind ourselves of errors 
without breaking builds)
+   ]
+   )],
+   [werror=$enableval], [werror="no"])
+if test x"$werror" = x"yes"
+then
+   WERROR_FLAGS="-Werror"
+   WERROR_FLAGS+=" -Wno-error=deprecated 
-Wno-error=deprecated-declarations"
+   WERROR_FLAGS+=" -Wno-error=cpp" # "#warning"
+   CFLAGS="$CFLAGS $WERROR_FLAGS"
+   CPPFLAGS="$CPPFLAGS $WERROR_FLAGS"
+fi
+
 # The following test is taken from WebKit's webkit.m4
 saved_CFLAGS="$CFLAGS"
 CFLAGS="$CFLAGS -fvisibility=hidden "
@@ -158,6 +176,9 @@
 AC_MSG_RESULT([$enable_ext_tests])
 AM_CONDITIONAL(ENABLE_EXT_TESTS, test "x$enable_ext_tests" = "xyes")
 
+AC_MSG_RESULT([CFLAGS="$CFLAGS"])
+AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"])
+
 dnl Generate the output
 AM_CONFIG_HEADER(bscconfig.h)
 

-- 
To view, visit https://gerrit.osmocom.org/7119
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifea235feb073a276302436936e908d9125c77a82
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] osmo-pcu[master]: configure: add --enable-werror

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7118

configure: add --enable-werror

Provide a sane means of adding the -Werror compiler flag.

Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"',
but that actually *overwrites* all the other CFLAGS we might want to have set.

Maintain these exceptions from -Werror:
a) deprecation (allow upstream to mark deprecation without breaking builds);
b) "#warning" pragmas (allow to remind ourselves of errors without breaking
   builds)

As a last configure step before generating the output files, print the complete
CFLAGS and CPPFLAGS by means of AC_MSG_RESULT.

Change-Id: I0f735913fc3bbda695c4e66449dcfc94f417dafb
---
M configure.ac
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/18/7118/1

diff --git a/configure.ac b/configure.ac
index 3706b6c..8cddd1a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -45,6 +45,24 @@
LDFLAGS="$LDFLAGS -fsanitize=address -fsanitize=undefined"
 fi
 
+AC_ARG_ENABLE(werror,
+   [AS_HELP_STRING(
+   [--enable-werror],
+   [Turn all compiler warnings into errors, with exceptions:
+a) deprecation (allow upstream to mark deprecation without 
breaking builds);
+b) "#warning" pragmas (allow to remind ourselves of errors 
without breaking builds)
+   ]
+   )],
+   [werror=$enableval], [werror="no"])
+if test x"$werror" = x"yes"
+then
+   WERROR_FLAGS="-Werror"
+   WERROR_FLAGS+=" -Wno-error=deprecated 
-Wno-error=deprecated-declarations"
+   WERROR_FLAGS+=" -Wno-error=cpp" # "#warning"
+   CFLAGS="$CFLAGS $WERROR_FLAGS"
+   CPPFLAGS="$CPPFLAGS $WERROR_FLAGS"
+fi
+
 AC_ARG_ENABLE(profile,
[AS_HELP_STRING([--enable-profile], [Compile with profiling 
support enabled], )],
[profile=$enableval], [profile="no"])
@@ -116,6 +134,9 @@
 STD_DEFINES_AND_INCLUDES="-Wall"
 AC_SUBST(STD_DEFINES_AND_INCLUDES)
 
+AC_MSG_RESULT([CFLAGS="$CFLAGS"])
+AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"])
+
 AC_OUTPUT(
 osmo-pcu.pc
 include/Makefile

-- 
To view, visit https://gerrit.osmocom.org/7118
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f735913fc3bbda695c4e66449dcfc94f417dafb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] osmo-mgw[master]: configure: add --enable-werror

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7116

configure: add --enable-werror

Provide a sane means of adding the -Werror compiler flag.

Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"',
but that actually *overwrites* all the other CFLAGS we might want to have set.

Maintain these exceptions from -Werror:
a) deprecation (allow upstream to mark deprecation without breaking builds);
b) "#warning" pragmas (allow to remind ourselves of errors without breaking
   builds)

As a last configure step before generating the output files, print the complete
CFLAGS and CPPFLAGS by means of AC_MSG_RESULT.

Change-Id: Ia66aa48e957f4dcbdf8a7df3010b84f472c33f76
---
M configure.ac
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/16/7116/1

diff --git a/configure.ac b/configure.ac
index 859acd1..fed44f0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -56,6 +56,24 @@
CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined"
 fi
 
+AC_ARG_ENABLE(werror,
+   [AS_HELP_STRING(
+   [--enable-werror],
+   [Turn all compiler warnings into errors, with exceptions:
+a) deprecation (allow upstream to mark deprecation without 
breaking builds);
+b) "#warning" pragmas (allow to remind ourselves of errors 
without breaking builds)
+   ]
+   )],
+   [werror=$enableval], [werror="no"])
+if test x"$werror" = x"yes"
+then
+   WERROR_FLAGS="-Werror"
+   WERROR_FLAGS+=" -Wno-error=deprecated 
-Wno-error=deprecated-declarations"
+   WERROR_FLAGS+=" -Wno-error=cpp" # "#warning"
+   CFLAGS="$CFLAGS $WERROR_FLAGS"
+   CPPFLAGS="$CPPFLAGS $WERROR_FLAGS"
+fi
+
 # Enable/disable transcoding within osmo-bsc_mgcp?
 AC_ARG_ENABLE([mgcp-transcoding], [AS_HELP_STRING([--enable-mgcp-transcoding], 
[Build the MGCP gateway with internal transcoding enabled.])],
 [osmo_ac_mgcp_transcoding="$enableval"],[osmo_ac_mgcp_transcoding="no"])
@@ -126,6 +144,9 @@
 AC_MSG_RESULT([$enable_ext_tests])
 AM_CONDITIONAL(ENABLE_EXT_TESTS, test "x$enable_ext_tests" = "xyes")
 
+AC_MSG_RESULT([CFLAGS="$CFLAGS"])
+AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"])
+
 dnl Generate the output
 AM_CONFIG_HEADER(bscconfig.h)
 

-- 
To view, visit https://gerrit.osmocom.org/7116
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia66aa48e957f4dcbdf8a7df3010b84f472c33f76
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] osmo-msc[master]: configure: add --enable-werror

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7117

configure: add --enable-werror

Provide a sane means of adding the -Werror compiler flag.

Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"',
but that actually *overwrites* all the other CFLAGS we might want to have set.

Maintain these exceptions from -Werror:
a) deprecation (allow upstream to mark deprecation without breaking builds);
b) "#warning" pragmas (allow to remind ourselves of errors without breaking
   builds)

As a last configure step before generating the output files, print the complete
CFLAGS and CPPFLAGS by means of AC_MSG_RESULT.

Change-Id: I0528dcb14bf79d0920905a718cc2edea1434c0e5
---
M configure.ac
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/17/7117/1

diff --git a/configure.ac b/configure.ac
index feb3de9..e8ae88c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -62,6 +62,24 @@
CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined"
 fi
 
+AC_ARG_ENABLE(werror,
+   [AS_HELP_STRING(
+   [--enable-werror],
+   [Turn all compiler warnings into errors, with exceptions:
+a) deprecation (allow upstream to mark deprecation without 
breaking builds);
+b) "#warning" pragmas (allow to remind ourselves of errors 
without breaking builds)
+   ]
+   )],
+   [werror=$enableval], [werror="no"])
+if test x"$werror" = x"yes"
+then
+   WERROR_FLAGS="-Werror"
+   WERROR_FLAGS+=" -Wno-error=deprecated 
-Wno-error=deprecated-declarations"
+   WERROR_FLAGS+=" -Wno-error=cpp" # "#warning"
+   CFLAGS="$CFLAGS $WERROR_FLAGS"
+   CPPFLAGS="$CPPFLAGS $WERROR_FLAGS"
+fi
+
 # Enable/disable smpp support in the msc?
 AC_ARG_ENABLE([smpp], [AS_HELP_STRING([--enable-smpp], [Build the SMPP 
interface])],
 [osmo_ac_build_smpp="$enableval"],[osmo_ac_build_smpp="no"])
@@ -175,6 +193,9 @@
 AC_MSG_RESULT([$enable_ext_tests])
 AM_CONDITIONAL(ENABLE_EXT_TESTS, test "x$enable_ext_tests" = "xyes")
 
+AC_MSG_RESULT([CFLAGS="$CFLAGS"])
+AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"])
+
 dnl Generate the output
 AM_CONFIG_HEADER(bscconfig.h)
 

-- 
To view, visit https://gerrit.osmocom.org/7117
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0528dcb14bf79d0920905a718cc2edea1434c0e5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] osmo-iuh[master]: configure: add --enable-werror

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7115

configure: add --enable-werror

Provide a sane means of adding the -Werror compiler flag.

Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"',
but that actually *overwrites* all the other CFLAGS we might want to have set.

Maintain these exceptions from -Werror:
a) deprecation (allow upstream to mark deprecation without breaking builds);
b) "#warning" pragmas (allow to remind ourselves of errors without breaking
   builds)

As a last configure step before generating the output files, print the complete
CFLAGS and CPPFLAGS by means of AC_MSG_RESULT.

Change-Id: Id659512d2d9fb3f28584ec5f071907f6b6e72e0d
---
M configure.ac
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/15/7115/1

diff --git a/configure.ac b/configure.ac
index dd1d75e..8a654dc 100644
--- a/configure.ac
+++ b/configure.ac
@@ -58,9 +58,30 @@
CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined"
 fi
 
+AC_ARG_ENABLE(werror,
+   [AS_HELP_STRING(
+   [--enable-werror],
+   [Turn all compiler warnings into errors, with exceptions:
+a) deprecation (allow upstream to mark deprecation without 
breaking builds);
+b) "#warning" pragmas (allow to remind ourselves of errors 
without breaking builds)
+   ]
+   )],
+   [werror=$enableval], [werror="no"])
+if test x"$werror" = x"yes"
+then
+   WERROR_FLAGS="-Werror"
+   WERROR_FLAGS+=" -Wno-error=deprecated 
-Wno-error=deprecated-declarations"
+   WERROR_FLAGS+=" -Wno-error=cpp" # "#warning"
+   CFLAGS="$CFLAGS $WERROR_FLAGS"
+   CPPFLAGS="$CPPFLAGS $WERROR_FLAGS"
+fi
+
 CFLAGS="$CFLAGS -Wall"
 CPPFLAGS="$CPPFLAGS -Wall"
 
+AC_MSG_RESULT([CFLAGS="$CFLAGS"])
+AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"])
+
 AC_OUTPUT(
libosmo-ranap.pc
src/Makefile

-- 
To view, visit https://gerrit.osmocom.org/7115
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id659512d2d9fb3f28584ec5f071907f6b6e72e0d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] osmo-bts[master]: configure: add --enable-werror

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7110

configure: add --enable-werror

Provide a sane means of adding the -Werror compiler flag.

Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"',
but that actually *overwrites* all the other CFLAGS we might want to have set.

Maintain these exceptions from -Werror:
a) deprecation (allow upstream to mark deprecation without breaking builds);
b) "#warning" pragmas (allow to remind ourselves of errors without breaking
   builds)

As a last configure step before generating the output files, print the complete
CFLAGS and CPPFLAGS by means of AC_MSG_RESULT.

Change-Id: I5b37602a117350159183fb53ac330294b94f4195
---
M configure.ac
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/10/7110/1

diff --git a/configure.ac b/configure.ac
index db8a97d..b375806 100644
--- a/configure.ac
+++ b/configure.ac
@@ -43,6 +43,24 @@
CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined"
 fi
 
+AC_ARG_ENABLE(werror,
+   [AS_HELP_STRING(
+   [--enable-werror],
+   [Turn all compiler warnings into errors, with exceptions:
+a) deprecation (allow upstream to mark deprecation without 
breaking builds);
+b) "#warning" pragmas (allow to remind ourselves of errors 
without breaking builds)
+   ]
+   )],
+   [werror=$enableval], [werror="no"])
+if test x"$werror" = x"yes"
+then
+   WERROR_FLAGS="-Werror"
+   WERROR_FLAGS+=" -Wno-error=deprecated 
-Wno-error=deprecated-declarations"
+   WERROR_FLAGS+=" -Wno-error=cpp" # "#warning"
+   CFLAGS="$CFLAGS $WERROR_FLAGS"
+   CPPFLAGS="$CPPFLAGS $WERROR_FLAGS"
+fi
+
 dnl checks for libraries
 PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore  >= 0.10.0)
 PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 0.10.0)
@@ -185,6 +203,9 @@
CPPFLAGS=$oldCPPFLAGS
 fi
 
+AC_MSG_RESULT([CFLAGS="$CFLAGS"])
+AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"])
+
 AM_CONFIG_HEADER(btsconfig.h)
 
 AC_OUTPUT(

-- 
To view, visit https://gerrit.osmocom.org/7110
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b37602a117350159183fb53ac330294b94f4195
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] osmo-ggsn[master]: configure: add --enable-werror

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7111

configure: add --enable-werror

Provide a sane means of adding the -Werror compiler flag.

Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"',
but that actually *overwrites* all the other CFLAGS we might want to have set.

Maintain these exceptions from -Werror:
a) deprecation (allow upstream to mark deprecation without breaking builds);
b) "#warning" pragmas (allow to remind ourselves of errors without breaking
   builds)

As a last configure step before generating the output files, print the complete
CFLAGS and CPPFLAGS by means of AC_MSG_RESULT.

Change-Id: Ifcde5a110cbed0eaa250dd946927e3b0f4f9bd13
---
M configure.ac
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/11/7111/1

diff --git a/configure.ac b/configure.ac
index 1193e46..b9073e9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -151,6 +151,27 @@
CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined"
 fi
 
+AC_ARG_ENABLE(werror,
+   [AS_HELP_STRING(
+   [--enable-werror],
+   [Turn all compiler warnings into errors, with exceptions:
+a) deprecation (allow upstream to mark deprecation without 
breaking builds);
+b) "#warning" pragmas (allow to remind ourselves of errors 
without breaking builds)
+   ]
+   )],
+   [werror=$enableval], [werror="no"])
+if test x"$werror" = x"yes"
+then
+   WERROR_FLAGS="-Werror"
+   WERROR_FLAGS+=" -Wno-error=deprecated 
-Wno-error=deprecated-declarations"
+   WERROR_FLAGS+=" -Wno-error=cpp" # "#warning"
+   CFLAGS="$CFLAGS $WERROR_FLAGS"
+   CPPFLAGS="$CPPFLAGS $WERROR_FLAGS"
+fi
+
+AC_MSG_RESULT([CFLAGS="$CFLAGS"])
+AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"])
+
 AC_CONFIG_FILES([Makefile
  doc/Makefile
  doc/examples/Makefile

-- 
To view, visit https://gerrit.osmocom.org/7111
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifcde5a110cbed0eaa250dd946927e3b0f4f9bd13
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] osmo-hlr[master]: configure: add --enable-werror

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7113

configure: add --enable-werror

Provide a sane means of adding the -Werror compiler flag.

Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"',
but that actually *overwrites* all the other CFLAGS we might want to have set.

Maintain these exceptions from -Werror:
a) deprecation (allow upstream to mark deprecation without breaking builds);
b) "#warning" pragmas (allow to remind ourselves of errors without breaking
   builds)

As a last configure step before generating the output files, print the complete
CFLAGS and CPPFLAGS by means of AC_MSG_RESULT.

Change-Id: Id5c0740a37067cbe8986d52d63c6134769c71c47
---
M configure.ac
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/13/7113/1

diff --git a/configure.ac b/configure.ac
index ef234c5..723c43f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -59,6 +59,24 @@
CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined"
 fi
 
+AC_ARG_ENABLE(werror,
+   [AS_HELP_STRING(
+   [--enable-werror],
+   [Turn all compiler warnings into errors, with exceptions:
+a) deprecation (allow upstream to mark deprecation without 
breaking builds);
+b) "#warning" pragmas (allow to remind ourselves of errors 
without breaking builds)
+   ]
+   )],
+   [werror=$enableval], [werror="no"])
+if test x"$werror" = x"yes"
+then
+   WERROR_FLAGS="-Werror"
+   WERROR_FLAGS+=" -Wno-error=deprecated 
-Wno-error=deprecated-declarations"
+   WERROR_FLAGS+=" -Wno-error=cpp" # "#warning"
+   CFLAGS="$CFLAGS $WERROR_FLAGS"
+   CPPFLAGS="$CPPFLAGS $WERROR_FLAGS"
+fi
+
 AC_ARG_ENABLE([external_tests],
AC_HELP_STRING([--enable-external-tests],
[Include the VTY/CTRL tests in make check 
[default=no]]),
@@ -74,6 +92,9 @@
 AC_MSG_RESULT([$enable_ext_tests])
 AM_CONDITIONAL(ENABLE_EXT_TESTS, test "x$enable_ext_tests" = "xyes")
 
+AC_MSG_RESULT([CFLAGS="$CFLAGS"])
+AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"])
+
 AC_OUTPUT(
Makefile
doc/Makefile

-- 
To view, visit https://gerrit.osmocom.org/7113
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5c0740a37067cbe8986d52d63c6134769c71c47
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] osmo-hlr[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7114

jenkins.sh: use --enable-werror configure flag, not CFLAGS

Change-Id: I5fe776cf9ccb5d462c3c1fbbb1e31abe6f42bde6
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/14/7114/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index eaf4f2b..8dc0162 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -36,7 +36,7 @@
 
 cd "$base"
 autoreconf --install --force
-./configure --enable-sanitize --enable-external-tests CFLAGS="-Werror" 
CPPFLAGS="-Werror"
+./configure --enable-sanitize --enable-external-tests --enable-werror
 $MAKE $PARALLEL_MAKE
 $MAKE check || cat-testlogs.sh
 $MAKE distcheck || cat-testlogs.sh

-- 
To view, visit https://gerrit.osmocom.org/7114
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5fe776cf9ccb5d462c3c1fbbb1e31abe6f42bde6
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] osmo-ggsn[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7112

jenkins.sh: use --enable-werror configure flag, not CFLAGS

Change-Id: I64e542ad4da34a7ac3bc1b599a122ecff47e892d
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/12/7112/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 033eed7..19df974 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -38,7 +38,7 @@
 
 cd "$base"
 autoreconf --install --force
-./configure --enable-sanitize CFLAGS="-Werror" CPPFLAGS="-Werror" $GTP
+./configure --enable-sanitize --enable-werror $GTP
 $MAKE $PARALLEL_MAKE
 $MAKE distcheck
 

-- 
To view, visit https://gerrit.osmocom.org/7112
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I64e542ad4da34a7ac3bc1b599a122ecff47e892d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] osmo-bsc[master]: jenkins.sh: add --enable-werror to configure flags

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7109

jenkins.sh: add --enable-werror to configure flags

Change-Id: I2294151ab91522231095006a0599bea02e07c259
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/09/7109/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 5b57532..b0af127 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -40,7 +40,7 @@
 
 cd "$base"
 autoreconf --install --force
-./configure --enable-sanitize --enable-external-tests
+./configure --enable-sanitize --enable-werror --enable-external-tests
 $MAKE $PARALLEL_MAKE
 LD_LIBRARY_PATH="$inst/lib" $MAKE check \
   || cat-testlogs.sh

-- 
To view, visit https://gerrit.osmocom.org/7109
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2294151ab91522231095006a0599bea02e07c259
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] osmo-bsc[master]: configure: add --enable-werror

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7108

configure: add --enable-werror

Provide a sane means of adding the -Werror compiler flag.

Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"',
but that actually *overwrites* all the other CFLAGS we might want to have set.

Maintain these exceptions from -Werror:
a) deprecation (allow upstream to mark deprecation without breaking builds);
b) "#warning" pragmas (allow to remind ourselves of errors without breaking
   builds)

As a last configure step before generating the output files, print the complete
CFLAGS and CPPFLAGS by means of AC_MSG_RESULT.

Change-Id: I8cf0f135131c348d0b43f25b1d444af5827f148d
---
M configure.ac
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/08/7108/1

diff --git a/configure.ac b/configure.ac
index e95a16d..c74402a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -81,6 +81,24 @@
CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined"
 fi
 
+AC_ARG_ENABLE(werror,
+   [AS_HELP_STRING(
+   [--enable-werror],
+   [Turn all compiler warnings into errors, with exceptions:
+a) deprecation (allow upstream to mark deprecation without 
breaking builds);
+b) "#warning" pragmas (allow to remind ourselves of errors 
without breaking builds)
+   ]
+   )],
+   [werror=$enableval], [werror="no"])
+if test x"$werror" = x"yes"
+then
+   WERROR_FLAGS="-Werror"
+   WERROR_FLAGS+=" -Wno-error=deprecated 
-Wno-error=deprecated-declarations"
+   WERROR_FLAGS+=" -Wno-error=cpp" # "#warning"
+   CFLAGS="$CFLAGS $WERROR_FLAGS"
+   CPPFLAGS="$CPPFLAGS $WERROR_FLAGS"
+fi
+
 # The following test is taken from WebKit's webkit.m4
 saved_CFLAGS="$CFLAGS"
 CFLAGS="$CFLAGS -fvisibility=hidden "
@@ -140,6 +158,9 @@
 AC_MSG_RESULT([$enable_ext_tests])
 AM_CONDITIONAL(ENABLE_EXT_TESTS, test "x$enable_ext_tests" = "xyes")
 
+AC_MSG_RESULT([CFLAGS="$CFLAGS"])
+AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"])
+
 dnl Generate the output
 AM_CONFIG_HEADER(bscconfig.h)
 

-- 
To view, visit https://gerrit.osmocom.org/7108
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8cf0f135131c348d0b43f25b1d444af5827f148d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] libsmpp34[master]: configure: add --enable-werror

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7106

configure: add --enable-werror

Provide a sane means of adding the -Werror compiler flag.

Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"',
but that actually *overwrites* all the other CFLAGS we might want to have set.

Maintain these exceptions from -Werror:
a) deprecation (allow upstream to mark deprecation without breaking builds);
b) "#warning" pragmas (allow to remind ourselves of errors without breaking
   builds)

As a last configure step before generating the output files, print the complete
CFLAGS and CPPFLAGS by means of AC_MSG_RESULT.

Change-Id: I5280a692eaf8f626523e0fd929d1febaa2859104
---
M configure.ac
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libsmpp34 refs/changes/06/7106/1

diff --git a/configure.ac b/configure.ac
index 85270bc..8ecbb77 100644
--- a/configure.ac
+++ b/configure.ac
@@ -53,6 +53,27 @@
CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined"
 fi
 
+AC_ARG_ENABLE(werror,
+   [AS_HELP_STRING(
+   [--enable-werror],
+   [Turn all compiler warnings into errors, with exceptions:
+a) deprecation (allow upstream to mark deprecation without 
breaking builds);
+b) "#warning" pragmas (allow to remind ourselves of errors 
without breaking builds)
+   ]
+   )],
+   [werror=$enableval], [werror="no"])
+if test x"$werror" = x"yes"
+then
+   WERROR_FLAGS="-Werror"
+   WERROR_FLAGS+=" -Wno-error=deprecated 
-Wno-error=deprecated-declarations"
+   WERROR_FLAGS+=" -Wno-error=cpp" # "#warning"
+   CFLAGS="$CFLAGS $WERROR_FLAGS"
+   CPPFLAGS="$CPPFLAGS $WERROR_FLAGS"
+fi
+
+AC_MSG_RESULT([CFLAGS="$CFLAGS"])
+AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"])
+
 AC_OUTPUT([Makefile
def_frame/Makefile
def_list/Makefile

-- 
To view, visit https://gerrit.osmocom.org/7106
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5280a692eaf8f626523e0fd929d1febaa2859104
Gerrit-PatchSet: 1
Gerrit-Project: libsmpp34
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] libsmpp34[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7107

jenkins.sh: use --enable-werror configure flag, not CFLAGS

Change-Id: Ib09a4aa3167e5dc24d02e3e59307baa6f7ee3f2c
---
M contrib/jenkins.sh
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libsmpp34 refs/changes/07/7107/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 0768d71..8680cde 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -6,8 +6,8 @@
 osmo-clean-workspace.sh
 
 autoreconf --install --force
-./configure --enable-sanitize
-$MAKE CFLAGS="-Werror" CPPFLAGS="-Werror"
+./configure --enable-sanitize --enable-werror
+$MAKE
 $MAKE $PARALLEL_MAKE
 $MAKE distcheck || cat-testlogs.sh
 

-- 
To view, visit https://gerrit.osmocom.org/7107
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib09a4aa3167e5dc24d02e3e59307baa6f7ee3f2c
Gerrit-PatchSet: 1
Gerrit-Project: libsmpp34
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] libosmocore[master]: jenkins_amd64.sh: use --enable-werror configure flag, not CF...

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7105

jenkins_amd64.sh: use --enable-werror configure flag, not CFLAGS

Note that the jenkins_arm.sh passes various CFLAGS and potentially overwrites
./configure internal CFLAGS like that. I'm staying out of that for now.

Change-Id: I81b50c39cd6e908c4c95651829b679425de87a28
---
M contrib/jenkins_amd64.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/05/7105/1

diff --git a/contrib/jenkins_amd64.sh b/contrib/jenkins_amd64.sh
index ff1cfdc..c3af378 100755
--- a/contrib/jenkins_amd64.sh
+++ b/contrib/jenkins_amd64.sh
@@ -15,7 +15,7 @@
 
 prep_build "$src_dir" "$build_dir"
 
-"$src_dir"/configure  --disable-silent-rules --enable-static 
$ENABLE_SANITIZE CFLAGS="-Werror" CPPFLAGS="-Werror"
+"$src_dir"/configure  --disable-silent-rules --enable-static 
$ENABLE_SANITIZE --enable-werror
 
 run_make
 }

-- 
To view, visit https://gerrit.osmocom.org/7105
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I81b50c39cd6e908c4c95651829b679425de87a28
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] libosmocore[master]: configure: add --enable-werror

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7104

configure: add --enable-werror

Provide a sane means of adding the -Werror compiler flag.

Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"',
but that actually *overwrites* all the other CFLAGS we might want to have set.

Maintain these exceptions from -Werror:
a) deprecation (allow upstream to mark deprecation without breaking builds);
b) "#warning" pragmas (allow to remind ourselves of errors without breaking
   builds)

As a last configure step before generating the output files, print the complete
CFLAGS and CPPFLAGS by means of AC_MSG_RESULT.

Change-Id: Ic5c8e68b64cd890b3309b4b26c7f22bde1edba83
---
M configure.ac
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/04/7104/1

diff --git a/configure.ac b/configure.ac
index 60c177f..7f2aabd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -272,6 +272,24 @@
CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined"
 fi
 
+AC_ARG_ENABLE(werror,
+   [AS_HELP_STRING(
+   [--enable-werror],
+   [Turn all compiler warnings into errors, with exceptions:
+a) deprecation (allow upstream to mark deprecation without 
breaking builds);
+b) "#warning" pragmas (allow to remind ourselves of errors 
without breaking builds)
+   ]
+   )],
+   [werror=$enableval], [werror="no"])
+if test x"$werror" = x"yes"
+then
+   WERROR_FLAGS="-Werror"
+   WERROR_FLAGS+=" -Wno-error=deprecated 
-Wno-error=deprecated-declarations"
+   WERROR_FLAGS+=" -Wno-error=cpp" # "#warning"
+   CFLAGS="$CFLAGS $WERROR_FLAGS"
+   CPPFLAGS="$CPPFLAGS $WERROR_FLAGS"
+fi
+
 CFLAGS="$CFLAGS -DBUILDING_LIBOSMOCORE -Wall"
 CPPFLAGS="$CPPFLAGS -DBUILDING_LIBOSMOCORE -Wall"
 
@@ -318,6 +336,9 @@
 CHECK_BUILTIN_SUPPORT([__builtin_cpu_supports],
   [Runtime SIMD detection will be disabled])
 
+AC_MSG_RESULT([CFLAGS="$CFLAGS"])
+AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"])
+
 AC_OUTPUT(
libosmocore.pc
libosmocodec.pc

-- 
To view, visit https://gerrit.osmocom.org/7104
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic5c8e68b64cd890b3309b4b26c7f22bde1edba83
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] libosmo-sccp[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7103

jenkins.sh: use --enable-werror configure flag, not CFLAGS

Change-Id: I5c3f11586d48a076479eb19ed80a11caad4251d8
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/03/7103/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index ecaa1fe..d15cebe 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -36,7 +36,7 @@
 set -x
 
 autoreconf --install --force
-./configure --enable-sanitize CFLAGS="-Werror" CPPFLAGS="-Werror"
+./configure --enable-sanitize --enable-werror
 $MAKE $PARALLEL_MAKE
 $MAKE distcheck \
   || cat-testlogs.sh

-- 
To view, visit https://gerrit.osmocom.org/7103
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c3f11586d48a076479eb19ed80a11caad4251d8
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] libasn1c[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7097

jenkins.sh: use --enable-werror configure flag, not CFLAGS

Change-Id: I4791c6a32d983869692df36172f93adee819debb
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libasn1c refs/changes/97/7097/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 5f31710..7d68736 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -13,7 +13,7 @@
 set -x
 
 autoreconf --install --force
-./configure CFLAGS="-Werror" CPPFLAGS="-Werror"
+./configure --enable-werror
 $MAKE $PARALLEL_MAKE
 $MAKE distcheck \
   || cat-testlogs.sh

-- 
To view, visit https://gerrit.osmocom.org/7097
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4791c6a32d983869692df36172f93adee819debb
Gerrit-PatchSet: 1
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] libosmo-abis[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7099

jenkins.sh: use --enable-werror configure flag, not CFLAGS

Change-Id: I487ab6f2e391aa57404725de2c8ab5447ca9f725
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/99/7099/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 45e540e..6a76044 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -33,7 +33,7 @@
 set -x
 
 autoreconf --install --force
-./configure --enable-sanitize CFLAGS="-Werror" CPPFLAGS="-Werror"
+./configure --enable-sanitize --enable-werror
 $MAKE $PARALLEL_MAKE
 $MAKE distcheck \
   || cat-testlogs.sh

-- 
To view, visit https://gerrit.osmocom.org/7099
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I487ab6f2e391aa57404725de2c8ab5447ca9f725
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] libosmo-netif[master]: configure: add --enable-werror

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7100

configure: add --enable-werror

Provide a sane means of adding the -Werror compiler flag.

Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"',
but that actually *overwrites* all the other CFLAGS we might want to have set.

Maintain these exceptions from -Werror:
a) deprecation (allow upstream to mark deprecation without breaking builds);
b) "#warning" pragmas (allow to remind ourselves of errors without breaking
   builds)

As a last configure step before generating the output files, print the complete
CFLAGS and CPPFLAGS by means of AC_MSG_RESULT.

Change-Id: I68e4781ec5dfaf1dac46510a092a87e35691f082
---
M configure.ac
1 file changed, 18 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/00/7100/1

diff --git a/configure.ac b/configure.ac
index d146513..f01dac9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -43,6 +43,24 @@
CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined"
 fi
 
+AC_ARG_ENABLE(werror,
+   [AS_HELP_STRING(
+   [--enable-werror],
+   [Turn all compiler warnings into errors, with exceptions:
+a) deprecation (allow upstream to mark deprecation without 
breaking builds);
+b) "#warning" pragmas (allow to remind ourselves of errors 
without breaking builds)
+   ]
+   )],
+   [werror=$enableval], [werror="no"])
+if test x"$werror" = x"yes"
+then
+   WERROR_FLAGS="-Werror"
+   WERROR_FLAGS+=" -Wno-error=deprecated 
-Wno-error=deprecated-declarations"
+   WERROR_FLAGS+=" -Wno-error=cpp" # "#warning"
+   CFLAGS="$CFLAGS $WERROR_FLAGS"
+   CPPFLAGS="$CPPFLAGS $WERROR_FLAGS"
+fi
+
 CFLAGS="$CFLAGS -Wall"
 CPPFLAGS="$CPPFLAGS -Wall"
 

-- 
To view, visit https://gerrit.osmocom.org/7100
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I68e4781ec5dfaf1dac46510a092a87e35691f082
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] libasn1c[master]: configure: add --enable-werror

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7096

configure: add --enable-werror

Provide a sane means of adding the -Werror compiler flag.

Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"',
but that actually *overwrites* all the other CFLAGS we might want to have set.

Maintain these exceptions from -Werror:
a) deprecation (allow upstream to mark deprecation without breaking builds);
b) "#warning" pragmas (allow to remind ourselves of errors without breaking
   builds)

As a last configure step before generating the output files, print the complete
CFLAGS and CPPFLAGS by means of AC_MSG_RESULT.

Change-Id: Ibcc8238584a585434b39a046cd2d7e18ddaf7f8c
---
M configure.ac
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libasn1c refs/changes/96/7096/1

diff --git a/configure.ac b/configure.ac
index 4d65c2f..1610973 100644
--- a/configure.ac
+++ b/configure.ac
@@ -29,6 +29,24 @@
CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined"
 fi
 
+AC_ARG_ENABLE(werror,
+   [AS_HELP_STRING(
+   [--enable-werror],
+   [Turn all compiler warnings into errors, with exceptions:
+a) deprecation (allow upstream to mark deprecation without 
breaking builds);
+b) "#warning" pragmas (allow to remind ourselves of errors 
without breaking builds)
+   ]
+   )],
+   [werror=$enableval], [werror="no"])
+if test x"$werror" = x"yes"
+then
+   WERROR_FLAGS="-Werror"
+   WERROR_FLAGS+=" -Wno-error=deprecated 
-Wno-error=deprecated-declarations"
+   WERROR_FLAGS+=" -Wno-error=cpp" # "#warning"
+   CFLAGS="$CFLAGS $WERROR_FLAGS"
+   CPPFLAGS="$CPPFLAGS $WERROR_FLAGS"
+fi
+
 # The following test is taken from WebKit's webkit.m4
 saved_CFLAGS="$CFLAGS"
 CFLAGS="$CFLAGS -fvisibility=hidden "
@@ -44,6 +62,9 @@
[build_debug="$enableval"], [build_debug="no"])
 AM_CONDITIONAL(BUILD_DEBUG, test "x$build_debug" = "xyes")
 
+AC_MSG_RESULT([CFLAGS="$CFLAGS"])
+AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"])
+
 AC_OUTPUT(
 libasn1c.pc
 src/Makefile

-- 
To view, visit https://gerrit.osmocom.org/7096
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibcc8238584a585434b39a046cd2d7e18ddaf7f8c
Gerrit-PatchSet: 1
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] libosmo-abis[master]: configure: add --enable-werror

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7098

configure: add --enable-werror

Provide a sane means of adding the -Werror compiler flag.

Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"',
but that actually *overwrites* all the other CFLAGS we might want to have set.

Maintain these exceptions from -Werror:
a) deprecation (allow upstream to mark deprecation without breaking builds);
b) "#warning" pragmas (allow to remind ourselves of errors without breaking
   builds)

As a last configure step before generating the output files, print the complete
CFLAGS and CPPFLAGS by means of AC_MSG_RESULT.

Change-Id: I20d5f18cf05c9e277d914ada259a95187b73fe39
---
M configure.ac
1 file changed, 20 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/98/7098/1

diff --git a/configure.ac b/configure.ac
index 0e07330..ce4bf39 100644
--- a/configure.ac
+++ b/configure.ac
@@ -78,6 +78,24 @@
CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined"
 fi
 
+AC_ARG_ENABLE(werror,
+   [AS_HELP_STRING(
+   [--enable-werror],
+   [Turn all compiler warnings into errors, with exceptions:
+a) deprecation (allow upstream to mark deprecation without 
breaking builds);
+b) "#warning" pragmas (allow to remind ourselves of errors 
without breaking builds)
+   ]
+   )],
+   [werror=$enableval], [werror="no"])
+if test x"$werror" = x"yes"
+then
+   WERROR_FLAGS="-Werror"
+   WERROR_FLAGS+=" -Wno-error=deprecated 
-Wno-error=deprecated-declarations"
+   WERROR_FLAGS+=" -Wno-error=cpp" # "#warning"
+   CFLAGS="$CFLAGS $WERROR_FLAGS"
+   CPPFLAGS="$CPPFLAGS $WERROR_FLAGS"
+fi
+
 _cflags_save=$CFLAGS
 CFLAGS="$CFLAGS $ORTP_CFLAGS"
 AC_COMPILE_IFELSE(
@@ -105,6 +123,8 @@
[rtp_session_signal_connect requires ulong parameter])])
 CFLAGS=$_cflags_save
 
+AC_MSG_RESULT([CFLAGS="$CFLAGS"])
+AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"])
 
 AC_OUTPUT(
libosmoabis.pc

-- 
To view, visit https://gerrit.osmocom.org/7098
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I20d5f18cf05c9e277d914ada259a95187b73fe39
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] libosmo-netif[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7101

jenkins.sh: use --enable-werror configure flag, not CFLAGS

Change-Id: I739f4562a96b7b6031075d47d94f46af7a37b4b4
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/01/7101/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index c289d2d..f2013a5 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -35,7 +35,7 @@
 set -x
 
 autoreconf --install --force
-./configure --enable-sanitize CFLAGS="-Werror" CPPFLAGS="-Werror"
+./configure --enable-sanitize --enable-werror
 $MAKE $PARALLEL_MAKE
 $MAKE distcheck \
   || cat-testlogs.sh

-- 
To view, visit https://gerrit.osmocom.org/7101
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I739f4562a96b7b6031075d47d94f46af7a37b4b4
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] libosmo-sccp[master]: configure: add --enable-werror

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/7102

configure: add --enable-werror

Provide a sane means of adding the -Werror compiler flag.

Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"',
but that actually *overwrites* all the other CFLAGS we might want to have set.

Maintain these exceptions from -Werror:
a) deprecation (allow upstream to mark deprecation without breaking builds);
b) "#warning" pragmas (allow to remind ourselves of errors without breaking
   builds)

As a last configure step before generating the output files, print the complete
CFLAGS and CPPFLAGS by means of AC_MSG_RESULT.

Change-Id: Idb579d546d6f228e86bd49ca15aa87b86978205a
---
M configure.ac
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/02/7102/1

diff --git a/configure.ac b/configure.ac
index 7b18db7..a73bc82 100644
--- a/configure.ac
+++ b/configure.ac
@@ -57,6 +57,24 @@
CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined"
 fi
 
+AC_ARG_ENABLE(werror,
+   [AS_HELP_STRING(
+   [--enable-werror],
+   [Turn all compiler warnings into errors, with exceptions:
+a) deprecation (allow upstream to mark deprecation without 
breaking builds);
+b) "#warning" pragmas (allow to remind ourselves of errors 
without breaking builds)
+   ]
+   )],
+   [werror=$enableval], [werror="no"])
+if test x"$werror" = x"yes"
+then
+   WERROR_FLAGS="-Werror"
+   WERROR_FLAGS+=" -Wno-error=deprecated 
-Wno-error=deprecated-declarations"
+   WERROR_FLAGS+=" -Wno-error=cpp" # "#warning"
+   CFLAGS="$CFLAGS $WERROR_FLAGS"
+   CPPFLAGS="$CPPFLAGS $WERROR_FLAGS"
+fi
+
 # The following test is taken from WebKit's webkit.m4
 saved_CFLAGS="$CFLAGS"
 CFLAGS="$CFLAGS -fvisibility=hidden "
@@ -80,6 +98,9 @@
 AC_PATH_PROG(DOXYGEN,doxygen,false)
 AM_CONDITIONAL(HAVE_DOXYGEN, test $DOXYGEN != false && test "x$doxygen" = 
"xyes")
 
+AC_MSG_RESULT([CFLAGS="$CFLAGS"])
+AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"])
+
 AC_OUTPUT(
 libosmo-sigtran.pc
 libosmo-sccp.pc

-- 
To view, visit https://gerrit.osmocom.org/7102
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb579d546d6f228e86bd49ca15aa87b86978205a
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] osmo-trx[master]: doc: Add sample cfg file for LimeSDR

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/7095

doc: Add sample cfg file for LimeSDR

Change-Id: I16de70eac0fd79107b8317af37201e6da834c169
---
A doc/examples/osmo-trx-limesdr.cfg
1 file changed, 20 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/95/7095/1

diff --git a/doc/examples/osmo-trx-limesdr.cfg 
b/doc/examples/osmo-trx-limesdr.cfg
new file mode 100644
index 000..c7e6b23
--- /dev/null
+++ b/doc/examples/osmo-trx-limesdr.cfg
@@ -0,0 +1,20 @@
+log stderr
+  logging filter all 1
+  logging color 1
+  logging print category 1
+  logging timestamp 1
+  logging level all info
+!
+line vty
+ no login
+!
+trx
+ bind-ip 127.0.0.1
+ remote-ip 127.0.0.1
+ base-port 5700
+ egprs disable
+ tx-sps 4
+ rx-sps 4
+ chan 0
+  tx-path BAND1
+  rx-path LNAW

-- 
To view, visit https://gerrit.osmocom.org/7095
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I16de70eac0fd79107b8317af37201e6da834c169
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 

[PATCH] osmo-trx[master]: osmo-trx: Use VTY cfg structures while still allowing cmd li...

[Pau Espin Pedrol]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/6651

to look at the new patch set (#6).

osmo-trx: Use VTY cfg structures while still allowing cmd line options

Existing cmd line options are kept for a while to give people some time
to move to use VTY cfg. All new cfg options should be set only through
VTY. VTY options take preference (override) over cmd line options.
Deprecated options are removed from help message to dissuade users from
keep using them.

Steps to drop cmd line options in the future:
- Drop comma_delimited_to_vector, print_deprecated
- Drop all options in handle_options marked with print_deprecated.
- Set "-c" param to do the same as "-C", to keep compatibility with old
param and still use same naming as all other osmocom projects.
- Remove the hack in main() to set 1 channel implicitly by default.

Change-Id: Ib8de1a5da4b3c0b6a49e00033f616e1d66656adf
---
M Transceiver52M/osmo-trx.cpp
1 file changed, 187 insertions(+), 269 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/51/6651/6

diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp
index 7bc025f..f975500 100644
--- a/Transceiver52M/osmo-trx.cpp
+++ b/Transceiver52M/osmo-trx.cpp
@@ -55,52 +55,11 @@
 #include "debug.h"
 }
 
-/* Samples-per-symbol for downlink path
- * 4 - Uses precision modulator (more computation, less distortion)
- * 1 - Uses minimized modulator (less computation, more distortion)
- *
- * Other values are invalid. Receive path (uplink) is always
- * downsampled to 1 sps. Default to 4 sps for all cases.
- */
-#define DEFAULT_TX_SPS 4
-
-/*
- * Samples-per-symbol for uplink (receiver) path
- * Do not modify this value. EDGE configures 4 sps automatically on
- * B200/B210 devices only. Use of 4 sps on the receive path for other
- * configurations is not supported.
- */
-#define DEFAULT_RX_SPS 1
-
-/* Default configuration parameters */
-#define DEFAULT_TRX_PORT   5700
-#define DEFAULT_TRX_IP "127.0.0.1"
-#define DEFAULT_CHANS  1
 #define DEFAULT_CONFIG_FILE"osmo-trx.cfg"
 
-struct trx_config {
-   std::string local_addr;
-   std::string remote_addr;
-   std::string dev_args;
-   char* config_file;
-   unsigned port;
-   unsigned tx_sps;
-   unsigned rx_sps;
-   unsigned chans;
-   unsigned rtsc;
-   unsigned rach_delay;
-   bool extref;
-   bool gpsref;
-   FillerType filler;
-   bool mcbts;
-   double offset;
-   double rssi_offset;
-   bool swap_channels;
-   bool edge;
-   int sched_rr;
-   std::vector rx_paths;
-   std::vector tx_paths;
-};
+#define charp2str(a) ((a) ? std::string(a) : std::string(""))
+
+static char* config_file = (char*)DEFAULT_CONFIG_FILE;
 
 volatile bool gshutdown = false;
 
@@ -112,80 +71,6 @@
 static RadioInterface *radio;
 static Transceiver *transceiver;
 
-/* Setup configuration values
- * Don't query the existence of the Log.Level because it's a
- * mandatory value. That is, if it doesn't exist, the configuration
- * table will crash or will have already crashed. Everything else we
- * can survive without and use default values if the database entries
- * are empty.
- */
-bool trx_setup_config(struct trx_config *config)
-{
-   std::string refstr, fillstr, divstr, mcstr, edgestr;
-   std::vector::const_iterator si;
-
-   if (config->mcbts && config->chans > 5) {
-   std::cout << "Unsupported number of channels" << std::endl;
-   return false;
-   }
-
-   edgestr = config->edge ? "Enabled" : "Disabled";
-   mcstr = config->mcbts ? "Enabled" : "Disabled";
-
-   if (config->extref)
-   refstr = "External";
-   else if (config->gpsref)
-   refstr = "GPS";
-   else
-   refstr = "Internal";
-
-   switch (config->filler) {
-   case FILLER_DUMMY:
-   fillstr = "Dummy bursts";
-   break;
-   case FILLER_ZERO:
-   fillstr = "Disabled";
-   break;
-   case FILLER_NORM_RAND:
-   fillstr = "Normal busrts with random payload";
-   break;
-   case FILLER_EDGE_RAND:
-   fillstr = "EDGE busrts with random payload";
-   break;
-   case FILLER_ACCESS_RAND:
-   fillstr = "Access busrts with random payload";
-   break;
-   }
-
-   std::ostringstream ost("");
-   ost << "Config Settings" << std::endl;
-   ost << "   Device args. " << config->dev_args << std::endl;
-   ost << "   TRX Base Port... " << config->port << std::endl;
-   ost << "   TRX Address. " << config->local_addr << 
std::endl;
-   ost << "   GSM Core Address." << config->remote_addr << 
std::endl;
-   ost << "   Channels " << config->chans << 

[PATCH] osmo-trx[master]: vty: Implement VTY cfg parsing for current parameters

[Pau Espin Pedrol]

Hello Vadim Yanitskiy, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/6650

to look at the new patch set (#6).

vty: Implement VTY cfg parsing for current parameters

At this stage, osmo-trx still uses the cmdline parameters top run the
device, but it is already able to parse all the same parameters from a
cfg file through the VTY and filling a trx_ctx structure which will be
later used to drive the device. Device config can be printed in the VTY
with "show trx".

Change-Id: Ie084c1b30b63f91c6e7640832ec1797d9e813832
---
M CommonLibs/trx_vty.c
M CommonLibs/trx_vty.h
M Transceiver52M/osmo-trx.cpp
3 files changed, 469 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/50/6650/6

diff --git a/CommonLibs/trx_vty.c b/CommonLibs/trx_vty.c
index b16cd24..843d19f 100644
--- a/CommonLibs/trx_vty.c
+++ b/CommonLibs/trx_vty.c
@@ -36,6 +36,22 @@
 
 static struct trx_ctx* g_trx_ctx;
 
+static const struct value_string clock_ref_names[] = {
+   { REF_INTERNAL, "internal" },
+   { REF_EXTERNAL, "external" },
+   { REF_GPS,  "gspdo" },
+   { 0,NULL }
+};
+
+static const struct value_string filler_names[] = {
+   { FILLER_DUMMY, "Dummy bursts" },
+   { FILLER_ZERO,  "Disabled" },
+   { FILLER_NORM_RAND, "Normal bursts with random payload" },
+   { FILLER_EDGE_RAND, "EDGE bursts with random payload" },
+   { FILLER_ACCESS_RAND,   "Access bursts with random payload" },
+   { 0,NULL }
+};
+
 struct trx_ctx *trx_from_vty(struct vty *v)
 {
 /* It can't hurt to force callers to continue to pass the vty instance
@@ -50,11 +66,18 @@
 
 enum trx_vty_node {
TRX_NODE = _LAST_OSMOVTY_NODE + 1,
+   CHAN_NODE,
 };
 
 static struct cmd_node trx_node = {
TRX_NODE,
"%s(config-trx)# ",
+   1,
+};
+
+static struct cmd_node chan_node = {
+   CHAN_NODE,
+   "%s(config-trx-chan)# ",
1,
 };
 
@@ -84,15 +107,364 @@
return CMD_SUCCESS;
 }
 
+DEFUN(cfg_remote_ip, cfg_remote_ip_cmd,
+   "remote-ip A.B.C.D",
+   "Set the IP address for the remote BTS\n"
+   "IPv4 Address\n")
+{
+   struct trx_ctx *trx = trx_from_vty(vty);
+
+   osmo_talloc_replace_string(trx, >cfg.remote_addr, argv[0]);
+
+   return CMD_SUCCESS;
+}
+
+DEFUN(cfg_base_port, cfg_base_port_cmd,
+   "base-port <1-65535>",
+   "Set the TRX Base Port\n"
+   "TRX Base Port\n")
+{
+   struct trx_ctx *trx = trx_from_vty(vty);
+
+   trx->cfg.base_port = atoi(argv[0]);
+
+   return CMD_SUCCESS;
+}
+
+DEFUN(cfg_dev_args, cfg_dev_args_cmd,
+   "dev-args DESC",
+   "Set the device-specific arguments to pass to the device\n"
+   "Device-specific arguments\n")
+{
+   struct trx_ctx *trx = trx_from_vty(vty);
+
+   osmo_talloc_replace_string(trx, >cfg.dev_args, argv[0]);
+
+   return CMD_SUCCESS;
+}
+
+DEFUN(cfg_tx_sps, cfg_tx_sps_cmd,
+   "tx-sps (1|4)",
+   "Set the Tx Samples-per-Symbol\n"
+   "Tx Samples-per-Symbol\n")
+{
+   struct trx_ctx *trx = trx_from_vty(vty);
+
+   trx->cfg.tx_sps = atoi(argv[0]);
+
+   return CMD_SUCCESS;
+}
+
+DEFUN(cfg_rx_sps, cfg_rx_sps_cmd,
+   "rx-sps (1|4)",
+   "Set the Rx Samples-per-Symbol\n"
+   "Rx Samples-per-Symbol\n")
+{
+   struct trx_ctx *trx = trx_from_vty(vty);
+
+   trx->cfg.rx_sps = atoi(argv[0]);
+
+   return CMD_SUCCESS;
+}
+
+DEFUN(cfg_test_rtsc, cfg_test_rtsc_cmd,
+   "test rtsc <0-7>",
+   "Set the Random Normal Burst test mode with TSC\n"
+   "TSC\n")
+{
+   struct trx_ctx *trx = trx_from_vty(vty);
+
+   if (trx->cfg.rach_delay_set) {
+   vty_out(vty, "rach-delay and rtsc options are 
mutual-exclusive%s",
+   VTY_NEWLINE);
+   return CMD_WARNING;
+   }
+
+   trx->cfg.rtsc_set = true;
+   trx->cfg.rtsc = atoi(argv[0]);
+   if (!trx->cfg.egprs) /* Don't override egprs which sets different 
filler */
+   trx->cfg.filler = FILLER_NORM_RAND;
+
+   return CMD_SUCCESS;
+}
+
+DEFUN(cfg_test_rach_delay, cfg_test_rach_delay_cmd,
+   "test rach-delay <0-68>",
+   "Set the Random Access Burst test mode with delay\n"
+   "RACH delay\n")
+{
+   struct trx_ctx *trx = trx_from_vty(vty);
+
+   if (trx->cfg.rtsc_set) {
+   vty_out(vty, "rach-delay and rtsc options are 
mutual-exclusive%s",
+   VTY_NEWLINE);
+   return CMD_WARNING;
+   }
+
+   if (trx->cfg.egprs) {
+   vty_out(vty, "rach-delay and egprs options are 
mutual-exclusive%s",
+   VTY_NEWLINE);
+   return CMD_WARNING;
+   }
+
+   trx->cfg.rach_delay_set = true;
+   trx->cfg.rach_delay = atoi(argv[0]);
+   trx->cfg.filler = FILLER_ACCESS_RAND;
+
+   return CMD_SUCCESS;
+}
+
+DEFUN(cfg_clock_ref, 

[PATCH] osmo-trx[master]: osmo-trx.cpp: Move trx start and stop to helper functions

[Pau Espin Pedrol]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/6648

to look at the new patch set (#6).

osmo-trx.cpp: Move trx start and stop to helper functions

Make main() smaller, and make it easier to replace cmdline parameters in
following commits.

Change-Id: I10eaaafe38ace2b7bb095a0ad1db70d6c06ee03b
---
M Transceiver52M/osmo-trx.cpp
1 file changed, 66 insertions(+), 52 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/48/6648/6

diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp
index 5f4e286..db0a813 100644
--- a/Transceiver52M/osmo-trx.cpp
+++ b/Transceiver52M/osmo-trx.cpp
@@ -108,6 +108,10 @@
 static struct trx_ctx *g_trx_ctx;
 static struct ctrl_handle *g_ctrlh;
 
+static RadioDevice *usrp;
+static RadioInterface *radio;
+static Transceiver *transceiver;
+
 /* Setup configuration values
  * Don't query the existence of the Log.Level because it's a
  * mandatory value. That is, if it doesn't exist, the configuration
@@ -227,33 +231,30 @@
  * and decoding schemes. Also included are the socket interfaces for
  * connecting to the upper layer stack.
  */
-Transceiver *makeTransceiver(struct trx_config *config, RadioInterface *radio)
+int makeTransceiver(struct trx_config *config, RadioInterface *radio)
 {
-   Transceiver *trx;
VectorFIFO *fifo;
 
-   trx = new Transceiver(config->port, config->local_addr.c_str(),
+   transceiver = new Transceiver(config->port, config->local_addr.c_str(),
  config->remote_addr.c_str(), config->tx_sps,
  config->rx_sps, config->chans, GSM::Time(3,0),
  radio, config->rssi_offset);
-   if (!trx->init(config->filler, config->rtsc,
+   if (!transceiver->init(config->filler, config->rtsc,
   config->rach_delay, config->edge)) {
LOG(ALERT) << "Failed to initialize transceiver";
-   delete trx;
-   return NULL;
+   return -1;
}
 
for (size_t i = 0; i < config->chans; i++) {
fifo = radio->receiveFIFO(i);
-   if (fifo && trx->receiveFIFO(fifo, i))
+   if (fifo && transceiver->receiveFIFO(fifo, i))
continue;
 
LOG(ALERT) << "Could not attach FIFO to channel " << i;
-   delete trx;
-   return NULL;
+   return -1;
}
 
-   return trx;
+   return 0;
 }
 
 static void sig_handler(int signo)
@@ -501,13 +502,61 @@
return 0;
 }
 
-int main(int argc, char *argv[])
+static void trx_stop()
+{
+   std::cout << "Shutting down transceiver..." << std::endl;
+
+   delete transceiver;
+   delete radio;
+   delete usrp;
+}
+
+static int trx_start(struct trx_config *config)
 {
int type, chans, ref;
-   RadioDevice *usrp;
-   RadioInterface *radio = NULL;
-   Transceiver *trx = NULL;
RadioDevice::InterfaceType iface = RadioDevice::NORMAL;
+
+   /* Create the low level device object */
+   if (config->mcbts)
+   iface = RadioDevice::MULTI_ARFCN;
+
+   if (config->extref)
+   ref = RadioDevice::REF_EXTERNAL;
+   else if (config->gpsref)
+   ref = RadioDevice::REF_GPS;
+   else
+   ref = RadioDevice::REF_INTERNAL;
+
+   usrp = RadioDevice::make(config->tx_sps, config->rx_sps, iface,
+config->chans, config->offset, 
config->tx_paths, config->rx_paths);
+   type = usrp->open(config->dev_args, ref, config->swap_channels);
+   if (type < 0) {
+   LOG(ALERT) << "Failed to create radio device" << std::endl;
+   goto shutdown;
+   }
+
+   /* Setup the appropriate device interface */
+   radio = makeRadioInterface(config, usrp, type);
+   if (!radio)
+   goto shutdown;
+
+   /* Create the transceiver core */
+   if(makeTransceiver(config, radio) < 0)
+   goto shutdown;
+
+   chans = transceiver->numChans();
+   std::cout << "-- Transceiver active with "
+ << chans << " channel(s)" << std::endl;
+
+   return 0;
+
+shutdown:
+   trx_stop();
+   return -1;
+}
+
+int main(int argc, char *argv[])
+{
struct trx_config config;
int rc;
 
@@ -589,48 +638,13 @@
 
srandom(time(NULL));
 
-   /* Create the low level device object */
-   if (config.mcbts)
-   iface = RadioDevice::MULTI_ARFCN;
-
-   if (config.extref)
-   ref = RadioDevice::REF_EXTERNAL;
-   else if (config.gpsref)
-   ref = RadioDevice::REF_GPS;
-   else
-   ref = RadioDevice::REF_INTERNAL;
-
-   usrp = RadioDevice::make(config.tx_sps, config.rx_sps, iface,
-config.chans, config.offset, config.tx_paths, 

[MERGED] osmo-trx[rel-0.3.0]: jenkins.sh: fix the download url if the qemu image wasn't setup

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged.

Change subject: jenkins.sh: fix the download url if the qemu image wasn't setup
..


jenkins.sh: fix the download url if the qemu image wasn't setup

Download the image from yesterday because linuxcontainers only contains the 
images of the last 3 days.

Change-Id: I75e270b7255c1cd7fca1674111b0f19fc7bba74f
(cherry picked from commit 28b8cc6283487bceace86fc9d7ee77bc9ba6123f)
---
M contrib/jenkins.sh
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 11def5c..35a9627 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -36,7 +36,8 @@
 sed -i "s/setup_proc//g" 
"$ROOTFS/debootstrap/suite-script"
 mychroot /debootstrap/debootstrap 
--second-stage --verbose http://ftp.de.debian.org/debian/
 else
-wget -nc -q 
"https://uk.images.linuxcontainers.org/images/debian/stretch/armhf/default/20180114_22:42/rootfs.tar.xz;
+YESTERDAY=$(python -c 'import datetime ; 
print((datetime.datetime.now() - 
datetime.timedelta(days=1)).strftime("%Y%m%d"))')
+wget -nc -q 
"https://uk.images.linuxcontainers.org/images/debian/stretch/armhf/default/${YESTERDAY}_22:42/rootfs.tar.xz;
 tar -xf rootfs.tar.xz -C "$ROOTFS/" || true
 echo "nameserver 8.8.8.8" > 
"$ROOTFS/etc/resolv.conf"
 fi

-- 
To view, visit https://gerrit.osmocom.org/7092
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I75e270b7255c1cd7fca1674111b0f19fc7bba74f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: rel-0.3.0
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 

[MERGED] osmo-trx[rel-0.3.0]: Fix USRP1 build with support for setting Rx/TxAntenna

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged.

Change subject: Fix USRP1 build with support for setting Rx/TxAntenna
..


Fix USRP1 build with support for setting Rx/TxAntenna

The USRP1 build was broken by commit 77ce99ac6720896f504a0581a5c57b2929a13cef.

Commit 77ce99ac6720896f504a0581a5c57b2929a13cef broke the USRP1 build

Change-Id: I28585947d5662cdd580a814cce54a5d9aa30eeb8
(cherry picked from commit 3f52f0e6c5d384f25ff8583648e5e4a4dc957530)
---
M Transceiver52M/USRPDevice.h
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/Transceiver52M/USRPDevice.h b/Transceiver52M/USRPDevice.h
index f5fbe85..f981643 100644
--- a/Transceiver52M/USRPDevice.h
+++ b/Transceiver52M/USRPDevice.h
@@ -198,6 +198,7 @@
   inline double numberRead() { return samplesRead; }
   inline double numberWritten() { return samplesWritten; }
 
+  std::vector tx_paths, rx_paths;
 };
 
 #endif // _USRP_DEVICE_H_

-- 
To view, visit https://gerrit.osmocom.org/7091
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I28585947d5662cdd580a814cce54a5d9aa30eeb8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: rel-0.3.0
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 

[MERGED] osmo-trx[rel-0.3.0]: Bump version: 0.2.0 → 0.3.0

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged.

Change subject: Bump version: 0.2.0 → 0.3.0
..


Bump version: 0.2.0 → 0.3.0

Change-Id: I4dad76ed95dc585acfbd52d7eed4f2e6f9f5fd1f
---
M debian/changelog
1 file changed, 68 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/debian/changelog b/debian/changelog
index ec65036..20bbfa0 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,71 @@
+osmo-trx (0.3.0) unstable; urgency=medium
+
+  [ Neels Hofmeyr ]
+  * jenkins: use osmo-clean-workspace.sh before and after build
+
+  [ Harald Welte ]
+  * SocketsTest: Fix printing of non-nul-terminated string
+
+  [ Piotr Krysik ]
+  * UHDDevice.cpp: add USRP B205mini support
+
+  [ Max ]
+  * Mark release target as virtual
+  * Remove outdated references to OpenBTS
+  * Remove unused headers
+  * Update installation instructions
+  * Update legal disclaimer
+  * Update license notes
+  * tests: null-terminate buffer
+
+  [ Pau Espin Pedrol ]
+  * cosmetic: Remove trailing whitespace
+  * Logger: Stop using Log.Alarms.Max from config
+  * Logger: Stop using Log.File and Log.Level from config
+  * Drop use of ConfigurationTable gConfig
+  * Remove Configuration module and libsqlite dependency
+  * cosmetic: AUTHORS: fix trailing whitespace
+  * Set up GNU Autotest infrastructure
+  * tests: InterThread: adapt to have reproducible output and enable autotest
+  * tests: Timeval: adapt to have reproducible output and enable autotest
+  * tests: Log: adapt to have reproducible output and enable autotest
+  * Sockets.cpp: Fix initialization of UDD socket
+  * tests: Sockets: adapt to have reproducible output and enable autotest
+  * utils/convolvtest: Remove uneeded libosmocore dependency
+  * Move ARCH_LA to Makefile.common
+  * tests: Migrate convtest util to autotest infrastructure
+  * arm/convert.c: Fix compilation error
+  * arm/convert.c: Add missing convert_init implementation
+  * .gitignore: Add missing test related files
+  * Remove UDDSocket class
+  * tests: SocketTests: Pick OS-assigned instead of setting one manually
+  * tests: SocketsTest: Avoid hang forever if test fails
+  * tests: SocketsTest: Fail test on write fail
+  * tests: TimevalTest: refactor and avoid double comparison
+  * contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests with ARM 
instruction set
+  * tests: convolve: Disable due to difference in output in different archs
+  * Remove unneeded libdl dependency
+  * Fix whitespace
+  * Add support to set Rx/TxAntenna
+  * UHDDevice: Initialize async_event_thrd in constructor
+  * Logger: Drop unused gLogEarly
+  * Logger: Remove unused logging macros
+  * Logger: get rid of alarm APIs
+  * Logger: Drop syslog support
+  * Logger: Drop support to log into file
+  * Logger: Remove unused includes
+  * Logger: Remove gLogToConsole flag
+  * configure.ac: Check for pkg-config
+
+  [ Alexander Huemer ]
+  * Unbreak `./configure --with-usrp1` build
+  * Fix USRP1 build with support for setting Rx/TxAntenna
+
+  [ Alexander Couzens ]
+  * jenkins.sh: fix the download url if the qemu image wasn't setup
+
+ -- Pau Espin Pedrol   Mon, 05 Mar 2018 16:49:42 +0100
+
 osmo-trx (0.2.0) unstable; urgency=medium
 
   [ Alexander Chemeris ]

-- 
To view, visit https://gerrit.osmocom.org/7093
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4dad76ed95dc585acfbd52d7eed4f2e6f9f5fd1f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: rel-0.3.0
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 

osmo-gsm-tester[master]: ms: Add a main function to start all of it

[Pau Espin Pedrol]

Patch Set 5:

Holger you need to rebase all your patches on top of latest osmo-gsm-tester 
master to have jenkins verifying correctly the patches.

-- 
To view, visit https://gerrit.osmocom.org/6919
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58c938500a067eebb213750e56d8bf4d8af43df2
Gerrit-PatchSet: 5
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: neels 
Gerrit-HasComments: No

libosmocore[master]: features: define osmo_bts_*_feature() as static inline

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7084
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddd97415a17b06b69f69ddca2e2e296eb2f23a89
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

[MERGED] osmo-ci[master]: osmo-clean-workspace: fix force checkout of a subdirectory

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: osmo-clean-workspace: fix force checkout of a subdirectory
..


osmo-clean-workspace: fix force checkout of a subdirectory

Instead of the subdirectory, the main repository was
forced checked out.

Change-Id: If23e89872edf48dc5b751b3c069faf585bd6a3ef
---
M scripts/osmo-clean-workspace.sh
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Harald Welte: Looks good to me, approved; Verified



diff --git a/scripts/osmo-clean-workspace.sh b/scripts/osmo-clean-workspace.sh
index 11a5b72..4b77066 100755
--- a/scripts/osmo-clean-workspace.sh
+++ b/scripts/osmo-clean-workspace.sh
@@ -31,12 +31,12 @@
 # but clean each git of build artifacts.
 if [ -d "$deps" ]; then
   for dep_dir in "$deps"/* ; do
-git checkout -f HEAD
+git -C "$dep_dir" checkout -f HEAD
 git -C "$dep_dir" clean -dxf
   done
 fi
 
 if [ -d "layer1-headers" ]; then
-  git checkout -f HEAD
+  git -C "layer1-headers" checkout -f HEAD
   git -C "layer1-headers" clean -dxf
 fi

-- 
To view, visit https://gerrit.osmocom.org/6964
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If23e89872edf48dc5b751b3c069faf585bd6a3ef
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 

[MERGED] osmo-bts[master]: l1_tch: remove dead code

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: l1_tch: remove dead code
..


l1_tch: remove dead code

the file l1_tch.c in the octphy spcific code has its root in the
tch.c file of sysmobts. It contains some sysmobts specific ifdefs
which enclose dead code.

- Remove the sysmobts specif ifdefs and the dead code

Change-Id: I33f3e0fd293ca8387fddf5ed20f642621e9680de
---
M src/osmo-bts-octphy/l1_tch.c
1 file changed, 0 insertions(+), 64 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-octphy/l1_tch.c b/src/osmo-bts-octphy/l1_tch.c
index eee24aa..df0469d 100644
--- a/src/osmo-bts-octphy/l1_tch.c
+++ b/src/osmo-bts-octphy/l1_tch.c
@@ -47,11 +47,6 @@
if (!msg)
return NULL;
 
-#ifdef USE_L1_RTP_MODE
-   /* new L1 can deliver bits like we need them */
-   cur = msgb_put(msg, GSM_FR_BYTES);
-   memcpy(cur, l1_payload, GSM_FR_BYTES);
-#else
/* step1: reverse the bit-order of each payload byte */
osmo_revbytebits_buf(l1_payload, payload_len);
 
@@ -61,7 +56,6 @@
osmo_nibble_shift_right(cur, l1_payload, GSM_FR_BITS / 4);
 
cur[0] |= 0xD0;
-#endif /* USE_L1_RTP_MODE */
 
return msg;
 }
@@ -75,56 +69,12 @@
 int rtppayload_to_l1_fr(uint8_t *l1_payload, const uint8_t *rtp_payload,
unsigned int payload_len)
 {
-#ifdef USE_L1_RTP_MODE
-   /* new L1 can deliver bits like we need them */
-   memcpy(l1_payload, rtp_payload, GSM_FR_BYTES);
-#else
/* step2: we need to shift the RTP payload left by one nibble */
osmo_nibble_shift_left_unal(l1_payload, rtp_payload, GSM_FR_BITS / 4);
 
/* step1: reverse the bit-order of each payload byte */
osmo_revbytebits_buf(l1_payload, payload_len);
-#endif /* USE_L1_RTP_MODE */
return GSM_FR_BYTES;
-}
-
-static struct msgb *l1_to_rtppayload_efr(uint8_t *l1_payload, uint8_t 
payload_len)
-{
-   struct msgb *msg;
-   uint8_t *cur;
-
-   msg = msgb_alloc_headroom(1024, 128, "L1P-to-RTP");
-   if (!msg)
-   return NULL;
-
-#ifdef USE_L1_RTP_MODE
-   /* new L1 can deliver bits like we need them */
-   cur = msgb_put(msg, GSM_EFR_BYTES);
-   memcpy(cur, l1_payload, GSM_EFR_BYTES);
-#else
-   /* step1: reverse the bit-order of each payload byte */
-   osmo_revbytebits_buf(l1_payload, payload_len);
-
-   cur = msgb_put(msg, GSM_EFR_BYTES);
-
-   /* step 2: we need to shift the entire L1 payload by 4 bits right */
-   osmo_nibble_shift_right(cur, l1_payload, GSM_EFR_BITS/4);
-
-   cur[0] |= 0xC0;
-#endif /* USE_L1_RTP_MODE */
-   return msg;
-}
-
-static int rtppayload_to_l1_efr(uint8_t *l1_payload, const uint8_t 
*rtp_payload,
-   unsigned int payload_len)
-{
-#ifndef USE_L1_RTP_MODE
-#warning "We don't support EFR with L1 that doesn't support RTP mode!"
-#else
-   memcpy(l1_payload, rtp_payload, payload_len);
-
-#endif
-   return payload_len;
 }
 
 static struct msgb *l1_to_rtppayload_hr(uint8_t *l1_payload, uint8_t 
payload_len)
@@ -145,10 +95,8 @@
cur = msgb_put(msg, GSM_HR_BYTES);
memcpy(cur, l1_payload, GSM_HR_BYTES);
 
-#ifndef USE_L1_RTP_MODE
/* reverse the bit-order of each payload byte */
osmo_revbytebits_buf(cur, GSM_HR_BYTES);
-#endif /* USE_L1_RTP_MODE */
 
return msg;
 }
@@ -171,10 +119,8 @@
 
memcpy(l1_payload, rtp_payload, GSM_HR_BYTES);
 
-#ifndef USE_L1_RTP_MODE
/* reverse the bit-order of each payload byte */
osmo_revbytebits_buf(l1_payload, GSM_HR_BYTES);
-#endif /* USE_L1_RTP_MODE */
 
return GSM_HR_BYTES;
 }
@@ -315,18 +261,8 @@
break;
case GSM48_CMODE_SPEECH_EFR:
/* Not supported currently */
-#if 0
-   *payload_type = cOCTVC1_GSM_PAYLOAD_TYPE_ENUM_EFR;
-   rc = rtppayload_to_l1_efr(l1_payload, rtp_pl, rtp_pl_len);
-   break;
-#endif
case GSM48_CMODE_SPEECH_AMR:
/* Not supported currently */
-#if 0
-   *payload_type = cOCTVC1_GSM_PAYLOAD_TYPE_ENUM_AMR;
-   rc = rtppayload_to_l1_amr(l1_payload, rtp_pl, rtp_pl_len);
-   break;
-#endif
LOGP(DRTP, LOGL_ERROR, "OctPHY only supports FR!\n");
default:
/* we don't support CSD modes */

-- 
To view, visit https://gerrit.osmocom.org/7029
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I33f3e0fd293ca8387fddf5ed20f642621e9680de
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 

osmo-bts[master]: l1_tch: remove dead code

[Harald Welte]

Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7029
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33f3e0fd293ca8387fddf5ed20f642621e9680de
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-HasComments: No

osmo-ci[master]: osmo-clean-workspace: fix force checkout of a subdirectory

[Harald Welte]

Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.osmocom.org/6964
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If23e89872edf48dc5b751b3c069faf585bd6a3ef
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

[MERGED] libosmocore[master]: features: define osmo_bts_*_feature() as static inline

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: features: define osmo_bts_*_feature() as static inline
..


features: define osmo_bts_*_feature() as static inline

The functions osmo_bts_set_feature() and osmo_bts_has_feature() are
currently defined as inline. Since inline is a hinting, the compiler
might choose not to inline the function. This eventually leads to
linker problems because the function is then defined multiple times.

- use "static inline" instead of "inline" only.

This patch is a follow up patch to
Change Id 680acae725b2b8dda2f239ff20073306fdfb3f6e

Change-Id: Iddd97415a17b06b69f69ddca2e2e296eb2f23a89
---
M include/osmocom/gsm/bts_features.h
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/gsm/bts_features.h 
b/include/osmocom/gsm/bts_features.h
index f9b0142..e84f95b 100644
--- a/include/osmocom/gsm/bts_features.h
+++ b/include/osmocom/gsm/bts_features.h
@@ -30,13 +30,13 @@
 
 const char *osmo_bts_feature_name(enum osmo_bts_features feature);
 
-inline int osmo_bts_set_feature(struct bitvec *features, enum 
osmo_bts_features feature)
+static inline int osmo_bts_set_feature(struct bitvec *features, enum 
osmo_bts_features feature)
 {
OSMO_ASSERT(_NUM_BTS_FEAT < MAX_BTS_FEATURES);
return bitvec_set_bit_pos(features, feature, 1);
 }
 
-inline bool osmo_bts_has_feature(const struct bitvec *features, enum 
osmo_bts_features feature)
+static inline bool osmo_bts_has_feature(const struct bitvec *features, enum 
osmo_bts_features feature)
 {
OSMO_ASSERT(_NUM_BTS_FEAT < MAX_BTS_FEATURES);
return bitvec_get_bit_pos(features, feature);

-- 
To view, visit https://gerrit.osmocom.org/7084
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iddd97415a17b06b69f69ddca2e2e296eb2f23a89
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 

osmo-bsc[master]: implement support for 3-digit MNC with leading zeros

[Harald Welte]

Patch Set 10: Code-Review+2

(2 comments)

https://gerrit.osmocom.org/#/c/6668/10/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:

PS10, Line 1280: ;
   :lai = (struct osmo_location_area_id)
why not simply have the '=' one line above, no typecast and no need to restate 
the 'lai'?  Super cosmetic, but I can't help to wonder "what was his 
motivation".


https://gerrit.osmocom.org/#/c/6668/10/src/osmo-bsc/osmo_bsc_vty.c
File src/osmo-bsc/osmo_bsc_vty.c:

Line 242:   
whitespace, not critical


-- 
To view, visit https://gerrit.osmocom.org/6668
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e722103344186fde118b26d8353db95a4581daa
Gerrit-PatchSet: 10
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: Yes

osmo-msc[master]: VLR: fix potential NULL dereference

[Harald Welte]

Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/6388
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13632908d0b67323202effa9dd6f29732a12cc91
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: neels 
Gerrit-HasComments: No

osmo-ttcn3-hacks[master]: bts/BTS_Tests.ttcn: update TC_rach_max_ta test case

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7090
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88545ed3aabd6da28a40599a8a77d1de477d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[MERGED] osmo-ttcn3-hacks[master]: bts/BTS_Tests.ttcn: update TC_rach_max_ta test case

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: bts/BTS_Tests.ttcn: update TC_rach_max_ta test case
..


bts/BTS_Tests.ttcn: update TC_rach_max_ta test case

Since the I662294fe3136cf7a259be13816a3e63f7db9a948, OsmoBTS
should pass RACH requests with ToA > -2 symbol periods only.

We do allow early signal arrival up to 2 symbols, otherwise
it is most likely noise, interference or a ghost.

Change-Id: I88545ed3aabd6da28a40599a8a77d1de477d
---
M bts/BTS_Tests.ttcn
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index e0e8ac4..e98a8ca 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -669,7 +669,9 @@
 
/* default max-ta is 63 (full range of GSM timing advance */
 
-   /* negative TA must not happen */
+   /* We allow early arrival up to 2 symbols */
+   f_rach_toffs(-1*256, true);
+   f_rach_toffs(-2*256, true);
f_rach_toffs(-10*256, false);
 
/* 0 / 32 / 63 bits is legal / permitted */

-- 
To view, visit https://gerrit.osmocom.org/7090
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I88545ed3aabd6da28a40599a8a77d1de477d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

[MERGED] osmo-bts[master]: common/l1sap.c: increment valid RACH counter after all checks

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: common/l1sap.c: increment valid RACH counter after all checks
..


common/l1sap.c: increment valid RACH counter after all checks

Previously, the number of RACH slots with valid non-handover RACH
burst was incremented between both BER (Bit Error Rate) and ToA
(Timing of Arrival) checks. So, if a RACH burst passed the BER
check, but was dropped by ToA check, the counter of valid RACH
requests could be increased anyway.

Change-Id: I31594a8c5dce1f42226ced5b2dc8778152b3d829
---
M src/common/l1sap.c
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index f83c46d..a96e793 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1211,11 +1211,6 @@
return 0;
}
 
-   /* increment number of RACH slots with valid non-handover RACH burst */
-   btsb->load.rach.access++;
-
-   lc = >ts[0].lchan[CCCH_LCHAN].lapdm_ch;
-
/* check for under/overflow / sign */
if (!check_acc_delay(rach_ind, btsb, _delay)) {
LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "ignoring RACH request %u 
> max_ta(%u)\n",
@@ -1224,6 +1219,11 @@
return 0;
}
 
+   /* increment number of RACH slots with valid non-handover RACH burst */
+   btsb->load.rach.access++;
+
+   lc = >ts[0].lchan[CCCH_LCHAN].lapdm_ch;
+
/* According to 3GPP TS 48.058 § 9.3.17 Access Delay is expressed same 
way as TA (number of symbols) */
set_ms_to_data(get_lchan_by_chan_nr(trx, rach_ind->chan_nr), acc_delay, 
false);
 

-- 
To view, visit https://gerrit.osmocom.org/7086
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I31594a8c5dce1f42226ced5b2dc8778152b3d829
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

[MERGED] osmo-bts[master]: common/l1sap.c: increase the BTS_CTR_RACH_DROP in RACH BER c...

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: common/l1sap.c: increase the BTS_CTR_RACH_DROP in RACH BER check
..


common/l1sap.c: increase the BTS_CTR_RACH_DROP in RACH BER check

The BTS_CTR_RACH_DROP counter is being increased in case if a RACH
request is ignored due to exceeding ToA value, but remains untouched
in case of exceeding BER (Bit Error Rate). Let's fix this.

Change-Id: Ia02e781d6c47d9d8012a4c8846fe4b731aab74d7
---
M src/common/l1sap.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 330b40a..f83c46d 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1207,6 +1207,7 @@
if (rach_ind->ber10k > btsb->max_ber10k_rach) {
DEBUGPFN(DL1C, rach_ind->fn, "ignoring RACH request: %u > %u 
(max BER)\n",
rach_ind->ber10k, btsb->max_ber10k_rach);
+   rate_ctr_inc2(trx->bts->ctrs, BTS_CTR_RACH_DROP);
return 0;
}
 

-- 
To view, visit https://gerrit.osmocom.org/7085
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia02e781d6c47d9d8012a4c8846fe4b731aab74d7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

[MERGED] osmo-bts[master]: common/l1sap.c: limit the minimal ToA for RACH bursts

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: common/l1sap.c: limit the minimal ToA for RACH bursts
..


common/l1sap.c: limit the minimal ToA for RACH bursts

In general, RACH bursts should not arrive with negative offset.
Let's limit early signal arrival up to 2 symbols, otherwise it
is most likely noise, interference or a ghost.

TTCN-3 test case: I88545ed3aabd6da28a40599a8a77d1de477d
Change-Id: I662294fe3136cf7a259be13816a3e63f7db9a948
---
M src/common/l1sap.c
1 file changed, 12 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index ce68599..8380175 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1159,9 +1159,13 @@
return 0;
 }
 
+#define RACH_MIN_TOA256 -2 * 256
+
 static bool rach_pass_filter(struct ph_rach_ind_param *rach_ind,
struct gsm_bts_role_bts *btsb)
 {
+   int16_t toa256 = rach_ind->acc_delay_256bits;
+
/* Check for RACH exceeding BER threshold (ghost RACH) */
if (rach_ind->ber10k > btsb->max_ber10k_rach) {
LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring RACH request: "
@@ -1170,11 +1174,15 @@
return false;
}
 
-   /* Make sure that ToA (Timing of Arrival) is acceptable */
-   if (rach_ind->acc_delay > btsb->max_ta) {
+   /**
+* Make sure that ToA (Timing of Arrival) is acceptable.
+* We allow early arrival up to 2 symbols, and delay
+* according to maximal allowed Timing Advance value.
+*/
+   if (toa256 < RACH_MIN_TOA256 || toa256 > btsb->max_ta * 256) {
LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring RACH request: "
-   "ToA(%u) exceeds the maximal allowed TA(%u) value\n",
-   rach_ind->acc_delay, btsb->max_ta);
+   "ToA(%d) exceeds the allowed range (%d..%d)\n",
+   toa256, RACH_MIN_TOA256, btsb->max_ta * 256);
return false;
}
 

-- 
To view, visit https://gerrit.osmocom.org/7089
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I662294fe3136cf7a259be13816a3e63f7db9a948
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

[MERGED] osmo-bts[master]: common/l1sap.c: perform noise / ghost filtering for handover...

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: common/l1sap.c: perform noise / ghost filtering for handover 
RACH
..


common/l1sap.c: perform noise / ghost filtering for handover RACH

For some reason, the noise / ghost filtering was performed for
normal RACH requests, but not for handover RACH requests. There
are also ghost RACH, interference and noise possible, so let's
extend the filtering coverage.

Change-Id: I94fc15835280d624780200dadc4418210bf565ff
---
M src/common/l1sap.c
1 file changed, 17 insertions(+), 14 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 9648caa..ce68599 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -797,20 +797,6 @@
return 1;
 }
 
-/* special case where handover RACH is detected */
-static int l1sap_handover_rach(struct gsm_bts_trx *trx,
-   struct osmo_phsap_prim *l1sap, struct ph_rach_ind_param *rach_ind)
-{
-   struct gsm_lchan *lchan;
-
-   lchan = get_lchan_by_chan_nr(trx, rach_ind->chan_nr);
-
-   handover_rach(lchan, rach_ind->ra, rach_ind->acc_delay);
-
-   /* must return 0, so in case of msg at l1sap, it will be freed */
-   return 0;
-}
-
 static bool rtppayload_is_octet_aligned(const uint8_t *rtp_pl, uint8_t 
payload_len)
 {
/*
@@ -1195,6 +1181,23 @@
return true;
 }
 
+/* Special case where handover RACH is detected */
+static int l1sap_handover_rach(struct gsm_bts_trx *trx,
+   struct osmo_phsap_prim *l1sap, struct ph_rach_ind_param *rach_ind)
+{
+   /* Filter out noise / interference / ghosts */
+   if (!rach_pass_filter(rach_ind, trx->bts->role)) {
+   rate_ctr_inc2(trx->bts->ctrs, BTS_CTR_RACH_DROP);
+   return 0;
+   }
+
+   handover_rach(get_lchan_by_chan_nr(trx, rach_ind->chan_nr),
+   rach_ind->ra, rach_ind->acc_delay);
+
+   /* must return 0, so in case of msg at l1sap, it will be freed */
+   return 0;
+}
+
 /* RACH received from bts model */
 static int l1sap_ph_rach_ind(struct gsm_bts_trx *trx,
 struct osmo_phsap_prim *l1sap, struct ph_rach_ind_param *rach_ind)

-- 
To view, visit https://gerrit.osmocom.org/7088
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94fc15835280d624780200dadc4418210bf565ff
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

[MERGED] osmo-bts[master]: common/l1sap.c: clean up noise / ghost RACH filtering

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: common/l1sap.c: clean up noise / ghost RACH filtering
..


common/l1sap.c: clean up noise / ghost RACH filtering

It makes sense to combine both existing BER (Bit Error Rate) and
ToA (Timing of Arrival) checks into a separate funcition, so
this code may be also used for handover RACH.

Change-Id: I1ddda238d5212a88a3dd5c4fc5dfcfea018151bd
---
M src/common/l1sap.c
1 file changed, 26 insertions(+), 21 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index a96e793..9648caa 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -797,13 +797,6 @@
return 1;
 }
 
-static int check_acc_delay(struct ph_rach_ind_param *rach_ind,
-   struct gsm_bts_role_bts *btsb, uint8_t *acc_delay)
-{
-   *acc_delay = rach_ind->acc_delay;
-   return *acc_delay <= btsb->max_ta;
-}
-
 /* special case where handover RACH is detected */
 static int l1sap_handover_rach(struct gsm_bts_trx *trx,
struct osmo_phsap_prim *l1sap, struct ph_rach_ind_param *rach_ind)
@@ -1180,6 +1173,28 @@
return 0;
 }
 
+static bool rach_pass_filter(struct ph_rach_ind_param *rach_ind,
+   struct gsm_bts_role_bts *btsb)
+{
+   /* Check for RACH exceeding BER threshold (ghost RACH) */
+   if (rach_ind->ber10k > btsb->max_ber10k_rach) {
+   LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring RACH request: "
+   "BER10k(%u) > BER10k_MAX(%u)\n",
+   rach_ind->ber10k, btsb->max_ber10k_rach);
+   return false;
+   }
+
+   /* Make sure that ToA (Timing of Arrival) is acceptable */
+   if (rach_ind->acc_delay > btsb->max_ta) {
+   LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring RACH request: "
+   "ToA(%u) exceeds the maximal allowed TA(%u) value\n",
+   rach_ind->acc_delay, btsb->max_ta);
+   return false;
+   }
+
+   return true;
+}
+
 /* RACH received from bts model */
 static int l1sap_ph_rach_ind(struct gsm_bts_trx *trx,
 struct osmo_phsap_prim *l1sap, struct ph_rach_ind_param *rach_ind)
@@ -1187,7 +1202,6 @@
struct gsm_bts *bts = trx->bts;
struct gsm_bts_role_bts *btsb = bts->role;
struct lapdm_channel *lc;
-   uint8_t acc_delay;
 
DEBUGPFN(DL1P, rach_ind->fn, "Rx PH-RA.ind");
 
@@ -1203,18 +1217,8 @@
if (rach_ind->rssi >= btsb->load.rach.busy_thresh)
btsb->load.rach.busy++;
 
-   /* check for RACH exceeding BER threshold (ghost RACH) */
-   if (rach_ind->ber10k > btsb->max_ber10k_rach) {
-   DEBUGPFN(DL1C, rach_ind->fn, "ignoring RACH request: %u > %u 
(max BER)\n",
-   rach_ind->ber10k, btsb->max_ber10k_rach);
-   rate_ctr_inc2(trx->bts->ctrs, BTS_CTR_RACH_DROP);
-   return 0;
-   }
-
-   /* check for under/overflow / sign */
-   if (!check_acc_delay(rach_ind, btsb, _delay)) {
-   LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "ignoring RACH request %u 
> max_ta(%u)\n",
-acc_delay, btsb->max_ta);
+   /* Filter out noise / interference / ghosts */
+   if (!rach_pass_filter(rach_ind, btsb)) {
rate_ctr_inc2(trx->bts->ctrs, BTS_CTR_RACH_DROP);
return 0;
}
@@ -1225,7 +1229,8 @@
lc = >ts[0].lchan[CCCH_LCHAN].lapdm_ch;
 
/* According to 3GPP TS 48.058 § 9.3.17 Access Delay is expressed same 
way as TA (number of symbols) */
-   set_ms_to_data(get_lchan_by_chan_nr(trx, rach_ind->chan_nr), acc_delay, 
false);
+   set_ms_to_data(get_lchan_by_chan_nr(trx, rach_ind->chan_nr),
+   rach_ind->acc_delay, false);
 
/* check for packet access */
if ((trx == bts->c0 && L1SAP_IS_PACKET_RACH(rach_ind->ra)) ||

-- 
To view, visit https://gerrit.osmocom.org/7087
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1ddda238d5212a88a3dd5c4fc5dfcfea018151bd
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

osmo-bts[master]: common/l1sap.c: limit the minimal ToA for RACH bursts

[Harald Welte]

Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7089
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I662294fe3136cf7a259be13816a3e63f7db9a948
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

osmo-bts[master]: common/l1sap.c: perform noise / ghost filtering for handover...

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7088
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94fc15835280d624780200dadc4418210bf565ff
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

osmo-bts[master]: common/l1sap.c: clean up noise / ghost RACH filtering

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7087
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ddda238d5212a88a3dd5c4fc5dfcfea018151bd
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

osmo-bts[master]: common/l1sap.c: increment valid RACH counter after all checks

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7086
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31594a8c5dce1f42226ced5b2dc8778152b3d829
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

osmo-bts[master]: common/l1sap.c: increase the BTS_CTR_RACH_DROP in RACH BER c...

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7085
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia02e781d6c47d9d8012a4c8846fe4b731aab74d7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[MERGED] libosmocore[master]: osmo-release.sh: Set correct version when generating the cha...

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: osmo-release.sh: Set correct version when generating the 
changelog
..


osmo-release.sh: Set correct version when generating the changelog

Otherwise, while updating osmo-trx 0.2.0->0.3.0, the version printed in
the changelog by gbp dch is 0.2.1

Change-Id: I744adb23b4602e5e47f80a012286578d1e59de88
---
M osmo-release.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/osmo-release.sh b/osmo-release.sh
index ff82e4c..ed40d0b 100755
--- a/osmo-release.sh
+++ b/osmo-release.sh
@@ -27,7 +27,7 @@
 echo "Releasing $VERSION -> $NEW_VER..."
 
 if [ "z$LIBVERS" = "z" ]; then
-   gbp dch --debian-tag='%(version)s' --auto --meta --git-author 
--multimaint-merge --ignore-branch
+   gbp dch --debian-tag='%(version)s' --auto --meta --git-author 
--multimaint-merge --ignore-branch --new-version="$NEW_VER"
 else
echo "You should NOT be doing this unless you've read and understood 
following article:"
echo 
"https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html#Updating-version-info;

-- 
To view, visit https://gerrit.osmocom.org/7094
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I744adb23b4602e5e47f80a012286578d1e59de88
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

libosmocore[master]: osmo-release.sh: Set correct version when generating the cha...

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7094
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I744adb23b4602e5e47f80a012286578d1e59de88
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

osmo-trx[rel-0.3.0]: jenkins.sh: fix the download url if the qemu image wasn't setup

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7092
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75e270b7255c1cd7fca1674111b0f19fc7bba74f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: rel-0.3.0
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-HasComments: No

osmo-trx[rel-0.3.0]: Bump version: 0.2.0 → 0.3.0

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7093
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dad76ed95dc585acfbd52d7eed4f2e6f9f5fd1f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: rel-0.3.0
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

osmo-trx[rel-0.3.0]: Fix USRP1 build with support for setting Rx/TxAntenna

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7091
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28585947d5662cdd580a814cce54a5d9aa30eeb8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: rel-0.3.0
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[PATCH] osmo-ci[master]: jenkins: add job osmo-gsm-tester_gerrit

[lynxis lazus]

jenkins: add job osmo-gsm-tester_gerrit

The job verifies the gerrit patchset.

Change-Id: If661675528059bc8a95d39a6489a5a9381f52677
---
M jobs/osmo-gsm-tester.yml
A jobs/osmo-gsm-tester_gerrit.sh
2 files changed, 63 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/22/7022/3

diff --git a/jobs/osmo-gsm-tester.yml b/jobs/osmo-gsm-tester.yml
index 41a7ec1..74d28eb 100644
--- a/jobs/osmo-gsm-tester.yml
+++ b/jobs/osmo-gsm-tester.yml
@@ -1,7 +1,6 @@
 ---
 #TODO:
 #  - trigger
-#  - gerrit
 #  - manual-run
 #
 - project:
@@ -100,6 +99,19 @@
   wipe-workspace: false
   skip-tag: true
   basedir: osmo-gsm-tester
+- scm:
+name: osmo-gsm-tester-gerrit
+scm:
+  - git:
+  url: ssh://jenk...@gerrit.osmocom.org:29418/osmo-gsm-tester
+  credentials-id: jenkins
+  branches:
+- $GERRIT_BRANCH
+  wipe-workspace: false
+  skip-tag: true
+  basedir: osmo-gsm-tester
+  clean:  true
+  choosing-strategy: 'gerrit'
 
 - scm:
 name: osmo-gsm-tester-repo-clean
@@ -133,6 +145,7 @@
   node: 'osmo-gsm-tester-rnd'
 jobs:
   - 'osmo-gsm-tester_run-{stage}'
+  - 'osmo-gsm-tester_gerrit'
 
 - builder:
 name: osmo_gsm_copy_artifact
@@ -192,6 +205,36 @@
   default: ""
   description: "pass additional command line options to 
osmo-gsm-tester.py, e.g. to select specific suites:scenarios. Default: leave 
empty."
 
+- job:
+name: 'osmo-gsm-tester_gerrit'
+defaults: runner
+triggers:
+  - gerrit:
+  server-name: 'gerrit.osmocom.org'
+  trigger-on:
+- patchset-created-event:
+exclude-no-code-change: true
+- draft-published-event
+  projects:
+- project-compare-type: 'PLAIN'
+  project-pattern: 'osmo-gsm-tester'
+  branches:
+- branch-compare-type: 'ANT'
+  branch-pattern: '**'
+builders:
+  - shell: |
+  # make sure no bin artifacts from a previous run remain
+  rm -f *.tgz *.md5
+  - osmo_gsm_copy_artifact_all
+  - shell: !include-raw osmo-gsm-tester_gerrit.sh
+publishers:
+  - archive:
+  artifacts: '*-run.tgz, *-bin.tgz'
+  default-excludes: false
+  - junit:
+  results: 'trial-*/last_run/trial-*.xml'
+  allow-empty-results: true
+
 - job-template:
 name: 'osmo-gsm-tester_run-{stage}'
 defaults: runner
diff --git a/jobs/osmo-gsm-tester_gerrit.sh b/jobs/osmo-gsm-tester_gerrit.sh
new file mode 100644
index 000..b07207f
--- /dev/null
+++ b/jobs/osmo-gsm-tester_gerrit.sh
@@ -0,0 +1,19 @@
+#!/bin/sh
+set -e -x
+
+# On our hardware, we actually use the example configuration as-is.
+export OSMO_GSM_TESTER_CONF="$PWD/osmo-gsm-tester/example"
+
+# debug: provoke a failure
+#export OSMO_GSM_TESTER_OPTS="-s debug -t fail"
+
+# TMP fix: prod main unit has sierra_2 and _3 instead of _1 and _2
+sed -i 
"s#/sys/devices/pci:00/:00:12.2/usb1/1-1/1-1.3#/sys/devices/pci:00/:00:12.2/usb1/1-1/1-1.7/1-1.7.3#g"
 "$OSMO_GSM_TESTER_CONF/resources.conf"
+sed -i 
"s#/sys/devices/pci:00/:00:12.2/usb1/1-1/1-1.2#/sys/devices/pci:00/:00:12.2/usb1/1-1/1-1.7/1-1.7.2#g"
 "$OSMO_GSM_TESTER_CONF/resources.conf"
+sed -i "s#90170009031#90170015252#g" 
"$OSMO_GSM_TESTER_CONF/resources.conf"
+sed -i "s#90170009029#90170015253#g" 
"$OSMO_GSM_TESTER_CONF/resources.conf"
+sed -i "s#80A37E6FDEA931EAC92FFA5F671EFEAD#EBAB63D06C3F546A16C977CB40E57C68#g" 
"$OSMO_GSM_TESTER_CONF/resources.conf"
+sed -i "s#00969E283349D354A8239E877F2E0866#EBD2B5F6CF3374106D0A66C11F922001#g" 
"$OSMO_GSM_TESTER_CONF/resources.conf"
+
+export OSMO_GSM_TESTER_OPTS="-s sms:sysmo -s aoip_sms:sysmo -s gprs:sysmo"
+./osmo-gsm-tester/contrib/jenkins-make-check-and-run.sh

-- 
To view, visit https://gerrit.osmocom.org/7022
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If661675528059bc8a95d39a6489a5a9381f52677
Gerrit-PatchSet: 3
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 

[PATCH] osmo-ci[master]: jenkins: add job osmo-gsm-tester_gerrit

[lynxis lazus]

jenkins: add job osmo-gsm-tester_gerrit

The job verifies the gerrit patchset.

Change-Id: If661675528059bc8a95d39a6489a5a9381f52677
---
M jobs/osmo-gsm-tester.yml
A jobs/osmo-gsm-tester_gerrit.sh
2 files changed, 63 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/22/7022/2

diff --git a/jobs/osmo-gsm-tester.yml b/jobs/osmo-gsm-tester.yml
index 41a7ec1..1013ef8 100644
--- a/jobs/osmo-gsm-tester.yml
+++ b/jobs/osmo-gsm-tester.yml
@@ -1,7 +1,6 @@
 ---
 #TODO:
 #  - trigger
-#  - gerrit
 #  - manual-run
 #
 - project:
@@ -100,6 +99,19 @@
   wipe-workspace: false
   skip-tag: true
   basedir: osmo-gsm-tester
+- scm:
+name: osmo-gsm-tester-gerrit
+scm:
+  - git:
+  url: ssh://jenk...@gerrit.osmocom.org:29418/osmo-gsm-tester
+  credentials-id: jenkins
+  branches:
+- $GERRIT_BRANCH
+  wipe-workspace: false
+  skip-tag: true
+  basedir: osmo-gsm-tester
+  clean:  true
+  choosing-strategy: 'gerrit'
 
 - scm:
 name: osmo-gsm-tester-repo-clean
@@ -133,6 +145,7 @@
   node: 'osmo-gsm-tester-rnd'
 jobs:
   - 'osmo-gsm-tester_run-{stage}'
+  - 'osmo-gsm-tester_gerrit'
 
 - builder:
 name: osmo_gsm_copy_artifact
@@ -192,6 +205,36 @@
   default: ""
   description: "pass additional command line options to 
osmo-gsm-tester.py, e.g. to select specific suites:scenarios. Default: leave 
empty."
 
+- job:
+name: 'osmo-gsm-tester_gerrit'
+defaults: runners
+triggers:
+  - gerrit:
+  server-name: 'gerrit.osmocom.org'
+  trigger-on:
+- patchset-created-event:
+exclude-no-code-change: true
+- draft-published-event
+  projects:
+- project-compare-type: 'PLAIN'
+  project-pattern: 'osmo-gsm-tester'
+  branches:
+- branch-compare-type: 'ANT'
+  branch-pattern: '**'
+builders:
+  - shell: |
+  # make sure no bin artifacts from a previous run remain
+  rm -f *.tgz *.md5
+  - osmo_gsm_copy_artifact_all
+  - shell: !include-raw osmo-gsm-tester_gerrit.sh
+publishers:
+  - archive:
+  artifacts: '*-run.tgz, *-bin.tgz'
+  default-excludes: false
+  - junit:
+  results: 'trial-*/last_run/trial-*.xml'
+  allow-empty-results: true
+
 - job-template:
 name: 'osmo-gsm-tester_run-{stage}'
 defaults: runner
diff --git a/jobs/osmo-gsm-tester_gerrit.sh b/jobs/osmo-gsm-tester_gerrit.sh
new file mode 100644
index 000..b07207f
--- /dev/null
+++ b/jobs/osmo-gsm-tester_gerrit.sh
@@ -0,0 +1,19 @@
+#!/bin/sh
+set -e -x
+
+# On our hardware, we actually use the example configuration as-is.
+export OSMO_GSM_TESTER_CONF="$PWD/osmo-gsm-tester/example"
+
+# debug: provoke a failure
+#export OSMO_GSM_TESTER_OPTS="-s debug -t fail"
+
+# TMP fix: prod main unit has sierra_2 and _3 instead of _1 and _2
+sed -i 
"s#/sys/devices/pci:00/:00:12.2/usb1/1-1/1-1.3#/sys/devices/pci:00/:00:12.2/usb1/1-1/1-1.7/1-1.7.3#g"
 "$OSMO_GSM_TESTER_CONF/resources.conf"
+sed -i 
"s#/sys/devices/pci:00/:00:12.2/usb1/1-1/1-1.2#/sys/devices/pci:00/:00:12.2/usb1/1-1/1-1.7/1-1.7.2#g"
 "$OSMO_GSM_TESTER_CONF/resources.conf"
+sed -i "s#90170009031#90170015252#g" 
"$OSMO_GSM_TESTER_CONF/resources.conf"
+sed -i "s#90170009029#90170015253#g" 
"$OSMO_GSM_TESTER_CONF/resources.conf"
+sed -i "s#80A37E6FDEA931EAC92FFA5F671EFEAD#EBAB63D06C3F546A16C977CB40E57C68#g" 
"$OSMO_GSM_TESTER_CONF/resources.conf"
+sed -i "s#00969E283349D354A8239E877F2E0866#EBD2B5F6CF3374106D0A66C11F922001#g" 
"$OSMO_GSM_TESTER_CONF/resources.conf"
+
+export OSMO_GSM_TESTER_OPTS="-s sms:sysmo -s aoip_sms:sysmo -s gprs:sysmo"
+./osmo-gsm-tester/contrib/jenkins-make-check-and-run.sh

-- 
To view, visit https://gerrit.osmocom.org/7022
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If661675528059bc8a95d39a6489a5a9381f52677
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 

[PATCH] osmo-ci[master]: jenkins: add job osmo-gsm-tester_build-trigger-all

[lynxis lazus]

Hello Pau Espin Pedrol,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/7020

to look at the new patch set (#2).

jenkins: add job osmo-gsm-tester_build-trigger-all

osmo-gsm-tester_build-trigger-all triggers a new build of all
osmo-gsm-tester build jobs.

Change-Id: I8dcf2a6fa2991cb73b4807f8a10d251f3dca77dd
---
M jobs/osmo-gsm-tester.yml
1 file changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/20/7020/2

diff --git a/jobs/osmo-gsm-tester.yml b/jobs/osmo-gsm-tester.yml
index 85523d0..034e137 100644
--- a/jobs/osmo-gsm-tester.yml
+++ b/jobs/osmo-gsm-tester.yml
@@ -30,6 +30,7 @@
 
 jobs:
   - 'osmo-gsm-tester_build-{repo}'
+  - 'osmo-gsm-tester_build-trigger-all'
 
 - parameter:
 name: gsmtester_build_branch
@@ -100,3 +101,14 @@
   wipe-workspace: false
   skip-tag: true
   basedir: osmo-gsm-tester
+
+## trigger build job
+- job:
+name: 'osmo-gsm-tester_build-trigger-all'
+description: 'Manually kick off all osmo-gsm-tester_build-osmo-* builds at 
once.'
+project-type: freestyle
+node: osmo-gsm-tester-build
+publishers:
+  # hopefully the trigger will support lists in the future
+  - trigger:
+  project: 
'osmo-gsm-tester_build-osmo-bsc,osmo-gsm-tester_build-osmo-bts,osmo-gsm-tester_build-osmo-ggsn,osmo-gsm-tester_build-osmo-hlr,osmo-gsm-tester_build-osmo-mgw,osmo-gsm-tester_build-osmo-msc,osmo-gsm-tester_build-osmo-pcu,osmo-gsm-tester_build-osmo-sgsn,osmo-gsm-tester_build-osmo-trx,osmo-gsm-tester_build-osmo-nitb,osmo-gsm-tester_build-osmo-stp,osmo-gsm-tester_build-osmo-bts-sysmo,osmo-gsm-tester_build-osmo-pcu-sysmo'

-- 
To view, visit https://gerrit.osmocom.org/7020
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8dcf2a6fa2991cb73b4807f8a10d251f3dca77dd
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Pau Espin Pedrol 

[PATCH] osmo-ci[master]: jenkins: add osmo-gsm-tester_run-{prod,rnd}

[lynxis lazus]

jenkins: add osmo-gsm-tester_run-{prod,rnd}

Both jobs doing the actual test run on the prod or rnd tester.

Change-Id: Ic1c4babc547f48402b0bcfaf38e2734e87e565f0
---
M jobs/osmo-gsm-tester.yml
A jobs/osmo-gsm-tester_run-prod.sh
A jobs/osmo-gsm-tester_run-rnd.sh
3 files changed, 150 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/21/7021/2

diff --git a/jobs/osmo-gsm-tester.yml b/jobs/osmo-gsm-tester.yml
index 034e137..41a7ec1 100644
--- a/jobs/osmo-gsm-tester.yml
+++ b/jobs/osmo-gsm-tester.yml
@@ -1,6 +1,5 @@
 ---
 #TODO:
-#  - run
 #  - trigger
 #  - gerrit
 #  - manual-run
@@ -102,6 +101,18 @@
   skip-tag: true
   basedir: osmo-gsm-tester
 
+- scm:
+name: osmo-gsm-tester-repo-clean
+scm:
+  - git:
+  url: git://git.osmocom.org/osmo-gsm-tester
+  branches:
+- ${OSMO_GSM_TESTER_BRANCH}
+  wipe-workspace: false
+  skip-tag: true
+  basedir: osmo-gsm-tester
+  clean:  true
+
 ## trigger build job
 - job:
 name: 'osmo-gsm-tester_build-trigger-all'
@@ -112,3 +123,109 @@
   # hopefully the trigger will support lists in the future
   - trigger:
   project: 
'osmo-gsm-tester_build-osmo-bsc,osmo-gsm-tester_build-osmo-bts,osmo-gsm-tester_build-osmo-ggsn,osmo-gsm-tester_build-osmo-hlr,osmo-gsm-tester_build-osmo-mgw,osmo-gsm-tester_build-osmo-msc,osmo-gsm-tester_build-osmo-pcu,osmo-gsm-tester_build-osmo-sgsn,osmo-gsm-tester_build-osmo-trx,osmo-gsm-tester_build-osmo-nitb,osmo-gsm-tester_build-osmo-stp,osmo-gsm-tester_build-osmo-bts-sysmo,osmo-gsm-tester_build-osmo-pcu-sysmo'
+
+## run jobs
+- project:
+name: osmo-gsm-testers-runner
+stage:
+  - prod
+  - rnd:
+  node: 'osmo-gsm-tester-rnd'
+jobs:
+  - 'osmo-gsm-tester_run-{stage}'
+
+- builder:
+name: osmo_gsm_copy_artifact
+builders:
+  - copyartifact:
+  project: '{repo}'
+  filter: '*.tgz, *.md5'
+  which-build: last-successful
+  stable: true
+
+# all artifact in one place
+- builder:
+name: osmo_gsm_copy_artifact_all
+builders:
+  - osmo_gsm_copy_artifact:
+ repo: osmo-gsm-tester_build-osmo-bsc
+  - osmo_gsm_copy_artifact:
+ repo: osmo-gsm-tester_build-osmo-bts
+  - osmo_gsm_copy_artifact:
+ repo: osmo-gsm-tester_build-osmo-ggsn
+  - osmo_gsm_copy_artifact:
+ repo: osmo-gsm-tester_build-osmo-hlr
+  - osmo_gsm_copy_artifact:
+ repo: osmo-gsm-tester_build-osmo-mgw
+  - osmo_gsm_copy_artifact:
+ repo: osmo-gsm-tester_build-osmo-msc
+  - osmo_gsm_copy_artifact:
+ repo: osmo-gsm-tester_build-osmo-pcu
+  - osmo_gsm_copy_artifact:
+ repo: osmo-gsm-tester_build-osmo-sgsn
+  - osmo_gsm_copy_artifact:
+ repo: osmo-gsm-tester_build-osmo-trx
+  - osmo_gsm_copy_artifact:
+ repo: osmo-gsm-tester_build-osmo-nitb
+  - osmo_gsm_copy_artifact:
+ repo: osmo-gsm-tester_build-osmo-stp
+  - osmo_gsm_copy_artifact:
+ repo: osmo-gsm-tester_build-osmo-bts-sysmo
+  - osmo_gsm_copy_artifact:
+ repo: osmo-gsm-tester_build-osmo-pcu-sysmo
+
+- defaults:
+name: runner
+description: 'Run an actual GSM hardware test using the binaries from the 
osmo-gsm-tester_build* jobs'
+node: 'osmo-gsm-tester-prod'
+project-type: freestyle
+properties:
+  - build-discarder:
+  num-to-keep: 60
+parameters:
+  - string:
+  name: "OSMO_GSM_TESTER_BRANCH"
+  default: "origin/master"
+  description: "Which branch/sha should be used for testing"
+  - string:
+  name: "OSMO_GSM_TESTER_OPTS"
+  default: ""
+  description: "pass additional command line options to 
osmo-gsm-tester.py, e.g. to select specific suites:scenarios. Default: leave 
empty."
+
+- job-template:
+name: 'osmo-gsm-tester_run-{stage}'
+defaults: runner
+triggers:
+  - timed: "H H/2 * * *"
+  - pollscm:
+  cron: "H/5 * * * *"
+  - reverse:
+jobs:
+- osmo-gsm-tester_build-osmo-bsc
+- osmo-gsm-tester_build-osmo-bts
+- osmo-gsm-tester_build-osmo-ggsn
+- osmo-gsm-tester_build-osmo-hlr
+- osmo-gsm-tester_build-osmo-mgw
+- osmo-gsm-tester_build-osmo-msc
+- osmo-gsm-tester_build-osmo-pcu
+- osmo-gsm-tester_build-osmo-sgsn
+- osmo-gsm-tester_build-osmo-trx
+- osmo-gsm-tester_build-osmo-nitb
+- osmo-gsm-tester_build-osmo-stp
+- osmo-gsm-tester_build-osmo-bts-sysmo
+- osmo-gsm-tester_build-osmo-pcu-sysmo
+builders:
+  - osmo_gsm_copy_artifact_all
+  - shell: !include-raw osmo-gsm-tester_run-{stage}.sh
+publishers:
+  - archive:
+  artifacts: '*-run.tgz, *-bin.tgz'
+  default-excludes: false
+  

[PATCH] osmo-ci[master]: jenkins: add osmo-gsm-tester-build jobs

[lynxis lazus]

Hello Pau Espin Pedrol,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/7019

to look at the new patch set (#3).

jenkins: add osmo-gsm-tester-build jobs

The build jobs building all osmocom components which will be used by the
osmo-gsm-tester. A .tgz archive will be used as artefact which is copied
later by the osmo-gsm-tester test run.

Change-Id: Ic49c94e9e6639e43f6ae14b868bc826af3ce2085
---
A jobs/osmo-gsm-tester.yml
1 file changed, 102 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/19/7019/3

diff --git a/jobs/osmo-gsm-tester.yml b/jobs/osmo-gsm-tester.yml
new file mode 100644
index 000..85523d0
--- /dev/null
+++ b/jobs/osmo-gsm-tester.yml
@@ -0,0 +1,102 @@
+---
+#TODO:
+#  - run
+#  - trigger
+#  - gerrit
+#  - manual-run
+#
+- project:
+name: osmo-gsm-tester-builder
+
+repo:
+  - osmo-bsc
+  - osmo-bts
+  - osmo-ggsn
+  - osmo-hlr
+  - osmo-mgw
+  - osmo-msc
+  - osmo-pcu
+  - osmo-sgsn
+  - osmo-trx
+  - osmo-nitb:
+  reverse-job: master-openbsc
+  - osmo-stp:
+  reverse-job: master-libosmo-sccp
+  - osmo-bts-sysmo:
+  reverse-job: master-osmo-bts
+  - osmo-pcu-sysmo:
+  reverse-job: master-osmo-pcu
+reverse-job: 'master-{repo}'
+
+jobs:
+  - 'osmo-gsm-tester_build-{repo}'
+
+- parameter:
+name: gsmtester_build_branch
+parameters:
+  - string:
+  name: "{name}"
+  default: ""
+  description: "Default: leave empty. Branch to build from, in the 
form my/branch or origin/my/branch (do not prepend 'refs/heads/')"
+
+- job-template:
+name: 'osmo-gsm-tester_build-{repo}'
+project-type: freestyle
+node: osmo-gsm-tester-build
+builders:
+  - shell: |
+  set -e -x
+  ./osmo-gsm-tester/contrib/jenkins-build-{repo}.sh
+triggers:
+  - reverse:
+jobs: '{reverse-job}'
+publishers:
+  - archive:
+  artifacts: '*.tgz, *.md5'
+  only-if-success: 'true'
+  default-excludes: false
+properties:
+  - build-discarder:
+  num-to-keep: 20
+parameters:
+  - string:
+  name: "OSMO_GSM_TESTER_BRANCH"
+  default: "origin/master"
+  description: "Which branch/sha should be used for testing"
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_libosmo-abis
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_libosmocore
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_libosmo-netif
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_libosmo_sccp
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_octphy_2g_headers
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_osmo_bts
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_osmo_mgw
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_osmo-mgw
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_osmo_msc
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_osmo_pcu
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_osmo_trx
+scm:
+  - osmo-gsm-tester-repo
+
+# The repo must be used seperate to workaround the bug "Can not expand 
OSMO_GSM_TESTER_BRANCH".
+# The safe-guard check to not use un-defined variables seems to be broken.
+- scm:
+name: osmo-gsm-tester-repo
+scm:
+  - git:
+  url: git://git.osmocom.org/osmo-gsm-tester
+  branches:
+- ${OSMO_GSM_TESTER_BRANCH}
+  wipe-workspace: false
+  skip-tag: true
+  basedir: osmo-gsm-tester

-- 
To view, visit https://gerrit.osmocom.org/7019
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic49c94e9e6639e43f6ae14b868bc826af3ce2085
Gerrit-PatchSet: 3
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

[PATCH] osmo-ci[master]: jenkins: add osmo-gsm-tester-build jobs

[lynxis lazus]

Hello Pau Espin Pedrol,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/7019

to look at the new patch set (#2).

jenkins: add osmo-gsm-tester-build jobs

The build jobs building all osmocom components which will be used by the
osmo-gsm-tester. A .tgz archive will be used as artefact which is copied
later by the osmo-gsm-tester test run.

Change-Id: Ic49c94e9e6639e43f6ae14b868bc826af3ce2085
---
A jobs/osmo-gsm-tester.yml
1 file changed, 102 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/19/7019/2

diff --git a/jobs/osmo-gsm-tester.yml b/jobs/osmo-gsm-tester.yml
new file mode 100644
index 000..c182821
--- /dev/null
+++ b/jobs/osmo-gsm-tester.yml
@@ -0,0 +1,102 @@
+---
+#TODO:
+#  - run
+#  - trigger
+#  - gerrit
+#  - manual-run
+#
+- project:
+name: osmo-gsm-testers
+
+repo:
+  - osmo-bsc
+  - osmo-bts
+  - osmo-ggsn
+  - osmo-hlr
+  - osmo-mgw
+  - osmo-msc
+  - osmo-pcu
+  - osmo-sgsn
+  - osmo-trx
+  - osmo-nitb:
+  reverse-job: master-openbsc
+  - osmo-stp:
+  reverse-job: master-libosmo-sccp
+  - osmo-bts-sysmo:
+  reverse-job: master-osmo-bts
+  - osmo-pcu-sysmo:
+  reverse-job: master-osmo-pcu
+reverse-job: 'master-{repo}'
+
+jobs:
+  - 'osmo-gsm-tester_build-{repo}'
+
+- parameter:
+name: gsmtester_build_branch
+parameters:
+  - string:
+  name: "{name}"
+  default: ""
+  description: "Default: leave empty. Branch to build from, in the 
form my/branch or origin/my/branch (do not prepend 'refs/heads/')"
+
+- job-template:
+name: 'osmo-gsm-tester_build-{repo}'
+project-type: freestyle
+node: osmo-gsm-tester-build
+builders:
+  - shell: |
+  set -e -x
+  ./osmo-gsm-tester/contrib/jenkins-build-{repo}.sh
+triggers:
+  - reverse:
+jobs: '{reverse-job}'
+publishers:
+  - archive:
+  artifacts: '*.tgz, *.md5'
+  only-if-success: 'true'
+  default-excludes: false
+properties:
+  - build-discarder:
+  num-to-keep: 20
+parameters:
+  - string:
+  name: "OSMO_GSM_TESTER_BRANCH"
+  default: "origin/master"
+  description: "Which branch/sha should be used for testing"
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_libosmo-abis
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_libosmocore
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_libosmo-netif
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_libosmo_sccp
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_octphy_2g_headers
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_osmo_bts
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_osmo_mgw
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_osmo-mgw
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_osmo_msc
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_osmo_pcu
+  - gsmtester_build_branch:
+ name: OSMO_GSM_TESTER_BUILD_osmo_trx
+scm:
+  - osmo-gsm-tester-repo
+
+# The repo must be used seperate to workaround the bug "Can not expand 
OSMO_GSM_TESTER_BRANCH".
+# The safe-guard check to not use un-defined variables seems to be broken.
+- scm:
+name: osmo-gsm-tester-repo
+scm:
+  - git:
+  url: git://git.osmocom.org/osmo-gsm-tester
+  branches:
+- ${OSMO_GSM_TESTER_BRANCH}
+  wipe-workspace: false
+  skip-tag: true
+  basedir: osmo-gsm-tester

-- 
To view, visit https://gerrit.osmocom.org/7019
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic49c94e9e6639e43f6ae14b868bc826af3ce2085
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

[PATCH] libosmocore[master]: osmo-release.sh: Set correct version when generating the cha...

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/7094

osmo-release.sh: Set correct version when generating the changelog

Otherwise, while updating osmo-trx 0.2.0->0.3.0, the version printed in
the changelog by gbp dch is 0.2.1

Change-Id: I744adb23b4602e5e47f80a012286578d1e59de88
---
M osmo-release.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/94/7094/1

diff --git a/osmo-release.sh b/osmo-release.sh
index ff82e4c..ed40d0b 100755
--- a/osmo-release.sh
+++ b/osmo-release.sh
@@ -27,7 +27,7 @@
 echo "Releasing $VERSION -> $NEW_VER..."
 
 if [ "z$LIBVERS" = "z" ]; then
-   gbp dch --debian-tag='%(version)s' --auto --meta --git-author 
--multimaint-merge --ignore-branch
+   gbp dch --debian-tag='%(version)s' --auto --meta --git-author 
--multimaint-merge --ignore-branch --new-version="$NEW_VER"
 else
echo "You should NOT be doing this unless you've read and understood 
following article:"
echo 
"https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html#Updating-version-info;

-- 
To view, visit https://gerrit.osmocom.org/7094
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I744adb23b4602e5e47f80a012286578d1e59de88
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 

[PATCH] osmo-trx[rel-0.3.0]: Bump version: 0.2.0 → 0.3.0

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/7093

Bump version: 0.2.0 → 0.3.0

Change-Id: I4dad76ed95dc585acfbd52d7eed4f2e6f9f5fd1f
---
M debian/changelog
1 file changed, 68 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/93/7093/1

diff --git a/debian/changelog b/debian/changelog
index ec65036..20bbfa0 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,71 @@
+osmo-trx (0.3.0) unstable; urgency=medium
+
+  [ Neels Hofmeyr ]
+  * jenkins: use osmo-clean-workspace.sh before and after build
+
+  [ Harald Welte ]
+  * SocketsTest: Fix printing of non-nul-terminated string
+
+  [ Piotr Krysik ]
+  * UHDDevice.cpp: add USRP B205mini support
+
+  [ Max ]
+  * Mark release target as virtual
+  * Remove outdated references to OpenBTS
+  * Remove unused headers
+  * Update installation instructions
+  * Update legal disclaimer
+  * Update license notes
+  * tests: null-terminate buffer
+
+  [ Pau Espin Pedrol ]
+  * cosmetic: Remove trailing whitespace
+  * Logger: Stop using Log.Alarms.Max from config
+  * Logger: Stop using Log.File and Log.Level from config
+  * Drop use of ConfigurationTable gConfig
+  * Remove Configuration module and libsqlite dependency
+  * cosmetic: AUTHORS: fix trailing whitespace
+  * Set up GNU Autotest infrastructure
+  * tests: InterThread: adapt to have reproducible output and enable autotest
+  * tests: Timeval: adapt to have reproducible output and enable autotest
+  * tests: Log: adapt to have reproducible output and enable autotest
+  * Sockets.cpp: Fix initialization of UDD socket
+  * tests: Sockets: adapt to have reproducible output and enable autotest
+  * utils/convolvtest: Remove uneeded libosmocore dependency
+  * Move ARCH_LA to Makefile.common
+  * tests: Migrate convtest util to autotest infrastructure
+  * arm/convert.c: Fix compilation error
+  * arm/convert.c: Add missing convert_init implementation
+  * .gitignore: Add missing test related files
+  * Remove UDDSocket class
+  * tests: SocketTests: Pick OS-assigned instead of setting one manually
+  * tests: SocketsTest: Avoid hang forever if test fails
+  * tests: SocketsTest: Fail test on write fail
+  * tests: TimevalTest: refactor and avoid double comparison
+  * contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests with ARM 
instruction set
+  * tests: convolve: Disable due to difference in output in different archs
+  * Remove unneeded libdl dependency
+  * Fix whitespace
+  * Add support to set Rx/TxAntenna
+  * UHDDevice: Initialize async_event_thrd in constructor
+  * Logger: Drop unused gLogEarly
+  * Logger: Remove unused logging macros
+  * Logger: get rid of alarm APIs
+  * Logger: Drop syslog support
+  * Logger: Drop support to log into file
+  * Logger: Remove unused includes
+  * Logger: Remove gLogToConsole flag
+  * configure.ac: Check for pkg-config
+
+  [ Alexander Huemer ]
+  * Unbreak `./configure --with-usrp1` build
+  * Fix USRP1 build with support for setting Rx/TxAntenna
+
+  [ Alexander Couzens ]
+  * jenkins.sh: fix the download url if the qemu image wasn't setup
+
+ -- Pau Espin Pedrol   Mon, 05 Mar 2018 16:49:42 +0100
+
 osmo-trx (0.2.0) unstable; urgency=medium
 
   [ Alexander Chemeris ]

-- 
To view, visit https://gerrit.osmocom.org/7093
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4dad76ed95dc585acfbd52d7eed4f2e6f9f5fd1f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: rel-0.3.0
Gerrit-Owner: Pau Espin Pedrol 

[PATCH] osmo-trx[rel-0.3.0]: Fix USRP1 build with support for setting Rx/TxAntenna

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/7091

Fix USRP1 build with support for setting Rx/TxAntenna

The USRP1 build was broken by commit 77ce99ac6720896f504a0581a5c57b2929a13cef.

Commit 77ce99ac6720896f504a0581a5c57b2929a13cef broke the USRP1 build

Change-Id: I28585947d5662cdd580a814cce54a5d9aa30eeb8
(cherry picked from commit 3f52f0e6c5d384f25ff8583648e5e4a4dc957530)
---
M Transceiver52M/USRPDevice.h
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/91/7091/1

diff --git a/Transceiver52M/USRPDevice.h b/Transceiver52M/USRPDevice.h
index f5fbe85..f981643 100644
--- a/Transceiver52M/USRPDevice.h
+++ b/Transceiver52M/USRPDevice.h
@@ -198,6 +198,7 @@
   inline double numberRead() { return samplesRead; }
   inline double numberWritten() { return samplesWritten; }
 
+  std::vector tx_paths, rx_paths;
 };
 
 #endif // _USRP_DEVICE_H_

-- 
To view, visit https://gerrit.osmocom.org/7091
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I28585947d5662cdd580a814cce54a5d9aa30eeb8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: rel-0.3.0
Gerrit-Owner: Pau Espin Pedrol 

[PATCH] osmo-trx[rel-0.3.0]: jenkins.sh: fix the download url if the qemu image wasn't setup

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/7092

jenkins.sh: fix the download url if the qemu image wasn't setup

Download the image from yesterday because linuxcontainers only contains the 
images of the last 3 days.

Change-Id: I75e270b7255c1cd7fca1674111b0f19fc7bba74f
(cherry picked from commit 28b8cc6283487bceace86fc9d7ee77bc9ba6123f)
---
M contrib/jenkins.sh
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/92/7092/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 11def5c..35a9627 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -36,7 +36,8 @@
 sed -i "s/setup_proc//g" 
"$ROOTFS/debootstrap/suite-script"
 mychroot /debootstrap/debootstrap 
--second-stage --verbose http://ftp.de.debian.org/debian/
 else
-wget -nc -q 
"https://uk.images.linuxcontainers.org/images/debian/stretch/armhf/default/20180114_22:42/rootfs.tar.xz;
+YESTERDAY=$(python -c 'import datetime ; 
print((datetime.datetime.now() - 
datetime.timedelta(days=1)).strftime("%Y%m%d"))')
+wget -nc -q 
"https://uk.images.linuxcontainers.org/images/debian/stretch/armhf/default/${YESTERDAY}_22:42/rootfs.tar.xz;
 tar -xf rootfs.tar.xz -C "$ROOTFS/" || true
 echo "nameserver 8.8.8.8" > 
"$ROOTFS/etc/resolv.conf"
 fi

-- 
To view, visit https://gerrit.osmocom.org/7092
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I75e270b7255c1cd7fca1674111b0f19fc7bba74f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: rel-0.3.0
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 

osmo-trx[master]: vty: Implement VTY cfg parsing for current parameters

[Vadim Yanitskiy]

Patch Set 5: Code-Review-1

Please add the configuration example(s) before this change.
At the moment, the "osmo-trx-limesdr.cfg" looks unrelated.

-- 
To view, visit https://gerrit.osmocom.org/6650
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie084c1b30b63f91c6e7640832ec1797d9e813832
Gerrit-PatchSet: 5
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-HasComments: No

[PATCH] osmo-bts[master]: common/l1sap.c: limit the minimal ToA for RACH bursts

[Vadim Yanitskiy]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/7089

to look at the new patch set (#3).

common/l1sap.c: limit the minimal ToA for RACH bursts

In general, RACH bursts should not arrive with negative offset.
Let's limit early signal arrival up to 2 symbols, otherwise it
is most likely noise, interference or a ghost.

TTCN-3 test case: I88545ed3aabd6da28a40599a8a77d1de477d
Change-Id: I662294fe3136cf7a259be13816a3e63f7db9a948
---
M src/common/l1sap.c
1 file changed, 12 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/89/7089/3

diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index ce68599..8380175 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1159,9 +1159,13 @@
return 0;
 }
 
+#define RACH_MIN_TOA256 -2 * 256
+
 static bool rach_pass_filter(struct ph_rach_ind_param *rach_ind,
struct gsm_bts_role_bts *btsb)
 {
+   int16_t toa256 = rach_ind->acc_delay_256bits;
+
/* Check for RACH exceeding BER threshold (ghost RACH) */
if (rach_ind->ber10k > btsb->max_ber10k_rach) {
LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring RACH request: "
@@ -1170,11 +1174,15 @@
return false;
}
 
-   /* Make sure that ToA (Timing of Arrival) is acceptable */
-   if (rach_ind->acc_delay > btsb->max_ta) {
+   /**
+* Make sure that ToA (Timing of Arrival) is acceptable.
+* We allow early arrival up to 2 symbols, and delay
+* according to maximal allowed Timing Advance value.
+*/
+   if (toa256 < RACH_MIN_TOA256 || toa256 > btsb->max_ta * 256) {
LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring RACH request: "
-   "ToA(%u) exceeds the maximal allowed TA(%u) value\n",
-   rach_ind->acc_delay, btsb->max_ta);
+   "ToA(%d) exceeds the allowed range (%d..%d)\n",
+   toa256, RACH_MIN_TOA256, btsb->max_ta * 256);
return false;
}
 

-- 
To view, visit https://gerrit.osmocom.org/7089
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I662294fe3136cf7a259be13816a3e63f7db9a948
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder

[PATCH] osmo-ttcn3-hacks[master]: bts/BTS_Tests.ttcn: update TC_rach_max_ta test case

[Vadim Yanitskiy]

Review at  https://gerrit.osmocom.org/7090

bts/BTS_Tests.ttcn: update TC_rach_max_ta test case

Since the I662294fe3136cf7a259be13816a3e63f7db9a948, OsmoBTS
should pass RACH requests with ToA > -2 symbol periods only.

We do allow early signal arrival up to 2 symbols, otherwise
it is most likely noise, interference or a ghost.

Change-Id: I88545ed3aabd6da28a40599a8a77d1de477d
---
M bts/BTS_Tests.ttcn
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/90/7090/1

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index e0e8ac4..e98a8ca 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -669,7 +669,9 @@
 
/* default max-ta is 63 (full range of GSM timing advance */
 
-   /* negative TA must not happen */
+   /* We allow early arrival up to 2 symbols */
+   f_rach_toffs(-1*256, true);
+   f_rach_toffs(-2*256, true);
f_rach_toffs(-10*256, false);
 
/* 0 / 32 / 63 bits is legal / permitted */

-- 
To view, visit https://gerrit.osmocom.org/7090
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I88545ed3aabd6da28a40599a8a77d1de477d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 

[PATCH] osmo-msc[master]: VLR: fix potential NULL dereference

[Neels Hofmeyr]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/6388

to look at the new patch set (#3).

VLR: fix potential NULL dereference

The vlr_subscr_get() can return NULL if its argument is NULL
(which isn't checked for) so before dereferencing it's result
we should check for it.

Change-Id: I13632908d0b67323202effa9dd6f29732a12cc91
---
M src/libmsc/gsm_04_08.c
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/88/6388/3

diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c
index 995bbf6..f87a4c6 100644
--- a/src/libmsc/gsm_04_08.c
+++ b/src/libmsc/gsm_04_08.c
@@ -3721,8 +3721,10 @@
 struct vlr_subscr *vsub)
 {
struct gsm_subscriber_connection *conn = msc_conn_ref;
+   OSMO_ASSERT(vsub);
OSMO_ASSERT(!conn->vsub);
conn->vsub = vlr_subscr_get(vsub);
+   OSMO_ASSERT(conn->vsub);
conn->vsub->cs.attached_via_ran = conn->via_ran;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/6388
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I13632908d0b67323202effa9dd6f29732a12cc91
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: neels 

osmo-msc[master]: VLR: fix potential NULL dereference

[Neels Hofmeyr]

Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/6388/1/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:

Line 3718:  conn->vsub = vlr_subscr_get(vsub);
> a NULL return is only possible if 'vsub' is NULL.  I don't think this is va
agreed


-- 
To view, visit https://gerrit.osmocom.org/6388
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13632908d0b67323202effa9dd6f29732a12cc91
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: neels 
Gerrit-HasComments: Yes

osmo-gsm-tester[master]: ms: Add a main function to start all of it

[Pau Espin Pedrol]

Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/6919
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58c938500a067eebb213750e56d8bf4d8af43df2
Gerrit-PatchSet: 5
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: neels 
Gerrit-HasComments: No

osmo-gsm-tester[master]: ms: Add a first test to use all parts of the system

[Pau Espin Pedrol]

Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/6918
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3277ed0f0f9ee734569bedd4752564eb68c9cfd
Gerrit-PatchSet: 5
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: neels 
Gerrit-HasComments: No

osmo-gsm-tester[master]: ms: Create a starter for virtphy and mobile application

[Pau Espin Pedrol]

Patch Set 5:

(3 comments)

https://gerrit.osmocom.org/#/c/6917/5/src/osmo_ms_driver/starter.py
File src/osmo_ms_driver/starter.py:

Line 58: import time
What about moving the import to the top with the other ones?


Line 88: 
Extra line, can be removed


Line 107: def start_mobile(self, loop):
Can now be called start(), as it's already in the mobile class.


-- 
To view, visit https://gerrit.osmocom.org/6917
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c6d742842d7f3e0a1858436ef3f8634d8c0582d
Gerrit-PatchSet: 5
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: neels 
Gerrit-HasComments: Yes

osmo-gsm-tester[master]: ms: Create template for the osmocom-bb mobile application

[Pau Espin Pedrol]

Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/6916
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9296f42edfab57762f8dd317d63231298cda5430
Gerrit-PatchSet: 5
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: neels 
Gerrit-HasComments: No

osmo-gsm-tester[master]: ms: Lua part of location update testing

[Pau Espin Pedrol]

Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/6232
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica5aa0c2f86d0e5d8a2bc4dc0652de18762dd156
Gerrit-PatchSet: 6
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-HasComments: No

osmo-gsm-tester[master]: ms: Add lua script support utilities

[Pau Espin Pedrol]

Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/6915
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43ae84a944c7f33e41d5de0880d4aaab3378809b
Gerrit-PatchSet: 5
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: neels 
Gerrit-HasComments: No

osmo-gsm-tester[master]: ms: Create an event server to handle Unix datagram messages

[Pau Espin Pedrol]

Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/6914
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida97c570e8e741410f2dba4a231a8058ca96da25
Gerrit-PatchSet: 4
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: neels 
Gerrit-HasComments: No

osmo-gsm-tester[master]: ms: Create a simple epoll (or kqueue) based event loop

[Pau Espin Pedrol]

Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/6913
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea06f33870cab9f21e9a1a1feb9758467343dd29
Gerrit-PatchSet: 4
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: neels 
Gerrit-HasComments: No