Build failure of network:osmocom:nightly/osmo-bsc in Debian_9.0/armv7l

2018-03-20 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/armv7l

Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  207s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  207s] make[3]: Entering directory '/usr/src/packages/BUILD'
[  207s] make[4]: Entering directory '/usr/src/packages/BUILD'
[  207s] make[4]: Nothing to be done for 'install-exec-am'.
[  207s] make[4]: Nothing to be done for 'install-data-am'.
[  207s] make[4]: Leaving directory '/usr/src/packages/BUILD'
[  207s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  207s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  207s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  207s]dh_install
[  207s] dh_install: Cannot find (any matches for) "usr/bin/ipaccess-config" 
(tried in "." and "debian/tmp")
[  207s] dh_install: osmo-bsc-ipaccess-utils missing files: 
usr/bin/ipaccess-config
[  207s] dh_install: Cannot find (any matches for) "usr/bin/bs11_config" (tried 
in "." and "debian/tmp")
[  207s] dh_install: osmo-bsc-bs11-utils missing files: usr/bin/bs11_config
[  207s] dh_install: missing files, aborting
[  207s] debian/rules:45: recipe for target 'binary' failed
[  207s] make: *** [binary] Error 2
[  207s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  207s] 
[  207s] armbuild21 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
22:31:53 UTC 2018.
[  207s] 
[  207s] ### VM INTERACTION START ###
[  210s] [  199.684016] SysRq : Power Off
[  210s] [  199.685229] reboot: Power down
[  210s] qemu-system-aarch64: Failed to unlink socket 
/var/cache/obs/worker/root_2/root.monitor: Permission denied
[  211s] ### VM INTERACTION END ###
[  211s] 
[  211s] armbuild21 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
22:31:57 UTC 2018.
[  211s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)


osmo-ttcn3-hacks[master]: Move make artifacts to build subdir

2018-03-20 Thread Pau Espin Pedrol

Patch Set 4:

Ok It looks fine now. I also tested I can build the c++ code correctly with the 
makefile and that the symlinks to the binary files in build/ are fine, and I 
can also run it with start_suite.sh.

The question regarding the MAIN file I did before still remains though.

-- 
To view, visit https://gerrit.osmocom.org/7405
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9ca176869ce6b80ccf2b2fff6554b121e1aa85c
Gerrit-PatchSet: 4
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No


[PATCH] osmo-ttcn3-hacks[master]: Move make artifacts to build subdir

2018-03-20 Thread Pau Espin Pedrol
Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/7405

to look at the new patch set (#4).

Move make artifacts to build subdir

Avoid having 50-100 symlinks and .o objects in the same dir where the
source/cfg files are. Move them instead to a ./build subdir.

A new symlink FooSuite/build/TestBinary -> FooSuite/TestBinary is added
to keep compatibility with docker-playground containers.

Change-Id: Id9ca176869ce6b80ccf2b2fff6554b121e1aa85c
---
M .gitignore
M Makefile
M bsc-nat/gen_links.sh
M bsc-nat/regen_makefile.sh
M bsc/gen_links.sh
M bsc/regen_makefile.sh
M bts/gen_links.sh
M bts/regen_makefile.sh
M gen_links.sh.inc
M ggsn_tests/gen_links.sh
M ggsn_tests/regen_makefile.sh
M hlr/gen_links.sh
M hlr/regen_makefile.sh
M lapdm/gen_links.sh
M lapdm/regen_makefile.sh
M mgw/gen_links.sh
M mgw/regen_makefile.sh
M msc/gen_links.sh
M msc/regen_makefile.sh
M pcu/gen_links.sh
M pcu/regen_makefile.sh
M selftest/gen_links.sh
M selftest/regen_makefile.sh
M sgsn/gen_links.sh
M sgsn/regen_makefile.sh
M start-testsuite.sh
M sysinfo/gen_links.sh
M sysinfo/regen_makefile.sh
28 files changed, 381 insertions(+), 275 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/05/7405/4

diff --git a/.gitignore b/.gitignore
index bf5baa0..0ca978f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -14,3 +14,4 @@
 */Makefile
 !bin/Makefile
 !deps/Makefile
+*/build
diff --git a/Makefile b/Makefile
index 0defc31..bf2d70c 100644
--- a/Makefile
+++ b/Makefile
@@ -29,29 +29,29 @@
 all: $(foreach dir,$(SUBDIRS),$(dir)/all)
 
 define DIR_Makefile_template
-$(1)/Makefile:
+$(1)/build/Makefile:
(cd $(1) && ./gen_links.sh && ./regen_makefile.sh)
 endef
 
 define DIR_compile_template
 .PHONY: $(1)/compile
-$(1)/compile: deps $(1)/Makefile
-   $(MAKE) -C $(1) compile
+$(1)/compile: deps $(1)/build/Makefile
+   $(MAKE) -C $(1)/build compile
 endef
 
 define DIR_clean_template
 .PHONY: $(1)/clean
-$(1)/clean: $(1)/Makefile
-   $(MAKE) -C $(1) clean
-   (cd $(1) && ../rmlinks.sh && rm Makefile)
+$(1)/clean: $(1)/build/Makefile
+   $(MAKE) -C $(1)/build clean
+   (cd $(1)/build && ../../rmlinks.sh && rm Makefile)
 endef
 
 define DIR_all_template
 $(1): $(1)/all
 .PHONY: $(1)/all
-$(1)/all: deps $(1)/Makefile
-   $(MAKE) -C $(1) compile
-   $(MAKE) $(PARALLEL_MAKE) -C $(1)
+$(1)/all: deps $(1)/build/Makefile
+   $(MAKE) -C $(1)/build compile
+   $(MAKE) $(PARALLEL_MAKE) -C $(1)/build
 endef
 
 $(foreach dir,$(SUBDIRS), \
diff --git a/bsc-nat/gen_links.sh b/bsc-nat/gen_links.sh
index 453d8ca..4d83183 100755
--- a/bsc-nat/gen_links.sh
+++ b/bsc-nat/gen_links.sh
@@ -1,53 +1,56 @@
 #!/bin/sh
 
-BASEDIR=../deps
+BASEDIR=$(readlink -f ..)
+DSTDIR=./build
 
-. ../gen_links.sh.inc
+. $BASEDIR/gen_links.sh.inc
 
-#DIR=$BASEDIR/titan.TestPorts.UNIX_DOMAIN_SOCKETasp/src
+mkdir -p $DSTDIR
+
+#DIR=$BASEDIR/deps/titan.TestPorts.UNIX_DOMAIN_SOCKETasp/src
 #FILES="UD_PT.cc  UD_PT.hh  UD_PortType.ttcn  UD_Types.ttcn"
-#gen_links $DIR $FILES
+#gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.Libraries.TCCUsefulFunctions/src
+DIR=$BASEDIR/deps/titan.Libraries.TCCUsefulFunctions/src
 FILES="TCCInterface_Functions.ttcn TCCConversion_Functions.ttcn 
TCCConversion.cc TCCInterface.cc TCCInterface_ip.h SDP_EncDec.cc"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.TestPorts.Common_Components.Socket-API/src
+DIR=$BASEDIR/deps/titan.TestPorts.Common_Components.Socket-API/src
 FILES="Socket_API_Definitions.ttcn"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.TestPorts.IPL4asp/src
+DIR=$BASEDIR/deps/titan.TestPorts.IPL4asp/src
 FILES="IPL4asp_Functions.ttcn  IPL4asp_PT.cc  IPL4asp_PT.hh 
IPL4asp_PortType.ttcn  IPL4asp_Types.ttcn  IPL4asp_discovery.cc 
IPL4asp_protocol_L234.hh"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
 # required by SCCP Emulation
-DIR=$BASEDIR/titan.TestPorts.MTP3asp/src
+DIR=$BASEDIR/deps/titan.TestPorts.MTP3asp/src
 FILES="MTP3asp_PortType.ttcn  MTP3asp_Types.ttcn"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.ProtocolEmulations.SCCP/src
+DIR=$BASEDIR/deps/titan.ProtocolEmulations.SCCP/src
 FILES="SCCP_Emulation.ttcn  SCCP_EncDec.cc  SCCP_Mapping.ttcnpp  
SCCP_Types.ttcn  SCCPasp_Types.ttcn"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.ProtocolModules.BSSMAP_v11.2.0/src
+DIR=$BASEDIR/deps/titan.ProtocolModules.BSSMAP_v11.2.0/src
 FILES="BSSAP_Types.ttcn"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.ProtocolModules.MobileL3_v13.4.0/src
+DIR=$BASEDIR/deps/titan.ProtocolModules.MobileL3_v13.4.0/src
 FILES="MobileL3_CC_Types.ttcn MobileL3_CommonIE_Types.ttcn 
MobileL3_GMM_SM_Types.ttcn MobileL3_MM_Types.ttcn MobileL3_RRM_Types.ttcn 
MobileL3_SMS_Types.ttcn MobileL3_SS_Types.ttcn MobileL3_Types.ttcn"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 

[PATCH] osmo-ttcn3-hacks[master]: Move make artifacts to build subdir

2018-03-20 Thread Pau Espin Pedrol
Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/7405

to look at the new patch set (#3).

Move make artifacts to build subdir

Avoid having 50-100 symlinks and .o objects in the same dir where the
source/cfg files are. Move them instead to a ./build subdir.

A new symlink FooSuite/build/TestBinary -> FooSuite/TestBinary is added
to keep compatibility with docker-playground containers.

Change-Id: Id9ca176869ce6b80ccf2b2fff6554b121e1aa85c
---
M .gitignore
M Makefile
M bsc-nat/gen_links.sh
M bsc-nat/regen_makefile.sh
M bsc/gen_links.sh
M bsc/regen_makefile.sh
M bts/gen_links.sh
M bts/regen_makefile.sh
M gen_links.sh.inc
M ggsn_tests/gen_links.sh
M ggsn_tests/regen_makefile.sh
M hlr/gen_links.sh
M hlr/regen_makefile.sh
M lapdm/gen_links.sh
M lapdm/regen_makefile.sh
M mgw/gen_links.sh
M mgw/regen_makefile.sh
M msc/gen_links.sh
M msc/regen_makefile.sh
M pcu/gen_links.sh
M pcu/regen_makefile.sh
M selftest/gen_links.sh
M selftest/regen_makefile.sh
M sgsn/gen_links.sh
M sgsn/regen_makefile.sh
M start-testsuite.sh
M sysinfo/gen_links.sh
M sysinfo/regen_makefile.sh
28 files changed, 380 insertions(+), 274 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/05/7405/3

diff --git a/.gitignore b/.gitignore
index bf5baa0..0ca978f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -14,3 +14,4 @@
 */Makefile
 !bin/Makefile
 !deps/Makefile
+*/build
diff --git a/Makefile b/Makefile
index 0defc31..9304d4c 100644
--- a/Makefile
+++ b/Makefile
@@ -29,29 +29,29 @@
 all: $(foreach dir,$(SUBDIRS),$(dir)/all)
 
 define DIR_Makefile_template
-$(1)/Makefile:
+$(1)/build/Makefile:
(cd $(1) && ./gen_links.sh && ./regen_makefile.sh)
 endef
 
 define DIR_compile_template
 .PHONY: $(1)/compile
-$(1)/compile: deps $(1)/Makefile
-   $(MAKE) -C $(1) compile
+$(1)/compile: deps $(1)/build/Makefile
+   $(MAKE) -C $(1)/build compile
 endef
 
 define DIR_clean_template
 .PHONY: $(1)/clean
 $(1)/clean: $(1)/Makefile
-   $(MAKE) -C $(1) clean
-   (cd $(1) && ../rmlinks.sh && rm Makefile)
+   $(MAKE) -C $(1)/build clean
+   (cd $(1)/build && ../../rmlinks.sh && rm Makefile)
 endef
 
 define DIR_all_template
 $(1): $(1)/all
 .PHONY: $(1)/all
-$(1)/all: deps $(1)/Makefile
-   $(MAKE) -C $(1) compile
-   $(MAKE) $(PARALLEL_MAKE) -C $(1)
+$(1)/all: deps $(1)/build/Makefile
+   $(MAKE) -C $(1)/build compile
+   $(MAKE) $(PARALLEL_MAKE) -C $(1)/build
 endef
 
 $(foreach dir,$(SUBDIRS), \
diff --git a/bsc-nat/gen_links.sh b/bsc-nat/gen_links.sh
index 453d8ca..4d83183 100755
--- a/bsc-nat/gen_links.sh
+++ b/bsc-nat/gen_links.sh
@@ -1,53 +1,56 @@
 #!/bin/sh
 
-BASEDIR=../deps
+BASEDIR=$(readlink -f ..)
+DSTDIR=./build
 
-. ../gen_links.sh.inc
+. $BASEDIR/gen_links.sh.inc
 
-#DIR=$BASEDIR/titan.TestPorts.UNIX_DOMAIN_SOCKETasp/src
+mkdir -p $DSTDIR
+
+#DIR=$BASEDIR/deps/titan.TestPorts.UNIX_DOMAIN_SOCKETasp/src
 #FILES="UD_PT.cc  UD_PT.hh  UD_PortType.ttcn  UD_Types.ttcn"
-#gen_links $DIR $FILES
+#gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.Libraries.TCCUsefulFunctions/src
+DIR=$BASEDIR/deps/titan.Libraries.TCCUsefulFunctions/src
 FILES="TCCInterface_Functions.ttcn TCCConversion_Functions.ttcn 
TCCConversion.cc TCCInterface.cc TCCInterface_ip.h SDP_EncDec.cc"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.TestPorts.Common_Components.Socket-API/src
+DIR=$BASEDIR/deps/titan.TestPorts.Common_Components.Socket-API/src
 FILES="Socket_API_Definitions.ttcn"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.TestPorts.IPL4asp/src
+DIR=$BASEDIR/deps/titan.TestPorts.IPL4asp/src
 FILES="IPL4asp_Functions.ttcn  IPL4asp_PT.cc  IPL4asp_PT.hh 
IPL4asp_PortType.ttcn  IPL4asp_Types.ttcn  IPL4asp_discovery.cc 
IPL4asp_protocol_L234.hh"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
 # required by SCCP Emulation
-DIR=$BASEDIR/titan.TestPorts.MTP3asp/src
+DIR=$BASEDIR/deps/titan.TestPorts.MTP3asp/src
 FILES="MTP3asp_PortType.ttcn  MTP3asp_Types.ttcn"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.ProtocolEmulations.SCCP/src
+DIR=$BASEDIR/deps/titan.ProtocolEmulations.SCCP/src
 FILES="SCCP_Emulation.ttcn  SCCP_EncDec.cc  SCCP_Mapping.ttcnpp  
SCCP_Types.ttcn  SCCPasp_Types.ttcn"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.ProtocolModules.BSSMAP_v11.2.0/src
+DIR=$BASEDIR/deps/titan.ProtocolModules.BSSMAP_v11.2.0/src
 FILES="BSSAP_Types.ttcn"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.ProtocolModules.MobileL3_v13.4.0/src
+DIR=$BASEDIR/deps/titan.ProtocolModules.MobileL3_v13.4.0/src
 FILES="MobileL3_CC_Types.ttcn MobileL3_CommonIE_Types.ttcn 
MobileL3_GMM_SM_Types.ttcn MobileL3_MM_Types.ttcn MobileL3_RRM_Types.ttcn 
MobileL3_SMS_Types.ttcn MobileL3_SS_Types.ttcn MobileL3_Types.ttcn"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.ProtocolModules.SDP/src

[PATCH] osmo-ttcn3-hacks[master]: Move make artifacts to build subdir

2018-03-20 Thread Pau Espin Pedrol
Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/7405

to look at the new patch set (#2).

Move make artifacts to build subdir

Avoid having 50-100 symlinks and .o objects in the same dir where the
source/cfg files are. Move them instead to a ./build subdir.

A new symlink FooSuite/build/TestBinary -> FooSuite/TestBinary is added
to keep compatibility with docker-playground containers.

Change-Id: Id9ca176869ce6b80ccf2b2fff6554b121e1aa85c
---
M .gitignore
M Makefile
M bsc-nat/gen_links.sh
M bsc-nat/regen_makefile.sh
M bsc/gen_links.sh
M bsc/regen_makefile.sh
M bts/gen_links.sh
M bts/regen_makefile.sh
M gen_links.sh.inc
M ggsn_tests/gen_links.sh
M ggsn_tests/regen_makefile.sh
M hlr/gen_links.sh
M hlr/regen_makefile.sh
M lapdm/gen_links.sh
M lapdm/regen_makefile.sh
M mgw/gen_links.sh
M mgw/regen_makefile.sh
M msc/gen_links.sh
M msc/regen_makefile.sh
M pcu/gen_links.sh
M pcu/regen_makefile.sh
M selftest/gen_links.sh
M selftest/regen_makefile.sh
M sgsn/gen_links.sh
M sgsn/regen_makefile.sh
M start-testsuite.sh
M sysinfo/gen_links.sh
M sysinfo/regen_makefile.sh
28 files changed, 377 insertions(+), 271 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/05/7405/2

diff --git a/.gitignore b/.gitignore
index bf5baa0..0ca978f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -14,3 +14,4 @@
 */Makefile
 !bin/Makefile
 !deps/Makefile
+*/build
diff --git a/Makefile b/Makefile
index 0defc31..e8e8286 100644
--- a/Makefile
+++ b/Makefile
@@ -36,22 +36,22 @@
 define DIR_compile_template
 .PHONY: $(1)/compile
 $(1)/compile: deps $(1)/Makefile
-   $(MAKE) -C $(1) compile
+   $(MAKE) -C $(1)/build compile
 endef
 
 define DIR_clean_template
 .PHONY: $(1)/clean
 $(1)/clean: $(1)/Makefile
-   $(MAKE) -C $(1) clean
-   (cd $(1) && ../rmlinks.sh && rm Makefile)
+   $(MAKE) -C $(1)/build clean
+   (cd $(1)/build && ../../rmlinks.sh && rm Makefile)
 endef
 
 define DIR_all_template
 $(1): $(1)/all
 .PHONY: $(1)/all
 $(1)/all: deps $(1)/Makefile
-   $(MAKE) -C $(1) compile
-   $(MAKE) $(PARALLEL_MAKE) -C $(1)
+   $(MAKE) -C $(1)/build compile
+   $(MAKE) $(PARALLEL_MAKE) -C $(1)/build
 endef
 
 $(foreach dir,$(SUBDIRS), \
diff --git a/bsc-nat/gen_links.sh b/bsc-nat/gen_links.sh
index 453d8ca..4d83183 100755
--- a/bsc-nat/gen_links.sh
+++ b/bsc-nat/gen_links.sh
@@ -1,53 +1,56 @@
 #!/bin/sh
 
-BASEDIR=../deps
+BASEDIR=$(readlink -f ..)
+DSTDIR=./build
 
-. ../gen_links.sh.inc
+. $BASEDIR/gen_links.sh.inc
 
-#DIR=$BASEDIR/titan.TestPorts.UNIX_DOMAIN_SOCKETasp/src
+mkdir -p $DSTDIR
+
+#DIR=$BASEDIR/deps/titan.TestPorts.UNIX_DOMAIN_SOCKETasp/src
 #FILES="UD_PT.cc  UD_PT.hh  UD_PortType.ttcn  UD_Types.ttcn"
-#gen_links $DIR $FILES
+#gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.Libraries.TCCUsefulFunctions/src
+DIR=$BASEDIR/deps/titan.Libraries.TCCUsefulFunctions/src
 FILES="TCCInterface_Functions.ttcn TCCConversion_Functions.ttcn 
TCCConversion.cc TCCInterface.cc TCCInterface_ip.h SDP_EncDec.cc"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.TestPorts.Common_Components.Socket-API/src
+DIR=$BASEDIR/deps/titan.TestPorts.Common_Components.Socket-API/src
 FILES="Socket_API_Definitions.ttcn"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.TestPorts.IPL4asp/src
+DIR=$BASEDIR/deps/titan.TestPorts.IPL4asp/src
 FILES="IPL4asp_Functions.ttcn  IPL4asp_PT.cc  IPL4asp_PT.hh 
IPL4asp_PortType.ttcn  IPL4asp_Types.ttcn  IPL4asp_discovery.cc 
IPL4asp_protocol_L234.hh"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
 # required by SCCP Emulation
-DIR=$BASEDIR/titan.TestPorts.MTP3asp/src
+DIR=$BASEDIR/deps/titan.TestPorts.MTP3asp/src
 FILES="MTP3asp_PortType.ttcn  MTP3asp_Types.ttcn"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.ProtocolEmulations.SCCP/src
+DIR=$BASEDIR/deps/titan.ProtocolEmulations.SCCP/src
 FILES="SCCP_Emulation.ttcn  SCCP_EncDec.cc  SCCP_Mapping.ttcnpp  
SCCP_Types.ttcn  SCCPasp_Types.ttcn"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.ProtocolModules.BSSMAP_v11.2.0/src
+DIR=$BASEDIR/deps/titan.ProtocolModules.BSSMAP_v11.2.0/src
 FILES="BSSAP_Types.ttcn"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.ProtocolModules.MobileL3_v13.4.0/src
+DIR=$BASEDIR/deps/titan.ProtocolModules.MobileL3_v13.4.0/src
 FILES="MobileL3_CC_Types.ttcn MobileL3_CommonIE_Types.ttcn 
MobileL3_GMM_SM_Types.ttcn MobileL3_MM_Types.ttcn MobileL3_RRM_Types.ttcn 
MobileL3_SMS_Types.ttcn MobileL3_SS_Types.ttcn MobileL3_Types.ttcn"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.ProtocolModules.SDP/src
+DIR=$BASEDIR/deps/titan.ProtocolModules.SDP/src
 FILES="SDP_EncDec.cc SDP_Types.ttcn SDP_parse_.tab.c SDP_parse_.tab.h 
SDP_parse_parser.h SDP_parser.l
 SDP_parser.y lex.SDP_parse_.c"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 

[PATCH] osmo-ttcn3-hacks[master]: log_merge.sh: Fix removal of log files

2018-03-20 Thread Pau Espin Pedrol

Review at  https://gerrit.osmocom.org/7408

log_merge.sh: Fix removal of log files

Files are not being expanded and fails:

Removing Input log files !!!
rm: cannot remove 'GGSN_Tests*.log': No such file or directory

Change-Id: I74e1f00c5e2b41668ebf2060f547fcc01212956d
---
M log_merge.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/08/7408/1

diff --git a/log_merge.sh b/log_merge.sh
index dee9cc2..d3c50f7 100755
--- a/log_merge.sh
+++ b/log_merge.sh
@@ -26,5 +26,5 @@
 
 if [ "$2" = "--rm" ]; then
echo "Removing Input log files !!!"
-   rm "$LOG_FILES"
+   rm $LOG_FILES
 fi

-- 
To view, visit https://gerrit.osmocom.org/7408
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I74e1f00c5e2b41668ebf2060f547fcc01212956d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 


Build failure of network:osmocom:nightly/osmo-bsc in Debian_9.0/aarch64

2018-03-20 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/aarch64

Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/aarch64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  583s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  583s] make[3]: Entering directory '/usr/src/packages/BUILD'
[  584s] make[4]: Entering directory '/usr/src/packages/BUILD'
[  584s] make[4]: Nothing to be done for 'install-exec-am'.
[  584s] make[4]: Nothing to be done for 'install-data-am'.
[  584s] make[4]: Leaving directory '/usr/src/packages/BUILD'
[  584s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  584s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  584s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  584s]dh_install
[  584s] dh_install: Cannot find (any matches for) "usr/bin/ipaccess-config" 
(tried in "." and "debian/tmp")
[  584s] dh_install: osmo-bsc-ipaccess-utils missing files: 
usr/bin/ipaccess-config
[  584s] dh_install: Cannot find (any matches for) "usr/bin/bs11_config" (tried 
in "." and "debian/tmp")
[  584s] dh_install: osmo-bsc-bs11-utils missing files: usr/bin/bs11_config
[  584s] dh_install: missing files, aborting
[  584s] debian/rules:45: recipe for target 'binary' failed
[  584s] make: *** [binary] Error 2
[  584s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  584s] 
[  584s] obs-arm-2 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:37:01 UTC 2018.
[  584s] 
[  584s] ### VM INTERACTION START ###
[  587s] [  533.398312] sysrq: SysRq : Power Off
[  587s] [  533.416315] reboot: Power down
[  587s] qemu-system-aarch64: Failed to unlink socket 
/var/cache/obs/worker/root_16/root.monitor: Permission denied
[  587s] ### VM INTERACTION END ###
[  587s] 
[  588s] obs-arm-2 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:37:05 UTC 2018.
[  588s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_17.04/x86_64

2018-03-20 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_17.04/x86_64

Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_17.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[   72s] make[4]: Leaving directory '/usr/src/packages/BUILD/tests'
[   72s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[   72s] make[3]: Entering directory '/usr/src/packages/BUILD'
[   72s] make[4]: Entering directory '/usr/src/packages/BUILD'
[   72s] make[4]: Nothing to be done for 'install-exec-am'.
[   72s] make[4]: Nothing to be done for 'install-data-am'.
[   72s] make[4]: Leaving directory '/usr/src/packages/BUILD'
[   72s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[   72s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   72s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   72s]dh_install
[   72s] dh_install: Cannot find (any matches for) "usr/bin/ipaccess-config" 
(tried in "." and "debian/tmp")
[   72s] dh_install: osmo-bsc-ipaccess-utils missing files: 
usr/bin/ipaccess-config
[   72s] dh_install: Cannot find (any matches for) "usr/bin/bs11_config" (tried 
in "." and "debian/tmp")
[   72s] dh_install: osmo-bsc-bs11-utils missing files: usr/bin/bs11_config
[   72s] dh_install: missing files, aborting
[   72s] debian/rules:45: recipe for target 'binary' failed
[   72s] make: *** [binary] Error 2
[   72s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[   72s] 
[   72s] build75 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:14:57 UTC 2018.
[   72s] 
[   72s] ### VM INTERACTION START ###
[   75s] [   70.563524] reboot: Power down
[   76s] qemu-system-x86_64: Failed to unlink socket 
/var/cache/obs/worker/root_2/root.monitor: Permission denied
[   76s] ### VM INTERACTION END ###
[   76s] 
[   76s] build75 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:15:01 UTC 2018.
[   76s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_16.10/x86_64

2018-03-20 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.10/x86_64

Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  166s] make[4]: Leaving directory '/usr/src/packages/BUILD/tests'
[  166s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  166s] make[3]: Entering directory '/usr/src/packages/BUILD'
[  166s] make[4]: Entering directory '/usr/src/packages/BUILD'
[  166s] make[4]: Nothing to be done for 'install-exec-am'.
[  166s] make[4]: Nothing to be done for 'install-data-am'.
[  166s] make[4]: Leaving directory '/usr/src/packages/BUILD'
[  166s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  166s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  166s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  166s]dh_install
[  166s] dh_install: Cannot find (any matches for) "usr/bin/ipaccess-config" 
(tried in "." and "debian/tmp")
[  166s] dh_install: osmo-bsc-ipaccess-utils missing files: 
usr/bin/ipaccess-config
[  166s] dh_install: Cannot find (any matches for) "usr/bin/bs11_config" (tried 
in "." and "debian/tmp")
[  166s] dh_install: osmo-bsc-bs11-utils missing files: usr/bin/bs11_config
[  166s] dh_install: missing files, aborting
[  166s] debian/rules:45: recipe for target 'binary' failed
[  166s] make: *** [binary] Error 2
[  166s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  166s] 
[  166s] cloud123 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:12:08 UTC 2018.
[  166s] 
[  166s] ### VM INTERACTION START ###
[  170s] [  154.255971] reboot: Power down
[  171s] qemu-system-x86_64: Failed to unlink socket 
/var/cache/obs/worker/root_2/root.monitor: Permission denied
[  171s] ### VM INTERACTION END ###
[  171s] 
[  171s] cloud123 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:12:13 UTC 2018.
[  171s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_16.04/x86_64

2018-03-20 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  132s] make[5]: Nothing to be done for 'install-data-am'.
[  132s] make[5]: Leaving directory '/usr/src/packages/BUILD/tests'
[  132s] make[4]: Leaving directory '/usr/src/packages/BUILD/tests'
[  132s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  132s] make[3]: Entering directory '/usr/src/packages/BUILD'
[  132s] make[4]: Entering directory '/usr/src/packages/BUILD'
[  132s] make[4]: Nothing to be done for 'install-exec-am'.
[  132s] make[4]: Nothing to be done for 'install-data-am'.
[  132s] make[4]: Leaving directory '/usr/src/packages/BUILD'
[  132s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  132s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  132s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  132s]dh_install
[  132s] dh_install: osmo-bsc-ipaccess-utils missing files: 
usr/bin/ipaccess-config
[  132s] dh_install: osmo-bsc-bs11-utils missing files: usr/bin/bs11_config
[  132s] dh_install: missing files, aborting
[  132s] debian/rules:45: recipe for target 'binary' failed
[  132s] make: *** [binary] Error 2
[  132s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  132s] 
[  132s] lamb72 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:10:35 UTC 2018.
[  132s] 
[  132s] ### VM INTERACTION START ###
[  135s] [  127.811294] reboot: Power down
[  135s] qemu-system-x86_64: Failed to unlink socket 
/var/cache/obs/worker/root_2/root.monitor: Permission denied
[  135s] ### VM INTERACTION END ###
[  135s] 
[  135s] lamb72 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:10:38 UTC 2018.
[  135s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_16.04/i586

2018-03-20 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.04/i586

Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  143s] make[5]: Nothing to be done for 'install-data-am'.
[  143s] make[5]: Leaving directory '/usr/src/packages/BUILD/tests'
[  143s] make[4]: Leaving directory '/usr/src/packages/BUILD/tests'
[  143s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  143s] make[3]: Entering directory '/usr/src/packages/BUILD'
[  143s] make[4]: Entering directory '/usr/src/packages/BUILD'
[  143s] make[4]: Nothing to be done for 'install-exec-am'.
[  143s] make[4]: Nothing to be done for 'install-data-am'.
[  143s] make[4]: Leaving directory '/usr/src/packages/BUILD'
[  143s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  143s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  143s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  143s]dh_install
[  143s] dh_install: osmo-bsc-ipaccess-utils missing files: 
usr/bin/ipaccess-config
[  143s] dh_install: osmo-bsc-bs11-utils missing files: usr/bin/bs11_config
[  143s] dh_install: missing files, aborting
[  143s] debian/rules:45: recipe for target 'binary' failed
[  143s] make: *** [binary] Error 2
[  143s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  143s] 
[  143s] lamb70 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:11:04 UTC 2018.
[  143s] 
[  143s] ### VM INTERACTION START ###
[  146s] [  140.272595] reboot: Power down
[  146s] qemu-system-x86_64: Failed to unlink socket 
/var/cache/obs/worker/root_1/root.monitor: Permission denied
[  146s] ### VM INTERACTION END ###
[  146s] 
[  146s] lamb70 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:11:07 UTC 2018.
[  146s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_17.04/i586

2018-03-20 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_17.04/i586

Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_17.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  173s] make[4]: Leaving directory '/usr/src/packages/BUILD/tests'
[  173s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  173s] make[3]: Entering directory '/usr/src/packages/BUILD'
[  173s] make[4]: Entering directory '/usr/src/packages/BUILD'
[  173s] make[4]: Nothing to be done for 'install-exec-am'.
[  173s] make[4]: Nothing to be done for 'install-data-am'.
[  173s] make[4]: Leaving directory '/usr/src/packages/BUILD'
[  173s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  173s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  173s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  173s]dh_install
[  173s] dh_install: Cannot find (any matches for) "usr/bin/ipaccess-config" 
(tried in "." and "debian/tmp")
[  173s] dh_install: osmo-bsc-ipaccess-utils missing files: 
usr/bin/ipaccess-config
[  173s] dh_install: Cannot find (any matches for) "usr/bin/bs11_config" (tried 
in "." and "debian/tmp")
[  173s] dh_install: osmo-bsc-bs11-utils missing files: usr/bin/bs11_config
[  173s] dh_install: missing files, aborting
[  173s] debian/rules:45: recipe for target 'binary' failed
[  173s] make: *** [binary] Error 2
[  173s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  173s] 
[  173s] wildcard3 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:09:42 UTC 2018.
[  173s] 
[  173s] ### VM INTERACTION START ###
[  176s] [  138.780428] reboot: Power down
[  218s] qemu-system-x86_64: Failed to unlink socket 
/var/cache/obs/worker/root_7/root.monitor: Permission denied
[  218s] ### VM INTERACTION END ###
[  218s] 
[  218s] wildcard3 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:10:28 UTC 2018.
[  218s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/osmo-bsc in Debian_9.0/x86_64

2018-03-20 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/x86_64

Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  151s] make[4]: Leaving directory '/usr/src/packages/BUILD/tests'
[  151s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  151s] make[3]: Entering directory '/usr/src/packages/BUILD'
[  151s] make[4]: Entering directory '/usr/src/packages/BUILD'
[  151s] make[4]: Nothing to be done for 'install-exec-am'.
[  151s] make[4]: Nothing to be done for 'install-data-am'.
[  151s] make[4]: Leaving directory '/usr/src/packages/BUILD'
[  151s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  151s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  151s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  151s]dh_install
[  151s] dh_install: Cannot find (any matches for) "usr/bin/ipaccess-config" 
(tried in "." and "debian/tmp")
[  151s] dh_install: osmo-bsc-ipaccess-utils missing files: 
usr/bin/ipaccess-config
[  151s] dh_install: Cannot find (any matches for) "usr/bin/bs11_config" (tried 
in "." and "debian/tmp")
[  151s] dh_install: osmo-bsc-bs11-utils missing files: usr/bin/bs11_config
[  151s] dh_install: missing files, aborting
[  151s] debian/rules:45: recipe for target 'binary' failed
[  151s] make: *** [binary] Error 2
[  151s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  151s] 
[  151s] lamb58 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:09:02 UTC 2018.
[  151s] 
[  151s] ### VM INTERACTION START ###
[  155s] [  146.545254] reboot: Power down
[  155s] qemu-system-x86_64: Failed to unlink socket 
/var/cache/obs/worker/root_12/root.monitor: Permission denied
[  155s] ### VM INTERACTION END ###
[  155s] 
[  155s] lamb58 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:09:06 UTC 2018.
[  155s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/osmo-bsc in Debian_8.0/x86_64

2018-03-20 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_8.0/x86_64

Package network:osmocom:nightly/osmo-bsc failed to build in Debian_8.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  203s] make[5]: Nothing to be done for 'install-data-am'.
[  203s] make[5]: Leaving directory '/usr/src/packages/BUILD/tests'
[  203s] make[4]: Leaving directory '/usr/src/packages/BUILD/tests'
[  203s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  203s] make[3]: Entering directory '/usr/src/packages/BUILD'
[  203s] make[4]: Entering directory '/usr/src/packages/BUILD'
[  203s] make[4]: Nothing to be done for 'install-exec-am'.
[  203s] make[4]: Nothing to be done for 'install-data-am'.
[  203s] make[4]: Leaving directory '/usr/src/packages/BUILD'
[  203s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  203s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  203s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  203s]dh_install
[  203s] cp: cannot stat 'debian/tmp/usr/bin/ipaccess-config': No such file or 
directory
[  203s] dh_install: cp -a debian/tmp/usr/bin/ipaccess-config 
debian/osmo-bsc-ipaccess-utils//usr/bin/ returned exit code 1
[  203s] debian/rules:45: recipe for target 'binary' failed
[  203s] make: *** [binary] Error 2
[  203s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  203s] 
[  203s] cloud127 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:07:23 UTC 2018.
[  203s] 
[  203s] ### VM INTERACTION START ###
[  204s] Powering off.
[  204s] [  184.861415] reboot: Power down
[  211s] qemu-system-x86_64: Failed to unlink socket 
/var/cache/obs/worker/root_1/root.monitor: Permission denied
[  211s] ### VM INTERACTION END ###
[  211s] 
[  211s] cloud127 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:07:31 UTC 2018.
[  211s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_17.10/x86_64

2018-03-20 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  132s] make[3]: Entering directory '/usr/src/packages/BUILD'
[  132s] make[4]: Entering directory '/usr/src/packages/BUILD'
[  132s] make[4]: Nothing to be done for 'install-exec-am'.
[  132s] make[4]: Nothing to be done for 'install-data-am'.
[  132s] make[4]: Leaving directory '/usr/src/packages/BUILD'
[  132s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  132s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  132s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  132s]dh_install
[  132s] dh_install: Cannot find (any matches for) "usr/bin/ipaccess-config" 
(tried in ., debian/tmp)
[  132s] 
[  132s] dh_install: osmo-bsc-ipaccess-utils missing files: 
usr/bin/ipaccess-config
[  132s] dh_install: Cannot find (any matches for) "usr/bin/bs11_config" (tried 
in ., debian/tmp)
[  132s] 
[  132s] dh_install: osmo-bsc-bs11-utils missing files: usr/bin/bs11_config
[  132s] dh_install: missing files, aborting
[  132s] debian/rules:45: recipe for target 'binary' failed
[  132s] make: *** [binary] Error 25
[  132s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  132s] 
[  132s] lamb55 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:06:53 UTC 2018.
[  132s] 
[  132s] ### VM INTERACTION START ###
[  135s] [  128.489111] reboot: Power down
[  135s] qemu-system-x86_64: Failed to unlink socket 
/var/cache/obs/worker/root_10/root.monitor: Permission denied
[  135s] ### VM INTERACTION END ###
[  135s] 
[  135s] lamb55 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:06:56 UTC 2018.
[  135s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/osmo-bsc in Debian_9.0/i586

2018-03-20 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/i586

Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  135s] make[4]: Leaving directory '/usr/src/packages/BUILD/tests'
[  135s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  135s] make[3]: Entering directory '/usr/src/packages/BUILD'
[  135s] make[4]: Entering directory '/usr/src/packages/BUILD'
[  135s] make[4]: Nothing to be done for 'install-exec-am'.
[  135s] make[4]: Nothing to be done for 'install-data-am'.
[  135s] make[4]: Leaving directory '/usr/src/packages/BUILD'
[  135s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  135s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  135s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  135s]dh_install
[  135s] dh_install: Cannot find (any matches for) "usr/bin/ipaccess-config" 
(tried in "." and "debian/tmp")
[  135s] dh_install: osmo-bsc-ipaccess-utils missing files: 
usr/bin/ipaccess-config
[  135s] dh_install: Cannot find (any matches for) "usr/bin/bs11_config" (tried 
in "." and "debian/tmp")
[  135s] dh_install: osmo-bsc-bs11-utils missing files: usr/bin/bs11_config
[  135s] dh_install: missing files, aborting
[  135s] debian/rules:45: recipe for target 'binary' failed
[  135s] make: *** [binary] Error 2
[  135s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  135s] 
[  135s] lamb08 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:06:43 UTC 2018.
[  135s] 
[  135s] ### VM INTERACTION START ###
[  138s] [  130.148490] reboot: Power down
[  138s] qemu-system-x86_64: Failed to unlink socket 
/var/cache/obs/worker/root_2/root.monitor: Permission denied
[  138s] ### VM INTERACTION END ###
[  138s] 
[  138s] lamb08 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:06:47 UTC 2018.
[  138s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/osmo-bsc in Debian_8.0/i586

2018-03-20 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_8.0/i586

Package network:osmocom:nightly/osmo-bsc failed to build in Debian_8.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  186s] make[5]: Nothing to be done for 'install-data-am'.
[  186s] make[5]: Leaving directory '/usr/src/packages/BUILD/tests'
[  186s] make[4]: Leaving directory '/usr/src/packages/BUILD/tests'
[  186s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  186s] make[3]: Entering directory '/usr/src/packages/BUILD'
[  186s] make[4]: Entering directory '/usr/src/packages/BUILD'
[  186s] make[4]: Nothing to be done for 'install-exec-am'.
[  186s] make[4]: Nothing to be done for 'install-data-am'.
[  186s] make[4]: Leaving directory '/usr/src/packages/BUILD'
[  186s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  186s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  186s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  186s]dh_install
[  186s] cp: cannot stat 'debian/tmp/usr/bin/ipaccess-config': No such file or 
directory
[  186s] dh_install: cp -a debian/tmp/usr/bin/ipaccess-config 
debian/osmo-bsc-ipaccess-utils//usr/bin/ returned exit code 1
[  186s] debian/rules:45: recipe for target 'binary' failed
[  186s] make: *** [binary] Error 2
[  186s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  186s] 
[  186s] cloud116 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:05:33 UTC 2018.
[  186s] 
[  186s] ### VM INTERACTION START ###
[  187s] Powering off.
[  187s] [  170.304501] reboot: Power down
[  188s] qemu-system-x86_64: Failed to unlink socket 
/var/cache/obs/worker/root_3/root.monitor: Permission denied
[  189s] ### VM INTERACTION END ###
[  189s] 
[  189s] cloud116 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:05:37 UTC 2018.
[  189s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_16.10/i586

2018-03-20 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.10/i586

Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  111s] make[4]: Leaving directory '/usr/src/packages/BUILD/tests'
[  111s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  111s] make[3]: Entering directory '/usr/src/packages/BUILD'
[  111s] make[4]: Entering directory '/usr/src/packages/BUILD'
[  111s] make[4]: Nothing to be done for 'install-exec-am'.
[  111s] make[4]: Nothing to be done for 'install-data-am'.
[  111s] make[4]: Leaving directory '/usr/src/packages/BUILD'
[  111s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  111s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  111s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  111s]dh_install
[  111s] dh_install: Cannot find (any matches for) "usr/bin/ipaccess-config" 
(tried in "." and "debian/tmp")
[  111s] dh_install: osmo-bsc-ipaccess-utils missing files: 
usr/bin/ipaccess-config
[  111s] dh_install: Cannot find (any matches for) "usr/bin/bs11_config" (tried 
in "." and "debian/tmp")
[  111s] dh_install: osmo-bsc-bs11-utils missing files: usr/bin/bs11_config
[  111s] dh_install: missing files, aborting
[  111s] debian/rules:45: recipe for target 'binary' failed
[  111s] make: *** [binary] Error 2
[  111s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  111s] 
[  111s] build77 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:02:51 UTC 2018.
[  111s] 
[  111s] ### VM INTERACTION START ###
[  114s] [  107.145431] reboot: Power down
[  114s] qemu-system-x86_64: Failed to unlink socket 
/var/cache/obs/worker/root_1/root.monitor: Permission denied
[  114s] ### VM INTERACTION END ###
[  114s] 
[  114s] build77 failed "build osmo-bsc_1.1.2.20180320.dsc" at Tue Mar 20 
20:02:55 UTC 2018.
[  114s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)


osmo-ttcn3-hacks[master]: Move make artifacts to build subdir

2018-03-20 Thread Pau Espin Pedrol

Patch Set 1:

BTW, the jenkins gerrit job doesn't seem to be running make compile, shall we 
add it to the gerrit job? Otherwise I'll let my PC run it this night.

-- 
To view, visit https://gerrit.osmocom.org/7405
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9ca176869ce6b80ccf2b2fff6554b121e1aa85c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No


[MERGED] osmo-ttcn3-hacks[master]: make ttcn3 RNC paging tests pass

2018-03-20 Thread Harald Welte
Harald Welte has submitted this change and it was merged.

Change subject: make ttcn3 RNC paging tests pass
..


make ttcn3 RNC paging tests pass

We do not implement paging by RNC. Fix test expectations accordingly.

Change-Id: I490fdaa9a73565c7e53e9a7eeafa0ee89c29b9d8
Related: OS#3073
---
M bsc/BSC_Tests.ttcn
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 3522358..aff6336 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -1144,27 +1144,27 @@
f_shutdown_helper();
 }
 
-/* Paging by PLMN+LAC+RNC */
+/* Paging by PLMN+LAC+RNC; We do not implement this; Verify nothing is paged */
 testcase TC_paging_imsi_nochan_plmn_lac_rnc() runs on test_CT {
var template BSSMAP_FIELD_CellIdentificationList cid_list;
cid_list := { cIl_PLMN_LAC_RNC := { ts_BSSMAP_CI_PLMN_LAC_RNC(cid.mcc, 
cid.mnc, cid.lac, 12) } };
-   f_pageing_helper('0010112'H, cid_list, c_BtsId_all);
+   f_pageing_helper('0010112'H, cid_list, c_BtsId_none);
f_shutdown_helper();
 }
 
-/* Paging by RNC */
+/* Paging by RNC; We do not implement this; Verify nothing is paged */
 testcase TC_paging_imsi_nochan_rnc() runs on test_CT {
var template BSSMAP_FIELD_CellIdentificationList cid_list;
cid_list := { cIl_RNC := { int2oct(13, 2) } };
-   f_pageing_helper('0010113'H, cid_list, c_BtsId_all);
+   f_pageing_helper('0010113'H, cid_list, c_BtsId_none);
f_shutdown_helper();
 }
 
-/* Paging by LAC+RNC */
+/* Paging by LAC+RNC; We do not implement; Verify nothing is paged */
 testcase TC_paging_imsi_nochan_lac_rnc() runs on test_CT {
var template BSSMAP_FIELD_CellIdentificationList cid_list;
cid_list := { cIl_LAC_RNC := { ts_BSSMAP_CI_LAC_RNC(cid.lac, 14) } };
-   f_pageing_helper('0010114'H, cid_list, c_BtsId_all);
+   f_pageing_helper('0010114'H, cid_list, c_BtsId_none);
f_shutdown_helper();
 }
 

-- 
To view, visit https://gerrit.osmocom.org/7407
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I490fdaa9a73565c7e53e9a7eeafa0ee89c29b9d8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder


osmo-ttcn3-hacks[master]: make ttcn3 RNC paging tests pass

2018-03-20 Thread Harald Welte

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7407
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I490fdaa9a73565c7e53e9a7eeafa0ee89c29b9d8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No


osmo-ttcn3-hacks[master]: Move make artifacts to build subdir

2018-03-20 Thread Pau Espin Pedrol

Patch Set 1:

Something which is not clear to me while working on this: Is there some sort of 
requirement of passing the MAIN file to ttcn3_makefilegen as the first 
argument? How does ttcn3_makefilegen select the name to use for the output 
binary?

-- 
To view, visit https://gerrit.osmocom.org/7405
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9ca176869ce6b80ccf2b2fff6554b121e1aa85c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No


[PATCH] osmo-ttcn3-hacks[master]: make ttcn3 RNC paging tests pass

2018-03-20 Thread Stefan Sperling

Review at  https://gerrit.osmocom.org/7407

make ttcn3 RNC paging tests pass

We do not implement paging by RNC. Fix test expectations accordingly.

Change-Id: I490fdaa9a73565c7e53e9a7eeafa0ee89c29b9d8
Related: OS#3073
---
M bsc/BSC_Tests.ttcn
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/07/7407/1

diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 3522358..aff6336 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -1144,27 +1144,27 @@
f_shutdown_helper();
 }
 
-/* Paging by PLMN+LAC+RNC */
+/* Paging by PLMN+LAC+RNC; We do not implement this; Verify nothing is paged */
 testcase TC_paging_imsi_nochan_plmn_lac_rnc() runs on test_CT {
var template BSSMAP_FIELD_CellIdentificationList cid_list;
cid_list := { cIl_PLMN_LAC_RNC := { ts_BSSMAP_CI_PLMN_LAC_RNC(cid.mcc, 
cid.mnc, cid.lac, 12) } };
-   f_pageing_helper('0010112'H, cid_list, c_BtsId_all);
+   f_pageing_helper('0010112'H, cid_list, c_BtsId_none);
f_shutdown_helper();
 }
 
-/* Paging by RNC */
+/* Paging by RNC; We do not implement this; Verify nothing is paged */
 testcase TC_paging_imsi_nochan_rnc() runs on test_CT {
var template BSSMAP_FIELD_CellIdentificationList cid_list;
cid_list := { cIl_RNC := { int2oct(13, 2) } };
-   f_pageing_helper('0010113'H, cid_list, c_BtsId_all);
+   f_pageing_helper('0010113'H, cid_list, c_BtsId_none);
f_shutdown_helper();
 }
 
-/* Paging by LAC+RNC */
+/* Paging by LAC+RNC; We do not implement; Verify nothing is paged */
 testcase TC_paging_imsi_nochan_lac_rnc() runs on test_CT {
var template BSSMAP_FIELD_CellIdentificationList cid_list;
cid_list := { cIl_LAC_RNC := { ts_BSSMAP_CI_LAC_RNC(cid.lac, 14) } };
-   f_pageing_helper('0010114'H, cid_list, c_BtsId_all);
+   f_pageing_helper('0010114'H, cid_list, c_BtsId_none);
f_shutdown_helper();
 }
 

-- 
To view, visit https://gerrit.osmocom.org/7407
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I490fdaa9a73565c7e53e9a7eeafa0ee89c29b9d8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling 


[PATCH] osmo-ci[master]: jobs: gerrit-osmo-ttcn3-hacks: Make deps before cleaning

2018-03-20 Thread Pau Espin Pedrol

Review at  https://gerrit.osmocom.org/7406

jobs: gerrit-osmo-ttcn3-hacks: Make deps before cleaning

make clean has subdir/Makefile as dependency. As a result,
subdir/gen_links.sh and subdir/makefile-regen.sh are called, and
ttcn3_makefilegen in there fails because the dep symlinks are done
against missing files (because git repos in deps have not been checked
out).

Change-Id: I07fee78bba5b07c7f3f4359869e00ef2583e0769
---
M jobs/gerrit-verifications.yml
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/06/7406/1

diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml
index 54c99cc..1814a05 100644
--- a/jobs/gerrit-verifications.yml
+++ b/jobs/gerrit-verifications.yml
@@ -189,7 +189,7 @@
   slave_axis: !!python/tuple [build2-deb9build]
   cmd: >
# keep first line with less indent to preserve newlines
-make clean; make deps-update && make compile
+make deps; make clean; make deps-update && make compile
 
 jobs:
   - 'gerrit-{repos}'

-- 
To view, visit https://gerrit.osmocom.org/7406
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I07fee78bba5b07c7f3f4359869e00ef2583e0769
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 


[PATCH] osmo-ttcn3-hacks[master]: Move make artifacts to build subdir

2018-03-20 Thread Pau Espin Pedrol

Review at  https://gerrit.osmocom.org/7405

Move make artifacts to build subdir

Avoid having 50-100 symlinks and .o objects in the same dir where the
source/cfg files are. Move them instead to a ./build subdir.

A new symlink FooSuite/build/TestBinary -> FooSuite/TestBinary is added
to keep compatibility with docker-playground containers.

Change-Id: Id9ca176869ce6b80ccf2b2fff6554b121e1aa85c
---
M .gitignore
M Makefile
M bsc-nat/gen_links.sh
M bsc-nat/regen_makefile.sh
M bsc/gen_links.sh
M bsc/regen_makefile.sh
M bts/gen_links.sh
M bts/regen_makefile.sh
M gen_links.sh.inc
M ggsn_tests/gen_links.sh
M ggsn_tests/regen_makefile.sh
M hlr/gen_links.sh
M hlr/regen_makefile.sh
M lapdm/gen_links.sh
M lapdm/regen_makefile.sh
M mgw/gen_links.sh
M mgw/regen_makefile.sh
M msc/gen_links.sh
M msc/regen_makefile.sh
M pcu/gen_links.sh
M pcu/regen_makefile.sh
M selftest/gen_links.sh
M selftest/regen_makefile.sh
M sgsn/gen_links.sh
M sgsn/regen_makefile.sh
M sysinfo/gen_links.sh
M sysinfo/regen_makefile.sh
27 files changed, 376 insertions(+), 270 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/05/7405/1

diff --git a/.gitignore b/.gitignore
index bf5baa0..0ca978f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -14,3 +14,4 @@
 */Makefile
 !bin/Makefile
 !deps/Makefile
+*/build
diff --git a/Makefile b/Makefile
index 0defc31..e8e8286 100644
--- a/Makefile
+++ b/Makefile
@@ -36,22 +36,22 @@
 define DIR_compile_template
 .PHONY: $(1)/compile
 $(1)/compile: deps $(1)/Makefile
-   $(MAKE) -C $(1) compile
+   $(MAKE) -C $(1)/build compile
 endef
 
 define DIR_clean_template
 .PHONY: $(1)/clean
 $(1)/clean: $(1)/Makefile
-   $(MAKE) -C $(1) clean
-   (cd $(1) && ../rmlinks.sh && rm Makefile)
+   $(MAKE) -C $(1)/build clean
+   (cd $(1)/build && ../../rmlinks.sh && rm Makefile)
 endef
 
 define DIR_all_template
 $(1): $(1)/all
 .PHONY: $(1)/all
 $(1)/all: deps $(1)/Makefile
-   $(MAKE) -C $(1) compile
-   $(MAKE) $(PARALLEL_MAKE) -C $(1)
+   $(MAKE) -C $(1)/build compile
+   $(MAKE) $(PARALLEL_MAKE) -C $(1)/build
 endef
 
 $(foreach dir,$(SUBDIRS), \
diff --git a/bsc-nat/gen_links.sh b/bsc-nat/gen_links.sh
index 453d8ca..4d83183 100755
--- a/bsc-nat/gen_links.sh
+++ b/bsc-nat/gen_links.sh
@@ -1,53 +1,56 @@
 #!/bin/sh
 
-BASEDIR=../deps
+BASEDIR=$(readlink -f ..)
+DSTDIR=./build
 
-. ../gen_links.sh.inc
+. $BASEDIR/gen_links.sh.inc
 
-#DIR=$BASEDIR/titan.TestPorts.UNIX_DOMAIN_SOCKETasp/src
+mkdir -p $DSTDIR
+
+#DIR=$BASEDIR/deps/titan.TestPorts.UNIX_DOMAIN_SOCKETasp/src
 #FILES="UD_PT.cc  UD_PT.hh  UD_PortType.ttcn  UD_Types.ttcn"
-#gen_links $DIR $FILES
+#gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.Libraries.TCCUsefulFunctions/src
+DIR=$BASEDIR/deps/titan.Libraries.TCCUsefulFunctions/src
 FILES="TCCInterface_Functions.ttcn TCCConversion_Functions.ttcn 
TCCConversion.cc TCCInterface.cc TCCInterface_ip.h SDP_EncDec.cc"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.TestPorts.Common_Components.Socket-API/src
+DIR=$BASEDIR/deps/titan.TestPorts.Common_Components.Socket-API/src
 FILES="Socket_API_Definitions.ttcn"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.TestPorts.IPL4asp/src
+DIR=$BASEDIR/deps/titan.TestPorts.IPL4asp/src
 FILES="IPL4asp_Functions.ttcn  IPL4asp_PT.cc  IPL4asp_PT.hh 
IPL4asp_PortType.ttcn  IPL4asp_Types.ttcn  IPL4asp_discovery.cc 
IPL4asp_protocol_L234.hh"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
 # required by SCCP Emulation
-DIR=$BASEDIR/titan.TestPorts.MTP3asp/src
+DIR=$BASEDIR/deps/titan.TestPorts.MTP3asp/src
 FILES="MTP3asp_PortType.ttcn  MTP3asp_Types.ttcn"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.ProtocolEmulations.SCCP/src
+DIR=$BASEDIR/deps/titan.ProtocolEmulations.SCCP/src
 FILES="SCCP_Emulation.ttcn  SCCP_EncDec.cc  SCCP_Mapping.ttcnpp  
SCCP_Types.ttcn  SCCPasp_Types.ttcn"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.ProtocolModules.BSSMAP_v11.2.0/src
+DIR=$BASEDIR/deps/titan.ProtocolModules.BSSMAP_v11.2.0/src
 FILES="BSSAP_Types.ttcn"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.ProtocolModules.MobileL3_v13.4.0/src
+DIR=$BASEDIR/deps/titan.ProtocolModules.MobileL3_v13.4.0/src
 FILES="MobileL3_CC_Types.ttcn MobileL3_CommonIE_Types.ttcn 
MobileL3_GMM_SM_Types.ttcn MobileL3_MM_Types.ttcn MobileL3_RRM_Types.ttcn 
MobileL3_SMS_Types.ttcn MobileL3_SS_Types.ttcn MobileL3_Types.ttcn"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.ProtocolModules.SDP/src
+DIR=$BASEDIR/deps/titan.ProtocolModules.SDP/src
 FILES="SDP_EncDec.cc SDP_Types.ttcn SDP_parse_.tab.c SDP_parse_.tab.h 
SDP_parse_parser.h SDP_parser.l
 SDP_parser.y lex.SDP_parse_.c"
-gen_links $DIR $FILES
+gen_links $DIR $DSTDIR $FILES
 
-DIR=$BASEDIR/titan.ProtocolModules.RTP/src
+DIR=$BASEDIR/deps/titan.ProtocolModules.RTP/src
 FILES="RTP_EncDec.cc RTP_Types.ttcn"
-gen_links 

[PATCH] osmo-ttcn3-hacks[master]: make management of osmo-ttcn3 git repository dependencies au...

2018-03-20 Thread Stefan Sperling
Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/7404

to look at the new patch set (#3).

make management of osmo-ttcn3 git repository dependencies automatic

Add rules to deps/Makefile which ensure that 'make deps' puts the git
repositories of dependencies into a known state. In particular, set
the origin remote url to a known value, and check out a known commit
into the work tree.

This change ensures that ttcn3 builds run with 'make' will always use
correct versions of dependencies.

The 'make update-deps' now has the same effect as 'make deps', but it
is not yet removed in case build scripts rely on its existence.
The new 'make deps' target is fast enough to be run before every build.

Change-Id: I561eee7e12d976cd2265ba1bb8cd22dd8c1a0735
Related: OS#3090
---
M Makefile
M deps/Makefile
2 files changed, 57 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/04/7404/3

diff --git a/Makefile b/Makefile
index 0defc31..aeca0e1 100644
--- a/Makefile
+++ b/Makefile
@@ -20,9 +20,10 @@
 deps:
$(MAKE) -C deps
 
+# deps-update target for backwards compat; now does the same as 'make deps'
 .PHONY: deps-update
 deps-update:
-   $(MAKE) -C deps update
+   $(MAKE) -C deps
 
 compile: $(foreach dir,$(SUBDIRS),$(dir)/compile)
 clean: $(foreach dir,$(SUBDIRS),$(dir)/clean)
diff --git a/deps/Makefile b/deps/Makefile
index c9c01ca..b448c73 100644
--- a/deps/Makefile
+++ b/deps/Makefile
@@ -47,22 +47,72 @@
 
 ALL_REPOS=$(ECLIPSEGIT_REPOS) $(ECLIPSEGIT2_REPOS) $(OSMOGITHUB_REPOS)
 
-all: $(ALL_REPOS)
+# Tag names from 'git-describe --tags'; if not available, a commit hash may be 
used instead.
+# In order to keep local changes in the repository of a dependency, set its 
commit to the
+# name of a local branch here (e.g. 'master').
+# CAREFUL: 'make clean' WILL DISCARD UNCOMMITTED CHANGES IN THESE REPOSITORIES!
+titan.Libraries.TCCUsefulFunctions_commit= R.30.A
+titan.ProtocolEmulations.M3UA_commit=  R.2.A
+titan.ProtocolEmulations.SCCP_commit=  
724c83fd2794e8ea362d08c42d9fc10fc1885ef1
+titan.ProtocolModules.BSSAPP_v7.3.0_commit=R.2.A
+titan.ProtocolModules.BSSGP_v13.0.0_commit=R.2.A
+titan.ProtocolModules.BSSMAP_v11.2.0_commit=   R.2.A
+titan.ProtocolModules.GRE_commit=  R.2.A
+titan.ProtocolModules.GTP_v13.5.0_commit=  R.2.A
+titan.ProtocolModules.GTPv2_v13.7.0_commit=R.2.A
+titan.ProtocolModules.ICMP_commit= R.2.A
+titan.ProtocolModules.ICMPv6_commit=   R.2.A
+titan.ProtocolModules.IP_commit=   R.10.B-1-g99d0ec9
+titan.ProtocolModules.ISUP_Q.762_commit=   R.8.A
+titan.ProtocolModules.L2TP_commit= R.2.A
+titan.ProtocolModules.LLC_v7.1.0_commit=   R.2.A
+titan.ProtocolModules.M2PA_commit= R.2.A
+titan.ProtocolModules.M3UA_commit= R.2.A
+titan.ProtocolModules.MobileL3_v13.4.0_commit= R.2.A
+titan.ProtocolModules.NS_v7.3.0_commit=R.2.A
+titan.ProtocolModules.RTP_commit=  R.5.A
+titan.ProtocolModules.SCTP_commit= R.2.A
+titan.ProtocolModules.SDP_commit=  R.14.A
+titan.ProtocolModules.SMPP_commit= R.2.A
+titan.ProtocolModules.SNDCP_v7.0.0_commit= R.2.A
+titan.ProtocolModules.SUA_commit=  R.5.A
+titan.ProtocolModules.TCP_commit=  R.3.A
+titan.ProtocolModules.UDP_commit=  R.4.A
+titan.TestPorts.Common_Components.Socket-API_commit=   R.6.A
+titan.TestPorts.GPIO_commit=   R.3.A
+titan.TestPorts.IPL4asp_commit=R.29.A
+titan.TestPorts.LANL2asp_commit=   R.8.B
+titan.TestPorts.MTP3asp_commit=
1cecdad6f3641a5f19b3833703bff6e5005eff11
+titan.TestPorts.PCAPasp_commit=R.7.A
+titan.TestPorts.SCTPasp_commit=R.11.A-2-g2faa9cf
+titan.TestPorts.SIPmsg_commit= R.15.A-1-ge4f9dd0
+titan.TestPorts.TCPasp_commit= R.9.A
+titan.TestPorts.TELNETasp_commit=  R.9.A
+titan.TestPorts.UDPasp_commit= R.8.A
+titan.TestPorts.UNIX_DOMAIN_SOCKETasp_commit=  R.2.A-3-g61e5a25
 
-update: $(foreach dir,$(ALL_REPOS),$(dir)/update)
+all: $(foreach dir,$(ALL_REPOS),$(dir)/update)
 clean: $(foreach dir,$(ALL_REPOS),$(dir)/clean)
 
 define GIT_template
+$(1)_ORIGIN!=  if [ -d $(1) ]; then cd $(1) && git remote get-url origin; fi
+$(1)_HEAD!=if [ -d $(1) ]; then cd $(1) && git describe --tags 2>/dev/null 
|| git rev-parse HEAD; fi
+
 $(1):
git clone $(2)/$(1)
 
-.PHONY:$(1)/update
+.PHONY: $(1)/update
 $(1)/update: $(1)
-   (cd $(1) && git remote set-url origin $(2)/$(1) && git fetch && git 
checkout -f -B master origin/master)
+ifneq ($$($(1)_ORIGIN),$(2)/$(1))
+   cd $(1) && git remote set-url origin $(2)/$(1) && git fetch
+endif
+ifneq ($$($(1)_HEAD),$($(1)_commit))
+   cd $(1) && git checkout -q -f 

[PATCH] osmo-ttcn3-hacks[master]: make management of osmo-ttcn3 git repository dependencies au...

2018-03-20 Thread Stefan Sperling

Review at  https://gerrit.osmocom.org/7404

make management of osmo-ttcn3 git repository dependencies automatic

Add rules to deps/Makefile which ensure that 'make deps' puts the git
repositories of dependencies into a known state. In particular, set
the origin remote url to a known value, and check out a known commit
into the work tree.

This change ensures that ttcn3 builds run with 'make' will always use
correct versions of dependencies.

The 'make update-deps' now has the same effect as 'make deps', but it
is not yet removed in case build scripts rely on its existence.
The new 'make deps' target is fast enough to be run before every build.

Change-Id: I561eee7e12d976cd2265ba1bb8cd22dd8c1a0735
Related: OS#3090
---
M Makefile
M deps/Makefile
2 files changed, 57 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/04/7404/1

diff --git a/Makefile b/Makefile
index 0defc31..aeca0e1 100644
--- a/Makefile
+++ b/Makefile
@@ -20,9 +20,10 @@
 deps:
$(MAKE) -C deps
 
+# deps-update target for backwards compat; now does the same as 'make deps'
 .PHONY: deps-update
 deps-update:
-   $(MAKE) -C deps update
+   $(MAKE) -C deps
 
 compile: $(foreach dir,$(SUBDIRS),$(dir)/compile)
 clean: $(foreach dir,$(SUBDIRS),$(dir)/clean)
diff --git a/deps/Makefile b/deps/Makefile
index c9c01ca..b9da7fa 100644
--- a/deps/Makefile
+++ b/deps/Makefile
@@ -47,22 +47,72 @@
 
 ALL_REPOS=$(ECLIPSEGIT_REPOS) $(ECLIPSEGIT2_REPOS) $(OSMOGITHUB_REPOS)
 
-all: $(ALL_REPOS)
+# Tag names from 'git-describe --tags'; if not available, a commit hash may be 
used instead.
+# In order to keep local changes in the repository of a dependency, set its 
commit to the
+# name of a local branch here (e.g. 'master').
+# CAREFUL: 'make clean' WILL DISCARD UNCOMMITTED CHANGES IN THESE REPOSITORIES!
+titan.Libraries.TCCUsefulFunctions_commit= R.30.A
+titan.ProtocolEmulations.M3UA_commit=  R.2.A
+titan.ProtocolEmulations.SCCP_commit=  
724c83fd2794e8ea362d08c42d9fc10fc1885ef1
+titan.ProtocolModules.BSSAPP_v7.3.0_commit=R.2.A
+titan.ProtocolModules.BSSGP_v13.0.0_commit=R.2.A
+titan.ProtocolModules.BSSMAP_v11.2.0_commit=   R.2.A
+titan.ProtocolModules.GRE_commit=  R.2.A
+titan.ProtocolModules.GTP_v13.5.0_commit=  R.2.A
+titan.ProtocolModules.GTPv2_v13.7.0_commit=R.2.A
+titan.ProtocolModules.ICMP_commit= R.2.A
+titan.ProtocolModules.ICMPv6_commit=   R.2.A
+titan.ProtocolModules.IP_commit=   R.10.B-1-g99d0ec9
+titan.ProtocolModules.ISUP_Q.762_commit=   R.8.A
+titan.ProtocolModules.L2TP_commit= R.2.A
+titan.ProtocolModules.LLC_v7.1.0_commit=   R.2.A
+titan.ProtocolModules.M2PA_commit= R.2.A
+titan.ProtocolModules.M3UA_commit= R.2.A
+titan.ProtocolModules.MobileL3_v13.4.0_commit= R.2.A
+titan.ProtocolModules.NS_v7.3.0_commit=R.2.A
+titan.ProtocolModules.RTP_commit=  R.5.A
+titan.ProtocolModules.SCTP_commit= R.2.A
+titan.ProtocolModules.SDP_commit=  R.14.A
+titan.ProtocolModules.SMPP_commit= R.2.A
+titan.ProtocolModules.SNDCP_v7.0.0_commit= R.2.A
+titan.ProtocolModules.SUA_commit=  R.5.A
+titan.ProtocolModules.TCP_commit=  R.3.A
+titan.ProtocolModules.UDP_commit=  R.4.A
+titan.TestPorts.Common_Components.Socket-API_commit=   R.6.A
+titan.TestPorts.GPIO_commit=   R.3.A
+titan.TestPorts.IPL4asp_commit=R.29.A
+titan.TestPorts.LANL2asp_commit=   R.8.B
+titan.TestPorts.MTP3asp_commit=
1cecdad6f3641a5f19b3833703bff6e5005eff11
+titan.TestPorts.PCAPasp_commit=R.7.A
+titan.TestPorts.SCTPasp_commit=R.11.A-2-g2faa9cf
+titan.TestPorts.SIPmsg_commit= R.15.A-1-ge4f9dd0
+titan.TestPorts.TCPasp_commit= R.9.A
+titan.TestPorts.TELNETasp_commit=  R.9.A
+titan.TestPorts.UDPasp_commit= R.8.A
+titan.TestPorts.UNIX_DOMAIN_SOCKETasp_commit=  R.2.A-3-g61e5a25
 
-update: $(foreach dir,$(ALL_REPOS),$(dir)/update)
+all: $(foreach dir,$(ALL_REPOS),$(dir)/update)
 clean: $(foreach dir,$(ALL_REPOS),$(dir)/clean)
 
 define GIT_template
+$(1)_ORIGIN!=  if [ -d "$(1)" ]; then cd $(1) && git remote get-url origin; fi
+$(1)_HEAD!=if [ -d "$(1)" ]; then cd $(1) && git describe --tags 
2>/dev/null || git rev-parse HEAD; fi
+
 $(1):
git clone $(2)/$(1)
 
-.PHONY:$(1)/update
+.PHONY: $(1)/update
 $(1)/update: $(1)
-   (cd $(1) && git remote set-url origin $(2)/$(1) && git fetch && git 
checkout -f -B master origin/master)
+ifneq ($$($(1)_ORIGIN),$(2)/$(1))
+   cd $(1) && git remote set-url origin "$(2)/$(1)" && git fetch
+endif
+ifneq ($$($(1)_HEAD),$($(1)_commit))
+   cd $(1) && git checkout -q -f "$($(1)_commit)"
+endif
 
 .PHONY: $(1)/clean
 $(1)/clean: $(1)
-   (cd $(1) && git checkout -f -B master && 

docker-playground[master]: fix ttcn3-bsc-test: BSC_Tests.cfg: set mp_test_ip

2018-03-20 Thread Harald Welte

Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.osmocom.org/7401
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3038481ed0bba1084b63dc6a6d2ff6e970100890
Gerrit-PatchSet: 2
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No


[MERGED] docker-playground[master]: fix ttcn3-bsc-test: BSC_Tests.cfg: set mp_test_ip

2018-03-20 Thread Harald Welte
Harald Welte has submitted this change and it was merged.

Change subject: fix ttcn3-bsc-test: BSC_Tests.cfg: set mp_test_ip
..


fix ttcn3-bsc-test: BSC_Tests.cfg: set mp_test_ip

Allow the osmo-bsc-main docker container to reach the virtual MGW set up by the
ttcn3-bsc-tests.

The module parameter mp_test_ip sets the IP address at which the virtual
services are set up to listen for connections -- currently actually only the
virtual MGW. Set this to 172.18.2.203 instead of using the default 127.0.0.1.

This fixes the second half of the disconnect between BSC and virtual MGW in
this docker setup. The first half is Ib53f000ec7e717b14a3e5df6e803d3d0950b937f

Change-Id: I3038481ed0bba1084b63dc6a6d2ff6e970100890
---
M ttcn3-bsc-test/BSC_Tests.cfg
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/ttcn3-bsc-test/BSC_Tests.cfg b/ttcn3-bsc-test/BSC_Tests.cfg
index ca2b76c..401c0f0 100644
--- a/ttcn3-bsc-test/BSC_Tests.cfg
+++ b/ttcn3-bsc-test/BSC_Tests.cfg
@@ -10,6 +10,7 @@
 
 [MODULE_PARAMETERS]
 BSC_Tests.mp_bsc_ip   := "172.18.2.20";
+BSC_Tests.mp_test_ip   := "172.18.2.203";
 BSC_Tests.mp_bssap_cfg := {
sccp_service_type := "mtp3_itu",
sctp_addr := { 23905, "172.18.2.203", 2905, "172.18.2.200" },

-- 
To view, visit https://gerrit.osmocom.org/7401
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3038481ed0bba1084b63dc6a6d2ff6e970100890
Gerrit-PatchSet: 2
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 


[MERGED] osmo-ttcn3-hacks[master]: add regression test for paging with unknown MCC/MNC

2018-03-20 Thread Harald Welte
Harald Welte has submitted this change and it was merged.

Change subject: add regression test for paging with unknown MCC/MNC
..


add regression test for paging with unknown MCC/MNC

Verify that the BSC does not page a subscriber when a cell identifier
with an unknown MCC/MNC is provided by the MSC.

This test introduces a magic value which represents an unknown MCC/MNC
combination: MCC=678 MNC=f90

Change-Id: I0b0af14a9a1cb7e5a7a4ec12cc489473fd7ead02
Related: OS#2980
---
M bsc/BSC_Tests.cfg
M bsc/BSC_Tests.ttcn
2 files changed, 11 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bsc/BSC_Tests.cfg b/bsc/BSC_Tests.cfg
index ef6823c..175654a 100644
--- a/bsc/BSC_Tests.cfg
+++ b/bsc/BSC_Tests.cfg
@@ -65,6 +65,7 @@
 #BSC_Tests.TC_paging_imsi_a_reset
 #BSC_Tests.TC_paging_imsi_load
 #BSC_Tests.TC_paging_counter
+#BSC_Tests.TC_paging_imsi_nochan_cgi_unknown_cid
 #BSC_Tests.TC_rsl_drop_counter
 #BSC_Tests.TC_classmark
 #BSC_Tests.TC_unsol_ass_fail
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index a2111fd..3522358 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -966,6 +966,7 @@
GsmCellId   ci
 };
 private const Cell_Identity cid := { '001'H, '01'H, 1, 0 };
+private const Cell_Identity unknown_cid := { '678'H, 'f90'H, 1, 0 };
 
 type set of integer BtsIdList;
 
@@ -1180,6 +1181,14 @@
var template BSSMAP_FIELD_CellIdentificationList cid_list;
cid_list := { cIl_LAC := { } };
f_pageing_helper('0010116'H, cid_list, c_BtsId_none);
+   f_shutdown_helper();
+}
+
+/* Paging by CGI with unknown MCC/MNC: Verify nothing is paged. */
+testcase TC_paging_imsi_nochan_cgi_unknown_cid() runs on test_CT {
+   var template BSSMAP_FIELD_CellIdentificationList cid_list;
+   cid_list := { cIl_CGI := { ts_BSSMAP_CI_CGI(unknown_cid.mcc, 
unknown_cid.mnc, unknown_cid.lac, unknown_cid.ci) } };
+   f_pageing_helper('0010106'H, cid_list, c_BtsId_none);
f_shutdown_helper();
 }
 
@@ -1961,6 +1970,7 @@
execute( TC_paging_imsi_nochan_lac_rnc() );
execute( TC_paging_imsi_nochan_lacs() );
execute( TC_paging_imsi_nochan_lacs_empty() );
+   execute( TC_paging_imsi_nochan_cgi_unknown_cid() );
execute( TC_paging_imsi_a_reset() );
execute( TC_paging_imsi_load() );
execute( TC_paging_counter() );

-- 
To view, visit https://gerrit.osmocom.org/7403
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0b0af14a9a1cb7e5a7a4ec12cc489473fd7ead02
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder


[MERGED] osmo-ggsn[master]: remove the -f option from osmo-ggsn.service

2018-03-20 Thread Harald Welte
Harald Welte has submitted this change and it was merged.

Change subject: remove the -f option from osmo-ggsn.service
..


remove the -f option from osmo-ggsn.service

This option was removed in dda21ed7d4a897c9284c69175d0da598598eae40
and the behaviour previously implied by -f has since been the default.

Change-Id: Iba13df713af03771739a4feff4b222a0c3352394
Related: OS#3044
---
M contrib/osmo-ggsn.service
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/contrib/osmo-ggsn.service b/contrib/osmo-ggsn.service
index 10e3507..c75325d 100644
--- a/contrib/osmo-ggsn.service
+++ b/contrib/osmo-ggsn.service
@@ -5,7 +5,7 @@
 [Service]
 Type=simple
 Restart=always
-ExecStart=/usr/bin/osmo-ggsn -c /etc/osmocom/osmo-ggsn.cfg -f
+ExecStart=/usr/bin/osmo-ggsn -c /etc/osmocom/osmo-ggsn.cfg
 RestartSec=2
 RestartPreventExitStatus=1
 

-- 
To view, visit https://gerrit.osmocom.org/7402
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iba13df713af03771739a4feff4b222a0c3352394
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder


osmo-ggsn[master]: remove the -f option from osmo-ggsn.service

2018-03-20 Thread Harald Welte

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7402
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba13df713af03771739a4feff4b222a0c3352394
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No


osmo-ttcn3-hacks[master]: add regression test for paging with unknown MCC/MNC

2018-03-20 Thread Harald Welte

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7403
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b0af14a9a1cb7e5a7a4ec12cc489473fd7ead02
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No


docker-playground[master]: fix ttcn3-bsc-test: BSC_Tests.cfg: set mp_test_ip

2018-03-20 Thread Harald Welte

Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7401
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3038481ed0bba1084b63dc6a6d2ff6e970100890
Gerrit-PatchSet: 2
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No


[PATCH] docker-playground[master]: fix ttcn3-bsc-test: BSC_Tests.cfg: set mp_test_ip

2018-03-20 Thread Neels Hofmeyr

fix ttcn3-bsc-test: BSC_Tests.cfg: set mp_test_ip

Allow the osmo-bsc-main docker container to reach the virtual MGW set up by the
ttcn3-bsc-tests.

The module parameter mp_test_ip sets the IP address at which the virtual
services are set up to listen for connections -- currently actually only the
virtual MGW. Set this to 172.18.2.203 instead of using the default 127.0.0.1.

This fixes the second half of the disconnect between BSC and virtual MGW in
this docker setup. The first half is Ib53f000ec7e717b14a3e5df6e803d3d0950b937f

Change-Id: I3038481ed0bba1084b63dc6a6d2ff6e970100890
---
M ttcn3-bsc-test/BSC_Tests.cfg
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/01/7401/2

diff --git a/ttcn3-bsc-test/BSC_Tests.cfg b/ttcn3-bsc-test/BSC_Tests.cfg
index ca2b76c..401c0f0 100644
--- a/ttcn3-bsc-test/BSC_Tests.cfg
+++ b/ttcn3-bsc-test/BSC_Tests.cfg
@@ -10,6 +10,7 @@
 
 [MODULE_PARAMETERS]
 BSC_Tests.mp_bsc_ip   := "172.18.2.20";
+BSC_Tests.mp_test_ip   := "172.18.2.203";
 BSC_Tests.mp_bssap_cfg := {
sccp_service_type := "mtp3_itu",
sctp_addr := { 23905, "172.18.2.203", 2905, "172.18.2.200" },

-- 
To view, visit https://gerrit.osmocom.org/7401
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3038481ed0bba1084b63dc6a6d2ff6e970100890
Gerrit-PatchSet: 2
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 


docker-playground[master]: fix ttcn3-bsc-test: BSC_Tests.cfg: set mp_test_ip

2018-03-20 Thread Neels Hofmeyr

Patch Set 1:

In this instance I wasn't sure whether anything else wanted to also connect at 
127.0.0.1, listening on any interface would combine the two. But if there's 
nothing else it makes sense.

-- 
To view, visit https://gerrit.osmocom.org/7401
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3038481ed0bba1084b63dc6a6d2ff6e970100890
Gerrit-PatchSet: 1
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No


[PATCH] osmo-ttcn3-hacks[master]: add regression test for paging with unknown MCC/MNC

2018-03-20 Thread Stefan Sperling

Review at  https://gerrit.osmocom.org/7403

add regression test for paging with unknown MCC/MNC

Verify that the BSC does not page a subscriber when a cell identifier
with an unknown MCC/MNC is provided by the MSC.

This test introduces a magic value which represents an unknown MCC/MNC
combination: MCC=678 MNC=f90

Change-Id: I0b0af14a9a1cb7e5a7a4ec12cc489473fd7ead02
Related: OS#2980
---
M bsc/BSC_Tests.cfg
M bsc/BSC_Tests.ttcn
2 files changed, 11 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/03/7403/1

diff --git a/bsc/BSC_Tests.cfg b/bsc/BSC_Tests.cfg
index ef6823c..175654a 100644
--- a/bsc/BSC_Tests.cfg
+++ b/bsc/BSC_Tests.cfg
@@ -65,6 +65,7 @@
 #BSC_Tests.TC_paging_imsi_a_reset
 #BSC_Tests.TC_paging_imsi_load
 #BSC_Tests.TC_paging_counter
+#BSC_Tests.TC_paging_imsi_nochan_cgi_unknown_cid
 #BSC_Tests.TC_rsl_drop_counter
 #BSC_Tests.TC_classmark
 #BSC_Tests.TC_unsol_ass_fail
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index a2111fd..3522358 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -966,6 +966,7 @@
GsmCellId   ci
 };
 private const Cell_Identity cid := { '001'H, '01'H, 1, 0 };
+private const Cell_Identity unknown_cid := { '678'H, 'f90'H, 1, 0 };
 
 type set of integer BtsIdList;
 
@@ -1180,6 +1181,14 @@
var template BSSMAP_FIELD_CellIdentificationList cid_list;
cid_list := { cIl_LAC := { } };
f_pageing_helper('0010116'H, cid_list, c_BtsId_none);
+   f_shutdown_helper();
+}
+
+/* Paging by CGI with unknown MCC/MNC: Verify nothing is paged. */
+testcase TC_paging_imsi_nochan_cgi_unknown_cid() runs on test_CT {
+   var template BSSMAP_FIELD_CellIdentificationList cid_list;
+   cid_list := { cIl_CGI := { ts_BSSMAP_CI_CGI(unknown_cid.mcc, 
unknown_cid.mnc, unknown_cid.lac, unknown_cid.ci) } };
+   f_pageing_helper('0010106'H, cid_list, c_BtsId_none);
f_shutdown_helper();
 }
 
@@ -1961,6 +1970,7 @@
execute( TC_paging_imsi_nochan_lac_rnc() );
execute( TC_paging_imsi_nochan_lacs() );
execute( TC_paging_imsi_nochan_lacs_empty() );
+   execute( TC_paging_imsi_nochan_cgi_unknown_cid() );
execute( TC_paging_imsi_a_reset() );
execute( TC_paging_imsi_load() );
execute( TC_paging_counter() );

-- 
To view, visit https://gerrit.osmocom.org/7403
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b0af14a9a1cb7e5a7a4ec12cc489473fd7ead02
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling 


[PATCH] osmo-ggsn[master]: remove the -f option from osmo-ggsn.service

2018-03-20 Thread Stefan Sperling

Review at  https://gerrit.osmocom.org/7402

remove the -f option from osmo-ggsn.service

This option was removed in dda21ed7d4a897c9284c69175d0da598598eae40
and the behaviour previously implied by -f has since been the default.

Change-Id: Iba13df713af03771739a4feff4b222a0c3352394
Related: OS#3044
---
M contrib/osmo-ggsn.service
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/02/7402/1

diff --git a/contrib/osmo-ggsn.service b/contrib/osmo-ggsn.service
index 10e3507..c75325d 100644
--- a/contrib/osmo-ggsn.service
+++ b/contrib/osmo-ggsn.service
@@ -5,7 +5,7 @@
 [Service]
 Type=simple
 Restart=always
-ExecStart=/usr/bin/osmo-ggsn -c /etc/osmocom/osmo-ggsn.cfg -f
+ExecStart=/usr/bin/osmo-ggsn -c /etc/osmocom/osmo-ggsn.cfg
 RestartSec=2
 RestartPreventExitStatus=1
 

-- 
To view, visit https://gerrit.osmocom.org/7402
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba13df713af03771739a4feff4b222a0c3352394
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling 


[ABANDON] openbsc[master]: libmsc/VTY: clean up the a3a8 command implementation

2018-03-20 Thread Vadim Yanitskiy
Vadim Yanitskiy has abandoned this change.

Change subject: libmsc/VTY: clean up the a3a8 command implementation
..


Abandoned

-- 
To view, visit https://gerrit.osmocom.org/7397
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia21d4c97c30505e1826aa401c5da180dd2ba27d2
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 


[PATCH] openbsc[master]: libmsc/auth.c: add Milenage algorithm support

2018-03-20 Thread Vadim Yanitskiy
Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/7399

to look at the new patch set (#2).

libmsc/auth.c: add Milenage algorithm support

Despite the current Milenage implementation in libosmogsm
does support 2G authentication, it has been disabled.
Let's enable it in order to support SIM cards
with Milenage algorithm set for 2G mode.

Change-Id: I519e6bb4eb37a5ac70556d580a18fcae62730a76
---
M openbsc/include/openbsc/gsm_data.h
M openbsc/include/openbsc/gsm_data_shared.h
M openbsc/src/libmsc/auth.c
M openbsc/src/libmsc/ctrl_commands.c
M openbsc/src/libmsc/vty_interface_layer3.c
M openbsc/tests/ctrl_test_runner.py
6 files changed, 19 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/99/7399/2

diff --git a/openbsc/include/openbsc/gsm_data.h 
b/openbsc/include/openbsc/gsm_data.h
index b823acc..9ed56e6 100644
--- a/openbsc/include/openbsc/gsm_data.h
+++ b/openbsc/include/openbsc/gsm_data.h
@@ -57,6 +57,7 @@
AUTH_ALGO_COMP128v1,
AUTH_ALGO_COMP128v2,
AUTH_ALGO_COMP128v3,
+   AUTH_ALGO_MILENAGE,
 };
 
 struct gsm_auth_info {
diff --git a/openbsc/include/openbsc/gsm_data_shared.h 
b/openbsc/include/openbsc/gsm_data_shared.h
index ddd5991..209fb1c 100644
--- a/openbsc/include/openbsc/gsm_data_shared.h
+++ b/openbsc/include/openbsc/gsm_data_shared.h
@@ -135,6 +135,7 @@
 #define A38_XOR_MIN_KEY_LEN12
 #define A38_XOR_MAX_KEY_LEN16
 #define A38_COMP128_KEY_LEN16
+#define A38_MILENAGE_KEY_LEN   16
 #define RSL_ENC_ALG_A5(x)  (x+1)
 #define MAX_EARFCN_LIST 32
 
diff --git a/openbsc/src/libmsc/auth.c b/openbsc/src/libmsc/auth.c
index 059d7b3..645349f 100644
--- a/openbsc/src/libmsc/auth.c
+++ b/openbsc/src/libmsc/auth.c
@@ -106,6 +106,9 @@
case AUTH_ALGO_XOR:
aud2g.algo = OSMO_AUTH_ALG_XOR;
break;
+   case AUTH_ALGO_MILENAGE:
+   aud2g.algo = OSMO_AUTH_ALG_MILENAGE;
+   break;
case AUTH_ALGO_COMP128v1:
aud2g.algo = OSMO_AUTH_ALG_COMP128v1;
break;
diff --git a/openbsc/src/libmsc/ctrl_commands.c 
b/openbsc/src/libmsc/ctrl_commands.c
index 8e4e8b6..924dbb5 100644
--- a/openbsc/src/libmsc/ctrl_commands.c
+++ b/openbsc/src/libmsc/ctrl_commands.c
@@ -45,6 +45,8 @@
return true;
if (strcasecmp(alg, "comp128v3") == 0)
return true;
+   if (strcasecmp(alg, "milenage") == 0)
+   return true;
return false;
 }
 
@@ -126,6 +128,8 @@
ainfo.auth_algo = AUTH_ALGO_COMP128v2;
else if (strcasecmp(alg, "comp128v3") == 0)
ainfo.auth_algo = AUTH_ALGO_COMP128v3;
+   else if (strcasecmp(alg, "milenage") == 0)
+   ainfo.auth_algo = AUTH_ALGO_MILENAGE;
 
rc = osmo_hexparse(ki, ainfo.a3a8_ki, 
sizeof(ainfo.a3a8_ki));
if (rc < 0) {
diff --git a/openbsc/src/libmsc/vty_interface_layer3.c 
b/openbsc/src/libmsc/vty_interface_layer3.c
index a97e1ec..4c2549d 100644
--- a/openbsc/src/libmsc/vty_interface_layer3.c
+++ b/openbsc/src/libmsc/vty_interface_layer3.c
@@ -775,10 +775,11 @@
return CMD_SUCCESS;
 }
 
-#define A3A8_ALG_TYPES "(none|xor|comp128v1|comp128v2|comp128v3)"
+#define A3A8_ALG_TYPES "(none|xor|milenage|comp128v1|comp128v2|comp128v3)"
 #define A3A8_ALG_HELP  \
"Use No A3A8 algorithm\n"   \
"Use XOR algorithm\n"   \
+   "Use Milenage algorithm\n"  \
"Use COMP128v1 algorithm\n" \
"Use COMP128v2 algorithm\n" \
"Use COMP128v3 algorithm\n"
@@ -810,6 +811,9 @@
ainfo.auth_algo = AUTH_ALGO_XOR;
minlen = A38_XOR_MIN_KEY_LEN;
maxlen = A38_XOR_MAX_KEY_LEN;
+   } else if (!strcasecmp(alg_str, "milenage")) {
+   ainfo.auth_algo = AUTH_ALGO_MILENAGE;
+   minlen = maxlen = A38_MILENAGE_KEY_LEN;
} else if (!strcasecmp(alg_str, "comp128v1")) {
ainfo.auth_algo = AUTH_ALGO_COMP128v1;
minlen = maxlen = A38_COMP128_KEY_LEN;
diff --git a/openbsc/tests/ctrl_test_runner.py 
b/openbsc/tests/ctrl_test_runner.py
index b63dd27..c4f67ef 100644
--- a/openbsc/tests/ctrl_test_runner.py
+++ b/openbsc/tests/ctrl_test_runner.py
@@ -506,6 +506,11 @@
 self.assertEquals(r['var'], 'subscriber-modify-v1')
 self.assertEquals(r['value'], 'OK')
 
+r = self.do_set('subscriber-modify-v1', 
'2620345,445566,milenage,00112233445566778899AABBCCDDEEFF')
+self.assertEquals(r['mtype'], 'SET_REPLY')
+self.assertEquals(r['var'], 'subscriber-modify-v1')
+self.assertEquals(r['value'], 'OK')
+
 r = self.do_set('subscriber-modify-v1', '2620345,445566,none')
 self.assertEquals(r['mtype'], 'SET_REPLY')
 self.assertEquals(r['var'], 

openbsc[master]: libmsc/VTY: clean up the a3a8 command implementation

2018-03-20 Thread Vadim Yanitskiy

Patch Set 1:

> I'm quite reluctant to merge openbsc.git patches that are not clear
 > bugfixes.  Nobody from the core developer team is doing any work on
 > it.  There is zero testing (whether automatic or manual).  Merging
 > non-bugfix patches risks introducing more bugs / breakage :/

Well, I think exactly this change doesn't affect the
further Milenage implementation, so we can avoid it.
I'll update the change set.

-- 
To view, visit https://gerrit.osmocom.org/7397
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia21d4c97c30505e1826aa401c5da180dd2ba27d2
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-HasComments: No


docker-playground[master]: fix ttcn3-bsc-test: BSC_Tests.cfg: set mp_test_ip

2018-03-20 Thread Harald Welte

Patch Set 1:

We normally always use explicit IP addresses rather than doing bind-all. This 
makes the setup easier to understand, IMHO. You look at the config file and 
know how things are - as opposed to seeing simply 0.0?0?0 everywhere and then 
having to combine that with Jenkins.sh in order to figure out what to use on 
the other end (osmo-bsc.cfg in this case).

-- 
To view, visit https://gerrit.osmocom.org/7401
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3038481ed0bba1084b63dc6a6d2ff6e970100890
Gerrit-PatchSet: 1
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-HasComments: No


[MERGED] docker-playground[master]: fix ttcn3-bsc-test: osmo-bsc.cfg: add mgw IP

2018-03-20 Thread Harald Welte
Harald Welte has submitted this change and it was merged.

Change subject: fix ttcn3-bsc-test: osmo-bsc.cfg: add mgw IP
..


fix ttcn3-bsc-test: osmo-bsc.cfg: add mgw IP

The osmo-bsc-main docker container is run in a separate docker container and
cannot reach the virtual MGW set up by the ttcn3-bsc-tests.

>From ttcn3-bsc-tests/jenkins.sh it is clear that the tests are run at IP
172.18.2.203. Add this as the 'mgw remote-ip' setting in
ttcn3-bsc-tests/osmo-bsc.cfg.

This fixes the first half of the disconnect between BSC and virtual MGW in this
docker setup. The second half is I3038481ed0bba1084b63dc6a6d2ff6e970100890.

Change-Id: Ib53f000ec7e717b14a3e5df6e803d3d0950b937f
---
M ttcn3-bsc-test/osmo-bsc.cfg
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/ttcn3-bsc-test/osmo-bsc.cfg b/ttcn3-bsc-test/osmo-bsc.cfg
index 142f0d7..9d0327e 100644
--- a/ttcn3-bsc-test/osmo-bsc.cfg
+++ b/ttcn3-bsc-test/osmo-bsc.cfg
@@ -362,6 +362,7 @@
  amr-config 5_15k forbidden
  amr-config 4_75k forbidden
  codec-list fr1 fr2 fr3
+ mgw remote-ip 172.18.2.203
 bsc
  mid-call-timeout 0
  no missing-msc-text

-- 
To view, visit https://gerrit.osmocom.org/7400
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib53f000ec7e717b14a3e5df6e803d3d0950b937f
Gerrit-PatchSet: 1
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 


docker-playground[master]: fix ttcn3-bsc-test: osmo-bsc.cfg: add mgw IP

2018-03-20 Thread Harald Welte

Patch Set 1: Code-Review+2 Verified+1

-- 
To view, visit https://gerrit.osmocom.org/7400
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib53f000ec7e717b14a3e5df6e803d3d0950b937f
Gerrit-PatchSet: 1
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-HasComments: No