Change in osmo-ci[master]: obs-nightly: introduce osmo-trx-debian8-jessie

[lynxis lazus]

lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10277 )

Change subject: obs-nightly: introduce osmo-trx-debian8-jessie
..

obs-nightly: introduce osmo-trx-debian8-jessie

A compatible package for debian8 as it does not support limesdr.
This patch depend on: I261302d2ed16e76540073589504e7426e23d00a1

Change-Id: I8477b580976b376ee5abdde98a651d47199ef6d9
---
M scripts/osmocom-nightly-packages.sh
1 file changed, 13 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  lynxis lazus: Verified



diff --git a/scripts/osmocom-nightly-packages.sh 
b/scripts/osmocom-nightly-packages.sh
index f2bf9b1..88b6812 100755
--- a/scripts/osmocom-nightly-packages.sh
+++ b/scripts/osmocom-nightly-packages.sh
@@ -134,6 +134,16 @@
   git checkout "$TAG"
 }

+create_osmo_trx_debian8_jessie() {
+  # The package must be already checked out via `checkout osmo-trx`
+  cd "$REPO"
+  cp -a osmo-trx osmo-trx-debian8-jessie
+  cd osmo-trx-debian8-jessie/
+  patch -p1 < debian/patches/build-for-debian8.patch
+  git commit -m 'auto-commit: allow debian8 to build' debian/
+  cd ..
+}
+
 build_osmocom() {
   BASE=$PWD
   DATA=$BASE/data
@@ -173,6 +183,8 @@
   checkout rtl-sdr
   checkout osmo-fl2k

+  create_osmo_trx_debian8_jessie
+
   build limesuite no_commit 
--git-upstream-tree=01e2d00c5005b85d1f94cca02881756a72e35e2a
   build libosmocore
   build libosmo-sccp
@@ -188,6 +200,7 @@
   build openbsc
   build osmo-pcap
   build osmo-trx
+  build osmo-trx-debian8-jessie
   build osmo-sip-connector
   build osmo-bts
   build osmo-pcu

--
To view, visit https://gerrit.osmocom.org/10277
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8477b580976b376ee5abdde98a651d47199ef6d9
Gerrit-Change-Number: 10277
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: lynxis lazus 

Change in osmo-ci[master]: obs-nightly: introduce osmo-trx-debian8-jessie

[lynxis lazus]

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/10277 )

Change subject: obs-nightly: introduce osmo-trx-debian8-jessie
..


Patch Set 2: Verified+1


--
To view, visit https://gerrit.osmocom.org/10277
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8477b580976b376ee5abdde98a651d47199ef6d9
Gerrit-Change-Number: 10277
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Fri, 10 Aug 2018 00:10:36 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: bssgp: introduce flush queue functions

[lynxis lazus]

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/10371 )

Change subject: bssgp: introduce flush queue functions
..


Patch Set 5:

> review comment to patch 2 still pending

what's missing exactly?


--
To view, visit https://gerrit.osmocom.org/10371
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29b6ad6742ddf9b0b58b4af37d9a1cf18e019325
Gerrit-Change-Number: 10371
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Fri, 10 Aug 2018 00:10:11 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bts[master]: send TCH/F fill frames in DTX mode (WIP)

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/10415 )

Change subject: send TCH/F fill frames in DTX mode (WIP)
..


Patch Set 1:

Specifically, this is what I am seeing:

osmo-bts: l1sap.c:793 000260/00/00/05/04 sending fill frame TCH chan_nr=9 
fn=260 dtx=enabled

ttcn3 test: Received DTX TCH fill frame with bad frame number: 268 (mod 104: 60)


--
To view, visit https://gerrit.osmocom.org/10415
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7bff00b8cf41dc1b0e6e668173bebce23be0d253
Gerrit-Change-Number: 10415
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Thu, 09 Aug 2018 18:28:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bts[master]: send TCH/F fill frames in DTX mode (WIP)

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/10415 )

Change subject: send TCH/F fill frames in DTX mode (WIP)
..


Patch Set 1:

This is WIP because the TTCN3 test TC_tch_sign_l2_fill_frame_dtxd is still 
failing with this diff.

I don't understand the reason for the failure.

The problem is that the TCH/F fill frame is received by the TTCN3 test in a 
frame number which is not in the set of required frame numbers % 104.
Hence the test fails with verdict "Unexpected L2 fill frame received on Um".

However, debug log which is written by this patch shows that the frame number 
used in my osmo-bts patch falls into the set of required frame numbers % 104.

Does anyone have an idea where this problem could be coming from?
Am I wrong in assuming that the frame number used in osmo-bts's 
l1sap_ph_rts_ind() should match the frame number received in TTCN3?


--
To view, visit https://gerrit.osmocom.org/10415
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7bff00b8cf41dc1b0e6e668173bebce23be0d253
Gerrit-Change-Number: 10415
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Thu, 09 Aug 2018 18:20:57 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bts[master]: send TCH/F fill frames in DTX mode (WIP)

[Stefan Sperling]

Stefan Sperling has uploaded this change for review. ( 
https://gerrit.osmocom.org/10415


Change subject: send TCH/F fill frames in DTX mode (WIP)
..

send TCH/F fill frames in DTX mode (WIP)

Send DTX TCH fill frames according to GSM 05.08, section 8.3.

Change-Id: I7bff00b8cf41dc1b0e6e668173bebce23be0d253
Related: OS#1950
---
M src/common/l1sap.c
1 file changed, 52 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/15/10415/1

diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 8d735e5..ed818cb 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -670,6 +670,19 @@
return 0;
 }

+ /* Determine whether we need to send a DTX TCH fill frame according to GSM 
05.08, section 8.3. */
+static bool is_required_tchf_fill_frame_dtx(uint32_t fn) {
+   /* On TCHF this subset of TDMA frames (mod 104) is always used for 
transmission during DTX: */
+   const int tchf_required_fn_dtx[] = { 52, 53, 54, 55, 56, 57, 58, 59 };
+   int i;
+
+   for (i = 0; i < ARRAY_SIZE(tchf_required_fn_dtx); i++) {
+   if (fn % 104 == tchf_required_fn_dtx[i])
+   return true;
+   }
+   return false;
+}
+
 /* PH-RTS-IND prim received from bts model */
 static int l1sap_ph_rts_ind(struct gsm_bts_trx *trx,
struct osmo_phsap_prim *l1sap, struct ph_data_param *rts_ind)
@@ -729,14 +742,18 @@
si = bts_sysinfo_get(trx->bts, _time);
if (si)
memcpy(p, si, GSM_MACBLOCK_LEN);
-   else
+   else {
memcpy(p, fill_frame, GSM_MACBLOCK_LEN);
+   DEBUGPGT(DL1P, _time, "sending fill frame BCCH 
chan_nr=%d fn=%u\n", chan_nr, fn);
+   }
} else if (!(chan_nr & 0x80)) { /* only TCH/F, TCH/H, SDCCH/4 and 
SDCCH/8 have C5 bit cleared */
+   bool dtxd = false;
lchan = get_active_lchan_by_chan_nr(trx, chan_nr);
if (!lchan) {
LOGPGT(DL1P, LOGL_ERROR, _time, "No lchan for 
PH-RTS.ind (chan_nr=%u)\n", chan_nr);
return 0;
}
+   dtxd = lchan->ts->trx->bts->dtxd;
if (L1SAP_IS_LINK_SACCH(link_id)) {
p = msgb_put(msg, GSM_MACBLOCK_LEN);
/* L1-header, if not set/modified by layer 1 */
@@ -756,20 +773,39 @@
if (si) {
/* The +2 is empty space where the DSP 
inserts the L1 hdr */
memcpy(p + 2, si, GSM_MACBLOCK_LEN - 2);
-   } else
+   } else {
memcpy(p + 2, fill_frame, 
GSM_MACBLOCK_LEN - 2);
-   } else if (L1SAP_IS_CHAN_SDCCH4(chan_nr) || 
L1SAP_IS_CHAN_SDCCH8(chan_nr) ||
-  (lchan->rsl_cmode == RSL_CMOD_SPD_SIGN && 
!lchan->ts->trx->bts->dtxd)) {
-   /*
-* SDCCH or TCH in signalling mode without DTX.
-*
-* Send fill frame according to GSM 05.08, 
section 8.3: "On the SDCCH and on the
-* half rate speech traffic channel in 
signalling only mode DTX is not allowed.
-* In these cases and during signalling on the 
TCH when DTX is not used, the same
-* L2 fill frame shall be transmitted in case 
there is nothing else to transmit."
-*/
+   DEBUGPGT(DL1P, _time, "sending fill 
frame SACCH chan_nr=%d fn=%u dtx=%s\n", chan_nr, fn, dtxd ? "enabled" : 
"disabled");
+   }
+   } else if (L1SAP_IS_CHAN_SDCCH4(chan_nr) || 
L1SAP_IS_CHAN_SDCCH8(chan_nr)) {
p = msgb_put(msg, GSM_MACBLOCK_LEN);
memcpy(p, fill_frame, GSM_MACBLOCK_LEN);
+   DEBUGPGT(DL1P, _time, "sending fill frame 
SDCCH chan_nr=%d fn=%u dtx=%s\n", chan_nr, fn, dtxd ? "enabled" : "disabled");
+   } else if (lchan->rsl_cmode == RSL_CMOD_SPD_SIGN) {
+   if (lchan->ts->trx->bts->dtxd) {
+   /*
+* TCH in signalling mode with DTX.
+* Send fill frame according to GSM 
05.08, section 8.3.
+*/
+   if (L1SAP_IS_CHAN_TCHF(chan_nr) && 
is_required_tchf_fill_frame_dtx(fn)) {
+   p = msgb_put(msg, 
GSM_MACBLOCK_LEN);
+   

Change in osmo-ttcn3-hacks[master]: update DTX fill frame test expectations

[Stefan Sperling]

Stefan Sperling has uploaded this change for review. ( 
https://gerrit.osmocom.org/10414


Change subject: update DTX fill frame test expectations
..

update DTX fill frame test expectations

Fix an off-by-one in frame number comparison: Ensure that we
won't stop testing until after fn + 104 has been received.

The DTX test case would never pass since the alt statement
was always repeated even if enough frames had been received.
Fix this by moving code which runs before frame fn + 104 is
received into an 'else' cause.

We receive SACCH frames in DTX mode so we must account for them.
Introduce separate counters for SACCH and non-SACCH fill frames
to make test failure diagnosis easier. Note that we cannot expect
a specific amount of SACCH frames during a particular test run
since their amount depends on what the current frame number window
happens to be. We can however add the counters for SACCH and
non-SACCH fill frames and obtain a meaningful result.

Change-Id: Ie573b54ab5654f027c470aa7a565d2b5b97dc74b
Related: OS#1950
---
M bts/BTS_Tests.ttcn
1 file changed, 38 insertions(+), 18 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/14/10414/1

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 890be91..923a8cc 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -3832,7 +3832,9 @@
var octetstring l2_fill_frame_sacch := substr(l2_fill_frame, 0, 
lengthof(l2_fill_frame) - 2);
var GsmFrameNumber first_fn;
var boolean is_first_frame := true;
-   var integer nfill_frames := 0;
+   var integer nfill_frames_sacch := 0;
+   var integer nfill_frames_nonsacch := 0;
+   var integer expected_fill_frames := 1; /* initial value causes test 
failure if not overridden */
const integer dtx_tchf_mod := 104;
/* Frames numbers (mod 104) for which a fill frame is expected on TCHF 
if DTX is enabled. */
var Integers required_tdma_frames_dtx_tchf := { 52, 53, 54, 55, 56, 57, 
58, 59 };
@@ -3872,32 +3874,47 @@
f_L1CTL_DM_REL_REQ(L1CTL, g_chan_nr);
setverdict(fail, "Received fill frame on 
non-TCH/F channel; DTX is only allowed on TCH/F!");
}
-   if (fn >= first_fn + dtx_tchf_mod) {
+   if (fn > first_fn + dtx_tchf_mod) {
T.stop;
f_rsl_chan_deact();
f_L1CTL_DM_REL_REQ(L1CTL, g_chan_nr);
-   /* With DTX enabled we can expect at least 1 
fill frame every 104 frames. */
-   if (nfill_frames < 1) {
-   setverdict(fail);
+
+   /* With DTX enabled we can expect at least 3 
fill frames for every 104 frames.
+* 2 SACCH, 1 TCH/F */
+   expected_fill_frames := 3;
+
+   if (nfill_frames_sacch + nfill_frames_nonsacch 
< expected_fill_frames) {
+   log("received only ", 
nfill_frames_sacch, "+", nfill_frames_nonsacch,
+   " (SACCH+other) out of ", 
expected_fill_frames, " expected fill frames");
+   setverdict(fail, "Not enough fill 
frames received");
} else {
setverdict(pass);
}
-   }
-   for (var integer i := 0; i < 
lengthof(required_tdma_frames_dtx_tchf); i := i + 1) {
-   if (fn mod dtx_tchf_mod == 
required_tdma_frames_dtx_tchf[i]) {
-   nfill_frames := nfill_frames + 1;
+   } else {
+   if (dl.dl_info.link_id.c == SACCH) {
+   nfill_frames_sacch := 
nfill_frames_sacch + 1;
repeat;
}
+   /* On DTX TCH/F channels, fill frames occur 
only for specific frame numbers mod 104. */
+   for (var integer i := 0; i < 
lengthof(required_tdma_frames_dtx_tchf); i := i + 1) {
+   if (fn mod dtx_tchf_mod == 
required_tdma_frames_dtx_tchf[i]) {
+   nfill_frames_nonsacch := 
nfill_frames_nonsacch + 1;
+   repeat;
+   }
+   }
+   log("Received DTX TCH fill frame with bad frame 
number: ", fn,
+   " (mod ", dtx_tchf_mod, ": ", fn mod 
dtx_tchf_mod, ")");
+   

Change in osmo-mgw[master]: add a VTY command which shows a specific mgcp endpoint

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/10022 )

Change subject: add a VTY command which shows a specific mgcp endpoint
..


Patch Set 1:

> Patch Set 1:
>
> ping?

There was no response from Neels yet to my question.


--
To view, visit https://gerrit.osmocom.org/10022
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5330e697ec34bf215de91d44209048a8dc226d51
Gerrit-Change-Number: 10022
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Thu, 09 Aug 2018 15:38:07 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #210

[jenkins]

See 


--
[...truncated 2.08 KB...]

+ ./configure
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking 

Change in osmo-gsm-tester[master]: bts_nanobts: Fix pwsup_list increasing its size every new test

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10411 )

Change subject: bts_nanobts: Fix pwsup_list increasing its size every new test
..

bts_nanobts: Fix pwsup_list increasing its size every new test

variables under class section are shared among all instances, and are
used unless the specific class instance attribute is set. As a result,
the same pwsup_list object was being re-used.

Take the chance to do the same with the _pcu var, since we want same
behavior for it.

See for reference: https://stackoverflow.com/a/1716730

Fixes: OS#3456
Change-Id: I3f6a9d64b35aec33430e90872f41c3d046653ce6
---
M src/osmo_gsm_tester/bts_nanobts.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_gsm_tester/bts_nanobts.py 
b/src/osmo_gsm_tester/bts_nanobts.py
index 7f0151f..a18f205 100644
--- a/src/osmo_gsm_tester/bts_nanobts.py
+++ b/src/osmo_gsm_tester/bts_nanobts.py
@@ -28,13 +28,13 @@

 class NanoBts(bts.Bts):

-pwsup_list = []
-_pcu = None
 ##
 # PROTECTED
 ##
 def __init__(self, suite_run, conf):
 super().__init__(suite_run, conf, 'nanobts_%s' % conf.get('label', 
'nolabel'), 'nanobts')
+self.pwsup_list = []
+self._pcu = None

 def _configure(self):
 if self.bsc is None:

--
To view, visit https://gerrit.osmocom.org/10411
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f6a9d64b35aec33430e90872f41c3d046653ce6
Gerrit-Change-Number: 10411
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-gsm-tester[master]: Cleanup of class scoped variables

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10413


Change subject: Cleanup of class scoped variables
..

Cleanup of class scoped variables

After bug described in OS#3456 and fixed in last commit, let's
categorize and place variables in its correct plac to avoid similar
issus. We leave under the class keyword (class scoped variables) the
attributes which are to be used as static class attributes. All other
ones are initialized during __init__(). This way w avoid scenarios in
which while using an object from an instance attribute we end up reading
a class scoped variable which is shared among all instances.

Change-Id: I5ad4cac34a9f49eaf42966c01c9c5a4d3f3e9dc8
---
M src/osmo_gsm_tester/bts.py
M src/osmo_gsm_tester/bts_octphy.py
M src/osmo_gsm_tester/bts_osmo.py
M src/osmo_gsm_tester/bts_osmotrx.py
M src/osmo_gsm_tester/bts_sysmo.py
M src/osmo_gsm_tester/esme.py
M src/osmo_gsm_tester/event_loop.py
M src/osmo_gsm_tester/modem.py
M src/osmo_gsm_tester/osmo_bsc.py
M src/osmo_gsm_tester/osmo_ggsn.py
M src/osmo_gsm_tester/osmo_hlr.py
M src/osmo_gsm_tester/osmo_mgcpgw.py
M src/osmo_gsm_tester/osmo_mgw.py
M src/osmo_gsm_tester/osmo_msc.py
M src/osmo_gsm_tester/osmo_nitb.py
M src/osmo_gsm_tester/osmo_sgsn.py
M src/osmo_gsm_tester/osmo_stp.py
M src/osmo_gsm_tester/osmocon.py
M src/osmo_gsm_tester/pcu.py
M src/osmo_gsm_tester/pcu_osmo.py
M src/osmo_gsm_tester/pcu_sysmo.py
M src/osmo_gsm_tester/process.py
M src/osmo_gsm_tester/sms.py
M src/osmo_gsm_tester/smsc.py
M src/osmo_gsm_tester/suite.py
M src/osmo_gsm_tester/test.py
M src/osmo_gsm_tester/trial.py
27 files changed, 92 insertions(+), 145 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/13/10413/1

diff --git a/src/osmo_gsm_tester/bts.py b/src/osmo_gsm_tester/bts.py
index 0f3ef1c..041b2bc 100644
--- a/src/osmo_gsm_tester/bts.py
+++ b/src/osmo_gsm_tester/bts.py
@@ -25,24 +25,21 @@
 from . import log, config, util, template, process, schema, pcu_osmo

 class Bts(log.Origin, metaclass=ABCMeta):
-suite_run = None
-conf = None
-bsc = None
-sgsn = None
-lac = None
-rac = None
-cellid = None
-bvci = None
-defaults_cfg_name = None
-_num_trx = 1
-_max_trx = None
-overlay_trx_list = []

 ##
 # PROTECTED
 ##
 def __init__(self, suite_run, conf, name, defaults_cfg_name):
 super().__init__(log.C_RUN, name)
+self.bsc = None
+self.sgsn = None
+self.lac = None
+self.rac = None
+self.cellid = None
+self.bvci = None
+self._num_trx = 1
+self._max_trx = None
+self.overlay_trx_list = []
 self.suite_run = suite_run
 self.conf = conf
 self.defaults_cfg_name = defaults_cfg_name
diff --git a/src/osmo_gsm_tester/bts_octphy.py 
b/src/osmo_gsm_tester/bts_octphy.py
index 318c30d..f1a0ce8 100644
--- a/src/osmo_gsm_tester/bts_octphy.py
+++ b/src/osmo_gsm_tester/bts_octphy.py
@@ -27,16 +27,14 @@
 ##
 # PROTECTED
 ##
-run_dir = None
-inst = None
-env = None

 BIN_BTS_OCTPHY = 'osmo-bts-octphy'
-
 CONF_BTS_OCTPHY = 'osmo-bts-octphy.cfg'

 def __init__(self, suite_run, conf):
 super().__init__(suite_run, conf, OsmoBtsOctphy.BIN_BTS_OCTPHY, 
'osmo_bts_octphy')
+self.run_dir = None
+self.inst = None
 self.env = {}
 self.values = {}

diff --git a/src/osmo_gsm_tester/bts_osmo.py b/src/osmo_gsm_tester/bts_osmo.py
index b9b7fef..32784bd 100644
--- a/src/osmo_gsm_tester/bts_osmo.py
+++ b/src/osmo_gsm_tester/bts_osmo.py
@@ -24,14 +24,14 @@
 from . import log, config, util, template, process, bts, pcu_osmo

 class OsmoBts(bts.Bts, metaclass=ABCMeta):
-proc_bts = None
-_pcu = None

 ##
 # PROTECTED
 ##
 def __init__(self, suite_run, conf, name, defaults_cfg_name):
 super().__init__(suite_run, conf, name, defaults_cfg_name)
+self._pcu = None
+self.proc_bts = None
 if len(self.pcu_socket_path().encode()) > 107:
 raise log.Error('Path for pcu socket is longer than max allowed 
len for unix socket path (107):', self.pcu_socket_path())

@@ -75,9 +75,9 @@
 ##
 # PROTECTED
 ##
-pcu_sk_tmp_dir = None

 def __init__(self, suite_run, conf, name, defaults_cfg_name):
+self.pcu_sk_tmp_dir = None
 super().__init__(suite_run, conf, name, defaults_cfg_name)

 
diff --git a/src/osmo_gsm_tester/bts_osmotrx.py 
b/src/osmo_gsm_tester/bts_osmotrx.py
index b9310f8..1584eb2 100644
--- a/src/osmo_gsm_tester/bts_osmotrx.py
+++ b/src/osmo_gsm_tester/bts_osmotrx.py
@@ -27,10 +27,6 @@
 ##
 # PROTECTED
 ##
-run_dir = None
-inst = None
-env = None
-trx = None

 BIN_BTS_TRX = 'osmo-bts-trx'
 BIN_PCU = 'osmo-pcu'
@@ -39,6 +35,9 @@

Change in docker-playground[master]: gr-gsm-master/Makefile: enable host USB access

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/10412


Change subject: gr-gsm-master/Makefile: enable host USB access
..

gr-gsm-master/Makefile: enable host USB access

Privileged USB access is required for direct communication
between the image's UHD driver and a host's USRP device.

Change-Id: I8170d2c31b4e28f6a406c50b10b7626f70f36d28
---
M gr-gsm-master/Makefile
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/12/10412/1

diff --git a/gr-gsm-master/Makefile b/gr-gsm-master/Makefile
index 8d0e10b..b030a43 100644
--- a/gr-gsm-master/Makefile
+++ b/gr-gsm-master/Makefile
@@ -1 +1,5 @@
+RUN_ARGS?= \
+   --privileged \
+   -v /dev/bus/usb:/dev/bus/usb
+
 include ../make/Makefile

--
To view, visit https://gerrit.osmocom.org/10412
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8170d2c31b4e28f6a406c50b10b7626f70f36d28
Gerrit-Change-Number: 10412
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 

Change in osmo-mgw[master]: add a VTY command which shows a specific mgcp endpoint

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10022 )

Change subject: add a VTY command which shows a specific mgcp endpoint
..


Patch Set 1:

ping?


--
To view, visit https://gerrit.osmocom.org/10022
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5330e697ec34bf215de91d44209048a8dc226d51
Gerrit-Change-Number: 10022
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Thu, 09 Aug 2018 11:56:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmocom-bb[master]: Minor Typo Fixes

[Harald Welte]

Harald Welte has abandoned this change. ( https://gerrit.osmocom.org/9209 )

Change subject: Minor Typo Fixes
..


Abandoned

no follow-up from submitter in 3 months, abandoning
--
To view, visit https://gerrit.osmocom.org/9209
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie5b1e0f23df23d5831059a1c3c9b16ee89963612
Gerrit-Change-Number: 9209
Gerrit-PatchSet: 1
Gerrit-Owner: Nikos Balkanas 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Pau Espin Pedrol 

Change in osmocom-bb[master]: Minor Typo Changes

[Harald Welte]

Harald Welte has abandoned this change. ( https://gerrit.osmocom.org/9210 )

Change subject: Minor Typo Changes
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/9210
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I69126638d81d98ce8236cae543515c8dc743f404
Gerrit-Change-Number: 9210
Gerrit-PatchSet: 1
Gerrit-Owner: Nikos Balkanas 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-bsc[master]: doc: update mgw settings in example config file

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10239 )

Change subject: doc: update mgw settings in example config file
..


Patch Set 1: Code-Review-1

do we want this? This would make it impossible to run bsc + msc on the same 
machine using the example configs, right?


--
To view, visit https://gerrit.osmocom.org/10239
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b1c5097d98ec2ab97d51f99b1105db3de85c75f
Gerrit-Change-Number: 10239
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Thu, 09 Aug 2018 11:53:42 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: doc: update mgw settings in example config file

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10240 )

Change subject: doc: update mgw settings in example config file
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10240
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17453e0d30eec757aba9530b63eb5d1539cbdffc
Gerrit-Change-Number: 10240
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Thu, 09 Aug 2018 11:52:51 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: doc: update mgw settings in example config file

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10240 )

Change subject: doc: update mgw settings in example config file
..

doc: update mgw settings in example config file

This example configuration files lack port settings for the mgcp
client. Lets explicitly assign a port for the MGW and a local port.
For the local port lets use the IETF port number + 1. The reason
for this is that the default config for osmo-bsc already uses the
IETF port and in osmo-bsc and osmo-msc run on the same machine in
many setups.

Change-Id: I17453e0d30eec757aba9530b63eb5d1539cbdffc
---
M doc/examples/osmo-msc/osmo-msc.cfg
M doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg
M doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg
3 files changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/doc/examples/osmo-msc/osmo-msc.cfg 
b/doc/examples/osmo-msc/osmo-msc.cfg
index 91c9eee..f80143d 100644
--- a/doc/examples/osmo-msc/osmo-msc.cfg
+++ b/doc/examples/osmo-msc/osmo-msc.cfg
@@ -14,6 +14,8 @@
  mm info 1
 msc
  mgw remote-ip 10.23.24.1
+ mgw remote-port 2427
+ mgw local-port 2728
  assign-tmsi
  auth-tuple-max-reuse-count 3
  auth-tuple-reuse-on-error 1
diff --git a/doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg 
b/doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg
index 0b9fd2a..39ca9d4 100644
--- a/doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg
+++ b/doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg
@@ -22,4 +22,6 @@
  cs7-instance-a 0
  cs7-instance-iu 0
  mgw remote-ip 10.23.24.1
+ mgw remote-port 2427
+ mgw local-port 2728
  assign-tmsi
diff --git a/doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg 
b/doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg
index 44ac3f8..2af1726 100644
--- a/doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg
+++ b/doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg
@@ -24,4 +24,6 @@
  cs7-instance-a 0
  cs7-instance-iu 1
  mgw remote-ip 10.23.24.1
+ mgw remote-port 2427
+ mgw local-port 2728
  assign-tmsi

--
To view, visit https://gerrit.osmocom.org/10240
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I17453e0d30eec757aba9530b63eb5d1539cbdffc
Gerrit-Change-Number: 10240
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in libosmocore[master]: bssgp: introduce flush queue functions

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10371 )

Change subject: bssgp: introduce flush queue functions
..


Patch Set 5:

review comment to patch 2 still pending


--
To view, visit https://gerrit.osmocom.org/10371
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29b6ad6742ddf9b0b58b4af37d9a1cf18e019325
Gerrit-Change-Number: 10371
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Thu, 09 Aug 2018 11:52:10 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in docker-playground[master]: Introduce Dockerfile for the GR-GSM project

[Vadim Yanitskiy]

Vadim Yanitskiy has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10410 )

Change subject: Introduce Dockerfile for the GR-GSM project
..

Introduce Dockerfile for the GR-GSM project

This change introduces a new sub-project - 'gr-gsm-master'.
It was decided to use Arch Linux as the base image, because it
provides the recent version of both UHD and GNU Radio without
tons of dependencies, such as Xorg.

Note: as there in no libosmocore package in Arch Linux, it will
be built from the latest source code.

Change-Id: I115b59dc9eaec5d132f3f64c4ee321173459e9ed
---
M Makefile
A gr-gsm-master/.release
A gr-gsm-master/Dockerfile
A gr-gsm-master/Makefile
4 files changed, 88 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Verified



diff --git a/Makefile b/Makefile
index 2cdbc58..f82e3f5 100644
--- a/Makefile
+++ b/Makefile
@@ -68,3 +68,7 @@
 .PHONY: m3ua-test
 m3ua-test: osmo-stp-master sigtran-tests
$(MAKE) -C m3ua-test
+
+.PHONY: gr-gsm-master
+gr-gsm-master:
+   $(MAKE) -C gr-gsm-master
diff --git a/gr-gsm-master/.release b/gr-gsm-master/.release
new file mode 100644
index 000..3e94f0e
--- /dev/null
+++ b/gr-gsm-master/.release
@@ -0,0 +1,2 @@
+release=0.0.0
+tag=gr-gsm-master-0.0.0
diff --git a/gr-gsm-master/Dockerfile b/gr-gsm-master/Dockerfile
new file mode 100644
index 000..e75d318
--- /dev/null
+++ b/gr-gsm-master/Dockerfile
@@ -0,0 +1,81 @@
+FROM   base/archlinux
+
+MAINTAINER Vadim Yanitskiy 
+
+ARGLIBOSMOCORE_BRANCH="master"
+ARGGR_GSM_BRANCH="fixeria/trx"
+
+# Build dependencies
+ENVBUILD_DEPS \
+   automake \
+   autoconf \
+   libtool \
+   pkgconf \
+   cmake \
+   make \
+   swig \
+   gcc
+
+# Sync pacman
+RUNpacman -Syu
+
+# Install persistent packages
+RUNpacman -S --needed --noconfirm \
+   gnuradio \
+   python2 \
+   python2-scipy \
+   python2-requests \
+   talloc \
+   boost
+
+# Download USRP firmware
+RUNuhd_images_downloader
+
+# Install build dependencies
+RUNpacman -S --needed --noconfirm \
+   $BUILD_DEPS
+
+# Make Python2 default
+RUNln -s /usr/bin/python2 /usr/bin/python
+
+# Install and configure git
+RUNpacman -S --needed --noconfirm git \
+   && git config --global user.email doc...@dock.er \
+   && git config --global user.name "Dock Er"
+
+WORKDIR/tmp
+
+# Download, build and install libosmocore
+RUNgit clone git://git.osmocom.org/libosmocore
+ADDhttp://git.osmocom.org/libosmocore/patch?h=$LIBOSMOCORE_BRANCH 
/tmp/commit-libosmocore
+
+RUNcd libosmocore \
+   && git fetch && git checkout -f -B $LIBOSMOCORE_BRANCH 
origin/$LIBOSMOCORE_BRANCH \
+   && autoreconf -fi \
+   && ./configure \
+   --disable-doxygen \
+   --disable-pcsc \
+   --prefix=/usr \
+   && make -j5 \
+   && make install \
+   && make distclean
+
+RUNgit clone git://git.osmocom.org/gr-gsm
+ADD http://git.osmocom.org/gr-gsm/patch?h=$GR_GSM_BRANCH /tmp/commit-gr-gsm
+
+RUNcd gr-gsm \
+   && git fetch && git checkout -f -B $GR_GSM_BRANCH origin/$GR_GSM_BRANCH 
\
+   && mkdir build/ \
+   && cd build/ \
+   && cmake \
+   -DCMAKE_INSTALL_PREFIX=/usr \
+   -Wno-dev \
+   ../ \
+   && make -j5 \
+   && make install \
+   && cd ../ \
+   && rm -rf build/
+
+# Remove build dependencies
+RUNpacman -Rs --noconfirm \
+   $BUILD_DEPS
diff --git a/gr-gsm-master/Makefile b/gr-gsm-master/Makefile
new file mode 100644
index 000..8d0e10b
--- /dev/null
+++ b/gr-gsm-master/Makefile
@@ -0,0 +1 @@
+include ../make/Makefile

--
To view, visit https://gerrit.osmocom.org/10410
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I115b59dc9eaec5d132f3f64c4ee321173459e9ed
Gerrit-Change-Number: 10410
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Piotr Krysik 
Gerrit-Reviewer: Vadim Yanitskiy 

Change in docker-playground[master]: Introduce Dockerfile for the GR-GSM project

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/10410 )

Change subject: Introduce Dockerfile for the GR-GSM project
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/10410
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I115b59dc9eaec5d132f3f64c4ee321173459e9ed
Gerrit-Change-Number: 10410
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Piotr Krysik 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 09 Aug 2018 11:51:26 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: sgsn: add TC_attach_gmm_attach_req_while_gmm_attach

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10392 )

Change subject: sgsn: add TC_attach_gmm_attach_req_while_gmm_attach
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/10392/1/sgsn/SGSN_Tests.ttcn
File sgsn/SGSN_Tests.ttcn:

https://gerrit.osmocom.org/#/c/10392/1/sgsn/SGSN_Tests.ttcn@1944
PS1, Line 1944: }
do you have a 'default activated altstep somewhere?  I'm asking as I don't see 
any "catch-all" clause here that would e.g. catch any other L3 PDU received 
from the SGSN.  In such situations, we would block until the guard timer times 
out and fail with a very nondescript error message.

As default-activated altsteps are somewhat un-obvious, an explicit altstep 
invocation like might be the best option. Avoids copying code around, while 
still making it explicit which alternatives exist in an alt{}

[] as_any_other_l3();



--
To view, visit https://gerrit.osmocom.org/10392
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bac50dc5a72ba8f9010b05bcb98aa7ff0b81cf6
Gerrit-Change-Number: 10392
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Thu, 09 Aug 2018 11:13:51 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: sgsn: rework TC_attach_closed_add_vty to be executed in a single BSSG...

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10391 )

Change subject: sgsn: rework TC_attach_closed_add_vty to be executed in a 
single BSSGP_ConnHldr
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10391
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e5ae832f3908a172b9beb6d936074b806e0c799
Gerrit-Change-Number: 10391
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Thu, 09 Aug 2018 11:11:06 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: debian: add patches for debian8

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10276 )

Change subject: debian: add patches for debian8
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10276
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I261302d2ed16e76540073589504e7426e23d00a1
Gerrit-Change-Number: 10276
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Thu, 09 Aug 2018 11:09:52 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: debian: add patches for debian8

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10276 )

Change subject: debian: add patches for debian8
..

debian: add patches for debian8

The osmocom-nightly/release can create debian8 package by patching
rules and control files

Change-Id: I261302d2ed16e76540073589504e7426e23d00a1
---
A debian/patches/build-for-debian8.patch
A debian/patches/series
2 files changed, 58 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/debian/patches/build-for-debian8.patch 
b/debian/patches/build-for-debian8.patch
new file mode 100644
index 000..d44eb2f
--- /dev/null
+++ b/debian/patches/build-for-debian8.patch
@@ -0,0 +1,57 @@
+Index: osmo-trx/debian/control
+===
+--- osmo-trx.orig/debian/control
 osmo-trx/debian/control
+@@ -13,7 +13,6 @@ Build-Depends: debhelper (>= 9),
+libfftw3-dev,
+libtalloc-dev,
+libusrp-dev,
+-   liblimesuite-dev,
+libosmocore-dev (>= 0.10.0)
+ Standards-Version: 3.9.6
+ Vcs-Browser: http://cgit.osmocom.org/osmo-trx
+@@ -29,7 +28,7 @@ Package: osmo-trx-dbg
+ Architecture: any
+ Section: debug
+ Priority: extra
+-Depends: osmo-trx-uhd (= ${binary:Version}), osmo-trx-usrp1 (= 
${binary:Version}), osmo-trx-lms (= ${binary:Version}), ${misc:Depends}
++Depends: osmo-trx-uhd (= ${binary:Version}), osmo-trx-usrp1 (= 
${binary:Version}), ${misc:Depends}
+ Description: Debug symbols for the osmo-trx-*
+  Make debugging possible
+
+@@ -70,22 +70,3 @@ Description: SDR transceiver that implem
+  3GPP is the "3rd Generation Partnership Project" which is the collaboration
+  between different telecommunication associations for developing new
+  generations of mobile phone networks. (post-2G/GSM)
+-
+-Package: osmo-trx-lms
+-Architecture: any
+-Depends: ${shlibs:Depends}, ${misc:Depends}
+-Description: SDR transceiver that implements Layer 1 of a GSM BTS (LimeSuite)
+- OsmoTRX is a software-defined radio transceiver that implements the Layer 1
+- physical layer of a BTS comprising the following 3GPP specifications:
+- .
+- TS 05.01 "Physical layer on the radio path"
+- TS 05.02 "Multiplexing and Multiple Access on the Radio Path"
+- TS 05.04 "Modulation"
+- TS 05.10 "Radio subsystem synchronization"
+- .
+- In this context, BTS is "Base transceiver station". It's the stations that
+- connect mobile phones to the mobile network.
+- .
+- 3GPP is the "3rd Generation Partnership Project" which is the collaboration
+- between different telecommunication associations for developing new
+- generations of mobile phone networks. (post-2G/GSM)
+Index: osmo-trx/debian/rules
+===
+--- osmo-trx.orig/debian/rules
 osmo-trx/debian/rules
+@@ -9,7 +9,7 @@ override_dh_shlibdeps:
+   dh_shlibdeps --dpkg-shlibdeps-params=--ignore-missing-info
+
+ override_dh_auto_configure:
+-  dh_auto_configure -- --with-uhd --with-usrp1 --with-lms
++  dh_auto_configure -- --with-uhd --with-usrp1
+
+ override_dh_strip:
+   dh_strip --dbg-package=osmo-trx-dbg
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 000..82063b7
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+# build-for-debian8.patch

--
To view, visit https://gerrit.osmocom.org/10276
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I261302d2ed16e76540073589504e7426e23d00a1
Gerrit-Change-Number: 10276
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-ci[master]: obs-nightly: introduce osmo-trx-debian8-jessie

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10277 )

Change subject: obs-nightly: introduce osmo-trx-debian8-jessie
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10277
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8477b580976b376ee5abdde98a651d47199ef6d9
Gerrit-Change-Number: 10277
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Thu, 09 Aug 2018 11:09:27 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: add DTX fill frame BTS tests

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10372 )

Change subject: add DTX fill frame BTS tests
..

add DTX fill frame BTS tests

Add tests TC_tch_sign_l2_fill_frame and TC_tch_sign_l2_fill_frame_dtxd.

TC_tch_sign_l2_fill_frame is already passing and verifies that fill
frames are sent if there is nothing else to transmit on a SDCCH4/SDCCH8,
TCH/H, or TCH/F signalling channel where DTX is disabled for downlink.

TC_tch_sign_l2_fill_frame_dtxd is currently failing. It verifies that
only specific fill frames are sent, as required by GSM 05.08 for TCHF
signalling channels with DTX enabled for downlink. At present, our
implementation generates no fill frames in this case, which is one
piece of the problem described in issue OS#1950.

Change-Id: Id4e0de6e78b62cd408f600a57a28617d91da64af
Related: OS#1950
---
M bts/BTS_Tests.ttcn
M bts/expected-results.xml
M library/RSL_Types.ttcn
3 files changed, 196 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index fb6137c..890be91 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -3794,6 +3794,187 @@
f_assert_lapdm('03e00d063505'O, tr_LAPDm_I(0, true, false, 7, 0, 
'063505'O), "I/7/0");
 }

+/***
+ * DTX Related (see GSM 05.08, section 8.3)
+ ***/
+
+/* XXX These functions must be kept in sync with g_AllChannels defined on 
test_CT. */
+function f_g_chan_is_tchf() runs on ConnHdlr return boolean {
+   return (g_chan_nr == valueof(ts_RslChanNr_Bm(1)) or
+   g_chan_nr == valueof(ts_RslChanNr_Bm(2)) or
+   g_chan_nr == valueof(ts_RslChanNr_Bm(3)) or
+   g_chan_nr == valueof(ts_RslChanNr_Bm(4)));
+}
+function f_g_chan_is_tchh() runs on ConnHdlr return boolean {
+   return (g_chan_nr == valueof(ts_RslChanNr_Lm(5,0)) or
+   g_chan_nr == valueof(ts_RslChanNr_Lm(5,1)));
+}
+function f_g_chan_is_sdcch4() runs on ConnHdlr return boolean {
+   return (g_chan_nr == valueof(ts_RslChanNr_SDCCH4(0,0)) or
+   g_chan_nr == valueof(ts_RslChanNr_SDCCH4(0,1)) or
+   g_chan_nr == valueof(ts_RslChanNr_SDCCH4(0,2)) or
+   g_chan_nr == valueof(ts_RslChanNr_SDCCH4(0,3)));
+}
+function f_g_chan_is_sdcch8() runs on ConnHdlr return boolean {
+   return (g_chan_nr == valueof(ts_RslChanNr_SDCCH8(6,0)) or
+   g_chan_nr == valueof(ts_RslChanNr_SDCCH8(6,1)) or
+   g_chan_nr == valueof(ts_RslChanNr_SDCCH8(6,2)) or
+   g_chan_nr == valueof(ts_RslChanNr_SDCCH8(6,3)) or
+   g_chan_nr == valueof(ts_RslChanNr_SDCCH8(6,4)) or
+   g_chan_nr == valueof(ts_RslChanNr_SDCCH8(6,5)) or
+   g_chan_nr == valueof(ts_RslChanNr_SDCCH8(6,6)) or
+   g_chan_nr == valueof(ts_RslChanNr_SDCCH8(6,7)));
+}
+
+function f_test_l2_fill_frames(boolean dtxd) runs on ConnHdlr {
+   var L1ctlDlMessage dl;
+   var octetstring l2_fill_frame := 
'0303012B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B'O;
+   var octetstring l2_fill_frame_sacch := substr(l2_fill_frame, 0, 
lengthof(l2_fill_frame) - 2);
+   var GsmFrameNumber first_fn;
+   var boolean is_first_frame := true;
+   var integer nfill_frames := 0;
+   const integer dtx_tchf_mod := 104;
+   /* Frames numbers (mod 104) for which a fill frame is expected on TCHF 
if DTX is enabled. */
+   var Integers required_tdma_frames_dtx_tchf := { 52, 53, 54, 55, 56, 57, 
58, 59 };
+   timer T := 5.0;
+
+   f_l1_tune(L1CTL);
+   RSL.clear;
+   L1CTL.clear;
+
+   /* activate TCHF signalling channel */
+   f_est_dchan(false);
+
+   T.start;
+   alt {
+   [] L1CTL.receive(tr_L1CTL_DATA_IND(g_chan_nr, ?)) -> value dl {
+   var GsmFrameNumber fn := dl.dl_info.frame_nr;
+   var octetstring l2 := dl.payload.data_ind.payload;
+
+   if (is_first_frame) {
+   is_first_frame := false;
+   first_fn := dl.dl_info.frame_nr;
+   }
+
+   if (dl.dl_info.link_id.c == SACCH) {
+   l2 := substr(l2, 2, lengthof(l2) - 2); /* remove L1 
header */
+   if (not match(l2_fill_frame_sacch, l2)) {
+   repeat;
+   }
+   } else if (not match(l2_fill_frame, l2)) {
+   repeat;
+   }
+
+   if (dtxd) {
+   if (not f_g_chan_is_tchf()) {
+   T.stop;
+   f_rsl_chan_deact();
+   f_L1CTL_DM_REL_REQ(L1CTL, g_chan_nr);
+   setverdict(fail, 

Change in osmo-ttcn3-hacks[master]: add DTX fill frame BTS tests

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10372 )

Change subject: add DTX fill frame BTS tests
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10372
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4e0de6e78b62cd408f600a57a28617d91da64af
Gerrit-Change-Number: 10372
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Thu, 09 Aug 2018 11:08:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-mgw[master]: mgcp_client: check local port only once

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10408 )

Change subject: mgcp_client: check local port only once
..

mgcp_client: check local port only once

When the user has set a local port for the mgcp client we want the
client to exit if this port is already occupied. If no port is set the
IETF default port is configured automatically. When we find this port
occupied we try up to 100 times the next port to find a useable port.

Since the for loop that controls the attempts always sets the port
config it uses for its checks it will mistakenly assume that the user
has set a port on the second cycle.

- Make sure we only check for the default port in the first cycle

Change-Id: Ic1fd1018d68fcac94961321615bfdd726465532d
---
M src/libosmo-mgcp-client/mgcp_client.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/libosmo-mgcp-client/mgcp_client.c 
b/src/libosmo-mgcp-client/mgcp_client.c
index 3663163..c10abc9 100644
--- a/src/libosmo-mgcp-client/mgcp_client.c
+++ b/src/libosmo-mgcp-client/mgcp_client.c
@@ -801,7 +801,7 @@
 * configured then we assume that the user has choosen
 * that port conciously and we will not try to resolve
 * this by silently choosing a different port. */
-   if (mgcp->actual.local_port != MGCP_CLIENT_LOCAL_PORT_DEFAULT)
+   if (mgcp->actual.local_port != MGCP_CLIENT_LOCAL_PORT_DEFAULT 
&& i == 0)
return -EINVAL;

/* Choose a new port number to try next */

--
To view, visit https://gerrit.osmocom.org/10408
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1fd1018d68fcac94961321615bfdd726465532d
Gerrit-Change-Number: 10408
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-mgw[master]: mgcp_client: check local port only once

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10408 )

Change subject: mgcp_client: check local port only once
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10408
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1fd1018d68fcac94961321615bfdd726465532d
Gerrit-Change-Number: 10408
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Thu, 09 Aug 2018 11:06:26 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in mncc-python[master]: recommend stock Debian/Ubuntu package for fysom

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10409 )

Change subject: recommend stock Debian/Ubuntu package for fysom
..

recommend stock Debian/Ubuntu package for fysom

fysom is now available as a regular Debian/Ubuntu package
so there is no need anymore to install it via pip:
  https://packages.debian.org/stretch/python-fysom
  https://packages.ubuntu.com/bionic/python-fysom

Change-Id: I59e3b93c1d3f849f14dcb2344f6f033312331884
---
M README
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/README b/README
index e1f68be..4645559 100644
--- a/README
+++ b/README
@@ -12,9 +12,7 @@
 mncc-python needs python-pykka, and fysom.

 On Debian or Ubuntu you can install them via
-   sudo apt-get install python-pykka python-pip
-   sudo pip install fysom
-
+   sudo apt-get install python-pykka python-fysom

 = Getting the code =


--
To view, visit https://gerrit.osmocom.org/10409
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I59e3b93c1d3f849f14dcb2344f6f033312331884
Gerrit-Change-Number: 10409
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 

Change in mncc-python[master]: recommend stock Debian/Ubuntu package for fysom

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10409 )

Change subject: recommend stock Debian/Ubuntu package for fysom
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10409
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59e3b93c1d3f849f14dcb2344f6f033312331884
Gerrit-Change-Number: 10409
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Thu, 09 Aug 2018 11:05:53 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in mncc-python[master]: recommend stock Debian/Ubuntu package for fysom

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10409 )

Change subject: recommend stock Debian/Ubuntu package for fysom
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10409
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59e3b93c1d3f849f14dcb2344f6f033312331884
Gerrit-Change-Number: 10409
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Thu, 09 Aug 2018 11:05:49 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: Introduce Dockerfile for the GR-GSM project

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10410 )

Change subject: Introduce Dockerfile for the GR-GSM project
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10410
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I115b59dc9eaec5d132f3f64c4ee321173459e9ed
Gerrit-Change-Number: 10410
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Piotr Krysik 
Gerrit-Comment-Date: Thu, 09 Aug 2018 11:05:15 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: bts_nanobts: Fix pwsup_list increasing its size every new test

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10411 )

Change subject: bts_nanobts: Fix pwsup_list increasing its size every new test
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10411
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f6a9d64b35aec33430e90872f41c3d046653ce6
Gerrit-Change-Number: 10411
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Thu, 09 Aug 2018 11:04:30 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: bts_nanobts: Fix pwsup_list increasing its size every new test

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded a new patch set (#2). ( 
https://gerrit.osmocom.org/10411 )

Change subject: bts_nanobts: Fix pwsup_list increasing its size every new test
..

bts_nanobts: Fix pwsup_list increasing its size every new test

variables under class section are shared among all instances, and are
used unless the specific class instance attribute is set. As a result,
the same pwsup_list object was being re-used.

Take the chance to do the same with the _pcu var, since we want same
behavior for it.

See for reference: https://stackoverflow.com/a/1716730

Fixes: OS#3456
Change-Id: I3f6a9d64b35aec33430e90872f41c3d046653ce6
---
M src/osmo_gsm_tester/bts_nanobts.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/11/10411/2
--
To view, visit https://gerrit.osmocom.org/10411
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3f6a9d64b35aec33430e90872f41c3d046653ce6
Gerrit-Change-Number: 10411
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-gsm-tester[master]: bts_nanobts: Fix pwsup_list increasing its size every new test

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10411


Change subject: bts_nanobts: Fix pwsup_list increasing its size every new test
..

bts_nanobts: Fix pwsup_list increasing its size every new test

variables under class section are shared among all instances, and are
used unless the specific class instance attribute is set. As a result,
the same pwsup_list object was being re-used.

Take the chance to do the same with the _pcu var, since we want same
behavior for it.

See for reference: https://stackoverflow.com/a/1716730

Change-Id: I3f6a9d64b35aec33430e90872f41c3d046653ce6
---
M src/osmo_gsm_tester/bts_nanobts.py
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/11/10411/1

diff --git a/src/osmo_gsm_tester/bts_nanobts.py 
b/src/osmo_gsm_tester/bts_nanobts.py
index 7f0151f..a18f205 100644
--- a/src/osmo_gsm_tester/bts_nanobts.py
+++ b/src/osmo_gsm_tester/bts_nanobts.py
@@ -28,13 +28,13 @@

 class NanoBts(bts.Bts):

-pwsup_list = []
-_pcu = None
 ##
 # PROTECTED
 ##
 def __init__(self, suite_run, conf):
 super().__init__(suite_run, conf, 'nanobts_%s' % conf.get('label', 
'nolabel'), 'nanobts')
+self.pwsup_list = []
+self._pcu = None

 def _configure(self):
 if self.bsc is None:

--
To view, visit https://gerrit.osmocom.org/10411
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f6a9d64b35aec33430e90872f41c3d046653ce6
Gerrit-Change-Number: 10411
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in docker-playground[master]: Introduce Dockerfile for the GR-GSM project

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/10410


Change subject: Introduce Dockerfile for the GR-GSM project
..

Introduce Dockerfile for the GR-GSM project

This change introduces a new sub-project - 'gr-gsm-master'.
It was decided to use Arch Linux as the base image, because it
provides the recent version of both UHD and GNU Radio without
tons of dependencies, such as Xorg.

Note: as there in no libosmocore package in Arch Linux, it will
be built from the latest source code.

Change-Id: I115b59dc9eaec5d132f3f64c4ee321173459e9ed
---
M Makefile
A gr-gsm-master/.release
A gr-gsm-master/Dockerfile
A gr-gsm-master/Makefile
4 files changed, 88 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/10/10410/1

diff --git a/Makefile b/Makefile
index 2cdbc58..f82e3f5 100644
--- a/Makefile
+++ b/Makefile
@@ -68,3 +68,7 @@
 .PHONY: m3ua-test
 m3ua-test: osmo-stp-master sigtran-tests
$(MAKE) -C m3ua-test
+
+.PHONY: gr-gsm-master
+gr-gsm-master:
+   $(MAKE) -C gr-gsm-master
diff --git a/gr-gsm-master/.release b/gr-gsm-master/.release
new file mode 100644
index 000..3e94f0e
--- /dev/null
+++ b/gr-gsm-master/.release
@@ -0,0 +1,2 @@
+release=0.0.0
+tag=gr-gsm-master-0.0.0
diff --git a/gr-gsm-master/Dockerfile b/gr-gsm-master/Dockerfile
new file mode 100644
index 000..e75d318
--- /dev/null
+++ b/gr-gsm-master/Dockerfile
@@ -0,0 +1,81 @@
+FROM   base/archlinux
+
+MAINTAINER Vadim Yanitskiy 
+
+ARGLIBOSMOCORE_BRANCH="master"
+ARGGR_GSM_BRANCH="fixeria/trx"
+
+# Build dependencies
+ENVBUILD_DEPS \
+   automake \
+   autoconf \
+   libtool \
+   pkgconf \
+   cmake \
+   make \
+   swig \
+   gcc
+
+# Sync pacman
+RUNpacman -Syu
+
+# Install persistent packages
+RUNpacman -S --needed --noconfirm \
+   gnuradio \
+   python2 \
+   python2-scipy \
+   python2-requests \
+   talloc \
+   boost
+
+# Download USRP firmware
+RUNuhd_images_downloader
+
+# Install build dependencies
+RUNpacman -S --needed --noconfirm \
+   $BUILD_DEPS
+
+# Make Python2 default
+RUNln -s /usr/bin/python2 /usr/bin/python
+
+# Install and configure git
+RUNpacman -S --needed --noconfirm git \
+   && git config --global user.email doc...@dock.er \
+   && git config --global user.name "Dock Er"
+
+WORKDIR/tmp
+
+# Download, build and install libosmocore
+RUNgit clone git://git.osmocom.org/libosmocore
+ADDhttp://git.osmocom.org/libosmocore/patch?h=$LIBOSMOCORE_BRANCH 
/tmp/commit-libosmocore
+
+RUNcd libosmocore \
+   && git fetch && git checkout -f -B $LIBOSMOCORE_BRANCH 
origin/$LIBOSMOCORE_BRANCH \
+   && autoreconf -fi \
+   && ./configure \
+   --disable-doxygen \
+   --disable-pcsc \
+   --prefix=/usr \
+   && make -j5 \
+   && make install \
+   && make distclean
+
+RUNgit clone git://git.osmocom.org/gr-gsm
+ADD http://git.osmocom.org/gr-gsm/patch?h=$GR_GSM_BRANCH /tmp/commit-gr-gsm
+
+RUNcd gr-gsm \
+   && git fetch && git checkout -f -B $GR_GSM_BRANCH origin/$GR_GSM_BRANCH 
\
+   && mkdir build/ \
+   && cd build/ \
+   && cmake \
+   -DCMAKE_INSTALL_PREFIX=/usr \
+   -Wno-dev \
+   ../ \
+   && make -j5 \
+   && make install \
+   && cd ../ \
+   && rm -rf build/
+
+# Remove build dependencies
+RUNpacman -Rs --noconfirm \
+   $BUILD_DEPS
diff --git a/gr-gsm-master/Makefile b/gr-gsm-master/Makefile
new file mode 100644
index 000..8d0e10b
--- /dev/null
+++ b/gr-gsm-master/Makefile
@@ -0,0 +1 @@
+include ../make/Makefile

--
To view, visit https://gerrit.osmocom.org/10410
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I115b59dc9eaec5d132f3f64c4ee321173459e9ed
Gerrit-Change-Number: 10410
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 

Change in mncc-python[master]: recommend stock Debian/Ubuntu package for fysom

[Stefan Sperling]

Stefan Sperling has uploaded this change for review. ( 
https://gerrit.osmocom.org/10409


Change subject: recommend stock Debian/Ubuntu package for fysom
..

recommend stock Debian/Ubuntu package for fysom

fysom is now available as a regular Debian/Ubuntu package
so there is no need anymore to install it via pip:
  https://packages.debian.org/stretch/python-fysom
  https://packages.ubuntu.com/bionic/python-fysom

Change-Id: I59e3b93c1d3f849f14dcb2344f6f033312331884
---
M README
1 file changed, 1 insertion(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/mncc-python refs/changes/09/10409/1

diff --git a/README b/README
index e1f68be..4645559 100644
--- a/README
+++ b/README
@@ -12,9 +12,7 @@
 mncc-python needs python-pykka, and fysom.

 On Debian or Ubuntu you can install them via
-   sudo apt-get install python-pykka python-pip
-   sudo pip install fysom
-
+   sudo apt-get install python-pykka python-fysom

 = Getting the code =


--
To view, visit https://gerrit.osmocom.org/10409
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I59e3b93c1d3f849f14dcb2344f6f033312331884
Gerrit-Change-Number: 10409
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 

Change in osmo-mgw[master]: mgcp_client: check local port only once

[dexter]

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/10408


Change subject: mgcp_client: check local port only once
..

mgcp_client: check local port only once

When the user has set a local port for the mgcp client we want the
client to exit if this port is already occupied. If no port is set the
IETF default port is configured automatically. When we find this port
occupied we try up to 100 times the next port to find a useable port.

Since the for loop that controls the attempts always sets the port
config it uses for its checks it will mistakenly assume that the user
has set a port on the second cycle.

- Make sure we only check for the default port in the first cycle

Change-Id: Ic1fd1018d68fcac94961321615bfdd726465532d
---
M src/libosmo-mgcp-client/mgcp_client.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/08/10408/1

diff --git a/src/libosmo-mgcp-client/mgcp_client.c 
b/src/libosmo-mgcp-client/mgcp_client.c
index 3663163..c10abc9 100644
--- a/src/libosmo-mgcp-client/mgcp_client.c
+++ b/src/libosmo-mgcp-client/mgcp_client.c
@@ -801,7 +801,7 @@
 * configured then we assume that the user has choosen
 * that port conciously and we will not try to resolve
 * this by silently choosing a different port. */
-   if (mgcp->actual.local_port != MGCP_CLIENT_LOCAL_PORT_DEFAULT)
+   if (mgcp->actual.local_port != MGCP_CLIENT_LOCAL_PORT_DEFAULT 
&& i == 0)
return -EINVAL;

/* Choose a new port number to try next */

--
To view, visit https://gerrit.osmocom.org/10408
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1fd1018d68fcac94961321615bfdd726465532d
Gerrit-Change-Number: 10408
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 

Change in osmo-ttcn3-hacks[master]: add DTX fill frame BTS tests

[Stefan Sperling]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10372

to look at the new patch set (#3).

Change subject: add DTX fill frame BTS tests
..

add DTX fill frame BTS tests

Add tests TC_tch_sign_l2_fill_frame and TC_tch_sign_l2_fill_frame_dtxd.

TC_tch_sign_l2_fill_frame is already passing and verifies that fill
frames are sent if there is nothing else to transmit on a SDCCH4/SDCCH8,
TCH/H, or TCH/F signalling channel where DTX is disabled for downlink.

TC_tch_sign_l2_fill_frame_dtxd is currently failing. It verifies that
only specific fill frames are sent, as required by GSM 05.08 for TCHF
signalling channels with DTX enabled for downlink. At present, our
implementation generates no fill frames in this case, which is one
piece of the problem described in issue OS#1950.

Change-Id: Id4e0de6e78b62cd408f600a57a28617d91da64af
Related: OS#1950
---
M bts/BTS_Tests.ttcn
M bts/expected-results.xml
M library/RSL_Types.ttcn
3 files changed, 196 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/72/10372/3
--
To view, visit https://gerrit.osmocom.org/10372
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id4e0de6e78b62cd408f600a57a28617d91da64af
Gerrit-Change-Number: 10372
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling 
Gerrit-CC: Harald Welte