Change in osmo-bts[master]: add vty config for GSMTAP-SAPI remote host (-i)

[Neels Hofmeyr]

Hello Vadim Yanitskiy, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10808

to look at the new patch set (#2).

Change subject: add vty config for GSMTAP-SAPI remote host (-i)
..

add vty config for GSMTAP-SAPI remote host (-i)

So far, the only way to configure the target for SAPI GSMTAP is to use the
cmdline argument -i. Add a vty command to allow configuring from cfg file.

Add 'bts 0' / 'gsmtap-remote-host HOSTNAME' and 'no gsmtap-remote-host'.

The -i option, if provided, overrides the cfg file option.

In order to set up the SAPI GSMTAP socket after reading the config file, shift
the socket init a bit further down in main.c.

BTW, if the user passed an -i option, the gsmtap host shows up in 'show
running-config' and hence will also appear in 'write file'.

Change-Id: I17676a21c4e0c9cbc88f2c5c53a39c6c6c473ca1
---
M include/osmo-bts/gsm_data_shared.h
M src/common/main.c
M src/common/vty.c
3 files changed, 52 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/08/10808/2
--
To view, visit https://gerrit.osmocom.org/10808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I17676a21c4e0c9cbc88f2c5c53a39c6c6c473ca1
Gerrit-Change-Number: 10808
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Harald Welte 
Gerrit-CC: Pau Espin Pedrol 

Change in osmo-bts[master]: add vty config for GSMTAP-SAPI host (-i)

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/10808 )

Change subject: add vty config for GSMTAP-SAPI host (-i)
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/10808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17676a21c4e0c9cbc88f2c5c53a39c6c6c473ca1
Gerrit-Change-Number: 10808
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Harald Welte 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Mon, 10 Sep 2018 01:02:50 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bsc[master]: ho fsm: handle RR HO Failure for inter-BSC outgoing

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10834 )

Change subject: ho fsm: handle RR HO Failure for inter-BSC outgoing
..

ho fsm: handle RR HO Failure for inter-BSC outgoing

Before, this would ignore the failure and hit a timeout instead. Rather handle
the event directly.

Change-Id: I21c43d2907d0413ef18ec43cf27f680ebecf9e82
---
M src/osmo-bsc/handover_fsm.c
1 file changed, 16 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c
index a42f10c..9d558bc 100644
--- a/src/osmo-bsc/handover_fsm.c
+++ b/src/osmo-bsc/handover_fsm.c
@@ -1025,6 +1025,18 @@
}
 }

+static void ho_out_fsm_wait_clear(struct osmo_fsm_inst *fi, uint32_t event, 
void *data)
+{
+   struct gsm_subscriber_connection *conn = ho_fi_conn(fi);
+   switch (event) {
+   case HO_EV_RR_HO_FAIL:
+   ho_fail(HO_RESULT_FAIL_RR_HO_FAIL, "Received RR Handover 
Failure message");
+   return;
+
+   default:
+   OSMO_ASSERT(false);
+   }
+}

 #define S(x)   (1 << (x))

@@ -1108,6 +1120,10 @@
},
[HO_OUT_ST_WAIT_CLEAR] = {
.name = "inter-BSC-OUT:WAIT_CLEAR",
+   .in_event_mask = 0
+   | S(HO_EV_RR_HO_FAIL)
+   ,
+   .action = ho_out_fsm_wait_clear,
},
 };


--
To view, visit https://gerrit.osmocom.org/10834
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I21c43d2907d0413ef18ec43cf27f680ebecf9e82
Gerrit-Change-Number: 10834
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 

Change in osmo-bsc[master]: lchan_fsm: allow late RTP release events without erroring

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10835 )

Change subject: lchan_fsm: allow late RTP release events without erroring
..

lchan_fsm: allow late RTP release events without erroring

Change-Id: Ia463f97402b957bd13a95d18d291d1c1f006f089
---
M src/osmo-bsc/lchan_fsm.c
1 file changed, 9 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index 7d47380..1ef7869 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -967,6 +967,10 @@
lchan_fsm_state_chg(LCHAN_ST_UNUSED);
break;

+   case LCHAN_EV_RTP_RELEASED:
+   /* ignore late lchan_rtp_fsm release events */
+   return;
+
default:
OSMO_ASSERT(false);
}
@@ -1119,6 +1123,7 @@
.name = "WAIT_BEFORE_RF_RELEASE",
.in_event_mask = 0
| S(LCHAN_EV_RLL_REL_IND) /* allow late REL_IND of 
SAPI[0] */
+   | S(LCHAN_EV_RTP_RELEASED) /* ignore late lchan_rtp_fsm 
release events */
,
.out_state_mask = 0
| S(LCHAN_ST_UNUSED)
@@ -1131,6 +1136,7 @@
.action = lchan_fsm_wait_rf_release_ack,
.in_event_mask = 0
| S(LCHAN_EV_RSL_RF_CHAN_REL_ACK)
+   | S(LCHAN_EV_RTP_RELEASED) /* ignore late lchan_rtp_fsm 
release events */
,
.out_state_mask = 0
| S(LCHAN_ST_UNUSED)
@@ -1140,6 +1146,9 @@
},
[LCHAN_ST_WAIT_AFTER_ERROR] = {
.name = "WAIT_AFTER_ERROR",
+   .in_event_mask = 0
+   | S(LCHAN_EV_RTP_RELEASED) /* ignore late lchan_rtp_fsm 
release events */
+   ,
.out_state_mask = 0
| S(LCHAN_ST_UNUSED)
,

--
To view, visit https://gerrit.osmocom.org/10835
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia463f97402b957bd13a95d18d291d1c1f006f089
Gerrit-Change-Number: 10835
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/armv7l

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  234s] No package 'libpcsclite' found
[  234s] simtrace2-remsim.o: In function `main':
[  234s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  234s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  234s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:772: undefined 
reference to `osim_uicc_sim_cic_profile'
[  234s] apdu_dispatch.o: In function `apdu_segment_in':
[  234s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  234s] /usr/src/packages/BUILD/host/apdu_dispatch.c:173: undefined reference 
to `osim_uicc_sim_cic_profile'
[  234s] collect2: error: ld returned 1 exit status
[  234s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  234s] make[2]: *** [simtrace2-remsim] Error 1
[  234s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  234s] Makefile:20: recipe for target 'utils' failed
[  234s] make[1]: *** [utils] Error 2
[  234s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  234s] dh_auto_build: make -j1 returned exit code 2
[  234s] debian/rules:4: recipe for target 'build' failed
[  234s] make: *** [build] Error 2
[  234s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  234s] 
[  234s] armbuild24 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sun Sep  9 
22:19:35 UTC 2018.
[  234s] 
[  234s] ### VM INTERACTION START ###
[  237s] [  224.716245] SysRq : Power Off
[  237s] [  224.717424] reboot: Power down
[  237s] ### VM INTERACTION END ###
[  237s] 
[  237s] armbuild24 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sun Sep  9 
22:19:38 UTC 2018.
[  237s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in libosmo-sccp[master]: Revert "Install systemd services with autotools"

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10855 )

Change subject: Revert "Install systemd services with autotools"
..


Patch Set 1:

We need to add "--with-systemdsystemunitdir=$prefix/lib/sytemd/system" or 
similar in osmo-ci build scripts, I'll do it tomorrow morning.


--
To view, visit https://gerrit.osmocom.org/10855
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I009825d293e7e7a6c48d10452c10b3bb6da3e684
Gerrit-Change-Number: 10855
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Assignee: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 09 Sep 2018 20:34:45 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  169s] No package 'libpcsclite' found
[  169s] simtrace2-remsim.o: In function `main':
[  169s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  169s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  169s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  169s] apdu_dispatch.o: In function `apdu_segment_in':
[  169s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  169s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  169s] collect2: error: ld returned 1 exit status
[  169s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  169s] make[2]: *** [simtrace2-remsim] Error 1
[  169s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  169s] Makefile:20: recipe for target 'utils' failed
[  169s] make[1]: *** [utils] Error 2
[  169s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  169s] dh_auto_build: make -j1 returned exit code 2
[  169s] debian/rules:4: recipe for target 'build' failed
[  169s] make: *** [build] Error 2
[  169s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  169s] 
[  169s] cloud122 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sun Sep  9 
19:58:05 UTC 2018.
[  169s] 
[  169s] ### VM INTERACTION START ###
[  172s] [  149.010531] sysrq: SysRq : Power Off
[  172s] [  149.022424] reboot: Power down
[  174s] ### VM INTERACTION END ###
[  174s] 
[  174s] cloud122 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sun Sep  9 
19:58:10 UTC 2018.
[  174s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_16.04/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  133s] No package 'libpcsclite' found
[  133s] simtrace2-remsim.o: In function `main':
[  133s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  133s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  133s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  133s] apdu_dispatch.o: In function `apdu_segment_in':
[  133s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  133s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  133s] collect2: error: ld returned 1 exit status
[  133s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  133s] make[2]: *** [simtrace2-remsim] Error 1
[  133s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  133s] Makefile:20: recipe for target 'utils' failed
[  133s] make[1]: *** [utils] Error 2
[  133s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  133s] dh_auto_build: make -j1 returned exit code 2
[  133s] debian/rules:4: recipe for target 'build' failed
[  133s] make: *** [build] Error 2
[  133s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  133s] 
[  133s] lamb03 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sun Sep  9 
19:57:32 UTC 2018.
[  133s] 
[  133s] ### VM INTERACTION START ###
[  136s] [  127.063976] sysrq: SysRq : Power Off
[  136s] [  127.075381] reboot: Power down
[  137s] ### VM INTERACTION END ###
[  137s] 
[  137s] lamb03 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sun Sep  9 
19:57:36 UTC 2018.
[  137s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_18.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  159s] No package 'libpcsclite' found
[  159s] simtrace2-remsim.o: In function `main':
[  159s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  159s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  159s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  159s] apdu_dispatch.o: In function `apdu_segment_in':
[  159s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  159s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  159s] collect2: error: ld returned 1 exit status
[  159s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  159s] make[2]: *** [simtrace2-remsim] Error 1
[  159s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  159s] Makefile:20: recipe for target 'utils' failed
[  159s] make[1]: *** [utils] Error 2
[  159s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  159s] dh_auto_build: make -j1 returned exit code 2
[  159s] debian/rules:4: recipe for target 'build' failed
[  159s] make: *** [build] Error 2
[  159s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  159s] 
[  159s] lamb62 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sun Sep  9 
19:57:10 UTC 2018.
[  159s] 
[  159s] ### VM INTERACTION START ###
[  162s] [  151.785922] sysrq: SysRq : Power Off
[  162s] [  151.793112] reboot: Power down
[  162s] ### VM INTERACTION END ###
[  162s] 
[  162s] lamb62 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sun Sep  9 
19:57:14 UTC 2018.
[  162s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_17.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  108s] No package 'libpcsclite' found
[  108s] simtrace2-remsim.o: In function `main':
[  108s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  108s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  108s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  108s] apdu_dispatch.o: In function `apdu_segment_in':
[  108s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  108s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  108s] collect2: error: ld returned 1 exit status
[  108s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  108s] make[2]: *** [simtrace2-remsim] Error 1
[  108s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  108s] Makefile:20: recipe for target 'utils' failed
[  108s] make[1]: *** [utils] Error 2
[  108s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  108s] dh_auto_build: make -j1 returned exit code 2
[  108s] debian/rules:4: recipe for target 'build' failed
[  108s] make: *** [build] Error 2
[  108s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  108s] 
[  108s] sheep83 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sun Sep  9 
19:56:59 UTC 2018.
[  108s] 
[  108s] ### VM INTERACTION START ###
[  112s] [  104.623132] sysrq: SysRq : Power Off
[  112s] [  104.629015] reboot: Power down
[  112s] ### VM INTERACTION END ###
[  112s] 
[  112s] sheep83 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sun Sep  9 
19:57:02 UTC 2018.
[  112s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/i586

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  138s] No package 'libpcsclite' found
[  138s] simtrace2-remsim.o: In function `main':
[  138s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  138s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  138s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  138s] apdu_dispatch.o: In function `apdu_segment_in':
[  138s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  138s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  138s] collect2: error: ld returned 1 exit status
[  138s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  138s] make[2]: *** [simtrace2-remsim] Error 1
[  138s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  138s] Makefile:20: recipe for target 'utils' failed
[  138s] make[1]: *** [utils] Error 2
[  138s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  138s] dh_auto_build: make -j1 returned exit code 2
[  138s] debian/rules:4: recipe for target 'build' failed
[  138s] make: *** [build] Error 2
[  138s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  138s] 
[  138s] lamb55 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sun Sep  9 
19:56:41 UTC 2018.
[  138s] 
[  138s] ### VM INTERACTION START ###
[  141s] [  130.362257] sysrq: SysRq : Power Off
[  141s] [  130.369976] reboot: Power down
[  141s] ### VM INTERACTION END ###
[  142s] 
[  142s] lamb55 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sun Sep  9 
19:56:46 UTC 2018.
[  142s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_17.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_17.10/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_17.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  135s] No package 'libpcsclite' found
[  135s] simtrace2-remsim.o: In function `main':
[  135s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  135s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  135s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  135s] apdu_dispatch.o: In function `apdu_segment_in':
[  135s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  135s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  135s] collect2: error: ld returned 1 exit status
[  135s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  135s] make[2]: *** [simtrace2-remsim] Error 1
[  135s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  135s] Makefile:20: recipe for target 'utils' failed
[  135s] make[1]: *** [utils] Error 2
[  135s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  135s] dh_auto_build: make -j1 returned exit code 2
[  135s] debian/rules:4: recipe for target 'build' failed
[  135s] make: *** [build] Error 2
[  135s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  135s] 
[  135s] lamb14 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sun Sep  9 
19:56:33 UTC 2018.
[  135s] 
[  135s] ### VM INTERACTION START ###
[  138s] [  128.905730] sysrq: SysRq : Power Off
[  138s] [  128.913386] reboot: Power down
[  138s] ### VM INTERACTION END ###
[  138s] 
[  138s] lamb14 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sun Sep  9 
19:56:36 UTC 2018.
[  138s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_16.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  138s] No package 'libpcsclite' found
[  138s] simtrace2-remsim.o: In function `main':
[  138s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  138s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  138s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  138s] apdu_dispatch.o: In function `apdu_segment_in':
[  138s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  138s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  138s] collect2: error: ld returned 1 exit status
[  138s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  138s] make[2]: *** [simtrace2-remsim] Error 1
[  138s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  138s] Makefile:20: recipe for target 'utils' failed
[  138s] make[1]: *** [utils] Error 2
[  138s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  138s] dh_auto_build: make -j1 returned exit code 2
[  138s] debian/rules:4: recipe for target 'build' failed
[  138s] make: *** [build] Error 2
[  138s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  138s] 
[  138s] lamb51 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sun Sep  9 
19:56:31 UTC 2018.
[  138s] 
[  138s] ### VM INTERACTION START ###
[  141s] [  131.158244] sysrq: SysRq : Power Off
[  141s] [  131.165260] reboot: Power down
[  141s] ### VM INTERACTION END ###
[  141s] 
[  141s] lamb51 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sun Sep  9 
19:56:35 UTC 2018.
[  141s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_18.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[   93s] No package 'libpcsclite' found
[   93s] simtrace2-remsim.o: In function `main':
[   93s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[   93s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[   93s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[   93s] apdu_dispatch.o: In function `apdu_segment_in':
[   93s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[   93s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[   93s] collect2: error: ld returned 1 exit status
[   93s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[   93s] make[2]: *** [simtrace2-remsim] Error 1
[   93s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[   93s] Makefile:20: recipe for target 'utils' failed
[   93s] make[1]: *** [utils] Error 2
[   93s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   93s] dh_auto_build: make -j1 returned exit code 2
[   93s] debian/rules:4: recipe for target 'build' failed
[   93s] make: *** [build] Error 2
[   93s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[   93s] 
[   93s] build82 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sun Sep  9 
19:56:34 UTC 2018.
[   93s] 
[   93s] ### VM INTERACTION START ###
[   96s] [   88.531769] sysrq: SysRq : Power Off
[   96s] [   88.534818] reboot: Power down
[   96s] ### VM INTERACTION END ###
[   96s] 
[   96s] build82 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sun Sep  9 
19:56:38 UTC 2018.
[   96s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Jenkins build is back to normal : master-openbsc » --disable-iu,--disable-mgcp-transcoding,--enable-smpp,osmocom-master-debian9 #2716

[jenkins]

See 

Jenkins build is back to normal : master-openbsc » --disable-iu,--enable-mgcp-transcoding,--enable-smpp,osmocom-master-debian9 #2716

[jenkins]

See 

Jenkins build is back to normal : master-osmo-iuh » a1=default,a2=default,a3=default,osmocom-master-debian9 #1985

[jenkins]

See 

Jenkins build is back to normal : master-osmo-bsc » a1=default,a2=default,a3=default,osmocom-master-debian9 #3428

[jenkins]

See 

Jenkins build is back to normal : master-osmo-msc » --enable-iu,a2=default,a3=default,osmocom-master-debian9 #5649

[jenkins]

See 

Jenkins build is back to normal : master-osmo-msc » --disable-iu,a2=default,a3=default,osmocom-master-debian9 #5649

[jenkins]

See 

Jenkins build is back to normal : master-osmo-sgsn » --enable-iu,a2=default,a3=default,osmocom-master-debian9 #5448

[jenkins]

See 

Change in libosmo-sccp[master]: Revert "Install systemd services with autotools"

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10855 )

Change subject: Revert "Install systemd services with autotools"
..

Revert "Install systemd services with autotools"

This reverts commit ba3da6d72564bb2c60f4f4a8d641b8a7b86d1f59.

That commit broke master-{osmo-iuh,osmo-msc,osmo-sgsn,openbsc,osmo-bsc}
build jobs with

make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/lib/systemd/system'
 /usr/bin/install -c -m 644 osmo-stp.service '/lib/systemd/system'
/usr/bin/install: cannot create regular file 
'/lib/systemd/system/osmo-stp.service': Permission denied
make[4]: *** [install-systemdsystemunitDATA] Error 1

Change-Id: I009825d293e7e7a6c48d10452c10b3bb6da3e684
---
M Makefile.am
M configure.ac
D contrib/Makefile.am
D contrib/systemd/Makefile.am
M debian/osmo-stp.install
A debian/osmo-stp.service
M debian/rules
7 files changed, 3 insertions(+), 29 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/Makefile.am b/Makefile.am
index 7d09259..3f4de13 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,16 +1,13 @@
 AUTOMAKE_OPTIONS = foreign dist-bzip2 1.6

 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include
-SUBDIRS = include src tests examples stp doc contrib
+SUBDIRS = include src tests examples stp doc

 pkgconfigdir = $(libdir)/pkgconfig
 pkgconfig_DATA = libosmo-sccp.pc libosmo-mtp.pc libosmo-sigtran.pc 
libosmo-xua.pc

 EXTRA_DIST = .version git-version-gen osmoappdesc.py doc/examples/osmo-stp.cfg

-DISTCHECK_CONFIGURE_FLAGS = \
-  --with-systemdsystemunitdir=$$dc_install_base/$(systemdsystemunitdir)
-
 @RELMAKE@

 BUILT_SOURCES = $(top_srcdir)/.version
diff --git a/configure.ac b/configure.ac
index af64bc0..c0cc488 100644
--- a/configure.ac
+++ b/configure.ac
@@ -98,21 +98,6 @@
 AC_PATH_PROG(DOXYGEN,doxygen,false)
 AM_CONDITIONAL(HAVE_DOXYGEN, test $DOXYGEN != false && test "x$doxygen" = 
"xyes")

-# https://www.freedesktop.org/software/systemd/man/daemon.html
-AC_ARG_WITH([systemdsystemunitdir],
- [AS_HELP_STRING([--with-systemdsystemunitdir=DIR], [Directory for systemd 
service files])],,
- [with_systemdsystemunitdir=auto])
-AS_IF([test "x$with_systemdsystemunitdir" = "xyes" -o 
"x$with_systemdsystemunitdir" = "xauto"], [
- def_systemdsystemunitdir=$($PKG_CONFIG --variable=systemdsystemunitdir 
systemd)
- AS_IF([test "x$def_systemdsystemunitdir" = "x"],
-   [AS_IF([test "x$with_systemdsystemunitdir" = "xyes"],
-[AC_MSG_ERROR([systemd support requested but pkg-config unable to query 
systemd package])])
-with_systemdsystemunitdir=no],
-   [with_systemdsystemunitdir="$def_systemdsystemunitdir"])])
-AS_IF([test "x$with_systemdsystemunitdir" != "xno"],
-  [AC_SUBST([systemdsystemunitdir], [$with_systemdsystemunitdir])])
-AM_CONDITIONAL([HAVE_SYSTEMD], [test "x$with_systemdsystemunitdir" != "xno"])
-
 AC_MSG_RESULT([CFLAGS="$CFLAGS"])
 AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"])

@@ -137,7 +122,5 @@
 stp/Makefile
 doc/Makefile
 doc/examples/Makefile
-contrib/Makefile
-contrib/systemd/Makefile
 Doxyfile
 Makefile)
diff --git a/contrib/Makefile.am b/contrib/Makefile.am
deleted file mode 100644
index 3439c97..000
--- a/contrib/Makefile.am
+++ /dev/null
@@ -1 +0,0 @@
-SUBDIRS = systemd
diff --git a/contrib/systemd/Makefile.am b/contrib/systemd/Makefile.am
deleted file mode 100644
index e7d846f..000
--- a/contrib/systemd/Makefile.am
+++ /dev/null
@@ -1,5 +0,0 @@
-if HAVE_SYSTEMD
-EXTRA_DIST = osmo-stp.service
-systemdsystemunit_DATA = \
-  osmo-stp.service
-endif
diff --git a/debian/osmo-stp.install b/debian/osmo-stp.install
index 2c250b0..b2f8077 100644
--- a/debian/osmo-stp.install
+++ b/debian/osmo-stp.install
@@ -1,3 +1,2 @@
-/lib/sytemd/system/osmo-stp.service
 /usr/bin/osmo-stp
 /usr/share/doc/libosmo-sccp/examples/osmo-stp/osmo-stp.cfg
diff --git a/debian/osmo-stp.service b/debian/osmo-stp.service
new file mode 12
index 000..55f37c2
--- /dev/null
+++ b/debian/osmo-stp.service
@@ -0,0 +1 @@
+../contrib/systemd/osmo-stp.service
\ No newline at end of file
diff --git a/debian/rules b/debian/rules
index c0c9f0c..bea0a76 100755
--- a/debian/rules
+++ b/debian/rules
@@ -24,7 +24,7 @@
dh_auto_test || (find . -name testsuite.log -exec cat {} \; ; false)

 override_dh_auto_configure:
-   dh_auto_configure -- --enable-static 
--with-systemdsystemunitdir=/lib/sytemd/system
+   dh_auto_configure -- --enable-static

 # Print test results in case of a failure
 override_dh_auto_test:

--
To view, visit https://gerrit.osmocom.org/10855
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I009825d293e7e7a6c48d10452c10b3bb6da3e684
Gerrit-Change-Number: 10855
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Assignee: Pau Espin 

Change in libosmo-sccp[master]: Revert "Install systemd services with autotools"

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10855 )

Change subject: Revert "Install systemd services with autotools"
..


Patch Set 1: Verified+1 Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10855
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I009825d293e7e7a6c48d10452c10b3bb6da3e684
Gerrit-Change-Number: 10855
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Assignee: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-CC: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 09 Sep 2018 18:21:21 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-sccp[master]: Revert "Install systemd services with autotools"

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/10855


Change subject: Revert "Install systemd services with autotools"
..

Revert "Install systemd services with autotools"

This reverts commit ba3da6d72564bb2c60f4f4a8d641b8a7b86d1f59.

That commit broke master-{osmo-iuh,osmo-msc,osmo-sgsn,openbsc,osmo-bsc}
build jobs with

make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/lib/systemd/system'
 /usr/bin/install -c -m 644 osmo-stp.service '/lib/systemd/system'
/usr/bin/install: cannot create regular file 
'/lib/systemd/system/osmo-stp.service': Permission denied
make[4]: *** [install-systemdsystemunitDATA] Error 1

Change-Id: I009825d293e7e7a6c48d10452c10b3bb6da3e684
---
M Makefile.am
M configure.ac
D contrib/Makefile.am
D contrib/systemd/Makefile.am
M debian/osmo-stp.install
A debian/osmo-stp.service
M debian/rules
7 files changed, 3 insertions(+), 29 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/55/10855/1

diff --git a/Makefile.am b/Makefile.am
index 7d09259..3f4de13 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,16 +1,13 @@
 AUTOMAKE_OPTIONS = foreign dist-bzip2 1.6

 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include
-SUBDIRS = include src tests examples stp doc contrib
+SUBDIRS = include src tests examples stp doc

 pkgconfigdir = $(libdir)/pkgconfig
 pkgconfig_DATA = libosmo-sccp.pc libosmo-mtp.pc libosmo-sigtran.pc 
libosmo-xua.pc

 EXTRA_DIST = .version git-version-gen osmoappdesc.py doc/examples/osmo-stp.cfg

-DISTCHECK_CONFIGURE_FLAGS = \
-  --with-systemdsystemunitdir=$$dc_install_base/$(systemdsystemunitdir)
-
 @RELMAKE@

 BUILT_SOURCES = $(top_srcdir)/.version
diff --git a/configure.ac b/configure.ac
index af64bc0..c0cc488 100644
--- a/configure.ac
+++ b/configure.ac
@@ -98,21 +98,6 @@
 AC_PATH_PROG(DOXYGEN,doxygen,false)
 AM_CONDITIONAL(HAVE_DOXYGEN, test $DOXYGEN != false && test "x$doxygen" = 
"xyes")

-# https://www.freedesktop.org/software/systemd/man/daemon.html
-AC_ARG_WITH([systemdsystemunitdir],
- [AS_HELP_STRING([--with-systemdsystemunitdir=DIR], [Directory for systemd 
service files])],,
- [with_systemdsystemunitdir=auto])
-AS_IF([test "x$with_systemdsystemunitdir" = "xyes" -o 
"x$with_systemdsystemunitdir" = "xauto"], [
- def_systemdsystemunitdir=$($PKG_CONFIG --variable=systemdsystemunitdir 
systemd)
- AS_IF([test "x$def_systemdsystemunitdir" = "x"],
-   [AS_IF([test "x$with_systemdsystemunitdir" = "xyes"],
-[AC_MSG_ERROR([systemd support requested but pkg-config unable to query 
systemd package])])
-with_systemdsystemunitdir=no],
-   [with_systemdsystemunitdir="$def_systemdsystemunitdir"])])
-AS_IF([test "x$with_systemdsystemunitdir" != "xno"],
-  [AC_SUBST([systemdsystemunitdir], [$with_systemdsystemunitdir])])
-AM_CONDITIONAL([HAVE_SYSTEMD], [test "x$with_systemdsystemunitdir" != "xno"])
-
 AC_MSG_RESULT([CFLAGS="$CFLAGS"])
 AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"])

@@ -137,7 +122,5 @@
 stp/Makefile
 doc/Makefile
 doc/examples/Makefile
-contrib/Makefile
-contrib/systemd/Makefile
 Doxyfile
 Makefile)
diff --git a/contrib/Makefile.am b/contrib/Makefile.am
deleted file mode 100644
index 3439c97..000
--- a/contrib/Makefile.am
+++ /dev/null
@@ -1 +0,0 @@
-SUBDIRS = systemd
diff --git a/contrib/systemd/Makefile.am b/contrib/systemd/Makefile.am
deleted file mode 100644
index e7d846f..000
--- a/contrib/systemd/Makefile.am
+++ /dev/null
@@ -1,5 +0,0 @@
-if HAVE_SYSTEMD
-EXTRA_DIST = osmo-stp.service
-systemdsystemunit_DATA = \
-  osmo-stp.service
-endif
diff --git a/debian/osmo-stp.install b/debian/osmo-stp.install
index 2c250b0..b2f8077 100644
--- a/debian/osmo-stp.install
+++ b/debian/osmo-stp.install
@@ -1,3 +1,2 @@
-/lib/sytemd/system/osmo-stp.service
 /usr/bin/osmo-stp
 /usr/share/doc/libosmo-sccp/examples/osmo-stp/osmo-stp.cfg
diff --git a/debian/osmo-stp.service b/debian/osmo-stp.service
new file mode 12
index 000..55f37c2
--- /dev/null
+++ b/debian/osmo-stp.service
@@ -0,0 +1 @@
+../contrib/systemd/osmo-stp.service
\ No newline at end of file
diff --git a/debian/rules b/debian/rules
index c0c9f0c..bea0a76 100755
--- a/debian/rules
+++ b/debian/rules
@@ -24,7 +24,7 @@
dh_auto_test || (find . -name testsuite.log -exec cat {} \; ; false)

 override_dh_auto_configure:
-   dh_auto_configure -- --enable-static 
--with-systemdsystemunitdir=/lib/sytemd/system
+   dh_auto_configure -- --enable-static

 # Print test results in case of a failure
 override_dh_auto_test:

--
To view, visit https://gerrit.osmocom.org/10855
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I009825d293e7e7a6c48d10452c10b3bb6da3e684
Gerrit-Change-Number: 10855
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Build failed in Jenkins: master-openbsc » --disable-iu,--enable-mgcp-transcoding,--enable-smpp,osmocom-master-debian9 #2715

[jenkins]

See 


--
[...truncated 195.62 KB...]
config.status: creating tests/xua/Makefile
config.status: creating tests/ss7/Makefile
config.status: creating examples/Makefile
config.status: creating stp/Makefile
config.status: creating doc/Makefile
config.status: creating doc/examples/Makefile
config.status: creating contrib/Makefile
config.status: creating contrib/systemd/Makefile
config.status: creating Doxyfile
config.status: creating Makefile
config.status: executing tests/atconfig commands
config.status: executing depfiles commands
config.status: executing libtool commands
+ make -j 8 install
echo 0.10.0.6-ba3d > .version-t && mv .version-t .version
make  install-recursive
make[1]: Entering directory '/build/deps/libosmo-sccp'
Making install in include
make[2]: Entering directory '/build/deps/libosmo-sccp/include'
Making install in sccp
make[3]: Entering directory '/build/deps/libosmo-sccp/include/sccp'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/sccp'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/sccp'
 /usr/bin/install -c -m 644 sccp_types.h sccp.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sccp'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/sccp'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/sccp'
Making install in mtp
make[3]: Entering directory '/build/deps/libosmo-sccp/include/mtp'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/mtp'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/mtp'
 /usr/bin/install -c -m 644 mtp_level3.h mtp_pcap.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/mtp'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/mtp'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/mtp'
Making install in osmocom
make[3]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
Making install in sigtran
make[4]: Entering directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[5]: Entering directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[5]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran'
 /bin/mkdir -p 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran/protocol'
 /usr/bin/install -c -m 644 xua_types.h xua_msg.h m2ua_types.h sccp_sap.h 
sigtran_sap.h sccp_helpers.h mtp_sap.h osmo_ss7.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran'
 /usr/bin/install -c -m 644 protocol/sua.h protocol/m3ua.h protocol/mtp.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran/protocol'
make[5]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
make[5]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
make[5]: Nothing to be done for 'install-exec-am'.
make[5]: Nothing to be done for 'install-data-am'.
make[5]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[3]: Entering directory '/build/deps/libosmo-sccp/include'
make[4]: Entering directory '/build/deps/libosmo-sccp/include'
make[4]: Nothing to be done for 'install-exec-am'.
make[4]: Nothing to be done for 'install-data-am'.
make[4]: Leaving directory '/build/deps/libosmo-sccp/include'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include'
make[2]: Leaving directory '/build/deps/libosmo-sccp/include'
Making install in src
make[2]: Entering directory '/build/deps/libosmo-sccp/src'
  CC   sccp.o
  CC   mtp_pcap.o
  CC   libxua_a-xua_msg.o
  CC   sccp_sap.lo
  CC   xua_msg.lo
  CC   sua.lo
  CC   sccp_helpers.lo
  CC   m3ua.lo
  CC   sccp2sua.lo
  CC   sccp_scrc.lo
  CC   sccp_sclc.lo
  CC   sccp_scoc.lo
  CC   sccp_user.lo
  CC   xua_rkm.lo
  CC   xua_default_lm_fsm.lo
sccp_scoc.c: In function 'scoc_fsm_active':
sccp_scoc.c:943:9: note: #pragma message: TODO: internal disco: send 
N-DISCONNECT.ind to user
 #pragma message ("TODO: internal disco: send N-DISCONNECT.ind to user")
 ^
  CC   osmo_ss7.lo
  CC   osmo_ss7_hmrt.lo
  CC   xua_asp_fsm.lo
  CC   xua_as_fsm.lo
  CC   osmo_ss7_vty.lo
  CC   sccp_vty.lo
  CC   ipa.lo
  AR   libsccp.a
  AR   libmtp.a
  AR   libxua.a
  CCLD libosmo-sigtran.la
make[3]: Entering directory '/build/deps/libosmo-sccp/src'
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/lib'
 

Build failed in Jenkins: master-openbsc » --disable-iu,--disable-mgcp-transcoding,--enable-smpp,osmocom-master-debian9 #2715

[jenkins]

See 


--
[...truncated 196.31 KB...]
config.status: creating tests/xua/Makefile
config.status: creating tests/ss7/Makefile
config.status: creating examples/Makefile
config.status: creating stp/Makefile
config.status: creating doc/Makefile
config.status: creating doc/examples/Makefile
config.status: creating contrib/Makefile
config.status: creating contrib/systemd/Makefile
config.status: creating Doxyfile
config.status: creating Makefile
config.status: executing tests/atconfig commands
config.status: executing depfiles commands
config.status: executing libtool commands
+ make -j 4 install
echo 0.10.0.6-ba3d > .version-t && mv .version-t .version
make  install-recursive
make[1]: Entering directory '/build/deps/libosmo-sccp'
Making install in include
make[2]: Entering directory '/build/deps/libosmo-sccp/include'
Making install in sccp
make[3]: Entering directory '/build/deps/libosmo-sccp/include/sccp'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/sccp'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/sccp'
 /usr/bin/install -c -m 644 sccp_types.h sccp.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sccp'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/sccp'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/sccp'
Making install in mtp
make[3]: Entering directory '/build/deps/libosmo-sccp/include/mtp'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/mtp'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/mtp'
 /usr/bin/install -c -m 644 mtp_level3.h mtp_pcap.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/mtp'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/mtp'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/mtp'
Making install in osmocom
make[3]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
Making install in sigtran
make[4]: Entering directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[5]: Entering directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[5]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran'
 /bin/mkdir -p 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran/protocol'
 /usr/bin/install -c -m 644 xua_types.h xua_msg.h m2ua_types.h sccp_sap.h 
sigtran_sap.h sccp_helpers.h mtp_sap.h osmo_ss7.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran'
 /usr/bin/install -c -m 644 protocol/sua.h protocol/m3ua.h protocol/mtp.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran/protocol'
make[5]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
make[5]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
make[5]: Nothing to be done for 'install-exec-am'.
make[5]: Nothing to be done for 'install-data-am'.
make[5]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[3]: Entering directory '/build/deps/libosmo-sccp/include'
make[4]: Entering directory '/build/deps/libosmo-sccp/include'
make[4]: Nothing to be done for 'install-exec-am'.
make[4]: Nothing to be done for 'install-data-am'.
make[4]: Leaving directory '/build/deps/libosmo-sccp/include'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include'
make[2]: Leaving directory '/build/deps/libosmo-sccp/include'
Making install in src
make[2]: Entering directory '/build/deps/libosmo-sccp/src'
  CC   sccp.o
  CC   mtp_pcap.o
  CC   libxua_a-xua_msg.o
  CC   sccp_sap.lo
  CC   sua.lo
  CC   m3ua.lo
  CC   xua_msg.lo
  CC   sccp_helpers.lo
  CC   sccp2sua.lo
  CC   sccp_scrc.lo
  CC   sccp_sclc.lo
  CC   sccp_scoc.lo
  CC   sccp_user.lo
sccp_scoc.c: In function 'scoc_fsm_active':
sccp_scoc.c:943:9: note: #pragma message: TODO: internal disco: send 
N-DISCONNECT.ind to user
 #pragma message ("TODO: internal disco: send N-DISCONNECT.ind to user")
 ^
  CC   xua_rkm.lo
  CC   xua_default_lm_fsm.lo
  CC   osmo_ss7.lo
  CC   osmo_ss7_hmrt.lo
  CC   xua_asp_fsm.lo
  CC   xua_as_fsm.lo
  CC   osmo_ss7_vty.lo
  CC   sccp_vty.lo
  CC   ipa.lo
  AR   libsccp.a
  AR   libmtp.a
  AR   libxua.a
  CCLD libosmo-sigtran.la
make[3]: Entering directory '/build/deps/libosmo-sccp/src'
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/lib'
 

Build failed in Jenkins: master-osmo-bsc » a1=default,a2=default,a3=default,osmocom-master-debian9 #3427

[jenkins]

See 


--
[...truncated 194.06 KB...]
config.status: creating tests/xua/Makefile
config.status: creating tests/ss7/Makefile
config.status: creating examples/Makefile
config.status: creating stp/Makefile
config.status: creating doc/Makefile
config.status: creating doc/examples/Makefile
config.status: creating contrib/Makefile
config.status: creating contrib/systemd/Makefile
config.status: creating Doxyfile
config.status: creating Makefile
config.status: executing tests/atconfig commands
config.status: executing depfiles commands
config.status: executing libtool commands
+ make -j 8 install
echo 0.10.0.6-ba3d > .version-t && mv .version-t .version
make  install-recursive
make[1]: Entering directory '/build/deps/libosmo-sccp'
Making install in include
make[2]: Entering directory '/build/deps/libosmo-sccp/include'
Making install in sccp
make[3]: Entering directory '/build/deps/libosmo-sccp/include/sccp'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/sccp'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/sccp'
 /usr/bin/install -c -m 644 sccp_types.h sccp.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sccp'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/sccp'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/sccp'
Making install in mtp
make[3]: Entering directory '/build/deps/libosmo-sccp/include/mtp'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/mtp'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/mtp'
 /usr/bin/install -c -m 644 mtp_level3.h mtp_pcap.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/mtp'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/mtp'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/mtp'
Making install in osmocom
make[3]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
Making install in sigtran
make[4]: Entering directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[5]: Entering directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[5]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran'
 /bin/mkdir -p 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran/protocol'
 /usr/bin/install -c -m 644 xua_types.h xua_msg.h m2ua_types.h sccp_sap.h 
sigtran_sap.h sccp_helpers.h mtp_sap.h osmo_ss7.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran'
 /usr/bin/install -c -m 644 protocol/sua.h protocol/m3ua.h protocol/mtp.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran/protocol'
make[5]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
make[5]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
make[5]: Nothing to be done for 'install-exec-am'.
make[5]: Nothing to be done for 'install-data-am'.
make[5]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[3]: Entering directory '/build/deps/libosmo-sccp/include'
make[4]: Entering directory '/build/deps/libosmo-sccp/include'
make[4]: Nothing to be done for 'install-exec-am'.
make[4]: Nothing to be done for 'install-data-am'.
make[4]: Leaving directory '/build/deps/libosmo-sccp/include'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include'
make[2]: Leaving directory '/build/deps/libosmo-sccp/include'
Making install in src
make[2]: Entering directory '/build/deps/libosmo-sccp/src'
  CC   sccp.o
  CC   mtp_pcap.o
  CC   libxua_a-xua_msg.o
  CC   sccp_sap.lo
  CC   sua.lo
  CC   m3ua.lo
  CC   sccp_helpers.lo
  CC   xua_msg.lo
  CC   sccp2sua.lo
  CC   sccp_scrc.lo
  CC   sccp_sclc.lo
  CC   sccp_scoc.lo
  CC   sccp_user.lo
  CC   xua_rkm.lo
  CC   xua_default_lm_fsm.lo
sccp_scoc.c: In function 'scoc_fsm_active':
sccp_scoc.c:943:9: note: #pragma message: TODO: internal disco: send 
N-DISCONNECT.ind to user
 #pragma message ("TODO: internal disco: send N-DISCONNECT.ind to user")
 ^
  CC   osmo_ss7.lo
  CC   osmo_ss7_hmrt.lo
  CC   xua_asp_fsm.lo
  CC   xua_as_fsm.lo
  CC   osmo_ss7_vty.lo
  CC   sccp_vty.lo
  CC   ipa.lo
  AR   libsccp.a
  AR   libmtp.a
  AR   libxua.a
  CCLD libosmo-sigtran.la
make[3]: Entering directory '/build/deps/libosmo-sccp/src'
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/lib'
 /bin/mkdir -p 

Build failed in Jenkins: master-openbsc » --disable-iu,--disable-mgcp-transcoding,--enable-smpp,osmocom-master-debian9 #2714

[jenkins]

See 


--
[...truncated 196.29 KB...]
config.status: creating tests/xua/Makefile
config.status: creating tests/ss7/Makefile
config.status: creating examples/Makefile
config.status: creating stp/Makefile
config.status: creating doc/Makefile
config.status: creating doc/examples/Makefile
config.status: creating contrib/Makefile
config.status: creating contrib/systemd/Makefile
config.status: creating Doxyfile
config.status: creating Makefile
config.status: executing tests/atconfig commands
config.status: executing depfiles commands
config.status: executing libtool commands
+ make -j 8 install
echo 0.10.0.6-ba3d > .version-t && mv .version-t .version
make  install-recursive
make[1]: Entering directory '/build/deps/libosmo-sccp'
Making install in include
make[2]: Entering directory '/build/deps/libosmo-sccp/include'
Making install in sccp
make[3]: Entering directory '/build/deps/libosmo-sccp/include/sccp'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/sccp'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/sccp'
 /usr/bin/install -c -m 644 sccp_types.h sccp.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sccp'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/sccp'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/sccp'
Making install in mtp
make[3]: Entering directory '/build/deps/libosmo-sccp/include/mtp'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/mtp'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/mtp'
 /usr/bin/install -c -m 644 mtp_level3.h mtp_pcap.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/mtp'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/mtp'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/mtp'
Making install in osmocom
make[3]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
Making install in sigtran
make[4]: Entering directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[5]: Entering directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[5]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran'
 /bin/mkdir -p 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran/protocol'
 /usr/bin/install -c -m 644 xua_types.h xua_msg.h m2ua_types.h sccp_sap.h 
sigtran_sap.h sccp_helpers.h mtp_sap.h osmo_ss7.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran'
 /usr/bin/install -c -m 644 protocol/sua.h protocol/m3ua.h protocol/mtp.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran/protocol'
make[5]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
make[5]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
make[5]: Nothing to be done for 'install-exec-am'.
make[5]: Nothing to be done for 'install-data-am'.
make[5]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[3]: Entering directory '/build/deps/libosmo-sccp/include'
make[4]: Entering directory '/build/deps/libosmo-sccp/include'
make[4]: Nothing to be done for 'install-exec-am'.
make[4]: Nothing to be done for 'install-data-am'.
make[4]: Leaving directory '/build/deps/libosmo-sccp/include'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include'
make[2]: Leaving directory '/build/deps/libosmo-sccp/include'
Making install in src
make[2]: Entering directory '/build/deps/libosmo-sccp/src'
  CC   sccp.o
  CC   mtp_pcap.o
  CC   libxua_a-xua_msg.o
  CC   sccp_sap.lo
  CC   sua.lo
  CC   m3ua.lo
  CC   xua_msg.lo
  CC   sccp_helpers.lo
  CC   sccp2sua.lo
  CC   sccp_scrc.lo
  CC   sccp_sclc.lo
  CC   sccp_scoc.lo
  CC   sccp_user.lo
sccp_scoc.c: In function 'scoc_fsm_active':
sccp_scoc.c:943:9: note: #pragma message: TODO: internal disco: send 
N-DISCONNECT.ind to user
 #pragma message ("TODO: internal disco: send N-DISCONNECT.ind to user")
 ^
  CC   xua_rkm.lo
  CC   xua_default_lm_fsm.lo
  CC   osmo_ss7.lo
  CC   osmo_ss7_hmrt.lo
  CC   xua_asp_fsm.lo
  CC   xua_as_fsm.lo
  CC   osmo_ss7_vty.lo
  CC   sccp_vty.lo
  CC   ipa.lo
  AR   libsccp.a
  AR   libmtp.a
  AR   libxua.a
  CCLD libosmo-sigtran.la
make[3]: Entering directory '/build/deps/libosmo-sccp/src'
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/lib'
 

Build failed in Jenkins: master-openbsc » --disable-iu,--enable-mgcp-transcoding,--enable-smpp,osmocom-master-debian9 #2714

[jenkins]

See 


--
[...truncated 196.28 KB...]
config.status: creating tests/xua/Makefile
config.status: creating tests/ss7/Makefile
config.status: creating examples/Makefile
config.status: creating stp/Makefile
config.status: creating doc/Makefile
config.status: creating doc/examples/Makefile
config.status: creating contrib/Makefile
config.status: creating contrib/systemd/Makefile
config.status: creating Doxyfile
config.status: creating Makefile
config.status: executing tests/atconfig commands
config.status: executing depfiles commands
config.status: executing libtool commands
+ make -j 8 install
echo 0.10.0.6-ba3d > .version-t && mv .version-t .version
make  install-recursive
make[1]: Entering directory '/build/deps/libosmo-sccp'
Making install in include
make[2]: Entering directory '/build/deps/libosmo-sccp/include'
Making install in sccp
make[3]: Entering directory '/build/deps/libosmo-sccp/include/sccp'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/sccp'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/sccp'
 /usr/bin/install -c -m 644 sccp_types.h sccp.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sccp'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/sccp'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/sccp'
Making install in mtp
make[3]: Entering directory '/build/deps/libosmo-sccp/include/mtp'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/mtp'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/mtp'
 /usr/bin/install -c -m 644 mtp_level3.h mtp_pcap.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/mtp'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/mtp'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/mtp'
Making install in osmocom
make[3]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
Making install in sigtran
make[4]: Entering directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[5]: Entering directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[5]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran/protocol'
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran'
 /usr/bin/install -c -m 644 xua_types.h xua_msg.h m2ua_types.h sccp_sap.h 
sigtran_sap.h sccp_helpers.h mtp_sap.h osmo_ss7.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran'
 /usr/bin/install -c -m 644 protocol/sua.h protocol/m3ua.h protocol/mtp.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran/protocol'
make[5]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
make[5]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
make[5]: Nothing to be done for 'install-exec-am'.
make[5]: Nothing to be done for 'install-data-am'.
make[5]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[3]: Entering directory '/build/deps/libosmo-sccp/include'
make[4]: Entering directory '/build/deps/libosmo-sccp/include'
make[4]: Nothing to be done for 'install-exec-am'.
make[4]: Nothing to be done for 'install-data-am'.
make[4]: Leaving directory '/build/deps/libosmo-sccp/include'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include'
make[2]: Leaving directory '/build/deps/libosmo-sccp/include'
Making install in src
make[2]: Entering directory '/build/deps/libosmo-sccp/src'
  CC   sccp.o
  CC   libxua_a-xua_msg.o
  CC   mtp_pcap.o
  CC   sccp_sap.lo
  CC   xua_msg.lo
  CC   sua.lo
  CC   sccp_helpers.lo
  CC   m3ua.lo
  CC   sccp2sua.lo
  CC   sccp_scrc.lo
  CC   sccp_sclc.lo
  CC   sccp_scoc.lo
  CC   sccp_user.lo
  CC   xua_rkm.lo
  CC   osmo_ss7.lo
  CC   xua_default_lm_fsm.lo
sccp_scoc.c: In function 'scoc_fsm_active':
sccp_scoc.c:943:9: note: #pragma message: TODO: internal disco: send 
N-DISCONNECT.ind to user
 #pragma message ("TODO: internal disco: send N-DISCONNECT.ind to user")
 ^
  CC   osmo_ss7_hmrt.lo
  CC   xua_asp_fsm.lo
  CC   xua_as_fsm.lo
  CC   osmo_ss7_vty.lo
  CC   sccp_vty.lo
  CC   ipa.lo
  AR   libsccp.a
  AR   libmtp.a
  AR   libxua.a
  CCLD libosmo-sigtran.la
make[3]: Entering directory '/build/deps/libosmo-sccp/src'
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/lib'
 

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,a2=default,a3=default,osmocom-master-debian9 #5447

[jenkins]

See 


--
[...truncated 299.24 KB...]
config.status: creating tests/xua/Makefile
config.status: creating tests/ss7/Makefile
config.status: creating examples/Makefile
config.status: creating stp/Makefile
config.status: creating doc/Makefile
config.status: creating doc/examples/Makefile
config.status: creating contrib/Makefile
config.status: creating contrib/systemd/Makefile
config.status: creating Doxyfile
config.status: creating Makefile
config.status: executing tests/atconfig commands
config.status: executing depfiles commands
config.status: executing libtool commands
+ make -j 8 install
echo 0.10.0.6-ba3d > .version-t && mv .version-t .version
make  install-recursive
make[1]: Entering directory '/build/deps/libosmo-sccp'
Making install in include
make[2]: Entering directory '/build/deps/libosmo-sccp/include'
Making install in sccp
make[3]: Entering directory '/build/deps/libosmo-sccp/include/sccp'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/sccp'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/sccp'
 /usr/bin/install -c -m 644 sccp_types.h sccp.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sccp'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/sccp'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/sccp'
Making install in mtp
make[3]: Entering directory '/build/deps/libosmo-sccp/include/mtp'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/mtp'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/mtp'
 /usr/bin/install -c -m 644 mtp_level3.h mtp_pcap.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/mtp'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/mtp'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/mtp'
Making install in osmocom
make[3]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
Making install in sigtran
make[4]: Entering directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[5]: Entering directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[5]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran'
 /bin/mkdir -p 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran/protocol'
 /usr/bin/install -c -m 644 xua_types.h xua_msg.h m2ua_types.h sccp_sap.h 
sigtran_sap.h sccp_helpers.h mtp_sap.h osmo_ss7.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran'
 /usr/bin/install -c -m 644 protocol/sua.h protocol/m3ua.h protocol/mtp.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran/protocol'
make[5]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
make[5]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
make[5]: Nothing to be done for 'install-exec-am'.
make[5]: Nothing to be done for 'install-data-am'.
make[5]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[3]: Entering directory '/build/deps/libosmo-sccp/include'
make[4]: Entering directory '/build/deps/libosmo-sccp/include'
make[4]: Nothing to be done for 'install-exec-am'.
make[4]: Nothing to be done for 'install-data-am'.
make[4]: Leaving directory '/build/deps/libosmo-sccp/include'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include'
make[2]: Leaving directory '/build/deps/libosmo-sccp/include'
Making install in src
make[2]: Entering directory '/build/deps/libosmo-sccp/src'
  CC   sccp.o
  CC   sccp_helpers.lo
  CC   mtp_pcap.o
  CC   sccp_sap.lo
  CC   libxua_a-xua_msg.o
  CC   sua.lo
  CC   m3ua.lo
  CC   xua_msg.lo
  CC   sccp2sua.lo
  CC   sccp_scrc.lo
  CC   sccp_sclc.lo
  CC   sccp_scoc.lo
  CC   sccp_user.lo
  CC   xua_rkm.lo
  CC   xua_default_lm_fsm.lo
sccp_scoc.c: In function 'scoc_fsm_active':
sccp_scoc.c:943:9: note: #pragma message: TODO: internal disco: send 
N-DISCONNECT.ind to user
 #pragma message ("TODO: internal disco: send N-DISCONNECT.ind to user")
 ^
  CC   osmo_ss7.lo
  CC   osmo_ss7_hmrt.lo
  CC   xua_asp_fsm.lo
  CC   xua_as_fsm.lo
  CC   osmo_ss7_vty.lo
  CC   sccp_vty.lo
  CC   ipa.lo
  AR   libsccp.a
  AR   libmtp.a
  AR   libxua.a
  CCLD libosmo-sigtran.la
make[3]: Entering directory '/build/deps/libosmo-sccp/src'
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/lib'
 /bin/mkdir -p 

Build failed in Jenkins: master-osmo-msc » --disable-iu,a2=default,a3=default,osmocom-master-debian9 #5648

[jenkins]

See 


--
[...truncated 196.14 KB...]
config.status: creating tests/xua/Makefile
config.status: creating tests/ss7/Makefile
config.status: creating examples/Makefile
config.status: creating stp/Makefile
config.status: creating doc/Makefile
config.status: creating doc/examples/Makefile
config.status: creating contrib/Makefile
config.status: creating contrib/systemd/Makefile
config.status: creating Doxyfile
config.status: creating Makefile
config.status: executing tests/atconfig commands
config.status: executing depfiles commands
config.status: executing libtool commands
+ make -j 8 install
echo 0.10.0.6-ba3d > .version-t && mv .version-t .version
make  install-recursive
make[1]: Entering directory '/build/deps/libosmo-sccp'
Making install in include
make[2]: Entering directory '/build/deps/libosmo-sccp/include'
Making install in sccp
make[3]: Entering directory '/build/deps/libosmo-sccp/include/sccp'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/sccp'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/sccp'
 /usr/bin/install -c -m 644 sccp_types.h sccp.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sccp'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/sccp'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/sccp'
Making install in mtp
make[3]: Entering directory '/build/deps/libosmo-sccp/include/mtp'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/mtp'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/mtp'
 /usr/bin/install -c -m 644 mtp_level3.h mtp_pcap.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/mtp'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/mtp'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/mtp'
Making install in osmocom
make[3]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
Making install in sigtran
make[4]: Entering directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[5]: Entering directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[5]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran'
 /bin/mkdir -p 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran/protocol'
 /usr/bin/install -c -m 644 xua_types.h xua_msg.h m2ua_types.h sccp_sap.h 
sigtran_sap.h sccp_helpers.h mtp_sap.h osmo_ss7.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran'
 /usr/bin/install -c -m 644 protocol/sua.h protocol/m3ua.h protocol/mtp.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran/protocol'
make[5]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
make[5]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
make[5]: Nothing to be done for 'install-exec-am'.
make[5]: Nothing to be done for 'install-data-am'.
make[5]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[3]: Entering directory '/build/deps/libosmo-sccp/include'
make[4]: Entering directory '/build/deps/libosmo-sccp/include'
make[4]: Nothing to be done for 'install-exec-am'.
make[4]: Nothing to be done for 'install-data-am'.
make[4]: Leaving directory '/build/deps/libosmo-sccp/include'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include'
make[2]: Leaving directory '/build/deps/libosmo-sccp/include'
Making install in src
make[2]: Entering directory '/build/deps/libosmo-sccp/src'
  CC   sccp.o
  CC   mtp_pcap.o
  CC   libxua_a-xua_msg.o
  CC   sccp_sap.lo
  CC   xua_msg.lo
  CC   sccp_helpers.lo
  CC   sua.lo
  CC   m3ua.lo
  CC   sccp2sua.lo
  CC   sccp_scrc.lo
  CC   sccp_sclc.lo
  CC   sccp_scoc.lo
  CC   sccp_user.lo
  CC   xua_rkm.lo
  CC   xua_default_lm_fsm.lo
sccp_scoc.c: In function 'scoc_fsm_active':
sccp_scoc.c:943:9: note: #pragma message: TODO: internal disco: send 
N-DISCONNECT.ind to user
 #pragma message ("TODO: internal disco: send N-DISCONNECT.ind to user")
 ^
  CC   osmo_ss7.lo
  CC   osmo_ss7_hmrt.lo
  CC   xua_asp_fsm.lo
  CC   xua_as_fsm.lo
  CC   osmo_ss7_vty.lo
  CC   sccp_vty.lo
  CC   ipa.lo
  AR   libsccp.a
  AR   libmtp.a
  AR   libxua.a
  CCLD libosmo-sigtran.la
make[3]: Entering directory '/build/deps/libosmo-sccp/src'
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/lib'
 /bin/mkdir -p 

Build failed in Jenkins: master-osmo-msc » --enable-iu,a2=default,a3=default,osmocom-master-debian9 #5648

[jenkins]

See 


--
[...truncated 287.04 KB...]
config.status: creating tests/xua/Makefile
config.status: creating tests/ss7/Makefile
config.status: creating examples/Makefile
config.status: creating stp/Makefile
config.status: creating doc/Makefile
config.status: creating doc/examples/Makefile
config.status: creating contrib/Makefile
config.status: creating contrib/systemd/Makefile
config.status: creating Doxyfile
config.status: creating Makefile
config.status: executing tests/atconfig commands
config.status: executing depfiles commands
config.status: executing libtool commands
+ make -j 8 install
echo 0.10.0.6-ba3d > .version-t && mv .version-t .version
make  install-recursive
make[1]: Entering directory '/build/deps/libosmo-sccp'
Making install in include
make[2]: Entering directory '/build/deps/libosmo-sccp/include'
Making install in sccp
make[3]: Entering directory '/build/deps/libosmo-sccp/include/sccp'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/sccp'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/sccp'
 /usr/bin/install -c -m 644 sccp_types.h sccp.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sccp'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/sccp'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/sccp'
Making install in mtp
make[3]: Entering directory '/build/deps/libosmo-sccp/include/mtp'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/mtp'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/mtp'
 /usr/bin/install -c -m 644 mtp_level3.h mtp_pcap.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/mtp'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/mtp'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/mtp'
Making install in osmocom
make[3]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
Making install in sigtran
make[4]: Entering directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[5]: Entering directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[5]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran'
 /bin/mkdir -p 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran/protocol'
 /usr/bin/install -c -m 644 xua_types.h xua_msg.h m2ua_types.h sccp_sap.h 
sigtran_sap.h sccp_helpers.h mtp_sap.h osmo_ss7.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran'
 /usr/bin/install -c -m 644 protocol/sua.h protocol/m3ua.h protocol/mtp.h 
'/build/deps/install/stow/libosmo-sccp/include/osmocom/sigtran/protocol'
make[5]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom/sigtran'
make[4]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
make[5]: Entering directory '/build/deps/libosmo-sccp/include/osmocom'
make[5]: Nothing to be done for 'install-exec-am'.
make[5]: Nothing to be done for 'install-data-am'.
make[5]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[4]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include/osmocom'
make[3]: Entering directory '/build/deps/libosmo-sccp/include'
make[4]: Entering directory '/build/deps/libosmo-sccp/include'
make[4]: Nothing to be done for 'install-exec-am'.
make[4]: Nothing to be done for 'install-data-am'.
make[4]: Leaving directory '/build/deps/libosmo-sccp/include'
make[3]: Leaving directory '/build/deps/libosmo-sccp/include'
make[2]: Leaving directory '/build/deps/libosmo-sccp/include'
Making install in src
make[2]: Entering directory '/build/deps/libosmo-sccp/src'
  CC   sccp.o
  CC   mtp_pcap.o
  CC   xua_msg.lo
  CC   libxua_a-xua_msg.o
  CC   sua.lo
  CC   m3ua.lo
  CC   sccp_sap.lo
  CC   sccp_helpers.lo
  CC   sccp2sua.lo
  CC   sccp_scrc.lo
  CC   sccp_sclc.lo
  CC   sccp_scoc.lo
  CC   sccp_user.lo
  CC   xua_rkm.lo
  CC   xua_default_lm_fsm.lo
sccp_scoc.c: In function 'scoc_fsm_active':
sccp_scoc.c:943:9: note: #pragma message: TODO: internal disco: send 
N-DISCONNECT.ind to user
 #pragma message ("TODO: internal disco: send N-DISCONNECT.ind to user")
 ^
  CC   osmo_ss7.lo
  CC   osmo_ss7_hmrt.lo
  CC   xua_asp_fsm.lo
  CC   xua_as_fsm.lo
  CC   osmo_ss7_vty.lo
  CC   sccp_vty.lo
  CC   ipa.lo
  AR   libsccp.a
  AR   libmtp.a
  AR   libxua.a
  CCLD libosmo-sigtran.la
make[3]: Entering directory '/build/deps/libosmo-sccp/src'
 /bin/mkdir -p '/build/deps/install/stow/libosmo-sccp/lib'
 /bin/mkdir -p 

Build failed in Jenkins: master-osmo-iuh » a1=default,a2=default,a3=default,osmocom-master-debian9 #1984

[jenkins]

See 


--
[...truncated 331.13 KB...]
config.status: creating doc/Makefile
config.status: creating doc/examples/Makefile
config.status: creating contrib/Makefile
config.status: creating contrib/systemd/Makefile
config.status: creating Doxyfile
config.status: creating Makefile
config.status: executing tests/atconfig commands
config.status: executing depfiles commands
config.status: executing libtool commands
+ make -j 4 install
echo 0.10.0.6-ba3d > .version-t && mv .version-t .version
make  install-recursive
make[1]: Entering directory 
'
Making install in include
make[2]: Entering directory 
'
Making install in sccp
make[3]: Entering directory 
'
make[4]: Entering directory 
'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p 
'
 /usr/bin/install -c -m 644 sccp_types.h sccp.h 
'
make[4]: Leaving directory 
'
make[3]: Leaving directory 
'
Making install in mtp
make[3]: Entering directory 
'
make[4]: Entering directory 
'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p 
'
 /usr/bin/install -c -m 644 mtp_level3.h mtp_pcap.h 
'
make[4]: Leaving directory 
'
make[3]: Leaving directory 
'
Making install in osmocom
make[3]: Entering directory 
'
Making install in sigtran
make[4]: Entering directory 
'
make[5]: Entering directory 
'
make[5]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p 
'
 /bin/mkdir -p 
'
 /usr/bin/install -c -m 644 xua_types.h xua_msg.h m2ua_types.h sccp_sap.h 
sigtran_sap.h sccp_helpers.h mtp_sap.h osmo_ss7.h 
'
 /usr/bin/install -c -m 644 protocol/sua.h protocol/m3ua.h protocol/mtp.h 

Change in libosmo-sccp[master]: Install systemd services with autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10843 )

Change subject: Install systemd services with autotools
..

Install systemd services with autotools

Change-Id: Ie77ee4b32a75e2d207030ddc78d39fb664103d33
---
M Makefile.am
M configure.ac
A contrib/Makefile.am
A contrib/systemd/Makefile.am
M debian/osmo-stp.install
D debian/osmo-stp.service
M debian/rules
7 files changed, 29 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/Makefile.am b/Makefile.am
index 3f4de13..7d09259 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,13 +1,16 @@
 AUTOMAKE_OPTIONS = foreign dist-bzip2 1.6

 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include
-SUBDIRS = include src tests examples stp doc
+SUBDIRS = include src tests examples stp doc contrib

 pkgconfigdir = $(libdir)/pkgconfig
 pkgconfig_DATA = libosmo-sccp.pc libosmo-mtp.pc libosmo-sigtran.pc 
libosmo-xua.pc

 EXTRA_DIST = .version git-version-gen osmoappdesc.py doc/examples/osmo-stp.cfg

+DISTCHECK_CONFIGURE_FLAGS = \
+  --with-systemdsystemunitdir=$$dc_install_base/$(systemdsystemunitdir)
+
 @RELMAKE@

 BUILT_SOURCES = $(top_srcdir)/.version
diff --git a/configure.ac b/configure.ac
index c0cc488..af64bc0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -98,6 +98,21 @@
 AC_PATH_PROG(DOXYGEN,doxygen,false)
 AM_CONDITIONAL(HAVE_DOXYGEN, test $DOXYGEN != false && test "x$doxygen" = 
"xyes")

+# https://www.freedesktop.org/software/systemd/man/daemon.html
+AC_ARG_WITH([systemdsystemunitdir],
+ [AS_HELP_STRING([--with-systemdsystemunitdir=DIR], [Directory for systemd 
service files])],,
+ [with_systemdsystemunitdir=auto])
+AS_IF([test "x$with_systemdsystemunitdir" = "xyes" -o 
"x$with_systemdsystemunitdir" = "xauto"], [
+ def_systemdsystemunitdir=$($PKG_CONFIG --variable=systemdsystemunitdir 
systemd)
+ AS_IF([test "x$def_systemdsystemunitdir" = "x"],
+   [AS_IF([test "x$with_systemdsystemunitdir" = "xyes"],
+[AC_MSG_ERROR([systemd support requested but pkg-config unable to query 
systemd package])])
+with_systemdsystemunitdir=no],
+   [with_systemdsystemunitdir="$def_systemdsystemunitdir"])])
+AS_IF([test "x$with_systemdsystemunitdir" != "xno"],
+  [AC_SUBST([systemdsystemunitdir], [$with_systemdsystemunitdir])])
+AM_CONDITIONAL([HAVE_SYSTEMD], [test "x$with_systemdsystemunitdir" != "xno"])
+
 AC_MSG_RESULT([CFLAGS="$CFLAGS"])
 AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"])

@@ -122,5 +137,7 @@
 stp/Makefile
 doc/Makefile
 doc/examples/Makefile
+contrib/Makefile
+contrib/systemd/Makefile
 Doxyfile
 Makefile)
diff --git a/contrib/Makefile.am b/contrib/Makefile.am
new file mode 100644
index 000..3439c97
--- /dev/null
+++ b/contrib/Makefile.am
@@ -0,0 +1 @@
+SUBDIRS = systemd
diff --git a/contrib/systemd/Makefile.am b/contrib/systemd/Makefile.am
new file mode 100644
index 000..e7d846f
--- /dev/null
+++ b/contrib/systemd/Makefile.am
@@ -0,0 +1,5 @@
+if HAVE_SYSTEMD
+EXTRA_DIST = osmo-stp.service
+systemdsystemunit_DATA = \
+  osmo-stp.service
+endif
diff --git a/debian/osmo-stp.install b/debian/osmo-stp.install
index b2f8077..2c250b0 100644
--- a/debian/osmo-stp.install
+++ b/debian/osmo-stp.install
@@ -1,2 +1,3 @@
+/lib/sytemd/system/osmo-stp.service
 /usr/bin/osmo-stp
 /usr/share/doc/libosmo-sccp/examples/osmo-stp/osmo-stp.cfg
diff --git a/debian/osmo-stp.service b/debian/osmo-stp.service
deleted file mode 12
index 55f37c2..000
--- a/debian/osmo-stp.service
+++ /dev/null
@@ -1 +0,0 @@
-../contrib/systemd/osmo-stp.service
\ No newline at end of file
diff --git a/debian/rules b/debian/rules
index bea0a76..c0c9f0c 100755
--- a/debian/rules
+++ b/debian/rules
@@ -24,7 +24,7 @@
dh_auto_test || (find . -name testsuite.log -exec cat {} \; ; false)

 override_dh_auto_configure:
-   dh_auto_configure -- --enable-static
+   dh_auto_configure -- --enable-static 
--with-systemdsystemunitdir=/lib/sytemd/system

 # Print test results in case of a failure
 override_dh_auto_test:

--
To view, visit https://gerrit.osmocom.org/10843
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie77ee4b32a75e2d207030ddc78d39fb664103d33
Gerrit-Change-Number: 10843
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-bts[master]: CBCH: Fix rejecting SMS-CB related RSL messages

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10845 )

Change subject: CBCH: Fix rejecting SMS-CB related RSL messages
..

CBCH: Fix rejecting SMS-CB related RSL messages

Normally, the "Common Channel" related RSL messages should actually
contain such a common channel.  However, since cell broadcast is
implemented inside what's essentially a downlink SDCCH, we should add
some explicit exceptions.

Before this patch, any RSL SMS BC CMD would have been discarded and
an RSL Error Indiciation returned.

Change-Id: I2f7f1dd43505cc27cd33489d8b0e8c981cd93880
Closes: OS#3533
---
M src/common/rsl.c
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/rsl.c b/src/common/rsl.c
index ff2d997..c6c00ea 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -2725,8 +2725,12 @@
}
msg->l3h = (unsigned char *)cch + sizeof(*cch);

-   if (chan_nr_is_dchan(cch->chan_nr))
-   return rsl_reject_unknown_lchan(msg);
+   /* normally we don't permit dedicated channels here ... */
+   if (chan_nr_is_dchan(cch->chan_nr)) {
+   /* ... however, CBCH is on a SDCCH, so we must permit it */
+   if (cch->c.msg_type != RSL_MT_SMS_BC_CMD && cch->c.msg_type != 
RSL_MT_SMS_BC_REQ)
+   return rsl_reject_unknown_lchan(msg);
+   }

msg->lchan = lchan_lookup(trx, cch->chan_nr, "RSL rx CCHAN: ");
if (!msg->lchan) {

--
To view, visit https://gerrit.osmocom.org/10845
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f7f1dd43505cc27cd33489d8b0e8c981cd93880
Gerrit-Change-Number: 10845
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bts[master]: CBCH: Implement CBCH support for osmo-bts-{trx, virtual}

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10603 )

Change subject: CBCH: Implement CBCH support for osmo-bts-{trx,virtual}
..

CBCH: Implement CBCH support for osmo-bts-{trx,virtual}

This patch adds scheduler support for the channel combinations that
substitute SDCCH index 2 for a CBCH in either a SDCCH/8 or SDCCH/4.

Change-Id: Icc15603079a1709ec094f400a9bcf0008211890f
Closes: OS#1617
---
M README.md
M include/osmo-bts/scheduler.h
M src/common/scheduler.c
M src/common/scheduler_mframe.c
M src/osmo-bts-trx/main.c
M src/osmo-bts-virtual/main.c
6 files changed, 223 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/README.md b/README.md
index 43c27b2..38b4bd9 100644
--- a/README.md
+++ b/README.md
@@ -124,4 +124,3 @@
  * TCH/F_PDCH cannel not working as voice (https://osmocom.org/issues/1865)
  * No BER value delivered to OsmoPCU (https://osmocom.org/issues/1855)
  * No 11bit RACH support (https://osmocom.org/issues/1854)
- * No CBCH support (https://osmocom.org/issues/1617)
diff --git a/include/osmo-bts/scheduler.h b/include/osmo-bts/scheduler.h
index 3fe7978..32d6e91 100644
--- a/include/osmo-bts/scheduler.h
+++ b/include/osmo-bts/scheduler.h
@@ -47,6 +47,7 @@
TRXC_SACCH8_7,
TRXC_PDTCH,
TRXC_PTCCH,
+   TRXC_CBCH,
_TRX_CHAN_MAX
 };

diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index 5c250e4..8a6c007 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -116,6 +116,7 @@
  */

 const struct trx_chan_desc trx_chan_desc[_TRX_CHAN_MAX] = {
+  /*   is_pdch chan_type   chan_nr link_id name
rts_fn  dl_fn   ul_fn   auto_active */
   {0,  TRXC_IDLE,  0,  LID_DEDIC,  "IDLE", 
NULL,   tx_idle_fn, NULL,   1 },
   {0,  TRXC_FCCH,  0,  LID_DEDIC,  "FCCH", 
NULL,   tx_fcch_fn, NULL,   1 },
   {0,  TRXC_SCH,   0,  LID_DEDIC,  "SCH",  
NULL,   tx_sch_fn,  NULL,   1 },
@@ -154,6 +155,7 @@
   {0,  TRXC_SACCH8_7,  0x78,   LID_SACCH,  "SACCH/8(7)",   
rts_data_fn,tx_data_fn, rx_data_fn, 0 },
   {1,  TRXC_PDTCH, 0xc0,   LID_DEDIC,  "PDTCH",
rts_data_fn,tx_pdtch_fn,rx_pdtch_fn,0 },
   {1,  TRXC_PTCCH, 0xc0,   LID_DEDIC,  "PTCCH",
rts_data_fn,tx_data_fn, rx_data_fn, 0 },
+  {0,  TRXC_CBCH,  0xc8,   LID_DEDIC,  "CBCH", 
rts_data_fn,tx_data_fn, NULL,   1 },
 };

 const struct value_string trx_chan_type_names[] = {
@@ -195,6 +197,7 @@
OSMO_VALUE_STRING(TRXC_SACCH8_7),
OSMO_VALUE_STRING(TRXC_PDTCH),
OSMO_VALUE_STRING(TRXC_PTCCH),
+   OSMO_VALUE_STRING(TRXC_CBCH),
OSMO_VALUE_STRING(_TRX_CHAN_MAX),
{ 0, NULL }
 };
diff --git a/src/common/scheduler_mframe.c b/src/common/scheduler_mframe.c
index ab0b5b6..b78ffa8 100644
--- a/src/common/scheduler_mframe.c
+++ b/src/common/scheduler_mframe.c
@@ -2,7 +2,7 @@

 /* (C) 2013 by Andreas Eversberg 
  * (C) 2015 by Alexander Chemeris 
- * (C) 2015-2017 by Harald Welte 
+ * (C) 2015-2018 by Harald Welte 
  *
  * All Rights Reserved
  *
@@ -170,6 +170,113 @@
   {TRXC_IDLE,  0,  TRXC_SDCCH4_2,  3 },
 };

+static const struct trx_sched_frame frame_bcch_sdcch4_cbch[102] = {
+/* dl_chan dl_bid  ul_chan ul_bid */
+  {TRXC_FCCH,  0,  TRXC_SDCCH4_3,  0 },
+  {TRXC_SCH,   0,  TRXC_SDCCH4_3,  1 },
+  { TRXC_BCCH, 0,  TRXC_SDCCH4_3,  2 },
+  { TRXC_BCCH, 1,  TRXC_SDCCH4_3,  3 },
+  { TRXC_BCCH, 2,  TRXC_RACH,  0 },
+  { TRXC_BCCH, 3,  TRXC_RACH,  0 },
+  { TRXC_CCCH, 0,  TRXC_IDLE,  0 },
+  { TRXC_CCCH, 1,  TRXC_IDLE,  1 },
+  { TRXC_CCCH, 2,  TRXC_IDLE,  2 },
+  { TRXC_CCCH, 3,  TRXC_IDLE,  3 },
+  {TRXC_FCCH,  0,  TRXC_SACCH4_3,  0 },
+  {TRXC_SCH,   0,  TRXC_SACCH4_3,  1 },
+  { TRXC_CCCH, 0,  TRXC_SACCH4_3,  2 },
+  { TRXC_CCCH, 1,  TRXC_SACCH4_3,  3 },
+  { TRXC_CCCH, 2,  TRXC_RACH,  0 },
+  { TRXC_CCCH, 3,  TRXC_RACH,  0 },
+  { TRXC_CCCH, 0,  TRXC_RACH,  0 },
+  { TRXC_CCCH, 1,  TRXC_RACH,  0 },
+  { TRXC_CCCH, 2,  TRXC_RACH,  0 },
+  { TRXC_CCCH, 3,  TRXC_RACH,  0 },
+  {TRXC_FCCH,  0,  TRXC_RACH,  0 },
+  {TRXC_SCH,   0,  TRXC_RACH,  0 },
+  { TRXC_SDCCH4_0, 0,  TRXC_RACH,  0 },
+  { TRXC_SDCCH4_0, 1,  

Change in osmo-bts[master]: CBCH: Use llist_first_entry_or_null() instead of reinventing it

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10846 )

Change subject: CBCH: Use llist_first_entry_or_null() instead of reinventing it
..

CBCH: Use llist_first_entry_or_null() instead of reinventing it

Change-Id: I376111e71d1c7be35a8fd7e392488adc34e21941
---
M src/common/cbch.c
1 file changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/cbch.c b/src/common/cbch.c
index b8f69c6..56d76f1 100644
--- a/src/common/cbch.c
+++ b/src/common/cbch.c
@@ -144,12 +144,10 @@
 {
struct smscb_msg *msg;

-   if (llist_empty(>smscb_state.queue))
+   msg = llist_first_entry_or_null(>smscb_state.queue, struct 
smscb_msg, list);
+   if (!msg)
return NULL;

-   msg = llist_entry(bts->smscb_state.queue.next,
- struct smscb_msg, list);
-
llist_del(>list);

return msg;

--
To view, visit https://gerrit.osmocom.org/10846
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I376111e71d1c7be35a8fd7e392488adc34e21941
Gerrit-Change-Number: 10846
Gerrit-PatchSet: 4
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bts[master]: [sysmo, lc15]: Consider CBCH channel combinations in chan_nr_by_sapi()

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10849 )

Change subject: [sysmo,lc15]: Consider CBCH channel combinations in 
chan_nr_by_sapi()
..

[sysmo,lc15]: Consider CBCH channel combinations in chan_nr_by_sapi()

Whenever a CBCH is used, this results in a new physical channel
combination on the relevant timeslot.  The chan_nr_by_sapi() function
must handle those cbch-enabled PCHAN types.

Change-Id: I963909bcec8392ec445d0bcf53a2a8d7d9535444
---
M src/osmo-bts-litecell15/l1_if.c
M src/osmo-bts-sysmo/l1_if.c
2 files changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-litecell15/l1_if.c b/src/osmo-bts-litecell15/l1_if.c
index e6cdfd4..f582bf2 100644
--- a/src/osmo-bts-litecell15/l1_if.c
+++ b/src/osmo-bts-litecell15/l1_if.c
@@ -709,9 +709,11 @@
cbits = 0x02 + subCh;
break;
case GSM_PCHAN_CCCH_SDCCH4:
+   case GSM_PCHAN_CCCH_SDCCH4_CBCH:
cbits = 0x04 + subCh;
break;
case GSM_PCHAN_SDCCH8_SACCH8C:
+   case GSM_PCHAN_SDCCH8_SACCH8C_CBCH:
cbits = 0x08 + subCh;
break;
default:
@@ -723,9 +725,11 @@
case GsmL1_Sapi_Sdcch:
switch(pchan) {
case GSM_PCHAN_CCCH_SDCCH4:
+   case GSM_PCHAN_CCCH_SDCCH4_CBCH:
cbits = 0x04 + subCh;
break;
case GSM_PCHAN_SDCCH8_SACCH8C:
+   case GSM_PCHAN_SDCCH8_SACCH8C_CBCH:
cbits = 0x08 + subCh;
break;
default:
diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c
index 3adb442..1321fe6 100644
--- a/src/osmo-bts-sysmo/l1_if.c
+++ b/src/osmo-bts-sysmo/l1_if.c
@@ -706,9 +706,11 @@
cbits = 0x02 + subCh;
break;
case GSM_PCHAN_CCCH_SDCCH4:
+   case GSM_PCHAN_CCCH_SDCCH4_CBCH:
cbits = 0x04 + subCh;
break;
case GSM_PCHAN_SDCCH8_SACCH8C:
+   case GSM_PCHAN_SDCCH8_SACCH8C_CBCH:
cbits = 0x08 + subCh;
break;
default:
@@ -720,9 +722,11 @@
case GsmL1_Sapi_Sdcch:
switch(pchan) {
case GSM_PCHAN_CCCH_SDCCH4:
+   case GSM_PCHAN_CCCH_SDCCH4_CBCH:
cbits = 0x04 + subCh;
break;
case GSM_PCHAN_SDCCH8_SACCH8C:
+   case GSM_PCHAN_SDCCH8_SACCH8C_CBCH:
cbits = 0x08 + subCh;
break;
default:

--
To view, visit https://gerrit.osmocom.org/10849
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I963909bcec8392ec445d0bcf53a2a8d7d9535444
Gerrit-Change-Number: 10849
Gerrit-PatchSet: 4
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bts[master]: CBCH: Move processing via L1SAP

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10602 )

Change subject: CBCH: Move processing via L1SAP
..

CBCH: Move processing via L1SAP

for some historical reason, CBCH handling was not using the normal
L1SAP boundary.  Let's change that and traverse L1SAP just like for
e.g. BCCH which is quite similar to CBCH handling.

This also has the added benefit of logging CBCH via GSMTAP.

Change-Id: Ibdba4c5e808330f8406f441a97fe0e81170fce97
Closes: OS#3534
---
M include/osmo-bts/l1sap.h
M src/common/l1sap.c
M src/osmo-bts-litecell15/l1_if.c
M src/osmo-bts-octphy/l1_if.c
M src/osmo-bts-sysmo/l1_if.c
5 files changed, 16 insertions(+), 15 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmo-bts/l1sap.h b/include/osmo-bts/l1sap.h
index 4568b7e..3225a60 100644
--- a/include/osmo-bts/l1sap.h
+++ b/include/osmo-bts/l1sap.h
@@ -23,6 +23,7 @@
 #define L1SAP_IS_CHAN_RACH(chan_nr) ((chan_nr & 0xf8) == 0x88)
 #define L1SAP_IS_CHAN_AGCH_PCH(chan_nr) ((chan_nr & 0xf8) == 0x90)
 #define L1SAP_IS_CHAN_PDCH(chan_nr) ((chan_nr & 0xf8) == 0xc0)
+#define L1SAP_IS_CHAN_CBCH(chan_nr) ((chan_nr & 0xf8) == 0xc8)

 /* rach type from ra */
 #define L1SAP_IS_PACKET_RACH(ra) ((ra & 0xf0) == 0x70 && (ra & 0x0f) != 0x0f)
diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 55b4a4b..b29fcc7 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -53,6 +53,7 @@
 #include 
 #include 
 #include 
+#include 

 struct gsm_lchan *get_lchan_by_chan_nr(struct gsm_bts_trx *trx,
   unsigned int chan_nr)
@@ -265,6 +266,8 @@
*chan_type = GSMTAP_CHANNEL_PCH;
else
*chan_type = GSMTAP_CHANNEL_AGCH;
+   } else if (L1SAP_IS_CHAN_CBCH(chan_nr)) {
+   *chan_type = GSMTAP_CHANNEL_CBCH51;
} else if (L1SAP_IS_CHAN_PDCH(chan_nr)) {
*chan_type = GSMTAP_CHANNEL_PDTCH;
}
@@ -737,6 +740,9 @@
memcpy(p, si, GSM_MACBLOCK_LEN);
else
memcpy(p, fill_frame, GSM_MACBLOCK_LEN);
+   } else if (L1SAP_IS_CHAN_CBCH(chan_nr)) {
+   p = msgb_put(msg, GSM_MACBLOCK_LEN);
+   bts_cbch_get(trx->bts, p, _time);
} else if (!(chan_nr & 0x80)) { /* only TCH/F, TCH/H, SDCCH/4 and 
SDCCH/8 have C5 bit cleared */
lchan = get_active_lchan_by_chan_nr(trx, chan_nr);
if (!lchan) {
diff --git a/src/osmo-bts-litecell15/l1_if.c b/src/osmo-bts-litecell15/l1_if.c
index f582bf2..82299ff 100644
--- a/src/osmo-bts-litecell15/l1_if.c
+++ b/src/osmo-bts-litecell15/l1_if.c
@@ -50,7 +50,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -700,6 +699,9 @@
case GsmL1_Sapi_Bcch:
cbits = 0x10;
break;
+   case GsmL1_Sapi_Cbch:
+   cbits = 0xc8; /* Osmocom extension for CBCH via L1SAP */
+   break;
case GsmL1_Sapi_Sacch:
switch(pchan) {
case GSM_PCHAN_TCH_F:
@@ -867,10 +869,6 @@
case GsmL1_Sapi_Prach:
goto empty_frame;
break;
-   case GsmL1_Sapi_Cbch:
-   /* get them from bts->si_buf[] */
-   bts_cbch_get(bts, msu_param->u8Buffer, _time);
-   break;
default:
memcpy(msu_param->u8Buffer, fill_frame, GSM_MACBLOCK_LEN);
break;
diff --git a/src/osmo-bts-octphy/l1_if.c b/src/osmo-bts-octphy/l1_if.c
index 91ef07b..35d0aa3 100644
--- a/src/osmo-bts-octphy/l1_if.c
+++ b/src/osmo-bts-octphy/l1_if.c
@@ -43,7 +43,6 @@
 #include 
 #include 
 #include 
-#include 

 #include "l1_if.h"
 #include "l1_oml.h"
@@ -357,6 +356,9 @@
case cOCTVC1_GSM_SAPI_ENUM_BCCH:
cbits = 0x10;
break;
+   case cOCTVC1_GSM_SAPI_ENUM_CBCH:
+   cbits = 0xc8; /* Osmocom extension for CBCH via L1SAP */
+   break;
case cOCTVC1_GSM_SAPI_ENUM_SACCH:
switch (pchan) {
case GSM_PCHAN_TCH_F:
@@ -1017,10 +1019,6 @@
(g_time.t1 << 7) | (g_time.t2 << 2) | (t3p >> 1);
data_req->Data.abyDataContent[3] = (t3p & 1);
break;
-   case cOCTVC1_GSM_SAPI_ENUM_CBCH:
-   rc = bts_cbch_get(bts, data_req->Data.abyDataContent, _time);
-   data_req->Data.ulDataLength = 23;   /* GSM MAX BLK SIZE */
-   break;
case cOCTVC1_GSM_SAPI_ENUM_PRACH:
 #if 0
/* in case we decide to send an empty frame... */
diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c
index 1321fe6..c0b42b4 100644
--- a/src/osmo-bts-sysmo/l1_if.c
+++ b/src/osmo-bts-sysmo/l1_if.c
@@ -46,7 +46,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 

Change in osmo-bts[master]: CBCH: Move processing via L1SAP

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10602 )

Change subject: CBCH: Move processing via L1SAP
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/10602
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdba4c5e808330f8406f441a97fe0e81170fce97
Gerrit-Change-Number: 10602
Gerrit-PatchSet: 4
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 09 Sep 2018 15:40:39 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bts[master]: CBCH: Fix rejecting SMS-CB related RSL messages

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10845 )

Change subject: CBCH: Fix rejecting SMS-CB related RSL messages
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10845
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f7f1dd43505cc27cd33489d8b0e8c981cd93880
Gerrit-Change-Number: 10845
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 09 Sep 2018 15:38:16 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: CBCH: Fix SI4 CBCH IE generation

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10854 )

Change subject: CBCH: Fix SI4 CBCH IE generation
..

CBCH: Fix SI4 CBCH IE generation

When a CBCH is present in the cell, SI4 contains the channel description
of the CBCH.  As SI4 may be generated at a time when the underlying
timeslot is not configured yet, we need to generate the channel
description for the _configured_ channel combination, not the currently
used one.

Change-Id: Idbf9b8e4b1ef0e0348580b83f91355b3236d8609
Closes: OS#3532
---
M src/osmo-bsc/system_information.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/system_information.c 
b/src/osmo-bsc/system_information.c
index 232a1b6..2104e92 100644
--- a/src/osmo-bsc/system_information.c
+++ b/src/osmo-bsc/system_information.c
@@ -963,7 +963,7 @@
cbch_lchan = gsm_bts_get_cbch(bts);
if (cbch_lchan) {
struct gsm48_chan_desc cd;
-   gsm48_lchan2chan_desc(, cbch_lchan);
+   gsm48_lchan2chan_desc_as_configured(, cbch_lchan);
tv_fixed_put(si4->data, GSM48_IE_CBCH_CHAN_DESC, 3,
 (uint8_t *) );
l2_plen += 3 + 1;

--
To view, visit https://gerrit.osmocom.org/10854
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idbf9b8e4b1ef0e0348580b83f91355b3236d8609
Gerrit-Change-Number: 10854
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bsc[master]: Introduce gsm48_lchan2chan_desc_as_configured()

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10853 )

Change subject: Introduce gsm48_lchan2chan_desc_as_configured()
..

Introduce gsm48_lchan2chan_desc_as_configured()

gsm48_lchan2chan_desc_as_configured() is similar to gsm48_lchan2chan_desc(),
but uses the *configured* channel combination, rather than the currently
active one.

Change-Id: Id4043218fb770e8420f19a4ef9428680ecdfd286
Related: OS#3532
---
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/gsm_data.c
2 files changed, 20 insertions(+), 5 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 68f888f..e408ff9 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -1200,6 +1200,7 @@

 void gsm48_lchan2chan_desc(struct gsm48_chan_desc *cd,
   const struct gsm_lchan *lchan);
+void gsm48_lchan2chan_desc_as_configured(struct gsm48_chan_desc *cd, const 
struct gsm_lchan *lchan);

 /* return the gsm_lchan for the CBCH (if it exists at all) */
 struct gsm_lchan *gsm_bts_get_cbch(struct gsm_bts *bts);
diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c
index ac965e2..12ab66e 100644
--- a/src/osmo-bsc/gsm_data.c
+++ b/src/osmo-bsc/gsm_data.c
@@ -1329,13 +1329,10 @@
gsm_trx_all_ts_dispatch(trx, ts_ev, data);
 }

-void gsm48_lchan2chan_desc(struct gsm48_chan_desc *cd,
-  const struct gsm_lchan *lchan)
+static void _chan_desc_fill_tail(struct gsm48_chan_desc *cd, const struct 
gsm_lchan *lchan)
 {
-   uint16_t arfcn = lchan->ts->trx->arfcn & 0x3ff;
-
-   cd->chan_nr = gsm_lchan2chan_nr(lchan);
if (!lchan->ts->hopping.enabled) {
+   uint16_t arfcn = lchan->ts->trx->arfcn & 0x3ff;
cd->h0.tsc = gsm_ts_tsc(lchan->ts);
cd->h0.h = 0;
cd->h0.arfcn_high = arfcn >> 8;
@@ -1349,6 +1346,23 @@
}
 }

+void gsm48_lchan2chan_desc(struct gsm48_chan_desc *cd,
+  const struct gsm_lchan *lchan)
+{
+   cd->chan_nr = gsm_lchan2chan_nr(lchan);
+   _chan_desc_fill_tail(cd, lchan);
+}
+
+/* like gsm48_lchan2chan_desc() above, but use ts->pchan_from_config to
+ * return a channel description based on what is configured, rather than
+ * what the current state of the pchan type is */
+void gsm48_lchan2chan_desc_as_configured(struct gsm48_chan_desc *cd,
+const struct gsm_lchan *lchan)
+{
+   cd->chan_nr = gsm_pchan2chan_nr(lchan->ts->pchan_from_config, 
lchan->ts->nr, lchan->nr);
+   _chan_desc_fill_tail(cd, lchan);
+}
+
 bool nm_is_running(const struct gsm_nm_state *s) {
return (s->operational == NM_OPSTATE_ENABLED) && (
(s->availability == NM_AVSTATE_OK) ||

--
To view, visit https://gerrit.osmocom.org/10853
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id4043218fb770e8420f19a4ef9428680ecdfd286
Gerrit-Change-Number: 10853
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bsc[master]: gsm48_lchan2chan_desc() belongs to gsm_data.h

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10852 )

Change subject: gsm48_lchan2chan_desc() belongs to gsm_data.h
..

gsm48_lchan2chan_desc() belongs to gsm_data.h

The function is defined in gsm_data.c, so it should be declared
in gsm_data.h and not in gsm_04_08_rr.h

Change-Id: I5200063fb43c857a984ea8e41a8485d796e49cde
---
M include/osmocom/bsc/gsm_04_08_rr.h
M include/osmocom/bsc/gsm_data.h
2 files changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/bsc/gsm_04_08_rr.h 
b/include/osmocom/bsc/gsm_04_08_rr.h
index 8f46922..7b7a62f 100644
--- a/include/osmocom/bsc/gsm_04_08_rr.h
+++ b/include/osmocom/bsc/gsm_04_08_rr.h
@@ -22,8 +22,6 @@
 int gsm48_handle_paging_resp(struct gsm_subscriber_connection *conn,
 struct msgb *msg, struct bsc_subscr *bsub);
 int gsm48_send_rr_ciph_mode(struct gsm_lchan *lchan, int want_imeisv);
-void gsm48_lchan2chan_desc(struct gsm48_chan_desc *cd,
-  const struct gsm_lchan *lchan);
 int gsm48_multirate_config(uint8_t *lv, const struct amr_multirate_conf *mr, 
const struct amr_mode *modes);
 struct msgb *gsm48_make_ho_cmd(struct gsm_lchan *new_lchan, uint8_t 
power_command, uint8_t ho_ref);
 int gsm48_send_ho_cmd(struct gsm_lchan *old_lchan, struct gsm_lchan *new_lchan,
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index d6e8954..68f888f 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -1198,6 +1198,9 @@
 uint8_t gsm_lchan_as_pchan2chan_nr(const struct gsm_lchan *lchan,
   enum gsm_phys_chan_config as_pchan);

+void gsm48_lchan2chan_desc(struct gsm48_chan_desc *cd,
+  const struct gsm_lchan *lchan);
+
 /* return the gsm_lchan for the CBCH (if it exists at all) */
 struct gsm_lchan *gsm_bts_get_cbch(struct gsm_bts *bts);


--
To view, visit https://gerrit.osmocom.org/10852
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5200063fb43c857a984ea8e41a8485d796e49cde
Gerrit-Change-Number: 10852
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bsc[master]: CBCH: Fix gsm_bts_get_cbch()

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10851 )

Change subject: CBCH: Fix gsm_bts_get_cbch()
..

CBCH: Fix gsm_bts_get_cbch()

When the timeslot FSMs were introduced, the function gsm_bts_get_cbch()
was ported to use 'pchan_is'.  However, the function is called very
early, before pchan_is is actually initialized.

Let's make sure we're using the _configured_ channel combination
when resolving where the CBCH is (if any) in the BTS.

Ever since merging the timeslot FSMs and before this patch, SI4 would
never indicate the presence of a CBCH.

Change-Id: I6251b5f3e1180ad466e9349a1845e1b91f661c0b
Related: OS#3532
---
M src/osmo-bsc/gsm_data.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c
index 12ab66e..0718e91 100644
--- a/src/osmo-bsc/gsm_data.c
+++ b/src/osmo-bsc/gsm_data.c
@@ -1204,12 +1204,12 @@
struct gsm_lchan *lchan = NULL;
struct gsm_bts_trx *trx = bts->c0;

-   if (trx->ts[0].pchan_is == GSM_PCHAN_CCCH_SDCCH4_CBCH)
+   if (trx->ts[0].pchan_from_config == GSM_PCHAN_CCCH_SDCCH4_CBCH)
lchan = >ts[0].lchan[2];
else {
int i;
for (i = 0; i < 8; i++) {
-   if (trx->ts[i].pchan_is == 
GSM_PCHAN_SDCCH8_SACCH8C_CBCH) {
+   if (trx->ts[i].pchan_from_config == 
GSM_PCHAN_SDCCH8_SACCH8C_CBCH) {
lchan = >ts[i].lchan[2];
break;
}

--
To view, visit https://gerrit.osmocom.org/10851
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6251b5f3e1180ad466e9349a1845e1b91f661c0b
Gerrit-Change-Number: 10851
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bts[master]: [sysmo, lc15]: Consider CBCH channel combinations in chan_nr_by_sapi()

[Harald Welte]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10849

to look at the new patch set (#3).

Change subject: [sysmo,lc15]: Consider CBCH channel combinations in 
chan_nr_by_sapi()
..

[sysmo,lc15]: Consider CBCH channel combinations in chan_nr_by_sapi()

Whenever a CBCH is used, this results in a new physical channel
combination on the relevant timeslot.  The chan_nr_by_sapi() function
must handle those cbch-enabled PCHAN types.

Change-Id: I963909bcec8392ec445d0bcf53a2a8d7d9535444
---
M src/osmo-bts-litecell15/l1_if.c
M src/osmo-bts-sysmo/l1_if.c
2 files changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/49/10849/3
--
To view, visit https://gerrit.osmocom.org/10849
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I963909bcec8392ec445d0bcf53a2a8d7d9535444
Gerrit-Change-Number: 10849
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bts[master]: CBCH: sprinkle some OMSO_ASSERT() and guard against talloc failure

[Harald Welte]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10848

to look at the new patch set (#3).

Change subject: CBCH: sprinkle some OMSO_ASSERT() and guard against talloc 
failure
..

CBCH: sprinkle some OMSO_ASSERT() and guard against talloc failure

Change-Id: I85fdecbf20de83a6f925765a46b5cd14765da03e
---
M src/common/cbch.c
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/48/10848/3
--
To view, visit https://gerrit.osmocom.org/10848
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I85fdecbf20de83a6f925765a46b5cd14765da03e
Gerrit-Change-Number: 10848
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bsc[master]: cbch: Don't send cell-broadcast command on BTS without CBCH channel

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10850 )

Change subject: cbch: Don't send cell-broadcast command on BTS without CBCH 
channel
..

cbch: Don't send cell-broadcast command on BTS without CBCH channel

Change-Id: I83d6b0b3eafd83e2c0fbdec81d9677ff0118db92
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index e99029a..b1938e6 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -4240,6 +4240,10 @@
vty_out(vty, "%% No such BTS (%d)%s", bts_nr, VTY_NEWLINE);
return CMD_WARNING;
}
+   if (!gsm_bts_get_cbch(bts)) {
+   vty_out(vty, "%% BTS %d doesn't have a CBCH%s", bts_nr, 
VTY_NEWLINE);
+   return CMD_WARNING;
+   }
rc = osmo_hexparse(argv[2], buf, sizeof(buf));
if (rc < 0 || rc > sizeof(buf)) {
vty_out(vty, "Error parsing HEXSTRING%s", VTY_NEWLINE);

--
To view, visit https://gerrit.osmocom.org/10850
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I83d6b0b3eafd83e2c0fbdec81d9677ff0118db92
Gerrit-Change-Number: 10850
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bts[master]: CBCH: Fix rejecting SMS-CB related RSL messages

[Harald Welte]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10845

to look at the new patch set (#2).

Change subject: CBCH: Fix rejecting SMS-CB related RSL messages
..

CBCH: Fix rejecting SMS-CB related RSL messages

Normally, the "Common Channel" related RSL messages should actually
contain such a common channel.  However, since cell broadcast is
implemented inside what's essentially a downlink SDCCH, we should add
some explicit exceptions.

Before this patch, any RSL SMS BC CMD would have been discarded and
an RSL Error Indiciation returned.

Change-Id: I2f7f1dd43505cc27cd33489d8b0e8c981cd93880
Closes: OS#3533
---
M src/common/rsl.c
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/45/10845/2
--
To view, visit https://gerrit.osmocom.org/10845
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f7f1dd43505cc27cd33489d8b0e8c981cd93880
Gerrit-Change-Number: 10845
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bts[master]: CBCH: Add FIXME comments on queue overflow/underflow handling

[Harald Welte]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10847

to look at the new patch set (#3).

Change subject: CBCH: Add FIXME comments on queue overflow/underflow handling
..

CBCH: Add FIXME comments on queue overflow/underflow handling

Change-Id: Ida97f25ab4bf7e4d0f03b13396cb37cdfe99ef40
---
M src/common/cbch.c
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/47/10847/3
--
To view, visit https://gerrit.osmocom.org/10847
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida97f25ab4bf7e4d0f03b13396cb37cdfe99ef40
Gerrit-Change-Number: 10847
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bts[master]: CBCH: Use llist_first_entry_or_null() instead of reinventing it

[Harald Welte]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10846

to look at the new patch set (#3).

Change subject: CBCH: Use llist_first_entry_or_null() instead of reinventing it
..

CBCH: Use llist_first_entry_or_null() instead of reinventing it

Change-Id: I376111e71d1c7be35a8fd7e392488adc34e21941
---
M src/common/cbch.c
1 file changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/46/10846/3
--
To view, visit https://gerrit.osmocom.org/10846
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I376111e71d1c7be35a8fd7e392488adc34e21941
Gerrit-Change-Number: 10846
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bts[master]: CBCH: Implement CBCH support for osmo-bts-{trx, virtual}

[Harald Welte]

Hello Vadim Yanitskiy, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10603

to look at the new patch set (#5).

Change subject: CBCH: Implement CBCH support for osmo-bts-{trx,virtual}
..

CBCH: Implement CBCH support for osmo-bts-{trx,virtual}

This patch adds scheduler support for the channel combinations that
substitute SDCCH index 2 for a CBCH in either a SDCCH/8 or SDCCH/4.

Change-Id: Icc15603079a1709ec094f400a9bcf0008211890f
Closes: OS#1617
---
M README.md
M include/osmo-bts/scheduler.h
M src/common/scheduler.c
M src/common/scheduler_mframe.c
M src/osmo-bts-trx/main.c
M src/osmo-bts-virtual/main.c
6 files changed, 223 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/03/10603/5
--
To view, visit https://gerrit.osmocom.org/10603
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icc15603079a1709ec094f400a9bcf0008211890f
Gerrit-Change-Number: 10603
Gerrit-PatchSet: 5
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmo-bsc[master]: CBCH: Fix SI4 CBCH IE generation

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10854 )

Change subject: CBCH: Fix SI4 CBCH IE generation
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10854
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbf9b8e4b1ef0e0348580b83f91355b3236d8609
Gerrit-Change-Number: 10854
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-CC: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 09 Sep 2018 15:25:48 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: Introduce gsm48_lchan2chan_desc_as_configured()

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10853 )

Change subject: Introduce gsm48_lchan2chan_desc_as_configured()
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10853
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4043218fb770e8420f19a4ef9428680ecdfd286
Gerrit-Change-Number: 10853
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-CC: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 09 Sep 2018 15:25:38 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: CBCH: Fix gsm_bts_get_cbch()

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10851 )

Change subject: CBCH: Fix gsm_bts_get_cbch()
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10851
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6251b5f3e1180ad466e9349a1845e1b91f661c0b
Gerrit-Change-Number: 10851
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 09 Sep 2018 15:26:07 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: gsm48_lchan2chan_desc() belongs to gsm_data.h

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10852 )

Change subject: gsm48_lchan2chan_desc() belongs to gsm_data.h
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10852
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5200063fb43c857a984ea8e41a8485d796e49cde
Gerrit-Change-Number: 10852
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-CC: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 09 Sep 2018 15:25:29 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: cbch: Don't send cell-broadcast command on BTS without CBCH channel

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10850 )

Change subject: cbch: Don't send cell-broadcast command on BTS without CBCH 
channel
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10850
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83d6b0b3eafd83e2c0fbdec81d9677ff0118db92
Gerrit-Change-Number: 10850
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 09 Sep 2018 15:25:21 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: CBCH: Fix SI4 CBCH IE generation

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/10854


Change subject: CBCH: Fix SI4 CBCH IE generation
..

CBCH: Fix SI4 CBCH IE generation

When a CBCH is present in the cell, SI4 contains the channel description
of the CBCH.  As SI4 may be generated at a time when the underlying
timeslot is not configured yet, we need to generate the channel
description for the _configured_ channel combination, not the currently
used one.

Change-Id: Idbf9b8e4b1ef0e0348580b83f91355b3236d8609
Closes: OS#3532
---
M src/osmo-bsc/system_information.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/54/10854/1

diff --git a/src/osmo-bsc/system_information.c 
b/src/osmo-bsc/system_information.c
index 232a1b6..2104e92 100644
--- a/src/osmo-bsc/system_information.c
+++ b/src/osmo-bsc/system_information.c
@@ -963,7 +963,7 @@
cbch_lchan = gsm_bts_get_cbch(bts);
if (cbch_lchan) {
struct gsm48_chan_desc cd;
-   gsm48_lchan2chan_desc(, cbch_lchan);
+   gsm48_lchan2chan_desc_as_configured(, cbch_lchan);
tv_fixed_put(si4->data, GSM48_IE_CBCH_CHAN_DESC, 3,
 (uint8_t *) );
l2_plen += 3 + 1;

--
To view, visit https://gerrit.osmocom.org/10854
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idbf9b8e4b1ef0e0348580b83f91355b3236d8609
Gerrit-Change-Number: 10854
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Change in osmo-bsc[master]: gsm48_lchan2chan_desc() belongs to gsm_data.h

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/10852


Change subject: gsm48_lchan2chan_desc() belongs to gsm_data.h
..

gsm48_lchan2chan_desc() belongs to gsm_data.h

The function is defined in gsm_data.c, so it should be declared
in gsm_data.h and not in gsm_04_08_rr.h

Change-Id: I5200063fb43c857a984ea8e41a8485d796e49cde
---
M include/osmocom/bsc/gsm_04_08_rr.h
M include/osmocom/bsc/gsm_data.h
2 files changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/52/10852/1

diff --git a/include/osmocom/bsc/gsm_04_08_rr.h 
b/include/osmocom/bsc/gsm_04_08_rr.h
index 8f46922..7b7a62f 100644
--- a/include/osmocom/bsc/gsm_04_08_rr.h
+++ b/include/osmocom/bsc/gsm_04_08_rr.h
@@ -22,8 +22,6 @@
 int gsm48_handle_paging_resp(struct gsm_subscriber_connection *conn,
 struct msgb *msg, struct bsc_subscr *bsub);
 int gsm48_send_rr_ciph_mode(struct gsm_lchan *lchan, int want_imeisv);
-void gsm48_lchan2chan_desc(struct gsm48_chan_desc *cd,
-  const struct gsm_lchan *lchan);
 int gsm48_multirate_config(uint8_t *lv, const struct amr_multirate_conf *mr, 
const struct amr_mode *modes);
 struct msgb *gsm48_make_ho_cmd(struct gsm_lchan *new_lchan, uint8_t 
power_command, uint8_t ho_ref);
 int gsm48_send_ho_cmd(struct gsm_lchan *old_lchan, struct gsm_lchan *new_lchan,
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index d6e8954..68f888f 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -1198,6 +1198,9 @@
 uint8_t gsm_lchan_as_pchan2chan_nr(const struct gsm_lchan *lchan,
   enum gsm_phys_chan_config as_pchan);

+void gsm48_lchan2chan_desc(struct gsm48_chan_desc *cd,
+  const struct gsm_lchan *lchan);
+
 /* return the gsm_lchan for the CBCH (if it exists at all) */
 struct gsm_lchan *gsm_bts_get_cbch(struct gsm_bts *bts);


--
To view, visit https://gerrit.osmocom.org/10852
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5200063fb43c857a984ea8e41a8485d796e49cde
Gerrit-Change-Number: 10852
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Change in osmo-bsc[master]: Introduce gsm48_lchan2chan_desc_as_configured()

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/10853


Change subject: Introduce gsm48_lchan2chan_desc_as_configured()
..

Introduce gsm48_lchan2chan_desc_as_configured()

gsm48_lchan2chan_desc_as_configured() is similar to gsm48_lchan2chan_desc(),
but uses the *configured* channel combination, rather than the currently
active one.

Change-Id: Id4043218fb770e8420f19a4ef9428680ecdfd286
Related: OS#3532
---
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/gsm_data.c
2 files changed, 20 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/53/10853/1

diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 68f888f..e408ff9 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -1200,6 +1200,7 @@

 void gsm48_lchan2chan_desc(struct gsm48_chan_desc *cd,
   const struct gsm_lchan *lchan);
+void gsm48_lchan2chan_desc_as_configured(struct gsm48_chan_desc *cd, const 
struct gsm_lchan *lchan);

 /* return the gsm_lchan for the CBCH (if it exists at all) */
 struct gsm_lchan *gsm_bts_get_cbch(struct gsm_bts *bts);
diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c
index ac965e2..12ab66e 100644
--- a/src/osmo-bsc/gsm_data.c
+++ b/src/osmo-bsc/gsm_data.c
@@ -1329,13 +1329,10 @@
gsm_trx_all_ts_dispatch(trx, ts_ev, data);
 }

-void gsm48_lchan2chan_desc(struct gsm48_chan_desc *cd,
-  const struct gsm_lchan *lchan)
+static void _chan_desc_fill_tail(struct gsm48_chan_desc *cd, const struct 
gsm_lchan *lchan)
 {
-   uint16_t arfcn = lchan->ts->trx->arfcn & 0x3ff;
-
-   cd->chan_nr = gsm_lchan2chan_nr(lchan);
if (!lchan->ts->hopping.enabled) {
+   uint16_t arfcn = lchan->ts->trx->arfcn & 0x3ff;
cd->h0.tsc = gsm_ts_tsc(lchan->ts);
cd->h0.h = 0;
cd->h0.arfcn_high = arfcn >> 8;
@@ -1349,6 +1346,23 @@
}
 }

+void gsm48_lchan2chan_desc(struct gsm48_chan_desc *cd,
+  const struct gsm_lchan *lchan)
+{
+   cd->chan_nr = gsm_lchan2chan_nr(lchan);
+   _chan_desc_fill_tail(cd, lchan);
+}
+
+/* like gsm48_lchan2chan_desc() above, but use ts->pchan_from_config to
+ * return a channel description based on what is configured, rather than
+ * what the current state of the pchan type is */
+void gsm48_lchan2chan_desc_as_configured(struct gsm48_chan_desc *cd,
+const struct gsm_lchan *lchan)
+{
+   cd->chan_nr = gsm_pchan2chan_nr(lchan->ts->pchan_from_config, 
lchan->ts->nr, lchan->nr);
+   _chan_desc_fill_tail(cd, lchan);
+}
+
 bool nm_is_running(const struct gsm_nm_state *s) {
return (s->operational == NM_OPSTATE_ENABLED) && (
(s->availability == NM_AVSTATE_OK) ||

--
To view, visit https://gerrit.osmocom.org/10853
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4043218fb770e8420f19a4ef9428680ecdfd286
Gerrit-Change-Number: 10853
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Jenkins build is back to normal : master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #241

[jenkins]

See 

Change in osmo-bsc[master]: cbch: Don't send cell-broadcast command on BTS without CBCH channel

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/10850


Change subject: cbch: Don't send cell-broadcast command on BTS without CBCH 
channel
..

cbch: Don't send cell-broadcast command on BTS without CBCH channel

Change-Id: I83d6b0b3eafd83e2c0fbdec81d9677ff0118db92
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/50/10850/1

diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index e99029a..b1938e6 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -4240,6 +4240,10 @@
vty_out(vty, "%% No such BTS (%d)%s", bts_nr, VTY_NEWLINE);
return CMD_WARNING;
}
+   if (!gsm_bts_get_cbch(bts)) {
+   vty_out(vty, "%% BTS %d doesn't have a CBCH%s", bts_nr, 
VTY_NEWLINE);
+   return CMD_WARNING;
+   }
rc = osmo_hexparse(argv[2], buf, sizeof(buf));
if (rc < 0 || rc > sizeof(buf)) {
vty_out(vty, "Error parsing HEXSTRING%s", VTY_NEWLINE);

--
To view, visit https://gerrit.osmocom.org/10850
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83d6b0b3eafd83e2c0fbdec81d9677ff0118db92
Gerrit-Change-Number: 10850
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Change in osmo-bsc[master]: CBCH: Fix gsm_bts_get_cbch()

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/10851


Change subject: CBCH: Fix gsm_bts_get_cbch()
..

CBCH: Fix gsm_bts_get_cbch()

When the timeslot FSMs were introduced, the function gsm_bts_get_cbch()
was ported to use 'pchan_is'.  However, the function is called very
early, before pchan_is is actually initialized.

Let's make sure we're using the _configured_ channel combination
when resolving where the CBCH is (if any) in the BTS.

Ever since merging the timeslot FSMs and before this patch, SI4 would
never indicate the presence of a CBCH.

Change-Id: I6251b5f3e1180ad466e9349a1845e1b91f661c0b
Related: OS#3532
---
M src/osmo-bsc/gsm_data.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/51/10851/1

diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c
index ac965e2..a953ce1 100644
--- a/src/osmo-bsc/gsm_data.c
+++ b/src/osmo-bsc/gsm_data.c
@@ -1204,12 +1204,12 @@
struct gsm_lchan *lchan = NULL;
struct gsm_bts_trx *trx = bts->c0;

-   if (trx->ts[0].pchan_is == GSM_PCHAN_CCCH_SDCCH4_CBCH)
+   if (trx->ts[0].pchan_from_config == GSM_PCHAN_CCCH_SDCCH4_CBCH)
lchan = >ts[0].lchan[2];
else {
int i;
for (i = 0; i < 8; i++) {
-   if (trx->ts[i].pchan_is == 
GSM_PCHAN_SDCCH8_SACCH8C_CBCH) {
+   if (trx->ts[i].pchan_from_config == 
GSM_PCHAN_SDCCH8_SACCH8C_CBCH) {
lchan = >ts[i].lchan[2];
break;
}

--
To view, visit https://gerrit.osmocom.org/10851
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6251b5f3e1180ad466e9349a1845e1b91f661c0b
Gerrit-Change-Number: 10851
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Change in osmo-bts[master]: [sysmo, lc15]: Consider CBCH channel combinations in chan_nr_by_sapi()

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10849 )

Change subject: [sysmo,lc15]: Consider CBCH channel combinations in 
chan_nr_by_sapi()
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10849
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I963909bcec8392ec445d0bcf53a2a8d7d9535444
Gerrit-Change-Number: 10849
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 09 Sep 2018 14:29:53 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: CBCH: Use llist_first_entry_or_null() instead of reinventing it

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10846 )

Change subject: CBCH: Use llist_first_entry_or_null() instead of reinventing it
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10846
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I376111e71d1c7be35a8fd7e392488adc34e21941
Gerrit-Change-Number: 10846
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 09 Sep 2018 14:29:34 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: CBCH: Implement CBCH support for osmo-bts-{trx, virtual}

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10603 )

Change subject: CBCH: Implement CBCH support for osmo-bts-{trx,virtual}
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10603
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc15603079a1709ec094f400a9bcf0008211890f
Gerrit-Change-Number: 10603
Gerrit-PatchSet: 4
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 09 Sep 2018 14:29:22 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: CBCH: Implement CBCH support for osmo-bts-{trx, virtual}

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10603 )

Change subject: CBCH: Implement CBCH support for osmo-bts-{trx,virtual}
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/10603
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc15603079a1709ec094f400a9bcf0008211890f
Gerrit-Change-Number: 10603
Gerrit-PatchSet: 4
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 09 Sep 2018 14:28:46 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bts[master]: CBCH: Fix rejecting SMS-CB related RSL messages

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10845 )

Change subject: CBCH: Fix rejecting SMS-CB related RSL messages
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10845
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f7f1dd43505cc27cd33489d8b0e8c981cd93880
Gerrit-Change-Number: 10845
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 09 Sep 2018 14:27:31 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: [sysmo, lc15]: Consider CBCH channel combinations in chan_nr_by_sapi()

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/10849


Change subject: [sysmo,lc15]: Consider CBCH channel combinations in 
chan_nr_by_sapi()
..

[sysmo,lc15]: Consider CBCH channel combinations in chan_nr_by_sapi()

Whenever a CBCH is used, this results in a new physical channel
combination on the relevant timeslot.  The chan_nr_by_sapi() function
must handle those cbch-enabled PCHAN types.

Change-Id: I963909bcec8392ec445d0bcf53a2a8d7d9535444
---
M src/osmo-bts-litecell15/l1_if.c
M src/osmo-bts-sysmo/l1_if.c
2 files changed, 8 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/49/10849/1

diff --git a/src/osmo-bts-litecell15/l1_if.c b/src/osmo-bts-litecell15/l1_if.c
index 8bb4909..c873fb1 100644
--- a/src/osmo-bts-litecell15/l1_if.c
+++ b/src/osmo-bts-litecell15/l1_if.c
@@ -711,9 +711,11 @@
cbits = 0x02 + subCh;
break;
case GSM_PCHAN_CCCH_SDCCH4:
+   case GSM_PCHAN_CCCH_SDCCH4_CBCH:
cbits = 0x04 + subCh;
break;
case GSM_PCHAN_SDCCH8_SACCH8C:
+   case GSM_PCHAN_SDCCH8_SACCH8C_CBCH:
cbits = 0x08 + subCh;
break;
default:
@@ -725,9 +727,11 @@
case GsmL1_Sapi_Sdcch:
switch(pchan) {
case GSM_PCHAN_CCCH_SDCCH4:
+   case GSM_PCHAN_CCCH_SDCCH4_CBCH:
cbits = 0x04 + subCh;
break;
case GSM_PCHAN_SDCCH8_SACCH8C:
+   case GSM_PCHAN_SDCCH8_SACCH8C_CBCH:
cbits = 0x08 + subCh;
break;
default:
diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c
index 5d52146..7f09fb1 100644
--- a/src/osmo-bts-sysmo/l1_if.c
+++ b/src/osmo-bts-sysmo/l1_if.c
@@ -708,9 +708,11 @@
cbits = 0x02 + subCh;
break;
case GSM_PCHAN_CCCH_SDCCH4:
+   case GSM_PCHAN_CCCH_SDCCH4_CBCH:
cbits = 0x04 + subCh;
break;
case GSM_PCHAN_SDCCH8_SACCH8C:
+   case GSM_PCHAN_SDCCH8_SACCH8C_CBCH:
cbits = 0x08 + subCh;
break;
default:
@@ -722,9 +724,11 @@
case GsmL1_Sapi_Sdcch:
switch(pchan) {
case GSM_PCHAN_CCCH_SDCCH4:
+   case GSM_PCHAN_CCCH_SDCCH4_CBCH:
cbits = 0x04 + subCh;
break;
case GSM_PCHAN_SDCCH8_SACCH8C:
+   case GSM_PCHAN_SDCCH8_SACCH8C_CBCH:
cbits = 0x08 + subCh;
break;
default:

--
To view, visit https://gerrit.osmocom.org/10849
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I963909bcec8392ec445d0bcf53a2a8d7d9535444
Gerrit-Change-Number: 10849
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Change in osmo-bts[master]: CBCH: Add FIXME comments on queue overflow/underflow handling

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/10847


Change subject: CBCH: Add FIXME comments on queue overflow/underflow handling
..

CBCH: Add FIXME comments on queue overflow/underflow handling

Change-Id: Ida97f25ab4bf7e4d0f03b13396cb37cdfe99ef40
---
M src/common/cbch.c
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/47/10847/1

diff --git a/src/common/cbch.c b/src/common/cbch.c
index 56d76f1..7bbe2c9 100644
--- a/src/common/cbch.c
+++ b/src/common/cbch.c
@@ -136,6 +136,7 @@
}

llist_add_tail(>list, >smscb_state.queue);
+   /* FIXME: limit queue size and optionally send CBCH LOAD Information 
(overflow) via RSL */
 
return 0;
 }
@@ -145,8 +146,10 @@
struct smscb_msg *msg;

msg = llist_first_entry_or_null(>smscb_state.queue, struct 
smscb_msg, list);
-   if (!msg)
+   if (!msg) {
+   /* FIXME: send CBCH LOAD Information (underflow) via RSL */
return NULL;
+   }

llist_del(>list);


--
To view, visit https://gerrit.osmocom.org/10847
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida97f25ab4bf7e4d0f03b13396cb37cdfe99ef40
Gerrit-Change-Number: 10847
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Change in osmo-bts[master]: CBCH: sprinkle some OMSO_ASSERT() and guard against talloc failure

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/10848


Change subject: CBCH: sprinkle some OMSO_ASSERT() and guard against talloc 
failure
..

CBCH: sprinkle some OMSO_ASSERT() and guard against talloc failure

Change-Id: I85fdecbf20de83a6f925765a46b5cd14765da03e
---
M src/common/cbch.c
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/48/10848/1

diff --git a/src/common/cbch.c b/src/common/cbch.c
index 7bbe2c9..c628cb5 100644
--- a/src/common/cbch.c
+++ b/src/common/cbch.c
@@ -20,6 +20,7 @@

 #include 

+#include 
 #include 
 #include 

@@ -59,6 +60,7 @@
/* No message: Send NULL mesage */
return get_smscb_null_block(out);
}
+   OSMO_ASSERT(msg->next_seg < 4);

block_type = (struct gsm412_block_type *) out++;

@@ -70,6 +72,7 @@
to_copy = GSM412_MSG_LEN - (msg->next_seg * GSM412_BLOCK_LEN);
if (to_copy > GSM412_BLOCK_LEN)
to_copy = GSM412_BLOCK_LEN;
+   OSMO_ASSERT(to_copy >= 0);

/* copy data and increment index */
memcpy(out, >msg[msg->next_seg * GSM412_BLOCK_LEN], to_copy);
@@ -115,6 +118,8 @@
}

scm = talloc_zero_size(bts, sizeof(*scm));
+   if (!scm)
+   return -1;

/* initialize entire message with default padding */
memset(scm->msg, GSM_MACBLOCK_PADDING, sizeof(scm->msg));

--
To view, visit https://gerrit.osmocom.org/10848
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I85fdecbf20de83a6f925765a46b5cd14765da03e
Gerrit-Change-Number: 10848
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Change in osmo-bts[master]: CBCH: Fix rejecting SMS-CB related RSL messages

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/10845


Change subject: CBCH: Fix rejecting SMS-CB related RSL messages
..

CBCH: Fix rejecting SMS-CB related RSL messages

Normally, the "Common Channel" related RSL messages should actually
contain such a common channel.  However, since cell broadcast is
implemented inside what's essentially a downlink SDCCH, we should add
some explicit exceptions.

Before this patch, any RSL SMS BC CMD would have been discarded and
an RSL Error Indiciation returned.

Change-Id: I2f7f1dd43505cc27cd33489d8b0e8c981cd93880
---
M src/common/rsl.c
1 file changed, 6 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/45/10845/1

diff --git a/src/common/rsl.c b/src/common/rsl.c
index ff2d997..c6c00ea 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -2725,8 +2725,12 @@
}
msg->l3h = (unsigned char *)cch + sizeof(*cch);

-   if (chan_nr_is_dchan(cch->chan_nr))
-   return rsl_reject_unknown_lchan(msg);
+   /* normally we don't permit dedicated channels here ... */
+   if (chan_nr_is_dchan(cch->chan_nr)) {
+   /* ... however, CBCH is on a SDCCH, so we must permit it */
+   if (cch->c.msg_type != RSL_MT_SMS_BC_CMD && cch->c.msg_type != 
RSL_MT_SMS_BC_REQ)
+   return rsl_reject_unknown_lchan(msg);
+   }

msg->lchan = lchan_lookup(trx, cch->chan_nr, "RSL rx CCHAN: ");
if (!msg->lchan) {

--
To view, visit https://gerrit.osmocom.org/10845
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f7f1dd43505cc27cd33489d8b0e8c981cd93880
Gerrit-Change-Number: 10845
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Change in osmo-bts[master]: CBCH: Use llist_first_entry_or_null() instead of reinventing it

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/10846


Change subject: CBCH: Use llist_first_entry_or_null() instead of reinventing it
..

CBCH: Use llist_first_entry_or_null() instead of reinventing it

Change-Id: I376111e71d1c7be35a8fd7e392488adc34e21941
---
M src/common/cbch.c
1 file changed, 2 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/46/10846/1

diff --git a/src/common/cbch.c b/src/common/cbch.c
index b8f69c6..56d76f1 100644
--- a/src/common/cbch.c
+++ b/src/common/cbch.c
@@ -144,12 +144,10 @@
 {
struct smscb_msg *msg;

-   if (llist_empty(>smscb_state.queue))
+   msg = llist_first_entry_or_null(>smscb_state.queue, struct 
smscb_msg, list);
+   if (!msg)
return NULL;

-   msg = llist_entry(bts->smscb_state.queue.next,
- struct smscb_msg, list);
-
llist_del(>list);

return msg;

--
To view, visit https://gerrit.osmocom.org/10846
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I376111e71d1c7be35a8fd7e392488adc34e21941
Gerrit-Change-Number: 10846
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Change in simtrace2[master]: owhw: set the right simtrace USB ID in usb2udp

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10844 )

Change subject: owhw: set the right simtrace USB ID in usb2udp
..

owhw: set the right simtrace USB ID in usb2udp

Change-Id: I0b54c2eb98b3fad1e2afaf9b81fbe4518b01fbda
---
M host/usb2udp.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/host/usb2udp.c b/host/usb2udp.c
index c25920f..97ffad0 100644
--- a/host/usb2udp.c
+++ b/host/usb2udp.c
@@ -35,7 +35,7 @@

 #include 

-#include "simtrace.h"
+#include "simtrace_usb.h"
 #include "simtrace_prot.h"
 #include "apdu_dispatch.h"
 #include "simtrace2-discovery.h"
@@ -243,7 +243,7 @@

libusb_set_pollfd_notifiers(NULL, _fd_added_cb, 
_fd_removed_cb, NULL);

-   g_devh = libusb_open_device_with_vid_pid(NULL, SIMTRACE_USB_VENDOR, 
SIMTRACE_USB_PRODUCT);
+   g_devh = libusb_open_device_with_vid_pid(NULL, USB_VENDOR_OPENMOKO, 
USB_PRODUCT_OWHW_SAM3);
if (!g_devh) {
fprintf(stderr, "can't open USB device\n");
goto close_exit;

--
To view, visit https://gerrit.osmocom.org/10844
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b54c2eb98b3fad1e2afaf9b81fbe4518b01fbda
Gerrit-Change-Number: 10844
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmo-sccp[master]: Install systemd services with autotools

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10843 )

Change subject: Install systemd services with autotools
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10843
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie77ee4b32a75e2d207030ddc78d39fb664103d33
Gerrit-Change-Number: 10843
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 09 Sep 2018 11:54:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in simtrace2[master]: owhw: set the right simtrace USB ID in usb2udp

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10844 )

Change subject: owhw: set the right simtrace USB ID in usb2udp
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10844
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b54c2eb98b3fad1e2afaf9b81fbe4518b01fbda
Gerrit-Change-Number: 10844
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 09 Sep 2018 10:50:01 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes