Change in osmo-ttcn3-hacks[master]: sgsn: implement TC_attach_usim_resync

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10769 )

Change subject: sgsn: implement TC_attach_usim_resync
..

sgsn: implement TC_attach_usim_resync

Test the UMTS AKA resync procedure with USIMs.

MS -> SGSN: Attach Request
MS <- SGSN: Identity Request IMSI
MS -> SGSN: Identity Response IMSI
MS <- SGSN: Identity Request IMEI
MS -> SGSN: Identity Response IMEI
HLR<- SGSN: SAI Request
HLR-> SGSN: SAI Response
MS <- SGSN: Auth Request
MS -> SGSN: Auth Failure (with AUTS)
HLR<- SGSN: SAI Request (with AUTS & RAND)
HLR-> SGSN: SAI Response (new key material)
MS <- SGSN: Auth Request (new key material)
MS -> SGSN: Auth Response
MS <- SGSN: Attach Accept
MS -> SGSN: Attach Complete

Change-Id: I52a8dc45bb67d4ca9f3efade278d3308bb0da73d
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 131 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 0112483..a2e93c0 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -2015,6 +2015,136 @@
vc_conn.done;
 }

+private function f_TC_attach_usim_resync(charstring id) runs on BSSGP_ConnHdlr 
{
+   var BssgpDecoded bd;
+   var RoutingAreaIdentificationV old_ra := f_random_RAI();
+
+   var template PDU_L3_MS_SGSN attach_req := 
ts_GMM_ATTACH_REQ(f_mi_get_lv(), old_ra, false, false, omit, omit);
+
+   /* send Attach Request */
+   /* indicate R99 capability of the MS to enable UMTS AKA in presence of
+* 3G auth vectors */
+   
attach_req.msgs.gprs_mm.attachRequest.msNetworkCapability.msNetworkCapabilityV.revisionLevelIndicatior
 := '1'B;
+   /* The thing is, if the solSACapability is 'omit', then the
+* revisionLevelIndicatior is at the wrong place! */
+   
attach_req.msgs.gprs_mm.attachRequest.msNetworkCapability.msNetworkCapabilityV.solSACapability
 := '0'B;
+   f_send_l3_gmm_llc(attach_req);
+
+   /* do the auth */
+   var PDU_L3_MS_SGSN l3_mo;
+   var PDU_L3_SGSN_MS l3_mt;
+   var default di := activate(as_mm_identity());
+
+   var GSUP_IE auth_tuple;
+   var template AuthenticationParameterAUTNTLV autn;
+
+   g_pars.vec := f_gen_auth_vec_3g();
+   autn := {
+   elementIdentifier := '28'O,
+   lengthIndicator := lengthof(g_pars.vec.autn),
+   autnValue := g_pars.vec.autn
+   };
+   auth_tuple := valueof(ts_GSUP_IE_AuthTuple2G3G(g_pars.vec.rand,
+   g_pars.vec.sres,
+   g_pars.vec.kc,
+   g_pars.vec.ik,
+   g_pars.vec.ck,
+   g_pars.vec.autn,
+   g_pars.vec.res));
+   log("GSUP sends 2G and 3G auth tuples", auth_tuple);
+   GSUP.receive(tr_GSUP_SAI_REQ(g_pars.imsi));
+   GSUP.send(ts_GSUP_SAI_RES(g_pars.imsi, auth_tuple));
+
+   var template PDU_L3_SGSN_MS auth_ciph_req := 
tr_GMM_AUTH_REQ(g_pars.vec.rand);
+   
auth_ciph_req.msgs.gprs_mm.authenticationAndCipheringRequest.authenticationParameterAUTN
 := autn;
+   BSSGP[0].receive(tr_BD_L3_MT(auth_ciph_req)) -> value bd;
+
+   /* send the gmm auth failure with resync IE */
+   f_send_l3_gmm_llc(ts_GMM_AUTH_FAIL_UMTS_AKA_RESYNC(g_pars.vec.auts));
+
+   /* wait for the GSUP resync request */
+   GSUP.receive(tr_GSUP_SAI_REQ_UMTS_AKA_RESYNC(
+   g_pars.imsi,
+   g_pars.vec.auts,
+   g_pars.vec.rand));
+
+   /* generate new key material */
+   g_pars.vec := f_gen_auth_vec_3g();
+   autn := {
+   elementIdentifier := '28'O,
+   lengthIndicator := lengthof(g_pars.vec.autn),
+   autnValue := g_pars.vec.autn
+   };
+
+   auth_tuple := valueof(ts_GSUP_IE_AuthTuple2G3G(g_pars.vec.rand,
+   g_pars.vec.sres,
+   g_pars.vec.kc,
+   g_pars.vec.ik,
+   g_pars.vec.ck,
+   g_pars.vec.autn,
+   g_pars.vec.res));
+   /* send new key material */
+   GSUP.send(ts_GSUP_SAI_RES(g_pars.imsi, auth_tuple));
+
+   /* wait for the new Auth Request */
+   auth_ciph_req := tr_GMM_AUTH_REQ(g_pars.vec.rand);
+   
auth_ciph_req.msgs.gprs_mm.authenticationAndCipheringRequest.authenticationParameterAUTN
 := autn;
+   BSSGP[0].receive(tr_BD_L3_MT(auth_ciph_req)) -> value bd;
+   l3_mt := bd.l3_mt;
+   

Change in osmo-ttcn3-hacks[master]: sgsn: implement TC_attach_usim_resync

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10769 )

Change subject: sgsn: implement TC_attach_usim_resync
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10769
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52a8dc45bb67d4ca9f3efade278d3308bb0da73d
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Fri, 14 Sep 2018 22:00:31 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: MSC_ConnectionHandler: Make sure COMPLETE LAYER 3 INFORMATION contain...

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10966 )

Change subject: MSC_ConnectionHandler: Make sure COMPLETE LAYER 3 INFORMATION 
contains a codecList
..


Patch Set 1:

I think this should only apply if not sccplite!


--
To view, visit https://gerrit.osmocom.org/10966
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia16a454e78421430ec32cc37939d429970cb06ec
Gerrit-Change-Number: 10966
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Fri, 14 Sep 2018 21:55:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/armv7l

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  298s] No package 'libpcsclite' found
[  298s] simtrace2-remsim.o: In function `main':
[  298s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  298s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  298s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:772: undefined 
reference to `osim_uicc_sim_cic_profile'
[  298s] apdu_dispatch.o: In function `apdu_segment_in':
[  298s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  298s] /usr/src/packages/BUILD/host/apdu_dispatch.c:173: undefined reference 
to `osim_uicc_sim_cic_profile'
[  298s] collect2: error: ld returned 1 exit status
[  298s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  298s] make[2]: *** [simtrace2-remsim] Error 1
[  298s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  298s] Makefile:20: recipe for target 'utils' failed
[  298s] make[1]: *** [utils] Error 2
[  298s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  298s] dh_auto_build: make -j1 returned exit code 2
[  298s] debian/rules:4: recipe for target 'build' failed
[  298s] make: *** [build] Error 2
[  298s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  298s] 
[  298s] armbuild04 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 14 
20:07:10 UTC 2018.
[  298s] 
[  298s] ### VM INTERACTION START ###
[  301s] [  279.74] SysRq : Power Off
[  301s] [  279.557070] reboot: Power down
[  301s] ### VM INTERACTION END ###
[  301s] 
[  301s] armbuild04 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 14 
20:07:13 UTC 2018.
[  301s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_18.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  163s] No package 'libpcsclite' found
[  163s] simtrace2-remsim.o: In function `main':
[  163s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  163s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  163s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  163s] apdu_dispatch.o: In function `apdu_segment_in':
[  163s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  163s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  163s] collect2: error: ld returned 1 exit status
[  163s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  163s] make[2]: *** [simtrace2-remsim] Error 1
[  163s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  163s] Makefile:20: recipe for target 'utils' failed
[  163s] make[1]: *** [utils] Error 2
[  163s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  163s] dh_auto_build: make -j1 returned exit code 2
[  163s] debian/rules:4: recipe for target 'build' failed
[  163s] make: *** [build] Error 2
[  163s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  163s] 
[  163s] lamb54 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 14 
19:57:53 UTC 2018.
[  163s] 
[  163s] ### VM INTERACTION START ###
[  166s] [  155.753039] sysrq: SysRq : Power Off
[  166s] [  155.762736] reboot: Power down
[  167s] ### VM INTERACTION END ###
[  167s] 
[  167s] lamb54 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 14 
19:57:57 UTC 2018.
[  167s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_18.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  201s] No package 'libpcsclite' found
[  201s] simtrace2-remsim.o: In function `main':
[  201s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  201s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  201s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  201s] apdu_dispatch.o: In function `apdu_segment_in':
[  201s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  201s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  201s] collect2: error: ld returned 1 exit status
[  201s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  201s] make[2]: *** [simtrace2-remsim] Error 1
[  201s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  201s] Makefile:20: recipe for target 'utils' failed
[  201s] make[1]: *** [utils] Error 2
[  201s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  201s] dh_auto_build: make -j1 returned exit code 2
[  201s] debian/rules:4: recipe for target 'build' failed
[  201s] make: *** [build] Error 2
[  201s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  201s] 
[  201s] lamb19 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 14 
19:57:57 UTC 2018.
[  201s] 
[  201s] ### VM INTERACTION START ###
[  204s] [  191.779075] sysrq: SysRq : Power Off
[  204s] [  191.786846] reboot: Power down
[  204s] ### VM INTERACTION END ###
[  204s] 
[  204s] lamb19 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 14 
19:58:02 UTC 2018.
[  204s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_17.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  177s] No package 'libpcsclite' found
[  177s] simtrace2-remsim.o: In function `main':
[  177s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  177s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  177s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  177s] apdu_dispatch.o: In function `apdu_segment_in':
[  177s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  177s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  177s] collect2: error: ld returned 1 exit status
[  177s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  177s] make[2]: *** [simtrace2-remsim] Error 1
[  177s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  177s] Makefile:20: recipe for target 'utils' failed
[  177s] make[1]: *** [utils] Error 2
[  177s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  177s] dh_auto_build: make -j1 returned exit code 2
[  177s] debian/rules:4: recipe for target 'build' failed
[  177s] make: *** [build] Error 2
[  177s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  177s] 
[  177s] cloud128 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 14 
19:57:45 UTC 2018.
[  177s] 
[  177s] ### VM INTERACTION START ###
[  180s] [  159.566898] sysrq: SysRq : Power Off
[  180s] [  159.571644] reboot: Power down
[  182s] ### VM INTERACTION END ###
[  182s] 
[  182s] cloud128 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 14 
19:57:51 UTC 2018.
[  182s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_16.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  137s] No package 'libpcsclite' found
[  137s] simtrace2-remsim.o: In function `main':
[  137s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  137s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  137s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  137s] apdu_dispatch.o: In function `apdu_segment_in':
[  137s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  137s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  137s] collect2: error: ld returned 1 exit status
[  137s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  137s] make[2]: *** [simtrace2-remsim] Error 1
[  137s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  137s] Makefile:20: recipe for target 'utils' failed
[  137s] make[1]: *** [utils] Error 2
[  137s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  137s] dh_auto_build: make -j1 returned exit code 2
[  137s] debian/rules:4: recipe for target 'build' failed
[  137s] make: *** [build] Error 2
[  137s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  137s] 
[  137s] lamb21 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 14 
19:57:49 UTC 2018.
[  137s] 
[  137s] ### VM INTERACTION START ###
[  141s] [  130.913077] sysrq: SysRq : Power Off
[  141s] [  130.917259] reboot: Power down
[  141s] ### VM INTERACTION END ###
[  141s] 
[  141s] lamb21 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 14 
19:57:53 UTC 2018.
[  141s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_17.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_17.10/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_17.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  134s] No package 'libpcsclite' found
[  134s] simtrace2-remsim.o: In function `main':
[  134s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  134s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  134s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  134s] apdu_dispatch.o: In function `apdu_segment_in':
[  134s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  134s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  134s] collect2: error: ld returned 1 exit status
[  134s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  134s] make[2]: *** [simtrace2-remsim] Error 1
[  134s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  134s] Makefile:20: recipe for target 'utils' failed
[  134s] make[1]: *** [utils] Error 2
[  134s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  134s] dh_auto_build: make -j1 returned exit code 2
[  134s] debian/rules:4: recipe for target 'build' failed
[  134s] make: *** [build] Error 2
[  134s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  134s] 
[  134s] lamb58 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 14 
19:57:05 UTC 2018.
[  134s] 
[  134s] ### VM INTERACTION START ###
[  137s] [  127.956983] sysrq: SysRq : Power Off
[  137s] [  127.963970] reboot: Power down
[  137s] ### VM INTERACTION END ###
[  137s] 
[  137s] lamb58 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 14 
19:57:09 UTC 2018.
[  137s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/i586

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  140s] No package 'libpcsclite' found
[  140s] simtrace2-remsim.o: In function `main':
[  140s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  140s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  140s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  140s] apdu_dispatch.o: In function `apdu_segment_in':
[  140s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  140s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  140s] collect2: error: ld returned 1 exit status
[  140s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  140s] make[2]: *** [simtrace2-remsim] Error 1
[  140s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  140s] Makefile:20: recipe for target 'utils' failed
[  140s] make[1]: *** [utils] Error 2
[  140s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  140s] dh_auto_build: make -j1 returned exit code 2
[  140s] debian/rules:4: recipe for target 'build' failed
[  140s] make: *** [build] Error 2
[  140s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  140s] 
[  140s] lamb13 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 14 
19:57:29 UTC 2018.
[  140s] 
[  140s] ### VM INTERACTION START ###
[  143s] [  131.651231] sysrq: SysRq : Power Off
[  143s] [  131.658457] reboot: Power down
[  143s] ### VM INTERACTION END ###
[  143s] 
[  143s] lamb13 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 14 
19:57:32 UTC 2018.
[  143s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_16.04/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  141s] No package 'libpcsclite' found
[  141s] simtrace2-remsim.o: In function `main':
[  141s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  141s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  141s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  141s] apdu_dispatch.o: In function `apdu_segment_in':
[  141s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  141s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  141s] collect2: error: ld returned 1 exit status
[  141s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  141s] make[2]: *** [simtrace2-remsim] Error 1
[  141s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  141s] Makefile:20: recipe for target 'utils' failed
[  141s] make[1]: *** [utils] Error 2
[  141s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  141s] dh_auto_build: make -j1 returned exit code 2
[  141s] debian/rules:4: recipe for target 'build' failed
[  141s] make: *** [build] Error 2
[  141s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  141s] 
[  141s] build31 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 14 
19:56:57 UTC 2018.
[  141s] 
[  141s] ### VM INTERACTION START ###
[  145s] [  132.987719] sysrq: SysRq : Power Off
[  145s] [  133.004495] reboot: Power down
[  145s] ### VM INTERACTION END ###
[  145s] 
[  145s] build31 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 14 
19:57:01 UTC 2018.
[  145s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  110s] No package 'libpcsclite' found
[  110s] simtrace2-remsim.o: In function `main':
[  110s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  110s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  110s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  110s] apdu_dispatch.o: In function `apdu_segment_in':
[  110s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  110s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  110s] collect2: error: ld returned 1 exit status
[  110s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  110s] make[2]: *** [simtrace2-remsim] Error 1
[  110s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  110s] Makefile:20: recipe for target 'utils' failed
[  110s] make[1]: *** [utils] Error 2
[  110s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  110s] dh_auto_build: make -j1 returned exit code 2
[  110s] debian/rules:4: recipe for target 'build' failed
[  110s] make: *** [build] Error 2
[  110s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  110s] 
[  110s] sheep81 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 14 
19:56:23 UTC 2018.
[  110s] 
[  110s] ### VM INTERACTION START ###
[  113s] [  104.731229] sysrq: SysRq : Power Off
[  113s] [  104.737575] reboot: Power down
[  113s] ### VM INTERACTION END ###
[  113s] 
[  113s] sheep81 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 14 
19:56:26 UTC 2018.
[  113s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-ttcn3-hacks[master]: MSC_ConnectionHandler: Make sure COMPLETE LAYER 3 INFORMATION contain...

[dexter]

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/10966


Change subject: MSC_ConnectionHandler: Make sure COMPLETE LAYER 3 INFORMATION 
contains a codecList
..

MSC_ConnectionHandler: Make sure COMPLETE LAYER 3 INFORMATION contains a 
codecList

Since our BSC implementation is ALL-IP, the COMPLETE LAYER 3 INFORMATION
message must contan a Codec List (BSS Supported) information element.
The test currently just receive a L3 compl Template and then continue.
This is implemented without an altstep. So lets have an altstep with
timeout here and make sure that the codecList information element is
always included.

- Check L3 compl message using an alt-step
- Make sure codecList is always included

Change-Id: Ia16a454e78421430ec32cc37939d429970cb06ec
Related: OS#3548
---
M bsc/MSC_ConnectionHandler.ttcn
1 file changed, 20 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/66/10966/1

diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn
index 9f67f1b..f67117a 100644
--- a/bsc/MSC_ConnectionHandler.ttcn
+++ b/bsc/MSC_ConnectionHandler.ttcn
@@ -822,6 +822,7 @@

var BSSMAP_FIELD_CodecType codecType;
var boolean sccplite := false;
+   timer T := 10.0;

/* Check if we run on SCCPLITE instead of SCCP by looking if a CIC is
 * present or not. */
@@ -844,7 +845,24 @@

f_create_chan_and_exp();
/* we should now have a COMPL_L3 at the MSC */
-   BSSAP.receive(tr_BSSMAP_ComplL3);
+
+   var template PDU_BSSAP exp_l3_compl;
+   exp_l3_compl := tr_BSSMAP_ComplL3()
+   exp_l3_compl.pdu.bssmap.completeLayer3Information.codecList := ?;
+   T.start;
+   alt {
+   [] BSSAP.receive(exp_l3_compl);
+   [] BSSAP.receive(tr_BSSMAP_ComplL3) {
+   setverdict(fail, "Received non-matching COMPLETE LAYER 3 
INFORMATION");
+   all component.stop;
+   mtc.stop;
+   }
+   [] T.timeout {
+   setverdict(fail, "Timeout waiting for COMPLETE LAYER 3 
INFORMATION");
+   all component.stop;
+   mtc.stop;
+   }
+   }

/* start ciphering, if requested */
if (ispresent(g_pars.encr)) {
@@ -858,10 +876,10 @@

var PDU_BSSAP ass_cmd := valueof(ass_tpl);
var PDU_BSSAP bssap;
-   timer T := 10.0;
var boolean exp_compl := 
ischosen(exp_ass_cpl.pdu.bssmap.assignmentComplete);
var boolean exp_fail := 
ischosen(exp_ass_cpl.pdu.bssmap.assignmentFailure);
var boolean exp_modify;
+
var ExpectCriteria mgcpcrit := {
connid := omit,
endpoint := omit,

--
To view, visit https://gerrit.osmocom.org/10966
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia16a454e78421430ec32cc37939d429970cb06ec
Gerrit-Change-Number: 10966
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 

Change in osmo-bsc[master]: codec_pref: add AMR configuration bits to make_scl_config() in unit-test

[dexter]

dexter has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/10963 )

Change subject: codec_pref: add AMR configuration bits to make_scl_config() in 
unit-test
..

codec_pref: add AMR configuration bits to make_scl_config() in unit-test

The the function make_scl_config() is used to generate realistically
looking speech codec lists to perform the unit tests for codec_pref.c.
This function does not yet populate the S0-S15 bits for AMR codecs. Lets
make sure that at least the default configuration is populated here.

Change-Id: I534239416c038ea856c128659f314aa521f85c15
---
M tests/codec_pref/codec_pref_test.c
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/63/10963/2
--
To view, visit https://gerrit.osmocom.org/10963
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I534239416c038ea856c128659f314aa521f85c15
Gerrit-Change-Number: 10963
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-CC: Jenkins Builder (102)

Change in osmo-bsc[master]: codec_pref: Add Codec List to COMPLETE LAYER 3 INFORMATION

[dexter]

dexter has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/10965 )

Change subject: codec_pref: Add Codec List to COMPLETE LAYER 3 INFORMATION
..

codec_pref: Add Codec List to COMPLETE LAYER 3 INFORMATION

The COMPLETE LAYER 3 INFORMATION message lacks the Codec List (BSS Supported)
information element. This information element is mandatory for networks
that use an IP based user plane (AoIP).

- Add function to generate the speech codec list from the current codec
  settings (Available codecs)
- Generate and embed information element in L3 Compl. message

Depends: libosmocore I4e656731b16621736c7a2f4e64d9ce63b1064e98

Change-Id: Id6f2af3fdab45bf05f06aec03e222734d7a4cf70
Related: OS#3548
---
M include/osmocom/bsc/codec_pref.h
M src/osmo-bsc/codec_pref.c
M src/osmo-bsc/gsm_08_08.c
M tests/codec_pref/codec_pref_test.c
M tests/codec_pref/codec_pref_test.ok
5 files changed, 1,213 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/65/10965/2
--
To view, visit https://gerrit.osmocom.org/10965
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id6f2af3fdab45bf05f06aec03e222734d7a4cf70
Gerrit-Change-Number: 10965
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-CC: Jenkins Builder (102)

Change in osmo-bsc[master]: codec_pref: fix missing breaks in switch-case statement

[dexter]

dexter has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/10964 )

Change subject: codec_pref: fix missing breaks in switch-case statement
..

codec_pref: fix missing breaks in switch-case statement

In function test_codec_support_bts() the switch case statement lacks
break; statements for some cases. This may lead into messed up codec
decisions.

- Add missing break statements

Change-Id: Ib5400a0a0a8a39fa714bd087df345160bed5cc61
---
M src/osmo-bsc/codec_pref.c
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/64/10964/2
--
To view, visit https://gerrit.osmocom.org/10964
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5400a0a0a8a39fa714bd087df345160bed5cc61
Gerrit-Change-Number: 10964
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-CC: Jenkins Builder (102)

Change in osmo-bsc[master]: codec_pref: add AMR configuration bits to make_scl_config in unit-test

[dexter]

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/10963


Change subject: codec_pref: add AMR configuration bits to make_scl_config in 
unit-test
..

codec_pref: add AMR configuration bits to make_scl_config in unit-test

The the function make_scl_config() is used to generate realistically
looking speech codec lists to perform the unit tests for codec_pref.c.
This function does not yet populate the S0-S15 bits for AMR codecs. Lets
make sure that at least the default configuration is populated here.

Change-Id: I534239416c038ea856c128659f314aa521f85c15
---
M tests/codec_pref/codec_pref_test.c
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/63/10963/1

diff --git a/tests/codec_pref/codec_pref_test.c 
b/tests/codec_pref/codec_pref_test.c
index b0b9f5e..efc77f6 100644
--- a/tests/codec_pref/codec_pref_test.c
+++ b/tests/codec_pref/codec_pref_test.c
@@ -78,11 +78,13 @@
case 3:
/* FR3 only */
scl->codec[0].type = GSM0808_SCT_FR3;
+   scl->codec[0].cfg = GSM0808_SC_CFG_DEFAULT_FR_AMR;
scl->len = 1;
break;
case 4:
/* HR3 only */
scl->codec[0].type = GSM0808_SCT_HR3;
+   scl->codec[0].cfg = GSM0808_SC_CFG_DEFAULT_HR_AMR;
scl->len = 1;
break;
case 5:
@@ -102,7 +104,9 @@
/* FR1, FR3 and HR3 */
scl->codec[0].type = GSM0808_SCT_FR1;
scl->codec[1].type = GSM0808_SCT_FR3;
+   scl->codec[1].cfg = GSM0808_SC_CFG_DEFAULT_FR_AMR;
scl->codec[2].type = GSM0808_SCT_HR3;
+   scl->codec[2].cfg = GSM0808_SC_CFG_DEFAULT_HR_AMR;
scl->len = 3;
break;
case 8:
@@ -110,8 +114,10 @@
scl->codec[0].type = GSM0808_SCT_FR1;
scl->codec[1].type = GSM0808_SCT_FR2;
scl->codec[2].type = GSM0808_SCT_FR3;
+   scl->codec[2].cfg = GSM0808_SC_CFG_DEFAULT_FR_AMR;
scl->codec[3].type = GSM0808_SCT_HR1;
scl->codec[4].type = GSM0808_SCT_HR3;
+   scl->codec[4].cfg = GSM0808_SC_CFG_DEFAULT_HR_AMR;
scl->len = 5;
break;
}

--
To view, visit https://gerrit.osmocom.org/10963
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I534239416c038ea856c128659f314aa521f85c15
Gerrit-Change-Number: 10963
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 

Change in osmo-bsc[master]: codec_pref: fix typo in comment

[dexter]

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/10962


Change subject: codec_pref: fix typo in comment
..

codec_pref: fix typo in comment

Change-Id: Ie4ea8179395cd331dad4b62227debb026b5b008c
---
M src/osmo-bsc/codec_pref.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/62/10962/1

diff --git a/src/osmo-bsc/codec_pref.c b/src/osmo-bsc/codec_pref.c
index 2a9be6e..96c2c38 100644
--- a/src/osmo-bsc/codec_pref.c
+++ b/src/osmo-bsc/codec_pref.c
@@ -167,7 +167,7 @@
 /*! Match the codec preferences from local config with a received codec 
preferences IEs received from the
  * MSC and the BTS' codec configuration.
  *  \param[out] chan_mode GSM 04.08 channel mode.
- *  \param[out] full_rate true iff full-rate.
+ *  \param[out] full_rate true if full-rate.
  *  \param[in] ct GSM 08.08 channel type received from MSC.
  *  \param[in] scl GSM 08.08 speech codec list received from MSC (optional).
  *  \param[in] audio_support List of allowed codecs as from local config.

--
To view, visit https://gerrit.osmocom.org/10962
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4ea8179395cd331dad4b62227debb026b5b008c
Gerrit-Change-Number: 10962
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 

Change in osmo-bsc[master]: codec_pref: fix missing breaks in switch-case statement

[dexter]

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/10964


Change subject: codec_pref: fix missing breaks in switch-case statement
..

codec_pref: fix missing breaks in switch-case statement

In function test_codec_support_bts() the switch case statement lacks
break; statements for some cases. This may lead into messed up codec
decisions.

- Add missing break statements

Change-Id: Ib5400a0a0a8a39fa714bd087df345160bed5cc61
---
M src/osmo-bsc/codec_pref.c
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/64/10964/1

diff --git a/src/osmo-bsc/codec_pref.c b/src/osmo-bsc/codec_pref.c
index 96c2c38..924f77f 100644
--- a/src/osmo-bsc/codec_pref.c
+++ b/src/osmo-bsc/codec_pref.c
@@ -148,15 +148,19 @@
case GSM0808_PERM_FR2:
if (bts_codec->efr)
return true;
+   break;
case GSM0808_PERM_FR3:
if (bts_codec->amr)
return true;
+   break;
case GSM0808_PERM_HR1:
if (bts_codec->hr)
return true;
+   break;
case GSM0808_PERM_HR3:
if (bts_codec->amr)
return true;
+   break;
default:
return false;
}

--
To view, visit https://gerrit.osmocom.org/10964
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5400a0a0a8a39fa714bd087df345160bed5cc61
Gerrit-Change-Number: 10964
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 

Change in libosmocore[master]: gsm0808: add function to convert amr gsm0408 setings to gsm0808

[dexter]

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/10961


Change subject: gsm0808: add function to convert amr gsm0408 setings to gsm0808
..

gsm0808: add function to convert amr gsm0408 setings to gsm0808

Add a function to convert struct gsm48_multi_rate_conf, which holds the
codec settings for AMR, to S0-S15 bit representation as defined in
3GPP TS 48.008 3.2.2.49

Change-Id: I4e656731b16621736c7a2f4e64d9ce63b1064e98
Related: OS#3548
---
M include/osmocom/gsm/gsm0808_utils.h
M include/osmocom/gsm/protocol/gsm_08_08.h
M src/gsm/gsm0808_utils.c
M src/gsm/libosmogsm.map
M tests/gsm0808/gsm0808_test.c
M tests/gsm0808/gsm0808_test.ok
6 files changed, 480 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/61/10961/1

diff --git a/include/osmocom/gsm/gsm0808_utils.h 
b/include/osmocom/gsm/gsm0808_utils.h
index 242bce9..0a7429e 100644
--- a/include/osmocom/gsm/gsm0808_utils.h
+++ b/include/osmocom/gsm/gsm0808_utils.h
@@ -104,6 +104,7 @@
 int gsm0808_chan_type_to_speech_codec(uint8_t perm_spch);
 int gsm0808_speech_codec_from_chan_type(struct gsm0808_speech_codec *sc,
uint8_t perm_spch);
+uint16_t gsm0808_sc_cfg_from_gsm48_mr_cfg(struct gsm48_multi_rate_conf *cfg, 
bool fr);

 /*! Return 3GPP TS 48.008 3.2.2.49 Current Channel Type 1 from enum 
gsm_chan_t. */
 static inline uint8_t gsm0808_current_channel_type_1(enum gsm_chan_t type)
diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h 
b/include/osmocom/gsm/protocol/gsm_08_08.h
index 9433817..8431ace 100644
--- a/include/osmocom/gsm/protocol/gsm_08_08.h
+++ b/include/osmocom/gsm/protocol/gsm_08_08.h
@@ -503,6 +503,20 @@
GSM0808_SC_CFG_DEFAULT_OHR_AMR_WB   = 0x01,
 };

+/*! Default speech codec configurations broken down by reate.
+ *  See also: 3GPP TS 28.062, Table 7.11.3.1.3-2: Preferred Configurations for
+ *  the Adaptive Multi-Rate Codec Types. */
+enum gsm0808_speech_codec_rate_defaults {
+   GSM0808_SC_CFG_DEFAULT_AMR_4_75 = 0xff03,
+   GSM0808_SC_CFG_DEFAULT_AMR_5_15 = 0x,
+   GSM0808_SC_CFG_DEFAULT_AMR_5_90 = 0xff06,
+   GSM0808_SC_CFG_DEFAULT_AMR_6_70 = 0x3e08,
+   GSM0808_SC_CFG_DEFAULT_AMR_7_40 = 0x0c12,
+   GSM0808_SC_CFG_DEFAULT_AMR_7_95 = 0xc020,
+   GSM0808_SC_CFG_DEFAULT_AMR_10_2 = 0x3040,
+   GSM0808_SC_CFG_DEFAULT_AMR_12_2 = 0xc082
+};
+
 /* 3GPP TS 48.008 3.2.2.103 Speech Codec List */
 #define SPEECH_CODEC_MAXLEN 255
 struct gsm0808_speech_codec_list {
diff --git a/src/gsm/gsm0808_utils.c b/src/gsm/gsm0808_utils.c
index 73f0234..4b2a5f5 100644
--- a/src/gsm/gsm0808_utils.c
+++ b/src/gsm/gsm0808_utils.c
@@ -1161,6 +1161,49 @@
return 0;
 }

+/*! Determine a set of AMR speech codec configuration bits (S0-S15) from a
+ *  given GSM 04.08 AMR configuration struct.
+ *  \param[in] cfg AMR configuration in GSM 04.08 format.
+ *  \param[in] hint if the resulting configuration shall be used with a FR or 
HR TCH.
+ *  \returns configuration bits (S0-S15) */
+uint16_t gsm0808_sc_cfg_from_gsm48_mr_cfg(struct gsm48_multi_rate_conf *cfg,
+ bool fr)
+{
+   uint16_t s15_s0 = 0;
+
+   /* Check each rate bit in the AMR multirate configuration and pick the
+* matching default configuration as specified in 3GPP TS 28.062,
+* Table 7.11.3.1.3-2. */
+   if (cfg->m4_75)
+   s15_s0 |= GSM0808_SC_CFG_DEFAULT_AMR_4_75;
+   if (cfg->m5_15)
+   s15_s0 |= GSM0808_SC_CFG_DEFAULT_AMR_5_15;
+   if (cfg->m5_90)
+   s15_s0 |= GSM0808_SC_CFG_DEFAULT_AMR_5_90;
+   if (cfg->m6_70)
+   s15_s0 |= GSM0808_SC_CFG_DEFAULT_AMR_6_70;
+   if (cfg->m7_40)
+   s15_s0 |= GSM0808_SC_CFG_DEFAULT_AMR_7_40;
+   if (cfg->m7_95)
+   s15_s0 |= GSM0808_SC_CFG_DEFAULT_AMR_7_95;
+   if (cfg->m10_2)
+   s15_s0 |= GSM0808_SC_CFG_DEFAULT_AMR_10_2;
+   if (cfg->m12_2)
+   s15_s0 |= GSM0808_SC_CFG_DEFAULT_AMR_12_2;
+
+   /* Note: 3GPP TS 48.008, chapter 3GPP TS 48.008 states that for AMR
+* some of the configuration bits must be coded as zeros. The applied
+* bitmask matches the default codec settings. See also the definition
+* of enum gsm0808_speech_codec_defaults in gsm_08_08.h and
+* 3GPP TS 28.062, Table 7.11.3.1.3-2. */
+   if (fr)
+   s15_s0 &= GSM0808_SC_CFG_DEFAULT_FR_AMR;
+   else
+   s15_s0 &= GSM0808_SC_CFG_DEFAULT_HR_AMR;
+
+   return s15_s0;
+}
+
 /*! Print a human readable name of the cell identifier to the char buffer.
  * This is useful both for struct gsm0808_cell_id and struct 
gsm0808_cell_id_list2.
  * See also gsm0808_cell_id_name() and gsm0808_cell_id_list_name().
diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map
index 0c40c88..3d08232 100644
--- a/src/gsm/libosmogsm.map
+++ 

Change in libosmocore[master]: gsm0808: fix wrong codec defaults for OFR_AMR_WB

[dexter]

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/10960


Change subject: gsm0808: fix wrong codec defaults for OFR_AMR_WB
..

gsm0808: fix wrong codec defaults for OFR_AMR_WB

3GPP TS 48.008 chapter 3.2.2.103 states that the configuration bits of
OFR_AMR_WB are coded as follows:

"S0, S2, S4 indicates the supported Codec Configurations. S1, S3, S5, S6,
S7 are reserved and coded with zeroes."

The current default setting of 0x3F violates this requirement. Lets set
the "forbidden" settings zu zero and keep only the allowed ones.

Change-Id: I4a481def59e9c98cfdcafc2b80c0ac7df0c14130
---
M include/osmocom/gsm/protocol/gsm_08_08.h
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/60/10960/1

diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h 
b/include/osmocom/gsm/protocol/gsm_08_08.h
index 69007b5..9433817 100644
--- a/include/osmocom/gsm/protocol/gsm_08_08.h
+++ b/include/osmocom/gsm/protocol/gsm_08_08.h
@@ -499,7 +499,7 @@
GSM0808_SC_CFG_DEFAULT_HR_AMR   = 0x073f,
GSM0808_SC_CFG_DEFAULT_OHR_AMR  = 0x57ff,
GSM0808_SC_CFG_DEFAULT_FR_AMR_WB= 0x01,
-   GSM0808_SC_CFG_DEFAULT_OFR_AMR_WB   = 0x3f,
+   GSM0808_SC_CFG_DEFAULT_OFR_AMR_WB   = 0x15,
GSM0808_SC_CFG_DEFAULT_OHR_AMR_WB   = 0x01,
 };


--
To view, visit https://gerrit.osmocom.org/10960
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a481def59e9c98cfdcafc2b80c0ac7df0c14130
Gerrit-Change-Number: 10960
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 

Change in osmo-bsc[master]: LCLS: use type and tch_mode from lchan to check codec

[dexter]

Hello Vadim Yanitskiy, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10905

to look at the new patch set (#2).

Change subject: LCLS: use type and tch_mode from lchan to check codec
..

LCLS: use type and tch_mode from lchan to check codec

When not explicitly allowed via VTY settings, the LCLS mechanisms will
avoid to locally switch connections with different codecs/rates. For
example GSM HR and GSM FR would not be locally switched.

At the moment osmo_bsc_lcls.c uses abandonned struct members to check if
there is a codec mismatch, so a mismatch will never be detected.

- Use struct member "tch_mode" and "type" from struct gsm_lchan *lchan
  instead of "full_rate" and "chan_mode" from struct gsm_subscriber_connection

Change-Id: Idd7117092b1f170d5029303ae5ba0a49e02a8bfb
Related: OS#1602
---
M src/osmo-bsc/osmo_bsc_lcls.c
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/05/10905/2
--
To view, visit https://gerrit.osmocom.org/10905
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd7117092b1f170d5029303ae5ba0a49e02a8bfb
Gerrit-Change-Number: 10905
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Harald Welte 
Gerrit-CC: Neels Hofmeyr 

Change in osmo-bsc[master]: gsm_data: remove unused struct member full_rate.

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/10906 )

Change subject: gsm_data: remove unused struct member full_rate.
..


Patch Set 1:

> (1 comment)

Presumably the problem with the abandoned struct members just slipped through 
while neels was working on the lchan FSM. I will ask him. Maybe he knows more 
about this.


--
To view, visit https://gerrit.osmocom.org/10906
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a14efe0039ff4690e27e3b083eb23c1b2a616c3
Gerrit-Change-Number: 10906
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: dexter 
Gerrit-CC: Neels Hofmeyr 
Gerrit-Comment-Date: Fri, 14 Sep 2018 17:37:18 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in meta-telephony[laforge/nightly]: osmo-ggsn: handle systemd and cfg files through autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10952 )

Change subject: osmo-ggsn: handle systemd and cfg files through autotools
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10952
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c220c11f58793c644d750040c7fad347500bb8a
Gerrit-Change-Number: 10952
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 14 Sep 2018 16:21:10 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-hlr: handle systemd and cfg files through autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10950 )

Change subject: osmo-hlr: handle systemd and cfg files through autotools
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10950
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e3725c6ffef9223015df8cf76b5d5c884a76fce
Gerrit-Change-Number: 10950
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 14 Sep 2018 16:21:02 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-sip-connector: handle systemd and cfg files through autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10957 )

Change subject: osmo-sip-connector: handle systemd and cfg files through 
autotools
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10957
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I88fa636fdc97dbd1c8d13358fb48d157bd95c805
Gerrit-Change-Number: 10957
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 14 Sep 2018 16:21:27 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-msc: handle systemd and cfg files through autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10955 )

Change subject: osmo-msc: handle systemd and cfg files through autotools
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10955
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ccddd158f88fdd5dbe8e9a36c62d515b973486a
Gerrit-Change-Number: 10955
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 14 Sep 2018 16:21:20 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: openbsc: handle systemd and cfg files through autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10959 )

Change subject: openbsc: handle systemd and cfg files through autotools
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10959
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6e6855cd34dd171e7e550646b8e37d606fc5653
Gerrit-Change-Number: 10959
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 14 Sep 2018 16:21:33 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-ggsn: Drop untested sysvinit support

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10951 )

Change subject: osmo-ggsn: Drop untested sysvinit support
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10951
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I303ea210e14e0e6e9a18b1bb4c25d470924d80c6
Gerrit-Change-Number: 10951
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 14 Sep 2018 16:21:06 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-sgsn: handle systemd and cfg files through autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10953 )

Change subject: osmo-sgsn: handle systemd and cfg files through autotools
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10953
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib84a3c8634db2282b2d3757ae7c044a196720852
Gerrit-Change-Number: 10953
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 14 Sep 2018 16:21:14 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-iuh: handle systemd and cfg files through autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10949 )

Change subject: osmo-iuh: handle systemd and cfg files through autotools
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10949
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: If879153a32ae21ad63284382a420da534f30e6eb
Gerrit-Change-Number: 10949
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 14 Sep 2018 16:20:59 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-mgw: handle systemd and cfg files through autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10954 )

Change subject: osmo-mgw: handle systemd and cfg files through autotools
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10954
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab265207f534f5d2b5960b707081b06aa5d34d11
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 14 Sep 2018 16:21:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-bsc: handle systemd and cfg files through autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10956 )

Change subject: osmo-bsc: handle systemd and cfg files through autotools
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10956
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I752503f1ad7562ead50ec2bb7be49a958b9dc0f0
Gerrit-Change-Number: 10956
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 14 Sep 2018 16:21:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: openbsc: Drop untested sysvinit support

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10958 )

Change subject: openbsc: Drop untested sysvinit support
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10958
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I864e4a61aed7933c46b80aa26598234faba43395
Gerrit-Change-Number: 10958
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 14 Sep 2018 16:21:30 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: libosmo-sccp: handle systemd and cfg files through autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10948 )

Change subject: libosmo-sccp: handle systemd and cfg files through autotools
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10948
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I7bb69bdad7582e29b66f075db1305305a9ca648c
Gerrit-Change-Number: 10948
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 14 Sep 2018 16:20:56 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-hlr: handle systemd and cfg files through autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10950


Change subject: osmo-hlr: handle systemd and cfg files through autotools
..

osmo-hlr: handle systemd and cfg files through autotools

Change-Id: I1e3725c6ffef9223015df8cf76b5d5c884a76fce
---
M recipes-osmocom/osmo-hlr/osmo-hlr.inc
1 file changed, 6 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/50/10950/1

diff --git a/recipes-osmocom/osmo-hlr/osmo-hlr.inc 
b/recipes-osmocom/osmo-hlr/osmo-hlr.inc
index 8f078ed..13c01f7 100644
--- a/recipes-osmocom/osmo-hlr/osmo-hlr.inc
+++ b/recipes-osmocom/osmo-hlr/osmo-hlr.inc
@@ -5,7 +5,7 @@

 DEPENDS = "libtalloc libosmocore libosmo-abis sqlite3 sqlite3-native"

-INC_PR="r1.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r2.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd

@@ -14,15 +14,15 @@
 }

 do_install_append() {
-   install -d ${D}${systemd_system_unitdir}/
-   install -d ${D}${sysconfdir}/osmocom/
install -d ${D}${localstatedir}/lib/osmocom/
-
-   install -m 0644 ${S}/doc/examples/osmo-hlr.cfg 
${D}${sysconfdir}/osmocom/
-   install -m 0644 ${S}/contrib/systemd/osmo-hlr.service 
${D}${systemd_system_unitdir}/
install -m 0644 ${WORKDIR}/hlr.db 
${D}${localstatedir}/lib/osmocom/hlr.db
 }

+PACKAGECONFIG ??= "\
+${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+"
+PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"
+
 PACKAGES =+ "libosmo-gsup-client libosmo-gsup-client-dev osmo-hlr-utils"

 FILES_libosmo-gsup-client = "${libdir}/libosmo-gsup-client${SOLIBS}"

--
To view, visit https://gerrit.osmocom.org/10950
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e3725c6ffef9223015df8cf76b5d5c884a76fce
Gerrit-Change-Number: 10950
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: openbsc: handle systemd and cfg files through autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10959


Change subject: openbsc: handle systemd and cfg files through autotools
..

openbsc: handle systemd and cfg files through autotools

Change-Id: Ie6e6855cd34dd171e7e550646b8e37d606fc5653
---
M recipes-osmocom/openbsc/openbsc.inc
1 file changed, 6 insertions(+), 15 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/59/10959/1

diff --git a/recipes-osmocom/openbsc/openbsc.inc 
b/recipes-osmocom/openbsc/openbsc.inc
index ca3b124..71921b7 100644
--- a/recipes-osmocom/openbsc/openbsc.inc
+++ b/recipes-osmocom/openbsc/openbsc.inc
@@ -6,30 +6,21 @@

 RDEPENDS_osmo-nitb = "libdbd-sqlite3"

-INC_PR = "r3.${META_TELEPHONY_OSMO_INC}"
+INC_PR = "r4.${META_TELEPHONY_OSMO_INC}"

 EXTRA_OECONF += "--enable-nat --enable-osmo-bsc --enable-smpp 
--enable-mgcp-transcoding --with-g729"

 inherit autotools systemd pkgconfig

 do_install_append() {
-   install -d ${D}${sysconfdir}/osmocom
-   install -m 0660 ${S}/doc/examples/osmo-nitb/nanobts/openbsc.cfg 
${D}${sysconfdir}/osmocom/osmo-nitb.cfg
-   install -m 0660 
${S}/doc/examples/osmo-bsc-sccplite/osmo-bsc-sccplite.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-sccplite.cfg
-   install -m 0644 ${S}/doc/examples/osmo-bsc_nat/osmo-bsc_nat.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-nat.cfg
-   install -m 0644 ${S}/doc/examples/osmo-bsc_mgcp/mgcp.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-mgcp.cfg
-
-   # Install systemd files and enable on sysinit
-   install -d ${D}${systemd_system_unitdir}/
-   install -m 0644 ${S}/contrib/systemd/osmo-nitb.service 
${D}${systemd_system_unitdir}/
-   install -m 0644 ${S}/contrib/systemd/osmo-bsc-sccplite.service 
${D}${systemd_system_unitdir}/
-   install -m 0644 ${S}/contrib/systemd/osmo-bsc-nat.service 
${D}${systemd_system_unitdir}/
-   install -m 0644 ${S}/contrib/systemd/osmo-bsc-mgcp.service 
${D}${systemd_system_unitdir}/
-
install -d ${D}/var/lib/osmocom
-
 }

+PACKAGECONFIG ??= "\
+${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+"
+PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"
+
 PACKAGES =+ "osmo-bsc-nat osmo-bsc-sccplite osmo-nitb osmo-bsc-mgcp"
 SYSTEMD_PACKAGES = "osmo-bsc-nat osmo-bsc-sccplite osmo-nitb osmo-bsc-mgcp"


--
To view, visit https://gerrit.osmocom.org/10959
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6e6855cd34dd171e7e550646b8e37d606fc5653
Gerrit-Change-Number: 10959
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: osmo-ggsn: Drop untested sysvinit support

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10951


Change subject: osmo-ggsn: Drop untested sysvinit support
..

osmo-ggsn: Drop untested sysvinit support

These bits come from times were sysvinit was used in stead of systemd in
yocto. Nowadays nobody is known to be using the recipes with sysvinit
instead of systemd, and anyway most osmocom recipes doesn't come with
sysvinit support, so let's drop it. If sysvinit support is required, it
should be added through autotools install process instead.

Change-Id: I303ea210e14e0e6e9a18b1bb4c25d470924d80c6
---
D recipes-osmocom/osmo-ggsn/files/osmo-ggsn.init
M recipes-osmocom/osmo-ggsn/osmo-ggsn.inc
M recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
3 files changed, 3 insertions(+), 179 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/51/10951/1

diff --git a/recipes-osmocom/osmo-ggsn/files/osmo-ggsn.init 
b/recipes-osmocom/osmo-ggsn/files/osmo-ggsn.init
deleted file mode 100755
index 157d6dd..000
--- a/recipes-osmocom/osmo-ggsn/files/osmo-ggsn.init
+++ /dev/null
@@ -1,169 +0,0 @@
-#!/bin/sh
-### BEGIN INIT INFO
-# Provides:  osmo-ggsn
-# Required-Start:$network $local_fs
-# Required-Stop:
-# Default-Start: 2 3 4 5
-# Default-Stop:  0 1 6
-# Short-Description: Osmocom GSM network-in-a-box
-# Description:   A minimal implementation of the GSM Base Station 
Controller,
-#Mobile Switching Center, Home Location regster and all 
other
-#components to run a self-contained GSM network.
-### END INIT INFO
-
-# Author: Harald Welte 
-
-# PATH should only include /usr/* if it runs after the mountnfs.sh script
-PATH=/sbin:/usr/sbin:/bin:/usr/bin
-DESC="Osmocom GGSN implementation"
-NAME=osmo-ggsn
-DAEMON=/usr/bin/ggsn
-DAEMON_ARGS="" # Arguments to run the daemon with
-PIDFILE=/var/run/$NAME.pid
-SCRIPTNAME=/etc/init.d/$NAME
-CONFIG_FILE=/etc/ggsn.conf
-
-# Exit if the package is not installed
-[ -x $DAEMON ] || exit 0
-
-# Read configuration variable file if it is present
-[ -r /etc/default/$NAME ] && . /etc/default/$NAME
-
-# Load the VERBOSE setting and other rcS variables
-# . /lib/init/vars.sh
-
-# Define LSB log_* functions.
-# Depend on lsb-base (>= 3.0-6) to ensure that this file is present.
-# . /lib/lsb/init-functions
-
-DAEMON_ARGS="$DAEMON_ARGS -c $CONFIG_FILE"
-
-#
-# Function that starts the daemon/service
-#
-do_start()
-{
-   # Return
-   #   0 if daemon has been started
-   #   1 if daemon was already running
-   #   2 if daemon could not be started
-/sbin/modprobe tun
-   start-stop-daemon --start --quiet --pidfile $PIDFILE --exec $DAEMON 
--test > /dev/null \
-   || return 1
-
-   # Check for runtime directory of nonvolatile data
-   if [ ! -d /var/lib/ggsn ]; then
-   mkdir /var/lib/ggsn
-   fi
-
-   # Check for GTP restart counter
-   if [ ! -f /var/lib/ggsn/gsn_restart ]; then
-   echo 0 > /var/lib/ggsn/gsn_restart
-   fi
-
-   start-stop-daemon --start --quiet --pidfile $PIDFILE --exec $DAEMON -- \
-   $DAEMON_ARGS \
-   || return 2
-   # Add code here, if necessary, that waits for the process to be ready
-   # to handle requests from services started subsequently which depend
-   # on this one.  As a last resort, sleep for some time.
-}
-
-#
-# Function that stops the daemon/service
-#
-do_stop()
-{
-   # Return
-   #   0 if daemon has been stopped
-   #   1 if daemon was already stopped
-   #   2 if daemon could not be stopped
-   #   other if a failure occurred
-   start-stop-daemon --stop --quiet --retry=TERM/30/KILL/5 --pidfile 
$PIDFILE --name $NAME
-   RETVAL="$?"
-   [ "$RETVAL" = 2 ] && return 2
-   # Wait for children to finish too if this is a daemon that forks
-   # and if the daemon is only ever run from this initscript.
-   # If the above conditions are not satisfied then add some other code
-   # that waits for the process to drop all resources that could be
-   # needed by services started subsequently.  A last resort is to
-   # sleep for some time.
-   start-stop-daemon --stop --quiet --oknodo --retry=0/30/KILL/5 --exec 
$DAEMON
-   [ "$?" = 2 ] && return 2
-   # Many daemons don't delete their pidfiles when they exit.
-   rm -f $PIDFILE
-   return "$RETVAL"
-}
-
-#
-# Function that sends a SIGHUP to the daemon/service
-#
-do_reload() {
-   #
-   # If the daemon can reload its configuration without
-   # restarting (for example, when it is sent a SIGHUP),
-   # then implement that here.
-   #
-   start-stop-daemon --stop --signal 1 --quiet --pidfile $PIDFILE --name 
$NAME
-   return 0
-}
-
-case "$1" in
-  start)
-#[ "$VERBOSE" != no ] && log_daemon_msg "Starting $DESC " "$NAME"
-

Change in meta-telephony[laforge/nightly]: osmo-bsc: handle systemd and cfg files through autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10956


Change subject: osmo-bsc: handle systemd and cfg files through autotools
..

osmo-bsc: handle systemd and cfg files through autotools

Change-Id: I752503f1ad7562ead50ec2bb7be49a958b9dc0f0
---
M recipes-osmocom/osmo-bsc/osmo-bsc.inc
1 file changed, 5 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/56/10956/1

diff --git a/recipes-osmocom/osmo-bsc/osmo-bsc.inc 
b/recipes-osmocom/osmo-bsc/osmo-bsc.inc
index d066a58..484a779 100644
--- a/recipes-osmocom/osmo-bsc/osmo-bsc.inc
+++ b/recipes-osmocom/osmo-bsc/osmo-bsc.inc
@@ -5,18 +5,14 @@

 DEPENDS = "sqlite3 libpcap libosmocore libosmo-abis libosmo-sccp libosmo-netif 
osmo-mgw"

-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd

-do_install_append() {
-   install -d ${D}${systemd_system_unitdir}/
-   install -d ${D}${sysconfdir}/osmocom/
-
-   install -m 0644 ${S}/doc/examples/osmo-bsc/osmo-bsc.cfg 
${D}${sysconfdir}/osmocom/
-
-   install -m 0644 ${S}/contrib/systemd/osmo-bsc.service 
${D}${systemd_system_unitdir}/
-}
+PACKAGECONFIG ??= "\
+${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+"
+PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"

 PACKAGES =+ "meas-utils ipaccess-utils bs11-utils abisip-find"
 SYSTEMD_PACKAGES = "osmo-bsc"

--
To view, visit https://gerrit.osmocom.org/10956
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: newchange
Gerrit-Change-Id: I752503f1ad7562ead50ec2bb7be49a958b9dc0f0
Gerrit-Change-Number: 10956
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: openbsc: Drop untested sysvinit support

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10958


Change subject: openbsc: Drop untested sysvinit support
..

openbsc: Drop untested sysvinit support

These bits come from times were sysvinit was used in stead of systemd in
yocto. Nowadays nobody is known to be using the recipes with sysvinit
instead of systemd, and anyway most osmocom recipes doesn't come with
sysvinit support, so let's drop it. If sysvinit support is required, it
should be added through autotools install process instead.

As update-rc.d was removed, it was noticied that systemd class inherit
was missing, so this commit adds it. As a result, it's not required to
define systemd service file paths in FILES_*.

Change-Id: I864e4a61aed7933c46b80aa26598234faba43395
---
M recipes-osmocom/openbsc/openbsc.inc
D recipes-osmocom/openbsc/openbsc/osmo-bsc-sccplite.init
D recipes-osmocom/openbsc/openbsc/osmo-nitb.init
M recipes-osmocom/openbsc/openbsc_git.bb
4 files changed, 2 insertions(+), 119 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/58/10958/1

diff --git a/recipes-osmocom/openbsc/openbsc.inc 
b/recipes-osmocom/openbsc/openbsc.inc
index ec130db..ca3b124 100644
--- a/recipes-osmocom/openbsc/openbsc.inc
+++ b/recipes-osmocom/openbsc/openbsc.inc
@@ -6,15 +6,11 @@

 RDEPENDS_osmo-nitb = "libdbd-sqlite3"

-SRC_URI = "file://osmo-nitb.init \
-  file://osmo-bsc-sccplite.init \
-  "
-
 INC_PR = "r3.${META_TELEPHONY_OSMO_INC}"

 EXTRA_OECONF += "--enable-nat --enable-osmo-bsc --enable-smpp 
--enable-mgcp-transcoding --with-g729"

-inherit autotools update-rc.d pkgconfig
+inherit autotools systemd pkgconfig

 do_install_append() {
install -d ${D}${sysconfdir}/osmocom
@@ -23,12 +19,6 @@
install -m 0644 ${S}/doc/examples/osmo-bsc_nat/osmo-bsc_nat.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-nat.cfg
install -m 0644 ${S}/doc/examples/osmo-bsc_mgcp/mgcp.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-mgcp.cfg

-   # Install sysv-init files
-   install -d ${D}${sysconfdir}/init.d
-   install -d ${D}${sysconfdir}/rc5.d
-   install -m 0775 ${WORKDIR}/osmo-nitb.init 
${D}${sysconfdir}/init.d/osmo-nitb
-   install -m 0775 ${WORKDIR}/osmo-bsc-sccplite.init 
${D}${sysconfdir}/init.d/osmo-bsc-sccplite
-
# Install systemd files and enable on sysinit
install -d ${D}${systemd_system_unitdir}/
install -m 0644 ${S}/contrib/systemd/osmo-nitb.service 
${D}${systemd_system_unitdir}/
@@ -42,27 +32,18 @@

 PACKAGES =+ "osmo-bsc-nat osmo-bsc-sccplite osmo-nitb osmo-bsc-mgcp"
 SYSTEMD_PACKAGES = "osmo-bsc-nat osmo-bsc-sccplite osmo-nitb osmo-bsc-mgcp"
-INITSCRIPT_PACKAGES = "osmo-bsc-sccplite osmo-nitb"

 CONFFILES_osmo-bsc-sccplite = "${sysconfdir}/osmocom/osmo-bsc-sccplite.cfg"
 SYSTEMD_SERVICE_osmo-bsc-sccplite = "osmo-bsc-sccplite.service"
-INITSCRIPT_NAME_osmo-bsc-sccplite = "osmo-bsc-sccplite"
-INITSCRIPT_PARAMS_osmo-bsc-sccplite = "defaults 30 30"
 FILES_osmo-bsc-sccplite = " ${bindir}/osmo-bsc-sccplite \
${sysconfdir}/osmocom/osmo-bsc-sccplite.cfg \
-   ${sysconfdir}/init.d/osmo-bsc-sccplite \
-   ${systemd_system_unitdir}/osmo-bsc-sccplite.service \
"

 CONFFILES_osmo-nitb = "${sysconfdir}/osmocom/osmo-nitb.cfg"
 SYSTEMD_SERVICE_osmo-nitb = "osmo-nitb.service"
-INITSCRIPT_NAME_osmo-nitb = "osmo-nitb"
-INITSCRIPT_PARAMS_osmo-nitb = "defaults 30 30"
 FILES_osmo-nitb = " ${bindir}/osmo-nitb \
/var/lib/osmocom \
-   ${sysconfdir}/init.d/osmo-nitb \
${sysconfdir}/osmocom/osmo-nitb.cfg \
-   ${systemd_system_unitdir}/osmo-nitb.service \
"

 CONFFILES_osmo-bsc-nat = "${sysconfdir}/osmocom/osmo-bsc_nat.cfg"
@@ -70,7 +51,6 @@
 FILES_osmo-bsc-nat = " \
${bindir}/osmo-bsc_nat \
${sysconfdir}/osmocom/osmo-bsc_nat.cfg \
-   ${systemd_system_unitdir}/osmo-bsc-nat.service \
"

 CONFFILES_osmo-bsc-mgcp = "${sysconfdir}/osmocom/osmo-bsc-mgcp.cfg"
@@ -78,5 +58,4 @@
 FILES_osmo-bsc-mgcp = " \
${bindir}/osmo-bsc_mgcp \
${sysconfdir}/osmocom/osmo-bsc-mgcp.cfg \
-   ${systemd_system_unitdir}/osmo-bsc-mgcp.service \
"
diff --git a/recipes-osmocom/openbsc/openbsc/osmo-bsc-sccplite.init 
b/recipes-osmocom/openbsc/openbsc/osmo-bsc-sccplite.init
deleted file mode 100755
index 3186f6d..000
--- a/recipes-osmocom/openbsc/openbsc/osmo-bsc-sccplite.init
+++ /dev/null
@@ -1,48 +0,0 @@
-#!/bin/sh
-### BEGIN INIT INFO
-# Provides:osmo-bsc-sccplite
-# Required-Start:  $syslog $networking
-# Required-Stop:   $syslog
-# Default-Start:   5
-# Default-Stop:1
-# Short-Description:   Osmocom GSM Base Station Controller (legacy, with 
SCCPLite)
-### END INIT INFO
-
-DAEMON=/usr/bin/osmo-bsc-sccplite

Change in meta-telephony[laforge/nightly]: osmo-ggsn: handle systemd and cfg files through autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10952


Change subject: osmo-ggsn: handle systemd and cfg files through autotools
..

osmo-ggsn: handle systemd and cfg files through autotools

Change-Id: I3c220c11f58793c644d750040c7fad347500bb8a
---
M recipes-osmocom/osmo-ggsn/osmo-ggsn.inc
1 file changed, 8 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/52/10952/1

diff --git a/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc 
b/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc
index fe0170f..0aaf418 100644
--- a/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc
+++ b/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc
@@ -5,22 +5,19 @@

 DEPENDS = "libosmocore"

-INC_PR="r1.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r2.${META_TELEPHONY_OSMO_INC}"
+
+inherit autotools pkgconfig systemd
+
+PACKAGECONFIG ??= "\
+${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+"
+PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"

 PACKAGES =+ " libgtp libgtp-dev libgtp-staticdev osmo-sgsnemu"
 RDEPENDS_${PN} += "iptables"
 RRECOMMENDS_${PN} += "kernel-module-ipt-masquerade kernel-module-tun"

-inherit autotools pkgconfig systemd
-
-do_install_append() {
-   install -d ${D}${systemd_system_unitdir}/
-   install -d ${D}/${sysconfdir}/osmocom/
-
-   install -m 0644 ${S}/contrib/osmo-ggsn.service 
${D}${systemd_system_unitdir}/
-   install -m 0644 ${S}/doc/examples/osmo-ggsn.cfg 
${D}${sysconfdir}/osmocom/
-}
-
 SYSTEMD_SERVICE_osmo-ggsn = "osmo-ggsn.service"

 CONFFILES_osmo-ggsn = "${sysconfdir}/osmocom/osmo-ggsn.cfg"

--
To view, visit https://gerrit.osmocom.org/10952
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c220c11f58793c644d750040c7fad347500bb8a
Gerrit-Change-Number: 10952
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: osmo-mgw: handle systemd and cfg files through autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10954


Change subject: osmo-mgw: handle systemd and cfg files through autotools
..

osmo-mgw: handle systemd and cfg files through autotools

Change-Id: Iab265207f534f5d2b5960b707081b06aa5d34d11
---
M recipes-osmocom/osmo-mgw/osmo-mgw.inc
1 file changed, 5 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/54/10954/1

diff --git a/recipes-osmocom/osmo-mgw/osmo-mgw.inc 
b/recipes-osmocom/osmo-mgw/osmo-mgw.inc
index 19e17ab..c00f998 100644
--- a/recipes-osmocom/osmo-mgw/osmo-mgw.inc
+++ b/recipes-osmocom/osmo-mgw/osmo-mgw.inc
@@ -5,17 +5,14 @@

 DEPENDS = "libosmocore libosmo-netif"

-INC_PR="r1.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r2.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd

-do_install_append() {
-   install -d ${D}${systemd_system_unitdir}/
-   install -d ${D}${sysconfdir}/osmocom/
-
-   install -m 0644 ${S}/doc/examples/osmo-mgw/osmo-mgw.cfg 
${D}${sysconfdir}/osmocom/osmo-mgw.cfg
-   install -m 0644 ${S}/contrib/systemd/osmo-mgw.service 
${D}${systemd_system_unitdir}/
-}
+PACKAGECONFIG ??= "\
+${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+"
+PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"

 PACKAGES =+ "libosmo-mgcp libosmo-mgcp-dev libosmo-mgcp-client 
libosmo-mgcp-client-dev"
 SYSTEMD_SERVICE_osmo-mgw = "osmo-mgw.service"

--
To view, visit https://gerrit.osmocom.org/10954
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab265207f534f5d2b5960b707081b06aa5d34d11
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: osmo-sip-connector: handle systemd and cfg files through autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10957


Change subject: osmo-sip-connector: handle systemd and cfg files through 
autotools
..

osmo-sip-connector: handle systemd and cfg files through autotools

Change-Id: I88fa636fdc97dbd1c8d13358fb48d157bd95c805
---
M recipes-osmocom/osmo-sip-connector/osmo-sip-connector.inc
1 file changed, 5 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/57/10957/1

diff --git a/recipes-osmocom/osmo-sip-connector/osmo-sip-connector.inc 
b/recipes-osmocom/osmo-sip-connector/osmo-sip-connector.inc
index d7f22a3..96d3734 100644
--- a/recipes-osmocom/osmo-sip-connector/osmo-sip-connector.inc
+++ b/recipes-osmocom/osmo-sip-connector/osmo-sip-connector.inc
@@ -5,17 +5,15 @@

 DEPENDS = "sofia-sip libosmocore"

-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd

-do_install_append() {
-   install -d ${D}${systemd_system_unitdir}/
-   install -d ${D}${sysconfdir}/osmocom/
+PACKAGECONFIG ??= "\
+${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+"
+PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"

-   install -m 0644 ${S}/doc/examples/osmo-sip-connector.cfg 
${D}${sysconfdir}/osmocom/

-   install -m 0644 ${S}/contrib/systemd/osmo-sip-connector.service 
${D}${systemd_system_unitdir}/
-}
 SYSTEMD_SERVICE_${PN} = "${PN}.service"
 CONFFILES_osmo-sip-connector = "${sysconfdir}/osmocom/osmo-sip-connector.cfg"

--
To view, visit https://gerrit.osmocom.org/10957
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88fa636fdc97dbd1c8d13358fb48d157bd95c805
Gerrit-Change-Number: 10957
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: osmo-sgsn: handle systemd and cfg files through autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10953


Change subject: osmo-sgsn: handle systemd and cfg files through autotools
..

osmo-sgsn: handle systemd and cfg files through autotools

At the same time systemd services were installed by autotools,
osmo-gtphub service became available too.

Change-Id: Ib84a3c8634db2282b2d3757ae7c044a196720852
---
M recipes-osmocom/osmo-sgsn/osmo-sgsn.inc
1 file changed, 8 insertions(+), 15 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/53/10953/1

diff --git a/recipes-osmocom/osmo-sgsn/osmo-sgsn.inc 
b/recipes-osmocom/osmo-sgsn/osmo-sgsn.inc
index 4711a2c..45256a5 100644
--- a/recipes-osmocom/osmo-sgsn/osmo-sgsn.inc
+++ b/recipes-osmocom/osmo-sgsn/osmo-sgsn.inc
@@ -5,29 +5,22 @@

 DEPENDS = "c-ares libosmocore libosmo-netif osmo-ggsn"

-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd

-PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'iu', d)}"
+PACKAGECONFIG ??= "\
+${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+${@bb.utils.filter('DISTRO_FEATURES', 'iu', d)} \
+"
+PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"
 PACKAGECONFIG[iu] = "--enable-iu,--disable-iu,libasn1c libosmo-sccp osmo-iuh,"

-do_install_append() {
-   install -d ${D}${systemd_system_unitdir}/
-   install -d ${D}${sysconfdir}/osmocom/
-
-   install -m 0644 ${S}/doc/examples/osmo-sgsn/osmo-sgsn.cfg 
${D}${sysconfdir}/osmocom/
-   install -m 0644 ${S}/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg 
${D}${sysconfdir}/osmocom/
-   install -m 0644 ${S}/doc/examples/osmo-gtphub/osmo-gtphub.cfg 
${D}${sysconfdir}/osmocom/
-
-   install -m 0644 ${S}/contrib/systemd/osmo-sgsn.service 
${D}${systemd_system_unitdir}/
-   install -m 0644 ${S}/contrib/systemd/osmo-gbproxy.service 
${D}${systemd_system_unitdir}/
-}
-
 PACKAGES =+ "osmo-gbproxy-doc osmo-gtphub-doc osmo-gbproxy osmo-gtphub"
-SYSTEMD_PACKAGES = "osmo-sgsn osmo-gbproxy"
+SYSTEMD_PACKAGES = "osmo-sgsn osmo-gbproxy osmo-gtphub"
 SYSTEMD_SERVICE_osmo-sgsn = "osmo-sgsn.service"
 SYSTEMD_SERVICE_osmo-gbproxy = "osmo-gbproxy.service"
+SYSTEMD_SERVICE_osmo-gtphub = "osmo-gtphub.service"

 CONFFILES_osmo-sgsn = "${sysconfdir}/osmocom/osmo-sgsn.cfg"


--
To view, visit https://gerrit.osmocom.org/10953
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib84a3c8634db2282b2d3757ae7c044a196720852
Gerrit-Change-Number: 10953
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: osmo-iuh: handle systemd and cfg files through autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10949


Change subject: osmo-iuh: handle systemd and cfg files through autotools
..

osmo-iuh: handle systemd and cfg files through autotools

Change-Id: If879153a32ae21ad63284382a420da534f30e6eb
---
M recipes-osmocom/osmo-iuh/osmo-iuh.inc
1 file changed, 5 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/49/10949/1

diff --git a/recipes-osmocom/osmo-iuh/osmo-iuh.inc 
b/recipes-osmocom/osmo-iuh/osmo-iuh.inc
index 6dfb344..ab412ad 100644
--- a/recipes-osmocom/osmo-iuh/osmo-iuh.inc
+++ b/recipes-osmocom/osmo-iuh/osmo-iuh.inc
@@ -5,17 +5,14 @@

 DEPENDS = "libosmocore libosmo-netif libosmo-sccp libasn1c"

-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd

-do_install_append() {
-   install -d ${D}${systemd_system_unitdir}/
-   install -d ${D}${sysconfdir}/osmocom/
-
-   install -m 0644 ${S}/doc/examples/osmo-hnbgw.cfg 
${D}${sysconfdir}/osmocom/
-   install -m 0644 ${S}/contrib/systemd/osmo-hnbgw.service 
${D}${systemd_system_unitdir}/
-}
+PACKAGECONFIG ??= "\
+${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+"
+PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"

 PACKAGES =+ "libosmo-ranap libosmo-ranap-dev osmo-hnbgw"
 SYSTEMD_PACKAGES = "osmo-hnbgw"

--
To view, visit https://gerrit.osmocom.org/10949
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: newchange
Gerrit-Change-Id: If879153a32ae21ad63284382a420da534f30e6eb
Gerrit-Change-Number: 10949
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: osmo-msc: handle systemd and cfg files through autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10955


Change subject: osmo-msc: handle systemd and cfg files through autotools
..

osmo-msc: handle systemd and cfg files through autotools

Change-Id: I0ccddd158f88fdd5dbe8e9a36c62d515b973486a
---
M recipes-osmocom/osmo-msc/osmo-msc.inc
1 file changed, 7 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/55/10955/1

diff --git a/recipes-osmocom/osmo-msc/osmo-msc.inc 
b/recipes-osmocom/osmo-msc/osmo-msc.inc
index e5364cd..59280ce 100644
--- a/recipes-osmocom/osmo-msc/osmo-msc.inc
+++ b/recipes-osmocom/osmo-msc/osmo-msc.inc
@@ -5,23 +5,20 @@

 DEPENDS = "libdbi libosmocore libosmo-abis libosmo-sccp libosmo-netif osmo-mgw 
osmo-hlr"

-INC_PR="r1.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r2.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd

-PACKAGECONFIG ??= "smpp ${@bb.utils.filter('DISTRO_FEATURES', 'iu', d)}"
+PACKAGECONFIG ??= "\
+smpp \
+${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+${@bb.utils.filter('DISTRO_FEATURES', 'iu', d)} \
+"
+PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"
 PACKAGECONFIG[iu] = "--enable-iu,--disable-iu,libasn1c osmo-iuh,"
 PACKAGECONFIG[smpp] = "--enable-smpp,--disable-smpp,libsmpp34,"

 RDEPENDS_${PN} = "libdbd-sqlite3"

-do_install_append() {
-   install -d ${D}${systemd_system_unitdir}/
-   install -d ${D}${sysconfdir}/osmocom/
-
-   install -m 0644 ${S}/doc/examples/osmo-msc/osmo-msc.cfg 
${D}${sysconfdir}/osmocom/
-   install -m 0644 ${S}/contrib/systemd/osmo-msc.service 
${D}${systemd_system_unitdir}/
-}
-
 SYSTEMD_SERVICE_${PN} = "${PN}.service"
 CONFFILES_osmo-msc = "${sysconfdir}/osmocom/osmo-msc.cfg"

--
To view, visit https://gerrit.osmocom.org/10955
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ccddd158f88fdd5dbe8e9a36c62d515b973486a
Gerrit-Change-Number: 10955
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in meta-telephony[201705]: osmo-ggsn: Split into .inc and _git.bb

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10944 )

Change subject: osmo-ggsn: Split into .inc and _git.bb
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/10944
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic92309726c6a256c7e543a2be04725023d43d9b7
Gerrit-Change-Number: 10944
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 14 Sep 2018 15:41:52 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #246

[jenkins]

See 


--
[...truncated 3.67 KB...]

+ ./configure
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking 

Change in libosmo-sccp[master]: debian: Document why enable-static is used in dh_auto_configure

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10947


Change subject: debian: Document why enable-static is used in dh_auto_configure
..

debian: Document why enable-static is used in dh_auto_configure

Change-Id: I4a7215d350e023dceadc5826be68ce366a185da1
---
M debian/rules
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/47/10947/1

diff --git a/debian/rules b/debian/rules
index 6e69d24..0bf9673 100755
--- a/debian/rules
+++ b/debian/rules
@@ -19,6 +19,8 @@
sed -i "/dependency_libs/ s/'.*'/''/" `find . -name '*.la'`
dh_install

+# enable-static: we require the tests to link to the static libosmo-sigtran
+# library to access symbols not starting with osmo_*
 override_dh_auto_configure:
dh_auto_configure -- --enable-static 
--with-systemdsystemunitdir=/lib/systemd/system


--
To view, visit https://gerrit.osmocom.org/10947
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a7215d350e023dceadc5826be68ce366a185da1
Gerrit-Change-Number: 10947
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-ttcn3-hacks[master]: sgsn: implement TC_attach_usim_resync

[lynxis lazus]

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/10769 )

Change subject: sgsn: implement TC_attach_usim_resync
..


Patch Set 3:

Rebased the commit


--
To view, visit https://gerrit.osmocom.org/10769
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52a8dc45bb67d4ca9f3efade278d3308bb0da73d
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Fri, 14 Sep 2018 14:40:01 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: sgsn: implement TC_attach_usim_resync

[lynxis lazus]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10769

to look at the new patch set (#3).

Change subject: sgsn: implement TC_attach_usim_resync
..

sgsn: implement TC_attach_usim_resync

Test the UMTS AKA resync procedure with USIMs.

MS -> SGSN: Attach Request
MS <- SGSN: Identity Request IMSI
MS -> SGSN: Identity Response IMSI
MS <- SGSN: Identity Request IMEI
MS -> SGSN: Identity Response IMEI
HLR<- SGSN: SAI Request
HLR-> SGSN: SAI Response
MS <- SGSN: Auth Request
MS -> SGSN: Auth Failure (with AUTS)
HLR<- SGSN: SAI Request (with AUTS & RAND)
HLR-> SGSN: SAI Response (new key material)
MS <- SGSN: Auth Request (new key material)
MS -> SGSN: Auth Response
MS <- SGSN: Attach Accept
MS -> SGSN: Attach Complete

Change-Id: I52a8dc45bb67d4ca9f3efade278d3308bb0da73d
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 131 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/69/10769/3
--
To view, visit https://gerrit.osmocom.org/10769
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I52a8dc45bb67d4ca9f3efade278d3308bb0da73d
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bts[master]: doc/examples/Makefile: Install bts-mgr cfg files used by systemd serv...

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10946


Change subject: doc/examples/Makefile: Install bts-mgr cfg files used by 
systemd services
..

doc/examples/Makefile: Install bts-mgr cfg files used by systemd services

Change-Id: Iaf362da2a9ebd6829391637252812c2be93e9c60
---
M doc/examples/Makefile.am
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/46/10946/1

diff --git a/doc/examples/Makefile.am b/doc/examples/Makefile.am
index 241f579..04f8279 100644
--- a/doc/examples/Makefile.am
+++ b/doc/examples/Makefile.am
@@ -12,7 +12,7 @@
 sysmo/osmo-bts-sysmo.cfg \
 sysmo/sysmobts-mgr.cfg
 EXTRA_DIST += $(doc_sysmo_DATA)
-OSMOCONF_FILES += sysmo/osmo-bts-sysmo.cfg
+OSMOCONF_FILES += sysmo/osmo-bts-sysmo.cfg sysmo/sysmobts-mgr.cfg
 endif

 if ENABLE_TRX
@@ -39,7 +39,7 @@
 litecell15/osmo-bts-lc15.cfg \
 litecell15/lc15bts-mgr.cfg
 EXTRA_DIST += $(doc_lc15_DATA)
-OSMOCONF_FILES += litecell15/osmo-bts-lc15.cfg
+OSMOCONF_FILES += litecell15/osmo-bts-lc15.cfg litecell15/lc15bts-mgr.cfg
 endif

 osmoconfdir = $(sysconfdir)/osmocom

--
To view, visit https://gerrit.osmocom.org/10946
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf362da2a9ebd6829391637252812c2be93e9c60
Gerrit-Change-Number: 10946
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmocom-bb[master]: trxcon/scheduler.h: share FRAME_DURATION_uS definition

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/10945


Change subject: trxcon/scheduler.h: share FRAME_DURATION_uS definition
..

trxcon/scheduler.h: share FRAME_DURATION_uS definition

Change-Id: I88be6088141af6bac8d34844b71193bfef51ad31
---
M src/host/trxcon/l1ctl.c
M src/host/trxcon/sched_clck.c
M src/host/trxcon/scheduler.h
3 files changed, 4 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/45/10945/1

diff --git a/src/host/trxcon/l1ctl.c b/src/host/trxcon/l1ctl.c
index 1e88f8b..a8a1289 100644
--- a/src/host/trxcon/l1ctl.c
+++ b/src/host/trxcon/l1ctl.c
@@ -337,10 +337,10 @@
trx_if_cmd_poweron(l1l->trx);

/* Start FBSB expire timer */
-   /* TODO: share FRAME_DURATION_uS=4615 from scheduler.c */
l1l->fbsb_timer.data = l1l;
l1l->fbsb_timer.cb = fbsb_timer_cb;
-   osmo_timer_schedule(>fbsb_timer, 0, timeout * 4615);
+   osmo_timer_schedule(>fbsb_timer, 0,
+   timeout * FRAME_DURATION_uS);

 exit:
msgb_free(msg);
diff --git a/src/host/trxcon/sched_clck.c b/src/host/trxcon/sched_clck.c
index 56b89a2..dab9578 100644
--- a/src/host/trxcon/sched_clck.c
+++ b/src/host/trxcon/sched_clck.c
@@ -43,7 +43,6 @@
 #include "trx_if.h"
 #include "trxcon.h"

-#define FRAME_DURATION_uS  4615
 #define MAX_FN_SKEW50
 #define TRX_LOSS_FRAMES400

diff --git a/src/host/trxcon/scheduler.h b/src/host/trxcon/scheduler.h
index 6c3a2f2..ddb863f 100644
--- a/src/host/trxcon/scheduler.h
+++ b/src/host/trxcon/scheduler.h
@@ -5,6 +5,8 @@

 #include 

+#define FRAME_DURATION_uS  4615
+
 #define GSM_SUPERFRAME (26 * 51)
 #define GSM_HYPERFRAME (2048 * GSM_SUPERFRAME)


--
To view, visit https://gerrit.osmocom.org/10945
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88be6088141af6bac8d34844b71193bfef51ad31
Gerrit-Change-Number: 10945
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 

Change in meta-telephony[201705]: osmo-ggsn: Split into .inc and _git.bb

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10944 )

Change subject: osmo-ggsn: Split into .inc and _git.bb
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10944
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic92309726c6a256c7e543a2be04725023d43d9b7
Gerrit-Change-Number: 10944
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 14 Sep 2018 12:23:33 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[201705]: osmo-ggsn: Split into .inc and _git.bb

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10944


Change subject: osmo-ggsn: Split into .inc and _git.bb
..

osmo-ggsn: Split into .inc and _git.bb

Change-Id: Ic92309726c6a256c7e543a2be04725023d43d9b7
---
A recipes-osmocom/osmo-ggsn/osmo-ggsn.inc
M recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
2 files changed, 43 insertions(+), 40 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/44/10944/1

diff --git a/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc 
b/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc
new file mode 100644
index 000..49dd1ee
--- /dev/null
+++ b/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc
@@ -0,0 +1,38 @@
+DESCRIPTION = "Osmocom GGSN implementation"
+HOMEPAGE = "https://osmocom.org/projects/openggsn;
+LICENSE = "GPLv2+"
+LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
+
+DEPENDS = "libosmocore"
+
+INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+
+PACKAGES =+ " libgtp libgtp-dev libgtp-staticdev osmo-sgsnemu"
+RDEPENDS_${PN} += "iptables"
+RRECOMMENDS_${PN} += "kernel-module-ipt-masquerade kernel-module-tun"
+
+inherit autotools update-rc.d pkgconfig systemd
+
+do_install_append() {
+   install -d ${D}${sysconfdir}/init.d
+   install -d ${D}${systemd_system_unitdir}/
+   install -d ${D}/${sysconfdir}/osmocom/
+
+   install -m 0776 ${WORKDIR}/osmo-ggsn.init 
${D}${sysconfdir}/init.d/osmo-ggsn
+   install -m 0644 ${S}/contrib/osmo-ggsn.service 
${D}${systemd_system_unitdir}/
+   install -m 0644 ${S}/doc/examples/osmo-ggsn.cfg 
${D}${sysconfdir}/osmocom/
+}
+
+SYSTEMD_SERVICE_osmo-ggsn = "osmo-ggsn.service"
+
+INITSCRIPT_PACKAGES = "osmo-ggsn"
+INITSCRIPT_NAME_osmo-ggsn = "osmo-ggsn"
+INITSCRIPT_PARAMS_osmo-ggsn = "defaults 29 29"
+
+CONFFILES_osmo-ggsn = "${sysconfdir}/osmocom/osmo-ggsn.cfg"
+
+FILES_libgtp = "${libdir}/*${SOLIBS}"
+FILES_libgtp-dev = "${includedir} ${libdir}/lib*${SOLIBSDEV} ${libdir}/*.la"
+FILES_libgtp-staticdev = "${libdir}/*.a"
+
+FILES_osmo-sgsnemu = "${bindir}/sgsnemu"
diff --git a/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb 
b/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
index 8c948cc..5219c03 100644
--- a/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
+++ b/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
@@ -1,45 +1,10 @@
-DESCRIPTION = "Osmocom GGSN implementation"
-HOMEPAGE = "https://osmocom.org/projects/openggsn;
-LICENSE = "GPLv2+"
-LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
-PV = "1.2.2+gitr${SRCPV}"
-PR = "r0"
+require ${PN}.inc

+S = "${WORKDIR}/git"
 SRCREV = "b673d1c438488fb74abda344e563d733e5ce451a"
 SRC_URI = "git://git.osmocom.org/osmo-ggsn   \
file://osmo-ggsn.init \
-  file://libgtp-queue_depth_32.patch   \
+   file://libgtp-queue_depth_32.patch  \
   "
-S = "${WORKDIR}/git"
-
-DEPENDS = "libosmocore"
-
-PACKAGES =+ " libgtp libgtp-dev libgtp-staticdev osmo-sgsnemu"
-RDEPENDS_${PN} += "iptables"
-RRECOMMENDS_${PN} += "kernel-module-ipt-masquerade kernel-module-tun"
-
-inherit autotools update-rc.d pkgconfig systemd
-
-do_install_append() {
-   install -d ${D}${sysconfdir}/init.d
-   install -d ${D}${systemd_system_unitdir}/
-   install -d ${D}/${sysconfdir}/osmocom/
-
-   install -m 0776 ${WORKDIR}/osmo-ggsn.init 
${D}${sysconfdir}/init.d/osmo-ggsn
-   install -m 0644 ${S}/contrib/osmo-ggsn.service 
${D}${systemd_system_unitdir}/
-   install -m 0644 ${S}/doc/examples/osmo-ggsn.cfg 
${D}${sysconfdir}/osmocom/
-}
-
-SYSTEMD_SERVICE_osmo-ggsn = "osmo-ggsn.service"
-
-INITSCRIPT_PACKAGES = "osmo-ggsn"
-INITSCRIPT_NAME_osmo-ggsn = "osmo-ggsn"
-INITSCRIPT_PARAMS_osmo-ggsn = "defaults 29 29"
-
-CONFFILES_osmo-ggsn = "${sysconfdir}/osmocom/osmo-ggsn.cfg"
-
-FILES_libgtp = "${libdir}/*${SOLIBS}"
-FILES_libgtp-dev = "${includedir} ${libdir}/lib*${SOLIBSDEV} ${libdir}/*.la"
-FILES_libgtp-staticdev = "${libdir}/*.a"
-
-FILES_osmo-sgsnemu = "${bindir}/sgsnemu"
+PV = "1.2.2+gitr${SRCPV}"
+PR = "${INC_PR}.0"

--
To view, visit https://gerrit.osmocom.org/10944
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic92309726c6a256c7e543a2be04725023d43d9b7
Gerrit-Change-Number: 10944
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-sgsn[master]: debian: add missing build dependencies

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10943 )

Change subject: debian: add missing build dependencies
..

debian: add missing build dependencies

Change-Id: I0d552f938224e553187f0b4da06eac90fc025c95
---
M debian/control
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/debian/control b/debian/control
index 46a6b67..8e34dbe 100644
--- a/debian/control
+++ b/debian/control
@@ -10,6 +10,7 @@
automake,
libtool,
pkg-config,
+   libasn1c-dev,
libtalloc-dev,
libc-ares-dev,
libgtp-dev,
@@ -17,6 +18,7 @@
libosmo-abis-dev,
libosmo-ranap-dev,
libosmo-sccp-dev,
+   libosmo-sigtran-dev,
libosmo-netif-dev
 Standards-Version: 3.9.8
 Vcs-Git: git://git.osmocom.org/osmo-sgsn.git

--
To view, visit https://gerrit.osmocom.org/10943
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d552f938224e553187f0b4da06eac90fc025c95
Gerrit-Change-Number: 10943
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-sgsn[master]: debian: Add missing dependencies to build with IU support

[Pau Espin Pedrol]

Pau Espin Pedrol has abandoned this change. ( https://gerrit.osmocom.org/10938 )

Change subject: debian: Add missing dependencies to build with IU support
..


Abandoned

Dropping in favor of https://gerrit.osmocom.org/#/c/osmo-sgsn/+/10943/
--
To view, visit https://gerrit.osmocom.org/10938
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic8bfef3a72d5e8ba7ecf1f4fb27f7007c5fa5f19
Gerrit-Change-Number: 10938
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-sgsn[master]: debian: add missing build dependencies

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10943 )

Change subject: debian: add missing build dependencies
..


Patch Set 1: Code-Review+2

this patch is actually a duplicate of my patch submited in 
https://gerrit.osmocom.org/#/c/osmo-sgsn/+/10938/1/debian/control

Basically I pushed the wrong version of the patch enabling IU which didn't 
contain these extra lines.

But I see my patch actually adds a duplicate libosmo-ranap-dev, so I'll drop 
mine in favour of yours.


--
To view, visit https://gerrit.osmocom.org/10943
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d552f938224e553187f0b4da06eac90fc025c95
Gerrit-Change-Number: 10943
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 14 Sep 2018 10:22:11 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes