Change in osmo-gsm-tester[master]: Add script to build virt_phy of OsmocomBB

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10972 )

Change subject: Add script to build virt_phy of OsmocomBB
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/10972
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f14ce43db2f5e16f94dc975e7496dceb4f4b72a
Gerrit-Change-Number: 10972
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 16 Sep 2018 05:49:44 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: osmo-bts-trx/l1_if.c: cosmetic: fix typo in debug msg

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10698 )

Change subject: osmo-bts-trx/l1_if.c: cosmetic: fix typo in debug msg
..

osmo-bts-trx/l1_if.c: cosmetic: fix typo in debug msg

There is a big difference between both L1 and L2 frames. In the
first case, a TDMA frame is assumed, while a L2 frame is the
result of decoding a few bursts (e.g. 4 for xCCH) arrived
on a few TDMA frames.

Anyway, the purpose of l1if_process_meas_res() is to handle
measurements, not frames.

Change-Id: Ic4362c2869e658c2f42664b4009a30e777f8048c
---
M src/osmo-bts-trx/l1_if.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c
index 23fc196..2b4f5c8 100644
--- a/src/osmo-bts-trx/l1_if.c
+++ b/src/osmo-bts-trx/l1_if.c
@@ -509,7 +509,7 @@
/* 100% BER is n_bits_total is 0 */
float ber = n_bits_total==0 ? 1.0 : (float)n_errors / 
(float)n_bits_total;

-   LOGPFN(DMEAS, LOGL_DEBUG, fn, "RX L1 frame %s fn=%u chan_nr=0x%02x MS 
pwr=%ddBm rssi=%.1f dBFS "
+   LOGPFN(DMEAS, LOGL_DEBUG, fn, "RX UL measurement for %s fn=%u 
chan_nr=0x%02x MS pwr=%ddBm rssi=%.1f dBFS "
"ber=%.2f%% (%d/%d bits) L1_ta=%d rqd_ta=%d toa256=%d\n",
gsm_lchan_name(lchan), fn, chan_nr, 
ms_pwr_dbm(lchan->ts->trx->bts->band, lchan->ms_power_ctrl.current),
rssi, ber*100, n_errors, n_bits_total, lchan->meas.l1_info[1], 
lchan->rqd_ta, toa256);

--
To view, visit https://gerrit.osmocom.org/10698
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4362c2869e658c2f42664b4009a30e777f8048c
Gerrit-Change-Number: 10698
Gerrit-PatchSet: 5
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmo-bts[master]: osmo-bts-trx/l1_if.c: cosmetic: fix typo in debug msg

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10698 )

Change subject: osmo-bts-trx/l1_if.c: cosmetic: fix typo in debug msg
..


Patch Set 5: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10698
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4362c2869e658c2f42664b4009a30e777f8048c
Gerrit-Change-Number: 10698
Gerrit-PatchSet: 5
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 16 Sep 2018 05:49:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: osmo-bts-trx/l1_if.c: cosmetic: fix typo in debug msg

[Vadim Yanitskiy]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10698

to look at the new patch set (#5).

Change subject: osmo-bts-trx/l1_if.c: cosmetic: fix typo in debug msg
..

osmo-bts-trx/l1_if.c: cosmetic: fix typo in debug msg

There is a big difference between both L1 and L2 frames. In the
first case, a TDMA frame is assumed, while a L2 frame is the
result of decoding a few bursts (e.g. 4 for xCCH) arrived
on a few TDMA frames.

Anyway, the purpose of l1if_process_meas_res() is to handle
measurements, not frames.

Change-Id: Ic4362c2869e658c2f42664b4009a30e777f8048c
---
M src/osmo-bts-trx/l1_if.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/98/10698/5
--
To view, visit https://gerrit.osmocom.org/10698
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic4362c2869e658c2f42664b4009a30e777f8048c
Gerrit-Change-Number: 10698
Gerrit-PatchSet: 5
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmo-gsm-tester[master]: build: Add script to build the mobile application

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10971 )

Change subject: build: Add script to build the mobile application
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/10971
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c537e56aa982b0b4a703fa78c77ade507738b68
Gerrit-Change-Number: 10971
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 16 Sep 2018 05:21:10 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: build: Add overload to clone repo and build in subdirectory

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10970 )

Change subject: build: Add overload to clone repo and build in subdirectory
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/10970
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67fbd54296f2c68316bf8e89cfeb37d147193d53
Gerrit-Change-Number: 10970
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 16 Sep 2018 05:21:54 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: Add building for "mobile" and "virt_phy" as well

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10973 )

Change subject: Add building for "mobile" and "virt_phy" as well
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/10973
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b2e6111f8b41219e9b2621be5720b9a738c69de
Gerrit-Change-Number: 10973
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Sun, 16 Sep 2018 05:20:50 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: osmo-bts-trx/l1_if.c: cosmetic: fix typo in debug msg

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10698 )

Change subject: osmo-bts-trx/l1_if.c: cosmetic: fix typo in debug msg
..


Patch Set 4: Code-Review+1

"Received UL Measurement" or the like should be the best option.


--
To view, visit https://gerrit.osmocom.org/10698
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4362c2869e658c2f42664b4009a30e777f8048c
Gerrit-Change-Number: 10698
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 16 Sep 2018 05:20:25 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: Install to /bin as it doesn't require special privileges..

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10967 )

Change subject: Install to /bin as it doesn't require special privileges..
..


Patch Set 1:

> Any idea regarding the origianl rationale to put it in sbin?

As the original author, I'm sure it was a copy+patte of some other Makefile, 
without giving it much thought, sorry.


--
To view, visit https://gerrit.osmocom.org/10967
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe572a4c17871785b623e70acc7f5da056f945e5
Gerrit-Change-Number: 10967
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 16 Sep 2018 05:18:49 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ggsn[master]: libgtp: implement gtp_clear_queues to clear req/resp queue

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10975 )

Change subject: libgtp: implement gtp_clear_queues to clear req/resp queue
..


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/10975/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/10975/1//COMMIT_MSG@11
PS1, Line 11: packages
packets.



--
To view, visit https://gerrit.osmocom.org/10975
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I279d1d7cbf5d37dd5609c2b968f317fe9a0e348d
Gerrit-Change-Number: 10975
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 16 Sep 2018 05:17:36 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: Install to /bin as it doesn't require special privileges..

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10967 )

Change subject: Install to /bin as it doesn't require special privileges..
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10967
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe572a4c17871785b623e70acc7f5da056f945e5
Gerrit-Change-Number: 10967
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 16 Sep 2018 05:17:52 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: library/GSUP_Types: correct value of the GSUP_CancelType

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10974 )

Change subject: library/GSUP_Types: correct value of the GSUP_CancelType
..

library/GSUP_Types: correct value of the GSUP_CancelType

The comment in the c header of OSMO_GSUP_CANCEL_TYPE_UPDATE says:
1 = /* 0 on the wire */,
2 = /* 1 on the wire */

Change-Id: I4d22af9fee19e6036dbb555422759e3c1285416a
---
M library/GSUP_Types.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn
index 0d21404..7680815 100644
--- a/library/GSUP_Types.ttcn
+++ b/library/GSUP_Types.ttcn
@@ -79,8 +79,8 @@
 } with { variant "FIELDLENGTH(8)" };

 type enumerated GSUP_CancelType {
-   OSMO_GSUP_CANCEL_TYPE_UPDATE(1),
-   OSMO_GSUP_CANCEL_TYPE_WITHDRAW  (2)
+   OSMO_GSUP_CANCEL_TYPE_UPDATE(0),
+   OSMO_GSUP_CANCEL_TYPE_WITHDRAW  (1)
 } with { variant "FIELDLENGTH(8)" };

 type enumerated GSUP_CnDomain {

--
To view, visit https://gerrit.osmocom.org/10974
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d22af9fee19e6036dbb555422759e3c1285416a
Gerrit-Change-Number: 10974
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: lynxis lazus 

Change in osmo-ttcn3-hacks[master]: library/GSUP_Types: correct value of the GSUP_CancelType

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10974 )

Change subject: library/GSUP_Types: correct value of the GSUP_CancelType
..


Patch Set 1:

0/1 is correct, as that's what osmo-sgsn uses and the GSUP protocol spec in 
osmo-gsm-manuals specifies.  So TTCN3 and wireshark are broken.


--
To view, visit https://gerrit.osmocom.org/10974
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d22af9fee19e6036dbb555422759e3c1285416a
Gerrit-Change-Number: 10974
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Sun, 16 Sep 2018 05:14:11 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: library/GSUP_Types: correct value of the GSUP_CancelType

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10974 )

Change subject: library/GSUP_Types: correct value of the GSUP_CancelType
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10974
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d22af9fee19e6036dbb555422759e3c1285416a
Gerrit-Change-Number: 10974
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Sun, 16 Sep 2018 05:14:18 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ggsn[master]: libgtp: implement gtp_clear_queues to clear req/resp queue

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/10975


Change subject: libgtp: implement gtp_clear_queues to clear req/resp queue
..

libgtp: implement gtp_clear_queues to clear req/resp queue

Clearing the request and response queue is useful for debugging
to reset "some" state. Otherwise some tests will get un-expected
packages.

Change-Id: I279d1d7cbf5d37dd5609c2b968f317fe9a0e348d
---
M gtp/gtp.c
M gtp/gtp.h
2 files changed, 20 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/75/10975/1

diff --git a/gtp/gtp.c b/gtp/gtp.c
index 1d58088..b98fba0 100644
--- a/gtp/gtp.c
+++ b/gtp/gtp.c
@@ -496,6 +496,24 @@
return 0;
 }

+
+/**
+ * @brief clear the request and response queue. Useful for debugging to reset 
"some" state.
+ * @param gsn The GGSN instance
+ */
+void gtp_clear_queues(struct gsn_t *gsn)
+{
+   struct qmsg_t *qmsg;
+
+   while (!queue_getfirst(gsn->queue_req, )) {
+   queue_freemsg(gsn->queue_req, qmsg);
+   }
+
+   while (!queue_getfirst(gsn->queue_resp, )) {
+   queue_freemsg(gsn->queue_resp, qmsg);
+   }
+}
+
 /* gtp_conf
  * Remove signalling packet from retransmission queue.
  * return 0 on success, EOF if packet was not found */
diff --git a/gtp/gtp.h b/gtp/gtp.h
index ed594f1..5f35ab5 100644
--- a/gtp/gtp.h
+++ b/gtp/gtp.h
@@ -369,6 +369,8 @@
   struct pdp_t * pdp,
   uint8_t recovery));

+void gtp_clear_queues(struct gsn_t *gsn);
+
 /* Internal functions (not part of the API */

 extern int gtp_echo_req(struct gsn_t *gsn, int version, void *cbp,

--
To view, visit https://gerrit.osmocom.org/10975
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I279d1d7cbf5d37dd5609c2b968f317fe9a0e348d
Gerrit-Change-Number: 10975
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-ttcn3-hacks[master]: library/GSUP_Types: correct value of the GSUP_CancelType

[lynxis lazus]

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/10974 )

Change subject: library/GSUP_Types: correct value of the GSUP_CancelType
..


Patch Set 1:

related to https://code.wireshark.org/review/#/c/29678/


--
To view, visit https://gerrit.osmocom.org/10974
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d22af9fee19e6036dbb555422759e3c1285416a
Gerrit-Change-Number: 10974
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Sun, 16 Sep 2018 01:58:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: library/GSUP_Types: correct value of the GSUP_CancelType

[lynxis lazus]

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/10974 )

Change subject: library/GSUP_Types: correct value of the GSUP_CancelType
..


Patch Set 1:

Hi Harald,

what is correct here? The header says it's 0-1 on the wire. But wireshark also 
interprets 1-2. osmo-sgsn use 0-1 . 
https://git.osmocom.org/libosmocore/tree/include/osmocom/gsm/gsup.h


--
To view, visit https://gerrit.osmocom.org/10974
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d22af9fee19e6036dbb555422759e3c1285416a
Gerrit-Change-Number: 10974
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Sun, 16 Sep 2018 01:53:54 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: library/GSUP_Types: correct value of the GSUP_CancelType

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/10974


Change subject: library/GSUP_Types: correct value of the GSUP_CancelType
..

library/GSUP_Types: correct value of the GSUP_CancelType

The comment in the c header of OSMO_GSUP_CANCEL_TYPE_UPDATE says:
1 = /* 0 on the wire */,
2 = /* 1 on the wire */

Change-Id: I4d22af9fee19e6036dbb555422759e3c1285416a
---
M library/GSUP_Types.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/74/10974/1

diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn
index 0d21404..7680815 100644
--- a/library/GSUP_Types.ttcn
+++ b/library/GSUP_Types.ttcn
@@ -79,8 +79,8 @@
 } with { variant "FIELDLENGTH(8)" };

 type enumerated GSUP_CancelType {
-   OSMO_GSUP_CANCEL_TYPE_UPDATE(1),
-   OSMO_GSUP_CANCEL_TYPE_WITHDRAW  (2)
+   OSMO_GSUP_CANCEL_TYPE_UPDATE(0),
+   OSMO_GSUP_CANCEL_TYPE_WITHDRAW  (1)
 } with { variant "FIELDLENGTH(8)" };

 type enumerated GSUP_CnDomain {

--
To view, visit https://gerrit.osmocom.org/10974
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d22af9fee19e6036dbb555422759e3c1285416a
Gerrit-Change-Number: 10974
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Build failed in Jenkins: master-libosmocore » a2=default,a3=default,amd64,osmocom-master-debian9 #476

[jenkins]

See 


--
[...truncated 520.31 KB...]
## -- ##
## libosmocore 0.12.0.57-2fd4 test suite. ##
## -- ##

Regression tests.

  1: a5  ok
  2: abisok
  3: ctrlok
  4: kasumi  ok
  5: bitsok
  6: bitvec  ok
  7: bitcomp ok
  8: bitfieldok
  9: convok
 10: conv_gsm0503ok
 11: coding  ok
 12: msgbok
 13: gea ok
 14: msgfile ok
 15: sms ok
 16: smscb   ok
 17: ussdok
 18: authok
 19: comp128 ok
 20: lapdok
 21: gsm0808 FAILED (testsuite.at:132)
 22: gsm0408 ok
 23: gprsok
 24: logging ok
 25: codec   ok
 26: codec_ecu_frok
 27: fr  ok
 28: loggingrb   ok
 29: strrb   ok
 30: vty ok
 31: gprs-bssgp  ok
 32: gprs-ns ok
 33: utils   ok
 34: stats   ok
 35: write_queue ok
 36: bssgp-fcok
 37: sim ok
 38: timer   ok
 39: clk_overrideok
 40: tlv ok
 41: gsupok
 42: fsm ok
 43: oap ok
 44: oap_client  ok
 45: socket  ok
 46: osmo-auc-genok
 47: endian  ok
 48: sercomm ok
 49: prbsok
 50: gsm23003ok

## - ##
## Test results. ##
## - ##

ERROR: All 50 tests were run,
1 failed unexpectedly.
## -- ##
## testsuite.log was created. ##
## -- ##

Please send `tests/testsuite.log' and all information you think might help:

   To: 
   Subject: [libosmocore 0.12.0.57-2fd4] testsuite: 21 failed

You may investigate any problem if you feel able to do so, in which
case the test suite provides a good starting point.  Its output may
be found below `tests/testsuite.dir'.

Makefile:1997: recipe for target 'check-local' failed
make[4]: *** [check-local] Error 1
make[4]: Leaving directory 
'
Makefile:1766: recipe for target 'check-am' failed
make[3]: *** [check-am] Error 2
make[3]: Leaving directory 
'
Makefile:1769: recipe for target 'check' failed
make[2]: *** [check] Error 2
make[2]: Leaving directory 
'
Makefile:614: recipe for target 'check-recursive' failed
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory 
'
Makefile:905: recipe for target 'check' failed
make: *** [check] Error 2
+ cat-testlogs.sh



 ./tests/testsuite.dir/21/testsuite.log

# -*- compilation -*-
21. testsuite.at:129: testing 

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_18.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  190s] No package 'libpcsclite' found
[  190s] simtrace2-remsim.o: In function `main':
[  190s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  190s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  190s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  190s] apdu_dispatch.o: In function `apdu_segment_in':
[  190s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  190s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  190s] collect2: error: ld returned 1 exit status
[  190s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  190s] make[2]: *** [simtrace2-remsim] Error 1
[  190s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  190s] Makefile:20: recipe for target 'utils' failed
[  190s] make[1]: *** [utils] Error 2
[  190s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  190s] dh_auto_build: make -j1 returned exit code 2
[  190s] debian/rules:4: recipe for target 'build' failed
[  190s] make: *** [build] Error 2
[  190s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  190s] 
[  190s] morla3 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sat Sep 15 
20:09:53 UTC 2018.
[  190s] 
[  190s] ### VM INTERACTION START ###
[  194s] [  179.852526] sysrq: SysRq : Power Off
[  194s] [  179.859367] reboot: Power down
[  194s] ### VM INTERACTION END ###
[  194s] 
[  194s] morla3 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sat Sep 15 
20:09:57 UTC 2018.
[  194s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_16.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  181s] No package 'libpcsclite' found
[  181s] simtrace2-remsim.o: In function `main':
[  181s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  181s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  181s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  181s] apdu_dispatch.o: In function `apdu_segment_in':
[  181s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  181s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  181s] collect2: error: ld returned 1 exit status
[  181s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  181s] make[2]: *** [simtrace2-remsim] Error 1
[  181s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  181s] Makefile:20: recipe for target 'utils' failed
[  181s] make[1]: *** [utils] Error 2
[  181s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  181s] dh_auto_build: make -j1 returned exit code 2
[  181s] debian/rules:4: recipe for target 'build' failed
[  181s] make: *** [build] Error 2
[  181s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  181s] 
[  181s] cloud126 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sat Sep 15 
20:09:46 UTC 2018.
[  181s] 
[  181s] ### VM INTERACTION START ###
[  185s] [  159.915694] sysrq: SysRq : Power Off
[  185s] [  159.925714] reboot: Power down
[  186s] ### VM INTERACTION END ###
[  186s] 
[  186s] cloud126 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sat Sep 15 
20:09:51 UTC 2018.
[  186s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/i586

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  191s] No package 'libpcsclite' found
[  191s] simtrace2-remsim.o: In function `main':
[  191s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  191s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  191s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  191s] apdu_dispatch.o: In function `apdu_segment_in':
[  191s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  191s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  191s] collect2: error: ld returned 1 exit status
[  191s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  191s] make[2]: *** [simtrace2-remsim] Error 1
[  191s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  191s] Makefile:20: recipe for target 'utils' failed
[  191s] make[1]: *** [utils] Error 2
[  191s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  191s] dh_auto_build: make -j1 returned exit code 2
[  191s] debian/rules:4: recipe for target 'build' failed
[  191s] make: *** [build] Error 2
[  191s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  191s] 
[  191s] cloud106 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sat Sep 15 
20:09:39 UTC 2018.
[  191s] 
[  191s] ### VM INTERACTION START ###
[  194s] [  166.005124] sysrq: SysRq : Power Off
[  194s] [  166.046758] reboot: Power down
[  195s] ### VM INTERACTION END ###
[  195s] 
[  195s] cloud106 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sat Sep 15 
20:09:44 UTC 2018.
[  195s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_18.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  174s] No package 'libpcsclite' found
[  174s] simtrace2-remsim.o: In function `main':
[  174s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  174s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  174s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  174s] apdu_dispatch.o: In function `apdu_segment_in':
[  174s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  174s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  174s] collect2: error: ld returned 1 exit status
[  174s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  174s] make[2]: *** [simtrace2-remsim] Error 1
[  174s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  174s] Makefile:20: recipe for target 'utils' failed
[  174s] make[1]: *** [utils] Error 2
[  174s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  174s] dh_auto_build: make -j1 returned exit code 2
[  174s] debian/rules:4: recipe for target 'build' failed
[  174s] make: *** [build] Error 2
[  174s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  174s] 
[  174s] lamb28 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sat Sep 15 
20:09:34 UTC 2018.
[  174s] 
[  174s] ### VM INTERACTION START ###
[  177s] [  166.069439] sysrq: SysRq : Power Off
[  177s] [  166.073095] reboot: Power down
[  177s] ### VM INTERACTION END ###
[  177s] 
[  177s] lamb28 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sat Sep 15 
20:09:38 UTC 2018.
[  177s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_16.04/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  139s] No package 'libpcsclite' found
[  139s] simtrace2-remsim.o: In function `main':
[  139s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  139s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  139s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  139s] apdu_dispatch.o: In function `apdu_segment_in':
[  139s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  139s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  139s] collect2: error: ld returned 1 exit status
[  139s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  139s] make[2]: *** [simtrace2-remsim] Error 1
[  139s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  139s] Makefile:20: recipe for target 'utils' failed
[  139s] make[1]: *** [utils] Error 2
[  139s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  139s] dh_auto_build: make -j1 returned exit code 2
[  139s] debian/rules:4: recipe for target 'build' failed
[  139s] make: *** [build] Error 2
[  139s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  139s] 
[  139s] lamb56 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sat Sep 15 
20:08:58 UTC 2018.
[  139s] 
[  139s] ### VM INTERACTION START ###
[  142s] [  131.960618] sysrq: SysRq : Power Off
[  142s] [  131.969223] reboot: Power down
[  142s] ### VM INTERACTION END ###
[  142s] 
[  142s] lamb56 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sat Sep 15 
20:09:02 UTC 2018.
[  142s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_17.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_17.10/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_17.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  172s] No package 'libpcsclite' found
[  172s] simtrace2-remsim.o: In function `main':
[  172s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  172s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  172s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  172s] apdu_dispatch.o: In function `apdu_segment_in':
[  172s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  172s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  172s] collect2: error: ld returned 1 exit status
[  172s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  172s] make[2]: *** [simtrace2-remsim] Error 1
[  172s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  172s] Makefile:20: recipe for target 'utils' failed
[  172s] make[1]: *** [utils] Error 2
[  172s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  172s] dh_auto_build: make -j1 returned exit code 2
[  172s] debian/rules:4: recipe for target 'build' failed
[  172s] make: *** [build] Error 2
[  172s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  172s] 
[  172s] cloud105 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sat Sep 15 
20:09:40 UTC 2018.
[  172s] 
[  172s] ### VM INTERACTION START ###
[  175s] [  154.294412] sysrq: SysRq : Power Off
[  175s] [  154.309031] reboot: Power down
[  177s] ### VM INTERACTION END ###
[  177s] 
[  177s] cloud105 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sat Sep 15 
20:09:46 UTC 2018.
[  177s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/armv7l

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  198s] No package 'libpcsclite' found
[  198s] simtrace2-remsim.o: In function `main':
[  198s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  198s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  198s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:772: undefined 
reference to `osim_uicc_sim_cic_profile'
[  198s] apdu_dispatch.o: In function `apdu_segment_in':
[  198s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  198s] /usr/src/packages/BUILD/host/apdu_dispatch.c:173: undefined reference 
to `osim_uicc_sim_cic_profile'
[  198s] collect2: error: ld returned 1 exit status
[  198s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  198s] make[2]: *** [simtrace2-remsim] Error 1
[  198s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  198s] Makefile:20: recipe for target 'utils' failed
[  198s] make[1]: *** [utils] Error 2
[  198s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  198s] dh_auto_build: make -j1 returned exit code 2
[  198s] debian/rules:4: recipe for target 'build' failed
[  198s] make: *** [build] Error 2
[  198s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  198s] 
[  198s] armbuild02 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sat Sep 15 
20:09:07 UTC 2018.
[  198s] 
[  198s] ### VM INTERACTION START ###
[  201s] [  181.248711] SysRq : Power Off
[  201s] [  181.250278] reboot: Power down
[  201s] ### VM INTERACTION END ###
[  202s] 
[  202s] armbuild02 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sat Sep 15 
20:09:11 UTC 2018.
[  202s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  162s] No package 'libpcsclite' found
[  162s] simtrace2-remsim.o: In function `main':
[  162s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  162s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  162s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  162s] apdu_dispatch.o: In function `apdu_segment_in':
[  162s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  162s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  162s] collect2: error: ld returned 1 exit status
[  162s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  162s] make[2]: *** [simtrace2-remsim] Error 1
[  162s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  162s] Makefile:20: recipe for target 'utils' failed
[  162s] make[1]: *** [utils] Error 2
[  162s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  162s] dh_auto_build: make -j1 returned exit code 2
[  162s] debian/rules:4: recipe for target 'build' failed
[  162s] make: *** [build] Error 2
[  162s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  162s] 
[  162s] morla3 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sat Sep 15 
20:09:20 UTC 2018.
[  162s] 
[  162s] ### VM INTERACTION START ###
[  166s] [  150.671119] sysrq: SysRq : Power Off
[  166s] [  150.682140] reboot: Power down
[  166s] ### VM INTERACTION END ###
[  166s] 
[  166s] morla3 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sat Sep 15 
20:09:24 UTC 2018.
[  166s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_17.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  109s] No package 'libpcsclite' found
[  109s] simtrace2-remsim.o: In function `main':
[  109s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  109s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  109s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  109s] apdu_dispatch.o: In function `apdu_segment_in':
[  109s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  109s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  109s] collect2: error: ld returned 1 exit status
[  109s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  109s] make[2]: *** [simtrace2-remsim] Error 1
[  109s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  109s] Makefile:20: recipe for target 'utils' failed
[  109s] make[1]: *** [utils] Error 2
[  109s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  109s] dh_auto_build: make -j1 returned exit code 2
[  109s] debian/rules:4: recipe for target 'build' failed
[  109s] make: *** [build] Error 2
[  109s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  109s] 
[  109s] sheep83 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sat Sep 15 
20:08:23 UTC 2018.
[  109s] 
[  109s] ### VM INTERACTION START ###
[  112s] [  105.234518] sysrq: SysRq : Power Off
[  112s] [  105.241021] reboot: Power down
[  112s] ### VM INTERACTION END ###
[  112s] 
[  112s] sheep83 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Sat Sep 15 
20:08:26 UTC 2018.
[  112s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in osmocom-bb[master]: Install to /bin as it doesn't require special privileges..

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10967 )

Change subject: Install to /bin as it doesn't require special privileges..
..


Patch Set 1:

Any idea regarding the origianl rationale to put it in sbin?


--
To view, visit https://gerrit.osmocom.org/10967
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe572a4c17871785b623e70acc7f5da056f945e5
Gerrit-Change-Number: 10967
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 15 Sep 2018 19:53:37 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmocom-bb[master]: Install to /bin as it doesn't require special privileges..

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10967 )

Change subject: Install to /bin as it doesn't require special privileges..
..


Patch Set 1:

It's actually not easier since we support using adding binaries from /sbin in 
there, but it's fine :)


--
To view, visit https://gerrit.osmocom.org/10967
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe572a4c17871785b623e70acc7f5da056f945e5
Gerrit-Change-Number: 10967
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 15 Sep 2018 19:52:56 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmocom-bb[master]: trxcon/scheduler: introduce TCH/H TDMA frame mapping helpres

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10459 )

Change subject: trxcon/scheduler: introduce TCH/H TDMA frame mapping helpres
..

trxcon/scheduler: introduce TCH/H TDMA frame mapping helpres

Unlike xCCH, TCH/H channels are using block diagonal interleaving,
so every single burst carries 57 bits of one traffic frame, and 57
bits of another one. Moreover, unlike TCH/F where both traffic
and FACCH/F frames are interleaved over 8 bursts, a FACCH/H is
interleaved over 6 bursts, while a traffic frame is interleaved
over 4 bursts.

This is why a TCH/H burst transmission can't be initiated on
an arbitrary TDMA frame number. It shall be aligned as of
stated in GSM 05.02, clause 7, table 1.

This change introduces two basic functions:

  - sched_tchh_block_map_fn - checks if a TCH/H block transmission
can be initiated / finished on a given frame number
and a given channel type;

  - sched_tchh_block_dl_first_fn - calculates TDMA frame number of
the first burst using given frame number of the last burst;

and some auxiliary wrappers to simplify the usage of
sched_tchh_block_map_fn().

Change-Id: Iaf4cb33f1b79df23f8a90c8b14ebe0cd9907fbb9
---
M src/host/trxcon/Makefile.am
A src/host/trxcon/sched_lchan_tchh.c
M src/host/trxcon/sched_prim.c
M src/host/trxcon/sched_trx.h
M src/host/trxcon/scheduler.h
5 files changed, 207 insertions(+), 16 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/host/trxcon/Makefile.am b/src/host/trxcon/Makefile.am
index c9cc170..7095cb5 100644
--- a/src/host/trxcon/Makefile.am
+++ b/src/host/trxcon/Makefile.am
@@ -35,6 +35,7 @@
sched_lchan_desc.c \
sched_lchan_xcch.c \
sched_lchan_tchf.c \
+   sched_lchan_tchh.c \
sched_lchan_rach.c \
sched_lchan_sch.c \
sched_mframe.c \
diff --git a/src/host/trxcon/sched_lchan_tchh.c 
b/src/host/trxcon/sched_lchan_tchh.c
new file mode 100644
index 000..316f995
--- /dev/null
+++ b/src/host/trxcon/sched_lchan_tchh.c
@@ -0,0 +1,183 @@
+/*
+ * OsmocomBB <-> SDR connection bridge
+ * TDMA scheduler: handlers for DL / UL bursts on logical channels
+ *
+ * (C) 2018 by Vadim Yanitskiy 
+ *
+ * All Rights Reserved
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ */
+
+#include 
+#include 
+#include 
+
+#include "scheduler.h"
+#include "sched_trx.h"
+
+static const uint8_t tch_h0_traffic_block_map[3][4] = {
+   /* B0(0,2,4,6), B1(4,6,8,10), B2(8,10,0,2) */
+   { 0, 2, 4, 6 },
+   { 4, 6, 8, 10 },
+   { 8, 10, 0, 2 },
+};
+
+static const uint8_t tch_h1_traffic_block_map[3][4] = {
+   /* B0(1,3,5,7), B1(5,7,9,11), B2(9,11,1,3) */
+   { 1, 3, 5, 7 },
+   { 5, 7, 9, 11 },
+   { 9, 11, 1, 3 },
+};
+
+static const uint8_t tch_h0_dl_facch_block_map[3][6] = {
+   /* B0(4,6,8,10,13,15), B1(13,15,17,19,21,23), B2(21,23,0,2,4,6) */
+   { 4, 6, 8, 10, 13, 15 },
+   { 13, 15, 17, 19, 21, 23 },
+   { 21, 23, 0, 2, 4, 6 },
+};
+
+static const uint8_t tch_h0_ul_facch_block_map[3][6] = {
+   /* B0(0,2,4,6,8,10), B1(8,10,13,15,17,19), B2(17,19,21,23,0,2) */
+   { 0, 2, 4, 6, 8, 10 },
+   { 8, 10, 13, 15, 17, 19 },
+   { 17, 19, 21, 23, 0, 2 },
+};
+
+static const uint8_t tch_h1_dl_facch_block_map[3][6] = {
+   /* B0(5,7,9,11,14,16), B1(14,16,18,20,22,24), B2(22,24,1,3,5,7) */
+   { 5, 7, 9, 11, 14, 16 },
+   { 14, 16, 18, 20, 22, 24 },
+   { 22, 24, 1, 3, 5, 7 },
+};
+
+const uint8_t tch_h1_ul_facch_block_map[3][6] = {
+   /* B0(1,3,5,7,9,11), B1(9,11,14,16,18,20), B2(18,20,22,24,1,3) */
+   { 1, 3, 5, 7, 9, 11 },
+   { 9, 11, 14, 16, 18, 20 },
+   { 18, 20, 22, 24, 1, 3 },
+};
+
+/**
+ * Can a TCH/H block transmission be initiated / finished
+ * on a given frame number and a given channel type?
+ *
+ * See GSM 05.02, clause 7, table 1
+ *
+ * @param  chan   channel type (TRXC_TCHH_0 or TRXC_TCHH_1)
+ * @param  fn the current frame number
+ * @param  ul Uplink or Downlink?
+ * @param  facch  FACCH/H or traffic?
+ * @param  start  init or end of transmission?
+ * @returntrue (yes) or false (no)
+ */
+bool sched_tchh_block_map_fn(enum trx_lchan_type chan,

Change in osmocom-bb[master]: trxcon/scheduler: add TCH/H channel support

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10460 )

Change subject: trxcon/scheduler: add TCH/H channel support
..

trxcon/scheduler: add TCH/H channel support

Change-Id: Ibb2a0850692c5ff86b13b820af10b12085589e67
---
M src/host/trxcon/sched_lchan_desc.c
M src/host/trxcon/sched_lchan_tchh.c
M src/host/trxcon/sched_trx.c
M src/host/trxcon/sched_trx.h
4 files changed, 331 insertions(+), 7 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/host/trxcon/sched_lchan_desc.c 
b/src/host/trxcon/sched_lchan_desc.c
index 37d1273..4cac439 100644
--- a/src/host/trxcon/sched_lchan_desc.c
+++ b/src/host/trxcon/sched_lchan_desc.c
@@ -27,10 +27,7 @@

 /* TODO: implement */
 #define tx_pdtch_fnNULL
-#define tx_tchh_fn NULL
-
 #define rx_pdtch_fnNULL
-#define rx_tchh_fn NULL

 /* Forward declaration of handlers */
 int rx_data_fn(struct trx_instance *trx, struct trx_ts *ts,
@@ -54,6 +51,14 @@
 int tx_tchf_fn(struct trx_instance *trx, struct trx_ts *ts,
struct trx_lchan_state *lchan, uint32_t fn, uint8_t bid);

+int rx_tchh_fn(struct trx_instance *trx, struct trx_ts *ts,
+   struct trx_lchan_state *lchan, uint32_t fn, uint8_t bid,
+   sbit_t *bits, int8_t rssi, int16_t toa256);
+
+int tx_tchh_fn(struct trx_instance *trx, struct trx_ts *ts,
+   struct trx_lchan_state *lchan, uint32_t fn, uint8_t bid);
+
+
 const struct trx_lchan_desc trx_lchan_desc[_TRX_CHAN_MAX] = {
{
TRXC_IDLE,  "IDLE",
diff --git a/src/host/trxcon/sched_lchan_tchh.c 
b/src/host/trxcon/sched_lchan_tchh.c
index 316f995..7fb2809 100644
--- a/src/host/trxcon/sched_lchan_tchh.c
+++ b/src/host/trxcon/sched_lchan_tchh.c
@@ -3,6 +3,7 @@
  * TDMA scheduler: handlers for DL / UL bursts on logical channels
  *
  * (C) 2018 by Vadim Yanitskiy 
+ * (C) 2018 by Harald Welte 
  *
  * All Rights Reserved
  *
@@ -23,11 +24,27 @@
  */

 #include 
+#include 
 #include 
 #include 

+#include 
+#include 
+#include 
+
+#include 
+#include 
+
+#include 
+#include 
+
+#include "l1ctl_proto.h"
 #include "scheduler.h"
 #include "sched_trx.h"
+#include "logging.h"
+#include "trx_if.h"
+#include "trxcon.h"
+#include "l1ctl.h"

 static const uint8_t tch_h0_traffic_block_map[3][4] = {
/* B0(0,2,4,6), B1(4,6,8,10), B2(8,10,0,2) */
@@ -181,3 +198,305 @@
/* Couldn't calculate the first fn, return the last */
return last_fn;
 }
+
+int rx_tchh_fn(struct trx_instance *trx, struct trx_ts *ts,
+   struct trx_lchan_state *lchan, uint32_t fn, uint8_t bid,
+   sbit_t *bits, int8_t rssi, int16_t toa256)
+{
+   const struct trx_lchan_desc *lchan_desc;
+   int n_errors = -1, n_bits_total, rc;
+   sbit_t *buffer, *offset;
+   uint8_t l2[128], *mask;
+   size_t l2_len;
+
+   /* Set up pointers */
+   lchan_desc = _lchan_desc[lchan->type];
+   mask = >rx_burst_mask;
+   buffer = lchan->rx_bursts;
+
+   LOGP(DSCHD, LOGL_DEBUG, "Traffic received on %s: fn=%u ts=%u bid=%u\n",
+   lchan_desc->name, fn, ts->index, bid);
+
+   if (*mask == 0x00) {
+   /* Align to the first burst */
+   if (bid > 0)
+   return 0;
+
+   /* Align reception of the first FACCH/H frame */
+   if (lchan->tch_mode == GSM48_CMODE_SIGN) {
+   if (!sched_tchh_facch_start(lchan->type, fn, 0))
+   return 0;
+   } else { /* or TCH/H traffic frame */
+   if (!sched_tchh_traffic_start(lchan->type, fn, 0))
+   return 0;
+   }
+   }
+
+   /* Update mask */
+   *mask |= (1 << bid);
+
+   /**
+* FIXME: properly update measurements
+*
+* Since TCH/H channel is using block-diagonal interleaving,
+* a single burst may carry 57 bits of one encoded frame,
+* and 57 bits of another. This should be taken into account.
+*/
+   lchan->meas.rssi_sum += rssi;
+   lchan->meas.toa256_sum += toa256;
+   lchan->meas.rssi_num++;
+   lchan->meas.toa256_num++;
+
+   /* Copy burst to the end of buffer of 6 bursts */
+   offset = buffer + bid * 116 + 464;
+   memcpy(offset, bits + 3, 58);
+   memcpy(offset + 58, bits + 87, 58);
+
+   /* Wait until the second burst */
+   if (bid != 1)
+   return 0;
+
+   /* Wait for complete set of bursts */
+   if (lchan->tch_mode == GSM48_CMODE_SIGN) {
+   /* FACCH/H is interleaved over 6 bursts */
+   if ((*mask & 0x3f) != 0x3f)
+   goto bfi_shift;
+   } else {
+   /* Traffic is interleaved over 4 bursts */
+   if ((*mask & 0x0f) != 0x0f)
+   goto bfi_shift;
+   }
+
+   /* Skip decoding 

Change in osmocom-bb[master]: trxcon/scheduler: introduce TDMA frame math helpers

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10942 )

Change subject: trxcon/scheduler: introduce TDMA frame math helpers
..

trxcon/scheduler: introduce TDMA frame math helpers

The 'normal' math operations, such as addition and substraction,
are not applicable for TDMA frame numbers because they may result
in out-of-range values.

Having TDMA frame math helpers in a single place would allow
one to avoid possible out-of-range result mistakes.

Change-Id: Ibb66ba846cc3d6c2eaa88414569e5f3751128047
---
M src/host/trxcon/sched_clck.c
M src/host/trxcon/sched_trx.c
M src/host/trxcon/scheduler.h
3 files changed, 16 insertions(+), 12 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/host/trxcon/sched_clck.c b/src/host/trxcon/sched_clck.c
index dab9578..d4054c9 100644
--- a/src/host/trxcon/sched_clck.c
+++ b/src/host/trxcon/sched_clck.c
@@ -83,8 +83,7 @@
timespecadd(tv_clock, _duration, tv_clock);
elapsed_us -= FRAME_DURATION_uS;

-   sched->fn_counter_proc = (sched->fn_counter_proc + 1)
-   % GSM_HYPERFRAME;
+   sched->fn_counter_proc = TDMA_FN_INC(sched->fn_counter_proc);

/* Call frame callback */
if (sched->clock_cb)
@@ -142,8 +141,7 @@
/* Calculate elapsed time / frames since last processed fn */
timespecsub(_now, tv_clock, );
elapsed_us = (elapsed.tv_sec * 100) + (elapsed.tv_nsec / 1000);
-   elapsed_fn = (fn + GSM_HYPERFRAME - sched->fn_counter_proc)
-   % GSM_HYPERFRAME;
+   elapsed_fn = TDMA_FN_SUB(fn, sched->fn_counter_proc);

if (elapsed_fn >= 135774)
elapsed_fn -= GSM_HYPERFRAME;
@@ -181,8 +179,7 @@

/* Transmit what we still need to transmit */
while (fn != sched->fn_counter_proc) {
-   sched->fn_counter_proc = (sched->fn_counter_proc + 1)
-   % GSM_HYPERFRAME;
+   sched->fn_counter_proc = TDMA_FN_INC(sched->fn_counter_proc);

/* Call frame callback */
if (sched->clock_cb)
diff --git a/src/host/trxcon/sched_trx.c b/src/host/trxcon/sched_trx.c
index 8bd3c72..e20da39 100644
--- a/src/host/trxcon/sched_trx.c
+++ b/src/host/trxcon/sched_trx.c
@@ -65,8 +65,8 @@
 * Advance frame number, giving the transceiver more
 * time until a burst must be transmitted...
 */
-   fn = (sched->fn_counter_proc + sched->fn_counter_advance)
-   % GSM_HYPERFRAME;
+   fn = TDMA_FN_SUM(sched->fn_counter_proc,
+   sched->fn_counter_advance);

/* Get frame from multiframe */
offset = fn % ts->mf_layout->period;
@@ -608,15 +608,14 @@
}

/* Calculate how many frames have been elapsed */
-   elapsed  = (burst_fn + GSM_HYPERFRAME - ts->mf_last_fn);
-   elapsed %= GSM_HYPERFRAME;
+   elapsed = TDMA_FN_SUB(burst_fn, ts->mf_last_fn);

/**
 * If not too many frames have been elapsed,
 * start counting from last fn + 1
 */
if (elapsed < 10)
-   fn = (ts->mf_last_fn + 1) % GSM_HYPERFRAME;
+   fn = TDMA_FN_INC(ts->mf_last_fn);
else
fn = burst_fn;

@@ -658,7 +657,7 @@
if (fn == burst_fn)
break;

-   fn = (fn + 1) % GSM_HYPERFRAME;
+   fn = TDMA_FN_INC(fn);
}

/* Set last processed frame number */
diff --git a/src/host/trxcon/scheduler.h b/src/host/trxcon/scheduler.h
index ddb863f..fccf7d2 100644
--- a/src/host/trxcon/scheduler.h
+++ b/src/host/trxcon/scheduler.h
@@ -10,6 +10,14 @@
 #define GSM_SUPERFRAME (26 * 51)
 #define GSM_HYPERFRAME (2048 * GSM_SUPERFRAME)

+/* TDMA frame number arithmetics */
+#define TDMA_FN_SUM(a, b) \
+   ((a + b) % GSM_HYPERFRAME)
+#define TDMA_FN_SUB(a, b) \
+   ((a + GSM_HYPERFRAME - b) % GSM_HYPERFRAME)
+#define TDMA_FN_INC(fn) \
+   TDMA_FN_SUM(fn, 1)
+
 enum tdma_sched_clck_state {
SCH_CLCK_STATE_WAIT,
SCH_CLCK_STATE_OK,

--
To view, visit https://gerrit.osmocom.org/10942
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb66ba846cc3d6c2eaa88414569e5f3751128047
Gerrit-Change-Number: 10942
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmocom-bb[master]: trxcon/scheduler: introduce TCH/H TDMA frame mapping helpres

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10459 )

Change subject: trxcon/scheduler: introduce TCH/H TDMA frame mapping helpres
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10459
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf4cb33f1b79df23f8a90c8b14ebe0cd9907fbb9
Gerrit-Change-Number: 10459
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sat, 15 Sep 2018 19:48:08 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: trxcon/scheduler: introduce TDMA frame math helpers

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10942 )

Change subject: trxcon/scheduler: introduce TDMA frame math helpers
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10942
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb66ba846cc3d6c2eaa88414569e5f3751128047
Gerrit-Change-Number: 10942
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sat, 15 Sep 2018 19:47:41 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: osmo-bts-trx/l1_if.c: cosmetic: fix typo in debug msg

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/10698 )

Change subject: osmo-bts-trx/l1_if.c: cosmetic: fix typo in debug msg
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/10698
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4362c2869e658c2f42664b4009a30e777f8048c
Gerrit-Change-Number: 10698
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sat, 15 Sep 2018 19:22:29 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmocom-bb[master]: trxcon/scheduler: introduce TDMA frame math helpers

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/10942 )

Change subject: trxcon/scheduler: introduce TDMA frame math helpers
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/10942
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb66ba846cc3d6c2eaa88414569e5f3751128047
Gerrit-Change-Number: 10942
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sat, 15 Sep 2018 19:15:22 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmocom-bb[master]: trxcon/scheduler: introduce TCH/H TDMA frame mapping helpres

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/10459 )

Change subject: trxcon/scheduler: introduce TCH/H TDMA frame mapping helpres
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/10459
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf4cb33f1b79df23f8a90c8b14ebe0cd9907fbb9
Gerrit-Change-Number: 10459
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sat, 15 Sep 2018 19:15:18 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmocom-bb[master]: trxcon/scheduler: add TCH/H channel support

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/10460 )

Change subject: trxcon/scheduler: add TCH/H channel support
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/10460
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb2a0850692c5ff86b13b820af10b12085589e67
Gerrit-Change-Number: 10460
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sat, 15 Sep 2018 19:15:05 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmocom-bb[master]: trxcon/scheduler: introduce TCH/H TDMA frame mapping helpres

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/10459 )

Change subject: trxcon/scheduler: introduce TCH/H TDMA frame mapping helpres
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/10459
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf4cb33f1b79df23f8a90c8b14ebe0cd9907fbb9
Gerrit-Change-Number: 10459
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sat, 15 Sep 2018 18:54:02 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmocom-bb[master]: trxcon/scheduler: introduce TDMA frame math helpers

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/10942 )

Change subject: trxcon/scheduler: introduce TDMA frame math helpers
..


Patch Set 1:

(1 comment)

I am wondering, may we share this code somewhere in libosmocore?

I just checked both OsmocomBB firmware and osmo-bts-trx - in both
cases the frame number of decoded L2 frame on TCH/H is calculated
in a wrong way. The firmware is just using frame number of the
last burst, while OsmoBTS is using frame number of 3/4 burst
for speech, and 5/6 burst for FACCH/H (bid == 0).

TCH/F channel is also affected: the firmware is using frame number
of the last 8/8 burst, osmo-bts-trx is using frame number of 4/8
burst, while for xCCH the correct frame number of 1/4 burst is
used everywhere...

This also raises a question: why should we use frame number of
the first burst in general? Why not frame number of the last?

https://gerrit.osmocom.org/#/c/10942/1/src/host/trxcon/scheduler.h
File src/host/trxcon/scheduler.h:

https://gerrit.osmocom.org/#/c/10942/1/src/host/trxcon/scheduler.h@14
PS1, Line 14: #define TDMA_FN_SUM(a, b) \
> you could implement TDMA_FN_INC(fn) as TDMA_FN_SUM(fn, 1)
Sure, thanks!



--
To view, visit https://gerrit.osmocom.org/10942
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb66ba846cc3d6c2eaa88414569e5f3751128047
Gerrit-Change-Number: 10942
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sat, 15 Sep 2018 18:44:47 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #247

[jenkins]

See 


--
[...truncated 3.67 KB...]

+ ./configure
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking 

Change in osmo-gsm-tester[master]: build: Add overload to clone repo and build in subdirectory

[Holger Freyther]

Holger Freyther has uploaded this change for review. ( 
https://gerrit.osmocom.org/10970


Change subject: build: Add overload to clone repo and build in subdirectory
..

build: Add overload to clone repo and build in subdirectory

To build osmo-nitb we need to clone "openbsc" and then enter the
"openbsc" sub-directory. For building "mobile" and "virt_phy" of
OsmocomBB we will need to do something similar. Instead of added
more hardcoded paths, add a variant that allows to specify the
source directory.

Change-Id: I67fbd54296f2c68316bf8e89cfeb37d147193d53
---
M contrib/jenkins-build-common.sh
M contrib/jenkins-build-osmo-nitb.sh
2 files changed, 14 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/70/10970/1

diff --git a/contrib/jenkins-build-common.sh b/contrib/jenkins-build-common.sh
index 731bf58..c2ffbb4 100644
--- a/contrib/jenkins-build-common.sh
+++ b/contrib/jenkins-build-common.sh
@@ -12,6 +12,7 @@
 # build_repo libosmocore --configure --opts
 # build_repo libosmo-foo special_branch --configure --opts
 # build_repo osmo-bar
+# build_repo_dir openbsc ./openbsc
 #
 # create_bin_tgz
 #--
@@ -98,11 +99,19 @@

 build_repo() {
   # usage: build_repo  [] [--configure-opts [...]]
+  dir="$1"
+  shift
+  build_repo_dir "${dir}" "./" $@
+}
+
+build_repo_dir() {
+  # usage: build_repo_dir   [] [--configure-opts [...]]
   dep="$1"
+  dir="$2"
   branch="master"
-  if [ -z "$(echo "$2" | grep '^-')" ]; then
+  if [ -z "$(echo "$3" | grep '^-')" ]; then
 # second arg does not start with a dash, it's empty or a branch
-branch="$2"
+branch="$3"
 if [ -n "$branch" ]; then
   # we had a branch arg, need to shift once more to get config options
   shift
@@ -111,6 +120,7 @@
 fi
   fi
   shift
+  shift
   configure_opts="$@"

   set +x; echo "
@@ -122,12 +132,7 @@

   have_repo "$dep" "$branch"

-  cd "$dep"
-
-  # special shim: we know the openbsc.git needs to be built in the openbsc/ 
subdir.
-  if [ "$dep" = "openbsc" ]; then
-cd openbsc
-  fi
+  cd "$dep/${dir}"

   set +x; echo; echo; set -x
   autoreconf -fi
diff --git a/contrib/jenkins-build-osmo-nitb.sh 
b/contrib/jenkins-build-osmo-nitb.sh
index 1e3ecc6..4f81fa8 100755
--- a/contrib/jenkins-build-osmo-nitb.sh
+++ b/contrib/jenkins-build-osmo-nitb.sh
@@ -10,6 +10,6 @@
 build_repo openggsn
 build_repo libsmpp34
 build_repo libosmo-sccp
-build_repo openbsc --enable-smpp --enable-osmo-bsc --enable-nat
+build_repo_dir openbsc openbsc --enable-smpp --enable-osmo-bsc --enable-nat

 create_bin_tgz "osmo-nitb osmo-bsc_mgcp"

--
To view, visit https://gerrit.osmocom.org/10970
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I67fbd54296f2c68316bf8e89cfeb37d147193d53
Gerrit-Change-Number: 10970
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 

Change in osmo-gsm-tester[master]: Add script to build virt_phy of OsmocomBB

[Holger Freyther]

Holger Freyther has uploaded this change for review. ( 
https://gerrit.osmocom.org/10972


Change subject: Add script to build virt_phy of OsmocomBB
..

Add script to build virt_phy of OsmocomBB

Change-Id: I1f14ce43db2f5e16f94dc975e7496dceb4f4b72a
---
A contrib/jenkins-build-virt_phy.sh
1 file changed, 10 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/72/10972/1

diff --git a/contrib/jenkins-build-virt_phy.sh 
b/contrib/jenkins-build-virt_phy.sh
new file mode 100755
index 000..4f00290
--- /dev/null
+++ b/contrib/jenkins-build-virt_phy.sh
@@ -0,0 +1,10 @@
+#!/bin/sh
+set -e -x
+base="$PWD"
+name="mobile"
+. "$(dirname "$0")/jenkins-build-common.sh"
+
+build_repo libosmocore --enable-sanitize --disable-doxygen
+build_repo_dir osmocom-bb src/host/virt_phy --enable-sanitize
+
+create_bin_tgz "virt_phy"

--
To view, visit https://gerrit.osmocom.org/10972
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f14ce43db2f5e16f94dc975e7496dceb4f4b72a
Gerrit-Change-Number: 10972
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 

Change in osmo-gsm-tester[master]: build: Add script to build the mobile application

[Holger Freyther]

Holger Freyther has uploaded this change for review. ( 
https://gerrit.osmocom.org/10971


Change subject: build: Add script to build the mobile application
..

build: Add script to build the mobile application

Change-Id: I2c537e56aa982b0b4a703fa78c77ade507738b68
---
A contrib/jenkins-build-mobile.sh
1 file changed, 10 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/71/10971/1

diff --git a/contrib/jenkins-build-mobile.sh b/contrib/jenkins-build-mobile.sh
new file mode 100755
index 000..ff2ae78
--- /dev/null
+++ b/contrib/jenkins-build-mobile.sh
@@ -0,0 +1,10 @@
+#!/bin/sh
+set -e -x
+base="$PWD"
+name="mobile"
+. "$(dirname "$0")/jenkins-build-common.sh"
+
+build_repo libosmocore --enable-sanitize --disable-doxygen
+build_repo_dir osmocom-bb src/host/layer23 --enable-sanitize
+
+create_bin_tgz "mobile"

--
To view, visit https://gerrit.osmocom.org/10971
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c537e56aa982b0b4a703fa78c77ade507738b68
Gerrit-Change-Number: 10971
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 

Change in osmo-ci[master]: osmocom_build_deps: Add liblimesuite-dev for osmo-trx-lms

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/10969


Change subject: osmocom_build_deps: Add liblimesuite-dev for osmo-trx-lms
..

osmocom_build_deps: Add liblimesuite-dev for osmo-trx-lms

Change-Id: I37d1f2482a03968f0a9d83a6ebda64651733a983
---
M ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/69/10969/1

diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml 
b/ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml
index 71bf9f1..7b8bdad 100644
--- a/ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml
+++ b/ansible/roles/osmocom-jenkins-slave/tasks/osmocom_build_deps.yml
@@ -103,4 +103,5 @@
 install_recommends: no
   with_items:
 - liblua5.3-dev
+- liblimesuite-dev
   when: ansible_distribution == 'Debian' and ansible_distribution_release == 
'stretch'

--
To view, visit https://gerrit.osmocom.org/10969
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I37d1f2482a03968f0a9d83a6ebda64651733a983
Gerrit-Change-Number: 10969
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Change in osmo-gsm-tester[master]: Keep track of all mobiles and copy them to unstarted later

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10684 )

Change subject: Keep track of all mobiles and copy them to unstarted later
..

Keep track of all mobiles and copy them to unstarted later

At all times have a list of mobiles that were created. Make a shallow
copy and use it as the unstarted list.

This will be used by the upcoming gsm tester integration to build a list
of subscribers to be added into the HLR/AuC database.

Change-Id: Id72b7ce8821cf53ac0d5e4a141b9a2b66242e2a3
---
M src/osmo_ms_driver/location_update_test.py
1 file changed, 7 insertions(+), 2 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_ms_driver/location_update_test.py 
b/src/osmo_ms_driver/location_update_test.py
index 2c59d97..e83d91b 100644
--- a/src/osmo_ms_driver/location_update_test.py
+++ b/src/osmo_ms_driver/location_update_test.py
@@ -16,7 +16,7 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see .

-
+from copy import copy
 from osmo_gsm_tester import log
 from .starter import OsmoVirtPhy, OsmoMobile
 from .test_support import imsi_ki_gen, Results
@@ -62,6 +62,7 @@
 self._cdf = cdf_function
 self._cdf.set_target(number_of_ms)
 self._unstarted = []
+self._mobiles = []
 self._phys = []
 self._results = {}
 imsi_gen = imsi_ki_gen()
@@ -78,9 +79,13 @@
 phy.phy_filename(),
 event_server.server_path())
 self._results[ms_name] = LUResult(ms_name)
-self._unstarted.append(launcher)
+self._mobiles.append(launcher)
 self._event_server = event_server
 self._event_server.register(self.handle_msg)
+self._unstarted = copy(self._mobiles)
+
+def mobiles(self):
+return self._mobiles

 def pre_launch(self, loop):
 """

--
To view, visit https://gerrit.osmocom.org/10684
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id72b7ce8821cf53ac0d5e4a141b9a2b66242e2a3
Gerrit-Change-Number: 10684
Gerrit-PatchSet: 4
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in libosmocore[master]: logging vty: add 'logging level set-all '

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10889 )

Change subject: logging vty: add 'logging level set-all '
..


Patch Set 2:

neels: you have the log related power/authority, please merge whenever you 
think it's ready.


--
To view, visit https://gerrit.osmocom.org/10889
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c3e4f786476cb813fdc0a7c64f30ee04758309d
Gerrit-Change-Number: 10889
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Sat, 15 Sep 2018 09:27:03 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-gsm-tester[master]: Sanitize existing suite names

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10931 )

Change subject: Sanitize existing suite names
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10931
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idea2e053d337548e0e9b1b47441dbb262124f909
Gerrit-Change-Number: 10931
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sat, 15 Sep 2018 09:26:01 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: add vty config for GSMTAP-SAPI remote host (-i)

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10808 )

Change subject: add vty config for GSMTAP-SAPI remote host (-i)
..


Patch Set 2:

> the gsmtap host setting only has effect during program startup, the
 > vty command doesn't actively change over to another address -- my
 > aim was to configure ot from .cfg file to not have to change the
 > cmdline, not to switch it in the running program ... then again,
 > maybe it should be doing that?

I think it would be best if any VTY configurable changes take effect 
eventuaally.  So far we should have settings that either
* take action immediately
* take action after some delay (like OML-reestablishment)

I think having VTY config statements that will never take action at all is very 
misleading to the user

 > Or, even if it doesn't do it yet, keep that option for the future
 > and not even start supporting arbitrary host names now?

I would say let's make it reconfigurable right away, and at that time enforce 
only IP addresses are accepted.


--
To view, visit https://gerrit.osmocom.org/10808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17676a21c4e0c9cbc88f2c5c53a39c6c6c473ca1
Gerrit-Change-Number: 10808
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Harald Welte 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 15 Sep 2018 09:25:38 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in openbsc[master]: cosmetic: Remove duplicate semicolon and whitespace

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10934 )

Change subject: cosmetic: Remove duplicate semicolon and whitespace
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10934
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib36b8937d1210488784ebae6917cb1b4c871c9d4
Gerrit-Change-Number: 10934
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sat, 15 Sep 2018 09:23:08 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in openbsc[master]: nat: return -EBADF in read wqueue cb on fd closed

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10937 )

Change subject: nat: return -EBADF in read wqueue cb on fd closed
..

nat: return -EBADF in read wqueue cb on fd closed

bsc_msc_lost will close the current fd (without freeing it), so let's
skip possible writes to an already closed fd
bsc_msc_lost will close the current fd (without freeing it), so let's
skip possible writes to an already closed fd..

Change-Id: I55c1a88f6524e897c70abf8ba18f1bb2b1f650aa
---
M openbsc/src/osmo-bsc_nat/bsc_nat.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c 
b/openbsc/src/osmo-bsc_nat/bsc_nat.c
index 8cc0f2d..c8a9e74 100644
--- a/openbsc/src/osmo-bsc_nat/bsc_nat.c
+++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c
@@ -864,7 +864,7 @@
msc_con->name, ret);

bsc_msc_lost(msc_con);
-   return -1;
+   return -EBADF;
}

LOGP(DNAT, LOGL_DEBUG,

--
To view, visit https://gerrit.osmocom.org/10937
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I55c1a88f6524e897c70abf8ba18f1bb2b1f650aa
Gerrit-Change-Number: 10937
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in openbsc[master]: nat: Remove misleading comment

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10935 )

Change subject: nat: Remove misleading comment
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10935
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeaa0e024b9542d1a22a8e3ab4c3229a6f8a0b49
Gerrit-Change-Number: 10935
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sat, 15 Sep 2018 09:23:18 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in openbsc[master]: nat: Remove misleading comment

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10936 )

Change subject: nat: Remove misleading comment
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10936
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88ca95d46f4ace1da4025d12302422dbfa578354
Gerrit-Change-Number: 10936
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 15 Sep 2018 09:23:34 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in openbsc[master]: nat: Remove misleading comment

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10936 )

Change subject: nat: Remove misleading comment
..

nat: Remove misleading comment

PONG is being sent a as an answer to PING a few lines above in same
function.

Change-Id: I88ca95d46f4ace1da4025d12302422dbfa578354
---
M openbsc/src/osmo-bsc_nat/bsc_nat.c
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c 
b/openbsc/src/osmo-bsc_nat/bsc_nat.c
index 0e69528..8cc0f2d 100644
--- a/openbsc/src/osmo-bsc_nat/bsc_nat.c
+++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c
@@ -1369,7 +1369,6 @@
return bsc_nat_handle_ctrlif_msg(bsc, msg);
}

-   /* FIXME: Currently no PONG is sent to the BSC */
/* FIXME: Currently no ID ACK is sent to the BSC */
forward_sccp_to_msc(bsc, msg, _closed);
return fd_closed ? -EBADF : 0;

--
To view, visit https://gerrit.osmocom.org/10936
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I88ca95d46f4ace1da4025d12302422dbfa578354
Gerrit-Change-Number: 10936
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in openbsc[master]: nat: Remove misleading comment

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10935 )

Change subject: nat: Remove misleading comment
..

nat: Remove misleading comment

Code is already doing stuff with the connection (fd).

Change-Id: Ieeaa0e024b9542d1a22a8e3ab4c3229a6f8a0b49
---
M openbsc/src/osmo-bsc_nat/bsc_nat.c
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c 
b/openbsc/src/osmo-bsc_nat/bsc_nat.c
index 0c91d04..0e69528 100644
--- a/openbsc/src/osmo-bsc_nat/bsc_nat.c
+++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c
@@ -1423,12 +1423,8 @@
if (rc != 0)
LOGP(DNAT, LOGL_ERROR, "Failed to set IP_TOS: %s\n", 
strerror(errno));

-   /* todo... do something with the connection */
/* todo... use GNUtls to see if we want to trust this as a BTS */

-   /*
-*
-*/
bsc = bsc_connection_alloc(nat);
if (!bsc) {
LOGP(DNAT, LOGL_ERROR, "Failed to allocate BSC struct.\n");

--
To view, visit https://gerrit.osmocom.org/10935
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieeaa0e024b9542d1a22a8e3ab4c3229a6f8a0b49
Gerrit-Change-Number: 10935
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in openbsc[master]: cosmetic: Remove duplicate semicolon and whitespace

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10934 )

Change subject: cosmetic: Remove duplicate semicolon and whitespace
..

cosmetic: Remove duplicate semicolon and whitespace

Change-Id: Ib36b8937d1210488784ebae6917cb1b4c871c9d4
---
M openbsc/src/osmo-bsc_nat/bsc_nat.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c 
b/openbsc/src/osmo-bsc_nat/bsc_nat.c
index 45f53bc..0c91d04 100644
--- a/openbsc/src/osmo-bsc_nat/bsc_nat.c
+++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c
@@ -1208,7 +1208,7 @@
}

/* hand data to a side channel */
-   if (bsc_ussd_check(con, parsed, msg) == 
1)
+   if (bsc_ussd_check(con, parsed, msg) == 
1)
con->con_local = 
NAT_CON_END_USSD;

/*
@@ -1703,7 +1703,7 @@
nat->msc_con->connection_loss = msc_connection_was_lost;
nat->msc_con->connected = msc_connection_connected;
nat->msc_con->write_queue.read_cb = ipaccess_msc_read_cb;
-   nat->msc_con->write_queue.write_cb = ipaccess_msc_write_cb;;
+   nat->msc_con->write_queue.write_cb = ipaccess_msc_write_cb;
nat->msc_con->write_queue.bfd.data = nat->msc_con;
bsc_msc_connect(nat->msc_con);


--
To view, visit https://gerrit.osmocom.org/10934
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib36b8937d1210488784ebae6917cb1b4c871c9d4
Gerrit-Change-Number: 10934
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in openbsc[master]: nat: return -EBADF in read wqueue cb on fd closed

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10937 )

Change subject: nat: return -EBADF in read wqueue cb on fd closed
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10937
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I55c1a88f6524e897c70abf8ba18f1bb2b1f650aa
Gerrit-Change-Number: 10937
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sat, 15 Sep 2018 09:22:52 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-hlr[master]: tweak example config

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10940 )

Change subject: tweak example config
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10940
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8296832704d779df5f1b20a595b568c99780e64d
Gerrit-Change-Number: 10940
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sat, 15 Sep 2018 09:22:13 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: Add includes so the file can be included by itself

[Holger Freyther]

Holger Freyther has uploaded this change for review. ( 
https://gerrit.osmocom.org/10968


Change subject: Add includes so the file can be included by itself
..

Add includes so the file can be included by itself

Add missing dependencies to make this file be includeable as the
only file.

Change-Id: I05b5f689f389b89deb5ff49507486b246111fc59
---
M src/host/layer23/include/osmocom/bb/mobile/gsm322.h
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/68/10968/1

diff --git a/src/host/layer23/include/osmocom/bb/mobile/gsm322.h 
b/src/host/layer23/include/osmocom/bb/mobile/gsm322.h
index 66bc852..d4caac9 100644
--- a/src/host/layer23/include/osmocom/bb/mobile/gsm322.h
+++ b/src/host/layer23/include/osmocom/bb/mobile/gsm322.h
@@ -1,6 +1,11 @@
 #ifndef _GSM322_H
 #define _GSM322_H

+#include 
+
+#include 
+#include 
+
 /* 4.3.1.1 List of states for PLMN slection process (automatic mode) */
 #define GSM322_A0_NULL 0
 #defineGSM322_A1_TRYING_RPLMN  1

--
To view, visit https://gerrit.osmocom.org/10968
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I05b5f689f389b89deb5ff49507486b246111fc59
Gerrit-Change-Number: 10968
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 

Change in osmocom-bb[master]: Install to /bin as it doesn't require special privileges..

[Holger Freyther]

Holger Freyther has uploaded this change for review. ( 
https://gerrit.osmocom.org/10967


Change subject: Install to /bin as it doesn't require special privileges..
..

Install to /bin as it doesn't require special privileges..

This makes packaging the binary for the gsm tester more easy.

Change-Id: Ibe572a4c17871785b623e70acc7f5da056f945e5
---
M src/host/virt_phy/src/Makefile.am
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/67/10967/1

diff --git a/src/host/virt_phy/src/Makefile.am 
b/src/host/virt_phy/src/Makefile.am
index 48f9de7..bfd0dfa 100644
--- a/src/host/virt_phy/src/Makefile.am
+++ b/src/host/virt_phy/src/Makefile.am
@@ -1,7 +1,7 @@
 AM_CFLAGS=-Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS)
 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include  
-I$(top_srcdir)/../layer23/include

-sbin_PROGRAMS = virtphy
+bin_PROGRAMS = virtphy
 virtphy_SOURCES = virtphy.c l1ctl_sock.c gsmtapl1_if.c l1ctl_sap.c 
virt_prim_pm.c virt_prim_fbsb.c virt_prim_rach.c virt_prim_data.c 
virt_prim_traffic.c virt_l1_sched_simple.c logging.c virt_l1_model.c 
shared/virtual_um.c shared/osmo_mcast_sock.c
 virtphy_LDADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS)
 virtphy_LDFLAGS = -pthread

--
To view, visit https://gerrit.osmocom.org/10967
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe572a4c17871785b623e70acc7f5da056f945e5
Gerrit-Change-Number: 10967
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 

Change in osmo-bts[master]: doc/examples/Makefile: Install bts-mgr cfg files used by systemd serv...

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10946 )

Change subject: doc/examples/Makefile: Install bts-mgr cfg files used by 
systemd services
..

doc/examples/Makefile: Install bts-mgr cfg files used by systemd services

Change-Id: Iaf362da2a9ebd6829391637252812c2be93e9c60
---
M doc/examples/Makefile.am
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/doc/examples/Makefile.am b/doc/examples/Makefile.am
index 241f579..04f8279 100644
--- a/doc/examples/Makefile.am
+++ b/doc/examples/Makefile.am
@@ -12,7 +12,7 @@
 sysmo/osmo-bts-sysmo.cfg \
 sysmo/sysmobts-mgr.cfg
 EXTRA_DIST += $(doc_sysmo_DATA)
-OSMOCONF_FILES += sysmo/osmo-bts-sysmo.cfg
+OSMOCONF_FILES += sysmo/osmo-bts-sysmo.cfg sysmo/sysmobts-mgr.cfg
 endif

 if ENABLE_TRX
@@ -39,7 +39,7 @@
 litecell15/osmo-bts-lc15.cfg \
 litecell15/lc15bts-mgr.cfg
 EXTRA_DIST += $(doc_lc15_DATA)
-OSMOCONF_FILES += litecell15/osmo-bts-lc15.cfg
+OSMOCONF_FILES += litecell15/osmo-bts-lc15.cfg litecell15/lc15bts-mgr.cfg
 endif

 osmoconfdir = $(sysconfdir)/osmocom

--
To view, visit https://gerrit.osmocom.org/10946
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf362da2a9ebd6829391637252812c2be93e9c60
Gerrit-Change-Number: 10946
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bts[master]: doc/examples/Makefile: Install bts-mgr cfg files used by systemd serv...

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10946 )

Change subject: doc/examples/Makefile: Install bts-mgr cfg files used by 
systemd services
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10946
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf362da2a9ebd6829391637252812c2be93e9c60
Gerrit-Change-Number: 10946
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sat, 15 Sep 2018 08:03:22 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-sccp[master]: debian: Document why enable-static is used in dh_auto_configure

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10947 )

Change subject: debian: Document why enable-static is used in dh_auto_configure
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10947
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a7215d350e023dceadc5826be68ce366a185da1
Gerrit-Change-Number: 10947
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sat, 15 Sep 2018 08:03:06 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-sccp[master]: debian: Document why enable-static is used in dh_auto_configure

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10947 )

Change subject: debian: Document why enable-static is used in dh_auto_configure
..

debian: Document why enable-static is used in dh_auto_configure

Change-Id: I4a7215d350e023dceadc5826be68ce366a185da1
---
M debian/rules
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/debian/rules b/debian/rules
index 6e69d24..0bf9673 100755
--- a/debian/rules
+++ b/debian/rules
@@ -19,6 +19,8 @@
sed -i "/dependency_libs/ s/'.*'/''/" `find . -name '*.la'`
dh_install

+# enable-static: we require the tests to link to the static libosmo-sigtran
+# library to access symbols not starting with osmo_*
 override_dh_auto_configure:
dh_auto_configure -- --enable-static 
--with-systemdsystemunitdir=/lib/systemd/system


--
To view, visit https://gerrit.osmocom.org/10947
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a7215d350e023dceadc5826be68ce366a185da1
Gerrit-Change-Number: 10947
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in meta-telephony[laforge/nightly]: openbsc: handle systemd and cfg files through autotools

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10959 )

Change subject: openbsc: handle systemd and cfg files through autotools
..

openbsc: handle systemd and cfg files through autotools

Change-Id: Ie6e6855cd34dd171e7e550646b8e37d606fc5653
---
M recipes-osmocom/openbsc/openbsc.inc
1 file changed, 6 insertions(+), 15 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/openbsc/openbsc.inc 
b/recipes-osmocom/openbsc/openbsc.inc
index ca3b124..71921b7 100644
--- a/recipes-osmocom/openbsc/openbsc.inc
+++ b/recipes-osmocom/openbsc/openbsc.inc
@@ -6,30 +6,21 @@

 RDEPENDS_osmo-nitb = "libdbd-sqlite3"

-INC_PR = "r3.${META_TELEPHONY_OSMO_INC}"
+INC_PR = "r4.${META_TELEPHONY_OSMO_INC}"

 EXTRA_OECONF += "--enable-nat --enable-osmo-bsc --enable-smpp 
--enable-mgcp-transcoding --with-g729"

 inherit autotools systemd pkgconfig

 do_install_append() {
-   install -d ${D}${sysconfdir}/osmocom
-   install -m 0660 ${S}/doc/examples/osmo-nitb/nanobts/openbsc.cfg 
${D}${sysconfdir}/osmocom/osmo-nitb.cfg
-   install -m 0660 
${S}/doc/examples/osmo-bsc-sccplite/osmo-bsc-sccplite.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-sccplite.cfg
-   install -m 0644 ${S}/doc/examples/osmo-bsc_nat/osmo-bsc_nat.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-nat.cfg
-   install -m 0644 ${S}/doc/examples/osmo-bsc_mgcp/mgcp.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-mgcp.cfg
-
-   # Install systemd files and enable on sysinit
-   install -d ${D}${systemd_system_unitdir}/
-   install -m 0644 ${S}/contrib/systemd/osmo-nitb.service 
${D}${systemd_system_unitdir}/
-   install -m 0644 ${S}/contrib/systemd/osmo-bsc-sccplite.service 
${D}${systemd_system_unitdir}/
-   install -m 0644 ${S}/contrib/systemd/osmo-bsc-nat.service 
${D}${systemd_system_unitdir}/
-   install -m 0644 ${S}/contrib/systemd/osmo-bsc-mgcp.service 
${D}${systemd_system_unitdir}/
-
install -d ${D}/var/lib/osmocom
-
 }

+PACKAGECONFIG ??= "\
+${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+"
+PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"
+
 PACKAGES =+ "osmo-bsc-nat osmo-bsc-sccplite osmo-nitb osmo-bsc-mgcp"
 SYSTEMD_PACKAGES = "osmo-bsc-nat osmo-bsc-sccplite osmo-nitb osmo-bsc-mgcp"


--
To view, visit https://gerrit.osmocom.org/10959
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6e6855cd34dd171e7e550646b8e37d606fc5653
Gerrit-Change-Number: 10959
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: osmo-sip-connector: handle systemd and cfg files through autotools

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10957 )

Change subject: osmo-sip-connector: handle systemd and cfg files through 
autotools
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10957
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I88fa636fdc97dbd1c8d13358fb48d157bd95c805
Gerrit-Change-Number: 10957
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 15 Sep 2018 08:02:05 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-sip-connector: handle systemd and cfg files through autotools

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10957 )

Change subject: osmo-sip-connector: handle systemd and cfg files through 
autotools
..

osmo-sip-connector: handle systemd and cfg files through autotools

Change-Id: I88fa636fdc97dbd1c8d13358fb48d157bd95c805
---
M recipes-osmocom/osmo-sip-connector/osmo-sip-connector.inc
1 file changed, 5 insertions(+), 7 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/osmo-sip-connector/osmo-sip-connector.inc 
b/recipes-osmocom/osmo-sip-connector/osmo-sip-connector.inc
index d7f22a3..96d3734 100644
--- a/recipes-osmocom/osmo-sip-connector/osmo-sip-connector.inc
+++ b/recipes-osmocom/osmo-sip-connector/osmo-sip-connector.inc
@@ -5,17 +5,15 @@

 DEPENDS = "sofia-sip libosmocore"

-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd

-do_install_append() {
-   install -d ${D}${systemd_system_unitdir}/
-   install -d ${D}${sysconfdir}/osmocom/
+PACKAGECONFIG ??= "\
+${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+"
+PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"

-   install -m 0644 ${S}/doc/examples/osmo-sip-connector.cfg 
${D}${sysconfdir}/osmocom/

-   install -m 0644 ${S}/contrib/systemd/osmo-sip-connector.service 
${D}${systemd_system_unitdir}/
-}
 SYSTEMD_SERVICE_${PN} = "${PN}.service"
 CONFFILES_osmo-sip-connector = "${sysconfdir}/osmocom/osmo-sip-connector.cfg"

--
To view, visit https://gerrit.osmocom.org/10957
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: merged
Gerrit-Change-Id: I88fa636fdc97dbd1c8d13358fb48d157bd95c805
Gerrit-Change-Number: 10957
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in meta-telephony[201705]: osmo-ggsn: Split into .inc and _git.bb

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10944 )

Change subject: osmo-ggsn: Split into .inc and _git.bb
..

osmo-ggsn: Split into .inc and _git.bb

Change-Id: Ic92309726c6a256c7e543a2be04725023d43d9b7
---
A recipes-osmocom/osmo-ggsn/osmo-ggsn.inc
M recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
2 files changed, 43 insertions(+), 40 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc 
b/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc
new file mode 100644
index 000..49dd1ee
--- /dev/null
+++ b/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc
@@ -0,0 +1,38 @@
+DESCRIPTION = "Osmocom GGSN implementation"
+HOMEPAGE = "https://osmocom.org/projects/openggsn;
+LICENSE = "GPLv2+"
+LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
+
+DEPENDS = "libosmocore"
+
+INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+
+PACKAGES =+ " libgtp libgtp-dev libgtp-staticdev osmo-sgsnemu"
+RDEPENDS_${PN} += "iptables"
+RRECOMMENDS_${PN} += "kernel-module-ipt-masquerade kernel-module-tun"
+
+inherit autotools update-rc.d pkgconfig systemd
+
+do_install_append() {
+   install -d ${D}${sysconfdir}/init.d
+   install -d ${D}${systemd_system_unitdir}/
+   install -d ${D}/${sysconfdir}/osmocom/
+
+   install -m 0776 ${WORKDIR}/osmo-ggsn.init 
${D}${sysconfdir}/init.d/osmo-ggsn
+   install -m 0644 ${S}/contrib/osmo-ggsn.service 
${D}${systemd_system_unitdir}/
+   install -m 0644 ${S}/doc/examples/osmo-ggsn.cfg 
${D}${sysconfdir}/osmocom/
+}
+
+SYSTEMD_SERVICE_osmo-ggsn = "osmo-ggsn.service"
+
+INITSCRIPT_PACKAGES = "osmo-ggsn"
+INITSCRIPT_NAME_osmo-ggsn = "osmo-ggsn"
+INITSCRIPT_PARAMS_osmo-ggsn = "defaults 29 29"
+
+CONFFILES_osmo-ggsn = "${sysconfdir}/osmocom/osmo-ggsn.cfg"
+
+FILES_libgtp = "${libdir}/*${SOLIBS}"
+FILES_libgtp-dev = "${includedir} ${libdir}/lib*${SOLIBSDEV} ${libdir}/*.la"
+FILES_libgtp-staticdev = "${libdir}/*.a"
+
+FILES_osmo-sgsnemu = "${bindir}/sgsnemu"
diff --git a/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb 
b/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
index 8c948cc..5219c03 100644
--- a/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
+++ b/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
@@ -1,45 +1,10 @@
-DESCRIPTION = "Osmocom GGSN implementation"
-HOMEPAGE = "https://osmocom.org/projects/openggsn;
-LICENSE = "GPLv2+"
-LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
-PV = "1.2.2+gitr${SRCPV}"
-PR = "r0"
+require ${PN}.inc

+S = "${WORKDIR}/git"
 SRCREV = "b673d1c438488fb74abda344e563d733e5ce451a"
 SRC_URI = "git://git.osmocom.org/osmo-ggsn   \
file://osmo-ggsn.init \
-  file://libgtp-queue_depth_32.patch   \
+   file://libgtp-queue_depth_32.patch  \
   "
-S = "${WORKDIR}/git"
-
-DEPENDS = "libosmocore"
-
-PACKAGES =+ " libgtp libgtp-dev libgtp-staticdev osmo-sgsnemu"
-RDEPENDS_${PN} += "iptables"
-RRECOMMENDS_${PN} += "kernel-module-ipt-masquerade kernel-module-tun"
-
-inherit autotools update-rc.d pkgconfig systemd
-
-do_install_append() {
-   install -d ${D}${sysconfdir}/init.d
-   install -d ${D}${systemd_system_unitdir}/
-   install -d ${D}/${sysconfdir}/osmocom/
-
-   install -m 0776 ${WORKDIR}/osmo-ggsn.init 
${D}${sysconfdir}/init.d/osmo-ggsn
-   install -m 0644 ${S}/contrib/osmo-ggsn.service 
${D}${systemd_system_unitdir}/
-   install -m 0644 ${S}/doc/examples/osmo-ggsn.cfg 
${D}${sysconfdir}/osmocom/
-}
-
-SYSTEMD_SERVICE_osmo-ggsn = "osmo-ggsn.service"
-
-INITSCRIPT_PACKAGES = "osmo-ggsn"
-INITSCRIPT_NAME_osmo-ggsn = "osmo-ggsn"
-INITSCRIPT_PARAMS_osmo-ggsn = "defaults 29 29"
-
-CONFFILES_osmo-ggsn = "${sysconfdir}/osmocom/osmo-ggsn.cfg"
-
-FILES_libgtp = "${libdir}/*${SOLIBS}"
-FILES_libgtp-dev = "${includedir} ${libdir}/lib*${SOLIBSDEV} ${libdir}/*.la"
-FILES_libgtp-staticdev = "${libdir}/*.a"
-
-FILES_osmo-sgsnemu = "${bindir}/sgsnemu"
+PV = "1.2.2+gitr${SRCPV}"
+PR = "${INC_PR}.0"

--
To view, visit https://gerrit.osmocom.org/10944
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic92309726c6a256c7e543a2be04725023d43d9b7
Gerrit-Change-Number: 10944
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: osmo-msc: handle systemd and cfg files through autotools

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10955 )

Change subject: osmo-msc: handle systemd and cfg files through autotools
..

osmo-msc: handle systemd and cfg files through autotools

Change-Id: I0ccddd158f88fdd5dbe8e9a36c62d515b973486a
---
M recipes-osmocom/osmo-msc/osmo-msc.inc
1 file changed, 7 insertions(+), 10 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/osmo-msc/osmo-msc.inc 
b/recipes-osmocom/osmo-msc/osmo-msc.inc
index e5364cd..59280ce 100644
--- a/recipes-osmocom/osmo-msc/osmo-msc.inc
+++ b/recipes-osmocom/osmo-msc/osmo-msc.inc
@@ -5,23 +5,20 @@

 DEPENDS = "libdbi libosmocore libosmo-abis libosmo-sccp libosmo-netif osmo-mgw 
osmo-hlr"

-INC_PR="r1.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r2.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd

-PACKAGECONFIG ??= "smpp ${@bb.utils.filter('DISTRO_FEATURES', 'iu', d)}"
+PACKAGECONFIG ??= "\
+smpp \
+${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+${@bb.utils.filter('DISTRO_FEATURES', 'iu', d)} \
+"
+PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"
 PACKAGECONFIG[iu] = "--enable-iu,--disable-iu,libasn1c osmo-iuh,"
 PACKAGECONFIG[smpp] = "--enable-smpp,--disable-smpp,libsmpp34,"

 RDEPENDS_${PN} = "libdbd-sqlite3"

-do_install_append() {
-   install -d ${D}${systemd_system_unitdir}/
-   install -d ${D}${sysconfdir}/osmocom/
-
-   install -m 0644 ${S}/doc/examples/osmo-msc/osmo-msc.cfg 
${D}${sysconfdir}/osmocom/
-   install -m 0644 ${S}/contrib/systemd/osmo-msc.service 
${D}${systemd_system_unitdir}/
-}
-
 SYSTEMD_SERVICE_${PN} = "${PN}.service"
 CONFFILES_osmo-msc = "${sysconfdir}/osmocom/osmo-msc.cfg"

--
To view, visit https://gerrit.osmocom.org/10955
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ccddd158f88fdd5dbe8e9a36c62d515b973486a
Gerrit-Change-Number: 10955
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in meta-telephony[201705]: osmo-ggsn: Split into .inc and _git.bb

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10944 )

Change subject: osmo-ggsn: Split into .inc and _git.bb
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10944
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic92309726c6a256c7e543a2be04725023d43d9b7
Gerrit-Change-Number: 10944
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 15 Sep 2018 08:02:46 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-bsc: handle systemd and cfg files through autotools

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10956 )

Change subject: osmo-bsc: handle systemd and cfg files through autotools
..

osmo-bsc: handle systemd and cfg files through autotools

Change-Id: I752503f1ad7562ead50ec2bb7be49a958b9dc0f0
---
M recipes-osmocom/osmo-bsc/osmo-bsc.inc
1 file changed, 5 insertions(+), 9 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/osmo-bsc/osmo-bsc.inc 
b/recipes-osmocom/osmo-bsc/osmo-bsc.inc
index d066a58..484a779 100644
--- a/recipes-osmocom/osmo-bsc/osmo-bsc.inc
+++ b/recipes-osmocom/osmo-bsc/osmo-bsc.inc
@@ -5,18 +5,14 @@

 DEPENDS = "sqlite3 libpcap libosmocore libosmo-abis libosmo-sccp libosmo-netif 
osmo-mgw"

-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd

-do_install_append() {
-   install -d ${D}${systemd_system_unitdir}/
-   install -d ${D}${sysconfdir}/osmocom/
-
-   install -m 0644 ${S}/doc/examples/osmo-bsc/osmo-bsc.cfg 
${D}${sysconfdir}/osmocom/
-
-   install -m 0644 ${S}/contrib/systemd/osmo-bsc.service 
${D}${systemd_system_unitdir}/
-}
+PACKAGECONFIG ??= "\
+${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+"
+PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"

 PACKAGES =+ "meas-utils ipaccess-utils bs11-utils abisip-find"
 SYSTEMD_PACKAGES = "osmo-bsc"

--
To view, visit https://gerrit.osmocom.org/10956
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: merged
Gerrit-Change-Id: I752503f1ad7562ead50ec2bb7be49a958b9dc0f0
Gerrit-Change-Number: 10956
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: osmo-sgsn: handle systemd and cfg files through autotools

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10953 )

Change subject: osmo-sgsn: handle systemd and cfg files through autotools
..

osmo-sgsn: handle systemd and cfg files through autotools

At the same time systemd services were installed by autotools,
osmo-gtphub service became available too.

Change-Id: Ib84a3c8634db2282b2d3757ae7c044a196720852
---
M recipes-osmocom/osmo-sgsn/osmo-sgsn.inc
1 file changed, 8 insertions(+), 15 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/osmo-sgsn/osmo-sgsn.inc 
b/recipes-osmocom/osmo-sgsn/osmo-sgsn.inc
index 4711a2c..45256a5 100644
--- a/recipes-osmocom/osmo-sgsn/osmo-sgsn.inc
+++ b/recipes-osmocom/osmo-sgsn/osmo-sgsn.inc
@@ -5,29 +5,22 @@

 DEPENDS = "c-ares libosmocore libosmo-netif osmo-ggsn"

-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd

-PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'iu', d)}"
+PACKAGECONFIG ??= "\
+${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+${@bb.utils.filter('DISTRO_FEATURES', 'iu', d)} \
+"
+PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"
 PACKAGECONFIG[iu] = "--enable-iu,--disable-iu,libasn1c libosmo-sccp osmo-iuh,"

-do_install_append() {
-   install -d ${D}${systemd_system_unitdir}/
-   install -d ${D}${sysconfdir}/osmocom/
-
-   install -m 0644 ${S}/doc/examples/osmo-sgsn/osmo-sgsn.cfg 
${D}${sysconfdir}/osmocom/
-   install -m 0644 ${S}/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg 
${D}${sysconfdir}/osmocom/
-   install -m 0644 ${S}/doc/examples/osmo-gtphub/osmo-gtphub.cfg 
${D}${sysconfdir}/osmocom/
-
-   install -m 0644 ${S}/contrib/systemd/osmo-sgsn.service 
${D}${systemd_system_unitdir}/
-   install -m 0644 ${S}/contrib/systemd/osmo-gbproxy.service 
${D}${systemd_system_unitdir}/
-}
-
 PACKAGES =+ "osmo-gbproxy-doc osmo-gtphub-doc osmo-gbproxy osmo-gtphub"
-SYSTEMD_PACKAGES = "osmo-sgsn osmo-gbproxy"
+SYSTEMD_PACKAGES = "osmo-sgsn osmo-gbproxy osmo-gtphub"
 SYSTEMD_SERVICE_osmo-sgsn = "osmo-sgsn.service"
 SYSTEMD_SERVICE_osmo-gbproxy = "osmo-gbproxy.service"
+SYSTEMD_SERVICE_osmo-gtphub = "osmo-gtphub.service"

 CONFFILES_osmo-sgsn = "${sysconfdir}/osmocom/osmo-sgsn.cfg"


--
To view, visit https://gerrit.osmocom.org/10953
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib84a3c8634db2282b2d3757ae7c044a196720852
Gerrit-Change-Number: 10953
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: openbsc: handle systemd and cfg files through autotools

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10959 )

Change subject: openbsc: handle systemd and cfg files through autotools
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10959
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6e6855cd34dd171e7e550646b8e37d606fc5653
Gerrit-Change-Number: 10959
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 15 Sep 2018 08:02:25 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: openbsc: Drop untested sysvinit support

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10958 )

Change subject: openbsc: Drop untested sysvinit support
..

openbsc: Drop untested sysvinit support

These bits come from times were sysvinit was used in stead of systemd in
yocto. Nowadays nobody is known to be using the recipes with sysvinit
instead of systemd, and anyway most osmocom recipes doesn't come with
sysvinit support, so let's drop it. If sysvinit support is required, it
should be added through autotools install process instead.

As update-rc.d was removed, it was noticied that systemd class inherit
was missing, so this commit adds it. As a result, it's not required to
define systemd service file paths in FILES_*.

Change-Id: I864e4a61aed7933c46b80aa26598234faba43395
---
M recipes-osmocom/openbsc/openbsc.inc
D recipes-osmocom/openbsc/openbsc/osmo-bsc-sccplite.init
D recipes-osmocom/openbsc/openbsc/osmo-nitb.init
M recipes-osmocom/openbsc/openbsc_git.bb
4 files changed, 2 insertions(+), 119 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/openbsc/openbsc.inc 
b/recipes-osmocom/openbsc/openbsc.inc
index ec130db..ca3b124 100644
--- a/recipes-osmocom/openbsc/openbsc.inc
+++ b/recipes-osmocom/openbsc/openbsc.inc
@@ -6,15 +6,11 @@

 RDEPENDS_osmo-nitb = "libdbd-sqlite3"

-SRC_URI = "file://osmo-nitb.init \
-  file://osmo-bsc-sccplite.init \
-  "
-
 INC_PR = "r3.${META_TELEPHONY_OSMO_INC}"

 EXTRA_OECONF += "--enable-nat --enable-osmo-bsc --enable-smpp 
--enable-mgcp-transcoding --with-g729"

-inherit autotools update-rc.d pkgconfig
+inherit autotools systemd pkgconfig

 do_install_append() {
install -d ${D}${sysconfdir}/osmocom
@@ -23,12 +19,6 @@
install -m 0644 ${S}/doc/examples/osmo-bsc_nat/osmo-bsc_nat.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-nat.cfg
install -m 0644 ${S}/doc/examples/osmo-bsc_mgcp/mgcp.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-mgcp.cfg
 
-   # Install sysv-init files
-   install -d ${D}${sysconfdir}/init.d
-   install -d ${D}${sysconfdir}/rc5.d
-   install -m 0775 ${WORKDIR}/osmo-nitb.init 
${D}${sysconfdir}/init.d/osmo-nitb
-   install -m 0775 ${WORKDIR}/osmo-bsc-sccplite.init 
${D}${sysconfdir}/init.d/osmo-bsc-sccplite
-
# Install systemd files and enable on sysinit
install -d ${D}${systemd_system_unitdir}/
install -m 0644 ${S}/contrib/systemd/osmo-nitb.service 
${D}${systemd_system_unitdir}/
@@ -42,27 +32,18 @@

 PACKAGES =+ "osmo-bsc-nat osmo-bsc-sccplite osmo-nitb osmo-bsc-mgcp"
 SYSTEMD_PACKAGES = "osmo-bsc-nat osmo-bsc-sccplite osmo-nitb osmo-bsc-mgcp"
-INITSCRIPT_PACKAGES = "osmo-bsc-sccplite osmo-nitb"

 CONFFILES_osmo-bsc-sccplite = "${sysconfdir}/osmocom/osmo-bsc-sccplite.cfg"
 SYSTEMD_SERVICE_osmo-bsc-sccplite = "osmo-bsc-sccplite.service"
-INITSCRIPT_NAME_osmo-bsc-sccplite = "osmo-bsc-sccplite"
-INITSCRIPT_PARAMS_osmo-bsc-sccplite = "defaults 30 30"
 FILES_osmo-bsc-sccplite = " ${bindir}/osmo-bsc-sccplite \
${sysconfdir}/osmocom/osmo-bsc-sccplite.cfg \
-   ${sysconfdir}/init.d/osmo-bsc-sccplite \
-   ${systemd_system_unitdir}/osmo-bsc-sccplite.service \
"

 CONFFILES_osmo-nitb = "${sysconfdir}/osmocom/osmo-nitb.cfg"
 SYSTEMD_SERVICE_osmo-nitb = "osmo-nitb.service"
-INITSCRIPT_NAME_osmo-nitb = "osmo-nitb"
-INITSCRIPT_PARAMS_osmo-nitb = "defaults 30 30"
 FILES_osmo-nitb = " ${bindir}/osmo-nitb \
/var/lib/osmocom \
-   ${sysconfdir}/init.d/osmo-nitb \
${sysconfdir}/osmocom/osmo-nitb.cfg \
-   ${systemd_system_unitdir}/osmo-nitb.service \
"

 CONFFILES_osmo-bsc-nat = "${sysconfdir}/osmocom/osmo-bsc_nat.cfg"
@@ -70,7 +51,6 @@
 FILES_osmo-bsc-nat = " \
${bindir}/osmo-bsc_nat \
${sysconfdir}/osmocom/osmo-bsc_nat.cfg \
-   ${systemd_system_unitdir}/osmo-bsc-nat.service \
"

 CONFFILES_osmo-bsc-mgcp = "${sysconfdir}/osmocom/osmo-bsc-mgcp.cfg"
@@ -78,5 +58,4 @@
 FILES_osmo-bsc-mgcp = " \
${bindir}/osmo-bsc_mgcp \
${sysconfdir}/osmocom/osmo-bsc-mgcp.cfg \
-   ${systemd_system_unitdir}/osmo-bsc-mgcp.service \
"
diff --git a/recipes-osmocom/openbsc/openbsc/osmo-bsc-sccplite.init 
b/recipes-osmocom/openbsc/openbsc/osmo-bsc-sccplite.init
deleted file mode 100755
index 3186f6d..000
--- a/recipes-osmocom/openbsc/openbsc/osmo-bsc-sccplite.init
+++ /dev/null
@@ -1,48 +0,0 @@
-#!/bin/sh
-### BEGIN INIT INFO
-# Provides:osmo-bsc-sccplite
-# Required-Start:  $syslog $networking
-# Required-Stop:   $syslog
-# Default-Start:   5
-# Default-Stop:1
-# Short-Description:   Osmocom GSM Base Station Controller (legacy, with 
SCCPLite)
-### END INIT INFO
-
-DAEMON=/usr/bin/osmo-bsc-sccplite

Change in meta-telephony[laforge/nightly]: osmo-mgw: handle systemd and cfg files through autotools

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10954 )

Change subject: osmo-mgw: handle systemd and cfg files through autotools
..

osmo-mgw: handle systemd and cfg files through autotools

Change-Id: Iab265207f534f5d2b5960b707081b06aa5d34d11
---
M recipes-osmocom/osmo-mgw/osmo-mgw.inc
1 file changed, 5 insertions(+), 8 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/osmo-mgw/osmo-mgw.inc 
b/recipes-osmocom/osmo-mgw/osmo-mgw.inc
index 19e17ab..c00f998 100644
--- a/recipes-osmocom/osmo-mgw/osmo-mgw.inc
+++ b/recipes-osmocom/osmo-mgw/osmo-mgw.inc
@@ -5,17 +5,14 @@

 DEPENDS = "libosmocore libosmo-netif"

-INC_PR="r1.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r2.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd

-do_install_append() {
-   install -d ${D}${systemd_system_unitdir}/
-   install -d ${D}${sysconfdir}/osmocom/
-
-   install -m 0644 ${S}/doc/examples/osmo-mgw/osmo-mgw.cfg 
${D}${sysconfdir}/osmocom/osmo-mgw.cfg
-   install -m 0644 ${S}/contrib/systemd/osmo-mgw.service 
${D}${systemd_system_unitdir}/
-}
+PACKAGECONFIG ??= "\
+${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+"
+PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"

 PACKAGES =+ "libosmo-mgcp libosmo-mgcp-dev libosmo-mgcp-client 
libosmo-mgcp-client-dev"
 SYSTEMD_SERVICE_osmo-mgw = "osmo-mgw.service"

--
To view, visit https://gerrit.osmocom.org/10954
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab265207f534f5d2b5960b707081b06aa5d34d11
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: osmo-ggsn: handle systemd and cfg files through autotools

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10952 )

Change subject: osmo-ggsn: handle systemd and cfg files through autotools
..

osmo-ggsn: handle systemd and cfg files through autotools

Change-Id: I3c220c11f58793c644d750040c7fad347500bb8a
---
M recipes-osmocom/osmo-ggsn/osmo-ggsn.inc
1 file changed, 8 insertions(+), 11 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc 
b/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc
index fe0170f..0aaf418 100644
--- a/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc
+++ b/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc
@@ -5,22 +5,19 @@

 DEPENDS = "libosmocore"

-INC_PR="r1.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r2.${META_TELEPHONY_OSMO_INC}"
+
+inherit autotools pkgconfig systemd
+
+PACKAGECONFIG ??= "\
+${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+"
+PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"

 PACKAGES =+ " libgtp libgtp-dev libgtp-staticdev osmo-sgsnemu"
 RDEPENDS_${PN} += "iptables"
 RRECOMMENDS_${PN} += "kernel-module-ipt-masquerade kernel-module-tun"

-inherit autotools pkgconfig systemd
-
-do_install_append() {
-   install -d ${D}${systemd_system_unitdir}/
-   install -d ${D}/${sysconfdir}/osmocom/
-
-   install -m 0644 ${S}/contrib/osmo-ggsn.service 
${D}${systemd_system_unitdir}/
-   install -m 0644 ${S}/doc/examples/osmo-ggsn.cfg 
${D}${sysconfdir}/osmocom/
-}
-
 SYSTEMD_SERVICE_osmo-ggsn = "osmo-ggsn.service"

 CONFFILES_osmo-ggsn = "${sysconfdir}/osmocom/osmo-ggsn.cfg"

--
To view, visit https://gerrit.osmocom.org/10952
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c220c11f58793c644d750040c7fad347500bb8a
Gerrit-Change-Number: 10952
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: osmo-hlr: handle systemd and cfg files through autotools

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10950 )

Change subject: osmo-hlr: handle systemd and cfg files through autotools
..

osmo-hlr: handle systemd and cfg files through autotools

Change-Id: I1e3725c6ffef9223015df8cf76b5d5c884a76fce
---
M recipes-osmocom/osmo-hlr/osmo-hlr.inc
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/osmo-hlr/osmo-hlr.inc 
b/recipes-osmocom/osmo-hlr/osmo-hlr.inc
index 8f078ed..13c01f7 100644
--- a/recipes-osmocom/osmo-hlr/osmo-hlr.inc
+++ b/recipes-osmocom/osmo-hlr/osmo-hlr.inc
@@ -5,7 +5,7 @@

 DEPENDS = "libtalloc libosmocore libosmo-abis sqlite3 sqlite3-native"

-INC_PR="r1.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r2.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd

@@ -14,15 +14,15 @@
 }

 do_install_append() {
-   install -d ${D}${systemd_system_unitdir}/
-   install -d ${D}${sysconfdir}/osmocom/
install -d ${D}${localstatedir}/lib/osmocom/
-
-   install -m 0644 ${S}/doc/examples/osmo-hlr.cfg 
${D}${sysconfdir}/osmocom/
-   install -m 0644 ${S}/contrib/systemd/osmo-hlr.service 
${D}${systemd_system_unitdir}/
install -m 0644 ${WORKDIR}/hlr.db 
${D}${localstatedir}/lib/osmocom/hlr.db
 }

+PACKAGECONFIG ??= "\
+${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+"
+PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"
+
 PACKAGES =+ "libosmo-gsup-client libosmo-gsup-client-dev osmo-hlr-utils"

 FILES_libosmo-gsup-client = "${libdir}/libosmo-gsup-client${SOLIBS}"

--
To view, visit https://gerrit.osmocom.org/10950
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e3725c6ffef9223015df8cf76b5d5c884a76fce
Gerrit-Change-Number: 10950
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: osmo-iuh: handle systemd and cfg files through autotools

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10949 )

Change subject: osmo-iuh: handle systemd and cfg files through autotools
..

osmo-iuh: handle systemd and cfg files through autotools

Change-Id: If879153a32ae21ad63284382a420da534f30e6eb
---
M recipes-osmocom/osmo-iuh/osmo-iuh.inc
1 file changed, 5 insertions(+), 8 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/osmo-iuh/osmo-iuh.inc 
b/recipes-osmocom/osmo-iuh/osmo-iuh.inc
index 6dfb344..ab412ad 100644
--- a/recipes-osmocom/osmo-iuh/osmo-iuh.inc
+++ b/recipes-osmocom/osmo-iuh/osmo-iuh.inc
@@ -5,17 +5,14 @@

 DEPENDS = "libosmocore libosmo-netif libosmo-sccp libasn1c"

-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd

-do_install_append() {
-   install -d ${D}${systemd_system_unitdir}/
-   install -d ${D}${sysconfdir}/osmocom/
-
-   install -m 0644 ${S}/doc/examples/osmo-hnbgw.cfg 
${D}${sysconfdir}/osmocom/
-   install -m 0644 ${S}/contrib/systemd/osmo-hnbgw.service 
${D}${systemd_system_unitdir}/
-}
+PACKAGECONFIG ??= "\
+${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+"
+PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"

 PACKAGES =+ "libosmo-ranap libosmo-ranap-dev osmo-hnbgw"
 SYSTEMD_PACKAGES = "osmo-hnbgw"

--
To view, visit https://gerrit.osmocom.org/10949
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: merged
Gerrit-Change-Id: If879153a32ae21ad63284382a420da534f30e6eb
Gerrit-Change-Number: 10949
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: osmo-ggsn: Drop untested sysvinit support

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10951 )

Change subject: osmo-ggsn: Drop untested sysvinit support
..

osmo-ggsn: Drop untested sysvinit support

These bits come from times were sysvinit was used in stead of systemd in
yocto. Nowadays nobody is known to be using the recipes with sysvinit
instead of systemd, and anyway most osmocom recipes doesn't come with
sysvinit support, so let's drop it. If sysvinit support is required, it
should be added through autotools install process instead.

Change-Id: I303ea210e14e0e6e9a18b1bb4c25d470924d80c6
---
D recipes-osmocom/osmo-ggsn/files/osmo-ggsn.init
M recipes-osmocom/osmo-ggsn/osmo-ggsn.inc
M recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
3 files changed, 3 insertions(+), 179 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/osmo-ggsn/files/osmo-ggsn.init 
b/recipes-osmocom/osmo-ggsn/files/osmo-ggsn.init
deleted file mode 100755
index 157d6dd..000
--- a/recipes-osmocom/osmo-ggsn/files/osmo-ggsn.init
+++ /dev/null
@@ -1,169 +0,0 @@
-#!/bin/sh
-### BEGIN INIT INFO
-# Provides:  osmo-ggsn
-# Required-Start:$network $local_fs
-# Required-Stop:
-# Default-Start: 2 3 4 5
-# Default-Stop:  0 1 6
-# Short-Description: Osmocom GSM network-in-a-box
-# Description:   A minimal implementation of the GSM Base Station 
Controller,
-#Mobile Switching Center, Home Location regster and all 
other
-#components to run a self-contained GSM network.
-### END INIT INFO
-
-# Author: Harald Welte 
-
-# PATH should only include /usr/* if it runs after the mountnfs.sh script
-PATH=/sbin:/usr/sbin:/bin:/usr/bin
-DESC="Osmocom GGSN implementation"
-NAME=osmo-ggsn
-DAEMON=/usr/bin/ggsn
-DAEMON_ARGS="" # Arguments to run the daemon with
-PIDFILE=/var/run/$NAME.pid
-SCRIPTNAME=/etc/init.d/$NAME
-CONFIG_FILE=/etc/ggsn.conf
-
-# Exit if the package is not installed
-[ -x $DAEMON ] || exit 0
-
-# Read configuration variable file if it is present
-[ -r /etc/default/$NAME ] && . /etc/default/$NAME
-
-# Load the VERBOSE setting and other rcS variables
-# . /lib/init/vars.sh
-
-# Define LSB log_* functions.
-# Depend on lsb-base (>= 3.0-6) to ensure that this file is present.
-# . /lib/lsb/init-functions
-
-DAEMON_ARGS="$DAEMON_ARGS -c $CONFIG_FILE"
-
-#
-# Function that starts the daemon/service
-#
-do_start()
-{
-   # Return
-   #   0 if daemon has been started
-   #   1 if daemon was already running
-   #   2 if daemon could not be started
-/sbin/modprobe tun
-   start-stop-daemon --start --quiet --pidfile $PIDFILE --exec $DAEMON 
--test > /dev/null \
-   || return 1
-
-   # Check for runtime directory of nonvolatile data
-   if [ ! -d /var/lib/ggsn ]; then
-   mkdir /var/lib/ggsn
-   fi
-
-   # Check for GTP restart counter
-   if [ ! -f /var/lib/ggsn/gsn_restart ]; then
-   echo 0 > /var/lib/ggsn/gsn_restart
-   fi
-
-   start-stop-daemon --start --quiet --pidfile $PIDFILE --exec $DAEMON -- \
-   $DAEMON_ARGS \
-   || return 2
-   # Add code here, if necessary, that waits for the process to be ready
-   # to handle requests from services started subsequently which depend
-   # on this one.  As a last resort, sleep for some time.
-}
-
-#
-# Function that stops the daemon/service
-#
-do_stop()
-{
-   # Return
-   #   0 if daemon has been stopped
-   #   1 if daemon was already stopped
-   #   2 if daemon could not be stopped
-   #   other if a failure occurred
-   start-stop-daemon --stop --quiet --retry=TERM/30/KILL/5 --pidfile 
$PIDFILE --name $NAME
-   RETVAL="$?"
-   [ "$RETVAL" = 2 ] && return 2
-   # Wait for children to finish too if this is a daemon that forks
-   # and if the daemon is only ever run from this initscript.
-   # If the above conditions are not satisfied then add some other code
-   # that waits for the process to drop all resources that could be
-   # needed by services started subsequently.  A last resort is to
-   # sleep for some time.
-   start-stop-daemon --stop --quiet --oknodo --retry=0/30/KILL/5 --exec 
$DAEMON
-   [ "$?" = 2 ] && return 2
-   # Many daemons don't delete their pidfiles when they exit.
-   rm -f $PIDFILE
-   return "$RETVAL"
-}
-
-#
-# Function that sends a SIGHUP to the daemon/service
-#
-do_reload() {
-   #
-   # If the daemon can reload its configuration without
-   # restarting (for example, when it is sent a SIGHUP),
-   # then implement that here.
-   #
-   start-stop-daemon --stop --signal 1 --quiet --pidfile $PIDFILE --name 
$NAME
-   return 0
-}
-
-case "$1" in
-  start)
-#[ "$VERBOSE" != no ] && log_daemon_msg "Starting $DESC " "$NAME"
- 

Change in meta-telephony[laforge/nightly]: libosmo-sccp: handle systemd and cfg files through autotools

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10948 )

Change subject: libosmo-sccp: handle systemd and cfg files through autotools
..

libosmo-sccp: handle systemd and cfg files through autotools

Change-Id: I7bb69bdad7582e29b66f075db1305305a9ca648c
---
M recipes-osmocom/libosmo-sccp/libosmo-sccp.inc
1 file changed, 6 insertions(+), 9 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/libosmo-sccp/libosmo-sccp.inc 
b/recipes-osmocom/libosmo-sccp/libosmo-sccp.inc
index 60793e3..78dd525 100644
--- a/recipes-osmocom/libosmo-sccp/libosmo-sccp.inc
+++ b/recipes-osmocom/libosmo-sccp/libosmo-sccp.inc
@@ -3,12 +3,17 @@
 HOMEPAGE = "https://osmocom.org/projects/libosmo-sccp;
 LICENSE = "AGPLv3"

-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"

 LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"

 inherit autotools pkgconfig systemd

+PACKAGECONFIG ??= "\
+${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+"
+PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"
+
 # we require the tests to link to the static libosmo-sigtran library to
 # access symbols not starting with osmo_*
 EXTRA_OECONF_remove = "--disable-static"
@@ -17,14 +22,6 @@
 SYSTEMD_PACKAGES = "osmo-stp"
 SYSTEMD_SERVICE_osmo-stp = "osmo-stp.service"

-do_install_append() {
-   install -d ${D}${systemd_system_unitdir}/
-   install -d ${D}${sysconfdir}/osmocom/
-
-   install -m 0644 ${S}/doc/examples/osmo-stp.cfg 
${D}${sysconfdir}/osmocom/
-   install -m 0644 ${S}/contrib/systemd/osmo-stp.service 
${D}${systemd_system_unitdir}/
-}
-
 FILES_osmo-stp = " \
${bindir}/osmo-stp \
${sysconfdir}/osmocom/osmo-stp.cfg \

--
To view, visit https://gerrit.osmocom.org/10948
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: merged
Gerrit-Change-Id: I7bb69bdad7582e29b66f075db1305305a9ca648c
Gerrit-Change-Number: 10948
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in meta-telephony[laforge/nightly]: openbsc: Drop untested sysvinit support

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10958 )

Change subject: openbsc: Drop untested sysvinit support
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10958
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I864e4a61aed7933c46b80aa26598234faba43395
Gerrit-Change-Number: 10958
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 15 Sep 2018 08:02:18 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-ggsn: handle systemd and cfg files through autotools

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10952 )

Change subject: osmo-ggsn: handle systemd and cfg files through autotools
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10952
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c220c11f58793c644d750040c7fad347500bb8a
Gerrit-Change-Number: 10952
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 15 Sep 2018 08:01:28 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-msc: handle systemd and cfg files through autotools

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10955 )

Change subject: osmo-msc: handle systemd and cfg files through autotools
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10955
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ccddd158f88fdd5dbe8e9a36c62d515b973486a
Gerrit-Change-Number: 10955
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 15 Sep 2018 08:01:49 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-sgsn: handle systemd and cfg files through autotools

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10953 )

Change subject: osmo-sgsn: handle systemd and cfg files through autotools
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10953
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib84a3c8634db2282b2d3757ae7c044a196720852
Gerrit-Change-Number: 10953
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 15 Sep 2018 08:01:37 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-bsc: handle systemd and cfg files through autotools

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10956 )

Change subject: osmo-bsc: handle systemd and cfg files through autotools
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10956
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I752503f1ad7562ead50ec2bb7be49a958b9dc0f0
Gerrit-Change-Number: 10956
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 15 Sep 2018 08:01:56 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-hlr: handle systemd and cfg files through autotools

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10950 )

Change subject: osmo-hlr: handle systemd and cfg files through autotools
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10950
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e3725c6ffef9223015df8cf76b5d5c884a76fce
Gerrit-Change-Number: 10950
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 15 Sep 2018 08:01:08 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-mgw: handle systemd and cfg files through autotools

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10954 )

Change subject: osmo-mgw: handle systemd and cfg files through autotools
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10954
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab265207f534f5d2b5960b707081b06aa5d34d11
Gerrit-Change-Number: 10954
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 15 Sep 2018 08:01:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-ggsn: Drop untested sysvinit support

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10951 )

Change subject: osmo-ggsn: Drop untested sysvinit support
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10951
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I303ea210e14e0e6e9a18b1bb4c25d470924d80c6
Gerrit-Change-Number: 10951
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 15 Sep 2018 08:01:21 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-iuh: handle systemd and cfg files through autotools

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10949 )

Change subject: osmo-iuh: handle systemd and cfg files through autotools
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10949
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: If879153a32ae21ad63284382a420da534f30e6eb
Gerrit-Change-Number: 10949
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 15 Sep 2018 08:01:02 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: libosmo-sccp: handle systemd and cfg files through autotools

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10948 )

Change subject: libosmo-sccp: handle systemd and cfg files through autotools
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10948
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I7bb69bdad7582e29b66f075db1305305a9ca648c
Gerrit-Change-Number: 10948
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 15 Sep 2018 08:00:56 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Build failed in Jenkins: master-libosmocore » a2=default,a3=default,amd64,osmocom-master-debian9 #475

[jenkins]

See 


Changes:

[pma...@sysmocom.de] gsm0808: fix wrong codec defaults for OFR_AMR_WB

[pma...@sysmocom.de] gsm0808: add function to convert amr gsm0408 setings to 
gsm0808

--
[...truncated 519.47 KB...]
## -- ##
## libosmocore 0.12.0.57-2fd4 test suite. ##
## -- ##

Regression tests.

  1: a5  ok
  2: abisok
  3: ctrlok
  4: kasumi  ok
  5: bitsok
  6: bitvec  ok
  7: bitcomp ok
  8: bitfieldok
  9: convok
 10: conv_gsm0503ok
 11: coding  ok
 12: msgbok
 13: gea ok
 14: msgfile ok
 15: sms ok
 16: smscb   ok
 17: ussdok
 18: authok
 19: comp128 ok
 20: lapdok
 21: gsm0808 FAILED (testsuite.at:132)
 22: gsm0408 ok
 23: gprsok
 24: logging ok
 25: codec   ok
 26: codec_ecu_frok
 27: fr  ok
 28: loggingrb   ok
 29: strrb   ok
 30: vty ok
 31: gprs-bssgp  ok
 32: gprs-ns ok
 33: utils   ok
 34: stats   ok
 35: write_queue ok
 36: bssgp-fcok
 37: sim ok
 38: timer   ok
 39: clk_overrideok
 40: tlv ok
 41: gsupok
 42: fsm ok
 43: oap ok
 44: oap_client  ok
 45: socket  ok
 46: osmo-auc-genok
 47: endian  ok
 48: sercomm ok
 49: prbsok
 50: gsm23003ok

## - ##
## Test results. ##
## - ##

ERROR: All 50 tests were run,
1 failed unexpectedly.
## -- ##
## testsuite.log was created. ##
## -- ##

Please send `tests/testsuite.log' and all information you think might help:

   To: 
   Subject: [libosmocore 0.12.0.57-2fd4] testsuite: 21 failed

You may investigate any problem if you feel able to do so, in which
case the test suite provides a good starting point.  Its output may
be found below `tests/testsuite.dir'.

Makefile:1997: recipe for target 'check-local' failed
make[4]: *** [check-local] Error 1
make[4]: Leaving directory 
'
Makefile:1766: recipe for target 'check-am' failed
make[3]: *** [check-am] Error 2
make[3]: Leaving directory 
'
Makefile:1769: recipe for target 'check' failed
make[2]: *** [check] Error 2
make[2]: Leaving directory 
'
Makefile:614: recipe for target 'check-recursive' failed
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory 
'
Makefile:905: recipe for target 'check' failed
make: *** 

Change in libosmocore[master]: gsm0808: add function to convert amr gsm0408 setings to gsm0808

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10961 )

Change subject: gsm0808: add function to convert amr gsm0408 setings to gsm0808
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10961
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e656731b16621736c7a2f4e64d9ce63b1064e98
Gerrit-Change-Number: 10961
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sat, 15 Sep 2018 07:57:19 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: gsm0808: fix wrong codec defaults for OFR_AMR_WB

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10960 )

Change subject: gsm0808: fix wrong codec defaults for OFR_AMR_WB
..

gsm0808: fix wrong codec defaults for OFR_AMR_WB

3GPP TS 48.008 chapter 3.2.2.103 states that the configuration bits of
OFR_AMR_WB are coded as follows:

"S0, S2, S4 indicates the supported Codec Configurations. S1, S3, S5, S6,
S7 are reserved and coded with zeroes."

The current default setting of 0x3F violates this requirement. Lets set
the "forbidden" settings zu zero and keep only the allowed ones.

Change-Id: I4a481def59e9c98cfdcafc2b80c0ac7df0c14130
---
M include/osmocom/gsm/protocol/gsm_08_08.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h 
b/include/osmocom/gsm/protocol/gsm_08_08.h
index 69007b5..9433817 100644
--- a/include/osmocom/gsm/protocol/gsm_08_08.h
+++ b/include/osmocom/gsm/protocol/gsm_08_08.h
@@ -499,7 +499,7 @@
GSM0808_SC_CFG_DEFAULT_HR_AMR   = 0x073f,
GSM0808_SC_CFG_DEFAULT_OHR_AMR  = 0x57ff,
GSM0808_SC_CFG_DEFAULT_FR_AMR_WB= 0x01,
-   GSM0808_SC_CFG_DEFAULT_OFR_AMR_WB   = 0x3f,
+   GSM0808_SC_CFG_DEFAULT_OFR_AMR_WB   = 0x15,
GSM0808_SC_CFG_DEFAULT_OHR_AMR_WB   = 0x01,
 };


--
To view, visit https://gerrit.osmocom.org/10960
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a481def59e9c98cfdcafc2b80c0ac7df0c14130
Gerrit-Change-Number: 10960
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmocore[master]: gsm0808: add function to convert amr gsm0408 setings to gsm0808

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10961 )

Change subject: gsm0808: add function to convert amr gsm0408 setings to gsm0808
..

gsm0808: add function to convert amr gsm0408 setings to gsm0808

Add a function to convert struct gsm48_multi_rate_conf, which holds the
codec settings for AMR, to S0-S15 bit representation as defined in
3GPP TS 48.008 3.2.2.49

Change-Id: I4e656731b16621736c7a2f4e64d9ce63b1064e98
Related: OS#3548
---
M include/osmocom/gsm/gsm0808_utils.h
M include/osmocom/gsm/protocol/gsm_08_08.h
M src/gsm/gsm0808_utils.c
M src/gsm/libosmogsm.map
M tests/gsm0808/gsm0808_test.c
M tests/gsm0808/gsm0808_test.ok
6 files changed, 480 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocom/gsm/gsm0808_utils.h 
b/include/osmocom/gsm/gsm0808_utils.h
index 242bce9..0a7429e 100644
--- a/include/osmocom/gsm/gsm0808_utils.h
+++ b/include/osmocom/gsm/gsm0808_utils.h
@@ -104,6 +104,7 @@
 int gsm0808_chan_type_to_speech_codec(uint8_t perm_spch);
 int gsm0808_speech_codec_from_chan_type(struct gsm0808_speech_codec *sc,
uint8_t perm_spch);
+uint16_t gsm0808_sc_cfg_from_gsm48_mr_cfg(struct gsm48_multi_rate_conf *cfg, 
bool fr);

 /*! Return 3GPP TS 48.008 3.2.2.49 Current Channel Type 1 from enum 
gsm_chan_t. */
 static inline uint8_t gsm0808_current_channel_type_1(enum gsm_chan_t type)
diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h 
b/include/osmocom/gsm/protocol/gsm_08_08.h
index 9433817..8431ace 100644
--- a/include/osmocom/gsm/protocol/gsm_08_08.h
+++ b/include/osmocom/gsm/protocol/gsm_08_08.h
@@ -503,6 +503,20 @@
GSM0808_SC_CFG_DEFAULT_OHR_AMR_WB   = 0x01,
 };

+/*! Default speech codec configurations broken down by reate.
+ *  See also: 3GPP TS 28.062, Table 7.11.3.1.3-2: Preferred Configurations for
+ *  the Adaptive Multi-Rate Codec Types. */
+enum gsm0808_speech_codec_rate_defaults {
+   GSM0808_SC_CFG_DEFAULT_AMR_4_75 = 0xff03,
+   GSM0808_SC_CFG_DEFAULT_AMR_5_15 = 0x,
+   GSM0808_SC_CFG_DEFAULT_AMR_5_90 = 0xff06,
+   GSM0808_SC_CFG_DEFAULT_AMR_6_70 = 0x3e08,
+   GSM0808_SC_CFG_DEFAULT_AMR_7_40 = 0x0c12,
+   GSM0808_SC_CFG_DEFAULT_AMR_7_95 = 0xc020,
+   GSM0808_SC_CFG_DEFAULT_AMR_10_2 = 0x3040,
+   GSM0808_SC_CFG_DEFAULT_AMR_12_2 = 0xc082
+};
+
 /* 3GPP TS 48.008 3.2.2.103 Speech Codec List */
 #define SPEECH_CODEC_MAXLEN 255
 struct gsm0808_speech_codec_list {
diff --git a/src/gsm/gsm0808_utils.c b/src/gsm/gsm0808_utils.c
index 73f0234..4b2a5f5 100644
--- a/src/gsm/gsm0808_utils.c
+++ b/src/gsm/gsm0808_utils.c
@@ -1161,6 +1161,49 @@
return 0;
 }

+/*! Determine a set of AMR speech codec configuration bits (S0-S15) from a
+ *  given GSM 04.08 AMR configuration struct.
+ *  \param[in] cfg AMR configuration in GSM 04.08 format.
+ *  \param[in] hint if the resulting configuration shall be used with a FR or 
HR TCH.
+ *  \returns configuration bits (S0-S15) */
+uint16_t gsm0808_sc_cfg_from_gsm48_mr_cfg(struct gsm48_multi_rate_conf *cfg,
+ bool fr)
+{
+   uint16_t s15_s0 = 0;
+
+   /* Check each rate bit in the AMR multirate configuration and pick the
+* matching default configuration as specified in 3GPP TS 28.062,
+* Table 7.11.3.1.3-2. */
+   if (cfg->m4_75)
+   s15_s0 |= GSM0808_SC_CFG_DEFAULT_AMR_4_75;
+   if (cfg->m5_15)
+   s15_s0 |= GSM0808_SC_CFG_DEFAULT_AMR_5_15;
+   if (cfg->m5_90)
+   s15_s0 |= GSM0808_SC_CFG_DEFAULT_AMR_5_90;
+   if (cfg->m6_70)
+   s15_s0 |= GSM0808_SC_CFG_DEFAULT_AMR_6_70;
+   if (cfg->m7_40)
+   s15_s0 |= GSM0808_SC_CFG_DEFAULT_AMR_7_40;
+   if (cfg->m7_95)
+   s15_s0 |= GSM0808_SC_CFG_DEFAULT_AMR_7_95;
+   if (cfg->m10_2)
+   s15_s0 |= GSM0808_SC_CFG_DEFAULT_AMR_10_2;
+   if (cfg->m12_2)
+   s15_s0 |= GSM0808_SC_CFG_DEFAULT_AMR_12_2;
+
+   /* Note: 3GPP TS 48.008, chapter 3GPP TS 48.008 states that for AMR
+* some of the configuration bits must be coded as zeros. The applied
+* bitmask matches the default codec settings. See also the definition
+* of enum gsm0808_speech_codec_defaults in gsm_08_08.h and
+* 3GPP TS 28.062, Table 7.11.3.1.3-2. */
+   if (fr)
+   s15_s0 &= GSM0808_SC_CFG_DEFAULT_FR_AMR;
+   else
+   s15_s0 &= GSM0808_SC_CFG_DEFAULT_HR_AMR;
+
+   return s15_s0;
+}
+
 /*! Print a human readable name of the cell identifier to the char buffer.
  * This is useful both for struct gsm0808_cell_id and struct 
gsm0808_cell_id_list2.
  * See also gsm0808_cell_id_name() and gsm0808_cell_id_list_name().
diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map
index 0c40c88..3d08232 100644
--- 

Change in osmo-bsc[master]: codec_pref: fix missing breaks in switch-case statement

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10964 )

Change subject: codec_pref: fix missing breaks in switch-case statement
..

codec_pref: fix missing breaks in switch-case statement

In function test_codec_support_bts() the switch case statement lacks
break; statements for some cases. This may lead into messed up codec
decisions.

- Add missing break statements

Change-Id: Ib5400a0a0a8a39fa714bd087df345160bed5cc61
---
M src/osmo-bsc/codec_pref.c
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/codec_pref.c b/src/osmo-bsc/codec_pref.c
index 96c2c38..924f77f 100644
--- a/src/osmo-bsc/codec_pref.c
+++ b/src/osmo-bsc/codec_pref.c
@@ -148,15 +148,19 @@
case GSM0808_PERM_FR2:
if (bts_codec->efr)
return true;
+   break;
case GSM0808_PERM_FR3:
if (bts_codec->amr)
return true;
+   break;
case GSM0808_PERM_HR1:
if (bts_codec->hr)
return true;
+   break;
case GSM0808_PERM_HR3:
if (bts_codec->amr)
return true;
+   break;
default:
return false;
}

--
To view, visit https://gerrit.osmocom.org/10964
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5400a0a0a8a39fa714bd087df345160bed5cc61
Gerrit-Change-Number: 10964
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmocore[master]: gsm0808: fix wrong codec defaults for OFR_AMR_WB

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10960 )

Change subject: gsm0808: fix wrong codec defaults for OFR_AMR_WB
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10960
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a481def59e9c98cfdcafc2b80c0ac7df0c14130
Gerrit-Change-Number: 10960
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sat, 15 Sep 2018 07:56:36 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: codec_pref: add AMR configuration bits to make_scl_config() in unit-test

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10963 )

Change subject: codec_pref: add AMR configuration bits to make_scl_config() in 
unit-test
..

codec_pref: add AMR configuration bits to make_scl_config() in unit-test

The the function make_scl_config() is used to generate realistically
looking speech codec lists to perform the unit tests for codec_pref.c.
This function does not yet populate the S0-S15 bits for AMR codecs. Lets
make sure that at least the default configuration is populated here.

Change-Id: I534239416c038ea856c128659f314aa521f85c15
---
M tests/codec_pref/codec_pref_test.c
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/codec_pref/codec_pref_test.c 
b/tests/codec_pref/codec_pref_test.c
index b0b9f5e..efc77f6 100644
--- a/tests/codec_pref/codec_pref_test.c
+++ b/tests/codec_pref/codec_pref_test.c
@@ -78,11 +78,13 @@
case 3:
/* FR3 only */
scl->codec[0].type = GSM0808_SCT_FR3;
+   scl->codec[0].cfg = GSM0808_SC_CFG_DEFAULT_FR_AMR;
scl->len = 1;
break;
case 4:
/* HR3 only */
scl->codec[0].type = GSM0808_SCT_HR3;
+   scl->codec[0].cfg = GSM0808_SC_CFG_DEFAULT_HR_AMR;
scl->len = 1;
break;
case 5:
@@ -102,7 +104,9 @@
/* FR1, FR3 and HR3 */
scl->codec[0].type = GSM0808_SCT_FR1;
scl->codec[1].type = GSM0808_SCT_FR3;
+   scl->codec[1].cfg = GSM0808_SC_CFG_DEFAULT_FR_AMR;
scl->codec[2].type = GSM0808_SCT_HR3;
+   scl->codec[2].cfg = GSM0808_SC_CFG_DEFAULT_HR_AMR;
scl->len = 3;
break;
case 8:
@@ -110,8 +114,10 @@
scl->codec[0].type = GSM0808_SCT_FR1;
scl->codec[1].type = GSM0808_SCT_FR2;
scl->codec[2].type = GSM0808_SCT_FR3;
+   scl->codec[2].cfg = GSM0808_SC_CFG_DEFAULT_FR_AMR;
scl->codec[3].type = GSM0808_SCT_HR1;
scl->codec[4].type = GSM0808_SCT_HR3;
+   scl->codec[4].cfg = GSM0808_SC_CFG_DEFAULT_HR_AMR;
scl->len = 5;
break;
}

--
To view, visit https://gerrit.osmocom.org/10963
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I534239416c038ea856c128659f314aa521f85c15
Gerrit-Change-Number: 10963
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bsc[master]: codec_pref: fix typo in comment

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10962 )

Change subject: codec_pref: fix typo in comment
..

codec_pref: fix typo in comment

Change-Id: Ie4ea8179395cd331dad4b62227debb026b5b008c
---
M src/osmo-bsc/codec_pref.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bsc/codec_pref.c b/src/osmo-bsc/codec_pref.c
index 2a9be6e..96c2c38 100644
--- a/src/osmo-bsc/codec_pref.c
+++ b/src/osmo-bsc/codec_pref.c
@@ -167,7 +167,7 @@
 /*! Match the codec preferences from local config with a received codec 
preferences IEs received from the
  * MSC and the BTS' codec configuration.
  *  \param[out] chan_mode GSM 04.08 channel mode.
- *  \param[out] full_rate true iff full-rate.
+ *  \param[out] full_rate true if full-rate.
  *  \param[in] ct GSM 08.08 channel type received from MSC.
  *  \param[in] scl GSM 08.08 speech codec list received from MSC (optional).
  *  \param[in] audio_support List of allowed codecs as from local config.

--
To view, visit https://gerrit.osmocom.org/10962
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4ea8179395cd331dad4b62227debb026b5b008c
Gerrit-Change-Number: 10962
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bsc[master]: codec_pref: add AMR configuration bits to make_scl_config() in unit-test

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10963 )

Change subject: codec_pref: add AMR configuration bits to make_scl_config() in 
unit-test
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10963
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I534239416c038ea856c128659f314aa521f85c15
Gerrit-Change-Number: 10963
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sat, 15 Sep 2018 07:55:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes