Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/i586

2018-09-20 Thread OBS Notification 
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_18.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  162s] No package 'libpcsclite' found
[  162s] simtrace2-remsim.o: In function `main':
[  162s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  162s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  162s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  162s] apdu_dispatch.o: In function `apdu_segment_in':
[  162s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  162s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  162s] collect2: error: ld returned 1 exit status
[  162s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  162s] make[2]: *** [simtrace2-remsim] Error 1
[  162s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  162s] Makefile:20: recipe for target 'utils' failed
[  162s] make[1]: *** [utils] Error 2
[  162s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  162s] dh_auto_build: make -j1 returned exit code 2
[  162s] debian/rules:4: recipe for target 'build' failed
[  162s] make: *** [build] Error 2
[  162s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  162s] 
[  162s] lamb03 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 20 
20:18:10 UTC 2018.
[  162s] 
[  162s] ### VM INTERACTION START ###
[  165s] [  154.451104] sysrq: SysRq : Power Off
[  165s] [  154.457774] reboot: Power down
[  165s] ### VM INTERACTION END ###
[  165s] 
[  165s] lamb03 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 20 
20:18:14 UTC 2018.
[  165s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_17.10/i586

2018-09-20 Thread OBS Notification 
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_17.10/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_17.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  137s] No package 'libpcsclite' found
[  137s] simtrace2-remsim.o: In function `main':
[  137s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  137s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  137s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  137s] apdu_dispatch.o: In function `apdu_segment_in':
[  137s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  137s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  137s] collect2: error: ld returned 1 exit status
[  137s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  137s] make[2]: *** [simtrace2-remsim] Error 1
[  137s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  137s] Makefile:20: recipe for target 'utils' failed
[  137s] make[1]: *** [utils] Error 2
[  137s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  137s] dh_auto_build: make -j1 returned exit code 2
[  137s] debian/rules:4: recipe for target 'build' failed
[  137s] make: *** [build] Error 2
[  137s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  137s] 
[  137s] lamb04 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 20 
20:17:16 UTC 2018.
[  137s] 
[  137s] ### VM INTERACTION START ###
[  141s] [  130.642580] sysrq: SysRq : Power Off
[  141s] [  130.650887] reboot: Power down
[  141s] ### VM INTERACTION END ###
[  141s] 
[  141s] lamb04 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 20 
20:17:20 UTC 2018.
[  141s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/i586

2018-09-20 Thread OBS Notification 
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/i586

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  145s] No package 'libpcsclite' found
[  145s] simtrace2-remsim.o: In function `main':
[  145s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  145s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  145s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  145s] apdu_dispatch.o: In function `apdu_segment_in':
[  145s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  145s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  145s] collect2: error: ld returned 1 exit status
[  145s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  145s] make[2]: *** [simtrace2-remsim] Error 1
[  145s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  145s] Makefile:20: recipe for target 'utils' failed
[  145s] make[1]: *** [utils] Error 2
[  145s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  145s] dh_auto_build: make -j1 returned exit code 2
[  145s] debian/rules:4: recipe for target 'build' failed
[  145s] make: *** [build] Error 2
[  145s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  145s] 
[  145s] lamb14 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 20 
20:16:01 UTC 2018.
[  145s] 
[  145s] ### VM INTERACTION START ###
[  148s] [  136.391398] sysrq: SysRq : Power Off
[  148s] [  136.406993] reboot: Power down
[  148s] ### VM INTERACTION END ###
[  148s] 
[  148s] lamb14 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 20 
20:16:05 UTC 2018.
[  148s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/x86_64

2018-09-20 Thread OBS Notification 
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  104s] No package 'libpcsclite' found
[  104s] simtrace2-remsim.o: In function `main':
[  104s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  104s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  104s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  104s] apdu_dispatch.o: In function `apdu_segment_in':
[  104s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  104s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  104s] collect2: error: ld returned 1 exit status
[  104s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  104s] make[2]: *** [simtrace2-remsim] Error 1
[  104s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  104s] Makefile:20: recipe for target 'utils' failed
[  104s] make[1]: *** [utils] Error 2
[  104s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  104s] dh_auto_build: make -j1 returned exit code 2
[  104s] debian/rules:4: recipe for target 'build' failed
[  104s] make: *** [build] Error 2
[  104s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  104s] 
[  104s] sheep82 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 20 
20:15:56 UTC 2018.
[  104s] 
[  104s] ### VM INTERACTION START ###
[  107s] [   99.184467] sysrq: SysRq : Power Off
[  107s] [   99.188674] reboot: Power down
[  107s] ### VM INTERACTION END ###
[  107s] 
[  107s] sheep82 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 20 
20:15:59 UTC 2018.
[  107s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_16.04/i586

2018-09-20 Thread OBS Notification 
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_16.04/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  201s] No package 'libpcsclite' found
[  201s] simtrace2-remsim.o: In function `main':
[  201s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  201s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  201s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  201s] apdu_dispatch.o: In function `apdu_segment_in':
[  201s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  201s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  201s] collect2: error: ld returned 1 exit status
[  201s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  201s] make[2]: *** [simtrace2-remsim] Error 1
[  201s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  201s] Makefile:20: recipe for target 'utils' failed
[  201s] make[1]: *** [utils] Error 2
[  201s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  201s] dh_auto_build: make -j1 returned exit code 2
[  201s] debian/rules:4: recipe for target 'build' failed
[  201s] make: *** [build] Error 2
[  201s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  201s] 
[  201s] lamb22 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 20 
20:13:53 UTC 2018.
[  201s] 
[  201s] ### VM INTERACTION START ###
[  205s] [  192.628549] sysrq: SysRq : Power Off
[  205s] [  192.636057] reboot: Power down
[  205s] ### VM INTERACTION END ###
[  205s] 
[  205s] lamb22 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 20 
20:13:58 UTC 2018.
[  205s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_17.10/x86_64

2018-09-20 Thread OBS Notification 
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  138s] No package 'libpcsclite' found
[  139s] simtrace2-remsim.o: In function `main':
[  139s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  139s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  139s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  139s] apdu_dispatch.o: In function `apdu_segment_in':
[  139s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  139s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  139s] collect2: error: ld returned 1 exit status
[  139s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  139s] make[2]: *** [simtrace2-remsim] Error 1
[  139s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  139s] Makefile:20: recipe for target 'utils' failed
[  139s] make[1]: *** [utils] Error 2
[  139s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  139s] dh_auto_build: make -j1 returned exit code 2
[  139s] debian/rules:4: recipe for target 'build' failed
[  139s] make: *** [build] Error 2
[  139s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  139s] 
[  139s] lamb17 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 20 
20:14:17 UTC 2018.
[  139s] 
[  139s] ### VM INTERACTION START ###
[  142s] [  131.902753] sysrq: SysRq : Power Off
[  142s] [  131.909320] reboot: Power down
[  142s] ### VM INTERACTION END ###
[  142s] 
[  142s] lamb17 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 20 
20:14:21 UTC 2018.
[  142s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/x86_64

2018-09-20 Thread OBS Notification 
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_18.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  172s] No package 'libpcsclite' found
[  172s] simtrace2-remsim.o: In function `main':
[  172s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  172s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  172s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  172s] apdu_dispatch.o: In function `apdu_segment_in':
[  172s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  172s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  172s] collect2: error: ld returned 1 exit status
[  172s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  172s] make[2]: *** [simtrace2-remsim] Error 1
[  172s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  172s] Makefile:20: recipe for target 'utils' failed
[  172s] make[1]: *** [utils] Error 2
[  172s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  172s] dh_auto_build: make -j1 returned exit code 2
[  172s] debian/rules:4: recipe for target 'build' failed
[  172s] make: *** [build] Error 2
[  172s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  172s] 
[  172s] lamb21 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 20 
20:13:26 UTC 2018.
[  172s] 
[  172s] ### VM INTERACTION START ###
[  175s] [  163.737906] sysrq: SysRq : Power Off
[  175s] [  163.743734] reboot: Power down
[  175s] ### VM INTERACTION END ###
[  175s] 
[  175s] lamb21 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 20 
20:13:30 UTC 2018.
[  175s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_16.04/x86_64

2018-09-20 Thread OBS Notification 
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  195s] No package 'libpcsclite' found
[  195s] simtrace2-remsim.o: In function `main':
[  195s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  195s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  195s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  195s] apdu_dispatch.o: In function `apdu_segment_in':
[  195s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  195s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  195s] collect2: error: ld returned 1 exit status
[  195s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  195s] make[2]: *** [simtrace2-remsim] Error 1
[  195s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  195s] Makefile:20: recipe for target 'utils' failed
[  195s] make[1]: *** [utils] Error 2
[  195s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  195s] dh_auto_build: make -j1 returned exit code 2
[  195s] debian/rules:4: recipe for target 'build' failed
[  195s] make: *** [build] Error 2
[  195s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  195s] 
[  195s] cloud104 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 20 
20:07:38 UTC 2018.
[  195s] 
[  195s] ### VM INTERACTION START ###
[  198s] [  159.712221] sysrq: SysRq : Power Off
[  198s] [  159.716557] reboot: Power down
[  200s] ### VM INTERACTION END ###
[  200s] 
[  200s] cloud104 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 20 
20:07:44 UTC 2018.
[  200s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/armv7l

2018-09-20 Thread OBS Notification 
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/armv7l

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  249s] No package 'libpcsclite' found
[  249s] simtrace2-remsim.o: In function `main':
[  249s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  249s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  249s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:772: undefined 
reference to `osim_uicc_sim_cic_profile'
[  249s] apdu_dispatch.o: In function `apdu_segment_in':
[  249s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  249s] /usr/src/packages/BUILD/host/apdu_dispatch.c:173: undefined reference 
to `osim_uicc_sim_cic_profile'
[  249s] collect2: error: ld returned 1 exit status
[  249s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  249s] make[2]: *** [simtrace2-remsim] Error 1
[  249s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  249s] Makefile:20: recipe for target 'utils' failed
[  249s] make[1]: *** [utils] Error 2
[  249s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  249s] dh_auto_build: make -j1 returned exit code 2
[  249s] debian/rules:4: recipe for target 'build' failed
[  249s] make: *** [build] Error 2
[  249s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  249s] 
[  249s] armbuild01 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 20 
20:03:07 UTC 2018.
[  249s] 
[  249s] ### VM INTERACTION START ###
[  252s] [  222.252625] SysRq : Power Off
[  252s] [  222.253919] reboot: Power down
[  252s] ### VM INTERACTION END ###
[  252s] 
[  252s] armbuild01 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 20 
20:03:10 UTC 2018.
[  252s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-pcu[master]: check for overlong unix socket paths

2018-09-20 Thread Vadim Yanitskiy 
Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11048 )

Change subject: check for overlong unix socket paths
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11048/1/src/osmobts_sock.cpp
File src/osmobts_sock.cpp:

https://gerrit.osmocom.org/#/c/11048/1/src/osmobts_sock.cpp@268
PS1, Line 268:  if (osmo_strlcpy(local.sun_path, bts->pcu_sock_path, 
sizeof(local.sun_path)) >= sizeof(local.sun_path)) {
I would prefer to see:

  rc = osmo_strlcpy(...);
  if (rc) { ... }

here instead of this long construction.



--
To view, visit https://gerrit.osmocom.org/11048
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I825190cbb34d052b797e9fb5208884d6f5992839
Gerrit-Change-Number: 11048
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 20 Sep 2018 17:25:07 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-trx[master]: Use pthread_setname_np to name threads

2018-09-20 Thread Vadim Yanitskiy 
Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11047 )

Change subject: Use pthread_setname_np to name threads
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11047
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84711739c3e224cb383fd12b6db933785b28209e
Gerrit-Change-Number: 11047
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 20 Sep 2018 17:18:37 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: osmo-depcheck: script to verify PKG_CHECK_MODULES

2018-09-20 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10932 )

Change subject: osmo-depcheck: script to verify PKG_CHECK_MODULES
..


Patch Set 5:

I did some tests and I lack some little improvements. See my comments in 
https://osmocom.org/issues/2642#note-26

They can be done in separate commits though.


--
To view, visit https://gerrit.osmocom.org/10932
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f495dbe030775f66ac125e60ded95c5d7660b65
Gerrit-Change-Number: 10932
Gerrit-PatchSet: 5
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 20 Sep 2018 17:03:05 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-pcu[master]: check for overlong unix socket paths

2018-09-20 Thread Stefan Sperling 
Stefan Sperling has uploaded this change for review. ( 
https://gerrit.osmocom.org/11048


Change subject: check for overlong unix socket paths
..

check for overlong unix socket paths

In pcu_l1if_open(), use osmo_strlcpy() instead of strncpy() and check for
overflow. This catches overlong and non-NUL-terminated socket paths.

Change-Id: I825190cbb34d052b797e9fb5208884d6f5992839
Related: OS#2673
---
M src/osmobts_sock.cpp
1 file changed, 5 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/48/11048/1

diff --git a/src/osmobts_sock.cpp b/src/osmobts_sock.cpp
index 477521d..6b49347 100644
--- a/src/osmobts_sock.cpp
+++ b/src/osmobts_sock.cpp
@@ -265,8 +265,11 @@
}

local.sun_family = AF_UNIX;
-   strncpy(local.sun_path, bts->pcu_sock_path, sizeof(local.sun_path));
-   local.sun_path[sizeof(local.sun_path) - 1] = '\0';
+   if (osmo_strlcpy(local.sun_path, bts->pcu_sock_path, 
sizeof(local.sun_path)) >= sizeof(local.sun_path)) {
+   LOGP(DLGLOBAL, LOGL_ERROR, "Socket path exceeds maximum length 
of %zd bytes: %s\n",
+sizeof(local.sun_path), bts->pcu_sock_path);
+   return -ENOSPC;
+   }

/* we use the same magic that X11 uses in Xtranssock.c for
 * calculating the proper length of the sockaddr */

--
To view, visit https://gerrit.osmocom.org/11048
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I825190cbb34d052b797e9fb5208884d6f5992839
Gerrit-Change-Number: 11048
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling

Change in osmo-trx[master]: Use pthread_setname_np to name threads

2018-09-20 Thread Pau Espin Pedrol 
Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11047


Change subject: Use pthread_setname_np to name threads
..

Use pthread_setname_np to name threads

osmo-trx can start a considerable amount of threads that can make
debugging it challenging at least. By using phtread_setname_np, the
system sets a meaningful name to the thread which can be seen while
debugging with gdb or by printing /proc/$pid/task/$tid/comm.

Now we also log system TID when setting the name so we can identify
different tasks in /proc even if pthread_setname_np fails.

Change-Id: I84711739c3e224cb383fd12b6db933785b28209e
---
M CommonLibs/Threads.cpp
M CommonLibs/Threads.h
M Transceiver52M/Transceiver.cpp
M Transceiver52M/device/uhd/UHDDevice.cpp
M Transceiver52M/radioInterface.cpp
M tests/CommonLibs/Makefile.am
6 files changed, 43 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/47/11047/1

diff --git a/CommonLibs/Threads.cpp b/CommonLibs/Threads.cpp
index de6520b..2988e12 100644
--- a/CommonLibs/Threads.cpp
+++ b/CommonLibs/Threads.cpp
@@ -24,11 +24,17 @@
 */


-
-
+#include 
+#include 

 #include "Threads.h"
 #include "Timeval.h"
+#include "Logger.h"
+
+#ifndef gettid
+#include 
+#define gettid() syscall(SYS_gettid)
+#endif


 using namespace std;
@@ -102,6 +108,19 @@
pthread_cond_timedwait(&mSignal,&wMutex.mMutex,&waitTime);
 }

+void set_selfthread_name(const char *name)
+{
+   pthread_t selfid = pthread_self();
+   pid_t tid = gettid();
+   if (pthread_setname_np(selfid, name) == 0) {
+   LOG(INFO) << "Thread "<< selfid << " (task " << tid << ") set 
name: " << name;
+   } else {
+   char buf[256];
+   int err = errno;
+   char* err_str = strerror_r(err, buf, sizeof(buf));
+   LOG(NOTICE) << "Thread "<< selfid << " (task " << tid << ") set 
name \"" << name << "\" failed: (" << err << ") " << err_str;
+   }
+}

 void Thread::start(void *(*task)(void*), void *arg)
 {
diff --git a/CommonLibs/Threads.h b/CommonLibs/Threads.h
index 47c7275..857c5d9 100644
--- a/CommonLibs/Threads.h
+++ b/CommonLibs/Threads.h
@@ -141,6 +141,8 @@
 #define START_THREAD(thread,function,argument) \
thread.start((void *(*)(void*))function, (void*)argument);

+void set_selfthread_name(const char *name);
+
 /** A C++ wrapper for pthread threads.  */
 class Thread {

diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp
index cdfd79d..076db3e 100644
--- a/Transceiver52M/Transceiver.cpp
+++ b/Transceiver52M/Transceiver.cpp
@@ -1044,11 +1044,15 @@

 void *RxUpperLoopAdapter(TransceiverChannel *chan)
 {
+  char thread_name[16];
   Transceiver *trx = chan->trx;
   size_t num = chan->num;

   delete chan;

+  snprintf(thread_name, 16, "RxUpper%zu", num);
+  set_selfthread_name(thread_name);
+
   trx->setPriority(0.42);

   while (1) {
@@ -1060,6 +1064,8 @@

 void *RxLowerLoopAdapter(Transceiver *transceiver)
 {
+  set_selfthread_name("RxLower");
+
   transceiver->setPriority(0.45);

   while (1) {
@@ -1071,6 +1077,8 @@

 void *TxLowerLoopAdapter(Transceiver *transceiver)
 {
+  set_selfthread_name("TxLower");
+
   transceiver->setPriority(0.44);

   while (1) {
@@ -1082,11 +1090,15 @@

 void *ControlServiceLoopAdapter(TransceiverChannel *chan)
 {
+  char thread_name[16];
   Transceiver *trx = chan->trx;
   size_t num = chan->num;

   delete chan;

+  snprintf(thread_name, 16, "CtrlService%zu", num);
+  set_selfthread_name(thread_name);
+
   while (1) {
 trx->driveControl(num);
 pthread_testcancel();
@@ -1096,11 +1108,15 @@

 void *TxUpperLoopAdapter(TransceiverChannel *chan)
 {
+  char thread_name[16];
   Transceiver *trx = chan->trx;
   size_t num = chan->num;

   delete chan;

+  snprintf(thread_name, 16, "TxUpper%zu", num);
+  set_selfthread_name(thread_name);
+
   trx->setPriority(0.40);

   while (1) {
diff --git a/Transceiver52M/device/uhd/UHDDevice.cpp 
b/Transceiver52M/device/uhd/UHDDevice.cpp
index b7109a4..c30f3a7 100644
--- a/Transceiver52M/device/uhd/UHDDevice.cpp
+++ b/Transceiver52M/device/uhd/UHDDevice.cpp
@@ -322,6 +322,7 @@

 void *async_event_loop(uhd_device *dev)
 {
+   set_selfthread_name("UHDAsyncEvent");
dev->setPriority(0.43);

while (1) {
diff --git a/Transceiver52M/radioInterface.cpp 
b/Transceiver52M/radioInterface.cpp
index 7d6a03b..0f949d7 100644
--- a/Transceiver52M/radioInterface.cpp
+++ b/Transceiver52M/radioInterface.cpp
@@ -148,6 +148,7 @@
 /** synchronization thread loop */
 void *AlignRadioServiceLoopAdapter(RadioInterface *radioInterface)
 {
+  set_selfthread_name("AlignRadio");
   while (1) {
 sleep(60);
 radioInterface->alignRadio();
diff --git a/tests/CommonLibs/Makefile.am b/tests/CommonLibs/Makefile.am
index 4543c72..2a9a021 100644
--- a/tests/CommonLibs/Makefile.am
+++ b/tests/CommonLibs/Makefile.am
@@ -28,11 +28,11 @@

 I

Change in osmo-bsc[master]: check for overlong unix socket paths

2018-09-20 Thread Stefan Sperling 
Stefan Sperling has uploaded this change for review. ( 
https://gerrit.osmocom.org/11046


Change subject: check for overlong unix socket paths
..

check for overlong unix socket paths

In rf_create_socket(), check the result of osmo_strlcpy().
This catches overlong and non-NUL-terminated socket paths.

Change-Id: I4b9ff9146068bf7f53d67c577454f32c02361b86
Related: OS#2673
---
M src/osmo-bsc/bsc_rf_ctrl.c
1 file changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/46/11046/1

diff --git a/src/osmo-bsc/bsc_rf_ctrl.c b/src/osmo-bsc/bsc_rf_ctrl.c
index f4a21b5..ac87fb9 100644
--- a/src/osmo-bsc/bsc_rf_ctrl.c
+++ b/src/osmo-bsc/bsc_rf_ctrl.c
@@ -450,8 +450,12 @@
}

local.sun_family = AF_UNIX;
-   osmo_strlcpy(local.sun_path, path, sizeof(local.sun_path));
unlink(local.sun_path);
+   if (osmo_strlcpy(local.sun_path, path, sizeof(local.sun_path)) >= 
sizeof(local.sun_path)) {
+   LOGP(DLINP, LOGL_ERROR, "Socket path exceeds maximum length of 
%zd bytes: %s\n",
+sizeof(local.sun_path), path);
+   return -1;
+   }

/* we use the same magic that X11 uses in Xtranssock.c for
 * calculating the proper length of the sockaddr */

--
To view, visit https://gerrit.osmocom.org/11046
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b9ff9146068bf7f53d67c577454f32c02361b86
Gerrit-Change-Number: 11046
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling

Change in libosmo-abis[master]: ensure unix socket paths are NUL-terminated for bind/connect

2018-09-20 Thread Stefan Sperling 
Stefan Sperling has uploaded this change for review. ( 
https://gerrit.osmocom.org/11045


Change subject: ensure unix socket paths are NUL-terminated for bind/connect
..

ensure unix socket paths are NUL-terminated for bind/connect

The unix(7) man page recommends that sun_path is NUL-terminated
when struct sockaddr_un is passed to a bind() or connect() call.
Non-NUL-terminated paths only need to be dealt with at the
receiving end of a UNIX domain socket.

Commit b24efa5 erroneously assumed otherwise.

Change-Id: I9beecfa500db75cb679b1edcc352c893bf098b13
Fixes: b24efa551dc91e177c5cb8da674e9f8432d52dc9
Related: OS#2673
---
M src/e1_input_vty.c
M src/input/unixsocket.c
2 files changed, 15 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/45/11045/1

diff --git a/src/e1_input_vty.c b/src/e1_input_vty.c
index 653c573..d81c859 100644
--- a/src/e1_input_vty.c
+++ b/src/e1_input_vty.c
@@ -101,10 +101,10 @@
int e1_nr = atoi(argv[0]);
struct sockaddr_un sun;

-   /* Don't exceed the maximum unix socket path length. See the unix(7) 
man page.*/
-   if (strlen(argv[1]) > sizeof(sun.sun_path)) {
+   /* Don't exceed the maximum unix socket path length, including a NUL 
byte. See the unix(7) man page.*/
+   if (strlen(argv[1]) > sizeof(sun.sun_path) - 1) {
vty_out(vty, "%% Socket path length exceeds %zd bytes: '%s'%s",
-   sizeof(sun.sun_path), argv[1], VTY_NEWLINE);
+   sizeof(sun.sun_path) - 1, argv[1], VTY_NEWLINE);
return CMD_WARNING;
}

diff --git a/src/input/unixsocket.c b/src/input/unixsocket.c
index 00e1f9b..bc4b357 100644
--- a/src/input/unixsocket.c
+++ b/src/input/unixsocket.c
@@ -229,7 +229,7 @@
 static int unixsocket_line_update(struct e1inp_line *line)
 {
struct unixsocket_line *config;
-   char default_sock_path[sizeof(struct sockaddr_un) + 1]; /* see unix(7) 
man page */
+   struct sockaddr_un un;
const char *sock_path;
int ret = 0;
int i;
@@ -252,9 +252,17 @@

/* Open unix domain socket */
if (line->sock_path == NULL) {
-   snprintf(default_sock_path, sizeof(default_sock_path), "%s%d",
-UNIXSOCKET_SOCK_PATH_DEFAULT, line->num);
-   sock_path = default_sock_path;
+   ret = snprintf(un.sun_path, sizeof(un.sun_path), "%s%d",
+   UNIXSOCKET_SOCK_PATH_DEFAULT, line->num);
+   if (ret == -1) {
+   LOGP(DLINP, LOGL_ERROR, "Cannot create default socket 
path: %s\n", strerror(errno));
+   return -errno;
+   } else if (ret >= sizeof(un.sun_path)) {
+   LOGP(DLINP, LOGL_ERROR, "Default socket path exceeds 
%zd bytes: %s%d\n",
+sizeof(un.sun_path), UNIXSOCKET_SOCK_PATH_DEFAULT, 
line->num);
+   return -ENOSPC;
+   }
+   sock_path = un.sun_path;
} else
sock_path = line->sock_path;
ret = osmo_sock_unix_init(SOCK_SEQPACKET, 0, sock_path,

--
To view, visit https://gerrit.osmocom.org/11045
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9beecfa500db75cb679b1edcc352c893bf098b13
Gerrit-Change-Number: 11045
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling

Change in libosmocore[master]: ensure unix socket paths are NUL-terminated for bind/connect

2018-09-20 Thread Stefan Sperling 
Stefan Sperling has uploaded this change for review. ( 
https://gerrit.osmocom.org/11044


Change subject: ensure unix socket paths are NUL-terminated for bind/connect
..

ensure unix socket paths are NUL-terminated for bind/connect

The unix(7) man page recommends that sun_path is NUL-terminated
when struct sockaddr_un is passed to a bind() or connect() call.
Non-NUL-terminated paths only need to be dealt with at the
receiving end of a UNIX domain socket.

Commit 896ff6d erroneously assumed otherwise.
This commit almost reverts 896ff6d: It only leaves the added
osmo_strlcpy() overflow check in place.

Change-Id: I6c4ac6b0a0eef4842beae4107f6f09f6cd29172a
Fixes: 896ff6db161465d506bb9bb5bee2cdeef220dd2e
Related: OS#2673
---
M src/socket.c
1 file changed, 5 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/44/11044/1

diff --git a/src/socket.c b/src/socket.c
index 6f56efb..a85edb7 100644
--- a/src/socket.c
+++ b/src/socket.c
@@ -605,29 +605,27 @@
struct sockaddr_un local;
int sfd, rc, on = 1;
unsigned int namelen;
-   const size_t socket_path_len = strlen(socket_path);

if ((flags & (OSMO_SOCK_F_BIND | OSMO_SOCK_F_CONNECT)) ==
 (OSMO_SOCK_F_BIND | OSMO_SOCK_F_CONNECT))
return -EINVAL;

local.sun_family = AF_UNIX;
-   if (socket_path_len == sizeof(local.sun_path)) {
-   /* Handle corner-case where sun_path is not NUL-terminated. See 
the unix(7) man page. */
-   memcpy(local.sun_path, socket_path, sizeof(local.sun_path));
-   } else if (osmo_strlcpy(local.sun_path, socket_path, 
sizeof(local.sun_path)) >= sizeof(local.sun_path)) {
+   /* When an AF_UNIX socket is bound, sun_path should be NUL-terminated. 
See unix(7) man page. */
+   if (osmo_strlcpy(local.sun_path, socket_path, sizeof(local.sun_path)) 
>= sizeof(local.sun_path)) {
LOGP(DLGLOBAL, LOGL_ERROR, "Socket path exceeds maximum length 
of %zd bytes: %s\n",
 sizeof(local.sun_path), socket_path);
return -ENOSPC;
}

 #if defined(BSD44SOCKETS) || defined(__UNIXWARE__)
-   local.sun_len = socket_path_len;
+   local.sun_len = strlen(local.sun_path);
 #endif
 #if defined(BSD44SOCKETS) || defined(SUN_LEN)
namelen = SUN_LEN(&local);
 #else
-   namelen = socket_path_len + offsetof(struct sockaddr_un, sun_path);
+   namelen = strlen(local.sun_path) +
+ offsetof(struct sockaddr_un, sun_path);
 #endif

sfd = socket(AF_UNIX, type, proto);

--
To view, visit https://gerrit.osmocom.org/11044
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c4ac6b0a0eef4842beae4107f6f09f6cd29172a
Gerrit-Change-Number: 11044
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling

Change in docker-playground[master]: debian-repo-install-test: UNKNOWN in --version?

2018-09-20 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11041 )

Change subject: debian-repo-install-test: UNKNOWN in --version?
..


Patch Set 1: Code-Review+2

(3 comments)

https://gerrit.osmocom.org/#/c/11041/1/debian-repo-install-test/testdata/repo-install-test.sh
File debian-repo-install-test/testdata/repo-install-test.sh:

https://gerrit.osmocom.org/#/c/11041/1/debian-repo-install-test/testdata/repo-install-test.sh@57
PS1, Line 57:   echo "ERROR: this program had UNKNOWN in 
--version!"
s/had/prints


https://gerrit.osmocom.org/#/c/11041/1/debian-repo-install-test/testdata/repo-install-test.sh@62
PS1, Line 62:   echo "ERROR: the following program(s) had UNKNOWN in 
--version:"
s/had/print


https://gerrit.osmocom.org/#/c/11041/1/debian-repo-install-test/testdata/repo-install-test.sh@73
PS1, Line 73:   osmo-trx-usrp1 -h
created issues that ask for --version to be added: OS#3576 OS#3577 OS#3578



--
To view, visit https://gerrit.osmocom.org/11041
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8
Gerrit-Change-Number: 11041
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 20 Sep 2018 15:38:18 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: osmo-depcheck: script to verify PKG_CHECK_MODULES

2018-09-20 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/10932 )

Change subject: osmo-depcheck: script to verify PKG_CHECK_MODULES
..


Patch Set 5: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10932
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f495dbe030775f66ac125e60ded95c5d7660b65
Gerrit-Change-Number: 10932
Gerrit-PatchSet: 5
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 20 Sep 2018 15:24:29 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: osmo-depcheck: script to verify PKG_CHECK_MODULES

2018-09-20 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/10932 )

Change subject: osmo-depcheck: script to verify PKG_CHECK_MODULES
..


Patch Set 5:

(3 comments)

https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/buildstack.py
File scripts/osmo-depcheck/buildstack.py:

https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/buildstack.py@97
PS2, Line 97: old = os.environ[env_var] if env_var in os.environ else ""
> Nice trick, but that seems to be a bit over-engineered here IMHO. ":path" 
> will work just as well.
hmm, really, ":/path" is allowed? but it looks unhappy. I don't think it's 
overengineered, but whatever, nm


https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/config.py
File scripts/osmo-depcheck/config.py:

https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/config.py@18
PS2, Line 18: # they are mentioned with PKG_CHECK_MODULES in configure.ac.
> Good point with the tuples. […]
not important.


https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/dependencies.py
File scripts/osmo-depcheck/dependencies.py:

https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/dependencies.py@20
PS2, Line 20: # Clone when needed
> Well, this is a pretty short function (14 LOC), and it does have a few key 
> differences: […]
not that important, keep it



--
To view, visit https://gerrit.osmocom.org/10932
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f495dbe030775f66ac125e60ded95c5d7660b65
Gerrit-Change-Number: 10932
Gerrit-PatchSet: 5
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 20 Sep 2018 15:20:15 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #252

2018-09-20 Thread jenkins 
See 


--
[...truncated 3.67 KB...]

+ ./configure
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dep

Change in docker-playground[master]: root Makefile: add rules for ttcn3-hlr-test

2018-09-20 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11043 )

Change subject: root Makefile: add rules for ttcn3-hlr-test
..


Patch Set 1: Verified+1

(sorry about the topic name, this is not 'wip' but ready for merge)


--
To view, visit https://gerrit.osmocom.org/11043
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfd59c3faabeaa1af00df988513d5574c680a3bb
Gerrit-Change-Number: 11043
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Thu, 20 Sep 2018 15:10:01 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: osmo-bsc.cfg: inter-bsc HO: add a neighbor identity

2018-09-20 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11042 )

Change subject: osmo-bsc.cfg: inter-bsc HO: add a neighbor identity
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/11042
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I077c2ad2ede900ec43f55655bd740651d3bbe83d
Gerrit-Change-Number: 11042
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Thu, 20 Sep 2018 15:09:01 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: root Makefile: add rules for ttcn3-hlr-test

2018-09-20 Thread Neels Hofmeyr 
Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/11043


Change subject: root Makefile: add rules for ttcn3-hlr-test
..

root Makefile: add rules for ttcn3-hlr-test

Change-Id: Idfd59c3faabeaa1af00df988513d5574c680a3bb
---
M Makefile
1 file changed, 8 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/43/11043/1

diff --git a/Makefile b/Makefile
index f82e3f5..e224274 100644
--- a/Makefile
+++ b/Makefile
@@ -33,6 +33,10 @@
 osmo-ggsn-master: debian-jessie-build
$(MAKE) -C osmo-ggsn-master

+.PHONY: osmo-hlr-master
+osmo-hlr-master: debian-jessie-build
+   $(MAKE) -C osmo-hlr-master
+
 .PHONY: ttcn3-bsc-test
 ttcn3-bsc-test: debian-stretch-titan osmo-stp-master osmo-bsc-master 
osmo-bts-master ttcn3-bsc-test
$(MAKE) -C ttcn3-bsc-test
@@ -53,6 +57,10 @@
 ttcn3-mgw-test: debian-stretch-titan osmo-mgw-master
$(MAKE) -C ttcn3-mgw-test

+.PHONY: ttcn3-hlr-test
+ttcn3-hlr-test: debian-stretch-titan osmo-hlr-master
+   $(MAKE) -C ttcn3-hlr-test
+
 .PHONY: sctp-test
 sctp-test: debian-jessie-build
$(MAKE) -C sctp-test

--
To view, visit https://gerrit.osmocom.org/11043
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idfd59c3faabeaa1af00df988513d5574c680a3bb
Gerrit-Change-Number: 11043
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr

Change in docker-playground[master]: osmo-bsc.cfg: inter-bsc HO: add a neighbor identity

2018-09-20 Thread Neels Hofmeyr 
Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/11042


Change subject: osmo-bsc.cfg: inter-bsc HO: add a neighbor identity
..

osmo-bsc.cfg: inter-bsc HO: add a neighbor identity

This mirrors osmo-ttcn3-hacks change:
"bsc: inter-BSC HO: add TC_ho_out_of_this_bsc, TC_ho_into_this_bsc"
change-id Id22852d4be7f127d827e7a8beeec55db27c07f03

Related: OS#2283
Change-Id: I077c2ad2ede900ec43f55655bd740651d3bbe83d
---
M ttcn3-bsc-test/osmo-bsc.cfg
M ttcn3-bsc-test/sccplite/osmo-bsc.cfg
2 files changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/42/11042/1

diff --git a/ttcn3-bsc-test/osmo-bsc.cfg b/ttcn3-bsc-test/osmo-bsc.cfg
index 5255127..876f960 100644
--- a/ttcn3-bsc-test/osmo-bsc.cfg
+++ b/ttcn3-bsc-test/osmo-bsc.cfg
@@ -93,6 +93,8 @@
   early-classmark-sending forbidden
   ip.access unit_id 1234 0
   oml ip.access stream_id 255 line 0
+  # remote-BSS neighbor:
+  neighbor add lac 99 arfcn 123 bsic any
   neighbor-list mode manual-si5
   neighbor-list add arfcn 100
   neighbor-list add arfcn 200
diff --git a/ttcn3-bsc-test/sccplite/osmo-bsc.cfg 
b/ttcn3-bsc-test/sccplite/osmo-bsc.cfg
index 858aa50..0c62104 100644
--- a/ttcn3-bsc-test/sccplite/osmo-bsc.cfg
+++ b/ttcn3-bsc-test/sccplite/osmo-bsc.cfg
@@ -103,6 +103,8 @@
   neighbor-list add arfcn 200
   si5 neighbor-list add arfcn 10
   si5 neighbor-list add arfcn 20
+  # remote-BSS neighbor:
+  neighbor add lac 99 arfcn 123 bsic any
   codec-support fr hr efr amr
   gprs mode gprs
   gprs 11bit_rach_support_for_egprs 0

--
To view, visit https://gerrit.osmocom.org/11042
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I077c2ad2ede900ec43f55655bd740651d3bbe83d
Gerrit-Change-Number: 11042
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr

Change in osmo-ttcn3-hacks[master]: bsc: inter-BSC HO: add TC_ho_out_of_this_bsc, TC_ho_into_this_bsc

2018-09-20 Thread Neels Hofmeyr 
Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9674

to look at the new patch set (#7).

Change subject: bsc: inter-BSC HO: add TC_ho_out_of_this_bsc, 
TC_ho_into_this_bsc
..

bsc: inter-BSC HO: add TC_ho_out_of_this_bsc, TC_ho_into_this_bsc

Add f_gen_handover_req() like f_gen_ass_req(), to match AoIP or SCCPlite
requirements.

For incoming HO, MSC_ConnHdlr needs to know the SCCP addresses to expect the
incoming SCCP Connection from MSC to BSC. Add 'handover' section to
TestHdlrParams, and pass in the addresses from test_CT via that.

In osmo-bsc.cfg, add a remote neighbor config, so that the VTY command
'handover any to arfcn 123 bsic any' can trigger an outgoing inter-BSC HO.

Add various BSSMAP handover templates to BSSMAP_Templates.ttcn.
Add RR Ho Command template to L3_Templates.ttcn.

Move ts_BSSAP_Conn_Req() from msc/BSC_ConnectionHandler.ttcn to
library/BSSMAP_Emulation.ttcn, so we can also model an SCCP Connection Request
in BSC_Tests.ttcn (this time from MSC to BSC).

Add the two new tests to bsc/expected-results.xml.

Related: OS#2283
Change-Id: Id22852d4be7f127d827e7a8beeec55db27c07f03
---
M bsc/BSC_Tests.ttcn
M bsc/MSC_ConnectionHandler.ttcn
M bsc/expected-results.xml
M bsc/osmo-bsc.cfg
M library/BSSMAP_Emulation.ttcn
M library/BSSMAP_Templates.ttcn
M library/L3_Templates.ttcn
M msc/BSC_ConnectionHandler.ttcn
8 files changed, 400 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/74/9674/7
--
To view, visit https://gerrit.osmocom.org/9674
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id22852d4be7f127d827e7a8beeec55db27c07f03
Gerrit-Change-Number: 9674
Gerrit-PatchSet: 7
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr

Change in osmo-ttcn3-hacks[master]: bsc: inter-BSC HO: add TC_ho_out_of_this_bsc, TC_ho_into_this_bsc

2018-09-20 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/9674 )

Change subject: bsc: inter-BSC HO: add TC_ho_out_of_this_bsc, 
TC_ho_into_this_bsc
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/9674
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id22852d4be7f127d827e7a8beeec55db27c07f03
Gerrit-Change-Number: 9674
Gerrit-PatchSet: 6
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Thu, 20 Sep 2018 15:03:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ci[master]: osmo-depcheck: script to verify PKG_CHECK_MODULES

2018-09-20 Thread osmith 
Hello Neels Hofmeyr, Harald Welte,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10932

to look at the new patch set (#5).

Change subject: osmo-depcheck: script to verify PKG_CHECK_MODULES
..

osmo-depcheck: script to verify PKG_CHECK_MODULES

This script verifies that Osomcom programs really build with the
dependency versions they claim to support in configure.ac. In order to
do that, it clones the dependency repositories if they don't exist
already, and checks out the minimum version tag. This happens
recursively for their dependencies as well. See 'osmo-depcheck.py -h'
for the full usage instructions.

There's also a new jenkins job in jobs/osmocom-depcheck.yml.

Change-Id: I8f495dbe030775f66ac125e60ded95c5d7660b65
Relates: OS#2642
---
A jobs/osmocom-depcheck.yml
A scripts/osmo-depcheck/buildstack.py
A scripts/osmo-depcheck/config.py
A scripts/osmo-depcheck/dependencies.py
A scripts/osmo-depcheck/osmo-depcheck.py
A scripts/osmo-depcheck/parse.py
6 files changed, 590 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/32/10932/5
--
To view, visit https://gerrit.osmocom.org/10932
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8f495dbe030775f66ac125e60ded95c5d7660b65
Gerrit-Change-Number: 10932
Gerrit-PatchSet: 5
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith

Change in docker-playground[master]: debian-repo-install-test: UNKNOWN in --version?

2018-09-20 Thread osmith 
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11041 )

Change subject: debian-repo-install-test: UNKNOWN in --version?
..


Patch Set 1: Verified+1

Tested locally with nightly and latest.
Nightly does not have UNKNOWN in their version string, but latest does (how 
useful for testing this patch!).

---
output from latest:
 + echo ERROR: the following program(s) had UNKNOWN in --version:
 ERROR: the following program(s) had UNKNOWN in --version:
 + echo  osmo-bsc osmo-gbproxy osmo-hlr osmo-hlr-db-tool osmo-msc osmo-sgsn
  osmo-bsc osmo-gbproxy osmo-hlr osmo-hlr-db-tool osmo-msc osmo-sgsn


--
To view, visit https://gerrit.osmocom.org/11041
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8
Gerrit-Change-Number: 11041
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 20 Sep 2018 14:13:31 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: debian-repo-install-test: UNKNOWN in --version?

2018-09-20 Thread osmith 
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11041


Change subject: debian-repo-install-test: UNKNOWN in --version?
..

debian-repo-install-test: UNKNOWN in --version?

With this patch, the debian-repo-install-test script checks if
the Osmocom programs as installed from the Debian repository have
"UNKNOWN" in their --version output.

Relates: OS#3555
Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8
---
M debian-repo-install-test/testdata/repo-install-test.sh
1 file changed, 36 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/41/11041/1

diff --git a/debian-repo-install-test/testdata/repo-install-test.sh 
b/debian-repo-install-test/testdata/repo-install-test.sh
index ea1c5fb..fdd0e3e 100755
--- a/debian-repo-install-test/testdata/repo-install-test.sh
+++ b/debian-repo-install-test/testdata/repo-install-test.sh
@@ -44,25 +44,48 @@
apt install -y $(cat /data/osmocom_packages.txt)
 }

+test_binaries_version() {
+   # Make sure --version runs and does not output UNKNOWN
+   failed=""
+   for program in $@; do
+   # Make sure it runs at all
+   $program --version
+
+   # Check for UNKNOWN
+   if $program --version | grep -q UNKNOWN; then
+   failed="$failed $program"
+   echo "ERROR: this program had UNKNOWN in --version!"
+   fi
+   done
+
+   if [ -n "$failed" ]; then
+   echo "ERROR: the following program(s) had UNKNOWN in --version:"
+   echo "$failed"
+   return 1
+   fi
+}
+
 test_binaries() {
# Make sure the binaries are not broken (run -h or --version)
-   osmo-bsc --version
-   osmo-bts-trx --version
-   osmo-bts-virtual --version
-   osmo-gbproxy --version
-   osmo-ggsn --version
osmo-gtphub -h
-   osmo-hlr --version
-   osmo-hlr-db-tool --version
-   osmo-hnbgw --version
-   osmo-mgw --version
-   osmo-msc --version
-   osmo-pcu --version
-   osmo-sgsn --version
osmo-sip-connector -h
-   osmo-stp --version
osmo-trx-uhd -h
osmo-trx-usrp1 -h
+
+   test_binaries_version \
+   osmo-bsc \
+   osmo-bts-trx \
+   osmo-bts-virtual \
+   osmo-gbproxy \
+   osmo-ggsn \
+   osmo-hlr \
+   osmo-hlr-db-tool \
+   osmo-hnbgw \
+   osmo-mgw \
+   osmo-msc \
+   osmo-pcu \
+   osmo-sgsn \
+   osmo-stp
 }

 finish() {

--
To view, visit https://gerrit.osmocom.org/11041
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8
Gerrit-Change-Number: 11041
Gerrit-PatchSet: 1
Gerrit-Owner: osmith

Change in osmo-ci[master]: osmo-depcheck: script to verify PKG_CHECK_MODULES

2018-09-20 Thread osmith 
Hello Neels Hofmeyr, Harald Welte,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10932

to look at the new patch set (#4).

Change subject: osmo-depcheck: script to verify PKG_CHECK_MODULES
..

osmo-depcheck: script to verify PKG_CHECK_MODULES

This script verifies that Osomcom programs really build with the
dependency versions they claim to support in configure.ac. In order to
do that, it clones the dependency repositories if they don't exist
already, and checks out the minimum version tag. This happens
recursively for their dependencies as well. See 'osmo-depcheck.py -h'
for the full usage instructions.

There's also a new jenkins job in jobs/osmocom-depcheck.yml.

Change-Id: I8f495dbe030775f66ac125e60ded95c5d7660b65
Relates: OS#2642
---
A jobs/osmocom-depcheck.yml
A scripts/osmo-depcheck/buildstack.py
A scripts/osmo-depcheck/config.py
A scripts/osmo-depcheck/dependencies.py
A scripts/osmo-depcheck/osmo-depcheck.py
A scripts/osmo-depcheck/parse.py
6 files changed, 584 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/32/10932/4
--
To view, visit https://gerrit.osmocom.org/10932
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8f495dbe030775f66ac125e60ded95c5d7660b65
Gerrit-Change-Number: 10932
Gerrit-PatchSet: 4
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith

Change in osmo-gsm-manuals[master]: osmotrx: Introduce code architecture chapter

2018-09-20 Thread Pau Espin Pedrol 
Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11040


Change subject: osmotrx: Introduce code architecture chapter
..

osmotrx: Introduce code architecture chapter

Change-Id: I21084e6315d79a1adcb305e12343da218837dc31
---
A OsmoTRX/chapters/code-architecture.adoc
M OsmoTRX/osmotrx-usermanual.adoc
M common/chapters/trx_if.adoc
3 files changed, 145 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals 
refs/changes/40/11040/1

diff --git a/OsmoTRX/chapters/code-architecture.adoc 
b/OsmoTRX/chapters/code-architecture.adoc
new file mode 100644
index 000..18d0e3a
--- /dev/null
+++ b/OsmoTRX/chapters/code-architecture.adoc
@@ -0,0 +1,141 @@
+[[code_architecture]]
+== Code Architecture
+
+[[fig-code-architecture-general]]
+.General overview of main OsmoTRX components
+[graphviz]
+
+digraph hierarchy {
+node[shape=record,style=filled,fillcolor=gray95]
+edge[dir=back, arrowtail=empty]
+
+2[label = "{Transceiver|+ constructor()\l+ destructor()\l+ init()\l+ 
numChans()\l+ receiveFIFO()\l+ setSignalHandler()}"]
+3[label = "{RadioInterface|...}"]
+4[label = "{RadioInterfaceResamp|...}"]
+5[label = "{RadioInterfaceMulti|...}"]
+6[label = "{RadioDevice|...}"]
+7[label = "{UHDDevice|...}"]
+8[label = "{LMSDevice|...}"]
+9[label = "{USRPDevice|...}"]
+
+2->3[arrowtail=odiamond]
+3->4[constraint=false]
+3->5[constraint=false]
+3->6[arrowtail=odiamond]
+6->7
+6->8
+6->9
+}
+
+
+[[fig-code-architecture-threads]]
+.Example of thread architecture with OsmoTRX configured to use 2 logical RF 
channels (Trx=Transceiver, RI=RadioIface)
+[graphviz]
+
+digraph hierarchy {
+node[shape=record,style=filled,fillcolor=gray95]
+
+trans [label="Transceiver"];
+radioiface [label="RadioInterface"];
+radiodev [label="RadioDevice"];
+
+trans:nw->trans:ne [label="Trx.ControlServiceLoop_0"];
+trans:nw->trans:ne [label="Trx.ControlServiceLoop_1"];
+trans:w->radioiface:w [label="Trx.TxPriorityQueueServiceLoop_0"];
+trans:w->radioiface:w [label="Trx.TxPriorityQueueServiceLoop_1"];
+radioiface:e->trans:e [label="Trx.RxServiceLoop_0"];
+radioiface:e->trans:e [label="Trx.RxServiceLoop_1"];
+radioiface->radiodev[label="RI.AlignRadioServiceLoop"];
+radioiface:sw->radiodev:nw [label="Trx.TxLowerLoop"];
+radiodev:ne->radioiface:se [label="Trx.RxLowerLoop"];
+}
+
+
+[[code_component_transceiver]]
+=== Transceiver
+
+The Transceiver is the main component managing the other components running in
+the OsmoTRX process. There's a unique instance per process.
+
+This class is quite complex from code point of view, as it starts lots of
+different threads and hence the interaction with this class from the outside is
+quite limited. Only interaction possible is to:
+
+* `Transceiver()`: Create an instance through its constructor, at this time 
most
+  configuration is handed to it.
+* `init()`: Start running all the threads.
+* `receiveFIFO()`: Attach a `radioInterface` channel FIFO in order to use it.
+* `setSignalHandler()`: Used to set up a callback to receive certain events
+  asynchronously from the Transceiver. No assumptions can be made about from
+  which thread is the callback being called, which means multi-thread locking
+  precautions may be required in certain cases, similar to usual signal handler
+  processing. One important event received through this path is for instance
+  when the Transceiver detected a fatal error which requires it to stop. Since
+  it cannot stop itself (see destructor below), stopping procedure must be
+  delegated to the user who created the instance.
+* `~Transceiver()`: The destructor, which stops all running threads created at
+  `init()` time. Destroying the object is the only way to stop the 
`Transceiver`
+  completely, and must be called from a thread not managed by the
+  `Transceiver`, otherwise it will deadlock. Usually it is stopped from the 
main
+  thread, the one that called the constructor during startup.
+
+During `init()` time, `Transceiver` will create a noticeable amount of threads,
+which may vary depending on the amount of RF channels requested.
+
+Static amount of Threads (1 per `Transceiver` instance):
+
+* `RxLowerLoop`: This thread is responsible for reading bursts from the
+  `RadioInterface`, storing them into its FIFO and sending Clock Indications
+  (<>) to _osmo-bts_trx_.
+* `TxLowerLoop`: Manages pushing bursts from buffers in the FIFO into the
+  `RadioInterface` at expected correct time based on the Transceiver clock.
+
+Dynamic amount of Threads (1 per RF logical channel on the `Transceiver` 
instance):
+
+* `ControlServiceLoop`: Handles commands from the Per-ARFCN Control Interface
+  socket (<>). Each thread is responsible for managing one
+  socket related to one ARFCN or which is the same, to one RF logical channel.
+  These are the only threads expected to use the private `start()` and `stop()`
+  methods of the `Transceiver()`

Change in osmo-gsm-manuals[master]: osmotrx: Create a common chapter for section documenting backends

2018-09-20 Thread Pau Espin Pedrol 
Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11039


Change subject: osmotrx: Create a common chapter for section documenting 
backends
..

osmotrx: Create a common chapter for section documenting backends

Change-Id: I6bea1ccca4ce72b92641a36f9f5894ac9a6cae72
---
M OsmoTRX/chapters/trx-backends.adoc
1 file changed, 6 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals 
refs/changes/39/11039/1

diff --git a/OsmoTRX/chapters/trx-backends.adoc 
b/OsmoTRX/chapters/trx-backends.adoc
index e801886..8829fa6 100644
--- a/OsmoTRX/chapters/trx-backends.adoc
+++ b/OsmoTRX/chapters/trx-backends.adoc
@@ -1,5 +1,8 @@
+[[trx_backends]]
+== OsmoTRX backend support
+
 [[backend_uhd]]
-== `osmo-trx-uhd` for UHD based Transceivers
+=== `osmo-trx-uhd` for UHD based Transceivers

 This OsmoTRX model uses _libuhd_ (UHD, USRP Hardware Driver) to drive the
 device, that is configuring it and reading/writing samples from/to it.
@@ -17,7 +20,7 @@
 _osmo-trx.git_.

 [[backend_lms]]
-== `osmo-trx-lms` for LimeSuite based Transceivers
+=== `osmo-trx-lms` for LimeSuite based Transceivers

 This OsmoTRX model uses LimeSuite API and library to drive the device, that is
 configuring it and reading/writing samples from/to it.
@@ -30,7 +33,7 @@
 _osmo-trx.git_.

 [[backend_usrp1]]
-== `osmo-trx-usrp1` for libusrp based Transceivers
+=== `osmo-trx-usrp1` for libusrp based Transceivers

 This OsmoTRX model uses the legacy libusrp driver provided in GNU Radio 3.4.2.


--
To view, visit https://gerrit.osmocom.org/11039
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6bea1ccca4ce72b92641a36f9f5894ac9a6cae72
Gerrit-Change-Number: 11039
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol

Change in osmo-ci[master]: osmo-depcheck: script to verify PKG_CHECK_MODULES

2018-09-20 Thread osmith 
osmith has posted comments on this change. ( https://gerrit.osmocom.org/10932 )

Change subject: osmo-depcheck: script to verify PKG_CHECK_MODULES
..


Patch Set 3: Verified+1

(19 comments)

> In general: in some places I think the overall design could be simpler and 
> much shorter, but the coding style is clear and mature, and I'm looking 
> forward to more patches from you.

Thank you for the detailed review!

> So yes, in the end, let's see a run in jenkins as Harald said :)

https://jenkins.osmocom.org/jenkins/job/Osmocom-depcheck (check out the new 
configurable build parameters!)

https://gerrit.osmocom.org/#/c/10932/2/.gitignore
File .gitignore:

https://gerrit.osmocom.org/#/c/10932/2/.gitignore@8
PS2, Line 8: __pycache__/
> technically this would be a separate patch from the rest
Submitted and merged here:
https://gerrit.osmocom.org/#/c/osmo-ci/+/11032/


https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/buildstack.py
File scripts/osmo-depcheck/buildstack.py:

https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/buildstack.py@2
PS2, Line 2: # Copyright 2018 sysmocom - s.f.m.c. GmbH 
> (You should write "Copyright  ...", the (c) is just a gimmick IIUC. […]
fixed in the upcoming patch


https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/buildstack.py@11
PS2, Line 11:
> Generally, this file reads like a re-invention of the GNU Make wheel...
make? never heard of that :p

But seriously: now that you say it, I could have probably replaced "next()", 
"generate()", "print_dict()", set_environment()" and "build()" with writing a 
Makefile, and then let make do the resolving and execute the commands.

I am not sure if it would have been possible to generate a nice overview of the 
build order as written below (but then again, this was never asked for).

So I'll consider this in the future, if there's a similar situation. Thanks for 
the hint!

---
Build order:
 * libosmocore:0.11.0
 * libosmo-abis:0.5.0
 * osmo-hlr:0.2.1


https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/buildstack.py@13
PS2, Line 13: def next_buildable(depends, done):
> some of the function names here read like generic tools, I think more concise 
> names would help reada […]
Replaced "next()" with "next_buildable()" in the next patchset.


https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/buildstack.py@20
PS2, Line 20: :param done: ordered dict of programs that would already 
have been
> it's actually an ordered dict, not a list
good catch! fixed in the upcoming patchset


https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/buildstack.py@50
PS2, Line 50: :param depends: return value of dependencies.generate()
> (an *ordered* dict)
+1


https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/buildstack.py@65
PS2, Line 65: def print_dict(stack):
> oh, so now it's a stack? .. […]
Well, the file is called "buildstack.py", so that ordered dict *is* the stack. 
There's no stack datatype in Python 3 from what I found, so I don't get why 
this is confusing :p


https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/buildstack.py@80
PS2, Line 80: :returns: the path to the temporary folder """
> (maybe a separator [. […]
Ack


https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/buildstack.py@95
PS2, Line 95:   "LD_LIBRARY_PATH": tempdir + "/lib"}
> (would be more readable: […]
I'll change this to env_var, folder (so I don't overwrite "tempdir" which is 
already used above).


https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/buildstack.py@97
PS2, Line 97: old = os.environ[env_var] if env_var in os.environ else ""
> if 'old' is empty, you end up producing ":new_dir". A neat trick in these 
> cases is join: […]
Nice trick, but that seems to be a bit over-engineered here IMHO. ":path" will 
work just as well.


https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/buildstack.py@134
PS2, Line 134: # Run the build commands
> hmm, do we need specific configure options sometimes?
--with-systemdsystemunitdir was also needed, besides that it worked for all 
programs I have tested without any additional parameters. On demand we could 
still add a mapping in config.py for repositories and the special configure 
parameters they need.


https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/config.py
File scripts/osmo-depcheck/config.py:

https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/config.py@10
PS2, Line 10: "osmo-hlr",
> indicate whether it's regex or shell glob or ...
Ack


https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/config.py@18
PS2, Line 18: # they are mentioned with PKG_CHECK_MODULES in configure.ac.
> would make sense to use tuples instead of lists -- they aren't supposed to be 
> mutable, right? […]
Good point with the tuples.

Regarding the lists, I built them that way so they follow PE

Change in osmo-gsm-tester[master]: contrib: Build osmo-msc with IU support

2018-09-20 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11027 )

Change subject: contrib: Build osmo-msc with IU support
..

contrib: Build osmo-msc with IU support

Change-Id: I68503ae2f27948aff60a9424e6b114db548d79e9
---
M contrib/jenkins-build-osmo-msc.sh
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/contrib/jenkins-build-osmo-msc.sh 
b/contrib/jenkins-build-osmo-msc.sh
index 5b5d1f6..b614052 100755
--- a/contrib/jenkins-build-osmo-msc.sh
+++ b/contrib/jenkins-build-osmo-msc.sh
@@ -11,6 +11,8 @@
 build_repo libosmo-sccp --enable-sanitize
 build_repo osmo-mgw --enable-sanitize
 build_repo osmo-hlr --enable-sanitize
-build_repo osmo-msc --enable-sanitize --enable-smpp --disable-iu
+build_repo libasn1c --enable-sanitize
+build_repo osmo-iuh --enable-sanitize
+build_repo osmo-msc --enable-sanitize --enable-smpp --enable-iu

 create_bin_tgz osmo-msc

--
To view, visit https://gerrit.osmocom.org/11027
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I68503ae2f27948aff60a9424e6b114db548d79e9
Gerrit-Change-Number: 11027
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-gsm-tester[master]: contrib: Build osmo-sgsn with IU support

2018-09-20 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11028 )

Change subject: contrib: Build osmo-sgsn with IU support
..

contrib: Build osmo-sgsn with IU support

Change-Id: I810ae848c350550430c1918b3abb4376d21d7317
---
M contrib/jenkins-build-osmo-sgsn.sh
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/contrib/jenkins-build-osmo-sgsn.sh 
b/contrib/jenkins-build-osmo-sgsn.sh
index 4a23b33..87aed76 100755
--- a/contrib/jenkins-build-osmo-sgsn.sh
+++ b/contrib/jenkins-build-osmo-sgsn.sh
@@ -9,6 +9,8 @@
 build_repo libosmo-netif --enable-sanitize --disable-doxygen
 build_repo libosmo-sccp --enable-sanitize
 build_repo osmo-ggsn --enable-sanitize
-build_repo osmo-sgsn --enable-sanitize --disable-iu
+build_repo libasn1c --enable-sanitize
+build_repo osmo-iuh --enable-sanitize
+build_repo osmo-sgsn --enable-sanitize --enable-iu

 create_bin_tgz osmo-sgsn

--
To view, visit https://gerrit.osmocom.org/11028
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I810ae848c350550430c1918b3abb4376d21d7317
Gerrit-Change-Number: 11028
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-ci[master]: osmo-depcheck: script to verify PKG_CHECK_MODULES

2018-09-20 Thread osmith 
Hello Neels Hofmeyr, Harald Welte,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10932

to look at the new patch set (#3).

Change subject: osmo-depcheck: script to verify PKG_CHECK_MODULES
..

osmo-depcheck: script to verify PKG_CHECK_MODULES

This script verifies that Osomcom programs really build with the
dependency versions they claim to support in configure.ac. In order to
do that, it clones the dependency repositories if they don't exist
already, and checks out the minimum version tag. This happens
recursively for their dependencies as well. See 'osmo-depcheck.py -h'
for the full usage instructions.

There's also a new jenkins job in jobs/osmocom-depcheck.yml.

Change-Id: I8f495dbe030775f66ac125e60ded95c5d7660b65
Relates: OS#2642
---
A jobs/osmocom-depcheck.yml
A scripts/osmo-depcheck/buildstack.py
A scripts/osmo-depcheck/config.py
A scripts/osmo-depcheck/dependencies.py
A scripts/osmo-depcheck/osmo-depcheck.py
A scripts/osmo-depcheck/parse.py
6 files changed, 586 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/32/10932/3
--
To view, visit https://gerrit.osmocom.org/10932
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8f495dbe030775f66ac125e60ded95c5d7660b65
Gerrit-Change-Number: 10932
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith

Change in pysim[master]: tests: add example test data for Wavemobile-SIM

2018-09-20 Thread Harald Welte 
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11036 )

Change subject: tests: add example test data for Wavemobile-SIM
..

tests: add example test data for Wavemobile-SIM

Change-Id: If69cd2d8af6d544155b3088f77eb6ea4b789901d
Related: SYS#4245
---
A tests/Wavemobile-SIM.data.example
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/tests/Wavemobile-SIM.data.example 
b/tests/Wavemobile-SIM.data.example
new file mode 100644
index 000..e9ba965
--- /dev/null
+++ b/tests/Wavemobile-SIM.data.example
@@ -0,0 +1,5 @@
+MCC=001
+MNC=01
+IMSI=00101000102
+ADM=0123456789ABCDEF
+

--
To view, visit https://gerrit.osmocom.org/11036
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If69cd2d8af6d544155b3088f77eb6ea4b789901d
Gerrit-Change-Number: 11036
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in pysim[master]: tests: add example test data for Wavemobile-SIM

2018-09-20 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11036 )

Change subject: tests: add example test data for Wavemobile-SIM
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11036
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If69cd2d8af6d544155b3088f77eb6ea4b789901d
Gerrit-Change-Number: 11036
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 20 Sep 2018 12:43:36 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: contrib: Build osmo-sgsn with IU support

2018-09-20 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11028 )

Change subject: contrib: Build osmo-sgsn with IU support
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11028
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I810ae848c350550430c1918b3abb4376d21d7317
Gerrit-Change-Number: 11028
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 20 Sep 2018 12:36:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: contrib: Build osmo-msc with IU support

2018-09-20 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11027 )

Change subject: contrib: Build osmo-msc with IU support
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11027
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68503ae2f27948aff60a9424e6b114db548d79e9
Gerrit-Change-Number: 11027
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 20 Sep 2018 12:35:58 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: osmo-depcheck: script to verify PKG_CHECK_MODULES

2018-09-20 Thread osmith 
osmith has posted comments on this change. ( https://gerrit.osmocom.org/10932 )

Change subject: osmo-depcheck: script to verify PKG_CHECK_MODULES
..


Patch Set 2:

> Please make sure that work directories are properly cleaned up after a build 
> so we don't waste tons of disks space.

The installation folders are properly cleaned up (with atexit). The sources get 
downloaded into the Jenkins workspace folder, which means they get 
automatically deleted by Jenkins as soon as the next job starts, right?


--
To view, visit https://gerrit.osmocom.org/10932
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f495dbe030775f66ac125e60ded95c5d7660b65
Gerrit-Change-Number: 10932
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 20 Sep 2018 11:15:35 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ci[master]: jobs: osmo-gsm-tester_run-gerrit: Update suites selected for verifica...

2018-09-20 Thread Pau Espin Pedrol 
Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11038


Change subject: jobs: osmo-gsm-tester_run-gerrit: Update suites selected for 
verification
..

jobs: osmo-gsm-tester_run-gerrit: Update suites selected for verification

Recently in osmo-gsm-tester some suite names were changed to have better
unified naming. As a result, some of the suites used here need to
updated.

Change-Id: Iafe865ab5f607fc8acfcb3f72ebe4b0ef0f1322a
---
M jobs/osmo-gsm-tester_run-gerrit.sh
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/38/11038/1

diff --git a/jobs/osmo-gsm-tester_run-gerrit.sh 
b/jobs/osmo-gsm-tester_run-gerrit.sh
index 6d33490..4f250be 100644
--- a/jobs/osmo-gsm-tester_run-gerrit.sh
+++ b/jobs/osmo-gsm-tester_run-gerrit.sh
@@ -10,5 +10,5 @@
 unlink osmo-gsm-tester/example/resources.conf || true
 ln -s resources.conf.prod osmo-gsm-tester/example/resources.conf

-export OSMO_GSM_TESTER_OPTS="-s sms:sysmo -s aoip_sms:sysmo -s gprs:sysmo"
+export OSMO_GSM_TESTER_OPTS="-s nitb_sms:sysmo -s sms:sysmo -s gprs:sysmo"
 ./osmo-gsm-tester/contrib/jenkins-make-check-and-run.sh

--
To view, visit https://gerrit.osmocom.org/11038
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iafe865ab5f607fc8acfcb3f72ebe4b0ef0f1322a
Gerrit-Change-Number: 11038
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol

Change in osmo-trx[master]: device/lms/LMSDevice.cpp: fix compilation warning

2018-09-20 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11037 )

Change subject: device/lms/LMSDevice.cpp: fix compilation warning
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11037
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b4a061fc12e5fd1db8d1087d8e0c46ff1e23412
Gerrit-Change-Number: 11037
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 20 Sep 2018 09:26:20 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: device/lms/LMSDevice.cpp: fix compilation warning

2018-09-20 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11037 )

Change subject: device/lms/LMSDevice.cpp: fix compilation warning
..

device/lms/LMSDevice.cpp: fix compilation warning

The following warning was observed with GCC 4.8.5:

  make[4]: Entering directory `.../osmo-trx/Transceiver52M/device/lms'
CXX  LMSDevice.lo
  LMSDevice.cpp: In member function 'LMSDevice::writeSamples()':
  LMSDevice.cpp:582:22: warning: 'rc' may be used uninitialized
in this function [-Wmaybe-uninitialized]
samplesWritten += rc;

Let's fix this by zero-initializing 'rc'.

Change-Id: I4b4a061fc12e5fd1db8d1087d8e0c46ff1e23412
---
M Transceiver52M/device/lms/LMSDevice.cpp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/Transceiver52M/device/lms/LMSDevice.cpp 
b/Transceiver52M/device/lms/LMSDevice.cpp
index d8220ea..32c3d15 100644
--- a/Transceiver52M/device/lms/LMSDevice.cpp
+++ b/Transceiver52M/device/lms/LMSDevice.cpp
@@ -543,7 +543,7 @@
bool * underrun, unsigned long long timestamp,
bool isControl)
 {
-   int rc;
+   int rc = 0;
unsigned int i;
lms_stream_status_t status;
lms_stream_meta_t tx_metadata = {};

--
To view, visit https://gerrit.osmocom.org/11037
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b4a061fc12e5fd1db8d1087d8e0c46ff1e23412
Gerrit-Change-Number: 11037
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-trx[master]: device/lms/LMSDevice.cpp: fix compilation warning

2018-09-20 Thread Vadim Yanitskiy 
Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/11037


Change subject: device/lms/LMSDevice.cpp: fix compilation warning
..

device/lms/LMSDevice.cpp: fix compilation warning

The following warning was observed with GCC 4.8.5:

  make[4]: Entering directory `.../osmo-trx/Transceiver52M/device/lms'
CXX  LMSDevice.lo
  LMSDevice.cpp: In member function 'LMSDevice::writeSamples()':
  LMSDevice.cpp:582:22: warning: 'rc' may be used uninitialized
in this function [-Wmaybe-uninitialized]
samplesWritten += rc;

Let's fix this by zero-initializing 'rc'.

Change-Id: I4b4a061fc12e5fd1db8d1087d8e0c46ff1e23412
---
M Transceiver52M/device/lms/LMSDevice.cpp
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/37/11037/1

diff --git a/Transceiver52M/device/lms/LMSDevice.cpp 
b/Transceiver52M/device/lms/LMSDevice.cpp
index d8220ea..32c3d15 100644
--- a/Transceiver52M/device/lms/LMSDevice.cpp
+++ b/Transceiver52M/device/lms/LMSDevice.cpp
@@ -543,7 +543,7 @@
bool * underrun, unsigned long long timestamp,
bool isControl)
 {
-   int rc;
+   int rc = 0;
unsigned int i;
lms_stream_status_t status;
lms_stream_meta_t tx_metadata = {};

--
To view, visit https://gerrit.osmocom.org/11037
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b4a061fc12e5fd1db8d1087d8e0c46ff1e23412
Gerrit-Change-Number: 11037
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy

Change in osmo-gsm-tester[master]: contrib: Add jenkins-build-osmo-iuh.sh

2018-09-20 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11026 )

Change subject: contrib: Add jenkins-build-osmo-iuh.sh
..

contrib: Add jenkins-build-osmo-iuh.sh

Change-Id: I75cb9551db6b1b4aa5bfb76177694c14fad82f04
---
A contrib/jenkins-build-osmo-iuh.sh
1 file changed, 15 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/contrib/jenkins-build-osmo-iuh.sh 
b/contrib/jenkins-build-osmo-iuh.sh
new file mode 100755
index 000..03295f9
--- /dev/null
+++ b/contrib/jenkins-build-osmo-iuh.sh
@@ -0,0 +1,15 @@
+#!/bin/sh
+set -e -x
+base="$PWD"
+name="osmo-iuh"
+. "$(dirname "$0")/jenkins-build-common.sh"
+
+build_repo libosmocore --enable-sanitize --disable-doxygen
+build_repo libosmo-abis --enable-sanitize
+build_repo libosmo-netif --enable-sanitize --disable-doxygen
+build_repo libosmo-sccp --enable-sanitize
+build_repo libasn1c --enable-sanitize
+
+build_repo osmo-iuh --enable-sanitize
+
+create_bin_tgz "osmo-hnbgw"

--
To view, visit https://gerrit.osmocom.org/11026
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I75cb9551db6b1b4aa5bfb76177694c14fad82f04
Gerrit-Change-Number: 11026
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-ci[master]: gitignore: add __pycache__

2018-09-20 Thread osmith 
osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11032 )

Change subject: gitignore: add __pycache__
..

gitignore: add __pycache__

The osmo-depcheck script consists of multiple Python files. Python
creates a __pycache__ folder, so let's make sure that does not get
added by accident into the git repository.

Related: OS#2642
Change-Id: Ic8fb08fec1629846fc0712d6bc0b6288fbba7dc9
---
M .gitignore
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  osmith: Verified



diff --git a/.gitignore b/.gitignore
index 07c4349..1717928 100644
--- a/.gitignore
+++ b/.gitignore
@@ -5,3 +5,4 @@
 .*.sw?
 jenkins_jobs.ini
 jenkins-jobs.ini
+__pycache__/

-- 
To view, visit https://gerrit.osmocom.org/11032
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8fb08fec1629846fc0712d6bc0b6288fbba7dc9
Gerrit-Change-Number: 11032
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: osmith

Change in osmo-ci[master]: gitignore: add __pycache__

2018-09-20 Thread osmith 
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11032 )

Change subject: gitignore: add __pycache__
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/11032
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8fb08fec1629846fc0712d6bc0b6288fbba7dc9
Gerrit-Change-Number: 11032
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 20 Sep 2018 08:11:44 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: osmocom-debian-install.yml: new jenkins jobs

2018-09-20 Thread osmith 
osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11031 )

Change subject: osmocom-debian-install.yml: new jenkins jobs
..

osmocom-debian-install.yml: new jenkins jobs

Installs most packages from the Osmocom Debian repository into a plain
debian:stretch container and call the osmo-* binaries with --version
(or -h).

Two jobs, one for nightly and one for latest.

Change-Id: Idbb43ed737e164f8cf3a0e085ed54e4c6a2d14bc
Related: OS#3176
---
A jobs/osmocom-debian-install.yml
1 file changed, 30 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  osmith: Verified



diff --git a/jobs/osmocom-debian-install.yml b/jobs/osmocom-debian-install.yml
new file mode 100644
index 000..823db3c
--- /dev/null
+++ b/jobs/osmocom-debian-install.yml
@@ -0,0 +1,30 @@
+---
+- project:
+name: Osmocom-Debian-install
+jobs:
+  - Osmocom-Debian-install-{type}
+type:
+  - nightly
+  - latest
+
+- job-template:
+name: 'Osmocom-Debian-install-{type}'
+
+project-type: freestyle
+defaults: global
+description: 'Generated by job-builder'
+node: osmocom-master-debian9
+builders:
+  - shell:
+  cd debian-repo-install-test && FEED={type} ./jenkins.sh
+scm:
+  - git:
+  branches:
+- '*/master'
+  url: git://git.osmocom.org/docker-playground
+  git-config-name: 'Jenkins Builder'
+  git-config-email: 'jenk...@osmocom.org'
+triggers:
+  - timed: "@midnight"
+
+# vim: expandtab tabstop=2 shiftwidth=2

--
To view, visit https://gerrit.osmocom.org/11031
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idbb43ed737e164f8cf3a0e085ed54e4c6a2d14bc
Gerrit-Change-Number: 11031
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: osmith

Change in pysim[master]: tests: add example test data for Wavemobile-SIM

2018-09-20 Thread dexter 
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11036


Change subject: tests: add example test data for Wavemobile-SIM
..

tests: add example test data for Wavemobile-SIM

Change-Id: If69cd2d8af6d544155b3088f77eb6ea4b789901d
Related: SYS#4245
---
A tests/Wavemobile-SIM.data.example
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/36/11036/1

diff --git a/tests/Wavemobile-SIM.data.example 
b/tests/Wavemobile-SIM.data.example
new file mode 100644
index 000..e9ba965
--- /dev/null
+++ b/tests/Wavemobile-SIM.data.example
@@ -0,0 +1,5 @@
+MCC=001
+MNC=01
+IMSI=00101000102
+ADM=0123456789ABCDEF
+

--
To view, visit https://gerrit.osmocom.org/11036
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If69cd2d8af6d544155b3088f77eb6ea4b789901d
Gerrit-Change-Number: 11036
Gerrit-PatchSet: 1
Gerrit-Owner: dexter