date:20180921

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/armv7l

2018-09-21 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/armv7l

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  317s] No package 'libpcsclite' found
[  317s] simtrace2-remsim.o: In function `main':
[  317s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  317s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  317s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:772: undefined 
reference to `osim_uicc_sim_cic_profile'
[  317s] apdu_dispatch.o: In function `apdu_segment_in':
[  317s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  317s] /usr/src/packages/BUILD/host/apdu_dispatch.c:173: undefined reference 
to `osim_uicc_sim_cic_profile'
[  317s] collect2: error: ld returned 1 exit status
[  317s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  317s] make[2]: *** [simtrace2-remsim] Error 1
[  317s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  317s] Makefile:20: recipe for target 'utils' failed
[  317s] make[1]: *** [utils] Error 2
[  317s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  317s] dh_auto_build: make -j1 returned exit code 2
[  317s] debian/rules:4: recipe for target 'build' failed
[  317s] make: *** [build] Error 2
[  317s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  317s] 
[  317s] armbuild02 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 21 
21:14:23 UTC 2018.
[  317s] 
[  317s] ### VM INTERACTION START ###
[  320s] [  265.605575] SysRq : Power Off
[  320s] [  265.654093] reboot: Power down
[  321s] ### VM INTERACTION END ###
[  321s] 
[  321s] armbuild02 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 21 
21:14:27 UTC 2018.
[  321s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/i586

2018-09-21 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_18.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  558s] No package 'libpcsclite' found
[  558s] simtrace2-remsim.o: In function `main':
[  558s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  558s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  558s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  558s] apdu_dispatch.o: In function `apdu_segment_in':
[  558s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  558s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  558s] collect2: error: ld returned 1 exit status
[  558s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  558s] make[2]: *** [simtrace2-remsim] Error 1
[  558s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  558s] Makefile:20: recipe for target 'utils' failed
[  558s] make[1]: *** [utils] Error 2
[  558s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  558s] dh_auto_build: make -j1 returned exit code 2
[  558s] debian/rules:4: recipe for target 'build' failed
[  558s] make: *** [build] Error 2
[  558s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  558s] 
[  558s] lamb24 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 21 
21:08:49 UTC 2018.
[  558s] 
[  558s] ### VM INTERACTION START ###
[  562s] [  534.604691] sysrq: SysRq : Power Off
[  562s] [  534.664991] reboot: Power down
[  562s] ### VM INTERACTION END ###
[  562s] 
[  562s] lamb24 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 21 
21:08:54 UTC 2018.
[  562s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/x86_64

2018-09-21 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_18.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  224s] No package 'libpcsclite' found
[  224s] simtrace2-remsim.o: In function `main':
[  224s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  224s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  224s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  224s] apdu_dispatch.o: In function `apdu_segment_in':
[  224s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  224s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  224s] collect2: error: ld returned 1 exit status
[  224s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  224s] make[2]: *** [simtrace2-remsim] Error 1
[  224s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  224s] Makefile:20: recipe for target 'utils' failed
[  224s] make[1]: *** [utils] Error 2
[  224s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  224s] dh_auto_build: make -j1 returned exit code 2
[  224s] debian/rules:4: recipe for target 'build' failed
[  224s] make: *** [build] Error 2
[  224s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  224s] 
[  224s] lamb54 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 21 
20:55:03 UTC 2018.
[  224s] 
[  224s] ### VM INTERACTION START ###
[  227s] [  212.489767] sysrq: SysRq : Power Off
[  227s] [  212.495885] reboot: Power down
[  227s] ### VM INTERACTION END ###
[  227s] 
[  227s] lamb54 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 21 
20:55:07 UTC 2018.
[  227s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/x86_64

2018-09-21 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  116s] No package 'libpcsclite' found
[  116s] simtrace2-remsim.o: In function `main':
[  116s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  116s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  116s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  116s] apdu_dispatch.o: In function `apdu_segment_in':
[  116s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  116s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  116s] collect2: error: ld returned 1 exit status
[  116s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  116s] make[2]: *** [simtrace2-remsim] Error 1
[  116s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  116s] Makefile:20: recipe for target 'utils' failed
[  116s] make[1]: *** [utils] Error 2
[  116s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  116s] dh_auto_build: make -j1 returned exit code 2
[  116s] debian/rules:4: recipe for target 'build' failed
[  116s] make: *** [build] Error 2
[  116s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  116s] 
[  116s] build74 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 21 
20:50:00 UTC 2018.
[  116s] 
[  116s] ### VM INTERACTION START ###
[  119s] [  107.444770] sysrq: SysRq : Power Off
[  119s] [  107.454946] reboot: Power down
[  120s] ### VM INTERACTION END ###
[  120s] 
[  120s] build74 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 21 
20:50:05 UTC 2018.
[  120s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/i586

2018-09-21 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/i586

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  190s] No package 'libpcsclite' found
[  190s] simtrace2-remsim.o: In function `main':
[  190s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  190s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  190s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  190s] apdu_dispatch.o: In function `apdu_segment_in':
[  190s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  190s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  190s] collect2: error: ld returned 1 exit status
[  190s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  190s] make[2]: *** [simtrace2-remsim] Error 1
[  190s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  190s] Makefile:20: recipe for target 'utils' failed
[  190s] make[1]: *** [utils] Error 2
[  190s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  190s] dh_auto_build: make -j1 returned exit code 2
[  190s] debian/rules:4: recipe for target 'build' failed
[  190s] make: *** [build] Error 2
[  190s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  190s] 
[  190s] lamb59 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 21 
20:49:22 UTC 2018.
[  190s] 
[  190s] ### VM INTERACTION START ###
[  193s] [  179.977218] sysrq: SysRq : Power Off
[  193s] [  179.988406] reboot: Power down
[  193s] ### VM INTERACTION END ###
[  193s] 
[  193s] lamb59 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 21 
20:49:26 UTC 2018.
[  193s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_17.10/i586

2018-09-21 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_17.10/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_17.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  158s] No package 'libpcsclite' found
[  158s] simtrace2-remsim.o: In function `main':
[  158s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  158s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  158s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  158s] apdu_dispatch.o: In function `apdu_segment_in':
[  158s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  158s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  158s] collect2: error: ld returned 1 exit status
[  158s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  158s] make[2]: *** [simtrace2-remsim] Error 1
[  158s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  158s] Makefile:20: recipe for target 'utils' failed
[  158s] make[1]: *** [utils] Error 2
[  158s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  158s] dh_auto_build: make -j1 returned exit code 2
[  158s] debian/rules:4: recipe for target 'build' failed
[  158s] make: *** [build] Error 2
[  158s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  158s] 
[  158s] wildcard2 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 21 
20:48:52 UTC 2018.
[  158s] 
[  158s] ### VM INTERACTION START ###
[  161s] [  145.092648] sysrq: SysRq : Power Off
[  161s] [  145.097021] reboot: Power down
[  163s] ### VM INTERACTION END ###
[  163s] 
[  163s] wildcard2 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 21 
20:48:58 UTC 2018.
[  163s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_16.04/i586

2018-09-21 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_16.04/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  202s] No package 'libpcsclite' found
[  202s] simtrace2-remsim.o: In function `main':
[  202s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  202s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  202s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  202s] apdu_dispatch.o: In function `apdu_segment_in':
[  202s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  202s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  202s] collect2: error: ld returned 1 exit status
[  202s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  202s] make[2]: *** [simtrace2-remsim] Error 1
[  202s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  202s] Makefile:20: recipe for target 'utils' failed
[  202s] make[1]: *** [utils] Error 2
[  202s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  202s] dh_auto_build: make -j1 returned exit code 2
[  202s] debian/rules:4: recipe for target 'build' failed
[  202s] make: *** [build] Error 2
[  202s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  202s] 
[  202s] cloud113 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 21 
20:41:01 UTC 2018.
[  202s] 
[  202s] ### VM INTERACTION START ###
[  205s] [  180.637796] sysrq: SysRq : Power Off
[  205s] [  180.691863] reboot: Power down
[  207s] ### VM INTERACTION END ###
[  207s] 
[  207s] cloud113 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 21 
20:41:07 UTC 2018.
[  207s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_16.04/x86_64

2018-09-21 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  189s] No package 'libpcsclite' found
[  189s] simtrace2-remsim.o: In function `main':
[  189s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  189s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  189s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  189s] apdu_dispatch.o: In function `apdu_segment_in':
[  189s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  189s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  189s] collect2: error: ld returned 1 exit status
[  189s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  189s] make[2]: *** [simtrace2-remsim] Error 1
[  189s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  189s] Makefile:20: recipe for target 'utils' failed
[  189s] make[1]: *** [utils] Error 2
[  189s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  189s] dh_auto_build: make -j1 returned exit code 2
[  189s] debian/rules:4: recipe for target 'build' failed
[  189s] make: *** [build] Error 2
[  189s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  189s] 
[  189s] cloud127 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 21 
20:38:46 UTC 2018.
[  189s] 
[  189s] ### VM INTERACTION START ###
[  192s] [  166.605812] sysrq: SysRq : Power Off
[  192s] [  166.646940] reboot: Power down
[  193s] ### VM INTERACTION END ###
[  193s] 
[  193s] cloud127 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 21 
20:38:51 UTC 2018.
[  193s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_17.10/x86_64

2018-09-21 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  207s] No package 'libpcsclite' found
[  207s] simtrace2-remsim.o: In function `main':
[  207s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  207s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  207s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  207s] apdu_dispatch.o: In function `apdu_segment_in':
[  207s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  207s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  207s] collect2: error: ld returned 1 exit status
[  207s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  207s] make[2]: *** [simtrace2-remsim] Error 1
[  207s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  207s] Makefile:20: recipe for target 'utils' failed
[  207s] make[1]: *** [utils] Error 2
[  207s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  207s] dh_auto_build: make -j1 returned exit code 2
[  207s] debian/rules:4: recipe for target 'build' failed
[  207s] make: *** [build] Error 2
[  208s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  208s] 
[  208s] cloud123 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 21 
20:39:09 UTC 2018.
[  208s] 
[  208s] ### VM INTERACTION START ###
[  211s] [  185.133410] sysrq: SysRq : Power Off
[  211s] [  185.154238] reboot: Power down
[  213s] ### VM INTERACTION END ###
[  214s] 
[  214s] cloud123 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Fri Sep 21 
20:39:16 UTC 2018.
[  214s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-ttcn3-hacks[master]: library/GSUP: implement SRI_FOR_SM message support

2018-09-21 Thread Vadim Yanitskiy

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/11061


Change subject: library/GSUP: implement SRI_FOR_SM message support
..

library/GSUP: implement SRI_FOR_SM message support

According to 3GPP TS 29.002, section 12.1 the SRI_FOR_SM message
(a.k.a MAP-SEND-ROUTING-INFO-FOR-SM) is used to retrieve the
routing information needed for routing a short message to
the servicing node of subscriber.

Please note that only the 'must-have' fields of SRI_FOR_SM
are introduced by this change, in particular:

  - GSUP_MSGT_SRI_FOR_SM_REQUEST (MAP Request)
- GSUP_MSISDN_IE
- GSUP_SM_RP_RPI_IE
- GSUP_SMSC_ADDR_IE

  - GSUP_MSGT_SRI_FOR_SM_RESULT (MAP Response)
- GSUP_IMSI_IE
- GSUP_NODE_ADDR_IE

  - GSUP_MSGT_SRI_FOR_SM_ERROR (MAP Response)
- GSUP_CAUSE_IE (MAP User Error, see 7.6.1)

Since there is no TCAP layer in GSUP, the context is emulated
using the session management IEs, in particular using the
GSUP_SESSION_ID_IE. The session state IE isn't used due to
the 'REQ-RSP' nature of this message.

Change-Id: I7c1a882748d82ed5ef0b22cf1ae5764da5e874a0
---
M library/GSUP_Types.ttcn
1 file changed, 141 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/61/11061/1

diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn
index 7680815..80b8e2e 100644
--- a/library/GSUP_Types.ttcn
+++ b/library/GSUP_Types.ttcn
@@ -31,6 +31,11 @@
OSMO_GSUP_PDP_QOS_IE('13'O),
OSMO_GSUP_CHARG_CHAR_IE ('14'O),

+   /* FIXME: should we reserve a separate range (e.g. 0x40) for SM? */
+   OSMO_GSUP_SMSC_ADDR ('15'O),
+   OSMO_GSUP_NODE_ADDR ('16'O),
+   OSMO_GSUP_SM_RP_RPI ('17'O),
+
OSMO_GSUP_RAND_IE   ('20'O),
OSMO_GSUP_SRES_IE   ('21'O),
OSMO_GSUP_KC_IE ('22'O),
@@ -75,7 +80,12 @@

OSMO_GSUP_MSGT_PROC_SS_REQUEST  ('0010'B),
OSMO_GSUP_MSGT_PROC_SS_ERROR('0011'B),
-   OSMO_GSUP_MSGT_PROC_SS_RESULT   ('00100010'B)
+   OSMO_GSUP_MSGT_PROC_SS_RESULT   ('00100010'B),
+
+   /* FIXME: 0b001001? any ideas? */
+   OSMO_GSUP_MSGT_SRI_FOR_SM_REQUEST   ('00100100'B),
+   OSMO_GSUP_MSGT_SRI_FOR_SM_ERROR ('00100101'B),
+   OSMO_GSUP_MSGT_SRI_FOR_SM_RESULT('00100110'B)
 } with { variant "FIELDLENGTH(8)" };

 type enumerated GSUP_CancelType {
@@ -128,6 +138,9 @@
 session_state, tag = 
OSMO_GSUP_SESSION_STATE_IE;
 session_id, tag = OSMO_GSUP_SESSION_ID_IE;
 ss_info, tag = OSMO_GSUP_SS_INFO_IE;
+smsc_addr, tag = OSMO_GSUP_SMSC_ADDR;
+node_addr, tag = OSMO_GSUP_NODE_ADDR;
+sm_rp_rpi, tag = OSMO_GSUP_SM_RP_RPI;
)"
 };

@@ -161,7 +174,11 @@
GSUP_SessionState   session_state,
OCT4session_id,
/* Supplementary Services */
-   octetstring ss_info
+   octetstring ss_info,
+   /* Short Message Service */
+   octetstring smsc_addr, /* FIXME: octetstring? */
+   octetstring node_addr, /* FIXME: octetstring? */
+   boolean sm_rp_rpi /* FIXME: boolean? */
 };

 type record GSUP_PDU {
@@ -593,6 +610,51 @@
}
 }

+template (value) GSUP_IE ts_GSUP_IE_SMSC_ADDR(octetstring addr) := {
+   tag := OSMO_GSUP_SMSC_ADDR,
+   len := 0, /* overwritten */
+   val := {
+   smsc_addr := addr
+   }
+}
+template GSUP_IE tr_GSUP_IE_SMSC_ADDR(template octetstring addr) := {
+   tag := OSMO_GSUP_SMSC_ADDR,
+   len := ?,
+   val := {
+   smsc_addr := addr
+   }
+}
+
+template (value) GSUP_IE ts_GSUP_IE_NODE_ADDR(octetstring addr) := {
+   tag := OSMO_GSUP_NODE_ADDR,
+   len := 0, /* overwritten */
+   val := {
+   node_addr := addr
+   }
+}
+template GSUP_IE tr_GSUP_IE_NODE_ADDR(template octetstring addr) := {
+   tag := OSMO_GSUP_NODE_ADDR,
+   len := ?,
+   val := {
+   node_addr := addr
+   }
+}
+
+template (value) GSUP_IE ts_GSUP_IE_SM_RP_RPI(boolean val) := {
+   tag := OSMO_GSUP_SM_RP_RPI,
+   len := 0, /* overwritten */
+   val := {
+   sm_rp_rpi := val
+   }
+}
+template GSUP_IE tr_GSUP_IE_SM_RP_RPI(template boolean val) := {
+   tag := OSMO_GSUP_SM_RP_RPI,
+   len := ?,
+   val := {
+   sm_rp_rpi := val
+   }
+}
+
 template (value) GSUP_IE ts_GSUP_IE_SSInfo(octetstring ss) := {
tag := OSMO_GSUP_SS_INFO_IE,
len := 0, /* overwritten */
@@ -714,6 +776,83 @@
}
 );

+template (value) GSUP_PDU ts_GSUP_SRI_FOR_SM_REQ(

Change in osmo-bts[master]: lc15: led_sleep_cb: pass correct ptr to llist_move_tail

2018-09-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9534 )

Change subject: lc15: led_sleep_cb: pass correct ptr to llist_move_tail
..

lc15: led_sleep_cb: pass correct ptr to llist_move_tail

Fix compilation warning. At runtime it's not a big issue because the
"list" field is the first field of the led_list (struct
lc15bts_led_timer_list) variable. Hence, the address passed is the same.

Change-Id: Ib8bf07990800d74bfb3ad7a55eccfc65e40cd480
---
M src/osmo-bts-litecell15/misc/lc15bts_led.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bts-litecell15/misc/lc15bts_led.c 
b/src/osmo-bts-litecell15/misc/lc15bts_led.c
index 603e0fb..a93d3fb 100644
--- a/src/osmo-bts-litecell15/misc/lc15bts_led.c
+++ b/src/osmo-bts-litecell15/misc/lc15bts_led.c
@@ -151,7 +151,7 @@
/* Delete current timer */
osmo_timer_del(_list->led_timer.timer);
/* Rotate the timer list */
-llist_move_tail(led_list, >lc15bts_leds.list);
+llist_move_tail(_list->list, 
>lc15bts_leds.list);
break;
}
}

--
To view, visit https://gerrit.osmocom.org/9534
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8bf07990800d74bfb3ad7a55eccfc65e40cd480
Gerrit-Change-Number: 9534
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-bsc[master]: codec_pref: handle S0-S15 in ASSIGNMENT REQUEST

2018-09-21 Thread dexter

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11060

to look at the new patch set (#3).

Change subject: codec_pref: handle S0-S15 in ASSIGNMENT REQUEST
..

codec_pref: handle S0-S15 in ASSIGNMENT REQUEST

Opposed to all other codecs that are common in GSM, AMR requires a codec
configuration that is expressed by a bitmask (S0 to S15) in the speech
codec list in the ASSIGNMENT REQUEST. Also the BSC acknowledges those
configuration in the ASSIGNMENT COMPLETE message.

At the moment osmo-bsc ignores all incoming configuration bits. The bits
in the ASSIGNMENT COMPLETE speech codec (choosen) field are hardcoded.

- Store the configuration bits while parsing the ASSIGNMENT COMPLETE
- Create an intersection with the configuration that is actually
  supported by the BSS
- Return the resulting (choosen) configuration bits with the assignment
  complete message.

Change-Id: I2d8ded51b3eb4c003fe2da6f2d6f48d001b73737
Related: OS#3529
---
M include/osmocom/bsc/codec_pref.h
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/assignment_fsm.c
M src/osmo-bsc/codec_pref.c
M src/osmo-bsc/handover_fsm.c
M src/osmo-bsc/osmo_bsc_bssap.c
M tests/codec_pref/codec_pref_test.c
M tests/codec_pref/codec_pref_test.ok
8 files changed, 139 insertions(+), 99 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/60/11060/3
--
To view, visit https://gerrit.osmocom.org/11060
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d8ded51b3eb4c003fe2da6f2d6f48d001b73737
Gerrit-Change-Number: 11060
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #253

2018-09-21 Thread jenkins

See 


--
[...truncated 3.74 KB...]
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style

Change in libosmocore[master]: gsm0808_utils: constify parameter

2018-09-21 Thread dexter

dexter has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11049 )

Change subject: gsm0808_utils: constify parameter
..

gsm0808_utils: constify parameter

parameter cfg in gsm0808_sc_cfg_from_gsm48_mr_cfg() is used read only.
Lets add a const to make this clear to the compiler.

Change-Id: I31e8d273b070b0afc446a298299d4f502d6c396b
---
M include/osmocom/gsm/gsm0808_utils.h
M src/gsm/gsm0808_utils.c
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocom/gsm/gsm0808_utils.h 
b/include/osmocom/gsm/gsm0808_utils.h
index 0a7429e..8746ceb 100644
--- a/include/osmocom/gsm/gsm0808_utils.h
+++ b/include/osmocom/gsm/gsm0808_utils.h
@@ -104,7 +104,7 @@
 int gsm0808_chan_type_to_speech_codec(uint8_t perm_spch);
 int gsm0808_speech_codec_from_chan_type(struct gsm0808_speech_codec *sc,
uint8_t perm_spch);
-uint16_t gsm0808_sc_cfg_from_gsm48_mr_cfg(struct gsm48_multi_rate_conf *cfg, 
bool fr);
+uint16_t gsm0808_sc_cfg_from_gsm48_mr_cfg(const struct gsm48_multi_rate_conf 
*cfg, bool fr);

 /*! Return 3GPP TS 48.008 3.2.2.49 Current Channel Type 1 from enum 
gsm_chan_t. */
 static inline uint8_t gsm0808_current_channel_type_1(enum gsm_chan_t type)
diff --git a/src/gsm/gsm0808_utils.c b/src/gsm/gsm0808_utils.c
index 4b2a5f5..0d6938e 100644
--- a/src/gsm/gsm0808_utils.c
+++ b/src/gsm/gsm0808_utils.c
@@ -1166,7 +1166,7 @@
  *  \param[in] cfg AMR configuration in GSM 04.08 format.
  *  \param[in] hint if the resulting configuration shall be used with a FR or 
HR TCH.
  *  \returns configuration bits (S0-S15) */
-uint16_t gsm0808_sc_cfg_from_gsm48_mr_cfg(struct gsm48_multi_rate_conf *cfg,
+uint16_t gsm0808_sc_cfg_from_gsm48_mr_cfg(const struct gsm48_multi_rate_conf 
*cfg,
  bool fr)
 {
uint16_t s15_s0 = 0;

--
To view, visit https://gerrit.osmocom.org/11049
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I31e8d273b070b0afc446a298299d4f502d6c396b
Gerrit-Change-Number: 11049
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: dexter

Change in osmo-bsc[master]: codec_pref: handle S0-S15 in ASSIGNMENT REQUEST

2018-09-21 Thread dexter

dexter has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/11060 )

Change subject: codec_pref: handle S0-S15 in ASSIGNMENT REQUEST
..

codec_pref: handle S0-S15 in ASSIGNMENT REQUEST

Opposed to all other codecs that are common in GSM, AMR requires a codec
configuration that is expressed by a bitmask (S0 to S15) in the speech
codec list in the ASSIGNMENT REQUEST. Also the BSC acknowledges those
configuration in the ASSIGNMENT COMPLETE message.

At the moment osmo-bsc ignores all incoming configuration bits. The bits
in the ASSIGNMENT COMPLETE speech codec (choosen) field are hardcoded.

- Store the configuration bits while parsing the ASSIGNMENT COMPLETE
- Create an intersection with the configuration that is actually
  supported by the BSS
- Return the resulting (choosen) configuration bits with the assignment
  complete message.

Change-Id: I2d8ded51b3eb4c003fe2da6f2d6f48d001b73737
Related: OS#3529
---
M include/osmocom/bsc/codec_pref.h
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/assignment_fsm.c
M src/osmo-bsc/codec_pref.c
M src/osmo-bsc/handover_fsm.c
M src/osmo-bsc/osmo_bsc_bssap.c
M tests/codec_pref/codec_pref_test.c
7 files changed, 89 insertions(+), 50 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/60/11060/2
--
To view, visit https://gerrit.osmocom.org/11060
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d8ded51b3eb4c003fe2da6f2d6f48d001b73737
Gerrit-Change-Number: 11060
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-CC: Jenkins Builder (102)

Change in osmo-bsc[master]: assignment_fsm: only include speech codec (choosen) on AoIP networks

2018-09-21 Thread dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11059


Change subject: assignment_fsm: only include speech codec (choosen) on AoIP 
networks
..

assignment_fsm: only include speech codec (choosen) on AoIP networks

The field speech codec (choosen) in the ASSIGNMENT COMPLETE message
has been specified with AoIP. Since sccp-lite has been specified before
AoIP, we should not include the speech codec (choosen) field in the
ASSIGNMENT COMPLETE, when osmo-bsc is connected to an sccp-lite based
network.

- make sure speech codec (choosen) is only included on AoIP based
  networks

Change-Id: Ic7f28aacc953d96ebf3aa04f3e1810475458c1a8
---
M src/osmo-bsc/assignment_fsm.c
1 file changed, 8 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/59/11059/1

diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c
index 63776f0..5304d6c 100644
--- a/src/osmo-bsc/assignment_fsm.c
+++ b/src/osmo-bsc/assignment_fsm.c
@@ -165,10 +165,14 @@
addr_local_p = _local;
}

-   /* Extrapolate speech codec from speech mode */
-   /* FIXME: AMR codec configuration must be derived from lchan1! 
*/
-   gsm0808_speech_codec_from_chan_type(, perm_spch);
-   sc_ptr = 
+   /* Only AoIP networks include a speech codec (choosen) in the
+* assignment complete message. */
+   if (gscon_is_aoip(conn)) {
+   /* Extrapolate speech codec from speech mode */
+   /* FIXME: AMR codec configuration must be derived from 
lchan1! */
+   gsm0808_speech_codec_from_chan_type(, perm_spch);
+   sc_ptr = 
+   }
}

resp = gsm0808_create_ass_compl(lchan->abis_ip.ass_compl.rr_cause,

--
To view, visit https://gerrit.osmocom.org/11059
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7f28aacc953d96ebf3aa04f3e1810475458c1a8
Gerrit-Change-Number: 11059
Gerrit-PatchSet: 1
Gerrit-Owner: dexter

Change in osmo-bsc[master]: gsm_data.c: Set reasonable AMR codec defaults in gsm_bts_alloc()

2018-09-21 Thread dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11058


Change subject: gsm_data.c: Set reasonable AMR codec defaults in gsm_bts_alloc()
..

gsm_data.c: Set reasonable AMR codec defaults in gsm_bts_alloc()

At the moment we do not initalize the struct members mr_full and mr_half
in struct gsm_bts. The user still has the option to configure reasonable
values via vty, but when not VTY configuration is made, the flags for
the AMR rates will be all zero. Lets initalize the struct members with
reasonable defaults.

- Make sure gsm_bts_alloc() populates fr_half and fr_full with
  reasonable defaults.

Change-Id: I68747ae6dd2582e2a7d60337d9f2c43bd06ac525
Related: OS#3548
---
M src/osmo-bsc/gsm_data.c
1 file changed, 28 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/58/11058/1

diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c
index 0718e91..6b4e5a7 100644
--- a/src/osmo-bsc/gsm_data.c
+++ b/src/osmo-bsc/gsm_data.c
@@ -774,6 +774,7 @@
 struct gsm_bts *gsm_bts_alloc(struct gsm_network *net, uint8_t bts_num)
 {
struct gsm_bts *bts = talloc_zero(net, struct gsm_bts);
+   struct gsm48_multi_rate_conf mr_cfg;
int i;

if (!bts)
@@ -885,6 +886,33 @@
.amr = 1,
};

+   /* Set reasonable defaults for AMR-FR and AMR-HR rate configuration.
+   *  See also: 3GPP TS 28.062, Table 7.11.3.1.3-2: Preferred 
Configurations for
+   *  the Adaptive Multi-Rate Codec Types. */
+   mr_cfg = (struct gsm48_multi_rate_conf) {
+   .m4_75 = 1,
+   .m5_15 = 1,
+   .m5_90 = 1,
+   .m6_70 = 1,
+   .m7_40 = 1,
+   .m7_95 = 1,
+   .m10_2 = 1,
+   .m12_2 = 1
+   };
+   memcpy(bts->mr_full.gsm48_ie, _cfg, sizeof(bts->mr_full.gsm48_ie));
+
+   mr_cfg = (struct gsm48_multi_rate_conf) {
+   .m4_75 = 1,
+   .m5_15 = 1,
+   .m5_90 = 1,
+   .m6_70 = 1,
+   .m7_40 = 1,
+   .m7_95 = 1,
+   .m10_2 = 0,
+   .m12_2 = 0
+   };
+   memcpy(bts->mr_half.gsm48_ie, _cfg, sizeof(bts->mr_half.gsm48_ie));
+
return bts;
 }


--
To view, visit https://gerrit.osmocom.org/11058
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I68747ae6dd2582e2a7d60337d9f2c43bd06ac525
Gerrit-Change-Number: 11058
Gerrit-PatchSet: 1
Gerrit-Owner: dexter

Change in osmo-bsc[master]: codec_pref: handle S0-S15 in ASSIGNMENT REQUEST

2018-09-21 Thread dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11060


Change subject: codec_pref: handle S0-S15 in ASSIGNMENT REQUEST
..

codec_pref: handle S0-S15 in ASSIGNMENT REQUEST

Opposed to all other codecs that are common in GSM, AMR requires a codec
configuration that is expressed by a bitmask (S0 to S15) in the speech
codec list in the ASSIGNMENT REQUEST. Also the BSC acknowledges those
configuration in the ASSIGNMENT COMPLETE message.

At the moment osmo-bsc ignores all incoming configuration bits. The bits
in the ASSIGNMENT COMPLETE speech codec (choosen) field are hardcoded.

- Store the configuration bits while parsing the ASSIGNMENT COMPLETE
- Create an intersection with the configuration that is actually
  supported by the BSS
- Return the resulting (choosen) configuration bits with the assignment
  complete message.

Change-Id: I2d8ded51b3eb4c003fe2da6f2d6f48d001b73737
Related: OS#3529
---
M include/osmocom/bsc/codec_pref.h
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/assignment_fsm.c
M src/osmo-bsc/codec_pref.c
M src/osmo-bsc/handover_fsm.c
M src/osmo-bsc/osmo_bsc_bssap.c
M tests/codec_pref/codec_pref_test.c
7 files changed, 89 insertions(+), 50 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/60/11060/1

diff --git a/include/osmocom/bsc/codec_pref.h b/include/osmocom/bsc/codec_pref.h
index 09aaa60..3085ad4 100644
--- a/include/osmocom/bsc/codec_pref.h
+++ b/include/osmocom/bsc/codec_pref.h
@@ -12,11 +12,11 @@

 int match_codec_pref(enum gsm48_chan_mode *chan_mode,
 bool *full_rate,
+uint16_t *s15_s0,
 const struct gsm0808_channel_type *ct,
 const struct gsm0808_speech_codec_list *scl,
-struct gsm_audio_support * const *audio_support,
-int audio_length,
-const struct bts_codec_conf *bts_codec);
+const struct bsc_msc_data *msc,
+const struct gsm_bts *bts);

 void gen_bss_supported_codec_list(struct gsm0808_speech_codec_list *scl,
  const struct bsc_msc_data *msc,
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 33a5a8d..7c91e59 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -109,6 +109,7 @@

enum gsm48_chan_mode chan_mode;
bool full_rate;
+   uint16_t s15_s0;
 };

 struct assignment_fsm_data {
diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c
index 5304d6c..221657e 100644
--- a/src/osmo-bsc/assignment_fsm.c
+++ b/src/osmo-bsc/assignment_fsm.c
@@ -169,8 +169,8 @@
 * assignment complete message. */
if (gscon_is_aoip(conn)) {
/* Extrapolate speech codec from speech mode */
-   /* FIXME: AMR codec configuration must be derived from 
lchan1! */
gsm0808_speech_codec_from_chan_type(, perm_spch);
+   sc.cfg = conn->assignment.req.s15_s0;
sc_ptr = 
}
}
diff --git a/src/osmo-bsc/codec_pref.c b/src/osmo-bsc/codec_pref.c
index c998e60..7aa5130 100644
--- a/src/osmo-bsc/codec_pref.c
+++ b/src/osmo-bsc/codec_pref.c
@@ -94,14 +94,18 @@
  * matches one of the permitted speech settings of the channel type element.
  * The matched permitted speech value is then also compared against the
  * speech codec list. (optional, only relevant for AoIP) */
-static bool test_codec_pref(const struct gsm0808_channel_type *ct,
-   const struct gsm0808_speech_codec_list *scl, 
uint8_t perm_spch)
+static bool test_codec_pref(const struct gsm0808_speech_codec **sc_match,
+   const struct gsm0808_speech_codec_list *scl,
+   const struct gsm0808_channel_type *ct,
+   uint8_t perm_spch)
 {
unsigned int i;
bool match = false;
struct gsm0808_speech_codec sc;
int rc;

+   *sc_match = NULL;
+
/* Try to find the given permitted speech value in the
 * codec list of the channel type element */
for (i = 0; i < ct->perm_spch_len; i++) {
@@ -129,8 +133,10 @@
/* Try to find extrapolated speech codec data in
 * the speech codec list */
for (i = 0; i < scl->len; i++) {
-   if (sc.type == scl->codec[i].type)
+   if (sc.type == scl->codec[i].type) {
+   *sc_match = >codec[i];
return true;
+   }
}

return false;
@@ -168,40 +174,74 @@
return false;
 }

+/* Helper function to generate the bss supported amr configuration bits 
(S0-S15) */
+static uint16_t gen_bss_supported_amr_s15_s0(const struct bsc_msc_data *msc, 
const struct gsm_bts *bts, bool hr)
+{
+   const

Change in osmocom-bb[master]: layer23/l1ctl.c: replace printf() calls by LOGP

2018-09-21 Thread Vadim Yanitskiy

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/11057


Change subject: layer23/l1ctl.c: replace printf() calls by LOGP
..

layer23/l1ctl.c: replace printf() calls by LOGP

Change-Id: I863fb668500b2010dfef7a63217255fd010c06d7
---
M src/host/layer23/src/common/l1ctl.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/57/11057/1

diff --git a/src/host/layer23/src/common/l1ctl.c 
b/src/host/layer23/src/common/l1ctl.c
index 78e340b..eedfb93 100644
--- a/src/host/layer23/src/common/l1ctl.c
+++ b/src/host/layer23/src/common/l1ctl.c
@@ -194,7 +194,7 @@
if (meas->dsc > meas->ds_fail)
meas->dsc = meas->ds_fail;
if (meas->dsc < meas->ds_fail)
-   printf("LOSS counter for CCCH %d\n", meas->dsc);
+   LOGP(DL1C, LOGL_INFO, "LOSS counter for CCCH 
%d\n", meas->dsc);
if (meas->dsc > 0)
break;
meas->ds_fail = 0;
@@ -216,7 +216,7 @@
if (meas->s > meas->rl_fail)
meas->s = meas->rl_fail;
if (meas->s < meas->rl_fail)
-   printf("LOSS counter for ACCH %d\n", meas->s);
+   LOGP(DL1C, LOGL_NOTICE, "LOSS counter for ACCH 
%d\n", meas->s);
if (meas->s > 0)
break;
meas->rl_fail = 0;

--
To view, visit https://gerrit.osmocom.org/11057
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I863fb668500b2010dfef7a63217255fd010c06d7
Gerrit-Change-Number: 11057
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy

Change in osmocom-bb[master]: layer23/l1ctl.c: drop redundant printf() call

2018-09-21 Thread Vadim Yanitskiy

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/11056


Change subject: layer23/l1ctl.c: drop redundant printf() call
..

layer23/l1ctl.c: drop redundant printf() call

Change-Id: I02bc581afb5a76c51fdef50ed40e2669c3eb3f2e
---
M src/host/layer23/src/common/l1ctl.c
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/56/11056/1

diff --git a/src/host/layer23/src/common/l1ctl.c 
b/src/host/layer23/src/common/l1ctl.c
index 3c57042..78e340b 100644
--- a/src/host/layer23/src/common/l1ctl.c
+++ b/src/host/layer23/src/common/l1ctl.c
@@ -226,7 +226,6 @@
}

if (dl->fire_crc >= 2) {
-printf("Dropping frame with %u bit errors\n", dl->num_biterr);
LOGP(DL1C, LOGL_NOTICE, "Dropping frame with %u bit errors\n",
dl->num_biterr);
msgb_free(msg);

--
To view, visit https://gerrit.osmocom.org/11056
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I02bc581afb5a76c51fdef50ed40e2669c3eb3f2e
Gerrit-Change-Number: 11056
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy

Change in osmo-ttcn3-hacks[master]: BSC_Tests: use consistant AMR S0-S15 bits

2018-09-21 Thread dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11055


Change subject: BSC_Tests: use consistant AMR S0-S15 bits
..

BSC_Tests: use consistant AMR S0-S15 bits

At the moment we use the default S0-S15 bits for the AMR config,
regardless what RSL_IE_Body mr_conf or osmo-bsc.cfg sets.

- Make sure consistant S0-S15 bits are used for AMR related tests.

Change-Id: I794e6d4fe8abc67337428cbe0bcc8802fae37a6e
---
M bsc/BSC_Tests.ttcn
1 file changed, 16 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/55/11055/1

diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index a99214b..9a43ead 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -1905,6 +1905,10 @@
 testcase TC_assignment_codec_amr_f() runs on test_CT {
var TestHdlrParams pars := valueof(t_def_TestHdlrPars);
var MSC_ConnHdlr vc_conn;
+
+   /* Note: This setups the codec configuration. The parameter payload in
+* mr_conf must be consistant with the parameter codecElements in pars
+* and also must match the amr-config in osmo-bsc.cfg! */
var RSL_IE_Body mr_conf := {
other := {
len := 2,
@@ -1912,11 +1916,14 @@
}
};

+   pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_F}));
+   pars.ass_codec_list.codecElements[0].s0_7 := '0110'B;
+   pars.ass_codec_list.codecElements[0].s8_15 := '01010111'B;
+   pars.expect_mr_conf_ie := mr_conf;
+
f_init(1, true);
f_sleep(1.0);

-   pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_F}));
-   pars.expect_mr_conf_ie := mr_conf;
vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);
vc_conn.done;
 }
@@ -1924,6 +1931,8 @@
 testcase TC_assignment_codec_amr_h() runs on test_CT {
var TestHdlrParams pars := valueof(t_def_TestHdlrPars);
var MSC_ConnHdlr vc_conn;
+
+   /* See note above */
var RSL_IE_Body mr_conf := {
other := {
len := 2,
@@ -1931,11 +1940,14 @@
}
};

+   pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_H}));
+   pars.ass_codec_list.codecElements[0].s0_7 := '0110'B;
+   pars.ass_codec_list.codecElements[0].s8_15 := '0111'B;
+   pars.expect_mr_conf_ie := mr_conf;
+
f_init(1, true);
f_sleep(1.0);

-   pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_H}));
-   pars.expect_mr_conf_ie := mr_conf;
vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);
vc_conn.done;
 }

--
To view, visit https://gerrit.osmocom.org/11055
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I794e6d4fe8abc67337428cbe0bcc8802fae37a6e
Gerrit-Change-Number: 11055
Gerrit-PatchSet: 1
Gerrit-Owner: dexter

Change in osmo-ci[master]: jobs: osmo-gsm-tester_run-gerrit: Update suites selected for verifica...

2018-09-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11038 )

Change subject: jobs: osmo-gsm-tester_run-gerrit: Update suites selected for 
verification
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/11038
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iafe865ab5f607fc8acfcb3f72ebe4b0ef0f1322a
Gerrit-Change-Number: 11038
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 21 Sep 2018 13:46:11 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: jobs: osmo-gsm-tester: Add osmo-iuh builds

2018-09-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11029 )

Change subject: jobs: osmo-gsm-tester: Add osmo-iuh builds
..


Patch Set 2: Verified+1


--
To view, visit https://gerrit.osmocom.org/11029
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b8f51597287e7673f79c65eae2508b074151781
Gerrit-Change-Number: 11029
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 21 Sep 2018 13:46:03 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: jobs: osmo-gsm-tester: Copy osmocom-bb build artifact

2018-09-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11030 )

Change subject: jobs: osmo-gsm-tester: Copy osmocom-bb build artifact
..


Patch Set 2: Verified+1


--
To view, visit https://gerrit.osmocom.org/11030
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fe41e2c7d9c38796ce16f2f279792bc5151b498
Gerrit-Change-Number: 11030
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 21 Sep 2018 13:46:07 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: osmo-depcheck: don't use /tmp, better git code

2018-09-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11053 )

Change subject: osmo-depcheck: don't use /tmp, better git code
..


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/11053/1/scripts/osmo-depcheck/dependencies.py
File scripts/osmo-depcheck/dependencies.py:

https://gerrit.osmocom.org/#/c/11053/1/scripts/osmo-depcheck/dependencies.py@46
PS1, Line 46: try:
This part probably belongs to a separate specific feature, and could easily go 
into a different patch.



--
To view, visit https://gerrit.osmocom.org/11053
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06589277b9d54a2af177451cfab2ca1a658b4058
Gerrit-Change-Number: 11053
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Fri, 21 Sep 2018 13:08:54 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: osmo-depcheck: don't use /tmp, better git code

2018-09-21 Thread osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/11053 )

Change subject: osmo-depcheck: don't use /tmp, better git code
..


Patch Set 1: Verified+1

Tested locally and with Jenkins:
https://jenkins.osmocom.org/jenkins/job/Osmocom-depcheck/5/


--
To view, visit https://gerrit.osmocom.org/11053
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06589277b9d54a2af177451cfab2ca1a658b4058
Gerrit-Change-Number: 11053
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Fri, 21 Sep 2018 13:05:14 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sip-connector[master]: Fix typo in -h: s/hekp/help

2018-09-21 Thread Neels Hofmeyr

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11051 )

Change subject: Fix typo in -h: s/hekp/help
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11051
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5336212845acc221d50d0aa30613723b9868
Gerrit-Change-Number: 11051
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 21 Sep 2018 13:09:27 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sip-connector[master]: Fix typo in -h: s/hekp/help

2018-09-21 Thread Neels Hofmeyr

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11051 )

Change subject: Fix typo in -h: s/hekp/help
..

Fix typo in -h: s/hekp/help

Change-Id: I5336212845acc221d50d0aa30613723b9868
---
M src/main.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Neels Hofmeyr: Looks good to me, approved



diff --git a/src/main.c b/src/main.c
index c267f5f..560995e 100644
--- a/src/main.c
+++ b/src/main.c
@@ -79,7 +79,7 @@
 static void print_help(void)
 {
printf("OsmoSIPcon: MNCC to SIP bridge\n");
-   printf("  -h --hekp\tthis text\n");
+   printf("  -h --help\tthis text\n");
printf("  -c --config-file NAME\tThe config file to use [%s]\n", 
config_file);
 }


--
To view, visit https://gerrit.osmocom.org/11051
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5336212845acc221d50d0aa30613723b9868
Gerrit-Change-Number: 11051
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-gsm-tester[master]: default-suites.conf: Add empty lines to easily spot different sections

2018-09-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11054


Change subject: default-suites.conf: Add empty lines to easily spot different 
sections
..

default-suites.conf: Add empty lines to easily spot different sections

Change-Id: If33fa9be091113d57b25dc3d73e277bbb3b0ce5a
---
M example/default-suites.conf
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/54/11054/1

diff --git a/example/default-suites.conf b/example/default-suites.conf
index 74f54a2..14e30d4 100644
--- a/example/default-suites.conf
+++ b/example/default-suites.conf
@@ -14,6 +14,7 @@
 - gprs:sysmo+mod-bts0-dynts-osmo
 - dynts:sysmo+mod-bts0-dynts67-ipa.conf+cfg-codec-fr1
 - dynts:sysmo+mod-bts0-dynts67-osmo.conf+cfg-codec-fr1
+
 - nitb_sms:trx-b200
 - sms:trx-b200
 - nitb_ussd:trx-b200
@@ -30,6 +31,7 @@
 - gprs:trx-b200+mod-bts0-dynts-osmo
 - dynts:trx-b200+mod-bts0-dynts67-ipa.conf+cfg-codec-fr1
 - dynts:trx-b200+mod-bts0-dynts67-osmo.conf+cfg-codec-fr1
+
 - nitb_sms:trx-sysmocell5000
 - sms:trx-sysmocell5000
 - nitb_ussd:trx-sysmocell5000
@@ -46,6 +48,7 @@
 - gprs:trx-sysmocell5000+mod-bts0-dynts-osmo
 - dynts:trx-sysmocell5000+mod-bts0-dynts67-ipa.conf+cfg-codec-fr1
 - dynts:trx-sysmocell5000+mod-bts0-dynts67-osmo.conf+cfg-codec-fr1
+
 - nitb_sms:nanobts
 - sms:nanobts+band-1900
 - nitb_ussd:nanobts+band-1900
@@ -58,6 +61,7 @@
 - gprs:nanobts+band-1900
 - gprs:nanobts+band-1900+mod-bts0-dynts-ipa
 - dynts:nanobts+band-1900+mod-bts0-dynts67-ipa.conf+cfg-codec-fr1
+
 - sms:nanobts+band-900
 - nitb_ussd:nanobts+band-900
 - ussd:nanobts+band-900
@@ -71,6 +75,7 @@
 - gprs:nanobts+band-900+mod-bts0-dynts-ipa
 - gprs:nanobts+band-900+mod-bts0-numtrx2+mod-bts0-chanallocdescend
 - dynts:nanobts+band-900+mod-bts0-dynts67-ipa.conf+cfg-codec-fr1
+
 - nitb_smpp
 - smpp
 - encryption

--
To view, visit https://gerrit.osmocom.org/11054
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If33fa9be091113d57b25dc3d73e277bbb3b0ce5a
Gerrit-Change-Number: 11054
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol

Change in osmo-ci[master]: osmo-depcheck: don't use /tmp, better git code

2018-09-21 Thread osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11053


Change subject: osmo-depcheck: don't use /tmp, better git code
..

osmo-depcheck: don't use /tmp, better git code

* replace --gitdir with --workdir and give it a new folder structure:
  * git/$repo: downloaded source code
  * build/$repo: files created during the build process
  * install/: installation prefix
* adjust the jenkins job to use --workdir
* fetch --tags when source exists already
* readable error message for failed git checkout

Change-Id: I06589277b9d54a2af177451cfab2ca1a658b4058
Relates: OS#2642
---
M jobs/osmocom-depcheck.yml
M scripts/osmo-depcheck/buildstack.py
M scripts/osmo-depcheck/dependencies.py
M scripts/osmo-depcheck/osmo-depcheck.py
M scripts/osmo-depcheck/parse.py
5 files changed, 96 insertions(+), 68 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/53/11053/1

diff --git a/jobs/osmocom-depcheck.yml b/jobs/osmocom-depcheck.yml
index f13d4b7..fd2432e 100644
--- a/jobs/osmocom-depcheck.yml
+++ b/jobs/osmocom-depcheck.yml
@@ -52,13 +52,13 @@
   # Build the arguments
   args="$PROJECTS"
   args="$args -j 5"
-  args="$args -g $PWD/DEPCHECK_GITDIR"
+  args="$args -w $PWD/DEPCHECK_WORKDIR"
   args="$args -u $GIT_URL_PREFIX"
   [ "$BUILD" = "true" ] && args="$args -b"
   [ "$PRINT_OLD_DEPENDS" = "true" ] && args="$args -o"

   # Run osmo-depcheck
-  mkdir DEPCHECK_GITDIR
+  mkdir DEPCHECK_WORKDIR
   export PYTHONUNBUFFERED=1
   scripts/osmo-depcheck/osmo-depcheck.py $args
 scm:
diff --git a/scripts/osmo-depcheck/buildstack.py 
b/scripts/osmo-depcheck/buildstack.py
index 87210ab..0a9a011 100644
--- a/scripts/osmo-depcheck/buildstack.py
+++ b/scripts/osmo-depcheck/buildstack.py
@@ -70,29 +70,15 @@
 print(" * " + program + ":" + version)


-def temp_install_folder():
-""" Generate a temporary installation folder
-
-It will be used as configure prefix, so when running 'make install',
-the files will get copied in there instead of "/usr/local/". The folder
-will get removed when the script has finished.
-
-:returns: the path to the temporary folder """
-ret = tempfile.mkdtemp(prefix="depcheck_")
-atexit.register(shutil.rmtree, ret)
-print("Temporary install folder: " + ret)
-return ret
-
-
-def set_environment(jobs, tempdir):
+def set_environment(jobs, prefix):
 """ Configure the environment variables before running configure, make etc.

 :param jobs: parallel build jobs (for make)
-:param tempdir: temporary installation dir (see temp_install_folder())
+:param prefix: installation folder
 """
-# Add tempdir to PKG_CONFIG_PATH and LD_LIBRARY_PATH
-extend = {"PKG_CONFIG_PATH": tempdir + "/lib/pkgconfig",
-  "LD_LIBRARY_PATH": tempdir + "/lib"}
+# Add prefix to PKG_CONFIG_PATH and LD_LIBRARY_PATH
+extend = {"PKG_CONFIG_PATH": prefix + "/lib/pkgconfig",
+  "LD_LIBRARY_PATH": prefix + "/lib"}
 for env_var, folder in extend.items():
 old = os.environ[env_var] if env_var in os.environ else ""
 os.environ[env_var] = old + ":" + folder
@@ -101,10 +87,10 @@
 os.environ["JOBS"] = str(jobs)


-def build(gitdir, jobs, stack):
+def build(workdir, jobs, stack):
 """ Build one program with all its dependencies.

-:param gitdir: folder to which the sources will be cloned
+:param workdir: path to where all data (git, build, install) is stored
 :param jobs: parallel build jobs (for make)
 :param stack: the build stack as returned by generate() above

@@ -122,18 +108,23 @@
   anymore in case they decide to compile the code again manually from
   the source folder. """
 # Prepare the install folder and environment
-tempdir = temp_install_folder()
-unitdir = tempdir + "/lib/systemd/system/"
-set_environment(jobs, tempdir)
+prefix = workdir + "/install"
+unitdir = prefix + "/lib/systemd/system/"
+set_environment(jobs, prefix)

 # Iterate over stack
 for program, version in stack.items():
 print("Building " + program + ":" + version)
-os.chdir(gitdir + "/" + program)
+
+# Create and enter the build folder
+builddir = workdir + "/build/" + program
+os.mkdir(builddir)
+os.chdir(builddir)

 # Run the build commands
-commands = [["autoreconf", "-fi"],
-["./configure", "--prefix", tempdir,
+gitdir = workdir + "/git/" + program
+commands = [["autoreconf", "-fi", gitdir],
+[gitdir + "/configure", "--prefix", prefix,
  "--with-systemdsystemunitdir=" + unitdir],
 ["make", "clean"],
 ["make"],
diff --git

Change in osmo-gsm-tester[master]: Add dynts suite to test switch between PDCH and TCH

2018-09-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11052


Change subject: Add dynts suite to test switch between PDCH and TCH
..

Add dynts suite to test switch between PDCH and TCH

It seems for not yet clear reasons the MS require some time after the
PDCH channels have been activated again to use them reliably. If no
sleep is used between call hangup and gprs activate pdp ctx, the MS
fails to activate the pdp ctx due to QMI error respone to the "Start
network" requested.

Related: OS#2582
Change-Id: I73b51c31309ac4c28c64ed7eb7c8c649e535aa22
---
M example/default-suites.conf
A example/scenarios/mod-bts0-dynts67-ipa.conf
A example/scenarios/mod-bts0-dynts67-osmo.conf
A suites/dynts/suite.conf
A suites/dynts/switch_tch_pdch.py
5 files changed, 142 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/52/11052/1

diff --git a/example/default-suites.conf b/example/default-suites.conf
index 1857ba5..74f54a2 100644
--- a/example/default-suites.conf
+++ b/example/default-suites.conf
@@ -12,6 +12,8 @@
 - gprs:sysmo
 - gprs:sysmo+mod-bts0-dynts-ipa
 - gprs:sysmo+mod-bts0-dynts-osmo
+- dynts:sysmo+mod-bts0-dynts67-ipa.conf+cfg-codec-fr1
+- dynts:sysmo+mod-bts0-dynts67-osmo.conf+cfg-codec-fr1
 - nitb_sms:trx-b200
 - sms:trx-b200
 - nitb_ussd:trx-b200
@@ -26,6 +28,8 @@
 - gprs:trx-b200
 - gprs:trx-b200+mod-bts0-dynts-ipa
 - gprs:trx-b200+mod-bts0-dynts-osmo
+- dynts:trx-b200+mod-bts0-dynts67-ipa.conf+cfg-codec-fr1
+- dynts:trx-b200+mod-bts0-dynts67-osmo.conf+cfg-codec-fr1
 - nitb_sms:trx-sysmocell5000
 - sms:trx-sysmocell5000
 - nitb_ussd:trx-sysmocell5000
@@ -40,6 +44,8 @@
 - gprs:trx-sysmocell5000
 - gprs:trx-sysmocell5000+mod-bts0-dynts-ipa
 - gprs:trx-sysmocell5000+mod-bts0-dynts-osmo
+- dynts:trx-sysmocell5000+mod-bts0-dynts67-ipa.conf+cfg-codec-fr1
+- dynts:trx-sysmocell5000+mod-bts0-dynts67-osmo.conf+cfg-codec-fr1
 - nitb_sms:nanobts
 - sms:nanobts+band-1900
 - nitb_ussd:nanobts+band-1900
@@ -51,6 +57,7 @@
 - voice:nanobts+band-1900+mod-bts0-dynts-ipa
 - gprs:nanobts+band-1900
 - gprs:nanobts+band-1900+mod-bts0-dynts-ipa
+- dynts:nanobts+band-1900+mod-bts0-dynts67-ipa.conf+cfg-codec-fr1
 - sms:nanobts+band-900
 - nitb_ussd:nanobts+band-900
 - ussd:nanobts+band-900
@@ -63,6 +70,7 @@
 - gprs:nanobts+band-900
 - gprs:nanobts+band-900+mod-bts0-dynts-ipa
 - gprs:nanobts+band-900+mod-bts0-numtrx2+mod-bts0-chanallocdescend
+- dynts:nanobts+band-900+mod-bts0-dynts67-ipa.conf+cfg-codec-fr1
 - nitb_smpp
 - smpp
 - encryption
diff --git a/example/scenarios/mod-bts0-dynts67-ipa.conf 
b/example/scenarios/mod-bts0-dynts67-ipa.conf
new file mode 100644
index 000..087b3b0
--- /dev/null
+++ b/example/scenarios/mod-bts0-dynts67-ipa.conf
@@ -0,0 +1,13 @@
+modifiers:
+  bts:
+  - num_trx: 1
+trx_list:
+- timeslot_list:
+  - phys_chan_config: 'CCCH+SDCCH4'
+  - phys_chan_config: 'SDCCH8'
+  - phys_chan_config: 'SDCCH8'
+  - phys_chan_config: 'SDCCH8'
+  - phys_chan_config: 'SDCCH8'
+  - phys_chan_config: 'SDCCH8'
+  - phys_chan_config: 'TCH/F_PDCH'
+  - phys_chan_config: 'TCH/F_PDCH'
diff --git a/example/scenarios/mod-bts0-dynts67-osmo.conf 
b/example/scenarios/mod-bts0-dynts67-osmo.conf
new file mode 100644
index 000..3153120
--- /dev/null
+++ b/example/scenarios/mod-bts0-dynts67-osmo.conf
@@ -0,0 +1,13 @@
+modifiers:
+  bts:
+  - num_trx: 1
+trx_list:
+- timeslot_list:
+  - phys_chan_config: 'CCCH+SDCCH4'
+  - phys_chan_config: 'SDCCH8'
+  - phys_chan_config: 'SDCCH8'
+  - phys_chan_config: 'SDCCH8'
+  - phys_chan_config: 'SDCCH8'
+  - phys_chan_config: 'SDCCH8'
+  - phys_chan_config: 'TCH/F_TCH/H_PDCH'
+  - phys_chan_config: 'TCH/F_TCH/H_PDCH'
diff --git a/suites/dynts/suite.conf b/suites/dynts/suite.conf
new file mode 100644
index 000..3b32480
--- /dev/null
+++ b/suites/dynts/suite.conf
@@ -0,0 +1,10 @@
+resources:
+  ip_address:
+  - times: 8 # msc, bsc, hlr, stp, mgw*2, sgsn, ggsn
+  bts:
+  - times: 1
+  modem:
+  - times: 2
+features:
+- gprs
+- voice
diff --git a/suites/dynts/switch_tch_pdch.py b/suites/dynts/switch_tch_pdch.py
new file mode 100755
index 000..f0bbd38
--- /dev/null
+++ b/suites/dynts/switch_tch_pdch.py
@@ -0,0 +1,98 @@
+#!/usr/bin/env python3
+from osmo_gsm_tester.testenv import *
+
+
+def activate_pdp(ms_mo, ms_mt):
+# We need to use inet46 since ofono qmi only uses ipv4v6 eua (OS#2713)
+ctx_id_v4_mo = ms_mo.activate_context(apn='inet46', 
protocol=ms_mo.CTX_PROT_IPv4)
+print('ms_mo pdp ctx %r activated' % repr(ctx_id_v4_mo))
+ctx_id_v4_mt = ms_mt.activate_context(apn='inet46', 
protocol=ms_mt.CTX_PROT_IPv4)
+print('ms_mt pdp ctx %r activated' % repr(ctx_id_v4_mt))
+sleep(5)
+ms_mo.deactivate_context(ctx_id_v4_mo)
+ms_mt.deactivate_context(ctx_id_v4_mt)
+
+def make_call(ms_mo, ms_mt):
+assert

Change in osmo-sip-connector[master]: Fix typo in -h: s/hekp/help

2018-09-21 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11051 )

Change subject: Fix typo in -h: s/hekp/help
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11051
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5336212845acc221d50d0aa30613723b9868
Gerrit-Change-Number: 11051
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 21 Sep 2018 12:25:20 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sip-connector[master]: Fix typo in -h: s/hekp/help

2018-09-21 Thread osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11051


Change subject: Fix typo in -h: s/hekp/help
..

Fix typo in -h: s/hekp/help

Change-Id: I5336212845acc221d50d0aa30613723b9868
---
M src/main.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector 
refs/changes/51/11051/1

diff --git a/src/main.c b/src/main.c
index c267f5f..560995e 100644
--- a/src/main.c
+++ b/src/main.c
@@ -79,7 +79,7 @@
 static void print_help(void)
 {
printf("OsmoSIPcon: MNCC to SIP bridge\n");
-   printf("  -h --hekp\tthis text\n");
+   printf("  -h --help\tthis text\n");
printf("  -c --config-file NAME\tThe config file to use [%s]\n", 
config_file);
 }


--
To view, visit https://gerrit.osmocom.org/11051
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5336212845acc221d50d0aa30613723b9868
Gerrit-Change-Number: 11051
Gerrit-PatchSet: 1
Gerrit-Owner: osmith

Change in osmo-gsm-manuals[master]: osmotrx: Introduce code architecture chapter

2018-09-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11040 )

Change subject: osmotrx: Introduce code architecture chapter
..

osmotrx: Introduce code architecture chapter

Change-Id: I21084e6315d79a1adcb305e12343da218837dc31
---
A OsmoTRX/chapters/code-architecture.adoc
M OsmoTRX/osmotrx-usermanual.adoc
M common/chapters/trx_if.adoc
3 files changed, 145 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/OsmoTRX/chapters/code-architecture.adoc 
b/OsmoTRX/chapters/code-architecture.adoc
new file mode 100644
index 000..18d0e3a
--- /dev/null
+++ b/OsmoTRX/chapters/code-architecture.adoc
@@ -0,0 +1,141 @@
+[[code_architecture]]
+== Code Architecture
+
+[[fig-code-architecture-general]]
+.General overview of main OsmoTRX components
+[graphviz]
+
+digraph hierarchy {
+node[shape=record,style=filled,fillcolor=gray95]
+edge[dir=back, arrowtail=empty]
+
+2[label = "{Transceiver|+ constructor()\l+ destructor()\l+ init()\l+ 
numChans()\l+ receiveFIFO()\l+ setSignalHandler()}"]
+3[label = "{RadioInterface|...}"]
+4[label = "{RadioInterfaceResamp|...}"]
+5[label = "{RadioInterfaceMulti|...}"]
+6[label = "{RadioDevice|...}"]
+7[label = "{UHDDevice|...}"]
+8[label = "{LMSDevice|...}"]
+9[label = "{USRPDevice|...}"]
+
+2->3[arrowtail=odiamond]
+3->4[constraint=false]
+3->5[constraint=false]
+3->6[arrowtail=odiamond]
+6->7
+6->8
+6->9
+}
+
+
+[[fig-code-architecture-threads]]
+.Example of thread architecture with OsmoTRX configured to use 2 logical RF 
channels (Trx=Transceiver, RI=RadioIface)
+[graphviz]
+
+digraph hierarchy {
+node[shape=record,style=filled,fillcolor=gray95]
+
+trans [label="Transceiver"];
+radioiface [label="RadioInterface"];
+radiodev [label="RadioDevice"];
+
+trans:nw->trans:ne [label="Trx.ControlServiceLoop_0"];
+trans:nw->trans:ne [label="Trx.ControlServiceLoop_1"];
+trans:w->radioiface:w [label="Trx.TxPriorityQueueServiceLoop_0"];
+trans:w->radioiface:w [label="Trx.TxPriorityQueueServiceLoop_1"];
+radioiface:e->trans:e [label="Trx.RxServiceLoop_0"];
+radioiface:e->trans:e [label="Trx.RxServiceLoop_1"];
+radioiface->radiodev[label="RI.AlignRadioServiceLoop"];
+radioiface:sw->radiodev:nw [label="Trx.TxLowerLoop"];
+radiodev:ne->radioiface:se [label="Trx.RxLowerLoop"];
+}
+
+
+[[code_component_transceiver]]
+=== Transceiver
+
+The Transceiver is the main component managing the other components running in
+the OsmoTRX process. There's a unique instance per process.
+
+This class is quite complex from code point of view, as it starts lots of
+different threads and hence the interaction with this class from the outside is
+quite limited. Only interaction possible is to:
+
+* `Transceiver()`: Create an instance through its constructor, at this time 
most
+  configuration is handed to it.
+* `init()`: Start running all the threads.
+* `receiveFIFO()`: Attach a `radioInterface` channel FIFO in order to use it.
+* `setSignalHandler()`: Used to set up a callback to receive certain events
+  asynchronously from the Transceiver. No assumptions can be made about from
+  which thread is the callback being called, which means multi-thread locking
+  precautions may be required in certain cases, similar to usual signal handler
+  processing. One important event received through this path is for instance
+  when the Transceiver detected a fatal error which requires it to stop. Since
+  it cannot stop itself (see destructor below), stopping procedure must be
+  delegated to the user who created the instance.
+* `~Transceiver()`: The destructor, which stops all running threads created at
+  `init()` time. Destroying the object is the only way to stop the 
`Transceiver`
+  completely, and must be called from a thread not managed by the
+  `Transceiver`, otherwise it will deadlock. Usually it is stopped from the 
main
+  thread, the one that called the constructor during startup.
+
+During `init()` time, `Transceiver` will create a noticeable amount of threads,
+which may vary depending on the amount of RF channels requested.
+
+Static amount of Threads (1 per `Transceiver` instance):
+
+* `RxLowerLoop`: This thread is responsible for reading bursts from the
+  `RadioInterface`, storing them into its FIFO and sending Clock Indications
+  (<>) to _osmo-bts_trx_.
+* `TxLowerLoop`: Manages pushing bursts from buffers in the FIFO into the
+  `RadioInterface` at expected correct time based on the Transceiver clock.
+
+Dynamic amount of Threads (1 per RF logical channel on the `Transceiver` 
instance):
+
+* `ControlServiceLoop`: Handles commands from the Per-ARFCN Control Interface
+  socket (<>). Each thread is responsible for managing one
+  socket related to one ARFCN or which is the same, to one RF logical channel.
+  These are the only threads expected to use the private `start()` and `stop()`
+  methods of the

Change in osmo-gsm-manuals[master]: osmotrx: Create a common chapter for section documenting backends

2018-09-21 Thread Pau Espin Pedrol

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11039 )

Change subject: osmotrx: Create a common chapter for section documenting 
backends
..

osmotrx: Create a common chapter for section documenting backends

Change-Id: I6bea1ccca4ce72b92641a36f9f5894ac9a6cae72
---
M OsmoTRX/chapters/trx-backends.adoc
1 file changed, 6 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/OsmoTRX/chapters/trx-backends.adoc 
b/OsmoTRX/chapters/trx-backends.adoc
index e801886..8829fa6 100644
--- a/OsmoTRX/chapters/trx-backends.adoc
+++ b/OsmoTRX/chapters/trx-backends.adoc
@@ -1,5 +1,8 @@
+[[trx_backends]]
+== OsmoTRX backend support
+
 [[backend_uhd]]
-== `osmo-trx-uhd` for UHD based Transceivers
+=== `osmo-trx-uhd` for UHD based Transceivers

 This OsmoTRX model uses _libuhd_ (UHD, USRP Hardware Driver) to drive the
 device, that is configuring it and reading/writing samples from/to it.
@@ -17,7 +20,7 @@
 _osmo-trx.git_.

 [[backend_lms]]
-== `osmo-trx-lms` for LimeSuite based Transceivers
+=== `osmo-trx-lms` for LimeSuite based Transceivers

 This OsmoTRX model uses LimeSuite API and library to drive the device, that is
 configuring it and reading/writing samples from/to it.
@@ -30,7 +33,7 @@
 _osmo-trx.git_.

 [[backend_usrp1]]
-== `osmo-trx-usrp1` for libusrp based Transceivers
+=== `osmo-trx-usrp1` for libusrp based Transceivers

 This OsmoTRX model uses the legacy libusrp driver provided in GNU Radio 3.4.2.


--
To view, visit https://gerrit.osmocom.org/11039
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6bea1ccca4ce72b92641a36f9f5894ac9a6cae72
Gerrit-Change-Number: 11039
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-ci[master]: osmo-depcheck: script to verify PKG_CHECK_MODULES

2018-09-21 Thread osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/10932 )

Change subject: osmo-depcheck: script to verify PKG_CHECK_MODULES
..


Patch Set 5: Verified+1


--
To view, visit https://gerrit.osmocom.org/10932
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f495dbe030775f66ac125e60ded95c5d7660b65
Gerrit-Change-Number: 10932
Gerrit-PatchSet: 5
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 21 Sep 2018 08:26:28 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: osmo-depcheck: script to verify PKG_CHECK_MODULES

2018-09-21 Thread osmith

osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10932 )

Change subject: osmo-depcheck: script to verify PKG_CHECK_MODULES
..

osmo-depcheck: script to verify PKG_CHECK_MODULES

This script verifies that Osomcom programs really build with the
dependency versions they claim to support in configure.ac. In order to
do that, it clones the dependency repositories if they don't exist
already, and checks out the minimum version tag. This happens
recursively for their dependencies as well. See 'osmo-depcheck.py -h'
for the full usage instructions.

There's also a new jenkins job in jobs/osmocom-depcheck.yml.

Change-Id: I8f495dbe030775f66ac125e60ded95c5d7660b65
Relates: OS#2642
---
A jobs/osmocom-depcheck.yml
A scripts/osmo-depcheck/buildstack.py
A scripts/osmo-depcheck/config.py
A scripts/osmo-depcheck/dependencies.py
A scripts/osmo-depcheck/osmo-depcheck.py
A scripts/osmo-depcheck/parse.py
6 files changed, 590 insertions(+), 0 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  osmith: Verified



diff --git a/jobs/osmocom-depcheck.yml b/jobs/osmocom-depcheck.yml
new file mode 100644
index 000..f13d4b7
--- /dev/null
+++ b/jobs/osmocom-depcheck.yml
@@ -0,0 +1,72 @@
+---
+- project:
+name: Osmocom-depcheck
+jobs:
+  - Osmocom-depcheck
+
+- job-template:
+name: 'Osmocom-depcheck'
+project-type: freestyle
+defaults: global
+description: |
+Verifies that Osmocom programs really build with the dependency
+versions they claim to support in configure.ac.
+(Generated by job-builder)
+node: osmocom-master-debian9
+parameters:
+  - string:
+  name: PROJECTS
+  description: |
+  Which Osmocom projects and revisions to build, leave
+  empty to default to all projects (!),
+  default revision is "master".
+  Examples: "osmo-hlr", "osmo-hlr:0.2.1 osmo-bts:0.8.1"
+  default: 'osmo-hlr:0.2.1'
+  - string:
+  name: GIT_URL_PREFIX
+  description: |
+Where to clone the sources from
+  default: 'git://git.osmocom.org/'
+  - bool:
+  name: BUILD
+  description: |
+Attempt to build the project with the minimum dependency
+versions found in the configure.ac files. If this is unchecked,
+this job will only clone the git repositories and parse the
+configure.ac files.
+  default: true
+  - bool:
+  name: PRINT_OLD_DEPENDS
+  description: |
+Report dependencies on old releases (printed after the other
+parsing output, before the build starts)
+  default: false
+  - string:
+  name: BRANCH
+  description: |
+Branch where the osmo-depcheck.py script gets pulled from.
+Only modify this if you are hacking on osmo-depcheck.py.
+  default: '*/master'
+builders:
+  - shell: |
+  # Build the arguments
+  args="$PROJECTS"
+  args="$args -j 5"
+  args="$args -g $PWD/DEPCHECK_GITDIR"
+  args="$args -u $GIT_URL_PREFIX"
+  [ "$BUILD" = "true" ] && args="$args -b"
+  [ "$PRINT_OLD_DEPENDS" = "true" ] && args="$args -o"
+
+  # Run osmo-depcheck
+  mkdir DEPCHECK_GITDIR
+  export PYTHONUNBUFFERED=1
+  scripts/osmo-depcheck/osmo-depcheck.py $args
+scm:
+  - git:
+  branches:
+- '$BRANCH'
+  url: git://git.osmocom.org/osmo-ci
+  git-config-name: 'Jenkins Builder'
+  git-config-email: 'jenk...@osmocom.org'
+
+# vim: expandtab tabstop=2 shiftwidth=2
diff --git a/scripts/osmo-depcheck/buildstack.py 
b/scripts/osmo-depcheck/buildstack.py
new file mode 100644
index 000..87210ab
--- /dev/null
+++ b/scripts/osmo-depcheck/buildstack.py
@@ -0,0 +1,144 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+# Copyright 2018 sysmocom - s.f.m.c. GmbH 
+
+import atexit
+import collections
+import sys
+import os
+import shutil
+import subprocess
+import tempfile
+
+
+def next_buildable(depends, done):
+""" Find the next program that can be built, because it has all
+dependencies satisfied. Initially this would be libosmocore, as it has
+no dependencies, then the only library that depends on libosmocore and
+so on.
+
+:param depends: return value of dependencies.generate()
+:param done: ordered dict of programs that would already have been
+ built at this point.
+ Example: {"lib-a": "0.11.0", "lib-b": "0.5.0"}
+"""
+# Iterate over dependencies
+for program, data in depends.items():
+# Skip what's already done
+if program in done:
+continue
+
+# Check for missing dependencies
+

Change in osmo-ci[master]: jobs: osmo-gsm-tester: Add osmo-iuh builds

2018-09-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11029 )

Change subject: jobs: osmo-gsm-tester: Add osmo-iuh builds
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11029
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b8f51597287e7673f79c65eae2508b074151781
Gerrit-Change-Number: 11029
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Fri, 21 Sep 2018 08:25:37 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: jobs: osmo-gsm-tester_run-gerrit: Update suites selected for verifica...

2018-09-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11038 )

Change subject: jobs: osmo-gsm-tester_run-gerrit: Update suites selected for 
verification
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11038
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iafe865ab5f607fc8acfcb3f72ebe4b0ef0f1322a
Gerrit-Change-Number: 11038
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Fri, 21 Sep 2018 08:25:14 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: jobs: osmo-gsm-tester: Copy osmocom-bb build artifact

2018-09-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11030 )

Change subject: jobs: osmo-gsm-tester: Copy osmocom-bb build artifact
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11030
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fe41e2c7d9c38796ce16f2f279792bc5151b498
Gerrit-Change-Number: 11030
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Fri, 21 Sep 2018 08:25:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-manuals[master]: osmotrx: Create a common chapter for section documenting backends

2018-09-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11039 )

Change subject: osmotrx: Create a common chapter for section documenting 
backends
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11039
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bea1ccca4ce72b92641a36f9f5894ac9a6cae72
Gerrit-Change-Number: 11039
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 21 Sep 2018 08:24:31 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-manuals[master]: osmotrx: Introduce code architecture chapter

2018-09-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11040 )

Change subject: osmotrx: Introduce code architecture chapter
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11040
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I21084e6315d79a1adcb305e12343da218837dc31
Gerrit-Change-Number: 11040
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 21 Sep 2018 08:24:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: bsc: inter-BSC HO: add TC_ho_out_of_this_bsc, TC_ho_into_this_bsc

2018-09-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9674 )

Change subject: bsc: inter-BSC HO: add TC_ho_out_of_this_bsc, 
TC_ho_into_this_bsc
..


Patch Set 7: Code-Review+2

great. I think next we need to think about some of the many handover failure 
cases and testing for those.  The most common ones of course being that either 
no RSL Handover Detect is received (as the phone wasn't received on the new 
lchan), or that Handover Detect still arrives, but no HO Complete is received, 
...


--
To view, visit https://gerrit.osmocom.org/9674
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id22852d4be7f127d827e7a8beeec55db27c07f03
Gerrit-Change-Number: 9674
Gerrit-PatchSet: 7
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Fri, 21 Sep 2018 08:24:12 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in gr-gsm[master]: apps/grgsm_trx: (re)structurize help message

2018-09-21 Thread Piotr Krysik

Piotr Krysik has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11050 )

Change subject: apps/grgsm_trx: (re)structurize help message
..

apps/grgsm_trx: (re)structurize help message

Change-Id: I612d8ae7d3ff99fee809e10d95919989bfbe0f59
---
M apps/grgsm_trx
1 file changed, 13 insertions(+), 11 deletions(-)

Approvals:
  Piotr Krysik: Looks good to me, approved; Verified



diff --git a/apps/grgsm_trx b/apps/grgsm_trx
index efb9c24..6b3565d 100755
--- a/apps/grgsm_trx
+++ b/apps/grgsm_trx
@@ -104,40 +104,42 @@
parser = ArgumentParser(prog = "grgsm_trx")

# TRX interface specific
-   parser.add_argument("-i", "--remote-addr",
+   trx_group = parser.add_argument_group("TRX interface")
+   trx_group.add_argument("-i", "--remote-addr",
dest = "remote_addr", type = str, default = "127.0.0.1",
help = "Set remote address (default %(default)s)")
-   parser.add_argument("-b", "--bind-addr",
+   trx_group.add_argument("-b", "--bind-addr",
dest = "bind_addr", type = str, default = "0.0.0.0",
help = "Set bind address (default %(default)s)")
-   parser.add_argument("-p", "--base_port",
+   trx_group.add_argument("-p", "--base_port",
dest = "base_port", type = int, default = 6700,
help = "Set base port number (default %(default)s)")

# PHY specific
-   parser.add_argument("-a", "--args",
+   phy_group = parser.add_argument_group("PHY parameters")
+   phy_group.add_argument("-a", "--args",
dest = "args", type = str, default = "",
help = "Set device arguments")
-   parser.add_argument("-s", "--sample-rate",
+   phy_group.add_argument("-s", "--sample-rate",
dest = "sample_rate", type = eng_float,
default = radio_if.SAMPLE_RATE,
help = "Set samp_rate (default %(default)s)")
-   parser.add_argument("-g", "--rx-gain",
+   phy_group.add_argument("-g", "--rx-gain",
dest = "rx_gain", type = float, default = 30,
help = "Set RX gain (default %(default)s)")
-   parser.add_argument("-G", "--tx-gain",
+   phy_group.add_argument("-G", "--tx-gain",
dest = "tx_gain", type = float, default = 10,
help = "Set TX gain (default %(default)s)")
-   parser.add_argument("--rx-antenna",
+   phy_group.add_argument("--rx-antenna",
dest = "rx_antenna", type = str, default = "RX2",
help = "Set RX antenna (default %(default)s)")
-   parser.add_argument("--tx-antenna",
+   phy_group.add_argument("--tx-antenna",
dest = "tx_antenna", type = str, default = "TX/RX",
help = "Set TX antenna (default %(default)s)")
-   parser.add_argument("--freq-offset",
+   phy_group.add_argument("--freq-offset",
dest = "freq_offset", type = eng_float, default = 0,
help = "Shift baseband freq. (e.g. -500M)")
-   parser.add_argument("--ppm",
+   phy_group.add_argument("--ppm",
dest = "ppm", type = float, default = 0,
help = "Set frequency correction (default %(default)s)")


--
To view, visit https://gerrit.osmocom.org/11050
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I612d8ae7d3ff99fee809e10d95919989bfbe0f59
Gerrit-Change-Number: 11050
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Piotr Krysik

Change in gr-gsm[master]: apps/grgsm_trx: (re)structurize help message

2018-09-21 Thread Piotr Krysik

Piotr Krysik has posted comments on this change. ( 
https://gerrit.osmocom.org/11050 )

Change subject: apps/grgsm_trx: (re)structurize help message
..


Patch Set 1: Verified+1 Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11050
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I612d8ae7d3ff99fee809e10d95919989bfbe0f59
Gerrit-Change-Number: 11050
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Piotr Krysik 
Gerrit-Comment-Date: Fri, 21 Sep 2018 08:23:49 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: osmo-bsc.cfg: inter-bsc HO: add a neighbor identity

2018-09-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11042 )

Change subject: osmo-bsc.cfg: inter-bsc HO: add a neighbor identity
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11042
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I077c2ad2ede900ec43f55655bd740651d3bbe83d
Gerrit-Change-Number: 11042
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Fri, 21 Sep 2018 08:20:26 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: root Makefile: add rules for ttcn3-hlr-test

2018-09-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11043 )

Change subject: root Makefile: add rules for ttcn3-hlr-test
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11043
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfd59c3faabeaa1af00df988513d5574c680a3bb
Gerrit-Change-Number: 11043
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Fri, 21 Sep 2018 08:20:03 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-pcu[master]: check for overlong unix socket paths

2018-09-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11048 )

Change subject: check for overlong unix socket paths
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11048
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I825190cbb34d052b797e9fb5208884d6f5992839
Gerrit-Change-Number: 11048
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 21 Sep 2018 08:19:30 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: debian-repo-install-test: UNKNOWN in --version?

2018-09-21 Thread osmith

osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11041 )

Change subject: debian-repo-install-test: UNKNOWN in --version?
..

debian-repo-install-test: UNKNOWN in --version?

With this patch, the debian-repo-install-test script checks if
the Osmocom programs as installed from the Debian repository have
"UNKNOWN" in their --version output.

Relates: OS#3555
Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8
---
M debian-repo-install-test/testdata/repo-install-test.sh
1 file changed, 36 insertions(+), 13 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  osmith: Verified



diff --git a/debian-repo-install-test/testdata/repo-install-test.sh 
b/debian-repo-install-test/testdata/repo-install-test.sh
index ea1c5fb..3ef88e8 100755
--- a/debian-repo-install-test/testdata/repo-install-test.sh
+++ b/debian-repo-install-test/testdata/repo-install-test.sh
@@ -44,25 +44,48 @@
apt install -y $(cat /data/osmocom_packages.txt)
 }

+test_binaries_version() {
+   # Make sure --version runs and does not output UNKNOWN
+   failed=""
+   for program in $@; do
+   # Make sure it runs at all
+   $program --version
+
+   # Check for UNKNOWN
+   if $program --version | grep -q UNKNOWN; then
+   failed="$failed $program"
+   echo "ERROR: this program prints UNKNOWN in --version!"
+   fi
+   done
+
+   if [ -n "$failed" ]; then
+   echo "ERROR: the following program(s) print UNKNOWN in 
--version:"
+   echo "$failed"
+   return 1
+   fi
+}
+
 test_binaries() {
# Make sure the binaries are not broken (run -h or --version)
-   osmo-bsc --version
-   osmo-bts-trx --version
-   osmo-bts-virtual --version
-   osmo-gbproxy --version
-   osmo-ggsn --version
osmo-gtphub -h
-   osmo-hlr --version
-   osmo-hlr-db-tool --version
-   osmo-hnbgw --version
-   osmo-mgw --version
-   osmo-msc --version
-   osmo-pcu --version
-   osmo-sgsn --version
osmo-sip-connector -h
-   osmo-stp --version
osmo-trx-uhd -h
osmo-trx-usrp1 -h
+
+   test_binaries_version \
+   osmo-bsc \
+   osmo-bts-trx \
+   osmo-bts-virtual \
+   osmo-gbproxy \
+   osmo-ggsn \
+   osmo-hlr \
+   osmo-hlr-db-tool \
+   osmo-hnbgw \
+   osmo-mgw \
+   osmo-msc \
+   osmo-pcu \
+   osmo-sgsn \
+   osmo-stp
 }

 finish() {

--
To view, visit https://gerrit.osmocom.org/11041
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8
Gerrit-Change-Number: 11041
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith

Change in osmo-bsc[master]: check for overlong unix socket paths

2018-09-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11046 )

Change subject: check for overlong unix socket paths
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11046
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b9ff9146068bf7f53d67c577454f32c02361b86
Gerrit-Change-Number: 11046
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 21 Sep 2018 08:19:26 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: debian-repo-install-test: UNKNOWN in --version?

2018-09-21 Thread osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/11041 )

Change subject: debian-repo-install-test: UNKNOWN in --version?
..


Patch Set 2: Verified+1


--
To view, visit https://gerrit.osmocom.org/11041
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8
Gerrit-Change-Number: 11041
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Fri, 21 Sep 2018 08:19:26 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: ensure unix socket paths are NUL-terminated for bind/connect

2018-09-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11044 )

Change subject: ensure unix socket paths are NUL-terminated for bind/connect
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11044
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c4ac6b0a0eef4842beae4107f6f09f6cd29172a
Gerrit-Change-Number: 11044
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 21 Sep 2018 08:19:47 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-abis[master]: ensure unix socket paths are NUL-terminated for bind/connect

2018-09-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11045 )

Change subject: ensure unix socket paths are NUL-terminated for bind/connect
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11045
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9beecfa500db75cb679b1edcc352c893bf098b13
Gerrit-Change-Number: 11045
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 21 Sep 2018 08:19:49 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: gsm0808_utils: constify parameter

2018-09-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11049 )

Change subject: gsm0808_utils: constify parameter
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11049
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31e8d273b070b0afc446a298299d4f502d6c396b
Gerrit-Change-Number: 11049
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 21 Sep 2018 08:18:41 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: debian-repo-install-test: UNKNOWN in --version?

2018-09-21 Thread osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/11041 )

Change subject: debian-repo-install-test: UNKNOWN in --version?
..


Patch Set 2:

Thanks for the review, updated.


--
To view, visit https://gerrit.osmocom.org/11041
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8
Gerrit-Change-Number: 11041
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Fri, 21 Sep 2018 08:18:53 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in docker-playground[master]: debian-repo-install-test: UNKNOWN in --version?

2018-09-21 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11041 )

Change subject: debian-repo-install-test: UNKNOWN in --version?
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11041
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8
Gerrit-Change-Number: 11041
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Fri, 21 Sep 2018 08:18:01 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: debian-repo-install-test: UNKNOWN in --version?

2018-09-21 Thread osmith

Hello Neels Hofmeyr, Harald Welte,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11041

to look at the new patch set (#2).

Change subject: debian-repo-install-test: UNKNOWN in --version?
..

debian-repo-install-test: UNKNOWN in --version?

With this patch, the debian-repo-install-test script checks if
the Osmocom programs as installed from the Debian repository have
"UNKNOWN" in their --version output.

Relates: OS#3555
Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8
---
M debian-repo-install-test/testdata/repo-install-test.sh
1 file changed, 36 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/41/11041/2
--
To view, visit https://gerrit.osmocom.org/11041
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8
Gerrit-Change-Number: 11041
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith

Change in gr-gsm[master]: apps/grgsm_trx: (re)structurize help message

2018-09-21 Thread Vadim Yanitskiy

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/11050


Change subject: apps/grgsm_trx: (re)structurize help message
..

apps/grgsm_trx: (re)structurize help message

Change-Id: I612d8ae7d3ff99fee809e10d95919989bfbe0f59
---
M apps/grgsm_trx
1 file changed, 13 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/50/11050/1

diff --git a/apps/grgsm_trx b/apps/grgsm_trx
index efb9c24..6b3565d 100755
--- a/apps/grgsm_trx
+++ b/apps/grgsm_trx
@@ -104,40 +104,42 @@
parser = ArgumentParser(prog = "grgsm_trx")

# TRX interface specific
-   parser.add_argument("-i", "--remote-addr",
+   trx_group = parser.add_argument_group("TRX interface")
+   trx_group.add_argument("-i", "--remote-addr",
dest = "remote_addr", type = str, default = "127.0.0.1",
help = "Set remote address (default %(default)s)")
-   parser.add_argument("-b", "--bind-addr",
+   trx_group.add_argument("-b", "--bind-addr",
dest = "bind_addr", type = str, default = "0.0.0.0",
help = "Set bind address (default %(default)s)")
-   parser.add_argument("-p", "--base_port",
+   trx_group.add_argument("-p", "--base_port",
dest = "base_port", type = int, default = 6700,
help = "Set base port number (default %(default)s)")

# PHY specific
-   parser.add_argument("-a", "--args",
+   phy_group = parser.add_argument_group("PHY parameters")
+   phy_group.add_argument("-a", "--args",
dest = "args", type = str, default = "",
help = "Set device arguments")
-   parser.add_argument("-s", "--sample-rate",
+   phy_group.add_argument("-s", "--sample-rate",
dest = "sample_rate", type = eng_float,
default = radio_if.SAMPLE_RATE,
help = "Set samp_rate (default %(default)s)")
-   parser.add_argument("-g", "--rx-gain",
+   phy_group.add_argument("-g", "--rx-gain",
dest = "rx_gain", type = float, default = 30,
help = "Set RX gain (default %(default)s)")
-   parser.add_argument("-G", "--tx-gain",
+   phy_group.add_argument("-G", "--tx-gain",
dest = "tx_gain", type = float, default = 10,
help = "Set TX gain (default %(default)s)")
-   parser.add_argument("--rx-antenna",
+   phy_group.add_argument("--rx-antenna",
dest = "rx_antenna", type = str, default = "RX2",
help = "Set RX antenna (default %(default)s)")
-   parser.add_argument("--tx-antenna",
+   phy_group.add_argument("--tx-antenna",
dest = "tx_antenna", type = str, default = "TX/RX",
help = "Set TX antenna (default %(default)s)")
-   parser.add_argument("--freq-offset",
+   phy_group.add_argument("--freq-offset",
dest = "freq_offset", type = eng_float, default = 0,
help = "Shift baseband freq. (e.g. -500M)")
-   parser.add_argument("--ppm",
+   phy_group.add_argument("--ppm",
dest = "ppm", type = float, default = 0,
help = "Set frequency correction (default %(default)s)")


--
To view, visit https://gerrit.osmocom.org/11050
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I612d8ae7d3ff99fee809e10d95919989bfbe0f59
Gerrit-Change-Number: 11050
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy

Change in libosmocore[master]: gsm0808_utils: constify parameter

2018-09-21 Thread dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11049


Change subject: gsm0808_utils: constify parameter
..

gsm0808_utils: constify parameter

parameter cfg in gsm0808_sc_cfg_from_gsm48_mr_cfg() is used read only.
Lets add a const to make this clear to the compiler.

Change-Id: I31e8d273b070b0afc446a298299d4f502d6c396b
---
M include/osmocom/gsm/gsm0808_utils.h
M src/gsm/gsm0808_utils.c
2 files changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/49/11049/1

diff --git a/include/osmocom/gsm/gsm0808_utils.h 
b/include/osmocom/gsm/gsm0808_utils.h
index 0a7429e..8746ceb 100644
--- a/include/osmocom/gsm/gsm0808_utils.h
+++ b/include/osmocom/gsm/gsm0808_utils.h
@@ -104,7 +104,7 @@
 int gsm0808_chan_type_to_speech_codec(uint8_t perm_spch);
 int gsm0808_speech_codec_from_chan_type(struct gsm0808_speech_codec *sc,
uint8_t perm_spch);
-uint16_t gsm0808_sc_cfg_from_gsm48_mr_cfg(struct gsm48_multi_rate_conf *cfg, 
bool fr);
+uint16_t gsm0808_sc_cfg_from_gsm48_mr_cfg(const struct gsm48_multi_rate_conf 
*cfg, bool fr);

 /*! Return 3GPP TS 48.008 3.2.2.49 Current Channel Type 1 from enum 
gsm_chan_t. */
 static inline uint8_t gsm0808_current_channel_type_1(enum gsm_chan_t type)
diff --git a/src/gsm/gsm0808_utils.c b/src/gsm/gsm0808_utils.c
index 4b2a5f5..0d6938e 100644
--- a/src/gsm/gsm0808_utils.c
+++ b/src/gsm/gsm0808_utils.c
@@ -1166,7 +1166,7 @@
  *  \param[in] cfg AMR configuration in GSM 04.08 format.
  *  \param[in] hint if the resulting configuration shall be used with a FR or 
HR TCH.
  *  \returns configuration bits (S0-S15) */
-uint16_t gsm0808_sc_cfg_from_gsm48_mr_cfg(struct gsm48_multi_rate_conf *cfg,
+uint16_t gsm0808_sc_cfg_from_gsm48_mr_cfg(const struct gsm48_multi_rate_conf 
*cfg,
  bool fr)
 {
uint16_t s15_s0 = 0;

--
To view, visit https://gerrit.osmocom.org/11049
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I31e8d273b070b0afc446a298299d4f502d6c396b
Gerrit-Change-Number: 11049
Gerrit-PatchSet: 1
Gerrit-Owner: dexter

59 matches

Mail list logo