Change in osmo-ttcn3-hacks[master]: cosmetic: fix typos

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/11553 )

Change subject: cosmetic: fix typos
..


Patch Set 1:

FYI, I don't have permissions to submit this change - someone else have to do 
it.


--
To view, visit https://gerrit.osmocom.org/11553
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e75af46e134d33f752214988054105aba91366c
Gerrit-Change-Number: 11553
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Comment-Date: Wed, 31 Oct 2018 22:34:59 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-mgw[master]: add DLCX command statistics to osmo-mgw

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11521 )

Change subject: add DLCX command statistics to osmo-mgw
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11521
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0dde2faf02fd68a69f986973d39b1bea367039b
Gerrit-Change-Number: 11521
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 31 Oct 2018 22:14:11 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-iuh[master]: add a VTY command which shows a specific HNB

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11506 )

Change subject: add a VTY command which shows a specific HNB
..

add a VTY command which shows a specific HNB

Add the 'show hnb NAME' VTY command which displays just
one specific HNB, addressed by its identity string.
This augments the functionality provided by 'show hnb all'.

Change-Id: Iab12aa4ab090b72c472358b84daf6919b30747f6
Related: OS#2774
---
M include/osmocom/iuh/hnbgw.h
M src/hnbgw.c
M src/hnbgw_vty.c
3 files changed, 37 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocom/iuh/hnbgw.h b/include/osmocom/iuh/hnbgw.h
index db49dc1..4848c2f 100644
--- a/include/osmocom/iuh/hnbgw.h
+++ b/include/osmocom/iuh/hnbgw.h
@@ -151,6 +151,7 @@
 extern void *talloc_asn1_ctx;

 struct hnb_context *hnb_context_by_id(struct hnb_gw *gw, uint32_t cid);
+struct hnb_context *hnb_context_by_identity_info(struct hnb_gw *gw, const char 
*identity_info);
 unsigned hnb_contexts(const struct hnb_gw *gw);

 struct ue_context *ue_context_by_id(struct hnb_gw *gw, uint32_t id);
diff --git a/src/hnbgw.c b/src/hnbgw.c
index cd6104b..e40996f 100644
--- a/src/hnbgw.c
+++ b/src/hnbgw.c
@@ -105,6 +105,19 @@
return NULL;
 }

+struct hnb_context *hnb_context_by_identity_info(struct hnb_gw *gw, const char 
*identity_info)
+{
+   struct hnb_context *hnb;
+
+   llist_for_each_entry(hnb, >hnb_list, list) {
+   if (strcmp(identity_info, hnb->identity_info) == 0)
+   return hnb;
+   }
+
+   return NULL;
+}
+
+
 unsigned hnb_contexts(const struct hnb_gw *gw)
 {
unsigned num_ctx = 0;
diff --git a/src/hnbgw_vty.c b/src/hnbgw_vty.c
index 859cd31..15fdaf8 100644
--- a/src/hnbgw_vty.c
+++ b/src/hnbgw_vty.c
@@ -200,7 +200,7 @@
vty_out(vty, "UE IMSI \"%s\" context ID %u%s", ue->imsi, 
ue->context_id, VTY_NEWLINE);
 }

-DEFUN(show_hnb, show_hnb_cmd, "show hnb all", SHOW_STR "Display information 
about a HNB")
+DEFUN(show_hnb, show_hnb_cmd, "show hnb all", SHOW_STR "Display information 
about all HNB")
 {
struct hnb_context *hnb;
unsigned int count = 0;
@@ -220,6 +220,27 @@
return CMD_SUCCESS;
 }

+DEFUN(show_one_hnb, show_one_hnb_cmd, "show hnb NAME ", SHOW_STR "Display 
information about a HNB")
+{
+   struct hnb_context *hnb;
+   int found = 0;
+   const char *identity_info = argv[0];
+
+   if (llist_empty(_hnb_gw->hnb_list)) {
+   vty_out(vty, "No HNB connected%s", VTY_NEWLINE);
+   return CMD_SUCCESS;
+   }
+
+   hnb = hnb_context_by_identity_info(_hnb_gw, identity_info);
+   if (hnb == NULL) {
+   vty_out(vty, "No HNB found with identity '%s'%s", 
identity_info, VTY_NEWLINE);
+   return CMD_SUCCESS;
+   }
+
+   vty_dump_hnb_info(vty, hnb);
+   return CMD_SUCCESS;
+}
+
 DEFUN(show_ue, show_ue_cmd, "show ue all", SHOW_STR "Display information about 
a UE")
 {
struct ue_context *ue;
@@ -377,6 +398,7 @@

install_element_ve(_cnlink_cmd);
install_element_ve(_hnb_cmd);
+   install_element_ve(_one_hnb_cmd);
install_element_ve(_ue_cmd);
install_element_ve(_talloc_cmd);
 }

--
To view, visit https://gerrit.osmocom.org/11506
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab12aa4ab090b72c472358b84daf6919b30747f6
Gerrit-Change-Number: 11506
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: lynxis lazus 

Change in osmo-iuh[master]: add a VTY command which shows a specific HNB

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11506 )

Change subject: add a VTY command which shows a specific HNB
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11506
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab12aa4ab090b72c472358b84daf6919b30747f6
Gerrit-Change-Number: 11506
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Wed, 31 Oct 2018 22:13:06 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: deps: osmo-sgsn depends on osmo-hlr's liboso-gsup-client

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11537 )

Change subject: deps: osmo-sgsn depends on osmo-hlr's liboso-gsup-client
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11537
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie47ca98740ca438e04d6ea76421e0f58d9e5715a
Gerrit-Change-Number: 11537
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 31 Oct 2018 22:12:28 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-pcap[master]: Install systemd services with autotools

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11545 )

Change subject: Install systemd services with autotools
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11545
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id938f3dab4826ac748abb5e0b169d800c2a625a5
Gerrit-Change-Number: 11545
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 31 Oct 2018 22:12:00 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-pcap[master]: contrib/jenkins.sh: Update to current osmocom infra

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11549 )

Change subject: contrib/jenkins.sh: Update to current osmocom infra
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11549
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I955b99ce27df143f5d022619dd14e32b763e6c14
Gerrit-Change-Number: 11549
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Wed, 31 Oct 2018 22:11:10 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: cosmetic: fix compilation warnings

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11557 )

Change subject: cosmetic: fix compilation warnings
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11557
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6210ecf5fcb39f751116ad63a69d2ae8651a60c5
Gerrit-Change-Number: 11557
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 31 Oct 2018 22:07:56 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: BSC LCLS: restructure tests

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11555 )

Change subject: BSC LCLS: restructure tests
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11555
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf9fc8e639b0ece662ab26c481899ef39fb7edfe
Gerrit-Change-Number: 11555
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 31 Oct 2018 22:07:13 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: BSC LCLS: explicitly check for RSL_IE_CHAN_NR

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11556 )

Change subject: BSC LCLS: explicitly check for RSL_IE_CHAN_NR
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11556
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc6824d7acef809d76c70b5ff060a8261a82e2be
Gerrit-Change-Number: 11556
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 31 Oct 2018 22:07:37 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: BSC: remove explicit address

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11554 )

Change subject: BSC: remove explicit address
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11554
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ideb8a78348af435f9992c42bce0bb197d1e73e04
Gerrit-Change-Number: 11554
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 31 Oct 2018 22:06:19 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: cosmetic: fix typos

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11553 )

Change subject: cosmetic: fix typos
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11553
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e75af46e134d33f752214988054105aba91366c
Gerrit-Change-Number: 11553
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 31 Oct 2018 22:06:02 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: library/MNCC_Types.ttcn: add MS-side related messages

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11561 )

Change subject: library/MNCC_Types.ttcn: add MS-side related messages
..

library/MNCC_Types.ttcn: add MS-side related messages

Change-Id: Icc41074e80da7115cfbd5075f88a14fedaf73489
---
M library/MNCC_Types.ttcn
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/library/MNCC_Types.ttcn b/library/MNCC_Types.ttcn
index 157457a..a3714b1 100644
--- a/library/MNCC_Types.ttcn
+++ b/library/MNCC_Types.ttcn
@@ -115,6 +115,13 @@
MNCC_USERINFO_IND   ('0126'O),
MNCC_REJ_REQ('0127'O),
MNCC_REJ_IND('0128'O),
+   MNCC_PROGRESS_IND   ('0129'O),
+   MNCC_CALL_PROC_IND  ('012a'O),
+   MNCC_CALL_CONF_REQ  ('012b'O),
+   MNCC_START_DTMF_REQ ('012c'O),
+   MNCC_STOP_DTMF_REQ  ('012d'O),
+   MNCC_HOLD_REQ   ('012e'O),
+   MNCC_RETRIEVE_REQ   ('012f'O),

MNCC_BRIDGE ('0200'O),
MNCC_FRAME_RECV ('0201'O),

--
To view, visit https://gerrit.osmocom.org/11561
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc41074e80da7115cfbd5075f88a14fedaf73489
Gerrit-Change-Number: 11561
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-ttcn3-hacks[master]: library/MNCC_Types.ttcn: add MS-side related messages

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11561 )

Change subject: library/MNCC_Types.ttcn: add MS-side related messages
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11561
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc41074e80da7115cfbd5075f88a14fedaf73489
Gerrit-Change-Number: 11561
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 31 Oct 2018 22:04:41 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: WIP: bts: f_est_dchan: verify Chan Rqd originated by RACH arrives on RSL

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11562


Change subject: WIP: bts: f_est_dchan: verify Chan Rqd originated by RACH 
arrives on RSL
..

WIP: bts: f_est_dchan: verify Chan Rqd originated by RACH arrives on RSL

Change-Id: I438fd3ee82d88498d928dbcc89ce9bd80d37ab64
---
M bts/BTS_Tests.ttcn
M library/RSL_Emulation.ttcn
M library/RSL_Types.ttcn
3 files changed, 76 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/62/11562/1

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 5b073ef..0676214 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -1344,17 +1344,37 @@
}
 }

+/* Send RACH request through l1CTL and wait for ChanReq on RSL BST->BSC */
+private function f_rach_req_wait_chan_rqd(integer ra) runs on ConnHdlr return 
GsmFrameNumber {
+   var GsmFrameNumber fn;
+   timer T := 8.0;
+
+   f_L1CTL_PARAM(L1CTL, g_pars.l1_pars.ms_actual_ta, 
g_pars.l1_pars.ms_power_level);
+   /* Send the actual RACH */
+   log("PESPIN: calling f_L1CTL_RACH ", ra);
+   fn := f_L1CTL_RACH(L1CTL, ra);
+   log("PESPIN: called with fn returned ", fn);
+   /* advertise to RSL Emulation that we expect to receive confirmation 
from RACH */
+   RSL.send(ts_RSLDC_ChanRqd(int2oct(ra,1), fn));
+   T.start;
+   alt {
+   [] RSL.receive(tr_RSL_CHAN_RQD(int2oct(ra,1), fn)) { setverdict(pass, 
"Received CHAN-RQD from RACH REQ")}
+   [] T.timeout {
+   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, 
log2str("Timeout waiting for CHAN-RQD from RACH REQ <", ra, ", ", fn, ">"));
+   }
+   }
+   T.stop
+   return fn;
+}

 /* Establish dedicated channel: L1CTL + RSL side */
 private function f_est_dchan(boolean encr_enable := false) runs on ConnHdlr {
-   var GsmFrameNumber fn;
var ImmediateAssignment imm_ass;
var integer ra := 23;
+   var GsmFrameNumber fn;
 
-   f_L1CTL_PARAM(L1CTL, g_pars.l1_pars.ms_actual_ta, 
g_pars.l1_pars.ms_power_level);
-   fn := f_L1CTL_RACH(L1CTL, ra);
-   /* This arrives on CCHAN, so we cannot test for receiving CHAN RQDhere 
*/
-   //RSL.receive(tr_RSL_CHAN_RQD(int2oct(23,1)));
+   /* Send RACH request and wait for ChanReq */
+   fn := f_rach_req_wait_chan_rqd(ra);

/* Activate channel on BTS side */
f_rsl_chan_act(g_pars.chan_mode, encr_enable);
diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn
index cf02d00..24c9202 100644
--- a/library/RSL_Emulation.ttcn
+++ b/library/RSL_Emulation.ttcn
@@ -148,7 +148,7 @@
 runs on RSL_Emulation_CT return integer {
var integer i;
for (i := 0; i < sizeof(ConnectionTable); i := i+1) {
-   if (ispresent(ConnectionTable[i].comp_ref) and
+   if (ispresent(ConnectionTable[i].comp_ref) and
ConnectionTable[i].comp_ref == comp_ref) {
return i;
}
@@ -161,7 +161,7 @@
 runs on RSL_Emulation_CT return integer {
var integer i;
for (i := 0; i < sizeof(ConnectionTable); i := i+1) {
-   if (ispresent(ConnectionTable[i].chan_nr) and
+   if (ispresent(ConnectionTable[i].chan_nr) and
ConnectionTable[i].chan_nr == chan_nr and 
ConnectionTable[i].trx_nr == trx_nr) {
return i;
}
@@ -183,6 +183,24 @@
return -1;
 }

+private function f_cid_by_ra_fn2(OCT1 ra, RSL_IE_FrameNumber fn)
+runs on RSL_Emulation_CT return integer {
+   var RSL_IE_FrameNumber ct_fn;
+   var integer i;
+   for (i := 0; i < sizeof(ConnectionTable); i := i+1) {
+   if (ispresent(ConnectionTable[i].ra) and
+   ConnectionTable[i].ra == ra) {
+   ct_fn := 
f_compute_RSL_IE_FrameNumber(ConnectionTable[i].ra_fn);
+   log("PESPIN: matching ", fn, " with ", ct_fn)
+   if (ct_fn == fn) {
+   return i;
+   }
+   }
+   }
+   log("No Dchan handler for ", ra, fn);
+   return -1;
+}
+
 /* create an ew client with given RA and FN */
 private function f_cid_create(OCT1 ra, GsmFrameNumber fn, RSL_DchanHdlr 
comp_ref)
 runs on RSL_Emulation_CT {
@@ -394,6 +412,23 @@
}
}
}
+   [not bts_role] IPA_PT.receive(tr_RSL(tr_RSL_CHAN_RQD(?))) -> 
value rx_rsl {
+   var RSL_IE_RequestRef req_ref;
+   var OCT1 ra;
+   var GsmFrameNumber fn;
+   req_ref := rx_rsl.rsl.ies[1].body.req_ref;
+   ra := req_ref.ra
+   //fn := 23; //FIXME(req_ref.frame_nr);
+   cid := f_cid_by_ra_fn2(req_ref.ra, req_ref.frame_nr);
+ 

Change in osmo-dev[master]: replace src/* git scripts with a single src/gits

[Neels Hofmeyr]

Hello osmith,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11560

to look at the new patch set (#2).

Change subject: replace src/* git scripts with a single src/gits
..

replace src/* git scripts with a single src/gits

I keep re-using this functionality in completely unrelated realms, and decided
to unify the oddly named scripts in a single 'gits' meta-repos tool, so I can
just symlink this script into my ~/bin and use it everywhere.

Change-Id: I579e7af26d76d5c5d83b2349695456bc7b54f5a2
---
M src/README
D src/e
D src/g
D src/git_branch_summary.py
A src/gits
D src/s
D src/st
7 files changed, 354 insertions(+), 298 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/60/11560/2
--
To view, visit https://gerrit.osmocom.org/11560
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I579e7af26d76d5c5d83b2349695456bc7b54f5a2
Gerrit-Change-Number: 11560
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 

Jenkins build is back to normal : master-osmo-ggsn » --disable-gtp-linux,a2=default,a3=default,osmocom-master-debian9 #1051

[jenkins]

See 

Change in osmo-ttcn3-hacks[master]: library/MNCC_Types.ttcn: add MS-side related messages

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/11561


Change subject: library/MNCC_Types.ttcn: add MS-side related messages
..

library/MNCC_Types.ttcn: add MS-side related messages

Change-Id: Icc41074e80da7115cfbd5075f88a14fedaf73489
---
M library/MNCC_Types.ttcn
1 file changed, 7 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/61/11561/1

diff --git a/library/MNCC_Types.ttcn b/library/MNCC_Types.ttcn
index 157457a..a3714b1 100644
--- a/library/MNCC_Types.ttcn
+++ b/library/MNCC_Types.ttcn
@@ -115,6 +115,13 @@
MNCC_USERINFO_IND   ('0126'O),
MNCC_REJ_REQ('0127'O),
MNCC_REJ_IND('0128'O),
+   MNCC_PROGRESS_IND   ('0129'O),
+   MNCC_CALL_PROC_IND  ('012a'O),
+   MNCC_CALL_CONF_REQ  ('012b'O),
+   MNCC_START_DTMF_REQ ('012c'O),
+   MNCC_STOP_DTMF_REQ  ('012d'O),
+   MNCC_HOLD_REQ   ('012e'O),
+   MNCC_RETRIEVE_REQ   ('012f'O),

MNCC_BRIDGE ('0200'O),
MNCC_FRAME_RECV ('0201'O),

--
To view, visit https://gerrit.osmocom.org/11561
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc41074e80da7115cfbd5075f88a14fedaf73489
Gerrit-Change-Number: 11561
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 

Change in osmo-dev[master]: replace src/* git scripts with a single src/gits

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11560 )

Change subject: replace src/* git scripts with a single src/gits
..


Patch Set 1:

I'm not sure that this is ready yet, will work with it for a few days to see if 
it still needs fixing. But uploading it already to share with osmith.


--
To view, visit https://gerrit.osmocom.org/11560
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I579e7af26d76d5c5d83b2349695456bc7b54f5a2
Gerrit-Change-Number: 11560
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 31 Oct 2018 20:41:10 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-dev[master]: replace src/* git scripts with a single src/gits

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/11560


Change subject: replace src/* git scripts with a single src/gits
..

replace src/* git scripts with a single src/gits

I keep re-using this functionality in completely unrelated realms, and decided
to unify the oddly named scripts in a single 'gits' meta-repos tool, so I can
just symlink this script into my ~/bin and use it everywhere.

Change-Id: I579e7af26d76d5c5d83b2349695456bc7b54f5a2
---
M src/README
D src/e
D src/g
D src/git_branch_summary.py
A src/gits
D src/s
D src/st
7 files changed, 353 insertions(+), 298 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/60/11560/1

diff --git a/src/README b/src/README
index a2fbe81..f066561 100644
--- a/src/README
+++ b/src/README
@@ -11,12 +11,11 @@
Pass a patch number seen on gerrit to fetch the latest patch set into
your git clone. See top comment in the script.

- ./g   run a git command in each source tree
- ./e   run an arbitrary shell command in each source tree
- ./st  show a brief branch and local mods status for each source tree
- ./s   walk through each source tree and use gitk as well as user interaction
-   to quickly fast-forward / reset changes coming in from upstream. (This
-   is potentially dangerous, but safe if you only hit enter every time.)
+ gits   Conveniently manage several git clones:
+- run a git or shell command in each source tree
+   - show a brief branch and local mods status for each source tree
+   - merge / rebase / fast-forward each source tree interactively
+   See ./gits help

 Examples:

@@ -54,7 +53,7 @@

 -

-./g fetch# run 'git fetch' in each clone = fetch all from upstream
+./gits fetch# run 'git fetch' in each clone = fetch all from upstream

 = libasn1c =
 remote: Counting objects: 29, done
@@ -90,7 +89,7 @@

 -

-./st # any modifications / updates? (e.g. useful after './g fetch')
+./gits st# any modifications / updates? (e.g. useful after './g fetch')
  # (checks only 'master' and the current checked-out branch)

  libasn1c master
@@ -116,13 +115,13 @@

 -

-./e rm .version  # in each source tree, remove the local .version file
+./gits sh rm .version  # in each source tree, remove the local .version file
 
 -

-./s # interactively try to fast-forward to upstream and/or save
-# local modifications.
-# If you just hit Enter all the time, nothing will be changed.
+./gits rebase  # interactively try to fast-forward to upstream and/or save
+   # local modifications.
+   # If you just hit Enter all the time, nothing dangerous will 
happen.


 libosmocore
diff --git a/src/e b/src/e
deleted file mode 100755
index 4d32bf1..000
--- a/src/e
+++ /dev/null
@@ -1,15 +0,0 @@
-#!/usr/bin/env python3
-import os
-import os.path
-import sys
-import subprocess
-
-base_dir = os.getcwd()
-
-for p in list(os.listdir('.')):
-   subdir = os.path.join(base_dir, p)
-   if not os.path.isdir(os.path.join(subdir, '.git')):
-   continue
-   print("\n= %s =" % p)
-   os.chdir(subdir)
-   subprocess.call(sys.argv[1:])
diff --git a/src/g b/src/g
deleted file mode 100755
index bb9b693..000
--- a/src/g
+++ /dev/null
@@ -1,17 +0,0 @@
-#!/usr/bin/env python3
-
-import sys
-import os
-import subprocess
-
-git_subdirs = []
-
-for subdir in os.listdir():
-  if not os.path.isdir(os.path.join(subdir, '.git')):
-continue
-
-  print('\n= %s =' % subdir)
-  sys.stdout.flush()
-  subprocess.call(['git', '-C', subdir] + sys.argv[1:])
-  sys.stdout.flush()
-  sys.stderr.flush()
diff --git a/src/git_branch_summary.py b/src/git_branch_summary.py
deleted file mode 100755
index 9d81f8b..000
--- a/src/git_branch_summary.py
+++ /dev/null
@@ -1,68 +0,0 @@
-#!/usr/bin/env python
-
-import sys, subprocess, re
-
-if len(sys.argv) < 2:
-  print("Usage: %s  [...]\nThis is mostly here for helping the 'st' 
script." % sys.argv[0])
-  exit(1)
-
-interesting_branch_names = [ 'master', 'sysmocom/iu', 'sysmocom/sccp', 
'aper-prefix-onto-upstream' ]
-
-re_branch_name = re.compile('^..([^ ]+) .*')
-re_ahead = re.compile('ahead [0-9]+|behind [0-9]+')
-
-def branch_name(line):
-  m = re_branch_name.match(line)
-  return m.group(1)
-
-interesting = []
-
-def do_one_git(git_dir):
-  global interesting
-  branch_strs = subprocess.check_output(('git', '-C', git_dir, 'branch', 
'-vv')).decode('utf-8').splitlines()
-  interesting_branches = []
-
-  for line in branch_strs:
-name = branch_name(line)
-

Change in osmo-bsc[master]: LCLS: prepare for adding new mode

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11551 )

Change subject: LCLS: prepare for adding new mode
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11551/2/src/osmo-bsc/osmo_bsc_lcls.c
File src/osmo-bsc/osmo_bsc_lcls.c:

https://gerrit.osmocom.org/#/c/11551/2/src/osmo-bsc/osmo_bsc_lcls.c@232
PS2, Line 232: static inline void lcls_mdcx(const struct 
gsm_subscriber_connection *conn, struct mgcp_conn_peer *mdcx_info)
Can you break adding this function and its users to a separate previous patch? 
you are doing several things at the same time in nearby code and it's difficult 
to track all changes here.



--
To view, visit https://gerrit.osmocom.org/11551
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I32ba232ad802625d97a0ad9d0511edc6ac7f251c
Gerrit-Change-Number: 11551
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 31 Oct 2018 19:33:13 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-bsc[master]: RSL: restructure MDCX functions

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11550 )

Change subject: RSL: restructure MDCX functions
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11550/2/src/osmo-bsc/abis_rsl.c
File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/#/c/11550/2/src/osmo-bsc/abis_rsl.c@1865
PS2, Line 1865: struct msgb *rsl_make_ipacc_mdcx(uint8_t chan_nr, uint16_t 
conn_id, uint32_t connect_ip, uint16_t connect_port,
Why not simply passing lchan and keeping all code? Lots of parameters for no 
apparent reason?



--
To view, visit https://gerrit.osmocom.org/11550
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffe2f4f10e841fc36965cce02b4e5f017a5ae6c8
Gerrit-Change-Number: 11550
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 31 Oct 2018 19:23:20 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: cosmetic: fix typos

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/11553 )

Change subject: cosmetic: fix typos
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11553
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e75af46e134d33f752214988054105aba91366c
Gerrit-Change-Number: 11553
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 31 Oct 2018 19:15:14 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: BSC: remove explicit address

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/11554 )

Change subject: BSC: remove explicit address
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11554
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ideb8a78348af435f9992c42bce0bb197d1e73e04
Gerrit-Change-Number: 11554
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 31 Oct 2018 19:15:18 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: cosmetic: fix compilation warnings

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/11557 )

Change subject: cosmetic: fix compilation warnings
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11557
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6210ecf5fcb39f751116ad63a69d2ae8651a60c5
Gerrit-Change-Number: 11557
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 31 Oct 2018 19:15:33 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: BSC LCLS: restructure tests

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/11555 )

Change subject: BSC LCLS: restructure tests
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11555
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf9fc8e639b0ece662ab26c481899ef39fb7edfe
Gerrit-Change-Number: 11555
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 31 Oct 2018 19:15:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: BSC LCLS: explicitly check for RSL_IE_CHAN_NR

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/11556 )

Change subject: BSC LCLS: explicitly check for RSL_IE_CHAN_NR
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11556
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc6824d7acef809d76c70b5ff060a8261a82e2be
Gerrit-Change-Number: 11556
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 31 Oct 2018 19:15:28 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bsc[master]: RSL: restructure MDCX functions

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/11550 )

Change subject: RSL: restructure MDCX functions
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11550
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffe2f4f10e841fc36965cce02b4e5f017a5ae6c8
Gerrit-Change-Number: 11550
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 31 Oct 2018 19:13:59 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bsc[master]: LCLS: prepare for adding new mode

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/11551 )

Change subject: LCLS: prepare for adding new mode
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11551
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I32ba232ad802625d97a0ad9d0511edc6ac7f251c
Gerrit-Change-Number: 11551
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 31 Oct 2018 19:14:05 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-pcap[master]: contrib/jenkins.sh: Update to current osmocom infra

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11549 )

Change subject: contrib/jenkins.sh: Update to current osmocom infra
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11549/1/contrib/jenkins.sh
File contrib/jenkins.sh:

https://gerrit.osmocom.org/#/c/11549/1/contrib/jenkins.sh@42
PS1, Line 42: $MAKE distcheck || cat-testlogs.sh
> Interesting, it worked when I tried it. […]
Making check in tests
make[2]: Entering directory 
'/home/pespin/dev/sysmocom/build/new/tmpdir/osmo-pcap/tests'
make  check-local
make[3]: Entering directory 
'/home/pespin/dev/sysmocom/build/new/tmpdir/osmo-pcap/tests'
make[3]: *** No rule to make target 'atconfig', needed by 'check-local'.  Stop.
make[3]: Leaving directory 
'/home/pespin/dev/sysmocom/build/new/tmpdir/osmo-pcap/tests'
make[2]: *** [Makefile:316: check-am] Error 2



-- 
To view, visit https://gerrit.osmocom.org/11549
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I955b99ce27df143f5d022619dd14e32b763e6c14
Gerrit-Change-Number: 11549
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Wed, 31 Oct 2018 18:39:00 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-pcap[master]: contrib/jenkins.sh: Update to current osmocom infra

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/11549 )

Change subject: contrib/jenkins.sh: Update to current osmocom infra
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11549/1/contrib/jenkins.sh
File contrib/jenkins.sh:

https://gerrit.osmocom.org/#/c/11549/1/contrib/jenkins.sh@42
PS1, Line 42: $MAKE distcheck || cat-testlogs.sh
> Because at least locally make check failed due to some at{foobar} makefile 
> target not working, so I  […]
Interesting, it worked when I tried it. distcheck will also run make check so 
maybe make sure that that works for you as well. It does here.



--
To view, visit https://gerrit.osmocom.org/11549
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I955b99ce27df143f5d022619dd14e32b763e6c14
Gerrit-Change-Number: 11549
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Wed, 31 Oct 2018 18:31:45 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-pcap[master]: test

[Pau Espin Pedrol]

Pau Espin Pedrol has abandoned this change. ( https://gerrit.osmocom.org/11543 )

Change subject: test
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/11543
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Iaab1f6d2d563df7ec3a1f56add2e883b4f697da6
Gerrit-Change-Number: 11543
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 

Change in osmo-pcap[master]: contrib/jenkins.sh: Update to current osmocom infra

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11549 )

Change subject: contrib/jenkins.sh: Update to current osmocom infra
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11549/1/contrib/jenkins.sh
File contrib/jenkins.sh:

https://gerrit.osmocom.org/#/c/11549/1/contrib/jenkins.sh@42
PS1, Line 42: $MAKE distcheck || cat-testlogs.sh
> cat-testlogs. […]
Because at least locally make check failed due to some at{foobar} makefile 
target not working, so I didn't invest time on fixing it since we don't have 
tests anyway.



--
To view, visit https://gerrit.osmocom.org/11549
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I955b99ce27df143f5d022619dd14e32b763e6c14
Gerrit-Change-Number: 11549
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Wed, 31 Oct 2018 18:23:01 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-pcap[master]: test

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/11543 )

Change subject: test
..


Patch Set 1: Code-Review-1

Abandon?


--
To view, visit https://gerrit.osmocom.org/11543
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaab1f6d2d563df7ec3a1f56add2e883b4f697da6
Gerrit-Change-Number: 11543
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Wed, 31 Oct 2018 18:22:21 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: Fix VLR test macro

[Max]

Max has abandoned this change. ( https://gerrit.osmocom.org/6296 )

Change subject: Fix VLR test macro
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/6296
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I36ae1f9bb395921dc2c5a39e35fbb8040ba47213
Gerrit-Change-Number: 6296
Gerrit-PatchSet: 7
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: neels 
Gerrit-CC: Pau Espin Pedrol 

Change in osmo-pcap[master]: contrib/jenkins.sh: Update to current osmocom infra

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/11549 )

Change subject: contrib/jenkins.sh: Update to current osmocom infra
..


Patch Set 1: Code-Review+1

(1 comment)

Looks okay comparing it to an existing jenkins.sh in osmo-bsc

https://gerrit.osmocom.org/#/c/11549/1/contrib/jenkins.sh
File contrib/jenkins.sh:

https://gerrit.osmocom.org/#/c/11549/1/contrib/jenkins.sh@42
PS1, Line 42: $MAKE distcheck || cat-testlogs.sh
cat-testlogs.sh wouldn't actually do anything useful since we don't have tests 
(yet?), but it shouldn't do any harm, either. If you want to leave it in for 
future tests why not leave the make check call in as well since there is 
already an empty testsuite?



--
To view, visit https://gerrit.osmocom.org/11549
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I955b99ce27df143f5d022619dd14e32b763e6c14
Gerrit-Change-Number: 11549
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Wed, 31 Oct 2018 18:16:28 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-pcap[master]: gitignore: Add compile

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/11547 )

Change subject: gitignore: Add compile
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11547
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie801d6929068d11fafd24a1370e60e984b0137c2
Gerrit-Change-Number: 11547
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Wed, 31 Oct 2018 18:03:16 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-pcap[master]: Install cfg files with autotools

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/11546 )

Change subject: Install cfg files with autotools
..


Patch Set 2: Code-Review-1

(1 comment)

Apart from the commit message it looks good

https://gerrit.osmocom.org/#/c/11546/2//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11546/2//COMMIT_MSG@11
PS2, Line 11: $prefix/share/doc/osmo-trx/examples/$subdir/, and 1 script per 
binary is
s/osmo-trx/osmo-pcap/



--
To view, visit https://gerrit.osmocom.org/11546
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3f3a7d3867c0d4d2b1fe01f465532d1ce4bda66
Gerrit-Change-Number: 11546
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Wed, 31 Oct 2018 18:02:14 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-pcap[master]: debian: Install osmo_pcap_clean_old in osmo-pcap-server pkg

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/11548 )

Change subject: debian: Install osmo_pcap_clean_old in osmo-pcap-server pkg
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11548
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4b031fdf54cde3d00818df82e89733420a735ba
Gerrit-Change-Number: 11548
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Wed, 31 Oct 2018 17:44:38 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-pcap[master]: debian: Clean up to look like other osmocom projects

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/11544 )

Change subject: debian: Clean up to look like other osmocom projects
..


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/11544/2/debian/copyright
File debian/copyright:

https://gerrit.osmocom.org/#/c/11544/2/debian/copyright@2
PS2, Line 2: Upstream-Name: OsmoHLR
c issue


https://gerrit.osmocom.org/#/c/11544/2/debian/copyright@3
PS2, Line 3: Source: http://cgit.osmocom.org/osmo-hlr/
Here as well


https://gerrit.osmocom.org/#/c/11544/2/debian/copyright@6
PS2, Line 6: Copyright: 2018 Sysmocom s. f. m. c. GmbH 
The sources all only list Holger and On-Waves as copyright holders...



--
To view, visit https://gerrit.osmocom.org/11544
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id71699642b799f5b2f8f3b794b9493ddaeb70cc0
Gerrit-Change-Number: 11544
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Wed, 31 Oct 2018 17:44:27 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #293

[jenkins]

See 


--
[...truncated 3.67 KB...]

+ ./configure
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking 

Change in osmo-dev[master]: deps: osmo-sgsn depends on osmo-hlr's liboso-gsup-client

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded a new patch set (#3). ( 
https://gerrit.osmocom.org/11537 )

Change subject: deps: osmo-sgsn depends on osmo-hlr's liboso-gsup-client
..

deps: osmo-sgsn depends on osmo-hlr's liboso-gsup-client

Change-Id: Ie47ca98740ca438e04d6ea76421e0f58d9e5715a
---
M 2G.deps
M 3G+2G.deps
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/37/11537/3
--
To view, visit https://gerrit.osmocom.org/11537
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie47ca98740ca438e04d6ea76421e0f58d9e5715a
Gerrit-Change-Number: 11537
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-pcap[master]: contrib/jenkins.sh: Update to current osmocom infra

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11549


Change subject: contrib/jenkins.sh: Update to current osmocom infra
..

contrib/jenkins.sh: Update to current osmocom infra

Otherwise builds end failing in osmocom jenkins/gerrit.

Change-Id: I955b99ce27df143f5d022619dd14e32b763e6c14
---
M contrib/jenkins.sh
1 file changed, 37 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/49/11549/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index e099ceb..d708369 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -1,19 +1,44 @@
 #!/usr/bin/env bash
+# jenkins build helper script for osmo-pcap.  This is how we build on 
jenkins.osmocom.org
+
+if ! [ -x "$(command -v osmo-build-dep.sh)" ]; then
+   echo "Error: We need to have scripts/osmo-deps.sh from 
http://git.osmocom.org/osmo-ci/ in PATH !"
+   exit 2
+fi

 set -ex

-rm -rf deps/install
-mkdir deps || true
-cd deps
-osmo-deps.sh libosmocore

-cd libosmocore
-autoreconf --install --force
-./configure --prefix=$PWD/../install
-$MAKE $PARALLEL_MAKE install
+base="$PWD"
+deps="$base/deps"
+inst="$deps/install"
+export deps inst

-cd ../../
+osmo-clean-workspace.sh
+
+mkdir "$deps" || true
+
+verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
+
+export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH"
+export LD_LIBRARY_PATH="$inst/lib"
+osmo-build-dep.sh libosmocore "" '--disable-doxygen --enable-gnutls'
+
+set +x
+echo
+echo
+echo
+echo " === osmo-pcap 
==="
+echo
+set -x
+
+
+cd "$base"
 autoreconf --install --force
-PCAP_LIBS="-lpcap" PCAP_CFLAGS="" 
PKG_CONFIG_PATH=$PWD/deps/install/lib/pkgconfig ./configure 
--with-pcap-config=/bin/true --enable-sanitize --enable-werror
-PKG_CONFIG_PATH=$PWD/deps/install/lib/pkgconfig $MAKE $PARALLEL_MAKE
-DISTCHECK_CONFIGURE_FLAGS="--with-pcap-config=/bin/true" PCAP_LIBS="-lpcap" 
PCAP_CFLAGS="" PKG_CONFIG_PATH=$PWD/deps/install/lib/pkgconfig 
LD_LIBRARY_PATH=$PWD/deps/install/lib $MAKE distcheck
+PCAP_LIBS="-lpcap" PCAP_CFLAGS="" ./configure --with-pcap-config=/bin/true 
--enable-sanitize --enable-werror
+$MAKE $PARALLEL_MAKE
+DISTCHECK_CONFIGURE_FLAGS="--with-pcap-config=/bin/true" \
+PCAP_LIBS="-lpcap" PCAP_CFLAGS="" \
+$MAKE distcheck || cat-testlogs.sh
+
+osmo-clean-workspace.sh

--
To view, visit https://gerrit.osmocom.org/11549
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I955b99ce27df143f5d022619dd14e32b763e6c14
Gerrit-Change-Number: 11549
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-dev[master]: deps: osmo-sgsn depends on osmo-hlr's liboso-gsup-client

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded a new patch set (#2). ( 
https://gerrit.osmocom.org/11537 )

Change subject: deps: osmo-sgsn depends on osmo-hlr's liboso-gsup-client
..

deps: osmo-sgsn depends on osmo-hlr's liboso-gsup-client

Change-Id: Ie47ca98740ca438e04d6ea76421e0f58d9e5715a
---
M 2G.deps
M 3G+2G.deps
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/37/11537/2
--
To view, visit https://gerrit.osmocom.org/11537
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie47ca98740ca438e04d6ea76421e0f58d9e5715a
Gerrit-Change-Number: 11537
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-pcap[master]: Install systemd services with autotools

[Pau Espin Pedrol]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11545

to look at the new patch set (#2).

Change subject: Install systemd services with autotools
..

Install systemd services with autotools

Change-Id: Id938f3dab4826ac748abb5e0b169d800c2a625a5
---
M Makefile.am
M configure.ac
M contrib/Makefile.am
A contrib/systemd/Makefile.am
A contrib/systemd/osmo-pcap-client.service
A contrib/systemd/osmo-pcap-server.service
M debian/osmo-pcap-client.install
M debian/osmo-pcap-server.install
M debian/rules
9 files changed, 63 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/45/11545/2
--
To view, visit https://gerrit.osmocom.org/11545
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id938f3dab4826ac748abb5e0b169d800c2a625a5
Gerrit-Change-Number: 11545
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-dev[master]: 2G.deps, 3G+2G.deps: add osmo-trx

[osmith]

osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11389 )

Change subject: 2G.deps, 3G+2G.deps: add osmo-trx
..

2G.deps, 3G+2G.deps: add osmo-trx

Change-Id: Ia4ebf2732694cee0600b602b82c660cf6278958d
---
M 2G.deps
M 3G+2G.deps
2 files changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  osmith: Verified



diff --git a/2G.deps b/2G.deps
index d6a58ad..213cb3d 100644
--- a/2G.deps
+++ b/2G.deps
@@ -10,3 +10,4 @@
 osmo-msc   libosmo-sccp osmo-mgw libsmpp34
 osmo-bsc   libosmo-sccp osmo-mgw
 osmo-sgsn  libosmo-sccp osmo-ggsn
+osmo-trx   libosmocore
diff --git a/3G+2G.deps b/3G+2G.deps
index 5a17146..0eea175 100644
--- a/3G+2G.deps
+++ b/3G+2G.deps
@@ -13,3 +13,4 @@
 osmo-bsc   libosmo-sccp osmo-mgw
 osmo-sgsn  osmo-iuh osmo-ggsn
 osmo-sip-connector libosmocore
+osmo-trx   libosmocore

--
To view, visit https://gerrit.osmocom.org/11389
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4ebf2732694cee0600b602b82c660cf6278958d
Gerrit-Change-Number: 11389
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 

Change in osmo-dev[master]: gen_makefile.py: detect changes in cpp files

[osmith]

osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11434 )

Change subject: gen_makefile.py: detect changes in cpp files
..

gen_makefile.py: detect changes in cpp files

Properly rebuild when cpp files (e.g. from osmo-trx) have been changed.

Change-Id: I9382d984fa1988eefbb6be3e45d88b2f1f5b598a
---
M gen_makefile.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  osmith: Verified
  Harald Welte: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Neels Hofmeyr: Looks good to me, approved



diff --git a/gen_makefile.py b/gen_makefile.py
index c2b6128..1ae29f5 100755
--- a/gen_makefile.py
+++ b/gen_makefile.py
@@ -168,7 +168,7 @@
 ### {proj} ###

 {proj}_configure_files := $(shell find {src_proj} -name "Makefile.am" -or 
-name "*.in" )
-{proj}_files := $(shell find {src_proj} -name "*.[hc]" -or -name "*.py" )
+{proj}_files := $(shell find {src_proj} -name "*.[hc]" -or -name "*.py" -or 
-name "*.cpp" )

 .make.{proj}.clone:
@echo "\n\n\n= $@\n"

--
To view, visit https://gerrit.osmocom.org/11434
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9382d984fa1988eefbb6be3e45d88b2f1f5b598a
Gerrit-Change-Number: 11434
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 

Change in osmo-dev[master]: 2G.deps, 3G+2G.deps: add osmo-trx

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/11389 )

Change subject: 2G.deps, 3G+2G.deps: add osmo-trx
..


Patch Set 3: Verified+1


--
To view, visit https://gerrit.osmocom.org/11389
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ebf2732694cee0600b602b82c660cf6278958d
Gerrit-Change-Number: 11389
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 31 Oct 2018 13:23:07 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: 2G.deps, 3G+2G.deps: add osmo-trx

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11389 )

Change subject: 2G.deps, 3G+2G.deps: add osmo-trx
..


Patch Set 3: Code-Review+2

that was fast


--
To view, visit https://gerrit.osmocom.org/11389
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ebf2732694cee0600b602b82c660cf6278958d
Gerrit-Change-Number: 11389
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 31 Oct 2018 13:19:41 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: gen_makefile.py: detect changes in cpp files

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/11434 )

Change subject: gen_makefile.py: detect changes in cpp files
..


Patch Set 2: Verified+1


--
To view, visit https://gerrit.osmocom.org/11434
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9382d984fa1988eefbb6be3e45d88b2f1f5b598a
Gerrit-Change-Number: 11434
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 31 Oct 2018 13:14:47 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: support osmo-sip-connector with kamailio

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/11144 )

Change subject: support osmo-sip-connector with kamailio
..


Patch Set 9: Verified+1


--
To view, visit https://gerrit.osmocom.org/11144
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5c4e9992eab390bc6d26ada7564223ff41a01b2
Gerrit-Change-Number: 11144
Gerrit-PatchSet: 9
Gerrit-Owner: osmith 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-CC: daniel 
Gerrit-Comment-Date: Wed, 31 Oct 2018 13:14:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: support osmo-sip-connector with kamailio

[osmith]

osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11144 )

Change subject: support osmo-sip-connector with kamailio
..

support osmo-sip-connector with kamailio

Kamailio is a SIP server, that is relatively easy to configure, in
contrary to asterisk it only has one config file. The config file
here is based on the example config provided in the wiki:



To enable the osmo-sip-connector, build it, install kamailio and
then set SIPCON_ENABLE=true in your copy of config_2g_3g.

Change-Id: Ia5c4e9992eab390bc6d26ada7564223ff41a01b2
---
M net/config_2g3g
A net/tmpl_std/kamailio.cfg
A net/tmpl_std/osmo-sip-connector.cfg
M net/tmpl_std/run.sh
4 files changed, 462 insertions(+), 3 deletions(-)

Approvals:
  osmith: Verified
  Neels Hofmeyr: Looks good to me, approved



diff --git a/net/config_2g3g b/net/config_2g3g
index c4545a4..622a4be 100644
--- a/net/config_2g3g
+++ b/net/config_2g3g
@@ -30,6 +30,7 @@
 HLR_IP="127.0.0.1"

 MSC_PC="0.23.1"
+MSC_MNCC_SOCKET="${NET_DIR}/msc_mncc_socket"

 AUTH=optional
 ENCR_A5=0
@@ -72,3 +73,9 @@
 SCRAMBLE2=258
 LAC2=2${UARFCN2}
 RAC2=22
+
+SIPCON_ENABLE="false"
+SIPCON_LOCAL="${PUBLIC_IP}"
+SIPCON_LOCAL_PORT="5069"
+SIPCON_REMOTE="${PUBLIC_IP}"
+SIPCON_REMOTE_PORT="5060"
diff --git a/net/tmpl_std/kamailio.cfg b/net/tmpl_std/kamailio.cfg
new file mode 100644
index 000..c5b0bf2
--- /dev/null
+++ b/net/tmpl_std/kamailio.cfg
@@ -0,0 +1,419 @@
+#!KAMAILIO
+
+#!define WITH_DEBUG
+#!define WITH_PSTN
+
+### Defined Values #
+
+# - flags
+#   FLT_ - per transaction (message) flags
+#   FLB_ - per branch flags
+#!define FLT_ACC 1
+#!define FLT_ACCMISSED 2
+#!define FLT_ACCFAILED 3
+#!define FLT_NATS 5
+#!define FLB_NATB 6
+#!define FLB_NATSIPPING 7
+
+### Global Parameters #
+
+### LOG Levels: 3=DBG, 2=INFO, 1=NOTICE, 0=WARN, -1=ERR
+#!ifdef WITH_DEBUG
+debug=2
+log_stderror=yes
+#!else
+debug=2
+log_stderror=no
+#!endif
+
+memdbg=5
+memlog=5
+
+log_facility=LOG_LOCAL0
+rundir="${NET_DIR}/kamailio_rundir"
+
+fork=yes
+children=4
+
+/* uncomment the next line to disable TCP (default on) */
+disable_tcp=yes
+
+/* uncomment the next line to disable the auto discovery of local aliases
+   based on reverse DNS on IPs (default on) */
+auto_aliases=no
+
+/* add local domain aliases */
+#alias="sip.mydomain.com"
+
+/* uncomment and configure the following line if you want Kamailio to
+   bind on a specific interface/port/proto (default bind on all available) */
+listen=${SIPCON_REMOTE}:${SIPCON_REMOTE_PORT}
+
+/* port to listen to
+ * - can be specified more than once if needed to listen on many ports */
+port=${SIPCON_REMOTE_PORT}
+
+# life time of TCP connection when there is no traffic
+# - a bit higher than registration expires to cope with UA behind NAT
+tcp_connection_lifetime=3605
+
+### Custom Parameters #
+
+# These parameters can be modified runtime via RPC interface
+# - see the documentation of 'cfg_rpc' module.
+#
+# Format: group.id = value 'desc' description
+# Access: $sel(cfg_get.group.id) or @cfg_get.group.id
+#
+
+#!ifdef WITH_PSTN
+# PSTN GW Routing
+#
+# - pstn.gw_ip: valid IP or hostname as string value, example:
+# pstn.gw_ip = "10.0.0.101" desc "My PSTN GW Address"
+#
+# - by default is empty to avoid misrouting
+pstn.gw_ip = "${SIPCON_LOCAL}:${SIPCON_LOCAL_PORT}" desc "osmo-sip-connector 
Address"
+#!endif
+
+
+### Modules Section 
+
+# set paths to location of modules (to sources or installation folders)
+#!ifdef WITH_SRCPATH
+mpath="modules"
+#!else
+mpath="/usr/lib/x86_64-linux-gnu/kamailio/modules/"
+#!endif
+
+# loadmodule "mi_fifo.so"
+loadmodule "kex.so"
+loadmodule "corex.so"
+loadmodule "tm.so"
+loadmodule "tmx.so"
+loadmodule "sl.so"
+loadmodule "rr.so"
+loadmodule "pv.so"
+loadmodule "maxfwd.so"
+loadmodule "usrloc.so"
+loadmodule "registrar.so"
+loadmodule "textops.so"
+loadmodule "siputils.so"
+loadmodule "xlog.so"
+loadmodule "sanity.so"
+# loadmodule "ctl.so"
+loadmodule "cfg_rpc.so"
+loadmodule "mi_rpc.so"
+loadmodule "acc.so"
+
+#!ifdef WITH_NAT
+loadmodule "nathelper.so"
+loadmodule "rtpproxy.so"
+#!endif
+
+#!ifdef WITH_DEBUG
+loadmodule "debugger.so"
+#!endif
+
+# - setting module-specific parameters ---
+
+# - mi_fifo params -
+#modparam("mi_fifo", "fifo_name", "/var/run/kamailio/kamailio_fifo")
+
+# - ctl params -
+#modparam("ctl", "binrpc", "unix:/var/run/kamailio/kamailio_ctl")
+
+# - tm params -
+# auto-discard branches from previous serial forking leg
+modparam("tm", "failure_reply_mode", 3)
+# default retransmission timeout: 30sec
+modparam("tm", "fr_timer", 3)
+# default invite retransmission timeout after 1xx: 120sec
+modparam("tm", "fr_inv_timer", 12)
+
+# - rr params -
+# add value to ;lr param to cope with most of the UAs
+modparam("rr", "enable_full_lr", 1)
+# do 

Change in osmo-dev[master]: 2G.deps, 3G+2G.deps: add osmo-trx

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/11389 )

Change subject: 2G.deps, 3G+2G.deps: add osmo-trx
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11389/2/3G%2B2G.deps
File 3G+2G.deps:

https://gerrit.osmocom.org/#/c/11389/2/3G%2B2G.deps@16
PS2, Line 16: osmo-trx  libosmocore
> how about in 2G. […]
Done



-- 
To view, visit https://gerrit.osmocom.org/11389
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ebf2732694cee0600b602b82c660cf6278958d
Gerrit-Change-Number: 11389
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 31 Oct 2018 13:14:03 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-dev[master]: 2G.deps, 3G+2G.deps: add osmo-trx

[osmith]

Hello Pau Espin Pedrol, Neels Hofmeyr, Harald Welte,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11389

to look at the new patch set (#3).

Change subject: 2G.deps, 3G+2G.deps: add osmo-trx
..

2G.deps, 3G+2G.deps: add osmo-trx

Change-Id: Ia4ebf2732694cee0600b602b82c660cf6278958d
---
M 2G.deps
M 3G+2G.deps
2 files changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/89/11389/3
--
To view, visit https://gerrit.osmocom.org/11389
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia4ebf2732694cee0600b602b82c660cf6278958d
Gerrit-Change-Number: 11389
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-dev[master]: gen_makefile.py: detect changes in cpp files

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11434 )

Change subject: gen_makefile.py: detect changes in cpp files
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11434
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9382d984fa1988eefbb6be3e45d88b2f1f5b598a
Gerrit-Change-Number: 11434
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 31 Oct 2018 13:11:31 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: 3G+2G.deps: add osmo-trx

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11389 )

Change subject: 3G+2G.deps: add osmo-trx
..


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/11389/2/3G%2B2G.deps
File 3G+2G.deps:

https://gerrit.osmocom.org/#/c/11389/2/3G%2B2G.deps@16
PS2, Line 16: osmo-trx  libosmocore
how about in 2G.deps as well?



--
To view, visit https://gerrit.osmocom.org/11389
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ebf2732694cee0600b602b82c660cf6278958d
Gerrit-Change-Number: 11389
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 31 Oct 2018 13:11:02 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: support osmo-sip-connector with kamailio

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11144 )

Change subject: support osmo-sip-connector with kamailio
..


Patch Set 8: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11144
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5c4e9992eab390bc6d26ada7564223ff41a01b2
Gerrit-Change-Number: 11144
Gerrit-PatchSet: 8
Gerrit-Owner: osmith 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-CC: daniel 
Gerrit-Comment-Date: Wed, 31 Oct 2018 13:08:06 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: fill_config.py: add NET_DIR variable

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11426 )

Change subject: fill_config.py: add NET_DIR variable
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/11426
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbdf478ebb9f0b2fcd860e5eff3c414a0a459561
Gerrit-Change-Number: 11426
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 31 Oct 2018 13:06:57 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: fill_config.py: add NET_DIR variable

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11426 )

Change subject: fill_config.py: add NET_DIR variable
..

fill_config.py: add NET_DIR variable

Allow all config files to use a new NET_DIR variable, which always
points to the network folder with the generated configs. We can use
this to place all temporary files (sockets, pid files, ...) there.

Change-Id: Idbdf478ebb9f0b2fcd860e5eff3c414a0a459561
---
M net/README
M net/fill_config.py
2 files changed, 6 insertions(+), 3 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved; Verified



diff --git a/net/README b/net/README
index 352bc56..1d07775 100644
--- a/net/README
+++ b/net/README
@@ -71,7 +71,8 @@

 The fill_config.py script helps to fill the templates with the config values. 
Simply
 invoke fill_config.py with a dir argument (templates dir) and a file argument 
(specific
-config values).
+config values). The dir argument can be used in the templates with ${NET_DIR},
+temporary files (sockets etc.) should be placed inside this folder.

 If one or both are omitted, the script tries to re-use the most recent paths,
 they were stored in local files '.last_config' and '.last_templates'.
diff --git a/net/fill_config.py b/net/fill_config.py
index d0e2e04..c33e6b7 100755
--- a/net/fill_config.py
+++ b/net/fill_config.py
@@ -50,8 +50,9 @@

 local_config_file = os.path.realpath(local_config_file)
 tmpl_dir = os.path.realpath(tmpl_dir)
+net_dir = os.path.realpath(".")

-print('using config file %r\non templates %r' % (local_config_file, tmpl_dir))
+print('using config file %r\non templates %r\nwith NET_DIR %r' % 
(local_config_file, tmpl_dir, net_dir))

 with open(LAST_LOCAL_CONFIG_FILE, 'w') as last_file:
   last_file.write(local_config_file)
@@ -59,7 +60,8 @@
   last_file.write(tmpl_dir)

 # read in variable values from config file
-local_config = {}
+# NET_DIR is the folder where fill_config.py was started
+local_config = {"NET_DIR": net_dir}

 line_nr = 0
 for line in open(local_config_file):

--
To view, visit https://gerrit.osmocom.org/11426
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idbdf478ebb9f0b2fcd860e5eff3c414a0a459561
Gerrit-Change-Number: 11426
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 

Change in osmo-dev[master]: fill_config.py: add NET_DIR variable

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11426 )

Change subject: fill_config.py: add NET_DIR variable
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11426
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbdf478ebb9f0b2fcd860e5eff3c414a0a459561
Gerrit-Change-Number: 11426
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 31 Oct 2018 13:06:42 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-pcap[master]: debian: Install osmo_pcap_clean_old in osmo-pcap-server pkg

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11548


Change subject: debian: Install osmo_pcap_clean_old in osmo-pcap-server pkg
..

debian: Install osmo_pcap_clean_old in osmo-pcap-server pkg

Change-Id: Ia4b031fdf54cde3d00818df82e89733420a735ba
---
M debian/osmo-pcap-server.install
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/48/11548/1

diff --git a/debian/osmo-pcap-server.install b/debian/osmo-pcap-server.install
index cedee92..0cb99b1 100644
--- a/debian/osmo-pcap-server.install
+++ b/debian/osmo-pcap-server.install
@@ -3,3 +3,4 @@
 usr/bin/osmo-pcap-server
 usr/share/doc/osmo-pcap/examples/osmo-pcap-server/osmo-pcap-server.cfg
 usr/share/doc/osmo-pcap/examples/osmo-pcap-server/osmo-pcap-server-tls.cfg
+usr/share/osmo-pcap/osmo_pcap_clean_old

--
To view, visit https://gerrit.osmocom.org/11548
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4b031fdf54cde3d00818df82e89733420a735ba
Gerrit-Change-Number: 11548
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-pcap[master]: gitignore: Add compile

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11547


Change subject: gitignore: Add compile
..

gitignore: Add compile

Change-Id: Ie801d6929068d11fafd24a1370e60e984b0137c2
---
M .gitignore
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/47/11547/1

diff --git a/.gitignore b/.gitignore
index 7e4da82..b80db93 100644
--- a/.gitignore
+++ b/.gitignore
@@ -17,6 +17,7 @@
 install-sh
 missing
 stamp-h1
+compile

 osmopcapconfig.h*


--
To view, visit https://gerrit.osmocom.org/11547
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie801d6929068d11fafd24a1370e60e984b0137c2
Gerrit-Change-Number: 11547
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-pcap[master]: Install cfg files with autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11546


Change subject: Install cfg files with autotools
..

Install cfg files with autotools

Cfg files are moved to doc/examples like in other osmocom projects.
All the cfg files get installed into
$prefix/share/doc/osmo-trx/examples/$subdir/, and 1 script per binary is
installed into /etc/osmocom.

Change-Id: If3f3a7d3867c0d4d2b1fe01f465532d1ce4bda66
---
M Makefile.am
M configure.ac
M contrib/Makefile.am
M debian/osmo-pcap-client.install
M debian/osmo-pcap-server.install
M debian/rules
A doc/Makefile.am
A doc/examples/Makefile.am
R doc/examples/osmo-pcap-client/osmo-pcap-client-tls.cfg
R doc/examples/osmo-pcap-client/osmo-pcap-client.cfg
R doc/examples/osmo-pcap-server/osmo-pcap-server-tls.cfg
R doc/examples/osmo-pcap-server/osmo-pcap-server.cfg
12 files changed, 40 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/46/11546/1

diff --git a/Makefile.am b/Makefile.am
index 61eb85d..cf8dfa3 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,6 +1,6 @@
 AUTOMAKE_OPTIONS = foreign dist-bzip2 1.6

-SUBDIRS = include src contrib tests
+SUBDIRS = include src contrib doc tests

 BUILT_SOURCES = $(top_srcdir)/.version
 EXTRA_DIST = git-version-gen .version
diff --git a/configure.ac b/configure.ac
index a0f786f..b16ae13 100644
--- a/configure.ac
+++ b/configure.ac
@@ -138,5 +138,7 @@
 src/Makefile
 contrib/Makefile
 contrib/systemd/Makefile
+doc/Makefile
+doc/examples/Makefile
 tests/Makefile
 Makefile)
diff --git a/contrib/Makefile.am b/contrib/Makefile.am
index 7bd8c23..e1927a7 100644
--- a/contrib/Makefile.am
+++ b/contrib/Makefile.am
@@ -1,3 +1,2 @@
 SUBDIRS = systemd
 dist_pkgdata_DATA = osmo_pcap_clean_old
-EXTRA_DIST = osmo-pcap-server.cfg osmo-pcap-client.cfg
diff --git a/debian/osmo-pcap-client.install b/debian/osmo-pcap-client.install
index ac7c65c..ef6576e 100644
--- a/debian/osmo-pcap-client.install
+++ b/debian/osmo-pcap-client.install
@@ -1,2 +1,5 @@
+etc/osmocom/osmo-pcap-client.cfg
 lib/systemd/system/osmo-pcap-client.service
 usr/bin/osmo-pcap-client
+usr/share/doc/osmo-pcap/examples/osmo-pcap-client/osmo-pcap-client.cfg
+usr/share/doc/osmo-pcap/examples/osmo-pcap-client/osmo-pcap-client-tls.cfg
diff --git a/debian/osmo-pcap-server.install b/debian/osmo-pcap-server.install
index 6ba698e..cedee92 100644
--- a/debian/osmo-pcap-server.install
+++ b/debian/osmo-pcap-server.install
@@ -1,2 +1,5 @@
+etc/osmocom/osmo-pcap-server.cfg
 lib/systemd/system/osmo-pcap-server.service
 usr/bin/osmo-pcap-server
+usr/share/doc/osmo-pcap/examples/osmo-pcap-server/osmo-pcap-server.cfg
+usr/share/doc/osmo-pcap/examples/osmo-pcap-server/osmo-pcap-server-tls.cfg
diff --git a/debian/rules b/debian/rules
index a9a8b30..90bd79e 100755
--- a/debian/rules
+++ b/debian/rules
@@ -21,17 +21,6 @@
PCAP_CFLAGS=$(PCAP_CFLAGS) \
PCAP_LIBS=$(PCAP_LIBS)

-override_dh_auto_install:
-   dh_auto_install $@
-   install -d -m 0755 $(CURDIR)/debian/osmo-pcap-client/etc/osmo-pcap/
-   install -m 0644 $(CURDIR)/contrib/osmo-pcap-client.cfg 
$(CURDIR)/debian/osmo-pcap-client/etc/osmo-pcap
-
-   install -d -m 0755 $(CURDIR)/debian/osmo-pcap-server/etc/osmo-pcap/
-   install -m 0644 $(CURDIR)/contrib/osmo-pcap-server.cfg 
$(CURDIR)/debian/osmo-pcap-server/etc/osmo-pcap
-
-   install -d -m 0755 $(CURDIR)/debian/osmo-pcap-server/etc/cron.daily/
-   install -m 0755 $(CURDIR)/contrib/osmo_pcap_clean_old 
$(CURDIR)/debian/osmo-pcap-server/etc/cron.daily/
-
 override_dh_strip:
dh_strip -posmo-pcap-client --dbg-package=osmo-pcap-client-dbg
dh_strip -posmo-pcap-server --dbg-package=osmo-pcap-server-dbg
diff --git a/doc/Makefile.am b/doc/Makefile.am
new file mode 100644
index 000..aee2d7b
--- /dev/null
+++ b/doc/Makefile.am
@@ -0,0 +1 @@
+SUBDIRS = examples
diff --git a/doc/examples/Makefile.am b/doc/examples/Makefile.am
new file mode 100644
index 000..9337c9e
--- /dev/null
+++ b/doc/examples/Makefile.am
@@ -0,0 +1,30 @@
+OSMOCONF_FILES = \
+   osmo-pcap-client/osmo-pcap-client.cfg \
+   osmo-pcap-server/osmo-pcap-server.cfg
+
+osmoconfdir = $(sysconfdir)/osmocom
+osmoconf_DATA = $(OSMOCONF_FILES)
+EXTRA_DIST = $(OSMOCONF_FILES)
+
+CFG_FILES = find $(srcdir) -type f -name '*.cfg*' | sed -e 's,^$(srcdir),,'
+
+dist-hook:
+   for f in $$($(CFG_FILES)); do \
+   j="$(distdir)/$$f" && \
+   mkdir -p "$$(dirname $$j)" && \
+   $(INSTALL_DATA) $(srcdir)/$$f $$j; \
+   done
+
+install-data-hook:
+   for f in $$($(CFG_FILES)); do \
+   j="$(DESTDIR)$(docdir)/examples/$$f" && \
+   mkdir -p "$$(dirname $$j)" && \
+   $(INSTALL_DATA) $(srcdir)/$$f $$j; \
+   done
+
+uninstall-hook:
+   @$(PRE_UNINSTALL)
+   for f in $$($(CFG_FILES)); do \
+   

Change in osmo-pcap[master]: debian: Clean up to look like other osmocom projects

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11544


Change subject: debian: Clean up to look like other osmocom projects
..

debian: Clean up to look like other osmocom projects

Change-Id: Id71699642b799f5b2f8f3b794b9493ddaeb70cc0
---
D debian/README
M debian/compat
A debian/copyright
D debian/init.d.ex
D debian/osmo-pcap-client.init
D debian/osmo-pcap.default.ex
M debian/rules
7 files changed, 28 insertions(+), 338 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/44/11544/1

diff --git a/debian/README b/debian/README
deleted file mode 100644
index 1719eed..000
--- a/debian/README
+++ /dev/null
@@ -1,6 +0,0 @@
-The Debian Package osmo-pcap
-
-
-Comments regarding the Package
-
- -- Holger Hans Peter Freyther   Wed, 01 Jun 2011 14:51:32 
+0200
diff --git a/debian/compat b/debian/compat
index 7f8f011..ec63514 100644
--- a/debian/compat
+++ b/debian/compat
@@ -1 +1 @@
-7
+9
diff --git a/debian/copyright b/debian/copyright
new file mode 100644
index 000..5b7df8b
--- /dev/null
+++ b/debian/copyright
@@ -0,0 +1,21 @@
+Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Upstream-Name: OsmoHLR
+Source: http://cgit.osmocom.org/osmo-hlr/
+
+Files: *
+Copyright: 2018 Sysmocom s. f. m. c. GmbH 
+License: AGPL-3+
+
+License: AGPL-3+
+ This program is free software: you can redistribute it and/or modify
+ it under the terms of the GNU Affero General Public License as published by
+ the Free Software Foundation, either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ GNU Affero General Public License for more details.
+
+ You should have received a copy of the GNU Affero General Public License
+ along with this program.  If not, see .
diff --git a/debian/init.d.ex b/debian/init.d.ex
deleted file mode 100644
index 8cabb58..000
--- a/debian/init.d.ex
+++ /dev/null
@@ -1,154 +0,0 @@
-#!/bin/sh
-### BEGIN INIT INFO
-# Provides:  osmo-pcap
-# Required-Start:$network $local_fs
-# Required-Stop:
-# Default-Start: 2 3 4 5
-# Default-Stop:  0 1 6
-# Short-Description: 
-# Description:   
-#<...>
-#<...>
-### END INIT INFO
-
-# Author: Holger Hans Peter Freyther 
-
-# PATH should only include /usr/* if it runs after the mountnfs.sh script
-PATH=/sbin:/usr/sbin:/bin:/usr/bin
-DESC=osmo-pcap # Introduce a short description here
-NAME=osmo-pcap # Introduce the short server's name here
-DAEMON=/usr/sbin/osmo-pcap # Introduce the server's location here
-DAEMON_ARGS="" # Arguments to run the daemon with
-PIDFILE=/var/run/$NAME.pid
-SCRIPTNAME=/etc/init.d/$NAME
-
-# Exit if the package is not installed
-[ -x $DAEMON ] || exit 0
-
-# Read configuration variable file if it is present
-[ -r /etc/default/$NAME ] && . /etc/default/$NAME
-
-# Load the VERBOSE setting and other rcS variables
-. /lib/init/vars.sh
-
-# Define LSB log_* functions.
-# Depend on lsb-base (>= 3.0-6) to ensure that this file is present.
-. /lib/lsb/init-functions
-
-#
-# Function that starts the daemon/service
-#
-do_start()
-{
-   # Return
-   #   0 if daemon has been started
-   #   1 if daemon was already running
-   #   2 if daemon could not be started
-   start-stop-daemon --start --quiet --pidfile $PIDFILE --exec $DAEMON 
--test > /dev/null \
-   || return 1
-   start-stop-daemon --start --quiet --pidfile $PIDFILE --exec $DAEMON -- \
-   $DAEMON_ARGS \
-   || return 2
-   # Add code here, if necessary, that waits for the process to be ready
-   # to handle requests from services started subsequently which depend
-   # on this one.  As a last resort, sleep for some time.
-}
-
-#
-# Function that stops the daemon/service
-#
-do_stop()
-{
-   # Return
-   #   0 if daemon has been stopped
-   #   1 if daemon was already stopped
-   #   2 if daemon could not be stopped
-   #   other if a failure occurred
-   start-stop-daemon --stop --quiet --retry=TERM/30/KILL/5 --pidfile 
$PIDFILE --name $NAME
-   RETVAL="$?"
-   [ "$RETVAL" = 2 ] && return 2
-   # Wait for children to finish too if this is a daemon that forks
-   # and if the daemon is only ever run from this initscript.
-   # If the above conditions are not satisfied then add some other code
-   # that waits for the process to drop all resources that could be
-   # needed by services started subsequently.  A last resort is to
-   # sleep for some time.
-   start-stop-daemon --stop --quiet --oknodo --retry=0/30/KILL/5 --exec 
$DAEMON
-   [ 

Change in osmo-pcap[master]: Install systemd services with autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11545


Change subject: Install systemd services with autotools
..

Install systemd services with autotools

Change-Id: Id938f3dab4826ac748abb5e0b169d800c2a625a5
---
M Makefile.am
M configure.ac
M contrib/Makefile.am
A contrib/systemd/Makefile.am
A contrib/systemd/osmo-pcap-client.service
A contrib/systemd/osmo-pcap-server.service
M debian/osmo-pcap-client.install
M debian/osmo-pcap-server.install
M debian/rules
9 files changed, 56 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/45/11545/1

diff --git a/Makefile.am b/Makefile.am
index 6caa009..61eb85d 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -5,6 +5,10 @@
 BUILT_SOURCES = $(top_srcdir)/.version
 EXTRA_DIST = git-version-gen .version

+DISTCHECK_CONFIGURE_FLAGS = \
+  --with-systemdsystemunitdir=$$dc_install_base/$(systemdsystemunitdir)
+
+
 @RELMAKE@

 $(top_srcdir)/.version:
diff --git a/configure.ac b/configure.ac
index b5468ee..a0f786f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -52,6 +52,21 @@
CPPFLAGS="$CPPFLAGS $WERROR_FLAGS"
 fi

+# https://www.freedesktop.org/software/systemd/man/daemon.html
+AC_ARG_WITH([systemdsystemunitdir],
+ [AS_HELP_STRING([--with-systemdsystemunitdir=DIR], [Directory for systemd 
service files])],,
+ [with_systemdsystemunitdir=auto])
+AS_IF([test "x$with_systemdsystemunitdir" = "xyes" -o 
"x$with_systemdsystemunitdir" = "xauto"], [
+ def_systemdsystemunitdir=$($PKG_CONFIG --variable=systemdsystemunitdir 
systemd)
+ AS_IF([test "x$def_systemdsystemunitdir" = "x"],
+   [AS_IF([test "x$with_systemdsystemunitdir" = "xyes"],
+[AC_MSG_ERROR([systemd support requested but pkg-config unable to query 
systemd package])])
+with_systemdsystemunitdir=no],
+   [with_systemdsystemunitdir="$def_systemdsystemunitdir"])])
+AS_IF([test "x$with_systemdsystemunitdir" != "xno"],
+  [AC_SUBST([systemdsystemunitdir], [$with_systemdsystemunitdir])])
+AM_CONDITIONAL([HAVE_SYSTEMD], [test "x$with_systemdsystemunitdir" != "xno"])
+
 AC_ARG_ENABLE([external_tests],
AC_HELP_STRING([--enable-external-tests],
[Include the VTY tests in make check 
[default=no]]),
@@ -122,5 +137,6 @@
 include/osmo-pcap/Makefile
 src/Makefile
 contrib/Makefile
+contrib/systemd/Makefile
 tests/Makefile
 Makefile)
diff --git a/contrib/Makefile.am b/contrib/Makefile.am
index 3585924..7bd8c23 100644
--- a/contrib/Makefile.am
+++ b/contrib/Makefile.am
@@ -1,2 +1,3 @@
+SUBDIRS = systemd
 dist_pkgdata_DATA = osmo_pcap_clean_old
 EXTRA_DIST = osmo-pcap-server.cfg osmo-pcap-client.cfg
diff --git a/contrib/systemd/Makefile.am b/contrib/systemd/Makefile.am
new file mode 100644
index 000..49a2625
--- /dev/null
+++ b/contrib/systemd/Makefile.am
@@ -0,0 +1,8 @@
+if HAVE_SYSTEMD
+SYSTEMD_SERVICES = \
+  osmo-pcap-client.service \
+  osmo-pcap-server.service
+
+EXTRA_DIST = $(SYSTEMD_SERVICES)
+systemdsystemunit_DATA = $(SYSTEMD_SERVICES)
+endif
diff --git a/contrib/systemd/osmo-pcap-client.service 
b/contrib/systemd/osmo-pcap-client.service
new file mode 100644
index 000..fd0de75
--- /dev/null
+++ b/contrib/systemd/osmo-pcap-client.service
@@ -0,0 +1,12 @@
+[Unit]
+Description=PCAP Client for the PCAP aggregation
+
+[Service]
+Type=simple
+Restart=always
+ExecStart=/usr/bin/osmo-pcap-client -c /etc/osmocom/osmo-pcap-client.cfg
+RestartSec=2
+
+[Install]
+WantedBy=multi-user.target
+
diff --git a/contrib/systemd/osmo-pcap-server.service 
b/contrib/systemd/osmo-pcap-server.service
new file mode 100644
index 000..3094fc4
--- /dev/null
+++ b/contrib/systemd/osmo-pcap-server.service
@@ -0,0 +1,12 @@
+[Unit]
+Description=PCAP Server for the PCAP aggregation
+
+[Service]
+Type=simple
+Restart=always
+ExecStart=/usr/bin/osmo-pcap-server -c /etc/osmocom/osmo-pcap-server.cfg
+RestartSec=2
+
+[Install]
+WantedBy=multi-user.target
+
diff --git a/debian/osmo-pcap-client.install b/debian/osmo-pcap-client.install
index f149b14..ac7c65c 100644
--- a/debian/osmo-pcap-client.install
+++ b/debian/osmo-pcap-client.install
@@ -1 +1,2 @@
+lib/systemd/system/osmo-pcap-client.service
 usr/bin/osmo-pcap-client
diff --git a/debian/osmo-pcap-server.install b/debian/osmo-pcap-server.install
index ad58c8e..6ba698e 100644
--- a/debian/osmo-pcap-server.install
+++ b/debian/osmo-pcap-server.install
@@ -1 +1,2 @@
+lib/systemd/system/osmo-pcap-server.service
 usr/bin/osmo-pcap-server
diff --git a/debian/rules b/debian/rules
index 6862888..a9a8b30 100755
--- a/debian/rules
+++ b/debian/rules
@@ -16,6 +16,7 @@

 override_dh_auto_configure:
dh_auto_configure -- \
+   --with-systemdsystemunitdir=/lib/systemd/system \
--with-pcap-config=/bin/false \
PCAP_CFLAGS=$(PCAP_CFLAGS) \
PCAP_LIBS=$(PCAP_LIBS)

--
To view, visit 

Change in osmo-mgw[master]: add DLCX command statistics to osmo-mgw

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11521 )

Change subject: add DLCX command statistics to osmo-mgw
..


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/11521/1/src/libosmo-mgcp/mgcp_protocol.c
File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/#/c/11521/1/src/libosmo-mgcp/mgcp_protocol.c@1347
PS1, Line 1347: 
rate_ctr_inc(_ctrs->ctr[MGCP_DLCX_FAIL_REJECTED_BY_POLICY]);
> I'd prefer consistency over making exceptions. […]
Well, deferring in this case is more a success than a failure, that's what I'm 
trying to tell you.


https://gerrit.osmocom.org/#/c/11521/1/src/libosmo-mgcp/mgcp_protocol.c@1573
PS1, Line 1573: OSMO_ASSERT(trunk->mgcp_dlcx_ctr_group);
> If it were up to me, all allocation failures in osmocom projects would be 
> handled like regular error […]
That's first notice I get regarding we use OSMO_ASSERT during allocations, I 
would say we usually don't.



--
To view, visit https://gerrit.osmocom.org/11521
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0dde2faf02fd68a69f986973d39b1bea367039b
Gerrit-Change-Number: 11521
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 31 Oct 2018 12:17:15 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-mgw[master]: add aggregated rtp connection stats to osmo-mgw

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11519 )

Change subject: add aggregated rtp connection stats to osmo-mgw
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11519/2/include/osmocom/mgcp/mgcp_conn.h
File include/osmocom/mgcp/mgcp_conn.h:

https://gerrit.osmocom.org/#/c/11519/2/include/osmocom/mgcp/mgcp_conn.h@64
PS2, Line 64:   [RTP_OCTETS_TX_CTR] = {"all_rtp:octets_tx", "Total outbound rtp 
octets."},
You ar still sneaking this octets_rx/octets_tx change without at least 
describing it in the commit log. Best would be to have it on a separate patch.



--
To view, visit https://gerrit.osmocom.org/11519
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80d36181600901ae2e0f321dc02b5d54ddc94139
Gerrit-Change-Number: 11519
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 31 Oct 2018 12:13:56 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-mgw[master]: add aggregated rtp connection stats to osmo-mgw

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11519 )

Change subject: add aggregated rtp connection stats to osmo-mgw
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11519/1/src/libosmo-mgcp/mgcp_protocol.c
File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/#/c/11519/1/src/libosmo-mgcp/mgcp_protocol.c@108
PS1, Line 108: static const struct rate_ctr_desc all_rtp_conn_rate_ctr_desc[] = 
{
> I think moving both of these definitions to a shared header file is the best 
> approach. […]
Ok, I didn't pay attention to the fact that strings are different, I thought 
only the last RTP_NUM_CONNECTIONS field was added.



--
To view, visit https://gerrit.osmocom.org/11519
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80d36181600901ae2e0f321dc02b5d54ddc94139
Gerrit-Change-Number: 11519
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 31 Oct 2018 12:10:25 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-pcap[master]: test

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11543


Change subject: test
..

test

Change-Id: Iaab1f6d2d563df7ec3a1f56add2e883b4f697da6
---
M README.md
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/43/11543/1

diff --git a/README.md b/README.md
index b2a26cf..a147b82 100644
--- a/README.md
+++ b/README.md
@@ -49,3 +49,4 @@
 ## Author and License

 osmo-pcap has been created by Holger Hans Peter Freyther (hol...@freyther.de) 
and is licensed as AGPLv3+. The author appreciates failure or success reports 
of using the software.
+test

--
To view, visit https://gerrit.osmocom.org/11543
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaab1f6d2d563df7ec3a1f56add2e883b4f697da6
Gerrit-Change-Number: 11543
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-mgw[master]: add DLCX command statistics to osmo-mgw

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/11521 )

Change subject: add DLCX command statistics to osmo-mgw
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11521/1/src/libosmo-mgcp/mgcp_protocol.c
File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/#/c/11521/1/src/libosmo-mgcp/mgcp_protocol.c@1347
PS1, Line 1347: }
> I'd say that's not a failure, but an app decision to handle it its own way, 
> so better remove FAIL fr […]
I'd prefer consistency over making exceptions.
I think it is fine to treat this and the case below like any other non-success 
cases.



--
To view, visit https://gerrit.osmocom.org/11521
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0dde2faf02fd68a69f986973d39b1bea367039b
Gerrit-Change-Number: 11521
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 31 Oct 2018 12:06:26 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-mgw[master]: add DLCX command statistics to osmo-mgw

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/11521 )

Change subject: add DLCX command statistics to osmo-mgw
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11521/1/src/libosmo-mgcp/mgcp_protocol.c
File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/#/c/11521/1/src/libosmo-mgcp/mgcp_protocol.c@1573
PS1, Line 1573:  *  (called once at startup by main function) */
> It doesn't hurt either. […]
If it were up to me, all allocation failures in osmocom projects would be 
handled like regular errors, i.e. propagated back to callers.
But our code was written with a different style.

Back when I first asked about this, I remember Harald specifically telling me 
that osmocom projects check allocations with OSMO_ASSERT(),
so that's what I've been doing.

It's fine if you guys change your minds, but consistency will be appreciated 
nevertheless :)



--
To view, visit https://gerrit.osmocom.org/11521
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0dde2faf02fd68a69f986973d39b1bea367039b
Gerrit-Change-Number: 11521
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 31 Oct 2018 12:02:08 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-pcap[master]: test NOT FOR MERGE

[Neels Hofmeyr]

Neels Hofmeyr has abandoned this change. ( https://gerrit.osmocom.org/11542 )

Change subject: test NOT FOR MERGE
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/11542
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I07108657f0d37ba14e85cf30df28be6f3fac9fa5
Gerrit-Change-Number: 11542
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-pcap[master]: test NOT FOR MERGE

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/11542


Change subject: test NOT FOR MERGE
..

test NOT FOR MERGE

Change-Id: I07108657f0d37ba14e85cf30df28be6f3fac9fa5
---
M README.md
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/42/11542/1

diff --git a/README.md b/README.md
index b2a26cf..1ec4dae 100644
--- a/README.md
+++ b/README.md
@@ -1,3 +1,4 @@
+test
 # osmo-pcap distributed network capture

 osmo-pcap has been created to collect network traces at different nodes

--
To view, visit https://gerrit.osmocom.org/11542
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I07108657f0d37ba14e85cf30df28be6f3fac9fa5
Gerrit-Change-Number: 11542
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 

Change in osmo-mgw[master]: add DLCX command statistics to osmo-mgw

[Stefan Sperling]

Hello Pau Espin Pedrol, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11521

to look at the new patch set (#2).

Change subject: add DLCX command statistics to osmo-mgw
..

add DLCX command statistics to osmo-mgw

Add a counter group for DLCX commands. The group contains counters for
successful connection processing as well as various error conditions.
This provides a quick overview of DLCX failures on each trunk throughout
the lifetime of the osmo-mgw process.

The counters are displayed by 'show mgcp stats' and 'show rate-counters'

Change-Id: Ie0dde2faf02fd68a69f986973d39b1bea367039b
Depends: I80d36181600901ae2e0f321dc02b5d54ddc94139I
Related: OS#2660
---
M include/osmocom/mgcp/mgcp.h
M src/libosmo-mgcp/mgcp_protocol.c
M src/libosmo-mgcp/mgcp_vty.c
3 files changed, 66 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/21/11521/2
--
To view, visit https://gerrit.osmocom.org/11521
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie0dde2faf02fd68a69f986973d39b1bea367039b
Gerrit-Change-Number: 11521
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Harald Welte 

Change in osmo-mgw[master]: add aggregated rtp connection stats to osmo-mgw

[Stefan Sperling]

Hello Pau Espin Pedrol, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11519

to look at the new patch set (#2).

Change subject: add aggregated rtp connection stats to osmo-mgw
..

add aggregated rtp connection stats to osmo-mgw

Add a counter group for aggregated RTP connection statistics.
This group contains RTP counters which aggregate values of the
ephemeral RTP counters maintained per connection (mgcp_conn).

This provides a global overview of RTP processing for each
trunk throughout the lifetime of the osmo-mgw process.

The counters are displayed by 'show mgcp stats' and 'show rate-counters'.

Change-Id: I80d36181600901ae2e0f321dc02b5d54ddc94139
Related: OS#2660
---
M include/osmocom/mgcp/mgcp.h
M include/osmocom/mgcp/mgcp_conn.h
M src/libosmo-mgcp/mgcp_conn.c
M src/libosmo-mgcp/mgcp_protocol.c
M src/libosmo-mgcp/mgcp_vty.c
5 files changed, 80 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/19/11519/2
--
To view, visit https://gerrit.osmocom.org/11519
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I80d36181600901ae2e0f321dc02b5d54ddc94139
Gerrit-Change-Number: 11519
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 

Change in osmo-mgw[master]: add aggregated rtp connection stats to osmo-mgw

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/11519 )

Change subject: add aggregated rtp connection stats to osmo-mgw
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11519/1/src/libosmo-mgcp/mgcp_protocol.c
File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/#/c/11519/1/src/libosmo-mgcp/mgcp_protocol.c@108
PS1, Line 108: static const struct rate_ctr_desc all_rtp_conn_rate_ctr_desc[] = 
{
> Let's better use a macro instead of manually keeping them in sync. That's 
> going to break eventually. […]
I think moving both of these definitions to a shared header file is the best 
approach.
If we keep these two definitions close to each other, the chances of them 
getting out of sync are insignificant.
See patch set 2.

Using a macro seems like overkill to me. Apart from the index values which 
derive from the enum, all the string fields contain different values.
And dynamic allocation of rate counter group definitions is discouraged; the 
rate counter documentation states that definitions are "usually const".



--
To view, visit https://gerrit.osmocom.org/11519
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80d36181600901ae2e0f321dc02b5d54ddc94139
Gerrit-Change-Number: 11519
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 31 Oct 2018 11:43:51 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-iuh[master]: add a VTY command which shows a specific HNB

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/11506 )

Change subject: add a VTY command which shows a specific HNB
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11506/1/src/hnbgw_vty.c
File src/hnbgw_vty.c:

https://gerrit.osmocom.org/#/c/11506/1/src/hnbgw_vty.c@234
PS1, Line 234:  hnb = hnb_context_by_identity_info(_hnb_gw, identity_info);
> I suggest to add a hnb_context_by_identity_info() function, similar to 
> hnb_context_by_id() which we  […]
Agreed. See patch set 2.



--
To view, visit https://gerrit.osmocom.org/11506
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab12aa4ab090b72c472358b84daf6919b30747f6
Gerrit-Change-Number: 11506
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 31 Oct 2018 11:20:15 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-iuh[master]: add a VTY command which shows a specific HNB

[Stefan Sperling]

Hello lynxis lazus, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11506

to look at the new patch set (#2).

Change subject: add a VTY command which shows a specific HNB
..

add a VTY command which shows a specific HNB

Add the 'show hnb NAME' VTY command which displays just
one specific HNB, addressed by its identity string.
This augments the functionality provided by 'show hnb all'.

Change-Id: Iab12aa4ab090b72c472358b84daf6919b30747f6
Related: OS#2774
---
M include/osmocom/iuh/hnbgw.h
M src/hnbgw.c
M src/hnbgw_vty.c
3 files changed, 37 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/06/11506/2
--
To view, visit https://gerrit.osmocom.org/11506
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iab12aa4ab090b72c472358b84daf6919b30747f6
Gerrit-Change-Number: 11506
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: Harald Welte 

Change in osmo-bsc[master]: ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely copy IP

[osmith]

osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11538 )

Change subject: ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely 
copy IP
..

ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely copy IP

Fixes: coverity scan CID#189459
Change-Id: Ib9c5e374b9c5c8f79eecf95c439a25b0f438e4e5
---
M src/osmo-bsc/bts_ipaccess_nanobts.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c 
b/src/osmo-bsc/bts_ipaccess_nanobts.c
index 40cabb8..1fffd89 100644
--- a/src/osmo-bsc/bts_ipaccess_nanobts.c
+++ b/src/osmo-bsc/bts_ipaccess_nanobts.c
@@ -32,6 +32,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -494,7 +495,7 @@
return;
entry->site_id = site_id;
entry->bts_id = bts_id;
-   strncpy(entry->ip, ip, sizeof(entry->ip));
+   osmo_strlcpy(entry->ip, ip, sizeof(entry->ip));
}

/* Add to beginning with current timestamp */

--
To view, visit https://gerrit.osmocom.org/11538
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9c5e374b9c5c8f79eecf95c439a25b0f438e4e5
Gerrit-Change-Number: 11538
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: osmith 

Change in osmo-bsc[master]: ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely copy IP

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11538 )

Change subject: ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely 
copy IP
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11538
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9c5e374b9c5c8f79eecf95c439a25b0f438e4e5
Gerrit-Change-Number: 11538
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 31 Oct 2018 09:42:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely copy IP

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11538 )

Change subject: ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely 
copy IP
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11538
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9c5e374b9c5c8f79eecf95c439a25b0f438e4e5
Gerrit-Change-Number: 11538
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 31 Oct 2018 09:37:05 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely copy IP

[osmith]

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11538


Change subject: ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely 
copy IP
..

ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely copy IP

Fixes: coverity scan CID#189459
Change-Id: Ib9c5e374b9c5c8f79eecf95c439a25b0f438e4e5
---
M src/osmo-bsc/bts_ipaccess_nanobts.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/38/11538/1

diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c 
b/src/osmo-bsc/bts_ipaccess_nanobts.c
index 40cabb8..1fffd89 100644
--- a/src/osmo-bsc/bts_ipaccess_nanobts.c
+++ b/src/osmo-bsc/bts_ipaccess_nanobts.c
@@ -32,6 +32,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -494,7 +495,7 @@
return;
entry->site_id = site_id;
entry->bts_id = bts_id;
-   strncpy(entry->ip, ip, sizeof(entry->ip));
+   osmo_strlcpy(entry->ip, ip, sizeof(entry->ip));
}

/* Add to beginning with current timestamp */

--
To view, visit https://gerrit.osmocom.org/11538
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9c5e374b9c5c8f79eecf95c439a25b0f438e4e5
Gerrit-Change-Number: 11538
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 

Change in osmo-gsm-tester[master]: Introduce iperf3 testing infrastructure

[Pau Espin Pedrol]

Hello Max, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11476

to look at the new patch set (#3).

Change subject: Introduce iperf3 testing infrastructure
..

Introduce iperf3 testing infrastructure

Change-Id: I6ff6bef14feb535d98ca41b9788700d699e1ef1e
---
A src/osmo_gsm_tester/iperf3.py
M src/osmo_gsm_tester/suite.py
A suites/gprs/iperf3.py
M suites/gprs/suite.conf
4 files changed, 189 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/76/11476/3
--
To view, visit https://gerrit.osmocom.org/11476
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6ff6bef14feb535d98ca41b9788700d699e1ef1e
Gerrit-Change-Number: 11476
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 

Change in osmo-gsm-tester[master]: utils: Introduce show_usb_device.py

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11460 )

Change subject: utils: Introduce show_usb_device.py
..

utils: Introduce show_usb_device.py

This is a small script written by Alexander Couzens that is useful to
list modems and its properties in a quick and easy way in
osmo-gsm-tester setup.

Change-Id: Iec049e2d56d61ecd50b65b64d95d69641fa0f8be
---
A utils/show_usb_device.py
1 file changed, 97 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/utils/show_usb_device.py b/utils/show_usb_device.py
new file mode 100755
index 000..9136234
--- /dev/null
+++ b/utils/show_usb_device.py
@@ -0,0 +1,97 @@
+#!/usr/bin/env python3
+# Alexander Couzens 
+# MIT
+
+# show usb device with their net and serial devices
+
+import os
+import usb.core
+import usb.util
+from pprint import pprint
+
+def get_path_ids(bus, port_numbers):
+port_numbers = [str(port) for port in port_numbers]
+ports = '.'.join(port_numbers)
+return '{}-{}'.format(bus, ports)
+
+def get_usb_dir(bus, port_numbers):
+return '/sys/bus/usb/devices/' + get_path_ids(bus, port_numbers) + '/'
+
+def get_usbmisc_from_usb(bus, port_numbers):
+usbmisc_ifaces = []
+path = get_usb_dir(bus, port_numbers)
+path_ids = get_path_ids(bus, port_numbers)
+
+usb_interfaces = [f for f in os.listdir(path) if f.startswith(path_ids)]
+for usb_iface in usb_interfaces:
+listdir = [f for f in os.listdir(path + usb_iface) if f == ('usbmisc')]
+if listdir:
+# found a net iface
+usbmisc_ifaces += os.listdir(path + usb_iface + '/usbmisc/')
+return usbmisc_ifaces
+
+def get_net_from_usb(bus, port_numbers):
+net_ifaces = []
+path = get_usb_dir(bus, port_numbers)
+path_ids = get_path_ids(bus, port_numbers)
+
+usb_interfaces = [f for f in os.listdir(path) if f.startswith(path_ids)]
+for usb_iface in usb_interfaces:
+listdir = [f for f in os.listdir(path + usb_iface) if f == ('net')]
+if listdir:
+# found a net iface
+net_ifaces += os.listdir(path + usb_iface + '/net/')
+return net_ifaces
+
+def get_serial_from_usb(bus, port_numbers):
+serial_ifaces = []
+path = get_usb_dir(bus, port_numbers)
+path_ids = get_path_ids(bus, port_numbers)
+
+usb_interfaces = [f for f in os.listdir(path) if f.startswith(path_ids)]
+for usb_iface in usb_interfaces:
+serial_ifaces += [f for f in os.listdir(path + usb_iface) if 
f.startswith('tty')]
+return serial_ifaces
+
+def get_product(bus, port_numbers):
+usb_dir = get_usb_dir(bus, port_numbers)
+try:
+product = open(os.path.join(usb_dir, 'product')).read().strip()
+except OSError as exp:
+product = "Unknown"
+return product
+
+def get_manuf(bus, port_numbers):
+usb_dir = get_usb_dir(bus, port_numbers)
+try:
+manuf = open(os.path.join(usb_dir, 'manufacturer')).read().strip()
+except OSError:
+manuf = "Unknown"
+return manuf
+
+def get_name(bus, port_numbers):
+manuf = get_manuf(bus, port_numbers)
+product = get_product(bus, port_numbers)
+return "%s %s" % (manuf, product)
+
+if __name__ == '__main__':
+USB_DEVS = [dev for dev in usb.core.find(find_all=True)]
+RESULT = {}
+for device in USB_DEVS:
+result = {}
+if not device.port_numbers:
+continue
+
+# retrieve manuf + product from /sys because non-root user can not ask 
the usb device
+result['name'] = get_name(device.bus, device.port_numbers)
+result['path'] = get_usb_dir(device.bus, device.port_numbers)
+result['net'] = get_net_from_usb(device.bus, device.port_numbers)
+result['cdc'] = get_usbmisc_from_usb(device.bus, device.port_numbers)
+result['serial'] = get_serial_from_usb(device.bus, device.port_numbers)
+
+# only show device which have serial or net devices
+if result['net'] or result['serial']:
+RESULT[device] = result
+
+pprint(RESULT)
+

--
To view, visit https://gerrit.osmocom.org/11460
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec049e2d56d61ecd50b65b64d95d69641fa0f8be
Gerrit-Change-Number: 11460
Gerrit-PatchSet: 4
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 

Change in osmo-gsm-tester[master]: utils: Introduce modem-netns-setup.py

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11461 )

Change subject: utils: Introduce modem-netns-setup.py
..

utils: Introduce modem-netns-setup.py

Used to quickly set modem net interfaces into their own net namespace
(named after modem USB ID path).

The idea is that since osmo-gsm-tester ofono modem.py knowns the USB
path from a modem (path yml attr), it can infer the netns from it and
run a ping process inside it.

Related: OS#2308
Change-Id: Iadb2df2974e132044fba1f1bc2db8b559912e4e1
---
A utils/modem-netns-setup.py
1 file changed, 87 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/utils/modem-netns-setup.py b/utils/modem-netns-setup.py
new file mode 100755
index 000..e0645d1
--- /dev/null
+++ b/utils/modem-netns-setup.py
@@ -0,0 +1,87 @@
+#!/usr/bin/env python3
+# Pau Espin Pedrol 
+# MIT
+
+# manage netns for ofono modems
+
+import os
+import sys
+import subprocess
+import usb.core
+import usb.util
+from pprint import pprint
+
+def get_path_ids(bus, port_numbers):
+port_numbers = [str(port) for port in port_numbers]
+ports = '.'.join(port_numbers)
+return '{}-{}'.format(bus, ports)
+
+def get_usb_dir(bus, port_numbers):
+return '/sys/bus/usb/devices/' + get_path_ids(bus, port_numbers) + '/'
+
+def get_net_from_usb(bus, port_numbers):
+net_ifaces = []
+path = get_usb_dir(bus, port_numbers)
+path_ids = get_path_ids(bus, port_numbers)
+
+usb_interfaces = [f for f in os.listdir(path) if f.startswith(path_ids)]
+for usb_iface in usb_interfaces:
+listdir = [f for f in os.listdir(path + usb_iface) if f == ('net')]
+if listdir:
+# found a net iface
+net_ifaces += os.listdir(path + usb_iface + '/net/')
+return net_ifaces
+
+def move_modem_to_netns(usb_path_id, net_li):
+
+if len(net_li) == 0:
+print("%s: Device has no net ifaces, skipping" %(usb_path_id))
+return
+
+if not os.path.exists("/var/run/netns/%s" % usb_path_id):
+print("%s: Creating netns" % (usb_path_id))
+subprocess.check_call(["ip", "netns", "add", usb_path_id])
+else:
+print("%s: netns already exists" % (usb_path_id))
+
+for netif in net_li:
+print("%s: Moving iface %s to netns" % (usb_path_id, netif))
+subprocess.check_call(["ip", "link", "set", netif, "netns", 
usb_path_id])
+# iface Must be set up AFTER pdp ctx is activated, otherwise we 
get no DHCP response.
+#print("%s: Setting up iface %s" % (usb_path_id, netif))
+#subprocess.check_call(["ip", "netns", "exec", usb_path_id, "ip", 
"link", "set", "dev", netif, "up"])
+#subprocess.check_call(["ip", "netns", "exec", usb_path_id, 
"udhcpc", "-i", netif])
+
+def delete_modem_netns(usb_path_id):
+if os.path.exists("/var/run/netns/%s" % usb_path_id):
+print("%s: Deleting netns" % (usb_path_id))
+subprocess.check_call(["ip", "netns", "delete", usb_path_id])
+else:
+print("%s: netns doesn't exist" % (usb_path_id))
+
+def print_help():
+print("Usage: %s start|stop" % sys.argv[0])
+exit(1)
+
+
+if __name__ == '__main__':
+
+if len(sys.argv) != 2:
+print_help()
+
+USB_DEVS = [dev for dev in usb.core.find(find_all=True)]
+RESULT = {}
+for device in USB_DEVS:
+result = {}
+if not device.port_numbers:
+continue
+
+usb_path_id = get_path_ids(device.bus, device.port_numbers)
+net_li = get_net_from_usb(device.bus, device.port_numbers)
+
+if sys.argv[1] == "start":
+move_modem_to_netns(usb_path_id, net_li)
+elif sys.argv[1] == "stop":
+delete_modem_netns(usb_path_id)
+else:
+print_help()

--
To view, visit https://gerrit.osmocom.org/11461
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iadb2df2974e132044fba1f1bc2db8b559912e4e1
Gerrit-Change-Number: 11461
Gerrit-PatchSet: 4
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-gsm-tester[master]: utils: Add osmo-gsm-tester_setcap_net_*.sh scripts

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11473 )

Change subject: utils: Add osmo-gsm-tester_setcap_net_*.sh scripts
..

utils: Add osmo-gsm-tester_setcap_net_*.sh scripts

This scripts were already being used by osmo-gsm-tester for a while, but
were not avaialable in this repository. Let's put them here to easy find
them and have all this kind of helper scripts together with code using
it.

Change-Id: Ib88a1b7818155fc608cc6ff763300fbd0e03a07a
---
A utils/osmo-gsm-tester_setcap_net_admin.sh
A utils/osmo-gsm-tester_setcap_net_raw.sh
2 files changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/utils/osmo-gsm-tester_setcap_net_admin.sh 
b/utils/osmo-gsm-tester_setcap_net_admin.sh
new file mode 100755
index 000..60e527a
--- /dev/null
+++ b/utils/osmo-gsm-tester_setcap_net_admin.sh
@@ -0,0 +1,2 @@
+#!/bin/sh
+/sbin/setcap cap_net_admin+ep "$1"
diff --git a/utils/osmo-gsm-tester_setcap_net_raw.sh 
b/utils/osmo-gsm-tester_setcap_net_raw.sh
new file mode 100755
index 000..1f3a727
--- /dev/null
+++ b/utils/osmo-gsm-tester_setcap_net_raw.sh
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+/sbin/setcap cap_net_raw+ep "$1"

--
To view, visit https://gerrit.osmocom.org/11473
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib88a1b7818155fc608cc6ff763300fbd0e03a07a
Gerrit-Change-Number: 11473
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-dev[master]: deps: osmo-sgsn depends on osmo-hlr's liboso-gsup-client

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11537


Change subject: deps: osmo-sgsn depends on osmo-hlr's liboso-gsup-client
..

deps: osmo-sgsn depends on osmo-hlr's liboso-gsup-client

Change-Id: Ie47ca98740ca438e04d6ea76421e0f58d9e5715a
---
M 3G+2G.deps
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/37/11537/1

diff --git a/3G+2G.deps b/3G+2G.deps
index 5a17146..adc2aec 100644
--- a/3G+2G.deps
+++ b/3G+2G.deps
@@ -11,5 +11,5 @@
 osmo-mgw   libosmo-netif
 osmo-msc   osmo-iuh osmo-mgw libsmpp34
 osmo-bsc   libosmo-sccp osmo-mgw
-osmo-sgsn  osmo-iuh osmo-ggsn
+osmo-sgsn  osmo-iuh osmo-ggsn osmo-hlr
 osmo-sip-connector libosmocore

--
To view, visit https://gerrit.osmocom.org/11537
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie47ca98740ca438e04d6ea76421e0f58d9e5715a
Gerrit-Change-Number: 11537
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in pysim[master]: pySim/transport: introduce Calypso based reader interface

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11480 )

Change subject: pySim/transport: introduce Calypso based reader interface
..


Patch Set 3:

assigning to tnt as pySim is his creation.


--
To view, visit https://gerrit.osmocom.org/11480
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec8101140581bf9e2cf7cf3a0b54bdf1875fc51b
Gerrit-Change-Number: 11480
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Assignee: tnt 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: tnt 
Gerrit-Comment-Date: Wed, 31 Oct 2018 08:23:47 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in pysim[master]: pySim/transport: introduce Calypso based reader interface

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11480 )

Change subject: pySim/transport: introduce Calypso based reader interface
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11480
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec8101140581bf9e2cf7cf3a0b54bdf1875fc51b
Gerrit-Change-Number: 11480
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Assignee: tnt 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: tnt 
Gerrit-Comment-Date: Wed, 31 Oct 2018 08:22:57 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in pysim[master]: pySim-*.py: add command line option for Calypso reader

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11482 )

Change subject: pySim-*.py: add command line option for Calypso reader
..


Patch Set 4: Code-Review+2

slightly related; maybe it makes sense to generalize some of the command line 
option parsing and share it between the two programs, rather than having 
copy+paste?


--
To view, visit https://gerrit.osmocom.org/11482
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia895ced62d29e06ae8af05cd95c9d181fb53b9df
Gerrit-Change-Number: 11482
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 31 Oct 2018 08:22:34 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: 3G+2G.deps: add osmo-trx

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11389 )

Change subject: 3G+2G.deps: add osmo-trx
..


Patch Set 2: Code-Review+1

> I don't seem to have +2 in this repo.

not even I do here, because it's more or less a "private project" (of course 
it's public, but it's something Neels created without clear mandate to improve 
his workflow and shared it with a wider audience) by neels which intrinsically 
he as the original author has the ultimate say.


--
To view, visit https://gerrit.osmocom.org/11389
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ebf2732694cee0600b602b82c660cf6278958d
Gerrit-Change-Number: 11389
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 31 Oct 2018 08:21:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-sccp[master]: vty: SCCP timers: add optional units

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11130 )

Change subject: vty: SCCP timers: add optional units
..


Patch Set 2: Code-Review-1

We don't need sub-second resolution timers here.  The way how timers/timeouts 
are treated in other parts of the code is that the unit is stated in the help 
text for the timer, so pressing "?" while entering will give you a hint in what 
kind of unit to enter it.

I think it's absolutely acceptable for timers that are in the few-seconds to 
few-minutes cases (like here for SCCP) to expect the user to be able to compute 
something like 180 seconds or 240 seconds in their head to 3 or 4 minutes.

So unless Neels has a really strong feeling about this, I would rather say no.  
We generally should have one way of specifying a given parameter, not N number 
of different ways.  Particularly not, if this is for one given sub-system only, 
and not a generalized feature available to every piece of code using the VTY.  
And having a generalized feature would require a much higher abstraction level 
of the VTY.


--
To view, visit https://gerrit.osmocom.org/11130
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I020d5dab19bc67e8444ed548db15b2a4d8871a9c
Gerrit-Change-Number: 11130
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 31 Oct 2018 08:19:41 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-mgw[master]: add DLCX command statistics to osmo-mgw

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11521 )

Change subject: add DLCX command statistics to osmo-mgw
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11521/1/src/libosmo-mgcp/mgcp_protocol.c
File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/#/c/11521/1/src/libosmo-mgcp/mgcp_protocol.c@1573
PS1, Line 1573: OSMO_ASSERT(trunk->mgcp_dlcx_ctr_group);
> I think we can drop this kind of check, unless rate_ctr_group_alloc does a 
> lot more than just clalin […]
It doesn't hurt either.  We don't use OSMO_ASSERT() on our allocations, do we?



--
To view, visit https://gerrit.osmocom.org/11521
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0dde2faf02fd68a69f986973d39b1bea367039b
Gerrit-Change-Number: 11521
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 31 Oct 2018 08:15:27 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-gsm-tester[master]: contrib: build-osmo-sgsn: Depend on osmo-hlr build

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11530 )

Change subject: contrib: build-osmo-sgsn: Depend on osmo-hlr build
..

contrib: build-osmo-sgsn: Depend on osmo-hlr build

Since osmo-sgsn f4b2c4ca42cc530c38c9ac6f275e4d7da9315fa2, it depends on
libosmo-gsup-client available in osmo-hlr.

Change-Id: I6aa997ff2092f9ddf2ac475fd094803be9063980
---
M contrib/jenkins-build-osmo-sgsn.sh
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/contrib/jenkins-build-osmo-sgsn.sh 
b/contrib/jenkins-build-osmo-sgsn.sh
index ffa787c..f296f8b 100755
--- a/contrib/jenkins-build-osmo-sgsn.sh
+++ b/contrib/jenkins-build-osmo-sgsn.sh
@@ -9,6 +9,7 @@
 build_repo libosmo-netif ${SANITIZE_FLAGS} --disable-doxygen
 build_repo libosmo-sccp ${SANITIZE_FLAGS}
 build_repo osmo-ggsn ${SANITIZE_FLAGS}
+build_repo osmo-hlr ${SANITIZE_FLAGS}
 build_repo libasn1c ${SANITIZE_FLAGS}
 build_repo osmo-iuh ${SANITIZE_FLAGS}
 build_repo osmo-sgsn ${SANITIZE_FLAGS} --enable-iu

--
To view, visit https://gerrit.osmocom.org/11530
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6aa997ff2092f9ddf2ac475fd094803be9063980
Gerrit-Change-Number: 11530
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-gsm-manuals[master]: author info: add "former" to Holger's job title

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11533 )

Change subject: author info: add "former" to Holger's job title
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11533
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0556a3f8dafc051f20a3854fc9006edf4ec1a0d3
Gerrit-Change-Number: 11533
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 31 Oct 2018 08:13:11 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-manuals[master]: bsc: document handover

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11532 )

Change subject: bsc: document handover
..


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/11532/2/OsmoBSC/chapters/handover.adoc
File OsmoBSC/chapters/handover.adoc:

https://gerrit.osmocom.org/#/c/11532/2/OsmoBSC/chapters/handover.adoc@12
PS2, Line 12: - move to another MSC (inter-MSC);
strictly speaking, there's also inter-PLMN hand-over, but AFAIK it's only a 
normal inter-MSC HO with a fancy name



-- 
To view, visit https://gerrit.osmocom.org/11532
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7afb3f66c98abda07fc8acc76e00c46091fe55e2
Gerrit-Change-Number: 11532
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 31 Oct 2018 08:12:29 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-gsm-manuals[master]: bsc: handover: clarify default of all-cells-are-neighbors

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11534 )

Change subject: bsc: handover: clarify default of all-cells-are-neighbors
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11534
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61f877c7a60419132bdd27c1b4e64150c0520751
Gerrit-Change-Number: 11534
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 31 Oct 2018 08:09:45 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-manuals[master]: bsc: handover: mention the need to resend SI for telnet neighbor cfg

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11535 )

Change subject: bsc: handover: mention the need to resend SI for telnet 
neighbor cfg
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11535
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I305ef558b75697015e2532aa7c135f7995662e0d
Gerrit-Change-Number: 11535
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 31 Oct 2018 08:08:58 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: layer23/ccch_scan: unwrap dump_bcch() as gsm48_rx_bcch()

[Vadim Yanitskiy]

Vadim Yanitskiy has abandoned this change. ( https://gerrit.osmocom.org/11479 )

Change subject: layer23/ccch_scan: unwrap dump_bcch() as gsm48_rx_bcch()
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/11479
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I382fbdb60513324164cd1147c36f3367bb6fb22c
Gerrit-Change-Number: 11479
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmocom-bb[master]: (WIP) misc/cbch_sacn: indicate CBCH cbits to L1/PHY

[Vadim Yanitskiy]

Vadim Yanitskiy has abandoned this change. ( https://gerrit.osmocom.org/11478 )

Change subject: (WIP) misc/cbch_sacn: indicate CBCH cbits to L1/PHY
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/11478
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: If19f2b2ed645c0f6f5baf7ed853b41011603f1a0
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)