Jenkins build is back to normal : master-osmo-sgsn » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #8824

[jenkins]

See 

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #8823

[jenkins]

See 


--
[...truncated 858.23 KB...]
^
../../include/osmocom/ranap/RANAP_LA-LIST.h:27:2: note: in expansion of macro 
'A_SEQUENCE_OF'
  A_SEQUENCE_OF(struct MemberA {
  ^
../../include/osmocom/ranap/RANAP_LA-LIST.h:27:23: warning: its scope is only 
this definition or declaration, which is probably not what you want
  A_SEQUENCE_OF(struct MemberA {
   ^
/build/deps/install/stow/libasn1c/include/asn1c/asn_SET_OF.h:17:16: note: in 
definition of macro 'A_SET_OF'
   void (*free)(type *);   \
^
../../include/osmocom/ranap/RANAP_LA-LIST.h:27:2: note: in expansion of macro 
'A_SEQUENCE_OF'
  A_SEQUENCE_OF(struct MemberA {
  ^
../../include/osmocom/ranap/RANAP_PLMNs-in-shared-network.h:27:23: warning: 
'struct MemberM' declared inside parameter list
  A_SEQUENCE_OF(struct MemberM {
   ^
/build/deps/install/stow/libasn1c/include/asn1c/asn_SET_OF.h:17:16: note: in 
definition of macro 'A_SET_OF'
   void (*free)(type *);   \
^
../../include/osmocom/ranap/RANAP_PLMNs-in-shared-network.h:27:2: note: in 
expansion of macro 'A_SEQUENCE_OF'
  A_SEQUENCE_OF(struct MemberM {
  ^
  CC   RANAP_SDU-Parameters.lo
  CC   RANAP_SDU-ParameterItem.lo
  CC   RANAP_SNA-Access-Information.lo
  CC   RANAP_SNAC.lo
  CC   RANAP_Service-Handover.lo
  CC   RANAP_Source-ToTarget-TransparentContainer.lo
  CC   RANAP_SourceeNodeB-ToTargeteNodeB-TransparentContainer.lo
  CC   RANAP_SourceCellID.lo
In file included from 
/build/deps/install/stow/libasn1c/include/asn1c/asn_SEQUENCE_OF.h:8:0,
 from ../../include/osmocom/ranap/RANAP_AuthorisedPLMNs.h:14,
 from 
../../include/osmocom/ranap/RANAP_SNA-Access-Information.h:14,
 from RANAP_SNA-Access-Information.c:7:
../../include/osmocom/ranap/RANAP_AuthorisedPLMNs.h:27:23: warning: 'struct 
MemberC' declared inside parameter list
  A_SEQUENCE_OF(struct MemberC {
   ^
/build/deps/install/stow/libasn1c/include/asn1c/asn_SET_OF.h:17:16: note: in 
definition of macro 'A_SET_OF'
   void (*free)(type *);   \
^
../../include/osmocom/ranap/RANAP_AuthorisedPLMNs.h:27:2: note: in expansion of 
macro 'A_SEQUENCE_OF'
  A_SEQUENCE_OF(struct MemberC {
  ^
../../include/osmocom/ranap/RANAP_AuthorisedPLMNs.h:27:23: warning: its scope 
is only this definition or declaration, which is probably not what you want
  A_SEQUENCE_OF(struct MemberC {
   ^
/build/deps/install/stow/libasn1c/include/asn1c/asn_SET_OF.h:17:16: note: in 
definition of macro 'A_SET_OF'
   void (*free)(type *);   \
^
../../include/osmocom/ranap/RANAP_AuthorisedPLMNs.h:27:2: note: in expansion of 
macro 'A_SEQUENCE_OF'
  A_SEQUENCE_OF(struct MemberC {
  ^
  CC   RANAP_SourceBSS-ToTargetBSS-TransparentContainer.lo
  CC   RANAP_SourceID.lo
  CC   RANAP_SourceRNC-ID.lo
  CC   RANAP_SourceRNC-ToTargetRNC-TransparentContainer.lo
  CC   RANAP_IRAT-Measurement-Configuration.lo
  CC   RANAP_IRATmeasurementParameters.lo
  CC   RANAP_RSRQ-Type.lo
  CC   RANAP_RSRQ-Extension.lo
  CC   RANAP_EUTRANFrequencies.lo
  CC   RANAP_MeasBand.lo
In file included from 
/build/deps/install/stow/libasn1c/include/asn1c/asn_SEQUENCE_OF.h:8:0,
 from ../../include/osmocom/ranap/RANAP_EUTRANFrequencies.h:14,
 from 
../../include/osmocom/ranap/RANAP_IRATmeasurementParameters.h:15,
 from 
../../include/osmocom/ranap/RANAP_IRAT-Measurement-Configuration.h:15,
 from RANAP_IRAT-Measurement-Configuration.c:7:
../../include/osmocom/ranap/RANAP_EUTRANFrequencies.h:27:23: warning: 'struct 
MemberJ' declared inside parameter list
  A_SEQUENCE_OF(struct MemberJ {
   ^
/build/deps/install/stow/libasn1c/include/asn1c/asn_SET_OF.h:17:16: note: in 
definition of macro 'A_SET_OF'
   void (*free)(type *);   \
^
../../include/osmocom/ranap/RANAP_EUTRANFrequencies.h:27:2: note: in expansion 
of macro 'A_SEQUENCE_OF'
  A_SEQUENCE_OF(struct MemberJ {
  ^
../../include/osmocom/ranap/RANAP_EUTRANFrequencies.h:27:23: warning: its scope 
is only this definition or declaration, which is probably not what you want
  A_SEQUENCE_OF(struct MemberJ {
   ^
/build/deps/install/stow/libasn1c/include/asn1c/asn_SET_OF.h:17:16: note: in 
definition of macro 'A_SET_OF'
   void (*free)(type *);   \
^
../../include/osmocom/ranap/RANAP_EUTRANFrequencies.h:27:2: note: in expansion 
of macro 'A_SEQUENCE_OF'
  A_SEQUENCE_OF(struct MemberJ {
  ^
In file included from 
/build/deps/install/stow/libasn1c/include/asn1c/asn_SEQUENCE_OF.h:8:0,
 from ../../include/osmocom/ranap/RANAP_EUTRANFrequencies.h:14,

Change in libosmocore[master]: Add multipatch capability to osmo-config-merge

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12897 )

Change subject: Add multipatch capability to osmo-config-merge
..


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/12897/3/utils/osmo-config-merge.c
File utils/osmo-config-merge.c:

https://gerrit.osmocom.org/#/c/12897/3/utils/osmo-config-merge.c@267
PS3, Line 267: return 3;
> Yes, but ASAN won't be happy. This is why we do talloc_free(ctx) in all other 
> cases.
Agree with Vadim, I already had a similar comment in another commit. Please 
let's free stuff as soon as not needed anymore, instead of assuming talloc will 
release it at some point in the future.



--
To view, visit https://gerrit.osmocom.org/12897
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I212cbdc3bf6f251c1a3175737ac74242fb004c6d
Gerrit-Change-Number: 12897
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 15 Feb 2019 20:02:26 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ci[master]: Fix copy and paste in the script.

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12921 )

Change subject: Fix copy and paste in the script.
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12921
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51d01a8799f09ce7d813a0ef8353a4233d5c8bb5
Gerrit-Change-Number: 12921
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 15 Feb 2019 20:00:15 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-pcu[master]: Don't install pcuif_proto.h header

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12907 )

Change subject: Don't install pcuif_proto.h header
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12907
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a87395d4ab7212fe2fc055dae0a737e10d20c69
Gerrit-Change-Number: 12907
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: Neels Hofmeyr 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 15 Feb 2019 19:57:56 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: Add multipatch capability to osmo-config-merge

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12897 )

Change subject: Add multipatch capability to osmo-config-merge
..


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/12897/3/utils/osmo-config-merge.c
File utils/osmo-config-merge.c:

https://gerrit.osmocom.org/#/c/12897/3/utils/osmo-config-merge.c@267
PS3, Line 267: return 3;
> That's return from the main() so all the memory will be cleared anyway.
Yes, but ASAN won't be happy. This is why we do talloc_free(ctx) in all other 
cases.



--
To view, visit https://gerrit.osmocom.org/12897
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I212cbdc3bf6f251c1a3175737ac74242fb004c6d
Gerrit-Change-Number: 12897
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Fri, 15 Feb 2019 18:15:20 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ci[master]: Fix copy and paste in the script.

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12921 )

Change subject: Fix copy and paste in the script.
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12921
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51d01a8799f09ce7d813a0ef8353a4233d5c8bb5
Gerrit-Change-Number: 12921
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Max 
Gerrit-Comment-Date: Fri, 15 Feb 2019 17:52:29 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: scheduler_trx: use stored fn for pdtch data indications

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12922 )

Change subject: scheduler_trx: use stored fn for pdtch data indications
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12922
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c01987be78203acfa689c6decb2c806f8fff3d6
Gerrit-Change-Number: 12922
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 15 Feb 2019 17:52:10 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: Add multipatch capability to osmo-config-merge

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12897 )

Change subject: Add multipatch capability to osmo-config-merge
..


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/12897/3/utils/osmo-config-merge.c
File utils/osmo-config-merge.c:

https://gerrit.osmocom.org/#/c/12897/3/utils/osmo-config-merge.c@267
PS3, Line 267: return 3;
> Why don't you talloc_free(ctx) here?
That's return from the main() so all the memory will be cleared anyway.



--
To view, visit https://gerrit.osmocom.org/12897
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I212cbdc3bf6f251c1a3175737ac74242fb004c6d
Gerrit-Change-Number: 12897
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Fri, 15 Feb 2019 17:18:15 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-bts[master]: scheduler_trx: use stored fn for pdtch data indications

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12922 )

Change subject: scheduler_trx: use stored fn for pdtch data indications
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12922
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c01987be78203acfa689c6decb2c806f8fff3d6
Gerrit-Change-Number: 12922
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 15 Feb 2019 16:59:10 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: scheduler_trx: use stored block fn instead of calculating it.

[dexter]

dexter has abandoned this change. ( https://gerrit.osmocom.org/12779 )

Change subject: scheduler_trx: use stored block fn instead of calculating it.
..


Abandoned

Unfortunately this approach does not work out, however, I submitted a patch for 
pdtch as vadim suggested under #12922
--
To view, visit https://gerrit.osmocom.org/12779
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia27254bbf6e36426f7890ece6154dcd395673f63
Gerrit-Change-Number: 12779
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: tnt 
Gerrit-CC: Harald Welte 
Gerrit-CC: Max 

Change in osmo-bts[master]: scheduler_trx: use stored fn for pdtch data indications

[dexter]

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/12922


Change subject: scheduler_trx: use stored fn for pdtch data indications
..

scheduler_trx: use stored fn for pdtch data indications

When the ph-data indications for the PDTCH are passed up to l1sap,
then a forumla is used to calculate the frame number of the beginning of
the block that is just passed up. This is not necessary since the start
frame number of the block is stored in *first_fn when the block arrives.
We should use this frame number instead. (For the measurement indication
it is already done this way).

Change-Id: I6c01987be78203acfa689c6decb2c806f8fff3d6
Related: OS#2977
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/22/12922/1

diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c
index b395479..32bdb98 100644
--- a/src/osmo-bts-trx/scheduler_trx.c
+++ b/src/osmo-bts-trx/scheduler_trx.c
@@ -974,7 +974,7 @@
return 0;
}
ber10k = compute_ber10k(n_bits_total, n_errors);
-   return _sched_compose_ph_data_ind(l1t, tn, (fn + GSM_HYPERFRAME - 3) % 
GSM_HYPERFRAME, chan,
+   return _sched_compose_ph_data_ind(l1t, tn, *first_fn, chan,
l2, rc, *rssi_sum / *rssi_num, *toa256_sum / *toa_num, 0,
  ber10k, PRES_INFO_BOTH);
 }

--
To view, visit https://gerrit.osmocom.org/12922
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c01987be78203acfa689c6decb2c806f8fff3d6
Gerrit-Change-Number: 12922
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 

Change in osmo-ci[master]: Fix copy and paste in the script.

[Holger Freyther]

Holger Freyther has uploaded this change for review. ( 
https://gerrit.osmocom.org/12921


Change subject: Fix copy and paste in the script.
..

Fix copy and paste in the script.

Change-Id: I51d01a8799f09ce7d813a0ef8353a4233d5c8bb5
---
M jobs/osmo-gsm-tester_ttcn3.sh
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/21/12921/1

diff --git a/jobs/osmo-gsm-tester_ttcn3.sh b/jobs/osmo-gsm-tester_ttcn3.sh
index f2b974f..a4d5e16 100644
--- a/jobs/osmo-gsm-tester_ttcn3.sh
+++ b/jobs/osmo-gsm-tester_ttcn3.sh
@@ -1,7 +1,7 @@
 #!/bin/sh
 set -e -x

-# On our hardware, we actually use the example configuration as-is.
+# On our hardware, we actually use the ttcn3 configuration as-is.
 export OSMO_GSM_TESTER_CONF="$PWD/osmo-gsm-tester/ttcn3"

 # debug: provoke a failure

--
To view, visit https://gerrit.osmocom.org/12921
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51d01a8799f09ce7d813a0ef8353a4233d5c8bb5
Gerrit-Change-Number: 12921
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 

Change in osmo-pcu[master]: Don't install pcuif_proto.h header

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12907 )

Change subject: Don't install pcuif_proto.h header
..


Patch Set 1:

> I think it's a good idea to install it since (maybe not osmo-bts now) any 
> application that wants to talk this interface

Which application do you have in mind exactly? It's a very specific niche 
protocol. In more than 10 years it's been used by osmo-bts and osmo-bsc only 
and I really doubt this is going to be any different in next 10 years.

> Are osmo-bts and osmo-pcu both installing this file at exactly the same 
> location?

OsmoBTS does not install it (local copy is used). OsmoBSC does not install it 
(local copy is used). OsmoPCU uses local copy as well but for legacy reasons it 
also installs it globally. This patch proposes to change that and make OsmoPCU 
behave like OsmoBTS and OsmoBSC.

In general I think it only make sense to have single copy of this file as long 
as all related functions are in the same repo: serialization, deserialization, 
tests, data structures etc. But that would be much more intrusive change.


--
To view, visit https://gerrit.osmocom.org/12907
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a87395d4ab7212fe2fc055dae0a737e10d20c69
Gerrit-Change-Number: 12907
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 15 Feb 2019 15:15:02 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-pcu[master]: Don't install pcuif_proto.h header

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12907 )

Change subject: Don't install pcuif_proto.h header
..


Patch Set 1:

> Why not to move it to libosmocore?

In general I agree (provided we move encoder/decoder, tests etc as well) but 
that would require exactly the same patch as this one anyway :)


--
To view, visit https://gerrit.osmocom.org/12907
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a87395d4ab7212fe2fc055dae0a737e10d20c69
Gerrit-Change-Number: 12907
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 15 Feb 2019 15:17:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #402

[jenkins]

See 


--
[...truncated 3.76 KB...]
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking depende

Build failed in Jenkins: master-osmo-trx » --with-sse,1,a3=default,a4=default,osmocom-master-debian9 #884

[jenkins]

See 


--
[...truncated 123.30 KB...]
Searching INPUT for files to process...
Reading and parsing tag files
Parsing files
Building group list...
Building directory list...
Building namespace list...
Building file list...
Building class list...
Associating documentation with classes...
Computing nesting relations for classes...
Building example list...
Searching for enumerations...
Searching for documented typedefs...
Searching for members imported via using declarations...
Searching for included using directives...
Searching for documented variables...
Building interface member list...
Building member list...
Searching for friends...
Searching for documented defines...
Computing class inheritance relations...
Computing class usage relations...
Flushing cached template relations that have become invalid...
Computing class relations...
Add enum values to enums...
Searching for member function documentation...
Creating members for template instances...
Building page list...
Search for main page...
Computing page relations...
Determining the scope of groups...
Sorting lists...
Freeing entry tree
Determining which enums are documented
Computing member relations...
Building full member lists recursively...
Adding members to member groups.
Computing member references...
Inheriting documentation...
Generating disk names...
Adding source references...
Adding xrefitems...
Sorting member lists...
Computing dependencies between directories...
Generating citations page...
Counting data structures...
Resolving user defined references...
Finding anchors and sections in the documentation...
Transferring function references...
Combining using relations...
Adding members to index pages...
Generating style sheet...
Generating search indices...
Generating example documentation...
Generating file sources...
Generating file documentation...
Generating page documentation...
Generating group documentation...
Generating class documentation...
Generating namespace index...
Generating graph info page...
Generating directory documentation...
Generating index page...
Generating page index...
Generating module index...
Generating namespace index...
Generating namespace member index...
Generating annotated compound index...
Generating alphabetical compound index...
Generating hierarchical class index...
Generating graphical class hierarchy...
Generating member index...
Generating file index...
Generating file member index...
Generating example index...
finalizing index lists...
writing tag file...
Running dot...
Running dot for graph 1/1
lookup cache used 0/65536 hits=0 misses=0
finished...
make[5]: Entering directory 
'
make[5]: Nothing to be done for 'install-exec-am'.
/bin/mkdir -p 

 /bin/mkdir -p 
'
/usr/bin/install -c -m 644 usrp_guide.html 

cp -r html 

 /usr/bin/install -c -m 644 ../README 
'
make[5]: Leaving directory 
'
make[4]: Leaving directory 
'
make[3]: Leaving directory 
'
make[2]: Leaving directory 
'
Making install in firmware
make[2]: Entering directory 
'

Change in osmo-bsc[master]: assignment_fsm: fix channel allocator preferences

[dexter]

Hello Max, Neels Hofmeyr, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12625

to look at the new patch set (#10).

Change subject: assignment_fsm: fix channel allocator preferences
..

assignment_fsm: fix channel allocator preferences

When the MSC allocates a channel through the ASSIGNMENT REQUEST, it may
ask for a TCH/H and a TCH/F at the same time and tell which of the two
types it prefers.

The process of channel allocation currently selects, based on the BTS,
MSC and MS capabilites exactly one apropriate codec/rate (e.g. TCH/H)
and then tries to allocate it. If that allocation fails, there is no way
to try the second choice and the assignment fails.

For example: The MSC asks for TCH/F and TCH/H, prefering TCH/F, then the
channel allocator will try TCH/F and if it fails (all TCH/F are
currently in use), then TCH/H is never tried.

Since the BSC currently only trys the first best codec/rate that is
supported it also ignores the preference.

Lets fix those problems by including the preference information and both
possible codec/rate settings into the channel allocation decision.

Change-Id: I5239e05c1cfbcb8af28f43373a58fa6c2d216c51
Related: OS#3503
---
M include/osmocom/bsc/codec_pref.h
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/assignment_fsm.c
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/codec_pref.c
M src/osmo-bsc/handover_fsm.c
M src/osmo-bsc/osmo_bsc_bssap.c
M tests/codec_pref/codec_pref_test.c
8 files changed, 323 insertions(+), 117 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/25/12625/10
--
To view, visit https://gerrit.osmocom.org/12625
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5239e05c1cfbcb8af28f43373a58fa6c2d216c51
Gerrit-Change-Number: 12625
Gerrit-PatchSet: 10
Gerrit-Owner: dexter 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-CC: tnt 

Change in osmo-asf4-dfu[master]: minox: use RAM address define instead of hardcoded value

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12920 )

Change subject: minox: use RAM address define instead of hardcoded value
..

minox: use RAM address define instead of hardcoded value

Change-Id: I81a42637194cbf0b5152fe38c691522021ab7582
---
M usb_dfu_main.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/usb_dfu_main.c b/usb_dfu_main.c
index f431d29..19fe437 100644
--- a/usb_dfu_main.c
+++ b/usb_dfu_main.c
@@ -73,7 +73,7 @@
 * if the SP is not in this range (e.g. flash has been erased) there is 
no valid application
 * the second entry in the vector table is the reset address, 
corresponding to the application start
 */
-   return (0x2000 == ((*application_start_address) & 0xFFF8));
+   return (HSRAM_ADDR == ((*application_start_address) & 0xFFF8));
 }

 /** Start the application

--
To view, visit https://gerrit.osmocom.org/12920
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I81a42637194cbf0b5152fe38c691522021ab7582
Gerrit-Change-Number: 12920
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-asf4-dfu[master]: minox: use RAM address define instead of hardcoded value

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12920 )

Change subject: minox: use RAM address define instead of hardcoded value
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12920
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81a42637194cbf0b5152fe38c691522021ab7582
Gerrit-Change-Number: 12920
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 15 Feb 2019 10:27:54 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-asf4-dfu[master]: fix DFU magic address and linker script

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12918 )

Change subject: fix DFU magic address and linker script
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12918
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69ad101593e903b74084f179cfc97fdfa5a3
Gerrit-Change-Number: 12918
Gerrit-PatchSet: 2
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Kévin Redon 
Gerrit-Comment-Date: Fri, 15 Feb 2019 10:28:05 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-asf4-dfu[master]: fix DFU magic address and linker script

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12918 )

Change subject: fix DFU magic address and linker script
..

fix DFU magic address and linker script

using the address specified in the linker script leads to a large
output binary (as large as the address specified.
instead the address is now specified in the source file.

Change-Id: I69ad101593e903b74084f179cfc97fdfa5a3
---
M gcc/gcc/same54p20a_flash.ld
M usb_dfu_main.c
2 files changed, 3 insertions(+), 9 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/gcc/gcc/same54p20a_flash.ld b/gcc/gcc/same54p20a_flash.ld
index 32ded77..6aa3fb1 100644
--- a/gcc/gcc/same54p20a_flash.ld
+++ b/gcc/gcc/same54p20a_flash.ld
@@ -48,12 +48,6 @@
 /* Section Definitions */
 SECTIONS
 {
-/* Location of the DFU magic. The application must set the magic value 
"DFU!" (e.g. 0x44465521) at this address to force the DFU bootloader to start 
(e.g. to perform a DFU detach) */
-.dfu_magic 0x2000 :
-{
-KEEP(*(.dfu_magic)) ;
-}
-
 .text :
 {
 . = ALIGN(4);
diff --git a/usb_dfu_main.c b/usb_dfu_main.c
index 7fd54d3..f431d29 100644
--- a/usb_dfu_main.c
+++ b/usb_dfu_main.c
@@ -28,7 +28,7 @@
 static uint32_t* application_start_address;

 /** Location of the DFU magic value to force starting DFU */
-static uint32_t dfu_magic __attribute__ ((section (".dfu_magic"))) 
__attribute__ ((__used__));
+static volatile uint32_t* dfu_magic = (uint32_t*)HSRAM_ADDR; // magic value 
should be written at start of RAM

 /** Check if the bootloader is valid
  *  \return true if the bootloader is valid and can be run
@@ -51,8 +51,8 @@
  */
 static bool check_force_dfu(void)
 {
-   if (0x44465521 == dfu_magic) { // check for the magic value which can 
be set by the main application
-   dfu_magic = 0; // erase value so we don't stay in the DFU 
bootloader upon reset
+   if (0x44465521 == *dfu_magic) { // check for the magic value which can 
be set by the main application
+   *dfu_magic = 0; // erase value so we don't stay in the DFU 
bootloader upon reset
return true;
}
if (0 == gpio_get_pin_level(BUTTON_FORCE_DFU)) { // signal is low when 
button is pressed

--
To view, visit https://gerrit.osmocom.org/12918
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I69ad101593e903b74084f179cfc97fdfa5a3
Gerrit-Change-Number: 12918
Gerrit-PatchSet: 2
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Kévin Redon 

Build failed in Jenkins: master-osmo-trx » --with-sse,1,a3=default,a4=default,osmocom-master-debian9 #883

[jenkins]

See 


--
[...truncated 107.47 KB...]
Searching INPUT for files to process...
Reading and parsing tag files
Parsing files
Building group list...
Building directory list...
Building namespace list...
Building file list...
Building class list...
Associating documentation with classes...
Computing nesting relations for classes...
Building example list...
Searching for enumerations...
Searching for documented typedefs...
Searching for members imported via using declarations...
Searching for included using directives...
Searching for documented variables...
Building interface member list...
Building member list...
Searching for friends...
Searching for documented defines...
Computing class inheritance relations...
Computing class usage relations...
Flushing cached template relations that have become invalid...
Computing class relations...
Add enum values to enums...
Searching for member function documentation...
Creating members for template instances...
Building page list...
Search for main page...
Computing page relations...
Determining the scope of groups...
Sorting lists...
Freeing entry tree
Determining which enums are documented
Computing member relations...
Building full member lists recursively...
Adding members to member groups.
Computing member references...
Inheriting documentation...
Generating disk names...
Adding source references...
Adding xrefitems...
Sorting member lists...
Computing dependencies between directories...
Generating citations page...
Counting data structures...
Resolving user defined references...
Finding anchors and sections in the documentation...
Transferring function references...
Combining using relations...
Adding members to index pages...
Generating style sheet...
Generating search indices...
Generating example documentation...
Generating file sources...
Generating file documentation...
Generating page documentation...
Generating group documentation...
Generating class documentation...
Generating namespace index...
Generating graph info page...
Generating directory documentation...
Generating index page...
Generating page index...
Generating module index...
Generating namespace index...
Generating namespace member index...
Generating annotated compound index...
Generating alphabetical compound index...
Generating hierarchical class index...
Generating graphical class hierarchy...
Generating member index...
Generating file index...
Generating file member index...
Generating example index...
finalizing index lists...
writing tag file...
Running dot...
Running dot for graph 1/1
lookup cache used 0/65536 hits=0 misses=0
finished...
make[5]: Entering directory 
'
make[5]: Nothing to be done for 'install-exec-am'.
/bin/mkdir -p 

 /bin/mkdir -p 
'
/usr/bin/install -c -m 644 usrp_guide.html 

 /usr/bin/install -c -m 644 ../README 
'
cp -r html 

make[5]: Leaving directory 
'
make[4]: Leaving directory 
'
make[3]: Leaving directory 
'
make[2]: Leaving directory 
'
Making install in firmware
make[2]: Entering directory 
'

Change in osmo-asf4-dfu[master]: fix DFU magic address and linker script

[Kévin Redon]

Kévin Redon has posted comments on this change. ( 
https://gerrit.osmocom.org/12918 )

Change subject: fix DFU magic address and linker script
..


Patch Set 2:

> (1 comment)

fixed. the same define is also used in the next commit


--
To view, visit https://gerrit.osmocom.org/12918
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69ad101593e903b74084f179cfc97fdfa5a3
Gerrit-Change-Number: 12918
Gerrit-PatchSet: 2
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Kévin Redon 
Gerrit-Comment-Date: Fri, 15 Feb 2019 09:12:15 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-asf4-dfu[master]: fix DFU magic address and linker script

[Kévin Redon]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12918

to look at the new patch set (#2).

Change subject: fix DFU magic address and linker script
..

fix DFU magic address and linker script

using the address specified in the linker script leads to a large
output binary (as large as the address specified.
instead the address is now specified in the source file.

Change-Id: I69ad101593e903b74084f179cfc97fdfa5a3
---
M gcc/gcc/same54p20a_flash.ld
M usb_dfu_main.c
2 files changed, 3 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/18/12918/2
--
To view, visit https://gerrit.osmocom.org/12918
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69ad101593e903b74084f179cfc97fdfa5a3
Gerrit-Change-Number: 12918
Gerrit-PatchSet: 2
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-asf4-dfu[master]: minox: use RAM address define instead of hardcoded value

[Kévin Redon]

Kévin Redon has uploaded this change for review. ( 
https://gerrit.osmocom.org/12920


Change subject: minox: use RAM address define instead of hardcoded value
..

minox: use RAM address define instead of hardcoded value

Change-Id: I81a42637194cbf0b5152fe38c691522021ab7582
---
M usb_dfu_main.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/20/12920/1

diff --git a/usb_dfu_main.c b/usb_dfu_main.c
index f431d29..19fe437 100644
--- a/usb_dfu_main.c
+++ b/usb_dfu_main.c
@@ -73,7 +73,7 @@
 * if the SP is not in this range (e.g. flash has been erased) there is 
no valid application
 * the second entry in the vector table is the reset address, 
corresponding to the application start
 */
-   return (0x2000 == ((*application_start_address) & 0xFFF8));
+   return (HSRAM_ADDR == ((*application_start_address) & 0xFFF8));
 }

 /** Start the application

--
To view, visit https://gerrit.osmocom.org/12920
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I81a42637194cbf0b5152fe38c691522021ab7582
Gerrit-Change-Number: 12920
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon