Change in osmo-gsm-tester[master]: pyflakes: Remove assigned but unread variables

[Holger Freyther]

Holger Freyther has uploaded this change for review. ( 
https://gerrit.osmocom.org/13071


Change subject: pyflakes: Remove assigned but unread variables
..

pyflakes: Remove assigned but unread variables

Change-Id: Ie257ac051739ea6f846d1aac2c8f778638b5f8a6
---
M src/osmo_gsm_tester/modem.py
M src/osmo_gsm_tester/osmo_nitb.py
M src/osmo_gsm_tester/template.py
M src/osmo_gsm_tester/util.py
4 files changed, 8 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/71/13071/1

diff --git a/src/osmo_gsm_tester/modem.py b/src/osmo_gsm_tester/modem.py
index f9b827a..95ebb6b 100644
--- a/src/osmo_gsm_tester/modem.py
+++ b/src/osmo_gsm_tester/modem.py
@@ -125,7 +125,7 @@
 user_data = (result_handler, error_handler, user_data)

 # See 
https://lazka.github.io/pgi-docs/Gio-2.0/classes/DBusProxy.html#Gio.DBusProxy.call
-ret = instance._bus.con.call(
+instance._bus.con.call(
 instance._bus_name, instance._path,
 proxymethod._iface_name, proxymethod.__name__,
 GLib.Variant(proxymethod._sinargs, proxymethod_args),
@@ -596,14 +596,14 @@
 if self.is_attached():
 self.detach()
 connmgr = self.dbus.interface(I_CONNMGR)
-prop = connmgr.SetProperty('RoamingAllowed', Variant('b', 
allow_roaming))
-prop = connmgr.SetProperty('Powered', Variant('b', True))
+connmgr.SetProperty('RoamingAllowed', Variant('b', allow_roaming))
+connmgr.SetProperty('Powered', Variant('b', True))

 def detach(self):
 self.dbg('detach')
 connmgr = self.dbus.interface(I_CONNMGR)
-prop = connmgr.SetProperty('RoamingAllowed', Variant('b', False))
-prop = connmgr.SetProperty('Powered', Variant('b', False))
+connmgr.SetProperty('RoamingAllowed', Variant('b', False))
+connmgr.SetProperty('Powered', Variant('b', False))
 connmgr.DeactivateAll()
 connmgr.ResetContexts() # Requires Powered=false

@@ -734,7 +734,7 @@
 call_dbus_obj = systembus_get(call_id)
 props = call_dbus_obj.GetProperties()
 state = props.get('State')
-except Exception as e:
+except Exception:
 self.log('asking call state for non existent call')
 log.log_exn()
 state = 'disconnected'
diff --git a/src/osmo_gsm_tester/osmo_nitb.py b/src/osmo_gsm_tester/osmo_nitb.py
index 66ab2a6..e161ccb 100644
--- a/src/osmo_gsm_tester/osmo_nitb.py
+++ b/src/osmo_gsm_tester/osmo_nitb.py
@@ -176,8 +176,6 @@
 return osmo_ctrl.OsmoCtrl(self.nitb.addr(), OsmoNitbCtrl.PORT)

 def subscriber_add(self, imsi, msisdn, ki=None, algo=None):
-created = False
-
 if algo:
 value = '%s,%s,%s,%s' % (imsi,msisdn,algo,ki)
 else:
diff --git a/src/osmo_gsm_tester/template.py b/src/osmo_gsm_tester/template.py
index c890963..6ce7ebd 100644
--- a/src/osmo_gsm_tester/template.py
+++ b/src/osmo_gsm_tester/template.py
@@ -51,7 +51,6 @@
 template = _lookup.get_template(tmpl_name)
 _logger.dbg('rendering', tmpl_name)

-line_info_name = tmpl_name.replace('-', '_').replace('.', '_')
 return template.render(**dict2obj(values))

 # vim: expandtab tabstop=4 shiftwidth=4
diff --git a/src/osmo_gsm_tester/util.py b/src/osmo_gsm_tester/util.py
index 930c86a..e9a1f30 100644
--- a/src/osmo_gsm_tester/util.py
+++ b/src/osmo_gsm_tester/util.py
@@ -64,7 +64,7 @@
 for line in proc.stdout.readlines():
 if 'inet' in line and ' ' + ip + '/' in line:
 return line.split()[-1]
-except Exception as e:
+except Exception:
 pass
 return None

@@ -79,7 +79,7 @@
 if words[i] == 'src':
 return words[i+1]
 i += 1
-except Exception as e:
+except Exception:
 pass
 return None


--
To view, visit https://gerrit.osmocom.org/13071
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie257ac051739ea6f846d1aac2c8f778638b5f8a6
Gerrit-Change-Number: 13071
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 

Change in osmo-gsm-tester[master]: pyflakes: Remove occurrences of using undefined variables

[Holger Freyther]

Holger Freyther has uploaded this change for review. ( 
https://gerrit.osmocom.org/13072


Change subject: pyflakes: Remove occurrences of using undefined variables
..

pyflakes: Remove occurrences of using undefined variables

Mention the attribute right away and remove a method that looks
to have been broken (more vs. more_rules).

Change-Id: Iba18a96ff804780e66c69b459e112f9d42b7b2ff
---
M src/osmo_gsm_tester/bts_nanobts.py
M src/osmo_gsm_tester/resource.py
2 files changed, 1 insertion(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/72/13072/1

diff --git a/src/osmo_gsm_tester/bts_nanobts.py 
b/src/osmo_gsm_tester/bts_nanobts.py
index 5fe8bae..4cdb98e 100644
--- a/src/osmo_gsm_tester/bts_nanobts.py
+++ b/src/osmo_gsm_tester/bts_nanobts.py
@@ -92,7 +92,7 @@

 def start(self, keepalive=False):
 if self.conf.get('ipa_unit_id') is None:
-raise log.Error('No attribute %s provided in conf!' % attr)
+raise log.Error('No attribute ipa_unit_id provided in conf!')
 self.run_dir = 
util.Dir(self.suite_run.get_test_run_dir().new_dir(self.name()))
 self._configure()

diff --git a/src/osmo_gsm_tester/resource.py b/src/osmo_gsm_tester/resource.py
index 29f641e..98651ce 100644
--- a/src/osmo_gsm_tester/resource.py
+++ b/src/osmo_gsm_tester/resource.py
@@ -395,11 +395,6 @@
 raise RuntimeError('adding a list of resources to itself?')
 config.add(self, copy.deepcopy(more))

-def combine(self, more_rules):
-if more_rules is self:
-raise RuntimeError('combining a list of resource rules with 
itself?')
-config.combine(self, copy.deepcopy(more))
-
 def mark_reserved_by(self, origin_id):
 for key, item_list in self.items():
 for item in item_list:

--
To view, visit https://gerrit.osmocom.org/13072
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba18a96ff804780e66c69b459e112f9d42b7b2ff
Gerrit-Change-Number: 13072
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 

Change in osmo-gsm-tester[master]: pyflake: Remove imports of unused modules

[Holger Freyther]

Holger Freyther has uploaded this change for review. ( 
https://gerrit.osmocom.org/13070


Change subject: pyflake: Remove imports of unused modules
..

pyflake: Remove imports of unused modules

Change-Id: I7496030e5857078cd66a36a5e46c9a50217ce6e3
---
M src/osmo_gsm_tester/osmo_ggsn.py
M src/osmo_gsm_tester/osmo_hlr.py
M src/osmo_gsm_tester/osmo_mgcpgw.py
M src/osmo_gsm_tester/osmo_mgw.py
M src/osmo_gsm_tester/osmo_sgsn.py
M src/osmo_gsm_tester/pcap_recorder.py
M src/osmo_gsm_tester/resource.py
M src/osmo_gsm_tester/template.py
M src/osmo_gsm_tester/util.py
9 files changed, 7 insertions(+), 18 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/70/13070/1

diff --git a/src/osmo_gsm_tester/osmo_ggsn.py b/src/osmo_gsm_tester/osmo_ggsn.py
index 2fdc792..0ece596 100644
--- a/src/osmo_gsm_tester/osmo_ggsn.py
+++ b/src/osmo_gsm_tester/osmo_ggsn.py
@@ -20,7 +20,7 @@
 import os
 import pprint

-from . import log, util, config, template, process, osmo_ctrl, pcap_recorder
+from . import log, util, config, template, process, pcap_recorder

 class OsmoGgsn(log.Origin):

diff --git a/src/osmo_gsm_tester/osmo_hlr.py b/src/osmo_gsm_tester/osmo_hlr.py
index a4633e3..1c361dd 100644
--- a/src/osmo_gsm_tester/osmo_hlr.py
+++ b/src/osmo_gsm_tester/osmo_hlr.py
@@ -18,11 +18,10 @@
 # along with this program.  If not, see .

 import os
-import re
 import pprint
 import sqlite3

-from . import log, util, config, template, process, osmo_ctrl, pcap_recorder
+from . import log, util, config, template, process, pcap_recorder

 class OsmoHlr(log.Origin):
 run_dir = None
diff --git a/src/osmo_gsm_tester/osmo_mgcpgw.py 
b/src/osmo_gsm_tester/osmo_mgcpgw.py
index 668e4ce..20bb689 100644
--- a/src/osmo_gsm_tester/osmo_mgcpgw.py
+++ b/src/osmo_gsm_tester/osmo_mgcpgw.py
@@ -20,7 +20,7 @@
 import os
 import pprint

-from . import log, util, config, template, process, osmo_ctrl, pcap_recorder
+from . import log, util, config, template, process, pcap_recorder

 class OsmoMgcpgw(log.Origin):

diff --git a/src/osmo_gsm_tester/osmo_mgw.py b/src/osmo_gsm_tester/osmo_mgw.py
index 1d5596e..ca7bd51 100644
--- a/src/osmo_gsm_tester/osmo_mgw.py
+++ b/src/osmo_gsm_tester/osmo_mgw.py
@@ -20,7 +20,7 @@
 import os
 import pprint

-from . import log, util, config, template, process, osmo_ctrl, pcap_recorder
+from . import log, util, config, template, process, pcap_recorder

 class OsmoMgw(log.Origin):

diff --git a/src/osmo_gsm_tester/osmo_sgsn.py b/src/osmo_gsm_tester/osmo_sgsn.py
index 07cf059..9ffaaed 100644
--- a/src/osmo_gsm_tester/osmo_sgsn.py
+++ b/src/osmo_gsm_tester/osmo_sgsn.py
@@ -20,7 +20,7 @@
 import os
 import pprint

-from . import log, util, config, template, process, osmo_ctrl, pcap_recorder
+from . import log, util, config, template, process, pcap_recorder

 class OsmoSgsn(log.Origin):

diff --git a/src/osmo_gsm_tester/pcap_recorder.py 
b/src/osmo_gsm_tester/pcap_recorder.py
index 70833d0..e0f0098 100644
--- a/src/osmo_gsm_tester/pcap_recorder.py
+++ b/src/osmo_gsm_tester/pcap_recorder.py
@@ -18,11 +18,8 @@
 # along with this program.  If not, see .

 import os
-import random
-import re
-import socket

-from . import log, util, config, template, process, osmo_ctrl
+from . import log, process

 class PcapRecorder(log.Origin):

diff --git a/src/osmo_gsm_tester/resource.py b/src/osmo_gsm_tester/resource.py
index 4f48dc4..29f641e 100644
--- a/src/osmo_gsm_tester/resource.py
+++ b/src/osmo_gsm_tester/resource.py
@@ -18,7 +18,6 @@
 # along with this program.  If not, see .

 import os
-import time
 import copy
 import atexit
 import pprint
@@ -27,8 +26,6 @@
 from . import config
 from . import util
 from . import schema
-from . import modem
-from . import osmo_nitb
 from . import bts_sysmo, bts_osmotrx, bts_osmovirtual, bts_octphy, bts_nanobts

 from .util import is_dict, is_list
diff --git a/src/osmo_gsm_tester/template.py b/src/osmo_gsm_tester/template.py
index 0ddfc84..c890963 100644
--- a/src/osmo_gsm_tester/template.py
+++ b/src/osmo_gsm_tester/template.py
@@ -18,8 +18,7 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see .

-import os, sys
-from mako.template import Template
+import os
 from mako.lookup import TemplateLookup

 from . import log
diff --git a/src/osmo_gsm_tester/util.py b/src/osmo_gsm_tester/util.py
index 27c71cf..930c86a 100644
--- a/src/osmo_gsm_tester/util.py
+++ b/src/osmo_gsm_tester/util.py
@@ -27,9 +27,6 @@
 import atexit
 import threading
 import importlib.util
-import fcntl
-import tty
-import readline
 import subprocess

 # This mirrors enum osmo_auth_algo in libosmocore/include/osmocom/crypt/auth.h

--
To view, visit https://gerrit.osmocom.org/13070
To unsubscribe, or for help writing mail filters, visit 

Change in osmo-gsm-tester[master]: pyflakes: Rename local variable to not shadow import

[Holger Freyther]

Holger Freyther has uploaded this change for review. ( 
https://gerrit.osmocom.org/13073


Change subject: pyflakes: Rename local variable to not shadow import
..

pyflakes: Rename local variable to not shadow import

Change-Id: Ib70130dbbeeeb9813eaea707bf66f1db91088b92
---
M src/osmo_gsm_tester/report.py
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/73/13073/1

diff --git a/src/osmo_gsm_tester/report.py b/src/osmo_gsm_tester/report.py
index 224cc46..4919937 100644
--- a/src/osmo_gsm_tester/report.py
+++ b/src/osmo_gsm_tester/report.py
@@ -42,8 +42,8 @@
 testsuite.set('time', str(math.ceil(suite.duration)))
 testsuite.set('tests', str(len(suite.tests)))
 testsuite.set('failures', str(suite.count_test_results()[2]))
-for test in suite.tests:
-testcase = test_to_junit(test)
+for suite_test in suite.tests:
+testcase = test_to_junit(suite_test)
 testsuite.append(testcase)
 return testsuite


--
To view, visit https://gerrit.osmocom.org/13073
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib70130dbbeeeb9813eaea707bf66f1db91088b92
Gerrit-Change-Number: 13073
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 

Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l

Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  192s] NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
[  192s] LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xdf2421 CMD=UI DATA 
[  192s] Got LLC message, CRC: df2421 (computed df2421)
[  192s] LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
[  192s] Got LLC message, CRC: a5ba79 (computed a5ba79)
[  192s] ATTACH_REJ: Got TLLI afe2b700, IMSI 12131415161718, invalidate
[  192s] gbproxy_validate_tlli({current = afe2b700, assigned = , 
net_vld = 0, bss_vld = 0}, afe2b700)
[  192s] gbproxy_validate_tlli({current = afe2b700, assigned = , 
net_vld = 0, bss_vld = 0}, afe2b700)
[  192s] Unregistering TLLI afe2b700
[  192s] NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
[  192s] LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
[  192s] Got LLC message, CRC: a5ba79 (computed a5ba79)
[  192s] LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
[  192s] Got LLC message, CRC: 017a81 (computed 017a81)
[  192s] ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
[  192s] Adding TLLI afe2b700 to list
[  192s] NSEI=4096(BSS) IMSI acquisition in progress, storing message 
(ATTACH_REQ)
[  192s] NSEI=4096(BSS) IMSI is required but not available, initiating 
identification procedure (ATTACH_REQ)
[  192s] NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
[  192s] LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
[  192s] Got LLC message, CRC: 36f8b7 (computed 36f8b7)
[  192s] Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol 
discriminator GMM.
[  192s] LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
[  194s] Got L[  168.382713] SysRq : Power Off
[  194s] [  168.383969] reboot: Power down
[  194s] ### VM INTERACTION END ###
[  194s] 
[  194s] armbuild01 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Wed Feb 27 
03:08:37 UTC 2019.
[  194s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_9.0/armv7l

Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  164s]  
[  164s]  PROCESSING ALIVE_ACK from 0x05060708:32000
[  164s]  0b 
[  164s] @@ -7311,7 +7311,7 @@
[  164s]  MESSAGE to SGSN at 0x05060708:32000, msg length 1
[  164s]  0a 
[  164s]  
[  164s] -result (RESET_ACK) = 1
[  164s] +result (RESET_ACK) = 0
[  164s]  
[  164s]  PROCESSING ALIVE_ACK from 0x05060708:32000
[  164s]  0b 
[  164s] 2. testsuite.at:10: 2. gbproxy (testsuite.at:10): FAILED 
(testsuite.at:13)
[  164s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[  164s] make[1]: *** [override_dh_auto_test] Error 1
[  164s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  164s] debian/rules:45: recipe for target 'build' failed
[  164s] make: *** [build] Error 2
[  164s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  164s] 
[  164s] armbuild22 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Wed Feb 27 
02:35:48 UTC 2019.
[  164s] 
[  164s] ### VM INTERACTION START ###
[  167s] [  149.798655] SysRq : Power Off
[  167s] [  149.813083] reboot: Power down
[  168s] ### VM INTERACTION END ###
[  168s] 
[  168s] armbuild22 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Wed Feb 27 
02:35:52 UTC 2019.
[  168s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-ccid-firmware[master]: fix ASFv4 USB stack

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/13056 )

Change subject: fix ASFv4 USB stack
..

fix ASFv4 USB stack

this ASFv4 USB library change fixes USB transfer.
two transfer-size issues existed:
- on multi-packet transfer if the last packet was less than the
USB transfer packet size, the packet would be received but not
acknowledged
- during normal transfer the packet size of a previous packet set
the size of the current packet, ignoring the actual transfer size

Change-Id: I4209072ee808f0e246bcd5e86917dcf1d213c26b
---
M sysmoOCTSIM/hpl/usb/hpl_usb.c
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/sysmoOCTSIM/hpl/usb/hpl_usb.c b/sysmoOCTSIM/hpl/usb/hpl_usb.c
index b5efe6c..eec9728 100644
--- a/sysmoOCTSIM/hpl/usb/hpl_usb.c
+++ b/sysmoOCTSIM/hpl/usb/hpl_usb.c
@@ -1135,6 +1135,7 @@
/* Short packet. */
ept->flags.bits.need_zlp = 0;
ept->trans_count += last_trans;
+   _usbd_ep_set_out_trans(epn, 0, ept->size, 0);
} else {
/* Full packets. */
ept->trans_count += trans_size;
@@ -1154,9 +1155,6 @@
if (trans_next > ept->size) {
if (trans_next > USB_D_DEV_TRANS_MAX) {
trans_next = 
USB_D_DEV_TRANS_MAX;
-   } else {
-   /* Must expect multiple of ep 
size. */
-   trans_next -= trans_next & 
size_mask;
}
} else if (trans_next < ept->size) {
/* Last un-aligned packet should be 
cached. */

--
To view, visit https://gerrit.osmocom.org/13056
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4209072ee808f0e246bcd5e86917dcf1d213c26b
Gerrit-Change-Number: 13056
Gerrit-PatchSet: 2
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-msc[master]: libmsc/sgs_iface.c: fix SGS_STATE_NS11 counter reference

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/13016 )

Change subject: libmsc/sgs_iface.c: fix SGS_STATE_NS11 counter reference
..

libmsc/sgs_iface.c: fix SGS_STATE_NS11 counter reference

The SGS_STATE_TS11 is not for counters, it's for timers!

Change-Id: Ifbb1a37e644ae8bf8e7959f6f6cd6403ac1f2f1b
Fixes: CID#190872 Out-of-bounds read (OVERRUN)
---
M src/libmsc/sgs_iface.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Max: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/libmsc/sgs_iface.c b/src/libmsc/sgs_iface.c
index 1c2146a..4f262a5 100644
--- a/src/libmsc/sgs_iface.c
+++ b/src/libmsc/sgs_iface.c
@@ -1129,7 +1129,7 @@
mme->ns11_remaining--;
} else {
LOGMME(mme, LOGL_ERROR, "Ts11 expired more than %u 
(Ns11) times, giving up\n",
-  sgs->cfg.counter[SGS_STATE_TS11]);
+  sgs->cfg.counter[SGS_STATE_NS11]);
osmo_fsm_inst_state_chg(fi, SGS_VLRR_ST_NULL, 0, 0);
}
break;

--
To view, visit https://gerrit.osmocom.org/13016
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbb1a37e644ae8bf8e7959f6f6cd6403ac1f2f1b
Gerrit-Change-Number: 13016
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-msc[master]: libmsc/sgs_iface.c: fix SGS_STATE_NS11 counter reference

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/13016 )

Change subject: libmsc/sgs_iface.c: fix SGS_STATE_NS11 counter reference
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/13016
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbb1a37e644ae8bf8e7959f6f6cd6403ac1f2f1b
Gerrit-Change-Number: 13016
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 26 Feb 2019 23:16:42 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: libmsc/ran_conn.c: add missing 'break' to OSMO_RAT_EUTRAN_SGS

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/13015 )

Change subject: libmsc/ran_conn.c: add missing 'break' to OSMO_RAT_EUTRAN_SGS
..

libmsc/ran_conn.c: add missing 'break' to OSMO_RAT_EUTRAN_SGS

Change-Id: I18dfd08ea0857f2751164a295dd9de20a2024ac3
Fixes: CID#190874
---
M src/libmsc/ran_conn.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/ran_conn.c b/src/libmsc/ran_conn.c
index be6bde0..79709c6 100644
--- a/src/libmsc/ran_conn.c
+++ b/src/libmsc/ran_conn.c
@@ -683,6 +683,7 @@
break;
case OSMO_RAT_EUTRAN_SGS:
conn->log_subsys = DSGS;
+   break;
default:
conn->log_subsys = DMSC;
break;

--
To view, visit https://gerrit.osmocom.org/13015
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I18dfd08ea0857f2751164a295dd9de20a2024ac3
Gerrit-Change-Number: 13015
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-msc[master]: libmsc/ran_conn.c: add missing 'break' to OSMO_RAT_EUTRAN_SGS

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/13015 )

Change subject: libmsc/ran_conn.c: add missing 'break' to OSMO_RAT_EUTRAN_SGS
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/13015
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18dfd08ea0857f2751164a295dd9de20a2024ac3
Gerrit-Change-Number: 13015
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 26 Feb 2019 23:16:09 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-hlr[master]: hlr.c: move hlr_ctx to the top

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/13050 )

Change subject: hlr.c: move hlr_ctx to the top
..

hlr.c: move hlr_ctx to the top

Allow all functions to use hlr_ctx, so it can be used by the upcoming
read_cb_forward() function in [1]. That new function is placed next to
the existing read_cb() function, which is above the current hlr_ctx
declaration.

[1]: Change-Id: Ia4f345abc877baaf0a8f73b8988e6514d9589bf5

Related: OS#3793
Change-Id: I5edf0a233ff323a63e321a1ca47736b5b212d1bb
---
M src/hlr.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Max: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/hlr.c b/src/hlr.c
index c544310..f374ccc 100644
--- a/src/hlr.c
+++ b/src/hlr.c
@@ -47,6 +47,7 @@
 #include "hlr_ussd.h"

 struct hlr *g_hlr;
+static void *hlr_ctx = NULL;
 static int quit = 0;

 /* Trigger 'Insert Subscriber Data' messages to all connected GSUP clients.
@@ -608,8 +609,6 @@
}
 }

-static void *hlr_ctx = NULL;
-
 static void signal_hdlr(int signal)
 {
switch (signal) {

--
To view, visit https://gerrit.osmocom.org/13050
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5edf0a233ff323a63e321a1ca47736b5b212d1bb
Gerrit-Change-Number: 13050
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Daniel Willmann 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-hlr[master]: hlr.c: move hlr_ctx to the top

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/13050 )

Change subject: hlr.c: move hlr_ctx to the top
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/13050
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5edf0a233ff323a63e321a1ca47736b5b212d1bb
Gerrit-Change-Number: 13050
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Daniel Willmann 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 26 Feb 2019 23:10:59 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-pcu[master]: Use boolean for DL resegmentation parameter

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/13057 )

Change subject: Use boolean for DL resegmentation parameter
..


Patch Set 1:

there is no downlink arq type "true" or "false".  While I agree i fthere are 
only two discrete values you should use a type with only two options, but if 
those optionsare not something that can be "true" or "false", using bool is 
just as wrong as using int, isn't it?


--
To view, visit https://gerrit.osmocom.org/13057
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d4fe5fe12068a4532cb3b61d4eeb229a77c1476
Gerrit-Change-Number: 13057
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Daniel Willmann 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 26 Feb 2019 23:10:35 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ccid-firmware[master]: update ASFv4 library

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/13059 )

Change subject: update ASFv4 library
..


Patch Set 1:

why merge this? you can always simply do a "diff -w" when diffing ASF and our 
repository. Worked quite fine with the two updates I did.


--
To view, visit https://gerrit.osmocom.org/13059
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic08fd2494b63b611ac4b4e1f35c91bce9aa746c5
Gerrit-Change-Number: 13059
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Tue, 26 Feb 2019 23:08:00 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ccid-firmware[master]: minor: rename MUX_SSTAT to MUX_STAT

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/13058 )

Change subject: minor: rename MUX_SSTAT to MUX_STAT
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/13058
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eee17de31fdce92346641772fc0c63d4c37507a
Gerrit-Change-Number: 13058
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Tue, 26 Feb 2019 23:06:53 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-pcu[master]: EDGE tests: reduce code duplication

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/13051 )

Change subject: EDGE tests: reduce code duplication
..

EDGE tests: reduce code duplication

* move duplicated code into helper function
* use proper parameter types

Change-Id: I8a9528032629e5df629996da5cd8b808efede017
---
M tests/edge/EdgeTest.cpp
1 file changed, 15 insertions(+), 8 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/edge/EdgeTest.cpp b/tests/edge/EdgeTest.cpp
index 98ca206..6ce2334 100644
--- a/tests/edge/EdgeTest.cpp
+++ b/tests/edge/EdgeTest.cpp
@@ -105,11 +105,22 @@

 }

+static bool check_strong_monotonicity(const GprsCodingScheme *cs, uint8_t 
last_UL, uint8_t last_DL)
+{
+   if (cs->maxBytesUL() <= last_UL)
+   return false;
+
+   if (cs->maxBytesDL() <= last_DL)
+   return false;
+
+   return true;
+}
+
 static void test_coding_scheme()
 {
unsigned i;
-   unsigned last_size_UL;
-   unsigned last_size_DL;
+   uint8_t last_size_UL;
+   uint8_t last_size_DL;
GprsCodingScheme::Scheme gprs_schemes[] = {
GprsCodingScheme::CS1,
GprsCodingScheme::CS2,
@@ -152,9 +163,7 @@
OSMO_ASSERT(GprsCodingScheme::Scheme(current_cs) == 
gprs_schemes[i]);
OSMO_ASSERT(current_cs == GprsCodingScheme(gprs_schemes[i]));

-   /* Check strong monotonicity */
-   OSMO_ASSERT(current_cs.maxBytesUL() > last_size_UL);
-   OSMO_ASSERT(current_cs.maxBytesDL() > last_size_DL);
+   OSMO_ASSERT(check_strong_monotonicity(_cs, 
last_size_UL, last_size_DL));
last_size_UL = current_cs.maxBytesUL();
last_size_DL = current_cs.maxBytesDL();

@@ -179,9 +188,7 @@
OSMO_ASSERT(GprsCodingScheme::Scheme(current_cs) == 
egprs_schemes[i].s);
OSMO_ASSERT(current_cs == GprsCodingScheme(egprs_schemes[i].s));

-   /* Check strong monotonicity */
-   OSMO_ASSERT(current_cs.maxBytesUL() > last_size_UL);
-   OSMO_ASSERT(current_cs.maxBytesDL() > last_size_DL);
+   OSMO_ASSERT(check_strong_monotonicity(_cs, 
last_size_UL, last_size_DL));
last_size_UL = current_cs.maxBytesUL();
last_size_DL = current_cs.maxBytesDL();


--
To view, visit https://gerrit.osmocom.org/13051
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a9528032629e5df629996da5cd8b808efede017
Gerrit-Change-Number: 13051
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Daniel Willmann 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 

Change in osmo-pcu[master]: MCS: internalize 'family' parameter

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/13060 )

Change subject: MCS: internalize 'family' parameter
..

MCS: internalize 'family' parameter

There's no need to expose it in header file as it's only used internally
for consistency checks.

Change-Id: Ic705615cd2a8ca077efef9ea62a2a676f70b4aed
---
M src/gprs_coding_scheme.cpp
M src/gprs_coding_scheme.h
2 files changed, 24 insertions(+), 30 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/gprs_coding_scheme.cpp b/src/gprs_coding_scheme.cpp
index 3094ae6..bbac6e7 100644
--- a/src/gprs_coding_scheme.cpp
+++ b/src/gprs_coding_scheme.cpp
@@ -53,6 +53,13 @@
}
};

+enum Family {
+   FAMILY_INVALID,
+   FAMILY_A,
+   FAMILY_B,
+   FAMILY_C,
+};
+
 static struct {
struct {
uint8_t bytes;
@@ -63,38 +70,38 @@
uint8_t optional_padding_bits;
const char *name;
GprsCodingScheme::HeaderType data_hdr;
-   GprsCodingScheme::Family family;
+   enum Family family;
 } mcs_info[GprsCodingScheme::NUM_SCHEMES] = {
{{0, 0},   {0, 0},0,  0, "UNKNOWN",
-   GprsCodingScheme::HEADER_INVALID, 
GprsCodingScheme::FAMILY_INVALID},
+   GprsCodingScheme::HEADER_INVALID, FAMILY_INVALID},
{{23, 0},  {23, 0},  20,  0, "CS-1",
-   GprsCodingScheme::HEADER_GPRS_DATA, 
GprsCodingScheme::FAMILY_INVALID},
+   GprsCodingScheme::HEADER_GPRS_DATA, FAMILY_INVALID},
{{33, 7},  {33, 7},  30,  0, "CS-2",
-   GprsCodingScheme::HEADER_GPRS_DATA, 
GprsCodingScheme::FAMILY_INVALID},
+   GprsCodingScheme::HEADER_GPRS_DATA, FAMILY_INVALID},
{{39, 3},  {39, 3},  36,  0, "CS-3",
-   GprsCodingScheme::HEADER_GPRS_DATA, 
GprsCodingScheme::FAMILY_INVALID},
+   GprsCodingScheme::HEADER_GPRS_DATA, FAMILY_INVALID},
{{53, 7},  {53, 7},  50,  0, "CS-4",
-   GprsCodingScheme::HEADER_GPRS_DATA, 
GprsCodingScheme::FAMILY_INVALID},
+   GprsCodingScheme::HEADER_GPRS_DATA, FAMILY_INVALID},

{{26, 1},  {26, 1},  22,  0, "MCS-1",
-   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_3, 
GprsCodingScheme::FAMILY_C},
+   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_3, FAMILY_C},
{{32, 1},  {32, 1},  28,  0, "MCS-2",
-   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_3, 
GprsCodingScheme::FAMILY_B},
+   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_3, FAMILY_B},
{{41, 1},  {41, 1},  37, 48, "MCS-3",
-   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_3, 
GprsCodingScheme::FAMILY_A},
+   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_3, FAMILY_A},
{{48, 1},  {48, 1},  44,  0, "MCS-4",
-   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_3, 
GprsCodingScheme::FAMILY_C},
+   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_3, FAMILY_C},

{{60, 7},  {59, 6},  56,  0, "MCS-5",
-   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_2, 
GprsCodingScheme::FAMILY_B},
+   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_2, FAMILY_B},
{{78, 7},  {77, 6},  74, 48, "MCS-6",
-   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_2, 
GprsCodingScheme::FAMILY_A},
+   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_2, FAMILY_A},
{{118, 2}, {117, 4}, 56,  0, "MCS-7",
-   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_1, 
GprsCodingScheme::FAMILY_B},
+   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_1, FAMILY_B},
{{142, 2}, {141, 4}, 68,  0, "MCS-8",
-   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_1, 
GprsCodingScheme::FAMILY_A},
+   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_1, FAMILY_A},
{{154, 2}, {153, 4}, 74,  0, "MCS-9",
-   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_1, 
GprsCodingScheme::FAMILY_A},
+   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_1, FAMILY_A},
 };

 static struct {
@@ -220,11 +227,6 @@
return mcs_info[m_scheme].data_hdr;
 }

-GprsCodingScheme::Family GprsCodingScheme::family() const
-{
-   return mcs_info[m_scheme].family;
-}
-
 void GprsCodingScheme::inc(Mode mode)
 {
if (!isCompatible(mode))
@@ -296,10 +298,10 @@
if (*this == o)
return true;

-   if (family() == FAMILY_INVALID)
+   if (mcs_info[m_scheme].family == FAMILY_INVALID)
return false;

-   return family() == o.family();
+   return mcs_info[m_scheme].family == mcs_info[o.m_scheme].family;
 }

 bool GprsCodingScheme::isCombinable(GprsCodingScheme o) const
diff --git a/src/gprs_coding_scheme.h b/src/gprs_coding_scheme.h
index 76cab0f..6087416 100644
--- a/src/gprs_coding_scheme.h
+++ b/src/gprs_coding_scheme.h
@@ -59,13 +59,6 @@
NUM_HEADER_TYPES
};

-   enum Family {

Change in osmo-pcu[master]: EDGE tests: remove no-op check

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/13052 )

Change subject: EDGE tests: remove no-op check
..


Patch Set 1:

maybe this is to present a unified interface of GPRS and EGPRS coding? Maybe 
there are (future) cases where the return isn't envisioned as being const?


-- 
To view, visit https://gerrit.osmocom.org/13052
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0f81fe05a2b3f432de7d1f3446e8115d7524ff4
Gerrit-Change-Number: 13052
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Daniel Willmann 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 26 Feb 2019 22:52:28 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-pcu[master]: EDGE tests: reduce code duplication

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/13051 )

Change subject: EDGE tests: reduce code duplication
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/13051
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a9528032629e5df629996da5cd8b808efede017
Gerrit-Change-Number: 13051
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Daniel Willmann 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 26 Feb 2019 22:51:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ccid-firmware[master]: add debug tracing using SWO

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/13055 )

Change subject: add debug tracing using SWO
..


Patch Set 1:

this is taking a quite different route than 
https://gerrit.osmocom.org/#/c/osmo-ccid-firmware/+/13035/

The problem I see with SWO is that it's only uni-directional, while we 
typically have some kind of textual debug console in our devices.

I guess for R it doesn't matter if you have 7 or 8 SIM cards active.  For 
production you can then enable the last one.

Maybe in the end it will have to be a single #define at compile time that 
decides if we use SWO or UART7 as output?  It would be great to align the code 
bases and use the I/O abstraction that ASF4 provides, see the patch I 
referenced above: https://gerrit.osmocom.org/#/c/osmo-ccid-firmware/+/13035/


--
To view, visit https://gerrit.osmocom.org/13055
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c6d66e7089971294d7c006fbb600e8085e58595
Gerrit-Change-Number: 13055
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Tue, 26 Feb 2019 22:49:18 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ccid-firmware[master]: add RMII clock output

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/13054 )

Change subject: add RMII clock output
..


Patch Set 1: Code-Review-1

I don't see how this could work without a hardware bugfix, see 
https://projects.sysmocom.de/issues/4482


--
To view, visit https://gerrit.osmocom.org/13054
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8409779d2835b56bbae7db2e962034c82fa3b62
Gerrit-Change-Number: 13054
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Tue, 26 Feb 2019 22:45:47 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ccid-firmware[master]: fix ASFv4 USB stack

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/13056 )

Change subject: fix ASFv4 USB stack
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/13056
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4209072ee808f0e246bcd5e86917dcf1d213c26b
Gerrit-Change-Number: 13056
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Tue, 26 Feb 2019 22:45:56 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: fix api doc typo for osmo_plmn_name2()

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/13065 )

Change subject: fix api doc typo for osmo_plmn_name2()
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/13065
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2652c7e4ffe1e707022168ac6c0da7c88ae7f45
Gerrit-Change-Number: 13065
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Tue, 26 Feb 2019 22:43:14 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-pcu[master]: MCS: internalize 'family' parameter

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/13060 )

Change subject: MCS: internalize 'family' parameter
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/13060
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic705615cd2a8ca077efef9ea62a2a676f70b4aed
Gerrit-Change-Number: 13060
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Daniel Willmann 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 26 Feb 2019 22:43:56 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: fix api doc typo for osmo_plmn_name2()

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/13065 )

Change subject: fix api doc typo for osmo_plmn_name2()
..

fix api doc typo for osmo_plmn_name2()

Change-Id: Ic2652c7e4ffe1e707022168ac6c0da7c88ae7f45
---
M src/gsm/gsm23003.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gsm/gsm23003.c b/src/gsm/gsm23003.c
index 95fca91..720c09b 100644
--- a/src/gsm/gsm23003.c
+++ b/src/gsm/gsm23003.c
@@ -129,7 +129,7 @@
return buf;
 }

-/*! Same as osmo_mcc_mnc_name(), but returning in a different static buffer.
+/*! Same as osmo_plmn_name(), but returning in a different static buffer.
  * \param[in] plmn  MCC-MNC value.
  * \returns string in static buffer.
  */

--
To view, visit https://gerrit.osmocom.org/13065
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2652c7e4ffe1e707022168ac6c0da7c88ae7f45
Gerrit-Change-Number: 13065
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-pcu[master]: MCS: move Coding Scheme enum to C header

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/13064 )

Change subject: MCS: move Coding Scheme enum to C header
..


Patch Set 1:

the code you're touching is undoubtedly C++ code.  I'm not sure if it's an 
improvement to turn [more] parts of it into C.  Also, I don't see from your 
changes or from the commitlog *why* this simplifies testing.  It's not clear 
that C++ can be tested less than C ?1?


--
To view, visit https://gerrit.osmocom.org/13064
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I993b49d9a82b8c7ad677d52d11003794aeabe117
Gerrit-Change-Number: 13064
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Tue, 26 Feb 2019 22:41:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-pcu[master]: MCS: remove dead code

[Harald Welte]

Harald Welte has removed a vote on this change.

Change subject: MCS: remove dead code
..


Removed Code-Review+2 by Harald Welte 
--
To view, visit https://gerrit.osmocom.org/13063
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ieef3b095a6732300e5efa395b989843112b9ca78
Gerrit-Change-Number: 13063
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #9065

[jenkins]

See 


--
[...truncated 1.15 MB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Build failed in Jenkins: master-osmo-sgsn » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #9065

[jenkins]

See 


--
[...truncated 412.50 KB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Build failed in Jenkins: master-osmo-sgsn » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #9064

[jenkins]

See 


--
[...truncated 388.25 KB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #9064

[jenkins]

See 


--
[...truncated 1.24 MB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Change in osmo-pcu[master]: Make get_retx_mcs() into regular function

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/13066


Change subject: Make get_retx_mcs() into regular function
..

Make get_retx_mcs() into regular function

Moving from header-defined inline function allows us to hide
egprs_mcs_retx_tbl definition and simplify further changes.

Change-Id: I95258d1558a3b918ae83f1a69e7c3de2b97e5627
---
M src/gprs_coding_scheme.cpp
M src/gprs_coding_scheme.h
2 files changed, 14 insertions(+), 18 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/66/13066/1

diff --git a/src/gprs_coding_scheme.cpp b/src/gprs_coding_scheme.cpp
index 3769363..1231f0e 100644
--- a/src/gprs_coding_scheme.cpp
+++ b/src/gprs_coding_scheme.cpp
@@ -21,13 +21,16 @@

 #include "gprs_coding_scheme.h"

+#define MAX_NUM_ARQ   2 /* max. number of ARQ */
+#define MAX_NUM_MCS   9 /* max. number of MCS */
+
 /*
  * 44.060 Table 8.1.1.1 and Table 8.1.1.2
  * It has 3 level indexing. 0th level is ARQ type
  * 1st level is Original MCS( index 0 corresponds to MCS1 and so on)
  * 2nd level is MS MCS (index 0 corresponds to MCS1 and so on)
  */
-enum CodingScheme GprsCodingScheme::egprs_mcs_retx_tbl[MAX_NUM_ARQ]
+static enum CodingScheme egprs_mcs_retx_tbl[MAX_NUM_ARQ]
[MAX_NUM_MCS][MAX_NUM_MCS] = {
{
{MCS1, MCS1, MCS1, MCS1, MCS1, MCS1, MCS1, MCS1, MCS1},
@@ -53,6 +56,16 @@
}
};

+CodingScheme GprsCodingScheme::get_retx_mcs(const GprsCodingScheme mcs,
+   const GprsCodingScheme 
demanded_mcs,
+   const unsigned arq_type)
+{
+   OSMO_ASSERT(mcs.to_num() > 0);
+   OSMO_ASSERT(demanded_mcs.to_num() > 0);
+
+   return egprs_mcs_retx_tbl[arq_type][mcs.to_num() - 
1][demanded_mcs.to_num() - 1];
+}
+
 static struct {
struct {
uint8_t bytes;
diff --git a/src/gprs_coding_scheme.h b/src/gprs_coding_scheme.h
index 1121d13..89054f5 100644
--- a/src/gprs_coding_scheme.h
+++ b/src/gprs_coding_scheme.h
@@ -31,8 +31,6 @@
 class GprsCodingScheme {
 public:
 
-#define MAX_NUM_ARQ   2  /* max. number of ARQ */
-#define MAX_NUM_MCS   9 /* max. number of MCS */
 #define EGPRS_ARQ10x0
 #define EGPRS_ARQ20x1

@@ -111,9 +109,6 @@
static CodingScheme get_retx_mcs(const GprsCodingScheme mcs,
const GprsCodingScheme retx_mcs,
const unsigned arq_type);
-
-   static enum CodingScheme egprs_mcs_retx_tbl[MAX_NUM_ARQ]
-   [MAX_NUM_MCS][MAX_NUM_MCS];
 private:
GprsCodingScheme(int s); /* fail on use */
GprsCodingScheme& operator =(int s); /* fail on use */
@@ -206,15 +201,3 @@
 {
return a.isCompatible(b) && a.to_num() < b.to_num();
 }
-
-inline CodingScheme GprsCodingScheme::get_retx_mcs(
-   const GprsCodingScheme mcs,
-   const GprsCodingScheme demanded_mcs,
-   const unsigned arq_type)
-{
-   OSMO_ASSERT(mcs.to_num() > 0);
-   OSMO_ASSERT(demanded_mcs.to_num() > 0);
-
-   return egprs_mcs_retx_tbl[arq_type][mcs.to_num() - 1]
-   [demanded_mcs.to_num() - 1];
-}

--
To view, visit https://gerrit.osmocom.org/13066
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I95258d1558a3b918ae83f1a69e7c3de2b97e5627
Gerrit-Change-Number: 13066
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Build failure of network:osmocom:nightly/osmo-sgsn in xUbuntu_17.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/xUbuntu_17.10/i586

Package network:osmocom:nightly/osmo-sgsn failed to build in xUbuntu_17.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[   78s] | #define HAVE_MEMORY_H 1
[   78s] | #define HAVE_STRINGS_H 1
[   78s] | #define HAVE_INTTYPES_H 1
[   78s] | #define HAVE_STDINT_H 1
[   78s] | #define HAVE_UNISTD_H 1
[   78s] | #define HAVE_DLFCN_H 1
[   78s] | #define LT_OBJDIR ".libs/"
[   78s] | #define BUILD_IU 1
[   78s] | #define STDC_HEADERS 1
[   78s] | #define HAVE_TM_GMTOFF_IN_TM 1
[   78s] | 
[   78s] | configure: exit 0
[   78s] 
[   78s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[   78s] make[1]: *** [override_dh_auto_test] Error 1
[   78s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   78s] debian/rules:45: recipe for target 'build' failed
[   78s] make: *** [build] Error 2
[   78s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   78s] 
[   78s] build76 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Tue Feb 26 
20:58:52 UTC 2019.
[   78s] 
[   78s] ### VM INTERACTION START ###
[   81s] [   73.396255] sysrq: SysRq : Power Off
[   81s] [   73.399088] reboot: Power down
[   81s] ### VM INTERACTION END ###
[   81s] 
[   81s] build76 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Tue Feb 26 
20:58:55 UTC 2019.
[   81s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in libosmocore[master]: log: fsm: allow logging the timeout on state change

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12987 )

Change subject: log: fsm: allow logging the timeout on state change
..

log: fsm: allow logging the timeout on state change

Add a flag that adds timeout info to osmo_fsm_inst state change logging.

To not affect unit testing, make this an opt-in feature that is disabled by
default -- mostly because osmo_fsm_inst_state_chg_keep_timer() will produce
non-deterministic logging depending on timing (logs remaining time).

Unit tests that don't verify log output and those that use fake time may also
enable this feature. Do so in fsm_test.c.

The idea is that in due course we will add osmo_fsm_log_timeouts(true) calls to
all of our production applications' main() initialization.

Change-Id: I089b81021a1a4ada1205261470da032b82d57872
---
M include/osmocom/core/fsm.h
M src/fsm.c
M tests/fsm/fsm_test.c
M tests/fsm/fsm_test.err
4 files changed, 53 insertions(+), 12 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/core/fsm.h b/include/osmocom/core/fsm.h
index df7e348..ae1c857 100644
--- a/include/osmocom/core/fsm.h
+++ b/include/osmocom/core/fsm.h
@@ -118,6 +118,7 @@
 };

 void osmo_fsm_log_addr(bool log_addr);
+void osmo_fsm_log_timeouts(bool log_timeouts);

 /*! Log using FSM instance's context, on explicit logging subsystem and level.
  * \param fi  An osmo_fsm_inst.
diff --git a/src/fsm.c b/src/fsm.c
index 6e15ab7..eb457a1 100644
--- a/src/fsm.c
+++ b/src/fsm.c
@@ -90,6 +90,7 @@

 LLIST_HEAD(osmo_g_fsms);
 static bool fsm_log_addr = true;
+static bool fsm_log_timeouts = false;

 /*! specify if FSM instance addresses should be logged or not
  *
@@ -104,6 +105,26 @@
fsm_log_addr = log_addr;
 }

+/*! Enable or disable logging of timeout values for FSM instance state changes.
+ *
+ * By default, state changes are logged by state name only, omitting the 
timeout. When passing true, each state change
+ * will also log the T number and the chosen timeout in seconds. 
osmo_fsm_inst_state_chg_keep_timer() will log remaining
+ * timeout in millisecond precision.
+ *
+ * The default for this is false to reflect legacy behavior. Since various C 
tests that verify logging output already
+ * existed prior to this option, keeping timeout logging off makes sure that 
they continue to pass. Particularly,
+ * osmo_fsm_inst_state_chg_keep_timer() may cause non-deterministic logging of 
remaining timeout values.
+ *
+ * For any program that does not explicitly require deterministic logging 
output, i.e. anything besides regression tests
+ * involving FSM instances, it is recommended to call 
osmo_fsm_log_timeouts(true).
+ *
+ * \param[in] log_timeouts  Pass true to log timeouts on state transitions, 
false to omit timeouts.
+ */
+void osmo_fsm_log_timeouts(bool log_timeouts)
+{
+   fsm_log_timeouts = log_timeouts;
+}
+
 struct osmo_fsm *osmo_fsm_find_by_name(const char *name)
 {
struct osmo_fsm *fsm;
@@ -436,6 +457,7 @@
struct osmo_fsm *fsm = fi->fsm;
uint32_t old_state = fi->state;
const struct osmo_fsm_state *st = >states[fi->state];
+   struct timeval remaining;

/* Limit to 0x7fff seconds as explained by
 * _osmo_fsm_inst_state_chg()'s API doc. */
@@ -458,8 +480,23 @@
if (st->onleave)
st->onleave(fi, new_state);

-   LOGPFSMSRC(fi, file, line, "state_chg to %s\n",
-  osmo_fsm_state_name(fsm, new_state));
+   if (fsm_log_timeouts) {
+   if (keep_timer && fi->timer.active && 
(osmo_timer_remaining(>timer, NULL, ) == 0))
+   LOGPFSMSRC(fi, file, line, "State change to %s (keeping 
T%d, %ld.%03lds remaining)\n",
+  osmo_fsm_state_name(fsm, new_state),
+  fi->T, remaining.tv_sec, remaining.tv_usec / 
1000);
+   else if (timeout_secs && !keep_timer)
+   LOGPFSMSRC(fi, file, line, "State change to %s (T%d, 
%lus)\n",
+  osmo_fsm_state_name(fsm, new_state),
+  T, timeout_secs);
+   else
+   LOGPFSMSRC(fi, file, line, "State change to %s (no 
timeout)\n",
+  osmo_fsm_state_name(fsm, new_state));
+   } else {
+   LOGPFSMSRC(fi, file, line, "state_chg to %s\n",
+  osmo_fsm_state_name(fsm, new_state));
+   }
+
fi->state = new_state;
st = >states[new_state];

diff --git a/tests/fsm/fsm_test.c b/tests/fsm/fsm_test.c
index 7aac8d3..f8ebdc7 100644
--- a/tests/fsm/fsm_test.c
+++ b/tests/fsm/fsm_test.c
@@ -406,6 +406,9 @@

osmo_fsm_log_addr(false);

+   /* Using fake time to get deterministic timeout logging */
+   osmo_fsm_log_timeouts(true);
+

Change in libosmocore[master]: fix api doc typo for osmo_plmn_name2()

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/13065


Change subject: fix api doc typo for osmo_plmn_name2()
..

fix api doc typo for osmo_plmn_name2()

Change-Id: Ic2652c7e4ffe1e707022168ac6c0da7c88ae7f45
---
M src/gsm/gsm23003.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/65/13065/1

diff --git a/src/gsm/gsm23003.c b/src/gsm/gsm23003.c
index 95fca91..720c09b 100644
--- a/src/gsm/gsm23003.c
+++ b/src/gsm/gsm23003.c
@@ -129,7 +129,7 @@
return buf;
 }

-/*! Same as osmo_mcc_mnc_name(), but returning in a different static buffer.
+/*! Same as osmo_plmn_name(), but returning in a different static buffer.
  * \param[in] plmn  MCC-MNC value.
  * \returns string in static buffer.
  */

--
To view, visit https://gerrit.osmocom.org/13065
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2652c7e4ffe1e707022168ac6c0da7c88ae7f45
Gerrit-Change-Number: 13065
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 

Build failure of network:osmocom:nightly/osmo-sgsn in xUbuntu_16.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/osmo-sgsn failed to build in 
xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  177s] | #define HAVE_MEMORY_H 1
[  177s] | #define HAVE_STRINGS_H 1
[  177s] | #define HAVE_INTTYPES_H 1
[  177s] | #define HAVE_STDINT_H 1
[  177s] | #define HAVE_UNISTD_H 1
[  177s] | #define HAVE_DLFCN_H 1
[  177s] | #define LT_OBJDIR ".libs/"
[  177s] | #define BUILD_IU 1
[  177s] | #define STDC_HEADERS 1
[  177s] | #define HAVE_TM_GMTOFF_IN_TM 1
[  177s] | 
[  177s] | configure: exit 0
[  177s] 
[  177s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[  177s] make[1]: *** [override_dh_auto_test] Error 1
[  177s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  177s] debian/rules:45: recipe for target 'build' failed
[  177s] make: *** [build] Error 2
[  177s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  177s] 
[  177s] lamb22 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Tue Feb 26 
20:53:38 UTC 2019.
[  177s] 
[  177s] ### VM INTERACTION START ###
[  180s] [  160.970226] sysrq: SysRq : Power Off
[  180s] [  160.976345] reboot: Power down
[  180s] ### VM INTERACTION END ###
[  180s] 
[  180s] lamb22 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Tue Feb 26 
20:53:42 UTC 2019.
[  180s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in xUbuntu_18.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/xUbuntu_18.04/x86_64

Package network:osmocom:nightly/osmo-sgsn failed to build in 
xUbuntu_18.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  141s]  
[  141s]  PROCESSING ALIVE_ACK from 0x05060708:32000
[  141s]  0b 
[  141s] @@ -7311,7 +7311,7 @@
[  141s]  MESSAGE to SGSN at 0x05060708:32000, msg length 1
[  141s]  0a 
[  141s]  
[  141s] -result (RESET_ACK) = 1
[  141s] +result (RESET_ACK) = 0
[  141s]  
[  141s]  PROCESSING ALIVE_ACK from 0x05060708:32000
[  141s]  0b 
[  141s] 2. testsuite.at:10: 2. gbproxy (testsuite.at:10): FAILED 
(testsuite.at:13)
[  141s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[  141s] make[1]: *** [override_dh_auto_test] Error 1
[  141s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  141s] debian/rules:45: recipe for target 'build' failed
[  141s] make: *** [build] Error 2
[  141s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  141s] 
[  141s] lamb15 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Tue Feb 26 
20:49:17 UTC 2019.
[  141s] 
[  141s] ### VM INTERACTION START ###
[  144s] [  132.050853] sysrq: SysRq : Power Off
[  144s] [  132.056363] reboot: Power down
[  144s] ### VM INTERACTION END ###
[  144s] 
[  144s] lamb15 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Tue Feb 26 
20:49:21 UTC 2019.
[  144s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #9063

[jenkins]

See 


--
[...truncated 1.24 MB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Build failed in Jenkins: master-osmo-sgsn » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #9063

[jenkins]

See 


--
[...truncated 411.04 KB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Change in osmo-pcu[master]: MCS: move Coding Scheme enum to C header

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/13064


Change subject: MCS: move Coding Scheme enum to C header
..

MCS: move Coding Scheme enum to C header

Move generic MCS enum to C header file to simplify further modifications
and testing.

Change-Id: I993b49d9a82b8c7ad677d52d11003794aeabe117
---
M src/Makefile.am
A src/coding_scheme.h
M src/gprs_coding_scheme.cpp
M src/gprs_coding_scheme.h
M src/gprs_ms.cpp
M src/gprs_ms.h
M src/rlc.cpp
M src/tbf_dl.cpp
M src/tbf_ul.cpp
M tests/edge/EdgeTest.cpp
M tests/tbf/TbfTest.cpp
11 files changed, 247 insertions(+), 230 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/64/13064/1

diff --git a/src/Makefile.am b/src/Makefile.am
index 50e0eda..eb4a2bb 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -97,6 +97,7 @@
cxx_linuxlist.h \
gprs_codel.h \
gprs_coding_scheme.h \
+   coding_scheme.h \
egprs_rlc_compression.h
 
 osmo_pcu_SOURCES = pcu_main.cpp
diff --git a/src/coding_scheme.h b/src/coding_scheme.h
new file mode 100644
index 000..3705ea4
--- /dev/null
+++ b/src/coding_scheme.h
@@ -0,0 +1,29 @@
+/* coding_scheme.h
+ *
+ * Copyright (C) 2015-2019 by sysmocom s.f.m.c. GmbH
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
+ */
+
+#pragma once
+
+enum CodingScheme {
+   UNKNOWN,
+   /* GPRS Coding Schemes: */
+   CS1, CS2, CS3, CS4,
+   /* EDGE/EGPRS Modulation and Coding Schemes: */
+   MCS1, MCS2, MCS3, MCS4, MCS5, MCS6, MCS7, MCS8, MCS9,
+   NUM_SCHEMES
+};
diff --git a/src/gprs_coding_scheme.cpp b/src/gprs_coding_scheme.cpp
index 3094ae6..3769363 100644
--- a/src/gprs_coding_scheme.cpp
+++ b/src/gprs_coding_scheme.cpp
@@ -27,7 +27,7 @@
  * 1st level is Original MCS( index 0 corresponds to MCS1 and so on)
  * 2nd level is MS MCS (index 0 corresponds to MCS1 and so on)
  */
-enum GprsCodingScheme::Scheme GprsCodingScheme::egprs_mcs_retx_tbl[MAX_NUM_ARQ]
+enum CodingScheme GprsCodingScheme::egprs_mcs_retx_tbl[MAX_NUM_ARQ]
[MAX_NUM_MCS][MAX_NUM_MCS] = {
{
{MCS1, MCS1, MCS1, MCS1, MCS1, MCS1, MCS1, MCS1, MCS1},
@@ -64,7 +64,7 @@
const char *name;
GprsCodingScheme::HeaderType data_hdr;
GprsCodingScheme::Family family;
-} mcs_info[GprsCodingScheme::NUM_SCHEMES] = {
+} mcs_info[NUM_SCHEMES] = {
{{0, 0},   {0, 0},0,  0, "UNKNOWN",
GprsCodingScheme::HEADER_INVALID, 
GprsCodingScheme::FAMILY_INVALID},
{{23, 0},  {23, 0},  20,  0, "CS-1",
@@ -231,7 +231,7 @@
/* This should not happen. TODO: Use assert? */
return;

-   Scheme new_cs(Scheme(m_scheme + 1));
+   CodingScheme new_cs(CodingScheme(m_scheme + 1));
if (!GprsCodingScheme(new_cs).isCompatible(mode))
/* Clipping, do not change the value */
return;
@@ -245,7 +245,7 @@
/* This should not happen. TODO: Use assert? */
return;

-   Scheme new_cs(Scheme(m_scheme - 1));
+   CodingScheme new_cs(CodingScheme(m_scheme - 1));
if (!GprsCodingScheme(new_cs).isCompatible(mode))
/* Clipping, do not change the value */
return;
@@ -264,7 +264,7 @@
if (!isValid())
return;

-   m_scheme = Scheme(m_scheme + 1);
+   m_scheme = CodingScheme(m_scheme + 1);
 }

 void GprsCodingScheme::dec()
@@ -278,7 +278,7 @@
if (!isValid())
return;

-   m_scheme = Scheme(m_scheme - 1);
+   m_scheme = CodingScheme(m_scheme - 1);
 }

 const char *GprsCodingScheme::modeName(Mode mode)
diff --git a/src/gprs_coding_scheme.h b/src/gprs_coding_scheme.h
index ee30c8a..1121d13 100644
--- a/src/gprs_coding_scheme.h
+++ b/src/gprs_coding_scheme.h
@@ -25,6 +25,7 @@

 extern "C" {
#include 
+   #include "coding_scheme.h"
 }

 class GprsCodingScheme {
@@ -35,14 +36,6 @@
 #define EGPRS_ARQ10x0
 #define EGPRS_ARQ20x1

-   enum Scheme {
-   UNKNOWN,
-   CS1, CS2, CS3, CS4,
-   MCS1, MCS2, MCS3, MCS4,
-   MCS5, MCS6, MCS7, MCS8, MCS9,
-   NUM_SCHEMES
-   };
-
enum 

Build failure of network:osmocom:nightly/osmo-sgsn in Debian_9.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_9.0/x86_64

Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  105s] | #define HAVE_MEMORY_H 1
[  105s] | #define HAVE_STRINGS_H 1
[  105s] | #define HAVE_INTTYPES_H 1
[  105s] | #define HAVE_STDINT_H 1
[  105s] | #define HAVE_UNISTD_H 1
[  105s] | #define HAVE_DLFCN_H 1
[  105s] | #define LT_OBJDIR ".libs/"
[  105s] | #define BUILD_IU 1
[  105s] | #define STDC_HEADERS 1
[  105s] | #define HAVE_TM_GMTOFF_IN_TM 1
[  105s] | 
[  105s] | configure: exit 0
[  105s] 
[  105s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[  105s] make[1]: *** [override_dh_auto_test] Error 1
[  105s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  105s] debian/rules:45: recipe for target 'build' failed
[  105s] make: *** [build] Error 2
[  105s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  105s] 
[  105s] lamb14 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Tue Feb 26 
20:34:16 UTC 2019.
[  105s] 
[  105s] ### VM INTERACTION START ###
[  108s] [   94.876555] sysrq: SysRq : Power Off
[  108s] [   94.882516] reboot: Power down
[  108s] ### VM INTERACTION END ###
[  108s] 
[  108s] lamb14 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Tue Feb 26 
20:34:20 UTC 2019.
[  108s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in xUbuntu_18.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/xUbuntu_18.10/x86_64

Package network:osmocom:nightly/osmo-sgsn failed to build in 
xUbuntu_18.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  315s] | #define HAVE_STDLIB_H 1
[  315s] | #define HAVE_STRING_H 1
[  315s] | #define HAVE_MEMORY_H 1
[  315s] | #define HAVE_STRINGS_H 1
[  315s] | #define HAVE_INTTYPES_H 1
[  315s] | #define HAVE_STDINT_H 1
[  315s] | #define HAVE_UNISTD_H 1
[  315s] | #define HAVE_DLFCN_H 1
[  315s] | #define LT_OBJDIR ".libs/"
[  315s] | #define BUILD_IU 1
[  315s] | #define STDC_HEADERS 1
[  315s] | #define HAVE_TM_GMTOFF_IN_TM 1
[  315s] | 
[  315s] | configure: exit 0
[  315s] 
[  315s] make[1]: *** [debian/rules:65: override_dh_auto_test] Error 1
[  315s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  315s] make: *** [debian/rules:45: build] Error 2
[  315s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  315s] 
[  315s] cloud128 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Tue Feb 26 
20:32:38 UTC 2019.
[  315s] 
[  315s] ### VM INTERACTION START ###
[  318s] [  271.936948] sysrq: SysRq : Power Off
[  318s] [  271.948832] reboot: Power down
[  319s] ### VM INTERACTION END ###
[  319s] 
[  319s] cloud128 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Tue Feb 26 
20:32:44 UTC 2019.
[  319s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in xUbuntu_18.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/xUbuntu_18.04/i586

Package network:osmocom:nightly/osmo-sgsn failed to build in xUbuntu_18.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  146s] | #define HAVE_MEMORY_H 1
[  146s] | #define HAVE_STRINGS_H 1
[  146s] | #define HAVE_INTTYPES_H 1
[  146s] | #define HAVE_STDINT_H 1
[  146s] | #define HAVE_UNISTD_H 1
[  146s] | #define HAVE_DLFCN_H 1
[  146s] | #define LT_OBJDIR ".libs/"
[  146s] | #define BUILD_IU 1
[  146s] | #define STDC_HEADERS 1
[  146s] | #define HAVE_TM_GMTOFF_IN_TM 1
[  146s] | 
[  146s] | configure: exit 0
[  146s] 
[  146s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[  146s] make[1]: *** [override_dh_auto_test] Error 1
[  146s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  146s] debian/rules:45: recipe for target 'build' failed
[  146s] make: *** [build] Error 2
[  146s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  146s] 
[  146s] lamb15 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Tue Feb 26 
20:28:29 UTC 2019.
[  146s] 
[  146s] ### VM INTERACTION START ###
[  149s] [  137.008663] sysrq: SysRq : Power Off
[  149s] [  137.014481] reboot: Power down
[  149s] ### VM INTERACTION END ###
[  149s] 
[  149s] lamb15 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Tue Feb 26 
20:28:33 UTC 2019.
[  149s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in xUbuntu_17.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/osmo-sgsn failed to build in 
xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  124s]  
[  124s]  PROCESSING ALIVE_ACK from 0x05060708:32000
[  124s]  0b 
[  124s] @@ -7311,7 +7311,7 @@
[  124s]  MESSAGE to SGSN at 0x05060708:32000, msg length 1
[  124s]  0a 
[  124s]  
[  124s] -result (RESET_ACK) = 1
[  124s] +result (RESET_ACK) = 0
[  124s]  
[  124s]  PROCESSING ALIVE_ACK from 0x05060708:32000
[  124s]  0b 
[  124s] 2. testsuite.at:10: 2. gbproxy (testsuite.at:10): FAILED 
(testsuite.at:13)
[  124s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[  124s] make[1]: *** [override_dh_auto_test] Error 1
[  124s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  124s] debian/rules:45: recipe for target 'build' failed
[  124s] make: *** [build] Error 2
[  124s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  124s] 
[  124s] lamb61 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Tue Feb 26 
20:26:51 UTC 2019.
[  124s] 
[  124s] ### VM INTERACTION START ###
[  127s] [  114.194149] sysrq: SysRq : Power Off
[  127s] [  114.199165] reboot: Power down
[  127s] ### VM INTERACTION END ###
[  127s] 
[  127s] lamb61 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Tue Feb 26 
20:26:56 UTC 2019.
[  127s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_9.0/i586

Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  171s]  
[  171s]  PROCESSING ALIVE_ACK from 0x05060708:32000
[  171s]  0b 
[  171s] @@ -7311,7 +7311,7 @@
[  171s]  MESSAGE to SGSN at 0x05060708:32000, msg length 1
[  171s]  0a 
[  171s]  
[  171s] -result (RESET_ACK) = 1
[  171s] +result (RESET_ACK) = 0
[  171s]  
[  171s]  PROCESSING ALIVE_ACK from 0x05060708:32000
[  171s]  0b 
[  171s] 2. testsuite.at:10: 2. gbproxy (testsuite.at:10): FAILED 
(testsuite.at:13)
[  171s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[  171s] make[1]: *** [override_dh_auto_test] Error 1
[  171s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  171s] debian/rules:45: recipe for target 'build' failed
[  171s] make: *** [build] Error 2
[  171s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  171s] 
[  171s] cloud120 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Tue Feb 26 
20:26:03 UTC 2019.
[  171s] 
[  171s] ### VM INTERACTION START ###
[  174s] [  143.185129] sysrq: SysRq : Power Off
[  174s] [  143.198425] reboot: Power down
[  175s] ### VM INTERACTION END ###
[  175s] 
[  175s] cloud120 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Tue Feb 26 
20:26:08 UTC 2019.
[  175s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in Debian_8.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_8.0/i586

Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_8.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  156s]  
[  156s]  PROCESSING ALIVE_ACK from 0x05060708:32000
[  156s]  0b 
[  156s] @@ -7311,7 +7311,7 @@
[  156s]  MESSAGE to SGSN at 0x05060708:32000, msg length 1
[  156s]  0a 
[  156s]  
[  156s] -result (RESET_ACK) = 1
[  156s] +result (RESET_ACK) = 0
[  156s]  
[  156s]  PROCESSING ALIVE_ACK from 0x05060708:32000
[  156s]  0b 
[  156s] 2. testsuite.at:10: 2. gbproxy (testsuite.at:10): FAILED 
(testsuite.at:13)
[  156s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[  156s] make[1]: *** [override_dh_auto_test] Error 1
[  156s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  156s] debian/rules:45: recipe for target 'build' failed
[  156s] make: *** [build] Error 2
[  156s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  156s] 
[  156s] cloud129 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Tue Feb 26 
20:24:14 UTC 2019.
[  156s] 
[  156s] ### VM INTERACTION START ###
[  157s] Powering off.
[  157s] [  129.877062] reboot: Power down
[  158s] ### VM INTERACTION END ###
[  158s] 
[  158s] cloud129 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Tue Feb 26 
20:24:17 UTC 2019.
[  158s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/xUbuntu_16.04/i586

Package network:osmocom:nightly/osmo-sgsn failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  117s] | #define HAVE_MEMORY_H 1
[  117s] | #define HAVE_STRINGS_H 1
[  117s] | #define HAVE_INTTYPES_H 1
[  117s] | #define HAVE_STDINT_H 1
[  117s] | #define HAVE_UNISTD_H 1
[  117s] | #define HAVE_DLFCN_H 1
[  117s] | #define LT_OBJDIR ".libs/"
[  117s] | #define BUILD_IU 1
[  117s] | #define STDC_HEADERS 1
[  117s] | #define HAVE_TM_GMTOFF_IN_TM 1
[  117s] | 
[  117s] | configure: exit 0
[  117s] 
[  117s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[  117s] make[1]: *** [override_dh_auto_test] Error 1
[  117s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  117s] debian/rules:45: recipe for target 'build' failed
[  117s] make: *** [build] Error 2
[  117s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  117s] 
[  117s] lamb06 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Tue Feb 26 
20:22:33 UTC 2019.
[  117s] 
[  117s] ### VM INTERACTION START ###
[  121s] [  109.496459] sysrq: SysRq : Power Off
[  121s] [  109.512836] reboot: Power down
[  121s] ### VM INTERACTION END ###
[  121s] 
[  121s] lamb06 failed "build osmo-sgsn_1.4.0.2.b6f8b7.dsc" at Tue Feb 26 
20:22:37 UTC 2019.
[  121s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-pcu[master]: MCS: remove dead code

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/13063


Change subject: MCS: remove dead code
..

MCS: remove dead code

As a preparation for (M)CS fixes in follow-up patches, remove unused
operators from GprsCodingScheme class.

Change-Id: Ieef3b095a6732300e5efa395b989843112b9ca78
---
M src/gprs_coding_scheme.h
1 file changed, 0 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/63/13063/1

diff --git a/src/gprs_coding_scheme.h b/src/gprs_coding_scheme.h
index 76cab0f..ee30c8a 100644
--- a/src/gprs_coding_scheme.h
+++ b/src/gprs_coding_scheme.h
@@ -220,20 +220,6 @@
GprsCodingScheme::Scheme(a) < GprsCodingScheme::Scheme(b);
 }

-inline bool operator >(GprsCodingScheme a, GprsCodingScheme b)
-{
-   return b < a;
-}
-
-inline bool operator <=(GprsCodingScheme a, GprsCodingScheme b)
-{
-   return a == b || a < b;
-}
-
-inline bool operator >=(GprsCodingScheme a, GprsCodingScheme b)
-{
-   return a == b || a > b;
-}
 inline GprsCodingScheme::Scheme GprsCodingScheme::get_retx_mcs(
const GprsCodingScheme mcs,
const GprsCodingScheme demanded_mcs,

--
To view, visit https://gerrit.osmocom.org/13063
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieef3b095a6732300e5efa395b989843112b9ca78
Gerrit-Change-Number: 13063
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in libosmocore[master]: use osmo_static_string() instead of numerous static buffers

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/13062


Change subject: use osmo_static_string() instead of numerous static buffers
..

use osmo_static_string() instead of numerous static buffers

Change-Id: Id0eab72fa71630c8eb9edafaa370a41ca16329aa
---
M include/osmocom/gsm/gsm0808_utils.h
M include/osmocom/gsm/gsm23003.h
M src/fsm.c
M src/gb/gprs_ns.c
M src/gsm/abis_nm.c
M src/gsm/apn.c
M src/gsm/gsm0808_utils.c
M src/gsm/gsm23003.c
M src/gsm/gsm48.c
M src/gsm/gsm_utils.c
M src/gsm/rsl.c
M src/msgb.c
M src/sim/core.c
M src/socket.c
M src/utils.c
15 files changed, 119 insertions(+), 94 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/62/13062/1

diff --git a/include/osmocom/gsm/gsm0808_utils.h 
b/include/osmocom/gsm/gsm0808_utils.h
index e1e345d..4ca355a 100644
--- a/include/osmocom/gsm/gsm0808_utils.h
+++ b/include/osmocom/gsm/gsm0808_utils.h
@@ -73,7 +73,8 @@
 { return get_value_string(gsm0808_cell_id_discr_names, id_discr); }

 const char *gsm0808_cell_id_name(const struct gsm0808_cell_id *cid);
-const char *gsm0808_cell_id_name2(const struct gsm0808_cell_id *cid);
+const char *gsm0808_cell_id_name2(const struct gsm0808_cell_id *cid)
+   OSMO_DEPRECATED("Use gsm0808_cell_id_name() instead, which now returns 
distinct static buffers for every invocation");
 const char *gsm0808_cell_id_list_name(const struct gsm0808_cell_id_list2 *cil);
 int gsm0808_cell_id_list_name_buf(char *buf, size_t buflen, const struct 
gsm0808_cell_id_list2 *cil);
 int gsm0808_cell_id_u_name(char *buf, size_t buflen,
diff --git a/include/osmocom/gsm/gsm23003.h b/include/osmocom/gsm/gsm23003.h
index b34a677..7c04760 100644
--- a/include/osmocom/gsm/gsm23003.h
+++ b/include/osmocom/gsm/gsm23003.h
@@ -99,9 +99,11 @@
 const char *osmo_mnc_name(uint16_t mnc, bool mnc_3_digits);
 const char *osmo_plmn_name(const struct osmo_plmn_id *plmn);
 const char *osmo_plmn_name2(const struct osmo_plmn_id *plmn);
+   OSMO_DEPRECATED("Use osmo_plmn_name() instead, which now returns 
distinct static buffers for every invocation");
 const char *osmo_lai_name(const struct osmo_location_area_id *lai);
 const char *osmo_cgi_name(const struct osmo_cell_global_id *cgi);
 const char *osmo_cgi_name2(const struct osmo_cell_global_id *cgi);
+   OSMO_DEPRECATED("Use osmo_cgi_name() instead, which now returns 
distinct static buffers for every invocation");
 const char *osmo_gummei_name(const struct osmo_gummei *gummei);

 void osmo_plmn_to_bcd(uint8_t *bcd_dst, const struct osmo_plmn_id *plmn);
diff --git a/src/fsm.c b/src/fsm.c
index 6e15ab7..e8c008e 100644
--- a/src/fsm.c
+++ b/src/fsm.c
@@ -391,9 +391,10 @@
  */
 const char *osmo_fsm_event_name(struct osmo_fsm *fsm, uint32_t event)
 {
-   static char buf[32];
if (!fsm->event_names) {
-   snprintf(buf, sizeof(buf), "%"PRIu32, event);
+   const size_t len = 32;
+   char *buf = osmo_static_string(len);
+   snprintf(buf, len, "%"PRIu32, event);
return buf;
} else
return get_value_string(fsm->event_names, event);
@@ -421,9 +422,10 @@
  */
 const char *osmo_fsm_state_name(struct osmo_fsm *fsm, uint32_t state)
 {
-   static char buf[32];
if (state >= fsm->num_states) {
-   snprintf(buf, sizeof(buf), "unknown %"PRIu32, state);
+   const size_t len = 32;
+   char *buf = osmo_static_string(len);
+   snprintf(buf, len, "unknown %"PRIu32, state);
return buf;
} else
return fsm->states[state].name;
diff --git a/src/gb/gprs_ns.c b/src/gb/gprs_ns.c
index 54964d3..5706701 100644
--- a/src/gb/gprs_ns.c
+++ b/src/gb/gprs_ns.c
@@ -1203,15 +1203,16 @@

 const char *gprs_ns_ll_str(const struct gprs_nsvc *nsvc)
 {
-   static char buf[80];
+   const size_t buflen = 80;
+   char *buf = osmo_static_string(buflen);

switch(nsvc->ll) {
case GPRS_NS_LL_UDP:
-   snprintf(buf, sizeof(buf), "%s:%u",
+   snprintf(buf, buflen, "%s:%u",
 inet_ntoa(nsvc->ip.bts_addr.sin_addr), 
osmo_ntohs(nsvc->ip.bts_addr.sin_port));
break;
case GPRS_NS_LL_FR_GRE:
-   snprintf(buf, sizeof(buf), "%s:%u",
+   snprintf(buf, buflen, "%s:%u",
 inet_ntoa(nsvc->frgre.bts_addr.sin_addr), 
osmo_ntohs(nsvc->frgre.bts_addr.sin_port));
break;
default:
@@ -1219,7 +1220,7 @@
break;
}

-   buf[sizeof(buf) - 1] = '\0';
+   buf[buflen - 1] = '\0';

return buf;
 }
diff --git a/src/gsm/abis_nm.c b/src/gsm/abis_nm.c
index 49d05ba..5b8df57 100644
--- a/src/gsm/abis_nm.c
+++ b/src/gsm/abis_nm.c
@@ -930,8 +930,9 @@

 const char *abis_nm_dump_foh(const struct abis_om_fom_hdr *foh)
 {
-   static char foh_buf[128];
-   

Change in libosmocore[master]: add osmo_string_ringbuffer and osmo_static_string() API

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/13061


Change subject: add osmo_string_ringbuffer and osmo_static_string() API
..

add osmo_string_ringbuffer and osmo_static_string() API

Change-Id: I48f8951de4d209d4cd3ca1aa9ce6137918913125
---
M include/osmocom/core/utils.h
M src/utils.c
M tests/utils/utils_test.c
M tests/utils/utils_test.ok
4 files changed, 639 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/61/13061/1

diff --git a/include/osmocom/core/utils.h b/include/osmocom/core/utils.h
index 16159d3..efc9bcc 100644
--- a/include/osmocom/core/utils.h
+++ b/include/osmocom/core/utils.h
@@ -230,4 +230,33 @@
 #define OSMO_STRBUF_PRINTF(STRBUF, fmt, args...) \
OSMO_STRBUF_APPEND(STRBUF, snprintf, fmt, ##args)

+/*! State for managing a ringbuffer of static strings. See 
osmo_static_string(). */
+struct osmo_string_ringbuffer {
+   /*! Start of the usable memory. */
+   char *buf;
+   /*! Size of the usable memory. */
+   size_t buf_size;
+   /*! Pointer to after the last used static string. */
+   char *next;
+   /*! Most recent usages, for sanity checking. If not NULL, should point 
to an array of char*[recent_len]. */
+   char **recent;
+   /*! Number of recent usages that is considered as still in use. */
+   size_t recent_len;
+};
+
+char *osmo_string_ringbuffer_get(struct osmo_string_ringbuffer *buf, size_t 
bufsize);
+size_t osmo_string_ringbuffer_avail(struct osmo_string_ringbuffer *buf);
+void osmo_string_ringbuffer_clear(struct osmo_string_ringbuffer *buf);
+
+char *osmo_static_string(size_t bufsize);
+
+/*! Useful to pass osmo_static_string() and size arguments without repeating 
the size.
+ *
+ * printf("%s\n", osmo_hexdump_buf(OSMO_STATIC_STRING(my_data_len*2), 
my_data, my_data_len, NULL, false));
+ */
+#define OSMO_STATIC_STRING(SIZE) osmo_static_string(SIZE), (SIZE)
+
+extern struct osmo_string_ringbuffer osmo_static_string_buf_default;
+extern struct osmo_string_ringbuffer *osmo_static_string_buf;
+
 /*! @} */
diff --git a/src/utils.c b/src/utils.c
index 2d5bcb0..12189b6 100644
--- a/src/utils.c
+++ b/src/utils.c
@@ -826,4 +826,160 @@
return (sum * 9) % 10 + '0';
 }

+/*! Return section from a string ringbuffer that is currently considered 
unused.
+ * \param[in] buf  osmo_string_ringbuffer instance.
+ * \param[in] bufsize  The amount of bytes that should be available, caller 
needs to include terminating nul.
+ * \returns Pointer to string buffer, or NULL if there is not enough unused 
memory available in osmo_static_string_buf.
+ */
+char *osmo_string_ringbuffer_get(struct osmo_string_ringbuffer *buf, size_t 
bufsize)
+{
+   char *ret;
+   int i;
+
+   if (!bufsize || !buf)
+   return NULL;
+
+   if (bufsize > buf->buf_size)
+   return NULL;
+
+   ret = buf->next;
+   if (ret < buf->buf
+   || ret + bufsize > buf->buf + buf->buf_size)
+   ret = buf->buf;
+
+   if (buf->recent) {
+   if (ret <= buf->recent[0]
+   && bufsize > buf->recent[0] - ret)
+   return NULL;
+
+   /* Record used chunk in list of recent buffers */
+   for (i = 0; i < buf->recent_len; i++) {
+   if (!buf->recent[i])
+   break;
+   }
+
+   if (i < buf->recent_len)
+   buf->recent[i] = ret;
+   else {
+   if (buf->recent_len > 1)
+   memmove(>recent[0], >recent[1], 
(buf->recent_len - 1) *
+   sizeof(buf->recent[0]));
+   buf->recent[buf->recent_len - 1] = ret;
+   }
+   }
+
+   buf->next = ret + bufsize;
+
+   return ret;
+}
+
+/*! Reset string ringbuffer to make all of its space available.
+ * This can be useful to mark a buffer as unused, e.g. to recover from a full 
buffer, or before and after the caller
+ * would like to allocate an unusually large buffer. All previously allocated 
pointers gotten by
+ * osmo_string_ringbuffer_get() for this ring buffer must no longer be used. */
+void osmo_string_ringbuffer_clear(struct osmo_string_ringbuffer *buf)
+{
+   if (buf->recent && buf->recent_len)
+   memset(buf->recent, 0, buf->recent_len * 
sizeof(buf->recent[0]));
+   buf->next = NULL;
+}
+
+/*! Return the largest amount of bytes that could be allocated at this point 
in time.
+ * \param[in] buf  osmo_string_ringbuffer instance.
+ * \returns Size of largest continuous chunk of bytes available.
+ */
+size_t osmo_string_ringbuffer_avail(struct osmo_string_ringbuffer *buf)
+{
+   char *pos = buf->next;
+   if (pos < buf->buf || pos > buf->buf + buf->buf_size)
+   pos = buf->buf;
+   if 

Change in osmo-pcu[master]: MCS: internalize 'family' parameter

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/13060


Change subject: MCS: internalize 'family' parameter
..

MCS: internalize 'family' parameter

There's no need to expose it in header file as it's only used internally
for consistency checks.

Change-Id: Ic705615cd2a8ca077efef9ea62a2a676f70b4aed
---
M src/gprs_coding_scheme.cpp
M src/gprs_coding_scheme.h
2 files changed, 24 insertions(+), 30 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/60/13060/1

diff --git a/src/gprs_coding_scheme.cpp b/src/gprs_coding_scheme.cpp
index 3094ae6..bbac6e7 100644
--- a/src/gprs_coding_scheme.cpp
+++ b/src/gprs_coding_scheme.cpp
@@ -53,6 +53,13 @@
}
};

+enum Family {
+   FAMILY_INVALID,
+   FAMILY_A,
+   FAMILY_B,
+   FAMILY_C,
+};
+
 static struct {
struct {
uint8_t bytes;
@@ -63,38 +70,38 @@
uint8_t optional_padding_bits;
const char *name;
GprsCodingScheme::HeaderType data_hdr;
-   GprsCodingScheme::Family family;
+   enum Family family;
 } mcs_info[GprsCodingScheme::NUM_SCHEMES] = {
{{0, 0},   {0, 0},0,  0, "UNKNOWN",
-   GprsCodingScheme::HEADER_INVALID, 
GprsCodingScheme::FAMILY_INVALID},
+   GprsCodingScheme::HEADER_INVALID, FAMILY_INVALID},
{{23, 0},  {23, 0},  20,  0, "CS-1",
-   GprsCodingScheme::HEADER_GPRS_DATA, 
GprsCodingScheme::FAMILY_INVALID},
+   GprsCodingScheme::HEADER_GPRS_DATA, FAMILY_INVALID},
{{33, 7},  {33, 7},  30,  0, "CS-2",
-   GprsCodingScheme::HEADER_GPRS_DATA, 
GprsCodingScheme::FAMILY_INVALID},
+   GprsCodingScheme::HEADER_GPRS_DATA, FAMILY_INVALID},
{{39, 3},  {39, 3},  36,  0, "CS-3",
-   GprsCodingScheme::HEADER_GPRS_DATA, 
GprsCodingScheme::FAMILY_INVALID},
+   GprsCodingScheme::HEADER_GPRS_DATA, FAMILY_INVALID},
{{53, 7},  {53, 7},  50,  0, "CS-4",
-   GprsCodingScheme::HEADER_GPRS_DATA, 
GprsCodingScheme::FAMILY_INVALID},
+   GprsCodingScheme::HEADER_GPRS_DATA, FAMILY_INVALID},

{{26, 1},  {26, 1},  22,  0, "MCS-1",
-   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_3, 
GprsCodingScheme::FAMILY_C},
+   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_3, FAMILY_C},
{{32, 1},  {32, 1},  28,  0, "MCS-2",
-   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_3, 
GprsCodingScheme::FAMILY_B},
+   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_3, FAMILY_B},
{{41, 1},  {41, 1},  37, 48, "MCS-3",
-   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_3, 
GprsCodingScheme::FAMILY_A},
+   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_3, FAMILY_A},
{{48, 1},  {48, 1},  44,  0, "MCS-4",
-   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_3, 
GprsCodingScheme::FAMILY_C},
+   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_3, FAMILY_C},

{{60, 7},  {59, 6},  56,  0, "MCS-5",
-   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_2, 
GprsCodingScheme::FAMILY_B},
+   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_2, FAMILY_B},
{{78, 7},  {77, 6},  74, 48, "MCS-6",
-   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_2, 
GprsCodingScheme::FAMILY_A},
+   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_2, FAMILY_A},
{{118, 2}, {117, 4}, 56,  0, "MCS-7",
-   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_1, 
GprsCodingScheme::FAMILY_B},
+   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_1, FAMILY_B},
{{142, 2}, {141, 4}, 68,  0, "MCS-8",
-   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_1, 
GprsCodingScheme::FAMILY_A},
+   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_1, FAMILY_A},
{{154, 2}, {153, 4}, 74,  0, "MCS-9",
-   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_1, 
GprsCodingScheme::FAMILY_A},
+   GprsCodingScheme::HEADER_EGPRS_DATA_TYPE_1, FAMILY_A},
 };

 static struct {
@@ -220,11 +227,6 @@
return mcs_info[m_scheme].data_hdr;
 }

-GprsCodingScheme::Family GprsCodingScheme::family() const
-{
-   return mcs_info[m_scheme].family;
-}
-
 void GprsCodingScheme::inc(Mode mode)
 {
if (!isCompatible(mode))
@@ -296,10 +298,10 @@
if (*this == o)
return true;

-   if (family() == FAMILY_INVALID)
+   if (mcs_info[m_scheme].family == FAMILY_INVALID)
return false;

-   return family() == o.family();
+   return mcs_info[m_scheme].family == mcs_info[o.m_scheme].family;
 }

 bool GprsCodingScheme::isCombinable(GprsCodingScheme o) const
diff --git a/src/gprs_coding_scheme.h b/src/gprs_coding_scheme.h
index 76cab0f..6087416 100644
--- a/src/gprs_coding_scheme.h
+++ b/src/gprs_coding_scheme.h
@@ -59,13 +59,6 @@
NUM_HEADER_TYPES
};

-   enum Family {
-   

Change in osmo-ccid-firmware[master]: minor: rename MUX_SSTAT to MUX_STAT

[Kévin Redon]

Kévin Redon has uploaded this change for review. ( 
https://gerrit.osmocom.org/13058


Change subject: minor: rename MUX_SSTAT to MUX_STAT
..

minor: rename MUX_SSTAT to MUX_STAT

Change-Id: I5eee17de31fdce92346641772fc0c63d4c37507a
---
M sysmoOCTSIM/atmel_start_config.atstart
M sysmoOCTSIM/atmel_start_pins.h
M sysmoOCTSIM/driver_init.c
3 files changed, 31 insertions(+), 23 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware 
refs/changes/58/13058/1

diff --git a/sysmoOCTSIM/atmel_start_config.atstart 
b/sysmoOCTSIM/atmel_start_config.atstart
index a5b73bd..948d1fb 100644
--- a/sysmoOCTSIM/atmel_start_config.atstart
+++ b/sysmoOCTSIM/atmel_start_config.atstart
@@ -1481,11 +1481,11 @@
 mode: Digital input
 user_label: SWITCH
 configuration: null
-  MUX_SSTAT:
+  MUX_STAT:
 name: PC15
 definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PC15
 mode: Digital input
-user_label: MUX_SSTAT
+user_label: MUX_STAT
 configuration: null
   SIM1_IO:
 name: PA16
@@ -1571,6 +1571,16 @@
 mode: Digital output
 user_label: SDA4
 configuration: null
+  UART_TX:
+name: PB30
+definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PB30
+mode: Advanced
+user_label: UART_TX
+configuration:
+  pad_direction: Out
+  pad_function: H
+  pad_initial_level: Low
+  pad_pull_config: 'Off'
   SCL2:
 name: PB02
 definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PB02
@@ -1583,14 +1593,4 @@
 mode: Digital output
 user_label: SDA2
 configuration: null
-  UART_TX:
-name: PB30
-definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PB30
-mode: Advanced
-user_label: UART_TX
-configuration:
-  pad_direction: Out
-  pad_function: H
-  pad_initial_level: Low
-  pad_pull_config: 'Off'
 toolchain_options: []
diff --git a/sysmoOCTSIM/atmel_start_pins.h b/sysmoOCTSIM/atmel_start_pins.h
index a2a4206..c6492fa 100644
--- a/sysmoOCTSIM/atmel_start_pins.h
+++ b/sysmoOCTSIM/atmel_start_pins.h
@@ -58,7 +58,7 @@
 #define SIM2_INT GPIO(GPIO_PORTC, 2)
 #define SIM3_INT GPIO(GPIO_PORTC, 3)
 #define SWITCH GPIO(GPIO_PORTC, 14)
-#define MUX_SSTAT GPIO(GPIO_PORTC, 15)
+#define MUX_STAT GPIO(GPIO_PORTC, 15)
 #define SIM6_IO GPIO(GPIO_PORTC, 16)
 #define USER_LED GPIO(GPIO_PORTC, 26)
 #define SCL4 GPIO(GPIO_PORTC, 27)
diff --git a/sysmoOCTSIM/driver_init.c b/sysmoOCTSIM/driver_init.c
index f442359..d6eb401 100644
--- a/sysmoOCTSIM/driver_init.c
+++ b/sysmoOCTSIM/driver_init.c
@@ -708,6 +708,14 @@
   //  High
   false);

+   gpio_set_pin_pull_mode(RMII_CLOCK,
+  //  Pull configuration
+  //  pad_pull_config
+  //  Off
+  //  Pull-up
+  //  Pull-down
+  GPIO_PULL_OFF);
+
gpio_set_pin_function(RMII_CLOCK,
  //  Pin function
  //  pad_function
@@ -768,6 +776,13 @@
   //  Out
   GPIO_DIRECTION_OUT);

+   gpio_set_pin_level(UART_TX,
+  //  Initial level
+  //  pad_initial_level
+  //  Low
+  //  High
+  false);
+
gpio_set_pin_pull_mode(UART_TX,
   //  Pull configuration
   //  pad_pull_config
@@ -776,13 +791,6 @@
   //  Pull-down
   GPIO_PULL_OFF);

-   gpio_set_pin_level(UART_TX,
-  //  Initial level
-  //  pad_initial_level
-  //  Low
-  //  High
-  false);
-
gpio_set_pin_function(UART_TX,
  //  Pin function
  //  pad_function
@@ -883,9 +891,9 @@
// GPIO on PC15

// Set pin direction to input
-   gpio_set_pin_direction(MUX_SSTAT, GPIO_DIRECTION_IN);
+   gpio_set_pin_direction(MUX_STAT, GPIO_DIRECTION_IN);

-   gpio_set_pin_pull_mode(MUX_SSTAT,
+   gpio_set_pin_pull_mode(MUX_STAT,
   //  Pull configuration
   //  pad_pull_config
   //  Off
@@ -893,7 +901,7 @@
   //  Pull-down
   GPIO_PULL_OFF);

-   gpio_set_pin_function(MUX_SSTAT, GPIO_PIN_FUNCTION_OFF);
+   gpio_set_pin_function(MUX_STAT, GPIO_PIN_FUNCTION_OFF);

// GPIO on PC26


--
To view, visit https://gerrit.osmocom.org/13058
To unsubscribe, or for help writing mail filters, visit 

Change in osmo-ccid-firmware[master]: update ASFv4 library

[Kévin Redon]

Kévin Redon has uploaded this change for review. ( 
https://gerrit.osmocom.org/13059


Change subject: update ASFv4 library
..

update ASFv4 library

this just updates the ASFv4 library files.
most of the time this is just about the line ending, but that will
make it easier to see future ASFv4 changes

Change-Id: Ic08fd2494b63b611ac4b4e1f35c91bce9aa746c5
---
M sysmoOCTSIM/CMSIS/Include/arm_common_tables.h
M sysmoOCTSIM/CMSIS/Include/arm_const_structs.h
M sysmoOCTSIM/CMSIS/Include/arm_math.h
M sysmoOCTSIM/CMSIS/Include/cmsis_armcc.h
M sysmoOCTSIM/CMSIS/Include/cmsis_armclang.h
M sysmoOCTSIM/CMSIS/Include/cmsis_compiler.h
M sysmoOCTSIM/CMSIS/Include/cmsis_gcc.h
M sysmoOCTSIM/CMSIS/Include/core_armv8mbl.h
M sysmoOCTSIM/CMSIS/Include/core_armv8mml.h
M sysmoOCTSIM/CMSIS/Include/core_cm0.h
M sysmoOCTSIM/CMSIS/Include/core_cm0plus.h
M sysmoOCTSIM/CMSIS/Include/core_cm23.h
M sysmoOCTSIM/CMSIS/Include/core_cm3.h
M sysmoOCTSIM/CMSIS/Include/core_cm33.h
M sysmoOCTSIM/CMSIS/Include/core_cm4.h
M sysmoOCTSIM/CMSIS/Include/core_cm7.h
M sysmoOCTSIM/CMSIS/Include/core_sc000.h
M sysmoOCTSIM/CMSIS/Include/core_sc300.h
M sysmoOCTSIM/CMSIS/Include/tz_context.h
M sysmoOCTSIM/gcc/gcc/same54n19a_flash.ld
M sysmoOCTSIM/gcc/gcc/same54n19a_sram.ld
M sysmoOCTSIM/include/component-version.h
M sysmoOCTSIM/include/component/ac.h
M sysmoOCTSIM/include/component/adc.h
M sysmoOCTSIM/include/component/aes.h
M sysmoOCTSIM/include/component/can.h
M sysmoOCTSIM/include/component/ccl.h
M sysmoOCTSIM/include/component/cmcc.h
M sysmoOCTSIM/include/component/dac.h
M sysmoOCTSIM/include/component/dmac.h
M sysmoOCTSIM/include/component/dsu.h
M sysmoOCTSIM/include/component/eic.h
M sysmoOCTSIM/include/component/evsys.h
M sysmoOCTSIM/include/component/freqm.h
M sysmoOCTSIM/include/component/gclk.h
M sysmoOCTSIM/include/component/gmac.h
M sysmoOCTSIM/include/component/hmatrixb.h
M sysmoOCTSIM/include/component/i2s.h
M sysmoOCTSIM/include/component/icm.h
M sysmoOCTSIM/include/component/mclk.h
M sysmoOCTSIM/include/component/nvmctrl.h
M sysmoOCTSIM/include/component/osc32kctrl.h
M sysmoOCTSIM/include/component/oscctrl.h
M sysmoOCTSIM/include/component/pac.h
M sysmoOCTSIM/include/component/pcc.h
M sysmoOCTSIM/include/component/pdec.h
M sysmoOCTSIM/include/component/picop.h
M sysmoOCTSIM/include/component/pm.h
M sysmoOCTSIM/include/component/port.h
M sysmoOCTSIM/include/component/qspi.h
M sysmoOCTSIM/include/component/ramecc.h
M sysmoOCTSIM/include/component/rstc.h
M sysmoOCTSIM/include/component/rtc.h
M sysmoOCTSIM/include/component/sdhc.h
M sysmoOCTSIM/include/component/sercom.h
M sysmoOCTSIM/include/component/supc.h
M sysmoOCTSIM/include/component/tc.h
M sysmoOCTSIM/include/component/tcc.h
M sysmoOCTSIM/include/component/trng.h
M sysmoOCTSIM/include/component/usb.h
M sysmoOCTSIM/include/component/wdt.h
M sysmoOCTSIM/include/instance/ac.h
M sysmoOCTSIM/include/instance/adc0.h
M sysmoOCTSIM/include/instance/adc1.h
M sysmoOCTSIM/include/instance/aes.h
M sysmoOCTSIM/include/instance/can0.h
M sysmoOCTSIM/include/instance/can1.h
M sysmoOCTSIM/include/instance/ccl.h
M sysmoOCTSIM/include/instance/cmcc.h
M sysmoOCTSIM/include/instance/dac.h
M sysmoOCTSIM/include/instance/dmac.h
M sysmoOCTSIM/include/instance/dsu.h
M sysmoOCTSIM/include/instance/eic.h
M sysmoOCTSIM/include/instance/evsys.h
M sysmoOCTSIM/include/instance/freqm.h
M sysmoOCTSIM/include/instance/gclk.h
M sysmoOCTSIM/include/instance/gmac.h
M sysmoOCTSIM/include/instance/hmatrix.h
M sysmoOCTSIM/include/instance/i2s.h
M sysmoOCTSIM/include/instance/icm.h
M sysmoOCTSIM/include/instance/mclk.h
M sysmoOCTSIM/include/instance/nvmctrl.h
M sysmoOCTSIM/include/instance/osc32kctrl.h
M sysmoOCTSIM/include/instance/oscctrl.h
M sysmoOCTSIM/include/instance/pac.h
M sysmoOCTSIM/include/instance/pcc.h
M sysmoOCTSIM/include/instance/pdec.h
M sysmoOCTSIM/include/instance/picop.h
M sysmoOCTSIM/include/instance/pm.h
M sysmoOCTSIM/include/instance/port.h
M sysmoOCTSIM/include/instance/pukcc.h
M sysmoOCTSIM/include/instance/qspi.h
M sysmoOCTSIM/include/instance/ramecc.h
M sysmoOCTSIM/include/instance/rstc.h
M sysmoOCTSIM/include/instance/rtc.h
M sysmoOCTSIM/include/instance/sdhc0.h
M sysmoOCTSIM/include/instance/sdhc1.h
M sysmoOCTSIM/include/instance/sercom0.h
M sysmoOCTSIM/include/instance/sercom1.h
M sysmoOCTSIM/include/instance/sercom2.h
M sysmoOCTSIM/include/instance/sercom3.h
M sysmoOCTSIM/include/instance/sercom4.h
M sysmoOCTSIM/include/instance/sercom5.h
M sysmoOCTSIM/include/instance/sercom6.h
M sysmoOCTSIM/include/instance/sercom7.h
M sysmoOCTSIM/include/instance/supc.h
M sysmoOCTSIM/include/instance/tc0.h
M sysmoOCTSIM/include/instance/tc1.h
M sysmoOCTSIM/include/instance/tc2.h
M sysmoOCTSIM/include/instance/tc3.h
M sysmoOCTSIM/include/instance/tc4.h
M sysmoOCTSIM/include/instance/tc5.h
M sysmoOCTSIM/include/instance/tc6.h
M sysmoOCTSIM/include/instance/tc7.h
M sysmoOCTSIM/include/instance/tcc0.h
M sysmoOCTSIM/include/instance/tcc1.h
M 

Change in osmo-pcu[master]: Use boolean for DL resegmentation parameter

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/13057


Change subject: Use boolean for DL resegmentation parameter
..

Use boolean for DL resegmentation parameter

In some places #define was used for DL resegmentation parameter, in
other int, in some other bool. Let's clarify this and always use boolean
value.

Change-Id: I4d4fe5fe12068a4532cb3b61d4eeb229a77c1476
---
M src/bts.h
M src/gprs_coding_scheme.h
M src/pcu_main.cpp
M src/pcu_vty.c
M tests/tbf/TbfTest.cpp
5 files changed, 9 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/57/13057/1

diff --git a/src/bts.h b/src/bts.h
index 578cece..51edc82 100644
--- a/src/bts.h
+++ b/src/bts.h
@@ -135,8 +135,8 @@
uint32_t dl_tbf_idle_msec; /* hold time for idle DL TBFs */
uint8_t si13[GSM_MACBLOCK_LEN];
bool si13_is_set;
-   /* 0 to support resegmentation in DL, 1 for no reseg */
-   uint8_t dl_arq_type;
+   /* false to support resegmentation in DL, true for no resegmentation */
+   bool dl_arq_type;

uint32_t ms_idle_sec;
uint8_t cs_adj_enabled;
diff --git a/src/gprs_coding_scheme.h b/src/gprs_coding_scheme.h
index 76cab0f..3c47266 100644
--- a/src/gprs_coding_scheme.h
+++ b/src/gprs_coding_scheme.h
@@ -32,8 +32,6 @@

 #define MAX_NUM_ARQ   2  /* max. number of ARQ */
 #define MAX_NUM_MCS   9 /* max. number of MCS */
-#define EGPRS_ARQ10x0
-#define EGPRS_ARQ20x1

enum Scheme {
UNKNOWN,
diff --git a/src/pcu_main.cpp b/src/pcu_main.cpp
index fe85160..8414ae3 100644
--- a/src/pcu_main.cpp
+++ b/src/pcu_main.cpp
@@ -263,7 +263,7 @@
 * By default resegmentation is supported in DL
 * can also be configured through VTY
 */
-   bts->dl_arq_type = EGPRS_ARQ1;
+   bts->dl_arq_type = false;

bts->pcu_sock_path = talloc_strdup(tall_pcu_ctx, PCU_SOCK_DEFAULT);

diff --git a/src/pcu_vty.c b/src/pcu_vty.c
index 960c90d..2d1903d 100644
--- a/src/pcu_vty.c
+++ b/src/pcu_vty.c
@@ -594,9 +594,9 @@
struct gprs_rlcmac_bts *bts = bts_main_data();

if (!strcmp(argv[0], "arq2"))
-   bts->dl_arq_type = 1;
+   bts->dl_arq_type = true;
else
-   bts->dl_arq_type = 0;
+   bts->dl_arq_type = false;

return CMD_SUCCESS;
 }
diff --git a/tests/tbf/TbfTest.cpp b/tests/tbf/TbfTest.cpp
index dfed79e..f96956f 100644
--- a/tests/tbf/TbfTest.cpp
+++ b/tests/tbf/TbfTest.cpp
@@ -2487,7 +2487,7 @@
bts->dl_tbf_idle_msec = 200;
bts->egprs_enabled = 1;
/* ARQ II */
-   bts->dl_arq_type = EGPRS_ARQ2;
+   bts->dl_arq_type = true;

/*
 * Simulate a message captured during over-the-air testing,
@@ -3022,7 +3022,7 @@
bts->dl_tbf_idle_msec = 200;
bts->egprs_enabled = 1;
/* ARQ II */
-   bts->dl_arq_type = EGPRS_ARQ2;
+   bts->dl_arq_type = true;


/* First parameter is current MCS, second one is demanded_mcs */
@@ -3052,7 +3052,7 @@
bts->egprs_enabled = 1;

/* ARQ I resegmentation support */
-   bts->dl_arq_type = EGPRS_ARQ1;
+   bts->dl_arq_type = false;

/*
 * First parameter is current MCS, second one is demanded_mcs
@@ -3083,7 +3083,7 @@
bts->dl_tbf_idle_msec = 200;
bts->egprs_enabled = 1;
/* ARQ II */
-   bts->dl_arq_type = EGPRS_ARQ2;
+   bts->dl_arq_type = true;

for (i = 1; i <= 9; i++)
establish_and_use_egprs_dl_tbf(_bts, i);

--
To view, visit https://gerrit.osmocom.org/13057
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d4fe5fe12068a4532cb3b61d4eeb229a77c1476
Gerrit-Change-Number: 13057
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in osmo-ccid-firmware[master]: Switch SERCOM7 (Debug UART) to sync mode + add STDIO

[Kévin Redon]

Kévin Redon has posted comments on this change. ( 
https://gerrit.osmocom.org/13035 )

Change subject: Switch SERCOM7 (Debug UART) to sync mode + add STDIO
..


Patch Set 2: Code-Review-1

instead of using SERCOM7 for UART debug I propose we use exclusively for SIM7 
and we can use SWO for debug output. this allows to also test SIM7 with debug 
output.
see https://gerrit.osmocom.org/#/c/osmo-ccid-firmware/+/13055/ for the 
corresponding change.
this also adds a less cluttered stdio/printf support.
the only downside is SWO does not have a corresponding input (UART RX) but this 
can be implemented in software.


--
To view, visit https://gerrit.osmocom.org/13035
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf4ba961d4bbf8d787558f38f3d557422587aad3
Gerrit-Change-Number: 13035
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Kévin Redon 
Gerrit-Comment-Date: Tue, 26 Feb 2019 18:45:09 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ccid-firmware[master]: add RMII clock output

[Kévin Redon]

Kévin Redon has uploaded this change for review. ( 
https://gerrit.osmocom.org/13054


Change subject: add RMII clock output
..

add RMII clock output

The TLK106 Ethernet PHY requires a 50 MHz input on XI in RMII mode.
RMII_CLOCK is connected on the micro-controller on PA14 and PB11.
PA14, with note "GTXCR" on the schematic, cannot be use to provide
the 50 MHz clock since this is the clock output for GLK[0], which
is reserved for the CPU running at 120 MHz.
PB11 is the clock output pin for GCLK[5], which now divides DPLL1
at 100 MHz to the required 50 MHz.
WARNING: I did not test if the output clock signal matches the
requirement of the input clock signal.

Change-Id: Id8409779d2835b56bbae7db2e962034c82fa3b62
---
M sysmoOCTSIM/atmel_start_config.atstart
M sysmoOCTSIM/atmel_start_pins.h
M sysmoOCTSIM/config/hpl_gclk_config.h
M sysmoOCTSIM/driver_init.c
4 files changed, 52 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware 
refs/changes/54/13054/1

diff --git a/sysmoOCTSIM/atmel_start_config.atstart 
b/sysmoOCTSIM/atmel_start_config.atstart
index 4590623..29ec468 100644
--- a/sysmoOCTSIM/atmel_start_config.atstart
+++ b/sysmoOCTSIM/atmel_start_config.atstart
@@ -734,7 +734,7 @@
   gclk_gen_4_div: 1
   gclk_gen_4_div_sel: false
   gclk_gen_4_oscillator: External Crystal Oscillator 8-48MHz (XOSC1)
-  gclk_gen_5_div: 5
+  gclk_gen_5_div: 2
   gclk_gen_5_div_sel: false
   gclk_gen_5_oscillator: Digital Phase Locked Loop (DPLL1)
   gclk_gen_6_div: 1
@@ -1453,6 +1453,16 @@
   pad_function: M
   pad_initial_level: Low
   pad_pull_config: 'Off'
+  RMII_CLOCK:
+name: PB11
+definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PB11
+mode: Advanced
+user_label: RMII_CLOCK
+configuration:
+  pad_direction: Out
+  pad_function: M
+  pad_initial_level: Low
+  pad_pull_config: 'Off'
   SCL1:
 name: PB14
 definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PB14
diff --git a/sysmoOCTSIM/atmel_start_pins.h b/sysmoOCTSIM/atmel_start_pins.h
index c877d5e..18a55fa 100644
--- a/sysmoOCTSIM/atmel_start_pins.h
+++ b/sysmoOCTSIM/atmel_start_pins.h
@@ -46,6 +46,7 @@
 #define SCL3 GPIO(GPIO_PORTB, 6)
 #define SDA3 GPIO(GPIO_PORTB, 7)
 #define SIM4_IO GPIO(GPIO_PORTB, 8)
+#define RMII_CLOCK GPIO(GPIO_PORTB, 11)
 #define SCL1 GPIO(GPIO_PORTB, 14)
 #define SDA1 GPIO(GPIO_PORTB, 15)
 #define SIM5_IO GPIO(GPIO_PORTB, 16)
diff --git a/sysmoOCTSIM/config/hpl_gclk_config.h 
b/sysmoOCTSIM/config/hpl_gclk_config.h
index 6b7586c..8c0beee 100644
--- a/sysmoOCTSIM/config/hpl_gclk_config.h
+++ b/sysmoOCTSIM/config/hpl_gclk_config.h
@@ -454,7 +454,7 @@
 // Generic clock generator 5 division <0x-0x>
 //  gclk_gen_5_div
 #ifndef CONF_GCLK_GEN_5_DIV
-#define CONF_GCLK_GEN_5_DIV 5
+#define CONF_GCLK_GEN_5_DIV 2
 #endif
 // 
 // 
diff --git a/sysmoOCTSIM/driver_init.c b/sysmoOCTSIM/driver_init.c
index e56ba0d..ef9c56b 100644
--- a/sysmoOCTSIM/driver_init.c
+++ b/sysmoOCTSIM/driver_init.c
@@ -691,6 +691,45 @@

gpio_set_pin_function(SDA3, GPIO_PIN_FUNCTION_OFF);

+   // GPIO on PB11
+
+   gpio_set_pin_direction(RMII_CLOCK,
+  //  Pin direction
+  //  pad_direction
+  //  Off
+  //  In
+  //  Out
+  GPIO_DIRECTION_OUT);
+
+   gpio_set_pin_level(RMII_CLOCK,
+  //  Initial level
+  //  pad_initial_level
+  //  Low
+  //  High
+  false);
+
+   gpio_set_pin_function(RMII_CLOCK,
+ //  Pin function
+ //  pad_function
+ //  Auto : use driver pinmux if signal is 
imported by driver, else turn off function
+ //  Auto
+ //  Off
+ //  A
+ //  B
+ //  C
+ //  D
+ //  E
+ //  F
+ //  G
+ //  H
+ //  I
+ //  J
+ //  K
+ //  L
+ //  M
+ //  N
+ GPIO_PIN_FUNCTION_M);
+
// GPIO on PB14

gpio_set_pin_level(SCL1,

--
To view, visit https://gerrit.osmocom.org/13054
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: 

Change in osmo-ccid-firmware[master]: add debug tracing using SWO

[Kévin Redon]

Kévin Redon has uploaded this change for review. ( 
https://gerrit.osmocom.org/13055


Change subject: add debug tracing using SWO
..

add debug tracing using SWO

the UART_TX debug pin is connected to PB30, allowing to output
printf debug information using SWO and save SERCOM7 for SIM7.

SWO is configured as UART output at 921600 bps, with blocking
write.
The DEBUG flag must be set to enable output.
WARNING: SWO output is also only enabled if a SWD debugger is
attached. I did not find in the datasheets how to always have it
enabled.

Change-Id: I4c6d66e7089971294d7c006fbb600e8085e58595
---
M sysmoOCTSIM/atmel_start_config.atstart
M sysmoOCTSIM/atmel_start_pins.h
M sysmoOCTSIM/driver_init.c
M sysmoOCTSIM/gcc/Makefile
M sysmoOCTSIM/main.c
A sysmoOCTSIM/trace.c
A sysmoOCTSIM/trace.h
7 files changed, 179 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware 
refs/changes/55/13055/1

diff --git a/sysmoOCTSIM/atmel_start_config.atstart 
b/sysmoOCTSIM/atmel_start_config.atstart
index 29ec468..a5b73bd 100644
--- a/sysmoOCTSIM/atmel_start_config.atstart
+++ b/sysmoOCTSIM/atmel_start_config.atstart
@@ -1583,4 +1583,14 @@
 mode: Digital output
 user_label: SDA2
 configuration: null
+  UART_TX:
+name: PB30
+definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PB30
+mode: Advanced
+user_label: UART_TX
+configuration:
+  pad_direction: Out
+  pad_function: H
+  pad_initial_level: Low
+  pad_pull_config: 'Off'
 toolchain_options: []
diff --git a/sysmoOCTSIM/atmel_start_pins.h b/sysmoOCTSIM/atmel_start_pins.h
index 18a55fa..a2a4206 100644
--- a/sysmoOCTSIM/atmel_start_pins.h
+++ b/sysmoOCTSIM/atmel_start_pins.h
@@ -52,6 +52,7 @@
 #define SIM5_IO GPIO(GPIO_PORTB, 16)
 #define SIM3_IO GPIO(GPIO_PORTB, 20)
 #define SIM7_IO GPIO(GPIO_PORTB, 21)
+#define UART_TX GPIO(GPIO_PORTB, 30)
 #define SIM0_INT GPIO(GPIO_PORTC, 0)
 #define SIM1_INT GPIO(GPIO_PORTC, 1)
 #define SIM2_INT GPIO(GPIO_PORTC, 2)
diff --git a/sysmoOCTSIM/driver_init.c b/sysmoOCTSIM/driver_init.c
index ef9c56b..f442359 100644
--- a/sysmoOCTSIM/driver_init.c
+++ b/sysmoOCTSIM/driver_init.c
@@ -758,6 +758,53 @@

gpio_set_pin_function(SDA1, GPIO_PIN_FUNCTION_OFF);

+   // GPIO on PB30
+
+   gpio_set_pin_direction(UART_TX,
+  //  Pin direction
+  //  pad_direction
+  //  Off
+  //  In
+  //  Out
+  GPIO_DIRECTION_OUT);
+
+   gpio_set_pin_pull_mode(UART_TX,
+  //  Pull configuration
+  //  pad_pull_config
+  //  Off
+  //  Pull-up
+  //  Pull-down
+  GPIO_PULL_OFF);
+
+   gpio_set_pin_level(UART_TX,
+  //  Initial level
+  //  pad_initial_level
+  //  Low
+  //  High
+  false);
+
+   gpio_set_pin_function(UART_TX,
+ //  Pin function
+ //  pad_function
+ //  Auto : use driver pinmux if signal is 
imported by driver, else turn off function
+ //  Auto
+ //  Off
+ //  A
+ //  B
+ //  C
+ //  D
+ //  E
+ //  F
+ //  G
+ //  H
+ //  I
+ //  J
+ //  K
+ //  L
+ //  M
+ //  N
+ GPIO_PIN_FUNCTION_H);
+
// GPIO on PC00

// Set pin direction to input
diff --git a/sysmoOCTSIM/gcc/Makefile b/sysmoOCTSIM/gcc/Makefile
index 5e3c38c..e5c7306 100644
--- a/sysmoOCTSIM/gcc/Makefile
+++ b/sysmoOCTSIM/gcc/Makefile
@@ -76,6 +76,7 @@
 hpl/osc32kctrl/hpl_osc32kctrl.o \
 examples/driver_examples.o \
 driver_init.o \
+trace.o \
 hal/src/hal_usart_async.o \
 hpl/sercom/hpl_sercom.o \
 hal/utils/src/utils_ringbuffer.o \
@@ -117,6 +118,7 @@
 "hpl/osc32kctrl/hpl_osc32kctrl.o" \
 "examples/driver_examples.o" \
 "driver_init.o" \
+"trace.o" \
 "hal/src/hal_usart_async.o" \
 "hpl/sercom/hpl_sercom.o" \
 "hal/utils/src/utils_ringbuffer.o" \
@@ -155,6 +157,7 @@
 "hal/src/hal_init.d" \
 "hpl/mclk/hpl_mclk.d" \
 "driver_init.d" \
+"trace.d" \
 "hal/src/hal_usart_async.d" \
 "hpl/osc32kctrl/hpl_osc32kctrl.d" \
 "main.d" \
@@ -256,4 +259,4 @@
rm -f $(DEPS_AS_ARGS)
rm -f 

Change in osmo-ccid-firmware[master]: fix ASFv4 USB stack

[Kévin Redon]

Kévin Redon has uploaded this change for review. ( 
https://gerrit.osmocom.org/13056


Change subject: fix ASFv4 USB stack
..

fix ASFv4 USB stack

this ASFv4 USB library change fixes USB transfer.
two transfer-size issues existed:
- on multi-packet transfer if the last packet was less than the
USB transfer packet size, the packet would be received but not
acknowledged
- during normal transfer the packet size of a previous packet set
the size of the current packet, ignoring the actual transfer size

Change-Id: I4209072ee808f0e246bcd5e86917dcf1d213c26b
---
M sysmoOCTSIM/hpl/usb/hpl_usb.c
1 file changed, 1 insertion(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware 
refs/changes/56/13056/1

diff --git a/sysmoOCTSIM/hpl/usb/hpl_usb.c b/sysmoOCTSIM/hpl/usb/hpl_usb.c
index b5efe6c..eec9728 100644
--- a/sysmoOCTSIM/hpl/usb/hpl_usb.c
+++ b/sysmoOCTSIM/hpl/usb/hpl_usb.c
@@ -1135,6 +1135,7 @@
/* Short packet. */
ept->flags.bits.need_zlp = 0;
ept->trans_count += last_trans;
+   _usbd_ep_set_out_trans(epn, 0, ept->size, 0);
} else {
/* Full packets. */
ept->trans_count += trans_size;
@@ -1154,9 +1155,6 @@
if (trans_next > ept->size) {
if (trans_next > USB_D_DEV_TRANS_MAX) {
trans_next = 
USB_D_DEV_TRANS_MAX;
-   } else {
-   /* Must expect multiple of ep 
size. */
-   trans_next -= trans_next & 
size_mask;
}
} else if (trans_next < ept->size) {
/* Last un-aligned packet should be 
cached. */

--
To view, visit https://gerrit.osmocom.org/13056
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4209072ee808f0e246bcd5e86917dcf1d213c26b
Gerrit-Change-Number: 13056
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 

Change in osmo-ccid-firmware[master]: switch UART debug to SIM7

[Kévin Redon]

Kévin Redon has uploaded this change for review. ( 
https://gerrit.osmocom.org/13053


Change subject: switch UART debug to SIM7
..

switch UART debug to SIM7

SERCOM7 will mainly be used for the SIM7 interface.
only if SIM7 is not present, the UART can be remapped to
UART_debug.

Change-Id: Idfbd067b4b0e2034337732da2ff5b7cfef8fe4ae
---
M sysmoOCTSIM/atmel_start_config.atstart
M sysmoOCTSIM/atmel_start_pins.h
M sysmoOCTSIM/config/hpl_sercom_config.h
M sysmoOCTSIM/driver_init.c
M sysmoOCTSIM/driver_init.h
M sysmoOCTSIM/examples/driver_examples.c
M sysmoOCTSIM/examples/driver_examples.h
M sysmoOCTSIM/main.c
8 files changed, 149 insertions(+), 190 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware 
refs/changes/53/13053/1

diff --git a/sysmoOCTSIM/atmel_start_config.atstart 
b/sysmoOCTSIM/atmel_start_config.atstart
index a301385..4590623 100644
--- a/sysmoOCTSIM/atmel_start_config.atstart
+++ b/sysmoOCTSIM/atmel_start_config.atstart
@@ -1274,9 +1274,9 @@
 configuration:
   core_gclk_selection: Generic clock generator 2
   slow_gclk_selection: Generic clock generator 3
-  UART_debug:
-user_label: UART_debug
-definition: 
Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::SERCOM7::driver_config_definition::UART::HAL:Driver:USART.Async
+  SIM7:
+user_label: SIM7
+definition: 
Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::SERCOM7::driver_config_definition::USART.with.ISO7816::HAL:Driver:USART.Async
 functionality: USART
 api: HAL:Driver:USART_Async
 configuration:
@@ -1285,30 +1285,28 @@
   usart_arch_cloden: false
   usart_arch_dbgstop: Keep running
   usart_arch_dord: LSB is transmitted first
-  usart_arch_enc: No encoding
-  usart_arch_fractional: 0
   usart_arch_ibon: false
-  usart_arch_lin_slave_enable: Disable
   usart_arch_runstdby: false
-  usart_arch_sampa: 7-8-9 (3-4-5 8-bit over-sampling)
-  usart_arch_sampr: 16x arithmetic
   usart_arch_sfde: false
-  usart_baud_rate: 921600
+  usart_baud_rate: 9600
   usart_character_size: 8 bits
-  usart_parity: No parity
+  usart_dsnack: The successive receive NACK is disable.
+  usart_gtime: 2-bit times
+  usart_inack: NACK is transmitted when a parity error is received.
+  usart_inverse_enabled: false
+  usart_iso7816_type: T=0
+  usart_maxiter: 7
+  usart_parity: Even parity
   usart_rx_enable: true
   usart_stop_bit: One stop bit
   usart_tx_enable: true
 optional_signals: []
 variant:
-  specification: TXPO=0, RXPO=1, CMODE=0
+  specification: TXPO=2, RXPO=0
   required_signals:
   - name: SERCOM7/PAD/0
-pad: PB30
-label: TX
-  - name: SERCOM7/PAD/1
-pad: PB31
-label: RX
+pad: PB21
+label: RX/TX
 clocks:
   domain_group:
 nodes:
@@ -1503,6 +1501,12 @@
 mode: Peripheral IO
 user_label: SIM3_IO
 configuration: null
+  SIM7_IO:
+name: PB21
+definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PB21
+mode: Peripheral IO
+user_label: SIM7_IO
+configuration: null
   VB0:
 name: PA20
 definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PA20
@@ -1557,18 +1561,6 @@
 mode: Digital output
 user_label: SDA4
 configuration: null
-  UART_TX:
-name: PB30
-definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PB30
-mode: Peripheral IO
-user_label: UART_TX
-configuration: null
-  UART_RX:
-name: PB31
-definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PB31
-mode: Peripheral IO
-user_label: UART_RX
-configuration: null
   SCL2:
 name: PB02
 definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PB02
diff --git a/sysmoOCTSIM/atmel_start_pins.h b/sysmoOCTSIM/atmel_start_pins.h
index 60b70bb..c877d5e 100644
--- a/sysmoOCTSIM/atmel_start_pins.h
+++ b/sysmoOCTSIM/atmel_start_pins.h
@@ -50,8 +50,7 @@
 #define SDA1 GPIO(GPIO_PORTB, 15)
 #define SIM5_IO GPIO(GPIO_PORTB, 16)
 #define SIM3_IO GPIO(GPIO_PORTB, 20)
-#define UART_TX GPIO(GPIO_PORTB, 30)
-#define UART_RX GPIO(GPIO_PORTB, 31)
+#define SIM7_IO GPIO(GPIO_PORTB, 21)
 #define SIM0_INT GPIO(GPIO_PORTC, 0)
 #define SIM1_INT GPIO(GPIO_PORTC, 1)
 #define SIM2_INT GPIO(GPIO_PORTC, 2)
diff --git a/sysmoOCTSIM/config/hpl_sercom_config.h 
b/sysmoOCTSIM/config/hpl_sercom_config.h
index 735fdc2..64607bb 100644
--- a/sysmoOCTSIM/config/hpl_sercom_config.h
+++ b/sysmoOCTSIM/config/hpl_sercom_config.h
@@ -1931,13 +1931,11 @@
 #endif

 //  Frame parity
-// <0x0=>No parity
 // <0x1=>Even parity
-// <0x2=>Odd parity
 //  Parity bit mode for USART frame
 //  usart_parity
 #ifndef CONF_SERCOM_7_USART_PARITY
-#define CONF_SERCOM_7_USART_PARITY 0x0
+#define CONF_SERCOM_7_USART_PARITY 1
 #endif

 //  Character Size
@@ -1961,11 +1959,75 @@
 #define CONF_SERCOM_7_USART_SBMODE 0
 #endif

-//  Baud 

Change in osmo-ccid-firmware[master]: PA11: Increase drive strength to 8mA

[Kévin Redon]

Kévin Redon has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/13034 )

Change subject: PA11: Increase drive strength to 8mA
..

PA11: Increase drive strength to 8mA

It has been observed that the 20 MHz clock signal doesn't even remotely
resemble a square shape unless DRVSTR=1 is set using this patch.

Change-Id: I1366e13442eda829756aa4121be81eb15135c73e
---
M sysmoOCTSIM/main.c
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Kévin Redon: Looks good to me, approved



diff --git a/sysmoOCTSIM/main.c b/sysmoOCTSIM/main.c
index 09d766e..50e82c6 100644
--- a/sysmoOCTSIM/main.c
+++ b/sysmoOCTSIM/main.c
@@ -18,6 +18,7 @@

 #include 
 #include 
+#include 

 #include "atmel_start.h"
 #include "atmel_start_pins.h"
@@ -54,6 +55,10 @@

cache_init();
cache_enable(CMCC);
+
+   /* increase drive strength of 20Mhz SIM clock output to 8mA
+* (there are 8 inputs + traces to drive!) */
+   hri_port_set_PINCFG_DRVSTR_bit(PORT, 0, 11);
 }

 int main(void)

--
To view, visit https://gerrit.osmocom.org/13034
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1366e13442eda829756aa4121be81eb15135c73e
Gerrit-Change-Number: 13034
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Kévin Redon 

Change in osmo-ccid-firmware[master]: Enable cache via CMCC for higher performance

[Kévin Redon]

Kévin Redon has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/13033 )

Change subject: Enable cache via CMCC for higher performance
..

Enable cache via CMCC for higher performance

Change-Id: I7a243a8d964fea3d3decc6c73c16e07036e4ee93
---
M sysmoOCTSIM/main.c
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Kévin Redon: Looks good to me, approved



diff --git a/sysmoOCTSIM/main.c b/sysmoOCTSIM/main.c
index 40f2147..09d766e 100644
--- a/sysmoOCTSIM/main.c
+++ b/sysmoOCTSIM/main.c
@@ -16,6 +16,9 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, 
USA.
 */

+#include 
+#include 
+
 #include "atmel_start.h"
 #include "atmel_start_pins.h"

@@ -48,6 +51,9 @@
/* only 7 slots, as last slot is debug uart! */
for (i = 0; i < 7; i++)
ncn8025_init(i);
+
+   cache_init();
+   cache_enable(CMCC);
 }

 int main(void)

--
To view, visit https://gerrit.osmocom.org/13033
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a243a8d964fea3d3decc6c73c16e07036e4ee93
Gerrit-Change-Number: 13033
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Kévin Redon 

Change in osmo-ccid-firmware[master]: Update from AtmelStart: Define all used GPIO pins

[Kévin Redon]

Kévin Redon has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/13032 )

Change subject: Update from AtmelStart: Define all used GPIO pins
..

Update from AtmelStart: Define all used GPIO pins

Change-Id: I2cb67fd01f6e8602af16bbdb4960427586cdd9a4
---
M sysmoOCTSIM/atmel_start_config.atstart
M sysmoOCTSIM/atmel_start_pins.h
M sysmoOCTSIM/driver_init.c
3 files changed, 366 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Kévin Redon: Looks good to me, approved



diff --git a/sysmoOCTSIM/atmel_start_config.atstart 
b/sysmoOCTSIM/atmel_start_config.atstart
index 58f05f6..a301385 100644
--- a/sysmoOCTSIM/atmel_start_config.atstart
+++ b/sysmoOCTSIM/atmel_start_config.atstart
@@ -1367,6 +1367,66 @@
 configuration:
   usb_gclk_selection: Generic clock generator 1
 pads:
+  SIM0_INT:
+name: PC00
+definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PC00
+mode: Digital input
+user_label: SIM0_INT
+configuration: null
+  SIM1_INT:
+name: PC01
+definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PC01
+mode: Digital input
+user_label: SIM1_INT
+configuration: null
+  SIM2_INT:
+name: PC02
+definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PC02
+mode: Digital input
+user_label: SIM2_INT
+configuration: null
+  SIM3_INT:
+name: PC03
+definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PC03
+mode: Digital input
+user_label: SIM3_INT
+configuration: null
+  SIM4_INT:
+name: PA02
+definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PA02
+mode: Digital input
+user_label: SIM4_INT
+configuration: null
+  SIM5_INT:
+name: PA03
+definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PA03
+mode: Digital input
+user_label: SIM5_INT
+configuration: null
+  SIM6_INT:
+name: PB04
+definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PB04
+mode: Digital input
+user_label: SIM6_INT
+configuration: null
+  SIM7_INT:
+name: PB05
+definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PB05
+mode: Digital input
+user_label: SIM7_INT
+configuration: null
+  SCL3:
+name: PB06
+definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PB06
+mode: Digital output
+user_label: SCL3
+configuration: null
+  SDA3:
+name: PB07
+definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PB07
+mode: Digital output
+user_label: SDA3
+configuration: null
   SIM4_IO:
 name: PB08
 definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PB08
@@ -1395,12 +1455,30 @@
   pad_function: M
   pad_initial_level: Low
   pad_pull_config: 'Off'
+  SCL1:
+name: PB14
+definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PB14
+mode: Digital output
+user_label: SCL1
+configuration: null
+  SDA1:
+name: PB15
+definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PB15
+mode: Digital output
+user_label: SDA1
+configuration: null
   SWITCH:
 name: PC14
 definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PC14
 mode: Digital input
 user_label: SWITCH
 configuration: null
+  MUX_SSTAT:
+name: PC15
+definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PC15
+mode: Digital input
+user_label: MUX_SSTAT
+configuration: null
   SIM1_IO:
 name: PA16
 definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PA16
@@ -1467,6 +1545,18 @@
 mode: Digital output
 user_label: USER_LED
 configuration: null
+  SCL4:
+name: PC27
+definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PC27
+mode: Digital output
+user_label: SCL4
+configuration: null
+  SDA4:
+name: PC28
+definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PC28
+mode: Digital output
+user_label: SDA4
+configuration: null
   UART_TX:
 name: PB30
 definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PB30
@@ -1479,4 +1569,16 @@
 mode: Peripheral IO
 user_label: UART_RX
 configuration: null
+  SCL2:
+name: PB02
+definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PB02
+mode: Digital output
+user_label: SCL2
+configuration: null
+  SDA2:
+name: PB03
+definition: Atmel:SAME54_Drivers:0.0.1::SAME54N19A-AF::pad::PB03
+mode: Digital output
+user_label: SDA2
+configuration: null
 toolchain_options: []
diff --git a/sysmoOCTSIM/atmel_start_pins.h b/sysmoOCTSIM/atmel_start_pins.h
index ad5f27b..60b70bb 100644
--- a/sysmoOCTSIM/atmel_start_pins.h
+++ b/sysmoOCTSIM/atmel_start_pins.h
@@ -27,6 +27,8 @@
 #define GPIO_PIN_FUNCTION_M 12
 #define GPIO_PIN_FUNCTION_N 13

+#define SIM4_INT GPIO(GPIO_PORTA, 2)
+#define SIM5_INT GPIO(GPIO_PORTA, 3)
 #define SIM0_IO GPIO(GPIO_PORTA, 4)
 

Change in osmo-ccid-firmware[master]: update from Atmel Start (just loading + re-exporting the project)

[Kévin Redon]

Kévin Redon has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/13031 )

Change subject: update from Atmel Start (just loading + re-exporting the 
project)
..

update from Atmel Start (just loading + re-exporting the project)

Change-Id: I59b2442a95871b8052bfdfdac6d77a7207d8b70a
---
M sysmoOCTSIM/AtmelStart.gpdsc
M sysmoOCTSIM/atmel_start_config.atstart
M sysmoOCTSIM/hal/include/hpl_spi_m_async.h
M sysmoOCTSIM/hal/include/hpl_spi_m_dma.h
M sysmoOCTSIM/hal/include/hpl_spi_m_sync.h
M sysmoOCTSIM/hal/include/hpl_spi_s_async.h
M sysmoOCTSIM/hal/include/hpl_spi_s_sync.h
7 files changed, 73 insertions(+), 12 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Kévin Redon: Looks good to me, approved



diff --git a/sysmoOCTSIM/AtmelStart.gpdsc b/sysmoOCTSIM/AtmelStart.gpdsc
index 51851db..6546fb5 100644
--- a/sysmoOCTSIM/AtmelStart.gpdsc
+++ b/sysmoOCTSIM/AtmelStart.gpdsc
@@ -67,11 +67,6 @@
 
 
 
-
-
-
-
-
 
 
 
@@ -169,6 +164,11 @@
 
 
 
+
+
+
+
+
 
 
 
diff --git a/sysmoOCTSIM/atmel_start_config.atstart 
b/sysmoOCTSIM/atmel_start_config.atstart
index 975423d..58f05f6 100644
--- a/sysmoOCTSIM/atmel_start_config.atstart
+++ b/sysmoOCTSIM/atmel_start_config.atstart
@@ -2,12 +2,12 @@
 name: sysmoOCTSIM
 versions:
   api: '1.0'
-  backend: 1.4.93
-  commit: 9c29f8365cf76e9937d19b1e765a83bc7a80e4e9
-  content: 1.0.1340
+  backend: 1.5.122
+  commit: 820baecf7dd115d94b0d42ee3b0b9d6ba2da7113
+  content: 1.0.1405
   content_pack_name: acme-packs-all
   format: '2'
-  frontend: 1.4.1810
+  frontend: 1.5.1826
 board:
   identifier: CustomBoard
   device: SAME54N19A-AF
@@ -773,6 +773,8 @@
 nodes:
 - name: CPU
   input: CPU
+  external: false
+  external_frequency: 0
 configuration: {}
   OSC32KCTRL:
 user_label: OSC32KCTRL
@@ -981,8 +983,12 @@
 nodes:
 - name: Core
   input: Generic clock generator 2
+  external: false
+  external_frequency: 0
 - name: Slow
   input: Generic clock generator 3
+  external: false
+  external_frequency: 0
 configuration:
   core_gclk_selection: Generic clock generator 2
   slow_gclk_selection: Generic clock generator 3
@@ -1024,8 +1030,12 @@
 nodes:
 - name: Core
   input: Generic clock generator 2
+  external: false
+  external_frequency: 0
 - name: Slow
   input: Generic clock generator 3
+  external: false
+  external_frequency: 0
 configuration:
   core_gclk_selection: Generic clock generator 2
   slow_gclk_selection: Generic clock generator 3
@@ -1067,8 +1077,12 @@
 nodes:
 - name: Core
   input: Generic clock generator 2
+  external: false
+  external_frequency: 0
 - name: Slow
   input: Generic clock generator 3
+  external: false
+  external_frequency: 0
 configuration:
   core_gclk_selection: Generic clock generator 2
   slow_gclk_selection: Generic clock generator 3
@@ -1110,8 +1124,12 @@
 nodes:
 - name: Core
   input: Generic clock generator 2
+  external: false
+  external_frequency: 0
 - name: Slow
   input: Generic clock generator 3
+  external: false
+  external_frequency: 0
 configuration:
   core_gclk_selection: Generic clock generator 2
   slow_gclk_selection: Generic clock generator 3
@@ -1153,8 +1171,12 @@
 nodes:
 - name: Core
   input: Generic clock generator 2
+  external: false
+  external_frequency: 0
 - name: Slow
   input: Generic clock generator 3
+  external: false
+  external_frequency: 0
 configuration:
   core_gclk_selection: Generic clock generator 2
   slow_gclk_selection: Generic clock generator 3
@@ -1196,8 +1218,12 @@
 nodes:
 - name: Core
   input: Generic clock generator 2
+  external: false
+  external_frequency: 0
 - name: Slow
   input: Generic clock generator 3
+  external: false
+  external_frequency: 0
 configuration:
   core_gclk_selection: Generic clock generator 2
   slow_gclk_selection: Generic clock generator 3
@@ -1239,8 +1265,12 @@
 nodes:
 - name: Core
   input: Generic clock generator 2
+  external: false
+  external_frequency: 0
 - name: Slow
   input: Generic clock generator 3
+  external: false
+  external_frequency: 0
 configuration:
   core_gclk_selection: Generic 

Change in osmo-ccid-firmware[master]: ncn8025: Add support for reading SIMx_INT status

[Kévin Redon]

Kévin Redon has posted comments on this change. ( 
https://gerrit.osmocom.org/13038 )

Change subject: ncn8025: Add support for reading SIMx_INT status
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/13038
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab9edc1214bb22ee304daa834fd9e2376d42c97c
Gerrit-Change-Number: 13038
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Kévin Redon 
Gerrit-Comment-Date: Tue, 26 Feb 2019 18:12:44 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ccid-firmware[master]: PA11: Increase drive strength to 8mA

[Kévin Redon]

Kévin Redon has posted comments on this change. ( 
https://gerrit.osmocom.org/13034 )

Change subject: PA11: Increase drive strength to 8mA
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/13034
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1366e13442eda829756aa4121be81eb15135c73e
Gerrit-Change-Number: 13034
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Kévin Redon 
Gerrit-Comment-Date: Tue, 26 Feb 2019 18:08:21 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ccid-firmware[master]: Update from AtmelStart: Define all used GPIO pins

[Kévin Redon]

Kévin Redon has posted comments on this change. ( 
https://gerrit.osmocom.org/13032 )

Change subject: Update from AtmelStart: Define all used GPIO pins
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/13032
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cb67fd01f6e8602af16bbdb4960427586cdd9a4
Gerrit-Change-Number: 13032
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Kévin Redon 
Gerrit-Comment-Date: Tue, 26 Feb 2019 17:48:35 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ccid-firmware[master]: Support for sysmoOCTSIM NCN8025/SX1503 control

[Kévin Redon]

Kévin Redon has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/13030 )

Change subject: Support for sysmoOCTSIM NCN8025/SX1503 control
..

Support for sysmoOCTSIM NCN8025/SX1503 control

This adds an I2C bit-banging layer, defines the four busses on the
sysmoOCTSIM and adds some high-level functions to control the NCN8025
for each SIM slot.

Change-Id: Ic5287cf80d2be2070c504e9d40f7c6fc0d37d8b9
---
M sysmoOCTSIM/gcc/Makefile
A sysmoOCTSIM/i2c_bitbang.c
A sysmoOCTSIM/i2c_bitbang.h
M sysmoOCTSIM/main.c
A sysmoOCTSIM/ncn8025.c
A sysmoOCTSIM/ncn8025.h
A sysmoOCTSIM/octsim_i2c.c
A sysmoOCTSIM/octsim_i2c.h
8 files changed, 440 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Kévin Redon: Looks good to me, approved



diff --git a/sysmoOCTSIM/gcc/Makefile b/sysmoOCTSIM/gcc/Makefile
index 572fb21..5e3c38c 100644
--- a/sysmoOCTSIM/gcc/Makefile
+++ b/sysmoOCTSIM/gcc/Makefile
@@ -70,6 +70,9 @@
 gcc/gcc/startup_same54.o \
 hal/src/hal_usb_device.o \
 main.o \
+i2c_bitbang.o \
+octsim_i2c.o \
+ncn8025.o \
 hpl/osc32kctrl/hpl_osc32kctrl.o \
 examples/driver_examples.o \
 driver_init.o \
@@ -108,6 +111,9 @@
 "gcc/gcc/startup_same54.o" \
 "hal/src/hal_usb_device.o" \
 "main.o" \
+"i2c_bitbang.o" \
+"octsim_i2c.o" \
+"ncn8025.o" \
 "hpl/osc32kctrl/hpl_osc32kctrl.o" \
 "examples/driver_examples.o" \
 "driver_init.o" \
@@ -152,6 +158,9 @@
 "hal/src/hal_usart_async.d" \
 "hpl/osc32kctrl/hpl_osc32kctrl.d" \
 "main.d" \
+"i2c_bitbang.d" \
+"octsim_i2c.d" \
+"ncn8025.d" \
 "examples/driver_examples.d" \
 "hal/src/hal_cache.d" \
 "hal/src/hal_sleep.d" \
diff --git a/sysmoOCTSIM/i2c_bitbang.c b/sysmoOCTSIM/i2c_bitbang.c
new file mode 100644
index 000..b1a9a62
--- /dev/null
+++ b/sysmoOCTSIM/i2c_bitbang.c
@@ -0,0 +1,189 @@
+/* Bit-banging I2C layer, inspired to a large extent from Linux kernel
+ * i2c-algo-bit.c code (C) 1995-2000 Simon G. Vogl.  This particular
+ * implementation is (C) 2019 by Harald Welte 
+ *
+ *  SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+#include 
+#include 
+#include 
+#include "i2c_bitbang.h"
+
+#define setsda(adap, val)  gpio_set_pin_level((adap)->pin_sda, val)
+#define setscl(adap, val)  gpio_set_pin_level((adap)->pin_scl, val)
+
+static int getsda(const struct i2c_adapter *adap)
+{
+   int rc;
+   gpio_set_pin_direction(adap->pin_sda, GPIO_DIRECTION_IN);
+   rc = gpio_get_pin_level(adap->pin_sda);
+   gpio_set_pin_direction(adap->pin_sda, GPIO_DIRECTION_OUT);
+   return rc;
+}
+
+static int getscl(const struct i2c_adapter *adap)
+{
+   int rc;
+   gpio_set_pin_direction(adap->pin_scl, GPIO_DIRECTION_IN);
+   rc = gpio_get_pin_level(adap->pin_scl);
+   gpio_set_pin_direction(adap->pin_scl, GPIO_DIRECTION_OUT);
+   return rc;
+}
+
+static inline void sdalo(const struct i2c_adapter *adap)
+{
+   setsda(adap, 0);
+   delay_us((adap->udelay+1) / 2);
+}
+
+static inline void sdahi(const struct i2c_adapter *adap)
+{
+   setsda(adap, 1);
+   delay_us((adap->udelay+1) / 2);
+}
+
+static inline void scllo(const struct i2c_adapter *adap)
+{
+   setscl(adap, 0);
+   delay_us(adap->udelay / 2);
+}
+
+
+static int sclhi(const struct i2c_adapter *adap)
+{
+   setscl(adap, 1);
+
+   /* wait for slow slaves' clock stretching to complete */
+   while (!getscl(adap)) {
+   /* FIXME: abort at some point */
+   }
+   return 0;
+}
+
+static void i2c_start(const struct i2c_adapter *adap)
+{
+   /* Assert: SCL + SDA are high */
+   setsda(adap, 0);/* set SDA to low */
+   delay_us(adap->udelay); /* delay */
+   scllo(adap);/* Set SCL to low */
+}
+
+static void i2c_repstart(const struct i2c_adapter *adap)
+{
+   /* Assert: SCL is low */
+   sdahi(adap);
+   sclhi(adap);
+   setsda(adap, 0);
+   delay_us(adap->udelay);
+   scllo(adap);
+}
+
+static void i2c_stop(const struct i2c_adapter *adap)
+{
+   /* Assert: SCL is low */
+   sdalo(adap);/* set SDA low */
+   sclhi(adap);/* set SCL to high */
+   setsda(adap, 1);/* set SDA to high */
+   delay_us(adap->udelay); /* delay */
+}
+
+static int i2c_outb(const struct i2c_adapter *adap, uint8_t outdata)
+{
+   uint8_t sb;
+   int ack, i;
+
+   /* Assert: SCL is low */
+   for (i = 7; i >= 0; i--) {
+   sb = (outdata >> i) & 1;
+   setsda(adap, sb);
+   delay_us((adap->udelay + 1) / 2);
+   if (sclhi(adap) < 0)
+   return -ERR_TIMEOUT;
+   scllo(adap);
+   }
+   sdahi(adap);
+   if (sclhi(adap) < 0)
+   return -ERR_TIMEOUT;
+   ack = !getsda(adap);
+   scllo(adap);
+   return ack;
+}
+
+static int i2c_inb(const struct i2c_adapter *adap)
+{
+   uint8_t indata = 

Change in osmo-ccid-firmware[master]: Support for sysmoOCTSIM NCN8025/SX1503 control

[Kévin Redon]

Kévin Redon has posted comments on this change. ( 
https://gerrit.osmocom.org/13030 )

Change subject: Support for sysmoOCTSIM NCN8025/SX1503 control
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/13030
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5287cf80d2be2070c504e9d40f7c6fc0d37d8b9
Gerrit-Change-Number: 13030
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Kévin Redon 
Gerrit-Comment-Date: Tue, 26 Feb 2019 17:27:22 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ccid-firmware[master]: Enable cache via CMCC for higher performance

[Kévin Redon]

Kévin Redon has posted comments on this change. ( 
https://gerrit.osmocom.org/13033 )

Change subject: Enable cache via CMCC for higher performance
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/13033
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a243a8d964fea3d3decc6c73c16e07036e4ee93
Gerrit-Change-Number: 13033
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Kévin Redon 
Gerrit-Comment-Date: Tue, 26 Feb 2019 16:50:20 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ccid-firmware[master]: update from Atmel Start (just loading + re-exporting the project)

[Kévin Redon]

Kévin Redon has posted comments on this change. ( 
https://gerrit.osmocom.org/13031 )

Change subject: update from Atmel Start (just loading + re-exporting the 
project)
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/13031
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59b2442a95871b8052bfdfdac6d77a7207d8b70a
Gerrit-Change-Number: 13031
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Kévin Redon 
Gerrit-Comment-Date: Tue, 26 Feb 2019 16:49:36 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-hlr[master]: hlr.c: move hlr_ctx to the top

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/13050 )

Change subject: hlr.c: move hlr_ctx to the top
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/13050
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5edf0a233ff323a63e321a1ca47736b5b212d1bb
Gerrit-Change-Number: 13050
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Daniel Willmann 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 26 Feb 2019 16:49:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-pcu[master]: EDGE tests: remove no-op check

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/13052


Change subject: EDGE tests: remove no-op check
..

EDGE tests: remove no-op check

The headerTypeControl() function always return constant and is only used
inside OSMO_ASSERT() which compares it to the very same constant which
makes it no-op. Let's remove this clutter.

Change-Id: Ie0f81fe05a2b3f432de7d1f3446e8115d7524ff4
---
M src/gprs_coding_scheme.h
M tests/edge/EdgeTest.cpp
2 files changed, 0 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/52/13052/1

diff --git a/src/gprs_coding_scheme.h b/src/gprs_coding_scheme.h
index 76cab0f..62cbb85 100644
--- a/src/gprs_coding_scheme.h
+++ b/src/gprs_coding_scheme.h
@@ -107,7 +107,6 @@
uint8_t optionalPaddingBits() const;
const char *name() const;
HeaderType headerTypeData() const;
-   HeaderType headerTypeControl() const;
Family family() const;

static GprsCodingScheme getBySizeUL(unsigned size);
@@ -154,11 +153,6 @@
return (isGprs() && o.isGprs()) || (isEgprs() && o.isEgprs());
 }

-inline GprsCodingScheme::HeaderType GprsCodingScheme::headerTypeControl() const
-{
-   return HEADER_GPRS_CONTROL;
-}
-
 inline GprsCodingScheme::GprsCodingScheme(Scheme s)
: m_scheme(s)
 {
diff --git a/tests/edge/EdgeTest.cpp b/tests/edge/EdgeTest.cpp
index 6ce2334..0cb123e 100644
--- a/tests/edge/EdgeTest.cpp
+++ b/tests/edge/EdgeTest.cpp
@@ -170,8 +170,6 @@
/* Check header types */
OSMO_ASSERT(current_cs.headerTypeData() ==
GprsCodingScheme::HEADER_GPRS_DATA);
-   OSMO_ASSERT(current_cs.headerTypeControl() ==
-   GprsCodingScheme::HEADER_GPRS_CONTROL);

check_coding_scheme(current_cs, GprsCodingScheme::GPRS);
}

--
To view, visit https://gerrit.osmocom.org/13052
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0f81fe05a2b3f432de7d1f3446e8115d7524ff4
Gerrit-Change-Number: 13052
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in osmo-pcu[master]: EDGE tests: reduce code duplication

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/13051


Change subject: EDGE tests: reduce code duplication
..

EDGE tests: reduce code duplication

* move duplicated code into helper function
* use proper parameter types

Change-Id: I8a9528032629e5df629996da5cd8b808efede017
---
M tests/edge/EdgeTest.cpp
1 file changed, 15 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/51/13051/1

diff --git a/tests/edge/EdgeTest.cpp b/tests/edge/EdgeTest.cpp
index 98ca206..6ce2334 100644
--- a/tests/edge/EdgeTest.cpp
+++ b/tests/edge/EdgeTest.cpp
@@ -105,11 +105,22 @@

 }

+static bool check_strong_monotonicity(const GprsCodingScheme *cs, uint8_t 
last_UL, uint8_t last_DL)
+{
+   if (cs->maxBytesUL() <= last_UL)
+   return false;
+
+   if (cs->maxBytesDL() <= last_DL)
+   return false;
+
+   return true;
+}
+
 static void test_coding_scheme()
 {
unsigned i;
-   unsigned last_size_UL;
-   unsigned last_size_DL;
+   uint8_t last_size_UL;
+   uint8_t last_size_DL;
GprsCodingScheme::Scheme gprs_schemes[] = {
GprsCodingScheme::CS1,
GprsCodingScheme::CS2,
@@ -152,9 +163,7 @@
OSMO_ASSERT(GprsCodingScheme::Scheme(current_cs) == 
gprs_schemes[i]);
OSMO_ASSERT(current_cs == GprsCodingScheme(gprs_schemes[i]));

-   /* Check strong monotonicity */
-   OSMO_ASSERT(current_cs.maxBytesUL() > last_size_UL);
-   OSMO_ASSERT(current_cs.maxBytesDL() > last_size_DL);
+   OSMO_ASSERT(check_strong_monotonicity(_cs, 
last_size_UL, last_size_DL));
last_size_UL = current_cs.maxBytesUL();
last_size_DL = current_cs.maxBytesDL();

@@ -179,9 +188,7 @@
OSMO_ASSERT(GprsCodingScheme::Scheme(current_cs) == 
egprs_schemes[i].s);
OSMO_ASSERT(current_cs == GprsCodingScheme(egprs_schemes[i].s));

-   /* Check strong monotonicity */
-   OSMO_ASSERT(current_cs.maxBytesUL() > last_size_UL);
-   OSMO_ASSERT(current_cs.maxBytesDL() > last_size_DL);
+   OSMO_ASSERT(check_strong_monotonicity(_cs, 
last_size_UL, last_size_DL));
last_size_UL = current_cs.maxBytesUL();
last_size_DL = current_cs.maxBytesDL();


--
To view, visit https://gerrit.osmocom.org/13051
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a9528032629e5df629996da5cd8b808efede017
Gerrit-Change-Number: 13051
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #9062

[jenkins]

See 


--
[...truncated 1.24 MB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Build failed in Jenkins: master-osmo-sgsn » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #9062

[jenkins]

See 


--
[...truncated 412.72 KB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #9061

[jenkins]

See 


--
[...truncated 1.24 MB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Build failed in Jenkins: master-osmo-sgsn » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #9061

[jenkins]

See 


--
[...truncated 411.70 KB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Build failed in Jenkins: master-osmo-sgsn » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #9060

[jenkins]

See 


--
[...truncated 411.51 KB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #9060

[jenkins]

See 


--
[...truncated 1.24 MB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Change in osmo-hlr[master]: hlr.c: move hlr_ctx to the top

[osmith]

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13050


Change subject: hlr.c: move hlr_ctx to the top
..

hlr.c: move hlr_ctx to the top

Allow all functions to use hlr_ctx, so it can be used by the upcoming
read_cb_forward() function in [1]. That new function is placed next to
the existing read_cb() function, which is above the current hlr_ctx
declaration.

[1]: Change-Id: Ia4f345abc877baaf0a8f73b8988e6514d9589bf5

Related: OS#3793
Change-Id: I5edf0a233ff323a63e321a1ca47736b5b212d1bb
---
M src/hlr.c
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/50/13050/1

diff --git a/src/hlr.c b/src/hlr.c
index c544310..f374ccc 100644
--- a/src/hlr.c
+++ b/src/hlr.c
@@ -47,6 +47,7 @@
 #include "hlr_ussd.h"

 struct hlr *g_hlr;
+static void *hlr_ctx = NULL;
 static int quit = 0;

 /* Trigger 'Insert Subscriber Data' messages to all connected GSUP clients.
@@ -608,8 +609,6 @@
}
 }

-static void *hlr_ctx = NULL;
-
 static void signal_hdlr(int signal)
 {
switch (signal) {

--
To view, visit https://gerrit.osmocom.org/13050
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5edf0a233ff323a63e321a1ca47736b5b212d1bb
Gerrit-Change-Number: 13050
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #413

[jenkins]

See 


--
[...truncated 3.76 KB...]
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking 

Change in libosmo-netif[master]: amr: add functions to convert between bw-efficient and octet-aligned

[dexter]

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13049


Change subject: amr: add functions to convert between bw-efficient and 
octet-aligned
..

amr: add functions to convert between bw-efficient and octet-aligned

RFC 3267 describes two different AMR frame formats. Octet Aligned and
Bandwidth efficient mode. In Bandwith efficient mode the padding bits,
which are used to align CMR, TOC and payload on octet boundaries are
saved and the fielda are packed directly one after another.

- Add functions to convert from one mode to the other and vice versa.
- Add function to detect in which mode an AMR frame is encoded.

Change-Id: I5b5a0fa644d8dbb1f04f9d7e35312683c7b3d196
Related: SYS#4470
---
M include/osmocom/netif/amr.h
M src/amr.c
M tests/Makefile.am
A tests/amr/amr_test.c
A tests/amr/amr_test.ok
M tests/testsuite.at
6 files changed, 492 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/49/13049/1

diff --git a/include/osmocom/netif/amr.h b/include/osmocom/netif/amr.h
index b0ab8a3..1384701 100644
--- a/include/osmocom/netif/amr.h
+++ b/include/osmocom/netif/amr.h
@@ -83,4 +83,8 @@
 int osmo_amr_ft_valid(uint8_t amr_ft);
 size_t osmo_amr_bytes(uint8_t amr_cmr);

+bool osmo_amr_is_oa(uint8_t *frame, unsigned int frame_len);
+int osmo_amr_oa_to_bwe(uint8_t *frame, unsigned int frame_len);
+int osmo_amr_bwe_to_oa(uint8_t *frame, unsigned int frame_len);
+
 #endif
diff --git a/src/amr.c b/src/amr.c
index 6f94a69..ec28a22 100644
--- a/src/amr.c
+++ b/src/amr.c
@@ -11,7 +11,9 @@
  */

 #include 
+#include 
 #include 
+#include 
 #include 

 /* According to TS 26.101:
@@ -62,3 +64,77 @@

return 1;
 }
+
+/* Check if an AMR frame is octet aligned by looking at the padding bits */
+bool osmo_amr_is_oa(uint8_t *frame, unsigned int frame_len)
+{
+   struct amr_hdr *oc_hdr = (struct amr_hdr *)frame;
+
+   /* Broken frame? */
+   if (!frame || frame_len < 2)
+   return false;
+
+   /* In octet aligned mode, padding bits are specified to be
+* set to zero. */
+   if (oc_hdr->pad1 != 0)
+   return false;
+   if (oc_hdr->pad2 != 0)
+   return false;
+
+   return true;
+}
+
+/* Convert an AMR frame from octet-aligned mode to bandwith-efficient mode */
+int osmo_amr_oa_to_bwe(uint8_t *frame, unsigned int frame_len)
+{
+   struct amr_hdr *oc_hdr = (struct amr_hdr *)frame;
+   unsigned int payload_len = frame_len - 2;
+   unsigned int i;
+
+   /* Be sure that we operate on an octet aligned frame. */
+   if (osmo_amr_is_oa(frame, frame_len) == false)
+   return -1;
+
+   /* This implementation is currently not capable to handle multi-payload
+* frames, so we need to make sure that the frame we operate on
+* contains only one payload */
+   if (oc_hdr->f != 0)
+   return -1;
+
+   /* Move TOC close to CMR */
+   frame[0] |= (frame[1] >> 4) & 0x0f;
+   frame[1] = (frame[1] << 4) & 0xf0;
+
+   for (i = 0; i < payload_len; i++) {
+   frame[i + 1] |= frame[i + 2] >> 2;
+   frame[i + 2] = frame[i + 2] << 6;
+   }
+
+   /* The overall saving is one byte! */
+   return frame_len - 1;
+}
+
+/* Convert an AMR frame from bandwith-efficient to octet-aligned mode mode */
+int osmo_amr_bwe_to_oa(uint8_t *frame, unsigned int frame_len)
+{
+   uint8_t buf[256];
+   unsigned int payload_len = frame_len - 1;
+   unsigned int i;
+
+   memset(buf, 0, sizeof(buf));
+
+   if (frame_len > sizeof(buf))
+   return -1;
+
+   buf[0] = frame[0] & 0xf0;
+   buf[1] = frame[0] << 4;
+   buf[1] |= (frame[1] >> 4) & 0x0c;
+
+   for (i = 0; i < payload_len; i++) {
+   buf[i + 2] = frame[i + 1] << 2;
+   buf[i + 2] |= frame[i + 2] >> 6;
+   }
+
+   memcpy(frame, buf, frame_len + 1);
+   return frame_len + 1;
+}
diff --git a/tests/Makefile.am b/tests/Makefile.am
index c3628ac..36447be 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -1,7 +1,7 @@
 AM_CFLAGS = -Wall -I$(top_srcdir)/include $(LIBOSMOCORE_CFLAGS) -g
 AM_LDFLAGS = $(LIBOSMOCORE_LDFLAGS)

-check_PROGRAMS = osmux/osmux_test osmux/osmux_test2 stream/stream_test 
jibuf/jibuf_test
+check_PROGRAMS = osmux/osmux_test osmux/osmux_test2 stream/stream_test 
jibuf/jibuf_test amr/amr_test
 check_HEADERS =

 osmux_osmux_test_SOURCES = osmux/osmux_test.c
@@ -17,6 +17,9 @@
 jibuf_jibuf_test_SOURCES = jibuf/jibuf_test.c
 jibuf_jibuf_test_LDADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) 
$(top_builddir)/src/libosmonetif.la

+amr_amr_test_SOURCES = amr/amr_test.c
+amr_amr_test_LDADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) 
$(top_builddir)/src/libosmonetif.la
+
 if HAVE_PCAP
 check_PROGRAMS += jibuf/jibuf_tool
 check_HEADERS += \
@@ -63,7 +66,9 @@
 osmux/osmux_test2.ok \
  

Change in osmo-hlr[master]: gsup_router.c: gsup_route_find(): support blob

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/13048 )

Change subject: gsup_router.c: gsup_route_find(): support blob
..


Patch Set 1:

(3 comments)

I was the one to send you on this journey, and I appreciate this solution.

My conclusion however from what you found is that we currently don't support 
BLOB addresses properly, especially since you told me that some places store 
the address as a nul-terminated string pointer without length.

If we want true BLOB support at some point in the future, nipping off the last 
byte is a new future quirk. Say we fixed all other places, then we might still 
need to keep this for legacy compat ...

I am not fully decided which way to go, but I lean towards: now always send the 
terminating nul from GSUP clients as contained in destination addresses 
(counted in the addr_len), i.e. we contain the nul in the BLOB, but the code 
should ignore that fact as much as currently possible -- towards a future where 
no code depends on the nul.

If we end up accepting this patch instead, then the following review applies...

https://gerrit.osmocom.org/#/c/13048/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/13048/1//COMMIT_MSG@15
PS1, Line 15: destination name blobs to gsup_route_find().
add "from incoming GSUP messages' destination_name IEs"


https://gerrit.osmocom.org/#/c/13048/1/src/gsup_router.c
File src/gsup_router.c:

https://gerrit.osmocom.org/#/c/13048/1/src/gsup_router.c@42
PS1, Line 42:   llist_for_each_entry(gr, >routes, list) {
An elaborate comment here would be nice, maybe

   /* gr->addr should be treated as a BLOB, yet for historical reasons may be 
assumed to be a nul-terminated
  string where the nul is not considered part of the address, especially in 
incoming GSUP messages.
  Hence, for incoming addr that are not nul-terminated, also compare 
without the nul. */


https://gerrit.osmocom.org/#/c/13048/1/src/gsup_router.c@50
PS1, Line 50:   if (gr_addrlen - 1 == addrlen && !memcmp(gr->addr, 
addr, addrlen))
&& addr[addrlen - 1] != '\0' && gr-addr[gr_addrlen - 1] == '\0'



--
To view, visit https://gerrit.osmocom.org/13048
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01a45900e14d41bcd338f50ad85d9fabf2c61405
Gerrit-Change-Number: 13048
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Tue, 26 Feb 2019 13:43:58 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-pcu[master]: Optionally Use the NS Sub-Network-Service (SNS) on Gb

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/13025 )

Change subject: Optionally Use the NS Sub-Network-Service (SNS) on Gb
..

Optionally Use the NS Sub-Network-Service (SNS) on Gb

This change add support for the recently-introduced GPRS Gb interface
auto-configuration using the NS IP Sub-Network Service (SNS) procedures.

It requires a Change-Id I84786c3b43a8ae34ef3b3ba84b33c90042d234ea of
libosmocore.

Related: OS#3372
Depends: I84786c3b43a8ae34ef3b3ba84b33c90042d234ea (libosmcore)
Change-Id: I256b40ac592d3b6e75dd581bf7b9512f69b11e83
---
M src/bts.h
M src/gprs_bssgp_pcu.cpp
M src/pcu_vty.c
3 files changed, 50 insertions(+), 7 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/bts.h b/src/bts.h
index 51760e2..578cece 100644
--- a/src/bts.h
+++ b/src/bts.h
@@ -159,6 +159,9 @@

/* Path to be used for the pcu-bts socket */
char *pcu_sock_path;
+
+   /* Are we talking Gb with IP-SNS (true) or classic Gb? */
+   bool gb_dialect_sns;
 };

 #ifdef __cplusplus
diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp
index 8bf6b7f..f63fac3 100644
--- a/src/gprs_bssgp_pcu.cpp
+++ b/src/gprs_bssgp_pcu.cpp
@@ -541,12 +541,20 @@
return -EINVAL;

nssd = (struct ns_signal_data *)signal_data;
-   if (nssd->nsvc != the_pcu.nsvc) {
+   if (signal != S_SNS_CONFIGURED &&  nssd->nsvc != the_pcu.nsvc) {
LOGP(DPCU, LOGL_ERROR, "Signal received of unknown NSVC\n");
return -EINVAL;
}

switch (signal) {
+   case S_SNS_CONFIGURED:
+   the_pcu.bvc_sig_reset = 0;
+   the_pcu.bvc_reset = 0;
+   /* There's no NS-RESET / NS-UNBLOCK procedure on IP SNS based 
NS-VCs */
+   the_pcu.nsvc_unblocked = 1;
+   LOGP(DPCU, LOGL_NOTICE, "NS-VC %d is unblocked.\n", 
the_pcu.nsvc->nsvci);
+   bvc_timeout(NULL);
+   break;
case S_NS_UNBLOCK:
if (!the_pcu.nsvc_unblocked) {
the_pcu.nsvc_unblocked = 1;
@@ -872,9 +880,10 @@
return -EBADF;
}

-   nsvc2 = gprs_ns_nsip_connect(bssgp_nsi, >ip.bts_addr,
-   nsvc->nsei, nsvc->nsvci);
-
+   if (the_pcu.bts->gb_dialect_sns)
+   nsvc2 = gprs_ns_nsip_connect_sns(bssgp_nsi, >ip.bts_addr, 
nsvc->nsei, nsvc->nsvci);
+   else
+   nsvc2 = gprs_ns_nsip_connect(bssgp_nsi, >ip.bts_addr, 
nsvc->nsei, nsvc->nsvci);
if (!nsvc2) {
LOGP(DBSSGP, LOGL_ERROR, "Failed to reconnect NSVC\n");
return -EIO;
@@ -905,8 +914,13 @@
return NULL;
}
gprs_ns_vty_init(bssgp_nsi);
-   bssgp_nsi->nsip.remote_port = sgsn_port;
-   bssgp_nsi->nsip.remote_ip = sgsn_ip;
+   /* don't specify remote IP/port if SNS dialect is in use; Doing so would
+* issue a connect() on the socket, which prevents us to dynamically 
communicate
+* with any number of IP-SNS endpoints on the SGSN side */
+   if (!bts->gb_dialect_sns) {
+   bssgp_nsi->nsip.remote_port = sgsn_port;
+   bssgp_nsi->nsip.remote_ip = sgsn_ip;
+   }
bssgp_nsi->nsip.local_port = local_port;
rc = gprs_ns_nsip_listen(bssgp_nsi);
if (rc < 0) {
@@ -920,7 +934,10 @@
dest.sin_port = htons(sgsn_port);
dest.sin_addr.s_addr = htonl(sgsn_ip);

-   the_pcu.nsvc = gprs_ns_nsip_connect(bssgp_nsi, , nsei, nsvci);
+   if (bts->gb_dialect_sns)
+   the_pcu.nsvc = gprs_ns_nsip_connect_sns(bssgp_nsi, , nsei, 
nsvci);
+   else
+   the_pcu.nsvc = gprs_ns_nsip_connect(bssgp_nsi, , nsei, 
nsvci);
if (!the_pcu.nsvc) {
LOGP(DBSSGP, LOGL_ERROR, "Failed to create NSVCt\n");
gprs_ns_destroy(bssgp_nsi);
diff --git a/src/pcu_vty.c b/src/pcu_vty.c
index 6f50bf1..960c90d 100644
--- a/src/pcu_vty.c
+++ b/src/pcu_vty.c
@@ -265,6 +265,11 @@
}
}

+   if (bts->gb_dialect_sns)
+   vty_out(vty, " gb-dialect ip-sns%s", VTY_NEWLINE);
+   else
+   vty_out(vty, " gb-dialect classic%s", VTY_NEWLINE);
+
return CMD_SUCCESS;
 }

@@ -1059,6 +1064,23 @@
return CMD_SUCCESS;
 }

+DEFUN(cfg_pcu_gb_dialect,
+  cfg_pcu_gb_dialect_cmd,
+  "gb-dialect (classic|ip-sns)",
+  "Select which Gb interface dialect to use\n"
+  "Classic Gb interface with NS-{RESET,BLOCK,UNBLOCK} and static 
configuration\n"
+  "Modern Gb interface with IP-SNS (Sub Network Service) and dynamic 
configuration\n")
+{
+   struct gprs_rlcmac_bts *bts = bts_main_data();
+
+   if (!strcmp(argv[0], "ip-sns"))
+   bts->gb_dialect_sns = true;
+   else
+   bts->gb_dialect_sns = false;
+
+   return CMD_SUCCESS;
+}
+
 

Change in osmo-pcu[master]: Optionally Use the NS Sub-Network-Service (SNS) on Gb

[Harald Welte]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/13025

to look at the new patch set (#2).

Change subject: Optionally Use the NS Sub-Network-Service (SNS) on Gb
..

Optionally Use the NS Sub-Network-Service (SNS) on Gb

This change add support for the recently-introduced GPRS Gb interface
auto-configuration using the NS IP Sub-Network Service (SNS) procedures.

It requires a Change-Id I84786c3b43a8ae34ef3b3ba84b33c90042d234ea of
libosmocore.

Related: OS#3372
Depends: I84786c3b43a8ae34ef3b3ba84b33c90042d234ea (libosmcore)
Change-Id: I256b40ac592d3b6e75dd581bf7b9512f69b11e83
---
M src/bts.h
M src/gprs_bssgp_pcu.cpp
M src/pcu_vty.c
3 files changed, 50 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/25/13025/2
--
To view, visit https://gerrit.osmocom.org/13025
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I256b40ac592d3b6e75dd581bf7b9512f69b11e83
Gerrit-Change-Number: 13025
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #9059

[jenkins]

See 


--
[...truncated 1.24 MB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Build failed in Jenkins: master-osmo-sgsn » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #9059

[jenkins]

See 


--
[...truncated 413.80 KB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Build failed in Jenkins: master-osmo-sgsn » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #9058

[jenkins]

See 


--
[...truncated 413.15 KB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #9058

[jenkins]

See 


--
[...truncated 1.24 MB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #9057

[jenkins]

See 


--
[...truncated 1.15 MB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Build failed in Jenkins: master-osmo-sgsn » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #9057

[jenkins]

See 


--
[...truncated 389.27 KB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #9056

[jenkins]

See 


--
[...truncated 1.24 MB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Build failed in Jenkins: master-osmo-sgsn » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #9056

[jenkins]

See 


--
[...truncated 411.61 KB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #9055

[jenkins]

See 


--
[...truncated 1.24 MB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Build failed in Jenkins: master-osmo-sgsn » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #9055

[jenkins]

See 


--
[...truncated 413.80 KB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Build failed in Jenkins: master-osmo-sgsn » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #9053

[jenkins]

See 


--
[...truncated 388.76 KB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #9052

[jenkins]

See 


--
[...truncated 1.15 MB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #9053

[jenkins]

See 


--
[...truncated 1.15 MB...]
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
Unregistering TLLI afe2b700
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa5ba79 CMD=UI DATA 
Got LLC message, CRC: a5ba79 (computed a5ba79)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x017a81 CMD=UI DATA 
Got LLC message, CRC: 017a81 (computed 017a81)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xfcdc9c CMD=UI DATA 
Got LLC message, CRC: fcdc9c (computed fcdc9c)
DETACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, PTMSI efe2b700
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition was in progress when receiving a DETACH_REQ.
NSEI=4096(BSS) IMSI not yet acquired, faking a DETACH_ACC.
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
Unregistering TLLI afe2b700
Removing TLLI afe2b700 from list (P-TMSI or IMSI are not set)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x684a29 CMD=UI DATA 
Got LLC message, CRC: 684a29 (computed 684a29)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
ATTACH_REQ: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96, PTMSI fbc54679
Adding TLLI afe2b700 to list
NSEI=4096(BSS) IMSI acquisition in progress, storing message (ATTACH_REQ)
NSEI=4096(BSS) IMSI is required but not available, initiating identification 
procedure (ATTACH_REQ)
NSEI=0 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x36f8b7 CMD=UI DATA 
Got LLC message, CRC: 36f8b7 (computed 36f8b7)
Unhandled GSM 04.08 message type IDENTITY REQUEST for protocol discriminator 
GMM.
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
DETACH_REQ: Got TLLI afe2b700, IMSI 12131415161718
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0x20a217 CMD=UI DATA 
Got LLC message, CRC: 20a217 (computed 20a217)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
DETACH_ACK: Got TLLI afe2b700, BSSGP RAID 112-332-16464-96, invalidate
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
gbproxy_validate_tlli({current = afe2b700, assigned = , net_vld = 0, 
bss_vld = 0}, afe2b700)
NSEI=4096(BSS) IMSI acquisition succeeded, flushing stored messages
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
Updated LLC message, CRC: 824988 -> 824988
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
Unregistering TLLI afe2b700
NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x824988 CMD=UI DATA 
Got LLC message, CRC: 824988 (computed 824988)
LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x8a2c65 CMD=UI DATA 
Got LLC message, CRC: 8a2c65 (computed 8a2c65)
validating counter group 0x44fc00(gbproxy:global) with 12 counters
counter group 'gbproxy:global' already exists for index 0, instead using index 
1. This is a software bug that needs fixing.
validating counter group 0x44fc00(gbproxy:global) with 12 counters
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '03242526' (9)
The TLLI has changed from c4d2 to c000162e
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
validating counter group 0x451460(gbproxy:peer) with 33 counters
Checking IMSI '03242526' (9)
Adding TLLI c4d2 to list
Checking IMSI '06272829' (9)
Adding TLLI c000162e to list
Removing TLLI c4d2 from list (stale, length 2, max_len exceeded)

Change in libosmocore[master]: NS: Factor out gprs_nsvc_start_test() and use it

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/13023 )

Change subject: NS: Factor out gprs_nsvc_start_test() and use it
..

NS: Factor out gprs_nsvc_start_test() and use it

This function performs  sending a NS-ALIVE PDU and starting Tns-Test,
let's use it in all places where we used to do that.

As part of this, also fix a bug where the sendto() return value (number
of bytes sent) would actually propagate up all the way to
gprs_ns_rx_reset() return value, which in turn affects the test results
on stdout.

Change-Id: I4d303117f77fabb74bbb91887b9914a81c2a084a
---
M src/gb/gb_internal.h
M src/gb/gprs_ns.c
M tests/gb/gprs_ns_test.ok
3 files changed, 21 insertions(+), 15 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/gb/gb_internal.h b/src/gb/gb_internal.h
index c1fa8e1..72d940f 100644
--- a/src/gb/gb_internal.h
+++ b/src/gb/gb_internal.h
@@ -4,6 +4,7 @@
 #include 
 #include 

+void gprs_nsvc_start_test(struct gprs_nsvc *nsvc);
 int gprs_ns_tx_sns_ack(struct gprs_nsvc *nsvc, uint8_t trans_id, uint8_t 
*cause,
   const struct gprs_ns_ie_ip4_elem *ip4_elems,unsigned int 
num_ip4_elems);

diff --git a/src/gb/gprs_ns.c b/src/gb/gprs_ns.c
index 660dfec..ad68bc9 100644
--- a/src/gb/gprs_ns.c
+++ b/src/gb/gprs_ns.c
@@ -1171,8 +1171,7 @@
rc = gprs_ns_tx_reset_ack(*nsvc);

/* start the test procedure */
-   gprs_ns_tx_alive(*nsvc);
-   nsvc_start_timer((*nsvc), NSVC_TIMER_TNS_TEST);
+   gprs_nsvc_start_test(*nsvc);

return rc;
 }
@@ -1295,10 +1294,9 @@
osmo_timer_del(&(*nsvc)->timer);
}
/* Initiate TEST proc.: Send ALIVE and start timer */
-   rc = gprs_ns_tx_alive(*nsvc);
-   nsvc_start_timer(*nsvc, NSVC_TIMER_TNS_TEST);
+   gprs_nsvc_start_test(*nsvc);

-   return rc;
+   return 0;
 }

 static int gprs_ns_rx_block(struct gprs_nsvc *nsvc, struct msgb *msg)
@@ -1949,4 +1947,11 @@
return s;
 }

+/*! Start the ALIVE timer procedure in all NS-VCs part of this NS Instance */
+void gprs_nsvc_start_test(struct gprs_nsvc *nsvc)
+{
+   gprs_ns_tx_alive(nsvc);
+   nsvc_start_timer(nsvc, NSVC_TIMER_TNS_TEST);
+}
+
 /*! @} */
diff --git a/tests/gb/gprs_ns_test.ok b/tests/gb/gprs_ns_test.ok
index 3cb1dfc..57ae188 100644
--- a/tests/gb/gprs_ns_test.ok
+++ b/tests/gb/gprs_ns_test.ok
@@ -344,7 +344,7 @@
 MESSAGE to BSS, msg length 1
 0a

-result (RESET_ACK) = 1
+result (RESET_ACK) = 0

 Current NS-VCIs:
 VCI 0x2001, NSEI 0x2000, peer 0x01020304:, ALIVE, UNBLOCKED, UNRESET
@@ -365,7 +365,7 @@
 MESSAGE to BSS, msg length 1
 0a

-result (RESET_ACK) = 1
+result (RESET_ACK) = 0

 Current NS-VCIs:
 VCI 0x2001, NSEI 0x2000, peer 0x:0, DEAD, BLOCKED, RESET
@@ -386,7 +386,7 @@
 MESSAGE to BSS, msg length 1
 0a

-result (RESET_ACK) = 1
+result (RESET_ACK) = 0

 Current NS-VCIs:
 VCI 0x2001, NSEI 0x2000, peer 0x:0, DEAD, BLOCKED, RESET
@@ -534,7 +534,7 @@
 MESSAGE to BSS, msg length 1
 0a

-result (RESET_ACK) = 1
+result (RESET_ACK) = 0

 Current NS-VCIs:
 VCI 0xf001, NSEI 0x1000, peer 0x:0, ALIVE, BLOCKED, UNRESET
@@ -557,7 +557,7 @@
 MESSAGE to BSS, msg length 1
 0a

-result (RESET_ACK) = 1
+result (RESET_ACK) = 0

 Current NS-VCIs:
 VCI 0xf001, NSEI 0x1000, peer 0x01020304:, ALIVE, BLOCKED, UNRESET
@@ -641,7 +641,7 @@
 MESSAGE to BSS, msg length 1
 0a

-result (RESET_ACK) = 1
+result (RESET_ACK) = 0
 
 Current NS-VCIs:
 VCI 0xf001, NSEI 0x1000, peer 0x:0, ALIVE, BLOCKED, UNRESET
@@ -666,7 +666,7 @@
 MESSAGE to SGSN, msg length 1
 0a

-result (RESET_ACK) = 1
+result (RESET_ACK) = 0

 PROCESSING ALIVE_ACK from 0x05060708:32000
 0b
@@ -818,7 +818,7 @@
 MESSAGE to SGSN, msg length 1
 0a

-result (RESET_ACK) = 1
+result (RESET_ACK) = 0

 PROCESSING ALIVE_ACK from 0x05060708:32000
 0b
@@ -898,7 +898,7 @@
 MESSAGE to SGSN, msg length 1
 0a

-result (RESET_ACK) = 1
+result (RESET_ACK) = 0
 
 PROCESSING ALIVE_ACK from 0x05060708:32000
 0b
@@ -956,7 +956,7 @@
 MESSAGE to SGSN, msg length 1
 0a

-result (RESET_ACK) = 1
+result (RESET_ACK) = 0

 PROCESSING ALIVE_ACK from 0x05060708:32000
 0b

--
To view, visit https://gerrit.osmocom.org/13023
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d303117f77fabb74bbb91887b9914a81c2a084a
Gerrit-Change-Number: 13023
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Max 
Gerrit-CC: Pau Espin Pedrol