Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 415s] ar: `u' modifier ignored since `D' is the default (see `U') [ 415s] libtool: link: ranlib .libs/libtransceiver_common.a [ 415s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 415s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 416s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 416s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 416s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 416s] collect2: error: ld returned 1 exit status [ 416s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 416s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 416s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 416s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 416s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 416s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 416s] make[1]: *** [Makefile:444: all] Error 2 [ 416s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 416s] dh_auto_build: make -j1 returned exit code 2 [ 416s] make: *** [debian/rules:6: build] Error 255 [ 416s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 416s] [ 416s] lamb14 failed "build osmo-trx_1.1.1.dsc" at Sat Aug 24 04:33:40 UTC 2019. [ 416s] [ 416s] ### VM INTERACTION START ### [ 419s] [ 399.314366] sysrq: SysRq : Power Off [ 419s] [ 399.320198] reboot: Power down [ 419s] ### VM INTERACTION END ### [ 419s] [ 419s] lamb14 failed "build osmo-trx_1.1.1.dsc" at Sat Aug 24 04:33:44 UTC 2019. [ 419s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-trx in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 436s] ar: `u' modifier ignored since `D' is the default (see `U') [ 436s] libtool: link: ranlib .libs/libtransceiver_common.a [ 436s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 436s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 436s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 436s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 436s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 436s] collect2: error: ld returned 1 exit status [ 436s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 436s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 436s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 436s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 436s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 436s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 436s] make[1]: *** [Makefile:444: all] Error 2 [ 436s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 436s] dh_auto_build: make -j1 returned exit code 2 [ 436s] make: *** [debian/rules:6: build] Error 255 [ 436s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 436s] [ 436s] lamb09 failed "build osmo-trx_1.1.1.dsc" at Sat Aug 24 04:07:38 UTC 2019. [ 436s] [ 436s] ### VM INTERACTION START ### [ 439s] [ 420.320157] sysrq: SysRq : Power Off [ 440s] [ 420.333933] reboot: Power down [ 440s] ### VM INTERACTION END ### [ 440s] [ 440s] lamb09 failed "build osmo-trx_1.1.1.dsc" at Sat Aug 24 04:07:42 UTC 2019. [ 440s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 405s] ar: `u' modifier ignored since `D' is the default (see `U') [ 405s] libtool: link: ranlib .libs/libtransceiver_common.a [ 405s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 405s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 406s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 406s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 406s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 406s] collect2: error: ld returned 1 exit status [ 406s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 406s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 406s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 406s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 406s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 406s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 406s] make[1]: *** [Makefile:444: all] Error 2 [ 406s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 406s] dh_auto_build: make -j1 returned exit code 2 [ 406s] make: *** [debian/rules:6: build] Error 255 [ 406s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 406s] [ 406s] lamb11 failed "build osmo-trx_1.1.1.2.67aa9.dsc" at Sat Aug 24 04:05:54 UTC 2019. [ 406s] [ 406s] ### VM INTERACTION START ### [ 409s] [ 390.928865] sysrq: SysRq : Power Off [ 409s] [ 390.936888] reboot: Power down [ 409s] ### VM INTERACTION END ### [ 409s] [ 409s] lamb11 failed "build osmo-trx_1.1.1.2.67aa9.dsc" at Sat Aug 24 04:05:58 UTC 2019. [ 409s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 401s] ar: `u' modifier ignored since `D' is the default (see `U') [ 401s] libtool: link: ranlib .libs/libtransceiver_common.a [ 401s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 401s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 401s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 402s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 402s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 402s] collect2: error: ld returned 1 exit status [ 402s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 402s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 402s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 402s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 402s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 402s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 402s] make[1]: *** [Makefile:444: all] Error 2 [ 402s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 402s] dh_auto_build: make -j1 returned exit code 2 [ 402s] make: *** [debian/rules:6: build] Error 255 [ 402s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 402s] [ 402s] lamb03 failed "build osmo-trx_1.1.1.2.67aa9.dsc" at Sat Aug 24 04:01:25 UTC 2019. [ 402s] [ 402s] ### VM INTERACTION START ### [ 405s] [ 386.741424] sysrq: SysRq : Power Off [ 405s] [ 386.746532] reboot: Power down [ 405s] ### VM INTERACTION END ### [ 405s] [ 405s] lamb03 failed "build osmo-trx_1.1.1.2.67aa9.dsc" at Sat Aug 24 04:01:28 UTC 2019. [ 405s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 419s] ar: `u' modifier ignored since `D' is the default (see `U') [ 419s] libtool: link: ranlib .libs/libtransceiver_common.a [ 419s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 419s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 419s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 419s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 419s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 419s] collect2: error: ld returned 1 exit status [ 419s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 419s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 419s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 419s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 419s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 419s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 419s] make[1]: *** [Makefile:444: all] Error 2 [ 419s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 419s] dh_auto_build: make -j1 returned exit code 2 [ 419s] make: *** [debian/rules:6: build] Error 255 [ 419s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 419s] [ 419s] lamb71 failed "build osmo-trx_1.1.1.2.67aa9.dsc" at Sat Aug 24 01:51:08 UTC 2019. [ 419s] [ 419s] ### VM INTERACTION START ### [ 422s] [ 403.835306] sysrq: SysRq : Power Off [ 422s] [ 403.845467] reboot: Power down [ 422s] ### VM INTERACTION END ### [ 422s] [ 422s] lamb71 failed "build osmo-trx_1.1.1.2.67aa9.dsc" at Sat Aug 24 01:51:11 UTC 2019. [ 422s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Change in ...osmo-msc[master]: smpp_openbsc.c: check acl before deref it
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15285 ) Change subject: smpp_openbsc.c: check acl before deref it .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibe0256535b40351594d79baa05a0147a9f89dc26 Gerrit-Change-Number: 15285 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sat, 24 Aug 2019 00:05:46 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-msc[master]: smpp_openbsc.c: check acl before deref it
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-msc/+/15285
Change subject: smpp_openbsc.c: check acl before deref it
..
smpp_openbsc.c: check acl before deref it
All other calls check acl before deref because in a setup
with no access policy, there won't be any acl structure
Change-Id: Ibe0256535b40351594d79baa05a0147a9f89dc26
---
M src/libmsc/smpp_openbsc.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/85/15285/1
diff --git a/src/libmsc/smpp_openbsc.c b/src/libmsc/smpp_openbsc.c
index bbfc500..e4c3891 100644
--- a/src/libmsc/smpp_openbsc.c
+++ b/src/libmsc/smpp_openbsc.c
@@ -326,7 +326,7 @@
"ESME is not (yet) bound, skipping alert\n");
continue;
}
- if (!esme->acl->alert_notifications) {
+ if (esme->acl && !esme->acl->alert_notifications) {
LOGP(DSMPP, LOGL_DEBUG,
"[%s] is not set to receive Alert
Notifications\n",
esme->system_id);
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15285
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ibe0256535b40351594d79baa05a0147a9f89dc26
Gerrit-Change-Number: 15285
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 408s] ar: `u' modifier ignored since `D' is the default (see `U') [ 408s] libtool: link: ranlib .libs/libtransceiver_common.a [ 408s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 408s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 408s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 409s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 409s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 409s] collect2: error: ld returned 1 exit status [ 409s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 409s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 409s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 409s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 409s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 409s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 409s] make[1]: *** [Makefile:444: all] Error 2 [ 409s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 409s] dh_auto_build: make -j1 returned exit code 2 [ 409s] make: *** [debian/rules:6: build] Error 255 [ 409s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 409s] [ 409s] lamb57 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Fri Aug 23 21:04:40 UTC 2019. [ 409s] [ 409s] ### VM INTERACTION START ### [ 412s] [ 393.283075] sysrq: SysRq : Power Off [ 412s] [ 393.291269] reboot: Power down [ 412s] ### VM INTERACTION END ### [ 412s] [ 412s] lamb57 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Fri Aug 23 21:04:44 UTC 2019. [ 412s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 395s] ar: `u' modifier ignored since `D' is the default (see `U') [ 395s] libtool: link: ranlib .libs/libtransceiver_common.a [ 395s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 395s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 395s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 395s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 395s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 395s] collect2: error: ld returned 1 exit status [ 395s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 395s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 395s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 395s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 395s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 395s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 395s] make[1]: *** [Makefile:444: all] Error 2 [ 395s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 395s] dh_auto_build: make -j1 returned exit code 2 [ 395s] make: *** [debian/rules:6: build] Error 255 [ 395s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 395s] [ 395s] lamb06 failed "build osmo-trx_1.1.1.dsc" at Fri Aug 23 21:02:55 UTC 2019. [ 395s] [ 395s] ### VM INTERACTION START ### [ 398s] [ 380.493129] sysrq: SysRq : Power Off [ 398s] [ 380.499705] reboot: Power down [ 399s] ### VM INTERACTION END ### [ 399s] [ 399s] lamb06 failed "build osmo-trx_1.1.1.dsc" at Fri Aug 23 21:02:58 UTC 2019. [ 399s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Change in ...osmo-ggsn[master]: ggsn: Implement echo req/resp and recovery
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15267 ) Change subject: ggsn: Implement echo req/resp and recovery .. Patch Set 4: Tested now with TTCN3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15267 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Id2c84165dc59dff495106758146a701ca488834f Gerrit-Change-Number: 15267 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Aug 2019 17:22:04 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...docker-playground[master]: ttcn3-ggsn: Disable echo-timer test when running against latest
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/15284 Change subject: ttcn3-ggsn: Disable echo-timer test when running against latest .. ttcn3-ggsn: Disable echo-timer test when running against latest Change-Id: I6657eefed00df96e3bcdca174a6ea0be1897b762 --- M ttcn3-ggsn-test/GGSN_Tests.cfg M ttcn3-ggsn-test/jenkins.sh 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/84/15284/1 diff --git a/ttcn3-ggsn-test/GGSN_Tests.cfg b/ttcn3-ggsn-test/GGSN_Tests.cfg index 064bf37..11c22cb 100644 --- a/ttcn3-ggsn-test/GGSN_Tests.cfg +++ b/ttcn3-ggsn-test/GGSN_Tests.cfg @@ -18,5 +18,7 @@ # GGSN announced DNS address GGSN_Tests.m_ggsn_ip4_dns1 := "172.18.3.201" +GGSN_Tests.m_ggsn_supports_echo_interval := true; + [EXECUTE] GGSN_Tests.control diff --git a/ttcn3-ggsn-test/jenkins.sh b/ttcn3-ggsn-test/jenkins.sh index 4250e4d..c4fac9d 100755 --- a/ttcn3-ggsn-test/jenkins.sh +++ b/ttcn3-ggsn-test/jenkins.sh @@ -10,6 +10,10 @@ mkdir $VOL_BASE_DIR/ggsn-tester cp GGSN_Tests.cfg $VOL_BASE_DIR/ggsn-tester/ +# VTY command "(no) echo-interval" must be disabled until osmo-ggsn.git release > 1.4.0 is available. +if [ "$IMAGE_SUFFIX" = "latest" ]; then + sed "s/GGSN_Tests.m_ggsn_supports_echo_interval := true;/GGSN_Tests.m_ggsn_supports_echo_interval := false;/g" -i $VOL_BASE_DIR/ggsn-tester/GGSN_Tests.cfg +fi mkdir $VOL_BASE_DIR/ggsn cp osmo-ggsn.cfg $VOL_BASE_DIR/ggsn/ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/15284 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6657eefed00df96e3bcdca174a6ea0be1897b762 Gerrit-Change-Number: 15284 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Change in ...osmo-ttcn3-hacks[master]: ggsn: Introduce test TC_pdp_act2_recovery
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15283
Change subject: ggsn: Introduce test TC_pdp_act2_recovery
..
ggsn: Introduce test TC_pdp_act2_recovery
Some code is moved out of f_pdp_ctx_act() into f_handle_create_req() in
order to re-use it in the test.
Related: OS#4165
Change-Id: I48c1bc9287ce8b820e5ea672dffbc5a8503f16d7
---
M ggsn_tests/GGSN_Tests.ttcn
M ggsn_tests/expected-results.xml
2 files changed, 111 insertions(+), 42 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/83/15283/1
diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn
index e294fb7..4a53fa1 100644
--- a/ggsn_tests/GGSN_Tests.ttcn
+++ b/ggsn_tests/GGSN_Tests.ttcn
@@ -267,6 +267,51 @@
}
}
+ function f_handle_create_req(inout PdpContext ctx, in Gtp1cUnitdata ud,
in OCT1 exp_cause := '80'O) runs on GT_CT {
+ var CreatePDPContextResponse cpr :=
ud.gtpc.gtpc_pdu.createPDPContextResponse;
+ if (exp_cause == '80'O and exp_cause == cpr.cause.causevalue) {
+ /* Check if EUA type corresponds to requested type */
+ if (match(ctx.eua, t_EuaIPv4(?)) and
+ not match(cpr.endUserAddress, tr_EuaIPv4(?))){
+ setverdict(fail);
+ }
+ if (match(ctx.eua, t_EuaIPv6(?)) and
+ not match(cpr.endUserAddress, tr_EuaIPv6(?))) {
+ setverdict(fail);
+ }
+ if (match(ctx.eua, t_EuaIPv4v6(?, ?)) and
+ not match(cpr.endUserAddress, tr_EuaIPv4v6(?, ?))) {
+ setverdict(fail);
+ }
+ /* Check if PCO response corresponds to request */
+ if (ispresent(ctx.pco_req)) {
+ if (match(ctx.pco_req, ts_PCO_IPv4_DNS_CONT) and
+ not match(cpr.protConfigOptions,
tr_PCO_IPv4_DNS_CONT_resp(?))) {
+ log("IPv4 DNS Container requested, but
missing");
+ setverdict(fail);
+ }
+ if (match(ctx.pco_req, ts_PCO_IPv6_DNS) and
+ not match(cpr.protConfigOptions,
tr_PCO_IPv6_DNS_resp(?))) {
+ log("IPv6 DNS Container requested, but
missing");
+ setverdict(fail);
+ }
+ }
+ ctx.teid_remote := cpr.teidDataI.teidDataI;
+ ctx.teic_remote :=
cpr.teidControlPlane.teidControlPlane;
+ ctx.eua := cpr.endUserAddress;
+ ctx.pco_neg := cpr.protConfigOptions;
+ setverdict(pass);
+ } else if (exp_cause != '80'O and exp_cause ==
cpr.cause.causevalue) {
+ if (ispresent(cpr.endUserAddress)) {
+ log("EUA received on createPDPContextResponse
cause=" & oct2str(cpr.cause.causevalue));
+ setverdict(fail);
+ }
+ setverdict(pass);
+ } else {
+ setverdict(fail);
+ }
+ }
+
/* send a PDP context activation */
function f_pdp_ctx_act(inout PdpContext ctx, OCT1 exp_cause := '80'O)
runs on GT_CT {
var Gtp1cUnitdata ud;
@@ -280,48 +325,7 @@
d := activate(pingpong());
alt {
[] GTPC.receive(tr_GTPC_MsgType(g_peer_c,
createPDPContextResponse, ctx.teic)) -> value ud {
- var CreatePDPContextResponse cpr :=
ud.gtpc.gtpc_pdu.createPDPContextResponse;
- if (exp_cause == '80'O and exp_cause ==
cpr.cause.causevalue) {
- /* Check if EUA type corresponds to
requested type */
- if (match(ctx.eua, t_EuaIPv4(?)) and
- not match(cpr.endUserAddress,
tr_EuaIPv4(?))){
- setverdict(fail);
- }
- if (match(ctx.eua, t_EuaIPv6(?)) and
- not match(cpr.endUserAddress,
tr_EuaIPv6(?))) {
- setverdict(fail);
- }
- if (match(ctx.eua, t_EuaIPv4v6(?, ?))
and
- not match(cpr.endUserAddress,
tr_EuaIPv4v6(?, ?))) {
-
Change in ...osmo-ttcn3-hacks[master]: ggsn: Introduce test TC_pdp_act_restart_ctr_echo
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15282
Change subject: ggsn: Introduce test TC_pdp_act_restart_ctr_echo
..
ggsn: Introduce test TC_pdp_act_restart_ctr_echo
VTY functionalities to enable and disable echo requests in osmo-ggsn are
added too as part of the test.
Depends: osmo-ggsn.git Id2c84165dc59dff495106758146a701ca488834f
Related: OS#4165
Change-Id: Ia37e48e7ff9ad063f9eabf447f8a6a0a3fc380d9
---
M ggsn_tests/GGSN_Tests.ttcn
M ggsn_tests/expected-results.xml
2 files changed, 86 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/82/15282/1
diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn
index ae92626..e294fb7 100644
--- a/ggsn_tests/GGSN_Tests.ttcn
+++ b/ggsn_tests/GGSN_Tests.ttcn
@@ -64,6 +64,13 @@
* The tests expect to be able to send ping packets between any
two simulated MS within the same
* address range. This requires IP forwarding to be enabled on
the corresponding tun interfaces.
*/
+
+ /*
+* Whether ggsn supports "(no) echo-interval" VTY command
+* (osmo-ggsn.git Id2c84165dc59dff495106758146a701ca488834f).
+* This option can be dropped after osmo-ggsn release > 1.4.0
exists.
+*/
+ boolean m_ggsn_supports_echo_interval := true;
}
type set PdpContext {
@@ -107,6 +114,7 @@
port TELNETasp_PT GGSNVTY;
var boolean use_gtpu_txseq := false;
+ var boolean g_use_echo := false;
}
private function f_init_vty() runs on GT_CT {
@@ -159,6 +167,17 @@
return true;
}
+ private function f_vty_enable_echo_interval(boolean enable) runs on
GT_CT {
+ f_vty_enter_config(GGSNVTY);
+ f_vty_transceive(GGSNVTY, "ggsn ggsn0");
+ if (enable) {
+ f_vty_transceive(GGSNVTY, "echo-interval 5");
+ } else {
+ f_vty_transceive(GGSNVTY, "no echo-interval");
+ }
+ f_vty_transceive(GGSNVTY, "end");
+ }
+
function f_init() runs on GT_CT {
if (g_initialized == true) {
return;
@@ -184,20 +203,22 @@
f_init_vty();
f_vty_set_gpdu_txseq(use_gtpu_txseq);
+ if (m_ggsn_supports_echo_interval) {
+ f_vty_enable_echo_interval(g_use_echo);
+ }
}
/* Altstep implementing responses to any incoming echo requests */
altstep pingpong() runs on GT_CT {
var Gtp1cUnitdata ud;
var Gtp1uUnitdata udu;
- [] GTPC.receive(tr_GTPC_PING(?)) -> value ud {
+ [g_use_echo] GTPC.receive(tr_GTPC_PING(?)) -> value ud {
var uint16_t seq :=
oct2int(ud.gtpc.opt_part.sequenceNumber);
- GTPC.send(ts_GTPC_PONG(ud.peer, seq, '00'O));
+ GTPC.send(ts_GTPC_PONG(ud.peer, seq, g_restart_ctr));
repeat;
};
- [] GTPU.receive(tr_GTPU_PING(?)) -> value udu {
- var uint16_t seq :=
oct2int(udu.gtpu.opt_part.sequenceNumber);
- GTPU.send(ts_GTPU_PONG(udu.peer, seq, '00'O));
+ [not g_use_echo] GTPC.receive(tr_GTPC_PING(?)) {
+ setverdict(fail, "GTP Echo Req rceived but not enabled
in VTY");
};
[] T_default.timeout { setverdict(fail); };
}
@@ -307,6 +328,35 @@
T_default.stop;
}
+ function f_pdp_ctx_exp_del_req(PdpContext ctx, template (omit) OCT1
expect_cause := omit, boolean expect_teardown := false) runs on GT_CT {
+ var Gtp1cUnitdata ud;
+ var default d;
+
+ T_default.start;
+ d := activate(pingpong());
+ alt {
+ [] GTPC.receive(tr_GTPC_MsgType(g_peer_c,
deletePDPContextRequest, ctx.teic)) -> value ud {
+ if (istemplatekind(expect_cause, "omit") and
not ispresent(ud.gtpc.gtpc_pdu.deletePDPContextRequest.cause.causevalue)) {
+ setverdict(pass);
+ } else if (not istemplatekind(expect_cause,
"omit") and
+
ispresent(ud.gtpc.gtpc_pdu.deletePDPContextRequest.cause.causevalue) and
+
ud.gtpc.gtpc_pdu.deletePDPContextRequest.cause.causevalue ==
valueof(expect_cause)) {
+ setverdict(pass);
+ } else {
+ setverdict(fail);
+
Change in ...osmo-pcu[master]: gprs_bssgp_destroy(): fix NULL-pointer dereference
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/15281 )
Change subject: gprs_bssgp_destroy(): fix NULL-pointer dereference
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/15281/1/src/gprs_bssgp_pcu.cpp
File src/gprs_bssgp_pcu.cpp:
https://gerrit.osmocom.org/#/c/15281/1/src/gprs_bssgp_pcu.cpp@980
PS1, Line 980: #warning "This causes ASAN to complain. It is not critical for
normal operation but should be fixed nevertheless"
Would be great to check with git log if this warning is related to same thing
(bctx being NULL).
You are missing putting everything inside the same block:
if (the_pcu.bctx != NULL) {
llist_del(_pcu.bctx->list);
#warning "..."
#if 0
talloc_free(the_pcu.bctx);
#endif
the_pcu.bctx = NULL;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15281
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I42cb911a679b9198fd06e74b42f1e2cb28323de9
Gerrit-Change-Number: 15281
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Fri, 23 Aug 2019 17:07:48 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_read(): further simplify the code
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/15280 )
Change subject: osmobts_sock.cpp: pcu_sock_read(): further simplify the code
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/15280/1/src/osmobts_sock.cpp
File src/osmobts_sock.cpp:
https://gerrit.osmocom.org/#/c/15280/1/src/osmobts_sock.cpp@146
PS1, Line 146: if (rc <= 0) {
This looks a lot simpler:
if (rc < 0 && errno == EAGAIN)
return 0;
if (rc <= 0) {
pcu_sock_close(state, 1);
return -EIO;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15280
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ie7c0ca8baf0ae5beadda60bda0bc76a44664d439
Gerrit-Change-Number: 15280
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-CC: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Comment-Date: Fri, 23 Aug 2019 17:04:29 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15278 ) Change subject: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15278 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7f5c7f5744ab14f36f46cf7941e91352eca8d2b9 Gerrit-Change-Number: 15278 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Aug 2019 17:02:11 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15279 ) Change subject: osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap .. Patch Set 3: > Patch Set 2: > > Are you sure msgb is not retrieved somehow (hacky way) later on in pcu_rx() > and its callees? Doing that would be quite stupid IMHO. Let's see ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4cb8ca80513df7b71e1438da2e82799be6be1fa0 Gerrit-Change-Number: 15279 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Aug 2019 16:33:47 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15278 ) Change subject: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/15278/2/src/osmobts_sock.cpp File src/osmobts_sock.cpp: https://gerrit.osmocom.org/#/c/15278/2/src/osmobts_sock.cpp@265 PS2, Line 265: state->conn_bfd.cb = pcu_sock_cb; > I think these 2 lines should be set before calling osmo_sock_unix_init_ofd()? > Or is it fine this way […] I think it's fine to do it here. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15278 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7f5c7f5744ab14f36f46cf7941e91352eca8d2b9 Gerrit-Change-Number: 15278 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Aug 2019 16:32:26 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/15279 to look at the new patch set (#3). Change subject: osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap .. osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap We don't really need to use the message buffer (on heap), because it's never getting passed to pcu_rx(). Let's use a buffer on stack. Change-Id: I4cb8ca80513df7b71e1438da2e82799be6be1fa0 --- M src/osmobts_sock.cpp 1 file changed, 3 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/79/15279/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4cb8ca80513df7b71e1438da2e82799be6be1fa0 Gerrit-Change-Number: 15279 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-pcu[master]: gprs_bssgp_destroy(): fix NULL-pointer dereference
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15281 Change subject: gprs_bssgp_destroy(): fix NULL-pointer dereference .. gprs_bssgp_destroy(): fix NULL-pointer dereference The 'gprs_bssgp_pcu' may not be initialized in some cases, e.g. when OsmoPCU is terminated before connecting to the SGSN. Change-Id: I42cb911a679b9198fd06e74b42f1e2cb28323de9 --- M src/gprs_bssgp_pcu.cpp 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/81/15281/1 diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp index ddf5174..ade9879 100644 --- a/src/gprs_bssgp_pcu.cpp +++ b/src/gprs_bssgp_pcu.cpp @@ -975,7 +975,8 @@ gprs_ns_destroy(nsi); /* FIXME: move this to libgb: btsctx_free() */ - llist_del(_pcu.bctx->list); + if (the_pcu.bctx != NULL) + llist_del(_pcu.bctx->list); #warning "This causes ASAN to complain. It is not critical for normal operation but should be fixed nevertheless" #if 0 talloc_free(the_pcu.bctx); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15281 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I42cb911a679b9198fd06e74b42f1e2cb28323de9 Gerrit-Change-Number: 15281 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_read(): further simplify the code
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/15280
Change subject: osmobts_sock.cpp: pcu_sock_read(): further simplify the code
..
osmobts_sock.cpp: pcu_sock_read(): further simplify the code
Change-Id: Ie7c0ca8baf0ae5beadda60bda0bc76a44664d439
---
M src/osmobts_sock.cpp
1 file changed, 6 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/80/15280/1
diff --git a/src/osmobts_sock.cpp b/src/osmobts_sock.cpp
index a3e9d63..95f8710 100644
--- a/src/osmobts_sock.cpp
+++ b/src/osmobts_sock.cpp
@@ -143,22 +143,15 @@
int rc;
rc = recv(bfd->fd, _prim, sizeof(pcu_prim), 0);
- if (rc == 0)
- goto close;
-
- if (rc < 0) {
- if (errno == EAGAIN)
+ if (rc <= 0) {
+ /* Try again later */
+ if (rc < 0 && errno == EAGAIN)
return 0;
- goto close;
+ pcu_sock_close(state, 1);
+ return -EIO;
}
- rc = pcu_rx(pcu_prim.msg_type, _prim);
-
- return rc;
-
-close:
- pcu_sock_close(state, 1);
- return -1;
+ return pcu_rx(pcu_prim.msg_type, _prim);
}
static int pcu_sock_write(struct osmo_fd *bfd)
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15280
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ie7c0ca8baf0ae5beadda60bda0bc76a44664d439
Gerrit-Change-Number: 15280
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/15278 to look at the new patch set (#3). Change subject: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API .. osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API Change-Id: I7f5c7f5744ab14f36f46cf7941e91352eca8d2b9 --- M src/osmobts_sock.cpp 1 file changed, 8 insertions(+), 50 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/78/15278/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15278 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7f5c7f5744ab14f36f46cf7941e91352eca8d2b9 Gerrit-Change-Number: 15278 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15279 ) Change subject: osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4cb8ca80513df7b71e1438da2e82799be6be1fa0 Gerrit-Change-Number: 15279 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 23 Aug 2019 16:17:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15279 ) Change subject: osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap .. Patch Set 2: Are you sure msgb is not retrieved somehow (hacky way) later on in pcu_rx() and its callees? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4cb8ca80513df7b71e1438da2e82799be6be1fa0 Gerrit-Change-Number: 15279 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-CC: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 23 Aug 2019 16:17:18 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15278 ) Change subject: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15278/2/src/osmobts_sock.cpp File src/osmobts_sock.cpp: https://gerrit.osmocom.org/#/c/15278/2/src/osmobts_sock.cpp@265 PS2, Line 265: state->conn_bfd.cb = pcu_sock_cb; I think these 2 lines should be set before calling osmo_sock_unix_init_ofd()? Or is it fine this way? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15278 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7f5c7f5744ab14f36f46cf7941e91352eca8d2b9 Gerrit-Change-Number: 15278 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Aug 2019 16:08:07 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API
Hello pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/15278 to look at the new patch set (#2). Change subject: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API .. osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API Change-Id: I7f5c7f5744ab14f36f46cf7941e91352eca8d2b9 --- M src/osmobts_sock.cpp 1 file changed, 8 insertions(+), 50 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/78/15278/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15278 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7f5c7f5744ab14f36f46cf7941e91352eca8d2b9 Gerrit-Change-Number: 15278 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset
Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/15279
Change subject: osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap
..
osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap
We don't really need to use the message buffer (on heap), because
it's never getting passed to pcu_rx(). Let's use a buffer on stack.
Change-Id: I4cb8ca80513df7b71e1438da2e82799be6be1fa0
---
M src/osmobts_sock.cpp
1 file changed, 3 insertions(+), 15 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/79/15279/1
diff --git a/src/osmobts_sock.cpp b/src/osmobts_sock.cpp
index 1072229..3fa6d15 100644
--- a/src/osmobts_sock.cpp
+++ b/src/osmobts_sock.cpp
@@ -139,17 +139,10 @@
static int pcu_sock_read(struct osmo_fd *bfd)
{
struct pcu_sock_state *state = (struct pcu_sock_state *)bfd->data;
- struct gsm_pcu_if *pcu_prim;
- struct msgb *msg;
+ struct gsm_pcu_if pcu_prim;
int rc;
- msg = msgb_alloc(sizeof(*pcu_prim), "pcu_sock_rx");
- if (!msg)
- return -ENOMEM;
-
- pcu_prim = (struct gsm_pcu_if *) msg->tail;
-
- rc = recv(bfd->fd, msg->tail, msgb_tailroom(msg), 0);
+ rc = recv(bfd->fd, _prim, sizeof(pcu_prim), 0);
if (rc == 0)
goto close;
@@ -159,16 +152,11 @@
goto close;
}
- rc = pcu_rx(pcu_prim->msg_type, pcu_prim);
-
- /* as we always synchronously process the message in pcu_rx() and
-* its callbacks, we can free the message here. */
- msgb_free(msg);
+ rc = pcu_rx(pcu_prim.msg_type, _prim);
return rc;
close:
- msgb_free(msg);
pcu_sock_close(state, 1);
return -1;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15279
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I4cb8ca80513df7b71e1438da2e82799be6be1fa0
Gerrit-Change-Number: 15279
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/15278
Change subject: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API
..
osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API
Change-Id: I7f5c7f5744ab14f36f46cf7941e91352eca8d2b9
---
M src/osmobts_sock.cpp
1 file changed, 9 insertions(+), 51 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/78/15278/1
diff --git a/src/osmobts_sock.cpp b/src/osmobts_sock.cpp
index 6b49347..1072229 100644
--- a/src/osmobts_sock.cpp
+++ b/src/osmobts_sock.cpp
@@ -239,9 +239,6 @@
int pcu_l1if_open(void)
{
struct pcu_sock_state *state;
- struct osmo_fd *bfd;
- struct sockaddr_un local;
- unsigned int namelen;
int rc;
struct gprs_rlcmac_bts *bts = bts_main_data();
@@ -255,60 +252,21 @@
INIT_LLIST_HEAD(>upqueue);
}
- bfd = >conn_bfd;
-
- bfd->fd = socket(AF_UNIX, SOCK_SEQPACKET, 0);
- if (bfd->fd < 0) {
- LOGP(DL1IF, LOGL_ERROR, "Failed to create PCU socket.\n");
- talloc_free(state);
- return -1;
- }
-
- local.sun_family = AF_UNIX;
- if (osmo_strlcpy(local.sun_path, bts->pcu_sock_path,
sizeof(local.sun_path)) >= sizeof(local.sun_path)) {
- LOGP(DLGLOBAL, LOGL_ERROR, "Socket path exceeds maximum length
of %zd bytes: %s\n",
-sizeof(local.sun_path), bts->pcu_sock_path);
- return -ENOSPC;
- }
-
- /* we use the same magic that X11 uses in Xtranssock.c for
-* calculating the proper length of the sockaddr */
-#if defined(BSD44SOCKETS) || defined(__UNIXWARE__)
- local.sun_len = strlen(local.sun_path);
-#endif
-#if defined(BSD44SOCKETS) || defined(SUN_LEN)
- namelen = SUN_LEN();
-#else
- namelen = strlen(local.sun_path) +
- offsetof(struct sockaddr_un, sun_path);
-#endif
- rc = connect(bfd->fd, (struct sockaddr *) , namelen);
- if (rc != 0) {
- LOGP(DL1IF, LOGL_ERROR, "Failed to connect to the osmo-bts"
- " PCU socket (%s), delaying... '%s'\n",
- strerror(errno), local.sun_path);
- pcu_sock_state = state;
- close(bfd->fd);
- bfd->fd = -1;
+ rc = osmo_sock_unix_init_ofd(>conn_bfd, SOCK_SEQPACKET, 0,
+bts->pcu_sock_path, OSMO_SOCK_F_CONNECT);
+ if (rc < 0) {
+ LOGP(DL1IF, LOGL_ERROR, "Failed to connect to the BTS (%s). "
+ "Retrying...\n", bts->pcu_sock_path);
osmo_timer_setup(>timer, pcu_sock_timeout, NULL);
osmo_timer_schedule(>timer, 5, 0);
- return 0;
+ return -EAGAIN;
}
- bfd->when = BSC_FD_READ;
- bfd->cb = pcu_sock_cb;
- bfd->data = state;
-
- rc = osmo_fd_register(bfd);
- if (rc < 0) {
- LOGP(DL1IF, LOGL_ERROR, "Could not register PCU fd: %d\n", rc);
- close(bfd->fd);
- talloc_free(state);
- return rc;
- }
+ state->conn_bfd.cb = pcu_sock_cb;
+ state->conn_bfd.data = state;
LOGP(DL1IF, LOGL_NOTICE, "osmo-bts PCU socket %s has been connected\n",
-local.sun_path);
+bts->pcu_sock_path);
pcu_sock_state = state;
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15278
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I7f5c7f5744ab14f36f46cf7941e91352eca8d2b9
Gerrit-Change-Number: 15278
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in ...osmo-bsc[master]: abis_nm.c: use LOGP() macro instead of LOGPC()
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15277 ) Change subject: abis_nm.c: use LOGP() macro instead of LOGPC() .. Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/15277/1/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/#/c/15277/1/src/osmo-bsc/abis_nm.c@314 PS1, Line 314: LOGPC(DNM, LOGL_ERROR, "BTS %u: Failure Event Report: ", bts->nr); > The ones here look like they need fixing too. Done. https://gerrit.osmocom.org/#/c/15277/1/src/osmo-bsc/abis_nm.c@344 PS1, Line 344: LOGP(DNM, LOGL_NOTICE, "BTS %u reported connected PCU version %s\n", bts->nr, text); > Don't we have LOGBTS or something similar? Or even better, pass foh as > parameter and use LOGPFOH. This is an idea for a separate change. Unfortunately there is no such macro. And... do we really need to know more than the BTS number? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I868633ad3e50f2cb3ebfb2c566d16c4710f17563 Gerrit-Change-Number: 15277 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Aug 2019 15:49:30 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in ...osmo-bsc[master]: abis_nm.c: use LOGP() macro instead of LOGPC()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15277 ) Change subject: abis_nm.c: use LOGP() macro instead of LOGPC() .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I868633ad3e50f2cb3ebfb2c566d16c4710f17563 Gerrit-Change-Number: 15277 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Aug 2019 15:49:00 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-bsc[master]: abis_nm.c: use LOGP() macro instead of LOGPC()
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/15277 to look at the new patch set (#2). Change subject: abis_nm.c: use LOGP() macro instead of LOGPC() .. abis_nm.c: use LOGP() macro instead of LOGPC() The LOGPC() is usually used for continuation when printing complex logging messages (e.g. where using format string is not enough). In this case, nothing is being printed before calling LOGPC(), so the logging messages appear without the meta info (time-stamp, level, category, etc.), for example: BTS 0 reported connected PCU version 0.7.0.1-2585-dirty Change-Id: I868633ad3e50f2cb3ebfb2c566d16c4710f17563 --- M src/osmo-bsc/abis_nm.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/77/15277/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I868633ad3e50f2cb3ebfb2c566d16c4710f17563 Gerrit-Change-Number: 15277 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-bsc[master]: abis_nm.c: handle_manufact_report(): use LOGP(), not LOGPC()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15277 ) Change subject: abis_nm.c: handle_manufact_report(): use LOGP(), not LOGPC() .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/15277/1/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/#/c/15277/1/src/osmo-bsc/abis_nm.c@314 PS1, Line 314: LOGPC(DNM, LOGL_ERROR, "BTS %u: Failure Event Report: ", bts->nr); The ones here look like they need fixing too. https://gerrit.osmocom.org/#/c/15277/1/src/osmo-bsc/abis_nm.c@344 PS1, Line 344: LOGP(DNM, LOGL_NOTICE, "BTS %u reported connected PCU version %s\n", bts->nr, text); Don't we have LOGBTS or something similar? Or even better, pass foh as parameter and use LOGPFOH. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I868633ad3e50f2cb3ebfb2c566d16c4710f17563 Gerrit-Change-Number: 15277 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-CC: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 23 Aug 2019 14:50:07 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-bsc[master]: lchan_select.c: tune log level in lchan_select_by_type()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15276 ) Change subject: lchan_select.c: tune log level in lchan_select_by_type() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9b45852116253e5237b779a91bed8b800758360e Gerrit-Change-Number: 15276 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 23 Aug 2019 14:46:27 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-bsc[master]: abis_nm.c: handle_manufact_report(): use LOGP(), not LOGPC()
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/15277
Change subject: abis_nm.c: handle_manufact_report(): use LOGP(), not LOGPC()
..
abis_nm.c: handle_manufact_report(): use LOGP(), not LOGPC()
The LOGPC() is usually used for continuation when printing complex
logging messages (e.g. where using format string is not enough).
In this case, nothing is being printed before calling LOGPC(), so
the logging messages appear without the meta info (time-stamp,
level, category, etc.), for example:
BTS 0 reported connected PCU version 0.7.0.1-2585-dirty
Change-Id: I868633ad3e50f2cb3ebfb2c566d16c4710f17563
---
M src/osmo-bsc/abis_nm.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/77/15277/1
diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c
index 7d059b5..b12ba43 100644
--- a/src/osmo-bsc/abis_nm.c
+++ b/src/osmo-bsc/abis_nm.c
@@ -341,10 +341,10 @@
switch (cause) {
case OSMO_EVT_PCU_VERS:
if (text) {
- LOGPC(DNM, LOGL_NOTICE, "BTS %u reported connected PCU
version %s\n", bts->nr, text);
+ LOGP(DNM, LOGL_NOTICE, "BTS %u reported connected PCU
version %s\n", bts->nr, text);
osmo_strlcpy(bts->pcu_version, text,
sizeof(bts->pcu_version));
} else {
- LOGPC(DNM, LOGL_ERROR, "BTS %u reported PCU
disconnection.\n", bts->nr);
+ LOGP(DNM, LOGL_ERROR, "BTS %u reported PCU
disconnection.\n", bts->nr);
bts->pcu_version[0] = '\0';
}
break;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15277
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I868633ad3e50f2cb3ebfb2c566d16c4710f17563
Gerrit-Change-Number: 15277
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in ...osmo-bsc[master]: lchan_select.c: tune log level in lchan_select_by_type()
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15276 Change subject: lchan_select.c: tune log level in lchan_select_by_type() .. lchan_select.c: tune log level in lchan_select_by_type() If lchan_select_by_type() fails to find a suitable logical channel, it would print a message using LOGL_ERROR. This can happen if all logical channels of the requested type are busy, thus it is not a error. Let's use LOGL_NOTICE for that. Change-Id: I9b45852116253e5237b779a91bed8b800758360e --- M src/osmo-bsc/lchan_select.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/76/15276/1 diff --git a/src/osmo-bsc/lchan_select.c b/src/osmo-bsc/lchan_select.c index 6df3b4a..d63db22 100644 --- a/src/osmo-bsc/lchan_select.c +++ b/src/osmo-bsc/lchan_select.c @@ -234,7 +234,7 @@ lchan->type = type; LOG_LCHAN(lchan, LOGL_INFO, "Selected\n"); } else - LOG_BTS(bts, DRLL, LOGL_ERROR, "Failed to select %s channel\n", + LOG_BTS(bts, DRLL, LOGL_NOTICE, "Failed to select %s channel\n", gsm_lchant_name(type)); return lchan; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9b45852116253e5237b779a91bed8b800758360e Gerrit-Change-Number: 15276 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in ...osmo-ggsn[master]: ggsn: Implement echo req/resp and recovery
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15267 to look at the new patch set (#3). Change subject: ggsn: Implement echo req/resp and recovery .. ggsn: Implement echo req/resp and recovery This patch is quite big because implementing echo req/resp and recovery requires having knowledge and managing differntiated state for each GSN peer attached/connected to osmo-ggsn. This kind of information was not available in osmo-ggsn nor in libgtp. So osmo-ggsn is now able to track GSN peers connected to a ggsn_ctx (associated gsn_t from libgtp) by means of "sgsn_peer" data structure, and accessible from the ggsn through a list. The instances of sgsn_peer are currently allocated and destroyed dynamically based on discovered peer who have at least a pdp context attached to us (we are not interested in peers without pdp contexts because we don't need o send echo requests/responses and maintain state in that case). A new private pointer (pdp_t->priv) data structure struct pdp_priv_t is added to be able to relate a pdp_t to an sgsn as well as the already existing pointer to an apn. An "echo-interval <0-36000>" VTY command is added which allows configuring time wait between echo requests being sent to each sgsn_peer. Transmission of echo requests is disabled by default. Finally, a new "show sgsn" VTY command is introduced, and its output is also printed during "show ggsn". Related: OS#4165 Change-Id: Id2c84165dc59dff495106758146a701ca488834f --- M doc/manuals/vty/ggsn_vty_reference.xml M ggsn/Makefile.am M ggsn/ggsn.c M ggsn/ggsn.h M ggsn/ggsn_vty.c A ggsn/sgsn.c A ggsn/sgsn.h 7 files changed, 389 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/67/15267/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15267 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Id2c84165dc59dff495106758146a701ca488834f Gerrit-Change-Number: 15267 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-ggsn[master]: doc: Update vty reference xml file
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15275 Change subject: doc: Update vty reference xml file .. doc: Update vty reference xml file Change-Id: I49e7db4d0f5c7868b86a4947d8b5739c2068da46 --- M doc/manuals/vty/ggsn_vty_reference.xml 1 file changed, 70 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/75/15275/1 diff --git a/doc/manuals/vty/ggsn_vty_reference.xml b/doc/manuals/vty/ggsn_vty_reference.xml index a395b23..15128ed 100644 --- a/doc/manuals/vty/ggsn_vty_reference.xml +++ b/doc/manuals/vty/ggsn_vty_reference.xml @@ -254,6 +254,41 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -614,6 +649,41 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15275 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I49e7db4d0f5c7868b86a4947d8b5739c2068da46 Gerrit-Change-Number: 15275 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Change in ...osmo-python-tests[master]: Add osmo_interact_exec.py
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/15273 ) Change subject: Add osmo_interact_exec.py .. Patch Set 1: Code-Review-2 This one was pushed by error by myself, probably needs to be abandonned. -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/15273 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: If38243171c94d8ce9d6cdc269da59c9ebc9942bb Gerrit-Change-Number: 15273 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Aug 2019 13:55:27 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-python-tests[master]: Add osmo_interact_exec.py
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/15273 ) Change subject: Add osmo_interact_exec.py .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/15273 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: If38243171c94d8ce9d6cdc269da59c9ebc9942bb Gerrit-Change-Number: 15273 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Aug 2019 13:55:07 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-python-tests[master]: vty.py: Fix endl removed when pkt buffer content ends exactly on a ne...
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/15274 Change subject: vty.py: Fix endl removed when pkt buffer content ends exactly on a newline char .. vty.py: Fix endl removed when pkt buffer content ends exactly on a newline char As a result, osmo_interact_vty.py was printing incorrect output: """ - - + https://gerrit.osmocom.org/c/python/osmo-python-tests/+/15274 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: Ib1dbf39db1b27331ea4c39051e550a87780d9f76 Gerrit-Change-Number: 15274 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Change in ...osmo-python-tests[master]: Add osmo_interact_exec.py
Hello osmith,
I'd like you to do a code review. Please visit
https://gerrit.osmocom.org/c/python/osmo-python-tests/+/15273
to review the following change.
Change subject: Add osmo_interact_exec.py
..
Add osmo_interact_exec.py
Change-Id: If38243171c94d8ce9d6cdc269da59c9ebc9942bb
---
M osmopy/osmo_interact/common.py
A osmopy/osmo_interact/exec.py
A scripts/osmo_interact_exec.py
3 files changed, 132 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests
refs/changes/73/15273/1
diff --git a/osmopy/osmo_interact/common.py b/osmopy/osmo_interact/common.py
index 39163a2..bc2b461 100644
--- a/osmopy/osmo_interact/common.py
+++ b/osmopy/osmo_interact/common.py
@@ -374,7 +374,7 @@
return passed
-def common_parser(doc=None):
+def common_parser(doc=None, host=True):
parser = argparse.ArgumentParser(description=doc,
formatter_class=argparse.RawDescriptionHelpFormatter)
parser.add_argument('-r', '--run', dest='run_app_str',
@@ -383,8 +383,9 @@
' application is launched.')
parser.add_argument('-p', '--port', dest='port',
help="Port to reach the application at.")
-parser.add_argument('-H', '--host', dest='host', default='localhost',
-help="Host to reach the application at.")
+if host:
+parser.add_argument('-H', '--host', dest='host', default='localhost',
+help="Host to reach the application at.")
return parser
def parser_add_verify_args(parser):
@@ -397,17 +398,30 @@
parser.add_argument('transcript_files', nargs='*', help='transcript
file(s) to verify')
return parser
-def parser_add_run_args(parser):
+def parser_add_run_args(parser, cmd_files=True):
parser.add_argument('-O', '--output', dest='output_path',
help="Write command results to a file instead of
stdout."
"('-O -' writes to stdout and is the default)")
parser.add_argument('-c', '--command', dest='cmd_str',
help="Run this command (before reading input files, if
any)."
" multiple commands may be separated by ';'")
-parser.add_argument('cmd_files', nargs='*', help='file(s) with plain
commands to run')
+if cmd_files:
+parser.add_argument('cmd_files', nargs='*', help='file(s) with plain
commands to run')
return parser
-def main_run_commands(run_app_str, output_path, cmd_str, cmd_files, interact):
+def parser_require_args(parser, dests):
+for dest in dests:
+found = False
+for action in parser._actions:
+if action.dest == dest:
+action.required = True
+found = True
+break
+if not found:
+raise RuntimeError("Could not find argument with dest: " + dest)
+
+def main_run_commands(run_app_str, output_path, cmd_str, cmd_files, interact,
+ purge_output=True):
to_stdout = False
if not output_path or output_path == '-':
to_stdout = True
@@ -418,7 +432,7 @@
application = None
if run_app_str:
-application = Application(run_app_str, quiet=to_stdout)
+application = Application(run_app_str, quiet=to_stdout,
purge_output=purge_output)
application.run()
try:
diff --git a/osmopy/osmo_interact/exec.py b/osmopy/osmo_interact/exec.py
new file mode 100644
index 000..c2f2f08
--- /dev/null
+++ b/osmopy/osmo_interact/exec.py
@@ -0,0 +1,84 @@
+#!/usr/bin/env python3
+#
+# (C) 2019 by sysmocom s.f.m.c. GmbH
+# All rights reserved.
+#
+# Author: Oliver Smith
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see
Change in ...osmo-ggsn[master]: ggsn: Implement echo req/resp and recovery
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15267 to look at the new patch set (#2). Change subject: ggsn: Implement echo req/resp and recovery .. ggsn: Implement echo req/resp and recovery This patch is quite big because implementing echo req/resp and recovery requires having knowledge and managing differntiated state for each GSN peer attached/connected to osmo-ggsn. This kind of information was not available in osmo-ggsn nor in libgtp. So osmo-ggsn is now able to track GSN peers connected to a ggsn_ctx (associated gsn_t from libgtp) by means of "sgsn_peer" data structure, and accessible from the ggsn through a list. The instances of sgsn_peer are currently allocated and destroyed dynamically based on discovered peer who have at least a pdp context attached to us (we are not interested in peers without pdp contexts because we don't need o send echo requests/responses and maintain state in that case). A new private pointer (pdp_t->priv) data structure struct pdp_priv_t is added to be able to relate a pdp_t to an sgsn as well as the already existing pointer to an apn. An "echo-interval <0-36000>" VTY command is added which allows configuring time wait between echo requests being sent to each sgsn_peer. Transmission of echo requests is disabled by default. Finally, a new "show sgsn" VTY command is introduced, and its output is also printed during "show ggsn". Related: OS#4165 Change-Id: Id2c84165dc59dff495106758146a701ca488834f --- M ggsn/Makefile.am M ggsn/ggsn.c M ggsn/ggsn.h M ggsn/ggsn_vty.c A ggsn/sgsn.c A ggsn/sgsn.h 6 files changed, 377 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/67/15267/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15267 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Id2c84165dc59dff495106758146a701ca488834f Gerrit-Change-Number: 15267 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-ggsn[master]: ggsn: Split application lifecycle related code into ggsn_main.c
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15249 to look at the new patch set (#2). Change subject: ggsn: Split application lifecycle related code into ggsn_main.c .. ggsn: Split application lifecycle related code into ggsn_main.c This way we further shrink ggsn.c and leave there GGSN related code. Change-Id: I9e6a3beac7657f0a8c02d514b54c6f1caa93bba7 --- M ggsn/Makefile.am M ggsn/ggsn.c M ggsn/ggsn.h A ggsn/ggsn_main.c 4 files changed, 214 insertions(+), 176 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/49/15249/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15249 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I9e6a3beac7657f0a8c02d514b54c6f1caa93bba7 Gerrit-Change-Number: 15249 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset
Change in ...osmo-ggsn[master]: ggsn: Move PCO handling code into its own file
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15246 to look at the new patch set (#2). Change subject: ggsn: Move PCO handling code into its own file .. ggsn: Move PCO handling code into its own file This way ggsn.c is shrinked in size and get rid of a lot of code there, which is of no interest unless the reader is interested in that really specific part. Change-Id: Ieaa7e71f17c7fd9377c76ef53362eab596d669a6 --- M ggsn/Makefile.am M ggsn/ggsn.c M ggsn/ggsn.h A ggsn/pco.c A ggsn/pco.h 5 files changed, 343 insertions(+), 312 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/46/15246/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15246 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ieaa7e71f17c7fd9377c76ef53362eab596d669a6 Gerrit-Change-Number: 15246 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset
Change in ...osmo-ggsn[master]: libgtp: announce pdp ctx deletion upon CreatePdpCtx being rejected
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ggsn/+/15259 )
Change subject: libgtp: announce pdp ctx deletion upon CreatePdpCtx being
rejected
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/15259/1/ggsn/ggsn.c
File ggsn/ggsn.c:
https://gerrit.osmocom.org/#/c/15259/1/ggsn/ggsn.c@389
PS1, Line 389: if (apn && apn->cfg.gtpu_mode == APN_GTPU_MODE_KERNEL_GTP) {
> Why is this in the same patch? It seems like an unrelated fix.
It's not unrelated. Since now we free pdp contexts being rejected, it means
they were never assigned an APN so apn is going to be NULL. I'm sure it
happens, I had to fix it after I wrote the patch ;)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15259
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I6c6215a4ce478afabc78ffaf5ffb0cf829e41226
Gerrit-Change-Number: 15259
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Fri, 23 Aug 2019 13:20:27 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith
Gerrit-MessageType: comment
Change in ...osmo-ggsn[master]: libgtp: announce pdp ctx deletion upon CreatePdpCtx being rejected
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ggsn/+/15259 )
Change subject: libgtp: announce pdp ctx deletion upon CreatePdpCtx being
rejected
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/15259/1/ggsn/ggsn.c
File ggsn/ggsn.c:
https://gerrit.osmocom.org/#/c/15259/1/ggsn/ggsn.c@389
PS1, Line 389: if (apn && apn->cfg.gtpu_mode == APN_GTPU_MODE_KERNEL_GTP) {
Why is this in the same patch? It seems like an unrelated fix.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15259
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I6c6215a4ce478afabc78ffaf5ffb0cf829e41226
Gerrit-Change-Number: 15259
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Fri, 23 Aug 2019 13:07:39 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in ...osmo-bts[master]: virtual: set link quality for GSMTAP_CHANNEL_RACH
osmith has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-bts/+/15271 )
Change subject: virtual: set link quality for GSMTAP_CHANNEL_RACH
..
virtual: set link quality for GSMTAP_CHANNEL_RACH
Don't ignore all incoming RACH requests anymore:
000881/00/23/14/09 Ignoring RACH request: link quality (0) below the minimum
(50)
Related: OS#3925
Fixes: b777c0f3ecb8b770f032db449e947f0f9731de11 ("Move Access Burst link
quality handling to L1SAP")
Change-Id: Ifcd576fed84346688e711a26a05c6d350588e83d
---
M src/osmo-bts-virtual/l1_if.c
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
diff --git a/src/osmo-bts-virtual/l1_if.c b/src/osmo-bts-virtual/l1_if.c
index 0e77651..acd8ea2 100644
--- a/src/osmo-bts-virtual/l1_if.c
+++ b/src/osmo-bts-virtual/l1_if.c
@@ -124,6 +124,7 @@
/* we don't really know which RACH burst type the virtual MS is
using, as this field is not
* part of information present in the GSMTAP header. So we
simply report all of them as 0 */
l1sap.u.rach_ind.burst_type = GSM_L1_BURST_TYPE_ACCESS_0;
+ l1sap.u.rach_ind.lqual_cb = 10 * signal_dbm; /* Link quality in
centiBel = 10 * dB. */
break;
case GSMTAP_CHANNEL_TCH_F:
case GSMTAP_CHANNEL_TCH_H:
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15271
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ifcd576fed84346688e711a26a05c6d350588e83d
Gerrit-Change-Number: 15271
Gerrit-PatchSet: 2
Gerrit-Owner: osmith
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 652s] ar: `u' modifier ignored since `D' is the default (see `U') [ 652s] libtool: link: ranlib .libs/libtransceiver_common.a [ 652s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 652s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 653s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 653s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 653s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 653s] collect2: error: ld returned 1 exit status [ 653s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 653s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 653s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 653s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 653s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 653s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 653s] make[1]: *** [Makefile:444: all] Error 2 [ 653s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 653s] dh_auto_build: make -j1 returned exit code 2 [ 653s] make: *** [debian/rules:6: build] Error 255 [ 653s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 653s] [ 653s] lamb25 failed "build osmo-trx_1.1.1.dsc" at Thu Aug 22 23:19:22 UTC 2019. [ 653s] [ 653s] ### VM INTERACTION START ### [ 656s] [ 633.536639] sysrq: SysRq : Power Off [ 656s] [ 633.559925] reboot: Power down [ 656s] ### VM INTERACTION END ### [ 656s] [ 656s] lamb25 failed "build osmo-trx_1.1.1.dsc" at Thu Aug 22 23:19:25 UTC 2019. [ 656s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 462s] ar: `u' modifier ignored since `D' is the default (see `U') [ 462s] libtool: link: ranlib .libs/libtransceiver_common.a [ 462s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 462s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 463s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 463s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 463s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 463s] collect2: error: ld returned 1 exit status [ 463s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 463s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 463s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 463s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 463s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 463s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 463s] make[1]: *** [Makefile:444: all] Error 2 [ 463s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 463s] dh_auto_build: make -j1 returned exit code 2 [ 463s] make: *** [debian/rules:6: build] Error 255 [ 463s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 463s] [ 463s] lamb51 failed "build osmo-trx_1.1.1.dsc" at Thu Aug 22 16:06:05 UTC 2019. [ 463s] [ 463s] ### VM INTERACTION START ### [ 466s] [ 448.256375] sysrq: SysRq : Power Off [ 466s] [ 448.263974] reboot: Power down [ 466s] ### VM INTERACTION END ### [ 466s] [ 466s] lamb51 failed "build osmo-trx_1.1.1.dsc" at Thu Aug 22 16:06:09 UTC 2019. [ 466s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libosmo-netif in xUbuntu_18.10/i586
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/xUbuntu_18.10/i586
Package network:osmocom:nightly/libosmo-netif failed to build in
xUbuntu_18.10/i586
Check out the package for editing:
osc checkout network:osmocom:nightly libosmo-netif
Last lines of build log:
[ 246s] | pdfdir='${docdir}'
[ 246s] | prefix='/usr'
[ 246s] | program_transform_name='s,x,x,'
[ 246s] | psdir='${docdir}'
[ 246s] | runstatedir='${localstatedir}/run'
[ 246s] | sbindir='${exec_prefix}/sbin'
[ 246s] | sharedstatedir='${prefix}/com'
[ 246s] | sysconfdir='/etc'
[ 246s] | target_alias=''
[ 246s] |
[ 246s] | ## --- ##
[ 246s] | ## confdefs.h. ##
[ 246s] | ## --- ##
[ 246s] |
[ 246s] | /* confdefs.h */
[ 246s] | #define PACKAGE_NAME "libosmo-netif"
[ 246s] | #define PACKAGE_TARNAME "libosmo-netif"
[ 246s] | #define PACKAGE_VERSION "0.6.0"
[ 246s] | #define PACKAGE_STRING "libosmo-netif 0.6.0"
[ 246s] | #define PACKAGE_BUGREPORT "openbsc-de...@lists.openbsc.org"
[ 246s] | #define PACKAGE_URL ""
[ 246s] | #define PACKAGE "libosmo-netif"
[ 246s] | #define VERSION "0.6.0"
[ 249s] | #define STDC_HEADER[ 221.235901] sysrq: SysRq : Power Off
[ 249s] [ 221.250253] reboot: Power down
[ 249s] ### VM INTERACTION END ###
[ 249s]
[ 249s] cloud115 failed "build libosmo-netif_0.6.0.dsc" at Fri Aug 23 01:56:40
UTC 2019.
[ 249s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 489s] ar: `u' modifier ignored since `D' is the default (see `U') [ 489s] libtool: link: ranlib .libs/libtransceiver_common.a [ 490s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 490s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 490s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 490s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 490s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 490s] collect2: error: ld returned 1 exit status [ 490s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 490s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 490s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 490s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 490s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 490s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 490s] make[1]: *** [Makefile:444: all] Error 2 [ 490s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 490s] dh_auto_build: make -j1 returned exit code 2 [ 490s] make: *** [debian/rules:6: build] Error 255 [ 490s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 490s] [ 490s] lamb04 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Fri Aug 23 03:15:51 UTC 2019. [ 490s] [ 490s] ### VM INTERACTION START ### [ 493s] [ 472.772417] sysrq: SysRq : Power Off [ 493s] [ 472.781484] reboot: Power down [ 493s] ### VM INTERACTION END ### [ 493s] [ 493s] lamb04 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Fri Aug 23 03:15:54 UTC 2019. [ 493s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 430s] ar: `u' modifier ignored since `D' is the default (see `U') [ 430s] libtool: link: ranlib .libs/libtransceiver_common.a [ 430s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 430s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 430s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 431s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 431s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 431s] collect2: error: ld returned 1 exit status [ 431s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 431s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 431s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 431s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 431s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 431s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 431s] make[1]: *** [Makefile:444: all] Error 2 [ 431s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 431s] dh_auto_build: make -j1 returned exit code 2 [ 431s] make: *** [debian/rules:6: build] Error 255 [ 431s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 431s] [ 431s] lamb24 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Thu Aug 22 16:03:50 UTC 2019. [ 431s] [ 431s] ### VM INTERACTION START ### [ 434s] [ 413.361810] sysrq: SysRq : Power Off [ 434s] [ 413.368393] reboot: Power down [ 434s] ### VM INTERACTION END ### [ 434s] [ 434s] lamb24 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Thu Aug 22 16:03:54 UTC 2019. [ 434s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 393s] ar: `u' modifier ignored since `D' is the default (see `U') [ 393s] libtool: link: ranlib .libs/libtransceiver_common.a [ 393s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 393s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 393s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 393s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 393s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 393s] collect2: error: ld returned 1 exit status [ 393s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 393s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 393s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 393s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 393s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 393s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 393s] make[1]: *** [Makefile:444: all] Error 2 [ 393s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 393s] dh_auto_build: make -j1 returned exit code 2 [ 393s] make: *** [debian/rules:6: build] Error 255 [ 393s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 393s] [ 393s] lamb06 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Thu Aug 22 23:07:44 UTC 2019. [ 393s] [ 393s] ### VM INTERACTION START ### [ 397s] [ 378.362676] sysrq: SysRq : Power Off [ 397s] [ 378.369577] reboot: Power down [ 397s] ### VM INTERACTION END ### [ 397s] [ 397s] lamb06 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Thu Aug 22 23:07:48 UTC 2019. [ 397s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 536s] ar: `u' modifier ignored since `D' is the default (see `U') [ 536s] libtool: link: ranlib .libs/libtransceiver_common.a [ 536s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 536s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 537s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 537s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 537s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 537s] collect2: error: ld returned 1 exit status [ 537s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 537s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 537s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 537s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 537s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 537s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 537s] make[1]: *** [Makefile:444: all] Error 2 [ 537s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 537s] dh_auto_build: make -j1 returned exit code 2 [ 537s] make: *** [debian/rules:6: build] Error 255 [ 537s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 537s] [ 537s] lamb52 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Fri Aug 23 03:33:06 UTC 2019. [ 537s] [ 537s] ### VM INTERACTION START ### [ 540s] [ 517.125797] sysrq: SysRq : Power Off [ 540s] [ 517.178437] reboot: Power down [ 540s] ### VM INTERACTION END ### [ 540s] [ 540s] lamb52 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Fri Aug 23 03:33:09 UTC 2019. [ 540s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 402s] ar: `u' modifier ignored since `D' is the default (see `U') [ 402s] libtool: link: ranlib .libs/libtransceiver_common.a [ 402s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 402s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 403s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 403s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 403s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 403s] collect2: error: ld returned 1 exit status [ 403s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 403s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 403s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 403s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 403s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 403s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 403s] make[1]: *** [Makefile:444: all] Error 2 [ 403s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 403s] dh_auto_build: make -j1 returned exit code 2 [ 403s] make: *** [debian/rules:6: build] Error 255 [ 403s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 403s] [ 403s] lamb17 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Fri Aug 23 07:21:30 UTC 2019. [ 403s] [ 403s] ### VM INTERACTION START ### [ 406s] [ 387.392865] sysrq: SysRq : Power Off [ 406s] [ 387.399797] reboot: Power down [ 406s] ### VM INTERACTION END ### [ 406s] [ 406s] lamb17 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Fri Aug 23 07:21:34 UTC 2019. [ 406s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-trx in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 392s] ar: `u' modifier ignored since `D' is the default (see `U') [ 392s] libtool: link: ranlib .libs/libtransceiver_common.a [ 392s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 392s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 393s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 393s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 393s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 393s] collect2: error: ld returned 1 exit status [ 393s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 393s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 393s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 393s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 393s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 393s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 393s] make[1]: *** [Makefile:444: all] Error 2 [ 393s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 393s] dh_auto_build: make -j1 returned exit code 2 [ 393s] make: *** [debian/rules:6: build] Error 255 [ 393s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 393s] [ 393s] lamb09 failed "build osmo-trx_1.1.1.dsc" at Fri Aug 23 08:34:14 UTC 2019. [ 393s] [ 393s] ### VM INTERACTION START ### [ 396s] [ 378.800935] sysrq: SysRq : Power Off [ 396s] [ 378.807814] reboot: Power down [ 396s] ### VM INTERACTION END ### [ 396s] [ 396s] lamb09 failed "build osmo-trx_1.1.1.dsc" at Fri Aug 23 08:34:17 UTC 2019. [ 396s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Change in ...libosmocore[master]: Cosmetic: l1sap.h: change /* !< to /*!
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15269 ) Change subject: Cosmetic: l1sap.h: change /* !< to /*!< .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icaec95a9c6105fd17bc1151fdc77394f4efd3b70 Gerrit-Change-Number: 15269 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Aug 2019 11:20:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-bts[master]: Cosmetic: virtual: l1sap.c: fix typos
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15270 ) Change subject: Cosmetic: virtual: l1sap.c: fix typos .. Cosmetic: virtual: l1sap.c: fix typos Change-Id: Id24e75812bda17e99f17a37b367462533a5607f9 --- M src/osmo-bts-virtual/l1_if.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, approved diff --git a/src/osmo-bts-virtual/l1_if.c b/src/osmo-bts-virtual/l1_if.c index d0c368e..0e77651 100644 --- a/src/osmo-bts-virtual/l1_if.c +++ b/src/osmo-bts-virtual/l1_if.c @@ -121,7 +121,7 @@ l1sap.u.rach_ind.acc_delay = 0; /* probably not used in virt um */ l1sap.u.rach_ind.is_11bit = 0; l1sap.u.rach_ind.fn = fn; - /* we don't rally know which RACH bursrt type the virtual MS is using, as this field is not + /* we don't really know which RACH burst type the virtual MS is using, as this field is not * part of information present in the GSMTAP header. So we simply report all of them as 0 */ l1sap.u.rach_ind.burst_type = GSM_L1_BURST_TYPE_ACCESS_0; break; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15270 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id24e75812bda17e99f17a37b367462533a5607f9 Gerrit-Change-Number: 15270 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in ...libosmocore[master]: Cosmetic: l1sap.h: change /* !< to /*!
pespin has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/libosmocore/+/15269 )
Change subject: Cosmetic: l1sap.h: change /* !< to /*!<
..
Cosmetic: l1sap.h: change /* !< to /*!<
Change-Id: Icaec95a9c6105fd17bc1151fdc77394f4efd3b70
---
M include/osmocom/gsm/l1sap.h
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
pespin: Looks good to me, approved
diff --git a/include/osmocom/gsm/l1sap.h b/include/osmocom/gsm/l1sap.h
index 19cc87a..3d2ad25 100644
--- a/include/osmocom/gsm/l1sap.h
+++ b/include/osmocom/gsm/l1sap.h
@@ -67,8 +67,8 @@
/* elements added on 2018-02-26 */
int8_t rssi;/*!< RSSI of RACH indication */
uint16_t ber10k;/*!< BER in units of 0.01% */
- int16_t acc_delay_256bits;/* !< Burst TA Offset in 1/256th bits */
- int16_t lqual_cb; /* !< Link quality in centiBel */
+ int16_t acc_delay_256bits;/*!< Burst TA Offset in 1/256th bits */
+ int16_t lqual_cb; /*!< Link quality in centiBel */
};
/*! for PH-[UNIT]DATA.{req,ind} | PH-RTS.ind */
@@ -79,10 +79,10 @@
int8_t rssi;/*!< RSSI of receivedindication */
uint16_t ber10k;/*!< BER in units of 0.01% */
union {
- int16_t ta_offs_qbits; /* !< Burst TA Offset in quarter bits */
+ int16_t ta_offs_qbits; /*!< Burst TA Offset in quarter bits */
int16_t ta_offs_256bits;/*!< timing advance offset (in 1/256th
bits) */
};
- int16_t lqual_cb; /* !< Link quality in centiBel */
+ int16_t lqual_cb; /*!< Link quality in centiBel */
enum osmo_ph_pres_info_type pdch_presence_info; /*!< Info regarding
presence/validity of header and data parts */
};
@@ -93,7 +93,7 @@
int8_t rssi;/*!< RSSI of received indication */
uint8_t marker; /*!< RTP Marker bit (speech onset indicator) */
uint16_t ber10k;/*!< BER in units of 0.01% */
- int16_t lqual_cb; /* !< Link quality in centiBel */
+ int16_t lqual_cb; /*!< Link quality in centiBel */
};
/*! for PH-CONN.ind */
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15269
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icaec95a9c6105fd17bc1151fdc77394f4efd3b70
Gerrit-Change-Number: 15269
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in ...osmo-bts[master]: Cosmetic: virtual: l1sap.c: fix typos
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15270 ) Change subject: Cosmetic: virtual: l1sap.c: fix typos .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15270 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id24e75812bda17e99f17a37b367462533a5607f9 Gerrit-Change-Number: 15270 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Aug 2019 11:19:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-bts[master]: virtual: set link quality for GSMTAP_CHANNEL_RACH
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15271 ) Change subject: virtual: set link quality for GSMTAP_CHANNEL_RACH .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15271 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifcd576fed84346688e711a26a05c6d350588e83d Gerrit-Change-Number: 15271 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Aug 2019 11:18:38 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...libosmocore[master]: Cosmetic: l1sap.h: change /* !< to /*!
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15269 ) Change subject: Cosmetic: l1sap.h: change /* !< to /*!< .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icaec95a9c6105fd17bc1151fdc77394f4efd3b70 Gerrit-Change-Number: 15269 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 23 Aug 2019 11:04:10 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-bts[master]: Cosmetic: virtual: l1sap.c: fix typos
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15270 ) Change subject: Cosmetic: virtual: l1sap.c: fix typos .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15270 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id24e75812bda17e99f17a37b367462533a5607f9 Gerrit-Change-Number: 15270 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 23 Aug 2019 11:03:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-bts[master]: virtual: set link quality for GSMTAP_CHANNEL_RACH
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15271 ) Change subject: virtual: set link quality for GSMTAP_CHANNEL_RACH .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15271 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifcd576fed84346688e711a26a05c6d350588e83d Gerrit-Change-Number: 15271 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Aug 2019 11:02:35 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-bts[master]: virtual: set link quality for GSMTAP_CHANNEL_RACH
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15271 ) Change subject: virtual: set link quality for GSMTAP_CHANNEL_RACH .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15271/1/src/osmo-bts-virtual/l1_if.c File src/osmo-bts-virtual/l1_if.c: https://gerrit.osmocom.org/#/c/15271/1/src/osmo-bts-virtual/l1_if.c@127 PS1, Line 127: data > rach_ind copy paste mistake from GSMTAP_CHANNEL_PTCCH below, fixed -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15271 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifcd576fed84346688e711a26a05c6d350588e83d Gerrit-Change-Number: 15271 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Aug 2019 10:36:19 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in ...osmo-bts[master]: virtual: set link quality for GSMTAP_CHANNEL_RACH
Hello pespin, fixeria, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/15271
to look at the new patch set (#2).
Change subject: virtual: set link quality for GSMTAP_CHANNEL_RACH
..
virtual: set link quality for GSMTAP_CHANNEL_RACH
Don't ignore all incoming RACH requests anymore:
000881/00/23/14/09 Ignoring RACH request: link quality (0) below the minimum
(50)
Related: OS#3925
Fixes: b777c0f3ecb8b770f032db449e947f0f9731de11 ("Move Access Burst link
quality handling to L1SAP")
Change-Id: Ifcd576fed84346688e711a26a05c6d350588e83d
---
M src/osmo-bts-virtual/l1_if.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/71/15271/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15271
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ifcd576fed84346688e711a26a05c6d350588e83d
Gerrit-Change-Number: 15271
Gerrit-PatchSet: 2
Gerrit-Owner: osmith
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-MessageType: newpatchset
Change in ...osmo-bts[master]: virtual: set link quality for GSMTAP_CHANNEL_RACH
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15271 ) Change subject: virtual: set link quality for GSMTAP_CHANNEL_RACH .. Patch Set 1: (Jenkins failures are unrelated, retriggered) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15271 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifcd576fed84346688e711a26a05c6d350588e83d Gerrit-Change-Number: 15271 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Aug 2019 10:34:02 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-bts[master]: virtual: set link quality for GSMTAP_CHANNEL_RACH
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15271 ) Change subject: virtual: set link quality for GSMTAP_CHANNEL_RACH .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/15271/1/src/osmo-bts-virtual/l1_if.c File src/osmo-bts-virtual/l1_if.c: https://gerrit.osmocom.org/#/c/15271/1/src/osmo-bts-virtual/l1_if.c@127 PS1, Line 127: data rach_ind -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15271 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifcd576fed84346688e711a26a05c6d350588e83d Gerrit-Change-Number: 15271 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 23 Aug 2019 10:33:56 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ci[master]: gerrit-verifications: fix osmo-bts cmd
osmith has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-ci/+/15272 )
Change subject: gerrit-verifications: fix osmo-bts cmd
..
gerrit-verifications: fix osmo-bts cmd
Fixes: 932b0037506130692bc8a1aa1edd95d5f54efd11 ("gerrit, master builds: use
ASCIIDOC_WARNINGS_CHECK")
Change-Id: Ia17d6a14ede93bae715fb67826b074ab91f87749
---
M jobs/gerrit-verifications.yml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
osmith: Looks good to me, approved; Verified
diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml
index cb370e9..abd8090 100644
--- a/jobs/gerrit-verifications.yml
+++ b/jobs/gerrit-verifications.yml
@@ -126,7 +126,7 @@
(FIRMWARE_VERSION == "litecell15" && BTS_MODEL == "lc15" &&
WITH_MANUALS == "0") ||
(FIRMWARE_VERSION == "oc2g" && BTS_MODEL == "oc2g" && WITH_MANUALS
== "0") ||
(FIRMWARE_VERSION == "oc2g-next" && BTS_MODEL == "oc2g" &&
WITH_MANUALS == "0")
- cmd: ASCIIDOC_WARNINGS_CHECK="1" './contrib/jenkins_bts_model.sh
"$BTS_MODEL"'
+ cmd: 'ASCIIDOC_WARNINGS_CHECK="1" ./contrib/jenkins_bts_model.sh
"$BTS_MODEL"'
- osmo-ggsn:
a1_name: GTP
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/15272
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ia17d6a14ede93bae715fb67826b074ab91f87749
Gerrit-Change-Number: 15272
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-Reviewer: osmith
Gerrit-MessageType: merged
Change in ...osmo-ci[master]: gerrit-verifications: fix osmo-bts cmd
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15272 ) Change subject: gerrit-verifications: fix osmo-bts cmd .. Patch Set 1: Verified+1 Code-Review+2 Super trivial and tested, merging directly. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/15272 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia17d6a14ede93bae715fb67826b074ab91f87749 Gerrit-Change-Number: 15272 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 23 Aug 2019 10:28:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ci[master]: gerrit-verifications: fix osmo-bts cmd
osmith has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ci/+/15272
Change subject: gerrit-verifications: fix osmo-bts cmd
..
gerrit-verifications: fix osmo-bts cmd
Fixes: 932b0037506130692bc8a1aa1edd95d5f54efd11 ("gerrit, master builds: use
ASCIIDOC_WARNINGS_CHECK")
Change-Id: Ia17d6a14ede93bae715fb67826b074ab91f87749
---
M jobs/gerrit-verifications.yml
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/72/15272/1
diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml
index cb370e9..abd8090 100644
--- a/jobs/gerrit-verifications.yml
+++ b/jobs/gerrit-verifications.yml
@@ -126,7 +126,7 @@
(FIRMWARE_VERSION == "litecell15" && BTS_MODEL == "lc15" &&
WITH_MANUALS == "0") ||
(FIRMWARE_VERSION == "oc2g" && BTS_MODEL == "oc2g" && WITH_MANUALS
== "0") ||
(FIRMWARE_VERSION == "oc2g-next" && BTS_MODEL == "oc2g" &&
WITH_MANUALS == "0")
- cmd: ASCIIDOC_WARNINGS_CHECK="1" './contrib/jenkins_bts_model.sh
"$BTS_MODEL"'
+ cmd: 'ASCIIDOC_WARNINGS_CHECK="1" ./contrib/jenkins_bts_model.sh
"$BTS_MODEL"'
- osmo-ggsn:
a1_name: GTP
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/15272
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ia17d6a14ede93bae715fb67826b074ab91f87749
Gerrit-Change-Number: 15272
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-MessageType: newchange
Change in ...osmo-bts[master]: virtual: set link quality for GSMTAP_CHANNEL_RACH
osmith has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bts/+/15271
Change subject: virtual: set link quality for GSMTAP_CHANNEL_RACH
..
virtual: set link quality for GSMTAP_CHANNEL_RACH
Don't ignore all incoming RACH requests anymore:
000881/00/23/14/09 Ignoring RACH request: link quality (0) below the minimum
(50)
Related: OS#3925
Fixes: b777c0f3ecb8b770f032db449e947f0f9731de11 ("Move Access Burst link
quality handling to L1SAP")
Change-Id: Ifcd576fed84346688e711a26a05c6d350588e83d
---
M src/osmo-bts-virtual/l1_if.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/71/15271/1
diff --git a/src/osmo-bts-virtual/l1_if.c b/src/osmo-bts-virtual/l1_if.c
index 0e77651..454c2c1 100644
--- a/src/osmo-bts-virtual/l1_if.c
+++ b/src/osmo-bts-virtual/l1_if.c
@@ -124,6 +124,7 @@
/* we don't really know which RACH burst type the virtual MS is
using, as this field is not
* part of information present in the GSMTAP header. So we
simply report all of them as 0 */
l1sap.u.rach_ind.burst_type = GSM_L1_BURST_TYPE_ACCESS_0;
+ l1sap.u.data.lqual_cb = 10 * signal_dbm; /* Link quality in
centiBel = 10 * dB. */
break;
case GSMTAP_CHANNEL_TCH_F:
case GSMTAP_CHANNEL_TCH_H:
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15271
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ifcd576fed84346688e711a26a05c6d350588e83d
Gerrit-Change-Number: 15271
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-MessageType: newchange
Change in ...osmo-bts[master]: Cosmetic: virtual: l1sap.c: fix typos
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15270 Change subject: Cosmetic: virtual: l1sap.c: fix typos .. Cosmetic: virtual: l1sap.c: fix typos Change-Id: Id24e75812bda17e99f17a37b367462533a5607f9 --- M src/osmo-bts-virtual/l1_if.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/70/15270/1 diff --git a/src/osmo-bts-virtual/l1_if.c b/src/osmo-bts-virtual/l1_if.c index d0c368e..0e77651 100644 --- a/src/osmo-bts-virtual/l1_if.c +++ b/src/osmo-bts-virtual/l1_if.c @@ -121,7 +121,7 @@ l1sap.u.rach_ind.acc_delay = 0; /* probably not used in virt um */ l1sap.u.rach_ind.is_11bit = 0; l1sap.u.rach_ind.fn = fn; - /* we don't rally know which RACH bursrt type the virtual MS is using, as this field is not + /* we don't really know which RACH burst type the virtual MS is using, as this field is not * part of information present in the GSMTAP header. So we simply report all of them as 0 */ l1sap.u.rach_ind.burst_type = GSM_L1_BURST_TYPE_ACCESS_0; break; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15270 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id24e75812bda17e99f17a37b367462533a5607f9 Gerrit-Change-Number: 15270 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in ...libosmocore[master]: Cosmetic: l1sap.h: change /* !< to /*!
osmith has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/15269
Change subject: Cosmetic: l1sap.h: change /* !< to /*!<
..
Cosmetic: l1sap.h: change /* !< to /*!<
Change-Id: Icaec95a9c6105fd17bc1151fdc77394f4efd3b70
---
M include/osmocom/gsm/l1sap.h
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/69/15269/1
diff --git a/include/osmocom/gsm/l1sap.h b/include/osmocom/gsm/l1sap.h
index 19cc87a..3d2ad25 100644
--- a/include/osmocom/gsm/l1sap.h
+++ b/include/osmocom/gsm/l1sap.h
@@ -67,8 +67,8 @@
/* elements added on 2018-02-26 */
int8_t rssi;/*!< RSSI of RACH indication */
uint16_t ber10k;/*!< BER in units of 0.01% */
- int16_t acc_delay_256bits;/* !< Burst TA Offset in 1/256th bits */
- int16_t lqual_cb; /* !< Link quality in centiBel */
+ int16_t acc_delay_256bits;/*!< Burst TA Offset in 1/256th bits */
+ int16_t lqual_cb; /*!< Link quality in centiBel */
};
/*! for PH-[UNIT]DATA.{req,ind} | PH-RTS.ind */
@@ -79,10 +79,10 @@
int8_t rssi;/*!< RSSI of receivedindication */
uint16_t ber10k;/*!< BER in units of 0.01% */
union {
- int16_t ta_offs_qbits; /* !< Burst TA Offset in quarter bits */
+ int16_t ta_offs_qbits; /*!< Burst TA Offset in quarter bits */
int16_t ta_offs_256bits;/*!< timing advance offset (in 1/256th
bits) */
};
- int16_t lqual_cb; /* !< Link quality in centiBel */
+ int16_t lqual_cb; /*!< Link quality in centiBel */
enum osmo_ph_pres_info_type pdch_presence_info; /*!< Info regarding
presence/validity of header and data parts */
};
@@ -93,7 +93,7 @@
int8_t rssi;/*!< RSSI of received indication */
uint8_t marker; /*!< RTP Marker bit (speech onset indicator) */
uint16_t ber10k;/*!< BER in units of 0.01% */
- int16_t lqual_cb; /* !< Link quality in centiBel */
+ int16_t lqual_cb; /*!< Link quality in centiBel */
};
/*! for PH-CONN.ind */
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15269
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icaec95a9c6105fd17bc1151fdc77394f4efd3b70
Gerrit-Change-Number: 15269
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-MessageType: newchange
Change in ...osmo-sgsn[master]: gprs_gmm.c: Print value_string of reject cause
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15263 ) Change subject: gprs_gmm.c: Print value_string of reject cause .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15263 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I71d9abcf7e3a836c475b7adbb95a82580e41ae6d Gerrit-Change-Number: 15263 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Aug 2019 07:00:46 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: gprs_gmm.c: Add spec document to function documentation
laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/15264 )
Change subject: gprs_gmm.c: Add spec document to function documentation
..
gprs_gmm.c: Add spec document to function documentation
Change-Id: Ibb89499e9c1ab588336df34fde26faf3fbf2c72c
---
M src/gprs/gprs_gmm.c
1 file changed, 16 insertions(+), 16 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index 1d8ec57..e44b3ec 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -674,7 +674,7 @@
return false;
}
-/* 3GPP TS 24.008 Section 9.4.9: Authentication and Ciphering Request */
+/* 3GPP TS 24.008 § 9.4.9: Authentication and Ciphering Request */
int gsm48_tx_gmm_auth_ciph_req(struct sgsn_mm_ctx *mm,
const struct osmo_auth_vector *vec,
uint8_t key_seq, bool force_standby)
@@ -742,7 +742,7 @@
return gsm48_gmm_sendmsg(msg, 1, mm, false);
}
-/* Section 9.4.11: Authentication and Ciphering Reject */
+/* 3GPP TS 24.008 § 9.4.11: Authentication and Ciphering Reject */
static int gsm48_tx_gmm_auth_ciph_rej(struct sgsn_mm_ctx *mm)
{
struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 AUTH CIPH REJ");
@@ -815,7 +815,7 @@
return OSMO_AUTH_TYPE_NONE;
}
-/* Section 9.4.10: Authentication and Ciphering Response */
+/* 3GPP TS 24.008 § 9.4.10: Authentication and Ciphering Response */
static int gsm48_rx_gmm_auth_ciph_resp(struct sgsn_mm_ctx *ctx,
struct msgb *msg)
{
@@ -892,7 +892,7 @@
return osmo_fsm_inst_dispatch(ctx->gmm_att_req.fsm,
E_AUTH_RESP_RECV_SUCCESS, NULL);
}
-/* Section 9.4.10: Authentication and Ciphering Failure */
+/* 3GPP TS 24.008 § 9.4.10: Authentication and Ciphering Failure */
static int gsm48_rx_gmm_auth_ciph_fail(struct sgsn_mm_ctx *ctx,
struct msgb *msg)
{
@@ -1357,7 +1357,7 @@
ctx->gmm_state = GMM_COMMON_PROC_INIT;
}
-/* Section 9.4.1 Attach request */
+/* 3GPP TS 24.008 § 9.4.1 Attach request */
static int gsm48_rx_gmm_att_req(struct sgsn_mm_ctx *ctx, struct msgb *msg,
struct gprs_llc_llme *llme)
{
@@ -1569,7 +1569,7 @@
return !!memcmp(gh_a, gh_b, GMM_ATTACH_REQ_LEN);
}
-/* Section 4.7.4.1 / 9.4.5.2 MO Detach request */
+/* 3GPP TS 24.008 § 4.7.4.1 / 9.4.5.2 MO Detach request */
static int gsm48_rx_gmm_det_req(struct sgsn_mm_ctx *ctx, struct msgb *msg)
{
struct gsm48_hdr *gh = (struct gsm48_hdr *) msgb_gmmh(msg);
@@ -1707,7 +1707,7 @@
}
}
-/* 3GPP TS 24.008 Section 4.7.13.4 Service request procedure not accepted by
the
+/* 3GPP TS 24.008 § 4.7.13.4 Service request procedure not accepted by the
* network. Returns true if MS has active PDP contexts in pdp_status */
bool pdp_status_has_active_nsapis(const uint8_t *pdp_status, const size_t
pdp_status_len)
{
@@ -1919,7 +1919,7 @@
return rc;
}
-/* 3GPP TS 24.008 Section 9.4.20 Service request.
+/* 3GPP TS 24.008 § 9.4.20 Service request.
* In Iu, a UE in PMM-IDLE mode can use GSM48_MT_GMM_SERVICE_REQ to switch back
* to PMM-CONNECTED mode. */
static int gsm48_rx_gmm_service_req(struct sgsn_mm_ctx *ctx, struct msgb *msg)
@@ -2009,7 +2009,7 @@
process_ms_ctx_status(ctx, pdp_status);
- /* 3GPP TS 24.008 Section 4.7.13.4 Service request procedure not
+ /* 3GPP TS 24.008 § 4.7.13.4 Service request procedure not
* accepted by the network. Cause #40. If MS has PDP Contexts in
* Active state in pdp_status but there is no PDP contexts on
* SGSN side then Reject with the cause will force the mobile to
@@ -2403,7 +2403,7 @@
}
#endif
-/* Section 9.5.2: Activate PDP Context Accept */
+/* 3GPP TS 24.008 § 9.5.2: Activate PDP Context Accept */
int gsm48_tx_gsm_act_pdp_acc(struct sgsn_pdp_ctx *pdp)
{
struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 PDP ACC");
@@ -2447,7 +2447,7 @@
return gsm48_gmm_sendmsg(msg, 0, pdp->mm, true);
}
-/* Section 9.5.3: Activate PDP Context reject */
+/* 3GPP TS 24.008 § 9.5.3: Activate PDP Context reject */
int gsm48_tx_gsm_act_pdp_rej(struct sgsn_mm_ctx *mm, uint8_t tid,
uint8_t cause, uint8_t pco_len, uint8_t *pco_v)
{
@@ -2472,7 +2472,7 @@
return gsm48_gmm_sendmsg(msg, 0, mm, true);
}
-/* Section 9.5.8: Deactivate PDP Context Request */
+/* 3GPP TS 24.008 § 9.5.8: Deactivate PDP Context Request */
static int _gsm48_tx_gsm_deact_pdp_req(struct sgsn_mm_ctx *mm, uint8_t tid,
uint8_t sm_cause, bool teardown)
{
@@ -2502,7 +2502,7 @@
return _gsm48_tx_gsm_deact_pdp_req(pdp->mm, pdp->ti, sm_cause,
teardown);
}
-/* Section 9.5.9: Deactivate PDP Context
Change in ...osmo-sgsn[master]: gprs_gmm.c: Print value_string of reject cause
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15263 ) Change subject: gprs_gmm.c: Print value_string of reject cause .. gprs_gmm.c: Print value_string of reject cause Change-Id: I71d9abcf7e3a836c475b7adbb95a82580e41ae6d --- M src/gprs/gprs_gmm.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c index dccec2b..1d8ec57 100644 --- a/src/gprs/gprs_gmm.c +++ b/src/gprs/gprs_gmm.c @@ -2455,7 +2455,8 @@ struct gsm48_hdr *gh; uint8_t transaction_id = tid ^ 0x8; /* flip */ - LOGMMCTXP(LOGL_NOTICE, mm, "<- ACTIVATE PDP CONTEXT REJ(cause=%u)\n", cause); + LOGMMCTXP(LOGL_NOTICE, mm, "<- ACTIVATE PDP CONTEXT REJ: %s\n", + get_value_string(gsm48_gsm_cause_names, cause)); rate_ctr_inc(>rate_ctrs->ctr[CTR_PDP_ACTIVATE_REJECT]); mmctx2msgid(msg, mm); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15263 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I71d9abcf7e3a836c475b7adbb95a82580e41ae6d Gerrit-Change-Number: 15263 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in ...osmo-sgsn[master]: gprs_gmm.c: Add spec document to function documentation
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15264 ) Change subject: gprs_gmm.c: Add spec document to function documentation .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ibb89499e9c1ab588336df34fde26faf3fbf2c72c Gerrit-Change-Number: 15264 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Aug 2019 07:00:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ggsn[master]: libgtp: announce pdp ctx deletion upon CreatePdpCtx being rejected
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15259 ) Change subject: libgtp: announce pdp ctx deletion upon CreatePdpCtx being rejected .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15259 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I6c6215a4ce478afabc78ffaf5ffb0cf829e41226 Gerrit-Change-Number: 15259 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Aug 2019 07:00:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: ggsn: Introduce test TC_pdp46_act_deact_apn4
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15262 ) Change subject: ggsn: Introduce test TC_pdp46_act_deact_apn4 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1893e0c181307ac1ceb07ee5f496507f7a603c8 Gerrit-Change-Number: 15262 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Aug 2019 06:54:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-trx[master]: Drop old setPriority related code
laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-trx/+/15258 )
Change subject: Drop old setPriority related code
..
Drop old setPriority related code
This code is not needed anymore since we are setting SCHED_RR scheduler
with a real time priority in main thread during startup, so all threads
will inherit same rt priority, which should be enough to keep the
process working reliably even on high system loads (from non rt
processes).
osmo-trx was tested to be reliable during test with stress-ng as
explained in related ticket below.
Related: OS#2344
Change-Id: I3a88946dd71e9aeeaac9d19d396e2236c302b608
---
M Transceiver52M/Transceiver.cpp
M Transceiver52M/Transceiver.h
M Transceiver52M/device/common/radioDevice.h
M Transceiver52M/device/lms/LMSDevice.h
M Transceiver52M/device/uhd/UHDDevice.cpp
M Transceiver52M/device/uhd/UHDDevice.h
M Transceiver52M/device/usrp1/USRPDevice.h
M Transceiver52M/radioInterface.h
8 files changed, 0 insertions(+), 32 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp
index 4da1876..2d5c04e 100644
--- a/Transceiver52M/Transceiver.cpp
+++ b/Transceiver52M/Transceiver.cpp
@@ -1126,8 +1126,6 @@
snprintf(thread_name, 16, "RxUpper%zu", num);
set_selfthread_name(thread_name);
- trx->setPriority(0.42);
-
while (1) {
trx->driveReceiveFIFO(num);
pthread_testcancel();
@@ -1139,8 +1137,6 @@
{
set_selfthread_name("RxLower");
- transceiver->setPriority(0.45);
-
while (1) {
transceiver->driveReceiveRadio();
pthread_testcancel();
@@ -1152,8 +1148,6 @@
{
set_selfthread_name("TxLower");
- transceiver->setPriority(0.44);
-
while (1) {
transceiver->driveTxFIFO();
pthread_testcancel();
@@ -1190,8 +1184,6 @@
snprintf(thread_name, 16, "TxUpper%zu", num);
set_selfthread_name(thread_name);
- trx->setPriority(0.40);
-
while (1) {
trx->driveTxPriorityQueue(num);
pthread_testcancel();
diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h
index 18dc5f2..1a4d28f 100644
--- a/Transceiver52M/Transceiver.h
+++ b/Transceiver52M/Transceiver.h
@@ -247,9 +247,6 @@
void reset();
- /** set priority on current thread */
- void setPriority(float prio = 0.5) { mRadioInterface->setPriority(prio); }
-
void logRxBurst(size_t chan, const struct trx_ul_burst_ind *bi);
};
diff --git a/Transceiver52M/device/common/radioDevice.h
b/Transceiver52M/device/common/radioDevice.h
index cd378a8..e637611 100644
--- a/Transceiver52M/device/common/radioDevice.h
+++ b/Transceiver52M/device/common/radioDevice.h
@@ -70,9 +70,6 @@
/** Get the Tx window type */
virtual enum TxWindowType getWindowType()=0;
- /** Enable thread priority */
- virtual void setPriority(float prio = 0.5) = 0;
-
/**
Read samples from the radio.
@param buf preallocated buf to contain read result
diff --git a/Transceiver52M/device/lms/LMSDevice.h
b/Transceiver52M/device/lms/LMSDevice.h
index bc79f97..47bac94 100644
--- a/Transceiver52M/device/lms/LMSDevice.h
+++ b/Transceiver52M/device/lms/LMSDevice.h
@@ -85,10 +85,6 @@
/** Stop the LMS */
bool stop();
- /** Set priority not supported */
- void setPriority(float prio = 0.5) {
- }
-
enum TxWindowType getWindowType() {
return TX_WINDOW_LMS1;
}
diff --git a/Transceiver52M/device/uhd/UHDDevice.cpp
b/Transceiver52M/device/uhd/UHDDevice.cpp
index 8bb94d6..5b38df4 100644
--- a/Transceiver52M/device/uhd/UHDDevice.cpp
+++ b/Transceiver52M/device/uhd/UHDDevice.cpp
@@ -125,7 +125,6 @@
void *async_event_loop(uhd_device *dev)
{
set_selfthread_name("UHDAsyncEvent");
- dev->setPriority(0.43);
while (1) {
dev->recv_async_msg();
@@ -643,12 +642,6 @@
return true;
}
-void uhd_device::setPriority(float prio)
-{
- uhd::set_thread_priority_safe(prio);
- return;
-}
-
int uhd_device::check_rx_md_err(uhd::rx_metadata_t , ssize_t num_smpls)
{
if (!num_smpls) {
diff --git a/Transceiver52M/device/uhd/UHDDevice.h
b/Transceiver52M/device/uhd/UHDDevice.h
index d5a6348..944578a 100644
--- a/Transceiver52M/device/uhd/UHDDevice.h
+++ b/Transceiver52M/device/uhd/UHDDevice.h
@@ -71,7 +71,6 @@
bool start();
bool stop();
bool restart();
- void setPriority(float prio);
enum TxWindowType getWindowType() { return tx_window; }
int readSamples(std::vector , int len, bool *overrun,
diff --git a/Transceiver52M/device/usrp1/USRPDevice.h
b/Transceiver52M/device/usrp1/USRPDevice.h
index 9a2426c..4123c7d 100644
--- a/Transceiver52M/device/usrp1/USRPDevice.h
+++ b/Transceiver52M/device/usrp1/USRPDevice.h
@@ -107,9 +107,6 @@
/** Stop the USRP */
bool stop();
- /** Set priority not supported */
- void
Change in ...osmo-trx[master]: Drop old setPriority related code
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15258 ) Change subject: Drop old setPriority related code .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I3a88946dd71e9aeeaac9d19d396e2236c302b608 Gerrit-Change-Number: 15258 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Aug 2019 06:55:07 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: ggsn: Add missing v4v6 tests in expected-results.xml
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15260 ) Change subject: ggsn: Add missing v4v6 tests in expected-results.xml .. ggsn: Add missing v4v6 tests in expected-results.xml Change-Id: I80598fad57b8e7172ac073ebe2b3445e5ab132f0 --- M ggsn_tests/expected-results.xml 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/ggsn_tests/expected-results.xml b/ggsn_tests/expected-results.xml index c60a804..445d566 100644 --- a/ggsn_tests/expected-results.xml +++ b/ggsn_tests/expected-results.xml @@ -19,6 +19,13 @@ + + + + + + + -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15260 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I80598fad57b8e7172ac073ebe2b3445e5ab132f0 Gerrit-Change-Number: 15260 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in ...osmo-ttcn3-hacks[master]: ggsn: Update test xfail->pass in expected-results.xml
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15261 ) Change subject: ggsn: Update test xfail->pass in expected-results.xml .. ggsn: Update test xfail->pass in expected-results.xml Commit below fixed the test but forgot to update this file. Fixes: 8e7a396656f8d32c44254de0c65f26c6a2c833f2 Change-Id: Ia5006c9258de9b442b32ae92ae75ef08670de7cf --- M ggsn_tests/expected-results.xml 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/ggsn_tests/expected-results.xml b/ggsn_tests/expected-results.xml index 445d566..e57a7df 100644 --- a/ggsn_tests/expected-results.xml +++ b/ggsn_tests/expected-results.xml @@ -8,12 +8,7 @@ - -Secondary DNS IPv4 PCO option not found - GGSN_Tests.ttcn:MASKED GGSN_Tests control part - GGSN_Tests.ttcn:MASKED TC_pdp4_act_deact_with_separate_dns testcase - - + -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15261 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia5006c9258de9b442b32ae92ae75ef08670de7cf Gerrit-Change-Number: 15261 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in ...osmo-ttcn3-hacks[master]: ggsn: Introduce test TC_pdp46_act_deact_apn4
laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15262 )
Change subject: ggsn: Introduce test TC_pdp46_act_deact_apn4
..
ggsn: Introduce test TC_pdp46_act_deact_apn4
Related osmo-ggsn.git libgtp fix: I6c6215a4ce478afabc78ffaf5ffb0cf829e41226
Related: OS#4154
Change-Id: Ia1893e0c181307ac1ceb07ee5f496507f7a603c8
---
M ggsn_tests/GGSN_Tests.ttcn
M ggsn_tests/expected-results.xml
2 files changed, 26 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn
index 31c1056..ae92626 100644
--- a/ggsn_tests/GGSN_Tests.ttcn
+++ b/ggsn_tests/GGSN_Tests.ttcn
@@ -247,7 +247,7 @@
}
/* send a PDP context activation */
- function f_pdp_ctx_act(inout PdpContext ctx) runs on GT_CT {
+ function f_pdp_ctx_act(inout PdpContext ctx, OCT1 exp_cause := '80'O)
runs on GT_CT {
var Gtp1cUnitdata ud;
var default d;
@@ -260,7 +260,7 @@
alt {
[] GTPC.receive(tr_GTPC_MsgType(g_peer_c,
createPDPContextResponse, ctx.teic)) -> value ud {
var CreatePDPContextResponse cpr :=
ud.gtpc.gtpc_pdu.createPDPContextResponse;
- if (cpr.cause.causevalue == '80'O) {
+ if (exp_cause == '80'O and exp_cause ==
cpr.cause.causevalue) {
/* Check if EUA type corresponds to
requested type */
if (match(ctx.eua, t_EuaIPv4(?)) and
not match(cpr.endUserAddress,
tr_EuaIPv4(?))){
@@ -292,6 +292,12 @@
ctx.eua := cpr.endUserAddress;
ctx.pco_neg := cpr.protConfigOptions;
setverdict(pass);
+ } else if (exp_cause != '80'O and exp_cause ==
cpr.cause.causevalue) {
+ if (ispresent(cpr.endUserAddress)) {
+ log("EUA received on
createPDPContextResponse cause=" & oct2str(cpr.cause.causevalue));
+ setverdict(fail);
+ }
+ setverdict(pass);
} else {
setverdict(fail);
}
@@ -1287,6 +1293,22 @@
f_pdp_ctx_del(ctxA, '1'B);
}
+ /* Test IPv4v6 context activation for dynamic IPv4v6 EUA on a v4-only
APN */
+ testcase TC_pdp46_act_deact_apn4() runs on GT_CT {
+ f_init();
+ /* A typical MS first attempts v4v6, and if rejected, then
tries v4 and v6 separetly */
+ var PdpContext ctx46 :=
valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInternet,
valueof(t_EuaIPv4Dynv6Dyn)));
+ f_pdp_ctx_act(ctx46, 'DC'O); /* Cause: Unknown PDP address or
PDP type */
+
+ var PdpContext ctx4 :=
valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInternet,
valueof(t_EuaIPv4Dyn)));
+ f_pdp_ctx_act(ctx4, '80'O); /* Normal accept cause */
+
+ var PdpContext ctx6 :=
valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInternet,
valueof(t_EuaIPv6Dyn)));
+ f_pdp_ctx_act(ctx6, 'DC'O); /* Cause: Unknown PDP address or
PDP type */
+
+ f_pdp_ctx_del(ctx4, '1'B);
+ }
+
/* Send a duplicate echo req. osmo-ggsn maintains a queue for sent
responses (60 seconds): If same delete req is sent and duplicate is
detected, saved duplicate response should be sent back. */
@@ -1332,6 +1354,7 @@
execute(TC_pdp46_act_deact_pcodns6());
execute(TC_pdp46_act_deact_gtpu_access());
execute(TC_pdp46_clients_interact());
+ execute(TC_pdp46_act_deact_apn4());
execute(TC_echo_req_resp());
execute(TC_act_deact_retrans_duplicate());
diff --git a/ggsn_tests/expected-results.xml b/ggsn_tests/expected-results.xml
index e57a7df..374cde0 100644
--- a/ggsn_tests/expected-results.xml
+++ b/ggsn_tests/expected-results.xml
@@ -21,6 +21,7 @@
+
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15262
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia1893e0c181307ac1ceb07ee5f496507f7a603c8
Gerrit-Change-Number: 15262
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in ...osmo-ttcn3-hacks[master]: ggsn: Add missing v4v6 tests in expected-results.xml
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15260 ) Change subject: ggsn: Add missing v4v6 tests in expected-results.xml .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15260 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I80598fad57b8e7172ac073ebe2b3445e5ab132f0 Gerrit-Change-Number: 15260 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Aug 2019 06:53:51 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: ggsn: Update test xfail->pass in expected-results.xml
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15261 ) Change subject: ggsn: Update test xfail->pass in expected-results.xml .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15261 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia5006c9258de9b442b32ae92ae75ef08670de7cf Gerrit-Change-Number: 15261 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Aug 2019 06:53:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: mgcp_send(): stop looping on conversion error
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15243 ) Change subject: mgcp_send(): stop looping on conversion error .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15243 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iba115a0b1d74e7cefba5dcdd777e98ddea9eba8c Gerrit-Change-Number: 15243 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Aug 2019 06:43:04 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: fix crashes: don't assert on incoming RTP packet size
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15242 ) Change subject: fix crashes: don't assert on incoming RTP packet size .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6bc6ee950ce07bcc2c585c30fad02b81153bdde2 Gerrit-Change-Number: 15242 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Aug 2019 06:42:32 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-iuh[master]: hnbgw_vty.c: fix: properly pass pointer to g_hnb_gw
laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-iuh/+/15268 )
Change subject: hnbgw_vty.c: fix: properly pass pointer to g_hnb_gw
..
hnbgw_vty.c: fix: properly pass pointer to g_hnb_gw
Otherwise the process hangs if the user enters:
$ show hnb NAME
hnbgw_vty.c: In function ‘show_one_hnb’:
hnbgw_vty.c:234:2: warning: passing argument 1 of
‘hnb_context_by_identity_info’
from incompatible pointer type
[enabled by default]
iuh/hnbgw.h:154:21: note: expected ‘struct hnb_gw *’
but argument is of type ‘struct hnb_gw **’
Change-Id: I42fdb10af5f6427886b5797325830dfc212af30f
---
M src/hnbgw_vty.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/hnbgw_vty.c b/src/hnbgw_vty.c
index 15fdaf8..84a5f01 100644
--- a/src/hnbgw_vty.c
+++ b/src/hnbgw_vty.c
@@ -231,7 +231,7 @@
return CMD_SUCCESS;
}
- hnb = hnb_context_by_identity_info(_hnb_gw, identity_info);
+ hnb = hnb_context_by_identity_info(g_hnb_gw, identity_info);
if (hnb == NULL) {
vty_out(vty, "No HNB found with identity '%s'%s",
identity_info, VTY_NEWLINE);
return CMD_SUCCESS;
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15268
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I42fdb10af5f6427886b5797325830dfc212af30f
Gerrit-Change-Number: 15268
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in ...osmo-iuh[master]: hnbgw_vty.c: fix: properly pass pointer to g_hnb_gw
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15268 ) Change subject: hnbgw_vty.c: fix: properly pass pointer to g_hnb_gw .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15268 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I42fdb10af5f6427886b5797325830dfc212af30f Gerrit-Change-Number: 15268 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Aug 2019 06:42:02 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
