Change in osmo-ttcn3-hacks[master]: hlr: add TC_MSLookup_mDNS_server

2020-01-19 Thread osmith
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16914

to look at the new patch set (#8).

Change subject: hlr: add TC_MSLookup_mDNS_server
..

hlr: add TC_MSLookup_mDNS_server

Send an mslookup mDNS request to OsmoHLR and verify the answer.

Related: SYS#4618
Depends: osmo-hlr I2fe453553c90e6ee527ed13a13089900efd488aa
Change-Id: Ia7f92d33691f910549353b16a7b0efc18e521719
---
M hlr/HLR_Tests.cfg
M hlr/HLR_Tests.default
M hlr/HLR_Tests.ttcn
M hlr/gen_links.sh
M hlr/regen_makefile.sh
A library/MSLookup_mDNS_Emulation.ttcn
A library/MSLookup_mDNS_Templates.ttcn
A library/MSLookup_mDNS_Types.ttcn
8 files changed, 274 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/14/16914/8
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16914
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia7f92d33691f910549353b16a7b0efc18e521719
Gerrit-Change-Number: 16914
Gerrit-PatchSet: 8
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith 
Gerrit-CC: pespin 
Gerrit-MessageType: newpatchset


Change in osmo-ttcn3-hacks[master]: deps: use UDPasp from osmocom github fork

2020-01-19 Thread osmith
osmith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16913 )

Change subject: deps: use UDPasp from osmocom github fork
..

deps: use UDPasp from osmocom github fork

Has additional SO_REUSEADDR patch, which is needed for D-GSM mslookup
mDNS testing.

Related: SYS#4618
Change-Id: Ie7e1c3dbd67dba9079a5768e442faffc936fd7fa
---
M deps/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/deps/Makefile b/deps/Makefile
index b816c8f..b04db9d 100644
--- a/deps/Makefile
+++ b/deps/Makefile
@@ -40,7 +40,6 @@
titan.TestPorts.SIPmsg \
titan.TestPorts.TCPasp \
titan.TestPorts.TELNETasp \
-   titan.TestPorts.UDPasp \
titan.TestPorts.UNIX_DOMAIN_SOCKETasp

 ECLIPSEGIT2_REPOS= titan.ProtocolModules.GRE \
@@ -64,6 +63,7 @@

 OSMOGITHUB_REPOS=  titan.TestPorts.SCTPasp \
titan.TestPorts.MTP3asp \
+   titan.TestPorts.UDPasp \
titan.ProtocolEmulations.M3UA \
titan.ProtocolEmulations.SCCP


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16913
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie7e1c3dbd67dba9079a5768e442faffc936fd7fa
Gerrit-Change-Number: 16913
Gerrit-PatchSet: 4
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in osmo-ttcn3-hacks[master]: deps: use UDPasp from osmocom github fork

2020-01-19 Thread osmith
osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16913 )

Change subject: deps: use UDPasp from osmocom github fork
..


Patch Set 3: Code-Review+2

1+1=2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16913
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie7e1c3dbd67dba9079a5768e442faffc936fd7fa
Gerrit-Change-Number: 16913
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 20 Jan 2020 07:32:37 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-ttcn3-hacks[master]: hlr: f_perform_UL: add CnDomain parameter

2020-01-19 Thread osmith
osmith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16911 )

Change subject: hlr: f_perform_UL: add CnDomain parameter
..

hlr: f_perform_UL: add CnDomain parameter

Make it possible to do CS location update, not only PS. This is needed
for upcoming D-GSM related tests.

Related: SYS#4618
Change-Id: Idd699f054c9242614b9bea066428293f8b2da9c2
---
M hlr/HLR_Tests.ttcn
M library/GSUP_Types.ttcn
2 files changed, 5 insertions(+), 4 deletions(-)

Approvals:
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn
index 4caa88e..b59f86e 100644
--- a/hlr/HLR_Tests.ttcn
+++ b/hlr/HLR_Tests.ttcn
@@ -447,7 +447,8 @@
 }

 function f_perform_UL(hexstring imsi, template hexstring msisdn,
-   template (omit) integer exp_err_cause := omit)
+   template (omit) integer exp_err_cause := omit,
+   GSUP_CnDomain dom := OSMO_GSUP_CN_DOMAIN_PS)
 runs on HLR_ConnHdlr return GSUP_PDU {
var GSUP_PDU ret;
timer T := 3.0;
@@ -457,7 +458,7 @@
exp_fail := true;
}

-   GSUP.send(valueof(ts_GSUP_UL_REQ(imsi)));
+   GSUP.send(valueof(ts_GSUP_UL_REQ(imsi, dom)));
T.start;
alt {
[exp_fail] GSUP.receive(tr_GSUP_UL_ERR(imsi, exp_err_cause)) -> value 
ret {
diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn
index 880a6ad..0f36d4d 100644
--- a/library/GSUP_Types.ttcn
+++ b/library/GSUP_Types.ttcn
@@ -495,9 +495,9 @@
tr_GSUP(OSMO_GSUP_MSGT_SEND_AUTH_INFO_RESULT, {
tr_GSUP_IE_IMSI(imsi), *, 
tr_GSUP_IE(OSMO_GSUP_AUTH_TUPLE_IE), * });

-template (value) GSUP_PDU ts_GSUP_UL_REQ(hexstring imsi) :=
+template (value) GSUP_PDU ts_GSUP_UL_REQ(hexstring imsi, GSUP_CnDomain dom := 
OSMO_GSUP_CN_DOMAIN_PS) :=
ts_GSUP(OSMO_GSUP_MSGT_UPDATE_LOCATION_REQUEST, {
-   valueof(ts_GSUP_IE_IMSI(imsi)) });
+   valueof(ts_GSUP_IE_IMSI(imsi)), 
valueof(ts_GSUP_IE_CnDomain(dom)) });

 template GSUP_PDU tr_GSUP_UL_REQ(template hexstring imsi) :=
tr_GSUP_IMSI(OSMO_GSUP_MSGT_UPDATE_LOCATION_REQUEST, imsi);

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16911
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Idd699f054c9242614b9bea066428293f8b2da9c2
Gerrit-Change-Number: 16911
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in osmo-ttcn3-hacks[master]: hlr: f_perform_UL: add CnDomain parameter

2020-01-19 Thread osmith
osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16911 )

Change subject: hlr: f_perform_UL: add CnDomain parameter
..


Patch Set 2: Code-Review+2

> Patch Set 2: Code-Review+1
>
> (2 comments)
>
> Not a merge blocker, but might be a desirable feature.

Then I'll leave it like it is for now. Thanks!


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16911
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Idd699f054c9242614b9bea066428293f8b2da9c2
Gerrit-Change-Number: 16911
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 20 Jan 2020 07:31:37 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-ttcn3-hacks[master]: deps: add titan.ProtocolModules.DNS

2020-01-19 Thread osmith
osmith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16912 )

Change subject: deps: add titan.ProtocolModules.DNS
..

deps: add titan.ProtocolModules.DNS

To be used in mslookup mDNS tests.

Related: SYS#4618
Change-Id: I89dd528b7934892c5a24209374e8218a95db6ab3
---
M deps/Makefile
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/deps/Makefile b/deps/Makefile
index 043aaa3..b816c8f 100644
--- a/deps/Makefile
+++ b/deps/Makefile
@@ -19,6 +19,7 @@
 OSMOGIT:=git://git.osmocom.org

 ECLIPSEGIT_REPOS=  titan.Libraries.TCCUsefulFunctions \
+   titan.ProtocolModules.DNS \
titan.ProtocolModules.ICMP \
titan.ProtocolModules.ICMPv6 \
titan.ProtocolModules.IP \
@@ -81,6 +82,7 @@
 titan.ProtocolModules.BSSAPP_v7.3.0_commit=R.2.A-4-g20cfaf8
 titan.ProtocolModules.BSSGP_v13.0.0_commit=R.2.A-6-gc447f28
 titan.ProtocolModules.BSSMAP_commit=   master
+titan.ProtocolModules.DNS_commit=  R.7.B
 titan.ProtocolModules.GRE_commit=  R.2.A-5-g654c446
 titan.ProtocolModules.GTP_v13.5.0_commit=  R.2.A-5-ge120ace
 titan.ProtocolModules.GTPv2_v13.7.0_commit=R.2.A-5-g85cb124

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16912
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I89dd528b7934892c5a24209374e8218a95db6ab3
Gerrit-Change-Number: 16912
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in osmo-ttcn3-hacks[master]: deps: add titan.ProtocolModules.DNS

2020-01-19 Thread osmith
osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16912 )

Change subject: deps: add titan.ProtocolModules.DNS
..


Patch Set 2: Code-Review+2

1+1=2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16912
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I89dd528b7934892c5a24209374e8218a95db6ab3
Gerrit-Change-Number: 16912
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 20 Jan 2020 07:32:13 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Build failure of network:osmocom:nightly/libosmo-netif in Debian_10/armv7l

2020-01-19 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Debian_10/armv7l

Package network:osmocom:nightly/libosmo-netif failed to build in 
Debian_10/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmo-netif

Last lines of build log:
[  337s] | configure:4747: /usr/bin/nm -B "conftest.o"
[  337s] | configure:4750: output
[  337s] |  B some_variable
[  337s] | configure:4751: result: BSD nm
[  337s] | configure:4754: checking whether ln -s works
[  337s] | configure:4758: result: yes
[  337s] | configure:4766: checking the maximum length of command line arguments
[  337s] | configure:4897: result: 1572864
[  337s] | configure:4945: checking how to convert arm-unknown-linux-gnueabihf 
file names to arm-unknown-linux-gnueabihf format
[  337s] | configure:4985: result: func_convert_file_noop
[  337s] | configure:4992: checking how to convert arm-unknown-linux-gnueabihf 
file names to toolchain format
[  337s] | configure:5012: result: func_convert_file_noop
[  337s] | configure:5019: checking for /usr/bin/ld option to reload object 
files
[  337s] | configure:5026: result: -r
[  337s] | configure:5100: checking for objdump
[  337s] | configure:5116: found /usr/bin/objdump
[  337s] | configure:5127: result: objdump
[  337s] | configure:5159: checking how to recognize dependent libraries
[  337s] | configure:5359: result: pass_all
[  337s] | configure:5444: checking for dlltool
[  337s] | configure:5474: result: no
[  337s] | configure:5504: checking how to associate runtime and link libraries
[  337s] | configure:5531: result: printf %s\n
[  337s] | configure:5592: checking for ar
[  337s] | configure:5608: found /usr/bin/ar
[  337s] | configure:5619: result: ar
[  339s] | configure:[  298.389292] sysrq: SysRq : Power Off
[  339s] [  298.425516] reboot: Power down
[  339s] ### VM INTERACTION END ###

-- 
Configure notifications at https://build.opensuse.org/my/notifications
openSUSE Build Service (https://build.opensuse.org/)


Change in osmo-msc[master]: msc/signal.h: remove unused (since the NiTB split up) signals

2020-01-19 Thread fixeria
fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/16938 )


Change subject: msc/signal.h: remove unused (since the NiTB split up) signals
..

msc/signal.h: remove unused (since the NiTB split up) signals

Change-Id: I3848d0db3c62de7613f609ad632641eb54453817
---
M include/osmocom/msc/signal.h
1 file changed, 0 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/38/16938/1

diff --git a/include/osmocom/msc/signal.h b/include/osmocom/msc/signal.h
index c7f8991..9153131 100644
--- a/include/osmocom/msc/signal.h
+++ b/include/osmocom/msc/signal.h
@@ -70,15 +70,6 @@
S_SCALL_DETACHED,
 };

-/* SS_IPAC_NWL signals */
-enum signal_ipaccess {
-   S_IPAC_NWL_COMPLETE,
-};
-
-enum signal_global {
-   S_GLOBAL_BTS_CLOSE_OM,
-};
-
 struct paging_signal_data {
struct vlr_subscr *vsub;
struct msc_a *msc_a;

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/16938
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I3848d0db3c62de7613f609ad632641eb54453817
Gerrit-Change-Number: 16938
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange


Change in libosmocore[master]: osmo_libusb: Check return of libusb_get_string_descriptor_ascii()

2020-01-19 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/16927 )

Change subject: osmo_libusb: Check return of 
libusb_get_string_descriptor_ascii()
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16927
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ifc0133737627a8277635f8f3662b3f6e922be149
Gerrit-Change-Number: 16927
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Sun, 19 Jan 2020 16:10:07 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in libosmo-sccp[master]: sccp: Fix wrong param type in osmo_sccp_pnc_name()

2020-01-19 Thread pespin
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/16924 )

Change subject: sccp: Fix wrong param type in osmo_sccp_pnc_name()
..

sccp: Fix wrong param type in osmo_sccp_pnc_name()

Wrong type was used when the function was introduced a few commits ago.

Fixes: 5a7eb34f735e0ae93a74da3bc8361454457e49cdi
Closes: CID#207712
Change-Id: Ie9b89483158dd6b988e4c34b497bf3b231c15cd3
---
M include/osmocom/sccp/sccp_types.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/include/osmocom/sccp/sccp_types.h 
b/include/osmocom/sccp/sccp_types.h
index f43f822..09bf271 100644
--- a/include/osmocom/sccp/sccp_types.h
+++ b/include/osmocom/sccp/sccp_types.h
@@ -81,7 +81,7 @@
 };

 extern const struct value_string osmo_sccp_pnc_names[];
-static inline const char *osmo_sccp_pnc_name(enum sccp_message_types val)
+static inline const char *osmo_sccp_pnc_name(enum sccp_parameter_name_codes 
val)
 { return get_value_string(osmo_sccp_pnc_names, val); }

 /* Figure 3/Q.713 Called/calling party address */

--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16924
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ie9b89483158dd6b988e4c34b497bf3b231c15cd3
Gerrit-Change-Number: 16924
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in osmo-msc[master]: libmsc: move subscriber expiration timer T3212 to libvlr

2020-01-19 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/16934 )

Change subject: libmsc: move subscriber expiration timer T3212 to libvlr
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/16934
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9b12066599a7c834a53a93acf5902d91273bc74f
Gerrit-Change-Number: 16934
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Sun, 19 Jan 2020 14:10:10 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-msc[master]: libvlr: use generic osmo_tdef API for T3250, T3260, and T3270

2020-01-19 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/16933 )

Change subject: libvlr: use generic osmo_tdef API for T3250, T3260, and T3270
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/16933
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ia8cf98da0aea0e626c5ff088a833d7359c43847f
Gerrit-Change-Number: 16933
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Sun, 19 Jan 2020 14:09:09 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-msc[master]: VTY: add osmo_tdef introspection and configuration commands

2020-01-19 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/16932 )

Change subject: VTY: add osmo_tdef introspection and configuration commands
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/16932
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I6024c104b6101666c8aa1108a043910eb75db9a5
Gerrit-Change-Number: 16932
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Sun, 19 Jan 2020 14:08:25 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-msc[master]: osmo-msc: fix: properly initialize default values for MGW timers

2020-01-19 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/16931 )

Change subject: osmo-msc: fix: properly initialize default values for MGW timers
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/16931
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4a0823c2f0ca50ed7407fb0457c54a485799c585
Gerrit-Change-Number: 16931
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Sun, 19 Jan 2020 14:07:36 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-msc[master]: manuals/vty: update the VTY reference to reflect recent changes

2020-01-19 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/16929 )

Change subject: manuals/vty: update the VTY reference to reflect recent changes
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/16929
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I14a5c9adff649406b4a079a75f86167ae6b95db4
Gerrit-Change-Number: 16929
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Sun, 19 Jan 2020 14:07:09 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-msc[master]: libvlr: remove unused 'periodic_lu_timer' from struct vlr_subscr

2020-01-19 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/16930 )

Change subject: libvlr: remove unused 'periodic_lu_timer' from struct vlr_subscr
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/16930
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I1b322b57fa0fd17ae2ebe1a2af2d8a93d81e14f0
Gerrit-Change-Number: 16930
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Sun, 19 Jan 2020 14:07:22 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-hlr[master]: Add vty `imsi unknown cause` to set the reject cause

2020-01-19 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `imsi unknown cause` to set the reject cause
..


Patch Set 2:

> (1 comment)

yes, all-lowercase with '-' as separator is the most "VTY like"


--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: fixeria 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Sun, 19 Jan 2020 14:06:48 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in ...osmo_gsup[master]: PDP_INFO_COMPLETE IE is optional for insert_sub_data_req

2020-01-19 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16937 )

Change subject: PDP_INFO_COMPLETE IE is optional for insert_sub_data_req
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16937
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo_gsup
Gerrit-Branch: master
Gerrit-Change-Id: I37fdfc68ae47fe35ef010711be20995680260c2c
Gerrit-Change-Number: 16937
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Sun, 19 Jan 2020 14:05:44 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in ...osmo_gsup[master]: gsup_protocol.hrl: make source / destination name IEs optional by def...

2020-01-19 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16925 )

Change subject: gsup_protocol.hrl: make source / destination name IEs optional 
by default
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16925
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo_gsup
Gerrit-Branch: master
Gerrit-Change-Id: I67ff73dfdeba1bfadf8ddfe112d8b4bdba62a699
Gerrit-Change-Number: 16925
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Sun, 19 Jan 2020 14:03:34 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in ...osmo_gsup[master]: Introduce basic contrib/jenkins.sh for Jenkins build verification

2020-01-19 Thread laforge
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16935 )

Change subject: Introduce basic contrib/jenkins.sh for Jenkins build 
verification
..

Introduce basic contrib/jenkins.sh for Jenkins build verification

Change-Id: I7b78aba09b1d249da90ad7a2d4359d8d23219ee5
Related: OS#4345
---
0 files changed, 0 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified




-- 
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16935
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo_gsup
Gerrit-Branch: master
Gerrit-Change-Id: I7b78aba09b1d249da90ad7a2d4359d8d23219ee5
Gerrit-Change-Number: 16935
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-MessageType: merged


Change in ...osmo_gsup[master]: Add optional NUM_VECTORS_REQ IE to send_auth_info_req

2020-01-19 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16936 )

Change subject: Add optional NUM_VECTORS_REQ IE to send_auth_info_req
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16936
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo_gsup
Gerrit-Branch: master
Gerrit-Change-Id: Ifb338cb849c0c9b2ce338eaa8ead6ac307188d3b
Gerrit-Change-Number: 16936
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Sun, 19 Jan 2020 14:04:18 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in ...osmo_gsup[master]: gsup_protocol.hrl: SM-RP-MR IE is mandatory for READY-FOR-SM messages

2020-01-19 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16926 )

Change subject: gsup_protocol.hrl: SM-RP-MR IE is mandatory for READY-FOR-SM 
messages
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16926
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo_gsup
Gerrit-Branch: master
Gerrit-Change-Id: I09b6b8afb1c0d28d4bf214fb8f01c21c895b8546
Gerrit-Change-Number: 16926
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Sun, 19 Jan 2020 14:03:48 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in ...osmo_gsup[master]: Introduce basic contrib/jenkins.sh for Jenkins build verification

2020-01-19 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16935 )

Change subject: Introduce basic contrib/jenkins.sh for Jenkins build 
verification
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16935
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo_gsup
Gerrit-Branch: master
Gerrit-Change-Id: I7b78aba09b1d249da90ad7a2d4359d8d23219ee5
Gerrit-Change-Number: 16935
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Sun, 19 Jan 2020 14:03:17 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in ...osmo_gsup[master]: PDP_INFO_COMPLETE IE is optional for insert_sub_data_req

2020-01-19 Thread fixeria
Hello lynxis lazus,

I'd like you to do a code review. Please visit

https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16937

to review the following change.


Change subject: PDP_INFO_COMPLETE IE is optional for insert_sub_data_req
..

PDP_INFO_COMPLETE IE is optional for insert_sub_data_req

Change-Id: I37fdfc68ae47fe35ef010711be20995680260c2c
---
M include/gsup_protocol.hrl
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_gsup 
refs/changes/37/16937/1

diff --git a/include/gsup_protocol.hrl b/include/gsup_protocol.hrl
index a08b934..569def7 100644
--- a/include/gsup_protocol.hrl
+++ b/include/gsup_protocol.hrl
@@ -182,7 +182,7 @@
   16#0c => #{message_type => purge_ms_req, mandatory => [], optional => 
[cn_domain, hlr_number]},
   16#0d => #{message_type => purge_ms_err, mandatory => [cause]},
   16#0e => #{message_type => purge_ms_res, mandatory => [freeze_p_tmsi]},
-  16#10 => #{message_type => insert_sub_data_req, mandatory => 
[pdp_info_complete], optional => [cn_domain, msisdn, hlr_number, pdp_info_list, 
pdp_charging]},
+  16#10 => #{message_type => insert_sub_data_req, mandatory => [], optional => 
[cn_domain, msisdn, hlr_number, pdp_info_complete, pdp_info_list, 
pdp_charging]},
   16#11 => #{message_type => insert_sub_data_err, mandatory => [cause]},
   16#12 => #{message_type => insert_sub_data_res, mandatory => []},
   16#14 => #{message_type => delete_sub_data_req, mandatory => [], optional => 
[cn_domain, pdp_context_id]},

--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16937
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo_gsup
Gerrit-Branch: master
Gerrit-Change-Id: I37fdfc68ae47fe35ef010711be20995680260c2c
Gerrit-Change-Number: 16937
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: lynxis lazus 
Gerrit-MessageType: newchange


Change in ...osmo_gsup[master]: Add optional NUM_VECTORS_REQ IE to send_auth_info_req

2020-01-19 Thread fixeria
Hello lynxis lazus,

I'd like you to do a code review. Please visit

https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16936

to review the following change.


Change subject: Add optional NUM_VECTORS_REQ IE to send_auth_info_req
..

Add optional NUM_VECTORS_REQ IE to send_auth_info_req

Change-Id: Ifb338cb849c0c9b2ce338eaa8ead6ac307188d3b
---
M include/gsup_protocol.hrl
M src/gsup_protocol.erl
M test/gsup_encode_decode_test.erl
3 files changed, 21 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_gsup 
refs/changes/36/16936/1

diff --git a/include/gsup_protocol.hrl b/include/gsup_protocol.hrl
index 3f04ece..a08b934 100644
--- a/include/gsup_protocol.hrl
+++ b/include/gsup_protocol.hrl
@@ -107,6 +107,7 @@
   sm_alert_reason => integer(),
   imei => binary(),
   imei_check_result => integer(),
+  num_vectors_req => integer(),
   message_class => integer(),
   source_name => binary(),
   destination_name => binary(),
@@ -158,6 +159,7 @@
 -define(SM_ALERT_REASON, 16#46).
 -define(IMEI, 16#50).
 -define(IMEI_CHECK_RESULT, 16#51).
+-define(NUM_VECTORS_REQ, 16#52).
 -define(SOURCE_NAME, 16#60).
 -define(DESTINATION_NAME, 16#61).
 -define(AN_APDU, 16#62).
@@ -173,7 +175,7 @@
   16#04 => #{message_type => location_upd_req, mandatory => [], optional => 
[cn_domain]},
   16#05 => #{message_type => location_upd_err, mandatory => [cause]},
   16#06 => #{message_type => location_upd_res, mandatory => [], optional => 
[msisdn, hlr_number, pdp_info_complete, pdp_info_list, pdp_charging]},
-  16#08 => #{message_type => send_auth_info_req, mandatory => [], optional => 
[cn_domain, auts, rand, supported_rat_types, current_rat_type]},
+  16#08 => #{message_type => send_auth_info_req, mandatory => [], optional => 
[cn_domain, auts, rand, supported_rat_types, current_rat_type, 
num_vectors_req]},
   16#09 => #{message_type => send_auth_info_err, mandatory => [cause]},
   16#0a => #{message_type => send_auth_info_res, mandatory => [], optional => 
[auth_tuples, auts, rand]},
   16#0b => #{message_type => auth_failure_report, mandatory => [], optional => 
[cn_domain]},
diff --git a/src/gsup_protocol.erl b/src/gsup_protocol.erl
index 30d5574..5dd4bda 100644
--- a/src/gsup_protocol.erl
+++ b/src/gsup_protocol.erl
@@ -159,6 +159,10 @@
   ?CHECK_LEN(imei_check_result, Len, 1, 1),
   decode_ie(Tail, Map#{imei_check_result => IMEIResult});

+decode_ie(<>, Map) ->
+  ?CHECK_LEN(num_vectors_req, Len, 1, 1),
+  decode_ie(Tail, Map#{num_vectors_req => NumVectorsRequest});
+
 decode_ie(<>, Map) ->
   decode_ie(Tail, Map#{source_name => SourceName});

@@ -467,6 +471,11 @@
   ?CHECK_SIZE(imei_check_result, Len, Value),
   encode_ie(maps:without([imei_check_result], GSUPMessage), <>);

+encode_ie(#{num_vectors_req := Value} = GSUPMessage, Head) ->
+  Len = 1,
+  ?CHECK_SIZE(num_vectors_req, Len, Value),
+  encode_ie(maps:without([num_vectors_req], GSUPMessage), <>);
+
 encode_ie(#{source_name := Value} = GSUPMessage, Head) ->
   Len = size(Value),
   encode_ie(maps:without([source_name], GSUPMessage), <>);
diff --git a/test/gsup_encode_decode_test.erl b/test/gsup_encode_decode_test.erl
index c0d3a21..2153707 100644
--- a/test/gsup_encode_decode_test.erl
+++ b/test/gsup_encode_decode_test.erl
@@ -44,6 +44,15 @@
   ?assertEqual(Map, gsup_protocol:decode(Bin)),
   ?assertEqual(Bin, gsup_protocol:encode(Map)).

+sai_req_num_test() ->
+  Bin = <<16#08, ?TEST_IMSI_IE, ?TEST_CLASS_SUBSCR_IE, 16#52, 16#01, 16#02>>,
+  Map = #{imsi => <<"123456789012345">>,
+  message_class => 1,
+  message_type => send_auth_info_req,
+  num_vectors_req => 2},
+  ?assertEqual(Map, gsup_protocol:decode(Bin)),
+  ?assertEqual(Bin, gsup_protocol:encode(Map)).
+
 sai_req_eps_test() ->
   Bin = <<16#08, ?TEST_IMSI_IE, ?TEST_CLASS_SUBSCR_IE, 
?TEST_SUPP_RAT_TYPES_IE, ?TEST_CURR_RAT_TYPE_LTE_IE>>,
   Map = #{imsi => <<"123456789012345">>, message_class => 1, message_type => 
send_auth_info_req,

--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16936
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo_gsup
Gerrit-Branch: master
Gerrit-Change-Id: Ifb338cb849c0c9b2ce338eaa8ead6ac307188d3b
Gerrit-Change-Number: 16936
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: lynxis lazus 
Gerrit-MessageType: newchange


Change in osmo-hlr[master]: Add vty `imsi unknown cause` to set the reject cause

2020-01-19 Thread fixeria
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `imsi unknown cause` to set the reject cause
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-hlr/+/16808/2/src/hlr_vty.c
File src/hlr_vty.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/16808/2/src/hlr_vty.c@345
PS2, Line 345: CAUSE
How about:

  ... cause (imsi-unknown|roaming-not-allowed)



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: fixeria 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Sun, 19 Jan 2020 12:33:04 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in ...osmo_gsup[master]: gsup_protocol.hrl: SM-RP-MR IE is mandatory for READY-FOR-SM messages

2020-01-19 Thread fixeria
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16926 )

Change subject: gsup_protocol.hrl: SM-RP-MR IE is mandatory for READY-FOR-SM 
messages
..


Patch Set 2:

This change is ready for review.


--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16926
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo_gsup
Gerrit-Branch: master
Gerrit-Change-Id: I09b6b8afb1c0d28d4bf214fb8f01c21c895b8546
Gerrit-Change-Number: 16926
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Comment-Date: Sun, 19 Jan 2020 12:28:12 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in ...osmo_gsup[master]: Introduce basic contrib/jenkins.sh for Jenkins build verification

2020-01-19 Thread fixeria
fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16935 )


Change subject: Introduce basic contrib/jenkins.sh for Jenkins build 
verification
..

Introduce basic contrib/jenkins.sh for Jenkins build verification

Change-Id: I7b78aba09b1d249da90ad7a2d4359d8d23219ee5
Related: OS#4345
---
A contrib/jenkins.sh
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_gsup 
refs/changes/35/16935/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
new file mode 100755
index 000..bc676c6
--- /dev/null
+++ b/contrib/jenkins.sh
@@ -0,0 +1,4 @@
+#!/bin/sh -ex
+
+rebar3 compile
+rebar3 eunit

--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16935
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo_gsup
Gerrit-Branch: master
Gerrit-Change-Id: I7b78aba09b1d249da90ad7a2d4359d8d23219ee5
Gerrit-Change-Number: 16935
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange


Re: Change in osmo-hlr[master]: Add vty `imsi unknown cause` to set the reject cause

2020-01-19 Thread Harald Welte
On Sun, Jan 19, 2020 at 03:10:26AM +, lynxis lazus wrote:

> @laforge which of the values do you prefer? For the causes we have 
> gsm48_gmm_cause_names. Which entries have whitespaces in there. Do you want 
> to see "GMM_CAUSE_NO_GPRS_PLMN" or "GPRS services not allowed in this PLMN" 
> in the vty configuration? I would prefer "GMM_CAUSE_NO_GPRS_PLMN".

I would prefer something like "no-gprs-plmn" or NO_GPRS_PLMN.  The first would 
be the most natural from
the vty perspective.

-- 
- Harald Weltehttp://laforge.gnumonks.org/

"Privacy in residential applications is a desirable marketing option."
  (ETSI EN 300 175-7 Ch. A6)


Build failure of network:osmocom:nightly/osmo-pcap in Debian_8.0/x86_64

2020-01-19 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcap/Debian_8.0/x86_64

Package network:osmocom:nightly/osmo-pcap failed to build in Debian_8.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcap

Last lines of build log:
[  119s] Processing triggers for libc-bin (2.19-18) ...
[  119s] [184/201] installing base-files-8
[  119s] Processing triggers for man-db (2.7.0.2-5) ...
[  119s] [185/201] installing libmount1-2.25.2-6
[  119s] Processing triggers for libc-bin (2.19-18) ...
[  119s] [186/201] installing mount-2.25.2-6
[  119s] Processing triggers for man-db (2.7.0.2-5) ...
[  120s] [187/201] installing bash-4.3-11+b1
[  120s] update-alternatives: using /usr/share/man/man7/bash-builtins.7.gz to 
provide /usr/share/man/man7/builtins.7.gz (builtins.7.gz) in auto mode
[  120s] Processing triggers for man-db (2.7.0.2-5) ...
[  120s] [188/201] installing dpkg-dev-1.17.25
[  121s] Processing triggers for man-db (2.7.0.2-5) ...
[  122s] [189/201] installing build-essential-11.7
[  122s] [190/201] installing initscripts-2.88dsf-59
[  123s]  ==> File on system created by you or by a script.
[  123s]  ==> File also in package provided by package maintainer.
[  123s]What would you like to do about it ?  Your options are:
[  123s] Y or I  : install the package maintainer's version
[  123s] N or O  : keep your currently-installed version
[  123s]   D : show the differences between the versions
[  123s]   Z : start a shell to examine the situation
[  123s]  The default action is to keep your current version.
[28931s] qemu-system-x86_64: terminating on signal 15 from pid 16957 (fuser)
[28931s] ### VM INTERACTION END ###
[28931s] No buildstatus set, either the base system is broken 
(kernel/initrd/udev/glibc/bash/perl)
[28931s] or the build host has a kernel or hardware problem...


Job seems to be stuck here, killed. (after 28800 seconds of inactivity)

-- 
Configure notifications at https://build.opensuse.org/my/notifications
openSUSE Build Service (https://build.opensuse.org/)