Build failure of network:osmocom:nightly/ulfius in Debian_Unstable/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Debian_Unstable/x86_64
Package network:osmocom:nightly/ulfius failed to build in Debian_Unstable/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly ulfius
Last lines of build log:
[ 133s] /usr/src/packages/BUILD/src/ulfius.c:839:48: error: passing argument 5
of 'MHD_start_daemon' from incompatible pointer type
[-Werror=incompatible-pointer-types]
[ 133s] 839 | mhd_flags, u_instance->port, NULL, NULL,
_webservice_dispatcher, (void *)u_instance,
[ 133s] |
^
[ 133s] ||
[ 133s] |int (*)(void *,
struct MHD_Connection *, const char *, const char *, const char *, const char
*, size_t *, void **) {aka int (*)(void *, struct MHD_Connection *, const char
*, const char *, const char *, const char *, long unsigned int *, void **)}
[ 133s] In file included from /usr/src/packages/BUILD/include/ulfius.h:46,
[ 133s] from /usr/src/packages/BUILD/include/u_private.h:29,
[ 133s] from /usr/src/packages/BUILD/src/ulfius.c:29:
[ 133s] /usr/include/microhttpd.h:2425:1: note: expected
'MHD_AccessHandlerCallback' {aka 'enum MHD_Result (*)(void *, struct
MHD_Connection *, const char *, const char *, const char *, const char *, long
unsigned int *, void **)'} but argument is of type 'int (*)(void *, struct
MHD_Connection *, const char *, const char *, const char *, const char *,
size_t *, void **)' {aka 'int (*)(void *, struct MHD_Connection *, const char
*, const char *, const char *, const char *, long unsigned int *, void **)'}
[ 133s] 2425 | MHD_start_daemon (unsigned int flags,
[ 133s] | ^~~~
[ 134s] cc1: all warnings being treated as errors
[ 134s] make[3]: *** [CMakeFiles/ulfius.dir/build.make:144:
CMakeFiles/ulfius.dir/src/ulfius.c.o] Error 1
[ 134s] make[3]: *** Waiting for unfinished jobs
[ 134s] make[3]: Leaving directory '/usr/src/packages/BUILD/build'
[ 134s] make[2]: *** [CMakeFiles/Makefile2:87: CMakeFiles/ulfius.dir/all]
Error 2
[ 134s] make[2]: Leaving directory '/usr/src/packages/BUILD/build'
[ 134s] make[1]: *** [Makefile:166: all] Error 2
[ 134s] make[1]: Leaving directory '/usr/src/packages/BUILD/build'
[ 134s] dh_auto_build: error: cd build && make -j8 "INSTALL=install
--strip-program=true" returned exit code 2
[ 134s] make: *** [debian/rules:9: build] Error 25
[ 134s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 134s] ### VM INTERACTION START ###
[ 137s] [ 123.258709] sysrq: SysRq : Power Off
[ 137s] [ 123.273245] reboot: Power down
[ 137s] ### VM INTERACTION END ###
[ 137s]
[ 137s] lamb26 failed "build ulfius_2.5.2-4.1.dsc" at Sun Jul 5 03:02:56 UTC
2020.
[ 137s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/open5gs in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_Unstable/x86_64 Package network:osmocom:nightly/open5gs failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 531s] [2088/2409] cc -Ilib/sbi/9848b6c@@ogssbi@sha -Ilib/sbi -I../lib/sbi -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app -I../lib/app -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 -I/usr/include/x86_64-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -DOGS_SBI_COMPILATION -MD -MQ 'lib/sbi/9848b6c@@ogssbi@sha/contrib_multipart_parser.c.o' -MF 'lib/sbi/9848b6c@@ogssbi@sha/contrib_multipart_parser.c.o.d' -o 'lib/sbi/9848b6c@@ogssbi@sha/contrib_multipart_parser.c.o' -c ../lib/sbi/contrib/multipart_parser.c [ 531s] [2089/2409] cc -Ilib/sbi/9848b6c@@ogssbi@sha -Ilib/sbi -I../lib/sbi -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app -I../lib/app -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 -I/usr/include/x86_64-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -DOGS_SBI_COMPILATION -MD -MQ 'lib/sbi/9848b6c@@ogssbi@sha/server.c.o' -MF 'lib/sbi/9848b6c@@ogssbi@sha/server.c.o.d' -o 'lib/sbi/9848b6c@@ogssbi@sha/server.c.o' -c ../lib/sbi/server.c [ 531s] FAILED: lib/sbi/9848b6c@@ogssbi@sha/server.c.o [ 531s] cc -Ilib/sbi/9848b6c@@ogssbi@sha -Ilib/sbi -I../lib/sbi -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app -I../lib/app -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 -I/usr/include/x86_64-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -DOGS_SBI_COMPILATION -MD -MQ 'lib/sbi/9848b6c@@ogssbi@sha/server.c.o' -MF 'lib/sbi/9848b6c@@ogssbi@sha/server.c.o.d' -o 'lib/sbi/9848b6c@@ogssbi@sha/server.c.o' -c ../lib/sbi/server.c [ 531s] ../lib/sbi/server.c: In function ‘ogs_sbi_server_start’: [ 531s] ../lib/sbi/server.c:268:17: error: passing argument 5 of ‘MHD_start_daemon’ from incompatible pointer type [-Werror=incompatible-pointer-types] [ 531s] 268 |
Build failure of network:osmocom:nightly/open5gs in xUbuntu_18.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/open5gs failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 556s] Build dir: /usr/src/packages/BUILD/obj-x86_64-linux-gnu [ 556s] Build type: native build [ 556s] [ 556s] meson.build:18:0: ERROR: Function does not take keyword arguments. [ 556s] [ 556s] A full log can be found at /usr/src/packages/BUILD/obj-x86_64-linux-gnu/meson-logs/meson-log.txt [ 556s]cd obj-x86_64-linux-gnu && tail -v -n \+0 meson-logs/meson-log.txt [ 556s] ==> meson-logs/meson-log.txt <== [ 556s] Build started at 2020-07-05T01:58:46.736867 [ 556s] Main binary: /usr/bin/python3 [ 556s] Python system: Linux [ 556s] The Meson build system [ 556s] Version: 0.45.1 [ 556s] Source dir: /usr/src/packages/BUILD [ 556s] Build dir: /usr/src/packages/BUILD/obj-x86_64-linux-gnu [ 556s] Build type: native build [ 556s] [ 556s] meson.build:18:0: ERROR: Function does not take keyword arguments. [ 556s] dh_auto_configure: cd obj-x86_64-linux-gnu && LC_ALL=C.UTF-8 meson .. --wrap-mode=nodownload --buildtype=plain --prefix=/usr --sysconfdir=/etc --localstatedir=/var --libdir=lib/x86_64-linux-gnu --libexecdir=lib/x86_64-linux-gnu returned exit code 1 [ 556s] debian/rules:11: recipe for target 'binary' failed [ 556s] make: *** [binary] Error 2 [ 556s] dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2 [ 556s] ### VM INTERACTION START ### [ 559s] [ 529.830999] sysrq: SysRq : Power Off [ 560s] [ 529.847611] reboot: Power down [ 560s] ### VM INTERACTION END ### [ 560s] [ 560s] lamb03 failed "build open5gs_1.3.0.20200705.dsc" at Sun Jul 5 01:58:51 UTC 2020. [ 560s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/open5gs in Debian_Unstable/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_Unstable/x86_64
Package network:osmocom:nightly/open5gs failed to build in
Debian_Unstable/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly open5gs
Last lines of build log:
[ 159s] FAILED: lib/sbi/9848b6c@@ogssbi@sha/server.c.o
[ 159s] cc -Ilib/sbi/9848b6c@@ogssbi@sha -Ilib/sbi -I../lib/sbi -Ilib -I../lib
-Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app -I../lib/app
-Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1
-I/usr/include/x86_64-linux-gnu -fdiagnostics-color=always -pipe
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes
-Werror=missing-declarations -Werror=implicit-function-declaration
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4
-ffunction-sections -fdata-sections -g -O2
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread
-DOGS_SBI_COMPILATION -MD -MQ 'lib/sbi/9848b6c@@ogssbi@sha/server.c.o' -MF
'lib/sbi/9848b6c@@ogssbi@sha/server.c.o.d' -o
'lib/sbi/9848b6c@@ogssbi@sha/server.c.o' -c ../lib/sbi/server.c
[ 159s] ../lib/sbi/server.c: In function ‘ogs_sbi_server_start’:
[ 159s] ../lib/sbi/server.c:268:17: error: passing argument 5 of
‘MHD_start_daemon’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
[ 159s] 268 | access_handler, server,
[ 159s] | ^~
[ 159s] | |
[ 159s] | int (*)(void *, struct MHD_Connection *, const
char *, const char *, const char *, const char *, size_t *, void **) {aka int
(*)(void *, struct MHD_Connection *, const char *, const char *, const char *,
const char *, long unsigned int *, void **)}
[ 159s] In file included from ../lib/sbi/server.c:23:
[ 159s] /usr/include/microhttpd.h:2425:1: note: expected
‘MHD_AccessHandlerCallback’ {aka ‘enum MHD_Result (*)(void *, struct
MHD_Connection *, const char *, const char *, const char *, const char *, long
unsigned int *, void **)’} but argument is of type ‘int (*)(void *, struct
MHD_Connection *, const char *, const char *, const char *, const char *,
size_t *, void **)’ {aka ‘int (*)(void *, struct MHD_Connection *, const char
*, const char *, const char *, const char *, long unsigned int *, void **)’}
[ 159s] 2425 | MHD_start_daemon (unsigned int flags,
[ 159s] | ^~~~
[ 159s] cc1: some warnings being treated as errors
[ 159s] [2088/2409] cc -Isrc/mme/e6d01c5@@mme@sta -Isrc/mme -I../src/mme
-Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/sctp
-I../lib/sctp -Ilib/s1ap -I../lib/s1ap -Ilib/asn1c/s1ap -I../lib/asn1c/s1ap
-Ilib/asn1c/common -I../lib/asn1c/common -Ilib/asn1c/util -I../lib/asn1c/util
-Ilib/nas/eps -I../lib/nas/eps -Ilib/nas/common -I../lib/nas/common -Ilib/crypt
-I../lib/crypt -Ilib/diameter/s6a -I../lib/diameter/s6a -Ilib/diameter/common
-I../lib/diameter/common -Isubprojects/freeDiameter/include
-I../subprojects/freeDiameter/include -Isubprojects/freeDiameter
-I../subprojects/freeDiameter -Ilib/gtp -I../lib/gtp -fdiagnostics-color=always
-pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes
-Werror=missing-declarations -Werror=implicit-function-declaration
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4
-ffunction-sections -fdata-sections -g -O2
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ
'src/mme/e6d01c5@@mme@sta/s1ap-sm.c.o' -MF
'src/mme/e6d01c5@@mme@sta/s1ap-sm.c.o.d' -o
'src/mme/e6d01c5@@mme@sta/s1ap-sm.c.o' -c ../src/mme/s1ap-sm.c
[ 159s] [2089/2409] cc
Build failure of network:osmocom:nightly/open5gs in xUbuntu_18.04/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/xUbuntu_18.04/i586 Package network:osmocom:nightly/open5gs failed to build in xUbuntu_18.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 425s] Build dir: /usr/src/packages/BUILD/obj-i686-linux-gnu [ 425s] Build type: native build [ 425s] [ 425s] meson.build:18:0: ERROR: Function does not take keyword arguments. [ 425s] [ 425s] A full log can be found at /usr/src/packages/BUILD/obj-i686-linux-gnu/meson-logs/meson-log.txt [ 425s]cd obj-i686-linux-gnu && tail -v -n \+0 meson-logs/meson-log.txt [ 425s] ==> meson-logs/meson-log.txt <== [ 425s] Build started at 2020-07-05T01:45:12.101753 [ 425s] Main binary: /usr/bin/python3 [ 425s] Python system: Linux [ 425s] The Meson build system [ 425s] Version: 0.45.1 [ 425s] Source dir: /usr/src/packages/BUILD [ 425s] Build dir: /usr/src/packages/BUILD/obj-i686-linux-gnu [ 425s] Build type: native build [ 425s] [ 425s] meson.build:18:0: ERROR: Function does not take keyword arguments. [ 425s] dh_auto_configure: cd obj-i686-linux-gnu && LC_ALL=C.UTF-8 meson .. --wrap-mode=nodownload --buildtype=plain --prefix=/usr --sysconfdir=/etc --localstatedir=/var --libdir=lib/i386-linux-gnu --libexecdir=lib/i386-linux-gnu returned exit code 1 [ 425s] debian/rules:11: recipe for target 'binary' failed [ 425s] make: *** [binary] Error 2 [ 425s] dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2 [ 425s] ### VM INTERACTION START ### [ 428s] [ 401.333556] sysrq: SysRq : Power Off [ 428s] [ 401.353291] reboot: Power down [ 428s] ### VM INTERACTION END ### [ 428s] [ 428s] lamb22 failed "build open5gs_1.3.0.20200705.dsc" at Sun Jul 5 01:45:16 UTC 2020. [ 428s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/open5gs in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_Unstable/x86_64 Package network:osmocom:nightly/open5gs failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 152s] [2086/2409] cc -Isrc/mme/e6d01c5@@mme@sta -Isrc/mme -I../src/mme -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/sctp -I../lib/sctp -Ilib/s1ap -I../lib/s1ap -Ilib/asn1c/s1ap -I../lib/asn1c/s1ap -Ilib/asn1c/common -I../lib/asn1c/common -Ilib/asn1c/util -I../lib/asn1c/util -Ilib/nas/eps -I../lib/nas/eps -Ilib/nas/common -I../lib/nas/common -Ilib/crypt -I../lib/crypt -Ilib/diameter/s6a -I../lib/diameter/s6a -Ilib/diameter/common -I../lib/diameter/common -Isubprojects/freeDiameter/include -I../subprojects/freeDiameter/include -Isubprojects/freeDiameter -I../subprojects/freeDiameter -Ilib/gtp -I../lib/gtp -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/mme/e6d01c5@@mme@sta/s1ap-build.c.o' -MF 'src/mme/e6d01c5@@mme@sta/s1ap-build.c.o.d' -o 'src/mme/e6d01c5@@mme@sta/s1ap-build.c.o' -c ../src/mme/s1ap-build.c [ 152s] [2087/2409] cc -Isrc/mme/e6d01c5@@mme@sta -Isrc/mme -I../src/mme -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/sctp -I../lib/sctp -Ilib/s1ap -I../lib/s1ap -Ilib/asn1c/s1ap -I../lib/asn1c/s1ap -Ilib/asn1c/common -I../lib/asn1c/common -Ilib/asn1c/util -I../lib/asn1c/util -Ilib/nas/eps -I../lib/nas/eps -Ilib/nas/common -I../lib/nas/common -Ilib/crypt -I../lib/crypt -Ilib/diameter/s6a -I../lib/diameter/s6a -Ilib/diameter/common -I../lib/diameter/common -Isubprojects/freeDiameter/include -I../subprojects/freeDiameter/include -Isubprojects/freeDiameter -I../subprojects/freeDiameter -Ilib/gtp -I../lib/gtp -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/mme/e6d01c5@@mme@sta/s1ap-sm.c.o' -MF 'src/mme/e6d01c5@@mme@sta/s1ap-sm.c.o.d' -o 'src/mme/e6d01c5@@mme@sta/s1ap-sm.c.o' -c ../src/mme/s1ap-sm.c [ 152s] [2088/2409] cc -Ilib/sbi/9848b6c@@ogssbi@sha -Ilib/sbi -I../lib/sbi -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/app -I../lib/app -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 -I/usr/include/x86_64-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections
Build failure of network:osmocom:latest/ulfius in Debian_Unstable/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/ulfius/Debian_Unstable/x86_64
Package network:osmocom:latest/ulfius failed to build in Debian_Unstable/x86_64
Check out the package for editing:
osc checkout network:osmocom:latest ulfius
Last lines of build log:
[ 115s] /usr/src/packages/BUILD/src/ulfius.c:839:48: error: passing argument 5
of 'MHD_start_daemon' from incompatible pointer type
[-Werror=incompatible-pointer-types]
[ 115s] 839 | mhd_flags, u_instance->port, NULL, NULL,
_webservice_dispatcher, (void *)u_instance,
[ 115s] |
^
[ 115s] ||
[ 115s] |int (*)(void *,
struct MHD_Connection *, const char *, const char *, const char *, const char
*, size_t *, void **) {aka int (*)(void *, struct MHD_Connection *, const char
*, const char *, const char *, const char *, long unsigned int *, void **)}
[ 115s] In file included from /usr/src/packages/BUILD/include/ulfius.h:46,
[ 115s] from /usr/src/packages/BUILD/include/u_private.h:29,
[ 115s] from /usr/src/packages/BUILD/src/ulfius.c:29:
[ 115s] /usr/include/microhttpd.h:2425:1: note: expected
'MHD_AccessHandlerCallback' {aka 'enum MHD_Result (*)(void *, struct
MHD_Connection *, const char *, const char *, const char *, const char *, long
unsigned int *, void **)'} but argument is of type 'int (*)(void *, struct
MHD_Connection *, const char *, const char *, const char *, const char *,
size_t *, void **)' {aka 'int (*)(void *, struct MHD_Connection *, const char
*, const char *, const char *, const char *, long unsigned int *, void **)'}
[ 115s] 2425 | MHD_start_daemon (unsigned int flags,
[ 115s] | ^~~~
[ 115s] cc1: all warnings being treated as errors
[ 115s] make[3]: *** [CMakeFiles/ulfius.dir/build.make:144:
CMakeFiles/ulfius.dir/src/ulfius.c.o] Error 1
[ 115s] make[3]: *** Waiting for unfinished jobs
[ 116s] make[3]: Leaving directory '/usr/src/packages/BUILD/build'
[ 116s] make[2]: *** [CMakeFiles/Makefile2:87: CMakeFiles/ulfius.dir/all]
Error 2
[ 116s] make[2]: Leaving directory '/usr/src/packages/BUILD/build'
[ 116s] make[1]: *** [Makefile:166: all] Error 2
[ 116s] make[1]: Leaving directory '/usr/src/packages/BUILD/build'
[ 116s] dh_auto_build: error: cd build && make -j8 "INSTALL=install
--strip-program=true" returned exit code 2
[ 116s] make: *** [debian/rules:9: build] Error 25
[ 116s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 116s] ### VM INTERACTION START ###
[ 119s] [ 106.636610] sysrq: SysRq : Power Off
[ 119s] [ 106.641718] reboot: Power down
[ 119s] ### VM INTERACTION END ###
[ 119s]
[ 119s] lamb14 failed "build ulfius_2.5.2-4.1.dsc" at Sat Jul 4 15:52:01 UTC
2020.
[ 119s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/ulfius in Debian_Unstable/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Debian_Unstable/x86_64
Package network:osmocom:nightly/ulfius failed to build in Debian_Unstable/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly ulfius
Last lines of build log:
[ 84s] /usr/src/packages/BUILD/src/ulfius.c:839:48: error: passing argument 5
of 'MHD_start_daemon' from incompatible pointer type
[-Werror=incompatible-pointer-types]
[ 84s] 839 | mhd_flags, u_instance->port, NULL, NULL,
_webservice_dispatcher, (void *)u_instance,
[ 84s] |
^
[ 84s] ||
[ 84s] |int (*)(void *,
struct MHD_Connection *, const char *, const char *, const char *, const char
*, size_t *, void **) {aka int (*)(void *, struct MHD_Connection *, const char
*, const char *, const char *, const char *, long unsigned int *, void **)}
[ 84s] In file included from /usr/src/packages/BUILD/include/ulfius.h:46,
[ 84s] from /usr/src/packages/BUILD/include/u_private.h:29,
[ 84s] from /usr/src/packages/BUILD/src/ulfius.c:29:
[ 84s] /usr/include/microhttpd.h:2425:1: note: expected
'MHD_AccessHandlerCallback' {aka 'enum MHD_Result (*)(void *, struct
MHD_Connection *, const char *, const char *, const char *, const char *, long
unsigned int *, void **)'} but argument is of type 'int (*)(void *, struct
MHD_Connection *, const char *, const char *, const char *, const char *,
size_t *, void **)' {aka 'int (*)(void *, struct MHD_Connection *, const char
*, const char *, const char *, const char *, long unsigned int *, void **)'}
[ 84s] 2425 | MHD_start_daemon (unsigned int flags,
[ 84s] | ^~~~
[ 84s] cc1: all warnings being treated as errors
[ 84s] make[3]: *** [CMakeFiles/ulfius.dir/build.make:144:
CMakeFiles/ulfius.dir/src/ulfius.c.o] Error 1
[ 84s] make[3]: *** Waiting for unfinished jobs
[ 84s] make[3]: Leaving directory '/usr/src/packages/BUILD/build'
[ 84s] make[2]: *** [CMakeFiles/Makefile2:87: CMakeFiles/ulfius.dir/all]
Error 2
[ 84s] make[2]: Leaving directory '/usr/src/packages/BUILD/build'
[ 84s] make[1]: *** [Makefile:166: all] Error 2
[ 84s] make[1]: Leaving directory '/usr/src/packages/BUILD/build'
[ 84s] dh_auto_build: error: cd build && make -j6 "INSTALL=install
--strip-program=true" returned exit code 2
[ 84s] make: *** [debian/rules:9: build] Error 25
[ 84s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 84s] ### VM INTERACTION START ###
[ 87s] [ 77.362435] sysrq: SysRq : Power Off
[ 87s] [ 77.366879] reboot: Power down
[ 87s] ### VM INTERACTION END ###
[ 87s]
[ 87s] sheep87 failed "build ulfius_2.5.2-4.1.dsc" at Sat Jul 4 15:51:26 UTC
2020.
[ 87s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-ttcn3-hacks[master]: bsc: verify data of SI2quater sent from osmo-bsc
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19115 ) Change subject: bsc: verify data of SI2quater sent from osmo-bsc .. Patch Set 1: > how will you deal with segmented SI2quater messages? probably add several SI2quater to the list of expected SI and succeed if any one of them matches ... this will be refactored a bit so I'll see where it goes -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19115 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1736d75839031e90d73dda1d1c267cadc55b702 Gerrit-Change-Number: 19115 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-CC: laforge Gerrit-Comment-Date: Sat, 04 Jul 2020 14:57:22 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: bsc: verify System Information presence on RSL startup
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19062 ) Change subject: bsc: verify System Information presence on RSL startup .. Patch Set 3: ok. I'll split SI off into separate tests. There we'll be free to add some arbitrary f_sleep(), because if we expect a certain SI to not appear at all (with or without SI payload data), in case of error we might get that unwanted SI after the expected SIs and could miss that, too. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a8ef404087efee491390dc1d2452ac323f145f0 Gerrit-Change-Number: 19062 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-CC: laforge Gerrit-Comment-Date: Sat, 04 Jul 2020 14:54:24 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: BTS_Tests: cosmetic: mark friend types / functions as such
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19135 )
Change subject: BTS_Tests: cosmetic: mark friend types / functions as such
..
BTS_Tests: cosmetic: mark friend types / functions as such
Change-Id: I53296b0d66594c198251526c8433a07348d821b1
---
M bts/BTS_Tests.ttcn
1 file changed, 13 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/35/19135/1
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index a42f628..15b0730 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -429,7 +429,7 @@
}
/* global init function */
-function f_init() runs on test_CT {
+friend function f_init() runs on test_CT {
var charstring id := testcasename();
g_AllChannels := {
/* TS 1..4: TCH/F */
@@ -503,7 +503,7 @@
}
/* Attach L1CTL to master test_CT (classic tests, non-handler mode) */
-function f_init_l1ctl() runs on test_CT {
+friend function f_init_l1ctl() runs on test_CT {
map(self:L1CTL, system:L1CTL);
f_connect_reset(L1CTL);
}
@@ -511,9 +511,9 @@
private type function void_fn(charstring id) runs on ConnHdlr;
/* create a new test component */
-function f_start_handler(void_fn fn, ConnHdlrPars pars,
-boolean pcu_comp := false,
-boolean trxc_comp := false)
+friend function f_start_handler(void_fn fn, ConnHdlrPars pars,
+ boolean pcu_comp := false,
+ boolean trxc_comp := false)
runs on test_CT return ConnHdlr {
var charstring id := testcasename();
var ConnHdlr vc_conn;
@@ -607,14 +607,17 @@
return rx;
}
-function f_rsl_transceive(template RSL_Message tx, template RSL_Message
exp_rx, charstring id,
- boolean ignore_other := false)
+friend function f_rsl_transceive(template RSL_Message tx, template RSL_Message
exp_rx,
+charstring id, boolean ignore_other := false)
runs on ConnHdlr {
var RSL_Message rx := f_rsl_transceive_ret(tx, exp_rx, id,
ignore_other);
}
-function f_rsl_chan_act(RSL_IE_ChannelMode mode, boolean encr_enable := false,
RSL_IE_List more_ies := {},
- RSL_IE_ActivationType act_type := t_RSL_IE_ActType_IA)
runs on ConnHdlr {
+friend function f_rsl_chan_act(RSL_IE_ChannelMode mode,
+ boolean encr_enable := false,
+ RSL_IE_List more_ies := {},
+ RSL_IE_ActivationType act_type :=
t_RSL_IE_ActType_IA)
+runs on ConnHdlr {
var RSL_Message ch_act := valueof(ts_RSL_CHAN_ACT(g_chan_nr, mode,
act_type));
if (encr_enable) {
/* append encryption related IEs, if requested */
@@ -627,7 +630,7 @@
f_rsl_transceive(ch_act, tr_RSL_CHAN_ACT_ACK(g_chan_nr), "RSL CHAN
ACT");
}
-function f_rsl_chan_deact() runs on ConnHdlr {
+friend function f_rsl_chan_deact() runs on ConnHdlr {
f_rsl_transceive(ts_RSL_RF_CHAN_REL(g_chan_nr),
tr_RSL_RF_CHAN_REL_ACK(g_chan_nr),
"RF CHAN REL", true);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19135
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I53296b0d66594c198251526c8433a07348d821b1
Gerrit-Change-Number: 19135
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: BTS_Tests: cosmetic: mark private types / functions as such
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19134 )
Change subject: BTS_Tests: cosmetic: mark private types / functions as such
..
BTS_Tests: cosmetic: mark private types / functions as such
Change-Id: I99ccf398130c7e5c2aac1932ebb83f158fed281d
---
M bts/BTS_Tests.ttcn
1 file changed, 93 insertions(+), 63 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/34/19134/1
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 1b6c9b2..a42f628 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -187,7 +187,7 @@
port PCUIF_CODEC_PT PCU;
}
-function f_init_rsl(charstring id) runs on test_CT {
+private function f_init_rsl(charstring id) runs on test_CT {
var bitstring trx_mask := ''B;
var integer trx_count := 0;
var RSLEm_Event ev;
@@ -250,11 +250,11 @@
}
/* Test-specific parameters */
-type union TestSpecUnion {
+private type union TestSpecUnion {
RllTestCase rll
}
-template (value) RachControlParameters ts_RachCtrl_default := {
+private template (value) RachControlParameters ts_RachCtrl_default := {
max_retrans := RACH_MAX_RETRANS_7,
tx_integer := '1001'B, /* 12 slots */
cell_barr_access := false,
@@ -262,7 +262,7 @@
acc := '0100'B
};
-template (value) CellSelectionParameters ts_CellSelPar_default := {
+private template (value) CellSelectionParameters ts_CellSelPar_default := {
cell_resel_hyst_2dB := 2,
ms_txpwr_max_cch := mp_ms_power_level_exp,
acs := '0'B,
@@ -270,7 +270,7 @@
rxlev_access_min := 0
}
-template (value) LocationAreaIdentification ts_LAI_default := {
+private template (value) LocationAreaIdentification ts_LAI_default := {
mcc_mnc := '262F42'H,
lac := 42
}
@@ -297,7 +297,7 @@
}
/* Default SYSTEM INFORMATION 3 */
-template (value) SystemInformation ts_SI3_default := {
+private template (value) SystemInformation ts_SI3_default := {
header := ts_RrHeader(SYSTEM_INFORMATION_TYPE_3, 18),
payload := {
si3 := {
@@ -327,7 +327,7 @@
}
}
-template (value) SystemInformation ts_SI2_default := {
+private template (value) SystemInformation ts_SI2_default := {
header := ts_RrHeader(SYSTEM_INFORMATION_TYPE_2, 22),
payload := {
si2 := {
@@ -338,7 +338,7 @@
}
}
-template (value) SystemInformation ts_SI4_default := {
+private template (value) SystemInformation ts_SI4_default := {
header := ts_RrHeader(SYSTEM_INFORMATION_TYPE_4, 12), /* no CBCH /
restoct */
payload := {
si4 := {
@@ -352,13 +352,13 @@
}
}
-function f_rsl_bcch_fill_raw(RSL_IE_SysinfoType rsl_si_type, octetstring
si_enc)
+private function f_rsl_bcch_fill_raw(RSL_IE_SysinfoType rsl_si_type,
octetstring si_enc)
runs on test_CT {
log("Setting ", rsl_si_type, ": ", si_enc);
RSL_CCHAN.send(ts_ASP_RSL_UD(ts_RSL_BCCH_INFO(rsl_si_type, si_enc)));
}
-function f_rsl_bcch_fill(RSL_IE_SysinfoType rsl_si_type, template (value)
SystemInformation si_dec)
+private function f_rsl_bcch_fill(RSL_IE_SysinfoType rsl_si_type, template
(value) SystemInformation si_dec)
runs on test_CT {
var octetstring si_enc := enc_SystemInformation(valueof(si_dec));
log("Setting ", rsl_si_type, ": ", si_dec);
@@ -508,7 +508,7 @@
f_connect_reset(L1CTL);
}
-type function void_fn(charstring id) runs on ConnHdlr;
+private type function void_fn(charstring id) runs on ConnHdlr;
/* create a new test component */
function f_start_handler(void_fn fn, ConnHdlrPars pars,
@@ -581,8 +581,8 @@
fn.apply(id);
}
-function f_rsl_transceive_ret(template RSL_Message tx, template RSL_Message
exp_rx, charstring id,
- boolean ignore_other := false)
+private function f_rsl_transceive_ret(template RSL_Message tx, template
RSL_Message exp_rx,
+ charstring id, boolean ignore_other :=
false)
runs on ConnHdlr return RSL_Message {
var RSL_Message rx;
timer T := 3.0;
@@ -1644,7 +1644,7 @@
* Measurement Processing / Reporting
***/
-template LapdmAddressField ts_LapdmAddr(LapdmSapi sapi, boolean c_r) := {
+private template LapdmAddressField ts_LapdmAddr(LapdmSapi sapi, boolean c_r)
:= {
spare := '0'B,
lpd := 0,
sapi := sapi,
@@ -1652,7 +1652,7 @@
ea := true
}
-template LapdmFrameAB ts_LAPDm_AB(LapdmSapi sapi, boolean c_r, boolean p,
octetstring pl) := {
+private template LapdmFrameAB ts_LAPDm_AB(LapdmSapi sapi, boolean c_r, boolean
p, octetstring pl) := {
addr := ts_LapdmAddr(sapi, c_r),
ctrl := ts_LapdmCtrlUI(p),
len := 0, /* overwritten */
@@ -1662,7 +1662,7 @@
}
/* handle incoming downlink
Change in osmo-ttcn3-hacks[master]: BTS_Tests: mark both TC_rll_data_{req, ind} as TODO
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19137 )
Change subject: BTS_Tests: mark both TC_rll_data_{req,ind} as TODO
..
BTS_Tests: mark both TC_rll_data_{req,ind} as TODO
Change-Id: I55d8dbc3a5cb3b0422cb6329b2bd60dd7b7fad6a
---
M bts/BTS_Tests.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/37/19137/1
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index c4d1c26..374228a 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -6069,11 +6069,11 @@
f_rll_testmatrix(tcs, refers(f_TC_rll_rel_req));
}
-/* test if RLL DATA REQ triggers I-frames on Um (TS 48.058 3.5) */
+/* TODO: test if RLL DATA REQ triggers I-frames on Um (TS 48.058 3.5) */
testcase TC_rll_data_req() runs on test_CT {
}
-/* test if I-frames on Um trigger RLL DATA IND (TS 48.058 3.6) */
+/* TODO: test if I-frames on Um trigger RLL DATA IND (TS 48.058 3.6) */
testcase TC_rll_data_ind() runs on test_CT {
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19137
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I55d8dbc3a5cb3b0422cb6329b2bd60dd7b7fad6a
Gerrit-Change-Number: 19137
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: BTS_Tests: cosmetic: mark private test case functions as such
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19133 )
Change subject: BTS_Tests: cosmetic: mark private test case functions as such
..
BTS_Tests: cosmetic: mark private test case functions as such
Change-Id: I173e42dbe1694a10b54f95a730df2e64f2c65d17
---
M bts/BTS_Tests.ttcn
1 file changed, 45 insertions(+), 45 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/33/19133/1
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 132e13e..1b6c9b2 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -674,7 +674,7 @@
***/
/* Stress test: Do 500 channel activations/deactivations in rapid succession */
-function f_TC_chan_act_stress(charstring id) runs on ConnHdlr {
+private function f_TC_chan_act_stress(charstring id) runs on ConnHdlr {
for (var integer i := 0; i < 500; i := i+1) {
f_rsl_chan_act(g_pars.chan_mode);
f_rsl_chan_deact();
@@ -691,7 +691,7 @@
}
/* Test if re-activation of an already active channel fails as expected */
-function f_TC_chan_act_react(charstring id) runs on ConnHdlr {
+private function f_TC_chan_act_react(charstring id) runs on ConnHdlr {
f_rsl_chan_act(g_pars.chan_mode);
/* attempt to activate the same lchan again -> expect reject */
RSL.send(ts_RSL_CHAN_ACT(g_chan_nr, g_pars.chan_mode));
@@ -715,7 +715,7 @@
}
/* Attempt to de-activate a channel that's not active */
-function f_TC_chan_deact_not_active(charstring id) runs on ConnHdlr {
+private function f_TC_chan_deact_not_active(charstring id) runs on ConnHdlr {
timer T := 3.0;
RSL.send(ts_RSL_RF_CHAN_REL(g_chan_nr));
T.start;
@@ -737,7 +737,7 @@
}
/* attempt to activate channel with wrong RSL Channel Nr IE; expect NACK */
-function f_TC_chan_act_wrong_nr(charstring id) runs on ConnHdlr {
+private function f_TC_chan_act_wrong_nr(charstring id) runs on ConnHdlr {
RSL.send(ts_RSL_CHAN_ACT(g_chan_nr, g_pars.chan_mode));
alt {
[] RSL.receive(tr_RSL_CHAN_ACT_ACK(g_chan_nr)) {
@@ -1571,7 +1571,7 @@
Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}
-function f_TC_ho_rach(charstring id) runs on ConnHdlr {
+private function f_TC_ho_rach(charstring id) runs on ConnHdlr {
var GsmFrameNumber fn;
var RSL_Message rm;
@@ -2000,7 +2000,7 @@
}
/* establish DChan, verify existance + contents of measurement reports */
-function f_TC_meas_res_periodic(charstring id) runs on ConnHdlr {
+private function f_TC_meas_res_periodic(charstring id) runs on ConnHdlr {
f_l1_tune(L1CTL);
RSL.clear;
@@ -2168,7 +2168,7 @@
}
/* Verify Tx power reduction and ramping up during BTS bring up */
-function f_TC_tx_power_start_ramp_up_bcch(charstring id) runs on ConnHdlr {
+private function f_TC_tx_power_start_ramp_up_bcch(charstring id) runs on
ConnHdlr {
f_l1_tune(L1CTL);
RSL.clear;
@@ -2188,7 +2188,7 @@
}
/* Verify Tx power reduction and ramping downd uring BTS bring shutdown due to
Abis link failure */
-function f_TC_tx_power_start_ramp_down_bcch(charstring id) runs on ConnHdlr {
+private function f_TC_tx_power_start_ramp_down_bcch(charstring id) runs on
ConnHdlr {
f_connhdlr_init_vty_bsc();
f_l1_tune(L1CTL);
@@ -2218,7 +2218,7 @@
* + ramping down during ADM state UNLOCKED->LOCKED
* + ramping up during ADM state LOCKED->UNLOCKED
*/
-function f_TC_tx_power_ramp_adm_state_change(charstring id) runs on ConnHdlr {
+private function f_TC_tx_power_ramp_adm_state_change(charstring id) runs on
ConnHdlr {
var L1ctlDlMessage l1_dl;
var integer last_rx_lvl;
@@ -2290,7 +2290,7 @@
/* see if the rsl meas res contains our expeced bs power level
bs power set during assignment */
-function f_TC_rsl_bs_pwr_static_ass(charstring id) runs on ConnHdlr {
+private function f_TC_rsl_bs_pwr_static_ass(charstring id) runs on ConnHdlr {
f_l1_tune(L1CTL);
RSL.clear;
@@ -2313,7 +2313,7 @@
/* see if the rsl meas res contains our expeced bs power level
bs power set after assignment */
-function f_TC_rsl_bs_pwr_static_power_control(charstring id) runs on ConnHdlr {
+private function f_TC_rsl_bs_pwr_static_power_control(charstring id) runs on
ConnHdlr {
f_l1_tune(L1CTL);
RSL.clear;
@@ -2364,7 +2364,7 @@
/* target level -100, first rssi -90, ms power 7, expected increase to 7+6
within 6 seconds,
second rssi -110, ms power 7+6, expected decrease to 7 within 6 seconds,
These power levels are valid for all bands and require no special handling */
-function f_TC_rsl_ms_pwr_dyn_ass_updown(charstring id) runs on ConnHdlr {
+private function f_TC_rsl_ms_pwr_dyn_ass_updown(charstring id) runs on
ConnHdlr {
var uint5_t pwr_var := 7;
var L1ctlDlMessage l1_dl;
@@ -2432,7 +2432,7 @@
}
Change in osmo-ttcn3-hacks[master]: bsc: verify System Information presence on RSL startup
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19062 ) Change subject: bsc: verify System Information presence on RSL startup .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19062/2/bsc/BSC_Tests.ttcn File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19062/2/bsc/BSC_Tests.ttcn@640 PS2, Line 640: deactivate > I'm not familiar with the details of SI during OML/RSL startup, […] An important thing that should be noted first is that the OML link and the RSL link(s) are separate TCP/IP connections. The OML link is established first, then the BSC configures all transceivers and timeslots, and after that the BSC indicates remote IP/port for the RSL link(s). All System Information messages are sent over the RSL link of C0. A BTS is considered "connected" when all its OML Managed Objects are "UNLOCKED", and all its transceivers have established the RSL connections. See all_trx_rsl_connected_unlocked(). I guess it works fine for you because we have TCP_NODELAY in the recent libosmo-abis. There is still a chance that not all System Information messages would arrive when f_wait_oml() returns and as_catch_RSL_sysinfo() gets deactivated. This would result in sporadic test case failures. The simplest, not elegant solution would be to call f_sleep(1.0) before deactivating as_catch_RSL_sysinfo(). The proper (IMO) solution would be to have a list of expected (not empty) System Information messages somewhere in the module parameters (in accordance with osmo-bsc.cfg), so you know what you're waiting for in the 'alt' statement, 'repeat' unless all expected kinds of SI are received, and fail if a timer expires. I am now also wondering whether we really need to expect/collect/check the SI messages here and thus in every test case, or exclusively in those ones that actually aimed to verify the SI. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a8ef404087efee491390dc1d2452ac323f145f0 Gerrit-Change-Number: 19062 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-CC: laforge Gerrit-Comment-Date: Sat, 04 Jul 2020 13:00:28 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: neels Gerrit-MessageType: comment
Change in osmo-bsc[master]: Don't print 'bogus channel load samplpe' message if total == 0
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19132 ) Change subject: Don't print 'bogus channel load samplpe' message if total == 0 .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19132 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I857fecc76dc16ba4431f3c0142bb0d798a9f73dc Gerrit-Change-Number: 19132 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt Gerrit-Comment-Date: Sat, 04 Jul 2020 12:55:26 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: Don't print 'bogus channel load samplpe' message if total == 0
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/19132 )
Change subject: Don't print 'bogus channel load samplpe' message if total == 0
..
Don't print 'bogus channel load samplpe' message if total == 0
Change-Id: I857fecc76dc16ba4431f3c0142bb0d798a9f73dc
Closes: OS#4614
---
M src/osmo-bsc/chan_alloc.c
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/32/19132/1
diff --git a/src/osmo-bsc/chan_alloc.c b/src/osmo-bsc/chan_alloc.c
index f23a982..9b80df3 100644
--- a/src/osmo-bsc/chan_alloc.c
+++ b/src/osmo-bsc/chan_alloc.c
@@ -203,9 +203,11 @@
}
/* Check for invalid samples (shouldn't happen). */
- if (total == 0 || used > total) {
+ if (used > total) {
LOG_BTS(bts, DRLL, LOGL_NOTICE, "bogus channel load sample
(used=%"PRIu64" / total=%"PRIu32")\n",
used, total);
+ }
+ if (total == 0 || used > total) {
bts->T3122 = 0; /* disable override of network-wide default
value */
bts->chan_load_samples_idx = 0; /* invalidate other samples
collected so far */
return;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19132
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I857fecc76dc16ba4431f3c0142bb0d798a9f73dc
Gerrit-Change-Number: 19132
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-MessageType: newchange
Change in libosmo-abis[master]: move flip_buf_bits() from DAHDI to a shared flip.c
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/19070 ) Change subject: move flip_buf_bits() from DAHDI to a shared flip.c .. Patch Set 5: As mentioned on IRC, replace with libosmocore implementation (possibly using LUT in libosmocore) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19070 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I8c6dc3eea921a73ebe65540aad0f0c0584d47e5a Gerrit-Change-Number: 19070 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: tnt Gerrit-Comment-Date: Sat, 04 Jul 2020 09:31:02 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmo-abis[master]: subchan_demux: Fix out-of-bounds write
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/19131 ) Change subject: subchan_demux: Fix out-of-bounds write .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19131 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I58d946265372278051e4f29301d4f201ab98c0fc Gerrit-Change-Number: 19131 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 04 Jul 2020 09:24:16 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-abis[master]: input/dahdi.c: Don't simply read beyond end of msgb
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/19127 ) Change subject: input/dahdi.c: Don't simply read beyond end of msgb .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: If84b31ea9a3fc7a6c8768918efed2822d1d58427 Gerrit-Change-Number: 19127 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: tnt Gerrit-Comment-Date: Sat, 04 Jul 2020 09:24:04 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-abis[master]: input/dahdi.c: Don't simply read beyond end of msgb
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/19127 )
Change subject: input/dahdi.c: Don't simply read beyond end of msgb
..
input/dahdi.c: Don't simply read beyond end of msgb
Let's first add two bytes to the msgb before writing. This way we
would assert in case there was no tailroom. As we just added tailroom
in the previous patch of this series, we are fine
Change-Id: If84b31ea9a3fc7a6c8768918efed2822d1d58427
Closes: OS#4644
---
M src/input/dahdi.c
1 file changed, 20 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/input/dahdi.c b/src/input/dahdi.c
index a461f27..8cebac3 100644
--- a/src/input/dahdi.c
+++ b/src/input/dahdi.c
@@ -224,7 +224,16 @@
struct e1inp_ts *e1i_ts = >ts[ts_nr-1];
int ret;
- ret = write(bfd->fd, msg->data, msg->len + 2);
+ if (msgb_tailroom(msg) >= 2) {
+ /* two bytes of space for the FCS added by DAHDI in the kernel
*/
+ msgb_put(msg, 2);
+ ret = write(bfd->fd, msg->data, msg->len);
+ } else {
+ /* work-around for code that sends us messages with no tailroom
(OS#4644) */
+ uint8_t buf[msg->len + 2];
+ memcpy(buf, msg->data, msg->len);
+ ret = write(bfd->fd, buf, sizeof(buf));
+ }
msgb_free(msg);
if (ret == -1)
handle_dahdi_exception(e1i_ts);
@@ -273,7 +282,16 @@
if (!msg)
return;
- ret = write(bfd->fd, msg->data, msg->len + 2);
+ if (msgb_tailroom(msg) >= 2) {
+ /* two bytes of space for the FCS added by DAHDI in the kernel
*/
+ msgb_put(msg, 2);
+ ret = write(bfd->fd, msg->data, msg->len);
+ } else {
+ /* work-around for code that sends us messages with no tailroom
(OS#4644) */
+ uint8_t buf[msg->len + 2];
+ memcpy(buf, msg->data, msg->len);
+ ret = write(bfd->fd, buf, sizeof(buf));
+ }
msgb_free(msg);
if (ret == -1)
handle_dahdi_exception(e1i_ts);
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19127
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: If84b31ea9a3fc7a6c8768918efed2822d1d58427
Gerrit-Change-Number: 19127
Gerrit-PatchSet: 2
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: tnt
Gerrit-MessageType: merged
Change in libosmo-abis[master]: subchan_demux: Fix out-of-bounds write
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/19131 )
Change subject: subchan_demux: Fix out-of-bounds write
..
subchan_demux: Fix out-of-bounds write
We cannot blindly append two ubits to the 320-ubit sized buffer. In the
end, we may already fill the buffer after the first ubit, causing a
buffer overflow with the second ubit.
Lets check if the buffer is full after every bit. Avoid copy+pasting
but move the code repeated per bit to a new function.
Change-Id: I58d946265372278051e4f29301d4f201ab98c0fc
Closes: OS#4648
---
M src/subchan_demux.c
1 file changed, 25 insertions(+), 23 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/subchan_demux.c b/src/subchan_demux.c
index 55503db..a3a44d9 100644
--- a/src/subchan_demux.c
+++ b/src/subchan_demux.c
@@ -92,6 +92,29 @@
return 0;
}
+static void append_bit_resync_out(struct subch_demux *dmx, int c, ubit_t bit)
+{
+ struct demux_subch *sch = >subch[c];
+ append_bit(sch, bit);
+
+ if (sync_hdr_complete(sch, bit))
+ resync_to_here(sch);
+
+ /* FIXME: verify the first bit in octet 2, 4, 6, ...
+* according to TS 08.60 4.8.1 */
+
+ /* once we have reached TRAU_FRAME_BITS, call
+* the TRAU frame handler callback function */
+ if (sch->out_idx >= TRAU_FRAME_BITS) {
+ if (sch->in_sync) {
+ dmx->out_cb(dmx, c, sch->out_bitbuf,
+ sch->out_idx, dmx->data);
+ sch->in_sync = 0;
+ }
+ sch->out_idx = 0;
+ }
+}
+
/*! \brief Input some data from the 64k full-slot into subchannel demux
* \param[in] dmx subchannel demuxer
* \param[in] data pointer to buffer containing input data
@@ -108,7 +131,6 @@
uint8_t inbyte = data[i];
for (c = 0; c < NR_SUBCH; c++) {
- struct demux_subch *sch = >subch[c];
uint8_t inbits;
uint8_t bit;
@@ -123,33 +145,13 @@
bit = 1;
else
bit = 0;
- append_bit(sch, bit);
-
- if (sync_hdr_complete(sch, bit))
- resync_to_here(sch);
+ append_bit_resync_out(dmx, c, bit);
if (inbits & 0x02)
bit = 1;
else
bit = 0;
- append_bit(sch, bit);
-
- if (sync_hdr_complete(sch, bit))
- resync_to_here(sch);
-
- /* FIXME: verify the first bit in octet 2, 4, 6, ...
-* according to TS 08.60 4.8.1 */
-
- /* once we have reached TRAU_FRAME_BITS, call
-* the TRAU frame handler callback function */
- if (sch->out_idx >= TRAU_FRAME_BITS) {
- if (sch->in_sync) {
- dmx->out_cb(dmx, c, sch->out_bitbuf,
- sch->out_idx, dmx->data);
- sch->in_sync = 0;
- }
- sch->out_idx = 0;
- }
+ append_bit_resync_out(dmx, c, bit);
}
}
return i;
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19131
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I58d946265372278051e4f29301d4f201ab98c0fc
Gerrit-Change-Number: 19131
Gerrit-PatchSet: 2
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in libosmocore[master]: lapd_core: After calling into L3, check if the state has changed
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19130 ) Change subject: lapd_core: After calling into L3, check if the state has changed .. lapd_core: After calling into L3, check if the state has changed While processing an I-frame we may deliver its payload to L3. After returning from L3 procesing, we run some additional code, assuming the LAPD/DL state has not changed meanwhile. However, if the application destroys the LAPD/DL meanwhile, our state might be NULL again, and in this state we should not perform any further action. This is one of the cases where synchronous in-line dispatch across various layers is hitting us. L3 should have an input queue, and only start processing after all L2 work has completed and we're about to go back to sleep in select(). Change-Id: I026b64503511002c13c0f4117648c366c48ecc62 Related: OS#1761 Closes: OS#4646 --- M src/gsm/lapd_core.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/gsm/lapd_core.c b/src/gsm/lapd_core.c index cf25f3d..6a56572 100644 --- a/src/gsm/lapd_core.c +++ b/src/gsm/lapd_core.c @@ -1578,6 +1578,10 @@ msgb_free(msg); } + /* the L3 or higher (called in-line above via send_dl_l3) might have destroyed the +* data link meanwhile. See OS#1761 */ + if (dl->state == LAPD_STATE_NULL) + return 0; } else LOGDL(dl, LOGL_INFO, "I frame ignored during own receiver busy condition\n"); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19130 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I026b64503511002c13c0f4117648c366c48ecc62 Gerrit-Change-Number: 19130 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in libosmocore[master]: lapd_core: Ensure we always have some tailroom
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19128 ) Change subject: lapd_core: Ensure we always have some tailroom .. lapd_core: Ensure we always have some tailroom At some points, e.g. when allocating message buffers from the Tx history, we used to allocate them exactly as large as the defined headroom plus the user data. This means that the underlying PH layer (E1 mostly) had no tailroom to add anything to the end of the message. Especially for DAHDI this is a problem, as we need to make space for two more bytes of frame check sequence (FCS). So let's simply make sure we always have some extra space at the end of such buffers. Change-Id: Id362ce131157c7513d744b0248c7f78fb75c590c Related: OS#4644 --- M src/gsm/lapd_core.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/gsm/lapd_core.c b/src/gsm/lapd_core.c index c77b663..cf25f3d 100644 --- a/src/gsm/lapd_core.c +++ b/src/gsm/lapd_core.c @@ -104,6 +104,7 @@ #define CR_NET2USER_RESP 0 #define LAPD_HEADROOM 56 +#define LAPD_TAILROOM 16 #define SBIT(a) (1 << a) #define ALL_STATES 0x @@ -120,7 +121,7 @@ /* adding space for padding, FIXME: add as an option */ if (length < 21) length = 21; - return msgb_alloc_headroom(length + LAPD_HEADROOM, LAPD_HEADROOM, name); + return msgb_alloc_headroom(length + LAPD_HEADROOM + LAPD_TAILROOM, LAPD_HEADROOM, name); } static inline uint8_t do_mod(uint8_t x, uint8_t m) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id362ce131157c7513d744b0248c7f78fb75c590c Gerrit-Change-Number: 19128 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in libosmocore[master]: lapd_core: After calling into L3, check if the state has changed
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19130 ) Change subject: lapd_core: After calling into L3, check if the state has changed .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19130 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I026b64503511002c13c0f4117648c366c48ecc62 Gerrit-Change-Number: 19130 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 04 Jul 2020 09:22:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: lapd_core: Ensure we always have some tailroom
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19128 ) Change subject: lapd_core: Ensure we always have some tailroom .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id362ce131157c7513d744b0248c7f78fb75c590c Gerrit-Change-Number: 19128 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 04 Jul 2020 09:22:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-abis[master]: WIP: trau_frame: New API
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/18249 to look at the new patch set (#7). Change subject: WIP: trau_frame: New API .. WIP: trau_frame: New API The old TRAU frame code in src/trau_frame.c (which is for some strange reason part of libosmo-abis, and not libosmo-trau!) was introduced more than a decade ago for the needs of bs11_abis AKA OpenBSC aka OsmoNITB. It is too constrained to implement TRAU frame parsing in a generic way, including: * no way to add support for 8k sub-slots * no way to handle CRC bits or UFI (i.e. no AMR) * no real API design, it was just ripped out from OsmoNITB and moved into a library (even the wrong one) For those reasons, let's introduce a new API for TRAU frame encoding/decoding - one that supports all the relevant use cases. This is marked WIP until the part handling T-bits is properly implemented. Change-Id: I5cf42e6c445d9224be18503cebc7584b3beba08c --- M include/Makefile.am A include/osmocom/trau/trau_frame.h M src/Makefile.am A src/trau/trau_frame.c 4 files changed, 1,473 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/49/18249/7 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/18249 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I5cf42e6c445d9224be18503cebc7584b3beba08c Gerrit-Change-Number: 18249 Gerrit-PatchSet: 7 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in libosmo-abis[master]: e1_input: Support I.460 timeslot type
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/18933 to look at the new patch set (#2). Change subject: e1_input: Support I.460 timeslot type .. e1_input: Support I.460 timeslot type Unlike the legacy TRAU mode, this only adds I460 mux/demux, without any TRAU frame synchronization. The user must still be adding the actual sub-channels using osmo_i460_subchan_add() depending on his requirements. Change-Id: I44da6dfec77ef475adb35001a0e4fa11d549aa02 --- M include/osmocom/abis/e1_input.h M src/e1_input.c M src/input/dahdi.c M src/input/e1d.c M src/input/misdn.c 5 files changed, 41 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/33/18933/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/18933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I44da6dfec77ef475adb35001a0e4fa11d549aa02 Gerrit-Change-Number: 18933 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in libosmo-abis[master]: subchan_demux: Fix out-of-bounds write
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmo-abis/+/19131 )
Change subject: subchan_demux: Fix out-of-bounds write
..
subchan_demux: Fix out-of-bounds write
We cannot blindly append two ubits to the 320-ubit sized buffer. In the
end, we may already fill the buffer after the first ubit, causing a
buffer overflow with the second ubit.
Lets check if the buffer is full after every bit. Avoid copy+pasting
but move the code repeated per bit to a new function.
Change-Id: I58d946265372278051e4f29301d4f201ab98c0fc
Closes: OS#4648
---
M src/subchan_demux.c
1 file changed, 25 insertions(+), 23 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/31/19131/1
diff --git a/src/subchan_demux.c b/src/subchan_demux.c
index 55503db..a3a44d9 100644
--- a/src/subchan_demux.c
+++ b/src/subchan_demux.c
@@ -92,6 +92,29 @@
return 0;
}
+static void append_bit_resync_out(struct subch_demux *dmx, int c, ubit_t bit)
+{
+ struct demux_subch *sch = >subch[c];
+ append_bit(sch, bit);
+
+ if (sync_hdr_complete(sch, bit))
+ resync_to_here(sch);
+
+ /* FIXME: verify the first bit in octet 2, 4, 6, ...
+* according to TS 08.60 4.8.1 */
+
+ /* once we have reached TRAU_FRAME_BITS, call
+* the TRAU frame handler callback function */
+ if (sch->out_idx >= TRAU_FRAME_BITS) {
+ if (sch->in_sync) {
+ dmx->out_cb(dmx, c, sch->out_bitbuf,
+ sch->out_idx, dmx->data);
+ sch->in_sync = 0;
+ }
+ sch->out_idx = 0;
+ }
+}
+
/*! \brief Input some data from the 64k full-slot into subchannel demux
* \param[in] dmx subchannel demuxer
* \param[in] data pointer to buffer containing input data
@@ -108,7 +131,6 @@
uint8_t inbyte = data[i];
for (c = 0; c < NR_SUBCH; c++) {
- struct demux_subch *sch = >subch[c];
uint8_t inbits;
uint8_t bit;
@@ -123,33 +145,13 @@
bit = 1;
else
bit = 0;
- append_bit(sch, bit);
-
- if (sync_hdr_complete(sch, bit))
- resync_to_here(sch);
+ append_bit_resync_out(dmx, c, bit);
if (inbits & 0x02)
bit = 1;
else
bit = 0;
- append_bit(sch, bit);
-
- if (sync_hdr_complete(sch, bit))
- resync_to_here(sch);
-
- /* FIXME: verify the first bit in octet 2, 4, 6, ...
-* according to TS 08.60 4.8.1 */
-
- /* once we have reached TRAU_FRAME_BITS, call
-* the TRAU frame handler callback function */
- if (sch->out_idx >= TRAU_FRAME_BITS) {
- if (sch->in_sync) {
- dmx->out_cb(dmx, c, sch->out_bitbuf,
- sch->out_idx, dmx->data);
- sch->in_sync = 0;
- }
- sch->out_idx = 0;
- }
+ append_bit_resync_out(dmx, c, bit);
}
}
return i;
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19131
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I58d946265372278051e4f29301d4f201ab98c0fc
Gerrit-Change-Number: 19131
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-MessageType: newchange
Change in libosmo-abis[master]: WIP: Add new TRAU frame sync code
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/18250 to look at the new patch set (#8). Change subject: WIP: Add new TRAU frame sync code .. WIP: Add new TRAU frame sync code This code is able to detect and sync against a variety of TRAU frame sync patterns. Focus is so far on those patterns present on 16k sub-slots, but 8k sub-slots are expected to be supported soon, too. A new codebase for this is required as the old OsmoNITB code had conflated a 16k sub-slot multiplexer with TRAU frame synchronization, so there was no way to separate those two parts and hence no way to support 8k sub-slots. Change-Id: Ia6fe6228b0b8b9a27999f37ce1115ed5558881ea --- M include/Makefile.am A include/osmocom/trau/trau_sync.h M src/Makefile.am A src/trau/trau_sync.c A src/trau/ubit_buf.h M tests/Makefile.am M tests/testsuite.at A tests/trau_sync/trau_sync_test.c A tests/trau_sync/trau_sync_test.err A tests/trau_sync/trau_sync_test.ok 10 files changed, 702 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/50/18250/8 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/18250 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ia6fe6228b0b8b9a27999f37ce1115ed5558881ea Gerrit-Change-Number: 18250 Gerrit-PatchSet: 8 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in libosmocore[master]: lapd_core: After calling into L3, check if the state has changed
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/19130 ) Change subject: lapd_core: After calling into L3, check if the state has changed .. lapd_core: After calling into L3, check if the state has changed While processing an I-frame we may deliver its payload to L3. After returning from L3 procesing, we run some additional code, assuming the LAPD/DL state has not changed meanwhile. However, if the application destroys the LAPD/DL meanwhile, our state might be NULL again, and in this state we should not perform any further action. This is one of the cases where synchronous in-line dispatch across various layers is hitting us. L3 should have an input queue, and only start processing after all L2 work has completed and we're about to go back to sleep in select(). Change-Id: I026b64503511002c13c0f4117648c366c48ecc62 Related: OS#1761 Closes: OS#4646 --- M src/gsm/lapd_core.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/30/19130/1 diff --git a/src/gsm/lapd_core.c b/src/gsm/lapd_core.c index cf25f3d..6a56572 100644 --- a/src/gsm/lapd_core.c +++ b/src/gsm/lapd_core.c @@ -1578,6 +1578,10 @@ msgb_free(msg); } + /* the L3 or higher (called in-line above via send_dl_l3) might have destroyed the +* data link meanwhile. See OS#1761 */ + if (dl->state == LAPD_STATE_NULL) + return 0; } else LOGDL(dl, LOGL_INFO, "I frame ignored during own receiver busy condition\n"); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19130 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I026b64503511002c13c0f4117648c366c48ecc62 Gerrit-Change-Number: 19130 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange
Change in osmo-mgw[master]: endp: add E1 endpoint interlocking
Hello pespin, neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/18898 to look at the new patch set (#10). Change subject: endp: add E1 endpoint interlocking .. endp: add E1 endpoint interlocking E1 endpoint names also represent different rates, this may mean that some rate / subslot combinations are not possible because they overlap within nthe timeslot. When the equipment (BSC) is properly configured, this will be no problem, however invalid configuration may cause the selection of overlapping endpoints and this needs to be prevented, and logged. Also rate counters need to be in place. Change-Id: I18e90b10648a7e504371179ad144645fc82e1c27 Related: OS#2547 --- M include/osmocom/mgcp/mgcp_endp.h M include/osmocom/mgcp/mgcp_ratectr.h M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_protocol.c M src/libosmo-mgcp/mgcp_ratectr.c M src/libosmo-mgcp/mgcp_vty.c 6 files changed, 301 insertions(+), 27 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/98/18898/10 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I18e90b10648a7e504371179ad144645fc82e1c27 Gerrit-Change-Number: 18898 Gerrit-PatchSet: 10 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-mgw[master]: mgcp_vty: be more specific about E1 trunks
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/19103 to look at the new patch set (#4). Change subject: mgcp_vty: be more specific about E1 trunks .. mgcp_vty: be more specific about E1 trunks Currently only E1 trunks can be crated using the node "trunk". However, should we ever introduce another trunk type we will not be able to distinguish the new trunk type. Lets rename "trunk" to "trunk-e1" along with its underlying constants and function names so that we can easily add another "trunk-t1" for example without making old configs incompatible with the old concept. Related: OS#2659 Change-Id: I22c39ee9a36e4e737992c91677f3e315907a4c7e --- M include/osmocom/mgcp/vty.h M src/libosmo-mgcp/mgcp_vty.c M src/osmo-mgw/mgw_main.c 3 files changed, 34 insertions(+), 34 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/03/19103/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I22c39ee9a36e4e737992c91677f3e315907a4c7e Gerrit-Change-Number: 19103 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-mgw[master]: trunk: parse E1 trunk number
Hello pespin, neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/18752 to look at the new patch set (#14). Change subject: trunk: parse E1 trunk number .. trunk: parse E1 trunk number The E1 trunk number is currently not parsed, whenever a trunk prefix is detected that indicates an E1 trunk, then the entire request is rejected. Parse the trunk number and select the trunk accordingly Related: OS#2547 Change-Id: Ifdaab953544151e73b58cc3e95d21afdb40765f4 --- M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/mgcp_trunk.c M tests/mgcp/mgcp_test.c 3 files changed, 70 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/52/18752/14 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18752 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifdaab953544151e73b58cc3e95d21afdb40765f4 Gerrit-Change-Number: 18752 Gerrit-PatchSet: 14 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-mgw[master]: mgcp_test: do not access endpoint array elements directly
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/19120 to look at the new patch set (#2). Change subject: mgcp_test: do not access endpoint array elements directly .. mgcp_test: do not access endpoint array elements directly The test assumes that the endpoint "rtpbridge/X@mgw" is at array position X in many places. This does not necessarly have to match. Accessing the array elements directly was the prefered way when the MGW did use integer numbers and not strings to identify endpoints. Since the endpoint name strings are used to access the endpoints the unit-test should also reflect this. Lets replace the integer variable last_endpoint with a string variable and do related verifications based on strings. Change-Id: Ic950c427f23be4a792af94972554637c2b0fbdf2 Related: OS#2659 --- M tests/mgcp/mgcp_test.c 1 file changed, 31 insertions(+), 31 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/20/19120/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic950c427f23be4a792af94972554637c2b0fbdf2 Gerrit-Change-Number: 19120 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-mgw[master]: mgcp_vty: refactor endpoint number configuration
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/19121 to look at the new patch set (#2). Change subject: mgcp_vty: refactor endpoint number configuration .. mgcp_vty: refactor endpoint number configuration At the moment the number of possible E1 endpoints (depends on the number of E1 timeslots that should be used) is hardcoded and the configuration of the number of virtual endpoints has an off-by-one problem. For the E1 timeslots one might choose not to occupy all E1 timeslots of once. A one TRX E1 BTS usually requires 3 E1 timeslots. One as D-Channel timeslot and two to cover the voice channels. The voice channels timeslots need to be set up in osmo-mgw, while the D-Channel timeslot must not be touched. The VTY config needs to be able to reflect that. Change-Id: I73b31e3c236a61ea0a6f76ef5ff98ce589f52c77 Related: OS#2547 --- M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/mgcp_trunk.c M src/libosmo-mgcp/mgcp_vty.c M tests/mgcp/mgcp_test.c 4 files changed, 85 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/21/19121/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I73b31e3c236a61ea0a6f76ef5ff98ce589f52c77 Gerrit-Change-Number: 19121 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-mgw[master]: mgcp_endp: use define constant to define max number of E1 subslots
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/19118 to look at the new patch set (#2). Change subject: mgcp_endp: use define constant to define max number of E1 subslots .. mgcp_endp: use define constant to define max number of E1 subslots There are 15 possible subslots (not all at the same time) in one E1 timeslot. Lets use a define constant for that. Change-Id: If7cb74e486946aff09e22abf8a8885bf0693f34e Related: OS#2547 --- M include/osmocom/mgcp/mgcp_endp.h M src/libosmo-mgcp/mgcp_endp.c 2 files changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/18/19118/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: If7cb74e486946aff09e22abf8a8885bf0693f34e Gerrit-Change-Number: 19118 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-mgw[master]: mgcp_trunk: remove double check
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/19119 to look at the new patch set (#2). Change subject: mgcp_trunk: remove double check .. mgcp_trunk: remove double check At the moment, the trunk prefix is checked twice. Lets re-arange the code a bit so that the check only happens once. Change-Id: I91fb8cf6e3b077ba8f18fdbcd071275c6fd7cacd Related: OS#2547 --- M src/libosmo-mgcp/mgcp_trunk.c 1 file changed, 3 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/19/19119/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19119 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I91fb8cf6e3b077ba8f18fdbcd071275c6fd7cacd Gerrit-Change-Number: 19119 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-mgw[master]: mgcp_trunk: pick trunk by number and type
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/19102 to look at the new patch set (#4). Change subject: mgcp_trunk: pick trunk by number and type .. mgcp_trunk: pick trunk by number and type The function mgcp_trunk_by_num() is used to directly pick a specific trunk that is known by its id number (sometimes called "index"). Traditionally the virtual trunk will reside under id number 0 and all consecutively created E1 trunks will be created under number 1 to 64. This works fine, but puts a limitation on us should we ever introduce an aditional trunk type (e.g. T1). Since the numbers must be unique regardless of the trunk type one could not have an E1 trunk number 1 and e.g. a T1 trunk number 1 at the same time. So we should pick the trunk not only by its number, but also by its type to allow different trunk types to carry the same number. The trunks will still be distinguishable by its type along with the respective endpoint prefix. Change-Id: I7af1e9ce601babd4a51e88201a98319e03945f83 Related: OS#2659 --- M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/mgcp_osmux.c M src/libosmo-mgcp/mgcp_trunk.c M src/libosmo-mgcp/mgcp_vty.c M tests/mgcp/mgcp_test.c 5 files changed, 49 insertions(+), 47 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/02/19102/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I7af1e9ce601babd4a51e88201a98319e03945f83 Gerrit-Change-Number: 19102 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-mgw[master]: mgcp_client: add function to generate e1-endpoint names
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/19075 to look at the new patch set (#5). Change subject: mgcp_client: add function to generate e1-endpoint names .. mgcp_client: add function to generate e1-endpoint names mgcp_client.h offers functions to generate endpoint names for wildcarded request. This is used in osmo-bsc, lets now also add a function that can generate e1-endpoint names. Related: OS#2547 Change-Id: Iec35b5bae8a7b07ddb3559f7114a24dcd10e8f14 --- M include/osmocom/mgcp_client/mgcp_client.h M src/libosmo-mgcp-client/mgcp_client.c 2 files changed, 62 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/75/19075/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19075 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iec35b5bae8a7b07ddb3559f7114a24dcd10e8f14 Gerrit-Change-Number: 19075 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-mgw[master]: endp: require domain name also for E1 endpoints
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/19074 to look at the new patch set (#5). Change subject: endp: require domain name also for E1 endpoints .. endp: require domain name also for E1 endpoints RFC3435 requires an MGW domain name appeneded to every endpoints. When defining endpoint names in Appendix E, the domain name is is not mentioned for digital trunks, however, this does not mean that digital trunks do not have a domain appended. Osmo-mgw currently violates the spec because it explicitly checks if the domain name is _NOT_ present for E1 endpoints. Change-Id: Ibb800b689e090b97b58d0206959b660890acd967 --- M src/libosmo-mgcp/mgcp_endp.c 1 file changed, 14 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/74/19074/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19074 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ibb800b689e090b97b58d0206959b660890acd967 Gerrit-Change-Number: 19074 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-mgw[master]: endp: add typeset for e1-endpoints
Hello pespin, neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/18755 to look at the new patch set (#10). Change subject: endp: add typeset for e1-endpoints .. endp: add typeset for e1-endpoints Add an endpoint typeset for E1 support, also lets add dummy callbacks for the cleanup and rtp dispatch functionality. Related: OS#2547 Change-Id: I68b719a906e8f7251f0ca8c74ceec73bc40376f7 --- M include/osmocom/mgcp/mgcp_endp.h M include/osmocom/mgcp/mgcp_internal.h M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_network.c 4 files changed, 41 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/55/18755/10 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I68b719a906e8f7251f0ca8c74ceec73bc40376f7 Gerrit-Change-Number: 18755 Gerrit-PatchSet: 10 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-msc[master]: is_reset_msg: use proper enum for rc value
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/19129 ) Change subject: is_reset_msg: use proper enum for rc value .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-msc/+/19129/1/src/libmsc/ran_peer.c File src/libmsc/ran_peer.c: https://gerrit.osmocom.org/c/osmo-msc/+/19129/1/src/libmsc/ran_peer.c@215 PS1, Line 215: 1 SCCP_RAN_MSG_RESET? https://gerrit.osmocom.org/c/osmo-msc/+/19129/1/src/libmsc/ran_peer.c@218 PS1, Line 218: 2 SCCP_RAN_MSG_RESET_ACK? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/19129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I88b6204bc3ffac06f92bfc87639ce503b2da24bc Gerrit-Change-Number: 19129 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Sat, 04 Jul 2020 06:28:35 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
