Build failure of network:osmocom:nightly/osmo-sgsn in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 272s] [455/513] installing python3-3.9.0-3 [ 272s] Processing triggers for man-db (2.9.3-2) ... [ 273s] [456/513] installing texlive-plain-generic-2020.20201129-1 [ 277s] Processing triggers for tex-common (6.15) ... [ 277s] Running mktexlsr. This may take some time... done. [ 278s] [457/513] installing libosmo-netif-dev-1.0.0.8.bd77 [ 278s] [458/513] installing texlive-latex-base-2020.20201129-2 [ 278s] Processing triggers for man-db (2.9.3-2) ... [ 279s] Processing triggers for tex-common (6.15) ... [ 279s] Running mktexlsr. This may take some time... done. [ 280s] Running updmap-sys. This may take some time... done. [ 280s] Running mktexlsr /var/lib/texmf ... done. [ 280s] Building format(s) --all. [ 289s]This may take some time... [ 289s] fmtutil failed. Output has been stored in [ 289s] /tmp/fmtutil.HJgsbIqc [ 289s] Please include this file if you report a bug. [ 289s] dpkg: error processing package tex-common (--install): [ 289s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 289s] Errors were encountered while processing: [ 289s] tex-common [ 289s] exit ... [ 289s] ### VM INTERACTION START ### [ 292s] [ 258.300858] sysrq: Power Off [ 292s] [ 258.307440] reboot: Power down [ 292s] ### VM INTERACTION END ### [ 292s] [ 292s] cloud129 failed "build osmo-sgsn_1.6.0.64.9e58.dsc" at Tue Dec 1 05:52:44 UTC 2020. [ 292s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-msc in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 130s] [458/516] installing python3-3.9.0-3 [ 131s] Processing triggers for man-db (2.9.3-2) ... [ 131s] [459/516] installing texlive-plain-generic-2020.20201129-1 [ 134s] Processing triggers for tex-common (6.15) ... [ 134s] Running mktexlsr. This may take some time... done. [ 134s] [460/516] installing libosmo-netif-dev-1.0.0.8.bd77 [ 134s] [461/516] installing texlive-latex-base-2020.20201129-2 [ 134s] Processing triggers for man-db (2.9.3-2) ... [ 134s] Processing triggers for tex-common (6.15) ... [ 135s] Running mktexlsr. This may take some time... done. [ 135s] Running updmap-sys. This may take some time... done. [ 135s] Running mktexlsr /var/lib/texmf ... done. [ 135s] Building format(s) --all. [ 141s]This may take some time... [ 141s] fmtutil failed. Output has been stored in [ 141s] /tmp/fmtutil.jWWK6yrI [ 141s] Please include this file if you report a bug. [ 141s] dpkg: error processing package tex-common (--install): [ 141s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 141s] Errors were encountered while processing: [ 141s] tex-common [ 141s] exit ... [ 141s] ### VM INTERACTION START ### [ 144s] [ 129.115815] sysrq: Power Off [ 144s] [ 129.119877] reboot: Power down [ 144s] ### VM INTERACTION END ### [ 144s] [ 144s] sheep85 failed "build osmo-msc_1.6.1.87.e917b.dsc" at Tue Dec 1 05:40:06 UTC 2020. [ 144s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-ggsn in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-ggsn/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-ggsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-ggsn Last lines of build log: [ 181s] Running mktexlsr /var/lib/texmf ... done. [ 181s] [436/492] installing python3-3.9.0-3 [ 181s] Processing triggers for man-db (2.9.3-2) ... [ 181s] [437/492] installing texlive-plain-generic-2020.20201129-1 [ 184s] Processing triggers for tex-common (6.15) ... [ 185s] Running mktexlsr. This may take some time... done. [ 185s] [438/492] installing texlive-latex-base-2020.20201129-2 [ 185s] Processing triggers for man-db (2.9.3-2) ... [ 186s] Processing triggers for tex-common (6.15) ... [ 186s] Running mktexlsr. This may take some time... done. [ 186s] Running updmap-sys. This may take some time... done. [ 186s] Running mktexlsr /var/lib/texmf ... done. [ 187s] Building format(s) --all. [ 194s]This may take some time... [ 194s] fmtutil failed. Output has been stored in [ 194s] /tmp/fmtutil.GVKgyIrr [ 194s] Please include this file if you report a bug. [ 194s] dpkg: error processing package tex-common (--install): [ 194s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 194s] Errors were encountered while processing: [ 194s] tex-common [ 194s] exit ... [ 194s] ### VM INTERACTION START ### [ 197s] [ 177.616826] sysrq: Power Off [ 197s] [ 177.627636] reboot: Power down [ 197s] ### VM INTERACTION END ### [ 197s] [ 197s] lamb12 failed "build osmo-ggsn_1.6.0.13.1230.dsc" at Tue Dec 1 05:37:56 UTC 2020. [ 197s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-hlr in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-hlr failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [ 178s] [445/502] installing python3-3.9.0-3 [ 178s] Processing triggers for man-db (2.9.3-2) ... [ 179s] [446/502] installing texlive-plain-generic-2020.20201129-1 [ 182s] Processing triggers for tex-common (6.15) ... [ 182s] Running mktexlsr. This may take some time... done. [ 182s] [447/502] installing libosmo-netif-dev-1.0.0.8.bd77 [ 182s] [448/502] installing texlive-latex-base-2020.20201129-2 [ 183s] Processing triggers for man-db (2.9.3-2) ... [ 183s] Processing triggers for tex-common (6.15) ... [ 183s] Running mktexlsr. This may take some time... done. [ 184s] Running updmap-sys. This may take some time... done. [ 184s] Running mktexlsr /var/lib/texmf ... done. [ 184s] Building format(s) --all. [ 191s]This may take some time... [ 191s] fmtutil failed. Output has been stored in [ 191s] /tmp/fmtutil.VHOYGTSY [ 191s] Please include this file if you report a bug. [ 191s] dpkg: error processing package tex-common (--install): [ 191s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 191s] Errors were encountered while processing: [ 191s] tex-common [ 191s] exit ... [ 191s] ### VM INTERACTION START ### [ 194s] [ 175.383169] sysrq: Power Off [ 194s] [ 175.389959] reboot: Power down [ 194s] ### VM INTERACTION END ### [ 194s] [ 194s] lamb23 failed "build osmo-hlr_1.2.0.67.dac8.dsc" at Tue Dec 1 05:30:32 UTC 2020. [ 194s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-mgw in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-mgw failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-mgw Last lines of build log: [ 133s] [442/499] installing python3-3.9.0-3 [ 133s] Processing triggers for man-db (2.9.3-2) ... [ 133s] [443/499] installing texlive-plain-generic-2020.20201129-1 [ 136s] Processing triggers for tex-common (6.15) ... [ 136s] Running mktexlsr. This may take some time... done. [ 136s] [444/499] installing libosmo-netif-dev-1.0.0.8.bd77 [ 136s] [445/499] installing texlive-latex-base-2020.20201129-2 [ 137s] Processing triggers for man-db (2.9.3-2) ... [ 137s] Processing triggers for tex-common (6.15) ... [ 137s] Running mktexlsr. This may take some time... done. [ 138s] Running updmap-sys. This may take some time... done. [ 138s] Running mktexlsr /var/lib/texmf ... done. [ 138s] Building format(s) --all. [ 144s]This may take some time... [ 144s] fmtutil failed. Output has been stored in [ 144s] /tmp/fmtutil.ckw8bbAn [ 144s] Please include this file if you report a bug. [ 144s] dpkg: error processing package tex-common (--install): [ 144s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 144s] Errors were encountered while processing: [ 144s] tex-common [ 144s] exit ... [ 144s] ### VM INTERACTION START ### [ 147s] [ 122.763822] sysrq: Power Off [ 147s] [ 122.765654] reboot: Power down [ 147s] ### VM INTERACTION END ### [ 147s] [ 147s] wildcard2 failed "build osmo-mgw_1.7.0.130.3c29.dsc" at Tue Dec 1 05:28:20 UTC 2020. [ 147s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libosmo-sccp in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/Debian_Unstable/x86_64 Package network:osmocom:nightly/libosmo-sccp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 216s] [445/502] installing python3-3.9.0-3 [ 216s] Processing triggers for man-db (2.9.3-2) ... [ 217s] [446/502] installing texlive-plain-generic-2020.20201129-1 [ 220s] Processing triggers for tex-common (6.15) ... [ 220s] Running mktexlsr. This may take some time... done. [ 220s] [447/502] installing libosmo-netif-dev-1.0.0.8.bd77 [ 220s] [448/502] installing texlive-latex-base-2020.20201129-2 [ 221s] Processing triggers for man-db (2.9.3-2) ... [ 221s] Processing triggers for tex-common (6.15) ... [ 221s] Running mktexlsr. This may take some time... done. [ 222s] Running updmap-sys. This may take some time... done. [ 222s] Running mktexlsr /var/lib/texmf ... done. [ 222s] Building format(s) --all. [ 229s]This may take some time... [ 229s] fmtutil failed. Output has been stored in [ 229s] /tmp/fmtutil.2Bd3v4Vg [ 229s] Please include this file if you report a bug. [ 229s] dpkg: error processing package tex-common (--install): [ 229s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 229s] Errors were encountered while processing: [ 229s] tex-common [ 229s] exit ... [ 229s] ### VM INTERACTION START ### [ 232s] [ 213.683223] sysrq: Power Off [ 232s] [ 213.688206] reboot: Power down [ 232s] ### VM INTERACTION END ### [ 232s] [ 232s] lamb15 failed "build libosmo-sccp_1.3.0.25.48e2.dsc" at Tue Dec 1 05:27:54 UTC 2020. [ 232s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 171s] Running mktexlsr /var/lib/texmf ... done. [ 171s] [416/471] installing python3-3.9.0-3 [ 171s] Processing triggers for man-db (2.9.3-2) ... [ 171s] [417/471] installing texlive-plain-generic-2020.20201129-1 [ 174s] Processing triggers for tex-common (6.15) ... [ 175s] Running mktexlsr. This may take some time... done. [ 175s] [418/471] installing texlive-latex-base-2020.20201129-2 [ 175s] Processing triggers for man-db (2.9.3-2) ... [ 176s] Processing triggers for tex-common (6.15) ... [ 176s] Running mktexlsr. This may take some time... done. [ 176s] Running updmap-sys. This may take some time... done. [ 176s] Running mktexlsr /var/lib/texmf ... done. [ 177s] Building format(s) --all. [ 184s]This may take some time... [ 184s] fmtutil failed. Output has been stored in [ 184s] /tmp/fmtutil.rv6IIUoz [ 184s] Please include this file if you report a bug. [ 184s] dpkg: error processing package tex-common (--install): [ 184s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 184s] Errors were encountered while processing: [ 184s] tex-common [ 184s] exit ... [ 184s] ### VM INTERACTION START ### [ 187s] [ 170.185086] sysrq: Power Off [ 187s] [ 170.192646] reboot: Power down [ 187s] ### VM INTERACTION END ### [ 187s] [ 187s] lamb13 failed "build osmo-gsm-manuals-dev_0.3.0.37.c507.dsc" at Tue Dec 1 05:10:51 UTC 2020. [ 187s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 156s] [COMPILING libboard/qmod/source/wwan_perst.c] [ 156s] [COMPILING libboard/qmod/source/card_pres.c] [ 156s] [COMPILING libboard/qmod/source/wwan_led.c] [ 156s] [COMPILING libboard/qmod/source/i2c.c] [ 156s] [COMPILING libboard/qmod/source/board_qmod.c] [ 156s] [COMPILING apps/dfu/main.c] [ 157s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 157s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 157s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 157s] Memory region Used Size Region Size %age Used [ 157s] rom: 16588 B16 KB101.25% [ 157s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 157s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 204 bytes [ 157s] collect2: error: ld returned 1 exit status [ 157s] % [ 157s] make[2]: *** [Makefile:234: flash] Error 1 [ 157s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 157s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 157s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 157s] dh_auto_build: error: make -j1 returned exit code 2 [ 157s] make: *** [debian/rules:16: build] Error 25 [ 157s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 157s] ### VM INTERACTION START ### [ 160s] [ 149.532128] sysrq: Power Off [ 160s] [ 149.539568] reboot: Power down [ 160s] ### VM INTERACTION END ### [ 160s] [ 160s] lamb16 failed "build simtrace2_0.7.0.69.aadd.dsc" at Tue Dec 1 04:29:36 UTC 2020. [ 160s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-smlc in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-smlc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-smlc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-smlc Last lines of build log: [ 138s] [438/496] installing python3-3.9.0-3 [ 138s] Processing triggers for man-db (2.9.3-2) ... [ 139s] [439/496] installing texlive-plain-generic-2020.20201129-1 [ 142s] Processing triggers for tex-common (6.15) ... [ 142s] Running mktexlsr. This may take some time... done. [ 142s] [440/496] installing libosmo-netif-dev-1.0.0.8.bd77 [ 142s] [441/496] installing texlive-latex-base-2020.20201129-2 [ 142s] Processing triggers for man-db (2.9.3-2) ... [ 142s] Processing triggers for tex-common (6.15) ... [ 143s] Running mktexlsr. This may take some time... done. [ 143s] Running updmap-sys. This may take some time... done. [ 143s] Running mktexlsr /var/lib/texmf ... done. [ 143s] Building format(s) --all. [ 149s]This may take some time... [ 149s] fmtutil failed. Output has been stored in [ 149s] /tmp/fmtutil.UfCh5zwa [ 149s] Please include this file if you report a bug. [ 149s] dpkg: error processing package tex-common (--install): [ 149s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 149s] Errors were encountered while processing: [ 149s] tex-common [ 149s] exit ... [ 149s] ### VM INTERACTION START ### [ 152s] [ 136.949253] sysrq: Power Off [ 152s] [ 136.957339] reboot: Power down [ 152s] ### VM INTERACTION END ### [ 152s] [ 152s] sheep84 failed "build osmo-smlc_0.1.0.5.5dad.dsc" at Tue Dec 1 04:25:24 UTC 2020. [ 152s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-bsc in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 105s] [449/507] installing python3-3.9.0-3 [ 106s] Processing triggers for man-db (2.9.3-2) ... [ 106s] [450/507] installing texlive-plain-generic-2020.20201129-1 [ 108s] Processing triggers for tex-common (6.15) ... [ 108s] Running mktexlsr. This may take some time... done. [ 108s] [451/507] installing libosmo-netif-dev-1.0.0.8.bd77 [ 108s] [452/507] installing texlive-latex-base-2020.20201129-2 [ 109s] Processing triggers for man-db (2.9.3-2) ... [ 109s] Processing triggers for tex-common (6.15) ... [ 109s] Running mktexlsr. This may take some time... done. [ 109s] Running updmap-sys. This may take some time... done. [ 109s] Running mktexlsr /var/lib/texmf ... done. [ 110s] Building format(s) --all. [ 114s]This may take some time... [ 114s] fmtutil failed. Output has been stored in [ 114s] /tmp/fmtutil.o3JVzCCt [ 114s] Please include this file if you report a bug. [ 114s] dpkg: error processing package tex-common (--install): [ 114s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 114s] Errors were encountered while processing: [ 114s] tex-common [ 114s] exit ... [ 114s] ### VM INTERACTION START ### [ 117s] [ 105.700740] sysrq: Power Off [ 117s] [ 105.701974] reboot: Power down [ 117s] ### VM INTERACTION END ### [ 117s] [ 117s] build70 failed "build osmo-bsc_1.6.0.413.c93b.dsc" at Tue Dec 1 04:24:50 UTC 2020. [ 117s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-uecups in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-uecups/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-uecups failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-uecups Last lines of build log: [ 174s] [442/499] installing python3-3.9.0-3 [ 174s] Processing triggers for man-db (2.9.3-2) ... [ 174s] [443/499] installing texlive-plain-generic-2020.20201129-1 [ 178s] Processing triggers for tex-common (6.15) ... [ 178s] Running mktexlsr. This may take some time... done. [ 178s] [444/499] installing libosmo-netif-dev-1.0.0.8.bd77 [ 178s] [445/499] installing texlive-latex-base-2020.20201129-2 [ 179s] Processing triggers for man-db (2.9.3-2) ... [ 179s] Processing triggers for tex-common (6.15) ... [ 179s] Running mktexlsr. This may take some time... done. [ 180s] Running updmap-sys. This may take some time... done. [ 180s] Running mktexlsr /var/lib/texmf ... done. [ 180s] Building format(s) --all. [ 187s]This may take some time... [ 187s] fmtutil failed. Output has been stored in [ 187s] /tmp/fmtutil.GOIDfsUh [ 187s] Please include this file if you report a bug. [ 187s] dpkg: error processing package tex-common (--install): [ 187s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 187s] Errors were encountered while processing: [ 187s] tex-common [ 187s] exit ... [ 187s] ### VM INTERACTION START ### [ 190s] [ 169.181599] sysrq: Power Off [ 190s] [ 169.184615] reboot: Power down [ 190s] ### VM INTERACTION END ### [ 190s] [ 190s] old-atreju2 failed "build osmo-uecups_0.1.3.1.8362.dsc" at Tue Dec 1 04:19:51 UTC 2020. [ 190s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 175s] Processing triggers for libc-bin (2.31-4) ... [ 175s] [575/656] installing python3-3.9.0-3 [ 175s] Processing triggers for man-db (2.9.3-2) ... [ 175s] [576/656] installing texlive-plain-generic-2020.20201129-1 [ 178s] Processing triggers for tex-common (6.15) ... [ 178s] Running mktexlsr. This may take some time... done. [ 178s] [577/656] installing texlive-latex-base-2020.20201129-2 [ 178s] Processing triggers for man-db (2.9.3-2) ... [ 178s] Processing triggers for tex-common (6.15) ... [ 179s] Running mktexlsr. This may take some time... done. [ 179s] Running updmap-sys. This may take some time... done. [ 179s] Running mktexlsr /var/lib/texmf ... done. [ 179s] Building format(s) --all. [ 184s]This may take some time... [ 184s] fmtutil failed. Output has been stored in [ 184s] /tmp/fmtutil.ZygzPj2a [ 184s] Please include this file if you report a bug. [ 184s] dpkg: error processing package tex-common (--install): [ 184s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 184s] Errors were encountered while processing: [ 184s] tex-common [ 184s] exit ... [ 184s] ### VM INTERACTION START ### [ 187s] [ 164.451151] sysrq: Power Off [ 187s] [ 164.453522] reboot: Power down [ 187s] ### VM INTERACTION END ### [ 187s] [ 187s] hci-cnode1-m0 failed "build osmo-trx_1.2.0.114.57db.dsc" at Tue Dec 1 04:09:40 UTC 2020. [ 187s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sip-connector in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sip-connector/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-sip-connector failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sip-connector Last lines of build log: [ 234s] Running mktexlsr /var/lib/texmf ... done. [ 234s] [454/515] installing python3-3.9.0-3 [ 234s] Processing triggers for man-db (2.9.3-2) ... [ 235s] [455/515] installing texlive-plain-generic-2020.20201129-1 [ 239s] Processing triggers for tex-common (6.15) ... [ 239s] Running mktexlsr. This may take some time... done. [ 239s] [456/515] installing texlive-latex-base-2020.20201129-2 [ 240s] Processing triggers for man-db (2.9.3-2) ... [ 241s] Processing triggers for tex-common (6.15) ... [ 241s] Running mktexlsr. This may take some time... done. [ 242s] Running updmap-sys. This may take some time... done. [ 242s] Running mktexlsr /var/lib/texmf ... done. [ 242s] Building format(s) --all. [ 250s]This may take some time... [ 250s] fmtutil failed. Output has been stored in [ 250s] /tmp/fmtutil.fg5n9hAY [ 250s] Please include this file if you report a bug. [ 251s] dpkg: error processing package tex-common (--install): [ 251s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 251s] Errors were encountered while processing: [ 251s] tex-common [ 251s] exit ... [ 251s] ### VM INTERACTION START ### [ 254s] [ 232.692789] sysrq: Power Off [ 254s] [ 232.704390] reboot: Power down [ 254s] ### VM INTERACTION END ### [ 254s] [ 254s] lamb28 failed "build osmo-sip-connector_1.4.1.6.05ee.dsc" at Tue Dec 1 04:04:24 UTC 2020. [ 254s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sgsn in Debian_8.0/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_8.0/x86_64 Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 232s] make[4]: Entering directory '/usr/src/packages/BUILD/src/gbproxy' [ 232s] CC gb_proxy.o [ 232s] gb_proxy.c: In function 'gbprox_relay2nse': [ 232s] gb_proxy.c:846:17: error: 'struct ' has no member named 'link_selector' [ 232s]nsp.u.unitdata.link_selector = tlli; [ 232s] ^ [ 232s] Makefile:482: recipe for target 'gb_proxy.o' failed [ 232s] make[4]: *** [gb_proxy.o] Error 1 [ 232s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gbproxy' [ 232s] Makefile:383: recipe for target 'all-recursive' failed [ 232s] make[3]: *** [all-recursive] Error 1 [ 232s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 232s] Makefile:449: recipe for target 'all-recursive' failed [ 232s] make[2]: *** [all-recursive] Error 1 [ 232s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 232s] Makefile:380: recipe for target 'all' failed [ 232s] make[1]: *** [all] Error 2 [ 232s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 232s] dh_auto_build: make -j1 returned exit code 2 [ 232s] debian/rules:45: recipe for target 'build' failed [ 232s] make: *** [build] Error 2 [ 232s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 232s] ### VM INTERACTION START ### [ 233s] Powering off. [ 233s] [ 217.443598] reboot: Power down [ 233s] ### VM INTERACTION END ### [ 233s] [ 233s] lamb03 failed "build osmo-sgsn_1.6.0.64.9e58.dsc" at Tue Dec 1 04:03:21 UTC 2020. [ 233s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 131s] Running mktexlsr /var/lib/texmf ... done. [ 131s] [434/490] installing python3-3.9.0-3 [ 131s] Processing triggers for man-db (2.9.3-2) ... [ 131s] [435/490] installing texlive-plain-generic-2020.20201129-1 [ 134s] Processing triggers for tex-common (6.15) ... [ 134s] Running mktexlsr. This may take some time... done. [ 134s] [436/490] installing texlive-latex-base-2020.20201129-2 [ 135s] Processing triggers for man-db (2.9.3-2) ... [ 135s] Processing triggers for tex-common (6.15) ... [ 135s] Running mktexlsr. This may take some time... done. [ 136s] Running updmap-sys. This may take some time... done. [ 136s] Running mktexlsr /var/lib/texmf ... done. [ 136s] Building format(s) --all. [ 141s]This may take some time... [ 141s] fmtutil failed. Output has been stored in [ 141s] /tmp/fmtutil.lfzIxjec [ 141s] Please include this file if you report a bug. [ 141s] dpkg: error processing package tex-common (--install): [ 141s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 141s] Errors were encountered while processing: [ 141s] tex-common [ 141s] exit ... [ 141s] ### VM INTERACTION START ### [ 144s] [ 130.387967] sysrq: Power Off [ 144s] [ 130.396194] reboot: Power down [ 144s] ### VM INTERACTION END ### [ 144s] [ 144s] sheep87 failed "build osmo-pcu_0.8.0.280.58cd.dsc" at Tue Dec 1 03:59:41 UTC 2020. [ 144s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-remsim in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 180s] Running mktexlsr /var/lib/texmf ... done. [ 180s] [470/528] installing python3-3.9.0-3 [ 180s] Processing triggers for man-db (2.9.3-2) ... [ 180s] [471/528] installing texlive-plain-generic-2020.20201129-1 [ 183s] Processing triggers for tex-common (6.15) ... [ 184s] Running mktexlsr. This may take some time... done. [ 184s] [472/528] installing texlive-latex-base-2020.20201129-2 [ 184s] Processing triggers for man-db (2.9.3-2) ... [ 184s] Processing triggers for tex-common (6.15) ... [ 184s] Running mktexlsr. This may take some time... done. [ 185s] Running updmap-sys. This may take some time... done. [ 185s] Running mktexlsr /var/lib/texmf ... done. [ 185s] Building format(s) --all. [ 192s]This may take some time... [ 192s] fmtutil failed. Output has been stored in [ 192s] /tmp/fmtutil.LQU9jcmJ [ 192s] Please include this file if you report a bug. [ 193s] dpkg: error processing package tex-common (--install): [ 193s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 193s] Errors were encountered while processing: [ 193s] tex-common [ 193s] exit ... [ 193s] ### VM INTERACTION START ### [ 196s] [ 174.682958] sysrq: Power Off [ 196s] [ 174.686043] reboot: Power down [ 196s] ### VM INTERACTION END ### [ 196s] [ 196s] old-atreju3 failed "build osmo-remsim_0.2.2.103.dc34.dsc" at Tue Dec 1 03:56:51 UTC 2020. [ 196s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.10/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 113s] [COMPILING apps/dfu/main.c] [ 113s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 113s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 113s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 113s] Memory region Used Size Region Size %age Used [ 113s] rom: 16580 B16 KB101.20% [ 113s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 113s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 113s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 113s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 113s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 113s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 113s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 196 bytes [ 113s] collect2: error: ld returned 1 exit status [ 113s] % [ 113s] make[2]: *** [Makefile:234: flash] Error 1 [ 113s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 113s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 113s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 113s] dh_auto_build: error: make -j1 returned exit code 2 [ 113s] make: *** [debian/rules:16: build] Error 25 [ 113s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 113s] ### VM INTERACTION START ### [ 116s] [ 104.832597] sysrq: Power Off [ 116s] [ 104.835770] reboot: Power down [ 116s] ### VM INTERACTION END ### [ 116s] [ 116s] sheep85 failed "build simtrace2_0.7.0.69.aadd.dsc" at Tue Dec 1 03:56:19 UTC 2020. [ 116s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-e1d in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-e1d/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-e1d failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-e1d Last lines of build log: [ 112s] Running mktexlsr /var/lib/texmf ... done. [ 112s] [434/490] installing python3-3.9.0-3 [ 112s] Processing triggers for man-db (2.9.3-2) ... [ 112s] [435/490] installing texlive-plain-generic-2020.20201129-1 [ 114s] Processing triggers for tex-common (6.15) ... [ 114s] Running mktexlsr. This may take some time... done. [ 114s] [436/490] installing texlive-latex-base-2020.20201129-2 [ 115s] Processing triggers for man-db (2.9.3-2) ... [ 115s] Processing triggers for tex-common (6.15) ... [ 115s] Running mktexlsr. This may take some time... done. [ 116s] Running updmap-sys. This may take some time... done. [ 116s] Running mktexlsr /var/lib/texmf ... done. [ 116s] Building format(s) --all. [ 120s]This may take some time... [ 120s] fmtutil failed. Output has been stored in [ 120s] /tmp/fmtutil.E0vr9b5H [ 120s] Please include this file if you report a bug. [ 120s] dpkg: error processing package tex-common (--install): [ 120s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 120s] Errors were encountered while processing: [ 120s] tex-common [ 121s] exit ... [ 121s] ### VM INTERACTION START ### [ 124s] [ 114.408950] sysrq: Power Off [ 124s] [ 114.412724] reboot: Power down [ 124s] ### VM INTERACTION END ### [ 124s] [ 124s] goat11 failed "build osmo-e1d_0.1.1.20.e542.dsc" at Tue Dec 1 03:48:15 UTC 2020. [ 124s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-bts in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 247s] Running mktexlsr /var/lib/texmf ... done. [ 247s] [445/501] installing python3-3.9.0-3 [ 248s] Processing triggers for man-db (2.9.3-2) ... [ 248s] [446/501] installing texlive-plain-generic-2020.20201129-1 [ 252s] Processing triggers for tex-common (6.15) ... [ 252s] Running mktexlsr. This may take some time... done. [ 252s] [447/501] installing texlive-latex-base-2020.20201129-2 [ 252s] Processing triggers for man-db (2.9.3-2) ... [ 253s] Processing triggers for tex-common (6.15) ... [ 253s] Running mktexlsr. This may take some time... done. [ 254s] Running updmap-sys. This may take some time... done. [ 254s] Running mktexlsr /var/lib/texmf ... done. [ 254s] Building format(s) --all. [ 262s]This may take some time... [ 262s] fmtutil failed. Output has been stored in [ 262s] /tmp/fmtutil.LWv3hnUf [ 262s] Please include this file if you report a bug. [ 262s] dpkg: error processing package tex-common (--install): [ 262s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 262s] Errors were encountered while processing: [ 262s] tex-common [ 262s] exit ... [ 262s] ### VM INTERACTION START ### [ 265s] [ 244.912299] sysrq: Power Off [ 265s] [ 244.916848] reboot: Power down [ 265s] ### VM INTERACTION END ### [ 265s] [ 265s] lamb09 failed "build osmo-bts_1.2.0.343.def2.dsc" at Tue Dec 1 03:42:25 UTC 2020. [ 265s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in Debian_8.0/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_8.0/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 124s] make[2]: Nothing to be done for 'all'. [ 124s] make[2]: Leaving directory '/usr/src/packages/BUILD/include' [ 124s] Making all in src [ 124s] make[2]: Entering directory '/usr/src/packages/BUILD/src' [ 124s] CXX gprs_debug.lo [ 124s] CC csn1.lo [ 126s] CC gsm_rlcmac.lo [ 127s] CXX gprs_bssgp_pcu.lo [ 127s] gprs_bssgp_pcu.cpp: In function 'int ns_create_nsvc(gprs_rlcmac_bts*, uint16_t, const osmo_sockaddr*, const osmo_sockaddr*, const uint16_t*, uint16_t)': [ 127s] gprs_bssgp_pcu.cpp:983:13: error: 'GPRS_NS2_LL_UDP' was not declared in this scope [ 127s] GPRS_NS2_LL_UDP); [ 127s] ^ [ 127s] Makefile:790: recipe for target 'gprs_bssgp_pcu.lo' failed [ 127s] make[2]: *** [gprs_bssgp_pcu.lo] Error 1 [ 127s] make[2]: Leaving directory '/usr/src/packages/BUILD/src' [ 127s] Makefile:405: recipe for target 'all-recursive' failed [ 127s] make[1]: *** [all-recursive] Error 1 [ 127s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 127s] dh_auto_build: make -j1 returned exit code 2 [ 127s] debian/rules:12: recipe for target 'build' failed [ 127s] make: *** [build] Error 2 [ 127s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 127s] ### VM INTERACTION START ### [ 128s] Powering off. [ 128s] [ 119.775690] reboot: Power down [ 128s] ### VM INTERACTION END ### [ 128s] [ 128s] sheep85 failed "build osmo-pcu_0.8.0.280.58cd.dsc" at Tue Dec 1 03:18:05 UTC 2020. [ 128s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-ggsn in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-ggsn/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-ggsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-ggsn Last lines of build log: [ 143s] Running mktexlsr /var/lib/texmf ... done. [ 143s] [436/492] installing python3-3.9.0-3 [ 144s] Processing triggers for man-db (2.9.3-2) ... [ 144s] [437/492] installing texlive-plain-generic-2020.20200925-1 [ 147s] Processing triggers for tex-common (6.15) ... [ 147s] Running mktexlsr. This may take some time... done. [ 147s] [438/492] installing texlive-latex-base-2020.20201129-1 [ 147s] Processing triggers for man-db (2.9.3-2) ... [ 148s] Processing triggers for tex-common (6.15) ... [ 148s] Running mktexlsr. This may take some time... done. [ 148s] Running updmap-sys. This may take some time... done. [ 148s] Running mktexlsr /var/lib/texmf ... done. [ 148s] Building format(s) --all. [ 154s]This may take some time... [ 154s] fmtutil failed. Output has been stored in [ 154s] /tmp/fmtutil.5oxEeuzV [ 154s] Please include this file if you report a bug. [ 154s] dpkg: error processing package tex-common (--install): [ 154s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 154s] Errors were encountered while processing: [ 154s] tex-common [ 154s] exit ... [ 154s] ### VM INTERACTION START ### [ 157s] [ 140.829043] sysrq: Power Off [ 157s] [ 140.832520] reboot: Power down [ 157s] ### VM INTERACTION END ### [ 157s] [ 157s] hci-cnode1-m0 failed "build osmo-ggsn_1.6.0.13.1230.dsc" at Tue Dec 1 03:03:37 UTC 2020. [ 157s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-hlr in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-hlr failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [ 167s] [445/502] installing python3-3.9.0-3 [ 167s] Processing triggers for man-db (2.9.3-2) ... [ 168s] [446/502] installing texlive-plain-generic-2020.20200925-1 [ 171s] Processing triggers for tex-common (6.15) ... [ 171s] Running mktexlsr. This may take some time... done. [ 171s] [447/502] installing libosmo-netif-dev-1.0.0.8.bd77 [ 172s] [448/502] installing texlive-latex-base-2020.20201129-1 [ 172s] Processing triggers for man-db (2.9.3-2) ... [ 172s] Processing triggers for tex-common (6.15) ... [ 173s] Running mktexlsr. This may take some time... done. [ 173s] Running updmap-sys. This may take some time... done. [ 173s] Running mktexlsr /var/lib/texmf ... done. [ 173s] Building format(s) --all. [ 181s]This may take some time... [ 181s] fmtutil failed. Output has been stored in [ 181s] /tmp/fmtutil.dNwreZRN [ 181s] Please include this file if you report a bug. [ 182s] dpkg: error processing package tex-common (--install): [ 182s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 182s] Errors were encountered while processing: [ 182s] tex-common [ 182s] exit ... [ 182s] ### VM INTERACTION START ### [ 185s] [ 165.020548] sysrq: Power Off [ 185s] [ 165.024950] reboot: Power down [ 185s] ### VM INTERACTION END ### [ 185s] [ 185s] old-atreju4 failed "build osmo-hlr_1.2.0.67.dac8.dsc" at Tue Dec 1 03:00:47 UTC 2020. [ 185s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libosmo-sccp in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/Debian_Unstable/x86_64 Package network:osmocom:nightly/libosmo-sccp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 269s] [445/502] installing python3-3.9.0-3 [ 269s] Processing triggers for man-db (2.9.3-2) ... [ 270s] [446/502] installing texlive-plain-generic-2020.20200925-1 [ 274s] Processing triggers for tex-common (6.15) ... [ 274s] Running mktexlsr. This may take some time... done. [ 274s] [447/502] installing libosmo-netif-dev-1.0.0.8.bd77 [ 274s] [448/502] installing texlive-latex-base-2020.20201129-1 [ 275s] Processing triggers for man-db (2.9.3-2) ... [ 275s] Processing triggers for tex-common (6.15) ... [ 275s] Running mktexlsr. This may take some time... done. [ 276s] Running updmap-sys. This may take some time... done. [ 276s] Running mktexlsr /var/lib/texmf ... done. [ 276s] Building format(s) --all. [ 285s]This may take some time... [ 285s] fmtutil failed. Output has been stored in [ 285s] /tmp/fmtutil.wRcC3IYH [ 285s] Please include this file if you report a bug. [ 285s] dpkg: error processing package tex-common (--install): [ 285s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 285s] Errors were encountered while processing: [ 285s] tex-common [ 285s] exit ... [ 285s] ### VM INTERACTION START ### [ 288s] [ 223.772454] sysrq: Power Off [ 288s] [ 223.797700] reboot: Power down [ 288s] ### VM INTERACTION END ### [ 288s] [ 288s] cloud107 failed "build libosmo-sccp_1.3.0.25.48e2.dsc" at Tue Dec 1 02:51:17 UTC 2020. [ 288s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-mgw in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-mgw failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-mgw Last lines of build log: [ 228s] [442/499] installing python3-3.9.0-3 [ 228s] Processing triggers for man-db (2.9.3-2) ... [ 229s] [443/499] installing texlive-plain-generic-2020.20200925-1 [ 233s] Processing triggers for tex-common (6.15) ... [ 233s] Running mktexlsr. This may take some time... done. [ 233s] [444/499] installing libosmo-netif-dev-1.0.0.8.bd77 [ 234s] [445/499] installing texlive-latex-base-2020.20201129-1 [ 234s] Processing triggers for man-db (2.9.3-2) ... [ 235s] Processing triggers for tex-common (6.15) ... [ 235s] Running mktexlsr. This may take some time... done. [ 235s] Running updmap-sys. This may take some time... done. [ 235s] Running mktexlsr /var/lib/texmf ... done. [ 236s] Building format(s) --all. [ 243s]This may take some time... [ 243s] fmtutil failed. Output has been stored in [ 243s] /tmp/fmtutil.6g3FJuAg [ 243s] Please include this file if you report a bug. [ 243s] dpkg: error processing package tex-common (--install): [ 243s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 243s] Errors were encountered while processing: [ 243s] tex-common [ 243s] exit ... [ 243s] ### VM INTERACTION START ### [ 247s] [ 227.305894] sysrq: Power Off [ 247s] [ 227.310453] reboot: Power down [ 247s] ### VM INTERACTION END ### [ 247s] [ 247s] lamb54 failed "build osmo-mgw_1.7.0.130.3c29.dsc" at Tue Dec 1 02:50:27 UTC 2020. [ 247s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 217s] Running mktexlsr /var/lib/texmf ... done. [ 217s] [416/471] installing python3-3.9.0-3 [ 217s] Processing triggers for man-db (2.9.3-2) ... [ 217s] [417/471] installing texlive-plain-generic-2020.20200925-1 [ 221s] Processing triggers for tex-common (6.15) ... [ 222s] Running mktexlsr. This may take some time... done. [ 222s] [418/471] installing texlive-latex-base-2020.20201129-1 [ 222s] Processing triggers for man-db (2.9.3-2) ... [ 223s] Processing triggers for tex-common (6.15) ... [ 223s] Running mktexlsr. This may take some time... done. [ 223s] Running updmap-sys. This may take some time... done. [ 224s] Running mktexlsr /var/lib/texmf ... done. [ 224s] Building format(s) --all. [ 233s]This may take some time... [ 233s] fmtutil failed. Output has been stored in [ 233s] /tmp/fmtutil.UpJM2cin [ 233s] Please include this file if you report a bug. [ 233s] dpkg: error processing package tex-common (--install): [ 233s] installed tex-common package post-installation script subprocess returned error exit status 1 [ 233s] Errors were encountered while processing: [ 233s] tex-common [ 233s] exit ... [ 233s] ### VM INTERACTION START ### [ 236s] [ 191.857361] sysrq: Power Off [ 236s] [ 191.863392] reboot: Power down [ 236s] ### VM INTERACTION END ### [ 236s] [ 236s] cloud117 failed "build osmo-gsm-manuals-dev_0.3.0.37.c507.dsc" at Tue Dec 1 02:32:00 UTC 2020. [ 236s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sgsn in Debian_8.0/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_8.0/i586 Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 140s] make[4]: Entering directory '/usr/src/packages/BUILD/src/gbproxy' [ 140s] CC gb_proxy.o [ 140s] gb_proxy.c: In function 'gbprox_relay2nse': [ 140s] gb_proxy.c:846:17: error: 'struct ' has no member named 'link_selector' [ 140s]nsp.u.unitdata.link_selector = tlli; [ 140s] ^ [ 140s] Makefile:482: recipe for target 'gb_proxy.o' failed [ 140s] make[4]: *** [gb_proxy.o] Error 1 [ 140s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gbproxy' [ 140s] Makefile:383: recipe for target 'all-recursive' failed [ 140s] make[3]: *** [all-recursive] Error 1 [ 140s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 140s] Makefile:449: recipe for target 'all-recursive' failed [ 140s] make[2]: *** [all-recursive] Error 1 [ 140s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 140s] Makefile:380: recipe for target 'all' failed [ 140s] make[1]: *** [all] Error 2 [ 140s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 140s] dh_auto_build: make -j1 returned exit code 2 [ 140s] debian/rules:45: recipe for target 'build' failed [ 140s] make: *** [build] Error 2 [ 140s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 140s] ### VM INTERACTION START ### [ 141s] Powering off. [ 141s] [ 134.385400] reboot: Power down [ 141s] ### VM INTERACTION END ### [ 141s] [ 141s] build83 failed "build osmo-sgsn_1.6.0.64.9e58.dsc" at Tue Dec 1 02:22:08 UTC 2020. [ 141s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in Debian_8.0/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_8.0/i586 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 154s] make[2]: Nothing to be done for 'all'. [ 154s] make[2]: Leaving directory '/usr/src/packages/BUILD/include' [ 154s] Making all in src [ 154s] make[2]: Entering directory '/usr/src/packages/BUILD/src' [ 154s] CXX gprs_debug.lo [ 155s] CC csn1.lo [ 158s] CC gsm_rlcmac.lo [ 159s] CXX gprs_bssgp_pcu.lo [ 159s] gprs_bssgp_pcu.cpp: In function 'int ns_create_nsvc(gprs_rlcmac_bts*, uint16_t, const osmo_sockaddr*, const osmo_sockaddr*, const uint16_t*, uint16_t)': [ 159s] gprs_bssgp_pcu.cpp:983:13: error: 'GPRS_NS2_LL_UDP' was not declared in this scope [ 159s] GPRS_NS2_LL_UDP); [ 159s] ^ [ 159s] Makefile:790: recipe for target 'gprs_bssgp_pcu.lo' failed [ 159s] make[2]: *** [gprs_bssgp_pcu.lo] Error 1 [ 159s] make[2]: Leaving directory '/usr/src/packages/BUILD/src' [ 159s] Makefile:405: recipe for target 'all-recursive' failed [ 159s] make[1]: *** [all-recursive] Error 1 [ 159s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 159s] dh_auto_build: make -j1 returned exit code 2 [ 159s] debian/rules:12: recipe for target 'build' failed [ 159s] make: *** [build] Error 2 [ 159s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 159s] ### VM INTERACTION START ### [ 160s] Powering off. [ 160s] [ 151.028803] reboot: Power down [ 160s] ### VM INTERACTION END ### [ 160s] [ 160s] hci-cnode1-m0 failed "build osmo-pcu_0.8.0.280.58cd.dsc" at Tue Dec 1 01:55:58 UTC 2020. [ 160s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libosmocore in Debian_8.0/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_8.0/x86_64
Package network:osmocom:nightly/libosmocore failed to build in Debian_8.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of build log:
[ 218s] ^
[ 218s] In file included from gprs_ns2_fr.c:45:0:
[ 218s] /usr/include/linux/if.h:252:8: error: redefinition of 'struct ifconf'
[ 218s] struct ifconf {
[ 218s] ^
[ 218s] In file included from gprs_ns2_fr.c:39:0:
[ 218s] /usr/include/net/if.h:176:8: note: originally defined here
[ 218s] struct ifconf
[ 218s] ^
[ 218s] Makefile:542: recipe for target 'gprs_ns2_fr.lo' failed
[ 218s] make[3]: *** [gprs_ns2_fr.lo] Error 1
[ 218s] make[3]: Leaving directory '/usr/src/packages/BUILD/src/gb'
[ 218s] Makefile:690: recipe for target 'all-recursive' failed
[ 218s] make[2]: *** [all-recursive] Error 1
[ 218s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[ 218s] Makefile:468: recipe for target 'all' failed
[ 218s] make[1]: *** [all] Error 2
[ 218s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[ 218s] dh_auto_build: make -j1 returned exit code 2
[ 218s] debian/rules:15: recipe for target 'build' failed
[ 218s] make: *** [build] Error 2
[ 218s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[ 218s] ### VM INTERACTION START ###
[ 219s] Powering off.
[ 219s] [ 200.234973] reboot: Power down
[ 219s] ### VM INTERACTION END ###
[ 219s]
[ 219s] old-atreju5 failed "build libosmocore_1.4.0.219.a24e7.dsc" at Tue Dec
1 01:40:57 UTC 2020.
[ 219s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libosmocore in Debian_8.0/i586
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_8.0/i586
Package network:osmocom:nightly/libosmocore failed to build in Debian_8.0/i586
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of build log:
[ 176s] ^
[ 176s] In file included from gprs_ns2_fr.c:45:0:
[ 176s] /usr/include/linux/if.h:252:8: error: redefinition of 'struct ifconf'
[ 176s] struct ifconf {
[ 176s] ^
[ 176s] In file included from gprs_ns2_fr.c:39:0:
[ 176s] /usr/include/net/if.h:176:8: note: originally defined here
[ 176s] struct ifconf
[ 176s] ^
[ 176s] Makefile:542: recipe for target 'gprs_ns2_fr.lo' failed
[ 176s] make[3]: *** [gprs_ns2_fr.lo] Error 1
[ 176s] make[3]: Leaving directory '/usr/src/packages/BUILD/src/gb'
[ 176s] Makefile:690: recipe for target 'all-recursive' failed
[ 176s] make[2]: *** [all-recursive] Error 1
[ 176s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[ 176s] Makefile:468: recipe for target 'all' failed
[ 176s] make[1]: *** [all] Error 2
[ 176s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[ 176s] dh_auto_build: make -j1 returned exit code 2
[ 176s] debian/rules:15: recipe for target 'build' failed
[ 176s] make: *** [build] Error 2
[ 176s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[ 176s] ### VM INTERACTION START ###
[ 177s] Powering off.
[ 177s] [ 169.762850] reboot: Power down
[ 177s] ### VM INTERACTION END ###
[ 177s]
[ 177s] lamb05 failed "build libosmocore_1.4.0.219.a24e7.dsc" at Tue Dec 1
01:33:04 UTC 2020.
[ 177s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Change in docker-playground[master]: Add ttcn3-gbproxy-test-fr for FR related testing
laforge has submitted this change. (
https://gerrit.osmocom.org/c/docker-playground/+/21412 )
Change subject: Add ttcn3-gbproxy-test-fr for FR related testing
..
Add ttcn3-gbproxy-test-fr for FR related testing
Testing FR support in osmo-gbproxy is a bit more complicated
as it involves the "hdlc" net-devices privded by the hdlc_fr.ko
kernel module.
So we need to
* run on a host with actual hdlc net-devices (e.g. dahdi_dyamic_loc)
* move those net-devices into the containers after starting them
* wait for the net-devices to appear in the containers before starting
either gbproxy or the test suite
Change-Id: Id4b52877db53cb6e59f6d0d3f754aaae633949e8
---
A ttcn3-gbproxy-test-fr/GBProxy_Tests.cfg
A ttcn3-gbproxy-test-fr/jenkins.sh
A ttcn3-gbproxy-test-fr/netdev-to-docker.sh
A ttcn3-gbproxy-test-fr/osmo-gbproxy.cfg
M ttcn3-gbproxy-test/Dockerfile
A ttcn3-gbproxy-test/docker-entrypoint.sh
A ttcn3-gbproxy-test/pipework
7 files changed, 776 insertions(+), 5 deletions(-)
Approvals:
laforge: Looks good to me, approved; Verified
diff --git a/ttcn3-gbproxy-test-fr/GBProxy_Tests.cfg
b/ttcn3-gbproxy-test-fr/GBProxy_Tests.cfg
new file mode 100644
index 000..adab61a
--- /dev/null
+++ b/ttcn3-gbproxy-test-fr/GBProxy_Tests.cfg
@@ -0,0 +1,100 @@
+[ORDERED_INCLUDE]
+# Common configuration, shared between test suites
+"/osmo-ttcn3-hacks/Common.cfg"
+# testsuite specific configuration, not expected to change
+"/osmo-ttcn3-hacks/gbproxy/GBProxy_Tests.default"
+
+# Local configuration below
+
+[LOGGING]
+
+[TESTPORT_PARAMETERS]
+*.GBPVTY.CTRL_HOSTNAME := "172.18.25.10"
+
+[MODULE_PARAMETERS]
+GBProxy_Tests.mp_nsconfig_sgsn := {
+ {
+ nsvc := {
+ {
+ provider := {
+ ip := {
+ address_family := AF_INET,
+ local_ip := "172.18.25.103",
+ local_udp_port := 23000,
+ remote_ip := "172.18.25.10"
+ }
+ }
+ }
+ }
+ }
+}
+GBProxy_Tests.mp_nsconfig_pcu := {
+ {
+ nsei := 1,
+ role_sgsn := false,
+ handle_sns := false,
+ nsvc := {
+ {
+ provider := {
+ fr := {
+ netdev := "hdlc1",
+ dlci := 16
+ }
+ },
+ nsvci := 1
+ }, {
+ provider := {
+ fr := {
+ netdev := "hdlc2",
+ dlci := 17
+ }
+ },
+ nsvci := 2
+ }, {
+ provider := {
+ fr := {
+ netdev := "hdlc3",
+ dlci := 18
+ }
+ },
+ nsvci := 3
+ }, {
+ provider := {
+ fr := {
+ netdev := "hdlc4",
+ dlci := 19
+ }
+ },
+ nsvci := 4
+ }
+ }
+ }
+}
+
+GBProxy_Tests.mp_gbconfigs := {
+ {
+ nsei := 1,
+ sgsn_role := false,
+ bvc := {
+ {
+ bvci := 196,
+ cell_id := {
+ ra_id := {
+ lai := {
+ mcc_mnc := '262F42'H,
+ lac := 13135
+ },
+ rac := 0
+ },
+ cell_id := 20960
+ },
+ depth := BSSGP_DECODE_DEPTH_BSSGP
+ }
+ }
+ }
+};
+
+[MAIN_CONTROLLER]
+
+[EXECUTE]
+GBProxy_Tests.control
diff --git a/ttcn3-gbproxy-test-fr/jenkins.sh
Change in docker-playground[master]: Add ttcn3-gbproxy-test-fr for FR related testing
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/21412 ) Change subject: Add ttcn3-gbproxy-test-fr for FR related testing .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/21412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id4b52877db53cb6e59f6d0d3f754aaae633949e8 Gerrit-Change-Number: 21412 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 30 Nov 2020 20:47:23 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: osmo-gbproxy-master (derived from osmo-sgsn-master)
laforge has submitted this change. (
https://gerrit.osmocom.org/c/docker-playground/+/21411 )
Change subject: osmo-gbproxy-master (derived from osmo-sgsn-master)
..
osmo-gbproxy-master (derived from osmo-sgsn-master)
Using a separate container will allow us to do gbproxy specific things
like waiting for physical net-devices to show up in the docker netns
before actually starting the osmo-gbproxy executable
Change-Id: I5e6351055ac9430f13e43291cf2a9d52683fe6bf
---
A osmo-gbproxy-master/Dockerfile
A osmo-gbproxy-master/Makefile
A osmo-gbproxy-master/docker-entrypoint.sh
A osmo-gbproxy-master/osmo-gbproxy.cfg
A osmo-gbproxy-master/pipework
5 files changed, 542 insertions(+), 0 deletions(-)
Approvals:
laforge: Looks good to me, approved; Verified
diff --git a/osmo-gbproxy-master/Dockerfile b/osmo-gbproxy-master/Dockerfile
new file mode 100644
index 000..8661ec9
--- /dev/null
+++ b/osmo-gbproxy-master/Dockerfile
@@ -0,0 +1,15 @@
+ARGUSER
+ARGDISTRO
+FROM $USER/osmo-sgsn-master
+
+COPY osmo-gbproxy.cfg/data/osmo-gbproxy.cfg
+
+# work-around for stupid docker not being able to properly deal with host
netdevices or start
+# containers in pre-existing netns
+COPY pipework/usr/bin/pipework
+COPY docker-entrypoint.sh/docker-entrypoint.sh
+
+WORKDIR/data
+CMD["/docker-entrypoint.sh"]
+
+EXPOSE 23000/udp 4246/tcp 4263/tcp
diff --git a/osmo-gbproxy-master/Makefile b/osmo-gbproxy-master/Makefile
new file mode 100644
index 000..1614f9a
--- /dev/null
+++ b/osmo-gbproxy-master/Makefile
@@ -0,0 +1,3 @@
+RUN_ARGS?=--rm --network sigtran --ip 172.18.0.21 -v gbproxy-vol:/data
+
+include ../make/Makefile
diff --git a/osmo-gbproxy-master/docker-entrypoint.sh
b/osmo-gbproxy-master/docker-entrypoint.sh
new file mode 100755
index 000..72c4e8c
--- /dev/null
+++ b/osmo-gbproxy-master/docker-entrypoint.sh
@@ -0,0 +1,9 @@
+#!/bin/bash
+set -e
+set -x
+
+if [[ -n ${WAIT_FOR_NETDEV:-} ]]; then
+ /usr/bin/pipework --wait -i ${WAIT_FOR_NETDEV}
+fi
+
+/usr/local/bin/osmo-gbproxy -c /data/osmo-gbproxy.cfg >/data/osmo-gbproxy.log
2>&1
diff --git a/osmo-gbproxy-master/osmo-gbproxy.cfg
b/osmo-gbproxy-master/osmo-gbproxy.cfg
new file mode 100644
index 000..29f698f
--- /dev/null
+++ b/osmo-gbproxy-master/osmo-gbproxy.cfg
@@ -0,0 +1,26 @@
+!
+! Osmocom Gb Proxy (0.9.0.404-6463) configuration saved from vty
+!!
+!
+line vty
+ no login
+!
+gbproxy
+ sgsn nsei 101
+ns
+ nse 101 nsvci 101
+ nse 101 remote-role sgsn
+ nse 101 encapsulation udp
+ nse 101 remote-ip 192.168.100.239
+ nse 101 remote-port
+ timer tns-block 3
+ timer tns-block-retries 3
+ timer tns-reset 3
+ timer tns-reset-retries 3
+ timer tns-test 30
+ timer tns-alive 3
+ timer tns-alive-retries 10
+ encapsulation framerelay-gre enabled 0
+ encapsulation framerelay-gre local-ip 0.0.0.0
+ encapsulation udp local-ip 127.0.0.100
+ encapsulation udp local-port 23000
diff --git a/osmo-gbproxy-master/pipework b/osmo-gbproxy-master/pipework
new file mode 100755
index 000..97ce66b
--- /dev/null
+++ b/osmo-gbproxy-master/pipework
@@ -0,0 +1,489 @@
+#!/bin/sh
+# This code should (try to) follow Google's Shell Style Guide
+# (https://google.github.io/styleguide/shell.xml)
+set -e
+
+case "$1" in
+ --wait)
+WAIT=1
+;;
+ --direct-phys)
+DIRECT_PHYS=1
+shift
+;;
+esac
+
+IFNAME=$1
+
+# default value set further down if not set here
+CONTAINER_IFNAME=
+if [ "$2" = "-i" ]; then
+ CONTAINER_IFNAME=$3
+ shift 2
+fi
+
+if [ "$2" = "-l" ]; then
+ LOCAL_IFNAME=$3
+ shift 2
+fi
+
+#inet or inet6
+FAMILY_FLAG="-4"
+if [ "$2" = "-a" ]; then
+ FAMILY_FLAG="-$3"
+ shift 2
+fi
+
+GUESTNAME=$2
+IPADDR=$3
+MACADDR=$4
+
+case "$MACADDR" in
+ *@*)
+VLAN="${MACADDR#*@}"
+VLAN="${VLAN%%@*}"
+MACADDR="${MACADDR%%@*}"
+;;
+ *)
+VLAN=
+;;
+esac
+
+# did they ask to generate a custom MACADDR?
+# generate the unique string
+case "$MACADDR" in
+ U:*)
+macunique="${MACADDR#*:}"
+# now generate a 48-bit hash string from $macunique
+MACADDR=$(echo $macunique|md5sum|sed
's/^\(..\)\(..\)\(..\)\(..\)\(..\).*$/02:\1:\2:\3:\4:\5/')
+ ;;
+esac
+
+
+[ "$IPADDR" ] || [ "$WAIT" ] || {
+ echo "Syntax:"
+ echo "pipework [-i containerinterface] [-l
localinterfacename] [-a addressfamily]
/[@default_gateway] [macaddr][@vlan]"
+ echo "pipework [-i containerinterface] [-l
localinterfacename] dhcp [macaddr][@vlan]"
+ echo "pipework mac: [-i containerinterface] [-l
localinterfacename] [-a addressfamily]
/[@default_gateway] [macaddr][@vlan]"
+ echo "pipework mac: [-i containerinterface] [-l
localinterfacename] dhcp [macaddr][@vlan]"
+ echo "pipework route "
+ echo "pipework rule "
+ echo "pipework tc "
+ echo "pipework --wait [-i containerinterface]"
+ exit 1
+}
+
+# Succeed if the given utility is installed. Fail otherwise.
+# For explanations about `which` vs `type` vs `command`, see:
+#
Change in docker-playground[master]: osmo-gbproxy-master (derived from osmo-sgsn-master)
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/21411 ) Change subject: osmo-gbproxy-master (derived from osmo-sgsn-master) .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/21411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5e6351055ac9430f13e43291cf2a9d52683fe6bf Gerrit-Change-Number: 21411 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 30 Nov 2020 20:47:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Verify LLC UI dummy frames are not appended at end of rlcmac DL ...
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21419 )
Change subject: pcu: Verify LLC UI dummy frames are not appended at end of
rlcmac DL block
..
pcu: Verify LLC UI dummy frames are not appended at end of rlcmac DL block
LLC UI dummy frames are only to be sent alone in order to delay TBF
termination. Until recently (osmo-pcu.git
Ifae1a7b2b3dfad8df19585063088ba0df2749c8f), osmo-pcu was sending LLC UI
dummy frames instead of padding at RLCMAC layer, which made no sense.
Related: OS#4849
Change-Id: I7e0d9ed2475dbf989fbf932c8b83117ff5fb28fc
---
M pcu/GPRS_Components.ttcn
M pcu/PCU_Tests.ttcn
2 files changed, 81 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/19/21419/1
diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn
index 0850a3d..16036ad 100644
--- a/pcu/GPRS_Components.ttcn
+++ b/pcu/GPRS_Components.ttcn
@@ -1001,13 +1001,6 @@
f_shutdown(__BFILE__, __LINE__);
}
- /* Check next data blocks contain dummy frames */
- if (lengthof(data_block.blocks) > 1 and
substr(data_block.blocks[1].payload, 0, 3) != '43C001'O) {
- setverdict(fail, "Second data payload is not a dummy frame: ",
- data_block.blocks[1].payload);
- f_shutdown(__BFILE__, __LINE__);
- }
-
if (not match(data_block.cs, exp_cs)) {
setverdict(fail, "Failed to match ", data_block.cs, " vs exp ",
exp_cs);
f_shutdown(__BFILE__, __LINE__);
@@ -1036,13 +1029,6 @@
f_shutdown(__BFILE__, __LINE__);
}
- /* Check next data blocks contain dummy frames */
- if (lengthof(data_block.blocks) > 1 and
substr(data_block.blocks[1].payload, 0, 3) != '43C001'O) {
- setverdict(fail, "Second data payload is not a dummy frame: ",
- data_block.blocks[1].payload);
- f_shutdown(__BFILE__, __LINE__);
- }
-
if (not match(data_block.mcs, exp_cs)) {
setverdict(fail, "Failed to match ", data_block.mcs, " vs exp
", exp_cs);
f_shutdown(__BFILE__, __LINE__);
diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index 67a811d..d187011 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -2546,6 +2546,85 @@
f_shutdown(__BFILE__, __LINE__, final := true);
}
+private function f_tc_dl_data_no_llc_ui_dummy(template (omit)
MSRadioAccessCapabilityV_BSSGP ms_racap := omit) runs on RAW_PCU_Test_CT {
+ var AckNackDescription ack_nack_desc :=
valueof(t_AckNackDescription_init);
+ var octetstring data := f_rnd_octstring(6);
+ var RlcmacDlBlock dl_block;
+ var GprsMS ms;
+ var uint32_t fn;
+
+ /* Initialize NS/BSSGP side */
+ f_init_bssgp();
+ /* Initialize GPRS MS side */
+ f_init_gprs_ms();
+ ms := g_ms[0]; /* We only use first MS in this test */
+
+ /* Initialize the PCU interface abstraction */
+ f_init_raw(testcasename());
+
+ /* Establish BSSGP connection to the PCU */
+ f_bssgp_establish();
+ f_bssgp_client_llgmm_assign(TLLI_UNUSED, ms.tlli);
+
+ /* SGSN sends some DL data, PCU will page on CCCH (PCH) */
+ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data, ms_racap));
+ f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH);
+
+ /* Wait timer X2002 and DL block is available after CCCH IMM ASS */
+ f_sleep(X2002);
+
+ /* Expect the first (GPRS DL) block with bsn=0 and rrbp_valid=1 */
+ f_rx_rlcmac_dl_block_exp_data(dl_block, fn, data, 0);
+
+ if (ischosen(dl_block.data_egprs)) {
+ if (lengthof(dl_block.data_egprs.blocks) != 2) {
+ setverdict(fail, "DL EGPRS block has unexpected number
of LLC frames: ", dl_block.data_egprs);
+ f_shutdown(__BFILE__, __LINE__);
+ }
+ if (dl_block.data_egprs.blocks[1].hdr.length_ind != 127) {
+ setverdict(fail, "DL EGPRS block 2nd llc frame is not
padding!: ", dl_block.data_egprs);
+ f_shutdown(__BFILE__, __LINE__);
+ }
+ if (dl_block.data_egprs.blocks[1].hdr.length_ind != 127) {
+ setverdict(fail, "DL EGPRS block 2nd llc frame is not
padding!: ", dl_block.data_egprs);
+ f_shutdown(__BFILE__, __LINE__);
+ }
+ if (not match(dl_block.data_egprs.blocks[1].payload,
+ f_pad_oct(''O,
lengthof(dl_block.data_egprs.blocks[1].payload), '2B'O))) {
+ setverdict(fail, "DL EGPRS block 2nd llc frame is not
padding!: ", dl_block.data_egprs);
+ f_shutdown(__BFILE__, __LINE__);
+ }
+ } else if (lengthof(dl_block.data.blocks) > 1) {
+
Change in osmo-sgsn[master]: gbproxy: Separate function to move gbproxy_peer to different nse
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/21418 )
Change subject: gbproxy: Separate function to move gbproxy_peer to different nse
..
gbproxy: Separate function to move gbproxy_peer to different nse
Change-Id: I0a8b1e4b78384ea99d50109f050ca501b18ba5d9
Related: SYS#5226
---
M include/osmocom/sgsn/gb_proxy.h
M src/gbproxy/gb_proxy.c
M src/gbproxy/gb_proxy_peer.c
3 files changed, 9 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/include/osmocom/sgsn/gb_proxy.h b/include/osmocom/sgsn/gb_proxy.h
index 54d4548..9f91bd6 100644
--- a/include/osmocom/sgsn/gb_proxy.h
+++ b/include/osmocom/sgsn/gb_proxy.h
@@ -344,6 +344,7 @@
struct gbproxy_config *cfg, struct tlv_parsed *tp);
struct gbproxy_peer *gbproxy_peer_alloc(struct gbproxy_nse *nse, uint16_t
bvci);
void gbproxy_peer_free(struct gbproxy_peer *peer);
+void gbproxy_peer_move(struct gbproxy_peer *peer, struct gbproxy_nse *nse);
int gbproxy_cleanup_peers(struct gbproxy_config *cfg, uint16_t nsei, uint16_t
bvci);
/* NSE handling */
diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c
index db7f55b..bd58617 100644
--- a/src/gbproxy/gb_proxy.c
+++ b/src/gbproxy/gb_proxy.c
@@ -1114,9 +1114,7 @@
LOGP(DGPRS, LOGL_NOTICE, "Peer for BVCI=%u
moved from NSEI=%u to NSEI=%u\n", bvci, nse_old->nsei, nsei);
/* Move peer to different NSE */
- llist_del(_peer->list);
- llist_add(_peer->list,
_new->bts_peers);
- from_peer->nse = nse_new;
+ gbproxy_peer_move(from_peer, nse_new);
}
if (TLVP_PRESENT(, BSSGP_IE_CELL_ID)) {
diff --git a/src/gbproxy/gb_proxy_peer.c b/src/gbproxy/gb_proxy_peer.c
index 920547c..62c4d94 100644
--- a/src/gbproxy/gb_proxy_peer.c
+++ b/src/gbproxy/gb_proxy_peer.c
@@ -253,6 +253,13 @@
talloc_free(peer);
}
+void gbproxy_peer_move(struct gbproxy_peer *peer, struct gbproxy_nse *nse)
+{
+ llist_del(>list);
+ llist_add(>list, >bts_peers);
+ peer->nse = nse;
+}
+
int gbproxy_cleanup_peers(struct gbproxy_config *cfg, uint16_t nsei, uint16_t
bvci)
{
int counter = 0;
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21418
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I0a8b1e4b78384ea99d50109f050ca501b18ba5d9
Gerrit-Change-Number: 21418
Gerrit-PatchSet: 2
Gerrit-Owner: daniel
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-sgsn[master]: gbproxy: Only send paging to each matching NSE once
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/21417 )
Change subject: gbproxy: Only send paging to each matching NSE once
..
gbproxy: Only send paging to each matching NSE once
Fixes: SYS#5226
Change-Id: Ia33e7816b354266b9d2659ef96b798db60c134f3
---
M src/gbproxy/gb_proxy.c
1 file changed, 34 insertions(+), 13 deletions(-)
Approvals:
pespin: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c
index 1ca4fc6..db7f55b 100644
--- a/src/gbproxy/gb_proxy.c
+++ b/src/gbproxy/gb_proxy.c
@@ -813,11 +813,10 @@
return rc;
}
-/* feed a message down the NS-VC associated with the specified peer */
-static int gbprox_relay2peer(struct msgb *old_msg, struct gbproxy_peer *peer,
+/* feed a message down the NSE */
+static int gbprox_relay2nse(struct msgb *old_msg, struct gbproxy_nse *nse,
uint16_t ns_bvci)
{
- struct gbproxy_nse *nse = peer->nse;
OSMO_ASSERT(nse);
OSMO_ASSERT(nse->cfg);
@@ -825,7 +824,7 @@
* be free()d safely when we return from gbprox_rcvmsg() */
struct gprs_ns2_inst *nsi = nse->cfg->nsi;
struct osmo_gprs_ns2_prim nsp = {};
- struct msgb *msg = bssgp_msgb_copy(old_msg, "msgb_relay2peer");
+ struct msgb *msg = bssgp_msgb_copy(old_msg, "msgb_relay2nse");
uint32_t tlli;
int rc;
@@ -849,6 +848,22 @@
osmo_prim_init(, SAP_NS, PRIM_NS_UNIT_DATA,
PRIM_OP_REQUEST, msg);
rc = gprs_ns2_recv_prim(nsi, );
+ /* FIXME: We need a counter group for gbproxy_nse */
+ //if (rc < 0)
+ // rate_ctr_inc(>ctrg->ctr[GBPROX_PEER_CTR_TX_ERR]);
+
+ return rc;
+}
+
+/* feed a message down the NS-VC associated with the specified peer */
+static int gbprox_relay2peer(struct msgb *old_msg, struct gbproxy_peer *peer,
+uint16_t ns_bvci)
+{
+ int rc;
+ struct gbproxy_nse *nse = peer->nse;
+ OSMO_ASSERT(nse);
+
+ rc = gbprox_relay2nse(old_msg, nse, ns_bvci);
if (rc < 0)
rate_ctr_inc(>ctrg->ctr[GBPROX_PEER_CTR_TX_ERR]);
@@ -1151,7 +1166,7 @@
{
struct gbproxy_nse *nse;
struct gbproxy_peer *peer;
- unsigned int n_peers = 0;
+ unsigned int n_nses = 0;
int errctr = GBPROX_GLOB_CTR_PROTO_ERR_SGSN;
/* FIXME: Handle paging logic to only page each matching NSE */
@@ -1176,9 +1191,11 @@
llist_for_each_entry(nse, >nse_peers, list) {
llist_for_each_entry(peer, >bts_peers, list) {
if (!memcmp(peer->ra, TLVP_VAL(tp,
BSSGP_IE_ROUTEING_AREA), 6)) {
- LOGPC(DGPRS, LOGL_INFO, "routing by RAI
to peer BVCI=%u\n", peer->bvci);
- gbprox_relay2peer(msg, peer, ns_bvci);
- n_peers++;
+ LOGPC(DGPRS, LOGL_INFO, "routing by RAI
to peer NSEI=%u\n", peer->bvci);
+ gbprox_relay2nse(msg, nse, ns_bvci);
+ n_nses++;
+ /* Only send it once to each NSE */
+ break;
}
}
}
@@ -1189,8 +1206,10 @@
llist_for_each_entry(peer, >bts_peers, list) {
if (!memcmp(peer->ra, TLVP_VAL(tp,
BSSGP_IE_LOCATION_AREA), 5)) {
LOGPC(DGPRS, LOGL_INFO, "routing by LAI
to peer BVCI=%u\n", peer->bvci);
- gbprox_relay2peer(msg, peer, ns_bvci);
- n_peers++;
+ gbprox_relay2nse(msg, nse, ns_bvci);
+ n_nses++;
+ /* Only send it once to each NSE */
+ break;
}
}
}
@@ -1199,8 +1218,10 @@
llist_for_each_entry(nse, >nse_peers, list) {
llist_for_each_entry(peer, >bts_peers, list) {
LOGPC(DGPRS, LOGL_INFO, "broadcasting to peer
BVCI=%u\n", peer->bvci);
- gbprox_relay2peer(msg, peer, ns_bvci);
- n_peers++;
+ gbprox_relay2nse(msg, nse, ns_bvci);
+ n_nses++;
+ /* Only send it once to each NSE */
+ break;
}
}
} else {
@@ -1210,7 +1231,7 @@
Change in osmo-sgsn[master]: gbproxy: Ensure BVC0 is reset before handling PtP BVCs
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/21410 )
Change subject: gbproxy: Ensure BVC0 is reset before handling PtP BVCs
..
gbproxy: Ensure BVC0 is reset before handling PtP BVCs
Change-Id: I9c67f973f7bca00e8eb22a024ef2282c007dd84b
Related: SYS#5226
---
M src/gbproxy/gb_proxy.c
M tests/gbproxy/gbproxy_test.c
M tests/gbproxy/gbproxy_test.ok
3 files changed, 125 insertions(+), 6 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c
index 736bd7a..1ca4fc6 100644
--- a/src/gbproxy/gb_proxy.c
+++ b/src/gbproxy/gb_proxy.c
@@ -1058,6 +1058,14 @@
LOGP(DGPRS, LOGL_INFO, "NSEI=%u Rx BVC RESET
(BVCI=%u)\n",
nsei, bvci);
if (bvci == 0) {
+ struct gbproxy_nse *nse;
+ /* Ensure the NSE peer is there and clear all
PtP BVCs */
+ nse = gbproxy_nse_by_nsei_or_new(cfg, nsei);
+ if (!nse)
+ LOGP(DGPRS, LOGL_ERROR, "Could not
allocate NSE for NSEI=%u\n", nsei);
+
+ gbproxy_cleanup_peers(cfg, nsei, 0);
+
/* FIXME: only do this if SGSN is alive! */
LOGP(DGPRS, LOGL_INFO, "NSEI=%u Tx fake "
"BVC RESET ACK of BVCI=0\n", nsei);
@@ -1066,10 +1074,11 @@
}
from_peer = gbproxy_peer_by_bvci(cfg, bvci);
if (!from_peer) {
- struct gbproxy_nse *nse =
gbproxy_nse_by_nsei_or_new(cfg, nsei);
+ struct gbproxy_nse *nse =
gbproxy_nse_by_nsei(cfg, nsei);
if (!nse) {
- LOGP(DGPRS, LOGL_ERROR, "Could not
allocate NSE for NSEI=%u\n", nsei);
- return
bssgp_tx_status(BSSGP_CAUSE_PROTO_ERR_UNSPEC, NULL, msg);
+ LOGP(DGPRS, LOGL_NOTICE, "Got PtP BVC
reset before signalling reset for "
+ "BVCI=%u NSEI=%u\n", bvci,
nsei);
+ return
bssgp_tx_status(BSSGP_CAUSE_PDU_INCOMP_STATE, NULL, msg);
}
/* if a PTP-BVC is reset, and we don't know that
* PTP-BVCI yet, we should allocate a new peer
*/
@@ -1081,10 +1090,11 @@
/* Could have moved to a different NSE */
if (!check_peer_nsei(from_peer, nsei)) {
struct gbproxy_nse *nse_old = from_peer->nse;
- struct gbproxy_nse *nse_new =
gbproxy_nse_by_nsei_or_new(cfg, nsei);
+ struct gbproxy_nse *nse_new =
gbproxy_nse_by_nsei(cfg, nsei);
if (!nse_new) {
- LOGP(DGPRS, LOGL_ERROR, "Could not
allocate NSE for NSEI=%u\n", nsei);
- return
bssgp_tx_status(BSSGP_CAUSE_PROTO_ERR_UNSPEC, NULL, msg);
+ LOGP(DGPRS, LOGL_NOTICE, "Got PtP BVC
reset before signalling reset for "
+ "BVCI=%u NSEI=%u\n", bvci,
nsei);
+ return
bssgp_tx_status(BSSGP_CAUSE_PDU_INCOMP_STATE, NULL, msg);
}
LOGP(DGPRS, LOGL_NOTICE, "Peer for BVCI=%u
moved from NSEI=%u to NSEI=%u\n", bvci, nse_old->nsei, nsei);
diff --git a/tests/gbproxy/gbproxy_test.c b/tests/gbproxy/gbproxy_test.c
index 06734b4..fec5914 100644
--- a/tests/gbproxy/gbproxy_test.c
+++ b/tests/gbproxy/gbproxy_test.c
@@ -930,6 +930,7 @@
"NSEI 0x%04x(%d)\n\n",
nsei, nsei);
send_ns_avail(nsi, nsei);
+ send_bssgp_reset(nsi, nsei, 0);
}
static void setup_bssgp(struct gprs_ns2_inst *nsi,
diff --git a/tests/gbproxy/gbproxy_test.ok b/tests/gbproxy/gbproxy_test.ok
index 14a2641..fbd5366 100644
--- a/tests/gbproxy/gbproxy_test.ok
+++ b/tests/gbproxy/gbproxy_test.ok
@@ -13,6 +13,15 @@
NS2 CALLBACK, prim 2, bvci 0x
+PROCESSING BVC_RESET from NSEI 4096
+22 04 82 00 00 07 81 08 08 88 11 22 33 40 50 60 10 00
+
+NS2 CALLBACK, prim 0, msg length 18, bvci 0x
+22 04 82 00 00 07 81 08 08 88 11 22 33 40 50 60 10 00
+
+Message for BSS (NSEI=4096 BVCI=0):
+23 04 82 00 00
+
Setup BSSGP: BVCI 0x1002(4098)
PROCESSING BVC_RESET from NSEI 4096
@@ -48,6 +57,15 @@
NS2 CALLBACK, prim 2, bvci 0x
+PROCESSING BVC_RESET from NSEI 8192
+22 04 82
Change in osmo-sgsn[master]: gbproxy: Remove test testing NSVCI change
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/21413 )
Change subject: gbproxy: Remove test testing NSVCI change
..
gbproxy: Remove test testing NSVCI change
This was overlooked in commit 82182d which already removed lots of
NS-specific code in gbproxy_test.c
>From that commit message:
"""
Since NS2 has a different abstraction we mock up the prim send/recv
functions and don't test NS like the old tests did.
"""
Change-Id: Ic1d7e646e633c9fa62812f5005ed10c0108a06f2
Related: SYS#5226
---
M tests/gbproxy/gbproxy_test.c
M tests/gbproxy/gbproxy_test.ok
2 files changed, 2 insertions(+), 255 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/tests/gbproxy/gbproxy_test.c b/tests/gbproxy/gbproxy_test.c
index 76fc000..78fa8cb 100644
--- a/tests/gbproxy/gbproxy_test.c
+++ b/tests/gbproxy/gbproxy_test.c
@@ -1309,7 +1309,7 @@
{
struct gprs_ns2_inst *nsi = gprs_ns2_instantiate(tall_sgsn_ctx,
gprs_ns2_callback, );
uint16_t bss_nsei[2] = {0x1000, 0x2000};
- uint16_t bvci[4] = {0x1002, 0x2002, 0x3002, 0x4002};
+ uint16_t bvci[4] = {0x1002, 0x2002, 0x3002};
gbcfg.nsi = nsi;
gbcfg.nsip_sgsn_nsei = SGSN_NSEI;
@@ -1381,45 +1381,6 @@
send_ns_unitdata(nsi, NULL, bss_nsei[0], bvci[2], (uint8_t *)"", 0);
send_ns_unitdata(nsi, NULL, SGSN_NSEI, bvci[2], (uint8_t *)"", 0);
- printf("--- Change NSVCI ---\n\n");
-
- setup_ns(nsi, bss_nsei[1]);
-
- printf("--- Setup BVCI 1 ---\n\n");
-
- setup_bssgp(nsi, bss_nsei[1], bvci[0]);
- send_bssgp_reset_ack(nsi, SGSN_NSEI, bvci[0]);
- dump_peers(stdout, 0, 0, );
-
- printf("--- Setup BVCI 4 ---\n\n");
-
- setup_bssgp(nsi, bss_nsei[1], bvci[3]);
- send_bssgp_reset_ack(nsi, SGSN_NSEI, bvci[3]);
- dump_peers(stdout, 0, 0, );
-
- printf("--- Send message from BSS 1 to SGSN and back, BVCI 1 ---\n\n");
-
- send_ns_unitdata(nsi, NULL, bss_nsei[1], bvci[0], (uint8_t *)"", 0);
- send_ns_unitdata(nsi, NULL, SGSN_NSEI, bvci[0], (uint8_t *)"", 0);
-
- printf("--- Send message from BSS 1 to SGSN and back, BVCI 2 "
- " (should fail) ---\n\n");
-
- send_ns_unitdata(nsi, NULL, bss_nsei[1], bvci[1], (uint8_t *)"", 0);
- dump_peers(stdout, 0, 0, );
- send_ns_unitdata(nsi, NULL, SGSN_NSEI, bvci[1], (uint8_t *)"", 0);
- dump_peers(stdout, 0, 0, );
-
- printf("--- Send message from BSS 1 to SGSN and back, BVCI 3 ---\n\n");
-
- send_ns_unitdata(nsi, NULL, bss_nsei[1], bvci[2], (uint8_t *)"", 0);
- send_ns_unitdata(nsi, NULL, SGSN_NSEI, bvci[2], (uint8_t *)"", 0);
-
- printf("--- Send message from BSS 1 to SGSN and back, BVCI 4 ---\n\n");
-
- send_ns_unitdata(nsi, NULL, bss_nsei[1], bvci[3], (uint8_t *)"", 0);
- send_ns_unitdata(nsi, NULL, SGSN_NSEI, bvci[3], (uint8_t *)"", 0);
-
dump_global(stdout, 0);
dump_peers(stdout, 0, 0, );
diff --git a/tests/gbproxy/gbproxy_test.ok b/tests/gbproxy/gbproxy_test.ok
index 6f20f12..74cedb3 100644
--- a/tests/gbproxy/gbproxy_test.ok
+++ b/tests/gbproxy/gbproxy_test.ok
@@ -654,227 +654,13 @@
Message for BSS (NSEI=8192 BVCI=12290):
[L2]> [L3]>
Change NSVCI ---
-
-Setup NS-VC: NSEI 0x2000(8192)
-
-NS2 CALLBACK, prim 2, bvci 0x
-
Setup BVCI 1 ---
-
-Setup BSSGP: BVCI 0x1002(4098)
-
-PROCESSING BVC_RESET from NSEI 8192
-22 04 82 10 02 07 81 08 08 88 11 22 33 40 50 60 10 00
-
-NS2 CALLBACK, prim 0, msg length 18, bvci 0x
-22 04 82 10 02 07 81 08 08 88 11 22 33 40 50 60 10 00
-
-NS2 UD REQUEST, prim 0, msg length 18, bvci 0x
-22 04 82 10 02 07 81 08 08 88 11 22 33 40 50 60 10 00
-
-Message for SGSN (NSEI=256 BVCI=0):
-[L2]> [L3]> 22 04 82 10 02 07 81 08 08 88 11 22 33 40 50 60 10 00
-
-PROCESSING BVC_RESET_ACK from NSEI 256
-23 04 82 10 02
-
-NS2 CALLBACK, prim 0, msg length 5, bvci 0x
-23 04 82 10 02
-
-NS2 UD REQUEST, prim 0, msg length 5, bvci 0x
-23 04 82 10 02
-
-Message for BSS (NSEI=8192 BVCI=0):
-[L2]> [L3]> 23 04 82 10 02
-
-Peers:
- NSEI 8192, BVCI 12290, not blocked, RAI 112-332-16464-96
-NSEI mismatch : 1
-TLLI-Cache: 0
- NSEI 4096, BVCI 8194, not blocked, RAI 112-332-16464-96
-NSEI mismatch : 1
-TLLI-Cache: 0
- NSEI 8192, BVCI 4098, not blocked, RAI 112-332-16464-96
-NSEI mismatch : 1
-TLLI-Cache: 0
Setup BVCI 4 ---
-
-Setup BSSGP: BVCI 0x4002(16386)
-
-PROCESSING BVC_RESET from NSEI 8192
-22 04 82 40 02 07 81 08 08 88 11 22 33 40 50 60 10 00
-
-NS2 CALLBACK, prim 0, msg length 18, bvci 0x
-22 04 82 40 02 07 81 08 08 88 11 22 33 40 50 60 10 00
-
-NS2 UD REQUEST, prim 0, msg length 18, bvci 0x
-22 04 82 40 02 07 81 08 08 88 11 22 33 40 50 60 10 00
-
-Message for SGSN (NSEI=256 BVCI=0):
-[L2]> [L3]> 22
Change in osmo-sgsn[master]: gbproxy: Remove test testing NSVCI change
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21413 ) Change subject: gbproxy: Remove test testing NSVCI change .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic1d7e646e633c9fa62812f5005ed10c0108a06f2 Gerrit-Change-Number: 21413 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 30 Nov 2020 19:38:08 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: gbproxy: Only send paging to each matching NSE once
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21417 ) Change subject: gbproxy: Only send paging to each matching NSE once .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia33e7816b354266b9d2659ef96b798db60c134f3 Gerrit-Change-Number: 21417 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 30 Nov 2020 17:36:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: gbproxy: Remove test testing NSVCI change
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21413 ) Change subject: gbproxy: Remove test testing NSVCI change .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic1d7e646e633c9fa62812f5005ed10c0108a06f2 Gerrit-Change-Number: 21413 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 30 Nov 2020 17:32:42 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: gbproxy: Remove test testing NSVCI change
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21413 ) Change subject: gbproxy: Remove test testing NSVCI change .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-sgsn/+/21413/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/21413/1//COMMIT_MSG@9 PS1, Line 9: Testing this here doesn't make much sense since ns2. > Ack Done (I hope) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic1d7e646e633c9fa62812f5005ed10c0108a06f2 Gerrit-Change-Number: 21413 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 30 Nov 2020 17:31:46 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-sgsn[master]: gbproxy: Add NSE peer that can have multiple gbproxy_peers
Hello Jenkins Builder, laforge, pespin, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21406 to look at the new patch set (#6). Change subject: gbproxy: Add NSE peer that can have multiple gbproxy_peers .. gbproxy: Add NSE peer that can have multiple gbproxy_peers We want this level of indirection to support multiple BVCs per NSE. The current code assumes that an NSE only has one BVC which breaks messages on the signalling BVC which should only be sent once to an NSE regardless of the number of BVCs it contains. Change-Id: I97cc6c8f8c0f1b91577ab8f679c4ae217cc88076 Related: SYS#5226 --- M include/osmocom/sgsn/gb_proxy.h M src/gbproxy/gb_proxy.c M src/gbproxy/gb_proxy_ctrl.c M src/gbproxy/gb_proxy_patch.c M src/gbproxy/gb_proxy_peer.c M src/gbproxy/gb_proxy_tlli.c M src/gbproxy/gb_proxy_vty.c M tests/gbproxy/gbproxy_test.c M tests/gbproxy/gbproxy_test.ok 9 files changed, 495 insertions(+), 285 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/06/21406/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I97cc6c8f8c0f1b91577ab8f679c4ae217cc88076 Gerrit-Change-Number: 21406 Gerrit-PatchSet: 6 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-sgsn[master]: gbproxy: Only send paging to each matching NSE once
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21417 to look at the new patch set (#2). Change subject: gbproxy: Only send paging to each matching NSE once .. gbproxy: Only send paging to each matching NSE once Fixes: SYS#5226 Change-Id: Ia33e7816b354266b9d2659ef96b798db60c134f3 --- M src/gbproxy/gb_proxy.c 1 file changed, 34 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/17/21417/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia33e7816b354266b9d2659ef96b798db60c134f3 Gerrit-Change-Number: 21417 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset
Change in osmo-sgsn[master]: gbproxy: Separate function to move gbproxy_peer to different nse
Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21418 to look at the new patch set (#2). Change subject: gbproxy: Separate function to move gbproxy_peer to different nse .. gbproxy: Separate function to move gbproxy_peer to different nse Change-Id: I0a8b1e4b78384ea99d50109f050ca501b18ba5d9 Related: SYS#5226 --- M include/osmocom/sgsn/gb_proxy.h M src/gbproxy/gb_proxy.c M src/gbproxy/gb_proxy_peer.c 3 files changed, 9 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/18/21418/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I0a8b1e4b78384ea99d50109f050ca501b18ba5d9 Gerrit-Change-Number: 21418 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-sgsn[master]: gbproxy: Remove test testing NSVCI change
Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21413 to look at the new patch set (#2). Change subject: gbproxy: Remove test testing NSVCI change .. gbproxy: Remove test testing NSVCI change This was overlooked in commit 82182d which already removed lots of NS-specific code in gbproxy_test.c >From that commit message: """ Since NS2 has a different abstraction we mock up the prim send/recv functions and don't test NS like the old tests did. """ Change-Id: Ic1d7e646e633c9fa62812f5005ed10c0108a06f2 Related: SYS#5226 --- M tests/gbproxy/gbproxy_test.c M tests/gbproxy/gbproxy_test.ok 2 files changed, 2 insertions(+), 255 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/13/21413/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic1d7e646e633c9fa62812f5005ed10c0108a06f2 Gerrit-Change-Number: 21413 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-sgsn[master]: gbproxy: Ensure BVC0 is reset before handling PtP BVCs
Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21410 to look at the new patch set (#4). Change subject: gbproxy: Ensure BVC0 is reset before handling PtP BVCs .. gbproxy: Ensure BVC0 is reset before handling PtP BVCs Change-Id: I9c67f973f7bca00e8eb22a024ef2282c007dd84b Related: SYS#5226 --- M src/gbproxy/gb_proxy.c M tests/gbproxy/gbproxy_test.c M tests/gbproxy/gbproxy_test.ok 3 files changed, 125 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/10/21410/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9c67f973f7bca00e8eb22a024ef2282c007dd84b Gerrit-Change-Number: 21410 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-gsm-tester[master]: Introduce Android UEs as new modems
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302 )
Change subject: Introduce Android UEs as new modems
..
Patch Set 3: Code-Review-1
(13 comments)
This is starting to look good, there's only a few things here and there which
needs polishing.
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/3/src/osmo_gsm_tester/obj/android_apn.py
File src/osmo_gsm_tester/obj/android_apn.py:
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/3/src/osmo_gsm_tester/obj/android_apn.py@30
PS3, Line 30: schema.register_resource_schema('apn', resource_schema)
This is probably not correct, as this should rpobably be under "modem" object
or alike. So modem will probably end up adding this by using
AndroidApn.schema() on its on_register_schemas()
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/3/src/osmo_gsm_tester/obj/android_apn.py@71
PS3, Line 71: def from_conf(cls, conf):
This one is PUBLIC INTERNAL API
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/3/src/osmo_gsm_tester/obj/android_apn.py@75
PS3, Line 75: @classmethod
This one is PUBLIC INTERNAL API
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/3/src/osmo_gsm_tester/obj/android_apn.py@87
PS3, Line 87: proc = self.run_androidue_cmd("set-apn",
[qry_carrier_cmd])
"get-carrier-id" instead of "set-apn"? or is set-apn the binary? Not sure now
if this is a description string or the binary name.
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/3/src/osmo_gsm_tester/obj/android_host.py
File src/osmo_gsm_tester/obj/android_host.py:
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/3/src/osmo_gsm_tester/obj/android_host.py@31
PS3, Line 31: def __init__(self, name, testenv, conf):
what's the point in passing these params to constructor if you don't use them?
You can remove them
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/3/src/osmo_gsm_tester/obj/android_host.py@42
PS3, Line 42: log.dbg("Deleted the following files: %s" %
clear_run_dir_proc.get_stdout())
You should better inherit from log.Origin in AndroidHost and use self.log. See
how other classes do it.
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/3/src/osmo_gsm_tester/obj/android_host.py@50
PS3, Line 50: self.dbg("Deleted the following files: %s" %
clear_diag_logs_proc.get_stdout())
see, you already expect to be inheriting from log.Origin, but you are not ;)
This probably works because subclasses are inheriting from log.Origin. You
should be inheriting here instead, and call this constructor from child classes
instead.
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/3/src/osmo_gsm_tester/obj/android_host.py@72
PS3, Line 72: if self._run_node.is_local():
I would welcome some description here too, specially what's the main difference
with the method above and the rationale for having both.
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/3/src/osmo_gsm_tester/obj/iperf3.py
File src/osmo_gsm_tester/obj/iperf3.py:
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/3/src/osmo_gsm_tester/obj/iperf3.py@297
PS3, Line 297: elif self._run_node.ssh_port():
So the main difference between this branch and the one below is that you need
to force "root" user?
I'm not liking checking here based on whether ssh port is set or not. We should
flag this somehow in the class implementing when passing its run_node by means
of this class set_run_node().
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/3/src/osmo_gsm_tester/obj/iperf3.py@315
PS3, Line 315: self.process = process.Process(self.name(),
self.run_dir, popen_args, env={})
Please add a new AdbProcess sublcass similar to NetNSProcess to hide this adb
command stuff.
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/3/src/osmo_gsm_tester/obj/ms_android.py
File src/osmo_gsm_tester/obj/ms_android.py:
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/3/src/osmo_gsm_tester/obj/ms_android.py@43
PS3, Line 43: resource_schema['apn.%s' % key] = val
what I wrote in the first file of this patch: This is done here, so no need to
have it in register_schemas() on the AndroidApn file.
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/3/src/osmo_gsm_tester/obj/ms_android.py@257
PS3, Line 257: ip_prefix = "172.16.0"
This API is probably PROTECTED?
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/3/src/osmo_gsm_tester/obj/qc_diag.py
File src/osmo_gsm_tester/obj/qc_diag.py:
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/3/src/osmo_gsm_tester/obj/qc_diag.py@81
PS3, Line 81: while timer > 0:
I think in general you should be using event_loop.py's wait() method for this
kind of sleeping loops.
See for instance:
"""
MainLoop.wait(self.dbus.has_interface, *req_ifaces, timeout=10)
"""
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302
To unsubscribe, or for
Change in osmo-sgsn[master]: gbproxy: Remove test testing NSVCI change
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21413 ) Change subject: gbproxy: Remove test testing NSVCI change .. Patch Set 1: Code-Review+1 (1 comment) would be good to get the commitlog amended so we can merge the other patches depending on this. https://gerrit.osmocom.org/c/osmo-sgsn/+/21413/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/21413/1//COMMIT_MSG@9 PS1, Line 9: Testing this here doesn't make much sense since ns2. > Why? Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic1d7e646e633c9fa62812f5005ed10c0108a06f2 Gerrit-Change-Number: 21413 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 30 Nov 2020 16:34:48 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-sgsn[master]: gbproxy: Separate function to move gbproxy_peer to different nse
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21418 ) Change subject: gbproxy: Separate function to move gbproxy_peer to different nse .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I0a8b1e4b78384ea99d50109f050ca501b18ba5d9 Gerrit-Change-Number: 21418 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 30 Nov 2020 16:34:13 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: gbproxy: Only send paging to each matching NSE once
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21417 ) Change subject: gbproxy: Only send paging to each matching NSE once .. Patch Set 1: Code-Review+1 one could probably introduce the per-NSE counters before this patch to avoid the FIXMe -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia33e7816b354266b9d2659ef96b798db60c134f3 Gerrit-Change-Number: 21417 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 30 Nov 2020 16:33:50 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: gbproxy: Ensure BVC0 is reset before handling PtP BVCs
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21410 ) Change subject: gbproxy: Ensure BVC0 is reset before handling PtP BVCs .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9c67f973f7bca00e8eb22a024ef2282c007dd84b Gerrit-Change-Number: 21410 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 30 Nov 2020 16:33:01 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: Process: Add remote_port as new parameter
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300 )
Change subject: Process: Add remote_port as new parameter
..
Process: Add remote_port as new parameter
remote_port defines a custom/additional port for
connections over ssh. It may be used in case several
ssh instances share one IP address.
Change-Id: I2c93fd2ea1c10c333d00eafd3c1066c35796e398
---
M src/osmo_gsm_tester/core/process.py
M src/osmo_gsm_tester/core/remote.py
M src/osmo_gsm_tester/obj/run_node.py
3 files changed, 21 insertions(+), 5 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo_gsm_tester/core/process.py
b/src/osmo_gsm_tester/core/process.py
index eaf8de7..0b96f2e 100644
--- a/src/osmo_gsm_tester/core/process.py
+++ b/src/osmo_gsm_tester/core/process.py
@@ -381,12 +381,14 @@
class RemoteProcess(Process):
-def __init__(self, name, run_dir, remote_user, remote_host, remote_cwd,
popen_args, remote_env={}, **popen_kwargs):
+def __init__(self, name, run_dir, remote_user, remote_host, remote_cwd,
popen_args,
+ remote_env={}, remote_port=None, **popen_kwargs):
super().__init__(name, run_dir, popen_args, **popen_kwargs)
self.remote_user = remote_user
self.remote_host = remote_host
self.remote_cwd = remote_cwd
self.remote_env = remote_env
+self.remote_port = remote_port
# hacky: instead of just prepending ssh, i.e. piping stdout and stderr
# over the ssh link, we should probably run on the remote side,
@@ -402,6 +404,10 @@
'%s %s %s' % (cd,
' '.join(['%s=%r'%(k,v) for k,v in
self.remote_env.items()]),
' '.join(self.popen_args))]
+if self.remote_port:
+self.popen_args.insert(1, '-p')
+self.popen_args.insert(2, self.remote_port)
+
self.dbg(self.popen_args, dir=self.run_dir, conf=self.popen_kwargs,
remote_env=self.remote_env)
def RunError(self, msg_prefix):
diff --git a/src/osmo_gsm_tester/core/remote.py
b/src/osmo_gsm_tester/core/remote.py
index 8deb25d..0ea873d 100644
--- a/src/osmo_gsm_tester/core/remote.py
+++ b/src/osmo_gsm_tester/core/remote.py
@@ -28,13 +28,14 @@
WRAPPER_SCRIPT = 'ssh_sigkiller.sh'
-def __init__(self, run_dir, remote_user = 'root', remote_host =
'localhost', remote_cwd=None):
+def __init__(self, run_dir, remote_user = 'root', remote_host =
'localhost', remote_cwd=None, remote_port=None):
super().__init__(log.C_RUN, 'host-' + remote_user + '@' + remote_host)
self.run_dir = util.Dir(run_dir.new_dir(self.name()))
self.remote_user = remote_user
self.remote_host = remote_host
self.remote_cwd = remote_cwd
self.remote_env = {}
+self.remote_port = remote_port
def user(self):
return self.remote_user
@@ -51,9 +52,13 @@
def get_remote_env(self):
return self.remote_env
+def get_remote_port(self):
+return self.remote_port
+
def RemoteProcess(self, name, popen_args, remote_env={}, **popen_kwargs):
run_dir = self.run_dir.new_dir(name)
-return process.RemoteProcess(name, run_dir, self.user(), self.host(),
self.cwd(), popen_args, remote_env=remote_env, **popen_kwargs)
+return process.RemoteProcess(name, run_dir, self.user(), self.host(),
self.cwd(), popen_args,
+ remote_env=remote_env,
remote_port=self.get_remote_port(), **popen_kwargs)
def generate_wrapper_script(self, wait_time_sec):
wrapper_script = self.run_dir.new_file(RemoteHost.WRAPPER_SCRIPT)
diff --git a/src/osmo_gsm_tester/obj/run_node.py
b/src/osmo_gsm_tester/obj/run_node.py
index 6a030ac..7c41705 100644
--- a/src/osmo_gsm_tester/obj/run_node.py
+++ b/src/osmo_gsm_tester/obj/run_node.py
@@ -30,13 +30,14 @@
T_LOCAL = 'local'
T_REM_SSH = 'ssh'
-def __init__(self, type=None, run_addr=None, ssh_user=None, ssh_addr=None,
run_label=None):
+def __init__(self, type=None, run_addr=None, ssh_user=None, ssh_addr=None,
run_label=None, ssh_port=None):
super().__init__(log.C_RUN, 'runnode')
self._type = type
self._run_addr = run_addr
self._ssh_user = ssh_user
self._ssh_addr = ssh_addr
self._run_label = run_label
+self._ssh_port = ssh_port
if not self._type:
raise log.Error('run_type not set')
if not self._run_addr:
@@ -55,7 +56,7 @@
def from_conf(cls, conf):
return cls(conf.get('run_type', None), conf.get('run_addr', None),
conf.get('ssh_user', None), conf.get('ssh_addr', None),
- conf.get('run_label', None))
+ conf.get('run_label', None), conf.get('ssh_port', None))
Change in osmo-sgsn[master]: gbproxy: Add NSE peer that can have multiple gbproxy_peers
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21406 ) Change subject: gbproxy: Add NSE peer that can have multiple gbproxy_peers .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I97cc6c8f8c0f1b91577ab8f679c4ae217cc88076 Gerrit-Change-Number: 21406 Gerrit-PatchSet: 5 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 30 Nov 2020 16:32:42 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: Process: Add remote_port as new parameter
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300 ) Change subject: Process: Add remote_port as new parameter .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21300 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I2c93fd2ea1c10c333d00eafd3c1066c35796e398 Gerrit-Change-Number: 21300 Gerrit-PatchSet: 2 Gerrit-Owner: ninjab3s Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 30 Nov 2020 16:32:21 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: gbproxy: Separate function to move gbproxy_peer to different nse
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21418 ) Change subject: gbproxy: Separate function to move gbproxy_peer to different nse .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I0a8b1e4b78384ea99d50109f050ca501b18ba5d9 Gerrit-Change-Number: 21418 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 30 Nov 2020 16:30:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: gbproxy: Add NSE peer that can have multiple gbproxy_peers
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21406 ) Change subject: gbproxy: Add NSE peer that can have multiple gbproxy_peers .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I97cc6c8f8c0f1b91577ab8f679c4ae217cc88076 Gerrit-Change-Number: 21406 Gerrit-PatchSet: 5 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 30 Nov 2020 16:28:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon/scheduler: invalidate hard-coded Measurement results
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/21416 ) Change subject: trxcon/scheduler: invalidate hard-coded Measurement results .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/21416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7da767e146aec7cef1de71e4d735d6a02b6c5642 Gerrit-Change-Number: 21416 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 30 Nov 2020 16:21:19 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon/scheduler: clarify the content of Measurement results
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/21415 ) Change subject: trxcon/scheduler: clarify the content of Measurement results .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/21415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I26546dcbc853166e351d00260936b1b9d584ae03 Gerrit-Change-Number: 21415 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 30 Nov 2020 16:20:13 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon/scheduler: clarify Measurement results padding
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/21414 ) Change subject: trxcon/scheduler: clarify Measurement results padding .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/21414 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4db6845c98aded10291134f416da98fd0f4f58e3 Gerrit-Change-Number: 21414 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 30 Nov 2020 16:18:42 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: gbproxy: Remove test testing NSVCI change
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21413 ) Change subject: gbproxy: Remove test testing NSVCI change .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-sgsn/+/21413/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/21413/1//COMMIT_MSG@9 PS1, Line 9: Testing this here doesn't make much sense since ns2. Why? -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic1d7e646e633c9fa62812f5005ed10c0108a06f2 Gerrit-Change-Number: 21413 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 30 Nov 2020 16:18:16 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-sgsn[master]: gbproxy: Ensure BVC0 is reset before handling PtP BVCs
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21410 ) Change subject: gbproxy: Ensure BVC0 is reset before handling PtP BVCs .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9c67f973f7bca00e8eb22a024ef2282c007dd84b Gerrit-Change-Number: 21410 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 30 Nov 2020 16:17:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: gbproxy: Separate function to move gbproxy_peer to different nse
daniel has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/21418 )
Change subject: gbproxy: Separate function to move gbproxy_peer to different nse
..
gbproxy: Separate function to move gbproxy_peer to different nse
Change-Id: I0a8b1e4b78384ea99d50109f050ca501b18ba5d9
Related: SYS#5226
---
M include/osmocom/sgsn/gb_proxy.h
M src/gbproxy/gb_proxy.c
M src/gbproxy/gb_proxy_peer.c
3 files changed, 9 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/18/21418/1
diff --git a/include/osmocom/sgsn/gb_proxy.h b/include/osmocom/sgsn/gb_proxy.h
index 54d4548..9f91bd6 100644
--- a/include/osmocom/sgsn/gb_proxy.h
+++ b/include/osmocom/sgsn/gb_proxy.h
@@ -344,6 +344,7 @@
struct gbproxy_config *cfg, struct tlv_parsed *tp);
struct gbproxy_peer *gbproxy_peer_alloc(struct gbproxy_nse *nse, uint16_t
bvci);
void gbproxy_peer_free(struct gbproxy_peer *peer);
+void gbproxy_peer_move(struct gbproxy_peer *peer, struct gbproxy_nse *nse);
int gbproxy_cleanup_peers(struct gbproxy_config *cfg, uint16_t nsei, uint16_t
bvci);
/* NSE handling */
diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c
index db7f55b..bd58617 100644
--- a/src/gbproxy/gb_proxy.c
+++ b/src/gbproxy/gb_proxy.c
@@ -1114,9 +1114,7 @@
LOGP(DGPRS, LOGL_NOTICE, "Peer for BVCI=%u
moved from NSEI=%u to NSEI=%u\n", bvci, nse_old->nsei, nsei);
/* Move peer to different NSE */
- llist_del(_peer->list);
- llist_add(_peer->list,
_new->bts_peers);
- from_peer->nse = nse_new;
+ gbproxy_peer_move(from_peer, nse_new);
}
if (TLVP_PRESENT(, BSSGP_IE_CELL_ID)) {
diff --git a/src/gbproxy/gb_proxy_peer.c b/src/gbproxy/gb_proxy_peer.c
index 920547c..62c4d94 100644
--- a/src/gbproxy/gb_proxy_peer.c
+++ b/src/gbproxy/gb_proxy_peer.c
@@ -253,6 +253,13 @@
talloc_free(peer);
}
+void gbproxy_peer_move(struct gbproxy_peer *peer, struct gbproxy_nse *nse)
+{
+ llist_del(>list);
+ llist_add(>list, >bts_peers);
+ peer->nse = nse;
+}
+
int gbproxy_cleanup_peers(struct gbproxy_config *cfg, uint16_t nsei, uint16_t
bvci)
{
int counter = 0;
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21418
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I0a8b1e4b78384ea99d50109f050ca501b18ba5d9
Gerrit-Change-Number: 21418
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
Gerrit-MessageType: newchange
Change in osmo-pcu[master]: Dl TBF: Get rid of LLC UI dummy blocks following other data
Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/21387 to look at the new patch set (#4). Change subject: Dl TBF: Get rid of LLC UI dummy blocks following other data .. Dl TBF: Get rid of LLC UI dummy blocks following other data According to: * 3GPP TS 44.060 version 16.0.0 "9.3.1a Delayed release of downlink Temporary Block Flow" * 3GPP TS 44.064 version 16.0.0 "6.4.2.2 Unconfirmed Information (UI) Dummy command" LLC UI Dummy frames are to be used when there no more data to send, only in order to delay the release of a TBF. Hence, while not incorrect per se, makes no sense to send those LLC UI Dummy frames inserted into rlcmac blocks which already contain other LLC frames, since the MS in that case is already being kept active. It only makes sense to send those LLC UI Dummy frames when we have nothing else to send, that is, alone inside a RLCMAC block without other LLC frames. Related: OS#4849 Change-Id: Ifae1a7b2b3dfad8df19585063088ba0df2749c8f --- M src/encoding.cpp M src/encoding.h M src/tbf_dl.cpp M tests/tbf/TbfTest.err 4 files changed, 170 insertions(+), 198 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/87/21387/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ifae1a7b2b3dfad8df19585063088ba0df2749c8f Gerrit-Change-Number: 21387 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: newpatchset
Change in osmo-sgsn[master]: gbproxy: Only send paging to each matching NSE once
daniel has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/21417 )
Change subject: gbproxy: Only send paging to each matching NSE once
..
gbproxy: Only send paging to each matching NSE once
Fixes: SYS#5226
Change-Id: Ia33e7816b354266b9d2659ef96b798db60c134f3
---
M src/gbproxy/gb_proxy.c
1 file changed, 34 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/17/21417/1
diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c
index 1ca4fc6..db7f55b 100644
--- a/src/gbproxy/gb_proxy.c
+++ b/src/gbproxy/gb_proxy.c
@@ -813,11 +813,10 @@
return rc;
}
-/* feed a message down the NS-VC associated with the specified peer */
-static int gbprox_relay2peer(struct msgb *old_msg, struct gbproxy_peer *peer,
+/* feed a message down the NSE */
+static int gbprox_relay2nse(struct msgb *old_msg, struct gbproxy_nse *nse,
uint16_t ns_bvci)
{
- struct gbproxy_nse *nse = peer->nse;
OSMO_ASSERT(nse);
OSMO_ASSERT(nse->cfg);
@@ -825,7 +824,7 @@
* be free()d safely when we return from gbprox_rcvmsg() */
struct gprs_ns2_inst *nsi = nse->cfg->nsi;
struct osmo_gprs_ns2_prim nsp = {};
- struct msgb *msg = bssgp_msgb_copy(old_msg, "msgb_relay2peer");
+ struct msgb *msg = bssgp_msgb_copy(old_msg, "msgb_relay2nse");
uint32_t tlli;
int rc;
@@ -849,6 +848,22 @@
osmo_prim_init(, SAP_NS, PRIM_NS_UNIT_DATA,
PRIM_OP_REQUEST, msg);
rc = gprs_ns2_recv_prim(nsi, );
+ /* FIXME: We need a counter group for gbproxy_nse */
+ //if (rc < 0)
+ // rate_ctr_inc(>ctrg->ctr[GBPROX_PEER_CTR_TX_ERR]);
+
+ return rc;
+}
+
+/* feed a message down the NS-VC associated with the specified peer */
+static int gbprox_relay2peer(struct msgb *old_msg, struct gbproxy_peer *peer,
+uint16_t ns_bvci)
+{
+ int rc;
+ struct gbproxy_nse *nse = peer->nse;
+ OSMO_ASSERT(nse);
+
+ rc = gbprox_relay2nse(old_msg, nse, ns_bvci);
if (rc < 0)
rate_ctr_inc(>ctrg->ctr[GBPROX_PEER_CTR_TX_ERR]);
@@ -1151,7 +1166,7 @@
{
struct gbproxy_nse *nse;
struct gbproxy_peer *peer;
- unsigned int n_peers = 0;
+ unsigned int n_nses = 0;
int errctr = GBPROX_GLOB_CTR_PROTO_ERR_SGSN;
/* FIXME: Handle paging logic to only page each matching NSE */
@@ -1176,9 +1191,11 @@
llist_for_each_entry(nse, >nse_peers, list) {
llist_for_each_entry(peer, >bts_peers, list) {
if (!memcmp(peer->ra, TLVP_VAL(tp,
BSSGP_IE_ROUTEING_AREA), 6)) {
- LOGPC(DGPRS, LOGL_INFO, "routing by RAI
to peer BVCI=%u\n", peer->bvci);
- gbprox_relay2peer(msg, peer, ns_bvci);
- n_peers++;
+ LOGPC(DGPRS, LOGL_INFO, "routing by RAI
to peer NSEI=%u\n", peer->bvci);
+ gbprox_relay2nse(msg, nse, ns_bvci);
+ n_nses++;
+ /* Only send it once to each NSE */
+ break;
}
}
}
@@ -1189,8 +1206,10 @@
llist_for_each_entry(peer, >bts_peers, list) {
if (!memcmp(peer->ra, TLVP_VAL(tp,
BSSGP_IE_LOCATION_AREA), 5)) {
LOGPC(DGPRS, LOGL_INFO, "routing by LAI
to peer BVCI=%u\n", peer->bvci);
- gbprox_relay2peer(msg, peer, ns_bvci);
- n_peers++;
+ gbprox_relay2nse(msg, nse, ns_bvci);
+ n_nses++;
+ /* Only send it once to each NSE */
+ break;
}
}
}
@@ -1199,8 +1218,10 @@
llist_for_each_entry(nse, >nse_peers, list) {
llist_for_each_entry(peer, >bts_peers, list) {
LOGPC(DGPRS, LOGL_INFO, "broadcasting to peer
BVCI=%u\n", peer->bvci);
- gbprox_relay2peer(msg, peer, ns_bvci);
- n_peers++;
+ gbprox_relay2nse(msg, nse, ns_bvci);
+ n_nses++;
+ /* Only send it once to each NSE */
+ break;
}
}
} else {
@@ -1210,7 +1231,7 @@
rate_ctr_inc(>ctrg->ctr[errctr]);
}
- if
Change in osmo-ttcn3-hacks[master]: bsc: add TC_assignment_codec_amr_startmode_cruft
neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21373 )
Change subject: bsc: add TC_assignment_codec_amr_startmode_cruft
..
bsc: add TC_assignment_codec_amr_startmode_cruft
Make sure that when a 'start-mode auto' is set, that the previous start
mode setting does not linger in the unused bits.
- after I577ff590d7588fd7e3ee4846c7955ab8f84cf2b1, osmo-bsc sets its
ICMI bit properly, but passes this test only because it *always* sends
smod (start-mode) bits as zero.
- in I49691df01745a7c485bf165e897872c35fc4b147, the smod bits are
properly sent on RSL, but this test shows that when ICMI becomes zero
for 'start-mode auto', the smod bits will remain whatever start-mode
was set in the previous osmo-bsc config. Instead, osmo-bsc should
clear the smod bits for 'start-mode auto' so that its MultiRate Config
does not vary depending on what was previously configured.
- in I1ec5bad0bce01cc425ee05ecf70c83ec662a226a, clearing smod is
implemented and this test is expected to pass.
Change-Id: I151678f64e680f30f35b6bb2b0036d63efde9f2c
---
M bsc/BSC_Tests.ttcn
1 file changed, 37 insertions(+), 0 deletions(-)
Approvals:
neels: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 251801b..7c12559 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -3711,6 +3711,42 @@
f_vty_amr_start_mode_restore(false);
}
+/* 'amr start-mode auto' should not keep the (unused) 'smod' bits from
previous configuration */
+testcase TC_assignment_codec_amr_startmode_cruft() runs on test_CT {
+ var TestHdlrParams pars := f_gen_test_hdlr_pars();
+ var MSC_ConnHdlr vc_conn;
+
+ var RSL_IE_Body mr_conf := {
+ other := {
+ len := 2,
+ payload := '2004'O /* <- expect ICMI=0, smod=00 */
+ }
+ };
+
+ pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_F}));
+ pars.ass_codec_list.codecElements[0].s0_7 := '0100'B; /* 5,90k */
+ pars.ass_codec_list.codecElements[0].s8_15 := '01010111'B;
+ pars.expect_mr_conf_ie := mr_conf;
+
+ f_init(1, true);
+ f_sleep(1.0);
+
+ /* First set nonzero start mode bits */
+ f_vty_amr_start_mode_set(true, "4");
+ /* Now set to auto, and expect the startmode bits to be zero in the
message, i.e. ensure that osmo-bsc does not
+* let the startmode bits stick around and has deterministic MultiRate
config for 'start-mode auto'; that is
+* ensured by above '2004'O, where 'x0xx'O indicates ICMI = 0, spare =
0, smod = 00. */
+ f_vty_amr_start_mode_set(true, "auto");
+
+ vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);
+ vc_conn.done;
+ f_shutdown_helper();
+
+ /* Clear the startmode bits to not affect subsequent tests, in case the
bits should indeed stick around. */
+ f_vty_amr_start_mode_set(true, "1");
+ f_vty_amr_start_mode_restore(true);
+}
+
function f_TC_assignment_codec_amr(boolean fr, octetstring mrconf, bitstring
s8_s0, bitstring exp_s8_s0,
charstring start_mode := "1")
runs on test_CT {
@@ -8415,6 +8451,7 @@
execute( TC_assignment_codec_amr_h_S7() );
execute( TC_assignment_codec_amr_f_start_mode_auto() );
execute( TC_assignment_codec_amr_h_start_mode_auto() );
+ execute( TC_assignment_codec_amr_startmode_cruft() );
}
execute( TC_assignment_codec_fr_exhausted_req_hr() );
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21373
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I151678f64e680f30f35b6bb2b0036d63efde9f2c
Gerrit-Change-Number: 21373
Gerrit-PatchSet: 3
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: bsc: add tests for AMR 'start-mode auto'
neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21371 )
Change subject: bsc: add tests for AMR 'start-mode auto'
..
bsc: add tests for AMR 'start-mode auto'
These tests will fail until osmo-bsc
I577ff590d7588fd7e3ee4846c7955ab8f84cf2b1
Related: OS#4868
Change-Id: Iec74b940009c8ec78a6da5c00615259e2edc1781
---
M bsc/BSC_Tests.ttcn
1 file changed, 15 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 4cbc256..251801b 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -3711,7 +3711,8 @@
f_vty_amr_start_mode_restore(false);
}
-function f_TC_assignment_codec_amr(boolean fr, octetstring mrconf, bitstring
s8_s0, bitstring exp_s8_s0)
+function f_TC_assignment_codec_amr(boolean fr, octetstring mrconf, bitstring
s8_s0, bitstring exp_s8_s0,
+ charstring start_mode := "1")
runs on test_CT {
var TestHdlrParams pars := f_gen_test_hdlr_pars();
@@ -3737,7 +3738,7 @@
f_init(1, true);
f_allow_amr_rate_4_75k_5_90k_7_40k_12_20k();
- f_vty_amr_start_mode_set(fr, "1");
+ f_vty_amr_start_mode_set(fr, start_mode);
f_sleep(1.0);
vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);
@@ -3886,6 +3887,16 @@
f_shutdown_helper();
}
+testcase TC_assignment_codec_amr_f_start_mode_auto() runs on test_CT {
+ f_TC_assignment_codec_amr(true, '209520882208'O, ''B,
'0010'B,
+ start_mode := "auto");
+}
+
+testcase TC_assignment_codec_amr_h_start_mode_auto() runs on test_CT {
+ f_TC_assignment_codec_amr(false, '2015208820'O, '10010101'B,
'00010101'B,
+ start_mode := "auto");
+}
+
private function f_disable_all_tch_f() runs on test_CT {
f_vty_transceive(BSCVTY, "bts 0 trx 0 timeslot 1 sub-slot 0 borken");
f_vty_transceive(BSCVTY, "bts 0 trx 0 timeslot 2 sub-slot 0 borken");
@@ -8402,6 +8413,8 @@
execute( TC_assignment_codec_amr_f_zero() );
execute( TC_assignment_codec_amr_f_unsupp() );
execute( TC_assignment_codec_amr_h_S7() );
+ execute( TC_assignment_codec_amr_f_start_mode_auto() );
+ execute( TC_assignment_codec_amr_h_start_mode_auto() );
}
execute( TC_assignment_codec_fr_exhausted_req_hr() );
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21371
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iec74b940009c8ec78a6da5c00615259e2edc1781
Gerrit-Change-Number: 21371
Gerrit-PatchSet: 4
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: bsc: set the AMR start-mode that the tests expect
neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21370 )
Change subject: bsc: set the AMR start-mode that the tests expect
..
bsc: set the AMR start-mode that the tests expect
osmo-bsc currently has a bug that fails to reflect the correct
start-mode in the AMR MultiRate config IE.
And it went unnoticed that the ttcn tests expect a MultiRate config of
ICMI = 1, even though the used configuration should yield ICMI = 0.
See mr_conf = '2804'O, where the '8' indicates ICMI = 1.
As a first fix of the ttcn3-bsc-tests, configure the BSC according to
the expected ICMI value and Start Mode, i.e. ICMI = 1 and StartMode = 0,
which is configured by 'amr tch-[fh] start-mode 1'. This should make
these tests pass as-is for both the current osmo-bsc as well as an
osmo-bsc where the bug is fixed, with minimal changes to the current
tests. See also OS#4868.
An upcoming patch will add tests for 'start-mode auto'.
Related: OS#4868
Change-Id: I4cff01c37d5c7e301e9a01f773b7e009a789519b
---
M bsc/BSC_Tests.ttcn
1 file changed, 28 insertions(+), 0 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index cda0687..4cbc256 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -3638,6 +3638,21 @@
});
}
+private function f_vty_amr_start_mode_set(boolean fr, charstring startmode)
runs on test_CT {
+ var charstring tch;
+ if (fr) {
+ tch := "tch-f";
+ } else {
+ tch := "tch-h";
+ }
+ f_vty_cfg_bts(BSCVTY, 0, { "amr " & tch & " start-mode " & startmode });
+}
+
+/* Set the AMR start-mode for this TCH back to the default configuration. */
+private function f_vty_amr_start_mode_restore(boolean fr) runs on test_CT {
+ f_vty_amr_start_mode_set(fr, "auto");
+}
+
testcase TC_assignment_codec_amr_f() runs on test_CT {
var TestHdlrParams pars := f_gen_test_hdlr_pars();
var MSC_ConnHdlr vc_conn;
@@ -3659,10 +3674,13 @@
f_init(1, true);
f_sleep(1.0);
+ f_vty_amr_start_mode_set(true, "1");
vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);
vc_conn.done;
f_shutdown_helper();
+
+ f_vty_amr_start_mode_restore(true);
}
testcase TC_assignment_codec_amr_h() runs on test_CT {
@@ -3684,10 +3702,13 @@
f_init(1, true);
f_sleep(1.0);
+ f_vty_amr_start_mode_set(false, "1");
vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);
vc_conn.done;
f_shutdown_helper();
+
+ f_vty_amr_start_mode_restore(false);
}
function f_TC_assignment_codec_amr(boolean fr, octetstring mrconf, bitstring
s8_s0, bitstring exp_s8_s0)
@@ -3716,11 +3737,13 @@
f_init(1, true);
f_allow_amr_rate_4_75k_5_90k_7_40k_12_20k();
+ f_vty_amr_start_mode_set(fr, "1");
f_sleep(1.0);
vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);
vc_conn.done;
f_allow_amr_rate_5_90k();
+ f_vty_amr_start_mode_restore(fr);
}
function f_TC_assignment_codec_amr_fail(boolean fr, bitstring s8_s0)
@@ -3739,11 +3762,13 @@
f_init(1, true);
f_allow_amr_rate_4_75k_5_90k_7_40k_12_20k();
+ f_vty_amr_start_mode_set(fr, "1");
f_sleep(1.0);
vc_conn := f_start_handler(refers(f_TC_assignment_codec_fail), pars);
vc_conn.done;
f_allow_amr_rate_5_90k();
+ f_vty_amr_start_mode_restore(fr);
}
@@ -4164,10 +4189,13 @@
f_init(1, true, true);
f_sleep(1.0);
+ f_vty_amr_start_mode_set(false, "1");
vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);
vc_conn.done;
f_shutdown_helper();
+
+ f_vty_amr_start_mode_restore(false);
}
/* test the procedure of the MSC requesting a Classmark Update:
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21370
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4cff01c37d5c7e301e9a01f773b7e009a789519b
Gerrit-Change-Number: 21370
Gerrit-PatchSet: 4
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: add f_vty_cfg_bts(), f_vty_cfg_msc()
neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21369 )
Change subject: add f_vty_cfg_bts(), f_vty_cfg_msc()
..
add f_vty_cfg_bts(), f_vty_cfg_msc()
These allow passing N vty configurations on the bts / msc node without
requiring subsequent 'exit'.
As an example, use f_vty_cfg_msc() in BSC_Tests.ttcn AMR config.
Change-Id: I9f3e485f692acb3d2a7620e9b454b372651be78e
---
M bsc/BSC_Tests.ttcn
M library/Osmocom_VTY_Functions.ttcn
2 files changed, 28 insertions(+), 22 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index a63d536..cda0687 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -3611,33 +3611,31 @@
/* Allow 5,90k only (current default config) */
private function f_allow_amr_rate_5_90k() runs on test_CT {
- f_vty_enter_cfg_msc(BSCVTY, 0);
- f_vty_transceive(BSCVTY, "amr-config 12_2k forbidden");
- f_vty_transceive(BSCVTY, "amr-config 10_2k forbidden");
- f_vty_transceive(BSCVTY, "amr-config 7_95k forbidden");
- f_vty_transceive(BSCVTY, "amr-config 7_40k forbidden");
- f_vty_transceive(BSCVTY, "amr-config 6_70k forbidden");
- f_vty_transceive(BSCVTY, "amr-config 5_90k allowed");
- f_vty_transceive(BSCVTY, "amr-config 5_15k forbidden");
- f_vty_transceive(BSCVTY, "amr-config 4_75k forbidden");
- f_vty_transceive(BSCVTY, "exit");
- f_vty_transceive(BSCVTY, "exit");
+ f_vty_cfg_msc(BSCVTY, 0, {
+ "amr-config 12_2k forbidden",
+ "amr-config 10_2k forbidden",
+ "amr-config 7_95k forbidden",
+ "amr-config 7_40k forbidden",
+ "amr-config 6_70k forbidden",
+ "amr-config 5_90k allowed",
+ "amr-config 5_15k forbidden",
+ "amr-config 4_75k forbidden"
+ });
}
/* Allow 4,75k, 5,90k, 4,70k and 12,2k, which are the most common rates
* ("Config-NB-Code = 1") */
private function f_allow_amr_rate_4_75k_5_90k_7_40k_12_20k() runs on test_CT {
- f_vty_enter_cfg_msc(BSCVTY, 0);
- f_vty_transceive(BSCVTY, "amr-config 12_2k allowed");
- f_vty_transceive(BSCVTY, "amr-config 10_2k forbidden");
- f_vty_transceive(BSCVTY, "amr-config 7_95k forbidden");
- f_vty_transceive(BSCVTY, "amr-config 7_40k allowed");
- f_vty_transceive(BSCVTY, "amr-config 6_70k forbidden");
- f_vty_transceive(BSCVTY, "amr-config 5_90k allowed");
- f_vty_transceive(BSCVTY, "amr-config 5_15k forbidden");
- f_vty_transceive(BSCVTY, "amr-config 4_75k allowed");
- f_vty_transceive(BSCVTY, "exit");
- f_vty_transceive(BSCVTY, "exit");
+ f_vty_cfg_msc(BSCVTY, 0, {
+ "amr-config 12_2k allowed",
+ "amr-config 10_2k forbidden",
+ "amr-config 7_95k forbidden",
+ "amr-config 7_40k allowed",
+ "amr-config 6_70k forbidden",
+ "amr-config 5_90k allowed",
+ "amr-config 5_15k forbidden",
+ "amr-config 4_75k allowed"
+ });
}
testcase TC_assignment_codec_amr_f() runs on test_CT {
diff --git a/library/Osmocom_VTY_Functions.ttcn
b/library/Osmocom_VTY_Functions.ttcn
index a51794f..b291b03 100644
--- a/library/Osmocom_VTY_Functions.ttcn
+++ b/library/Osmocom_VTY_Functions.ttcn
@@ -174,6 +174,14 @@
f_vty_config2(pt, {config_node}, cmd);
}
+function f_vty_cfg_bts(TELNETasp_PT pt, BtsNr bts := 0, rof_charstring cmds) {
+ f_vty_config3(pt, {"network", "bts " & int2str(bts)}, cmds);
+}
+
+function f_vty_cfg_msc(TELNETasp_PT pt, MscNr msc := 0, rof_charstring cmds) {
+ f_vty_config3(pt, {"msc " & int2str(msc)}, cmds);
+}
+
function f_vty_transceive_match(TELNETasp_PT pt, charstring cmd, template
charstring exp_ret) {
var charstring ret := f_vty_transceive_ret(pt, cmd);
if (not match(ret, exp_ret)) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21369
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9f3e485f692acb3d2a7620e9b454b372651be78e
Gerrit-Change-Number: 21369
Gerrit-PatchSet: 3
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: add f_vty_config3(), to run N commands on a sub-node
neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21368 )
Change subject: add f_vty_config3(), to run N commands on a sub-node
..
add f_vty_config3(), to run N commands on a sub-node
f_vty_config2() makes it convenient to enter a specific vty node without
needing to send 'exit'/'end' explicitly. However, to pass multiple
commands on the same node, the VTY would enter and exit the node for
each call of f_vty_config2(). The new f_vty_config3() also allows
multiple commands to be run on that same node without intermediate
exiting.
Change-Id: If969ac645aa82e5a36245d974de2a251633de111
---
M library/Osmocom_VTY_Functions.ttcn
1 file changed, 9 insertions(+), 3 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/library/Osmocom_VTY_Functions.ttcn
b/library/Osmocom_VTY_Functions.ttcn
index 042f244..a51794f 100644
--- a/library/Osmocom_VTY_Functions.ttcn
+++ b/library/Osmocom_VTY_Functions.ttcn
@@ -149,19 +149,25 @@
}
type record of charstring rof_charstring;
-function f_vty_config2(TELNETasp_PT pt, rof_charstring config_nodes,
charstring cmd)
+function f_vty_config3(TELNETasp_PT pt, rof_charstring config_nodes,
rof_charstring cmds)
{
/* enter config mode; enter node */
f_vty_enter_config(pt);
for (var integer i := 0; i < sizeof(config_nodes); i := i+1) {
f_vty_transceive(pt, config_nodes[i]);
}
- /* execute command */
- f_vty_transceive(pt, cmd);
+ /* execute commands */
+ for (var integer i := 0; i < sizeof(cmds); i := i+1) {
+ f_vty_transceive(pt, cmds[i]);
+ }
/* leave config mode */
f_vty_transceive(pt, "end");
}
+function f_vty_config2(TELNETasp_PT pt, rof_charstring config_nodes,
charstring cmd)
+{
+ f_vty_config3(pt, config_nodes, { cmd });
+}
function f_vty_config(TELNETasp_PT pt, charstring config_node, charstring cmd)
{
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21368
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If969ac645aa82e5a36245d974de2a251633de111
Gerrit-Change-Number: 21368
Gerrit-PatchSet: 3
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: bsc: add TC_assignment_codec_amr_startmode_cruft
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21373 ) Change subject: bsc: add TC_assignment_codec_amr_startmode_cruft .. Patch Set 2: Code-Review+2 re-add +2 after adding comment -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I151678f64e680f30f35b6bb2b0036d63efde9f2c Gerrit-Change-Number: 21373 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 30 Nov 2020 15:58:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: bsc: add TC_assignment_codec_amr_startmode_cruft
Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21373 to look at the new patch set (#2). Change subject: bsc: add TC_assignment_codec_amr_startmode_cruft .. bsc: add TC_assignment_codec_amr_startmode_cruft Make sure that when a 'start-mode auto' is set, that the previous start mode setting does not linger in the unused bits. - after I577ff590d7588fd7e3ee4846c7955ab8f84cf2b1, osmo-bsc sets its ICMI bit properly, but passes this test only because it *always* sends smod (start-mode) bits as zero. - in I49691df01745a7c485bf165e897872c35fc4b147, the smod bits are properly sent on RSL, but this test shows that when ICMI becomes zero for 'start-mode auto', the smod bits will remain whatever start-mode was set in the previous osmo-bsc config. Instead, osmo-bsc should clear the smod bits for 'start-mode auto' so that its MultiRate Config does not vary depending on what was previously configured. - in I1ec5bad0bce01cc425ee05ecf70c83ec662a226a, clearing smod is implemented and this test is expected to pass. Change-Id: I151678f64e680f30f35b6bb2b0036d63efde9f2c --- M bsc/BSC_Tests.ttcn 1 file changed, 37 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/21373/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I151678f64e680f30f35b6bb2b0036d63efde9f2c Gerrit-Change-Number: 21373 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: bsc: add TC_assignment_codec_amr_startmode_cruft
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21373 )
Change subject: bsc: add TC_assignment_codec_amr_startmode_cruft
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21373/1/bsc/BSC_Tests.ttcn
File bsc/BSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21373/1/bsc/BSC_Tests.ttcn@3714
PS1, Line 3714: testcase TC_assignment_codec_amr_startmode_cruft() runs on
test_CT {
> in general a short description of the test in the line above is welcome.
forgot, thx
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21373
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I151678f64e680f30f35b6bb2b0036d63efde9f2c
Gerrit-Change-Number: 21373
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Mon, 30 Nov 2020 15:53:26 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
Change in osmo-pcu[master]: Dl TBF: Get rid of LLC UI dummy blocks following other data
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21387 ) Change subject: Dl TBF: Get rid of LLC UI dummy blocks following other data .. Patch Set 3: Code-Review+1 (1 comment) We need a TTCN-3 test case (of course)! https://gerrit.osmocom.org/c/osmo-pcu/+/21387/3/src/encoding.cpp File src/encoding.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/21387/3/src/encoding.cpp@1688 PS3, Line 1688: prev_li = (struct rlc_li_field_egprs *) no need for a line break here -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ifae1a7b2b3dfad8df19585063088ba0df2749c8f Gerrit-Change-Number: 21387 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Mon, 30 Nov 2020 15:53:03 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: AMR start-mode auto: send smod bits as zero
neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/21376 )
Change subject: AMR start-mode auto: send smod bits as zero
..
AMR start-mode auto: send smod bits as zero
When ICMI becomes zero for 'start-mode auto', the smod bits will remain
whatever start-mode was set in the previous osmo-bsc config. Instead, osmo-bsc
should clear the smod bits for 'start-mode auto' so that its MultiRate Config
does not vary depending on what was previously configured.
Change-Id: I1ec5bad0bce01cc425ee05ecf70c83ec662a226a
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
neels: Looks good to me, approved
dexter: Looks good to me, but someone else must approve
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 5022fe1..d8e9682 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -4199,9 +4199,10 @@
}
}
- if (argv[0][0] == 'a' || num == 0)
+ if (argv[0][0] == 'a' || num == 0) {
mr_conf->icmi = 0;
- else {
+ mr_conf->smod = 0;
+ } else {
mr_conf->icmi = 1;
if (num < atoi(argv[0]))
mr_conf->smod = num - 1;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21376
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1ec5bad0bce01cc425ee05ecf70c83ec662a226a
Gerrit-Change-Number: 21376
Gerrit-PatchSet: 3
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-bsc[master]: fix AMR start-mode auto: reflect proper ICMI in MultiRate Config IE
neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/21372 )
Change subject: fix AMR start-mode auto: reflect proper ICMI in MultiRate
Config IE
..
fix AMR start-mode auto: reflect proper ICMI in MultiRate Config IE
Send the proper ICMI value, instead of always sending ICMI=1 regardless
of the AMR start-mode setting.
To avoid test fallout from the fix, we should first merge
osmo-ttcn3-hacks I4cff01c37d5c7e301e9a01f773b7e009a789519b
Change-Id: I577ff590d7588fd7e3ee4846c7955ab8f84cf2b1
---
M src/osmo-bsc/lchan_fsm.c
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, but someone else must approve
neels: Looks good to me, approved
dexter: Looks good to me, but someone else must approve
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index e97c1ba..0ca7f2c 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -467,6 +467,7 @@
mr = >mr_full;
else
mr = >mr_half;
+ mr_conf_bts = (struct gsm48_multi_rate_conf *)mr->gsm48_ie;
if (lchan->activate.info.activ_for == FOR_VTY)
/* If the channel is activated manually from VTY, then there is
no
@@ -503,7 +504,6 @@
* if the channel activation was triggerd by the VTY, do not
* filter anything (see also comment above) */
if (lchan->activate.info.activ_for != FOR_VTY) {
- mr_conf_bts = (struct gsm48_multi_rate_conf *)mr->gsm48_ie;
rc_rate = calc_amr_rate_intersection(_conf_filtered,
mr_conf_bts, _conf_filtered);
if (rc_rate < 0) {
LOG_LCHAN(lchan, LOGL_ERROR,
@@ -512,6 +512,10 @@
}
}
+ /* Set the ICMI according to the BTS. Above
gsm48_mr_cfg_from_gsm0808_sc_cfg() always sets ICMI = 1, which
+* carried through all of the above rate intersections. */
+ mr_conf_filtered.icmi = mr_conf_bts->icmi;
+
/* Proceed with the generation of the multirate configuration IE
* (MS and BTS) */
rc = gsm48_multirate_config(lchan->mr_ms_lv, _conf_filtered,
mr->ms_mode, mr->num_modes);
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21372
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I577ff590d7588fd7e3ee4846c7955ab8f84cf2b1
Gerrit-Change-Number: 21372
Gerrit-PatchSet: 3
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-bsc[master]: AMR start-mode: send proper smod bits
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21375 ) Change subject: AMR start-mode: send proper smod bits .. AMR start-mode: send proper smod bits So far, the smod bits reflecting the start mode never made it to the MultiRate Config IE: gsm48_mr_cfg_from_gsm0808_sc_cfg() always sets them to zero, and the mode filtering fails to carry the BTS set bits. Set smod bits according to BTS config after the filtering of available modes. Change-Id: I49691df01745a7c485bf165e897872c35fc4b147 --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve neels: Looks good to me, approved dexter: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 0ca7f2c..1903645 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -515,6 +515,7 @@ /* Set the ICMI according to the BTS. Above gsm48_mr_cfg_from_gsm0808_sc_cfg() always sets ICMI = 1, which * carried through all of the above rate intersections. */ mr_conf_filtered.icmi = mr_conf_bts->icmi; + mr_conf_filtered.smod = mr_conf_bts->smod; /* Proceed with the generation of the multirate configuration IE * (MS and BTS) */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I49691df01745a7c485bf165e897872c35fc4b147 Gerrit-Change-Number: 21375 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-bsc[master]: AMR start-mode auto: send smod bits as zero
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21376 ) Change subject: AMR start-mode auto: send smod bits as zero .. Patch Set 2: Code-Review+2 combine -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21376 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1ec5bad0bce01cc425ee05ecf70c83ec662a226a Gerrit-Change-Number: 21376 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 30 Nov 2020 15:49:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: AMR start-mode: send proper smod bits
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21375 ) Change subject: AMR start-mode: send proper smod bits .. Patch Set 2: Code-Review+2 combine -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I49691df01745a7c485bf165e897872c35fc4b147 Gerrit-Change-Number: 21375 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 30 Nov 2020 15:49:12 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: fix AMR start-mode auto: reflect proper ICMI in MultiRate Config IE
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21372 ) Change subject: fix AMR start-mode auto: reflect proper ICMI in MultiRate Config IE .. Patch Set 2: Code-Review+2 combine -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I577ff590d7588fd7e3ee4846c7955ab8f84cf2b1 Gerrit-Change-Number: 21372 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 30 Nov 2020 15:48:39 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: gbproxy: Add NSE peer that can have multiple gbproxy_peers
Hello Jenkins Builder, pespin, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21406 to look at the new patch set (#5). Change subject: gbproxy: Add NSE peer that can have multiple gbproxy_peers .. gbproxy: Add NSE peer that can have multiple gbproxy_peers We want this level of indirection to support multiple BVCs per NSE. The current code assumes that an NSE only has one BVC which breaks messages on the signalling BVC which should only be sent once to an NSE regardless of the number of BVCs it contains. Change-Id: I97cc6c8f8c0f1b91577ab8f679c4ae217cc88076 Related: SYS#5226 --- M include/osmocom/sgsn/gb_proxy.h M src/gbproxy/gb_proxy.c M src/gbproxy/gb_proxy_ctrl.c M src/gbproxy/gb_proxy_patch.c M src/gbproxy/gb_proxy_peer.c M src/gbproxy/gb_proxy_tlli.c M src/gbproxy/gb_proxy_vty.c M tests/gbproxy/gbproxy_test.c M tests/gbproxy/gbproxy_test.ok 9 files changed, 495 insertions(+), 285 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/06/21406/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I97cc6c8f8c0f1b91577ab8f679c4ae217cc88076 Gerrit-Change-Number: 21406 Gerrit-PatchSet: 5 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: newpatchset
Change in osmocom-bb[master]: trxcon/scheduler: clarify Measurement results padding
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/21414 ) Change subject: trxcon/scheduler: clarify Measurement results padding .. trxcon/scheduler: clarify Measurement results padding Table 10.5.2.20.0 "Measurement Results Contents" in 3GPP TS 44.018 is clear on what should be used as padding - '0**', i.e. zeroes. Change-Id: I4db6845c98aded10291134f416da98fd0f4f58e3 --- M src/host/trxcon/sched_prim.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/14/21414/1 diff --git a/src/host/trxcon/sched_prim.c b/src/host/trxcon/sched_prim.c index fc0f05d..e5204ba 100644 --- a/src/host/trxcon/sched_prim.c +++ b/src/host/trxcon/sched_prim.c @@ -144,10 +144,10 @@ /* LAPDm header */ 0x01, 0x03, 0x49, - /* Measurement report */ + /* Measurement report (see 3GPP TS 44.018, section 10.5.2.20) */ 0x06, 0x15, 0x36, 0x36, 0x01, 0xC0, - /* TODO: Padding? Randomize if so */ + /* 0** -- Padding with zeroes */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, }; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/21414 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4db6845c98aded10291134f416da98fd0f4f58e3 Gerrit-Change-Number: 21414 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmocom-bb[master]: trxcon/scheduler: clarify the content of Measurement results
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/21415 ) Change subject: trxcon/scheduler: clarify the content of Measurement results .. trxcon/scheduler: clarify the content of Measurement results Change-Id: I26546dcbc853166e351d00260936b1b9d584ae03 --- M src/host/trxcon/sched_prim.c 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/15/21415/1 diff --git a/src/host/trxcon/sched_prim.c b/src/host/trxcon/sched_prim.c index e5204ba..f4f5e40 100644 --- a/src/host/trxcon/sched_prim.c +++ b/src/host/trxcon/sched_prim.c @@ -144,8 +144,21 @@ /* LAPDm header */ 0x01, 0x03, 0x49, - /* Measurement report (see 3GPP TS 44.018, section 10.5.2.20) */ - 0x06, 0x15, 0x36, 0x36, 0x01, 0xC0, + /* RR Management messages, Measurement Report */ + 0x06, 0x15, + + /* Measurement results (see 3GPP TS 44.018, section 10.5.2.20): +* 0... = BA-USED: 0 +* .0.. = DTX-USED: DTX was not used +* ..11 0110 = RXLEV-FULL-SERVING-CELL: -57 <= x < -56 dBm (54) +* 0... = 3G-BA-USED: 0 +* .0.. = MEAS-VALID: The measurement results are valid +* ..11 0110 = RXLEV-SUB-SERVING-CELL: -57 <= x < -56 dBm (54) +* 0... = SI23_BA_USED: 0 +* .000 = RXQUAL-FULL-SERVING-CELL: BER < 0.2%, Mean value 0.14% (0) +* 000. = RXQUAL-SUB-SERVING-CELL: BER < 0.2%, Mean value 0.14% (0) +* ...1 11.. = NO-NCELL-M: Neighbour cell information not available */ + 0x36, 0x36, 0x01, 0xc0, /* 0** -- Padding with zeroes */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/21415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I26546dcbc853166e351d00260936b1b9d584ae03 Gerrit-Change-Number: 21415 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmocom-bb[master]: trxcon/scheduler: invalidate hard-coded Measurement results
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/21416 ) Change subject: trxcon/scheduler: invalidate hard-coded Measurement results .. trxcon/scheduler: invalidate hard-coded Measurement results This is what trxcon sends to the network before the first SACCH block is received from the higher layers. The indicated values are of course invalid because they're hard-coded. According to 3GPP TS 44.018, table 10.5.2.20.1: 0 The measurement results are valid 1 The measurement results are not valid Change-Id: I7da767e146aec7cef1de71e4d735d6a02b6c5642 Related: SYS#4918 --- M src/host/trxcon/sched_prim.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/16/21416/1 diff --git a/src/host/trxcon/sched_prim.c b/src/host/trxcon/sched_prim.c index f4f5e40..9473320 100644 --- a/src/host/trxcon/sched_prim.c +++ b/src/host/trxcon/sched_prim.c @@ -152,13 +152,13 @@ * .0.. = DTX-USED: DTX was not used * ..11 0110 = RXLEV-FULL-SERVING-CELL: -57 <= x < -56 dBm (54) * 0... = 3G-BA-USED: 0 -* .0.. = MEAS-VALID: The measurement results are valid +* .1.. = MEAS-VALID: The measurement results are not valid * ..11 0110 = RXLEV-SUB-SERVING-CELL: -57 <= x < -56 dBm (54) * 0... = SI23_BA_USED: 0 * .000 = RXQUAL-FULL-SERVING-CELL: BER < 0.2%, Mean value 0.14% (0) * 000. = RXQUAL-SUB-SERVING-CELL: BER < 0.2%, Mean value 0.14% (0) * ...1 11.. = NO-NCELL-M: Neighbour cell information not available */ - 0x36, 0x36, 0x01, 0xc0, + 0x36, 0x76, 0x01, 0xc0, /* 0** -- Padding with zeroes */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/21416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7da767e146aec7cef1de71e4d735d6a02b6c5642 Gerrit-Change-Number: 21416 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmo-sgsn[master]: gbproxy: Remove test testing NSVCI change
daniel has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/21413 )
Change subject: gbproxy: Remove test testing NSVCI change
..
gbproxy: Remove test testing NSVCI change
Testing this here doesn't make much sense since ns2.
Change-Id: Ic1d7e646e633c9fa62812f5005ed10c0108a06f2
Related: SYS#5226
---
M tests/gbproxy/gbproxy_test.c
M tests/gbproxy/gbproxy_test.ok
2 files changed, 2 insertions(+), 255 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/13/21413/1
diff --git a/tests/gbproxy/gbproxy_test.c b/tests/gbproxy/gbproxy_test.c
index 76fc000..78fa8cb 100644
--- a/tests/gbproxy/gbproxy_test.c
+++ b/tests/gbproxy/gbproxy_test.c
@@ -1309,7 +1309,7 @@
{
struct gprs_ns2_inst *nsi = gprs_ns2_instantiate(tall_sgsn_ctx,
gprs_ns2_callback, );
uint16_t bss_nsei[2] = {0x1000, 0x2000};
- uint16_t bvci[4] = {0x1002, 0x2002, 0x3002, 0x4002};
+ uint16_t bvci[4] = {0x1002, 0x2002, 0x3002};
gbcfg.nsi = nsi;
gbcfg.nsip_sgsn_nsei = SGSN_NSEI;
@@ -1381,45 +1381,6 @@
send_ns_unitdata(nsi, NULL, bss_nsei[0], bvci[2], (uint8_t *)"", 0);
send_ns_unitdata(nsi, NULL, SGSN_NSEI, bvci[2], (uint8_t *)"", 0);
- printf("--- Change NSVCI ---\n\n");
-
- setup_ns(nsi, bss_nsei[1]);
-
- printf("--- Setup BVCI 1 ---\n\n");
-
- setup_bssgp(nsi, bss_nsei[1], bvci[0]);
- send_bssgp_reset_ack(nsi, SGSN_NSEI, bvci[0]);
- dump_peers(stdout, 0, 0, );
-
- printf("--- Setup BVCI 4 ---\n\n");
-
- setup_bssgp(nsi, bss_nsei[1], bvci[3]);
- send_bssgp_reset_ack(nsi, SGSN_NSEI, bvci[3]);
- dump_peers(stdout, 0, 0, );
-
- printf("--- Send message from BSS 1 to SGSN and back, BVCI 1 ---\n\n");
-
- send_ns_unitdata(nsi, NULL, bss_nsei[1], bvci[0], (uint8_t *)"", 0);
- send_ns_unitdata(nsi, NULL, SGSN_NSEI, bvci[0], (uint8_t *)"", 0);
-
- printf("--- Send message from BSS 1 to SGSN and back, BVCI 2 "
- " (should fail) ---\n\n");
-
- send_ns_unitdata(nsi, NULL, bss_nsei[1], bvci[1], (uint8_t *)"", 0);
- dump_peers(stdout, 0, 0, );
- send_ns_unitdata(nsi, NULL, SGSN_NSEI, bvci[1], (uint8_t *)"", 0);
- dump_peers(stdout, 0, 0, );
-
- printf("--- Send message from BSS 1 to SGSN and back, BVCI 3 ---\n\n");
-
- send_ns_unitdata(nsi, NULL, bss_nsei[1], bvci[2], (uint8_t *)"", 0);
- send_ns_unitdata(nsi, NULL, SGSN_NSEI, bvci[2], (uint8_t *)"", 0);
-
- printf("--- Send message from BSS 1 to SGSN and back, BVCI 4 ---\n\n");
-
- send_ns_unitdata(nsi, NULL, bss_nsei[1], bvci[3], (uint8_t *)"", 0);
- send_ns_unitdata(nsi, NULL, SGSN_NSEI, bvci[3], (uint8_t *)"", 0);
-
dump_global(stdout, 0);
dump_peers(stdout, 0, 0, );
diff --git a/tests/gbproxy/gbproxy_test.ok b/tests/gbproxy/gbproxy_test.ok
index 6f20f12..74cedb3 100644
--- a/tests/gbproxy/gbproxy_test.ok
+++ b/tests/gbproxy/gbproxy_test.ok
@@ -654,227 +654,13 @@
Message for BSS (NSEI=8192 BVCI=12290):
[L2]> [L3]>
Change NSVCI ---
-
-Setup NS-VC: NSEI 0x2000(8192)
-
-NS2 CALLBACK, prim 2, bvci 0x
-
Setup BVCI 1 ---
-
-Setup BSSGP: BVCI 0x1002(4098)
-
-PROCESSING BVC_RESET from NSEI 8192
-22 04 82 10 02 07 81 08 08 88 11 22 33 40 50 60 10 00
-
-NS2 CALLBACK, prim 0, msg length 18, bvci 0x
-22 04 82 10 02 07 81 08 08 88 11 22 33 40 50 60 10 00
-
-NS2 UD REQUEST, prim 0, msg length 18, bvci 0x
-22 04 82 10 02 07 81 08 08 88 11 22 33 40 50 60 10 00
-
-Message for SGSN (NSEI=256 BVCI=0):
-[L2]> [L3]> 22 04 82 10 02 07 81 08 08 88 11 22 33 40 50 60 10 00
-
-PROCESSING BVC_RESET_ACK from NSEI 256
-23 04 82 10 02
-
-NS2 CALLBACK, prim 0, msg length 5, bvci 0x
-23 04 82 10 02
-
-NS2 UD REQUEST, prim 0, msg length 5, bvci 0x
-23 04 82 10 02
-
-Message for BSS (NSEI=8192 BVCI=0):
-[L2]> [L3]> 23 04 82 10 02
-
-Peers:
- NSEI 8192, BVCI 12290, not blocked, RAI 112-332-16464-96
-NSEI mismatch : 1
-TLLI-Cache: 0
- NSEI 4096, BVCI 8194, not blocked, RAI 112-332-16464-96
-NSEI mismatch : 1
-TLLI-Cache: 0
- NSEI 8192, BVCI 4098, not blocked, RAI 112-332-16464-96
-NSEI mismatch : 1
-TLLI-Cache: 0
Setup BVCI 4 ---
-
-Setup BSSGP: BVCI 0x4002(16386)
-
-PROCESSING BVC_RESET from NSEI 8192
-22 04 82 40 02 07 81 08 08 88 11 22 33 40 50 60 10 00
-
-NS2 CALLBACK, prim 0, msg length 18, bvci 0x
-22 04 82 40 02 07 81 08 08 88 11 22 33 40 50 60 10 00
-
-NS2 UD REQUEST, prim 0, msg length 18, bvci 0x
-22 04 82 40 02 07 81 08 08 88 11 22 33 40 50 60 10 00
-
-Message for SGSN (NSEI=256 BVCI=0):
-[L2]> [L3]> 22 04 82 40 02 07 81 08 08 88 11 22 33 40 50 60 10 00
-
-PROCESSING BVC_RESET_ACK from NSEI 256
-23 04 82 40 02
-
-NS2 CALLBACK, prim 0, msg length 5, bvci 0x
-23 04 82 40 02
-
-NS2 UD REQUEST, prim 0, msg length 5, bvci 0x
-23 04 82 40 02
-
-Message
Change in osmo-sgsn[master]: gbproxy: Ensure BVC0 is reset before handling PtP BVCs
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21410 to look at the new patch set (#2). Change subject: gbproxy: Ensure BVC0 is reset before handling PtP BVCs .. gbproxy: Ensure BVC0 is reset before handling PtP BVCs Change-Id: I9c67f973f7bca00e8eb22a024ef2282c007dd84b Related: SYS#5226 --- M src/gbproxy/gb_proxy.c M tests/gbproxy/gbproxy_test.c M tests/gbproxy/gbproxy_test.ok 3 files changed, 125 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/10/21410/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9c67f973f7bca00e8eb22a024ef2282c007dd84b Gerrit-Change-Number: 21410 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-sgsn[master]: gbproxy: Add NSE peer that can have multiple gbproxy_peers
Hello Jenkins Builder, pespin, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21406 to look at the new patch set (#4). Change subject: gbproxy: Add NSE peer that can have multiple gbproxy_peers .. gbproxy: Add NSE peer that can have multiple gbproxy_peers We want this level of indirection to support multiple BVCs per NSE. The current code assumes that an NSE only has one BVC which breaks messages on the signalling BVC which should only be sent once to an NSE regardless of the number of BVCs it contains. Change-Id: I97cc6c8f8c0f1b91577ab8f679c4ae217cc88076 Related: SYS#5226 --- M include/osmocom/sgsn/gb_proxy.h M src/gbproxy/gb_proxy.c M src/gbproxy/gb_proxy_ctrl.c M src/gbproxy/gb_proxy_patch.c M src/gbproxy/gb_proxy_peer.c M src/gbproxy/gb_proxy_tlli.c M src/gbproxy/gb_proxy_vty.c M tests/gbproxy/gbproxy_test.c M tests/gbproxy/gbproxy_test.ok 9 files changed, 499 insertions(+), 290 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/06/21406/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I97cc6c8f8c0f1b91577ab8f679c4ae217cc88076 Gerrit-Change-Number: 21406 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: newpatchset
Change in osmo-pcu[master]: Dl TBF: Get rid of LLC UI dummy blocks following other data
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/21387 to look at the new patch set (#3). Change subject: Dl TBF: Get rid of LLC UI dummy blocks following other data .. Dl TBF: Get rid of LLC UI dummy blocks following other data According to: * 3GPP TS 44.060 version 16.0.0 "9.3.1a Delayed release of downlink Temporary Block Flow" * 3GPP TS 44.064 version 16.0.0 "6.4.2.2 Unconfirmed Information (UI) Dummy command" LLC UI Dummy frames are to be used when there no more data to send, only in order to delay the release of a TBF. Hence, while not incorrect per se, makes no sense to send those LLC UI Dummy frames inserted into rlcmac blocks which already contain other LLC frames, since the MS in that case is already being kept active. It only makes sense to send those LLC UI Dummy frames when we have nothing else to send, that is, alone inside a RLCMAC block without other LLC frames. Related: OS#4849 Change-Id: Ifae1a7b2b3dfad8df19585063088ba0df2749c8f --- M src/encoding.cpp M src/encoding.h M src/tbf_dl.cpp M tests/tbf/TbfTest.err 4 files changed, 171 insertions(+), 198 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/87/21387/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ifae1a7b2b3dfad8df19585063088ba0df2749c8f Gerrit-Change-Number: 21387 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in docker-playground[master]: Add ttcn3-gbproxy-test-fr for FR related testing
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/docker-playground/+/21412 )
Change subject: Add ttcn3-gbproxy-test-fr for FR related testing
..
Add ttcn3-gbproxy-test-fr for FR related testing
Testing FR support in osmo-gbproxy is a bit more complicated
as it involves the "hdlc" net-devices privded by the hdlc_fr.ko
kernel module.
So we need to
* run on a host with actual hdlc net-devices (e.g. dahdi_dyamic_loc)
* move those net-devices into the containers after starting them
* wait for the net-devices to appear in the containers before starting
either gbproxy or the test suite
Change-Id: Id4b52877db53cb6e59f6d0d3f754aaae633949e8
---
A ttcn3-gbproxy-test-fr/GBProxy_Tests.cfg
A ttcn3-gbproxy-test-fr/jenkins.sh
A ttcn3-gbproxy-test-fr/netdev-to-docker.sh
A ttcn3-gbproxy-test-fr/osmo-gbproxy.cfg
M ttcn3-gbproxy-test/Dockerfile
A ttcn3-gbproxy-test/docker-entrypoint.sh
A ttcn3-gbproxy-test/pipework
7 files changed, 776 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground
refs/changes/12/21412/1
diff --git a/ttcn3-gbproxy-test-fr/GBProxy_Tests.cfg
b/ttcn3-gbproxy-test-fr/GBProxy_Tests.cfg
new file mode 100644
index 000..adab61a
--- /dev/null
+++ b/ttcn3-gbproxy-test-fr/GBProxy_Tests.cfg
@@ -0,0 +1,100 @@
+[ORDERED_INCLUDE]
+# Common configuration, shared between test suites
+"/osmo-ttcn3-hacks/Common.cfg"
+# testsuite specific configuration, not expected to change
+"/osmo-ttcn3-hacks/gbproxy/GBProxy_Tests.default"
+
+# Local configuration below
+
+[LOGGING]
+
+[TESTPORT_PARAMETERS]
+*.GBPVTY.CTRL_HOSTNAME := "172.18.25.10"
+
+[MODULE_PARAMETERS]
+GBProxy_Tests.mp_nsconfig_sgsn := {
+ {
+ nsvc := {
+ {
+ provider := {
+ ip := {
+ address_family := AF_INET,
+ local_ip := "172.18.25.103",
+ local_udp_port := 23000,
+ remote_ip := "172.18.25.10"
+ }
+ }
+ }
+ }
+ }
+}
+GBProxy_Tests.mp_nsconfig_pcu := {
+ {
+ nsei := 1,
+ role_sgsn := false,
+ handle_sns := false,
+ nsvc := {
+ {
+ provider := {
+ fr := {
+ netdev := "hdlc1",
+ dlci := 16
+ }
+ },
+ nsvci := 1
+ }, {
+ provider := {
+ fr := {
+ netdev := "hdlc2",
+ dlci := 17
+ }
+ },
+ nsvci := 2
+ }, {
+ provider := {
+ fr := {
+ netdev := "hdlc3",
+ dlci := 18
+ }
+ },
+ nsvci := 3
+ }, {
+ provider := {
+ fr := {
+ netdev := "hdlc4",
+ dlci := 19
+ }
+ },
+ nsvci := 4
+ }
+ }
+ }
+}
+
+GBProxy_Tests.mp_gbconfigs := {
+ {
+ nsei := 1,
+ sgsn_role := false,
+ bvc := {
+ {
+ bvci := 196,
+ cell_id := {
+ ra_id := {
+ lai := {
+ mcc_mnc := '262F42'H,
+ lac := 13135
+ },
+ rac := 0
+ },
+ cell_id := 20960
+ },
+ depth := BSSGP_DECODE_DEPTH_BSSGP
+ }
+ }
+ }
+};
+
+[MAIN_CONTROLLER]
+
+[EXECUTE]
+GBProxy_Tests.control
diff --git
Change in docker-playground[master]: osmo-gbproxy-master (derived from osmo-sgsn-master)
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/docker-playground/+/21411 )
Change subject: osmo-gbproxy-master (derived from osmo-sgsn-master)
..
osmo-gbproxy-master (derived from osmo-sgsn-master)
Using a separate container will allow us to do gbproxy specific things
like waiting for physical net-devices to show up in the docker netns
before actually starting the osmo-gbproxy executable
Change-Id: I5e6351055ac9430f13e43291cf2a9d52683fe6bf
---
A osmo-gbproxy-master/Dockerfile
A osmo-gbproxy-master/Makefile
A osmo-gbproxy-master/docker-entrypoint.sh
A osmo-gbproxy-master/osmo-gbproxy.cfg
A osmo-gbproxy-master/pipework
5 files changed, 542 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground
refs/changes/11/21411/1
diff --git a/osmo-gbproxy-master/Dockerfile b/osmo-gbproxy-master/Dockerfile
new file mode 100644
index 000..8661ec9
--- /dev/null
+++ b/osmo-gbproxy-master/Dockerfile
@@ -0,0 +1,15 @@
+ARGUSER
+ARGDISTRO
+FROM $USER/osmo-sgsn-master
+
+COPY osmo-gbproxy.cfg/data/osmo-gbproxy.cfg
+
+# work-around for stupid docker not being able to properly deal with host
netdevices or start
+# containers in pre-existing netns
+COPY pipework/usr/bin/pipework
+COPY docker-entrypoint.sh/docker-entrypoint.sh
+
+WORKDIR/data
+CMD["/docker-entrypoint.sh"]
+
+EXPOSE 23000/udp 4246/tcp 4263/tcp
diff --git a/osmo-gbproxy-master/Makefile b/osmo-gbproxy-master/Makefile
new file mode 100644
index 000..1614f9a
--- /dev/null
+++ b/osmo-gbproxy-master/Makefile
@@ -0,0 +1,3 @@
+RUN_ARGS?=--rm --network sigtran --ip 172.18.0.21 -v gbproxy-vol:/data
+
+include ../make/Makefile
diff --git a/osmo-gbproxy-master/docker-entrypoint.sh
b/osmo-gbproxy-master/docker-entrypoint.sh
new file mode 100755
index 000..72c4e8c
--- /dev/null
+++ b/osmo-gbproxy-master/docker-entrypoint.sh
@@ -0,0 +1,9 @@
+#!/bin/bash
+set -e
+set -x
+
+if [[ -n ${WAIT_FOR_NETDEV:-} ]]; then
+ /usr/bin/pipework --wait -i ${WAIT_FOR_NETDEV}
+fi
+
+/usr/local/bin/osmo-gbproxy -c /data/osmo-gbproxy.cfg >/data/osmo-gbproxy.log
2>&1
diff --git a/osmo-gbproxy-master/osmo-gbproxy.cfg
b/osmo-gbproxy-master/osmo-gbproxy.cfg
new file mode 100644
index 000..29f698f
--- /dev/null
+++ b/osmo-gbproxy-master/osmo-gbproxy.cfg
@@ -0,0 +1,26 @@
+!
+! Osmocom Gb Proxy (0.9.0.404-6463) configuration saved from vty
+!!
+!
+line vty
+ no login
+!
+gbproxy
+ sgsn nsei 101
+ns
+ nse 101 nsvci 101
+ nse 101 remote-role sgsn
+ nse 101 encapsulation udp
+ nse 101 remote-ip 192.168.100.239
+ nse 101 remote-port
+ timer tns-block 3
+ timer tns-block-retries 3
+ timer tns-reset 3
+ timer tns-reset-retries 3
+ timer tns-test 30
+ timer tns-alive 3
+ timer tns-alive-retries 10
+ encapsulation framerelay-gre enabled 0
+ encapsulation framerelay-gre local-ip 0.0.0.0
+ encapsulation udp local-ip 127.0.0.100
+ encapsulation udp local-port 23000
diff --git a/osmo-gbproxy-master/pipework b/osmo-gbproxy-master/pipework
new file mode 100755
index 000..97ce66b
--- /dev/null
+++ b/osmo-gbproxy-master/pipework
@@ -0,0 +1,489 @@
+#!/bin/sh
+# This code should (try to) follow Google's Shell Style Guide
+# (https://google.github.io/styleguide/shell.xml)
+set -e
+
+case "$1" in
+ --wait)
+WAIT=1
+;;
+ --direct-phys)
+DIRECT_PHYS=1
+shift
+;;
+esac
+
+IFNAME=$1
+
+# default value set further down if not set here
+CONTAINER_IFNAME=
+if [ "$2" = "-i" ]; then
+ CONTAINER_IFNAME=$3
+ shift 2
+fi
+
+if [ "$2" = "-l" ]; then
+ LOCAL_IFNAME=$3
+ shift 2
+fi
+
+#inet or inet6
+FAMILY_FLAG="-4"
+if [ "$2" = "-a" ]; then
+ FAMILY_FLAG="-$3"
+ shift 2
+fi
+
+GUESTNAME=$2
+IPADDR=$3
+MACADDR=$4
+
+case "$MACADDR" in
+ *@*)
+VLAN="${MACADDR#*@}"
+VLAN="${VLAN%%@*}"
+MACADDR="${MACADDR%%@*}"
+;;
+ *)
+VLAN=
+;;
+esac
+
+# did they ask to generate a custom MACADDR?
+# generate the unique string
+case "$MACADDR" in
+ U:*)
+macunique="${MACADDR#*:}"
+# now generate a 48-bit hash string from $macunique
+MACADDR=$(echo $macunique|md5sum|sed
's/^\(..\)\(..\)\(..\)\(..\)\(..\).*$/02:\1:\2:\3:\4:\5/')
+ ;;
+esac
+
+
+[ "$IPADDR" ] || [ "$WAIT" ] || {
+ echo "Syntax:"
+ echo "pipework [-i containerinterface] [-l
localinterfacename] [-a addressfamily]
/[@default_gateway] [macaddr][@vlan]"
+ echo "pipework [-i containerinterface] [-l
localinterfacename] dhcp [macaddr][@vlan]"
+ echo "pipework mac: [-i containerinterface] [-l
localinterfacename] [-a addressfamily]
/[@default_gateway] [macaddr][@vlan]"
+ echo "pipework mac: [-i containerinterface] [-l
localinterfacename] dhcp [macaddr][@vlan]"
+ echo "pipework route "
+ echo "pipework rule "
+ echo "pipework tc "
+ echo "pipework --wait [-i containerinterface]"
+ exit 1
+}
+
+# Succeed if the given utility is installed. Fail otherwise.
+# For explanations about
Change in osmo-bts[master]: l1sap: add repeated uplink SACCH
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21185 ) Change subject: l1sap: add repeated uplink SACCH .. Patch Set 5: (1 comment) (ensure all comments are sent) https://gerrit.osmocom.org/c/osmo-bts/+/21185/4/src/osmo-bts-trx/sched_lchan_xcch.c File src/osmo-bts-trx/sched_lchan_xcch.c: https://gerrit.osmocom.org/c/osmo-bts/+/21185/4/src/osmo-bts-trx/sched_lchan_xcch.c@37 PS4, Line 37: /* Add two arrays of sbits */ : static void add_sbits(sbit_t *current, const sbit_t *previous) > I believe addition is fine, since it could be perceived as a diversity scheme > and the individual sof […] See also Patchset 5 for the non saturated approach. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7e4cc33cc010866e41e3b594351a7f7bf93e08ac Gerrit-Change-Number: 21185 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: tnt Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 30 Nov 2020 14:47:22 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen Comment-In-Reply-To: laforge Comment-In-Reply-To: dexter Gerrit-MessageType: comment
Change in osmo-bsc[master]: ipaccess-proxy: generate coredump and exit upon SIGABRT received
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/21346 )
Change subject: ipaccess-proxy: generate coredump and exit upon SIGABRT received
..
ipaccess-proxy: generate coredump and exit upon SIGABRT received
Previous code relied on abort() switching sigaction to SIG_FDL +
retriggering SIGABRT in case the signal handler returns, which would
then generate the coredump + terminate the process.
However, if a SIGABRT is received from somewhere else (kill -SIGABRT),
then the process would print the talloc report and continue running,
which is not desired.
Change-Id: Iff920ff3dbeb48bd871b7578470f27fe9d0f9516
Fixes: OS#4865
---
M src/ipaccess/ipaccess-proxy.c
1 file changed, 13 insertions(+), 5 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/ipaccess/ipaccess-proxy.c b/src/ipaccess/ipaccess-proxy.c
index 47465b4..d676038 100644
--- a/src/ipaccess/ipaccess-proxy.c
+++ b/src/ipaccess/ipaccess-proxy.c
@@ -1086,14 +1086,22 @@
return ret;
}
-static void signal_handler(int signal)
+static void signal_handler(int signum)
{
- fprintf(stdout, "signal %u received\n", signal);
+ fprintf(stdout, "signal %u received\n", signum);
- switch (signal) {
+ switch (signum) {
case SIGABRT:
- /* in case of abort, we want to obtain a talloc report
-* and then return to the caller, who will abort the process */
+ /* in case of abort, we want to obtain a talloc report and
+* then run default SIGABRT handler, who will generate coredump
+* and abort the process. abort() should do this for us after we
+* return, but program wouldn't exit if an external SIGABRT is
+* received.
+*/
+ talloc_report_full(tall_bsc_ctx, stderr);
+ signal(SIGABRT, SIG_DFL);
+ raise(SIGABRT);
+ break;
case SIGUSR1:
talloc_report_full(tall_bsc_ctx, stderr);
break;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21346
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iff920ff3dbeb48bd871b7578470f27fe9d0f9516
Gerrit-Change-Number: 21346
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-bsc[master]: ipaccess-proxy: generate coredump and exit upon SIGABRT received
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21346 ) Change subject: ipaccess-proxy: generate coredump and exit upon SIGABRT received .. Patch Set 2: Code-Review+2 Merging myself, I already merged tons of similar patches in different projects. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21346 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iff920ff3dbeb48bd871b7578470f27fe9d0f9516 Gerrit-Change-Number: 21346 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 30 Nov 2020 14:32:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: gbproxy: Fix log messages in timeout situations
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21402 )
Change subject: gbproxy: Fix log messages in timeout situations
..
gbproxy: Fix log messages in timeout situations
Printing an unbound 'rx' variable when nothing was received due to
timeout is somehow not really useful. Print what we expected to
receive.
Change-Id: Idab8bed06281468164006682aa6b4c2c3e236880
---
M gbproxy/GBProxy_Tests.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn
index b708fa0..2120fa7 100644
--- a/gbproxy/GBProxy_Tests.ttcn
+++ b/gbproxy/GBProxy_Tests.ttcn
@@ -571,7 +571,7 @@
mtc.stop;
}
[] T.timeout {
- setverdict(fail, "Timeout waiting for BSSGP on SGSN side: ",
rx);
+ setverdict(fail, "Timeout waiting for BSSGP on SGSN side: ",
exp_rx);
mtc.stop;
}
}
@@ -606,7 +606,7 @@
mtc.stop;
}
[] T.timeout {
- setverdict(fail, "Timeout waiting for BSSGP on PCU side: ", rx);
+ setverdict(fail, "Timeout waiting for BSSGP on PCU side: ",
exp_rx);
mtc.stop;
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21402
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Idab8bed06281468164006682aa6b4c2c3e236880
Gerrit-Change-Number: 21402
Gerrit-PatchSet: 2
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-pcu[master]: Implement downgrade to DL MCS1-4 when USF for GPRS_only MS
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21179 ) Change subject: Implement downgrade to DL MCS1-4 when USF for GPRS_only MS .. Patch Set 5: 10 days passed since I submitted last version. Can we merge? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21179 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9af23e175435fe9ae7b0e4119ad52fcd4707b9ca Gerrit-Change-Number: 21179 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Comment-Date: Mon, 30 Nov 2020 14:31:05 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_mcs_max_dl
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21128 ) Change subject: pcu: Introduce test TC_mcs_max_dl .. Patch Set 5: 13 days passed since I pushed latest version. Can we merge? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If6c58cc18b537c4a1354f1b8263db8321347fbd7 Gerrit-Change-Number: 21128 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Mon, 30 Nov 2020 14:30:26 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: gnuradio_zmq_broker_remote: fix eNB port mapping for carrier aggregation
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21409 )
Change subject: gnuradio_zmq_broker_remote: fix eNB port mapping for carrier
aggregation
..
gnuradio_zmq_broker_remote: fix eNB port mapping for carrier aggregation
the mapping of ports didn't consider when a eNB had two ports for
different EARFCNs
Change-Id: I5548f67a3b37b03482e4b6172828fcd891e704a5
---
M src/osmo_gsm_tester/external/gnuradio_zmq_broker_remote.py
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
pespin: Looks good to me, approved; Verified
diff --git a/src/osmo_gsm_tester/external/gnuradio_zmq_broker_remote.py
b/src/osmo_gsm_tester/external/gnuradio_zmq_broker_remote.py
index fa69efd..98942f3 100755
--- a/src/osmo_gsm_tester/external/gnuradio_zmq_broker_remote.py
+++ b/src/osmo_gsm_tester/external/gnuradio_zmq_broker_remote.py
@@ -22,7 +22,7 @@
class GrBroker(gr.top_block):
def __init__(self, args, cfg):
-gr.top_block.__init__(self, "Intra Handover Flowgraph")
+gr.top_block.__init__(self, "InterENB Handover Flowgraph")
##
# Variables
@@ -83,10 +83,10 @@
idx = 0
for enb in self.cfg['enb']:
for it in enb:
-print('Connecting ENB port %u to Adder[%u] for earfcn %u' %
(it['bind_port'], blocks_add_next_avail_port[earfcn], it['earfcn']))
-self.connect((it['gr_block_multiply'], 0),
(self.blocks_add[it['earfcn']], blocks_add_next_avail_port[earfcn]))
+print('Connecting ENB port %u to Adder[%u] for earfcn %u' %
(it['bind_port'], blocks_add_next_avail_port[it['earfcn']], it['earfcn']))
+self.connect((it['gr_block_multiply'], 0),
(self.blocks_add[it['earfcn']], blocks_add_next_avail_port[it['earfcn']]))
# TODO: if it['use_mimo'], connect it['gr_block_multiply2'] to
some adder...
-blocks_add_next_avail_port[earfcn] += 1
+blocks_add_next_avail_port[it['earfcn']] += 1
# Connect the Adder to the UE-side (Dl):
for earfcn, bl_add in self.blocks_add.items():
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21409
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I5548f67a3b37b03482e4b6172828fcd891e704a5
Gerrit-Change-Number: 21409
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: jenkins-build-amarisoft.sh: set symlink to srslte_rf lib
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21408 )
Change subject: jenkins-build-amarisoft.sh: set symlink to srslte_rf lib
..
jenkins-build-amarisoft.sh: set symlink to srslte_rf lib
Change-Id: Ifc8e5ba0dd59fb92cdf22f2a18acea904e2153f7
---
M contrib/jenkins-build-amarisoft.sh
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, approved; Verified
diff --git a/contrib/jenkins-build-amarisoft.sh
b/contrib/jenkins-build-amarisoft.sh
index f880876..43755ea 100755
--- a/contrib/jenkins-build-amarisoft.sh
+++ b/contrib/jenkins-build-amarisoft.sh
@@ -66,6 +66,7 @@
cp
${base}/${project_name_srslte}/build/lib/src/phy/rf/libsrslte_rf.so
inst-amarisoftue/
cp
${base}/${project_name_zmq}/build/libtrx_zmq-linux-2018-10-18.so
inst-amarisoftue/trx_zmq.so
patchelf --set-rpath '$ORIGIN/' inst-amarisoftue/trx_zmq.so
+cd inst-amarisoftue && ln -s libsrslte_rf.so libsrslte_rf.so.0
&& cd ..
fi
cp ${base}/inst-tmp/trx_uhd-linux*/trx_uhd.so inst-amarisoftue/
this="amarisoftue.build-${BUILD_NUMBER-$(date +%Y-%m-%d_%H_%M_%S)}"
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21408
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ifc8e5ba0dd59fb92cdf22f2a18acea904e2153f7
Gerrit-Change-Number: 21408
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: gnuradio_zmq_broker_remote: fix eNB port mapping for carrier aggregation
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21409 ) Change subject: gnuradio_zmq_broker_remote: fix eNB port mapping for carrier aggregation .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21409 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I5548f67a3b37b03482e4b6172828fcd891e704a5 Gerrit-Change-Number: 21409 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 30 Nov 2020 14:12:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: ms_amarisoft: fix various regressions
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21258 )
Change subject: ms_amarisoft: fix various regressions
..
ms_amarisoft: fix various regressions
this patch fixes some regressions in the Amarisoft UE class,
the config template, etc. that have been undetected bc we never
executed tests with it.
Change-Id: I397e675a4018acf3372a3b7e29fd864703b2b919
---
M src/osmo_gsm_tester/obj/ms.py
M src/osmo_gsm_tester/obj/ms_amarisoft.py
M src/osmo_gsm_tester/templates/amarisoft_lteue.cfg.tmpl
M sysmocom/defaults.conf
A sysmocom/scenarios/cfg-ms-count@.conf
5 files changed, 28 insertions(+), 10 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo_gsm_tester/obj/ms.py b/src/osmo_gsm_tester/obj/ms.py
index 70ce558..7257769 100644
--- a/src/osmo_gsm_tester/obj/ms.py
+++ b/src/osmo_gsm_tester/obj/ms.py
@@ -36,6 +36,11 @@
}
schema.register_resource_schema('modem', resource_schema)
+config_schema = {
+'count': schema.UINT
+}
+schema.register_config_schema('modem', config_schema)
+
class MS(log.Origin, metaclass=ABCMeta):
"""Base for everything about mobile/modem and SIMs."""
@@ -125,3 +130,6 @@
def get_counter(self, counter_name):
raise log.Error('get_counter() not implemented!')
+
+def features(self):
+return self._conf.get('features', [])
diff --git a/src/osmo_gsm_tester/obj/ms_amarisoft.py
b/src/osmo_gsm_tester/obj/ms_amarisoft.py
index fa16d63..9b6d64a 100644
--- a/src/osmo_gsm_tester/obj/ms_amarisoft.py
+++ b/src/osmo_gsm_tester/obj/ms_amarisoft.py
@@ -98,6 +98,7 @@
self.remote_config_rf_file = None
self.remote_log_file = None
self.remote_ifup_file = None
+self.num_carriers = 1
if not rf_type_valid(conf.get('rf_dev_type', None)):
raise log.Error('Invalid rf_dev_type=%s' % conf.get('rf_dev_type',
None))
if conf.get('rf_dev_type') == 'zmq':
@@ -247,13 +248,17 @@
# We need to set some specific variables programatically here to match
IP addresses:
if self._conf.get('rf_dev_type') == 'zmq':
base_srate = num_prb2base_srate(self.enb.num_prb())
-enb_base_port = self.enb.zmq_base_bind_port()
-rf_dev_args = 'tx_port0=tcp://' + self.addr() + ':' +
str(self._zmq_base_bind_port + 0) \
-+ ',tx_port1=tcp://' + self.addr() + ':' +
str(self._zmq_base_bind_port + 1) \
-+ ',rx_port0=tcp://' + self.enb.addr() + ':' +
str(enb_base_port + 0) \
-+ ',rx_port1=tcp://' + self.enb.addr() + ':' +
str(enb_base_port + 1) \
-+
',tx_freq=2510e6,rx_freq=2630e6,tx_freq2=2530e6,rx_freq2=2650e6' \
-+ ',id=ue,base_srate='+ str(base_srate)
+rf_dev_args = self.enb.get_zmq_rf_dev_args_for_ue(self)
+
+# Single carrier
+if self.enb.num_ports() == 1:
+# SISO
+rf_dev_args += ',rx_freq0=2630e6,tx_freq0=2510e6'
+elif self.enb.num_ports() == 2:
+# MIMO
+rf_dev_args +=
',rx_freq0=2630e6,rx_freq1=2630e6,tx_freq0=2510e6,tx_freq1=2510e6'
+
+rf_dev_args += ',id=ue,base_srate='+ str(base_srate)
config.overlay(values, dict(ue=dict(sample_rate = base_srate /
(1000*1000),
rf_dev_args = rf_dev_args)))
@@ -285,6 +290,7 @@
# different cfg namespace 'trx'. Copy needed values over there:
config.overlay(values,
dict(trx=dict(rf_dev_type=values['ue'].get('rf_dev_type', None),
rf_dev_args=values['ue'].get('rf_dev_args', None),
+
rf_dev_sync=values['ue'].get('rf_dev_sync', None),
rx_gain=values['ue'].get('rx_gain', None),
tx_gain=values['ue'].get('tx_gain', None),
)))
@@ -331,7 +337,7 @@
proc.launch_sync()
return proc
-def verify_metric(self, value, operation='avg', metric='dl_brate',
criterion='gt'):
+def verify_metric(self, value, operation='avg', metric='dl_brate',
criterion='gt', window=None):
return 'metrics not yet implemented with Amarisoft UE'
# vim: expandtab tabstop=4 shiftwidth=4
diff --git a/src/osmo_gsm_tester/templates/amarisoft_lteue.cfg.tmpl
b/src/osmo_gsm_tester/templates/amarisoft_lteue.cfg.tmpl
index d6ba32d..6f38491 100644
--- a/src/osmo_gsm_tester/templates/amarisoft_lteue.cfg.tmpl
+++ b/src/osmo_gsm_tester/templates/amarisoft_lteue.cfg.tmpl
@@ -48,7 +48,7 @@
ue_category: 4,
/* USIM data */
- sim_algo: "${sub.auth_algo}", /* USIM authentication algorithm: xor,
milenage or tuak */
+
