Build failure of network:osmocom:nightly/osmo-bsc in Debian_10/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_10/aarch64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_10/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 853s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/-g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z,relro -o isdnsync isdnsync.o [ 854s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z -Wl,relro -o isdnsync isdnsync.o -pthread [ 854s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o meas_json-meas_json.o `test -f 'meas_json.c' || echo './'`meas_json.c [ 855s] /bin/bash ../../libtool --tag=CC --mode=link gcc -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z,relro -o meas_json meas_json-meas_json.o ../../src/osmo-bsc/abis_nm.o ../../src/osmo-bsc/acc.o ../../src/osmo-bsc/bts.o ../../src/osmo-bsc/bts_sm.o ../../src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o ../../src/osmo-bsc/bts_trx.o ../../src/osmo-bsc/gsm_data.o ../../src/osmo-bsc/nm_common_fsm.o ../../src/osmo-bsc/nm_bts_sm_fsm.o ../../src/osmo-bsc/nm_bts_fsm.o ../../src/osmo-bsc/nm_bb_transc_fsm.o ../../src/osmo-bsc/nm_channel_fsm.o ../../src/osmo-bsc/nm_gprs_cell_fsm.o ../../src/osmo-bsc/nm_gprs_nse_fsm.o ../../src/osmo-bsc/nm_gprs_nsvc_fsm.o ../../src/osmo-bsc/nm_rcarrier_fsm.o -ltalloc -losmocore -ltalloc -losmogsm -losmocore -losmoabis [ 856s] libtool: link: gcc -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z -Wl,relro -o meas_json meas_json-meas_json.o ../../src/osmo-bsc/abis_nm.o ../../src/osmo-bsc/acc.o ../../src/osmo-bsc/bts.o ../../src/osmo-bsc/bts_sm.o ../../src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o ../../src/osmo-bsc/bts_trx.o ../../src/osmo-bsc/gsm_data.o ../../src/osmo-bsc/nm_common_fsm.o ../../src/osmo-bsc/nm_bts_sm_fsm.o ../../src/osmo-bsc/nm_bts_fsm.o ../../src/osmo-bsc/nm_bb_transc_fsm.o ../../src/osmo-bsc/nm_channel_fsm.o ../../src/osmo-bsc/nm_gprs_cell_fsm.o ../../src/osmo-bsc/nm_gprs_nse_fsm.o ../../src/osmo-bsc/nm_gprs_nsvc_fsm.o ../../src/osmo-bsc/nm_rcarrier_fsm.o -ltalloc /usr/lib/aarch64-linux-gnu/libosmogsm.so /usr/lib/aarch64-linux-gnu/libosmocore.so /usr/lib/aarch64-linux-gnu/libosmoabis.so -pthread [ 856s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o meas_vis-meas_vis.o `test -f 'meas_vis.c' || echo './'`meas_vis.c [ 856s] meas_vis.c: In function 'write_uni': [ 856s] meas_vis.c:196:16: error: 'struct gsm_meas_rep' has no member named 'bs_power'; did you mean 'bs_power_db'? [ 856s]pwr = ms->mr.bs_power; [ 856s] ^~~~ [ 856s] bs_power_db [ 856s] make[4]: *** [Makefile:736: meas_vis-meas_vis.o] Error 1 [ 856s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/utils' [ 856s] make[3]: *** [Makefile:403: all-recursive] Error 1 [ 856s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 856s] make[2]: *** [Makefile:453: all-recursive] Error 1 [ 856s] make[2]: Leaving
Build failure of network:osmocom:nightly/osmo-bsc in Debian_9.0/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/aarch64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 389s] libtool: link: gcc -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z -Wl,relro -o meas_json meas_json-meas_json.o ../../src/osmo-bsc/abis_nm.o ../../src/osmo-bsc/acc.o ../../src/osmo-bsc/bts.o ../../src/osmo-bsc/bts_sm.o ../../src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o ../../src/osmo-bsc/bts_trx.o ../../src/osmo-bsc/gsm_data.o ../../src/osmo-bsc/nm_common_fsm.o ../../src/osmo-bsc/nm_bts_sm_fsm.o ../../src/osmo-bsc/nm_bts_fsm.o ../../src/osmo-bsc/nm_bb_transc_fsm.o ../../src/osmo-bsc/nm_channel_fsm.o ../../src/osmo-bsc/nm_gprs_cell_fsm.o ../../src/osmo-bsc/nm_gprs_nse_fsm.o ../../src/osmo-bsc/nm_gprs_nsvc_fsm.o ../../src/osmo-bsc/nm_rcarrier_fsm.o -ltalloc /usr/lib/aarch64-linux-gnu/libosmogsm.so /usr/lib/aarch64-linux-gnu/libosmocore.so /usr/lib/aarch64-linux-gnu/libosmoabis.so -pthread [ 390s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o meas_vis-meas_vis.o `test -f 'meas_vis.c' || echo './'`meas_vis.c [ 390s] meas_vis.c: In function 'write_uni': [ 390s] meas_vis.c:196:15: error: 'struct gsm_meas_rep' has no member named 'bs_power'; did you mean 'bs_power_db'? [ 390s]pwr = ms->mr.bs_power; [ 390s]^ [ 390s] Makefile:723: recipe for target 'meas_vis-meas_vis.o' failed [ 390s] make[4]: *** [meas_vis-meas_vis.o] Error 1 [ 390s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/utils' [ 390s] Makefile:403: recipe for target 'all-recursive' failed [ 390s] make[3]: *** [all-recursive] Error 1 [ 390s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 390s] Makefile:453: recipe for target 'all-recursive' failed [ 390s] make[2]: *** [all-recursive] Error 1 [ 390s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 390s] Makefile:385: recipe for target 'all' failed [ 390s] make[1]: *** [all] Error 2 [ 390s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 390s] dh_auto_build: make -j1 returned exit code 2 [ 390s] debian/rules:45: recipe for target 'build' failed [ 390s] make: *** [build] Error 2 [ 390s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 390s] ### VM INTERACTION START ### [ 393s] [ 375.604748] sysrq: Power Off [ 393s] [ 375.636177] reboot: Power down [ 394s] ### VM INTERACTION END ### [ 394s] [ 394s] obs-arm-9 failed "build osmo-bsc_1.7.0.108.4d5604.202106070026.dsc" at Mon Jun 7 01:00:12 UTC 2021. [ 394s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_20.10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_20.10/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/libsmpp34-dev.deb: Input/output error (worker was cloud115:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-bsc in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 417s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/-g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z,relro -o isdnsync isdnsync.o [ 417s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z -Wl,relro -o isdnsync isdnsync.o -pthread [ 417s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o meas_json-meas_json.o `test -f 'meas_json.c' || echo './'`meas_json.c [ 417s] /bin/bash ../../libtool --tag=CC --mode=link gcc -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z,relro -o meas_json meas_json-meas_json.o ../../src/osmo-bsc/abis_nm.o ../../src/osmo-bsc/acc.o ../../src/osmo-bsc/bts.o ../../src/osmo-bsc/bts_sm.o ../../src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o ../../src/osmo-bsc/bts_trx.o ../../src/osmo-bsc/gsm_data.o ../../src/osmo-bsc/nm_common_fsm.o ../../src/osmo-bsc/nm_bts_sm_fsm.o ../../src/osmo-bsc/nm_bts_fsm.o ../../src/osmo-bsc/nm_bb_transc_fsm.o ../../src/osmo-bsc/nm_channel_fsm.o ../../src/osmo-bsc/nm_gprs_cell_fsm.o ../../src/osmo-bsc/nm_gprs_nse_fsm.o ../../src/osmo-bsc/nm_gprs_nsvc_fsm.o ../../src/osmo-bsc/nm_rcarrier_fsm.o -ltalloc -losmocore -ltalloc -losmogsm -losmocore -losmoabis [ 418s] libtool: link: gcc -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z -Wl,relro -o meas_json meas_json-meas_json.o ../../src/osmo-bsc/abis_nm.o ../../src/osmo-bsc/acc.o ../../src/osmo-bsc/bts.o ../../src/osmo-bsc/bts_sm.o ../../src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o ../../src/osmo-bsc/bts_trx.o ../../src/osmo-bsc/gsm_data.o ../../src/osmo-bsc/nm_common_fsm.o ../../src/osmo-bsc/nm_bts_sm_fsm.o ../../src/osmo-bsc/nm_bts_fsm.o ../../src/osmo-bsc/nm_bb_transc_fsm.o ../../src/osmo-bsc/nm_channel_fsm.o ../../src/osmo-bsc/nm_gprs_cell_fsm.o ../../src/osmo-bsc/nm_gprs_nse_fsm.o ../../src/osmo-bsc/nm_gprs_nsvc_fsm.o ../../src/osmo-bsc/nm_rcarrier_fsm.o -ltalloc /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so /usr/lib/x86_64-linux-gnu/libosmoabis.so -pthread [ 418s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o meas_vis-meas_vis.o `test -f 'meas_vis.c' || echo './'`meas_vis.c [ 418s] meas_vis.c: In function 'write_uni': [ 418s] meas_vis.c:196:16: error: 'struct gsm_meas_rep' has no member named 'bs_power'; did you mean 'bs_power_db'? [ 418s] 196 | pwr = ms->mr.bs_power; [ 418s] |^~~~ [ 418s] |bs_power_db [ 418s] make[4]: *** [Makefile:736: meas_vis-meas_vis.o] Error 1 [ 418s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/utils' [ 418s] make[3]: *** [Makefile:403: all-recursive] Error 1 [ 418s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 418s] make[2]: *** [Makefile:455: all-recursive] Error 1 [
Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_20.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 392s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/-g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-Bsymbolic-functions -Wl,-z,relro -o isdnsync isdnsync.o [ 392s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -o isdnsync isdnsync.o -pthread [ 392s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o meas_json-meas_json.o `test -f 'meas_json.c' || echo './'`meas_json.c [ 392s] /bin/bash ../../libtool --tag=CC --mode=link gcc -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-Bsymbolic-functions -Wl,-z,relro -o meas_json meas_json-meas_json.o ../../src/osmo-bsc/abis_nm.o ../../src/osmo-bsc/acc.o ../../src/osmo-bsc/bts.o ../../src/osmo-bsc/bts_sm.o ../../src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o ../../src/osmo-bsc/bts_trx.o ../../src/osmo-bsc/gsm_data.o ../../src/osmo-bsc/nm_common_fsm.o ../../src/osmo-bsc/nm_bts_sm_fsm.o ../../src/osmo-bsc/nm_bts_fsm.o ../../src/osmo-bsc/nm_bb_transc_fsm.o ../../src/osmo-bsc/nm_channel_fsm.o ../../src/osmo-bsc/nm_gprs_cell_fsm.o ../../src/osmo-bsc/nm_gprs_nse_fsm.o ../../src/osmo-bsc/nm_gprs_nsvc_fsm.o ../../src/osmo-bsc/nm_rcarrier_fsm.o -ltalloc -losmocore -ltalloc -losmogsm -losmocore -losmoabis [ 393s] libtool: link: gcc -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -o meas_json meas_json-meas_json.o ../../src/osmo-bsc/abis_nm.o ../../src/osmo-bsc/acc.o ../../src/osmo-bsc/bts.o ../../src/osmo-bsc/bts_sm.o ../../src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o ../../src/osmo-bsc/bts_trx.o ../../src/osmo-bsc/gsm_data.o ../../src/osmo-bsc/nm_common_fsm.o ../../src/osmo-bsc/nm_bts_sm_fsm.o ../../src/osmo-bsc/nm_bts_fsm.o ../../src/osmo-bsc/nm_bb_transc_fsm.o ../../src/osmo-bsc/nm_channel_fsm.o ../../src/osmo-bsc/nm_gprs_cell_fsm.o ../../src/osmo-bsc/nm_gprs_nse_fsm.o ../../src/osmo-bsc/nm_gprs_nsvc_fsm.o ../../src/osmo-bsc/nm_rcarrier_fsm.o -ltalloc /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so /usr/lib/x86_64-linux-gnu/libosmoabis.so -pthread [ 393s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o meas_vis-meas_vis.o `test -f 'meas_vis.c' || echo './'`meas_vis.c [ 393s] meas_vis.c: In function 'write_uni': [ 393s] meas_vis.c:196:16: error: 'struct gsm_meas_rep' has no member named 'bs_power'; did you mean 'bs_power_db'? [ 393s] 196 | pwr = ms->mr.bs_power; [ 393s] |^~~~ [ 393s] |bs_power_db [ 393s] make[4]: *** [Makefile:736: meas_vis-meas_vis.o] Error 1 [ 393s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/utils' [ 393s] make[3]: *** [Makefile:403: all-recursive] Error 1 [ 393s] make[3]: Leaving
Build failure of network:osmocom:nightly/osmo-bsc in Debian_10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_10/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 306s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/-g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z,relro -o isdnsync isdnsync.o [ 306s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z -Wl,relro -o isdnsync isdnsync.o -pthread [ 307s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o meas_json-meas_json.o `test -f 'meas_json.c' || echo './'`meas_json.c [ 307s] /bin/bash ../../libtool --tag=CC --mode=link gcc -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z,relro -o meas_json meas_json-meas_json.o ../../src/osmo-bsc/abis_nm.o ../../src/osmo-bsc/acc.o ../../src/osmo-bsc/bts.o ../../src/osmo-bsc/bts_sm.o ../../src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o ../../src/osmo-bsc/bts_trx.o ../../src/osmo-bsc/gsm_data.o ../../src/osmo-bsc/nm_common_fsm.o ../../src/osmo-bsc/nm_bts_sm_fsm.o ../../src/osmo-bsc/nm_bts_fsm.o ../../src/osmo-bsc/nm_bb_transc_fsm.o ../../src/osmo-bsc/nm_channel_fsm.o ../../src/osmo-bsc/nm_gprs_cell_fsm.o ../../src/osmo-bsc/nm_gprs_nse_fsm.o ../../src/osmo-bsc/nm_gprs_nsvc_fsm.o ../../src/osmo-bsc/nm_rcarrier_fsm.o -ltalloc -losmocore -ltalloc -losmogsm -losmocore -losmoabis [ 307s] libtool: link: gcc -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z -Wl,relro -o meas_json meas_json-meas_json.o ../../src/osmo-bsc/abis_nm.o ../../src/osmo-bsc/acc.o ../../src/osmo-bsc/bts.o ../../src/osmo-bsc/bts_sm.o ../../src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o ../../src/osmo-bsc/bts_trx.o ../../src/osmo-bsc/gsm_data.o ../../src/osmo-bsc/nm_common_fsm.o ../../src/osmo-bsc/nm_bts_sm_fsm.o ../../src/osmo-bsc/nm_bts_fsm.o ../../src/osmo-bsc/nm_bb_transc_fsm.o ../../src/osmo-bsc/nm_channel_fsm.o ../../src/osmo-bsc/nm_gprs_cell_fsm.o ../../src/osmo-bsc/nm_gprs_nse_fsm.o ../../src/osmo-bsc/nm_gprs_nsvc_fsm.o ../../src/osmo-bsc/nm_rcarrier_fsm.o -ltalloc /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so /usr/lib/x86_64-linux-gnu/libosmoabis.so -pthread [ 307s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o meas_vis-meas_vis.o `test -f 'meas_vis.c' || echo './'`meas_vis.c [ 307s] meas_vis.c: In function 'write_uni': [ 307s] meas_vis.c:196:16: error: 'struct gsm_meas_rep' has no member named 'bs_power'; did you mean 'bs_power_db'? [ 307s]pwr = ms->mr.bs_power; [ 307s] ^~~~ [ 307s] bs_power_db [ 307s] make[4]: *** [Makefile:736: meas_vis-meas_vis.o] Error 1 [ 307s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/utils' [ 307s] make[3]: *** [Makefile:403: all-recursive] Error 1 [ 307s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 307s] make[2]: *** [Makefile:453: all-recursive] Error 1 [ 307s] make[2]: Leaving
Build failure of network:osmocom:nightly/osmo-bsc in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 219s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/-g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z,relro -o isdnsync isdnsync.o [ 219s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z -Wl,relro -o isdnsync isdnsync.o -pthread [ 219s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o meas_json-meas_json.o `test -f 'meas_json.c' || echo './'`meas_json.c [ 219s] /bin/bash ../../libtool --tag=CC --mode=link gcc -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z,relro -o meas_json meas_json-meas_json.o ../../src/osmo-bsc/abis_nm.o ../../src/osmo-bsc/acc.o ../../src/osmo-bsc/bts.o ../../src/osmo-bsc/bts_sm.o ../../src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o ../../src/osmo-bsc/bts_trx.o ../../src/osmo-bsc/gsm_data.o ../../src/osmo-bsc/nm_common_fsm.o ../../src/osmo-bsc/nm_bts_sm_fsm.o ../../src/osmo-bsc/nm_bts_fsm.o ../../src/osmo-bsc/nm_bb_transc_fsm.o ../../src/osmo-bsc/nm_channel_fsm.o ../../src/osmo-bsc/nm_gprs_cell_fsm.o ../../src/osmo-bsc/nm_gprs_nse_fsm.o ../../src/osmo-bsc/nm_gprs_nsvc_fsm.o ../../src/osmo-bsc/nm_rcarrier_fsm.o -ltalloc -losmocore -ltalloc -losmogsm -losmocore -losmoabis [ 219s] libtool: link: gcc -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z -Wl,relro -o meas_json meas_json-meas_json.o ../../src/osmo-bsc/abis_nm.o ../../src/osmo-bsc/acc.o ../../src/osmo-bsc/bts.o ../../src/osmo-bsc/bts_sm.o ../../src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o ../../src/osmo-bsc/bts_trx.o ../../src/osmo-bsc/gsm_data.o ../../src/osmo-bsc/nm_common_fsm.o ../../src/osmo-bsc/nm_bts_sm_fsm.o ../../src/osmo-bsc/nm_bts_fsm.o ../../src/osmo-bsc/nm_bb_transc_fsm.o ../../src/osmo-bsc/nm_channel_fsm.o ../../src/osmo-bsc/nm_gprs_cell_fsm.o ../../src/osmo-bsc/nm_gprs_nse_fsm.o ../../src/osmo-bsc/nm_gprs_nsvc_fsm.o ../../src/osmo-bsc/nm_rcarrier_fsm.o -ltalloc /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so /usr/lib/x86_64-linux-gnu/libosmoabis.so -pthread [ 219s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o meas_vis-meas_vis.o `test -f 'meas_vis.c' || echo './'`meas_vis.c [ 219s] meas_vis.c: In function 'write_uni': [ 219s] meas_vis.c:196:16: error: 'struct gsm_meas_rep' has no member named 'bs_power'; did you mean 'bs_power_db'? [ 219s] 196 | pwr = ms->mr.bs_power; [ 219s] |^~~~ [ 219s] |bs_power_db [ 219s] make[4]: *** [Makefile:736: meas_vis-meas_vis.o] Error 1 [ 219s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/utils' [ 219s] make[3]: *** [Makefile:403: all-recursive] Error 1 [ 219s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 219s] make[2]: *** [Makefile:455: all-recursive] Error 1 [
Build failure of network:osmocom:nightly/osmo-bsc in Debian_10/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_10/i586 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 289s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/-g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z,relro -o isdnsync isdnsync.o [ 289s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z -Wl,relro -o isdnsync isdnsync.o -pthread [ 289s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o meas_json-meas_json.o `test -f 'meas_json.c' || echo './'`meas_json.c [ 290s] /bin/bash ../../libtool --tag=CC --mode=link gcc -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z,relro -o meas_json meas_json-meas_json.o ../../src/osmo-bsc/abis_nm.o ../../src/osmo-bsc/acc.o ../../src/osmo-bsc/bts.o ../../src/osmo-bsc/bts_sm.o ../../src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o ../../src/osmo-bsc/bts_trx.o ../../src/osmo-bsc/gsm_data.o ../../src/osmo-bsc/nm_common_fsm.o ../../src/osmo-bsc/nm_bts_sm_fsm.o ../../src/osmo-bsc/nm_bts_fsm.o ../../src/osmo-bsc/nm_bb_transc_fsm.o ../../src/osmo-bsc/nm_channel_fsm.o ../../src/osmo-bsc/nm_gprs_cell_fsm.o ../../src/osmo-bsc/nm_gprs_nse_fsm.o ../../src/osmo-bsc/nm_gprs_nsvc_fsm.o ../../src/osmo-bsc/nm_rcarrier_fsm.o -ltalloc -losmocore -ltalloc -losmogsm -losmocore -losmoabis [ 290s] libtool: link: gcc -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z -Wl,relro -o meas_json meas_json-meas_json.o ../../src/osmo-bsc/abis_nm.o ../../src/osmo-bsc/acc.o ../../src/osmo-bsc/bts.o ../../src/osmo-bsc/bts_sm.o ../../src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o ../../src/osmo-bsc/bts_trx.o ../../src/osmo-bsc/gsm_data.o ../../src/osmo-bsc/nm_common_fsm.o ../../src/osmo-bsc/nm_bts_sm_fsm.o ../../src/osmo-bsc/nm_bts_fsm.o ../../src/osmo-bsc/nm_bb_transc_fsm.o ../../src/osmo-bsc/nm_channel_fsm.o ../../src/osmo-bsc/nm_gprs_cell_fsm.o ../../src/osmo-bsc/nm_gprs_nse_fsm.o ../../src/osmo-bsc/nm_gprs_nsvc_fsm.o ../../src/osmo-bsc/nm_rcarrier_fsm.o -ltalloc /usr/lib/i386-linux-gnu/libosmogsm.so /usr/lib/i386-linux-gnu/libosmocore.so /usr/lib/i386-linux-gnu/libosmoabis.so -pthread [ 290s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o meas_vis-meas_vis.o `test -f 'meas_vis.c' || echo './'`meas_vis.c [ 290s] meas_vis.c: In function 'write_uni': [ 290s] meas_vis.c:196:16: error: 'struct gsm_meas_rep' has no member named 'bs_power'; did you mean 'bs_power_db'? [ 290s]pwr = ms->mr.bs_power; [ 290s] ^~~~ [ 290s] bs_power_db [ 290s] make[4]: *** [Makefile:736: meas_vis-meas_vis.o] Error 1 [ 290s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/utils' [ 290s] make[3]: *** [Makefile:403: all-recursive] Error 1 [ 290s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 290s] make[2]: *** [Makefile:453: all-recursive] Error 1 [ 290s] make[2]: Leaving directory
Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_18.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 294s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o meas_vis-meas_vis.o `test -f 'meas_vis.c' || echo './'`meas_vis.c [ 294s] meas_vis.c: In function 'write_uni': [ 294s] meas_vis.c:196:16: error: 'struct gsm_meas_rep' has no member named 'bs_power'; did you mean 'bs_power_db'? [ 294s]pwr = ms->mr.bs_power; [ 294s] ^~~~ [ 294s] bs_power_db [ 294s] Makefile:723: recipe for target 'meas_vis-meas_vis.o' failed [ 294s] make[4]: *** [meas_vis-meas_vis.o] Error 1 [ 294s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/utils' [ 294s] Makefile:403: recipe for target 'all-recursive' failed [ 294s] make[3]: *** [all-recursive] Error 1 [ 294s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 294s] Makefile:453: recipe for target 'all-recursive' failed [ 294s] make[2]: *** [all-recursive] Error 1 [ 294s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 294s] Makefile:385: recipe for target 'all' failed [ 294s] make[1]: *** [all] Error 2 [ 294s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 294s] dh_auto_build: make -j1 returned exit code 2 [ 294s] debian/rules:45: recipe for target 'build' failed [ 294s] make: *** [build] Error 2 [ 294s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 294s] ### VM INTERACTION START ### [ 297s] [ 284.832556] sysrq: Power Off [ 297s] [ 284.839498] reboot: Power down [ 298s] ### VM INTERACTION END ### [ 298s] [ 298s] lamb23 failed "build osmo-bsc_1.7.0.108.4d5604.202106070026.dsc" at Mon Jun 7 00:46:08 UTC 2021. [ 298s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-bsc in Debian_8.0/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_8.0/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 114s] CCLD meas_json [ 115s] CC meas_vis-meas_vis.o [ 115s] meas_vis.c: In function 'write_uni': [ 115s] meas_vis.c:196:15: error: 'struct gsm_meas_rep' has no member named 'bs_power' [ 115s]pwr = ms->mr.bs_power; [ 115s]^ [ 115s] Makefile:711: recipe for target 'meas_vis-meas_vis.o' failed [ 115s] make[4]: *** [meas_vis-meas_vis.o] Error 1 [ 115s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/utils' [ 115s] Makefile:391: recipe for target 'all-recursive' failed [ 115s] make[3]: *** [all-recursive] Error 1 [ 115s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 115s] Makefile:441: recipe for target 'all-recursive' failed [ 115s] make[2]: *** [all-recursive] Error 1 [ 115s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 115s] Makefile:372: recipe for target 'all' failed [ 115s] make[1]: *** [all] Error 2 [ 115s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 115s] dh_auto_build: make -j1 returned exit code 2 [ 115s] debian/rules:45: recipe for target 'build' failed [ 115s] make: *** [build] Error 2 [ 115s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 115s] ### VM INTERACTION START ### [ 116s] Powering off. [ 116s] [ 109.421450] reboot: Power down [ 116s] ### VM INTERACTION END ### [ 116s] [ 116s] build75 failed "build osmo-bsc_1.7.0.108.4d5604.202106070026.dsc" at Mon Jun 7 00:46:06 UTC 2021. [ 116s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sgsn in Debian_8.0/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_8.0/i586 Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: /var/cache/obs/worker/root_1/.pkgs/libgtp-dev.deb: Input/output error (worker was cloud115:1) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_20.10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_20.10/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/libosmocore-dev.deb: Input/output error (worker was cloud115:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_21.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_21.04/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_21.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: /var/cache/obs/worker/root_1/.pkgs/libosmocore-dev.deb: Input/output error (worker was cloud115:1) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-bsc in Debian_9.0/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 221s] libtool: link: gcc -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z -Wl,relro -o meas_json meas_json-meas_json.o ../../src/osmo-bsc/abis_nm.o ../../src/osmo-bsc/acc.o ../../src/osmo-bsc/bts.o ../../src/osmo-bsc/bts_sm.o ../../src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o ../../src/osmo-bsc/bts_trx.o ../../src/osmo-bsc/gsm_data.o ../../src/osmo-bsc/nm_common_fsm.o ../../src/osmo-bsc/nm_bts_sm_fsm.o ../../src/osmo-bsc/nm_bts_fsm.o ../../src/osmo-bsc/nm_bb_transc_fsm.o ../../src/osmo-bsc/nm_channel_fsm.o ../../src/osmo-bsc/nm_gprs_cell_fsm.o ../../src/osmo-bsc/nm_gprs_nse_fsm.o ../../src/osmo-bsc/nm_gprs_nsvc_fsm.o ../../src/osmo-bsc/nm_rcarrier_fsm.o -ltalloc /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so /usr/lib/x86_64-linux-gnu/libosmoabis.so -pthread [ 221s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o meas_vis-meas_vis.o `test -f 'meas_vis.c' || echo './'`meas_vis.c [ 221s] meas_vis.c: In function 'write_uni': [ 221s] meas_vis.c:196:15: error: 'struct gsm_meas_rep' has no member named 'bs_power'; did you mean 'bs_power_db'? [ 221s]pwr = ms->mr.bs_power; [ 221s]^ [ 221s] Makefile:723: recipe for target 'meas_vis-meas_vis.o' failed [ 221s] make[4]: *** [meas_vis-meas_vis.o] Error 1 [ 221s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/utils' [ 221s] Makefile:403: recipe for target 'all-recursive' failed [ 221s] make[3]: *** [all-recursive] Error 1 [ 221s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 221s] Makefile:453: recipe for target 'all-recursive' failed [ 221s] make[2]: *** [all-recursive] Error 1 [ 221s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 221s] Makefile:385: recipe for target 'all' failed [ 221s] make[1]: *** [all] Error 2 [ 221s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 221s] dh_auto_build: make -j1 returned exit code 2 [ 221s] debian/rules:45: recipe for target 'build' failed [ 221s] make: *** [build] Error 2 [ 221s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 221s] ### VM INTERACTION START ### [ 224s] [ 212.476968] sysrq: Power Off [ 224s] [ 212.485190] reboot: Power down [ 224s] ### VM INTERACTION END ### [ 225s] [ 225s] lamb57 failed "build osmo-bsc_1.7.0.108.4d5604.202106070026.dsc" at Mon Jun 7 00:44:44 UTC 2021. [ 225s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-iuh in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/libasn1c-dev.deb: Input/output error (worker was cloud115:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-bsc in Debian_8.0/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_8.0/i586 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 206s] CCLD meas_json [ 206s] CC meas_vis-meas_vis.o [ 206s] meas_vis.c: In function 'write_uni': [ 206s] meas_vis.c:196:15: error: 'struct gsm_meas_rep' has no member named 'bs_power' [ 206s]pwr = ms->mr.bs_power; [ 206s]^ [ 206s] Makefile:711: recipe for target 'meas_vis-meas_vis.o' failed [ 206s] make[4]: *** [meas_vis-meas_vis.o] Error 1 [ 206s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/utils' [ 206s] Makefile:391: recipe for target 'all-recursive' failed [ 206s] make[3]: *** [all-recursive] Error 1 [ 206s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 206s] Makefile:441: recipe for target 'all-recursive' failed [ 206s] make[2]: *** [all-recursive] Error 1 [ 206s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 206s] Makefile:372: recipe for target 'all' failed [ 206s] make[1]: *** [all] Error 2 [ 206s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 206s] dh_auto_build: make -j1 returned exit code 2 [ 206s] debian/rules:45: recipe for target 'build' failed [ 206s] make: *** [build] Error 2 [ 206s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 206s] ### VM INTERACTION START ### [ 207s] Powering off. [ 207s] [ 197.397707] reboot: Power down [ 208s] ### VM INTERACTION END ### [ 208s] [ 208s] lamb07 failed "build osmo-bsc_1.7.0.108.4d5604.202106070026.dsc" at Mon Jun 7 00:44:26 UTC 2021. [ 208s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-bsc in Debian_9.0/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/i586 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 255s] libtool: link: gcc -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z -Wl,relro -o meas_json meas_json-meas_json.o ../../src/osmo-bsc/abis_nm.o ../../src/osmo-bsc/acc.o ../../src/osmo-bsc/bts.o ../../src/osmo-bsc/bts_sm.o ../../src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o ../../src/osmo-bsc/bts_trx.o ../../src/osmo-bsc/gsm_data.o ../../src/osmo-bsc/nm_common_fsm.o ../../src/osmo-bsc/nm_bts_sm_fsm.o ../../src/osmo-bsc/nm_bts_fsm.o ../../src/osmo-bsc/nm_bb_transc_fsm.o ../../src/osmo-bsc/nm_channel_fsm.o ../../src/osmo-bsc/nm_gprs_cell_fsm.o ../../src/osmo-bsc/nm_gprs_nse_fsm.o ../../src/osmo-bsc/nm_gprs_nsvc_fsm.o ../../src/osmo-bsc/nm_rcarrier_fsm.o -ltalloc /usr/lib/i386-linux-gnu/libosmogsm.so /usr/lib/i386-linux-gnu/libosmocore.so /usr/lib/i386-linux-gnu/libosmoabis.so -pthread [ 255s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o meas_vis-meas_vis.o `test -f 'meas_vis.c' || echo './'`meas_vis.c [ 255s] meas_vis.c: In function 'write_uni': [ 255s] meas_vis.c:196:15: error: 'struct gsm_meas_rep' has no member named 'bs_power'; did you mean 'bs_power_db'? [ 255s]pwr = ms->mr.bs_power; [ 255s]^ [ 255s] Makefile:723: recipe for target 'meas_vis-meas_vis.o' failed [ 255s] make[4]: *** [meas_vis-meas_vis.o] Error 1 [ 255s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/utils' [ 255s] Makefile:403: recipe for target 'all-recursive' failed [ 255s] make[3]: *** [all-recursive] Error 1 [ 255s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 255s] Makefile:453: recipe for target 'all-recursive' failed [ 255s] make[2]: *** [all-recursive] Error 1 [ 255s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 255s] Makefile:385: recipe for target 'all' failed [ 255s] make[1]: *** [all] Error 2 [ 255s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 255s] dh_auto_build: make -j1 returned exit code 2 [ 255s] debian/rules:45: recipe for target 'build' failed [ 255s] make: *** [build] Error 2 [ 255s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 255s] ### VM INTERACTION START ### [ 258s] [ 246.074566] sysrq: Power Off [ 258s] [ 246.082139] reboot: Power down [ 258s] ### VM INTERACTION END ### [ 258s] [ 258s] lamb51 failed "build osmo-bsc_1.7.0.108.4d5604.202106070026.dsc" at Mon Jun 7 00:44:21 UTC 2021. [ 258s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-iuh in Debian_10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/Debian_10/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/libasn1c-dev.deb: Input/output error (worker was cloud115:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-remsim in xUbuntu_20.10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/xUbuntu_20.10/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: /var/cache/obs/worker/root_1/.pkgs/osmo-gsm-manuals-dev.deb: Input/output error (worker was cloud115:1) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-uecups in Debian_8.0/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-uecups/Debian_8.0/i586 Package network:osmocom:nightly/osmo-uecups failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-uecups Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/libosmocore-dev.deb: Input/output error (worker was cloud115:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-ggsn in xUbuntu_20.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-ggsn/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/osmo-ggsn failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-ggsn Last lines of build log: /var/cache/obs/worker/root_1/.pkgs/libosmocore-dev.deb: Input/output error (worker was cloud115:1) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libosmo-abis in xUbuntu_19.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/xUbuntu_19.04/x86_64 Package network:osmocom:nightly/libosmo-abis failed to build in xUbuntu_19.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-abis Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/libosmocore-dev.deb: Input/output error (worker was cloud115:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-ggsn in CentOS_8/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-ggsn/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-ggsn failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-ggsn Last lines of build log: /var/cache/obs/worker/root_1/.pkgs/libgtpnl-devel.rpm: Input/output error (worker was cloud115:1) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-cbc in xUbuntu_18.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-cbc failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/libosmocore-dev.deb: Input/output error (worker was cloud115:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-smlc in openSUSE_Tumbleweed/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-smlc/openSUSE_Tumbleweed/x86_64 Package network:osmocom:nightly/osmo-smlc failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-smlc Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/libosmonetif-devel.rpm: Input/output error (worker was cloud115:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-cbc in openSUSE_Leap_15.2/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/openSUSE_Leap_15.2/x86_64 Package network:osmocom:nightly/osmo-cbc failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/libosmocore-devel.rpm: Input/output error (worker was cloud115:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-e1d in xUbuntu_18.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-e1d/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-e1d failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-e1d Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/libosmocore-dev.deb: Input/output error (worker was cloud115:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libsmpp34 in CentOS_8/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libsmpp34/CentOS_8/x86_64 Package network:osmocom:nightly/libsmpp34 failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libsmpp34 Last lines of build log: /var/cache/obs/worker/root_2/.pkgs/gcc.rpm: Input/output error (worker was cloud115:2) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libosmo-abis in openSUSE_Tumbleweed/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/openSUSE_Tumbleweed/i586 Package network:osmocom:nightly/libosmo-abis failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-abis Last lines of build log: /var/cache/obs/worker/root_2/.pkgs/zlib-devel.rpm: Input/output error (worker was cloud115:2) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-bts[master]: l1sap: fix TDMA frame number wrap in l1sap_info_time_ind()
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bts/+/24594 )
Change subject: l1sap: fix TDMA frame number wrap in l1sap_info_time_ind()
..
l1sap: fix TDMA frame number wrap in l1sap_info_time_ind()
Using the normal arithmetic for TDMA frame numbers may result
in getting wrong values. Consider the following situation:
'info_time_ind->fn' is 0 (beginning of period)
'bts->gsm_time.fn' is 2715647 (end of period)
With these input values the following expression:
info_time_ind->fn - bts->gsm_time.fn
will be equal to:
0 - 2715647 or -2715647
In this case osmo-bts does not log an error, because:
if (-2715647 > 0) // is false
As a consequence, we do not increment number of RACH slots that
have passed by since the last time indication:
for (i = 0; i < -2715647; i++) // is false
This is why we introduced GSM_TDMA_FN_{SUB,SUM,DIFF,INC} API.
Change-Id: I6168dd75daea50bbe2e19338e637185ac9ac87ef
---
M src/common/l1sap.c
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/94/24594/1
diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index b17bf01..cd2af57 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -592,17 +592,17 @@
struct osmo_phsap_prim *l1sap,
struct info_time_ind_param *info_time_ind)
{
- int frames_expired;
- int i;
+ unsigned int frames_expired;
+ unsigned int i;
DEBUGPFN(DL1P, info_time_ind->fn, "Rx MPH_INFO time ind\n");
/* Calculate and check frame difference */
- frames_expired = info_time_ind->fn - bts->gsm_time.fn;
+ frames_expired = GSM_TDMA_FN_SUB(info_time_ind->fn, bts->gsm_time.fn);
if (frames_expired > 1) {
if (bts->gsm_time.fn)
LOGPFN(DL1P, LOGL_ERROR, info_time_ind->fn,
-"Invalid condition detected: Frame difference is
%"PRIu32"-%"PRIu32"=%d > 1!\n",
+"Invalid condition detected: Frame difference is
%"PRIu32"-%"PRIu32"=%u > 1!\n",
info_time_ind->fn, bts->gsm_time.fn,
frames_expired);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24594
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6168dd75daea50bbe2e19338e637185ac9ac87ef
Gerrit-Change-Number: 24594
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in libosmocore[master]: gprs_ns2_sns: implement outbound SNS DEL procedures
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/24591 to look at the new patch set (#2). Change subject: gprs_ns2_sns: implement outbound SNS DEL procedures .. gprs_ns2_sns: implement outbound SNS DEL procedures When removing a bind the remote side needs to be informed via the SNS DELETE procedure. Related: OS#5036 Change-Id: I53cd54dfd262c70c425c3f13dad3b29526daa523 --- M src/gb/gprs_ns2_sns.c 1 file changed, 76 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/91/24591/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I53cd54dfd262c70c425c3f13dad3b29526daa523 Gerrit-Change-Number: 24591 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: newpatchset
Change in libosmocore[master]: gprs_ns2_sns: implement local change weight procedure
Hello Jenkins Builder, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/23187 to look at the new patch set (#8). Change subject: gprs_ns2_sns: implement local change weight procedure .. gprs_ns2_sns: implement local change weight procedure When changing the bind ip-sns weight, initiate a SNS CHANGE WEIGHT procedure to inform the other side. Related: OS#5036 Change-Id: Icec4dabb46bc198f68f91bfe09ba279fbe68d454 --- M src/gb/gprs_ns2.c M src/gb/gprs_ns2_internal.h M src/gb/gprs_ns2_sns.c M src/gb/gprs_ns2_vty.c M tests/gb/gprs_ns2_vty.vty 5 files changed, 464 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/87/23187/8 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icec4dabb46bc198f68f91bfe09ba279fbe68d454 Gerrit-Change-Number: 23187 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: newpatchset
Change in libosmocore[master]: gprs_ns2_sns: implement outbound SNS ADD procedures
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/24123 to look at the new patch set (#5). Change subject: gprs_ns2_sns: implement outbound SNS ADD procedures .. gprs_ns2_sns: implement outbound SNS ADD procedures When adding a bind, the remote side needs to be informed via the SNS ADD procedure. Related: OS#5036 Change-Id: I71c33200bd1f0307ceb943ee958db5ebe3623d36 --- M src/gb/gprs_ns2_sns.c 1 file changed, 190 insertions(+), 36 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/23/24123/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I71c33200bd1f0307ceb943ee958db5ebe3623d36 Gerrit-Change-Number: 24123 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: newpatchset
Change in libosmocore[master]: gprs_ns2_sns: implement outbound DEL SNS procedures
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24591 ) Change subject: gprs_ns2_sns: implement outbound DEL SNS procedures .. Patch Set 1: Code-Review-1 TODO: check SGSN side -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I53cd54dfd262c70c425c3f13dad3b29526daa523 Gerrit-Change-Number: 24591 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Sun, 06 Jun 2021 23:35:32 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2_sns: implement outbound ADD_SNS procedures
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24123 ) Change subject: gprs_ns2_sns: implement outbound ADD_SNS procedures .. Patch Set 4: Code-Review-1 TODO: check SGSN side -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I71c33200bd1f0307ceb943ee958db5ebe3623d36 Gerrit-Change-Number: 24123 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Sun, 06 Jun 2021 23:35:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2_sns: implement local update weight procedure
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23187 ) Change subject: gprs_ns2_sns: implement local update weight procedure .. Patch Set 7: Code-Review-1 TODO: check SGSN side -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icec4dabb46bc198f68f91bfe09ba279fbe68d454 Gerrit-Change-Number: 23187 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Sun, 06 Jun 2021 23:35:21 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: RAW_NS/NS_Provider_IPL4: allow to use the new NSVC interface
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24401 ) Change subject: RAW_NS/NS_Provider_IPL4: allow to use the new NSVC interface .. Patch Set 4: Here is another solution which is just skipping the connect(). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24401 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iafd9310e04066958914201da0cbdcd563bd5c976 Gerrit-Change-Number: 24401 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Sun, 06 Jun 2021 23:24:18 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: RAW_NS/NS_Provider_IPL4: allow to use the new NSVC interface
Hello Jenkins Builder, fixeria, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24401 to look at the new patch set (#4). Change subject: RAW_NS/NS_Provider_IPL4: allow to use the new NSVC interface .. RAW_NS/NS_Provider_IPL4: allow to use the new NSVC interface RAW_NS used previous a single TTCN3 port for a single UDP port (source/listen side). This has the limitation that only a single NSVC could be tested for a local UDP port. However SNS tests require multiple NSVCs over a single UDP port. NS_Provider_IPL4 already supports multiple NSVCs for the NS_Emulation. Extend the support in NS_Provider_IPL4 to also allow RAW_NS to use multiple NSVCs. Related: OS#5036 Change-Id: Iafd9310e04066958914201da0cbdcd563bd5c976 --- M fr-net/gen_links.sh M fr/gen_links.sh M gbproxy/gen_links.sh M library/NS_Provider_IPL4.ttcn M library/RAW_NS.ttcnpp M ns/gen_links.sh M pcu/gen_links.sh M sgsn/gen_links.sh 8 files changed, 106 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/01/24401/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24401 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iafd9310e04066958914201da0cbdcd563bd5c976 Gerrit-Change-Number: 24401 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-CC: laforge Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: RAW_NS/NS_Provider_IPL4: allow to use the new NSVC interface
lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24593 ) Change subject: RAW_NS/NS_Provider_IPL4: allow to use the new NSVC interface .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3fe097a879918e3446dba55767db1a5b5ed5212a Gerrit-Change-Number: 24593 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon
Change in osmo-ttcn3-hacks[master]: NS_Tests: add test case TC_sns_bss_add_change_del
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580 to look at the new patch set (#4). Change subject: NS_Tests: add test case TC_sns_bss_add_change_del .. NS_Tests: add test case TC_sns_bss_add_change_del 1. do SNS configuration 2. add a bind 3. receive the SNS_ADD 4. before answering the SNS_ADD, change the weight via vty and remove the bind Related: OS#5036 Change-Id: Ibc565bba4c7e0a0b4dd28a48847dbdb998c8528d --- M ns/NS_Tests.ttcn 1 file changed, 47 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/24580/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibc565bba4c7e0a0b4dd28a48847dbdb998c8528d Gerrit-Change-Number: 24580 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: NS_Tests: add test case TC_sns_bss_add_change_del
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580 to look at the new patch set (#3). Change subject: NS_Tests: add test case TC_sns_bss_add_change_del .. NS_Tests: add test case TC_sns_bss_add_change_del 1. do SNS configuration 2. add a bind 3. receive the SNS_ADD 4. before answering the SNS_ADD, change the weight via vty and remove the bind Related: OS#5036 Change-Id: Ibc565bba4c7e0a0b4dd28a48847dbdb998c8528d --- M ns/NS_Tests.ttcn 1 file changed, 45 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/24580/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibc565bba4c7e0a0b4dd28a48847dbdb998c8528d Gerrit-Change-Number: 24580 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in libosmocore[master]: gprs_ns2_sns: implement outbound ADD_SNS procedures
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24123 ) Change subject: gprs_ns2_sns: implement outbound ADD_SNS procedures .. Patch Set 4: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I71c33200bd1f0307ceb943ee958db5ebe3623d36 Gerrit-Change-Number: 24123 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sun, 06 Jun 2021 23:13:32 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2_sns: implement local update weight procedure
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23187 ) Change subject: gprs_ns2_sns: implement local update weight procedure .. Patch Set 7: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icec4dabb46bc198f68f91bfe09ba279fbe68d454 Gerrit-Change-Number: 23187 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Sun, 06 Jun 2021 23:13:29 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2_sns: implement local update weight procedure
lynxis lazus has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23187 ) Change subject: gprs_ns2_sns: implement local update weight procedure .. Removed Code-Review-2 by lynxis lazus -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icec4dabb46bc198f68f91bfe09ba279fbe68d454 Gerrit-Change-Number: 23187 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: deleteVote
Change in osmo-ttcn3-hacks[master]: RAW_NS/NS_Provider_IPL4: allow to use the new NSVC interface
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24593 )
Change subject: RAW_NS/NS_Provider_IPL4: allow to use the new NSVC interface
..
RAW_NS/NS_Provider_IPL4: allow to use the new NSVC interface
RAW_NS used previous a single TTCN3 port for a single UDP port
(source/listen side).
This has the limitation that only a single NSVC could be tested for a
local UDP port. However SNS tests require multiple NSVCs over a single UDP port.
NS_Provider_IPL4 already supports multiple NSVCs for the NS_Emulation.
Extend the support in NS_Provider_IPL4 to also allow RAW_NS to use
multiple NSVCs.
Related: OS#5036
Change-Id: I3fe097a879918e3446dba55767db1a5b5ed5212a
---
M library/NS_Provider_IPL4.ttcn
M library/RAW_NS.ttcnpp
2 files changed, 100 insertions(+), 26 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/93/24593/1
diff --git a/library/NS_Provider_IPL4.ttcn b/library/NS_Provider_IPL4.ttcn
index 774c08a..09e7dc0 100644
--- a/library/NS_Provider_IPL4.ttcn
+++ b/library/NS_Provider_IPL4.ttcn
@@ -27,6 +27,7 @@
import from Misc_Helpers all;
import from NS_Emulation all;
+import from RAW_NS all;
import from NS_Types all;
import from IPL4asp_Types all;
@@ -42,6 +43,7 @@
/* per-NSVC ports and state */
port NS_PROVIDER_PT NSVC[NUM_MAX_NSVC];
+ var boolean g_nsvc_bound[NUM_MAX_NSVC];
var PerNsvcState g_nsvc[NUM_MAX_NSVC];
/* management port via which */
@@ -54,31 +56,35 @@
NSVC_CT vc_nsvc
};
-signature NSPIP_add_nsvc(charstring remote_ip, PortNumber remote_port, NSVC_CT
vc_nsvc);
-signature NSPIP_del_nsvc(charstring remote_ip, PortNumber remote_port);
+signature NSPIP_add_nsvc(charstring remote_ip, PortNumber remote_port, NSVC_CT
vc_nsvc) return integer;
+signature NSPIP_del_nsvc(charstring remote_ip, PortNumber remote_port) return
integer;
type port NSPIP_PROC_PT procedure {
inout NSPIP_add_nsvc, NSPIP_del_nsvc;
} with { extension "internal" };
/* add a new NSVC to the provider */
-private function f_nsvc_add(PerNsvcState nsvc) runs on NS_Provider_IPL4_CT
+private function f_nsvc_add(PerNsvcState nsvc) runs on NS_Provider_IPL4_CT
return integer
{
for (var integer i := 0; i < sizeof(g_nsvc); i := i+1) {
- if (g_nsvc[i].vc_nsvc == null) {
+ if (g_nsvc_bound[i] == false) {
g_nsvc[i] := nsvc;
- connect(self:NSVC[i], nsvc.vc_nsvc:NSCP);
- NSVC[i].send(NS_Provider_Evt:{link_status :=
NS_PROV_LINK_STATUS_UP});
- return;
+ g_nsvc_bound[i] := true;
+ if (isbound(nsvc.vc_nsvc) and nsvc.vc_nsvc != null) {
+ connect(self:NSVC[i], nsvc.vc_nsvc:NSCP);
+ NSVC[i].send(NS_Provider_Evt:{link_status :=
NS_PROV_LINK_STATUS_UP});
+ }
+ return i;
}
}
Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Overflow of
g_nsvc array"));
+ return -1;
}
-private function f_nsvc_del(PerNsvcState nsvc) runs on NS_Provider_IPL4_CT
+private function f_nsvc_del(PerNsvcState nsvc) runs on NS_Provider_IPL4_CT
return integer
{
for (var integer i := 0; i < sizeof(g_nsvc); i := i+1) {
- if (g_nsvc[i].vc_nsvc != null and
+ if (g_nsvc_bound[i] and
g_nsvc[i].remote_ip == nsvc.remote_ip and
g_nsvc[i].remote_port == nsvc.remote_port) {
g_nsvc[i] := {
@@ -86,19 +92,23 @@
remote_port := -,
vc_nsvc := null
}
+ g_nsvc_bound[i] := false;
NSVC[i].send(NS_Provider_Evt:{link_status :=
NS_PROV_LINK_STATUS_DOWN});
- disconnect(self:NSVC[i], nsvc.vc_nsvc:NSCP);
- return;
+ if (isbound(g_nsvc[i].vc_nsvc) and g_nsvc[i].vc_nsvc !=
null) {
+ disconnect(self:NSVC[i], nsvc.vc_nsvc:NSCP);
+ }
+ return i;
}
}
Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("attempt to
delete unknown NSVC"));
+ return -1;
}
private function f_get_nsvc_idx(charstring remote_ip, PortNumber remote_port)
runs on NS_Provider_IPL4_CT return integer
{
for (var integer i := 0; i < sizeof(g_nsvc); i := i+1) {
- if (g_nsvc[i].vc_nsvc != null and
+ if (g_nsvc_bound[i] and
g_nsvc[i].remote_ip == remote_ip and g_nsvc[i].remote_port
== remote_port) {
return i;
}
@@ -109,6 +119,7 @@
function main(NSVCConfiguration config, NSConfiguration
Change in osmo-ttcn3-hacks[master]: NS_Tests: add test case TC_sns_bss_add_change_del
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580 to look at the new patch set (#2). Change subject: NS_Tests: add test case TC_sns_bss_add_change_del .. NS_Tests: add test case TC_sns_bss_add_change_del 1. do SNS configuration 2. add a bind 3. receive the SNS_ADD 4. before answering the SNS_ADD, change the weight via vty and remove the bind Related: OS#5036 Change-Id: Ibc565bba4c7e0a0b4dd28a48847dbdb998c8528d --- M ns/NS_Tests.ttcn 1 file changed, 46 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/24580/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibc565bba4c7e0a0b4dd28a48847dbdb998c8528d Gerrit-Change-Number: 24580 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: NS_Tests: reset the weights of all udp binds
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24579 to look at the new patch set (#2). Change subject: NS_Tests: reset the weights of all udp binds .. NS_Tests: reset the weights of all udp binds Some test cases change the weight of the binds. Ensure all test cases starts with the same configuration. Related: OS#5036 Change-Id: Iae2ba130b2f7d29ec8b417f07d0bef87f74ce5a4 --- M ns/NS_Tests.ttcn 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/79/24579/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24579 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iae2ba130b2f7d29ec8b417f07d0bef87f74ce5a4 Gerrit-Change-Number: 24579 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: NS_Tests: add testcases for incoming SNS_ADD/DEL procedures
Hello Jenkins Builder, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24402 to look at the new patch set (#4). Change subject: NS_Tests: add testcases for incoming SNS_ADD/DEL procedures .. NS_Tests: add testcases for incoming SNS_ADD/DEL procedures Allow to test add and remove a bind via vty. Related: OS#5036 Change-Id: I98c04c083521ab38b58e8df9f1aee89445ab536d --- M ns/NS_Tests.sns.cfg M ns/NS_Tests.ttcn M ns/osmo-ns.sns.cfg 3 files changed, 69 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/02/24402/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I98c04c083521ab38b58e8df9f1aee89445ab536d Gerrit-Change-Number: 24402 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: RAW_NS: f_incoming_sns_chg_weight() allow to receive/send the chg_wei...
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24578 to look at the new patch set (#2). Change subject: RAW_NS: f_incoming_sns_chg_weight() allow to receive/send the chg_weight over a different .. RAW_NS: f_incoming_sns_chg_weight() allow to receive/send the chg_weight over a different The SGSN/PCU will use a different NSVC as the NSVC which will be changed weight'ed. Related: OS#5036 Change-Id: I5766afaa74db30d94318312ab775e7933b9df783 --- M library/RAW_NS.ttcnpp 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/78/24578/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24578 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5766afaa74db30d94318312ab775e7933b9df783 Gerrit-Change-Number: 24578 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Build failure of network:osmocom:nightly/osmo-bsc in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 479s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/-g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z,relro -o isdnsync isdnsync.o [ 479s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z -Wl,relro -o isdnsync isdnsync.o -pthread [ 479s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o meas_json-meas_json.o `test -f 'meas_json.c' || echo './'`meas_json.c [ 479s] /bin/bash ../../libtool --tag=CC --mode=link gcc -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z,relro -o meas_json meas_json-meas_json.o ../../src/osmo-bsc/abis_nm.o ../../src/osmo-bsc/acc.o ../../src/osmo-bsc/bts.o ../../src/osmo-bsc/bts_sm.o ../../src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o ../../src/osmo-bsc/bts_trx.o ../../src/osmo-bsc/gsm_data.o ../../src/osmo-bsc/nm_common_fsm.o ../../src/osmo-bsc/nm_bts_sm_fsm.o ../../src/osmo-bsc/nm_bts_fsm.o ../../src/osmo-bsc/nm_bb_transc_fsm.o ../../src/osmo-bsc/nm_channel_fsm.o ../../src/osmo-bsc/nm_gprs_cell_fsm.o ../../src/osmo-bsc/nm_gprs_nse_fsm.o ../../src/osmo-bsc/nm_gprs_nsvc_fsm.o ../../src/osmo-bsc/nm_rcarrier_fsm.o -ltalloc -losmocore -ltalloc -losmogsm -losmocore -losmoabis [ 480s] libtool: link: gcc -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z -Wl,relro -o meas_json meas_json-meas_json.o ../../src/osmo-bsc/abis_nm.o ../../src/osmo-bsc/acc.o ../../src/osmo-bsc/bts.o ../../src/osmo-bsc/bts_sm.o ../../src/osmo-bsc/bts_ipaccess_nanobts_omlattr.o ../../src/osmo-bsc/bts_trx.o ../../src/osmo-bsc/gsm_data.o ../../src/osmo-bsc/nm_common_fsm.o ../../src/osmo-bsc/nm_bts_sm_fsm.o ../../src/osmo-bsc/nm_bts_fsm.o ../../src/osmo-bsc/nm_bb_transc_fsm.o ../../src/osmo-bsc/nm_channel_fsm.o ../../src/osmo-bsc/nm_gprs_cell_fsm.o ../../src/osmo-bsc/nm_gprs_nse_fsm.o ../../src/osmo-bsc/nm_gprs_nsvc_fsm.o ../../src/osmo-bsc/nm_rcarrier_fsm.o -ltalloc /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so /usr/lib/x86_64-linux-gnu/libosmoabis.so -pthread [ 480s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o meas_vis-meas_vis.o `test -f 'meas_vis.c' || echo './'`meas_vis.c [ 480s] meas_vis.c: In function 'write_uni': [ 480s] meas_vis.c:196:16: error: 'struct gsm_meas_rep' has no member named 'bs_power'; did you mean 'bs_power_db'? [ 480s] 196 | pwr = ms->mr.bs_power; [ 480s] |^~~~ [ 480s] |bs_power_db [ 480s] make[4]: *** [Makefile:736: meas_vis-meas_vis.o] Error 1 [ 480s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/utils' [ 480s] make[3]: *** [Makefile:403: all-recursive] Error 1 [ 480s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 480s] make[2]: *** [Makefile:455: all-recursive] Error 1 [
Change in osmo-bts[master]: [VAMOS] trx_sched_init_ts(): assign names to per-timeslot counters
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bts/+/24592 )
Change subject: [VAMOS] trx_sched_init_ts(): assign names to per-timeslot
counters
..
[VAMOS] trx_sched_init_ts(): assign names to per-timeslot counters
Thanks to [1], it's now possible to associate a human-readable
name with a rate counter group. Before this API, we had to use
weird index values for each timeslot, and with introduction
of the shadow timeslots the situation got even worse.
In change [2] I introduced rate_ctr_group_set_name_fmt() to
allow passing a format string - use it in this patch.
Change-Id: Ie872ab37661fa5d44f219f59c7daaa1033113289
Depends: [1] I0dc510783dd9ae8436dae8005a7b3330e80d36f3
Depends: [2] I6e813476cfb6a0ad275c4a51e9f065eeca8cb406
---
M src/common/scheduler.c
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/92/24592/1
diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index 3ab94a2..a946bbf 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -622,6 +622,10 @@
l1ts->ctrs = rate_ctr_group_alloc(ts->trx,
_ts_ctrg_desc,
rate_ctr_idx);
+ rate_ctr_group_set_name_fmt(l1ts->ctrs, "bts%u-trx%u-ts%u%s",
+ ts->trx->bts->nr, ts->trx->nr, ts->nr,
+ ts->vamos.is_shadow ? "-shadow" : "");
+
INIT_LLIST_HEAD(>dl_prims);
for (i = 0; i < ARRAY_SIZE(l1ts->chan_state); i++) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24592
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie872ab37661fa5d44f219f59c7daaa1033113289
Gerrit-Change-Number: 24592
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Build failure of network:osmocom:latest/libosmo-sccp in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/Debian_Unstable/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: /var/cache/obs/worker/root_1/.pkgs/libosmocore-dev.deb: Input/output error (worker was cloud115:1) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in libosmocore[master]: gprs_ns2_sns: implement outbound DEL SNS procedures
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/24591 )
Change subject: gprs_ns2_sns: implement outbound DEL SNS procedures
..
gprs_ns2_sns: implement outbound DEL SNS procedures
When removing a bind the remote side needs to be
informed via the SNS-DELETE procedure.
Related: OS#5036
Change-Id: I53cd54dfd262c70c425c3f13dad3b29526daa523
---
M src/gb/gprs_ns2_sns.c
1 file changed, 76 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/91/24591/1
diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index 656e06f..091a62b 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -592,6 +592,32 @@
return -1;
}
+static int remove_bind_elem(struct ns2_sns_state *gss, struct ns2_sns_elems
*elems, struct ns2_sns_bind *sbind)
+{
+ struct gprs_ns_ie_ip4_elem ip4;
+ struct gprs_ns_ie_ip6_elem ip6;
+ const struct osmo_sockaddr *saddr =
gprs_ns2_ip_bind_sockaddr(sbind->bind);
+
+ switch (saddr->u.sa.sa_family) {
+ case AF_INET:
+ ip4.ip_addr = saddr->u.sin.sin_addr.s_addr;
+ ip4.udp_port = saddr->u.sin.sin_port;
+ ip4.sig_weight = sbind->bind->sns_sig_weight;
+ ip4.data_weight = sbind->bind->sns_data_weight;
+ return remove_ip4_elem(gss, elems, );
+ case AF_INET6:
+ memcpy(_addr, >u.sin6.sin6_addr, sizeof(struct
in6_addr));
+ ip6.udp_port = saddr->u.sin.sin_port;
+ ip6.sig_weight = sbind->bind->sns_sig_weight;
+ ip6.data_weight = sbind->bind->sns_data_weight;
+ return remove_ip6_elem(gss, elems, );
+ default:
+ return -1;
+ }
+
+ return -1;
+}
+
static int do_sns_change_weight(struct osmo_fsm_inst *fi, const struct
gprs_ns_ie_ip4_elem *ip4, const struct gprs_ns_ie_ip6_elem *ip6)
{
struct ns2_sns_state *gss = (struct ns2_sns_state *) fi->priv;
@@ -1484,6 +1510,12 @@
else
ns2_tx_sns_change_weight(gss->sns_nsvc,
gss->current_procedure->trans_id, NULL, 0, >current_procedure->ip6, 1);
break;
+ case SNS_DEL:
+ if (gss->family == AF_INET)
+ ns2_tx_sns_del(gss->sns_nsvc,
gss->current_procedure->trans_id, >current_procedure->ip4, 1, NULL, 0);
+ else
+ ns2_tx_sns_del(gss->sns_nsvc,
gss->current_procedure->trans_id, NULL, 0, >current_procedure->ip6, 1);
+ break;
default:
break;
}
@@ -1596,8 +1628,11 @@
add_ip6_elem(gss, >local,
>current_procedure->ip6);
break;
}
- create_nsvc_for_new_sbind(gss,
gss->current_procedure->sbind);
- gprs_ns2_start_alive_all_nsvcs(nse);
+ /* the sbind can be NULL if the bind has been released
by del_bind */
+ if (gss->current_procedure->sbind) {
+ create_nsvc_for_new_sbind(gss,
gss->current_procedure->sbind);
+ gprs_ns2_start_alive_all_nsvcs(nse);
+ }
break;
case SNS_CHANGE_WEIGHT:
switch (gss->family) {
@@ -1630,6 +1665,16 @@
OSMO_ASSERT(0);
}
break;
+ case SNS_DEL:
+ switch (gss->family) {
+ case AF_INET:
+ remove_ip4_elem(gss, >local,
>current_procedure->ip4);
+ break;
+ case AF_INET6:
+ remove_ip6_elem(gss, >local,
>current_procedure->ip6);
+ break;
+ }
+ break;
default:
break;
}
@@ -1851,6 +1896,8 @@
switch (procedure_type) {
case SNS_ADD:
break;
+ case SNS_DEL:
+ break;
case SNS_CHANGE_WEIGHT:
llist_for_each_entry(procedure, >procedures, list) {
if (procedure->sbind == sbind && procedure->procedure
== procedure_type &&
@@ -1881,8 +1928,16 @@
if (!procedure)
return;
+ switch (procedure_type) {
+ case SNS_ADD:
+ case SNS_CHANGE_WEIGHT:
+ procedure->sbind = sbind;
+ break;
+ default:
+ break;
+ }
+
llist_add_tail(>list, >procedures);
- procedure->sbind = sbind;
procedure->procedure = procedure_type;
procedure->sig_weight = sbind->bind->sns_sig_weight;
procedure->data_weight =
Change in libosmocore[master]: gprs_ns2_sns: bss: set gss->family
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/24590 )
Change subject: gprs_ns2_sns: bss: set gss->family
..
gprs_ns2_sns: bss: set gss->family
gss->family (and gss->ip) was never set.
So IPv6 should have never worked.
Fixes: e769f5226be6 ("gprs_ns2_sns: rework IP-SNS initial remote")
Related: OS#5036
Change-Id: I4e39dc5c7f766a7040645ceb62afdf6a9cfad00f
---
M src/gb/gprs_ns2_sns.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/90/24590/1
diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index ec4bd87..588dd02 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -1598,6 +1598,7 @@
gss->initial = llist_entry(gss->initial->list.next,
struct sns_endpoint, list);
}
+ gss->family = gss->initial->saddr.u.sa.sa_family;
gss->reselection_running = false;
osmo_fsm_inst_state_chg(fi, GPRS_SNS_ST_BSS_SIZE,
nse->nsi->timeout[NS_TOUT_TSNS_PROV], 1);
break;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24590
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4e39dc5c7f766a7040645ceb62afdf6a9cfad00f
Gerrit-Change-Number: 24590
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in libosmocore[master]: gprs_ns2_sns: replace ns2_sns_type with address family
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/24589 )
Change subject: gprs_ns2_sns: replace ns2_sns_type with address family
..
gprs_ns2_sns: replace ns2_sns_type with address family
Reduces the code as the conversion between address family (bind)
and ns2_sns_type is not needed anymore.
Related: OS#5036
Change-Id: I1bcdd43af34c926d4b88491d00669422c299bef7
---
M src/gb/gprs_ns2_sns.c
1 file changed, 23 insertions(+), 28 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/89/24589/1
diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index 0badcee..ec4bd87 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -56,11 +56,6 @@
#define S(x) (1 << (x))
-enum ns2_sns_type {
- IPv4,
- IPv6,
-};
-
enum ns2_sns_role {
GPRS_SNS_ROLE_BSS,
GPRS_SNS_ROLE_SGSN,
@@ -132,7 +127,7 @@
struct ns2_sns_state {
struct gprs_ns2_nse *nse;
- enum ns2_sns_type ip;
+ int family;
enum ns2_sns_role role; /* local role: BSS or SGSN */
/* holds the list of initial SNS endpoints */
@@ -665,14 +660,14 @@
/* Upon receiving an SNS-ADD PDU, if the consequent number of IPv4
endpoints
* exceeds the number of IPv4 endpoints supported by the NSE, the NSE
shall send
* an SNS-ACK PDU with a cause code set to "Invalid number of IP4
Endpoints". */
- switch (gss->ip) {
- case IPv4:
+ switch (gss->family) {
+ case AF_INET:
if (gss->remote.num_ip4 >= gss->num_max_ip4_remote)
return -NS_CAUSE_INVAL_NR_NS_VC;
/* TODO: log message duplicate */
rc = add_ip4_elem(gss, >remote, ip4);
break;
- case IPv6:
+ case AF_INET6:
if (gss->remote.num_ip6 >= gss->num_max_ip6_remote)
return -NS_CAUSE_INVAL_NR_NS_VC;
/* TODO: log message duplicate */
@@ -689,8 +684,8 @@
/* Upon receiving an SNS-ADD PDU containing an already configured IP
endpoint the
* NSE shall send an SNS-ACK PDU with the cause code "Protocol error -
* unspecified" */
- switch (gss->ip) {
- case IPv4:
+ switch (gss->family) {
+ case AF_INET:
nsvc = nsvc_by_ip4_elem(nse, ip4);
if (nsvc) {
/* the nsvc should be already in sync with the ip4 /
ip6 elements */
@@ -700,7 +695,7 @@
/* TODO: failure case */
ns2_nsvc_create_ip4(fi, nse, ip4);
break;
- case IPv6:
+ case AF_INET6:
nsvc = nsvc_by_ip6_elem(nse, ip6);
if (nsvc) {
/* the nsvc should be already in sync with the ip4 /
ip6 elements */
@@ -751,7 +746,7 @@
}
}
-static int ns2_sns_count_num_local_ep(struct osmo_fsm_inst *fi, enum
ns2_sns_type stype)
+static int ns2_sns_count_num_local_ep(struct osmo_fsm_inst *fi, int ip_proto)
{
struct ns2_sns_state *gss = (struct ns2_sns_state *) fi->priv;
struct ns2_sns_bind *sbind;
@@ -762,12 +757,12 @@
if (!sa)
continue;
- switch (stype) {
- case IPv4:
+ switch (ip_proto) {
+ case AF_INET:
if (sa->u.sas.ss_family == AF_INET)
count++;
break;
- case IPv6:
+ case AF_INET6:
if (sa->u.sas.ss_family == AF_INET6)
count++;
break;
@@ -805,8 +800,8 @@
return;
}
- switch (gss->ip) {
- case IPv4:
+ switch (gss->family) {
+ case AF_INET:
ip4_elems = talloc_realloc(fi, gss->local.ip4, struct
gprs_ns_ie_ip4_elem, count);
if (!ip4_elems)
return;
@@ -840,7 +835,7 @@
gss->local.num_ip4 = count;
gss->num_max_nsvcs = OSMO_MAX(gss->num_max_ip4_remote *
gss->local.num_ip4, 8);
break;
- case IPv6:
+ case AF_INET6:
/* IPv6 */
ip6_elems = talloc_realloc(fi, gss->local.ip6, struct
gprs_ns_ie_ip6_elem, count);
if (!ip6_elems)
@@ -959,13 +954,13 @@
gss->N = 0;
/* Transmit SNS-CONFIG */
- switch (gss->ip) {
- case IPv4:
+ switch (gss->family) {
+ case AF_INET:
ns2_tx_sns_config(gss->sns_nsvc, true,
gss->local.ip4, gss->local.num_ip4,
NULL, 0);
break;
- case IPv6:
+ case AF_INET6:
ns2_tx_sns_config(gss->sns_nsvc, true,
NULL, 0,
Change in libosmocore[master]: gprs_ns2_sns: refactor nss_weight_sum_data -> ip46_weight_sum_data
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/24588 )
Change subject: gprs_ns2_sns: refactor nss_weight_sum_data ->
ip46_weight_sum_data
..
gprs_ns2_sns: refactor nss_weight_sum_data -> ip46_weight_sum_data
Allow to use ip46_weight_sum_data for local endpoints as well.
Related: OS#5036
Change-Id: I75d88f3da89ad13e34a3fd5ae72bd967d81f4abc
---
M src/gb/gprs_ns2_sns.c
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/88/24588/1
diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index 66765f3..0badcee 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -209,13 +209,13 @@
#define ip6_weight_sum_data(elems) ip6_weight_sum(elems, true)
#define ip6_weight_sum_sig(elems) ip6_weight_sum(elems, false)
-static int nss_weight_sum(const struct ns2_sns_state *nss, bool data_weight)
+static int ip46_weight_sum(const struct ns2_sns_elems *elems, bool data_weight)
{
- return ip4_weight_sum(>remote, data_weight) +
- ip6_weight_sum(>remote, data_weight);
+ return ip4_weight_sum(elems, data_weight) +
+ ip6_weight_sum(elems, data_weight);
}
-#define nss_weight_sum_data(nss) nss_weight_sum(nss, true)
-#define nss_weight_sum_sig(nss)nss_weight_sum(nss, false)
+#define ip46_weight_sum_data(elems)ip46_weight_sum(elems, true)
+#define ip46_weight_sum_sig(elems) ip46_weight_sum(elems, false)
static struct gprs_ns2_vc *nsvc_by_ip4_elem(struct gprs_ns2_nse *nse,
const struct gprs_ns_ie_ip4_elem
*ip4)
@@ -1067,7 +1067,7 @@
}
if (event == GPRS_SNS_EV_RX_CONFIG_END) {
/* check if sum of data / sig weights == 0 */
- if (nss_weight_sum_data(gss) == 0 ||
nss_weight_sum_sig(gss) == 0) {
+ if (ip46_weight_sum_data(>remote) == 0 ||
ip46_weight_sum_sig(>remote) == 0) {
cause = NS_CAUSE_INVAL_WEIGH;
ns2_tx_sns_config_ack(gss->sns_nsvc, );
osmo_fsm_inst_state_chg(fi,
GPRS_SNS_ST_UNCONFIGURED, 0, 0);
@@ -2094,7 +2094,7 @@
/* only change state if last CONFIG was received */
if (event == GPRS_SNS_EV_RX_CONFIG_END) {
/* ensure sum of data weight / sig weights is > 0 */
- if (nss_weight_sum_data(gss) == 0 ||
nss_weight_sum_sig(gss) == 0) {
+ if (ip46_weight_sum_data(>remote) == 0 ||
ip46_weight_sum_sig(>remote) == 0) {
cause = NS_CAUSE_INVAL_WEIGH;
ns2_tx_sns_config_ack(gss->sns_nsvc, );
osmo_fsm_inst_state_chg(fi,
GPRS_SNS_ST_UNCONFIGURED, 0, 0);
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24588
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I75d88f3da89ad13e34a3fd5ae72bd967d81f4abc
Gerrit-Change-Number: 24588
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in libosmocore[master]: gprs_ns2_sns: refactor ip4_weight_sum/ip6_weight_sum
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/24587 )
Change subject: gprs_ns2_sns: refactor ip4_weight_sum/ip6_weight_sum
..
gprs_ns2_sns: refactor ip4_weight_sum/ip6_weight_sum
Use the new introduced struct ns2_sns_elems instead of
the elems seperate.
Related: OS#5036
Change-Id: I0956ab6085554210569188f52cae121e32fca19b
---
M src/gb/gprs_ns2_sns.c
1 file changed, 14 insertions(+), 16 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/87/24587/1
diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index 2e84d16..66765f3 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -176,45 +176,43 @@
}
/* helper function to compute the sum of all (data or signaling) weights */
-static int ip4_weight_sum(const struct gprs_ns_ie_ip4_elem *ip4, unsigned int
num,
- bool data_weight)
+static int ip4_weight_sum(const struct ns2_sns_elems *elems, bool data_weight)
{
unsigned int i;
int weight_sum = 0;
- for (i = 0; i < num; i++) {
+ for (i = 0; i < elems->num_ip4; i++) {
if (data_weight)
- weight_sum += ip4[i].data_weight;
+ weight_sum += elems->ip4[i].data_weight;
else
- weight_sum += ip4[i].sig_weight;
+ weight_sum += elems->ip4[i].sig_weight;
}
return weight_sum;
}
-#define ip4_weight_sum_data(x,y) ip4_weight_sum(x, y, true)
-#define ip4_weight_sum_sig(x,y)ip4_weight_sum(x, y, false)
+#define ip4_weight_sum_data(elems) ip4_weight_sum(elems, true)
+#define ip4_weight_sum_sig(elems) ip4_weight_sum(elems, false)
/* helper function to compute the sum of all (data or signaling) weights */
-static int ip6_weight_sum(const struct gprs_ns_ie_ip6_elem *ip6, unsigned int
num,
- bool data_weight)
+static int ip6_weight_sum(const struct ns2_sns_elems *elems, bool data_weight)
{
unsigned int i;
int weight_sum = 0;
- for (i = 0; i < num; i++) {
+ for (i = 0; i < elems->num_ip6; i++) {
if (data_weight)
- weight_sum += ip6[i].data_weight;
+ weight_sum += elems->ip6[i].data_weight;
else
- weight_sum += ip6[i].sig_weight;
+ weight_sum += elems->ip6[i].sig_weight;
}
return weight_sum;
}
-#define ip6_weight_sum_data(x,y) ip6_weight_sum(x, y, true)
-#define ip6_weight_sum_sig(x,y)ip6_weight_sum(x, y, false)
+#define ip6_weight_sum_data(elems) ip6_weight_sum(elems, true)
+#define ip6_weight_sum_sig(elems) ip6_weight_sum(elems, false)
static int nss_weight_sum(const struct ns2_sns_state *nss, bool data_weight)
{
- return ip4_weight_sum(nss->remote.ip4, nss->remote.num_ip4,
data_weight) +
- ip6_weight_sum(nss->remote.ip6, nss->remote.num_ip6,
data_weight);
+ return ip4_weight_sum(>remote, data_weight) +
+ ip6_weight_sum(>remote, data_weight);
}
#define nss_weight_sum_data(nss) nss_weight_sum(nss, true)
#define nss_weight_sum_sig(nss)nss_weight_sum(nss, false)
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24587
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0956ab6085554210569188f52cae121e32fca19b
Gerrit-Change-Number: 24587
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in libosmocore[master]: gprs_ns2_sns: add check for duplicates to add_ip6_elem()
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/24586 )
Change subject: gprs_ns2_sns: add check for duplicates to add_ip6_elem()
..
gprs_ns2_sns: add check for duplicates to add_ip6_elem()
The ip4 version already checks for duplicates.
Related: OS#5036
Change-Id: I4a1528ea3427946ce465085919b2b522d3cedd07
---
M src/gb/gprs_ns2_sns.c
1 file changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/86/24586/1
diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index c50b2b9..2e84d16 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -452,10 +452,8 @@
static int add_ip4_elem(struct ns2_sns_state *gss, struct ns2_sns_elems *elems,
const struct gprs_ns_ie_ip4_elem *ip4)
{
- unsigned int i;
-
/* check for duplicates */
- for (i = 0; i < elems->num_ip4; i++) {
+ for (unsigned int i = 0; i < elems->num_ip4; i++) {
if (memcmp(>ip4[i], ip4, sizeof(*ip4)))
continue;
return -1;
@@ -507,6 +505,12 @@
static int add_ip6_elem(struct ns2_sns_state *gss, struct ns2_sns_elems *elems,
const struct gprs_ns_ie_ip6_elem *ip6)
{
+ /* check for duplicates */
+ for (unsigned int i = 0; i < elems->num_ip6; i++) {
+ if (memcmp(>ip6[i], ip6, sizeof(*ip6)))
+ continue;
+ return -1;
+ }
elems->ip6 = talloc_realloc(gss, elems->ip6, struct gprs_ns_ie_ip6_elem,
elems->num_ip6+1);
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24586
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4a1528ea3427946ce465085919b2b522d3cedd07
Gerrit-Change-Number: 24586
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in libosmocore[master]: gprs_ns2_sns: move gss->remote specific check out of add_ip4_elem/add...
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/24585 )
Change subject: gprs_ns2_sns: move gss->remote specific check out of
add_ip4_elem/add_ip6_elem
..
gprs_ns2_sns: move gss->remote specific check out of add_ip4_elem/add_ip6_elem
Allow to use the add_ip4_elem also with local elemens.
Related: OS#5036
Change-Id: Ib48dfd7567467e60c5af2348924ece5cc6124206
---
M src/gb/gprs_ns2_sns.c
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/85/24585/1
diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index 20076ed..c50b2b9 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -454,15 +454,11 @@
{
unsigned int i;
- if (gss->remote.num_ip4 >= gss->num_max_ip4_remote)
- return -NS_CAUSE_INVAL_NR_NS_VC;
-
/* check for duplicates */
for (i = 0; i < elems->num_ip4; i++) {
if (memcmp(>ip4[i], ip4, sizeof(*ip4)))
continue;
- /* TODO: log message duplicate */
- return -NS_CAUSE_PROTO_ERR_UNSPEC;
+ return -1;
}
elems->ip4 = talloc_realloc(gss, elems->ip4, struct gprs_ns_ie_ip4_elem,
@@ -511,8 +507,6 @@
static int add_ip6_elem(struct ns2_sns_state *gss, struct ns2_sns_elems *elems,
const struct gprs_ns_ie_ip6_elem *ip6)
{
- if (elems->num_ip6 >= gss->num_max_ip6_remote)
- return -NS_CAUSE_INVAL_NR_NS_VC;
elems->ip6 = talloc_realloc(gss, elems->ip6, struct gprs_ns_ie_ip6_elem,
elems->num_ip6+1);
@@ -671,9 +665,15 @@
* an SNS-ACK PDU with a cause code set to "Invalid number of IP4
Endpoints". */
switch (gss->ip) {
case IPv4:
+ if (gss->remote.num_ip4 >= gss->num_max_ip4_remote)
+ return -NS_CAUSE_INVAL_NR_NS_VC;
+ /* TODO: log message duplicate */
rc = add_ip4_elem(gss, >remote, ip4);
break;
case IPv6:
+ if (gss->remote.num_ip6 >= gss->num_max_ip6_remote)
+ return -NS_CAUSE_INVAL_NR_NS_VC;
+ /* TODO: log message duplicate */
rc = add_ip6_elem(gss, >remote, ip6);
break;
default:
@@ -682,7 +682,7 @@
}
if (rc)
- return rc;
+ return -NS_CAUSE_PROTO_ERR_UNSPEC;
/* Upon receiving an SNS-ADD PDU containing an already configured IP
endpoint the
* NSE shall send an SNS-ACK PDU with the cause code "Protocol error -
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24585
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib48dfd7567467e60c5af2348924ece5cc6124206
Gerrit-Change-Number: 24585
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in libosmocore[master]: gprs_ns2_sns: use struct ns2_sns_elems in add/update/remove remote_elems
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/24584 )
Change subject: gprs_ns2_sns: use struct ns2_sns_elems in add/update/remove
remote_elems
..
gprs_ns2_sns: use struct ns2_sns_elems in add/update/remove remote_elems
Prepare to use the function also with local elems.
Related: OS#5036
Change-Id: I7db43c8dbd5bd7e7b07a7d629d2615bfa18623db
---
M src/gb/gprs_ns2_sns.c
1 file changed, 47 insertions(+), 41 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/24584/1
diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index 0c1ca6d..20076ed 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -449,7 +449,8 @@
}
/* Add a given remote IPv4 element to gprs_sns_state */
-static int add_remote_ip4_elem(struct ns2_sns_state *gss, const struct
gprs_ns_ie_ip4_elem *ip4)
+static int add_ip4_elem(struct ns2_sns_state *gss, struct ns2_sns_elems *elems,
+ const struct gprs_ns_ie_ip4_elem *ip4)
{
unsigned int i;
@@ -457,93 +458,98 @@
return -NS_CAUSE_INVAL_NR_NS_VC;
/* check for duplicates */
- for (i = 0; i < gss->remote.num_ip4; i++) {
- if (memcmp(>remote.ip4[i], ip4, sizeof(*ip4)))
+ for (i = 0; i < elems->num_ip4; i++) {
+ if (memcmp(>ip4[i], ip4, sizeof(*ip4)))
continue;
/* TODO: log message duplicate */
return -NS_CAUSE_PROTO_ERR_UNSPEC;
}
- gss->remote.ip4 = talloc_realloc(gss, gss->remote.ip4, struct
gprs_ns_ie_ip4_elem,
-gss->remote.num_ip4+1);
- gss->remote.ip4[gss->remote.num_ip4] = *ip4;
- gss->remote.num_ip4 += 1;
+ elems->ip4 = talloc_realloc(gss, elems->ip4, struct gprs_ns_ie_ip4_elem,
+elems->num_ip4+1);
+ elems->ip4[elems->num_ip4] = *ip4;
+ elems->num_ip4 += 1;
return 0;
}
/* Remove a given remote IPv4 element from gprs_sns_state */
-static int remove_remote_ip4_elem(struct ns2_sns_state *gss, const struct
gprs_ns_ie_ip4_elem *ip4)
+static int remove_ip4_elem(struct ns2_sns_state *gss, struct ns2_sns_elems
*elems,
+ const struct gprs_ns_ie_ip4_elem *ip4)
{
unsigned int i;
- for (i = 0; i < gss->remote.num_ip4; i++) {
- if (memcmp(>remote.ip4[i], ip4, sizeof(*ip4)))
+ for (i = 0; i < elems->num_ip4; i++) {
+ if (memcmp(>ip4[i], ip4, sizeof(*ip4)))
continue;
/* all array elements < i remain as they are; all > i are
shifted left by one */
- memmove(>remote.ip4[i], >remote.ip4[i+1],
gss->remote.num_ip4-i-1);
- gss->remote.num_ip4 -= 1;
+ memmove(>ip4[i], >ip4[i+1], elems->num_ip4-i-1);
+ elems->num_ip4 -= 1;
return 0;
}
return -1;
}
/* update the weights for specified remote IPv4 */
-static int update_remote_ip4_elem(struct ns2_sns_state *gss, const struct
gprs_ns_ie_ip4_elem *ip4)
+static int update_ip4_elem(struct ns2_sns_state *gss, struct ns2_sns_elems
*elems,
+ const struct gprs_ns_ie_ip4_elem *ip4)
{
unsigned int i;
- for (i = 0; i < gss->remote.num_ip4; i++) {
- if (gss->remote.ip4[i].ip_addr != ip4->ip_addr ||
- gss->remote.ip4[i].udp_port != ip4->udp_port)
+ for (i = 0; i < elems->num_ip4; i++) {
+ if (elems->ip4[i].ip_addr != ip4->ip_addr ||
+ elems->ip4[i].udp_port != ip4->udp_port)
continue;
- gss->remote.ip4[i].sig_weight = ip4->sig_weight;
- gss->remote.ip4[i].data_weight = ip4->data_weight;
+ elems->ip4[i].sig_weight = ip4->sig_weight;
+ elems->ip4[i].data_weight = ip4->data_weight;
return 0;
}
return -1;
}
/* Add a given remote IPv6 element to gprs_sns_state */
-static int add_remote_ip6_elem(struct ns2_sns_state *gss, const struct
gprs_ns_ie_ip6_elem *ip6)
+static int add_ip6_elem(struct ns2_sns_state *gss, struct ns2_sns_elems *elems,
+ const struct gprs_ns_ie_ip6_elem *ip6)
{
- if (gss->remote.num_ip6 >= gss->num_max_ip6_remote)
+ if (elems->num_ip6 >= gss->num_max_ip6_remote)
return -NS_CAUSE_INVAL_NR_NS_VC;
- gss->remote.ip6 = talloc_realloc(gss, gss->remote.ip6, struct
gprs_ns_ie_ip6_elem,
-gss->remote.num_ip6+1);
- gss->remote.ip6[gss->remote.num_ip6] = *ip6;
- gss->remote.num_ip6 += 1;
+ elems->ip6 = talloc_realloc(gss, elems->ip6, struct gprs_ns_ie_ip6_elem,
+elems->num_ip6+1);
+ elems->ip6[elems->num_ip6] = *ip6;
+
Change in libosmocore[master]: gprs_ns2_sns: refactor ns2_clear_ipv46_entries_local to use new elems...
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/24583 )
Change subject: gprs_ns2_sns: refactor ns2_clear_ipv46_entries_local to use new
elems functions
..
gprs_ns2_sns: refactor ns2_clear_ipv46_entries_local to use new elems functions
Related: OS#5036
Change-Id: I7225f7a4215842f0ea601ce6d9d38220f98f808d
---
M src/gb/gprs_ns2_sns.c
1 file changed, 10 insertions(+), 19 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/83/24583/1
diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index 66dd421..0c1ca6d 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -295,22 +295,13 @@
osmo_fsm_inst_dispatch(fi, GPRS_SNS_EV_REQ_NO_NSVC, NULL);
}
-static void ns2_clear_ipv46_entries_local(struct ns2_sns_state *gss)
+static void ns2_clear_elems(struct ns2_sns_elems *elems)
{
- TALLOC_FREE(gss->local.ip4);
- TALLOC_FREE(gss->local.ip6);
+ TALLOC_FREE(elems->ip4);
+ TALLOC_FREE(elems->ip6);
- gss->local.num_ip4 = 0;
- gss->local.num_ip6 = 0;
-}
-
-static void ns2_clear_ipv46_entries_remote(struct ns2_sns_state *gss)
-{
- TALLOC_FREE(gss->remote.ip4);
- TALLOC_FREE(gss->remote.ip6);
-
- gss->remote.num_ip4 = 0;
- gss->remote.num_ip6 = 0;
+ elems->num_ip4 = 0;
+ elems->num_ip6 = 0;
}
static void ns2_vc_create_ip(struct osmo_fsm_inst *fi, struct gprs_ns2_nse
*nse, const struct osmo_sockaddr *remote,
@@ -789,7 +780,7 @@
struct osmo_sockaddr local;
int count;
- ns2_clear_ipv46_entries_local(gss);
+ ns2_clear_elems(>local);
/* no initial available */
if (gss->role == GPRS_SNS_ROLE_BSS) {
@@ -1585,8 +1576,8 @@
* gprs_ns2_free_nsvcs() will trigger NO_NSVC, prevent this
from triggering a reselection */
gss->reselection_running = true;
gprs_ns2_free_nsvcs(nse);
- ns2_clear_ipv46_entries_local(gss);
- ns2_clear_ipv46_entries_remote(gss);
+ ns2_clear_elems(>local);
+ ns2_clear_elems(>remote);
/* Choose the next sns endpoint. */
if (!ns2_sns_bss_valid_configuration(gss)) {
@@ -2282,8 +2273,8 @@
/* clear all state */
osmo_fsm_inst_state_chg(fi, GPRS_SNS_ST_UNCONFIGURED,
0, 0);
gss->N = 0;
- ns2_clear_ipv46_entries_local(gss);
- ns2_clear_ipv46_entries_remote(gss);
+ ns2_clear_elems(>local);
+ ns2_clear_elems(>remote);
llist_for_each_entry_safe(nsvc, nsvc2, >nse->nsvc,
list) {
if (nsvc == gss->sns_nsvc) {
/* keep the NSVC we need for SNS, but
unconfigure it */
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24583
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7225f7a4215842f0ea601ce6d9d38220f98f808d
Gerrit-Change-Number: 24583
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in libosmocore[master]: gprs_ns2_sns: refactor local and remote entries into a struct
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/24582 )
Change subject: gprs_ns2_sns: refactor local and remote entries into a struct
..
gprs_ns2_sns: refactor local and remote entries into a struct
The IPv4/IPv6 elemens are the same for local and remote.
Refactor the entries into a struct to use function to manipulate
them with a single function.
Related: OS#5036
Change-Id: I05e053a9eb3328655502dfe2981c8f402104e292
---
M src/gb/gprs_ns2_sns.c
1 file changed, 102 insertions(+), 105 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/82/24582/1
diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index 9865acd..66dd421 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -122,6 +122,13 @@
struct gprs_ns2_vc_bind *bind;
};
+struct ns2_sns_elems {
+ struct gprs_ns_ie_ip4_elem *ip4;
+ unsigned int num_ip4;
+ struct gprs_ns_ie_ip6_elem *ip6;
+ unsigned int num_ip6;
+};
+
struct ns2_sns_state {
struct gprs_ns2_nse *nse;
@@ -150,26 +157,16 @@
bool alive;
/* local configuration to send to the remote end */
- struct gprs_ns_ie_ip4_elem *ip4_local;
- size_t num_ip4_local;
+ struct ns2_sns_elems local;
- /* local configuration to send to the remote end */
- struct gprs_ns_ie_ip6_elem *ip6_local;
- size_t num_ip6_local;
+ /* remote configuration as received */
+ struct ns2_sns_elems remote;
/* local configuration about our capabilities in terms of connections to
* remote (SGSN) side */
size_t num_max_nsvcs;
size_t num_max_ip4_remote;
size_t num_max_ip6_remote;
-
- /* remote configuration as received */
- struct gprs_ns_ie_ip4_elem *ip4_remote;
- unsigned int num_ip4_remote;
-
- /* remote configuration as received */
- struct gprs_ns_ie_ip6_elem *ip6_remote;
- unsigned int num_ip6_remote;
};
static inline struct gprs_ns2_nse *nse_inst_from_fi(struct osmo_fsm_inst *fi)
@@ -216,8 +213,8 @@
static int nss_weight_sum(const struct ns2_sns_state *nss, bool data_weight)
{
- return ip4_weight_sum(nss->ip4_remote, nss->num_ip4_remote,
data_weight) +
- ip6_weight_sum(nss->ip6_remote, nss->num_ip6_remote,
data_weight);
+ return ip4_weight_sum(nss->remote.ip4, nss->remote.num_ip4,
data_weight) +
+ ip6_weight_sum(nss->remote.ip6, nss->remote.num_ip6,
data_weight);
}
#define nss_weight_sum_data(nss) nss_weight_sum(nss, true)
#define nss_weight_sum_sig(nss)nss_weight_sum(nss, false)
@@ -300,20 +297,20 @@
static void ns2_clear_ipv46_entries_local(struct ns2_sns_state *gss)
{
- TALLOC_FREE(gss->ip4_local);
- TALLOC_FREE(gss->ip6_local);
+ TALLOC_FREE(gss->local.ip4);
+ TALLOC_FREE(gss->local.ip6);
- gss->num_ip4_local = 0;
- gss->num_ip6_local = 0;
+ gss->local.num_ip4 = 0;
+ gss->local.num_ip6 = 0;
}
static void ns2_clear_ipv46_entries_remote(struct ns2_sns_state *gss)
{
- TALLOC_FREE(gss->ip4_remote);
- TALLOC_FREE(gss->ip6_remote);
+ TALLOC_FREE(gss->remote.ip4);
+ TALLOC_FREE(gss->remote.ip6);
- gss->num_ip4_remote = 0;
- gss->num_ip6_remote = 0;
+ gss->remote.num_ip4 = 0;
+ gss->remote.num_ip6 = 0;
}
static void ns2_vc_create_ip(struct osmo_fsm_inst *fi, struct gprs_ns2_nse
*nse, const struct osmo_sockaddr *remote,
@@ -393,8 +390,8 @@
unsigned int i;
/* iterate over all remote IPv4 endpoints */
- for (i = 0; i < gss->num_ip4_remote; i++) {
- const struct gprs_ns_ie_ip4_elem *ip4 = >ip4_remote[i];
+ for (i = 0; i < gss->remote.num_ip4; i++) {
+ const struct gprs_ns_ie_ip4_elem *ip4 = >remote.ip4[i];
remote.u.sin.sin_family = AF_INET;
remote.u.sin.sin_addr.s_addr = ip4->ip_addr;
@@ -425,8 +422,8 @@
}
/* iterate over all remote IPv4 endpoints */
- for (i = 0; i < gss->num_ip6_remote; i++) {
- const struct gprs_ns_ie_ip6_elem *ip6 = >ip6_remote[i];
+ for (i = 0; i < gss->remote.num_ip6; i++) {
+ const struct gprs_ns_ie_ip6_elem *ip6 = >remote.ip6[i];
remote.u.sin6.sin6_family = AF_INET6;
remote.u.sin6.sin6_addr = ip6->ip_addr;
@@ -465,21 +462,21 @@
{
unsigned int i;
- if (gss->num_ip4_remote >= gss->num_max_ip4_remote)
+ if (gss->remote.num_ip4 >= gss->num_max_ip4_remote)
return -NS_CAUSE_INVAL_NR_NS_VC;
/* check for duplicates */
- for (i = 0; i < gss->num_ip4_remote; i++) {
- if (memcmp(>ip4_remote[i], ip4, sizeof(*ip4)))
+ for (i = 0; i < gss->remote.num_ip4; i++) {
+ if (memcmp(>remote.ip4[i], ip4, sizeof(*ip4)))
Change in libosmocore[master]: gprs_ns2_sns: bss: improve validation of configuration
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/24581 )
Change subject: gprs_ns2_sns: bss: improve validation of configuration
..
gprs_ns2_sns: bss: improve validation of configuration
Some combination of IPv4 and IPv6 result in incomplete
combination.
E.g. IPv6 binds, but only IPv4 endpoints and vice versa.
Related: OS#5036
Change-Id: I2fcf67bc2431ddac23c4ae23cebbb29771e573f1
---
M src/gb/gprs_ns2_sns.c
1 file changed, 49 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/24581/1
diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index 5d85ec0..9865acd 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -1519,6 +1519,54 @@
}
}
+/* validate the bss configuration (sns endpoint and binds)
+ * - no endpoints -> invalid
+ * - no binds -> invalid
+ * - only v4 sns endpoints, only v6 binds -> invalid
+ * - only v4 sns endpoints, but v4 sig weights == 0 -> invalid ...
+ */
+static int ns2_sns_bss_valid_configuration(struct ns2_sns_state *gss)
+{
+ struct ns2_sns_bind *sbind;
+ struct sns_endpoint *endpoint;
+ const struct osmo_sockaddr *addr;
+ int v4_sig = 0, v4_data = 0, v6_sig = 0, v6_data = 0;
+ bool v4_endpoints = false;
+ bool v6_endpoints = false;
+
+ if (llist_empty(>sns_endpoints) || llist_empty(>binds))
+ return 0;
+
+ llist_for_each_entry(sbind, >binds, list) {
+ addr = gprs_ns2_ip_bind_sockaddr(sbind->bind);
+ if (!addr)
+ continue;
+ switch (addr->u.sa.sa_family) {
+ case AF_INET:
+ v4_sig += sbind->bind->sns_sig_weight;
+ v4_data += sbind->bind->sns_data_weight;
+ break;
+ case AF_INET6:
+ v6_sig += sbind->bind->sns_sig_weight;
+ v6_data += sbind->bind->sns_data_weight;
+ break;
+ }
+ }
+
+ llist_for_each_entry(endpoint, >sns_endpoints, list) {
+ switch (endpoint->saddr.u.sa.sa_family) {
+ case AF_INET:
+ v4_endpoints = true;
+ break;
+ case AF_INET6:
+ v6_endpoints = true;
+ break;
+ }
+ }
+
+ return (v4_endpoints && v4_sig && v4_data) || (v6_endpoints && v6_sig
&& v6_data);
+}
+
/* allstate-action for BSS role */
static void ns2_sns_st_all_action_bss(struct osmo_fsm_inst *fi, uint32_t
event, void *data)
{
@@ -1544,7 +1592,7 @@
ns2_clear_ipv46_entries_remote(gss);
/* Choose the next sns endpoint. */
- if (llist_empty(>sns_endpoints) ||
llist_empty(>binds)) {
+ if (!ns2_sns_bss_valid_configuration(gss)) {
gss->initial = NULL;
ns2_prim_status_ind(gss->nse, NULL, 0,
GPRS_NS2_AFF_CAUSE_SNS_NO_ENDPOINTS);
osmo_fsm_inst_state_chg(fi, GPRS_SNS_ST_UNCONFIGURED,
0, 3);
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24581
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2fcf67bc2431ddac23c4ae23cebbb29771e573f1
Gerrit-Change-Number: 24581
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in libosmocore[master]: gprs_ns2_sns: move selection of the next bind into own function
Hello Jenkins Builder, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/24122 to look at the new patch set (#5). Change subject: gprs_ns2_sns: move selection of the next bind into own function .. gprs_ns2_sns: move selection of the next bind into own function It will be also used by del_bind() when removing an active bind Related: OS#5036 Change-Id: Ic39f0e5474ecc055d9a1b6a7b30777574d8b741d --- M src/gb/gprs_ns2_sns.c 1 file changed, 10 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/22/24122/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic39f0e5474ecc055d9a1b6a7b30777574d8b741d Gerrit-Change-Number: 24122 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: NS_Tests: add test case TC_sns_bss_add_change_del
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580 )
Change subject: NS_Tests: add test case TC_sns_bss_add_change_del
..
NS_Tests: add test case TC_sns_bss_add_change_del
1. do SNS configuration
2. add a bind
3. receive the SNS_ADD
4. before answering the SNS_ADD, change the weight via vty and remove the bind
Change-Id: Ibc565bba4c7e0a0b4dd28a48847dbdb998c8528d
---
M ns/NS_Tests.ttcn
1 file changed, 46 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/80/24580/1
diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn
index 3971f0d..6d53bd8 100644
--- a/ns/NS_Tests.ttcn
+++ b/ns/NS_Tests.ttcn
@@ -580,6 +580,51 @@
f_clean_ns_codec();
}
+/* 1. do SNS configuration
+ * 2. add a bind
+ * 3. receive the SNS_ADD
+ * 4. before answering the SNS_ADD, change the weight via vty and remove the
bind
+ */
+testcase TC_sns_bss_add_change_del() runs on RAW_Test_CT {
+ var PDU_NS rx;
+ var NSVCConfiguration nsvc_cfg;
+
+ g_handle_rx_alive := true;
+ f_init_vty();
+ f_init_ns_codec(mp_nsconfig);
+ f_init_ns_codec(mp_nsconfig, 1);
+ f_incoming_sns_size();
+ f_incoming_sns_config();
+ f_outgoing_sns_config();
+ activate(as_rx_alive_tx_ack());
+ f_vty_config2(NSVTY, {"ns", "nse " & int2str(g_nsconfig.nsei)},
"ip-sns-bind local2");
+
+
+ nsvc_cfg := g_nsconfig.nsvc[1];
+ if (nsvc_cfg.provider.ip.address_family == AF_INET) {
+ var template (omit) IP4_Elements v4_elem := {
ts_SNS_IPv4(nsvc_cfg.provider.ip.remote_ip,
+
nsvc_cfg.provider.ip.remote_udp_port,
+1, 1) };
+ rx := f_ns_exp(tr_SNS_ADD(g_nsconfig.nsei, ?, v4 := v4_elem),
0);
+ } else {
+ var template (omit) IP6_Elements v6_elem := {
ts_SNS_IPv6(nsvc_cfg.provider.ip.remote_ip,
+
nsvc_cfg.provider.ip.remote_udp_port,
+1, 1) };
+ rx := f_ns_exp(tr_SNS_ADD(g_nsconfig.nsei, ?, omit, v6_elem),
0);
+ }
+
+ /* delete the endpoint */
+ f_vty_config2(NSVTY, {"ns", "bind udp local2"}, "ip-sns
signalling-weight 99 data-weight 99");
+ f_vty_config2(NSVTY, {"ns", "nse " & int2str(g_nsconfig.nsei)}, "no
ip-sns-bind local2");
+ NSCP[0].send(ts_SNS_ACK(g_nsconfig.nsei, rx.pDU_SNS_Add.transactionID));
+
+ //f_ns_exp(tr_SNS_CHG_WEIGHT(g_nsconfig.nsei, ?, ?, ?), 0)
+ f_incoming_sns_chg_weight(idx_chg := 1);
+ f_incoming_sns_del(idx_del := 1, w_sig := 99, w_user := 99);
+ setverdict(pass);
+ f_clean_ns_codec();
+}
+
control {
if (mp_dialect == NS2_DIALECT_STATIC_RESETBLOCK or mp_dialect ==
NS2_DIALECT_IPACCESS) {
execute( TC_tx_reset() );
@@ -629,6 +674,7 @@
execute( TC_sns_bss_change_weight_timeout() );
execute( TC_sns_bss_add() );
execute( TC_sns_bss_del() );
+ execute( TC_sns_bss_add_change_del() );
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibc565bba4c7e0a0b4dd28a48847dbdb998c8528d
Gerrit-Change-Number: 24580
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: NS_Tests: reset the weights of all udp binds
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24579 )
Change subject: NS_Tests: reset the weights of all udp binds
..
NS_Tests: reset the weights of all udp binds
Some test cases change the weight of the binds. Ensure all test cases
starts with the same configuration.
Change-Id: Iae2ba130b2f7d29ec8b417f07d0bef87f74ce5a4
---
M ns/NS_Tests.ttcn
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/79/24579/1
diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn
index 58b2dda..3971f0d 100644
--- a/ns/NS_Tests.ttcn
+++ b/ns/NS_Tests.ttcn
@@ -73,6 +73,8 @@
f_vty_transceive(NSVTY, "enable");
f_vty_transceive(NSVTY, "nsvc nsei " & int2str(mp_nsconfig.nsei) & "
force-unconfigured");
f_vty_config2(NSVTY, {"ns", "nse " & int2str(mp_nsconfig.nsei)}, "no
ip-sns-bind local2");
+ f_vty_config2(NSVTY, {"ns", "bind udp local"}, "ip-sns
signalling-weight 1 data-weight 1");
+ f_vty_config2(NSVTY, {"ns", "bind udp local2"}, "ip-sns
signalling-weight 1 data-weight 1");
}
/* ensure no matching message is received within 'tout' */
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24579
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iae2ba130b2f7d29ec8b417f07d0bef87f74ce5a4
Gerrit-Change-Number: 24579
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: RAW_NS: f_incoming_sns_chg_weight() allow to receive/send the chg_wei...
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24578 )
Change subject: RAW_NS: f_incoming_sns_chg_weight() allow to receive/send the
chg_weight over a different
..
RAW_NS: f_incoming_sns_chg_weight() allow to receive/send the chg_weight over a
different
The SGSN/PCU will use a different NSVC as the NSVC which will be changed
weight'ed.
Change-Id: I5766afaa74db30d94318312ab775e7933b9df783
---
M library/RAW_NS.ttcnpp
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/78/24578/1
diff --git a/library/RAW_NS.ttcnpp b/library/RAW_NS.ttcnpp
index 8f986e4..42efb7d 100644
--- a/library/RAW_NS.ttcnpp
+++ b/library/RAW_NS.ttcnpp
@@ -408,11 +408,11 @@
}
/* perform inbound SNS-CHANGE-WEIGHT procedure */
-function f_incoming_sns_chg_weight(template (omit) NsCause cause := omit,
integer idx := 0)
+function f_incoming_sns_chg_weight(integer idx_chg := 0, template (omit)
NsCause cause := omit, integer idx := 0)
runs on RAW_NS_CT {
log("f_incoming_sns_chg_weight(idx=", idx, ")");
var PDU_NS rx;
- var NSVCConfiguration nsvc_cfg := g_nsconfig.nsvc[idx];
+ var NSVCConfiguration nsvc_cfg := g_nsconfig.nsvc[idx_chg];
if (nsvc_cfg.provider.ip.address_family == AF_INET) {
var template IP4_Elements v4_elem := {
tr_SNS_IPv4(nsvc_cfg.provider.ip.remote_ip,
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24578
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5766afaa74db30d94318312ab775e7933b9df783
Gerrit-Change-Number: 24578
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Build failure of network:osmocom:latest/libosmocore in openSUSE_Tumbleweed/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmocore/openSUSE_Tumbleweed/x86_64 Package network:osmocom:latest/libosmocore failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmocore Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/liblua5_4-5.rpm: Input/output error (worker was cloud115:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmocom-nightly in openSUSE_Tumbleweed/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmocom-nightly/openSUSE_Tumbleweed/x86_64 Package network:osmocom:nightly/osmocom-nightly failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmocom-nightly Last lines of build log: /var/cache/obs/worker/root_2/.pkgs/zlib-devel.rpm: Input/output error (worker was cloud115:2) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in libosmocore[master]: stats_vty: also show rate counter group name (if present)
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/24577 )
Change subject: stats_vty: also show rate counter group name (if present)
..
stats_vty: also show rate counter group name (if present)
Change-Id: I358f52e81a85f041fc21960634d04d18e7883dd5
---
M src/vty/stats_vty.c
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/77/24577/1
diff --git a/src/vty/stats_vty.c b/src/vty/stats_vty.c
index 630ee32..d5d3292 100644
--- a/src/vty/stats_vty.c
+++ b/src/vty/stats_vty.c
@@ -555,7 +555,10 @@
static int rate_ctr_group_handler(struct rate_ctr_group *ctrg, void *sctx_)
{
struct vty *vty = sctx_;
- vty_out(vty, "%s %u:%s", ctrg->desc->group_description, ctrg->idx,
VTY_NEWLINE);
+ vty_out(vty, "%s %u", ctrg->desc->group_description, ctrg->idx);
+ if (ctrg->name != NULL)
+ vty_out(vty, " (%s)", ctrg->name);
+ vty_out(vty, ":%s", VTY_NEWLINE);
vty_out_rate_ctr_group_fmt(vty, "%25n: %10c (%S/s %M/m %H/h %D/d) %d",
ctrg);
return 0;
}
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24577
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I358f52e81a85f041fc21960634d04d18e7883dd5
Gerrit-Change-Number: 24577
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in libosmocore[master]: stat, rate_ctr: allow setting group name using a format string
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/24576 )
Change subject: stat,rate_ctr: allow setting group name using a format string
..
stat,rate_ctr: allow setting group name using a format string
Change-Id: I6e813476cfb6a0ad275c4a51e9f065eeca8cb406
---
M include/osmocom/core/rate_ctr.h
M include/osmocom/core/stat_item.h
M src/rate_ctr.c
M src/stat_item.c
4 files changed, 50 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/76/24576/1
diff --git a/include/osmocom/core/rate_ctr.h b/include/osmocom/core/rate_ctr.h
index d944cc0..40b432c 100644
--- a/include/osmocom/core/rate_ctr.h
+++ b/include/osmocom/core/rate_ctr.h
@@ -76,6 +76,7 @@
grp->idx = idx;
}
void rate_ctr_group_set_name(struct rate_ctr_group *grp, const char *name);
+void rate_ctr_group_set_name_fmt(struct rate_ctr_group *grp, const char *fmt,
...);
struct rate_ctr *rate_ctr_group_get_ctr(struct rate_ctr_group *grp, unsigned
int idx);
diff --git a/include/osmocom/core/stat_item.h b/include/osmocom/core/stat_item.h
index fbe0433..377c762 100644
--- a/include/osmocom/core/stat_item.h
+++ b/include/osmocom/core/stat_item.h
@@ -83,6 +83,7 @@
}
struct osmo_stat_item *osmo_stat_item_group_get_item(struct
osmo_stat_item_group *grp, unsigned int idx);
void osmo_stat_item_group_set_name(struct osmo_stat_item_group *statg, const
char *name);
+void osmo_stat_item_group_set_name_fmt(struct osmo_stat_item_group *statg,
const char *fmt, ...);
void osmo_stat_item_group_free(struct osmo_stat_item_group *statg);
void osmo_stat_item_inc(struct osmo_stat_item *item, int32_t value);
diff --git a/src/rate_ctr.c b/src/rate_ctr.c
index 4d99699..b860b86 100644
--- a/src/rate_ctr.c
+++ b/src/rate_ctr.c
@@ -283,6 +283,30 @@
osmo_talloc_replace_string(grp, >name, name);
}
+/*! Similar to rate_ctr_group_set_name(), but accepts a format string.
+ * \param[in] grp Rate counter group.
+ * \param[in] fmt Format string for the name.
+ * \param[in] ... Variable argument list for the format string.
+ */
+void rate_ctr_group_set_name_fmt(struct rate_ctr_group *grp,
+const char *fmt, ...)
+{
+ char *name = NULL;
+
+ if (grp->name != NULL)
+ talloc_free(grp->name);
+
+ if (fmt != NULL) {
+ va_list ap;
+
+ va_start(ap, fmt);
+ name = talloc_vasprintf(grp, fmt, ap);
+ va_end(ap);
+ }
+
+ grp->name = name;
+}
+
/*! Add a number to the counter */
void rate_ctr_add(struct rate_ctr *ctr, int inc)
{
diff --git a/src/stat_item.c b/src/stat_item.c
index 55aa951..c81c704 100644
--- a/src/stat_item.c
+++ b/src/stat_item.c
@@ -187,6 +187,30 @@
osmo_talloc_replace_string(statg, >name, name);
}
+/*! Similar to osmo_stat_item_group_set_name(), but accepts a format string.
+ * \param[in] statg Rate counter group.
+ * \param[in] fmt Format string for the name.
+ * \param[in] ... Variable argument list for the format string.
+ */
+void osmo_stat_item_group_set_name_fmt(struct osmo_stat_item_group *statg,
+ const char *fmt, ...)
+{
+ char *name = NULL;
+
+ if (statg->name != NULL)
+ talloc_free(statg->name);
+
+ if (fmt != NULL) {
+ va_list ap;
+
+ va_start(ap, fmt);
+ name = talloc_vasprintf(statg, fmt, ap);
+ va_end(ap);
+ }
+
+ statg->name = name;
+}
+
/*! Increase the stat_item to the given value.
* This function adds a new value for the given stat_item at the end of
* the FIFO.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24576
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6e813476cfb6a0ad275c4a51e9f065eeca8cb406
Gerrit-Change-Number: 24576
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: add two handover_test cases for upgrade of TCH/H -> TCH/F
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24571 ) Change subject: add two handover_test cases for upgrade of TCH/H -> TCH/F .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib88f7e00d8bd77e2b02a7242a0fab4dd79333037 Gerrit-Change-Number: 24571 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sun, 06 Jun 2021 15:48:02 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: msc_tx_common_id(): fix potential NULL pointer dereference
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-msc/+/24575 )
Change subject: msc_tx_common_id(): fix potential NULL pointer dereference
..
msc_tx_common_id(): fix potential NULL pointer dereference
Reported by GCC 11.1.0. msc_a_vsub() may return NULL.
Change-Id: Iebdd6399e819a03258398e6b7b453bda37e45a20
---
M src/libmsc/msc_a.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/75/24575/1
diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c
index 391d251..05030d3 100644
--- a/src/libmsc/msc_a.c
+++ b/src/libmsc/msc_a.c
@@ -1638,6 +1638,8 @@
int msc_tx_common_id(struct msc_a *msc_a, enum msc_role to_role)
{
struct vlr_subscr *vsub = msc_a_vsub(msc_a);
+ if (vsub == NULL)
+ return -ENODEV;
struct ran_msg msg = {
.msg_type = RAN_MSG_COMMON_ID,
.common_id = {
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/24575
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Iebdd6399e819a03258398e6b7b453bda37e45a20
Gerrit-Change-Number: 24575
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Build failure of network:osmocom:latest/libosmocore in openSUSE_Tumbleweed/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmocore/openSUSE_Tumbleweed/x86_64 Package network:osmocom:latest/libosmocore failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmocore Last lines of build log: /var/cache/obs/worker/root_2/.pkgs/zlib-devel.rpm: Input/output error (worker was cloud115:2) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmocom-nightly in openSUSE_Tumbleweed/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmocom-nightly/openSUSE_Tumbleweed/x86_64 Package network:osmocom:nightly/osmocom-nightly failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmocom-nightly Last lines of build log: /var/cache/obs/worker/root_2/.pkgs/zlib-devel.rpm: Input/output error (worker was cloud115:2) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-bsc[master]: implement Channel Mode Modify to VAMOS mode
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24374 ) Change subject: implement Channel Mode Modify to VAMOS mode .. Patch Set 18: (3 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/24374/10/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/24374/10/src/osmo-bsc/bsc_vty.c@2174 PS10, Line 2174: modify lchan > Agree with Harald here. Done https://gerrit.osmocom.org/c/osmo-bsc/+/24374/10/src/osmo-bsc/bsc_vty.c@2193 PS10, Line 2193:vty_out(vty, "Invalid sub-slot number for this timeslot type%s", VTY_NEWLINE); > Missing %% prefix. Done https://gerrit.osmocom.org/c/osmo-bsc/+/24374/10/src/osmo-bsc/bsc_vty.c@2198 PS10, Line 2198:vty_out(vty, "BTS does not support VAMOS%s", VTY_NEWLINE); > Missing %% prefix. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibf53f4797d7491b17a33946fd7d920f038362b4c Gerrit-Change-Number: 24374 Gerrit-PatchSet: 18 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Sun, 06 Jun 2021 12:31:02 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Comment-In-Reply-To: laforge Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Build failure of network:osmocom:nightly/ulfius in openSUSE_Tumbleweed/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/openSUSE_Tumbleweed/i586 Package network:osmocom:nightly/ulfius failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/orcania-devel.rpm: Input/output error (worker was cloud115:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in simtrace2[master]: simtrace2-list: Use osmo_st2_compatible_dev_ids[]
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/24523 ) Change subject: simtrace2-list: Use osmo_st2_compatible_dev_ids[] .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/24523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I2231006b94c33fe3b28ce37b0d54c67206751058 Gerrit-Change-Number: 24523 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 06 Jun 2021 10:22:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in simtrace2[master]: firmware: octsimtest: ensure all card_insert GPIO are 0 after reset
laforge has submitted this change. (
https://gerrit.osmocom.org/c/simtrace2/+/24573 )
Change subject: firmware: octsimtest: ensure all card_insert GPIO are 0 after
reset
..
firmware: octsimtest: ensure all card_insert GPIO are 0 after reset
Change-Id: I3c3744673ba53750cb66aa5023c8228edb006bfc
---
M firmware/libboard/octsimtest/source/board_octsimtest.c
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/firmware/libboard/octsimtest/source/board_octsimtest.c
b/firmware/libboard/octsimtest/source/board_octsimtest.c
index c77c1ce..d8b1cc4 100644
--- a/firmware/libboard/octsimtest/source/board_octsimtest.c
+++ b/firmware/libboard/octsimtest/source/board_octsimtest.c
@@ -79,8 +79,10 @@
mux_init();
i2c_pin_init();
/* PORT A: all outputs, Port B0 output, B1..B7 unused */
- if (mcp23017_init(MCP23017_ADDRESS, 0x00, 0xfe) == 0)
+ if (mcp23017_init(MCP23017_ADDRESS, 0x00, 0xfe) == 0) {
mcp2317_present = true;
+ mcp23017_set_output_a(MCP23017_ADDRESS, 0);
+ }
/* Initialize checking for card insert/remove events */
//card_present_init();
#endif
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/24573
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I3c3744673ba53750cb66aa5023c8228edb006bfc
Gerrit-Change-Number: 24573
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in simtrace2[master]: firmware: octsimtest: Add i/I command for setting card-insert via I2C...
laforge has submitted this change. (
https://gerrit.osmocom.org/c/simtrace2/+/24572 )
Change subject: firmware: octsimtest: Add i/I command for setting card-insert
via I2C GPIO
..
firmware: octsimtest: Add i/I command for setting card-insert via I2C GPIO
Change-Id: Ie1483ccf8465df0d640d55e50421fda910dced4a
---
M firmware/libboard/octsimtest/source/board_octsimtest.c
1 file changed, 10 insertions(+), 4 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/firmware/libboard/octsimtest/source/board_octsimtest.c
b/firmware/libboard/octsimtest/source/board_octsimtest.c
index 5dff046..c77c1ce 100644
--- a/firmware/libboard/octsimtest/source/board_octsimtest.c
+++ b/firmware/libboard/octsimtest/source/board_octsimtest.c
@@ -35,10 +35,11 @@
switch (ch) {
case '?':
printf("\t?\thelp\n\r");
+ printf("\t0-8\tselect physical SIM slot\n\r");
printf("\tR\treset SAM3\n\r");
printf("\tm\trun mcp23017 test\n\r");
- printf("\tR\ttoggle MSB of gpio on mcp23017\n\r");
- printf("\t0-8\tselect physical SIM slot\n\r");
+ printf("\ti\tset card insert via I2C\n\r");
+ printf("\tI\tdisable card insert\n\r");
break;
case '0': mux_set_slot(0); break;
case '1': mux_set_slot(1); break;
@@ -56,8 +57,13 @@
case 'm':
mcp23017_test(MCP23017_ADDRESS);
break;
- case 't':
- mcp23017_toggle(MCP23017_ADDRESS);
+ case 'i':
+ printf("Setting card insert (slot=%u)\r\n", mux_get_slot());
+ mcp23017_set_output_a(MCP23017_ADDRESS, (1 << mux_get_slot()));
+ break;
+ case 'I':
+ printf("Releasing card insert (slot=%u)\r\n", mux_get_slot());
+ mcp23017_set_output_a(MCP23017_ADDRESS, 0);
break;
default:
printf("Unknown command '%c'\n\r", ch);
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/24572
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Ie1483ccf8465df0d640d55e50421fda910dced4a
Gerrit-Change-Number: 24572
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in simtrace2[master]: firmware: octsimtest: ensure all card_insert GPIO are 0 after reset
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/24573 ) Change subject: firmware: octsimtest: ensure all card_insert GPIO are 0 after reset .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/24573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I3c3744673ba53750cb66aa5023c8228edb006bfc Gerrit-Change-Number: 24573 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 06 Jun 2021 10:21:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in simtrace2[master]: firmware: octsimtest: Add i/I command for setting card-insert via I2C...
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/24572 ) Change subject: firmware: octsimtest: Add i/I command for setting card-insert via I2C GPIO .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/24572 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie1483ccf8465df0d640d55e50421fda910dced4a Gerrit-Change-Number: 24572 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 06 Jun 2021 10:21:55 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in simtrace2[master]: firmware: octsimtest: ensure all card_insert GPIO are 0 after reset
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/simtrace2/+/24573 )
Change subject: firmware: octsimtest: ensure all card_insert GPIO are 0 after
reset
..
firmware: octsimtest: ensure all card_insert GPIO are 0 after reset
Change-Id: I3c3744673ba53750cb66aa5023c8228edb006bfc
---
M firmware/libboard/octsimtest/source/board_octsimtest.c
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/73/24573/1
diff --git a/firmware/libboard/octsimtest/source/board_octsimtest.c
b/firmware/libboard/octsimtest/source/board_octsimtest.c
index c77c1ce..d8b1cc4 100644
--- a/firmware/libboard/octsimtest/source/board_octsimtest.c
+++ b/firmware/libboard/octsimtest/source/board_octsimtest.c
@@ -79,8 +79,10 @@
mux_init();
i2c_pin_init();
/* PORT A: all outputs, Port B0 output, B1..B7 unused */
- if (mcp23017_init(MCP23017_ADDRESS, 0x00, 0xfe) == 0)
+ if (mcp23017_init(MCP23017_ADDRESS, 0x00, 0xfe) == 0) {
mcp2317_present = true;
+ mcp23017_set_output_a(MCP23017_ADDRESS, 0);
+ }
/* Initialize checking for card insert/remove events */
//card_present_init();
#endif
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/24573
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I3c3744673ba53750cb66aa5023c8228edb006bfc
Gerrit-Change-Number: 24573
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-MessageType: newchange
Change in simtrace2[master]: Introduce simtrace2-tool
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/simtrace2/+/24574 )
Change subject: Introduce simtrace2-tool
..
Introduce simtrace2-tool
The simtrace-tool isa command line tool which can be used to e.g.
manually request a modem reset.
Change-Id: I3a8896ac2b3caef7590b51118359e5caed820a40
---
M host/src/Makefile.am
A host/src/simtrace2-tool.c
2 files changed, 341 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/74/24574/1
diff --git a/host/src/Makefile.am b/host/src/Makefile.am
index fa5be6e..17be9eb 100644
--- a/host/src/Makefile.am
+++ b/host/src/Makefile.am
@@ -5,10 +5,12 @@
LDADD= $(top_builddir)/lib/libosmo-simtrace2.la \
$(LIBOSMOCORE_LIBS) $(LIBOSMOSIM_LIBS) $(LIBOSMOUSB_LIBS) $(LIBUSB_LIBS)
-bin_PROGRAMS = simtrace2-cardem-pcsc simtrace2-list simtrace2-sniff
+bin_PROGRAMS = simtrace2-cardem-pcsc simtrace2-list simtrace2-sniff
simtrace2-tool
simtrace2_cardem_pcsc_SOURCES = simtrace2-cardem-pcsc.c
simtrace2_list_SOURCES = simtrace2_usb.c
simtrace2_sniff_SOURCES = simtrace2-sniff.c
+
+simtrace2_tool_SOURCES = simtrace2-tool.c
diff --git a/host/src/simtrace2-tool.c b/host/src/simtrace2-tool.c
new file mode 100644
index 000..56ec791
--- /dev/null
+++ b/host/src/simtrace2-tool.c
@@ -0,0 +1,338 @@
+/* simtrace2-tool - main program for the host PC to provide a remote SIM
+ * using the SIMtrace 2 firmware in card emulation mode
+ *
+ * (C) 2019 by Harald Welte
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301,
USA.
+ */
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#define _GNU_SOURCE
+#include
+
+#include
+
+#include
+
+#include
+#include
+#include
+#include
+
+#include
+#include
+
+/***
+ * Incoming Messages
+ ***/
+
+static void print_welcome(void)
+{
+ printf("simtrace2-tool\n"
+ "(C) 2019 Harald Welte \n");
+}
+
+static void print_help(void)
+{
+ printf( "simtrace2-tool [OPTIONS] COMMAND\n\n");
+ printf( "Options:\n"
+ "\t-h\t--help\n"
+ "\t-V\t--usb-vendor\tVENDOR_ID\n"
+ "\t-P\t--usb-product\tPRODUCT_ID\n"
+ "\t-C\t--usb-config\tCONFIG_ID\n"
+ "\t-I\t--usb-interface\tINTERFACE_ID\n"
+ "\t-S\t--usb-altsetting ALTSETTING_ID\n"
+ "\t-A\t--usb-address\tADDRESS\n"
+ "\t-H\t--usb-path\tPATH\n"
+ "\n"
+ );
+ printf( "Commands:\n"
+ "\tmodem reset (enable|disable|cycle)\n"
+ "\tmodem sim-switch (local|remote)\n"
+ "\n");
+}
+
+static const struct option opts[] = {
+ { "help", 0, 0, 'h' },
+ { "usb-vendor", 1, 0, 'V' },
+ { "usb-product", 1, 0, 'P' },
+ { "usb-config", 1, 0, 'C' },
+ { "usb-interface", 1, 0, 'I' },
+ { "usb-altsetting", 1, 0, 'S' },
+ { "usb-address", 1, 0, 'A' },
+ { "usb-path", 1, 0, 'H' },
+ { NULL, 0, 0, 0 }
+};
+
+static void run_mainloop(struct osmo_st2_cardem_inst *ci)
+{
+ struct osmo_st2_transport *transp = ci->slot->transp;
+ uint8_t buf[16*265];
+ int xfer_len;
+ int rc;
+
+ while (1) {
+ /* read data from SIMtrace2 device */
+ rc = libusb_bulk_transfer(transp->usb_devh, transp->usb_ep.in,
+ buf, sizeof(buf), _len, 100);
+ if (rc < 0 && rc != LIBUSB_ERROR_TIMEOUT &&
+ rc != LIBUSB_ERROR_INTERRUPTED &&
+ rc != LIBUSB_ERROR_IO) {
+ fprintf(stderr, "BULK IN transfer error; rc=%d\n", rc);
+ return;
+ }
+ /* break the loop if no new messages arrive within 100ms */
+ if (rc == LIBUSB_ERROR_TIMEOUT)
+ return;
+ }
+}
+
+static struct osmo_st2_transport _transp;
+
+static struct osmo_st2_slot _slot = {
+ .transp = &_transp,
+ .slot_nr = 0,
+};
+
+struct osmo_st2_cardem_inst _ci = {
+ .slot = &_slot,
+};
+
+struct
Change in simtrace2[master]: firmware: octsimtest: Add i/I command for setting card-insert via I2C...
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/simtrace2/+/24572 )
Change subject: firmware: octsimtest: Add i/I command for setting card-insert
via I2C GPIO
..
firmware: octsimtest: Add i/I command for setting card-insert via I2C GPIO
Change-Id: Ie1483ccf8465df0d640d55e50421fda910dced4a
---
M firmware/libboard/octsimtest/source/board_octsimtest.c
1 file changed, 10 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/72/24572/1
diff --git a/firmware/libboard/octsimtest/source/board_octsimtest.c
b/firmware/libboard/octsimtest/source/board_octsimtest.c
index 5dff046..c77c1ce 100644
--- a/firmware/libboard/octsimtest/source/board_octsimtest.c
+++ b/firmware/libboard/octsimtest/source/board_octsimtest.c
@@ -35,10 +35,11 @@
switch (ch) {
case '?':
printf("\t?\thelp\n\r");
+ printf("\t0-8\tselect physical SIM slot\n\r");
printf("\tR\treset SAM3\n\r");
printf("\tm\trun mcp23017 test\n\r");
- printf("\tR\ttoggle MSB of gpio on mcp23017\n\r");
- printf("\t0-8\tselect physical SIM slot\n\r");
+ printf("\ti\tset card insert via I2C\n\r");
+ printf("\tI\tdisable card insert\n\r");
break;
case '0': mux_set_slot(0); break;
case '1': mux_set_slot(1); break;
@@ -56,8 +57,13 @@
case 'm':
mcp23017_test(MCP23017_ADDRESS);
break;
- case 't':
- mcp23017_toggle(MCP23017_ADDRESS);
+ case 'i':
+ printf("Setting card insert (slot=%u)\r\n", mux_get_slot());
+ mcp23017_set_output_a(MCP23017_ADDRESS, (1 << mux_get_slot()));
+ break;
+ case 'I':
+ printf("Releasing card insert (slot=%u)\r\n", mux_get_slot());
+ mcp23017_set_output_a(MCP23017_ADDRESS, 0);
break;
default:
printf("Unknown command '%c'\n\r", ch);
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/24572
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Ie1483ccf8465df0d640d55e50421fda910dced4a
Gerrit-Change-Number: 24572
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-MessageType: newchange
Build failure of network:osmocom:latest/osmo-bsc in openSUSE_Tumbleweed/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/openSUSE_Tumbleweed/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/libosmo-mgcp-client-devel.rpm: Input/output error (worker was cloud115:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/ulfius in openSUSE_Tumbleweed/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/ulfius/openSUSE_Tumbleweed/x86_64 Package network:osmocom:latest/ulfius failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:latest ulfius Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/orcania-devel.rpm: Input/output error (worker was cloud115:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-hlr in openSUSE_Tumbleweed/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/openSUSE_Tumbleweed/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/libosmoabis-devel.rpm: Input/output error (worker was cloud115:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/libosmo-abis in openSUSE_Tumbleweed/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-abis/openSUSE_Tumbleweed/x86_64 Package network:osmocom:latest/libosmo-abis failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-abis Last lines of build log: /var/cache/obs/worker/root_1/.pkgs/libosmocore-devel.rpm: Input/output error (worker was cloud115:1) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/orcania in openSUSE_Tumbleweed/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/orcania/openSUSE_Tumbleweed/x86_64 Package network:osmocom:latest/orcania failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:latest orcania Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/liblua5_4-5.rpm: Input/output error (worker was cloud115:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmocom-latest in openSUSE_Tumbleweed/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmocom-latest/openSUSE_Tumbleweed/x86_64 Package network:osmocom:latest/osmocom-latest failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmocom-latest Last lines of build log: /var/cache/obs/worker/root_2/.pkgs/zlib-devel.rpm: Input/output error (worker was cloud115:2) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/libosmocore in openSUSE_Tumbleweed/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmocore/openSUSE_Tumbleweed/x86_64 Package network:osmocom:latest/libosmocore failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmocore Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/liblua5_4-5.rpm: Input/output error (worker was cloud115:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Tumbleweed/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Tumbleweed/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/libasn1c-devel.rpm: Input/output error (worker was cloud115:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-bsc in openSUSE_Tumbleweed/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/openSUSE_Tumbleweed/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: /var/cache/obs/worker/root_1/.pkgs/libosmo-mgcp-client-devel.rpm: Input/output error (worker was cloud115:1) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmocom-nightly in openSUSE_Tumbleweed/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmocom-nightly/openSUSE_Tumbleweed/x86_64 Package network:osmocom:nightly/osmocom-nightly failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmocom-nightly Last lines of build log: /var/cache/obs/worker/root_2/.pkgs/zlib-devel.rpm: Input/output error (worker was cloud115:2) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-iuh in openSUSE_Tumbleweed/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/openSUSE_Tumbleweed/i586 Package network:osmocom:latest/osmo-iuh failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/libasn1c-devel.rpm: Input/output error (worker was cloud115:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-smlc in openSUSE_Tumbleweed/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/openSUSE_Tumbleweed/i586 Package network:osmocom:latest/osmo-smlc failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: /var/cache/obs/worker/root_1/.pkgs/libosmonetif-devel.rpm: Input/output error (worker was cloud115:1) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-sip-connector in openSUSE_Tumbleweed/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/openSUSE_Tumbleweed/i586 Package network:osmocom:latest/osmo-sip-connector failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/libosmocore-devel.rpm: Input/output error (worker was cloud115:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/libosmo-abis in openSUSE_Tumbleweed/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-abis/openSUSE_Tumbleweed/i586 Package network:osmocom:latest/libosmo-abis failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:latest libosmo-abis Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/libosmocore-devel.rpm: Input/output error (worker was cloud115:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/ulfius in openSUSE_Tumbleweed/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/openSUSE_Tumbleweed/i586 Package network:osmocom:nightly/ulfius failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: /var/cache/obs/worker/root_2/.pkgs/zlib-devel.rpm: Input/output error (worker was cloud115:2) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
