Build failure of network:osmocom:latest/osmo-sgsn in Debian_Unstable/x86_64

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_Unstable/x86_64

Package network:osmocom:latest/osmo-sgsn failed to build in 
Debian_Unstable/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-sgsn

Last lines of build log:
[  498s] #  is like basename from coreutils, and . is WD.
[  498s] if ! [ -f osmosgsn-usermanual.adoc ]; then \
[  498s]ln -s osmosgsn-usermanual.adoc osmosgsn-usermanual.adoc; \
[  498s] fi
[  498s] # TEXINPUTS: find LaTeX includes like 
\includegraphics{./common/images/sysmocom.pdf}
[  498s] # in /usr/share/osmo-gsm-manuals.
[  498s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \
[  498s]a2x -vv -L --asciidoc-opts="-f 
/usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f 
/usr/share/osmo-gsm-manuals/build/diag-filter.conf -f 
/usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a 
srcdir='/usr/src/packages/BUILD/doc/manuals' -a 
commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s 
/usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P 
draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" 
osmosgsn-usermanual.adoc
[  498s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f 
/usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f 
/usr/share/osmo-gsm-manuals/build/diag-filter.conf -f 
/usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a 
srcdir='/usr/src/packages/BUILD/doc/manuals' -a 
commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s 
/usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P 
draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 
'revdate=unknown', 'osmosgsn-usermanual.adoc']
[  498s] a2x: resource files: []
[  498s] a2x: resource directories: ['/etc/asciidoc/stylesheets']
[  498s] make[4]: *** 
[/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: 
osmosgsn-usermanual.pdf] Error 1
[  498s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals'
[  498s] make[3]: *** [Makefile:393: all-recursive] Error 1
[  498s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc'
[  498s] make[2]: *** [Makefile:462: all-recursive] Error 1
[  498s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  498s] make[1]: *** [Makefile:394: all] Error 2
[  498s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  498s] dh_auto_build: error: make -j1 returned exit code 2
[  498s] make: *** [debian/rules:45: build] Error 25
[  498s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  498s] ### VM INTERACTION START ###
[  499s] Powering off.
[  499s] [  421.254912] reboot: Power down
[  500s] ### VM INTERACTION END ###
[  500s] 
[  500s] cloud108 failed "build osmo-sgsn_1.7.1.dsc" at Tue Nov  2 03:30:22 UTC 
2021.
[  500s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Leap_15.1_ARM/armv7l

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Leap_15.1_ARM/armv7l

Package network:osmocom:nightly/osmo-iuh failed to build in 
openSUSE_Leap_15.1_ARM/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-iuh

Last lines of build log:
[ 1031s] intention of the Shared Library Policy is to allow parallel 
installation of
[ 1031s] multiple versions of the same shared library, hard dependencies likely 
make
[ 1031s] that impossible. Please remove this dependency and instead move it to 
the
[ 1031s] runtime uses of your library.
[ 1031s] 
[ 1031s] osmo-iuh.armv7hl: W: suse-missing-rclink osmo-hnbgw
[ 1031s] The package contains an init script or systemd service file but lacks 
the
[ 1031s] symlink /usr/sbin/rcFOO -> /usr/sbin/service
[ 1031s] 
[ 1031s] libosmo-hnbap0.armv7hl: E: library-without-ldconfig-postin (Badness: 
300) /usr/lib/libosmo-hnbap.so.0.0.0
[ 1031s] libosmo-rua0.armv7hl: E: library-without-ldconfig-postin (Badness: 
300) /usr/lib/libosmo-rua.so.0.0.0
[ 1031s] This package contains a library and provides no %post scriptlet 
containing a
[ 1031s] call to ldconfig.
[ 1031s] 
[ 1031s] libosmo-hnbap0.armv7hl: E: library-without-ldconfig-postun (Badness: 
300) /usr/lib/libosmo-hnbap.so.0.0.0
[ 1031s] libosmo-rua0.armv7hl: E: library-without-ldconfig-postun (Badness: 
300) /usr/lib/libosmo-rua.so.0.0.0
[ 1031s] This package contains a library and provides no %postun scriptlet 
containing a
[ 1031s] call to ldconfig.
[ 1031s] 
[ 1031s] (none): E: badness 1200 exceeds threshold 1000, aborting.
[ 1031s] 10 packages and 0 specfiles checked; 4 errors, 21 warnings.
[ 1031s] 
[ 1031s] ### VM INTERACTION START ###
[ 1036s] [ 1018.608257] sysrq: SysRq : Power Off
[ 1036s] [ 1018.615053] reboot: Power down
[ 1037s] ### VM INTERACTION END ###
[ 1037s] 
[ 1037s] armbuild02 failed "build osmo-iuh.spec" at Tue Nov  2 01:20:54 UTC 
2021.
[ 1037s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/simtrace2 in Raspbian_10/armv7l

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Raspbian_10/armv7l

Package network:osmocom:nightly/simtrace2 failed to build in Raspbian_10/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  228s] 336  0   0 336 150 
obj/simtrace/dfu_board_lowlevel.o
[  228s]1230  010332263 8d7 
obj/simtrace/dfu_uart_console.o
[  228s] 624184   0 808 328 obj/simtrace/dfu_led.o
[  228s]   8  0   0   8   8 
obj/simtrace/dfu_boardver_adc.o
[  228s]  28 16   0  44  2c 
obj/simtrace/dfu_manifest.o
[  228s] 108  0   0 108  6c 
obj/simtrace/dfu_sim_switch.o
[  228s] 225  0   0 225  e1 
obj/simtrace/dfu_board_simtrace.o
[  228s] 929  0   1 930 3a2 obj/simtrace/dfu_main.o
[  228s] 244  0   0 244  f4 obj/simtrace/dfu_dfu.o
[  228s] 640104  72 816 330 
obj/simtrace/dfu_dfu_desc.o
[  228s]1045 24 5321601 641 
obj/simtrace/dfu_dfu_driver.o
[  228s]   13032  0   11440   244725f98 bin/simtrace-dfu-dfu.elf
[  228s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  228s] make -C firmware BOARD=simtrace APP=blupdate
[  228s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware'
[  228s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', 
needed by 'apps/blupdate/usb_strings.txt.patched'.  Stop.
[  228s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  228s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2
[  228s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  228s] dh_auto_build: make -j1 returned exit code 2
[  228s] make: *** [debian/rules:16: build] Error 2
[  228s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  228s] ### VM INTERACTION START ###
[  232s] [  194.516188] sysrq: SysRq : Power Off
[  232s] [  194.519290] reboot: Power down
[  233s] ### VM INTERACTION END ###
[  233s] 
[  233s] obs-arm-6 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at 
Tue Nov  2 01:03:00 UTC 2021.
[  233s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/simtrace2 in Debian_Testing/x86_64

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_Testing/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
Debian_Testing/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  193s] 336  0   0 336 150 
obj/simtrace/dfu_board_lowlevel.o
[  193s]   8  0   0   8   8 
obj/simtrace/dfu_boardver_adc.o
[  193s] 652184   0 836 344 obj/simtrace/dfu_led.o
[  193s]  28 16   0  44  2c 
obj/simtrace/dfu_manifest.o
[  193s]1254  010332287 8ef 
obj/simtrace/dfu_uart_console.o
[  193s] 225  0   0 225  e1 
obj/simtrace/dfu_board_simtrace.o
[  193s] 108  0   0 108  6c 
obj/simtrace/dfu_sim_switch.o
[  193s] 929  0   1 930 3a2 obj/simtrace/dfu_main.o
[  193s] 244  0   0 244  f4 obj/simtrace/dfu_dfu.o
[  193s] 636104  72 812 32c 
obj/simtrace/dfu_dfu_desc.o
[  193s]1053 24 5321609 649 
obj/simtrace/dfu_dfu_driver.o
[  193s]   13008  0   11440   244485f80 bin/simtrace-dfu-dfu.elf
[  193s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  193s] make -C firmware BOARD=simtrace APP=blupdate
[  193s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware'
[  193s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', 
needed by 'apps/blupdate/usb_strings.txt.patched'.  Stop.
[  193s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  193s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2
[  193s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  193s] dh_auto_build: error: make -j1 returned exit code 2
[  193s] make: *** [debian/rules:16: build] Error 25
[  193s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  193s] ### VM INTERACTION START ###
[  196s] [  165.543485] sysrq: Power Off
[  196s] [  165.571940] reboot: Power down
[  196s] ### VM INTERACTION END ###
[  196s] 
[  196s] goat01 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue 
Nov  2 00:58:21 UTC 2021.
[  196s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64

Package network:osmocom:nightly/osmo-gsm-manuals failed to build in 
Debian_Unstable/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-gsm-manuals

Last lines of build log:
[  231s] # we create a symlink at ./srcfile.adoc pointing at
[  231s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc,
[  231s] #  is like basename from coreutils, and . is WD.
[  231s] if ! [ -f test-usermanual.adoc ]; then \
[  231s]ln -s test-usermanual.adoc test-usermanual.adoc; \
[  231s] fi
[  231s] # TEXINPUTS: find LaTeX includes like 
\includegraphics{./common/images/sysmocom.pdf}
[  231s] # in ...
[  231s] TEXINPUTS=".." \
[  231s]a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f 
../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a 
srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" 
--dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P 
draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" 
test-usermanual.adoc
[  232s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f 
../build/mscgen-filter.conf -f ../build/diag-filter.conf -f 
../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a 
commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P 
draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT 
', '-a', 'revdate=unknown', 'test-usermanual.adoc']
[  232s] a2x: resource files: []
[  232s] a2x: resource directories: ['/etc/asciidoc/stylesheets']
[  232s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] 
Error 1
[  232s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  232s] make[2]: *** [Makefile:439: all-recursive] Error 1
[  232s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  232s] make[1]: *** [Makefile:363: all] Error 2
[  232s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  232s] dh_auto_build: error: make -j1 returned exit code 2
[  232s] make: *** [debian/rules:5: binary] Error 25
[  232s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess 
returned exit status 2
[  232s] ### VM INTERACTION START ###
[  233s] Powering off.
[  233s] [  221.344837] reboot: Power down
[  233s] ### VM INTERACTION END ###
[  233s] 
[  233s] goat17 failed "build 
osmo-gsm-manuals-dev_1.1.0.17.b92c.202111020026.dsc" at Tue Nov  2 00:58:03 UTC 
2021.
[  233s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_21.04/x86_64

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_21.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_21.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  182s] 340  0   0 340 154 
obj/simtrace/dfu_board_lowlevel.o
[  182s]   8  0   0   8   8 
obj/simtrace/dfu_boardver_adc.o
[  182s] 660184   0 844 34c obj/simtrace/dfu_led.o
[  182s]  28 16   0  44  2c 
obj/simtrace/dfu_manifest.o
[  182s]1270  010332303 8ff 
obj/simtrace/dfu_uart_console.o
[  182s] 225  0   0 225  e1 
obj/simtrace/dfu_board_simtrace.o
[  182s] 108  0   0 108  6c 
obj/simtrace/dfu_sim_switch.o
[  182s] 925  0   1 926 39e obj/simtrace/dfu_main.o
[  182s] 244  0   0 244  f4 obj/simtrace/dfu_dfu.o
[  182s] 636104  72 812 32c 
obj/simtrace/dfu_dfu_desc.o
[  182s]1053 24 5321609 649 
obj/simtrace/dfu_dfu_driver.o
[  182s]3700  01368506813cc bin/simtrace-dfu-dfu.elf
[  182s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  182s] make -C firmware BOARD=simtrace APP=blupdate
[  182s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware'
[  182s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', 
needed by 'apps/blupdate/usb_strings.txt.patched'.  Stop.
[  182s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  182s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2
[  182s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  182s] dh_auto_build: error: make -j1 returned exit code 2
[  182s] make: *** [debian/rules:16: build] Error 25
[  182s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  182s] ### VM INTERACTION START ###
[  185s] [  173.873284] sysrq: Power Off
[  185s] [  173.880144] reboot: Power down
[  185s] ### VM INTERACTION END ###
[  185s] 
[  185s] goat01 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue 
Nov  2 00:57:06 UTC 2021.
[  185s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Leap_15.2/x86_64

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Leap_15.2/x86_64

Package network:osmocom:nightly/osmo-iuh failed to build in 
openSUSE_Leap_15.2/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-iuh

Last lines of build log:
[  191s] intention of the Shared Library Policy is to allow parallel 
installation of
[  191s] multiple versions of the same shared library, hard dependencies likely 
make
[  191s] that impossible. Please remove this dependency and instead move it to 
the
[  191s] runtime uses of your library.
[  191s] 
[  191s] osmo-iuh.x86_64: W: suse-missing-rclink osmo-hnbgw
[  191s] The package contains an init script or systemd service file but lacks 
the
[  191s] symlink /usr/sbin/rcFOO -> /usr/sbin/service
[  191s] 
[  191s] libosmo-hnbap0.x86_64: E: library-without-ldconfig-postin (Badness: 
300) /usr/lib64/libosmo-hnbap.so.0.0.0
[  191s] libosmo-rua0.x86_64: E: library-without-ldconfig-postin (Badness: 300) 
/usr/lib64/libosmo-rua.so.0.0.0
[  191s] This package contains a library and provides no %post scriptlet 
containing a
[  191s] call to ldconfig.
[  191s] 
[  191s] libosmo-hnbap0.x86_64: E: library-without-ldconfig-postun (Badness: 
300) /usr/lib64/libosmo-hnbap.so.0.0.0
[  191s] libosmo-rua0.x86_64: E: library-without-ldconfig-postun (Badness: 300) 
/usr/lib64/libosmo-rua.so.0.0.0
[  191s] This package contains a library and provides no %postun scriptlet 
containing a
[  191s] call to ldconfig.
[  191s] 
[  191s] (none): E: badness 1200 exceeds threshold 1000, aborting.
[  191s] 10 packages and 0 specfiles checked; 4 errors, 21 warnings.
[  191s] 
[  191s] ### VM INTERACTION START ###
[  194s] [  183.910136] sysrq: Power Off
[  194s] [  183.915301] reboot: Power down
[  194s] ### VM INTERACTION END ###
[  194s] 
[  194s] lamb16 failed "build osmo-iuh.spec" at Tue Nov  2 00:54:34 UTC 2021.
[  194s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/simtrace2 in Debian_10/i586

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_10/i586

Package network:osmocom:nightly/simtrace2 failed to build in Debian_10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  242s] 336  0   0 336 150 
obj/simtrace/dfu_board_lowlevel.o
[  242s]1230  010332263 8d7 
obj/simtrace/dfu_uart_console.o
[  242s] 624184   0 808 328 obj/simtrace/dfu_led.o
[  242s]   8  0   0   8   8 
obj/simtrace/dfu_boardver_adc.o
[  242s]  28 16   0  44  2c 
obj/simtrace/dfu_manifest.o
[  242s] 108  0   0 108  6c 
obj/simtrace/dfu_sim_switch.o
[  242s] 225  0   0 225  e1 
obj/simtrace/dfu_board_simtrace.o
[  242s] 929  0   1 930 3a2 obj/simtrace/dfu_main.o
[  242s] 244  0   0 244  f4 obj/simtrace/dfu_dfu.o
[  242s] 640104  72 816 330 
obj/simtrace/dfu_dfu_desc.o
[  242s]1045 24 5321601 641 
obj/simtrace/dfu_dfu_driver.o
[  242s]   13032  0   11440   244725f98 bin/simtrace-dfu-dfu.elf
[  242s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  242s] make -C firmware BOARD=simtrace APP=blupdate
[  242s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware'
[  242s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', 
needed by 'apps/blupdate/usb_strings.txt.patched'.  Stop.
[  242s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  242s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2
[  242s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  242s] dh_auto_build: make -j1 returned exit code 2
[  242s] make: *** [debian/rules:16: build] Error 2
[  242s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  242s] ### VM INTERACTION START ###
[  245s] [  193.647053] sysrq: Power Off
[  245s] [  193.667250] reboot: Power down
[  246s] ### VM INTERACTION END ###
[  246s] 
[  246s] cloud114 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at 
Tue Nov  2 00:54:25 UTC 2021.
[  246s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Leap_15.1/x86_64

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Leap_15.1/x86_64

Package network:osmocom:nightly/osmo-iuh failed to build in 
openSUSE_Leap_15.1/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-iuh

Last lines of build log:
[  225s] intention of the Shared Library Policy is to allow parallel 
installation of
[  225s] multiple versions of the same shared library, hard dependencies likely 
make
[  225s] that impossible. Please remove this dependency and instead move it to 
the
[  225s] runtime uses of your library.
[  225s] 
[  225s] osmo-iuh.x86_64: W: suse-missing-rclink osmo-hnbgw
[  225s] The package contains an init script or systemd service file but lacks 
the
[  225s] symlink /usr/sbin/rcFOO -> /usr/sbin/service
[  225s] 
[  225s] libosmo-hnbap0.x86_64: E: library-without-ldconfig-postin (Badness: 
300) /usr/lib64/libosmo-hnbap.so.0.0.0
[  225s] libosmo-rua0.x86_64: E: library-without-ldconfig-postin (Badness: 300) 
/usr/lib64/libosmo-rua.so.0.0.0
[  225s] This package contains a library and provides no %post scriptlet 
containing a
[  225s] call to ldconfig.
[  225s] 
[  225s] libosmo-hnbap0.x86_64: E: library-without-ldconfig-postun (Badness: 
300) /usr/lib64/libosmo-hnbap.so.0.0.0
[  225s] libosmo-rua0.x86_64: E: library-without-ldconfig-postun (Badness: 300) 
/usr/lib64/libosmo-rua.so.0.0.0
[  225s] This package contains a library and provides no %postun scriptlet 
containing a
[  225s] call to ldconfig.
[  225s] 
[  225s] (none): E: badness 1200 exceeds threshold 1000, aborting.
[  225s] 10 packages and 0 specfiles checked; 4 errors, 21 warnings.
[  225s] 
[  225s] ### VM INTERACTION START ###
[  228s] [  217.666094] sysrq: SysRq : Power Off
[  228s] [  217.684835] reboot: Power down
[  228s] ### VM INTERACTION END ###
[  228s] 
[  228s] goat01 failed "build osmo-iuh.spec" at Tue Nov  2 00:52:34 UTC 2021.
[  228s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/simtrace2 in Debian_11/x86_64

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_11/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in Debian_11/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  465s] 336  0   0 336 150 
obj/simtrace/dfu_board_lowlevel.o
[  465s]   8  0   0   8   8 
obj/simtrace/dfu_boardver_adc.o
[  465s] 652184   0 836 344 obj/simtrace/dfu_led.o
[  465s]  28 16   0  44  2c 
obj/simtrace/dfu_manifest.o
[  465s]1254  010332287 8ef 
obj/simtrace/dfu_uart_console.o
[  465s] 225  0   0 225  e1 
obj/simtrace/dfu_board_simtrace.o
[  465s] 108  0   0 108  6c 
obj/simtrace/dfu_sim_switch.o
[  465s] 929  0   1 930 3a2 obj/simtrace/dfu_main.o
[  465s] 244  0   0 244  f4 obj/simtrace/dfu_dfu.o
[  465s] 636104  72 812 32c 
obj/simtrace/dfu_dfu_desc.o
[  465s]1053 24 5321609 649 
obj/simtrace/dfu_dfu_driver.o
[  465s]   13008  0   11440   244485f80 bin/simtrace-dfu-dfu.elf
[  465s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  465s] make -C firmware BOARD=simtrace APP=blupdate
[  465s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware'
[  465s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', 
needed by 'apps/blupdate/usb_strings.txt.patched'.  Stop.
[  465s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  465s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2
[  465s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  465s] dh_auto_build: error: make -j1 returned exit code 2
[  465s] make: *** [debian/rules:16: build] Error 25
[  465s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  465s] ### VM INTERACTION START ###
[  468s] [  409.750570] sysrq: Power Off
[  468s] [  409.757932] reboot: Power down
[  468s] ### VM INTERACTION END ###
[  468s] 
[  468s] old-atreju5 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" 
at Tue Nov  2 00:50:00 UTC 2021.
[  468s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/simtrace2 in Debian_10/x86_64

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_10/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in Debian_10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  292s] 336  0   0 336 150 
obj/simtrace/dfu_board_lowlevel.o
[  292s]1230  010332263 8d7 
obj/simtrace/dfu_uart_console.o
[  292s] 624184   0 808 328 obj/simtrace/dfu_led.o
[  292s]   8  0   0   8   8 
obj/simtrace/dfu_boardver_adc.o
[  292s]  28 16   0  44  2c 
obj/simtrace/dfu_manifest.o
[  292s] 108  0   0 108  6c 
obj/simtrace/dfu_sim_switch.o
[  292s] 225  0   0 225  e1 
obj/simtrace/dfu_board_simtrace.o
[  292s] 929  0   1 930 3a2 obj/simtrace/dfu_main.o
[  292s] 244  0   0 244  f4 obj/simtrace/dfu_dfu.o
[  292s] 640104  72 816 330 
obj/simtrace/dfu_dfu_desc.o
[  292s]1045 24 5321601 641 
obj/simtrace/dfu_dfu_driver.o
[  292s]   13032  0   11440   244725f98 bin/simtrace-dfu-dfu.elf
[  292s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  292s] make -C firmware BOARD=simtrace APP=blupdate
[  292s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware'
[  292s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', 
needed by 'apps/blupdate/usb_strings.txt.patched'.  Stop.
[  292s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  292s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2
[  292s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  292s] dh_auto_build: make -j1 returned exit code 2
[  292s] make: *** [debian/rules:16: build] Error 2
[  292s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  292s] ### VM INTERACTION START ###
[  295s] [  274.644221] sysrq: Power Off
[  295s] [  274.693089] reboot: Power down
[  295s] ### VM INTERACTION END ###
[  295s] 
[  296s] lamb02 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue 
Nov  2 00:46:02 UTC 2021.
[  296s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/x86_64

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_18.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  211s] 624184   0 808 328 obj/simtrace/dfu_led.o
[  211s]   8  0   0   8   8 
obj/simtrace/dfu_boardver_adc.o
[  211s]  28 16   0  44  2c 
obj/simtrace/dfu_manifest.o
[  211s] 104  0   0 104  68 
obj/simtrace/dfu_sim_switch.o
[  211s] 225  0   0 225  e1 
obj/simtrace/dfu_board_simtrace.o
[  211s] 929  0   1 930 3a2 obj/simtrace/dfu_main.o
[  211s] 244  0   0 244  f4 obj/simtrace/dfu_dfu.o
[  211s] 640104  72 816 330 
obj/simtrace/dfu_dfu_desc.o
[  211s]1053 24 5321609 649 
obj/simtrace/dfu_dfu_driver.o
[  211s]   13112  0   11440   245525fe8 bin/simtrace-dfu-dfu.elf
[  211s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  211s] make -C firmware BOARD=simtrace APP=blupdate
[  211s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware'
[  211s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', 
needed by 'apps/blupdate/usb_strings.txt.patched'.  Stop.
[  211s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  211s] Makefile:11: recipe for target 'fw-simtrace-blupdate' failed
[  211s] make[1]: *** [fw-simtrace-blupdate] Error 2
[  211s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  211s] dh_auto_build: make -j1 returned exit code 2
[  211s] debian/rules:16: recipe for target 'build' failed
[  211s] make: *** [build] Error 2
[  211s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  211s] ### VM INTERACTION START ###
[  214s] [  195.126496] sysrq: Power Off
[  214s] [  195.151405] reboot: Power down
[  214s] ### VM INTERACTION END ###
[  214s] 
[  214s] lamb56 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue 
Nov  2 00:45:45 UTC 2021.
[  214s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.04/x86_64

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_20.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  258s] 340  0   0 340 154 
obj/simtrace/dfu_board_lowlevel.o
[  258s]1270  010332303 8ff 
obj/simtrace/dfu_uart_console.o
[  258s] 660184   0 844 34c obj/simtrace/dfu_led.o
[  258s]   8  0   0   8   8 
obj/simtrace/dfu_boardver_adc.o
[  258s]  28 16   0  44  2c 
obj/simtrace/dfu_manifest.o
[  258s] 108  0   0 108  6c 
obj/simtrace/dfu_sim_switch.o
[  258s] 225  0   0 225  e1 
obj/simtrace/dfu_board_simtrace.o
[  258s] 925  0   1 926 39e obj/simtrace/dfu_main.o
[  258s] 244  0   0 244  f4 obj/simtrace/dfu_dfu.o
[  258s] 636104  72 812 32c 
obj/simtrace/dfu_dfu_desc.o
[  258s]1053 24 5321609 649 
obj/simtrace/dfu_dfu_driver.o
[  258s]   13188  0   11440   246286034 bin/simtrace-dfu-dfu.elf
[  258s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  258s] make -C firmware BOARD=simtrace APP=blupdate
[  258s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware'
[  258s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', 
needed by 'apps/blupdate/usb_strings.txt.patched'.  Stop.
[  258s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  258s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2
[  258s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  258s] dh_auto_build: error: make -j1 returned exit code 2
[  258s] make: *** [debian/rules:16: build] Error 25
[  258s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  258s] ### VM INTERACTION START ###
[  261s] [  234.372393] sysrq: Power Off
[  261s] [  234.448899] reboot: Power down
[  261s] ### VM INTERACTION END ###
[  262s] 
[  262s] old-atreju2 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" 
at Tue Nov  2 00:45:29 UTC 2021.
[  262s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/x86_64

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[   77s] 628184   0 812 32c obj/simtrace/dfu_led.o
[   77s]   8  0   0   8   8 
obj/simtrace/dfu_boardver_adc.o
[   77s]  28 16   0  44  2c 
obj/simtrace/dfu_manifest.o
[   77s] 104  0   0 104  68 
obj/simtrace/dfu_sim_switch.o
[   77s] 229  0   0 229  e5 
obj/simtrace/dfu_board_simtrace.o
[   77s] 941  0   1 942 3ae obj/simtrace/dfu_main.o
[   77s] 244  0   0 244  f4 obj/simtrace/dfu_dfu.o
[   77s] 640104  72 816 330 
obj/simtrace/dfu_dfu_desc.o
[   77s]1029 24 5321585 631 
obj/simtrace/dfu_dfu_driver.o
[   77s]   13144  0   11440   245846008 bin/simtrace-dfu-dfu.elf
[   77s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[   77s] make -C firmware BOARD=simtrace APP=blupdate
[   77s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware'
[   77s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', 
needed by 'apps/blupdate/usb_strings.txt.patched'.  Stop.
[   77s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[   77s] Makefile:11: recipe for target 'fw-simtrace-blupdate' failed
[   77s] make[1]: *** [fw-simtrace-blupdate] Error 2
[   77s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   77s] dh_auto_build: make -j1 returned exit code 2
[   77s] debian/rules:16: recipe for target 'build' failed
[   77s] make: *** [build] Error 2
[   77s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   77s] ### VM INTERACTION START ###
[   80s] [   69.336347] sysrq: Power Off
[   80s] [   69.338986] reboot: Power down
[   80s] ### VM INTERACTION END ###
[   80s] 
[   80s] old-cirrus2 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" 
at Tue Nov  2 00:43:22 UTC 2021.
[   80s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/i586

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/i586

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  138s] 628184   0 812 32c obj/simtrace/dfu_led.o
[  138s]   8  0   0   8   8 
obj/simtrace/dfu_boardver_adc.o
[  138s]  28 16   0  44  2c 
obj/simtrace/dfu_manifest.o
[  138s] 104  0   0 104  68 
obj/simtrace/dfu_sim_switch.o
[  138s] 229  0   0 229  e5 
obj/simtrace/dfu_board_simtrace.o
[  138s] 941  0   1 942 3ae obj/simtrace/dfu_main.o
[  138s] 244  0   0 244  f4 obj/simtrace/dfu_dfu.o
[  138s] 640104  72 816 330 
obj/simtrace/dfu_dfu_desc.o
[  138s]1029 24 5321585 631 
obj/simtrace/dfu_dfu_driver.o
[  138s]   13144  0   11440   245846008 bin/simtrace-dfu-dfu.elf
[  138s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  138s] make -C firmware BOARD=simtrace APP=blupdate
[  138s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware'
[  138s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', 
needed by 'apps/blupdate/usb_strings.txt.patched'.  Stop.
[  138s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  138s] Makefile:11: recipe for target 'fw-simtrace-blupdate' failed
[  138s] make[1]: *** [fw-simtrace-blupdate] Error 2
[  138s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  138s] dh_auto_build: make -j1 returned exit code 2
[  138s] debian/rules:16: recipe for target 'build' failed
[  138s] make: *** [build] Error 2
[  138s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  138s] ### VM INTERACTION START ###
[  141s] [  114.910606] sysrq: Power Off
[  141s] [  114.936143] reboot: Power down
[  141s] ### VM INTERACTION END ###
[  141s] 
[  141s] lamb18 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue 
Nov  2 00:42:44 UTC 2021.
[  141s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/simtrace2 in Debian_Unstable/x86_64

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_Unstable/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
Debian_Unstable/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  145s] 336  0   4 340 154 
obj/simtrace/dfu_board_lowlevel.o
[  145s]   8  0   0   8   8 
obj/simtrace/dfu_boardver_adc.o
[  145s] 656184   0 840 348 obj/simtrace/dfu_led.o
[  145s]  28 16   0  44  2c 
obj/simtrace/dfu_manifest.o
[  145s]1254  010332287 8ef 
obj/simtrace/dfu_uart_console.o
[  145s] 225  0   0 225  e1 
obj/simtrace/dfu_board_simtrace.o
[  145s] 108  0   0 108  6c 
obj/simtrace/dfu_sim_switch.o
[  145s] 909  0  20 929 3a1 obj/simtrace/dfu_main.o
[  145s] 244  0   0 244  f4 obj/simtrace/dfu_dfu.o
[  145s] 636104  72 812 32c 
obj/simtrace/dfu_dfu_desc.o
[  145s]1053 24 5321609 649 
obj/simtrace/dfu_dfu_driver.o
[  145s]   13176  0   11444   24620602c bin/simtrace-dfu-dfu.elf
[  145s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  145s] make -C firmware BOARD=simtrace APP=blupdate
[  145s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware'
[  145s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', 
needed by 'apps/blupdate/usb_strings.txt.patched'.  Stop.
[  145s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  145s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2
[  145s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  145s] dh_auto_build: error: make -j1 returned exit code 2
[  145s] make: *** [debian/rules:16: build] Error 25
[  145s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  145s] ### VM INTERACTION START ###
[  148s] [  109.554710] sysrq: Power Off
[  148s] [  109.562526] reboot: Power down
[  148s] ### VM INTERACTION END ###
[  148s] 
[  148s] goat17 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue 
Nov  2 00:40:41 UTC 2021.
[  148s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.10/x86_64

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.10/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_20.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  107s] 340  0   0 340 154 
obj/simtrace/dfu_board_lowlevel.o
[  107s]   8  0   0   8   8 
obj/simtrace/dfu_boardver_adc.o
[  107s] 660184   0 844 34c obj/simtrace/dfu_led.o
[  107s]  28 16   0  44  2c 
obj/simtrace/dfu_manifest.o
[  107s]1270  010332303 8ff 
obj/simtrace/dfu_uart_console.o
[  107s] 225  0   0 225  e1 
obj/simtrace/dfu_board_simtrace.o
[  107s] 108  0   0 108  6c 
obj/simtrace/dfu_sim_switch.o
[  107s] 925  0   1 926 39e obj/simtrace/dfu_main.o
[  107s] 244  0   0 244  f4 obj/simtrace/dfu_dfu.o
[  107s] 636104  72 812 32c 
obj/simtrace/dfu_dfu_desc.o
[  107s]1053 24 5321609 649 
obj/simtrace/dfu_dfu_driver.o
[  107s]   13188  0   11440   246286034 bin/simtrace-dfu-dfu.elf
[  107s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  107s] make -C firmware BOARD=simtrace APP=blupdate
[  107s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware'
[  107s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', 
needed by 'apps/blupdate/usb_strings.txt.patched'.  Stop.
[  107s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  107s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2
[  107s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  107s] dh_auto_build: error: make -j1 returned exit code 2
[  107s] make: *** [debian/rules:16: build] Error 25
[  107s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  107s] ### VM INTERACTION START ###
[  110s] [   98.244658] sysrq: Power Off
[  110s] [   98.249196] reboot: Power down
[  110s] ### VM INTERACTION END ###
[  110s] 
[  110s] sheep85 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at 
Tue Nov  2 00:40:07 UTC 2021.
[  110s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_19.04/x86_64

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_19.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_19.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  101s] 336  0   0 336 150 
obj/simtrace/dfu_board_lowlevel.o
[  101s]1230  010332263 8d7 
obj/simtrace/dfu_uart_console.o
[  101s] 624184   0 808 328 obj/simtrace/dfu_led.o
[  101s]   8  0   0   8   8 
obj/simtrace/dfu_boardver_adc.o
[  101s]  28 16   0  44  2c 
obj/simtrace/dfu_manifest.o
[  101s] 108  0   0 108  6c 
obj/simtrace/dfu_sim_switch.o
[  101s] 225  0   0 225  e1 
obj/simtrace/dfu_board_simtrace.o
[  101s] 929  0   1 930 3a2 obj/simtrace/dfu_main.o
[  101s] 244  0   0 244  f4 obj/simtrace/dfu_dfu.o
[  101s] 640104  72 816 330 
obj/simtrace/dfu_dfu_desc.o
[  101s]1045 24 5321601 641 
obj/simtrace/dfu_dfu_driver.o
[  101s]   13032  0   11440   244725f98 bin/simtrace-dfu-dfu.elf
[  101s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  101s] make -C firmware BOARD=simtrace APP=blupdate
[  101s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware'
[  101s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', 
needed by 'apps/blupdate/usb_strings.txt.patched'.  Stop.
[  101s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  101s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2
[  101s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  101s] dh_auto_build: make -j1 returned exit code 2
[  101s] make: *** [debian/rules:16: build] Error 2
[  101s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  101s] ### VM INTERACTION START ###
[  104s] [   97.115091] sysrq: Power Off
[  104s] [   97.125214] reboot: Power down
[  104s] ### VM INTERACTION END ###
[  104s] 
[  104s] goat09 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue 
Nov  2 00:39:54 UTC 2021.
[  104s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/simtrace2 in Debian_11/i586

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_11/i586

Package network:osmocom:nightly/simtrace2 failed to build in Debian_11/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  217s] 336  0   0 336 150 
obj/simtrace/dfu_board_lowlevel.o
[  217s]   8  0   0   8   8 
obj/simtrace/dfu_boardver_adc.o
[  217s] 652184   0 836 344 obj/simtrace/dfu_led.o
[  217s]  28 16   0  44  2c 
obj/simtrace/dfu_manifest.o
[  217s]1254  010332287 8ef 
obj/simtrace/dfu_uart_console.o
[  217s] 225  0   0 225  e1 
obj/simtrace/dfu_board_simtrace.o
[  217s] 108  0   0 108  6c 
obj/simtrace/dfu_sim_switch.o
[  217s] 929  0   1 930 3a2 obj/simtrace/dfu_main.o
[  217s] 244  0   0 244  f4 obj/simtrace/dfu_dfu.o
[  217s] 636104  72 812 32c 
obj/simtrace/dfu_dfu_desc.o
[  217s]1053 24 5321609 649 
obj/simtrace/dfu_dfu_driver.o
[  217s]   13008  0   11440   244485f80 bin/simtrace-dfu-dfu.elf
[  217s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  217s] make -C firmware BOARD=simtrace APP=blupdate
[  217s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware'
[  217s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', 
needed by 'apps/blupdate/usb_strings.txt.patched'.  Stop.
[  217s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  217s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2
[  217s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  217s] dh_auto_build: error: make -j1 returned exit code 2
[  217s] make: *** [debian/rules:16: build] Error 25
[  217s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  217s] ### VM INTERACTION START ###
[  220s] [  190.064802] sysrq: Power Off
[  220s] [  190.069963] reboot: Power down
[  220s] ### VM INTERACTION END ###
[  220s] 
[  220s] hci-cnode1-e5 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" 
at Tue Nov  2 00:38:37 UTC 2021.
[  220s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Leap_15.1_ARM/aarch64

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Leap_15.1_ARM/aarch64

Package network:osmocom:nightly/osmo-iuh failed to build in 
openSUSE_Leap_15.1_ARM/aarch64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-iuh

Last lines of build log:
[  160s] intention of the Shared Library Policy is to allow parallel 
installation of
[  160s] multiple versions of the same shared library, hard dependencies likely 
make
[  160s] that impossible. Please remove this dependency and instead move it to 
the
[  160s] runtime uses of your library.
[  160s] 
[  160s] osmo-iuh.aarch64: W: suse-missing-rclink osmo-hnbgw
[  160s] The package contains an init script or systemd service file but lacks 
the
[  160s] symlink /usr/sbin/rcFOO -> /usr/sbin/service
[  160s] 
[  160s] libosmo-hnbap0.aarch64: E: library-without-ldconfig-postin (Badness: 
300) /usr/lib64/libosmo-hnbap.so.0.0.0
[  160s] libosmo-rua0.aarch64: E: library-without-ldconfig-postin (Badness: 
300) /usr/lib64/libosmo-rua.so.0.0.0
[  160s] This package contains a library and provides no %post scriptlet 
containing a
[  160s] call to ldconfig.
[  160s] 
[  160s] libosmo-hnbap0.aarch64: E: library-without-ldconfig-postun (Badness: 
300) /usr/lib64/libosmo-hnbap.so.0.0.0
[  160s] libosmo-rua0.aarch64: E: library-without-ldconfig-postun (Badness: 
300) /usr/lib64/libosmo-rua.so.0.0.0
[  160s] This package contains a library and provides no %postun scriptlet 
containing a
[  160s] call to ldconfig.
[  160s] 
[  160s] (none): E: badness 1200 exceeds threshold 1000, aborting.
[  160s] 10 packages and 0 specfiles checked; 4 errors, 21 warnings.
[  160s] 
[  160s] ### VM INTERACTION START ###
[  163s] [  155.817206] sysrq: SysRq : Power Off
[  163s] [  155.817791] reboot: Power down
[  163s] ### VM INTERACTION END ###
[  163s] 
[  163s] obs-arm-11 failed "build osmo-iuh.spec" at Tue Nov  2 00:36:00 UTC 
2021.
[  163s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/simtrace2 in Debian_11/aarch64

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_11/aarch64

Package network:osmocom:nightly/simtrace2 failed to build in Debian_11/aarch64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  134s] 336  0   0 336 150 
obj/simtrace/dfu_board_lowlevel.o
[  134s]   8  0   0   8   8 
obj/simtrace/dfu_boardver_adc.o
[  134s] 652184   0 836 344 obj/simtrace/dfu_led.o
[  134s]  28 16   0  44  2c 
obj/simtrace/dfu_manifest.o
[  134s]1254  010332287 8ef 
obj/simtrace/dfu_uart_console.o
[  134s] 225  0   0 225  e1 
obj/simtrace/dfu_board_simtrace.o
[  134s] 108  0   0 108  6c 
obj/simtrace/dfu_sim_switch.o
[  134s] 929  0   1 930 3a2 obj/simtrace/dfu_main.o
[  134s] 244  0   0 244  f4 obj/simtrace/dfu_dfu.o
[  134s] 636104  72 812 32c 
obj/simtrace/dfu_dfu_desc.o
[  134s]1053 24 5321609 649 
obj/simtrace/dfu_dfu_driver.o
[  134s]   13008  0   11440   244485f80 bin/simtrace-dfu-dfu.elf
[  134s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  134s] make -C firmware BOARD=simtrace APP=blupdate
[  134s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware'
[  134s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', 
needed by 'apps/blupdate/usb_strings.txt.patched'.  Stop.
[  134s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  134s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2
[  134s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  134s] dh_auto_build: error: make -j1 returned exit code 2
[  134s] make: *** [debian/rules:16: build] Error 25
[  134s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  134s] ### VM INTERACTION START ###
[  138s] [  119.004300] sysrq: Power Off
[  138s] [  119.005301] reboot: Power down
[  138s] ### VM INTERACTION END ###
[  138s] 
[  138s] obs-arm-9 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at 
Tue Nov  2 00:35:11 UTC 2021.
[  138s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/aarch64

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/aarch64

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/aarch64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  112s] 628184   0 812 32c obj/simtrace/dfu_led.o
[  112s]   8  0   0   8   8 
obj/simtrace/dfu_boardver_adc.o
[  112s]  28 16   0  44  2c 
obj/simtrace/dfu_manifest.o
[  112s] 104  0   0 104  68 
obj/simtrace/dfu_sim_switch.o
[  112s] 229  0   0 229  e5 
obj/simtrace/dfu_board_simtrace.o
[  112s] 941  0   1 942 3ae obj/simtrace/dfu_main.o
[  112s] 244  0   0 244  f4 obj/simtrace/dfu_dfu.o
[  112s] 640104  72 816 330 
obj/simtrace/dfu_dfu_desc.o
[  112s]1029 24 5321585 631 
obj/simtrace/dfu_dfu_driver.o
[  112s]   13144  0   11440   245846008 bin/simtrace-dfu-dfu.elf
[  112s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  112s] make -C firmware BOARD=simtrace APP=blupdate
[  112s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware'
[  112s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', 
needed by 'apps/blupdate/usb_strings.txt.patched'.  Stop.
[  112s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  112s] Makefile:11: recipe for target 'fw-simtrace-blupdate' failed
[  112s] make[1]: *** [fw-simtrace-blupdate] Error 2
[  112s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  112s] dh_auto_build: make -j1 returned exit code 2
[  112s] debian/rules:16: recipe for target 'build' failed
[  112s] make: *** [build] Error 2
[  112s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  112s] ### VM INTERACTION START ###
[  115s] [  102.059678] sysrq: Power Off
[  115s] [  102.060705] reboot: Power down
[  115s] ### VM INTERACTION END ###
[  115s] 
[  115s] obs-arm-8 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at 
Tue Nov  2 00:34:12 UTC 2021.
[  115s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/simtrace2 in Debian_10/aarch64

2021-11-01 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_10/aarch64

Package network:osmocom:nightly/simtrace2 failed to build in Debian_10/aarch64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[   67s] 336  0   0 336 150 
obj/simtrace/dfu_board_lowlevel.o
[   67s]1230  010332263 8d7 
obj/simtrace/dfu_uart_console.o
[   67s] 624184   0 808 328 obj/simtrace/dfu_led.o
[   67s]   8  0   0   8   8 
obj/simtrace/dfu_boardver_adc.o
[   67s]  28 16   0  44  2c 
obj/simtrace/dfu_manifest.o
[   67s] 108  0   0 108  6c 
obj/simtrace/dfu_sim_switch.o
[   67s] 225  0   0 225  e1 
obj/simtrace/dfu_board_simtrace.o
[   67s] 929  0   1 930 3a2 obj/simtrace/dfu_main.o
[   67s] 244  0   0 244  f4 obj/simtrace/dfu_dfu.o
[   67s] 640104  72 816 330 
obj/simtrace/dfu_dfu_desc.o
[   67s]1045 24 5321601 641 
obj/simtrace/dfu_dfu_driver.o
[   67s]   13032  0   11440   244725f98 bin/simtrace-dfu-dfu.elf
[   67s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[   67s] make -C firmware BOARD=simtrace APP=blupdate
[   67s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware'
[   67s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', 
needed by 'apps/blupdate/usb_strings.txt.patched'.  Stop.
[   67s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[   67s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2
[   67s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   67s] dh_auto_build: make -j1 returned exit code 2
[   67s] make: *** [debian/rules:16: build] Error 2
[   67s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[   67s] ### VM INTERACTION START ###
[   70s] [   60.656045] sysrq: Power Off
[   70s] [   60.656821] reboot: Power down
[   70s] ### VM INTERACTION END ###
[   70s] 
[   70s] obs-arm-11 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at 
Tue Nov  2 00:33:21 UTC 2021.
[   70s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Change in osmo-bsc[master]: doc/manuals: add documentation for interference reporting

2021-11-01 Thread fixeria
fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/26056 )


Change subject: doc/manuals: add documentation for interference reporting
..

doc/manuals: add documentation for interference reporting

Change-Id: I3c15b11bbcba0811e3a15fe64365067bf8ad0dae
Related: SYS#5313
---
A doc/manuals/chapters/interf_meas.adoc
M doc/manuals/osmobsc-usermanual.adoc
2 files changed, 46 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/56/26056/1

diff --git a/doc/manuals/chapters/interf_meas.adoc 
b/doc/manuals/chapters/interf_meas.adoc
new file mode 100644
index 000..b3b2e42
--- /dev/null
+++ b/doc/manuals/chapters/interf_meas.adoc
@@ -0,0 +1,44 @@
+== Interference reporting
+
+According to 3GPP 48.058, section 6.1, the BTS shall periodically report the
+interference levels on *idle* channels using the "Radio resource indication"
+procedure.  This is done by sending the `RF RESource INDication` message,
+which is specified in sections 8.6.1 and 9.3.21.
+
+// TODO: BSC -> MSC reporting (3GPP TS 48.008, section 3.1.3)
+
+=== Interference reporting parameters
+
+The interference band is calculated by the BTS based on the `Interference level
+Boundaries` and the `Averaging period`.  These parameters are sent by the BSC
+over the A-bis/OML, and can be configured via the VTY interface.
+
+Below are the default values for them:
+
+
+network
+ bts 0
+  interference-meas avg-period 6 <1>
+  interference-meas level-bounds -85 <2> -91 -97 -103 -109 -115 <3>
+
+<1> Averaging period (`Intave`) in SACCH multiframe periods (480ms).
+<2> Interference level boundary `0` (in dBm).
+<3> Interference level boundary `X5` (in dBm).
+
+The `Intave` parameter defines the averaging period, so with the default value
+of 6 SACCH multiframe periods the BTS is instructed to report interference
+levels approximately every 3 seconds.  Before reporting to the BSC, the BTS
+maps each interference level (in dBm) to one of the 5 bands using the given
+boundaries.
+
+
+-85 dBm-91 dBm-97 dBm   -103 dBm   -109 dBm   -115 dBm
+   |  |  |  |  |  |
+   +--+--+--+--+--+
+   |  band 1  |  band 2  |  band 3  |  band 4  |  band 5  |
+   +--+--+--+--+--+
+
+
+// FIXME: what happens if a value is below -115 dBm or above -85 dBm
+// TODO: document PDCH interference reporting
+// TODO: dynamic timeslot handling
diff --git a/doc/manuals/osmobsc-usermanual.adoc 
b/doc/manuals/osmobsc-usermanual.adoc
index 120fe2c..0afa015 100644
--- a/doc/manuals/osmobsc-usermanual.adoc
+++ b/doc/manuals/osmobsc-usermanual.adoc
@@ -26,6 +26,8 @@

 include::{srcdir}/chapters/power_control.adoc[]

+include::{srcdir}/chapters/interf_meas.adoc[]
+
 include::{srcdir}/chapters/handover.adoc[]

 include::{srcdir}/chapters/smscb.adoc[]

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26056
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3c15b11bbcba0811e3a15fe64365067bf8ad0dae
Gerrit-Change-Number: 26056
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange


Change in pysim[master]: commands: do not check SW manually, use send_apdu_checksw()

2021-11-01 Thread fixeria
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/26055 )

Change subject: commands: do not check SW manually, use send_apdu_checksw()
..


Patch Set 2: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/pysim/+/26055/2/pySim/commands.py
File pySim/commands.py:

https://gerrit.osmocom.org/c/pysim/+/26055/2/pySim/commands.py@148
PS2, Line 148:  data, sw = self._tp.send_apdu_checksw(pdu)
I would wrap this block into additional try/catch:

  try:
data, sw = self._tp.send_apdu_checksw(pdu)
total_data += data
chunk_offset += chunk_len
  except Exception as e:
raise ValueError('Failed to read (offset %d)' % (offset)) from e

Note 'from e' in the last line. This way, if send_apdu_checksw() raises an 
exception, it would get equipped with the contextual information. See 
https://docs.python.org/3/tutorial/errors.html#exception-chaining.


https://gerrit.osmocom.org/c/pysim/+/26055/2/pySim/commands.py@177
PS2, Line 177:  chunk_data, chunk_sw = 
self._tp.send_apdu_checksw(pdu)
Same here.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/26055
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79
Gerrit-Change-Number: 26055
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Mon, 01 Nov 2021 18:29:59 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-ttcn3-hacks[master]: BSC_Tests: set band in f_TC_fh_params_set

2021-11-01 Thread dexter
dexter has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828 )

Change subject: BSC_Tests: set band in f_TC_fh_params_set
..

BSC_Tests: set band in f_TC_fh_params_set

The function f_TC_fh_params_set sets frequency hopping parameters. The
ARFCN is also part of those parameters. However, this function does not
set the respective band for the ARFCN that it configurs. This results in
an invalid setting at the BSC that might cause unexpected behavior.

Lets make sure we configure the band parameter correctly before setting
the ARFCN

Change-Id: I447e4145c68c62b11b818e28f0081c19e9107647
Related: SYS#5369
---
M bsc/BSC_Tests.ttcn
1 file changed, 39 insertions(+), 8 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index ee4dac2..ad8f666 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -8439,7 +8439,7 @@

 /* Hopping parameters per a transceiver */
 private type record FHParamsTrx {
-   GsmArfcnarfcn,
+   GsmBandArfcnarfcn,
FHParamsTs  ts[8]
 };

@@ -8448,8 +8448,10 @@
 runs on test_CT return FHParamsTrx {
var FHParamsTrx fhp;

-   /* Generate a random ARFCN, including ARFCN 0 */
-   fhp.arfcn := f_rnd_int(3);
+   /* Generate a random ARFCN in the range of 0 - 3. This ARFCN will
+* fall in the GSM900 band. */
+   fhp.arfcn.arfcn := f_rnd_int(3);
+   fhp.arfcn.pcs := false;

for (var integer tn := 0; tn < 8; tn := tn + 1) {
if (not match(tn, tr_tn)) {
@@ -8488,7 +8490,7 @@
tr_maio_hsn := tr_HsnMaio(fhp.ts[tn].hsn, fhp.ts[tn].maio);
tr_cd := tr_ChanDescH1(cd.chan_nr, tr_maio_hsn);
} else {
-   tr_cd := tr_ChanDescH0(cd.chan_nr, fhp.arfcn);
+   tr_cd := tr_ChanDescH0(cd.chan_nr, fhp.arfcn.arfcn);
}

if (not match(cd, tr_cd)) {
@@ -8533,7 +8535,7 @@
}

/* Take ARFCN of the TRX itself into account */
-   full_mask[fhp.arfcn] := '1'B;
+   full_mask[fhp.arfcn.arfcn] := '1'B;

/* Compose a bit-mask for the given timeslot number */
for (var integer i := 0; i < lengthof(fhp.ts[tn].ma); i := i + 1) {
@@ -8570,15 +8572,41 @@
return { len := ma_mask_len, ma := ma_mask };
 }

+/* Configure the appropriate band for a given arfcn, exc */
+private function f_TC_set_band_by_arfcn(integer bts_nr, GsmBandArfcn arfcn) 
runs on test_CT
+{
+   var charstring band;
+   var GsmBandArfcn arfcn_ := valueof(ts_GsmBandArfcn(arfcn.arfcn, 
arfcn.pcs, false));
+
+   select (arfcn_) {
+   case (tr_GsmBandArfcn((259..293), false, ?)) { band := "GSM450"; }
+   case (tr_GsmBandArfcn((306..340), false, ?)) { band := "GSM480"; }
+   case (tr_GsmBandArfcn((438..511), false, ?)) { band := "GSM750"; }
+   case (tr_GsmBandArfcn((128..251), false, ?)) { band := "GSM850"; }
+   case (tr_GsmBandArfcn((0..124), false, ?)) { band := "GSM900"; }
+   case (tr_GsmBandArfcn((955..1023), false, ?)) { band := "GSM900"; }
+   case (tr_GsmBandArfcn((512..885), false, ?)) { band := "DCS1800"; }
+   case (tr_GsmBandArfcn((512..810), true, ?)) { band := "PCS1900"; }
+   case else { return; }
+   }
+
+   f_vty_enter_cfg_bts(BSCVTY, bts_nr);
+   f_vty_transceive(BSCVTY, "band " & band);
+   f_vty_transceive(BSCVTY, "end");
+}
+
 /* Configure the hopping parameters in accordance with the given record */
 private function f_TC_fh_params_set(in FHParamsTrx fhp,
uint8_t bts_nr := 0,
uint8_t trx_nr := 0)
 runs on test_CT {
+
+   f_TC_set_band_by_arfcn(bts_nr, fhp.arfcn);
+
/* Enter the configuration node for the given BTS/TRX numbers */
f_vty_enter_cfg_trx(BSCVTY, bts_nr, trx_nr);

-   f_vty_transceive(BSCVTY, "arfcn " & int2str(fhp.arfcn));
+   f_vty_transceive(BSCVTY, "arfcn " & int2str(fhp.arfcn.arfcn));

for (var integer tn := 0; tn < lengthof(fhp.ts); tn := tn + 1) {
f_vty_transceive(BSCVTY, "timeslot " & int2str(tn));
@@ -8609,12 +8637,15 @@
 private function f_TC_fh_params_unset(in FHParamsTrx fhp,
  uint8_t bts_nr := 0,
  uint8_t trx_nr := 0,
- GsmArfcn arfcn := 871)
+ GsmBandArfcn arfcn := {pcs := false, 
arfcn := 871})
 runs on test_CT {
+
+   f_TC_set_band_by_arfcn(bts_nr, arfcn);
+
/* Enter the configuration node for the given BTS/TRX numbers */
f_vty_enter_cfg_trx(BSCVTY, bts_nr, trx_nr);

-   f_vty_transceive(BSCVTY, "arfcn " & int2str(arfcn));
+   f_vty_transceive(BSCVTY, "arfcn " & int2str(arfcn.arfcn));

for (var integer tn := 0; tn < lengthof(fhp.ts); tn := tn + 1) {

Change in pysim[master]: commands: do not check SW manually, use send_apdu_checksw()

2021-11-01 Thread dexter
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/pysim/+/26055

to look at the new patch set (#2).

Change subject: commands: do not check SW manually, use send_apdu_checksw()
..

commands: do not check SW manually, use send_apdu_checksw()

The transport layer provides a method send_apdu_checksw to send APDUs
and to be sure the SW is the expected one. Given that, there is no need
to verify the SW manually. The exception of send_apdu_checksw will catch
the problem and also display the SW in a human readable form.

Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79
Related: OS#5275
---
M pySim/commands.py
1 file changed, 7 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/55/26055/2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/26055
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79
Gerrit-Change-Number: 26055
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset


Change in pysim[master]: commands: do not check SW manually, use send_apdu_checksw()

2021-11-01 Thread dexter
dexter has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/pysim/+/26055 )


Change subject: commands: do not check SW manually, use send_apdu_checksw()
..

commands: do not check SW manually, use send_apdu_checksw()

The transport layer provides a method send_apdu_checksw to send APDUs
and to be sure the SW is the expected one. Given that, there is no need
to verify the SW manually. The exception of send_apdu_checksw will catch
the problem and also display the SW in a human readable form.

Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79
Related: OS#5275
---
M pySim/commands.py
1 file changed, 6 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/55/26055/1

diff --git a/pySim/commands.py b/pySim/commands.py
index 805fe61..dbe7e51 100644
--- a/pySim/commands.py
+++ b/pySim/commands.py
@@ -145,12 +145,9 @@
while chunk_offset < length:
chunk_len = min(255, length-chunk_offset)
pdu = self.cla_byte + 'b0%04x%02x' % (offset + 
chunk_offset, chunk_len)
-   data,sw = self._tp.send_apdu(pdu)
-   if sw == '9000':
-   total_data += data
-   chunk_offset += chunk_len
-   else:
-   raise ValueError('Failed to read (offset %d)' % 
(offset))
+   data, sw = self._tp.send_apdu_checksw(pdu)
+   total_data += data
+   chunk_offset += chunk_len
return total_data, sw

def update_binary(self, ef, data:str, offset:int=0, verify:bool=False, 
conserve:bool=False):
@@ -172,19 +169,14 @@

self.select_path(ef)
total_data = ''
-   total_sw = "9000"
chunk_offset = 0
while chunk_offset < data_length:
chunk_len = min(255, data_length - chunk_offset)
# chunk_offset is bytes, but data slicing is hex chars, 
so we need to multiply by 2
pdu = self.cla_byte + 'd6%04x%02x' % (offset + 
chunk_offset, chunk_len) + data[chunk_offset*2 : (chunk_offset+chunk_len)*2]
-   chunk_data, chunk_sw = self._tp.send_apdu(pdu)
-   if chunk_sw == total_sw:
-   total_data += chunk_data
-   chunk_offset += chunk_len
-   else:
-   total_sw = chunk_sw
-   raise ValueError('Failed to write chunk 
(chunk_offset %d, chunk_len %d)' % (chunk_offset, chunk_len))
+   chunk_data, chunk_sw = self._tp.send_apdu_checksw(pdu)
+   total_data += chunk_data
+   chunk_offset += chunk_len
if verify:
self.verify_binary(ef, data, offset)
return total_data, total_sw

--
To view, visit https://gerrit.osmocom.org/c/pysim/+/26055
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79
Gerrit-Change-Number: 26055
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-MessageType: newchange


Change in osmo-bts[master]: osmo-bts-trx-calypso.cfg: Adjust settings to work with current osmo-b...

2021-11-01 Thread fixeria
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/26054 )

Change subject: osmo-bts-trx-calypso.cfg: Adjust settings to work with current 
osmo-bts versions
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26054
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I69436b914cf1bec57f9fe7acea4a896e7c46b3a9
Gerrit-Change-Number: 26054
Gerrit-PatchSet: 1
Gerrit-Owner: roox 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Comment-Date: Mon, 01 Nov 2021 16:13:19 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-bts[master]: osmo-bts-trx-calypso.cfg: Adjust settings to work with current osmo-b...

2021-11-01 Thread roox
roox has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/26054 )


Change subject: osmo-bts-trx-calypso.cfg: Adjust settings to work with current 
osmo-bts versions
..

osmo-bts-trx-calypso.cfg: Adjust settings to work with current osmo-bts versions

* Remove deprecated configuration options:
  'osmotrx timing-advance-loop' is deprecated, Timing Advance loop is now 
active by default
  'osmotrx ms-power-loop <-127-127>' is deprecated, MS Power Control is now 
managed by BSC
* Adjust 'ipa unit-id' (1801 -> 6969) to match the one from the example 
osmo-bsc.cfg
* Set clock advance values to known working values:
  + 'osmotrx fn-advance' -> 20
  + 'osmotrx rts-advance' -> 5
* Set 'nominal-tx-power' since the calypso-bts tranceiver does not support 
NOMTXPOWER

Change-Id: I69436b914cf1bec57f9fe7acea4a896e7c46b3a9
---
M doc/examples/trx/osmo-bts-trx-calypso.cfg
1 file changed, 5 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/54/26054/1

diff --git a/doc/examples/trx/osmo-bts-trx-calypso.cfg 
b/doc/examples/trx/osmo-bts-trx-calypso.cfg
index 3f2e778..d6cc43a 100644
--- a/doc/examples/trx/osmo-bts-trx-calypso.cfg
+++ b/doc/examples/trx/osmo-bts-trx-calypso.cfg
@@ -1,6 +1,6 @@
 !
 ! OsmoBTS configuration example for CalypsoBTS
-! http://osmocom.org/projects/baseband/wiki/CalypsoBTS
+! https://osmocom.org/projects/baseband/wiki/CalypsoBTS
 !!
 !
 log stderr
@@ -24,14 +24,15 @@
  instance 0
  osmotrx ip local 127.0.0.1
  osmotrx ip remote 127.0.0.1
- osmotrx timing-advance-loop
- osmotrx ms-power-loop -65
  osmotrx legacy-setbsic
+ osmotrx fn-advance 20
+ osmotrx rts-advance 5
 bts 0
  oml remote-ip 127.0.0.1
- ipa unit-id 1801 0
+ ipa unit-id 6969 0
  gsmtap-sapi pdtch
  gsmtap-sapi ccch
  band 900
  trx 0
   phy 0 instance 0
+  nominal-tx-power 23

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26054
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I69436b914cf1bec57f9fe7acea4a896e7c46b3a9
Gerrit-Change-Number: 26054
Gerrit-PatchSet: 1
Gerrit-Owner: roox 
Gerrit-MessageType: newchange


Change in simtrace2[master]: add our default clang-format file

2021-11-01 Thread laforge
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/simtrace2/+/26030 )

Change subject: add our default clang-format file
..

add our default clang-format file

Change-Id: I77aab70400bdbb46cbdd83e428e2a28ebf29b8dd
---
A .clang-format
1 file changed, 563 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/.clang-format b/.clang-format
new file mode 100644
index 000..5d4791c
--- /dev/null
+++ b/.clang-format
@@ -0,0 +1,563 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# clang-format configuration file. Intended for clang-format >= 4.
+#
+# For more information, see:
+#
+#   Documentation/process/clang-format.rst
+#   https://clang.llvm.org/docs/ClangFormat.html
+#   https://clang.llvm.org/docs/ClangFormatStyleOptions.html
+#
+---
+AccessModifierOffset: -4
+AlignAfterOpenBracket: Align
+AlignConsecutiveAssignments: false
+AlignConsecutiveDeclarations: false
+#AlignEscapedNewlines: Left # Unknown to clang-format-4.0
+AlignOperands: true
+AlignTrailingComments: false
+AllowAllParametersOfDeclarationOnNextLine: false
+AllowShortBlocksOnASingleLine: false
+AllowShortCaseLabelsOnASingleLine: false
+AllowShortFunctionsOnASingleLine: None
+AllowShortIfStatementsOnASingleLine: false
+AllowShortLoopsOnASingleLine: false
+AlwaysBreakAfterDefinitionReturnType: None
+AlwaysBreakAfterReturnType: None
+AlwaysBreakBeforeMultilineStrings: false
+AlwaysBreakTemplateDeclarations: false
+BinPackArguments: true
+BinPackParameters: true
+BraceWrapping:
+  AfterClass: false
+  AfterControlStatement: false
+  AfterEnum: false
+  AfterFunction: true
+  AfterNamespace: true
+  AfterObjCDeclaration: false
+  AfterStruct: false
+  AfterUnion: false
+  #AfterExternBlock: false # Unknown to clang-format-5.0
+  BeforeCatch: false
+  BeforeElse: false
+  IndentBraces: false
+  #SplitEmptyFunction: true # Unknown to clang-format-4.0
+  #SplitEmptyRecord: true # Unknown to clang-format-4.0
+  #SplitEmptyNamespace: true # Unknown to clang-format-4.0
+BreakBeforeBinaryOperators: None
+BreakBeforeBraces: Custom
+#BreakBeforeInheritanceComma: false # Unknown to clang-format-4.0
+BreakBeforeTernaryOperators: false
+BreakConstructorInitializersBeforeComma: false
+#BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0
+BreakAfterJavaFieldAnnotations: false
+BreakStringLiterals: false
+ColumnLimit: 120
+CommentPragmas: '^ IWYU pragma:'
+#CompactNamespaces: false # Unknown to clang-format-4.0
+ConstructorInitializerAllOnOneLineOrOnePerLine: false
+ConstructorInitializerIndentWidth: 8
+ContinuationIndentWidth: 8
+Cpp11BracedListStyle: false
+DerivePointerAlignment: false
+DisableFormat: false
+ExperimentalAutoDetectBinPacking: false
+#FixNamespaceComments: false # Unknown to clang-format-4.0
+
+# Taken from:
+#   git grep -h '^#define [^[:space:]]*for_each[^[:space:]]*(' include/ \
+#   | sed "s,^#define \([^[:space:]]*for_each[^[:space:]]*\)(.*$,  - '\1'," \
+#   | sort | uniq
+ForEachMacros:
+  - 'apei_estatus_for_each_section'
+  - 'ata_for_each_dev'
+  - 'ata_for_each_link'
+  - '__ata_qc_for_each'
+  - 'ata_qc_for_each'
+  - 'ata_qc_for_each_raw'
+  - 'ata_qc_for_each_with_internal'
+  - 'ax25_for_each'
+  - 'ax25_uid_for_each'
+  - '__bio_for_each_bvec'
+  - 'bio_for_each_bvec'
+  - 'bio_for_each_bvec_all'
+  - 'bio_for_each_integrity_vec'
+  - '__bio_for_each_segment'
+  - 'bio_for_each_segment'
+  - 'bio_for_each_segment_all'
+  - 'bio_list_for_each'
+  - 'bip_for_each_vec'
+  - 'bitmap_for_each_clear_region'
+  - 'bitmap_for_each_set_region'
+  - 'blkg_for_each_descendant_post'
+  - 'blkg_for_each_descendant_pre'
+  - 'blk_queue_for_each_rl'
+  - 'bond_for_each_slave'
+  - 'bond_for_each_slave_rcu'
+  - 'bpf_for_each_spilled_reg'
+  - 'btree_for_each_safe128'
+  - 'btree_for_each_safe32'
+  - 'btree_for_each_safe64'
+  - 'btree_for_each_safel'
+  - 'card_for_each_dev'
+  - 'cgroup_taskset_for_each'
+  - 'cgroup_taskset_for_each_leader'
+  - 'cpufreq_for_each_entry'
+  - 'cpufreq_for_each_entry_idx'
+  - 'cpufreq_for_each_valid_entry'
+  - 'cpufreq_for_each_valid_entry_idx'
+  - 'css_for_each_child'
+  - 'css_for_each_descendant_post'
+  - 'css_for_each_descendant_pre'
+  - 'device_for_each_child_node'
+  - 'displayid_iter_for_each'
+  - 'dma_fence_chain_for_each'
+  - 'do_for_each_ftrace_op'
+  - 'drm_atomic_crtc_for_each_plane'
+  - 'drm_atomic_crtc_state_for_each_plane'
+  - 'drm_atomic_crtc_state_for_each_plane_state'
+  - 'drm_atomic_for_each_plane_damage'
+  - 'drm_client_for_each_connector_iter'
+  - 'drm_client_for_each_modeset'
+  - 'drm_connector_for_each_possible_encoder'
+  - 'drm_for_each_bridge_in_chain'
+  - 'drm_for_each_connector_iter'
+  - 'drm_for_each_crtc'
+  - 'drm_for_each_crtc_reverse'
+  - 'drm_for_each_encoder'
+  - 'drm_for_each_encoder_mask'
+  - 'drm_for_each_fb'
+  - 'drm_for_each_legacy_plane'
+  - 'drm_for_each_plane'
+  - 

Change in simtrace2[master]: firmware: drop cref printing

2021-11-01 Thread laforge
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/simtrace2/+/26029 )

Change subject: firmware: drop cref printing
..

firmware: drop cref printing

No one reads this, no one wants to know this.

Change-Id: Ie2281e207164f82d8ee29bd596a5593c22aaf198
---
M firmware/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/firmware/Makefile b/firmware/Makefile
index 810c7f3..f6e8316 100644
--- a/firmware/Makefile
+++ b/firmware/Makefile
@@ -205,7 +205,7 @@
 endif

 ASFLAGS = -mcpu=cortex-m3 -mthumb -Wall -g $(OPTIMIZATION) $(INCLUDES) 
-D$(CHIP) -D__ASSEMBLY__
-LDFLAGS = -mcpu=cortex-m3 -mthumb -Wl,--cref -Wl,--check-sections 
-Wl,--gc-sections -Wl,--entry=ResetException 
-Wl,--unresolved-symbols=report-all -Wl,--warn-common -Wl,--no-undefined $(LIB)
+LDFLAGS = -mcpu=cortex-m3 -mthumb -Wl,--check-sections -Wl,--gc-sections 
-Wl,--entry=ResetException -Wl,--unresolved-symbols=report-all 
-Wl,--warn-common -Wl,--no-undefined $(LIB)
 ifeq ("$(USE_CLANG)","0")
 LDFLAGS += -Wl,--warn-section-align -Wl,--print-memory-usage
 endif

--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26029
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Ie2281e207164f82d8ee29bd596a5593c22aaf198
Gerrit-Change-Number: 26029
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged


Change in simtrace2[master]: firmware: increase reset delay before usb reattach

2021-11-01 Thread laforge
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/simtrace2/+/26028 )

Change subject: firmware: increase reset delay before usb reattach
..

firmware: increase reset delay before usb reattach

The previous value was way too low and led to reenumeration issues when
switching from app to bl because the hosts are fairly lenient and
feature long delays until they accept disappearing devices as gone for
good instead of ignoring a presuambly flaky usb cable or connection.

Related: SYS5061
Change-Id: I9b8c8bf794ad5b94fc7ea2a01d1ebf4e36862c36
---
M firmware/apps/dfu/main.c
M firmware/libcommon/source/usb.c
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/firmware/apps/dfu/main.c b/firmware/apps/dfu/main.c
index 4813881..48ba879 100644
--- a/firmware/apps/dfu/main.c
+++ b/firmware/apps/dfu/main.c
@@ -342,7 +342,7 @@
TRACE_INFO("USB init...\n\r");
/* Signal USB reset by disabling the pull-up on USB D+ for at least 10 
ms */
USBD_Disconnect();
-   mdelay(50);
+   mdelay(500);
USBDFU_Initialize(_descriptors);

while (USBD_GetState() < USBD_STATE_CONFIGURED) {
diff --git a/firmware/libcommon/source/usb.c b/firmware/libcommon/source/usb.c
index 0868263..d86fc92 100644
--- a/firmware/libcommon/source/usb.c
+++ b/firmware/libcommon/source/usb.c
@@ -690,7 +690,7 @@
unsigned int i;
/* Signal USB reset by disabling the pull-up on USB D+ for at least 10 
ms */
USBD_HAL_Suspend();
-   mdelay(20);
+   mdelay(500);
USBD_HAL_Activate();

// Get std USB driver

--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26028
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I9b8c8bf794ad5b94fc7ea2a01d1ebf4e36862c36
Gerrit-Change-Number: 26028
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged


Change in simtrace2[master]: firmware: remove usb pullup that dates back to simtrace1

2021-11-01 Thread laforge
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/simtrace2/+/26027 )

Change subject: firmware: remove usb pullup that dates back to simtrace1
..

firmware: remove usb pullup that dates back to simtrace1

All the parts are DNP and never existed on the simtrace2 with sam3; the
sam3 has internal pullups that are part of the usb peripheral.

Change-Id: I04a703a2eba6ff1dc64692c089213389d0c1066d
---
M firmware/apps/dfu/main.c
M firmware/libboard/octsimtest/include/board.h
M firmware/libboard/sam3p256/include/board.h
M firmware/libboard/simtrace/include/board.h
M firmware/libcommon/source/usb.c
5 files changed, 0 insertions(+), 32 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/firmware/apps/dfu/main.c b/firmware/apps/dfu/main.c
index d5a6fa6..4813881 100644
--- a/firmware/apps/dfu/main.c
+++ b/firmware/apps/dfu/main.c
@@ -342,16 +342,7 @@
TRACE_INFO("USB init...\n\r");
/* Signal USB reset by disabling the pull-up on USB D+ for at least 10 
ms */
USBD_Disconnect();
-#ifdef PIN_USB_PULLUP
-   const Pin usb_dp_pullup = PIN_USB_PULLUP;
-   PIO_Configure(_dp_pullup, 1);
-   PIO_Set(_dp_pullup);
-#endif
mdelay(50);
-#ifdef PIN_USB_PULLUP
-   PIO_Clear(_dp_pullup);
-#endif
-
USBDFU_Initialize(_descriptors);

while (USBD_GetState() < USBD_STATE_CONFIGURED) {
diff --git a/firmware/libboard/octsimtest/include/board.h 
b/firmware/libboard/octsimtest/include/board.h
index 530f27b..697619c 100644
--- a/firmware/libboard/octsimtest/include/board.h
+++ b/firmware/libboard/octsimtest/include/board.h
@@ -87,11 +87,6 @@
 /* SPI flash write protect pin (active low, pulled low) */
 #define PIN_SPI_WP{PA15, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT}

-/** Pin configuration to control USB pull-up on D+
- *  @details the USB pull-up on D+ is enable by default on the board but can 
be disabled by setting PA16 high
- */
-#define PIN_USB_PULLUP  {PIO_PA16, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT}
-
 /** USB definitions */
 /* OpenMoko SIMtrace 2 USB vendor ID */
 #define BOARD_USB_VENDOR_IDUSB_VENDOR_OPENMOKO
diff --git a/firmware/libboard/sam3p256/include/board.h 
b/firmware/libboard/sam3p256/include/board.h
index 58e8a24..06cfdce 100644
--- a/firmware/libboard/sam3p256/include/board.h
+++ b/firmware/libboard/sam3p256/include/board.h
@@ -135,11 +135,6 @@
 #define PIN_SPI_WP{PA15, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT}
 #endif

-/** Pin configuration to control USB pull-up on D+
- *  @details the USB pull-up on D+ is enable by default on the board but can 
be disabled by setting PA16 high
- */
-#define PIN_USB_PULLUP  {PIO_PA16, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT}
-
 /** USB definitions */
 /* OpenMoko SIMtrace 2 USB vendor ID */
 #define BOARD_USB_VENDOR_IDUSB_VENDOR_OPENMOKO
diff --git a/firmware/libboard/simtrace/include/board.h 
b/firmware/libboard/simtrace/include/board.h
index be18f64..6e4cd98 100644
--- a/firmware/libboard/simtrace/include/board.h
+++ b/firmware/libboard/simtrace/include/board.h
@@ -134,11 +134,6 @@
 /* SPI flash write protect pin (active low, pulled low) */
 #define PIN_SPI_WP{PA15, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT}

-/** Pin configuration to control USB pull-up on D+
- *  @details the USB pull-up on D+ is enable by default on the board but can 
be disabled by setting PA16 high
- */
-#define PIN_USB_PULLUP  {PIO_PA16, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT}
-
 /** USB definitions */
 /* OpenMoko SIMtrace 2 USB vendor ID */
 #define BOARD_USB_VENDOR_IDUSB_VENDOR_OPENMOKO
diff --git a/firmware/libcommon/source/usb.c b/firmware/libcommon/source/usb.c
index e75646e..0868263 100644
--- a/firmware/libcommon/source/usb.c
+++ b/firmware/libcommon/source/usb.c
@@ -689,16 +689,8 @@
 {
unsigned int i;
/* Signal USB reset by disabling the pull-up on USB D+ for at least 10 
ms */
-#ifdef PIN_USB_PULLUP
-   const Pin usb_dp_pullup = PIN_USB_PULLUP;
-   PIO_Configure(_dp_pullup, 1);
-   PIO_Set(_dp_pullup);
-#endif
USBD_HAL_Suspend();
mdelay(20);
-#ifdef PIN_USB_PULLUP
-   PIO_Clear(_dp_pullup);
-#endif
USBD_HAL_Activate();

// Get std USB driver

--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26027
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I04a703a2eba6ff1dc64692c089213389d0c1066d
Gerrit-Change-Number: 26027
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged


Change in osmo-bts[master]: [overpower] Turn it on and off depending on DL RxQual

2021-11-01 Thread fixeria
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/25899 )

Change subject: [overpower] Turn it on and off depending on DL RxQual
..


Patch Set 7:

This change is ready for review.


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25899
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iaa812d4661ee17c4cd4a8c4ae4bd3e94c1a2e6cc
Gerrit-Change-Number: 25899
Gerrit-PatchSet: 7
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 01 Nov 2021 14:14:09 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in pysim[master]: pySim-shell: add method to probe for UICC

2021-11-01 Thread dexter
dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/26043 )

Change subject: pySim-shell: add method to probe for UICC
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/26043/1/pySim-shell.py
File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/26043/1/pySim-shell.py@87
PS1, Line 87: card_is_uicc = probe_card(card, ['UICC'])
> why does the 'UICC' get passed in a list? […]
It gets passed in a list because in theory the function can do more than one 
test in one go. Its also possible to ask ['UICC', 'SIM'] = Is this a UICC card 
with SIM functionality? Unfortunately I noticed that I did not need the 
possibility to ask for both at once.

Regarding the card model I think we should try to drop it - we could keep the 
file as compatibility layer for pySim-prog and pySim-read, but in pySim-shell 
we should try to use the SimCardCommands class directly. Thats what we already 
do by using the private _scc object in the card object, which is not nice 
because _scc is ment to be a private property of the card.

I think the only special functions of the card object we use is the verify_adm 
method, which may be different for each card. This is not much and can 
separated, so that the pySim-shell and the old code can use it.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/26043
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I535bef35847140e611d4fa95ed2859ee81cce605
Gerrit-Change-Number: 26043
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge 
Gerrit-Comment-Date: Mon, 01 Nov 2021 13:38:50 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment


Change in simtrace2[master]: firmware: drop cref printing

2021-11-01 Thread Hoernchen
Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/simtrace2/+/26029

to look at the new patch set (#5).

Change subject: firmware: drop cref printing
..

firmware: drop cref printing

No one reads this, no one wants to know this.

Change-Id: Ie2281e207164f82d8ee29bd596a5593c22aaf198
---
M firmware/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/29/26029/5
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26029
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Ie2281e207164f82d8ee29bd596a5593c22aaf198
Gerrit-Change-Number: 26029
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset


Change in simtrace2[master]: firmware: remove usb pullup that dates back to simtrace1

2021-11-01 Thread Hoernchen
Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/simtrace2/+/26027

to look at the new patch set (#5).

Change subject: firmware: remove usb pullup that dates back to simtrace1
..

firmware: remove usb pullup that dates back to simtrace1

All the parts are DNP and never existed on the simtrace2 with sam3; the
sam3 has internal pullups that are part of the usb peripheral.

Change-Id: I04a703a2eba6ff1dc64692c089213389d0c1066d
---
M firmware/apps/dfu/main.c
M firmware/libboard/octsimtest/include/board.h
M firmware/libboard/sam3p256/include/board.h
M firmware/libboard/simtrace/include/board.h
M firmware/libcommon/source/usb.c
5 files changed, 0 insertions(+), 32 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/27/26027/5
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26027
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I04a703a2eba6ff1dc64692c089213389d0c1066d
Gerrit-Change-Number: 26027
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset


Change in simtrace2[master]: firmware: increase reset delay before usb reattach

2021-11-01 Thread Hoernchen
Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/simtrace2/+/26028

to look at the new patch set (#5).

Change subject: firmware: increase reset delay before usb reattach
..

firmware: increase reset delay before usb reattach

The previous value was way too low and led to reenumeration issues when
switching from app to bl because the hosts are fairly lenient and
feature long delays until they accept disappearing devices as gone for
good instead of ignoring a presuambly flaky usb cable or connection.

Related: SYS5061
Change-Id: I9b8c8bf794ad5b94fc7ea2a01d1ebf4e36862c36
---
M firmware/apps/dfu/main.c
M firmware/libcommon/source/usb.c
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/28/26028/5
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26028
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I9b8c8bf794ad5b94fc7ea2a01d1ebf4e36862c36
Gerrit-Change-Number: 26028
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset


Change in simtrace2[master]: jenkins: build bootloader updater

2021-11-01 Thread Hoernchen
Hoernchen has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/simtrace2/+/26053 )


Change subject: jenkins: build bootloader updater
..

jenkins: build bootloader updater

Change-Id: I8b2023921a67b0e8945d8f24e4c8076de3e12acf
---
M contrib/jenkins.sh
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/53/26053/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 40015f7..8e81820 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -28,11 +28,11 @@
 export LD_LIBRARY_PATH="$inst/lib"

 BUILDS=""
-BUILDS+="simtrace/dfu simtrace/trace simtrace/cardem "
-BUILDS+="qmod/dfu qmod/cardem "
-BUILDS+="owhw/dfu owhw/cardem "
+BUILDS+="simtrace/dfu simtrace/blupdate simtrace/trace simtrace/cardem "
+BUILDS+="qmod/dfu qmod/blupdate qmod/cardem "
+BUILDS+="owhw/dfu owhw/blupdate owhw/cardem "
 BUILDS+="octsimtest/cardem "
-BUILDS+="ngff_cardem/dfu ngff_cardem/cardem ngff_cardem/trace "
+BUILDS+="ngff_cardem/dfu ngff_cardem/blupdate ngff_cardem/cardem 
ngff_cardem/trace "

 cd $TOPDIR/firmware
 for build in $BUILDS; do

--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26053
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I8b2023921a67b0e8945d8f24e4c8076de3e12acf
Gerrit-Change-Number: 26053
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen 
Gerrit-MessageType: newchange


Change in simtrace2[master]: add our default clang-format file

2021-11-01 Thread Hoernchen
Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/simtrace2/+/26030

to look at the new patch set (#3).

Change subject: add our default clang-format file
..

add our default clang-format file

Change-Id: I77aab70400bdbb46cbdd83e428e2a28ebf29b8dd
---
A .clang-format
1 file changed, 563 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/30/26030/3
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26030
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I77aab70400bdbb46cbdd83e428e2a28ebf29b8dd
Gerrit-Change-Number: 26030
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset


Change in osmo-ttcn3-hacks[master]: BTS_Tests: execute test cases for BS power control on TRX1

2021-11-01 Thread Hoernchen
Hoernchen has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25908 )

Change subject: BTS_Tests: execute test cases for BS power control on TRX1
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25908
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ied3e38986690850f0323d4db072cf59b6975587e
Gerrit-Change-Number: 25908
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 01 Nov 2021 12:49:10 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr

2021-11-01 Thread neels
neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/25973 )

Change subject: add time_cc API: cumlative counter for time, reported as 
rate_ctr
..


Patch Set 1:

> > Well maybe then the question is why are you using rate_ctr and not 
> > stat_items here, it really confuses me.
> 
> At least at first sight, I agree.  The resulting metric computed by this  new 
> code base renders a single value which matches better a state_item than a 
> rate_ctr. Any particular argument to go for rate_ctr, Neels?

The decision to use a rate_ctr is based on discussion with the customer,
and it also makes a lot of sence in practice.

Logically, a stat_item is not actually a good choice. We can of course report 
the total time of all-allocated, and thus get for example the complete amount 
of seconds that all SDCCH channels were allocated since osmo-bsc started. But 
it's not interesting to get an arbitrary amount of time of all-allocated since 
forever; instead, it is important to qualify in which period of elapsed time 
this amount was accumulated. A rate_ctr is well suited since it also provides 
the "per time" aspect. All rate_ctr stats reflect a number-of-events-per-time. 
For all_allocated, it is the number of seconds that all channels were allocated 
per a given amount of time. For example, if the VTY shows all_allocated:sdcch 
of 10/min, it means all channels were allocated for 10 seconds of the last 
minute. For a stat item, getting this "per time" part is a complex problem.

When reporting as a stat_item, we open a new dimension of options:
The spec defines different reporting periods, suggesting at least the options 
of 5 minutes, 15 minutes, 30 minutes, 60 minutes. We could periodically clear 
the stat item based on user config.
The customer requesting this feature already implements these reporting periods 
outside of osmo-bsc, based on stats received from osmo-bsc. So instead of 
introducing these reporting periods to osmo-bsc and choose some method of 
adding a per-time aspect to stat_item, it is best to just trigger a count for 
each second of all-allocated-channels.

> simply a counter value changing over time.

When I started on it, I thought it would take half an hour.
When thinking about the exact implementation, the options and complexity 
unfolded...
This patch is the result that ensures correct counts with minimal complexity.

> So I'm not really following on why you need all this infrastructure sorry,

I would appreciate if your criticism could be qualified as well as constructive.
What do you mean by "all this"? What do you suggest instead?

> this all looks super complicated for no reason (I'm able to see). Maybe 
> someone else can also shed some light on it.

It's straightforward:

The aim is to report for how many seconds per given time period all channels of 
a type were allocated.
To achieve that, we need to count free/allocated lchans.
When a count reveals that all chans of type X are allocated, we set a flag to 
true.
Based on that flag, a time counter increments. The flag-per-time counter is 
generalized API (time_cc).
In order to periodically report that time counter to stats, an osmo_timer is 
involved.

I am open to simplifications, if possible.

There are some additional options to configure time_cc with different 
granularity,
and to allow tweaking the counter precision vs response time.
These options aren't strictly necessary. I think they make sense to keep 
time_cc generally useful.

> So the question remains: Should the result be exposed as rate_ctr or as 
> stat_item?

We could do both, in fact. All the complex parts are already implemented and 
working correctly.

Next to the rate_ctr, we can just add a stat_item to time_cc, and publish the 
time count as stat item. But then we need to define the time periods and exact 
meaning of the stat_item values.
I encourage you to practically imagine the solution and you should see how the 
problem is not as trivial as it sounds at first. It is easy to add the 
stat_item, as soon as it is clear which value the stat_item should reflect. We 
already have a value implemented that counts all seconds where all channels 
were allocated since osmo-bsc started. But does it make sense to publish that 
as stat_item?

Here are the various ideas I had before we decided for a rate_ctr as the 
simplest and most effective solution:

"
I am thinking about the allAvailable{TCH,SDCCH}AllocatedTime indicators:

In 3GPP TS 52.402, there is a defined Granularity Period, which is configurable,
and suggested to have at least the settings of 5, 15, 30, 60 minutes.
The allAvailableXxxAllocatedTime indicators are defined as cumulative counter 
(CC),
which I interpret as the number of seconds that all channels of the given kind 
were occupied.

A "problem" is that the meaning of this cumulative value depends on the 
Granularity Period.
For example, if the granularity 

Change in osmo-bsc[master]: control.adoc: comment out fixme note

2021-11-01 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/26052 )

Change subject: control.adoc: comment out fixme note
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26052
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id68f53d18f0873af3c07a0ae52cd12bc94bc0b96
Gerrit-Change-Number: 26052
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Mon, 01 Nov 2021 12:06:15 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-bsc[master]: heighbor_ident: add/del neighbor cells via ctrl interface

2021-11-01 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/25976 )

Change subject: heighbor_ident: add/del neighbor cells via ctrl interface
..


Patch Set 6: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25976
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I343a40e18fa9b91e6c381912c0426a002841e079
Gerrit-Change-Number: 25976
Gerrit-PatchSet: 6
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-CC: fixeria 
Gerrit-Comment-Date: Mon, 01 Nov 2021 12:06:00 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in simtrace2[master]: firmware: increase reset delay before usb reattach

2021-11-01 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/simtrace2/+/26028 )

Change subject: firmware: increase reset delay before usb reattach
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26028
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I9b8c8bf794ad5b94fc7ea2a01d1ebf4e36862c36
Gerrit-Change-Number: 26028
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Mon, 01 Nov 2021 12:04:39 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in simtrace2[master]: firmware: remove usb pullup that dates back to simtrace1

2021-11-01 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/simtrace2/+/26027 )

Change subject: firmware: remove usb pullup that dates back to simtrace1
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26027
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I04a703a2eba6ff1dc64692c089213389d0c1066d
Gerrit-Change-Number: 26027
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Mon, 01 Nov 2021 12:04:33 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in simtrace2[master]: firmware: add bootloader update "app"

2021-11-01 Thread laforge
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/simtrace2/+/26026 )

Change subject: firmware: add bootloader update "app"
..

firmware: add bootloader update "app"

This bl updater can be flashed as app and will update the bootloader and
then
delete itself before resetting the sam3, so the device will end up in
the newly
updated dfu bootloader afterwards, without having to press the
bootloader button
or requring any other manual interaction, ready to receive a new
application image.

Building the blupdater requires a previously built dfu-flash bootloader
bin file that
will then be embedded into the app during building.

Related: OS#1704
Related: SYS5061
Change-Id: I53dea57bba790a2ab3245d9483e0ff1c8d19d5e3
---
M Makefile
M firmware/Makefile
A firmware/apps/blupdate/Makefile
A firmware/apps/blupdate/main.c
M firmware/libboard/common/resources/sam3s4/dfu.ld
5 files changed, 192 insertions(+), 9 deletions(-)

Approvals:
  laforge: Looks good to me, approved; Verified



diff --git a/Makefile b/Makefile
index b15f38d..9951e54 100644
--- a/Makefile
+++ b/Makefile
@@ -8,16 +8,23 @@
 endef

 $(eval $(call RULES,simtrace,dfu))
+$(eval $(call RULES,simtrace,blupdate))
 $(eval $(call RULES,simtrace,trace))
 $(eval $(call RULES,simtrace,cardem))
 $(eval $(call RULES,qmod,dfu))
+$(eval $(call RULES,qmod,blupdate))
 $(eval $(call RULES,qmod,cardem))
 $(eval $(call RULES,ngff_cardem,dfu))
+$(eval $(call RULES,ngff_cardem,blupdate))
 $(eval $(call RULES,ngff_cardem,trace))
 $(eval $(call RULES,ngff_cardem,cardem))

-fw-clean: fw-simtrace-dfu-clean fw-simtrace-trace-clean 
fw-simtrace-cardem-clean fw-qmod-dfu-clean fw-qmod-cardem-clean
-fw: fw-simtrace-dfu fw-simtrace-trace fw-simtrace-cardem fw-qmod-dfu 
fw-qmod-cardem fw-ngff_cardem-dfu fw-ngff_cardem-trace fw-ngff_cardem-cardem
+fw-clean: fw-simtrace-dfu-clean fw-simtrace-blupdate-clean 
fw-simtrace-trace-clean fw-simtrace-cardem-clean \
+   fw-qmod-dfu-clean fw-qmod-blupdate-clean fw-qmod-cardem-clean \
+   fw-ngff_cardem-dfu-clean fw-ngff_cardem-blupdate-clean 
fw-ngff_cardem-trace-clean fw-ngff_cardem-cardem-clean
+fw: fw-simtrace-dfu fw-simtrace-blupdate fw-simtrace-trace fw-simtrace-cardem \
+   fw-qmod-dfu fw-qmod-blupdate fw-qmod-cardem \
+   fw-ngff_cardem-dfu fw-ngff_cardem-blupdate fw-ngff_cardem-trace 
fw-ngff_cardem-cardem

 utils:
(cd host && \
diff --git a/firmware/Makefile b/firmware/Makefile
index bfe2c9d..810c7f3 100644
--- a/firmware/Makefile
+++ b/firmware/Makefile
@@ -245,12 +245,13 @@
 define RULES
 C_OBJECTS_$(1) = $(addprefix $(OBJ)/$(1)_, $(C_OBJECTS))
 ASM_OBJECTS_$(1) = $(addprefix $(OBJ)/$(1)_, $(ASM_OBJECTS))
+EXTRA_OBJECTS_$(1) = $(addprefix $(OBJ)/$(1)_, $(EXTRA_OBJECTS))

-$(1): $$(ASM_OBJECTS_$(1)) $$(C_OBJECTS_$(1))
-   $(SILENT)$(CC) $(CFLAGS) $(LDFLAGS) $(LD_OPTIONAL) 
-T"libboard/common/resources/$(CHIP)/$$@.ld" -Wl,-Map,$(OUTPUT)-$$@.map -o 
$(OUTPUT)-$$@.elf $$^ $(LIBS)
-   $(SILENT)$(NM) $(OUTPUT)-$$@.elf >$(OUTPUT)-$$@.elf.txt
-   $(SILENT)$(OBJCOPY) -O binary $(OUTPUT)-$$@.elf $(OUTPUT)-$$@.bin
-   $(SILENT)$(SIZE) $$^ $(OUTPUT)-$$@.elf
+build_$(1): $$(ASM_OBJECTS_$(1)) $$(C_OBJECTS_$(1)) $$(EXTRA_OBJECTS_$(1))
+   $(SILENT)$(CC) $(CFLAGS) $(LDFLAGS) $(LD_OPTIONAL) 
-T"libboard/common/resources/$(CHIP)/$(1).ld" -Wl,-Map,$(OUTPUT)-$(1).map -o 
$(OUTPUT)-$(1).elf $$^ $(LIBS)
+   $(SILENT)$(NM) $(OUTPUT)-$(1).elf >$(OUTPUT)-$(1).elf.txt
+   $(SILENT)$(OBJCOPY) -O binary $(OUTPUT)-$(1).elf $(OUTPUT)-$(1).bin
+   $(SILENT)$(SIZE) $$^ $(OUTPUT)-$(1).elf

 $$(C_OBJECTS_$(1)): $(OBJ)/$(1)_%.o: %.c Makefile $(OBJ) $(BIN)
@echo [COMPILING $$<]
@@ -258,13 +259,34 @@

 $$(ASM_OBJECTS_$(1)): $(OBJ)/$(1)_%.o: %.S Makefile $(OBJ) $(BIN)
@echo [ASSEMBLING $$@]
-   $(SILENT)@$(CC) $(ASFLAGS) -DENVIRONMENT_$(1) -DENVIRONMENT=\"$(1)\" -c 
-o $$@ $$<
+   $(SILENT)$(CC) $(ASFLAGS) -DENVIRONMENT_$(1) -DENVIRONMENT=\"$(1)\" -c 
-o $$@ $$<

 debug_$(1): $(1)
$(GDB) -x "$(BOARD_LIB)/resources/gcc/$(BOARD)_$(1).gdb" -ex "reset" 
-readnow -se $(OUTPUT)-$(1).elf
 endef

-$(foreach MEMORY, $(MEMORIES), $(eval $(call RULES,$(MEMORY
+ALL_MEMORIES = dfu flash ram
+$(foreach MEMORY, $(ALL_MEMORIES), $(eval $(call RULES,$(MEMORY
+
+# files with those names do exist..
+.PHONY: ram
+.PHONY: dfu
+.PHONY: flash
+ram: build_ram
+dfu: build_dfu
+ifeq ($(APP), blupdate)
+   $(info updating updater section with padded bootloader file..)
+   $(SILENT)dd if=/dev/zero bs=16384 count=1 
of=$(BIN)/$(BOARD)-dfu-flash-padded.bin
+   $(SILENT)dd if=$(BIN)/$(BOARD)-dfu-flash.bin conv=notrunc 
of=$(BIN)/$(BOARD)-dfu-flash-padded.bin
+   $(SILENT)$(OBJCOPY) --update-section 
.blupdate=bin/$(BOARD)-dfu-flash-padded.bin bin/$(BOARD)-blupdate-dfu.elf
+   $(SILENT)$(OBJCOPY) -O binary bin/$(BOARD)-blupdate-dfu.elf 
bin/$(BOARD)-blupdate-dfu.bin
+endif
+flash: build_flash
+#alternate 

Change in simtrace2[master]: firmware: add bootloader update "app"

2021-11-01 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/simtrace2/+/26026 )

Change subject: firmware: add bootloader update "app"
..


Patch Set 4: Verified+1 Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26026
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I53dea57bba790a2ab3245d9483e0ff1c8d19d5e3
Gerrit-Change-Number: 26026
Gerrit-PatchSet: 4
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: fixeria 
Gerrit-Comment-Date: Mon, 01 Nov 2021 12:04:19 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in simtrace2[master]: firmware: add bootloader update "app"

2021-11-01 Thread laforge
laforge has uploaded a new patch set (#4) to the change originally created by 
Hoernchen. ( https://gerrit.osmocom.org/c/simtrace2/+/26026 )

Change subject: firmware: add bootloader update "app"
..

firmware: add bootloader update "app"

This bl updater can be flashed as app and will update the bootloader and
then
delete itself before resetting the sam3, so the device will end up in
the newly
updated dfu bootloader afterwards, without having to press the
bootloader button
or requring any other manual interaction, ready to receive a new
application image.

Building the blupdater requires a previously built dfu-flash bootloader
bin file that
will then be embedded into the app during building.

Related: OS#1704
Related: SYS5061
Change-Id: I53dea57bba790a2ab3245d9483e0ff1c8d19d5e3
---
M Makefile
M firmware/Makefile
A firmware/apps/blupdate/Makefile
A firmware/apps/blupdate/main.c
M firmware/libboard/common/resources/sam3s4/dfu.ld
5 files changed, 192 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/26/26026/4
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26026
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I53dea57bba790a2ab3245d9483e0ff1c8d19d5e3
Gerrit-Change-Number: 26026
Gerrit-PatchSet: 4
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: fixeria 
Gerrit-MessageType: newpatchset


Change in simtrace2[master]: firmware: add bootloader update "app"

2021-11-01 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/simtrace2/+/26026 )

Change subject: firmware: add bootloader update "app"
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26026
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I53dea57bba790a2ab3245d9483e0ff1c8d19d5e3
Gerrit-Change-Number: 26026
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: fixeria 
Gerrit-Comment-Date: Mon, 01 Nov 2021 12:02:52 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-bsc[master]: control.adoc: comment out fixme note

2021-11-01 Thread dexter
dexter has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/26052 )


Change subject: control.adoc: comment out fixme note
..

control.adoc: comment out fixme note

The fixme note:
"FIXME: add variables defined in src/ctrl/control_if.c?"

is not directed at the reader of the manual. It should stay in the
source, but it should not be visible in the pdf. Lets comment it out.

Change-Id: Id68f53d18f0873af3c07a0ae52cd12bc94bc0b96
---
M doc/manuals/chapters/control.adoc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/52/26052/1

diff --git a/doc/manuals/chapters/control.adoc 
b/doc/manuals/chapters/control.adoc
index 9193646..b57c31c 100644
--- a/doc/manuals/chapters/control.adoc
+++ b/doc/manuals/chapters/control.adoc
@@ -148,4 +148,4 @@

 NOTE: The bsic-number () can also be set to "any" if no explcit bsic 
shall be given

-FIXME: add variables defined in src/ctrl/control_if.c?
+//FIXME: add variables defined in src/ctrl/control_if.c?

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26052
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id68f53d18f0873af3c07a0ae52cd12bc94bc0b96
Gerrit-Change-Number: 26052
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-MessageType: newchange


Change in osmo-bsc[master]: heighbor_ident: add/del neighbor cells via ctrl interface

2021-11-01 Thread dexter
Hello Jenkins Builder, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/25976

to look at the new patch set (#6).

Change subject: heighbor_ident: add/del neighbor cells via ctrl interface
..

heighbor_ident: add/del neighbor cells via ctrl interface

The VTY allows flexible control over the neighbor cell information via
the neighbor command, which can be found in the configure terminal under
the bts node. Lets add pendant of this command on the control interface
as well.

Change-Id: I343a40e18fa9b91e6c381912c0426a002841e079
Related: SYS#5641
---
M doc/manuals/chapters/control.adoc
M include/osmocom/bsc/neighbor_ident.h
M src/osmo-bsc/Makefile.am
M src/osmo-bsc/bsc_ctrl_commands.c
A src/osmo-bsc/neighbor_ident_ctrl.c
M src/osmo-bsc/neighbor_ident_vty.c
M tests/ctrl_test_runner.py
7 files changed, 958 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/76/25976/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25976
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I343a40e18fa9b91e6c381912c0426a002841e079
Gerrit-Change-Number: 25976
Gerrit-PatchSet: 6
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-CC: fixeria 
Gerrit-CC: laforge 
Gerrit-MessageType: newpatchset


Change in osmo-bsc[master]: heighbor_ident: add/del neighbor cells via ctrl interface

2021-11-01 Thread dexter
dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/25976 )

Change subject: heighbor_ident: add/del neighbor cells via ctrl interface
..


Patch Set 5:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/25976/5/doc/manuals/chapters/control.adoc
File doc/manuals/chapters/control.adoc:

https://gerrit.osmocom.org/c/osmo-bsc/+/25976/5/doc/manuals/chapters/control.adoc@148
PS5, Line 148: FIXME: add variables defined in src/ctrl/control_if.c?
> that line already existed before hand. […]
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/25976/5/src/osmo-bsc/neighbor_ident_ctrl.c
File src/osmo-bsc/neighbor_ident_ctrl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25976/5/src/osmo-bsc/neighbor_ident_ctrl.c@48
PS5, Line 48:   return 1;
> it is unusual in osmocom code to return positive integers in error case. […]
Its indeed a bit odd, however I have oriented myself here on the verify_ 
functions in other code locations. I don't know why we use a different scheme 
for the control interface...



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25976
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I343a40e18fa9b91e6c381912c0426a002841e079
Gerrit-Change-Number: 25976
Gerrit-PatchSet: 5
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-CC: fixeria 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Mon, 01 Nov 2021 11:28:24 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge 
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment


Change in osmo-bsc[master]: refactor lchan counting

2021-11-01 Thread neels
neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/25972 )

Change subject: refactor lchan counting
..


Patch Set 2:

(2 comments)

Shifted things around a bit and fixed a few patch errors (unrelated changes 
that shouldn't have been in the patch).

Using a typedef to fixate the array dimensions is still my favorite solution.

I wouldn't generally allow typedefs, so in this case i would delete the linter 
-1, instead of disabling the linter test.

https://gerrit.osmocom.org/c/osmo-bsc/+/25972/1/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/25972/1/include/osmocom/bsc/gsm_data.h@1448
PS1, Line 1448: typedef unsigned int chan_counts_t 
[CHAN_COUNTS1_N][CHAN_COUNTS2_N][_GSM_LCHAN_MAX];
> I'd go for the struct with the multidimensional array inside it. […]
it'll be quite a bit of effort to change this.
With array-in-a-struct there's still the problem with functions working on only 
the third or second dimension. With a struct, how would you solve 
chan_counts_dim3_add()?

I find that moving to a struct makes things more complex,
and it seems there is no benefit besides personal preference?


https://gerrit.osmocom.org/c/osmo-bsc/+/25972/1/src/osmo-bsc/abis_rsl.c
File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25972/1/src/osmo-bsc/abis_rsl.c@1974
PS1, Line 1974: free_tchf = 
bts_counts[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F];
> Yes please, a getter like you wrote, and with some minimal description like 
> "Remember to call bts_co […]
i don't see the point for such a getter function. it makes for literally the 
same code except punctuation and braces.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3
Gerrit-Change-Number: 25972
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-CC: fixeria 
Gerrit-Comment-Date: Mon, 01 Nov 2021 11:26:24 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels 
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment


Change in simtrace2[master]: firmware: increase reset delay before usb reattach

2021-11-01 Thread Hoernchen
Hoernchen has posted comments on this change. ( 
https://gerrit.osmocom.org/c/simtrace2/+/26028 )

Change subject: firmware: increase reset delay before usb reattach
..


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/simtrace2/+/26028/3/firmware/libcommon/source/usb.c
File firmware/libcommon/source/usb.c:

https://gerrit.osmocom.org/c/simtrace2/+/26028/3/firmware/libcommon/source/usb.c@693
PS3, Line 693:  mdelay(500);
> are we sure this doesn't make us run into the watchdog?
I don't see how, the apps are loaded immediately by calling their reset handler 
functions from the bl reset handler, and those apps then initialize the WD with 
a 2s timeout before calling this function, there is nothing that should be 
blocking this long here, and after returning the wd gets reset while waiting 
until usb is initialized.



--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26028
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I9b8c8bf794ad5b94fc7ea2a01d1ebf4e36862c36
Gerrit-Change-Number: 26028
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Mon, 01 Nov 2021 11:25:09 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment


Change in osmo-bsc[master]: refactor lchan counting

2021-11-01 Thread neels
Hello Jenkins Builder, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/25972

to look at the new patch set (#2).

Change subject: refactor lchan counting
..

refactor lchan counting

Add chan_counts_for_trx() and chan_counts_for_bts(). Drop
bts_count_free_ts() and trx_count_free_ts().

Rationale:

The bts_count_free_ts() and trx_count_free_ts() always returned the
number of free lchans, not timeslots. Hence, passing the pchan type as
argument never really matched the semantics.

Especially, when looking for free SDCCH, there is no clear match on a
gsm_phys_chan_config enum value: SDCCH8_SACCH8C, CCCH_SDCCH4,
CCCH_SDCCH4_CBCH, SDCCH8_SACCH8C_CBCH? -- GSM_LCHAN_SDCCH is clear.

==> Rather count free lchans by enum gsm_chan_t.

Counting lchans of distinct types required separate iterations for each
lchan type.

==> Rather compose an array of counts for all types, in one go.

I need to count the amount of free SDCCH lchans in an upcoming patch to
implement the performance indicator allAvailableAllocatedSDCCH (cumulate
time for which no SDCCH are available).

To implement allAvailableAllocated{SDCCH,TCH}, I need a count of both
the used as well as the total lchans for a type: it does not make sense
to flag "all available allocated" if none are ever available.

To properly count dynamic ts, I need the maximum total that can be
possible at any time. And to count currently free lchans, I need the
current total. This may seem counter intuitive, but consider, e.g.:

- Obviously, if a cell has only static TCH/F timeslots, it does not make
  sense to flag that all available TCH/H are occupied, because no TCH/H
  are available ever. Just stating this as contrast to dyn TS.

- If a cell has OSMO_DYN timeslots, I *do* want to flag that all TCH/H
  are occupied when all dyn timeslots are fully occupied.

- If those OSMO_DYN however are all used as TCH/F, the current total of
  TCH/H becomes zero, and it seems like TCH/H should not be considered.

- To count the nr of currently free lchans, I need the currently
  possible total of lchans and the nr of occupied lchans.

So return both a maximum total and a current total of lchans. In above
example, the maximum total shows that there would be TCH/H possible.

BTW, it would be nice to keep a chan_counts array on trx, bts and bsc
level and update as channels are allocated and released, instead of
counting them all over periodically. But it's less error prone this way.

Related: SYS#4878
Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3
---
M include/osmocom/bsc/Makefile.am
M include/osmocom/bsc/bts.h
M include/osmocom/bsc/bts_trx.h
A include/osmocom/bsc/chan_counts.h
M src/osmo-bsc/Makefile.am
M src/osmo-bsc/abis_rsl.c
M src/osmo-bsc/bts.c
M src/osmo-bsc/bts_trx.c
A src/osmo-bsc/chan_counts.c
M src/osmo-bsc/handover_decision_2.c
10 files changed, 219 insertions(+), 72 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/72/25972/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3
Gerrit-Change-Number: 25972
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-CC: fixeria 
Gerrit-MessageType: newpatchset


Change in osmo-bsc[master]: constify lchan_state_is()

2021-11-01 Thread neels
neels has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/25971 )

Change subject: constify lchan_state_is()
..

constify lchan_state_is()

An upcoming patch would rather pass a const struct gsm_lchan*.
See I2fb48c549186db812b1e9d6b735a92e80f27b8d3.

Related: OS#4878
Change-Id: I523cbf04e77f43924c3f09094d56f815d3de640d
---
M include/osmocom/bsc/lchan_fsm.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/bsc/lchan_fsm.h b/include/osmocom/bsc/lchan_fsm.h
index e7a06d5..fa0d299 100644
--- a/include/osmocom/bsc/lchan_fsm.h
+++ b/include/osmocom/bsc/lchan_fsm.h
@@ -72,7 +72,7 @@
return lchan->fi ? osmo_fsm_inst_state_name(lchan->fi) : "NULL";
 }

-static inline bool lchan_state_is(struct gsm_lchan *lchan, uint32_t state)
+static inline bool lchan_state_is(const struct gsm_lchan *lchan, uint32_t 
state)
 {
return (!lchan->fi && state == LCHAN_ST_UNUSED)
|| (lchan->fi && lchan->fi->state == state);

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25971
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I523cbf04e77f43924c3f09094d56f815d3de640d
Gerrit-Change-Number: 25971
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in simtrace2[master]: firmware: add bootloader update "app"

2021-11-01 Thread Hoernchen
Hoernchen has posted comments on this change. ( 
https://gerrit.osmocom.org/c/simtrace2/+/26026 )

Change subject: firmware: add bootloader update "app"
..


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/simtrace2/+/26026/3/firmware/Makefile
File firmware/Makefile:

https://gerrit.osmocom.org/c/simtrace2/+/26026/3/firmware/Makefile@248
PS3, Line 248: EXTRA_OBJECTS_$(1) = $(addprefix $(OBJ)/$(1)_, $(EXTRA_OBJECTS))
> tbh, I'm not following exactly what you are doing here in detail without 
> further analysis, but it lo […]
As the commit message states the bl binary gets embedded into the updater 
firmware, this is what those changes do.



--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26026
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I53dea57bba790a2ab3245d9483e0ff1c8d19d5e3
Gerrit-Change-Number: 26026
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: fixeria 
Gerrit-Comment-Date: Mon, 01 Nov 2021 11:12:19 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment


Change in osmo-bsc[master]: neighbor_ident: add comment about Neighbor Address Resolution Service

2021-11-01 Thread dexter
dexter has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/25977 )

Change subject: neighbor_ident: add comment about Neighbor Address Resolution 
Service
..

neighbor_ident: add comment about Neighbor Address Resolution Service

The Neighbor Address Resolution Service is using the control interface
API as well. Lets add a comment to indicate that this service is not
related to the normal control interface.

Change-Id: Iec86f72548bfc54a2c86dadec69dd1c64813d852
---
M src/osmo-bsc/neighbor_ident.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve



diff --git a/src/osmo-bsc/neighbor_ident.c b/src/osmo-bsc/neighbor_ident.c
index c66d3ac..44b0b43 100644
--- a/src/osmo-bsc/neighbor_ident.c
+++ b/src/osmo-bsc/neighbor_ident.c
@@ -489,6 +489,7 @@

 struct ctrl_handle *neighbor_controlif_setup(struct gsm_network *net)
 {
+   /* See also osmobsc-usermanual.pdf, section 14.1 Neighbor Address 
Resolution Service */
return ctrl_interface_setup_dynip2(net, net->neigh_ctrl.addr, 
net->neigh_ctrl.port,
   NULL, _LAST_CTRL_NODE_NEIGHBOR);
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25977
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iec86f72548bfc54a2c86dadec69dd1c64813d852
Gerrit-Change-Number: 25977
Gerrit-PatchSet: 6
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in osmo-ttcn3-hacks[master]: BSC_Tests: set band in f_TC_fh_params_set

2021-11-01 Thread fixeria
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828 )

Change subject: BSC_Tests: set band in f_TC_fh_params_set
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I447e4145c68c62b11b818e28f0081c19e9107647
Gerrit-Change-Number: 25828
Gerrit-PatchSet: 4
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 01 Nov 2021 09:49:05 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-ttcn3-hacks[master]: BSC_Tests: set band in f_TC_fh_params_set

2021-11-01 Thread dexter
dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828 )

Change subject: BSC_Tests: set band in f_TC_fh_params_set
..


Patch Set 4:

(3 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828/3/bsc/BSC_Tests.ttcn
File bsc/BSC_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828/3/bsc/BSC_Tests.ttcn@8579
PS3, Line 8579: var GsmBandArfcn arfcn_ := 
valueof(ts_GsmBandArfcn(arfcn.arfcn, arfcn.pcs, false));
> Could you please explain why you're doing this? I guess this has something to 
> do with the 'uplink' a […]
I am doing this because it is not possible to use ts_GsmBandArfcn from inside 
the function definition:

private function f_TC_fh_params_unset(in FHParamsTrx fhp,
  uint8_t bts_nr := 0,
  uint8_t trx_nr := 0,
  GsmBandArfcn arfcn := {pcs := false, 
arfcn := 871})


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828/3/bsc/BSC_Tests.ttcn@8581
PS3, Line 8581: select (arfcn_) {
> The 'case' statements should be inline with the 'select', similar to 'switch' 
> in C. […]
Done


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828/3/bsc/BSC_Tests.ttcn@8582
PS3, Line 8582: ?
> Not critical, but this argument can be omitted here (and below) because '?' 
> is the default value.
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I447e4145c68c62b11b818e28f0081c19e9107647
Gerrit-Change-Number: 25828
Gerrit-PatchSet: 4
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 01 Nov 2021 09:43:57 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment


Change in osmo-ttcn3-hacks[master]: BSC_Tests: set band in f_TC_fh_params_set

2021-11-01 Thread dexter
Hello Jenkins Builder, laforge, fixeria, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828

to look at the new patch set (#4).

Change subject: BSC_Tests: set band in f_TC_fh_params_set
..

BSC_Tests: set band in f_TC_fh_params_set

The function f_TC_fh_params_set sets frequency hopping parameters. The
ARFCN is also part of those parameters. However, this function does not
set the respective band for the ARFCN that it configurs. This results in
an invalid setting at the BSC that might cause unexpected behavior.

Lets make sure we configure the band parameter correctly before setting
the ARFCN

Change-Id: I447e4145c68c62b11b818e28f0081c19e9107647
Related: SYS#5369
---
M bsc/BSC_Tests.ttcn
1 file changed, 39 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/28/25828/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I447e4145c68c62b11b818e28f0081c19e9107647
Gerrit-Change-Number: 25828
Gerrit-PatchSet: 4
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset