[S] Change in osmo-hnbgw[master]: systemd,manual: set LimitNOFILE=65536
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/35177?usp=email )
Change subject: systemd,manual: set LimitNOFILE=65536
..
systemd,manual: set LimitNOFILE=65536
A typical OS imposed limit is 1024 open FD, which is too low when there
are thousands of HNB.
In systemd service file, set a super high limit of 65536.
In osmo-hnbgw's user manual, add section 'Configure limits' describing
this in detail.
Related: OS#6256
Related: osmo-bsc I26c4058484b11ff1d035a919bf88824c3af14e71
Change-Id: I5333765199cf9e3e5a570f85b85d2b7423d34a4d
---
M contrib/systemd/osmo-hnbgw.service
M doc/manuals/chapters/running.adoc
2 files changed, 37 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
diff --git a/contrib/systemd/osmo-hnbgw.service
b/contrib/systemd/osmo-hnbgw.service
index ba41e24..2307bcc 100644
--- a/contrib/systemd/osmo-hnbgw.service
+++ b/contrib/systemd/osmo-hnbgw.service
@@ -6,6 +6,7 @@
[Service]
Type=simple
Restart=always
+LimitNOFILE=65536
StateDirectory=osmocom
WorkingDirectory=%S/osmocom
ExecStart=/usr/bin/osmo-hnbgw -c /etc/osmocom/osmo-hnbgw.cfg
diff --git a/doc/manuals/chapters/running.adoc
b/doc/manuals/chapters/running.adoc
index 45d9b2f..08e1b87 100644
--- a/doc/manuals/chapters/running.adoc
+++ b/doc/manuals/chapters/running.adoc
@@ -76,6 +76,23 @@
configure a distinct point-code, see <>.
+=== Configure limits
+
+When connecting hundreds of HNB to OsmoHNBGW, it may be necessary to adjust the
+operating system's limit on open file descriptors for the osmo-hnbgw process. A
+typical default limit imposed by operating systems is 1024; this would be
+exceeded by, for example, about 1024 HNB on Iuh, sockets for other interfaces
+not considered yet.
+
+It should be ok to set an OS limit on open file descriptors as high as 65536
+for osmo-hnbgw, which practically rules out failure from running out of file
+descriptors anywhere (<50,000 HNB).
+
+When using systemd, the file descriptor limit may be adjusted in the service
+file by the `LimitNOFILE` setting ("Number of Open FILE descriptors").
+OsmoHNBGW ships a systemd service file with a high LimitNOFILE setting.
+
+
=== Configuring Primary Links
[[configure_iucs_iups]]
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35177?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I5333765199cf9e3e5a570f85b85d2b7423d34a4d
Gerrit-Change-Number: 35177
Gerrit-PatchSet: 2
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[S] Change in osmo-hnbgw[master]: systemd,manual: set LimitNOFILE=65536
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35177?usp=email ) Change subject: systemd,manual: set LimitNOFILE=65536 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35177?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5333765199cf9e3e5a570f85b85d2b7423d34a4d Gerrit-Change-Number: 35177 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Comment-Date: Sun, 03 Dec 2023 02:20:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-mgw[master]: systemd,manual: set LimitNOFILE=65536
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/35178?usp=email )
Change subject: systemd,manual: set LimitNOFILE=65536
..
systemd,manual: set LimitNOFILE=65536
A typical OS imposed limit is 1024 open FD, which can bee too low when
there are hundreds of concurrent voice calls.
In systemd service file, set a super high limit of 65536.
In osmo-mgw's user manual, add section 'Configure limits' describing
this in detail.
Related: OS#6256
Related: osmo-bsc I26c4058484b11ff1d035a919bf88824c3af14e71
Change-Id: I46512517bc3b5bb90cac7643e7ac73afba398d36
---
M contrib/systemd/osmo-mgw.service
M doc/manuals/chapters/running.adoc
2 files changed, 37 insertions(+), 0 deletions(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/contrib/systemd/osmo-mgw.service b/contrib/systemd/osmo-mgw.service
index b187e1a..03f40ff 100644
--- a/contrib/systemd/osmo-mgw.service
+++ b/contrib/systemd/osmo-mgw.service
@@ -5,6 +5,7 @@
[Service]
Type=simple
+LimitNOFILE=65536
StateDirectory=osmocom
WorkingDirectory=%S/osmocom
Restart=always
diff --git a/doc/manuals/chapters/running.adoc
b/doc/manuals/chapters/running.adoc
index c178e31..e3bab4d 100644
--- a/doc/manuals/chapters/running.adoc
+++ b/doc/manuals/chapters/running.adoc
@@ -23,3 +23,20 @@
Disable colors for logging to stderr. This has mostly been
deprecated by VTY based logging configuration, see <>
for more information.
+
+
+=== Configure limits
+
+When servicing hundreds of media endpoints, it may be necessary to adjust the
+operating system's limit on open file descriptors for the osmo-mgw process. A
+typical default limit imposed by operating systems is 1024; this would be
+exceeded by, for example, about 256 active voice calls with 4 RTP/RTPC ports
+each, sockets for other interfaces not considered yet.
+
+It should be ok to set an OS limit on open file descriptors as high as 65536
+for osmo-mgw, which practically rules out failure from running out of file
+descriptors anywhere (<16,000 active calls).
+
+When using systemd, the file descriptor limit may be adjusted in the service
+file by the `LimitNOFILE` setting ("Number of Open FILE descriptors"). OsmoMGW
+ships a systemd service file with a high LimitNOFILE setting.
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35178?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I46512517bc3b5bb90cac7643e7ac73afba398d36
Gerrit-Change-Number: 35178
Gerrit-PatchSet: 2
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[S] Change in osmo-mgw[master]: systemd,manual: set LimitNOFILE=65536
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35178?usp=email ) Change subject: systemd,manual: set LimitNOFILE=65536 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35178?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I46512517bc3b5bb90cac7643e7ac73afba398d36 Gerrit-Change-Number: 35178 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Comment-Date: Sun, 03 Dec 2023 02:20:46 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmocom-bb[master]: mobile: Fix PCS ARFCN handling: PCS can only be ARFCN 512..810
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/33532?usp=email )
Change subject: mobile: Fix PCS ARFCN handling: PCS can only be ARFCN 512..810
..
mobile: Fix PCS ARFCN handling: PCS can only be ARFCN 512..810
While it is correct to use the band indicator from SI1 rest octets,
it may only be applied for ARFCN values in the range 512..810.
The function gsm_refer_pcs() is used to determine, if the cell (which
'talks' about ARFCNs) refers to them PCS or DCS channels. It returns
true, if it refers to PCS, but this only means that ARFCNs in the range
512..810 are PCS channels, not all ARFCNs.
The new function gsm_arfcn_refer_pcs() is used to add the PCS flag to an
ARFCN, if the given cell refers to PCS and the given ARFCN is in the PCS
range 512..810.
Change-Id: Id99c8534bf853f4f24f99364790c1ac1df6cc007
Related: OS#6078
---
M src/host/layer23/include/osmocom/bb/common/sysinfo.h
M src/host/layer23/src/common/sysinfo.c
M src/host/layer23/src/mobile/gsm322.c
M src/host/layer23/src/mobile/gsm48_rr.c
4 files changed, 71 insertions(+), 41 deletions(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, but someone else must approve
Jenkins Builder: Verified
jolly: Looks good to me, approved
diff --git a/src/host/layer23/include/osmocom/bb/common/sysinfo.h
b/src/host/layer23/include/osmocom/bb/common/sysinfo.h
index 9efb248..c31cf9d 100644
--- a/src/host/layer23/include/osmocom/bb/common/sysinfo.h
+++ b/src/host/layer23/include/osmocom/bb/common/sysinfo.h
@@ -71,7 +71,7 @@
/* si1 rest */
uint8_t nch;
uint8_t nch_position;
- uint8_t band_ind; /* set for DCS */
+ boolband_ind; /* set for DCS */
/* si3 rest */
uint8_t sp;
@@ -181,7 +181,8 @@
};
char *gsm_print_arfcn(uint16_t arfcn);
-uint8_t gsm_refer_pcs(uint16_t arfcn, const struct gsm48_sysinfo *s);
+bool gsm_refer_pcs(uint16_t cell_arfcn, const struct gsm48_sysinfo *cell_s);
+uint16_t gsm_arfcn_refer_pcs(uint16_t cell_arfcn, const struct gsm48_sysinfo
*cell_s, uint16_t arfcn);
int gsm48_sysinfo_dump(const struct gsm48_sysinfo *s, uint16_t arfcn,
void (*print)(void *, const char *, ...),
void *priv, uint8_t *freq_map);
diff --git a/src/host/layer23/src/common/sysinfo.c
b/src/host/layer23/src/common/sysinfo.c
index f541c85..7fdc6ff 100644
--- a/src/host/layer23/src/common/sysinfo.c
+++ b/src/host/layer23/src/common/sysinfo.c
@@ -50,20 +50,35 @@
return text;
}
-/* check if the cell 'talks' about DCS (0) or PCS (1) */
-uint8_t gsm_refer_pcs(uint16_t arfcn, const struct gsm48_sysinfo *s)
+/* Check if the cell 'talks' about DCS (false) or PCS (true) */
+bool gsm_refer_pcs(uint16_t cell_arfcn, const struct gsm48_sysinfo *cell_s)
{
/* If ARFCN is PCS band, the cell refers to PCS */
- if ((arfcn & ARFCN_PCS))
- return 1;
+ if ((cell_arfcn & ARFCN_PCS))
+ return true;
/* If no SI1 is available, we assume DCS. Be sure to call this
* function only if SI 1 is available. */
- if (!s->si1)
+ if (!cell_s->si1)
return 0;
/* If band indicator indicates PCS band, the cell refers to PCSThe */
- return s->band_ind;
+ return cell_s->band_ind;
+}
+
+/* Change the given ARFCN to PCS ARFCN, if it is in the PCS channel range and
the cell refers to PCS band. */
+uint16_t gsm_arfcn_refer_pcs(uint16_t cell_arfcn, const struct gsm48_sysinfo
*cell_s, uint16_t arfcn)
+{
+ /* If ARFCN is not one of the overlapping channel of PCS and DCS. */
+ if (arfcn < 512 && arfcn > 810)
+ return arfcn;
+
+ /* If the 'cell' does not refer to PCS. */
+ if (!gsm_refer_pcs(cell_arfcn, cell_s))
+ return arfcn;
+
+ /* The ARFCN is PCS, because the ARFCN is in the PCS range and the cell
refers to it. */
+ return arfcn | ARFCN_PCS;
}
int gsm48_sysinfo_dump(const struct gsm48_sysinfo *s, uint16_t arfcn,
@@ -541,10 +556,7 @@
s->nch_position = bitvec_get_uint(, 5);
} else
s->nch = 0;
- if (bitvec_get_bit_high() == H)
- s->band_ind = 1;
- else
- s->band_ind = 0;
+ s->band_ind = (bitvec_get_bit_high() == H);
return 0;
}
diff --git a/src/host/layer23/src/mobile/gsm322.c
b/src/host/layer23/src/mobile/gsm322.c
index 35811d3..3d0cc77 100644
--- a/src/host/layer23/src/mobile/gsm322.c
+++ b/src/host/layer23/src/mobile/gsm322.c
@@ -2419,7 +2419,8 @@
struct gsm322_cellsel *cs = >cellsel;
struct gsm48_sysinfo *s;
struct gsm322_ba_list *ba = NULL;
- int i, refer_pcs;
+ int i;
+ bool refer_pcs;
uint8_t
[S] Change in libosmocore[master]: soft_uart: check Rx/Tx state once in osmo_soft_uart_{rx,tx}_ubits()
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35171?usp=email )
Change subject: soft_uart: check Rx/Tx state once in
osmo_soft_uart_{rx,tx}_ubits()
..
soft_uart: check Rx/Tx state once in osmo_soft_uart_{rx,tx}_ubits()
Check it once rather than doing this in a loop. Return -EAGAIN if
Rx or Tx is not enabled when calling osmo_soft_uart_{rx,tx}_ubits().
This [theoretically] improves performance by reducing the number of
conditional statements in loops. In the Tx path, this also prevents
calling the .tx_cb() when the transmitter is disabled, so that we
don't loose the application data.
Change-Id: I70f93b3655eb21c2323e451052c40cd305c016c8
Related: OS#4396
---
M src/core/soft_uart.c
M tests/soft_uart/soft_uart_test.c
2 files changed, 36 insertions(+), 8 deletions(-)
Approvals:
osmith: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
neels: Looks good to me, but someone else must approve
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/core/soft_uart.c b/src/core/soft_uart.c
index 8d9142b..8cf45e1 100644
--- a/src/core/soft_uart.c
+++ b/src/core/soft_uart.c
@@ -111,9 +111,6 @@
/* receive a single bit */
static inline void osmo_uart_rx_bit(struct osmo_soft_uart *suart, const ubit_t
bit)
{
- if (!suart->rx.running)
- return;
-
switch (suart->rx.flow_state) {
case SUART_FLOW_ST_IDLE:
if (bit == 0) { /* start bit condition */
@@ -196,9 +193,12 @@
* \param[in] suart soft-UART instance to feed bits into.
* \param[in] ubits pointer to the unpacked bits.
* \param[in] n_ubits number of unpacked bits to be fed.
- * \returns 0 on success; negative on error. */
+ * \returns 0 on success; negative on error.
+ * -EAGAIN indicates that the receiver is disabled. */
int osmo_soft_uart_rx_ubits(struct osmo_soft_uart *suart, const ubit_t *ubits,
size_t n_ubits)
{
+ if (!suart->rx.running)
+ return -EAGAIN;
for (size_t i = 0; i < n_ubits; i++)
osmo_uart_rx_bit(suart, ubits[i]);
return 0;
@@ -213,9 +213,6 @@
{
ubit_t tx_bit = 1;
- if (!suart->tx.running)
- return tx_bit;
-
switch (suart->tx.flow_state) {
case SUART_FLOW_ST_IDLE:
if (msg && msgb_length(msg) > 0) { /* if we have pending data */
@@ -280,7 +277,8 @@
* \param[in] suart soft-UART instance to pull the bits from.
* \param[out] ubits pointer to a buffer where to store pulled bits.
* \param[in] n_ubits number of unpacked bits to be pulled.
- * \returns 0 on success; negative on error. */
+ * \returns 0 on success; negative on error.
+ * -EAGAIN indicates that the transmitter is disabled. */
int osmo_soft_uart_tx_ubits(struct osmo_soft_uart *suart, ubit_t *ubits,
size_t n_ubits)
{
const struct osmo_soft_uart_cfg *cfg = >cfg;
@@ -290,6 +288,9 @@
if (OSMO_UNLIKELY(n_ubits == 0))
return -EINVAL;
+ if (!suart->tx.running)
+ return -EAGAIN;
+
/* calculate UART frame size for the effective config */
n_frame_bits = 1 + cfg->num_data_bits + cfg->num_stop_bits;
if (cfg->parity_mode != OSMO_SUART_PARITY_NONE)
diff --git a/tests/soft_uart/soft_uart_test.c b/tests/soft_uart/soft_uart_test.c
index 522739a..276ffe1 100644
--- a/tests/soft_uart/soft_uart_test.c
+++ b/tests/soft_uart/soft_uart_test.c
@@ -16,6 +16,7 @@
*
*/
+#include
#include
#include
@@ -256,10 +257,18 @@
{
struct osmo_soft_uart_cfg cfg;
struct osmo_soft_uart *suart;
+ int rc;
suart = osmo_soft_uart_alloc(NULL, __func__, _test_default_cfg);
OSMO_ASSERT(suart != NULL);
+ /* expect -EAGAIN when the transmitter is not enabled */
+ rc = osmo_soft_uart_tx_ubits(suart, NULL, 42);
+ OSMO_ASSERT(rc == -EAGAIN);
+ /* expect -EAGAIN when the receiver is not enabled */
+ rc = osmo_soft_uart_rx_ubits(suart, NULL, 42);
+ OSMO_ASSERT(rc == -EAGAIN);
+
osmo_soft_uart_set_tx(suart, true);
osmo_soft_uart_set_rx(suart, true);
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35171?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I70f93b3655eb21c2323e451052c40cd305c016c8
Gerrit-Change-Number: 35171
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[S] Change in libosmocore[master]: soft_uart: add osmo_soft_uart_{get,set}_name()
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35169?usp=email )
Change subject: soft_uart: add osmo_soft_uart_{get,set}_name()
..
soft_uart: add osmo_soft_uart_{get,set}_name()
Change-Id: Iabf29f42d876035481011fa8e8a51c0590fe63b8
Related: OS#4396
---
M include/osmocom/core/soft_uart.h
M src/core/libosmocore.map
M src/core/soft_uart.c
3 files changed, 32 insertions(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
osmith: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/core/soft_uart.h b/include/osmocom/core/soft_uart.h
index 097d2ee..7b7c394 100644
--- a/include/osmocom/core/soft_uart.h
+++ b/include/osmocom/core/soft_uart.h
@@ -87,6 +87,10 @@
const struct osmo_soft_uart_cfg
*cfg);
void osmo_soft_uart_free(struct osmo_soft_uart *suart);
int osmo_soft_uart_configure(struct osmo_soft_uart *suart, const struct
osmo_soft_uart_cfg *cfg);
+
+const char *osmo_soft_uart_get_name(const struct osmo_soft_uart *suart);
+void osmo_soft_uart_set_name(struct osmo_soft_uart *suart, const char *name);
+
int osmo_soft_uart_set_rx(struct osmo_soft_uart *suart, bool enable);
int osmo_soft_uart_set_tx(struct osmo_soft_uart *suart, bool enable);
diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map
index 3d6aa42..4ae5108 100644
--- a/src/core/libosmocore.map
+++ b/src/core/libosmocore.map
@@ -444,6 +444,8 @@
osmo_soft_uart_alloc;
osmo_soft_uart_free;
osmo_soft_uart_configure;
+osmo_soft_uart_get_name;
+osmo_soft_uart_set_name;
osmo_soft_uart_set_rx;
osmo_soft_uart_set_tx;
osmo_soft_uart_rx_ubits;
diff --git a/src/core/soft_uart.c b/src/core/soft_uart.c
index 4fffaee..5b4 100644
--- a/src/core/soft_uart.c
+++ b/src/core/soft_uart.c
@@ -396,6 +396,22 @@
return 0;
}
+/*! Get a name for the given soft-UART instance.
+ * \param[in] suart soft-UART instance to get the name from.
+ * \returns name of the given soft-UART instance. */
+const char *osmo_soft_uart_get_name(const struct osmo_soft_uart *suart)
+{
+ return suart->name;
+}
+
+/*! Set a new name for the given soft-UART instance.
+ * \param[in] suart soft-UART instance to set the name for.
+ * \param[in] name the new name. */
+void osmo_soft_uart_set_name(struct osmo_soft_uart *suart, const char *name)
+{
+ osmo_talloc_replace_string(suart, (char **)>name, name);
+}
+
/*! Enable/disable receiver of the given soft-UART.
* \param[in] suart soft-UART instance to be re-configured.
* \param[in] enable enable/disable state of the receiver.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35169?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iabf29f42d876035481011fa8e8a51c0590fe63b8
Gerrit-Change-Number: 35169
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[S] Change in libosmocore[master]: soft_uart: fix doxygen doc for osmo_soft_uart_tx_ubits()
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35170?usp=email )
Change subject: soft_uart: fix doxygen doc for osmo_soft_uart_tx_ubits()
..
soft_uart: fix doxygen doc for osmo_soft_uart_tx_ubits()
Change-Id: I648db45bbde39c6b3d839c744a56d01a562e4129
Related: OS#4396
---
M src/core/soft_uart.c
1 file changed, 11 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, approved
diff --git a/src/core/soft_uart.c b/src/core/soft_uart.c
index 5b4..8d9142b 100644
--- a/src/core/soft_uart.c
+++ b/src/core/soft_uart.c
@@ -280,7 +280,7 @@
* \param[in] suart soft-UART instance to pull the bits from.
* \param[out] ubits pointer to a buffer where to store pulled bits.
* \param[in] n_ubits number of unpacked bits to be pulled.
- * \returns number of unpacked bits pulled; negative on error. */
+ * \returns 0 on success; negative on error. */
int osmo_soft_uart_tx_ubits(struct osmo_soft_uart *suart, ubit_t *ubits,
size_t n_ubits)
{
const struct osmo_soft_uart_cfg *cfg = >cfg;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35170?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I648db45bbde39c6b3d839c744a56d01a562e4129
Gerrit-Change-Number: 35170
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: osmith
Gerrit-MessageType: merged
[S] Change in libosmocore[master]: soft_uart: check Rx/Tx state once in osmo_soft_uart_{rx,tx}_ubits()
Attention is currently required from: fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35171?usp=email )
Change subject: soft_uart: check Rx/Tx state once in
osmo_soft_uart_{rx,tx}_ubits()
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35171?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I70f93b3655eb21c2323e451052c40cd305c016c8
Gerrit-Change-Number: 35171
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-Attention: fixeria
Gerrit-Comment-Date: Sun, 03 Dec 2023 02:18:52 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
[M] Change in libosmocore[master]: osmo_io: Factor out and use common send function from backend
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35078?usp=email )
Change subject: osmo_io: Factor out and use common send function from backend
..
osmo_io: Factor out and use common send function from backend
This handles reenqueuing a message on EAGAIN and incomplete write
Change-Id: I6da2653d32aedd0e7872be0cf90a841b56462e59
---
M src/core/osmo_io.c
M src/core/osmo_io_internal.h
M src/core/osmo_io_poll.c
M src/core/osmo_io_uring.c
4 files changed, 58 insertions(+), 60 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c
index 8507f46..e059f87 100644
--- a/src/core/osmo_io.c
+++ b/src/core/osmo_io.c
@@ -344,6 +344,46 @@
}
}
+/*! completion handler: Calld by osmo_io backend after a given I/O operation
has completed
+ * \param[in] iofd I/O file-descriptor on which I/O has completed
+ * \param[in] rc return value of the I/O operation
+ * \param[in] msghdr serialized msghdr containing state of completed I/O
+ */
+void iofd_handle_send_completion(struct osmo_io_fd *iofd, int rc, struct
iofd_msghdr *msghdr)
+{
+ struct msgb *msg = msghdr->msg;
+
+ /* Incomplete write */
+ if (rc > 0 && rc < msgb_length(msg)) {
+ /* Re-enqueue remaining data */
+ msgb_pull(msg, rc);
+ msghdr->iov[0].iov_len = msgb_length(msg);
+ iofd_txqueue_enqueue_front(iofd, msghdr);
+ return;
+ }
+
+ /* Reenqueue the complete msgb */
+ if (rc == -EAGAIN) {
+ iofd_txqueue_enqueue_front(iofd, msghdr);
+ return;
+ }
+
+ /* All other failure and success cases are handled here */
+ switch (msghdr->action) {
+ case IOFD_ACT_WRITE:
+ iofd->io_ops.write_cb(iofd, rc, msg);
+ break;
+ case IOFD_ACT_SENDTO:
+ iofd->io_ops.sendto_cb(iofd, rc, msg, >osa);
+ break;
+ default:
+ OSMO_ASSERT(0);
+ }
+
+ msgb_free(msghdr->msg);
+ iofd_msghdr_free(msghdr);
+}
+
/* Public functions */
/*! Send a message through a connected socket.
diff --git a/src/core/osmo_io_internal.h b/src/core/osmo_io_internal.h
index 73a81e1..e8f4ea2 100644
--- a/src/core/osmo_io_internal.h
+++ b/src/core/osmo_io_internal.h
@@ -146,6 +146,7 @@
struct msgb *iofd_msgb_pending_or_alloc(struct osmo_io_fd *iofd);
void iofd_handle_recv(struct osmo_io_fd *iofd, struct msgb *msg, int rc,
struct iofd_msghdr *msghdr);
+void iofd_handle_send_completion(struct osmo_io_fd *iofd, int rc, struct
iofd_msghdr *msghdr);
void iofd_handle_segmented_read(struct osmo_io_fd *iofd, struct msgb *msg, int
rc);
int iofd_txqueue_enqueue(struct osmo_io_fd *iofd, struct iofd_msghdr *msghdr);
diff --git a/src/core/osmo_io_poll.c b/src/core/osmo_io_poll.c
index 2c1e422..5000dca 100644
--- a/src/core/osmo_io_poll.c
+++ b/src/core/osmo_io_poll.c
@@ -78,33 +78,8 @@
if (what & OSMO_FD_WRITE) {
struct iofd_msghdr *msghdr = iofd_txqueue_dequeue(iofd);
if (msghdr) {
- msg = msghdr->msg;
-
rc = sendmsg(ofd->fd, >hdr, msghdr->flags);
- if (rc > 0 && rc < msgb_length(msg)) {
- msgb_pull(msg, rc);
- iofd_txqueue_enqueue_front(iofd, msghdr);
- return;
- }
- if (rc == -EAGAIN) {
- iofd_txqueue_enqueue_front(iofd, msghdr);
- return;
- }
-
- switch (iofd->mode) {
- case OSMO_IO_FD_MODE_READ_WRITE:
- iofd->io_ops.write_cb(iofd, rc, msg);
- break;
- case OSMO_IO_FD_MODE_RECVFROM_SENDTO:
- iofd->io_ops.sendto_cb(iofd, rc, msg,
>osa);
- break;
- case OSMO_IO_FD_MODE_SCTP_RECVMSG_SEND:
- OSMO_ASSERT(false);
- break;
- }
-
- talloc_free(msghdr);
- msgb_free(msg);
+ iofd_handle_send_completion(iofd, rc, msghdr);
} else {
if (iofd->mode == OSMO_IO_FD_MODE_READ_WRITE)
/* Socket is writable, but we have no data to
send. A non-blocking/async
diff --git a/src/core/osmo_io_uring.c b/src/core/osmo_io_uring.c
index abeea79..1aa17d4 100644
--- a/src/core/osmo_io_uring.c
+++ b/src/core/osmo_io_uring.c
@@ -186,43 +186,14 @@
static void iofd_uring_handle_tx(struct iofd_msghdr
[M] Change in libosmocore[master]: osmo_io: Factor out and use common send function from backend
Attention is currently required from: daniel, lynxis lazus, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35078?usp=email ) Change subject: osmo_io: Factor out and use common send function from backend .. Patch Set 3: Code-Review+2 (1 comment) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/35078/comment/e6fd896d_11d3bc56 PS3, Line 191: msgb_free(msghdr->msg); > msg is not owned by msghdr because during receive msg needs to live longer. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35078?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6da2653d32aedd0e7872be0cf90a841b56462e59 Gerrit-Change-Number: 35078 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Attention: pespin Gerrit-Attention: daniel Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Sun, 03 Dec 2023 02:18:09 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[L] Change in osmo-msc[master]: test_call: codecs: test specific PT from MO to MT
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35174?usp=email ) Change subject: test_call: codecs: test specific PT from MO to MT .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35174?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8fbabe242982441d676d09f4d0ed7557c8349f2c Gerrit-Change-Number: 35174 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Comment-Date: Sun, 03 Dec 2023 02:17:35 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-msc[master]: test_call: codecs: allow specific PT numbers [2/2]
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35141?usp=email ) Change subject: test_call: codecs: allow specific PT numbers [2/2] .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35141?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I25df2ed7ad792fbe66dfd0fbf08182c9cf6cfc5b Gerrit-Change-Number: 35141 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Comment-Date: Sun, 03 Dec 2023 02:17:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in osmo-msc[master]: test_call: codecs: allow specific PT numbers [1/2]
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35140?usp=email ) Change subject: test_call: codecs: allow specific PT numbers [1/2] .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35140?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I618e3cf1b412985589a0c63bd76b7a60202f17b9 Gerrit-Change-Number: 35140 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Comment-Date: Sun, 03 Dec 2023 02:17:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-msc[master]: add comment in codec_mapping.c
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35139?usp=email ) Change subject: add comment in codec_mapping.c .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0905a1264cd8f940c7a9964addf241091425fe72 Gerrit-Change-Number: 35139 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Comment-Date: Sun, 03 Dec 2023 02:17:06 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in osmo-msc[master]: msc_vlr_test_call: codecs: properly test new codec matching
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35138?usp=email ) Change subject: msc_vlr_test_call: codecs: properly test new codec matching .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35138?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib933554f826c1b4347dfa3f6c4f6fe086be8b133 Gerrit-Change-Number: 35138 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Comment-Date: Sun, 03 Dec 2023 02:16:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-mgw[master]: check_rtp_origin: drop special case for legacy IuUP hack
Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35181?usp=email ) Change subject: check_rtp_origin: drop special case for legacy IuUP hack .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35181?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I158dd046fdfcb10392cde3de8cc88dd095a05b40 Gerrit-Change-Number: 35181 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Attention: pespin Gerrit-Comment-Date: Sun, 03 Dec 2023 02:15:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-mgw[master]: mgcp_network: Improve err logging when rtp pkt from unexpected origin...
Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35175?usp=email ) Change subject: mgcp_network: Improve err logging when rtp pkt from unexpected origin comes in .. Patch Set 1: Code-Review+1 (2 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/35175/comment/f32e904e_b7b92c95 PS1, Line 873: osmo_sockaddr_to_str(addr), osmo_sockaddr_ntop(>end.addr.u.sa, ipbuf)); > I used osmo_sockaddr_ntop on purpose since we are only interested about the > wrong IP address there, […] Done https://gerrit.osmocom.org/c/osmo-mgw/+/35175/comment/ff06a5b8_4af3fca2 PS1, Line 885: osmo_sockaddr_to_str(addr), osmo_sockaddr_port(>end.addr.u.sa), > It's printing the port of *another* address. See the check between "got" and > "expected" there. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id9b60395df667ae9898c23cbc2afe56ac7e8b0e5 Gerrit-Change-Number: 35175 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Attention: neels Gerrit-Attention: pespin Gerrit-Comment-Date: Sun, 03 Dec 2023 02:14:22 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[S] Change in osmo-e1d[master]: Use uniform log format for default config files
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/35186?usp=email ) Change subject: Use uniform log format for default config files .. Use uniform log format for default config files Related: OS#6272 Change-Id: I4a8cb558816534ac942bc38ff0b178849d610457 --- M doc/examples/osmo-e1d-octoi-client.cfg M doc/examples/osmo-e1d-octoi-server.cfg M doc/examples/osmo-e1d-vpair.cfg 3 files changed, 24 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/doc/examples/osmo-e1d-octoi-client.cfg b/doc/examples/osmo-e1d-octoi-client.cfg index ddb981c..88a0e48 100644 --- a/doc/examples/osmo-e1d-octoi-client.cfg +++ b/doc/examples/osmo-e1d-octoi-client.cfg @@ -7,9 +7,9 @@ logging color 1 logging print category-hex 0 logging print category 1 - logging print thread-id 0 - logging timestamp 1 - logging print file 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level e1d info logging level linp info ! diff --git a/doc/examples/osmo-e1d-octoi-server.cfg b/doc/examples/osmo-e1d-octoi-server.cfg index ac5e2b7..32eb227 100644 --- a/doc/examples/osmo-e1d-octoi-server.cfg +++ b/doc/examples/osmo-e1d-octoi-server.cfg @@ -8,8 +8,9 @@ logging print category-hex 0 logging print category 1 logging print thread-id 0 - logging timestamp 1 - logging print file 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level e1d info logging level linp info ! diff --git a/doc/examples/osmo-e1d-vpair.cfg b/doc/examples/osmo-e1d-vpair.cfg index 04bdb72..265a5d0 100644 --- a/doc/examples/osmo-e1d-vpair.cfg +++ b/doc/examples/osmo-e1d-vpair.cfg @@ -1,2 +1,10 @@ +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + e1d virtual-e1-pair 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4a8cb558816534ac942bc38ff0b178849d610457 Gerrit-Change-Number: 35186 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[S] Change in osmo-e1d[master]: Use uniform log format for default config files
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/35186?usp=email ) Change subject: Use uniform log format for default config files .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4a8cb558816534ac942bc38ff0b178849d610457 Gerrit-Change-Number: 35186 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sun, 03 Dec 2023 02:12:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-cbc[master]: Use uniform log format for default config files
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/35185?usp=email ) Change subject: Use uniform log format for default config files .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/35185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I9897bf964880f2e35a59812d319851eb6e06de68 Gerrit-Change-Number: 35185 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sun, 03 Dec 2023 02:12:23 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-cbc[master]: Use uniform log format for default config files
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/35185?usp=email ) Change subject: Use uniform log format for default config files .. Use uniform log format for default config files Related: OS#6272 Change-Id: I9897bf964880f2e35a59812d319851eb6e06de68 --- M doc/examples/osmo-cbc/osmo-cbc.cfg 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/examples/osmo-cbc/osmo-cbc.cfg b/doc/examples/osmo-cbc/osmo-cbc.cfg index 9874a39..5310268 100644 --- a/doc/examples/osmo-cbc/osmo-cbc.cfg +++ b/doc/examples/osmo-cbc/osmo-cbc.cfg @@ -1,4 +1,10 @@ log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level main notice logging level smscb notice logging level cbsp notice -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/35185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I9897bf964880f2e35a59812d319851eb6e06de68 Gerrit-Change-Number: 35185 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[S] Change in osmo-bsc-nat[master]: Use uniform log format for default config files
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/35183?usp=email ) Change subject: Use uniform log format for default config files .. Use uniform log format for default config files Related: OS#6272 Change-Id: I811f7ede8d8b5ae4036bfd9cb530b1100ba0fb07 --- M doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg b/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg index ef6b1ae..49daec9 100644 --- a/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg +++ b/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg @@ -1,3 +1,11 @@ +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + cs7 instance 0 point-code 0.23.3 asp asp-clnt-OsmoBSCNAT-CN 2905 0 m3ua -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/35183?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I811f7ede8d8b5ae4036bfd9cb530b1100ba0fb07 Gerrit-Change-Number: 35183 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[S] Change in osmo-bsc-nat[master]: Use uniform log format for default config files
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/35183?usp=email ) Change subject: Use uniform log format for default config files .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/35183?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I811f7ede8d8b5ae4036bfd9cb530b1100ba0fb07 Gerrit-Change-Number: 35183 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sun, 03 Dec 2023 02:12:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-gbproxy[master]: Use uniform log format for default config files
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/35187?usp=email ) Change subject: Use uniform log format for default config files .. Use uniform log format for default config files Related: OS#6272 Change-Id: I80708f7394d2d6f407523628a7101ec9428e1443 --- M doc/examples/osmo-gbproxy/osmo-gbproxy-legacy.cfg M doc/examples/osmo-gbproxy/osmo-gbproxy-pool.cfg M doc/examples/osmo-gbproxy/osmo-gbproxy.cfg 3 files changed, 30 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/doc/examples/osmo-gbproxy/osmo-gbproxy-legacy.cfg b/doc/examples/osmo-gbproxy/osmo-gbproxy-legacy.cfg index e30b9f7..79b0c4b 100644 --- a/doc/examples/osmo-gbproxy/osmo-gbproxy-legacy.cfg +++ b/doc/examples/osmo-gbproxy/osmo-gbproxy-legacy.cfg @@ -5,7 +5,11 @@ log stderr logging filter all 1 logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level all debug logging level gprs debug logging level ns info diff --git a/doc/examples/osmo-gbproxy/osmo-gbproxy-pool.cfg b/doc/examples/osmo-gbproxy/osmo-gbproxy-pool.cfg index 7457ee8..3fa5e6d 100644 --- a/doc/examples/osmo-gbproxy/osmo-gbproxy-pool.cfg +++ b/doc/examples/osmo-gbproxy/osmo-gbproxy-pool.cfg @@ -2,6 +2,14 @@ ! Osmocom Gb Proxy (0.9.0.404-6463) configuration saved from vty !! ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login ! diff --git a/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg b/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg index 15c53d2..91edbab 100644 --- a/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg +++ b/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg @@ -2,6 +2,14 @@ ! Osmocom Gb Proxy (0.9.0.404-6463) configuration saved from vty !! ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login ! -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/35187?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I80708f7394d2d6f407523628a7101ec9428e1443 Gerrit-Change-Number: 35187 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[S] Change in osmo-gbproxy[master]: Use uniform log format for default config files
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/35187?usp=email ) Change subject: Use uniform log format for default config files .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/35187?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I80708f7394d2d6f407523628a7101ec9428e1443 Gerrit-Change-Number: 35187 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sun, 03 Dec 2023 02:11:23 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-bts[master]: Use uniform log format for default config files
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35184?usp=email ) Change subject: Use uniform log format for default config files .. Use uniform log format for default config files Related: OS#6272 Change-Id: I08b297ea78e7cd60f28f0df79f2096f70c0692c6 --- M doc/examples/litecell15/lc15bts-mgr.cfg M doc/examples/litecell15/osmo-bts-lc15.cfg M doc/examples/oc2g/oc2gbts-mgr.cfg M doc/examples/oc2g/osmo-bts-oc2g.cfg M doc/examples/octphy/osmo-bts-octphy.cfg M doc/examples/octphy/osmo-bts-trx2dsp1.cfg M doc/examples/sysmo/osmo-bts-sysmo.cfg M doc/examples/sysmo/sysmobts-mgr.cfg M doc/examples/trx/osmo-bts-trx-calypso.cfg M doc/examples/trx/osmo-bts-trx.cfg M doc/examples/virtual/osmo-bts-virtual.cfg 11 files changed, 54 insertions(+), 7 deletions(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/examples/litecell15/lc15bts-mgr.cfg b/doc/examples/litecell15/lc15bts-mgr.cfg index a92a3fd..850fb15 100644 --- a/doc/examples/litecell15/lc15bts-mgr.cfg +++ b/doc/examples/litecell15/lc15bts-mgr.cfg @@ -3,10 +3,12 @@ !! ! log stderr - logging filter all 1 logging color 1 - logging print category 0 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level temp info logging level fw info logging level find info diff --git a/doc/examples/litecell15/osmo-bts-lc15.cfg b/doc/examples/litecell15/osmo-bts-lc15.cfg index 907d83a..16651eb 100644 --- a/doc/examples/litecell15/osmo-bts-lc15.cfg +++ b/doc/examples/litecell15/osmo-bts-lc15.cfg @@ -4,7 +4,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level rsl info logging level oml info logging level rll notice diff --git a/doc/examples/oc2g/oc2gbts-mgr.cfg b/doc/examples/oc2g/oc2gbts-mgr.cfg index 8248f60..ce72e5d 100644 --- a/doc/examples/oc2g/oc2gbts-mgr.cfg +++ b/doc/examples/oc2g/oc2gbts-mgr.cfg @@ -3,10 +3,12 @@ !! ! log stderr - logging filter all 1 logging color 1 - logging print category 0 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level temp info logging level fw info logging level find info diff --git a/doc/examples/oc2g/osmo-bts-oc2g.cfg b/doc/examples/oc2g/osmo-bts-oc2g.cfg index f985f3b..ddf69f4 100644 --- a/doc/examples/oc2g/osmo-bts-oc2g.cfg +++ b/doc/examples/oc2g/osmo-bts-oc2g.cfg @@ -4,7 +4,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level rsl info logging level oml info logging level rll notice diff --git a/doc/examples/octphy/osmo-bts-octphy.cfg b/doc/examples/octphy/osmo-bts-octphy.cfg index d6d03b5..a3a0093 100644 --- a/doc/examples/octphy/osmo-bts-octphy.cfg +++ b/doc/examples/octphy/osmo-bts-octphy.cfg @@ -4,7 +4,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level rsl info logging level oml info logging level rll notice diff --git a/doc/examples/octphy/osmo-bts-trx2dsp1.cfg b/doc/examples/octphy/osmo-bts-trx2dsp1.cfg index bf590f7..477bff8 100644 --- a/doc/examples/octphy/osmo-bts-trx2dsp1.cfg +++ b/doc/examples/octphy/osmo-bts-trx2dsp1.cfg @@ -4,7 +4,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level rsl info logging level oml info logging level rll notice diff --git a/doc/examples/sysmo/osmo-bts-sysmo.cfg b/doc/examples/sysmo/osmo-bts-sysmo.cfg index 6ff043d..f44c718 100644 --- a/doc/examples/sysmo/osmo-bts-sysmo.cfg +++ b/doc/examples/sysmo/osmo-bts-sysmo.cfg @@ -4,7 +4,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level rsl info logging level oml info logging level rll notice diff --git a/doc/examples/sysmo/sysmobts-mgr.cfg b/doc/examples/sysmo/sysmobts-mgr.cfg index f891ada..00be2fd 100644 --- a/doc/examples/sysmo/sysmobts-mgr.cfg +++ b/doc/examples/sysmo/sysmobts-mgr.cfg @@ -3,9 +3,12 @@ !! ! log stderr - logging filter all 1 logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level temp info logging level fw info logging level find info diff --git
[M] Change in osmo-bts[master]: Use uniform log format for default config files
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35184?usp=email ) Change subject: Use uniform log format for default config files .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35184?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I08b297ea78e7cd60f28f0df79f2096f70c0692c6 Gerrit-Change-Number: 35184 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sun, 03 Dec 2023 02:10:35 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-hlr[master]: Use uniform log format for default config files
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/35189?usp=email ) Change subject: Use uniform log format for default config files .. Use uniform log format for default config files Related: OS#6272 Change-Id: I4319b688286845d2ffbd944e51e9cc2e5159563c --- M doc/examples/osmo-hlr-dgsm.cfg M doc/examples/osmo-hlr.cfg 2 files changed, 21 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/doc/examples/osmo-hlr-dgsm.cfg b/doc/examples/osmo-hlr-dgsm.cfg index 2774c24..50abefb 100644 --- a/doc/examples/osmo-hlr-dgsm.cfg +++ b/doc/examples/osmo-hlr-dgsm.cfg @@ -1,4 +1,12 @@ # OsmoHLR example configuration for Distributed GSM (mslookup) +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + hlr gsup # For D-GSM roaming, osmo-hlr's GSUP must listen on a public IP: diff --git a/doc/examples/osmo-hlr.cfg b/doc/examples/osmo-hlr.cfg index dd5292e..e2a3163 100644 --- a/doc/examples/osmo-hlr.cfg +++ b/doc/examples/osmo-hlr.cfg @@ -4,11 +4,11 @@ log stderr logging filter all 1 logging color 1 - logging print category 1 logging print category-hex 0 - logging print level 1 + logging print category 1 + logging timestamp 0 logging print file basename last - logging print extended-timestamp 1 + logging print level 1 logging level main notice logging level db notice logging level auc notice -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/35189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I4319b688286845d2ffbd944e51e9cc2e5159563c Gerrit-Change-Number: 35189 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[S] Change in osmo-hlr[master]: Use uniform log format for default config files
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/35189?usp=email ) Change subject: Use uniform log format for default config files .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/35189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I4319b688286845d2ffbd944e51e9cc2e5159563c Gerrit-Change-Number: 35189 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sun, 03 Dec 2023 02:10:20 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-sgsn[master]: Use uniform log format for default config files
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/35188?usp=email ) Change subject: Use uniform log format for default config files .. Use uniform log format for default config files Related: OS#6272 Change-Id: I6b6aa5a5100cf0045dcba1b062acc9376d34b0ae --- M doc/examples/osmo-gtphub/osmo-gtphub-1iface.cfg M doc/examples/osmo-gtphub/osmo-gtphub.cfg M doc/examples/osmo-sgsn/osmo-sgsn-accept-all.cfg M doc/examples/osmo-sgsn/osmo-sgsn.cfg M doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg 5 files changed, 50 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/doc/examples/osmo-gtphub/osmo-gtphub-1iface.cfg b/doc/examples/osmo-gtphub/osmo-gtphub-1iface.cfg index 3913d2c..d4dadf9 100644 --- a/doc/examples/osmo-gtphub/osmo-gtphub-1iface.cfg +++ b/doc/examples/osmo-gtphub/osmo-gtphub-1iface.cfg @@ -5,6 +5,14 @@ ! For the test, try to use most config commands. ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login diff --git a/doc/examples/osmo-gtphub/osmo-gtphub.cfg b/doc/examples/osmo-gtphub/osmo-gtphub.cfg index 652d97d..da9bba5 100644 --- a/doc/examples/osmo-gtphub/osmo-gtphub.cfg +++ b/doc/examples/osmo-gtphub/osmo-gtphub.cfg @@ -2,6 +2,14 @@ ! Osmocom gtphub configuration ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login diff --git a/doc/examples/osmo-sgsn/osmo-sgsn-accept-all.cfg b/doc/examples/osmo-sgsn/osmo-sgsn-accept-all.cfg index 7abe7b3..69000b4 100644 --- a/doc/examples/osmo-sgsn/osmo-sgsn-accept-all.cfg +++ b/doc/examples/osmo-sgsn/osmo-sgsn-accept-all.cfg @@ -2,6 +2,14 @@ ! Osmocom SGSN configuration ! ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login ! diff --git a/doc/examples/osmo-sgsn/osmo-sgsn.cfg b/doc/examples/osmo-sgsn/osmo-sgsn.cfg index 11413c1..0b5ef4b 100644 --- a/doc/examples/osmo-sgsn/osmo-sgsn.cfg +++ b/doc/examples/osmo-sgsn/osmo-sgsn.cfg @@ -2,6 +2,14 @@ ! Osmocom SGSN configuration ! ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login ! diff --git a/doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg b/doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg index 1cc4bde..a7ed9cf 100644 --- a/doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg +++ b/doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg @@ -2,6 +2,14 @@ ! Osmocom SGSN configuration ! ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login ! -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/35188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6b6aa5a5100cf0045dcba1b062acc9376d34b0ae Gerrit-Change-Number: 35188 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[M] Change in osmo-sgsn[master]: Use uniform log format for default config files
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/35188?usp=email ) Change subject: Use uniform log format for default config files .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/35188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6b6aa5a5100cf0045dcba1b062acc9376d34b0ae Gerrit-Change-Number: 35188 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sun, 03 Dec 2023 02:10:05 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-mgw[master]: Use uniform log format for default config files
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35192?usp=email ) Change subject: Use uniform log format for default config files .. Use uniform log format for default config files Related: OS#6272 Change-Id: I82ee4ce3c961976526a792862061c237a372e31b --- M doc/examples/osmo-mgw/osmo-mgw-abis_e1.cfg M doc/examples/osmo-mgw/osmo-mgw.cfg 2 files changed, 26 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/doc/examples/osmo-mgw/osmo-mgw-abis_e1.cfg b/doc/examples/osmo-mgw/osmo-mgw-abis_e1.cfg index bd948b8..dcf3663 100644 --- a/doc/examples/osmo-mgw/osmo-mgw-abis_e1.cfg +++ b/doc/examples/osmo-mgw/osmo-mgw-abis_e1.cfg @@ -1,6 +1,14 @@ ! ! MGCP configuration example ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + e1_input e1_line 0 driver dahdi e1_line 0 port 0 diff --git a/doc/examples/osmo-mgw/osmo-mgw.cfg b/doc/examples/osmo-mgw/osmo-mgw.cfg index 320feae..8535efe 100644 --- a/doc/examples/osmo-mgw/osmo-mgw.cfg +++ b/doc/examples/osmo-mgw/osmo-mgw.cfg @@ -1,6 +1,14 @@ ! ! MGCP configuration example ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + mgcp bind ip 127.0.0.1 rtp port-range 4002 16000 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I82ee4ce3c961976526a792862061c237a372e31b Gerrit-Change-Number: 35192 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[S] Change in osmo-mgw[master]: Use uniform log format for default config files
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35192?usp=email ) Change subject: Use uniform log format for default config files .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I82ee4ce3c961976526a792862061c237a372e31b Gerrit-Change-Number: 35192 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sun, 03 Dec 2023 02:09:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-hnbgw[master]: Use uniform log format for default config files
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35190?usp=email ) Change subject: Use uniform log format for default config files .. Use uniform log format for default config files Related: OS#6272 Change-Id: I10bfc4150e10cac048f320641c040fa300f734c4 --- M doc/examples/osmo-hnbgw/osmo-hnbgw-cnpool.cfg M doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg M doc/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg M doc/examples/osmo-hnbgw/osmo-hnbgw.cfg 4 files changed, 22 insertions(+), 12 deletions(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/examples/osmo-hnbgw/osmo-hnbgw-cnpool.cfg b/doc/examples/osmo-hnbgw/osmo-hnbgw-cnpool.cfg index 3236afb..83e03b9 100644 --- a/doc/examples/osmo-hnbgw/osmo-hnbgw-cnpool.cfg +++ b/doc/examples/osmo-hnbgw/osmo-hnbgw-cnpool.cfg @@ -1,11 +1,11 @@ log stderr logging filter all 1 logging color 1 - logging print level 1 - logging print category 1 logging print category-hex 0 + logging print category 1 + logging timestamp 0 logging print file basename last - logging print extended-timestamp 1 + logging print level 1 logging level set-all notice cs7 instance 0 diff --git a/doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg b/doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg index 8be4b1b..671d790 100644 --- a/doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg +++ b/doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg @@ -22,9 +22,9 @@ log stderr logging filter all 1 logging color 1 - logging print level 1 - logging print category 1 logging print category-hex 0 + logging print category 1 + logging timestamp 0 logging print file basename last - logging print extended-timestamp 1 + logging print level 1 logging level set-all notice diff --git a/doc/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg b/doc/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg index 087764c..7599427 100644 --- a/doc/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg +++ b/doc/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg @@ -1,11 +1,11 @@ log stderr logging filter all 1 logging color 1 - logging print level 1 - logging print category 1 logging print category-hex 0 + logging print category 1 + logging timestamp 0 logging print file basename last - logging print extended-timestamp 1 + logging print level 1 logging level set-all notice hnbgw plmn 001 01 diff --git a/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg b/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg index a9edc77..996a3ae 100644 --- a/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg +++ b/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg @@ -1,11 +1,11 @@ log stderr logging filter all 1 logging color 1 - logging print level 1 - logging print category 1 logging print category-hex 0 + logging print category 1 + logging timestamp 0 logging print file basename last - logging print extended-timestamp 1 + logging print level 1 logging level set-all notice hnbgw plmn 001 01 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35190?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I10bfc4150e10cac048f320641c040fa300f734c4 Gerrit-Change-Number: 35190 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[S] Change in osmo-hnbgw[master]: Use uniform log format for default config files
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35190?usp=email ) Change subject: Use uniform log format for default config files .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35190?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I10bfc4150e10cac048f320641c040fa300f734c4 Gerrit-Change-Number: 35190 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sun, 03 Dec 2023 02:09:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-hnodeb[master]: Use uniform log format for default config files
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/35191?usp=email ) Change subject: Use uniform log format for default config files .. Use uniform log format for default config files Related: OS#6272 Change-Id: I239229c0f23f70a75155ca8790b51a7c39acca21 --- M doc/examples/osmo-hnodeb/osmo-hnodeb.cfg 1 file changed, 14 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/doc/examples/osmo-hnodeb/osmo-hnodeb.cfg b/doc/examples/osmo-hnodeb/osmo-hnodeb.cfg index 89b4799..6c46bd2 100644 --- a/doc/examples/osmo-hnodeb/osmo-hnodeb.cfg +++ b/doc/examples/osmo-hnodeb/osmo-hnodeb.cfg @@ -1,9 +1,11 @@ log stderr logging filter all 1 logging color 1 - logging print category 1 logging print category-hex 0 - logging timestamp 1 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 ! line vty no login -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/35191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I239229c0f23f70a75155ca8790b51a7c39acca21 Gerrit-Change-Number: 35191 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[S] Change in osmo-hnodeb[master]: Use uniform log format for default config files
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/35191?usp=email ) Change subject: Use uniform log format for default config files .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/35191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I239229c0f23f70a75155ca8790b51a7c39acca21 Gerrit-Change-Number: 35191 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sun, 03 Dec 2023 02:09:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-pcap[master]: Use uniform log format for default config files
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/35194?usp=email ) Change subject: Use uniform log format for default config files .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/35194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I0754f45561a45557d0f9fb3218813a2c8e83559c Gerrit-Change-Number: 35194 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sun, 03 Dec 2023 02:09:19 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-pcap[master]: Use uniform log format for default config files
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/35194?usp=email ) Change subject: Use uniform log format for default config files .. Use uniform log format for default config files Related: OS#6272 Change-Id: I0754f45561a45557d0f9fb3218813a2c8e83559c --- M doc/examples/osmo-pcap-client/osmo-pcap-client-tls.cfg M doc/examples/osmo-pcap-client/osmo-pcap-client.cfg M doc/examples/osmo-pcap-server/osmo-pcap-server-tls.cfg M doc/examples/osmo-pcap-server/osmo-pcap-server.cfg 4 files changed, 34 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/examples/osmo-pcap-client/osmo-pcap-client-tls.cfg b/doc/examples/osmo-pcap-client/osmo-pcap-client-tls.cfg index 73d1535..6249f2a 100644 --- a/doc/examples/osmo-pcap-client/osmo-pcap-client-tls.cfg +++ b/doc/examples/osmo-pcap-client/osmo-pcap-client-tls.cfg @@ -3,6 +3,14 @@ !! ! ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login ! diff --git a/doc/examples/osmo-pcap-client/osmo-pcap-client.cfg b/doc/examples/osmo-pcap-client/osmo-pcap-client.cfg index 829ae5d..7035099 100644 --- a/doc/examples/osmo-pcap-client/osmo-pcap-client.cfg +++ b/doc/examples/osmo-pcap-client/osmo-pcap-client.cfg @@ -3,6 +3,14 @@ !! ! ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login ! diff --git a/doc/examples/osmo-pcap-server/osmo-pcap-server-tls.cfg b/doc/examples/osmo-pcap-server/osmo-pcap-server-tls.cfg index 1b89ba5..db055d4 100644 --- a/doc/examples/osmo-pcap-server/osmo-pcap-server-tls.cfg +++ b/doc/examples/osmo-pcap-server/osmo-pcap-server-tls.cfg @@ -4,7 +4,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level all everything logging level pcap notice logging level client notice diff --git a/doc/examples/osmo-pcap-server/osmo-pcap-server.cfg b/doc/examples/osmo-pcap-server/osmo-pcap-server.cfg index e380113..abfae61 100644 --- a/doc/examples/osmo-pcap-server/osmo-pcap-server.cfg +++ b/doc/examples/osmo-pcap-server/osmo-pcap-server.cfg @@ -4,7 +4,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level all everything logging level pcap notice logging level client notice -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/35194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I0754f45561a45557d0f9fb3218813a2c8e83559c Gerrit-Change-Number: 35194 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[S] Change in osmo-msc[master]: Use uniform log format for default config files
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35193?usp=email ) Change subject: Use uniform log format for default config files .. Use uniform log format for default config files Related: OS#6272 Change-Id: Ic710873f9203414b343b216097785cef36ca05a9 --- M doc/examples/osmo-msc/osmo-msc.cfg M doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg M doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg 3 files changed, 34 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, approved diff --git a/doc/examples/osmo-msc/osmo-msc.cfg b/doc/examples/osmo-msc/osmo-msc.cfg index b086237..aac27d2 100644 --- a/doc/examples/osmo-msc/osmo-msc.cfg +++ b/doc/examples/osmo-msc/osmo-msc.cfg @@ -1,6 +1,14 @@ ! ! OsmoMSC configuration saved from vty ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login ! diff --git a/doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg b/doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg index 176867a..5033598 100644 --- a/doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg +++ b/doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg @@ -1,6 +1,14 @@ ! ! OsmoMSC configuration saved from vty ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login ! diff --git a/doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg b/doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg index 66adfdd..22f8734 100644 --- a/doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg +++ b/doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg @@ -1,6 +1,14 @@ ! ! OsmoMSC configuration saved from vty ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + line vty no login ! -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic710873f9203414b343b216097785cef36ca05a9 Gerrit-Change-Number: 35193 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[S] Change in osmo-msc[master]: Use uniform log format for default config files
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35193?usp=email ) Change subject: Use uniform log format for default config files .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic710873f9203414b343b216097785cef36ca05a9 Gerrit-Change-Number: 35193 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sun, 03 Dec 2023 02:09:07 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-sip-connector[master]: Use uniform log format for default config files
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/35196?usp=email ) Change subject: Use uniform log format for default config files .. Use uniform log format for default config files Related: OS#6272 Change-Id: I1b1ebca276184158d585815a62da3b91fa9c3081 --- M doc/examples/osmo-sip-connector.cfg 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/doc/examples/osmo-sip-connector.cfg b/doc/examples/osmo-sip-connector.cfg index bf4967e..ed77956 100644 --- a/doc/examples/osmo-sip-connector.cfg +++ b/doc/examples/osmo-sip-connector.cfg @@ -1,3 +1,11 @@ +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + app mncc socket-path /tmp/msc_mncc -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/35196?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I1b1ebca276184158d585815a62da3b91fa9c3081 Gerrit-Change-Number: 35196 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[S] Change in osmo-sip-connector[master]: Use uniform log format for default config files
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/35196?usp=email ) Change subject: Use uniform log format for default config files .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/35196?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I1b1ebca276184158d585815a62da3b91fa9c3081 Gerrit-Change-Number: 35196 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sun, 03 Dec 2023 02:08:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-sysmon[master]: Use uniform log format for default config files
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/35198?usp=email ) Change subject: Use uniform log format for default config files .. Use uniform log format for default config files Related: OS#6272 Change-Id: If737fb3aa92735a3f4280170370ec48c89134526 --- M doc/examples/osmo-sysmon.cfg 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/examples/osmo-sysmon.cfg b/doc/examples/osmo-sysmon.cfg index 22c27cb..4e6e633 100644 --- a/doc/examples/osmo-sysmon.cfg +++ b/doc/examples/osmo-sysmon.cfg @@ -1,3 +1,11 @@ +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + ctrl-client bsc 127.0.0.1 4249 get-variable msc.0.connection_status get-variable bts_connection_status -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/35198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: If737fb3aa92735a3f4280170370ec48c89134526 Gerrit-Change-Number: 35198 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[S] Change in osmo-sysmon[master]: Use uniform log format for default config files
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/35198?usp=email ) Change subject: Use uniform log format for default config files .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/35198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: If737fb3aa92735a3f4280170370ec48c89134526 Gerrit-Change-Number: 35198 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sun, 03 Dec 2023 02:08:36 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-smlc[master]: Use uniform log format for default config files
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/35197?usp=email ) Change subject: Use uniform log format for default config files .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/35197?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I24f454bd83f32504b9c135d1620b7d02167e8bc6 Gerrit-Change-Number: 35197 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sun, 03 Dec 2023 02:08:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-smlc[master]: Use uniform log format for default config files
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/35197?usp=email ) Change subject: Use uniform log format for default config files .. Use uniform log format for default config files Related: OS#6272 Change-Id: I24f454bd83f32504b9c135d1620b7d02167e8bc6 --- M doc/examples/osmo-smlc/osmo-smlc.cfg 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/doc/examples/osmo-smlc/osmo-smlc.cfg b/doc/examples/osmo-smlc/osmo-smlc.cfg index 6585d47..74b90e0 100644 --- a/doc/examples/osmo-smlc/osmo-smlc.cfg +++ b/doc/examples/osmo-smlc/osmo-smlc.cfg @@ -1,3 +1,11 @@ +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + cells lac-ci 23 42 lat 12.34567 lon 34.56789 cgi 262 42 17 5 lat 12.34765 lon 34.56987 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/35197?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I24f454bd83f32504b9c135d1620b7d02167e8bc6 Gerrit-Change-Number: 35197 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[S] Change in osmo-pcu[master]: Use uniform log format for default config files
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35195?usp=email ) Change subject: Use uniform log format for default config files .. Use uniform log format for default config files Related: OS#6272 Change-Id: I0d0042aa37da887afa0e9a5060cfbacaec23ed0a --- M doc/examples/osmo-pcu.cfg M doc/examples/osmo-pcu.e1_ccu.cfg 2 files changed, 26 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/doc/examples/osmo-pcu.cfg b/doc/examples/osmo-pcu.cfg index 4a3842d..1459826 100644 --- a/doc/examples/osmo-pcu.cfg +++ b/doc/examples/osmo-pcu.cfg @@ -1,3 +1,11 @@ +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + pcu flow-control-interval 10 cs 2 diff --git a/doc/examples/osmo-pcu.e1_ccu.cfg b/doc/examples/osmo-pcu.e1_ccu.cfg index 01f9b09..359f1d9 100644 --- a/doc/examples/osmo-pcu.e1_ccu.cfg +++ b/doc/examples/osmo-pcu.e1_ccu.cfg @@ -1,3 +1,11 @@ +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + pcu flow-control-interval 10 cs 2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35195?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0d0042aa37da887afa0e9a5060cfbacaec23ed0a Gerrit-Change-Number: 35195 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[S] Change in osmo-pcu[master]: Use uniform log format for default config files
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35195?usp=email ) Change subject: Use uniform log format for default config files .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35195?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0d0042aa37da887afa0e9a5060cfbacaec23ed0a Gerrit-Change-Number: 35195 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sun, 03 Dec 2023 02:07:54 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-trx[master]: Use uniform log format for default config files
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/35199?usp=email ) Change subject: Use uniform log format for default config files .. Use uniform log format for default config files Related: OS#6272 Change-Id: If9466e925a405d35deed2e81f25a0a1677de0f3c --- M doc/examples/osmo-trx-ipc/osmo-trx-ipc.cfg M doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg M doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg M doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg M doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg 5 files changed, 30 insertions(+), 10 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/doc/examples/osmo-trx-ipc/osmo-trx-ipc.cfg b/doc/examples/osmo-trx-ipc/osmo-trx-ipc.cfg index e3047c0..d66f09a 100644 --- a/doc/examples/osmo-trx-ipc/osmo-trx-ipc.cfg +++ b/doc/examples/osmo-trx-ipc/osmo-trx-ipc.cfg @@ -1,9 +1,11 @@ log stderr logging filter all 1 logging color 1 + logging print category-hex 0 logging print category 1 - logging timestamp 1 - logging print file basename + logging timestamp 0 + logging print file basename last + logging print level 1 logging level set-all notice ! line vty diff --git a/doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg b/doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg index ae55efe..8989565 100644 --- a/doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg +++ b/doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg @@ -1,9 +1,11 @@ log stderr logging filter all 1 logging color 1 + logging print category-hex 0 logging print category 1 - logging timestamp 1 - logging print file basename + logging timestamp 0 + logging print file basename last + logging print level 1 logging level set-all notice ! line vty diff --git a/doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg b/doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg index ae55efe..8989565 100644 --- a/doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg +++ b/doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg @@ -1,9 +1,11 @@ log stderr logging filter all 1 logging color 1 + logging print category-hex 0 logging print category 1 - logging timestamp 1 - logging print file basename + logging timestamp 0 + logging print file basename last + logging print level 1 logging level set-all notice ! line vty diff --git a/doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg b/doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg index 1468e93..6af7844 100644 --- a/doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg +++ b/doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg @@ -1,9 +1,11 @@ log stderr logging filter all 1 logging color 1 + logging print category-hex 0 logging print category 1 - logging timestamp 1 - logging print file basename + logging timestamp 0 + logging print file basename last + logging print level 1 logging level set-all notice ! line vty diff --git a/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg b/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg index 9eeb395..87aed57 100644 --- a/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg +++ b/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg @@ -1,9 +1,11 @@ log stderr logging filter all 1 logging color 1 + logging print category-hex 0 logging print category 1 - logging timestamp 1 - logging print file basename + logging timestamp 0 + logging print file basename last + logging print level 1 logging level set-all notice ! line vty -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/35199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9466e925a405d35deed2e81f25a0a1677de0f3c Gerrit-Change-Number: 35199 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[S] Change in osmo-trx[master]: Use uniform log format for default config files
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/35199?usp=email ) Change subject: Use uniform log format for default config files .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/35199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9466e925a405d35deed2e81f25a0a1677de0f3c Gerrit-Change-Number: 35199 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sun, 03 Dec 2023 02:07:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-bsc[master]: Use uniform log format for default config files
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35182?usp=email ) Change subject: Use uniform log format for default config files .. Use uniform log format for default config files Related: OS#6272 Change-Id: I992ff466db768f625dd722d40829aa0301cc1705 --- M doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus01-4trx.cfg M doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg M doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg M doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-4trx.cfg M doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-8trx.cfg M doc/examples/osmo-bsc/ericsson/osmo-bsc.rbs2308.cfg M doc/examples/osmo-bsc/nokia/osmo-bsc.insite.cfg M doc/examples/osmo-bsc/osmo-bsc-4trx.cfg M doc/examples/osmo-bsc/osmo-bsc-minimal.cfg M doc/examples/osmo-bsc/osmo-bsc.cfg M doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg M doc/examples/osmo-bsc/siemens/osmo-bsc.bs11.cfg 12 files changed, 84 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus01-4trx.cfg b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus01-4trx.cfg index 7d676d6..22c70b9 100644 --- a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus01-4trx.cfg +++ b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus01-4trx.cfg @@ -7,6 +7,12 @@ no login ! log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level lmi info logging level linp info logging level nm debug diff --git a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg index 38e7afb..79ebca9 100644 --- a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg +++ b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg @@ -10,6 +10,12 @@ no login ! log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level lmi info logging level linp info logging level nm debug diff --git a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg index 1f33577..4487ff0 100644 --- a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg +++ b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg @@ -7,6 +7,12 @@ no login ! log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level lmi info logging level linp info logging level nm debug diff --git a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-4trx.cfg b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-4trx.cfg index 464b37f..7e87bab 100644 --- a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-4trx.cfg +++ b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-4trx.cfg @@ -7,6 +7,12 @@ no login ! log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level lmi info logging level linp info logging level nm debug diff --git a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-8trx.cfg b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-8trx.cfg index 844bf05..dd015c0 100644 --- a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-8trx.cfg +++ b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-8trx.cfg @@ -7,6 +7,12 @@ no login ! log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level lmi info logging level linp info logging level nm debug diff --git a/doc/examples/osmo-bsc/ericsson/osmo-bsc.rbs2308.cfg b/doc/examples/osmo-bsc/ericsson/osmo-bsc.rbs2308.cfg index 82283c8..e61acc0 100644 --- a/doc/examples/osmo-bsc/ericsson/osmo-bsc.rbs2308.cfg +++ b/doc/examples/osmo-bsc/ericsson/osmo-bsc.rbs2308.cfg @@ -7,6 +7,12 @@ no login ! log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level lmi info logging level linp info logging level nm debug diff --git a/doc/examples/osmo-bsc/nokia/osmo-bsc.insite.cfg b/doc/examples/osmo-bsc/nokia/osmo-bsc.insite.cfg index 0b0afa8..34ffa99 100644 --- a/doc/examples/osmo-bsc/nokia/osmo-bsc.insite.cfg +++ b/doc/examples/osmo-bsc/nokia/osmo-bsc.insite.cfg @@ -11,7 +11,9
[M] Change in osmo-bsc[master]: Use uniform log format for default config files
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35182?usp=email ) Change subject: Use uniform log format for default config files .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35182?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I992ff466db768f625dd722d40829aa0301cc1705 Gerrit-Change-Number: 35182 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sun, 03 Dec 2023 02:07:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
