[M] Change in libosmocore[master]: {fsm,vty}: add a VTY command to generate FSM state graphs
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/36713?usp=email )
Change subject: {fsm,vty}: add a VTY command to generate FSM state graphs
..
{fsm,vty}: add a VTY command to generate FSM state graphs
This command generates a state transitions graph for the given FSM.
The output format is DOT/Graphviz, which can be rendered using offline
or online (web) tools. It's useful for quickly getting a graphical
representation of the FSM states and their interconnections.
https://en.wikipedia.org/wiki/DOT_(graph_description_language)
https://graphviz.org/doc/info/lang.html
Change-Id: I09ee0a8c3fc4b1aa991ab5c93c0b654fccd7ea4c
---
M src/vty/fsm_vty.c
1 file changed, 56 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/13/36713/1
diff --git a/src/vty/fsm_vty.c b/src/vty/fsm_vty.c
index da6038f..19c35da 100644
--- a/src/vty/fsm_vty.c
+++ b/src/vty/fsm_vty.c
@@ -158,6 +158,44 @@
return CMD_SUCCESS;
}
+DEFUN(show_fsm_state_graph, show_fsm_state_graph_cmd,
+ "show fsm-state-graph NAME",
+ SHOW_STR "Generate a state transition graph (using DOT language)\n"
+ "FSM name\n")
+{
+ const struct osmo_fsm *fsm;
+
+ fsm = osmo_fsm_find_by_name(argv[0]);
+ if (!fsm) {
+ vty_out(vty, "Error: FSM with name '%s' doesn't exist!%s",
+ argv[0], VTY_NEWLINE);
+ return CMD_WARNING;
+ }
+
+ vty_out(vty, "digraph \"%s\" {%s", fsm->name, VTY_NEWLINE);
+
+ for (unsigned int i = 0; i < fsm->num_states; i++) {
+ const struct osmo_fsm_state *st = >states[i];
+
+ vty_out(vty, "\t\"%s\"; # out_state_mask=0x%08x%s",
+ st->name, st->out_state_mask, VTY_NEWLINE);
+
+ for (unsigned int j = 0; j < sizeof(st->out_state_mask) * 8;
j++) {
+ if (~st->out_state_mask & (1 << j))
+ continue;
+ vty_out(vty, "\t\"%s\" -> \"%s\";%s",
+ st->name, osmo_fsm_state_name(fsm, j),
+ VTY_NEWLINE);
+ }
+
+ vty_out(vty, "%s", VTY_NEWLINE);
+ }
+
+ vty_out(vty, "}%s", VTY_NEWLINE);
+
+ return CMD_SUCCESS;
+}
+
DEFUN(show_fsm_insts, show_fsm_insts_cmd,
"show fsm-instances all",
SH_FSMI_STR
@@ -214,6 +252,7 @@
install_lib_element_ve(_fsm_cmd);
install_lib_element_ve(_fsms_cmd);
+ install_lib_element_ve(_fsm_state_graph_cmd);
install_lib_element_ve(_fsm_inst_cmd);
install_lib_element_ve(_fsm_insts_cmd);
osmo_fsm_vty_cmds_installed = true;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36713?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I09ee0a8c3fc4b1aa991ab5c93c0b654fccd7ea4c
Gerrit-Change-Number: 36713
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
[S] Change in osmo-bts[master]: rsl.adoc: document RSL_IE_OSMO_RTP_EXTENSIONS
Attention is currently required from: pespin. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36706?usp=email ) Change subject: rsl.adoc: document RSL_IE_OSMO_RTP_EXTENSIONS .. Patch Set 2: (2 comments) File doc/manuals/abis/rsl.adoc: https://gerrit.osmocom.org/c/osmo-bts/+/36706/comment/6ee11c2a_b2d1bac1 PS1, Line 872: | 0x62 | RSL_IE_OSMO_TEMP_OVP_ACCH_CAP | <> > The current state of the doc covers IEIs up to 0x61, but libosmocore has > definitions up to 0x63. […] The pre-patch has been split off. https://gerrit.osmocom.org/c/osmo-bts/+/36706/comment/3c7422cf_203dc94e PS1, Line 1097: [[RSL_IE_OSMO_TEMP_OVP_ACCH_CAP]] > Same for these 2 above. The pre-patch has been split off. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6117049b17ced5fb6635ac70d9238169033af4de Gerrit-Change-Number: 36706 Gerrit-PatchSet: 2 Gerrit-Owner: falconia Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 07 May 2024 18:43:54 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[S] Change in osmo-bts[master]: rsl.adoc: mention currently undocumented IEs
falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/36712?usp=email ) Change subject: rsl.adoc: mention currently undocumented IEs .. rsl.adoc: mention currently undocumented IEs RSL_IE_OSMO_TEMP_OVP_ACCH_CAP and RSL_IE_OSMO_OSMUX_CID have been defined for a while now, but are still not documented. Until someone who knows them can document them properly, we need to at least acknowledge their existence, and show the IEI code points that have been allocated to them, so it is clear from the documentation what IEI code points have already been allocated and where new extensions are to be added. Change-Id: I55d7eef946c24cd0e224157d95fdac3243a374ef --- M doc/manuals/abis/rsl.adoc 1 file changed, 29 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/12/36712/1 diff --git a/doc/manuals/abis/rsl.adoc b/doc/manuals/abis/rsl.adoc index e627f5c..6e8746a 100644 --- a/doc/manuals/abis/rsl.adoc +++ b/doc/manuals/abis/rsl.adoc @@ -867,6 +867,8 @@ | 0x01 | RSL_IE_CHAN_NR | <> | 0x60 | RSL_IE_OSMO_REP_ACCH_CAP | <> | 0x61 | RSL_IE_OSMO_TRAINING_SEQUENCE | <> +| 0x62 | RSL_IE_OSMO_TEMP_OVP_ACCH_CAP | <> +| 0x63 | RSL_IE_OSMO_OSMUX_CID | <> | 0xf0 | RSL_IE_IPAC_REMOTE_IP | <> | 0xf1 | RSL_IE_IPAC_REMOTE_PORT | <> | 0xf3 | RSL_IE_IPAC_LOCAL_PORT | <> @@ -1089,6 +1091,16 @@ | 8..255 | reserved values |=== +[[RSL_IE_OSMO_TEMP_OVP_ACCH_CAP]] + RSL_IE_OSMO_TEMP_OVP_ACCH_CAP + +FIXME: this IE has been defined, but remains to be documented. + +[[RSL_IE_OSMO_OSMUX_CID]] + RSL_IE_OSMO_OSMUX_CID + +FIXME: this IE has been defined, but remains to be documented. + [[RSL_IE_IPAC_RTP_CSD_FORMAT]] RSL_IE_IPAC_RTP_CSD_FORMAT -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36712?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I55d7eef946c24cd0e224157d95fdac3243a374ef Gerrit-Change-Number: 36712 Gerrit-PatchSet: 1 Gerrit-Owner: falconia Gerrit-MessageType: newchange
[S] Change in osmo-bts[master]: rsl.adoc: document RSL_IE_OSMO_RTP_EXTENSIONS
Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/36706?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: rsl.adoc: document RSL_IE_OSMO_RTP_EXTENSIONS .. rsl.adoc: document RSL_IE_OSMO_RTP_EXTENSIONS This addition to Abis RSL is an Osmocom-specific IE, intended for Osmocom flavor of Abis over IP. It requests the use of non-standard enhanced RTP transport formats. Change-Id: I6117049b17ced5fb6635ac70d9238169033af4de --- M doc/manuals/abis/rsl.adoc 1 file changed, 30 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/06/36706/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6117049b17ced5fb6635ac70d9238169033af4de Gerrit-Change-Number: 36706 Gerrit-PatchSet: 2 Gerrit-Owner: falconia Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[S] Change in osmo-bts[master]: rsl.adoc: document RSL_IE_OSMO_RTP_EXTENSIONS
Attention is currently required from: pespin. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36706?usp=email ) Change subject: rsl.adoc: document RSL_IE_OSMO_RTP_EXTENSIONS .. Patch Set 1: (2 comments) File doc/manuals/abis/rsl.adoc: https://gerrit.osmocom.org/c/osmo-bts/+/36706/comment/8b58b70a_77cfacb1 PS1, Line 872: | 0x62 | RSL_IE_OSMO_TEMP_OVP_ACCH_CAP | <> > These 2 above seem to actually be missing but not really related to this > patch, so perhaps submit th […] The current state of the doc covers IEIs up to 0x61, but libosmocore has definitions up to 0x63. I picked 0x64 for my new IE, but attempting to document 0x64 right after 0x61 makes it obvious that the documentation step got skipped for 0x62 and 0x63. But yes, I will split this part off into a separate pre-patch. https://gerrit.osmocom.org/c/osmo-bts/+/36706/comment/234cb521_8172cf88 PS1, Line 1110: This information element requests the use of non-standard enhanced RTP > I'm maybe missing some sort of packetdiag output (see for instance packetdiag > examples in . […] About TLV: I am open to changing this IE to TV. For context, please read TW-TS-003: https://www.freecalypso.org/specs/tw-ts-003-v010001.txt TW-TS-003 defines one new IE on AoIP BSSMAP interface, and that one is of fixed-length TV format. Now we need to propagate the same signaling from the BSC to the BTS - but for Abis-IP, unlike AoIP, there are no 3GPP specs at all, hence nothing to extend with TW-TS-* specs - instead all Abis-IP definitions have to be worked out in Osmocom only. For the Osmocom-controlled IE from OsmoBSC to OsmoBTS, my first thought was to make it TV and define it as an exact copy of TW-TS-003 on AoIP. But then I saw that all other Osmocom extension IEs, e.g., RSL_IE_OSMO_OSMUX_CID, are defined as TLV, even though Osmux CID for example is always one byte. Hence I followed suit with my new IE. Maybe we can now decide if the new IE (that replicates TW-TS-003 on Abis-IP) should be TV or TLV, and then document it accordingly? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6117049b17ced5fb6635ac70d9238169033af4de Gerrit-Change-Number: 36706 Gerrit-PatchSet: 1 Gerrit-Owner: falconia Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 07 May 2024 17:24:04 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: asterisk: Introduce AMI_Adapter_CT
Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36711?usp=email ) Change subject: asterisk: Introduce AMI_Adapter_CT .. Patch Set 1: (1 comment) Patchset: PS1: FYI, I plan to submit a follow-up patch to this one which changes Telnet_PT to a regular TCP socket for the AMI interface. This is a step forward towards separating the wire coding from ttcn3 message encoding. I started using Telnet_PT port since initial use of the interface was done through telnet, but it's not really a telnet interface and stuff starts becoming difficult to maintain properly when events (generated by Asterisk at any time) arrive. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36711?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibf230d2302fecf443f34e1c4d4acfd4802f4cc79 Gerrit-Change-Number: 36711 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: jolly Gerrit-Reviewer: laforge Gerrit-Attention: jolly Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 07 May 2024 15:06:48 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: asterisk: Introduce AMI_Adapter_CT
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36711?usp=email )
Change subject: asterisk: Introduce AMI_Adapter_CT
..
asterisk: Introduce AMI_Adapter_CT
This allows to keep string handling totally internal to the AMI_Adapter
component, which also means now the CLIENT port acts asynchronously on
full AMI messages.
This allows for instance using activated altsteps to ignore events or
answer to them.
Change-Id: Ibf230d2302fecf443f34e1c4d4acfd4802f4cc79
---
M asterisk/AMI_Functions.ttcn
M asterisk/Asterisk_Tests.ttcn
2 files changed, 126 insertions(+), 48 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/11/36711/1
diff --git a/asterisk/AMI_Functions.ttcn b/asterisk/AMI_Functions.ttcn
index 72420e1..6e0b8d0 100644
--- a/asterisk/AMI_Functions.ttcn
+++ b/asterisk/AMI_Functions.ttcn
@@ -167,6 +167,58 @@
tr_AMI_Field_ActionId(action_id)
);
+
+/***
+ * Adapter:
+ ***/
+
+type port AMI_Msg_PT message {
+ inout AMI_Msg;
+} with { extension "internal" };
+
+type component AMI_Adapter_CT {
+ port TELNETasp_PT AMI;
+ port AMI_Msg_PT CLIENT;
+}
+
+function f_AMI_Adapter_main() runs on AMI_Adapter_CT {
+ var AMI_Msg msg;
+
+ var charstring rx, buf := "";
+ var integer fd;
+
+ map(self:AMI, system:AMI);
+
+ while (true) {
+
+ alt {
+ [] AMI.receive(pattern "\n") {
+ buf := buf & "\n";
+ msg := dec_AMI_Msg(buf);
+ buf := "";
+ CLIENT.send(msg);
+ };
+ [] AMI.receive(charstring:?) -> value rx {
+ buf := buf & rx;
+ };
+ [] AMI.receive(integer:?) -> value fd {
+ if (fd == -1) {
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__,
fail,
+ "AMI Telnet Connection
Failure: " & int2str(fd));
+ } else {
+ /* telnet connection succeeded */
+ }
+ }
+ [] CLIENT.receive(AMI_Msg:?) -> value msg {
+ /* TODO: in the future, queue Action if there's already
one Action in transit, to fullfill AMI requirements. */
+ var charstring tx_txt := enc_AMI_Msg(msg);
+ AMI.send(tx_txt);
+ }
+ }
+ }
+}
+
+
/*
* Functions:
*/
@@ -223,62 +275,66 @@
return field.val;
}
-private function f_ami_wait_for_prompt_str(TELNETasp_PT pt, charstring
log_label := "(?)")
-return charstring {
- var charstring rx, buf := "";
- var integer fd;
+function f_ami_transceive_ret(AMI_Msg_PT pt, template (value) AMI_Msg tx_msg,
float rx_timeout := 10.0) return AMI_Msg {
+ var AMI_Msg rx_msg;
timer T;
- T.start(mp_ami_prompt_timeout);
+ T.start(rx_timeout);
+ pt.send(tx_msg);
alt {
- [] pt.receive(pattern "\n") { buf := buf & "\n" };
- [] pt.receive(charstring:?) -> value rx { buf := buf & rx; repeat };
- [] pt.receive(integer:?) -> value fd {
- if (fd == -1) {
- Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
- "AMI Telnet Connection Failure:
" & log_label);
- } else {
- repeat; /* telnet connection succeeded */
- }
- }
+ [] pt.receive(AMI_Msg:?) -> value rx_msg;
[] T.timeout {
Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
- "AMI Timeout for prompt: " & log_label);
- };
+ log2str("AMI Response timeout: ",
tx_msg));
+ }
}
T.stop;
- return buf;
+ return rx_msg;
+
}
-function f_ami_wait_for_prompt(TELNETasp_PT pt, charstring log_label := "(?)")
return AMI_Msg {
- var charstring buf := f_ami_wait_for_prompt_str(pt, log_label);
- var AMI_Msg msg := dec_AMI_Msg(buf);
- return msg;
-}
-
-/* send a AMI command and obtain response until prompt is received */
-private function f_ami_transceive_ret_str(TELNETasp_PT pt, charstring tx)
return charstring {
- pt.send(tx);
- return f_ami_wait_for_prompt_str(pt, tx);
-}
-
-function f_ami_transceive_ret(TELNETasp_PT pt, template (value) AMI_Msg
tx_msg) return AMI_Msg {
- var charstring tx_txt := enc_AMI_Msg(valueof(tx_msg));
- var charstring resp_txt := f_ami_transceive_ret_str(pt, tx_txt);
- return dec_AMI_Msg(resp_txt);
-}
-
-function f_ami_transceive_match(TELNETasp_PT pt,
- template (value)
[M] Change in osmo-ttcn3-hacks[master]: asterisk: Initial steps to emulate IMS core
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36642?usp=email )
Change subject: asterisk: Initial steps to emulate IMS core
..
asterisk: Initial steps to emulate IMS core
Add the initial infrastructure to manage 2 SIPmsg_PT ports, one for the
local SIP UAs and one for the IMS core.
Still missing:
* Trigger Asterisk (through AMI) to do the initial connect + register to it
* Configure ipsec after Unauthorized response from IMS core
Change-Id: Ibbbadd54b7facf4ef7384499704e742f482a1252
---
M asterisk/Asterisk_Tests.default
M asterisk/Asterisk_Tests.ttcn
A asterisk/IMS_ConnectionHandler.ttcn
3 files changed, 145 insertions(+), 7 deletions(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/asterisk/Asterisk_Tests.default b/asterisk/Asterisk_Tests.default
index 0996545..622a5a9 100644
--- a/asterisk/Asterisk_Tests.default
+++ b/asterisk/Asterisk_Tests.default
@@ -4,7 +4,8 @@
mtc.FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;
[TESTPORT_PARAMETERS]
-*.*.DEBUG := "yes"
+#*.*.DEBUG := "yes"
+#*.*.debug := "enabled"
*.AMI.PROMPT1 := "Asterisk Call Manager/9.0.0\n"
*.AMI.PROMPT2 := "\n"
#*.AMI.REGEX_PROMPT1 := "^Asterisk Call Manager.*$"
@@ -16,11 +17,20 @@
*.AMI.CTRL_READMODE := "buffered"
*.AMI.CTRL_CLIENT_CLEANUP_LINEFEED := "yes"
*.AMI.CTRL_CRLF := "yes"
-*.SIP.local_sip_port := "5060"
-*.SIP.default_local_address := "127.0.0.2"
-*.SIP.default_sip_protocol := "UDP"
-*.SIP.default_dest_port := "5060"
-*.SIP.default_dest_address := "127.0.0.1"
+# Local SIP UAs:
+Asterisk_Tests_LOCAL_SIP_EMU.SIP.default_sip_protocol := "UDP";
+Asterisk_Tests_LOCAL_SIP_EMU.SIP.local_sip_port := "5060"
+Asterisk_Tests_LOCAL_SIP_EMU.SIP.default_local_address := "127.0.0.2"
+Asterisk_Tests_LOCAL_SIP_EMU.SIP.default_dest_port := "5060"
+Asterisk_Tests_LOCAL_SIP_EMU.SIP.default_dest_address := "127.0.0.1"
+# IMS Core:
+Asterisk_Tests_IMS_SIP_EMU.SIP.default_sip_protocol := "TCP";
+Asterisk_Tests_IMS_SIP_EMU.SIP.listen_enabled := "enabled";
+Asterisk_Tests_IMS_SIP_EMU.SIP.local_sip_port := "5060"
+Asterisk_Tests_IMS_SIP_EMU.SIP.default_local_address := "127.0.0.3"
+# Disabled for Server mode:
+#Asterisk_Tests_IMS_SIP_EMU.SIP.default_dest_address := "127.0.0.1"
+#Asterisk_Tests_IMS_SIP_EMU.SIP.default_dest_port := "5060"
[MODULE_PARAMETERS]
diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn
index caa941c..c94f97f 100644
--- a/asterisk/Asterisk_Tests.ttcn
+++ b/asterisk/Asterisk_Tests.ttcn
@@ -27,6 +27,7 @@
import from SIP_Templates all;
import from SIP_ConnectionHandler all;
+import from IMS_ConnectionHandler all;
modulepar {
charstring mp_local_sip_host := "127.0.0.2";
@@ -34,15 +35,24 @@
charstring mp_remote_sip_host := "127.0.0.1";
integer mp_remote_sip_port := 5060;
+ charstring mp_local_ims_host := "127.0.0.3";
+ integer mp_local_ims_port := 5060;
+
/* Asterisk AMI: */
charstring mp_ami_user := "test_user";
charstring mp_ami_secret := "1234";
}
type component test_CT {
+ /* Manages all local VoIP users Asterisk is serving: */
var SIP_Emulation_CT vc_SIP;
+ /* Manages the IMS server Asterisk connects to: */
+ var SIP_Emulation_CT vc_IMS;
+
port TELNETasp_PT AMI;
+
port Coord_PT COORD;
+ port IMSCoord_PT IMS_COORD;
}
const charstring broadcast_sip_extension := "0500";
@@ -64,9 +74,24 @@
f_ami_action_login(AMI, mp_ami_user, mp_ami_secret);
}
+/* Local SIP UAs */
+private function f_init_sip_local() runs on test_CT {
+ var charstring id := "Asterisk_Tests_LOCAL_SIP_EMU";
+ f_init_sip(vc_SIP, id);
+}
+
+/* IMS Server connection */
+private function f_init_sip_ims() runs on test_CT {
+ var charstring id := "Asterisk_Tests_IMS_SIP_EMU";
+ f_init_sip(vc_IMS, id);
+}
+
function f_init() runs on test_CT {
+ var charstring id;
+
f_init_ami();
- f_init_sip(vc_SIP, "Asterisk_Test_SIP_EMU");
+ f_init_sip_local();
+ f_init_sip_ims();
log("end of f_init");
}
diff --git a/asterisk/IMS_ConnectionHandler.ttcn
b/asterisk/IMS_ConnectionHandler.ttcn
new file mode 100644
index 000..a1baeb4
--- /dev/null
+++ b/asterisk/IMS_ConnectionHandler.ttcn
@@ -0,0 +1,88 @@
+/* Component implementing a IMS server towards Asterisk's IMS UE
+ * (C) 2024 by sysmocom - s.f.m.c. GmbH
+ * Author: Pau Espin Pedrol
+ * All rights reserved.
+ *
+ * Released under the terms of GNU General Public License, Version 2 or
+ * (at your option) any later version.
+ *
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+module IMS_ConnectionHandler {
+
+import from TCCOpenSecurity_Functions all;
+import from General_Types all;
+import from Osmocom_Types all;
+import from
[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: tr_SIP_REGISTER(): Pass via field directly as a param
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36644?usp=email )
Change subject: SIP_Templates: tr_SIP_REGISTER(): Pass via field directly as a
param
..
SIP_Templates: tr_SIP_REGISTER(): Pass via field directly as a param
Similar to other templates which already required it.
There's no user of this template (yet).
Change-Id: I9fe477370e028543b04dee35a3285ddae6bb2c59
---
M library/SIP_Templates.ttcn
1 file changed, 14 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
osmith: Looks good to me, but someone else must approve
diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn
index e115bb7..3492dc4 100644
--- a/library/SIP_Templates.ttcn
+++ b/library/SIP_Templates.ttcn
@@ -572,14 +572,14 @@
template (present) CallidString call_id := ?,
template (present) SipAddr from_addr := ?,
template (present) SipAddr to_addr := ?,
+ template (present) Via via :=
tr_Via_from(f_tr_HostPort_opt_defport(?)),
template integer seq_nr := *,
template Contact contact := *,
template Expires expires := *,
template charstring body := *) := {
requestLine := tr_SIP_ReqLine(REGISTER_E, sip_url_host_port),
msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, contact,
-
tr_Via_from(f_tr_HostPort_opt_defport(from_addr.addr.nameAddr.addrSpec.hostPort)),
-"REGISTER", *, seq_nr,
+via, "REGISTER", *, seq_nr,
expires := expires),
messageBody := body,
payload := omit
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36644?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9fe477370e028543b04dee35a3285ddae6bb2c59
Gerrit-Change-Number: 36644
Gerrit-PatchSet: 2
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[S] Change in osmo-ttcn3-hacks[master]: SIP_Emulation: Rename component id
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641?usp=email )
Change subject: SIP_Emulation: Rename component id
..
SIP_Emulation: Rename component id
Remove the dash character, since it makes it impossible to reference the
component name under TESTPORT_PARAMETERS in .default/.cfg files.
While at it, actually, allow the test to provide a full id instead of
always appending the suffix to it. This provides more freedom on the
testsuite to provide a fitting component name.
Change-Id: Iecefe7d98a5842872f1efc55e013f672186ef1a8
---
M asterisk/Asterisk_Tests.ttcn
M library/SIP_Emulation.ttcn
M sip/SIP_Tests.ttcn
3 files changed, 19 insertions(+), 5 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
Jenkins Builder: Verified
pespin: Looks good to me, approved
osmith: Looks good to me, but someone else must approve
diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn
index b164ee5..caa941c 100644
--- a/asterisk/Asterisk_Tests.ttcn
+++ b/asterisk/Asterisk_Tests.ttcn
@@ -66,7 +66,7 @@
function f_init() runs on test_CT {
f_init_ami();
- f_init_sip(vc_SIP, "Asterisk_Test");
+ f_init_sip(vc_SIP, "Asterisk_Test_SIP_EMU");
log("end of f_init");
}
diff --git a/library/SIP_Emulation.ttcn b/library/SIP_Emulation.ttcn
index 1b357b7..a5ebcfb 100644
--- a/library/SIP_Emulation.ttcn
+++ b/library/SIP_Emulation.ttcn
@@ -226,9 +226,7 @@
SipCreateCallback create_cb
};
-function f_init_sip(inout SIP_Emulation_CT ct, charstring id) {
- id := id & "-SIP";
-
+function f_init_sip(inout SIP_Emulation_CT ct, charstring id := "SIP_EMU") {
var SipOps ops := {
create_cb := refers(SIP_Emulation.ExpectedCreateCallback)
};
diff --git a/sip/SIP_Tests.ttcn b/sip/SIP_Tests.ttcn
index 95f09e8..5899311 100644
--- a/sip/SIP_Tests.ttcn
+++ b/sip/SIP_Tests.ttcn
@@ -131,7 +131,7 @@
//f_ipa_ctrl_start_client(mp_osmosip_host, mp_osmosip_port_ctrl);
f_init_mncc("SIP_Test");
log("end of f_init_mncc");
- f_init_sip(vc_SIP, "SIP_Test");
+ f_init_sip(vc_SIP, "SIP_Test_SIP_EMU");
log("end of f_init_sip");
map(self:SIPVTY, system:SIPVTY);
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iecefe7d98a5842872f1efc55e013f672186ef1a8
Gerrit-Change-Number: 36641
Gerrit-PatchSet: 2
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-CC: fixeria
Gerrit-MessageType: merged
[M] Change in osmo-ttcn3-hacks[master]: asterisk: Initial steps to emulate IMS core
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36642?usp=email ) Change subject: asterisk: Initial steps to emulate IMS core .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36642?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibbbadd54b7facf4ef7384499704e742f482a1252 Gerrit-Change-Number: 36642 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Tue, 07 May 2024 14:48:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: SIP_Emulation: Rename component id
Attention is currently required from: fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641?usp=email ) Change subject: SIP_Emulation: Rename component id .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iecefe7d98a5842872f1efc55e013f672186ef1a8 Gerrit-Change-Number: 36641 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: osmith Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 07 May 2024 14:48:39 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-sgsn[master]: VTY: sync default UMTS UEA config with osmo-msc
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/36702?usp=email ) Change subject: VTY: sync default UMTS UEA config with osmo-msc .. Patch Set 1: (1 comment) Patchset: PS1: so iiuc this patch is actually enabling EUA1 and EUA2 and removing EUA2 when default config is used? -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/36702?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4eb9451b4267fc1436ed90a55ff200cf36f16bf6 Gerrit-Change-Number: 36702 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 07 May 2024 14:43:32 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in osmo-sgsn[master]: VTY: move default settings to sgsn_instance_alloc()
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/36701?usp=email ) Change subject: VTY: move default settings to sgsn_instance_alloc() .. Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I agree the related ticket looks wrong, so convert it to +2 when you fix it :) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/36701?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I1a439dcc76272a181986b6ec9368ef16441dc098 Gerrit-Change-Number: 36701 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: osmith Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 07 May 2024 14:42:06 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: fix request sending in f_http_tx_request
Attention is currently required from: dexter, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36710?usp=email ) Change subject: HTTP_Adapter: fix request sending in f_http_tx_request .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36710?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I258ee6209c35d0601f5a4d82423d2f5c6fbb03cc Gerrit-Change-Number: 36710 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: dexter Gerrit-Comment-Date: Tue, 07 May 2024 14:39:50 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-bts[master]: osmo-bts-{trx,virtual}: do not advertise TCH/F14.4 NT
Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/36709?usp=email )
Change subject: osmo-bts-{trx,virtual}: do not advertise TCH/F14.4 NT
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36709?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I8a068162400c8efb194f2a169a67ee6ea5f081ca
Gerrit-Change-Number: 36709
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Attention: fixeria
Gerrit-Comment-Date: Tue, 07 May 2024 14:38:49 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
[S] Change in osmo-bts[master]: rsl.adoc: document RSL_IE_OSMO_RTP_EXTENSIONS
Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36706?usp=email ) Change subject: rsl.adoc: document RSL_IE_OSMO_RTP_EXTENSIONS .. Patch Set 1: (3 comments) File doc/manuals/abis/rsl.adoc: https://gerrit.osmocom.org/c/osmo-bts/+/36706/comment/b3a1fc10_e11a4850 PS1, Line 872: | 0x62 | RSL_IE_OSMO_TEMP_OVP_ACCH_CAP | <> These 2 above seem to actually be missing but not really related to this patch, so perhaps submit them separately as a pre-patch we can merge straight away? https://gerrit.osmocom.org/c/osmo-bts/+/36706/comment/65b38eb1_4f36bb66 PS1, Line 1097: [[RSL_IE_OSMO_TEMP_OVP_ACCH_CAP]] Same for these 2 above. https://gerrit.osmocom.org/c/osmo-bts/+/36706/comment/a2ec53dd_03aea77b PS1, Line 1110: This information element requests the use of non-standard enhanced RTP I'm maybe missing some sort of packetdiag output (see for instance packetdiag examples in ./osmo-bsc/doc/manuals/osmux-reference.adoc), or at least a table here (see eg. line 1084). I think this is imporant since this field seems to be a TLV which may be extended later, so I'm not really sure what's the idea here. Is it for now a bitmask? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6117049b17ced5fb6635ac70d9238169033af4de Gerrit-Change-Number: 36706 Gerrit-PatchSet: 1 Gerrit-Owner: falconia Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: falconia Gerrit-Comment-Date: Tue, 07 May 2024 14:34:45 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in osmo-hnbgw[master]: jenkins.sh: add NFTABLES axis
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36537?usp=email ) Change subject: jenkins.sh: add NFTABLES axis .. Patch Set 4: (1 comment) Patchset: PS4: We can probably cherry-pick/rebase this one on top of master and get it merged already? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36537?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I331cce7b187cf427a5cbffb3aedb17054918bcc8 Gerrit-Change-Number: 36537 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Comment-Date: Tue, 07 May 2024 14:24:59 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in osmo-hnbgw[master]: jenkins.sh: add NFTABLES axis
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36537?usp=email ) Change subject: jenkins.sh: add NFTABLES axis .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36537?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I331cce7b187cf427a5cbffb3aedb17054918bcc8 Gerrit-Change-Number: 36537 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Comment-Date: Tue, 07 May 2024 14:24:19 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-hnodeb[master]: .deb/.rpm: various fixes related to non-root
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/36661?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/36661?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6dd0205fb65d4ad5a79821c111865e67fb293a73 Gerrit-Change-Number: 36661 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Tue, 07 May 2024 14:23:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-cbc[master]: .deb/.rpm: various fixes related to non-root
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/36658?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/36658?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I6dd0205fb65d4ad5a79821c111865e67fb293a73 Gerrit-Change-Number: 36658 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Tue, 07 May 2024 14:22:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in libosmo-sccp[master]: .deb/.rpm: various fixes related to non-root
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36656?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36656?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ie34e7aa65e576cf1742a33530a6f44d2344c39d0 Gerrit-Change-Number: 36656 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Tue, 07 May 2024 14:22:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-bsc[master]: .deb/.rpm: various fixes related to non-root
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36657?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36657?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie34e7aa65e576cf1742a33530a6f44d2344c39d0 Gerrit-Change-Number: 36657 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Tue, 07 May 2024 14:22:07 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-msc[master]: .deb/.rpm: various fixes related to non-root
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36662?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36662?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I406ff0d625b02991d580c8382aa4be04dba45a00 Gerrit-Change-Number: 36662 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Tue, 07 May 2024 14:21:51 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-smlc[master]: .deb/.rpm: various fixes related to non-root
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/36665?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/36665?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Ib129217f6aff713d1d0e7aa831b4b54823e9bade Gerrit-Change-Number: 36665 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Tue, 07 May 2024 14:21:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ci[master]: ansible/setup-jenkins: install rsync
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36667?usp=email ) Change subject: ansible/setup-jenkins: install rsync .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36667?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic8ffd61fc2c89574085e9c3abbceb554f3c5da6a Gerrit-Change-Number: 36667 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Tue, 07 May 2024 14:20:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-hlr[master]: .deb/.rpm: various fixes related to non-root
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/36659?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/36659?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ib20406dd253f5e8720552e92e9002e45591218fa Gerrit-Change-Number: 36659 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Tue, 07 May 2024 14:20:42 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-sgsn[master]: .deb/.rpm: various fixes related to non-root
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/36663?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/36663?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I406ff0d625b02991d580c8382aa4be04dba45a00 Gerrit-Change-Number: 36663 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Tue, 07 May 2024 14:19:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ci[master]: ttcn3-bsc-test-io_uring: limit jenkins nodes again
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36668?usp=email ) Change subject: ttcn3-bsc-test-io_uring: limit jenkins nodes again .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36668?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iddf2d47a641998860fd1ef615de976104667c5ab Gerrit-Change-Number: 36668 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Tue, 07 May 2024 14:17:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-sgsn[master]: VTY: sync default UMTS UEA config with osmo-msc
Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/36702?usp=email ) Change subject: VTY: sync default UMTS UEA config with osmo-msc .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/36702?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4eb9451b4267fc1436ed90a55ff200cf36f16bf6 Gerrit-Change-Number: 36702 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 07 May 2024 13:11:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-sgsn[master]: VTY: move default settings to sgsn_instance_alloc()
Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/36701?usp=email ) Change subject: VTY: move default settings to sgsn_instance_alloc() .. Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/36701/comment/1b398318_1ba07913 PS1, Line 10: Related: OS#6443 * wrong issue number? * explaining why this is done would be useful :) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/36701?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I1a439dcc76272a181986b6ec9368ef16441dc098 Gerrit-Change-Number: 36701 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: osmith Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 07 May 2024 13:09:57 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: fix request sending in f_http_tx_request
dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36710?usp=email )
Change subject: HTTP_Adapter: fix request sending in f_http_tx_request
..
HTTP_Adapter: fix request sending in f_http_tx_request
The function f_http_tx_request has two parameters to spcifiy the body
part of the HTTP request (body and binary_body). The function only
sends a request when either body or binary_body is populated, but not
when none of the two is populated. This means requests without body
part (e.g. a GET request) can not be sent.
There is also no proper interlocking between body and binary_body. We
should make sure that this situation does not occur.
Related: SYS#6824
Change-Id: I258ee6209c35d0601f5a4d82423d2f5c6fbb03cc
---
M library/HTTP_Adapter.ttcn
1 file changed, 29 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/10/36710/1
diff --git a/library/HTTP_Adapter.ttcn b/library/HTTP_Adapter.ttcn
index f408ee4..97233e5 100644
--- a/library/HTTP_Adapter.ttcn
+++ b/library/HTTP_Adapter.ttcn
@@ -205,13 +205,21 @@
use_client_id := client_id;
}
- if (not istemplatekind(body, "omit")) {
+ if (not istemplatekind(body, "omit") and istemplatekind(binary_body,
"omit")) {
+ /* HTTP message with ASCII content */
HTTP.send(ts_HTTP_Req(url, method, body, host :=
g_pars.http_host & ":" & int2str(g_pars.http_port),
custom_hdr := custom_hdr, client_id :=
use_client_id));
- } else if (not istemplatekind(binary_body, "omit")) {
+ } else if (not istemplatekind(binary_body, "omit") and
istemplatekind(body, "omit")) {
+ /* HTTP message with binary content */
HTTP.send(ts_HTTP_Req_Bin(url, method, binary_body,
host := g_pars.http_host & ":" &
int2str(g_pars.http_port),
custom_hdr := custom_hdr, client_id
:= use_client_id));
+ } else if (istemplatekind(binary_body, "omit") and istemplatekind(body,
"omit")) {
+ /* HTTP message without content (e.g. a GET request) */
+ HTTP.send(ts_HTTP_Req(url, method, host := g_pars.http_host &
":" & int2str(g_pars.http_port),
+ custom_hdr := custom_hdr, client_id :=
use_client_id));
+ } else {
+ setverdict(fail, "either binary_body or body must be used (a
request can contain either ASCII data or binary data, not both!");
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36710?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I258ee6209c35d0601f5a4d82423d2f5c6fbb03cc
Gerrit-Change-Number: 36710
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-MessageType: newchange
[S] Change in osmo-sgsn[master]: VTY: sync default UMTS UEA config with osmo-msc
Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/36702?usp=email ) Change subject: VTY: sync default UMTS UEA config with osmo-msc .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/36702?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4eb9451b4267fc1436ed90a55ff200cf36f16bf6 Gerrit-Change-Number: 36702 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 07 May 2024 12:04:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-bts[master]: osmo-bts-{trx,virtual}: do not advertise TCH/F14.4 NT
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bts/+/36709?usp=email )
Change subject: osmo-bts-{trx,virtual}: do not advertise TCH/F14.4 NT
..
osmo-bts-{trx,virtual}: do not advertise TCH/F14.4 NT
This mode is currently not supported.
Change-Id: I8a068162400c8efb194f2a169a67ee6ea5f081ca
Related: OS#6167
---
M src/osmo-bts-trx/main.c
M src/osmo-bts-virtual/main.c
2 files changed, 16 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/09/36709/1
diff --git a/src/osmo-bts-trx/main.c b/src/osmo-bts-trx/main.c
index 9809e6c..ddc4428 100644
--- a/src/osmo-bts-trx/main.c
+++ b/src/osmo-bts-trx/main.c
@@ -196,8 +196,9 @@
trx->support.chan_modes = NM_IPAC_MASK_CHANM_SPEECH
| NM_IPAC_MASK_CHANM_CSD_NT
| NM_IPAC_MASK_CHANM_CSD_T;
- /* TODO: NM_IPAC_F_CHANM_CSD_T_14k4 (see OS#6167) */
+ /* TODO: missing rate adaptation for TCH/F14.4 (see OS#6167) */
trx->support.chan_modes &= ~NM_IPAC_F_CHANM_CSD_T_14k4;
+ trx->support.chan_modes &= ~NM_IPAC_F_CHANM_CSD_NT_14k4;
/* The nominal value for each TRX is later overwritten through VTY cmd
* 'nominal-tx-power' if present, otherwise through TRXC cmd NOMTXPOWER.
diff --git a/src/osmo-bts-virtual/main.c b/src/osmo-bts-virtual/main.c
index 367d923..82becc3 100644
--- a/src/osmo-bts-virtual/main.c
+++ b/src/osmo-bts-virtual/main.c
@@ -99,8 +99,9 @@
trx->support.chan_modes = NM_IPAC_MASK_CHANM_SPEECH
| NM_IPAC_MASK_CHANM_CSD_NT
| NM_IPAC_MASK_CHANM_CSD_T;
- /* TODO: NM_IPAC_F_CHANM_CSD_T_14k4 (see OS#6167) */
+ /* TODO: missing rate adaptation for TCH/F14.4 (see OS#6167) */
trx->support.chan_modes &= ~NM_IPAC_F_CHANM_CSD_T_14k4;
+ trx->support.chan_modes &= ~NM_IPAC_F_CHANM_CSD_NT_14k4;
return 0;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36709?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I8a068162400c8efb194f2a169a67ee6ea5f081ca
Gerrit-Change-Number: 36709
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
[S] Change in osmo-trx[master]: transceiver: use log level cache
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36386?usp=email ) Change subject: transceiver: use log level cache .. transceiver: use log level cache This uses the newly added log level caching in libosmocore, which prevents lock contention during the massive amount of usually disabled but concurrent (threads) log statements. Depends: libosmocore.git I539872fc9e3c50b407e6bc388f1e091fa2c826c3 Change-Id: Ic9f0e81c89827f2696ce046a3396f041703d6ae5 --- M TODO-RELEASE M Transceiver52M/osmo-trx.cpp 2 files changed, 16 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index e69de29..1011784 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -0,0 +1 @@ +libosmocore > 1.9.2 requires log_cache_enable call diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp index 8f5cc85..c460e98 100644 --- a/Transceiver52M/osmo-trx.cpp +++ b/Transceiver52M/osmo-trx.cpp @@ -645,6 +645,7 @@ osmo_init_logging2(tall_trx_ctx, _info); log_enable_multithread(); + log_cache_enable(); osmo_stats_init(tall_trx_ctx); vty_init(_vty_info); logging_vty_add_cmds(); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ic9f0e81c89827f2696ce046a3396f041703d6ae5 Gerrit-Change-Number: 36386 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: merged
[S] Change in osmo-trx[master]: transceiver: use log level cache
Attention is currently required from: Hoernchen. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36386?usp=email ) Change subject: transceiver: use log level cache .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ic9f0e81c89827f2696ce046a3396f041703d6ae5 Gerrit-Change-Number: 36386 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Attention: Hoernchen Gerrit-Comment-Date: Tue, 07 May 2024 11:51:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ci[master]: jobs/update-osmo-python: remove build3
Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36708?usp=email ) Change subject: jobs/update-osmo-python: remove build3 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36708?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idba77a3b9595c234ee21dfd1d0e267021a17bb03 Gerrit-Change-Number: 36708 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: osmith Gerrit-Comment-Date: Tue, 07 May 2024 11:50:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ci[master]: jobs/update-osmo-python: remove build3
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36708?usp=email ) Change subject: jobs/update-osmo-python: remove build3 .. jobs/update-osmo-python: remove build3 build3 does not exist anymore, but it was still referenced here, leading to the job waiting forever until build3 comes online. Related: OS#6186 Change-Id: Idba77a3b9595c234ee21dfd1d0e267021a17bb03 --- M jobs/update-osmo-python-on-slaves.yml 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/jobs/update-osmo-python-on-slaves.yml b/jobs/update-osmo-python-on-slaves.yml index 0842fba..fad1cf6 100644 --- a/jobs/update-osmo-python-on-slaves.yml +++ b/jobs/update-osmo-python-on-slaves.yml @@ -8,7 +8,6 @@ values: - build2-deb10build-ansible - build2-deb11build-ansible -- build3-deb11build-ansible - build4-deb12build-ansible - host2-deb11build-ansible - rpi4-raspbian11build-ansible-1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36708?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idba77a3b9595c234ee21dfd1d0e267021a17bb03 Gerrit-Change-Number: 36708 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
[S] Change in osmo-ci[master]: jobs/update-osmo-python: remove build3
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/36708?usp=email ) Change subject: jobs/update-osmo-python: remove build3 .. jobs/update-osmo-python: remove build3 build3 does not exist anymore, but it was still referenced here, leading to the job waiting forever until build3 comes online. Related: OS#6186 Change-Id: Idba77a3b9595c234ee21dfd1d0e267021a17bb03 --- M jobs/update-osmo-python-on-slaves.yml 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/08/36708/1 diff --git a/jobs/update-osmo-python-on-slaves.yml b/jobs/update-osmo-python-on-slaves.yml index 0842fba..fad1cf6 100644 --- a/jobs/update-osmo-python-on-slaves.yml +++ b/jobs/update-osmo-python-on-slaves.yml @@ -8,7 +8,6 @@ values: - build2-deb10build-ansible - build2-deb11build-ansible -- build3-deb11build-ansible - build4-deb12build-ansible - host2-deb11build-ansible - rpi4-raspbian11build-ansible-1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36708?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idba77a3b9595c234ee21dfd1d0e267021a17bb03 Gerrit-Change-Number: 36708 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
[S] Change in osmo-trx[master]: transceiver: use log level cache
Attention is currently required from: Hoernchen, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36386?usp=email ) Change subject: transceiver: use log level cache .. Patch Set 2: Code-Review+1 (1 comment) Patchset: PS1: > Ack Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ic9f0e81c89827f2696ce046a3396f041703d6ae5 Gerrit-Change-Number: 36386 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Attention: Hoernchen Gerrit-Attention: laforge Gerrit-Comment-Date: Tue, 07 May 2024 08:02:59 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
[S] Change in osmo-trx[master]: transceiver: use log level cache
Attention is currently required from: Hoernchen, fixeria, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/36386?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: transceiver: use log level cache .. transceiver: use log level cache This uses the newly added log level caching in libosmocore, which prevents lock contention during the massive amount of usually disabled but concurrent (threads) log statements. Depends: libosmocore.git I539872fc9e3c50b407e6bc388f1e091fa2c826c3 Change-Id: Ic9f0e81c89827f2696ce046a3396f041703d6ae5 --- M TODO-RELEASE M Transceiver52M/osmo-trx.cpp 2 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/86/36386/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ic9f0e81c89827f2696ce046a3396f041703d6ae5 Gerrit-Change-Number: 36386 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Attention: Hoernchen Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-MessageType: newpatchset
