[L] Change in osmo-ttcn3-hacks[master]: DIAMETER_Types: Generate types for 3GPP TS 29.273

2024-03-05 Thread fixeria
Attention is currently required from: pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162?usp=email )

Change subject: DIAMETER_Types: Generate types for 3GPP TS 29.273
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I17f7f025ff31d9ce619cd23bfa5f1af282969dbf
Gerrit-Change-Number: 36162
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Tue, 05 Mar 2024 18:15:24 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


[L] Change in osmo-ttcn3-hacks[master]: DIAMETER_Types: Generate types for 3GPP TS 29.273

2024-03-05 Thread laforge
Attention is currently required from: pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162?usp=email )

Change subject: DIAMETER_Types: Generate types for 3GPP TS 29.273
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I17f7f025ff31d9ce619cd23bfa5f1af282969dbf
Gerrit-Change-Number: 36162
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Tue, 05 Mar 2024 14:09:24 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


[L] Change in osmo-ttcn3-hacks[master]: DIAMETER_Types: Generate types for 3GPP TS 29.273

2024-03-05 Thread pespin
Attention is currently required from: pespin.

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162?usp=email

to look at the new patch set (#4).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder


Change subject: DIAMETER_Types: Generate types for 3GPP TS 29.273
..

DIAMETER_Types: Generate types for 3GPP TS 29.273

The ddf file is added at the end of the list since it depends on tons of
other RFC and 3GGP TS specs, see for instance TS 29.372 Table 8.2.3.0.

Change-Id: I17f7f025ff31d9ce619cd23bfa5f1af282969dbf
---
M library/DIAMETER_Types.ttcn
M library/regen-DIAMETER_Types_ttcn.sh
2 files changed, 445 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/62/36162/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I17f7f025ff31d9ce619cd23bfa5f1af282969dbf
Gerrit-Change-Number: 36162
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset


[L] Change in osmo-ttcn3-hacks[master]: DIAMETER_Types: Generate types for 3GPP TS 29.273

2024-03-05 Thread Jenkins Builder
Attention is currently required from: pespin.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162?usp=email )

Change subject: DIAMETER_Types: Generate types for 3GPP TS 29.273
..


Patch Set 2:

(36 comments)

File library/DIAMETER_Types.ttcn:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/e195df18_3f29a13b 
PS2, Line 2387: // Dependant applications
'Dependant' may be misspelled - perhaps 'Dependent'?


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/afe15e86_2065ecc4
PS2, Line 2399: type AVP_Grouped AAA_3GPP_Non_3GPP_User_Data
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/85d27377_9ab96daf
PS2, Line 2436: type AVP_UTF8String AAA_3GPP_ANID
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/46e9d5ed_5aa134fd
PS2, Line 2440: type AVP_Grouped AAA_3GPP_Trace_Info
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/5a69ee20_0535fba7
PS2, Line 2444: type AVP_OctetString AAA_3GPP_MIP_FA_RK
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/a0d1bb65_4e31e901
PS2, Line 2448: type AVP_Unsigned32 AAA_3GPP_MIP_FA_RK_SPI
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/2bf8288f_e2e6ffa3
PS2, Line 2452: type AVP_Unsigned32 AAA_3GPP_PPR_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/f28f145d_2739a0bb
PS2, Line 2456: type AVP_Grouped AAA_3GPP_WLAN_Identifier
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/09135bb1_70da4f3d
PS2, Line 2460: type AVP_Grouped AAA_3GPP_TWAN_Access_Info
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/8078937c_78072de9
PS2, Line 2464: type AVP_Unsigned32 AAA_3GPP_Access_Authorization_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/0d820c90_c76d1a3b
PS2, Line 2468: type AVP_Unsigned32 AAA_3GPP_TWAN_Default_APN_Context_Id
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/88e61c3a_2dacc328
PS2, Line 2482: type AVP_OctetString AAA_3GPP_Full_Network_Name
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/2639f06b_bd99e3ee
PS2, Line 2486: type AVP_OctetString AAA_3GPP_Short_Network_Name
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/4333bfe2_2001736d
PS2, Line 2490: type AVP_Unsigned32 AAA_3GPP_AAA_Failure_Indication
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/c42f219f_1accb0aa
PS2, Line 2504: type AVP_Unsigned32 AAA_3GPP_DER_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/ad1011e4_434e3818
PS2, Line 2508: type AVP_Unsigned32 AAA_3GPP_DEA_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/e8d1aa3e_baa8b0f1
PS2, Line 2512: type AVP_Unsigned32 AAA_3GPP_RAR_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/48c9cf2b_d8ed1ee6
PS2, Line 2516: type AVP_Unsigned32 AAA_3GPP_DER_S6b_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/a3b808be_fd86ca5c
PS2, Line 2520: type AVP_UTF8String AAA_3GPP_SSID
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/6ed15b6d_21d67d0d
PS2, Line 2524: type AVP_UTF8String AAA_3GPP_HESSID
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):

[L] Change in osmo-ttcn3-hacks[master]: DIAMETER_Types: Generate types for 3GPP TS 29.273

2024-03-05 Thread pespin
Attention is currently required from: pespin.

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder


Change subject: DIAMETER_Types: Generate types for 3GPP TS 29.273
..

DIAMETER_Types: Generate types for 3GPP TS 29.273

Change-Id: I17f7f025ff31d9ce619cd23bfa5f1af282969dbf
---
M library/DIAMETER_Types.ttcn
M library/regen-DIAMETER_Types_ttcn.sh
2 files changed, 547 insertions(+), 108 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/62/36162/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I17f7f025ff31d9ce619cd23bfa5f1af282969dbf
Gerrit-Change-Number: 36162
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset


[L] Change in osmo-ttcn3-hacks[master]: DIAMETER_Types: Generate types for 3GPP TS 29.273

2024-03-05 Thread Jenkins Builder
Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162?usp=email )

Change subject: DIAMETER_Types: Generate types for 3GPP TS 29.273
..


Patch Set 1:

(36 comments)

File library/DIAMETER_Types.ttcn:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/40468ccd_49762597
PS1, Line 1821: // Dependant applications
'Dependant' may be misspelled - perhaps 'Dependent'?


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/8d113e68_4552c4f1
PS1, Line 1832: type AVP_Grouped AAA_3GPP_Non_3GPP_User_Data
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/e07425e6_6ddead09
PS1, Line 1869: type AVP_UTF8String AAA_3GPP_ANID
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/6a1a2272_e926d8e6
PS1, Line 1873: type AVP_Grouped AAA_3GPP_Trace_Info
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/08b7bc4d_cf0d880d
PS1, Line 1877: type AVP_OctetString AAA_3GPP_MIP_FA_RK
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/21005e2d_a6a2dd9b
PS1, Line 1881: type AVP_Unsigned32 AAA_3GPP_MIP_FA_RK_SPI
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/d40df8ed_b394320f 
PS1, Line 1885: type AVP_Unsigned32 AAA_3GPP_PPR_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/e23d9418_09fed780
PS1, Line 1889: type AVP_Grouped AAA_3GPP_WLAN_Identifier
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/14c5d19d_f80614fa
PS1, Line 1893: type AVP_Grouped AAA_3GPP_TWAN_Access_Info
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/bd595ba2_d0e7c959
PS1, Line 1897: type AVP_Unsigned32 AAA_3GPP_Access_Authorization_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/c177361e_f635be18
PS1, Line 1901: type AVP_Unsigned32 AAA_3GPP_TWAN_Default_APN_Context_Id
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/87abfb17_ce9a1212
PS1, Line 1915: type AVP_OctetString AAA_3GPP_Full_Network_Name
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/67ebde4f_a3626979 
PS1, Line 1919: type AVP_OctetString AAA_3GPP_Short_Network_Name
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/273b763b_52bcc352
PS1, Line 1923: type AVP_Unsigned32 AAA_3GPP_AAA_Failure_Indication
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/27e14ff3_33edb0d7
PS1, Line 1937: type AVP_Unsigned32 AAA_3GPP_DER_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/38282507_204bbc45
PS1, Line 1941: type AVP_Unsigned32 AAA_3GPP_DEA_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/f6bf5465_5e500075
PS1, Line 1945: type AVP_Unsigned32 AAA_3GPP_RAR_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/414d75cb_415be9b2
PS1, Line 1949: type AVP_Unsigned32 AAA_3GPP_DER_S6b_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/1fa43b5b_01126e52
PS1, Line 1953: type AVP_UTF8String AAA_3GPP_SSID
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/9c84c94e_c62557c8
PS1, Line 1957: type AVP_UTF8String AAA_3GPP_HESSID
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):