[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst

2023-10-30 Thread arehbein 
arehbein has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )

Change subject: gsmtap: Hide implementation of gsmtap_inst
..


Patch Set 5:

(1 comment)

Patchset:

PS5:
> osmo-remsim: create a TODO-RELEASE file if it exists. […]
I have uploaded https://gerrit.osmocom.org/c/osmo-remsim/+/34919 for 
osmo-remsim.

@lafo...@osmocom.org I suppose "you don't need to worry" means that I don't 
have to upload any changes at all for osmocom-bb as well as simtrace2?
Just checking because simtrace2.git:host/lib/gsmtap.c contains a call to 
`gsmtap_inst_fd()` and host code does make use of system libosmocore



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 30 Oct 2023 11:26:03 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein 
Comment-In-Reply-To: laforge 
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst

2023-10-16 Thread laforge 
Attention is currently required from: arehbein.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )

Change subject: gsmtap: Hide implementation of gsmtap_inst
..


Patch Set 5:

(1 comment)

Patchset:

PS5:
> I grepped through the repos and only three are using `gsmtap_isnt_fd()`: […]
osmo-remsim: create a TODO-RELEASE file if it exists.  for the 
firmware-lbiosmocore (osmoocm-bb/simtrace2) you don't need to worry.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: arehbein 
Gerrit-Comment-Date: Mon, 16 Oct 2023 15:21:03 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein 
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst

2023-10-16 Thread arehbein 
arehbein has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )

Change subject: gsmtap: Hide implementation of gsmtap_inst
..


Patch Set 5:

(1 comment)

Patchset:

PS5:
> Alright, will keep that in mind
I grepped through the repos and only three are using `gsmtap_isnt_fd()`:

osmo-remsim: Doesn't have a TODO-RELEASE file. Are there any similar files to 
edit?

osmocom-bb: Seems to have fixed its own version of libosmocore, not sure if 
there's anything to do here now.

simtrace2: Similar to osmocom-bb.

Currently, I have a patch for only osmo-remsim sitting locally, because I'm not 
sure how to proceed.
How do I best go about this?



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Oct 2023 14:47:19 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein 
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst

2023-10-16 Thread arehbein 
arehbein has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )

Change subject: gsmtap: Hide implementation of gsmtap_inst
..

gsmtap: Hide implementation of gsmtap_inst

 - Use forward decl. of struct gsmtap_inst in header
 - Remove 'static inline' attributes from gsmtap_inst_fd() declaration,
   move function definition to gsmtap_util.c and mark it as deprecated
 - Add gsmtap_inst_fd2() as replacement for gsmtap_inst_fd()

Related: OS#6213
Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
---
M TODO-RELEASE
M include/osmocom/core/gsmtap_util.h
M src/core/gsmtap_util.c
M src/core/libosmocore.map
4 files changed, 48 insertions(+), 15 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  Jenkins Builder: Verified
  arehbein: Looks good to me, approved
  pespin: Looks good to me, approved




diff --git a/TODO-RELEASE b/TODO-RELEASE
index 2f9903d..b67161d 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -7,4 +7,5 @@
 # If any interfaces have been added since the last public release: c:r:a + 1.
 # If any interfaces have been removed or changed since the last public 
release: c:r:0.
 #library   whatdescription / commit summary line
-core  ADD   osmo_sock_multiaddr_{add,del}_local_addr()
\ No newline at end of file
+core  ADD   osmo_sock_multiaddr_{add,del}_local_addr()
+core  ADD   gsmtap_inst_fd2() core, DEPRECATE gsmtap_inst_fd()
diff --git a/include/osmocom/core/gsmtap_util.h 
b/include/osmocom/core/gsmtap_util.h
index 9137c1d..d24ee95 100644
--- a/include/osmocom/core/gsmtap_util.h
+++ b/include/osmocom/core/gsmtap_util.h
@@ -24,19 +24,12 @@
int8_t snr, const uint8_t *data, unsigned int len);

 /*! one gsmtap instance */
-struct gsmtap_inst {
-   int ofd_wq_mode;/*!< wait queue mode? */
-   struct osmo_wqueue wq;  /*!< the wait queue */
-   struct osmo_fd sink_ofd;/*!< file descriptor */
-};
+struct gsmtap_inst;

-/*! obtain the file descriptor associated with a gsmtap instance
- *  \param[in] gti GSMTAP instance
- *  \returns file descriptor of GSMTAP instance */
-static inline int gsmtap_inst_fd(struct gsmtap_inst *gti)
-{
-   return gti->wq.bfd.fd;
-}
+int gsmtap_inst_fd(struct gsmtap_inst *gti)
+   OSMO_DEPRECATED("Use gsmtap_inst_fd2() instead");
+
+int gsmtap_inst_fd2(const struct gsmtap_inst *gti);

 int gsmtap_source_init_fd(const char *host, uint16_t port);
 int gsmtap_source_init_fd2(const char *local_host, uint16_t local_port, const 
char *rem_host, uint16_t rem_port);
diff --git a/src/core/gsmtap_util.c b/src/core/gsmtap_util.c
index 20c0ce1..dcbd304 100644
--- a/src/core/gsmtap_util.c
+++ b/src/core/gsmtap_util.c
@@ -46,6 +46,28 @@
  *
  * \file gsmtap_util.c */

+/*! one gsmtap instance */
+struct gsmtap_inst {
+   int ofd_wq_mode;/*!< wait queue mode? This field member may not 
be changed or moved (backwards compatibility) */
+   struct osmo_wqueue wq;  /*!< the wait queue. This field member may not 
be changed or moved (backwards compatibility) */
+   struct osmo_fd sink_ofd; /*!< file descriptor */
+};
+
+/*! Deprecated, use gsmtap_inst_fd2() instead
+ *  \param[in] gti GSMTAP instance
+ *  \returns file descriptor of GSMTAP instance */
+int gsmtap_inst_fd(struct gsmtap_inst *gti)
+{
+   return gsmtap_inst_fd2(gti);
+}
+
+/*! obtain the file descriptor associated with a gsmtap instance
+ *  \param[in] gti GSMTAP instance
+ *  \returns file descriptor of GSMTAP instance */
+int gsmtap_inst_fd2(const struct gsmtap_inst *gti)
+{
+   return gti->wq.bfd.fd;
+}

 /*! convert RSL channel number to GSMTAP channel type
  *  \param[in] rsl_chantype RSL channel type
@@ -330,7 +352,7 @@
/* try immediate send and return error if any */
int rc;

-   rc = write(gsmtap_inst_fd(gti), msg->data, msg->len);
+   rc = write(gsmtap_inst_fd2(gti), msg->data, msg->len);
if (rc < 0) {
return rc;
} else if (rc >= msg->len) {
@@ -447,7 +469,7 @@
 {
int fd, rc;

-   fd = gsmtap_source_add_sink_fd(gsmtap_inst_fd(gti));
+   fd = gsmtap_source_add_sink_fd(gsmtap_inst_fd2(gti));
if (fd < 0)
return fd;

diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map
index 6c02cd3..e5f8bd8 100644
--- a/src/core/libosmocore.map
+++ b/src/core/libosmocore.map
@@ -39,6 +39,8 @@
 get_value_string;
 get_value_string_or_null;
 gsmtap_gsm_channel_names;
+gsmtap_inst_fd;
+gsmtap_inst_fd2;
 gsmtap_makemsg;
 gsmtap_makemsg_ex;
 gsmtap_send;

--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id:

[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst

2023-10-16 Thread arehbein 
Attention is currently required from: daniel.

arehbein has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )

Change subject: gsmtap: Hide implementation of gsmtap_inst
..


Patch Set 5: Code-Review+2

(2 comments)

File include/osmocom/core/gsmtap_util.h:

https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/dde5fab4_12e50e49
PS2, Line 29: int gsmtap_inst_fd(struct gsmtap_inst *gti);
> This API being static inline before, means the appsusing it actually got the 
> implementation compiled […]
Done


File src/core/gsmtap_util.c:

https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/15f4bec9_25d964b7
PS2, Line 52:   struct osmo_wqueue wq;  /*!< the wait queue */
> Sounds good to me, but have a look at osmo_static_assert instead of 
> OSMO_ASSERT. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: daniel 
Gerrit-Comment-Date: Mon, 16 Oct 2023 13:49:00 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: arehbein 
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst

2023-10-15 Thread pespin 
Attention is currently required from: arehbein, daniel.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )

Change subject: gsmtap: Hide implementation of gsmtap_inst
..


Patch Set 5: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: arehbein 
Gerrit-Attention: daniel 
Gerrit-Comment-Date: Sun, 15 Oct 2023 21:54:10 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst

2023-10-15 Thread laforge 
Attention is currently required from: arehbein, daniel, pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )

Change subject: gsmtap: Hide implementation of gsmtap_inst
..


Patch Set 5: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: arehbein 
Gerrit-Attention: pespin 
Gerrit-Attention: daniel 
Gerrit-Comment-Date: Sun, 15 Oct 2023 12:23:28 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst

2023-10-13 Thread arehbein 
Attention is currently required from: daniel, laforge, pespin.

arehbein has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )

Change subject: gsmtap: Hide implementation of gsmtap_inst
..


Patch Set 5:

(3 comments)

File TODO-RELEASE:

https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/170ea941_3c8b0151
PS4, Line 12: core  DEPRECATE gsmtap_inst_fd2()
> wrong, not deprecating gsmtap_inst_fd2. […]
Done


File include/osmocom/core/gsmtap_util.h:

https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/71abc76d_2313647f
PS2, Line 30:
> Alright... […]
Done


File src/core/libosmocore.map:

https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/b275ea45_45d0bda8
PS2, Line 42: gsmtap_inst_fd;
> I have added `gsmtap_inst_fd` and `gsmtap_inst_fd2` (the latter as 
> deprecated) to libosmocore.map . […]
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: daniel 
Gerrit-Comment-Date: Fri, 13 Oct 2023 13:21:01 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein 
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: daniel 
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst

2023-10-13 Thread arehbein 
Attention is currently required from: daniel, laforge, pespin.

arehbein has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )

Change subject: gsmtap: Hide implementation of gsmtap_inst
..


Patch Set 5:

(1 comment)

Patchset:

PS5:
> Once this is merged, please submit patches for projects using the _fd() 
> version to use the _fd2() in […]
Alright, will keep that in mind



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: daniel 
Gerrit-Comment-Date: Fri, 13 Oct 2023 13:20:20 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst

2023-10-13 Thread pespin 
Attention is currently required from: arehbein, daniel, laforge.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )

Change subject: gsmtap: Hide implementation of gsmtap_inst
..


Patch Set 5:

(1 comment)

Patchset:

PS5:
Once this is merged, please submit patches for projects using the _fd() version 
to use the _fd2() instead (and update its TODO-RELEASE to state they need 
libosmocore > 1.9.0)



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: arehbein 
Gerrit-Attention: laforge 
Gerrit-Attention: daniel 
Gerrit-Comment-Date: Fri, 13 Oct 2023 10:50:10 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst

2023-10-13 Thread pespin 
Attention is currently required from: arehbein, daniel, laforge.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )

Change subject: gsmtap: Hide implementation of gsmtap_inst
..


Patch Set 5: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: arehbein 
Gerrit-Attention: laforge 
Gerrit-Attention: daniel 
Gerrit-Comment-Date: Fri, 13 Oct 2023 10:49:12 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst

2023-10-12 Thread arehbein 
Attention is currently required from: arehbein, daniel, laforge.

Hello Jenkins Builder, daniel, laforge, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email

to look at the new patch set (#5).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder


Change subject: gsmtap: Hide implementation of gsmtap_inst
..

gsmtap: Hide implementation of gsmtap_inst

 - Use forward decl. of struct gsmtap_inst in header
 - Remove 'static inline' attributes from gsmtap_inst_fd() declaration,
   move function definition to gsmtap_util.c and mark it as deprecated
 - Add gsmtap_inst_fd2() as replacement for gsmtap_inst_fd()

Related: OS#6213
Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
---
M TODO-RELEASE
M include/osmocom/core/gsmtap_util.h
M src/core/gsmtap_util.c
M src/core/libosmocore.map
4 files changed, 48 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/20/34720/5
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: arehbein 
Gerrit-Attention: laforge 
Gerrit-Attention: daniel 
Gerrit-MessageType: newpatchset

[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst

2023-10-12 Thread pespin 
Attention is currently required from: arehbein, daniel, laforge.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )

Change subject: gsmtap: Hide implementation of gsmtap_inst
..


Patch Set 4:

(1 comment)

File TODO-RELEASE:

https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/99b31817_01662270
PS4, Line 12: core  DEPRECATE gsmtap_inst_fd2()
wrong, not deprecating gsmtap_inst_fd2.
Better add it in the same line, it's fine for me, then I understand they are 
related.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 4
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: arehbein 
Gerrit-Attention: laforge 
Gerrit-Attention: daniel 
Gerrit-Comment-Date: Thu, 12 Oct 2023 15:31:29 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst

2023-10-12 Thread arehbein 
Attention is currently required from: daniel, laforge, pespin.

arehbein has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )

Change subject: gsmtap: Hide implementation of gsmtap_inst
..


Patch Set 4:

(1 comment)

File TODO-RELEASE:

https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/17382528_3b51da22
PS3, Line 11: core  ADD   gsmtap_inst_fd2()
> append: (Deprecate gsmtap_inst_fd())
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 4
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: daniel 
Gerrit-Comment-Date: Thu, 12 Oct 2023 15:10:03 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst

2023-10-12 Thread arehbein 
Attention is currently required from: daniel, laforge, pespin.

arehbein has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )

Change subject: gsmtap: Hide implementation of gsmtap_inst
..


Patch Set 4:

(3 comments)

Patchset:

PS3:
> BTW, you are missing some sort of comment here regarding the wq field cannot 
> be changed despite bein […]
iiuc, this also pertains to the preceding struct member due to possible 
padding, so I've added a comment for the member `ofd_wq_mode`, too


File include/osmocom/core/gsmtap_util.h:

https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/14304b99_6d001547
PS3, Line 32: int gsmtap_inst_fd2(struct gsmtap_inst *gti);
> while at it, make gti const :)
Done


File src/core/logging_gsmtap.c:

https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/eb560cbb_99bc75f4
PS3, Line 54: struct gsmtap_inst;
> This is not needed, you are already adding gsmtap_util.h  abovewhich adds 
> this line.
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 4
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: daniel 
Gerrit-Comment-Date: Thu, 12 Oct 2023 15:09:43 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst

2023-10-12 Thread arehbein 
Attention is currently required from: arehbein, daniel, laforge, pespin.

Hello Jenkins Builder, daniel, laforge, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email

to look at the new patch set (#4).

The following approvals got outdated and were removed:
Code-Review-1 by pespin, Verified+1 by Jenkins Builder


Change subject: gsmtap: Hide implementation of gsmtap_inst
..

gsmtap: Hide implementation of gsmtap_inst

 - Use forward decl. of struct gsmtap_inst in header
 - Remove 'static inline' attributes from gsmtap_inst_fd() declaration,
   move function definition to gsmtap_util.c and mark it as deprecated
 - Add gsmtap_inst_fd2() as replacement for gsmtap_inst_fd()

Related: OS#6213
Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
---
M TODO-RELEASE
M include/osmocom/core/gsmtap_util.h
M src/core/gsmtap_util.c
M src/core/libosmocore.map
4 files changed, 49 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/20/34720/4
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 4
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: arehbein 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: daniel 
Gerrit-MessageType: newpatchset

[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst

2023-10-12 Thread pespin 
Attention is currently required from: arehbein, daniel, laforge.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )

Change subject: gsmtap: Hide implementation of gsmtap_inst
..


Patch Set 3:

(1 comment)

Patchset:

PS3:
BTW, you are missing some sort of comment here regarding the wq field cannot be 
changed despite being private, due to struct beign prevoously pulic 
osmo_gsmtap_fd() acessing it as a static inline.
This needs to be done now that the struct is moved to be private!



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 3
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: arehbein 
Gerrit-Attention: laforge 
Gerrit-Attention: daniel 
Gerrit-Comment-Date: Thu, 12 Oct 2023 14:49:58 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst

2023-10-12 Thread pespin 
Attention is currently required from: daniel, laforge, pespin.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )

Change subject: gsmtap: Hide implementation of gsmtap_inst
..


Patch Set 3: Code-Review-1

(3 comments)

File TODO-RELEASE:

https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/191b6602_76b8b7be
PS3, Line 11: core  ADD   gsmtap_inst_fd2()
append: (Deprecate gsmtap_inst_fd())


File include/osmocom/core/gsmtap_util.h:

https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/6c7449f5_c9f7f6e6
PS3, Line 32: int gsmtap_inst_fd2(struct gsmtap_inst *gti);
while at it, make gti const :)


File src/core/logging_gsmtap.c:

https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/14ca953a_3e11f19f
PS3, Line 54: struct gsmtap_inst;
This is not needed, you are already adding gsmtap_util.h  abovewhich adds this 
line.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 3
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: daniel 
Gerrit-Comment-Date: Thu, 12 Oct 2023 14:48:47 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst

2023-10-12 Thread arehbein 
Attention is currently required from: daniel, laforge, pespin.

arehbein has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )

Change subject: gsmtap: Hide implementation of gsmtap_inst
..


Patch Set 3:

(2 comments)

File include/osmocom/core/gsmtap_util.h:

https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/d53b48bb_59fe2b8e
PS2, Line 30:
> in summary: gsmtap_inst_fd() will now become a monster, so better make sure 
> nobody uses that cursed  […]
Alright... so I have deprecated `gsmtap_inst_fd()` and added 
`gsmtap_inst_fd2()` without yet changing anything about the implementation 
(that would be the next commit, I suppose).


File src/core/libosmocore.map:

https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/f58c7908_ef653696
PS2, Line 42: gsmtap_inst_fd;
> Yes, but let's add it as gsmtap_inst_fd2 better.
I have added `gsmtap_inst_fd` and `gsmtap_inst_fd2` (the latter as deprecated) 
to libosmocore.map .

I have only added a TODO-RELEASE line for `gsmtap_inst_fd2`. Should I add the 
deprecated function there, as well?



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 3
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: daniel 
Gerrit-Comment-Date: Thu, 12 Oct 2023 14:48:03 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein 
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: daniel 
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst

2023-10-12 Thread arehbein 
Attention is currently required from: arehbein, daniel, laforge.

Hello Jenkins Builder, daniel, laforge, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email

to look at the new patch set (#3).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder


Change subject: gsmtap: Hide implementation of gsmtap_inst
..

gsmtap: Hide implementation of gsmtap_inst

 - Use forward decl. of struct gsmtap_inst in header
 - Remove 'static inline' attributes from gsmtap_inst_fd() declaration,
   move function definition to gsmtap_util.c and mark it as deprecated
 - Add gsmtap_inst_fd2() as replacement for gsmtap_inst_fd()

Related: OS#6213
Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
---
M TODO-RELEASE
M include/osmocom/core/gsmtap_util.h
M src/core/gsmtap_util.c
M src/core/libosmocore.map
M src/core/logging_gsmtap.c
5 files changed, 50 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/20/34720/3
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e36582609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 3
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: arehbein 
Gerrit-Attention: laforge 
Gerrit-Attention: daniel 
Gerrit-MessageType: newpatchset