[M] Change in libosmocore[master]: tdef_vty: Introduce generalized per-object tdef support

2023-12-14 Thread pespin 
Attention is currently required from: arehbein, neels.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/35355?usp=email )

Change subject: tdef_vty: Introduce generalized per-object tdef support
..


Patch Set 9:

(2 comments)

File include/osmocom/vty/tdef_vty.h:

https://gerrit.osmocom.org/c/libosmocore/+/35355/comment/76dc011a_7fa8fed0
PS9, Line 87: #define DEFUN_TDEF_PER_OBJ(show_funcname, show_cmdname, 
cfg_funcname, cfg_cmdname, object_type, tdef_groups_name) \
DEFUN_TDEF(


File src/vty/tdef_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/35355/comment/12969a00_0b258b43
PS9, Line 416: void osmo_tdef_vty_groups_init_per_obj(unsigned int 
parent_cfg_node, struct osmo_tdef_group *groups, const char *cmd_category,
Probably simply call it osmo_tdef_vty_groups_init2, since it's basically the 
same as osmo_tdef_vty_groups_init but passing more parameters.

BTW, you can now implement osmo_tdef_vty_groups_init() by calling 
osmo_tdef_vty_groups_init2, so it's clear their relation.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35355?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib3b22640a11eae152d66d62c0f47b953d80de945
Gerrit-Change-Number: 35355
Gerrit-PatchSet: 9
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels 
Gerrit-CC: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: arehbein 
Gerrit-Comment-Date: Thu, 14 Dec 2023 12:26:55 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: tdef_vty: Introduce generalized per-object tdef support

2023-12-13 Thread arehbein 
arehbein has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/35355?usp=email )

Change subject: tdef_vty: Introduce generalized per-object tdef support
..


Patch Set 9:

(1 comment)

Patchset:

PS9:
A working example should be given by 
https://gerrit.osmocom.org/c/osmo-bsc/+/31878



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35355?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib3b22640a11eae152d66d62c0f47b953d80de945
Gerrit-Change-Number: 35355
Gerrit-PatchSet: 9
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Thu, 14 Dec 2023 00:28:29 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: tdef_vty: Introduce generalized per-object tdef support

2023-12-13 Thread arehbein 
arehbein has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/35355?usp=email )

Change subject: tdef_vty: Introduce generalized per-object tdef support
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35355?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib3b22640a11eae152d66d62c0f47b953d80de945
Gerrit-Change-Number: 35355
Gerrit-PatchSet: 9
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Thu, 14 Dec 2023 00:14:17 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment