[M] Change in osmo-ttcn3-hacks[master]: Introduce DIAMETER_rfc5447_Templates.ttcn
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34874?usp=email ) Change subject: Introduce DIAMETER_rfc5447_Templates.ttcn .. Introduce DIAMETER_rfc5447_Templates.ttcn Add templates for RFC 5447 MIP6-Feature-Vector. This AVP is a bitmask which as only a few bits defined in RFC 5447, with other interfaces using this AVP adding interface-specific bits in the spec of each interface. The templates are added in a new separate file with the aim of start splitting the tons of AVPs originating from different specs in order to be able to quickly identify them and avoid confusion. Change-Id: I0fc646e5354d78283a2f3e1b9bb9c4688cf744a1 --- M epdg/gen_links.sh A library/DIAMETER_rfc5447_Templates.ttcn 2 files changed, 60 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/epdg/gen_links.sh b/epdg/gen_links.sh index b464203..bc9d90e 100755 --- a/epdg/gen_links.sh +++ b/epdg/gen_links.sh @@ -42,7 +42,7 @@ FILES+="Osmocom_CTRL_Types.ttcn " FILES+="L3_Common.ttcn " FILES+="DIAMETER_Types.ttcn DIAMETER_CodecPort.ttcn DIAMETER_CodecPort_CtrlFunct.ttcn DIAMETER_CodecPort_CtrlFunctDef.cc DIAMETER_Emulation.ttcn " -FILES+="DIAMETER_Templates.ttcn DIAMETER_ts29_273_Templates.ttcn " +FILES+="DIAMETER_Templates.ttcn DIAMETER_rfc5447_Templates.ttcn DIAMETER_ts29_273_Templates.ttcn " FILES+="IPA_Types.ttcn IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn IPA_CodecPort_CtrlFunctDef.cc IPA_Emulation.ttcnpp " FILES+="GSUP_Types.ttcn GSUP_Emulation.ttcn " diff --git a/library/DIAMETER_rfc5447_Templates.ttcn b/library/DIAMETER_rfc5447_Templates.ttcn new file mode 100644 index 000..4c119c7 --- /dev/null +++ b/library/DIAMETER_rfc5447_Templates.ttcn @@ -0,0 +1,41 @@ +module DIAMETER_rfc5447_Templates { + +/* (C) 2023 by sysmocom s.f.m.c. GmbH https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0fc646e5354d78283a2f3e1b9bb9c4688cf744a1 Gerrit-Change-Number: 34874 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[M] Change in osmo-ttcn3-hacks[master]: Introduce DIAMETER_rfc5447_Templates.ttcn
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34874?usp=email ) Change subject: Introduce DIAMETER_rfc5447_Templates.ttcn .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0fc646e5354d78283a2f3e1b9bb9c4688cf744a1 Gerrit-Change-Number: 34874 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 24 Oct 2023 21:35:12 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: Introduce DIAMETER_rfc5447_Templates.ttcn
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34874?usp=email ) Change subject: Introduce DIAMETER_rfc5447_Templates.ttcn .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0fc646e5354d78283a2f3e1b9bb9c4688cf744a1 Gerrit-Change-Number: 34874 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 24 Oct 2023 09:04:08 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: Introduce DIAMETER_rfc5447_Templates.ttcn
Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34874?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Introduce DIAMETER_rfc5447_Templates.ttcn .. Introduce DIAMETER_rfc5447_Templates.ttcn Add templates for RFC 5447 MIP6-Feature-Vector. This AVP is a bitmask which as only a few bits defined in RFC 5447, with other interfaces using this AVP adding interface-specific bits in the spec of each interface. The templates are added in a new separate file with the aim of start splitting the tons of AVPs originating from different specs in order to be able to quickly identify them and avoid confusion. Change-Id: I0fc646e5354d78283a2f3e1b9bb9c4688cf744a1 --- M epdg/gen_links.sh A library/DIAMETER_rfc5447_Templates.ttcn 2 files changed, 60 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/74/34874/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0fc646e5354d78283a2f3e1b9bb9c4688cf744a1 Gerrit-Change-Number: 34874 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[M] Change in osmo-ttcn3-hacks[master]: Introduce DIAMETER_rfc5447_Templates.ttcn
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34874?usp=email ) Change subject: Introduce DIAMETER_rfc5447_Templates.ttcn .. Introduce DIAMETER_rfc5447_Templates.ttcn Add templates for RFC 5447 MIP6-Feature-Vector. This AVP is a bitmask which as only a few bits defined in RFC 5447, with other interfaces using this AVP adding interface-specific bits in the spec of each interface. The templates are added in a new separate file with the aim of start splitting the tons of AVPs originating from different specs in order to be able to quickly identify them and avoid confusion. Change-Id: I0fc646e5354d78283a2f3e1b9bb9c4688cf744a1 --- M epdg/gen_links.sh A library/DIAMETER_rfc5447_Templates.ttcn M library/DIAMETER_ts29_273_Templates.ttcn 3 files changed, 67 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/74/34874/1 diff --git a/epdg/gen_links.sh b/epdg/gen_links.sh index b464203..bc9d90e 100755 --- a/epdg/gen_links.sh +++ b/epdg/gen_links.sh @@ -42,7 +42,7 @@ FILES+="Osmocom_CTRL_Types.ttcn " FILES+="L3_Common.ttcn " FILES+="DIAMETER_Types.ttcn DIAMETER_CodecPort.ttcn DIAMETER_CodecPort_CtrlFunct.ttcn DIAMETER_CodecPort_CtrlFunctDef.cc DIAMETER_Emulation.ttcn " -FILES+="DIAMETER_Templates.ttcn DIAMETER_ts29_273_Templates.ttcn " +FILES+="DIAMETER_Templates.ttcn DIAMETER_rfc5447_Templates.ttcn DIAMETER_ts29_273_Templates.ttcn " FILES+="IPA_Types.ttcn IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn IPA_CodecPort_CtrlFunctDef.cc IPA_Emulation.ttcnpp " FILES+="GSUP_Types.ttcn GSUP_Emulation.ttcn " diff --git a/library/DIAMETER_rfc5447_Templates.ttcn b/library/DIAMETER_rfc5447_Templates.ttcn new file mode 100644 index 000..4c119c7 --- /dev/null +++ b/library/DIAMETER_rfc5447_Templates.ttcn @@ -0,0 +1,41 @@ +module DIAMETER_rfc5447_Templates { + +/* (C) 2023 by sysmocom s.f.m.c. GmbH https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0fc646e5354d78283a2f3e1b9bb9c4688cf744a1 Gerrit-Change-Number: 34874 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange