[M] Change in osmo-ttcn3-hacks[master]: sgsn: add TC_attach_rau_invalid_old_rai

2024-05-22 Thread laforge
Attention is currently required from: fixeria, pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email )

Change subject: sgsn: add TC_attach_rau_invalid_old_rai
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I006adabdad26c0c48e1ebe99421bcab7295dc147
Gerrit-Change-Number: 36625
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-CC: lynxis lazus 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 22 May 2024 15:36:34 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


[M] Change in osmo-ttcn3-hacks[master]: sgsn: add TC_attach_rau_invalid_old_rai

2024-05-16 Thread lynxis lazus
Attention is currently required from: fixeria, pespin.

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email )

Change subject: sgsn: add TC_attach_rau_invalid_old_rai
..


Patch Set 2:

(1 comment)

File sgsn/SGSN_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625/comment/182434c6_22564a9e
PS2, Line 2758: private function f_TC_attach_rau_invalid_old_rai(charstring id) 
runs on BSSGP_ConnHdlr {
> Probably a short comment explaining here what the test specific aim is may be 
> good for other readers […]
+1



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I006adabdad26c0c48e1ebe99421bcab7295dc147
Gerrit-Change-Number: 36625
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-CC: lynxis lazus 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Thu, 16 May 2024 14:03:05 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment


[M] Change in osmo-ttcn3-hacks[master]: sgsn: add TC_attach_rau_invalid_old_rai

2024-04-22 Thread pespin
Attention is currently required from: fixeria.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email )

Change subject: sgsn: add TC_attach_rau_invalid_old_rai
..


Patch Set 2:

(1 comment)

File sgsn/SGSN_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625/comment/f731f277_9dda5043
PS2, Line 2758: private function f_TC_attach_rau_invalid_old_rai(charstring id) 
runs on BSSGP_ConnHdlr {
Probably a short comment explaining here what the test specific aim is may be 
good for other readers, also probably with a ref to the OS# ticket.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I006adabdad26c0c48e1ebe99421bcab7295dc147
Gerrit-Change-Number: 36625
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Mon, 22 Apr 2024 14:03:53 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


[M] Change in osmo-ttcn3-hacks[master]: sgsn: add TC_attach_rau_invalid_old_rai

2024-04-22 Thread pespin
Attention is currently required from: fixeria.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email )

Change subject: sgsn: add TC_attach_rau_invalid_old_rai
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I006adabdad26c0c48e1ebe99421bcab7295dc147
Gerrit-Change-Number: 36625
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Mon, 22 Apr 2024 14:02:43 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


[M] Change in osmo-ttcn3-hacks[master]: sgsn: add TC_attach_rau_invalid_old_rai

2024-04-22 Thread fixeria
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder


Change subject: sgsn: add TC_attach_rau_invalid_old_rai
..

sgsn: add TC_attach_rau_invalid_old_rai

This testcase currently crashes osmo-sgsn.

Change-Id: I006adabdad26c0c48e1ebe99421bcab7295dc147
Related: OS#6441
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 57 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/25/36625/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I006adabdad26c0c48e1ebe99421bcab7295dc147
Gerrit-Change-Number: 36625
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset


[M] Change in osmo-ttcn3-hacks[master]: sgsn: add TC_attach_rau_invalid_old_rai

2024-04-22 Thread fixeria
fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email )


Change subject: sgsn: add TC_attach_rau_invalid_old_rai
..

sgsn: add TC_attach_rau_invalid_old_rai

This testcase currently crashes osmo-sgsn.

Change-Id: I006adabdad26c0c48e1ebe99421bcab7295dc147
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 56 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/25/36625/1

diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 0371e29..d55a264 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -2755,6 +2755,49 @@
f_cleanup();
 }

+private function f_TC_attach_rau_invalid_old_rai(charstring id) runs on 
BSSGP_ConnHdlr {
+   timer T;
+
+   /* perform regular attach */
+   f_TC_attach(id);
+
+   /* perform RAU via cell A */
+   f_routing_area_update(g_pars.ra);
+
+   f_bssgp_client_unregister(g_pars.imsi);
+   f_bssgp_client_register(g_pars.imsi, g_pars.tlli, BSSGP_PROC[1]);
+
+   /* perform RAU via cell B, but indicating the new RAI as the old RAI */
+   var RoutingAreaIdentificationV old_ra := 
f_cellid_to_RAI(g_pars.bssgp_cell_id[1]);
+   f_send_l3(ts_GMM_RAU_REQ(f_mi_get_lv(), GPRS_UPD_T_RA, old_ra), 1);
+
+   T.start(2.0);
+   alt {
+   [] BSSGP[1].receive(tr_GMM_RAU_REJECT) {
+   setverdict(pass);
+   T.stop;
+   }
+   [] BSSGP[1].receive(tr_LLC_XID_MT_CMD(?, ?)) { repeat; }
+   [] T.timeout {
+   setverdict(fail, "Timeout waiting for RAU Reject");
+   mtc.stop;
+   }
+   }
+
+   /* perform RAU via cell B, this time with proper old RAI of cell A */
+   f_routing_area_update(old_ra := g_pars.ra, ran_index := 1);
+
+   f_detach_mo(c_GMM_DTT_MO_GPRS, true, true, 1);
+}
+testcase TC_attach_rau_invalid_old_rai() runs on test_CT {
+   var BSSGP_ConnHdlr vc_conn;
+   f_init();
+   f_sleep(1.0);
+   vc_conn := f_start_handler(refers(f_TC_attach_rau_invalid_old_rai), 
testcasename(), g_gb, 138);
+   vc_conn.done;
+   f_cleanup();
+}
+
 private function f_TC_attach_gmm_attach_req_while_gmm_attach(charstring id) 
runs on BSSGP_ConnHdlr {
var integer count_req := 0;
var MobileIdentityLV mi;
@@ -3984,6 +4027,8 @@

/* At the end, may crash osmo-sgsn, see OS#3957, OS#4245 */
execute( TC_attach_req_id_req_ra_update() );
+   /* At the end, may crash osmo-sgsn */
+   execute( TC_attach_rau_invalid_old_rai() );
 }



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I006adabdad26c0c48e1ebe99421bcab7295dc147
Gerrit-Change-Number: 36625
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange