[S] Change in ...osmo-epdg[master]: dia: 3gpp_ts29_273_s6b: add missing *[ AVP ] to AAA
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35216?usp=email ) Change subject: dia: 3gpp_ts29_273_s6b: add missing *[ AVP ] to AAA .. dia: 3gpp_ts29_273_s6b: add missing *[ AVP ] to AAA AAA allows to have unknown AVPs. Change-Id: I934c87e912882ddef1cbac1466dec66c72b9c77c --- M dia/diameter_3gpp_ts29_273_s6b.dia 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/dia/diameter_3gpp_ts29_273_s6b.dia b/dia/diameter_3gpp_ts29_273_s6b.dia index b009e20..af1c561 100644 --- a/dia/diameter_3gpp_ts29_273_s6b.dia +++ b/dia/diameter_3gpp_ts29_273_s6b.dia @@ -94,6 +94,7 @@ [ OC-Supported-Features ] [ OC-OLR ] *[ Load ] + *[ AVP ] ;; 9.2.2.3.1 Session-Termination-Request (STR) ;; 9.2.2.4.3 Session-Termination-Request (STR) -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35216?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I934c87e912882ddef1cbac1466dec66c72b9c77c Gerrit-Change-Number: 35216 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[S] Change in ...osmo-epdg[master]: dia: 3gpp_ts29_273_s6b: add missing *[ AVP ] to AAA
Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35216?usp=email ) Change subject: dia: 3gpp_ts29_273_s6b: add missing *[ AVP ] to AAA .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35216?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I934c87e912882ddef1cbac1466dec66c72b9c77c Gerrit-Change-Number: 35216 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Tue, 05 Dec 2023 19:05:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in ...osmo-epdg[master]: dia: 3gpp_ts29_273_s6b: add missing *[ AVP ] to AAA
Attention is currently required from: lynxis lazus, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35216?usp=email ) Change subject: dia: 3gpp_ts29_273_s6b: add missing *[ AVP ] to AAA .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35216?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I934c87e912882ddef1cbac1466dec66c72b9c77c Gerrit-Change-Number: 35216 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: pespin Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Tue, 05 Dec 2023 17:00:20 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in ...osmo-epdg[master]: dia: 3gpp_ts29_273_s6b: add missing *[ AVP ] to AAA
Attention is currently required from: pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35216?usp=email ) Change subject: dia: 3gpp_ts29_273_s6b: add missing *[ AVP ] to AAA .. Patch Set 2: (1 comment) Patchset: PS1: > This is wrong. Youy are mentioning AAR in commit description, but modifying > AAA. Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35216?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I934c87e912882ddef1cbac1466dec66c72b9c77c Gerrit-Change-Number: 35216 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 05 Dec 2023 16:01:31 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[S] Change in ...osmo-epdg[master]: dia: 3gpp_ts29_273_s6b: add missing *[ AVP ] to AAA
Attention is currently required from: lynxis lazus, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35216?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by pespin Change subject: dia: 3gpp_ts29_273_s6b: add missing *[ AVP ] to AAA .. dia: 3gpp_ts29_273_s6b: add missing *[ AVP ] to AAA AAA allows to have unknown AVPs. Change-Id: I934c87e912882ddef1cbac1466dec66c72b9c77c --- M dia/diameter_3gpp_ts29_273_s6b.dia 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/16/35216/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35216?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I934c87e912882ddef1cbac1466dec66c72b9c77c Gerrit-Change-Number: 35216 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: pespin Gerrit-Attention: lynxis lazus Gerrit-MessageType: newpatchset
