[S] Change in ...osmo-epdg[master]: epdg_ue_fsm: Properly define type of field in record

2024-03-18 Thread pespin 
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36341?usp=email )

Change subject: epdg_ue_fsm: Properly define type of field in record
..

epdg_ue_fsm: Properly define type of field in record

Change-Id: I0d1c91be2fadbcfecef8ca5aaf6df07b98a834f2
---
M src/epdg_ue_fsm.erl
1 file changed, 10 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved
  dexter: Looks good to me, but someone else must approve




diff --git a/src/epdg_ue_fsm.erl b/src/epdg_ue_fsm.erl
index 4a090e9..bb4602f 100644
--- a/src/epdg_ue_fsm.erl
+++ b/src/epdg_ue_fsm.erl
@@ -68,7 +68,7 @@
 imsi,
 apn = "internet":: string(),
 pgw_rem_addr_list   = []:: list(),
-tun_pdp_ctx :: epdg_tun_pdp_ctx,
+tun_pdp_ctx :: #epdg_tun_pdp_ctx{},
 tear_down_gsup_needed   = false :: boolean(), %% need to send 
GSUP PurgeMSResp after STR+STA?
 tear_down_gsup_cause= 0 :: integer(),
 tear_down_s2b_needed= false :: boolean(), %% need to send 
S2b DeleteSessionReq

--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36341?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I0d1c91be2fadbcfecef8ca5aaf6df07b98a834f2
Gerrit-Change-Number: 36341
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in ...osmo-epdg[master]: epdg_ue_fsm: Properly define type of field in record

2024-03-18 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36341?usp=email )

Change subject: epdg_ue_fsm: Properly define type of field in record
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36341?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I0d1c91be2fadbcfecef8ca5aaf6df07b98a834f2
Gerrit-Change-Number: 36341
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 18 Mar 2024 17:28:44 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in ...osmo-epdg[master]: epdg_ue_fsm: Properly define type of field in record

2024-03-18 Thread dexter 
Attention is currently required from: pespin.

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36341?usp=email )

Change subject: epdg_ue_fsm: Properly define type of field in record
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36341?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I0d1c91be2fadbcfecef8ca5aaf6df07b98a834f2
Gerrit-Change-Number: 36341
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Mon, 18 Mar 2024 16:43:17 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in ...osmo-epdg[master]: epdg_ue_fsm: Properly define type of field in record

2024-03-18 Thread pespin 
pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36341?usp=email )


Change subject: epdg_ue_fsm: Properly define type of field in record
..

epdg_ue_fsm: Properly define type of field in record

Change-Id: I0d1c91be2fadbcfecef8ca5aaf6df07b98a834f2
---
M src/epdg_ue_fsm.erl
1 file changed, 10 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg 
refs/changes/41/36341/1

diff --git a/src/epdg_ue_fsm.erl b/src/epdg_ue_fsm.erl
index 4a090e9..bb4602f 100644
--- a/src/epdg_ue_fsm.erl
+++ b/src/epdg_ue_fsm.erl
@@ -68,7 +68,7 @@
 imsi,
 apn = "internet":: string(),
 pgw_rem_addr_list   = []:: list(),
-tun_pdp_ctx :: epdg_tun_pdp_ctx,
+tun_pdp_ctx :: #epdg_tun_pdp_ctx{},
 tear_down_gsup_needed   = false :: boolean(), %% need to send 
GSUP PurgeMSResp after STR+STA?
 tear_down_gsup_cause= 0 :: integer(),
 tear_down_s2b_needed= false :: boolean(), %% need to send 
S2b DeleteSessionReq

--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36341?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I0d1c91be2fadbcfecef8ca5aaf6df07b98a834f2
Gerrit-Change-Number: 36341
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange